Re: [darktable-dev] CR3 support integrated

2021-11-16 Thread Andreas Schneider
On Sunday, November 14, 2021 7:29:41 PM CET Pascal Obry wrote:
> Just a quick note about the recent integration of the CR3 support in
> darktable.
> 
> Be sure to update the submodules after next git pull to ensure the
> LibRaw sub-module is properly populated.
> 
> $ git submodule init
> $ git submodule update

Hi Pascal,

why can't you use the system libraw? I do not see why I should build and 
package a libraw if it is available in the system.


Best regards,


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Difference between "brilliance" and "brightness"?

2021-04-22 Thread Andreas Schneider
On Thursday, 22 April 2021 17:10:21 CEST Jeronimo Pellegrini wrote:
> Thank you!
> I had not yet translated that part of the manual, it helps a lot.

You're welcome. Thanks for doing the translation!


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Difference between "brilliance" and "brightness"?

2021-04-22 Thread Andreas Schneider
On Thursday, 22 April 2021 12:32:56 CEST Jeronimo Pellegrini wrote:
> Hello,
> 
> While translating, I found a new word that I'm not sure I know
> the meaning.
> 
> Is "brilliance" the same as "brightness"? Or, can I translate both
> to the same word?

Take a look at the definitions section of
https://darktable-org.github.io/dtdocs/special-topics/color-management/color-dimensions/

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Lens information is not correct

2021-04-20 Thread Andreas Schneider
On Tuesday, 20 April 2021 10:57:37 CEST u...@halla.de wrote:
> Hello,

Hi,

> As you see in the Exif_darktable.jpg the lens information is not correct. I
> do not own a Sigma 14-24mm. The raw picture was taken with a Sigma 18-35
> 1.8. You see that the aperture is listed with 31mm, which could not happen
> with the lens in the exif.
> 
> I have checked the same raw picture with Canon DPP and all is listed fine.
> Even pics taken and imported last year with the former version are listed
> fine. Only pics taken and opened now first time with darktable are showing
> the wrong lens.

See "CONFIGURATION FILE" at https://exiv2.org/manpage.html


Cheers

Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OBS → Stable branch snapshots

2021-01-15 Thread Andreas Schneider
On Friday, 15 January 2021 17:30:23 CET Timur Irikovich Davletshin wrote:
> It's like one year ago...
> 
> Latest 3.4 branch via OBS is darktable_3.4.0~git15.b2a685928_amd64.deb
> Latest 3.4 via github is 0e4ecc1
> 
> Master branch builds are fine.

There is an issue with the debian packages right now:

dpkg-source: error: can't build with source format '3.0 (native)': native 
package version may not have a revision

I don't have a fix for that yet ...


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OBS → Stable branch snapshots

2021-01-15 Thread Andreas Schneider
On Friday, 15 January 2021 09:49:33 CET Timur Irikovich Davletshin wrote:
> Dear developers (darix?), any chance of getting updates for stable
> release branch snapshots on OBS? Builds are not working for quite a
> while.

Can you please be more precise?

The only failing build is currently Debian_Next ...

https://build.opensuse.org/package/show/graphics:darktable:stable/darktable

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Planning 3.4

2020-11-30 Thread Andreas Schneider
On Monday, 30 November 2020 21:29:35 CET Pascal Obry wrote:
> Hello !

Hi Pascal,
 
> As announced we are entering the string freeze now.
> 
> This means that translators can start translating the dt strings for
> our next major release 3.4.

thank you very very much for all the work you do for darktable! Also thanks to 
all contributors, darktable 3.4 is an absolutely incredible release. It is a 
huge milestone!

Thanks!


Andreas

P.S.: Please build Windows executables with libavif support! Let me know if 
have questions about avif.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] The Canon CR3

2020-08-30 Thread Andreas Schneider
On Sunday, 30 August 2020 05:03:34 CEST Patrick Shanahan wrote:
> The difficulty in reverse engineering their proprietary algorithms w/o
> becoming liable is apparently quite great.  Would you consider paying
> their fines if they occur?

That's only true for the US and maybe some other countries, we don't have 
software patents in the EU and reverse engineering is allowed here too ...

You comment from above is counter-productive! It spreads FUD.




___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] The Canon CR3

2020-08-30 Thread Andreas Schneider
On Sunday, 30 August 2020 01:37:53 CEST Stille wrote:
> I wonder, if exiv2 keep not implementing cr3 support, would it be
> possible to read those via libraw (which does support it as of snapshot
> 201910 - https://www.libraw.org/news/libraw-snapshot-201910)

CR3 is a ISOBMFF container as far as I know. So exiv2 just needs support for 
ISOBMFF to get the exiv2 data ...


Andreas



___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Local Contrast Module broken using OpenCL

2020-08-16 Thread Andreas Schneider
On Friday, 14 August 2020 20:37:29 CEST Dusenberg wrote:
> Thanks for the prompt reply Andreas. 

There is a workaround for the issue in 3.2.1. So you can just use ROCm without 
any problems with darktable 3.2.1.


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Local Contrast Module broken using OpenCL

2020-08-13 Thread Andreas Schneider
On Thursday, 13 August 2020 14:50:02 CEST Dusenberg wrote:
> I recently migrated to a new Linux workstation with OpenCL capability, and
> Darktable 3.0.2 from the OpenSUSE 15.1 distro repository. The Local
> Contrast Module (LC) is broken and produces ugly, extreme 'shading' and
> artifacts in local laplacian mode that makes it unusable. The problem
> manifests on viewing images previously developed on my old laptop with LC
> enabled (same DT version but no OpenCL) as well as developing on the
> workstation. Everything else in DT (and other apps) that I use in my
> workflow is working as normal on the workstation.  OpenCL compiled and
> loaded with no errors. There are no runtime error messages, normal or with
> debug.  Disabling OpenCL fixes the Local Contrast module and it works as
> expected. I've tried rebuilding locallaplacian.cl.bin, which again compiled
> and loaded without error, but the problem remains. 
> 
> Appears to a be bug in OpenCL code.  Any ideas/help?

Its a bug in the OpenCL compiler ...

https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/103


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Taking reference photos for adding lens correction profiles

2020-08-12 Thread Andreas Schneider
On Tuesday, 11 August 2020 20:16:26 CEST Germano Massullo wrote:
> I have a question concerning shooting reference photos in order to add
> lens correction profiles for various lenses.
> 
> I would like to use these buildings
> https://goo.gl/maps/fX6om53ENGSnN9Fw8 as reference.
> 
> When you enter that area, the lowest window with those red squares is
> about 3 meters from the ground.
> 
> Is that a problem if I shoot photos of such buildings where the "first"
> useful horizontal line is 3 meters from ground level?

You need a line at the top and one after on about 1/3 of the picture from the 
top. If this fits your lens it will work. If you have try to calibrate a wide 
angle lens it might not work as you can't get close enough or the angle will 
be bad.

Try it and find out :-)

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] preparing 3.2

2020-07-15 Thread Andreas Schneider
On Tuesday, 14 July 2020 16:21:12 CEST Pascal Obry wrote:
> @All devs !

Pascal,

thank you very much for maintaining darktable. You are doing an absolutely 
fantastic job!


T H A N K S !


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Large number of warnings when building dt master

2020-06-10 Thread Andreas Schneider
On Tuesday, 9 June 2020 23:17:10 CEST Nicolas Auffray wrote:
> Hi Peter,
> 
> I just compile last master (so 3.1.0+2031 now) and I don't have any
> error about libxcf on my side (nor I have on previous compile). But I am
> on Ubuntu 20.04 so that could make some differences.
> 
> Do you update submodule (git submodule update ; a git submodule init is
> sometimes good to do again) ?

Just use:

git pull --rebase --rescure-submodules

:-)



-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Incorrect lens name not displayed

2020-04-03 Thread Andreas Schneider
On Friday, 3 April 2020 11:16:40 CEST Mikael Puhakka wrote:
> EXIF information is a messy business. The FLOSS "de-facto" standard
> library used by everyone is Phil Harvey's  exiftool. Recently I used
> it to study some of my images; a Sigma 35mm f/1.4 ART was rendered as
> Canon 17-40 by the tool.

The problem is that some manufacturers use lens ids in the EXIF and not 
strings. So you need a database which maps the id (integer) to a human 
readable string. Looks like Sigma is using the same id as canon for that lens 
...

The mappin is coming from libexiv2 which darktable uses. So your bug report 
should go to the exiv2 project :-)

However, you can setup your own mappings:

man exiv2 -> CONFIGURATION FILE



    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Trouble compiling lens.cc with lensfun 0.3.95

2020-04-02 Thread Andreas Schneider
On Thursday, 2 April 2020 13:37:38 CEST Patrick Shanahan wrote:
> * Andreas Schneider  [04-02-20 02:27]:
> > On Thursday, 2 April 2020 08:10:54 CEST Hossam Elgabarty wrote:
> > > Thanks Patrick Shanahan and Parafin. I have fallen back to 0.3.2, and I
> > > second the opinion that it would probably be best to simply kill the
> > > 0.3.95
> > > preprocessor directive.
> > 
> > https://build.opensuse.org/request/show/790678
> 
> but the osc build for openSUSE Tumbleweed is still failing ???
>  https://build.opensuse.org/package/show/graphics:darktable:master/darktable
> https://build.opensuse.org/package/live_build_log/graphics:darktable:master
> /darktable/openSUSE_Tumbleweed/x86_64 still @  3.1.0~git822.a06f8db58
> since 15 March while
> current is:  3.1.0~git1066.5d2601b12

If you look at the SR it is in staging ...

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Trouble compiling lens.cc with lensfun 0.3.95

2020-04-02 Thread Andreas Schneider
On Thursday, 2 April 2020 08:10:54 CEST Hossam Elgabarty wrote:
> Thanks Patrick Shanahan and Parafin. I have fallen back to 0.3.2, and I
> second the opinion that it would probably be best to simply kill the 0.3.95
> preprocessor directive.

https://build.opensuse.org/request/show/790678

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] New documentation for 3.0

2020-02-12 Thread Andreas Schneider
On Wednesday, 12 February 2020 13:08:18 CET Pascal Obry wrote:
> Thanks to Matt Maguire for building a script to build the documentation
> we are now in better shape to build it.
 
> So I have created the PDF which can be downloaded here:
> https://github.com/darktable-org/darktable/releases/tag/release-3.0.0
> 
> And the online documentation has also been updated for 3.0:
> 
> https://darktable.gitlab.io/doc/index.html
> 
> All the links will soon be updated on darktable.org.
> 
> Note that the 3.0 documentation is not finalized yet.
> 
> Have a nice day!


Thanks.

You also need to update

https://www.darktable.org/resources/

it still says v2.6


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Writing clear documentation

2020-01-29 Thread Andreas Schneider
Hello fellow developers and writers,

a friend and colleague of mine gave a really great presentation at devconf.cz 
about how to write clear documentation last weekend.

Marc is a Senior Technical Writer and has some valid points and great 
suggestions!

The slides can be found here:

https://marc-muehlfeld.de/writing_clear_docs.pdf

I will let you know when the recording of his talk is online.



Cheers,


Andreas


P.S.: I have to improve all my articles now ;-)

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Unit Tests

2020-01-20 Thread Andreas Schneider
On Sunday, 19 January 2020 19:59:30 CET i...@burrima.ch wrote:
> Hi David,

Hi Martin,
 
> Thank you for your reply. What a co-incidence, I was not aware of that.
> That's good news!
>
> I came to cmocka while analyzing different frameworks and I thought this
> might be the most suitable one.


I'm the cmocka developer and maintainer. It looks like you already got the 
gist of it especially the mocking functionality. This is great. I also would 
appreciate patches to cmocka to improve the docs if you find anything.

> Only had a quick look at your integration, looks similar to mine.

If you could create a pull request I would be happy to do a code review.
 
> There are code coverage tools around, though I don't know any of them.
> As a first start I thought it would be enough to go just straight (aka
> "human code coverage analyzer" ;-)) and then increase the coverage
> later. But I don't mind using such tools from beginning on. Do you know
> any such tools or shall I look around?

As soon as you use ctest you have it available with cmake, see "make help", 
there is e.g. make ExperimentalCoverage if you set the path to gcov. However 
it runs it only over the tests so we are probably at 1% :-)

> I also thought it would be good to focus on the process() methods of the
> darktable modules first. Bigger units in terms of "unit testing", maybe
> not full coverage, but probably very effective as a first quality
> improvement (and also good for me to get into the code and into the
> mathematics of the modules).
> 
> Thank you for the notice about IRC - I will look into this.

I'm gladiac on IRC.


Cheers,


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Error at compile from current git master - libavif

2019-12-31 Thread Andreas Schneider
On Tuesday, 31 December 2019 12:56:50 CET Heiko Bauke wrote:
> Am 31.12.19 um 12:49 schrieb Heiko Bauke:
> > Hi,
> > 
> > Am 30.12.19 um 11:09 schrieb Richard Hobday:
> >> As far as I can see the package "libavif" or "libavif-dev" does not
> >> exist in Ubumtu 18.04.
> > 
> > FYI: Ubuntu 19.10 comes with
> > 
> > libavifile-0.7-bin - toolkit for libavifile
> > libavifile-0.7-common - toolkit for libavifile
> > libavifile-0.7-dev - development header files for libavifile
> > libavifile-0.7c2 - shared libraries for AVI read/writing
> 
> ... which is completely unrelated to libavif. :-(

Yes, that is something else. For libavif you need dav1d and rav1e. dav1d is 
proably already available as Firefox uses it. rav1e is pretty new. Once that 
is available libavif can be packaged.

My rav1e request for openSUSE is nearly through. For Fedora it takes a little 
longer as cargo-c just made it into the distro.



___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Error at compile from current git master - libavif

2019-12-30 Thread Andreas Schneider
On Monday, 30 December 2019 11:09:43 CET Richard Hobday wrote:
> Linux Mint 19.3 / Ubuntu 18.04
> Just compiled from git 3.1.0+242~g505fd4dd2, and see the following error
> 
> messages:
> > CMake Warning at src/CMakeLists.txt:324 (find_package):
> >   By not providing "Findlibavif.cmake" in CMAKE_MODULE_PATH this project
> >   has
> >   asked CMake to find a package configuration file provided by "libavif",
> >   but
> >   CMake did not find one.
> >   
> >   Could not find a package configuration file provided by "libavif"
> >   
> >   (requested version 0.5.2) with any of the following names:
> > libavifConfig.cmake
> > libavif-config.cmake
> >   
> >   Add the installation prefix of "libavif" to CMAKE_PREFIX_PATH or set
> >   "libavif_DIR" to a directory containing one of the above files.  If
> >   "libavif" provides a separate development package or SDK, be sure it has
> >   been installed.
> 
> As far as I can see the package "libavif" or "libavif-dev" does not
> exist in Ubumtu 18.04.

Ask for inclusion! :-)
 
> What is this package and what is its purpose here in darktable?

See https://blog.cryptomilk.org/2019/11/26/avif-image-support-for-darktable/
 
> dt compiles to completion regardless!

It is optional, I think it should be set to CONFIG mode to produce less 
confusing output.

https://github.com/darktable-org/darktable/pull/3947


Thanks for reporting!


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Future 3.0 article for christmas release

2019-12-22 Thread Andreas Schneider
On Friday, 20 December 2019 16:38:41 CET Nicolas Auffray wrote:
> Hi Maurizio,
> 
> Sorry, I forgot to inform. My Github needed a cleanup to make the PR to
> prepare coming publishing.
> 
> The new path for the article is this one :
> https://github.com/Nilvus/dtorg/tree/3.0-article/content/blog/2019-12-24-dar
> ktable-3.0

On another note. If you write:

> The announcement and release notes for this new release can be found here: 
https://www.darktable.org/2019/12/darktable-300-released/.

Then "here" should be the link!

The announcement and release notes for this new release can be found [here]
(https://www.darktable.org/2019/12/darktable-300-released/).

If you want URL in the text you write:

The announcement and release notes for this new release can be found in the 
following link: https://www.darktable.org/2019/12/darktable-300-released/


:-)


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Future 3.0 article for christmas release

2019-12-22 Thread Andreas Schneider
On Friday, 20 December 2019 16:38:41 CET Nicolas Auffray wrote:
> Hi Maurizio,
> 
> Sorry, I forgot to inform. My Github needed a cleanup to make the PR to
> prepare coming publishing.
> 
> The new path for the article is this one :
> https://github.com/Nilvus/dtorg/tree/3.0-article/content/blog/2019-12-24-dar
> ktable-3.0

So changes should be a PR to your repo? The first paragraph is a bit strange. 
Also I don't know what you are trying to express.

> Following the tradition, darktable 3.0 was released for Christmas.

Following the tradition of the last years, darktable 3.0 has been released for 
Christmas.

> After a lot of renewal in 2018, 2019 has seen many very unexpected changes 
in darktable, both in its user interface and in its internal mechanisms. This 
makes darktable 3.0 a more than major version, justifying the direct 
transition from version 2.6.x to version 3.0.

What do you mean with renewal? It is normally used for subscriptions. My guess 
would be that you meant innovation:

After a lot of innovation in 2018, this year we have seen a lot of unexpected 
research, redesign and development in darktable. Both the user interface an 
the internal wiring of darktable had significant changes. This makes darktable 
3.0 a major version, which justifies the major version bump from 2.6 to 3.0. 



Just my 2 cents.


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] HDR and SDR

2019-12-17 Thread Andreas Schneider
On Tuesday, 17 December 2019 14:32:11 CET Moritz Moeller wrote:
> On 17.12.19 14:24, Andreas Schneider wrote:
> > All TIFF files are currently set to SDR ...
> 
> That doesn't make sense. I use 16bit EXR when grading 3D rendered stuff
> via DT but someone could as well use 32bit float TIFF.

I know that it is broken, the question was **how** to fix that.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] HDR and SDR

2019-12-17 Thread Andreas Schneider
On Tuesday, 17 December 2019 14:12:48 CET Sturm Flut wrote:
> Hi Andreas,
> 
> On 16.12.19 20:13, Andreas Schneider wrote:
> > sRGB -> SDR
> > AdobeRGB -> SDR
> > 
> > PQ Rec2020 -> HDR
> > HLG Rec2020 -> HDR
> > 
> > Does that make sense? I could look into that next.
> 
> Where do RAW files fit into this definition? They have no color space.
> 
> A 16 Bit AdobeRGB out-of-camera TIFF file might have more dynamic range
> than 10 Bit Rec.2020 data. Color space alone might not be a sufficient
> measure.

If you have a better idea, I'm open to suggestions!

All TIFF files are currently set to SDR ...


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Future 3.0 article for christmas release

2019-12-16 Thread Andreas Schneider
On Monday, 16 December 2019 21:20:40 CET Nicolas Auffray wrote:
> Hi all,

Hi Nicolas,

> As you know, each year Mathieu Moy write a detailled article about the
> new release. This year, Mathieu doesn't have time to do it, so after
> discussing it with him, I've replaced him. With help of french community
> from darktable.fr forums, we have finished the french version (we begin
> by that just because some people helping don't speak english). I've
> beginning to translate this article in english and will finish it this
> week (noise reduction part from rawfiner ; filmic and tone equalizer
> from Aurélien Pierre).
> 
> See WIP here (i will update it regularly):
> https://github.com/Nilvus/dtorg/tree/master/content/blog/2019-12-24-darktabl
> e-3.0
> 
> Already translated parts are a first draft, some probably needs to be
> improved.
> 
> Feel free to translate it in your language if you want to. I know that
> Maurizio Paglia translate the article in italian last year. Don't know
> if it follows this mailing list.

thanks for working on this.

Just a suggestion for a tool to help with translations (if you don't know it 
yet):

https://www.deepl.com/translator





Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] HDR and SDR

2019-12-16 Thread Andreas Schneider
Hi,

darktable is setting a flag for images to be HDR and SDR. It doesn't really 
make use of it, but we probably have to change that in future.
Currently the decision if an image is a HDR or SDR is based on the image file 
type. I think this is wrong and we need to do it based on the color space of 
the image.

sRGB -> SDR
AdobeRGB -> SDR

PQ Rec2020 -> HDR
HLG Rec2020 -> HDR

Does that make sense? I could look into that next.

The next step would be to convert HDR nits to SDR nits, so that you can 
actually see the images. We also need a mode to edit in HDR in future which 
means that the histogram needs to scale differently.

See also:
https://github.com/darktable-org/darktable/pull/3752
and
https://github.com/darktable-org/darktable/pull/3749


Cheers!


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Contact to raw.pixls.us

2019-11-24 Thread Andreas Schneider
On Sunday, 24 November 2019 16:23:02 CET Bernhard wrote:
> Hi there,

Hi Bernhard,
 
> I uploaded the Oly E-P3-File to rawsamples.ch years ago
> and now I find it as non-CC0 sample in the raw.pixls.us - database.
> I wanted to re-upload this to fix the issue but I constantly get the message

thank you very much for contribution!

andabata edited the license and changed it to CC0. Please check!


Cheers


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Cameras listed in Lens Correction module

2019-11-24 Thread Andreas Schneider
On Sunday, 24 November 2019 16:20:50 CET Moritz Mœller wrote:
> Andreas,
> 
> On November 24, 2019 12:10:10 Andreas Schneider  wrote:
> > [...] I have profiles for more lenses almost ready.
> 
> Mitakon Speedmaster 50mm f/0.95 by any chance? :)

Nope please create calibration images!

See https://pixls.us/articles/create-lens-calibration-data-for-lensfun/


    Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: [darktable-dev] Cameras listed in Lens Correction module

2019-11-24 Thread Andreas Schneider
On Sunday, 24 November 2019 12:11:56 CET Bruce Williams wrote:
> Andreas,

Hi Bruce,
 
> Tamron E 28-75/2.8
> Laowa D-Dreamer 15/2 MF
> Sony E 70-200/4

I don't own any of those lenses. I just need to do vignetting pictures the 
next days, but I have profiles for:

SAMYANG35f28  SEL1635GM  SEL55F18Z  SEL70200GM  SEL70200GM-TC2.0  SEL85F18GM  
SIGMA20f14

If you take the pictures for your lenses, I can generate the profiles for you!


See https://pixls.us/articles/create-lens-calibration-data-for-lensfun/


Cheers,


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Cameras listed in Lens Correction module

2019-11-24 Thread Andreas Schneider
On Sunday, 24 November 2019 11:58:11 CET Bruce Williams wrote:
> Hi all,

Hi Bruce,

> Who do we talk to re: cameras missing from the above-named module?
> I shoot with an a7iii, which is now a 12 month old camera at least, and
> yet, even in 3.0 rc1, it is not listed in the Lens Correction module's
> camera drop-down list.

see https://github.com/lensfun/lensfun/pull/496

Which lenses do you own? I have profiles for more lenses almost ready.


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Fujifilm X-a10 support

2019-11-20 Thread Andreas Schneider
On Thursday, 21 November 2019 08:03:19 CET Mateusz Kruk wrote:
> Hi, is there possibility to add support Fujifilm X-a10?

Hi,

there is no support in rawspeed yet, open a bug at:

https://github.com/darktable-org/rawspeed/issues



Cheers,


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable 3.0 rc1 openCL

2019-11-20 Thread Andreas Schneider
On Wednesday, 20 November 2019 02:48:00 CET Jozef Dassen wrote:
> No luck with rocm either, but the message changes, see below
>  
> I am not sure if the hsa module is correct... Why does it refer to
> /data/jenkins_workspace/ ??? This is not on my computer.
>  
> Does anyone have darktable with openCL running on a Dell Precision 7700
> series ??? If so which graphics card? 
> Thanks Jozef Dassen
>  
> rocminfo:
> ROCk module is loaded
> dassen is member of video group
> hsa api call failure at:
> /data/jenkins_workspace/compute-rocm-rel-2.9/rocminfo/rocminfo.cc:1102 Call
> returned HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate
> the necessary resources. This error may also occur when the core runtime
> library needs to spawn threads or create internal OS-specific events. 
> clinfo:
> Number of platforms: 1
>   Platform Profile: FULL_PROFILE
>   Platform Version: OpenCL 2.1 AMD-APP (2982.0)
>   Platform Name: AMD Accelerated Parallel Processing
>   Platform Vendor: Advanced Micro Devices, Inc.
>   Platform Extensions: cl_khr_icd cl_amd_event_callback
> cl_amd_offline_devices
> 
>   Platform Name: AMD Accelerated Parallel Processing
> ERROR: clGetDeviceIDs(-1)

Something is wrong with your opencl setup, clinfo returns an error.

Check /etc/OpenCL

and check the drivers loaded in the kernel.


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable 3.0 rc1 openCL

2019-11-19 Thread Andreas Schneider
On Tuesday, 19 November 2019 12:27:50 CET Jozef Dassen wrote:
> After a lot of struggle I managed to install amdgpu drivers on my Ubuntu
> 18.04. It did not work with kernel 5.0 but going back to kernel 4.15 worked
> fine. Flawless installation of amdgpu 18.40. 
> Then I ran darktable-cltest  (darktable 3.0 rc1) and got the following
> result: 
> 0.037740 [opencl_init] opencl related configuration options:
> 0.037752 [opencl_init]
> 0.037755 [opencl_init] opencl: 1
> 0.037757 [opencl_init] opencl_library: ''
> 0.037759 [opencl_init] opencl_memory_requirement: 500
> 0.037761 [opencl_init] opencl_memory_headroom: 0
> 0.037763 [opencl_init] opencl_device_priority: '*/!0,*/*/*'
> 0.037784 [opencl_init] opencl_mandatory_timeout: 200
> 0.037786 [opencl_init] opencl_size_roundup: 16
> 0.037788 [opencl_init] opencl_async_pixelpipe: 0
> 0.037790 [opencl_init] opencl_synch_cache: active module
> 0.037794 [opencl_init] opencl_number_event_handles: 25
> 0.037797 [opencl_init] opencl_micro_nap: 1000
> 0.037800 [opencl_init] opencl_use_pinned_memory: 0
> 0.037802 [opencl_init] opencl_use_cpu_devices: 0
> 0.037804 [opencl_init] opencl_avoid_atomics: 1
> 0.037806 [opencl_init]
> 0.037962 [opencl_init] found opencl runtime library 'libOpenCL'
> 0.037980 [opencl_init] opencl library 'libOpenCL' found on your system and
> loaded 0.170870 [opencl_init] found 1 platform
> 0.170885 [opencl_init] found 1 device
> 0.170923 [opencl_init] device 0 `Capeverde' supports image sizes of 16384 x
> 16384 0.170927 [opencl_init] device 0 `Capeverde' allows GPU memory
> allocations of up to 1053MB [opencl_init] device 0: Capeverde
>  GLOBAL_MEM_SIZE:  1472MB
>  MAX_WORK_GROUP_SIZE:  256
>  MAX_WORK_ITEM_DIMENSIONS: 3
>  MAX_WORK_ITEM_SIZES:  [ 1024 1024 1024 ]
>  DRIVER_VERSION:   2686.5
>  DEVICE_VERSION:   OpenCL 1.2 AMD-APP (2686.5)
> 0.171329 [opencl_init] could not create command queue for device 0: -6
> 0.171373 [opencl_init] FINALLY: opencl is NOT AVAILABLE on this system.
> 0.171376 [opencl_init] initial status of opencl enabled flag is OFF.
>  
>  
> my display is:
> 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
> Venus XTX [Radeon HD 8890M / R9 M275X/M375X] (rev 83) (prog-if 00 [VGA
> controller]) Subsystem: Dell Venus XTX [Radeon HD 8890M / R9 M275X/M375X]
> Flags: bus master, fast devsel, latency 0, IRQ 128
> Memory at b000 (64-bit, prefetchable) [size=256M]
> Memory at de30 (64-bit, non-prefetchable) [size=256K]
> I/O ports at e000 [size=256]
> Expansion ROM at 000c [disabled] [size=128K]
> Capabilities: [48] Vendor Specific Information: Len=08 
> Capabilities: [50] Power Management version 3
> Capabilities: [58] Express Legacy Endpoint, MSI 00
> Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
> Capabilities: [100] Vendor Specific Information: ID=0001 Rev=1 Len=010
>  Capabilities: [150] Advanced Error Reporting
> Capabilities: [200] #15
> Capabilities: [270] #19
> Kernel driver in use: amdgpu
> Kernel modules: radeon, amdgpu
>  
> I have fresh Ubuntu 18.04-1 installation on a sytem with 64Gbyte RAM. Only
> Firefox is running. So no resource problems. I have deferred all other
> installations until I can get darktable with openCL running. This is a
> sine-qua-non for me. 
> So no luck... Again
>  
> Any ideas what could be the problem ??
>  
> darktablerc parameters:
> opencl=true
> opencl_async_pixelpipe=false
> opencl_avoid_atomics=true
> opencl_checksum=
> opencl_device_priority=*/!0,*/*/*
> opencl_disable_drivers_blacklist=false
> opencl_library=
> opencl_mandatory_timeout=200
> opencl_memory_headroom=0
> opencl_memory_requirement=500
> opencl_micro_nap=1000
> opencl_number_event_handles=25
> opencl_scheduling_profile=default
> opencl_size_roundup=16
> opencl_synch_cache=active module
> opencl_use_cpu_devices=false
> opencl_use_pinned_memory=false

I would suggest to just use the open source driver provided by the kernel and 
install ROCm for OpenCL.

http://repo.radeon.com/rocm/apt/


Works just fine on Fedora and openSUSE. I can't help you with the proprietary 
driver.


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] dt 3.0rc1 → gamma module

2019-11-17 Thread Andreas Schneider
On Sunday, 17 November 2019 10:30:00 CET Timur Irikovich Davletshin wrote:
> Hi dear developers!
> 
> Short question. What is gamma module which has appeared in history
> stack in dt 3.0 builds? There is no such module in darktable nor it can
> be disabled in history stack. Is it something that has got into history
> stack by mistake or some hidden darkroom module?

See, e.g.

https://www.cambridgeincolour.com/tutorials/gamma-correction.htm


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable 3.0.0rc1 released

2019-11-14 Thread Andreas Schneider
On Thursday, 14 November 2019 11:55:17 CET Pascal Obry wrote:
> The darktable 3.0.0rc1 release is out.
> 
> The full description and release notes can be found here:
> 
> https://github.com/darktable-org/darktable/releases/tag/release-3.0.0rc1
> <https://github.com/darktable-org/darktable/releases/tag/release-3.0.0rc0>
> 
> This is the second pre-release, test it and please be sure to report
> issues you found.
> 
> If you are using RC0, please upgrade as soon as possible. This RC1 fixes
> the issues about iop-order notified yesterday.
> 
> Thanks all!

Thank you very much for all your work on darktable. Especially reviewing all 
the code!


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Increased memory requirements?

2019-11-10 Thread Andreas Schneider
On Sunday, 10 November 2019 11:47:30 CET KOVÁCS István wrote:
> On Sat, 9 Nov 2019 at 21:28, Aurélien Pierre  
wrote:
> > atrous (contrast equalizer) is quite heavy on hardware and needs a lot of
> > memory to store the intermediate wavelets scales. I remember having the
> > same issue on my previous laptop (GPU Nvidia 635M, 2 GB too) with certain
> > updates of the driver.
> May I ask what beast of a hardware you use now? In your filmic RGB +
> tone EQ video everything was instantaneous, even with the screen
> recorder running.

You don't really need a beast. AMD RX560 with 4GB of RAM cost ~120 Euro and 
RX570 with 8GB ~160 Euro in Germany.

You find used RX470 8GB cards for ~100Euro. However I don't know what budget 
you have. Start searching for used cards and if you look for a while I'm sure 
you will find a good deal to get one.

Then just do some tweaking:

https://discuss.pixls.us/t/darktable-3-0-and-opencl-on-modern-hardware/14782


    Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable crashes when opening styles list

2019-11-04 Thread Andreas Schneider
On Monday, 4 November 2019 20:09:10 CET Henkka wrote:
> Sorry mate, but I'm not tech savvy at all and I don't understand what
> github is nor what it means. Honestly.
> Version 2.6.3+1
> Previous version was 2.6.2

Maybe start here: https://www.chiark.greenend.org.uk/~sgtatham/bugs.html


Then goto here https://www.darktable.org/development/ and look for bug tracker 
...


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] haze removal default values

2019-11-02 Thread Andreas Schneider
On Friday, 1 November 2019 21:26:27 CET Heiko Bauke wrote:

> > A PR would be nice and we can let Heiko discuss this here.
> 
> I was not able to work and darktable and to follow the list for some
> time.  Sorry for the late reply.
> 
> I have seen that your patch already made it into darktable.  I
> completely agree (with the more practical experience today) that the
> default values are almost always too strong, in particular with the
> recent changes in pixel pipe (ordering of modules, basecurve replaced by
> filmic (rgb)).  Therefore, I am absolutely fine with the change of
> default values.

Thanks Heiko!


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Drag-and-drop to change module order

2019-11-01 Thread Andreas Schneider
On Friday, 1 November 2019 08:19:46 CET David Vincent-Jones wrote:
> Something interesting .. I moved the rgb-filmic module to a new
> location and the image was significantly changed! Am I also changing the
> pipeline?

See 

https://www.darktable.org/usermanual/en/darkroom_concepts.html#pixelpipe


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Basecurve preserve colors

2019-10-30 Thread Andreas Schneider
On Tuesday, 29 October 2019 23:08:29 CET jys wrote:
> On Tue, Oct 29, 2019, at 14:55, Aurélien Pierre wrote:
> > So, the colour preservation in base curve is kind of the 1.5 option :
> > you won't get the full-on shadows resaturation, but you will keep the
> > uniformity of saturation along the dynamic range in case you want to
> > adjust it finely later.
> 
> Going that far, I have to wonder if it wouldn't make sense to make the same
> "branded" curves from the basecurve module also available in the tonecurve
> or RGB curve modules somehow (maybe optionally, or when the "apply
> basecurve automatically" option is unselected). Wouldn't this provide a
> better combination of initial user-friendliness and potential to "grow"
> into more advanced processing? Just a thought.

The base curve is very basic. If you want to reproduce the look of OOC JPEGs 
then you need to create a profile.

https://pixls.us/articles/profiling-a-camera-with-darktable-chart/


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] New 2.6.x release

2019-10-14 Thread Andreas Schneider
Hi,

I see that in the 2.6.x trees are some fixes and support for e.g. the Sony 
A6400 camera. People are looking for support for this camera.


Pascal, could you release 2.6.3 with what we have? Maybe add Sony A7R3M4 
support too. Roman just added it to rawspeed and darktable.


Cheers,

Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darktable for ARM

2019-10-06 Thread Andreas Schneider
On Sunday, 6 October 2019 12:43:16 CEST Holger Klemm wrote:
> Hello,
> I installed Raspbian Buster on a Raspberry Pi 3B + and tried to compile
> Darktable 2.6.2.
> 
> cmake is aborted with the error message not supported platform.
> Is this a bug or is it due to the 32bit operating system?

I think so, you need aarch64 ...


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darktable for ARM

2019-10-05 Thread Andreas Schneider
On Saturday, 5 October 2019 08:59:57 CEST Holger Klemm wrote:
> Hello,

Hi,

> is an ARM version planned for Darktable 3.0.0?
> The current Raspberry Pi 4, Rock Pi 4 and NanoPi M4 are available with 4GB
> of RAM and should be powerful enough to handle small tasks.
> In particular, with the camera control then new applications would arise.
> 
> I would be very happy about an ARM version for Rasbian / Armbian.

there is one for openSUSE

http://download.opensuse.org/repositories/graphics:/darktable/
openSUSE_Tumbleweed_ARM/

and Fedora has also aarch64

https://koji.fedoraproject.org/koji/buildinfo?buildID=1322464


Cheers,

Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Current dt master very slow

2019-09-27 Thread Andreas Schneider
On Friday, 27 September 2019 01:42:54 CEST Terry Duell wrote:
> Hello,

Hi,

> I've just built the current master (1886-ga2f84373b) on Fedora 30, using
> my usual rpmbuild spec file, and find that it is very slow, particularly
> noticeable when zooming the image or applying noise reduction, it takes
> much longer than previous builds to finish 'working'.
> It's possible I have a local issue, but not seen anything obvious thus far.

OpenMP is turned off in the Fedora spec file.


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Using local version of exiv2

2019-09-15 Thread Andreas Schneider
On Wednesday, September 4, 2019 12:20:43 PM CEST Michael Gauland wrote:
> I'm building on a Debian "Buster" system, which uses exiv2 version
> 0.25.  I have installed a newer version of exiv2, to take advantage of
> its ability to identify lenses in a ~/.exiv2 file.
> 
> When I build darktable, it uses the system exiv2 from /usr, instead of
> the newer version in /usr/local.

That /usr/local is searched before /usr depends on the configuration for your 
ldconfig normally.

For building you need to point cmake to the right location, see e.g. cmake -L 
or ccmake.



    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] haze removal default values

2019-09-15 Thread Andreas Schneider
Hi Heiko,

the haze removal default values are in 99% of the cases too strong. Is there a 
reason that they are this strong?

My suggestions for default values would be:

strength: 0.15
distance: 0.200


I'm happy to create a patch if we agree :-)


Cheers,


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: [darktable-dev] Feature freeze for 3.0

2019-08-20 Thread Andreas Schneider
On Sunday, August 18, 2019 3:29:30 AM CEST Bruce Williams wrote:
> I will certainly do what I can.
> As yet, I have not delved into the world of github, pull requests, merges,
> and so forth.
> Nor compiling!
> But when I get home from holiday (another 8 days), that is on my list of
> things to get up to speed on. 

I'm going on vacation soon, but I could offer a walk through git (video chat) 
once I'm back.


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] X-Trans Interpolation code

2019-06-14 Thread Andreas Schneider
On Friday, June 14, 2019 1:40:34 PM CEST johannes hanika wrote:
> > So, if it is practical and you folks are OK with it,  I'd like to
> > "borrow/reuse" that code in DeepSkyStacker.
> 
> sure, it's GPL:
> 

This means it is not compatible with libraw (LGPL & CDDL) nor with 
DeepSkyTracker as it is not Open Source :-(

It is never too late to choose a copyleft license :-)

https://tldrlegal.com/license/gnu-general-public-license-v3-(gpl-3)

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Camera-specific curves generation process

2019-06-03 Thread Andreas Schneider
On Monday, 3 June 2019 13:57:18 CEST Florian W wrote:
> Hi there,
> 
> Does anyone know if the procedure to generate the curves for a specific
> camera model is still up to date ?
> 
> I took the instructions from here (5 years old though) :
> https://www.darktable.org/2013/10/about-basecurves/#comment-30544 and in
> the README of $darktable_src/tools/basecurve.
> 
> I tried to generate curves for my Canon 750d with shots unfocused, both
> over and under exposed at the same time as instructed (see the jpg at
> https://ibb.co/C29R6Q9).
> And well... the generated curve is not very useful... see
> https://ibb.co/rG5yvnm
> 
> Does one has to do a lot a sample shots (and maybe more diverse kind of
> shots) to get a correct result ?
> Or maybe someone has successfuly generated its camera's basecurve and can
> provide some guidance with this problem ?


The correct way would be to follow:

https://pixls.us/articles/profiling-a-camera-with-darktable-chart/



Andreas 


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] DT bad on skin tones?

2019-05-28 Thread Andreas Schneider
On Wednesday, May 29, 2019 5:48:30 AM CEST paul sorenson wrote:
> This thread is fascinating to me. Are there resources out there for
> those who want to learn a more technical approach to editing with
> Darktable. As has been mentioned elsewhere, the manual kind of presents
> modules in isolation eg the base curve docs don't come with a warning -
> well maybe a hint in the tip at the end.
> 
> I am using 2.7 built from source with base curve turned off but still
> tend to use filmic a bit by the seat of the pants.

As always there are several ways to contribute to a Free and Open Source 
project. If you're not writing code, writing documentation is a very good way 
to contribute!

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Suggestion for a different module to correct fisheye distortion

2019-05-27 Thread Andreas Schneider
On Monday, May 27, 2019 10:58:21 AM CEST Dane Goodwin wrote:
> Hey all

Hi,

> I came across this blog which shows an alternative way to correct fisheye
> distortion that gives better results than the current rectilinear
> correction offered by the lens correction module in darktable:
> https://www.lonelyspeck.com/defish/

doesn't hugin correct fish-eye lenses? I also thought that lensfun has special 
support for them.


    Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Testing darktable isolated from production

2019-05-03 Thread Andreas Schneider
On Thursday, 2 May 2019 17:28:33 CEST dt-l...@stefan-klinger.de wrote:
> Florian Hühn (2019-May-02, excerpt):
> > If you rerun
> > cmake --build './build' --target install -- -j "$(nproc)"
> 
> ok.  But it is necessary to install, right?
> 
> > Just two thoughts about the isolation issue: Maybe consider setting
> > LD_LIBRARY_PATH as well to reduce your chances of accidentially mixing up
> > the *.so's with your productive version.
> 
> How would I set this up?  Is it just
> 
> export LD_LIBRARY_PATH="${prefix}/lib64"
> "${prefix}/bin/darktable" --configdir "${tmpCfg}" --cachedir
> "${tmpCache}"
> > (Personally I use a dedicated VM for
> > development, so take my suggestens as ideas, not as tested procedure.)
> 
> That would be overkill (meaning: I'm too lazy to go through all that
> hassle), I'd rather not do this at all.

Normally you can run applications out of the build dir from cmake, however 
darktable is a bit different because it loads a lot of modules using dlopen(). 
The path is normally the one of system installation dir.

It would be possible to support that, if you put the bin and modules in 
specific dirs, write the build dir to a config.h and then change the functions 
looking for the modules to first check the build dir and then the system dir. 
We could support this for e.g. debug builds.

I've worked on that some time ago but didn't have time to finish it.


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable-gen-noiseprofile crashing: darktable-cli: Cannot access memory at address 0x0

2019-03-11 Thread Andreas Schneider
On Saturday, March 9, 2019 7:18:44 PM CET Wolfgang Goetz wrote:
> Hi,
> 
> following the new process for generating noise profiles by Andreas Schneider
> on pixls.us: unfortunately the tool is stopping in first picture.
> (Exitcode: 139)

Pascal, this dereferences `self` which is a NULL pointer when calling 
dt_undo_start_group().

This means that when we call the function in dt_undo_start_group(). The global 
variable `darktable` seems not to be set up yet! Also normally it is a bad 
thing to work with extern variables, we should use getter and setter for that 
which do error checking and probably abort() early if something is wrong.


Just my 2 cents :-)



Andreas

> 
> see ProcCmdLine in Ubu problem report. (sorry for the Screenshot, c+p not
> possible)
> 
> 
> darktable-cli DSC_0120.NEF DSC_0120.-l.jpg
> 
> crashlog attached.
> 
> 
> 
> 
> goetz@wgdesktop:~/noiseprofile_Z7$
> /opt/darktable/libexec/darktable/tools/darktable-gen-noiseprofile -d $(pwd)
> ===> Check for required tools
> --> Check for images handling tools availability
> --> Check for images export tools availability
> --> Check for profiling tools availability
> --> Check for tethering tools availability
> --> Check for pdf tools availability
> 
> ===> Check profiling directory
> 
> ===> List profiling input RAW images
> --> Found ISO 31 image: /home/goetz/noiseprofile_Z7/DSC_0120.NEF
> --> Found ISO 40 image: /home/goetz/noiseprofile_Z7/DSC_0121.NEF
> --> Found ISO 50 image: /home/goetz/noiseprofile_Z7/DSC_0122.NEF
> --> Found ISO 64 image: /home/goetz/noiseprofile_Z7/DSC_0123.NEF
> --> Found ISO 80 image: /home/goetz/noiseprofile_Z7/DSC_0124.NEF
> --> Found ISO 100 image: /home/goetz/noiseprofile_Z7/DSC_0125.NEF
> --> Found ISO 125 image: /home/goetz/noiseprofile_Z7/DSC_0126.NEF
> --> Found ISO 160 image: /home/goetz/noiseprofile_Z7/DSC_0127.NEF
> --> Found ISO 200 image: /home/goetz/noiseprofile_Z7/DSC_0128.NEF
> --> Found ISO 250 image: /home/goetz/noiseprofile_Z7/DSC_0129.NEF
> --> Found ISO 320 image: /home/goetz/noiseprofile_Z7/DSC_0130.NEF
> --> Found ISO 400 image: /home/goetz/noiseprofile_Z7/DSC_0131.NEF
> --> Found ISO 500 image: /home/goetz/noiseprofile_Z7/DSC_0132.NEF
> --> Found ISO 640 image: /home/goetz/noiseprofile_Z7/DSC_0133.NEF
> --> Found ISO 800 image: /home/goetz/noiseprofile_Z7/DSC_0134.NEF
> --> Found ISO 1000 image: /home/goetz/noiseprofile_Z7/DSC_0135.NEF
> --> Found ISO 1250 image: /home/goetz/noiseprofile_Z7/DSC_0136.NEF
> --> Found ISO 1600 image: /home/goetz/noiseprofile_Z7/DSC_0137.NEF
> --> Found ISO 2000 image: /home/goetz/noiseprofile_Z7/DSC_0138.NEF
> --> Found ISO 2500 image: /home/goetz/noiseprofile_Z7/DSC_0139.NEF
> --> Found ISO 3200 image: /home/goetz/noiseprofile_Z7/DSC_0140.NEF
> --> Found ISO 4000 image: /home/goetz/noiseprofile_Z7/DSC_0141.NEF
> --> Found ISO 5000 image: /home/goetz/noiseprofile_Z7/DSC_0142.NEF
> --> Found ISO 6400 image: /home/goetz/noiseprofile_Z7/DSC_0143.NEF
> --> Found ISO 8000 image: /home/goetz/noiseprofile_Z7/DSC_0144.NEF
> --> Found ISO 1 image: /home/goetz/noiseprofile_Z7/DSC_0145.NEF
> --> Found ISO 12800 image: /home/goetz/noiseprofile_Z7/DSC_0146.NEF
> --> Found ISO 16000 image: /home/goetz/noiseprofile_Z7/DSC_0147.NEF
> --> Found ISO 2 image: /home/goetz/noiseprofile_Z7/DSC_0148.NEF
> --> Found ISO 25600 image: /home/goetz/noiseprofile_Z7/DSC_0149.NEF
> --> Found ISO 32254 image: /home/goetz/noiseprofile_Z7/DSC_0150.NEF
> --> Found ISO 40637 image: /home/goetz/noiseprofile_Z7/DSC_0151.NEF
> --> Found ISO 51200 image: /home/goetz/noiseprofile_Z7/DSC_0152.NEF
> --> Found ISO 102400 image: /home/goetz/noiseprofile_Z7/DSC_0153.NEF
> 
> The script will use existing input RAW images for the profiling. No more
> shot will be taken.
> 
> ===> Checking profiling RAW images correctness + Jpeg export
> --> ISO 31:
> /home/goetz/noiseprofile_Z7/DSC_0120.NEF
> goetz@wgdesktop:~/noiseprofile_Z7$ echo $?
> 139


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL memory usage on integrated graphics

2019-03-11 Thread Andreas Schneider
On Friday, March 8, 2019 5:09:23 PM CET Sturm Flut wrote:
> Hi Bjoern,
> 
> hm, Global memory size is 5.78GiB and Max allocation size is 2.89GiB. I
> had a look at darktable's OpenCL code and opencl_memory_requirement from
> darktablerc is compared against CL_DEVICE_GLOBAL_MEM_SIZE. So in your
> case that should be 512 MB < 5.78GiB and the device should be used.
> 
> The relevant error message should be "[opencl_init] discarding device
> $DEVICE due to insufficient global memory ($GLOBAL_MEM MB)". Do you see
> that error message when running darktable with "-d opencl", and if yes,
> what does it say?
> 
> I would understand it if the device/driver was blacklisted, or if the
> system didn't have enough memory, but I'm curious as to why it works
> when you set opencl_memory_requirement to slightly less than 512 MB. It
> feels like a rather arbitrary limit.

Intel's Beignet OpenCL driver is blacklisted as it doesn't work!

See also the 'darktable-cltest' command.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL question

2019-03-07 Thread Andreas Schneider
On Thursday, March 7, 2019 8:34:39 PM CET David Vincent-Jones wrote:
> Thank you Andreas . here are my results
> 
> [W530 ~]# opencl_device_priority=*/!0,*/*/*
> -bash: !0: event not found
> [W530 ~]# opencl_mandatory_timeout=250
> [W530 ~]# opencl_scheduling_profile=very fast GPU
> -bash: fast: command not found
> 
> I am using dual monitors by the way with dt running on the extended display.
> On 2019-03-07 11:21 a.m., Andreas Schneider wrote:
> > opencl_scheduling_profile=very fast GPU[W530 ~]#
> > opencl_async_pixelpipe=true

Those are for the darktablerc config file not commands for bash ...


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL question

2019-03-07 Thread Andreas Schneider
On Thursday, March 7, 2019 8:09:48 PM CET David Vincent-Jones wrote:
> Sorry for the lack of appropriate material ... I hope this added info is
> what you are looking for:
> 
> Card is Nvidia GK107GLM (Quadro K1000M)
> 
> driver=nvidia ver:415.27
> 
> Operating system x86_64 Manjaro rolling release using Arch repos.
> 
> I am not sure if the intel driver is blacklisted  does it
> specifically need blacklisting?

I'm using the following settings:

opencl_async_pixelpipe=true
opencl_device_priority=*/!0,*/*/*
opencl_mandatory_timeout=250
opencl_scheduling_profile=very fast GPU


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL question

2019-03-07 Thread Andreas Schneider
On Wednesday, 6 March 2019 22:06:37 CET David Vincent-Jones wrote:
> dt version: 2.7.0+594~g03d44f57e Manjaro from Arch-repos.
> 
> I have recently initiated OpenCL on my system. When I start from the
> terminal (-d opencl) all indications are that all the elements are
> successfully in place ... no errors are shown, however the system is now
> running very very slowly and after a while it locks-up. When I
> switch-off opencl dt runs correctly again.

As always when asking those questions, please be precise and share details. 
This means it would be nice to know which graphics card you have and which 
driver you're using.

For exmaple Intel is blacklisted.


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Pushing ISO (ISO invarience)

2019-03-02 Thread Andreas Schneider
Hi,

there a video where they did take and underexposed image and then pushed the 
exposure 4 EVs. darktable produced a darker image than the other raw 
developers.

https://www.youtube.com/watch?v=RAb85TukSuc


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] An algorithm to downscale raw data BEFORE demosaic by whatever scale factor

2019-02-20 Thread Andreas Schneider
On Wednesday, 5 September 2018 21:34:21 CET rawfiner wrote:
> Hi!

Hi rawfinder,

> Some of you may now that I am working on a raw denoising algorithm.
> One of the hard thing was that prior to demosaic, the algorithms are
> computed on unscaled data, while after demosaic the algorithms can compute
> a preview on a downscaled image, which is easier in terms of speed.

what happended to your work, any news?


Thanks,


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Links on darktable.org

2019-02-17 Thread Andreas Schneider
On Sunday, February 17, 2019 10:22:25 PM CET Bruce Williams wrote:
> Hey guys,

Hi Bruce,

> Just wondering what the etiquette/procedure is for getting a link added to
> the resources page of darktable.org?
> The link to my darktable playlist (currently at 28 episodes, and still
> growing) is here:
> https://www.youtube.com/playlist?list=PLlYWvzmJQTrRq7JrYdD7k3-8-v-uHnhK_
> I had someone email and ask why my videos weren't linked from there. I said
> I didn't know. 
> Is it possible to add that link, by any chance?

you can find the sources of the website here:

https://github.com/darktable-org/dtorg

and submit pull requests :-)


Best regards,


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Dynamic Memory Allocation Overhaul

2019-02-03 Thread Andreas Schneider
On Sunday, 3 February 2019 18:17:00 CET Mark Feit wrote:
> (This has been split off from the static code analysis thread since it's
> a different topic.)
> 
> I've completed the first cut of an overhaul of the use of dynamic memory
> allocation in the source tree with an eye toward safety and an eventual
> place to do a clean shutdown (closing the database, removing locks, etc.).
> 
> 
> What was done:
> 
> Malloc(), calloc(), realloc(), strdup() and strndup() have been made
> fail-safe through counterparts named dt_*() which exit cleanly through a
> common function.  The new versions are in the utilities.h header as
> short static inline functions that, on failure, call an error function
> in utilities.c.  This arrangement seems subjectively faster than a
> straight-up function call and doesn't pepper copies of the same static
> strings all over the object files.  If any functions have been missed,
> please point them out.
> 
> Calls to free() have been changed to dt_free(), which is currently a
> pass-through to free().
> 
> dt_alloc_align() and dt_free_align() have been given the same treatment
> and renamed to dt_malloc_aligned() and dt_free_aligned() for name
> consistency with the other functions.

Thanks for your work.

If you want to change allocations anyway, you should really take a look at 
talloc [1]. talloc is a hierarchical, reference counted memory pool system 
with destructors. If you free the top memory context all children will be 
freed to. It is just fun working with it and memory leaks don't really happen 
anymore. If you forget to free some memory it will be gone once the parent is 
freed. Also you can print the memory allocation tree for inspection.

Just my 2 cents.

Cheers,


Andreas

[1] https://talloc.samba.org/talloc/doc/html/index.html


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] static code analysis

2019-01-27 Thread Andreas Schneider
On Sunday, 27 January 2019 12:18:51 CET Heiko Bauke wrote:
> Hi,
> 
> I think darktable has made a huge step forwards regarding new features
> in the recent 2.6 release.  For this reason I would like to focus on
> code quality, performance and user experience in my future contributions.

Hello Heiko,

static code analysis is OK. I use csbuild in my CI and have a Coverity 
account. However the Coverity scan service is currentrly down.

csbuild is what we use internally to do static analyis on every package which 
goes into the distribution, but it is open source so could be integrated into 
CI easily. See. e.g. here:

https://gitlab.com/libssh/libssh-mirror/pipelines
or
https://gitlab.com/cmocka/cmocka/pipelines

select a pipeline and look for the csbuild runner. It wont run Coverity for 
you, but clang-analyzer and cppcheck and more.

Extremly good are the Sanitizers. There is AddressSanitzer, MemorySanitizer, 
UndefinedSanitizer and ThreadSanitizer. However they do runtime detection and 
for that you need tests. Darktable doesn't have any testing at all. It means 
you would need to run darktable and edit images with it. The sanitizers make 
the code much slower, even with optimization turned on. Might still be worth 
to try them.

If you write multithreaded code you should always run your stuff with helgrind 
and drd.

Also compilers have really good warnings in the meantime you just need to turn 
them on and make them errors for developers. See the projects mentioned above.



Cheers,


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Cannot run darktable

2019-01-09 Thread Andreas Schneider
On Wednesday, January 9, 2019 11:59:25 AM CET Shah Faisal wrote:
> Hi everyone

Hi Faisal,

> Tried installing and uninstalling many times, both normally and through
> chocolatey.
> Attaching the bug report.

can you run 'darktable-cltest' in a console window. That should output the 
driver string so we can blacklist it.

Thanks

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Cannot run darktable

2019-01-09 Thread Andreas Schneider
On Wednesday, January 9, 2019 11:59:25 AM CET Shah Faisal wrote:
> Hi everyone
> Tried installing and uninstalling many times, both normally and through
> chocolatey.
> Attaching the bug report.
> Thanks,
> Faisal

Looks like we need to blacklist Intel OpenCL drivers on Windows too.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Update usermanual on website

2019-01-09 Thread Andreas Schneider
On Tuesday, January 8, 2019 7:28:48 PM CET rawfiner wrote:
> Hi,
> Is there any plan to update the usermanual to 2.6 soon on darktable.org?
> (both the online version and pdfs)
> It would be nice to have new modules and other change documentation
> available :-)

Did the documentation for the color balance module get updated?


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-17 Thread Andreas Schneider
On Saturday, 17 November 2018 16:28:02 CET johannes hanika wrote:
> hi,
> 
> this sounds weird, since the last changes to the core of that
> algorithm seem to be from 2017.
> 
> the bug report rawfiner linked may be related to this commit:
> 911133c87b45be22251cf7252ed729d1632a27b2 and that
> 51bfe2f29411c0146d0aea70bdf073647d606a40 (i.e. this is just how it
> works if you don't want to spend the full compute every time).
> 
> was your image the result of an export? high quality option checked?
> or a screen grab from darkroom mode? if it only happens spuriously
> with opencl there may be a memory allocation issue on the GPU? if
> there are any new processes claiming some of that for themselves
> running in the background after a system upgrade maybe?

This happende in darkroom and in the export and if I turned off OpenCL it 
works in darkroom.

It could also be a bug in the ROCm OpenCL implementation.


Cheers,


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread Andreas Schneider
On Friday, 16 November 2018 18:36:07 CET Pascal Obry wrote:
> Hu Andreas,

Hey!
 
> I cannot reproduce! Do you have this with all pictures or some only?
> What settings you're using? This module has not been changed recently.
> Any other module activated that could create bad interaction?

The issue is gone if I disable OpenCL ...


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] local contrast -> laplacian filter seems to be broken

2018-11-16 Thread Andreas Schneider
Hi,

the local contrast laplacian filter doesn't work anymore, it produces halos 
and strange artifacts. Here is just one example image showing the issue:

https://xor.cryptomilk.org/darktable/dt_local_contrast_laplacian.jpg

Was perfectly fine some days ago.


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: [darktable-dev] feature freeze

2018-11-15 Thread Andreas Schneider
On Thursday, 15 November 2018 21:33:00 CET Pascal Obry wrote:
> Le jeudi 15 novembre 2018 à 21:25 +0100, Andreas Schneider a écrit :
> > The issue is probably a migration which didn't work:
> > 
> > https://github.com/darktable-org/darktable/pull/1827
> > 
> > 
> > I'm using darktable master which was normally quite stable. The question
> > is
> > how can I fix this, change the blendop version in the XMP file back to an
> > earlier that the migration is redone and hope it will work?
> 
> If you have an XMP previous to the migration it should work.
> 
> But you probably didn't notice, the presets in data.db are all broken.
> So best to restore your backup :)

I don't have a backup to restore but I will have in future for the last 14 
days ...

$ which darktable
/home/asn/bin/darktable
$ cat bin/darktable 
#!/bin/bash

dt_db_files="data.db library.db"

dt_config_dir="$HOME/.config/darktable"
dt_backup_dir="$dt_config_dir/backup"

today=$(date +"%Y-%m-%d")

_backupdir="$dt_backup_dir/$today"

if [ ! -d "$_backupdir" ]; then
mkdir -p $_backupdir

for f in $dt_db_files; do
cp "$dt_config_dir/$f" "$_backupdir"
done

find $dt_backup_dir -maxdepth 1 -mtime +14 -type d | xargs rm -rf
fi

/usr/bin/darktable $@

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: [darktable-dev] feature freeze

2018-11-15 Thread Andreas Schneider
On Thursday, 15 November 2018 21:33:00 CET Pascal Obry wrote:
> Le jeudi 15 novembre 2018 à 21:25 +0100, Andreas Schneider a écrit :
> > The issue is probably a migration which didn't work:
> > 
> > https://github.com/darktable-org/darktable/pull/1827
> > 
> > 
> > I'm using darktable master which was normally quite stable. The question
> > is
> > how can I fix this, change the blendop version in the XMP file back to an
> > earlier that the migration is redone and hope it will work?
> 
> If you have an XMP previous to the migration it should work.

If not, how do you fix it?

> But you probably didn't notice, the presets in data.db are all broken.
> So best to restore your backup :)

All presets or just the ones using blend modes or masks? It really would help 
to get more details what actually is broken.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: [darktable-dev] feature freeze

2018-11-15 Thread Andreas Schneider
On Thursday, 15 November 2018 20:55:31 CET Bruce Williams wrote:
> Can you force a reload via the "selected images" module? I'm not at my
> machine right now, but from memory, there's a button that says "load side
> car file" or something similar.

The issue is probably a migration which didn't work:

https://github.com/darktable-org/darktable/pull/1827


I'm using darktable master which was normally quite stable. The question is 
how can I fix this, change the blendop version in the XMP file back to an 
earlier that the migration is redone and hope it will work?

Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] feature freeze

2018-11-15 Thread Andreas Schneider
On Thursday, 15 November 2018 18:36:02 CET Pascal Obry wrote:
> Dear all,
> 
> The feature freeze is effective since yesterday Nov 14th. So no more
> new feature can be integrated into darktable at this stage.
> 
> It is a good time to do some testing and report the issues you
> encounter. That is, we are entering a bug squash period :)

I have an image which just lost all its blend modes and drawn and paramatric 
masks.

However if I open the XMP file I can see the mask stuff still in there.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Error in user manual

2018-11-14 Thread Andreas Schneider
On Thursday, November 15, 2018 5:44:29 AM CET Bruce Williams wrote:
> Not sure who to address here, but came across this.
> In section 3.4.1.7, the screenshot shows a value called "Precedence", but
> the related text block is titled "Preference".

Bruce,

do you know how to use git? If not I can give you the instructions how to 
update the documentation. Just email me directly.


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Noise Profile

2018-11-05 Thread Andreas Schneider
Hi,

I'm still looking how to simplify the process for creating noise profiles. So 
I did a new experiment today.

However nobody really explained the plots to me. Could someone do that?

New test setup:

https://discuss.pixls.us/t/fujifilm-x-t3-support-tracking-discussion/9243/15?
u=asn

I just quickly shot the images so I was not very careful. Some could be a bit 
darker which produces a better result. I just want do know it this works. 
However nobody explained the plots and what to look at yet, so I have no idea 
and an explanation would be great.

Results:
https://xor.cryptomilk.org/darktable/ILCE-7M3/noise_result.pdf

https://xor.cryptomilk.org/darktable/ILCE-7M3/darktable-noiseprofile-20181105.tar.gz



Cheers,


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Lens recognition of Tamron 24-70 mm lens in lens correction module of darktable version 2.4.4

2018-11-05 Thread Andreas Schneider
On Monday, 5 November 2018 17:39:16 CET J. Kilchert wrote:
> Hi,

Hi Joachim,

> *This would require darktable to use **Exiv2 v0.26*
> 
> /*How can I get *//Exiv2 v0.26 into my * *//*darktable 2.4.4
> installation?*/

you should talk to the darktable maintainer of your Linux distribution.


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Camera recognition EOS 6D Mk II in Base curve module of darktable version 2.4.4

2018-11-05 Thread Andreas Schneider
On Monday, 5 November 2018 17:39:03 CET J. Kilchert wrote:
> Hi,

Hi Joachim,

> I'm using darktable 2.4.4 in a Linux Mint distro.
> 
> achim@achim-N56VZ ~ $ dpkg-query -W darktable
> darktable1:2.4.4-0pmjdebruijn1~xenial
> 
> Distributor ID:LinuxMint
> Description:Linux Mint 18.3 Sylvia
> Release:18.3
> Codename:sylvia
> 
> In the base curve module EOS 6D Mk II is not listed as one of the camera
> models.
> 
> /*Where is the camera model data base and how can I update it?*/

most cameras are not listed anymore. The best is to create a camera profile 
for your camera. You will get a tone curve for your camera which you can also 
copy into a basecurve. See:

https://blog.pixelbook.org/2018/10/sony-alpha-7-iii-basecurve-and-camera-profile-for-darktable/


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] What is the gamma.c IOP ?

2018-11-03 Thread Andreas Schneider
On Saturday, 3 November 2018 09:59:23 CET Andreas Schneider wrote:
> On Friday, 2 November 2018 21:10:33 CET Aurélien Pierre wrote:
> > Hi Jo !
> > 
> > Thanks for your answer.
> > 
> > So this doesn't explain why the global colorpicker readings change
> > depending on the display ICC profile, nor why using a log encoding
> > between -2.5 and 2.5 EV, the grey gets remapped to L = 77 instead of 50.
> > 
> > I believe there is a gamma correction where it doesn't belong. Where is
> > the code for the colorpicker ?
> 
> Aurélien,
> 
> you broke image export with the latest change:
> 
> See:
> 
> https://xor.cryptomilk.org/darktable/broken.jpg

Oh, I get the same if I open it in the darkroom!

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] What is the gamma.c IOP ?

2018-11-03 Thread Andreas Schneider
On Friday, 2 November 2018 21:10:33 CET Aurélien Pierre wrote:
> Hi Jo !
> 
> Thanks for your answer.
> 
> So this doesn't explain why the global colorpicker readings change
> depending on the display ICC profile, nor why using a log encoding
> between -2.5 and 2.5 EV, the grey gets remapped to L = 77 instead of 50.
> 
> I believe there is a gamma correction where it doesn't belong. Where is
> the code for the colorpicker ?

Aurélien,

you broke image export with the latest change:

See:

https://xor.cryptomilk.org/darktable/broken.jpg



Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darktable lag on a 4K monitor.

2018-11-02 Thread Andreas Schneider
On Friday, 2 November 2018 12:58:52 CET Sturm Flut wrote:
> Dear list,
> 
> I guess this can also depend a lot on the hardware and the specific
> X.Org/Mesa/GTK/driver version combinations. I've been using darktable on
> a 4K display with Arch Linux running on a Ryzen 1600X for one and a half
> years and there haven't been any noticeable lags, neither with the old
> NVIDIA GTX950 nor the new AMD RX570 GPU.

There definitely is, I'm running on openSUSE Tumbleweed, which is likely the 
same as you're running. And yes there is an event storm going on if you move 
the mouse.


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darktable lag on a 4K monitor.

2018-11-02 Thread Andreas Schneider
On Friday, 2 November 2018 05:05:51 CET August Schwerdfeger wrote:
> Darktable 2.4.3 and .4, MacOS and Fedora.
> 
> When using Darktable on a 4K monitor, I am experiencing a UI lag that seems
> dependent on the size of the application window.
> 
> For example, when I size the window with dimensions that are half those of
> the screen, the image highlight in the light table follows my mouse pointer
> with no noticeable lag. Resizing to three-quarters of the screen dimensions
> introduces a delay of about half a second between the time the pointer
> moves and the time the highlight changes. Resizing to full screen increases
> this lag to about a second.
> 
> Does anyone know what is causing this?

Yes, the lighttable code isn't as good as it could be :-)

See https://redmine.darktable.org/issues/10764


It probably need a rewrite but I have no clue about GTK. If someone knows GTK 
I'm happy to do some pair-programming to fix it.


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL issues

2018-10-30 Thread Andreas Schneider
On Monday, 29 October 2018 22:55:44 CET Aurélien Pierre wrote:
> Hallo Heiko !
> 
> Very pleased to hear that (not the bug part, though).
> 
> Did you try with smaller pictures ? Usually, darktable falls back to CPU
> when there is not enough ressource available on the GPU.
> 
> You can try :
> 
>  1. the command *nvidia-smi* to see how the GPU RAM is used (if there is
> not enough vRAM available, you will see an OpenCL error code -4).
>  2. setting opencl_async_pixelpipe=true in darktablerc
>  3. setting opencl_mandatory_timeout > 200 in darktablerc
> 
> Also, I have discovered this week that Gnome 3.28.2 with Xorg has
> serious memory leaks issues and can affect OpenCL performance. After
> several hours of uptime, Xorg consumes up to 1GB RAM/vRAM on Ubuntu
> 18.04, so OpenCL has not enough space.

Normally you need to select "very fast gpu" that darktable runs more stuff via 
OpenCL and this bright a huge boost when processing.

However this doesn't work for me right now. I've started to use the ROCm open 
soruce stuff from AMD but it doesn't have image support yet.


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] error on compiling dt

2018-10-28 Thread Andreas Schneider
On Sunday, 28 October 2018 13:54:01 CET rawfiner wrote:
> Hello
> 
> I see it is code from one of my pull request, though it compiled well on my
> computer.
> I learned afterwards that we should use gboolean instead of bool.
> I will correct this.
> Sorry for the mistake

I've already created https://github.com/darktable-org/darktable/pull/1780

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darkroom UI refactoring

2018-10-27 Thread Andreas Schneider
On Saturday, 27 October 2018 08:17:44 CEST Coding Dave wrote:
> I wonder 2 things:

Hi Dave,
 
> 1) Is this whole color topic written down somewhere with like a tutorial
> how to tune darktable for your camera to have nice colors (A video would be
> ok for me too)?

take a look at:

https://blog.pixelbook.org/2018/10/sony-alpha-7-iii-basecurve-and-camera-profile-for-darktable/

> 2) can we turn off the basecurve as default module if this is not the
> correct way to get nice colors?

It shouldn't be turned of by default in darktable but you can turn it off in 
the preset settings for your installation.


    Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] How to write on dt.org blog ?

2018-10-19 Thread Andreas Schneider
On Thursday, 18 October 2018 23:46:50 CEST Aurélien Pierre wrote:
> Hi everyone,

Hi Aurélien,
 
> My 2 pull requests have been merged into master, I'm very happy about
> it. These tools are very powerfull but certainly not intuitive and need
> a proper tutorial.

they also need to be documented in the darktable manual! :-) However great 
work!

> Could I get access to darktable.org blog so I can write a full tuto in
> English ?

The blog is here:

https://github.com/darktable-org/dtorg/tree/master/content/blog


You need to clone the repo and add a new entry :-)


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Colour Matrix for Canon EOS M3

2018-10-10 Thread Andreas Schneider
On Wednesday, 10 October 2018 09:23:13 CEST Andreas Schneider wrote:
> On Tuesday, 9 October 2018 22:33:19 CEST openhab.doc wrote:
> > Hi all,
> 
> Hi,
> 
> > the links are online again!
> > 
> > https://c.web.de/@615570179773960144/nzTRoUvERdKwexyPn7dv1w
> > 
> > https://c.web.de/@615570179773960144/fNAZ_GfRSuufUTyy4XQ--g
> 
> some of your pictures have glare, you need to check that it is absolutely
> minimal.
> 
> 
> The darktable-chart manual states:
> 
>   The neutral white color patch in the gray ramp (G00) should end up at 
> the L
> value specified in the description of your card. Often this is L=92 and
> requires you to overexpose the shot by about 1/3 EV. Ideally you make
> several shots with slightly different exposures to later select the right
> one in darktable.
> 
> However it doesn't tell you in which image and we always assumed the RAW
> without any modules applied. However it might be that the JPG is meant here.
> I've just tested it and the profile looks correct for my color checker now.

No, it is still too bright. I think I need to shoot my target again, and 
retry.

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Colour Matrix for Canon EOS M3

2018-10-10 Thread Andreas Schneider
On Tuesday, 9 October 2018 22:33:19 CEST openhab.doc wrote:
> Hi all,

Hi,
 
> the links are online again!
> 
> https://c.web.de/@615570179773960144/nzTRoUvERdKwexyPn7dv1w
> 
> https://c.web.de/@615570179773960144/fNAZ_GfRSuufUTyy4XQ--g

some of your pictures have glare, you need to check that it is absolutely 
minimal.


The darktable-chart manual states:

The neutral white color patch in the gray ramp (G00) should end up at 
the L
value specified in the description of your card. Often this is L=92 and
requires you to overexpose the shot by about 1/3 EV. Ideally you make
several shots with slightly different exposures to later select the 
right
one in darktable.

However it doesn't tell you in which image and we always assumed the RAW 
without any modules applied. However it might be that the JPG is meant here. 
I've just tested it and the profile looks correct for my color checker now.


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darkroom UI refactoring

2018-10-08 Thread Andreas Schneider
On Monday, 8 October 2018 10:06:45 CEST Jørn Villesen Christensen wrote:
> Hi,
> 
> 
> An alternative suggestion (as I have also found the module list a bit...
> difficult to work with sometimes :-D ). I have often wished for a search
> box, so here is an idea; not thought through, but meant as inspiration:
> 
> How about one big list of modules, but with collapsible sections (and
> thus not have the top buttons for bases, tones, colours, etc.).
> 
> At the top of the list, there would be a search bar that would let you
> easily filter on
>- name of module
>- tags associated (from the developers) with the module, such as
> bases, colours, enhancements...

I think Aurélien his idea is great also this is easy to achieve from a code 
point of you. This is also easy for newcomers to understand.

However the search option is an amazing idea with tags associated with 
modules. Could also be doable with a few lines of code.

However dynamic lists as you suggest are much harder to implement would need 
quite some refactoring and new code.



Andreas



-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darkroom UI refactoring

2018-10-08 Thread Andreas Schneider
On Monday, 8 October 2018 03:06:34 CEST Aurélien Pierre wrote:
> Hi everyone !

Hi Aurélien,
 
> I would like to propose a lifting for the UI in the darkroom.

I like the idea. However the crop and rotate module should be in the 'optics 
handling' subcategory.

Also the corrections group is too big, we need to split it or reduce it. As 
not everyone has all modules enabled, reducing it a bit might be enough.

I think defringe and haze removal are more saturation modules (one decreases 
and the other increases saturation) and maybe create a category for noise 
handling.


Best regards,


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Re: Colour Matrix for Canon EOS M3

2018-10-06 Thread Andreas Schneider
I'm currently travelling, but I guess you have glare in your image. I will 
update the article on pixls.us next week.

On October 5, 2018 5:44:07 PM UTC, "openhab.doc"  wrote:
>Hi,
>
>With the instructions on pixls.us and the link on darktable.org I'm
>trying 
>to create a profile for my camera. I noticed that if the value for GS0
>in 
>the RAW photo matches with the IT8 board (Wolf Faust C1 Target), the 
>corresponding JPG photo is very bright. What could be the reason?
>
>Example Inages can be downloaded from here:
>https://c.web.de/@615570179773960144/nzTRoUvERdKwexyPn7dv1w
>
>Camera setup:
>* In the camera I have switched off lens correction for vignetting and 
>colour failures
>* metering mode is set to evaluative metering
>
>darktable modules for RAW:
>* Base curve is witched off
>* demosaic is sitched off
>* White balance is switched on
>
>Thanks
>Pierre

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Color balance wheels

2018-09-22 Thread Andreas Schneider
On Saturday, September 22, 2018 2:32:16 AM CEST Aurélien Pierre wrote:
> Hi,

Hi Aurélien,
 
> I'm to add the ASC CDL mode (https://en.wikipedia.org/wiki/ASC_CDL) in
> RecRGB 2020 into the colorbalance module.
> 
> I have seen the prototype of the code for color wheels, from Tobias, and
> the comment :
> 
> // these are not in a state to be useful. but they look nice. too
> bad i couldn't map the enhanced mode with
> // negative values to the wheels :(
> 
> What exactly didn't work ? If the problem is merely mathematical, I can
> work on it. I'm just bad at GUIs and GTK stuff.
> 
> On another note, is it mandatory to make the adjustement in sRGB ? (why
> not a larger RGB space ?)

Oh, this sounds interesting, I use that module to fix color casts in 
nightphotography shots and haven't found a better way. However often it 
doesn't work that well and I woul with that the tone curve would have R G B 
channels to modify. I find it often really hard to modify a and b in L*a*b.


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Nikon D850 - white balance presets missing

2018-09-21 Thread Andreas Schneider
On Thursday, 20 September 2018 13:00:33 CEST Per Inge Oestmoen wrote:
> Hello Andreas,

Hi Per Inge,
 
> Thank you, it is beautiful in the Alps, I have seen many pictures from
> the Tirol area where the incomparably brilliant Swarovski binoculars are
> made :-)
> 
> But straight to the matter, it is nice that you are back in the seat -
> and tell me if you need any more material in some form or fashion.

I've started to update the values with the once you created, however there are 
some missing:

SodiumVaporFluorescent
WarmWhiteFluorescent
WhiteFluorescent
DayWhiteFluorescent
DaylightFluorescent
HighTempMercuryVaporFluorescent

Could you create pictures with those white balance presets and provide the 
values like before?

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Nikon D850 - white balance presets missing

2018-09-20 Thread Andreas Schneider
On Friday, 14 September 2018 21:56:06 CEST Per Inge Oestmoen wrote:
> Hello again Andreas,
> 
> Have the values provided been helpful in your work with the white
> balance presets for Nikon D850?

Hi Per Inge,

sorry, I was on vacation in the alps.

the D850 white balance has been pushed upstream but the 1.1 firmware. I can 
look into getting your values in.


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Nikon D850 - white balance presets missing

2018-09-08 Thread Andreas Schneider
On Friday, 7 September 2018 16:28:43 CEST Per Inge Oestmoen wrote:
> Hello Andreas!

Hi Per Inge,

> 
> I have now followed the instructions and run the perl script below, and
> here are the results. Please tell me if I need to do something more with
> them.
> 
>  > https://xor.cryptomilk.org/darktable/wb_extract.pl

I've just discovered https://github.com/darktable-org/darktable/pull/1680

Maybe check if the values match your findings.


Andreas

> Sincerely,
> Per Inge Oestmoen, Norway
> 
> 
> 
> The Nikon D850 White Balance presets:
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0360_Auto.NEF
> 
> 
>{ "NIKON", "D850", "Auto0", 0,{ 1.30127, 1, 1.873047,
> 0 } },
> 
> 
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0361_Natural_Light_Auto.NEF
> 
> 
>{ "NIKON", "D850", "Natural Auto", 0, { 1.852051, 1,
> 1.375488, 0 } },
> 
> 
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0362_Incandescent.NEF
> 
> 
>{ "NIKON", "D850", "Incandescent", 0, { 1.205078, 1,
> 2.206543, 0 } },
> 
> 
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0363_Fluorescent.NEF
> 
> 
>{ "NIKON", "D850", "Cool WHT FL", 0,  { 1.721191, 1,
> 2.064453, 0 } },
> 
> 
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0364_Direct_Sunlight.NEF
> 
> 
>{ "NIKON", "D850", "Direct sunlight", 0,  { 1.900391, 1,
> 1.375488, 0 } },
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0365_Flash.NEF
>{ "NIKON", "D850", "Flash", 0,{ 2.164063, 1,
> 1.204102, 0 } },
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0366_Cloudy.NEF
>{ "NIKON", "D850", "Cloudy", 0,   { 2.049805, 1,
> 1.244629, 0 } },
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> perl wb_extract.pl _DSC0367_Shade.NEF
>{ "NIKON", "D850", "Shade", 0,{ 2.396484, 1,
> 1.114258, 0 } },
> 
> siberia@linux-hf6b:/run/media/siberia/WD_Passport/Nikon_D850_WB_presets>
> 
> 
>  > Andreas Schneider wrote:
> > On Saturday, 1 September 2018 12:33:15 CEST Per Inge Oestmoen wrote:
> >> Hello,
> > 
> > Hello Per Inge,
> > 
> >> I have noticed that as of September 01, 2018, there are no white balance
> >> presets for the Nikon D850.
> >> 
> >> Are there plans to include the white balance presets for the Nikon D850
> >> soon?
> >> 
> >> Do you need and want me to provide some RAW files in order to help you
> >> with the process?
> > 
> > if you want them, you need to take a pictures and calculate them.
> > 
> > I wanted to create a nice python script which can extract them, but exiv2
> > doesn't support it yet. However the developer promised to add support for
> > it.
> > 
> > In the meantime you can use a very old perl script. I've uploaded it here:
> > 
> > https://xor.cryptomilk.org/darktable/wb_extract.pl
> > 
> > It needs exiftool.
> > 
> > You need to take a picture for every preset available and I've also
> > created
> > presets for the following Kelvin values:
> > 
> > 2500K
> > 3200K
> > 4500K
> > 5000K
> > 5500K
> > 6000K
> > 6500K
> > 
> > Put the RAW files in a directory and run the perl script from above. When
> > shooting the pictures, note down which image number is which preset.
> > Sometimes you don't find the name in the RAW.
> > 
> > 
> > Cheers,
> > 
> > Andreas




___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] How do you feel about code bounties ?

2018-09-08 Thread Andreas Schneider
On Saturday, 8 September 2018 07:24:51 CEST Aurélien Pierre wrote:
> Hi everyone,

Hi Aurélien,

> Shouldn't we merge Github issues and Redmine bugs/FR, and promote
> bountysource ?

I doesn't really make sense to start with bounties while github merge requests 
are bit rotting. Even small changes which are easy to review ...


Andreas


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: Re: [darktable-dev] Which colour target is recommended for a proper colour matrix

2018-09-05 Thread Andreas Schneider
On Wednesday, 5 September 2018 20:48:14 CEST openhab.doc wrote:
> Hi,
> In the meantime, I've become more familiar with the topic and I have further
> questions.
> 
> As reported I still do not have a color chart.

> 3.) Wolf Faust offers for the C1 additionally to the Kodak Paper a new
> version based on alu-dibond. Can this make trouble?
> http://www.targets.coloraid.de/

I would go with that one, it has been suggested by houz or hanatos. Also I'm 
really interested in the results. It might not ship with a cht file but well 
you could create one, I'm sure it will come with the information needed to do 
so.


Andreas

> PS: @Andreas Schnerider: In your article at pixls.us you refer to ArgyllCMS
> CIE and CHT files at /usr/share/color/argyll/ref/
> I know that the path is from system to system different.
> for Manjaro Linux the files can be fond here:
> /usr/share/argyllcms/ref/argyllcms

I can't list all possible directories but one should be able to find out with 
his package manager e.g. rpm -ql aryllcms and if I add this then someone comes 
and tells me it doesn't work on Debian ...

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] GMIC module

2018-09-05 Thread Andreas Schneider
On Wednesday, 5 September 2018 07:49:26 CEST Heiko Bauke wrote:
> Hi,

Hi Heiko,

> I am not sure, if one should integrate this module into main.  After
> playing with the GMIC filters, however, I think it would be great to
> (re-)implement some of the GMIC filters for darktable.  In particular,
> the Richardson-Lucy deconvolution sharpening filter is something that I
> desperately miss in vanilla darktable.
> 
> What do you think?  Any suggestions?  Is the a GMIC filter that you wish
> to able to use in darktable?

I think having a few filter available (implemented) in darktable would be 
really great!

However, something else, I'm still looking forward to get the guided filter 
for parametric and drawn masks, any news on that front? :-)


    Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Which colour target is recommended for a proper colour matrix

2018-09-04 Thread Andreas Schneider
On Tuesday, 4 September 2018 19:48:29 CEST openhab.doc wrote:
> Hello Andreas,
> 
> thank you for reply!
> 
> At the darktable homepage you will find here
> https://www.darktable.org/development/
> the Chapter "… a color matrix for your camera:" with a link to
> https://encrypted.pcode.nl/blog/2010/06/28/darktable-camera-color-profiling/
> 
> The link above is the article I read.
> 
> I don't know the article your link is referring. I'll look at this one, too
> Is this a newer one?

Yes, the one on pixls.us is newer :-)


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Which colour target is recommended for a proper colour matrix

2018-09-04 Thread Andreas Schneider
On Tuesday, 4 September 2018 17:43:37 CEST openhab.doc wrote:
> Good evening all,

Hello Pierre,

> I have read the article „color matrix for your camera“ at the darktable
> homepage. Now I think over to buy me a colour target but I am not sure
> which one.

can you please post a link to the article you read? I don't find one with that 
title.

If you want to create a camera profile with a target, I suggest you read:

https://pixls.us/articles/profiling-a-camera-with-darktable-chart/


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



  1   2   >