Bug#809719: roxterm: Most shortcuts are ineffective

[François Gannaz]

Le 2016-01-06, Tony Houghton  a écrit :
> On 05/01/16 18:32, François Gannaz wrote:
> > Removing the locale with `LANG=C roxterm --separate` does fix it.
> >
> > And just as you suggested, the problem lies within the matching of
> > action names. The strange part is that only part of it is
> > translated:
> >
> > File/New Tab=t
> > File/Nouvel Onglet=t
> >
> > "File" is translated into "Fichier" in roxterm's menu, but
> > "Fichier/Nouvel Onglet" was ignored.  
> 
> So the submenu strings have to be translated, but not the top-level
> menus? Strange. I might be able to at least correct that for
> consistency, but I don't know what the ultimate solution would be. It
> doesn't help that it's years since I worked on the relevant parts of
> the code! If I make it so that the shortcuts are English then the
> standard ones will work no matter what the language, but that will
> make it harder for non-English users to configure their own. Is it
> normal for the keystrokes to stay the same no matter what language is
> used, or for those to be changed to match the words in other
> languages? For example, would you expect to use t to
> match the English version, or o for "onglet".

I'm very reluctant to a localized configuration, with keyboard shortcuts
would vary with the locale. When I switch to another system, I expect
an application to behave similarly: I've used Ctrl-Shift-t with several
terminal emulators, and I did not care much which locale was declared,
it was always the same shortcuts in every terminal.

I would also get very confused if my config file were to break when the
locale changes.

I suspect some people pay more attention to menus and consistency
between labels and shortcuts, but probably not that much for something
as technical as a terminal emulator.

That's my opinion, you decide.
--
François

Bug#809719: roxterm: Most shortcuts are ineffective

[Tony Houghton]

On 05/01/16 15:23, François Gannaz wrote:
> Le 2016-01-05, Tony Houghton  a écrit :
>>
>> Can you try building replacement debian packages to test? You should
>> just be able to run debuild -b in the git/source directory.
>
> I had to install itstool and po4a. The resulting package had no
> keyboard shortcuts.

Strange.

> The new roxterm executable was the same size as the official one,
> though the MD5 sum was different. The locally-compiled (outside
> debuild) file was 43% larger.

The difference in size is probably because the debian build strips out 
the debugging symbols and puts them in a separate package (roxterm-dbg).

I think the most likely reason for the self-build working and the
debian build not is because the latter sets PREFIX to /usr. Without
being set eg by debian/rules it defaults to /usr/local, so I would have
expected your self-build to fail to find some files. Does it appear all
in English instead of partially French (the French translation is only
71% complete)?

There's also a script called AppRun in the source tree. It's designed
to run roxterm directly from its build directory and point it to its 
default resource files supplied with the source. It would be
interesting to know whether that works.

I've just had an idea. The shortcuts might not be matching, because the 
menu strings have been translated to French so they don't match the 
strings in the Shortcuts/Default file. Do they work if you edit your 
Shortcuts file to translate the strings to French so they match the 
translated menus?

>>> The keypad decimal bug is not affected by this, so it should go in
>>> another bug report.
>>
>> Could you test that in gnome-terminal instead of xfce4-terminal?  I
>> think xfce4 is still based on GTK+2.0 with a much older version of
>> vte. Also try other text fields from gnome-terminal, roxterm and/or
>> other GTK+3.0-based programs.
>
> To sum it up:
>
> xev:.
> xfce4-terminal: . (GTK+2, libvte 0.28)
> gnome-terminal: ,
> roxterm 3.3.1:  , (libvte 0.42)
>
> Unless you suggest something else, I suppose I shall open a new ticket
> in libgtk-3-0.

Check some other text entry widgets too to test whether it's all of
GTK3 or just VTE.

PS Make sure you don't install gettext 0.19.7-1 because bug #809846 
prevents roxterm from being built with translations.

Bug#809719: roxterm: Most shortcuts are ineffective

[François Gannaz]

Le 2016-01-06, Tony Houghton  a écrit :
> So for the moment you would prefer the config to be in English, I
> think. Even that will be a bit difficult to fix and test, but ideally
> there should be some sort of system to allow users to edit the
> shortcuts in their own language and store the results in English.
> Solving this might have to wait until if and when I do a major rewrite
>  

I've had a look at the code yesterday, to see if I could submit an easy
patch, but I was cast away by the mix of GTK's map_accelerators and
gettext. I could not even plan a pretty way out.

> but at the moment I'm leaning towards discontinuing roxterm and
> trying to get more involved with gnome-terminal and vte development
> if the current team are willing to let me add some features from
> roxterm. If not, I suppose I could fork it.

I'd read about this in roxterm's forum before reporting the bug. That's
sad because I think roxterm is good, better than xfce4-terminal that I
was using a few years ago. Yet I understand the move. I may try again
gnome-terminal on the next roxterm bug ;-)

--
François

Bug#809719: roxterm: Most shortcuts are ineffective

[François Gannaz]

Le 2016-01-05, Tony Houghton  a écrit :
> 
> Can you try building replacement debian packages to test? You should
> just be able to run debuild -b in the git/source directory.

I had to install itstool and po4a. The resulting package had no keyboard
shortcuts.

The new roxterm executable was the same size as the official one, though
the MD5 sum was different. The locally-compiled (outside debuild) file was
43% larger.

> > The keypad decimal bug is not affected by this, so it should go in
> > another bug report.  
> 
> Could you test that in gnome-terminal instead of xfce4-terminal?  I
> think xfce4 is still based on GTK+2.0 with a much older version of vte.
> Also try other text fields from gnome-terminal, roxterm and/or other
> GTK+3.0-based programs.

To sum it up:

xev:.
xfce4-terminal: . (GTK+2, libvte 0.28)
gnome-terminal: ,
roxterm 3.3.1:  , (libvte 0.42)

Unless you suggest something else, I suppose I shall open a new ticket
in libgtk-3-0.

Bug#809719: roxterm: Most shortcuts are ineffective

[Tony Houghton]

On 05/01/16 10:43, François Gannaz wrote:

On my laptop, I compiled roxterm from the source, using the git tag 3.3.1.
I wanted to bisect the bug, but shortcuts worked flawlessly with this
self-compiled roxterm. I followed the default process, didn't set any
configuration option, and simply run `./build/roxterm --separate`.

If I copy this new roxterm binary to my desktop computer (both are
Testing Debian amd64) in /usr/bin/, shortcuts are also fixed.


Can you try building replacement debian packages to test? You should
just be able to run debuild -b in the git/source directory.


The keypad decimal bug is not affected by this, so it should go in
another bug report.


Could you test that in gnome-terminal instead of xfce4-terminal?  I
think xfce4 is still based on GTK+2.0 with a much older version of vte.
Also try other text fields from gnome-terminal, roxterm and/or other
GTK+3.0-based programs.

Bug#809719: roxterm: Most shortcuts are ineffective

[François Gannaz]

On my laptop, I compiled roxterm from the source, using the git tag 3.3.1.
I wanted to bisect the bug, but shortcuts worked flawlessly with this
self-compiled roxterm. I followed the default process, didn't set any
configuration option, and simply run `./build/roxterm --separate`.

If I copy this new roxterm binary to my desktop computer (both are
Testing Debian amd64) in /usr/bin/, shortcuts are also fixed.

The keypad decimal bug is not affected by this, so it should go in
another bug report.

Le 2016-01-04, Tony Houghton  a écrit :
> tags 809719 - moreinfo
> thanks
> 
> It looks like there's a problem in roxterm's locale handling, maybe 
> specifically fr_FR.utf8. The reporter of #804144, which looks related, 
> has the same locale.

Bug#809719: roxterm: Most shortcuts are ineffective

[Tony Houghton]

tags 809719 - moreinfo
thanks

It looks like there's a problem in roxterm's locale handling, maybe 
specifically fr_FR.utf8. The reporter of #804144, which looks related, 
has the same locale.

Bug#809719: roxterm: Most shortcuts are ineffective

[François Gannaz]

Thank you for your quick response.

The diff between /usr and ~/.config shortcuts is one line long:
9d8
< Edit/Select All=a

Removing the user config file or copying over it has no visible effect.

I don't know if it is related, but KP_Decimal outputs a comma "," within
roxterm. It printed a dot "." before the upgrade, like xfce4-terminal
still does. My config has not changed, and `setxkbmap -query` confirms
that "option kpdl:dot" is still active. `xev` also sees a "." for this
keypress.

Le 2016-01-04, Tony Houghton  a écrit :
> tags 809719 + unreproducible moreinfo
> thanks
> 
> On 03/01/16 11:13, François Gannaz wrote:
> 
> > After updating my distribution, most shortcuts defined in the default
> > profile of roxterm are ineffective. The same behaviour occurs on my
> > laptop, after updating it to the latest Stretch.
> >
> > The configuration file for shortcuts is unchanged:
> > `~/.config/roxterm.sourceforge.net/Shortcuts/Default`  
> 
> Please post that file here here. It's possible there might have been a 
> format change over the years, or at least I can try the config here and 
> hopefully be able to reproduce the problem.
> 
> If the shortcuts are unchanged you shouldn't need that config file and 
> it will use the one from /usr/share/roxterm/Config. Does removing the 
> one in ~/.config/ fix it? If so, does editing the shortcuts break it again?

Bug#809719: roxterm: Most shortcuts are ineffective

[Tony Houghton]

tags 809719 + unreproducible moreinfo
thanks

On 03/01/16 11:13, François Gannaz wrote:


After updating my distribution, most shortcuts defined in the default
profile of roxterm are ineffective. The same behaviour occurs on my
laptop, after updating it to the latest Stretch.

The configuration file for shortcuts is unchanged:
`~/.config/roxterm.sourceforge.net/Shortcuts/Default`


Please post that file here here. It's possible there might have been a 
format change over the years, or at least I can try the config here and 
hopefully be able to reproduce the problem.


If the shortcuts are unchanged you shouldn't need that config file and 
it will use the one from /usr/share/roxterm/Config. Does removing the 
one in ~/.config/ fix it? If so, does editing the shortcuts break it again?

Bug#809719: roxterm: Most shortcuts are ineffective

[François Gannaz]

Package: roxterm
Version: 3.3.1-1
Severity: important

Dear Maintainer,

After updating my distribution, most shortcuts defined in the default
profile of roxterm are ineffective. The same behaviour occurs on my
laptop, after updating it to the latest Stretch.

The configuration file for shortcuts is unchanged:
`~/.config/roxterm.sourceforge.net/Shortcuts/Default`

I tried each of them (21 shortcuts) and the only definitions that worked
were: Tabs/Previous Tab=Page_Up
Tabs/Next Tab=Page_Down

It seems the keys are simply sent to the shell. Ctrl-Shit-t behaves like
Ctrl-t (transpose). C-S-c is like Ctrl-c. Ctrl-- or F1 have no visible
effect. I tried to change the most needed "File/New Tab" shortcut, but
it made no difference.

I suspected libvte was in fault, but Ctrl-Shift-t does work in
xfce4-terminal 0.6.3-2 and gnome-terminal 3.18.2-1.

Regards,

F. G.

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (800, 'testing'), (600, 'stable'), (50, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.8-fg (SMP w/6 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages roxterm depends on:
ii  libc6   2.21-6
ii  libcairo2   1.14.4-1
ii  libdbus-1-3 1.10.6-1
ii  libdbus-glib-1-20.102-1
ii  libgdk-pixbuf2.0-0  2.32.3-1
ii  libglib2.0-02.46.2-3
ii  libgtk-3-0  3.18.6-1
ii  libice6 2:1.0.9-1+b1
ii  libpango-1.0-0  1.38.1-1
ii  librsvg2-common 2.40.11-2
ii  libsm6  2:1.2.2-1+b1
ii  libvte-2.91-0   0.42.1-2
ii  libx11-62:1.6.3-1
ii  roxterm-data3.3.1-1

roxterm recommends no packages.

roxterm suggests no packages.

-- no debconf information