Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-13 Thread Martijn Kruithof

+1

Martijn

Op 11-3-2013 15:05, Peter Reilly schreef:

+1
Peter


On Sun, Mar 10, 2013 at 9:30 AM, Jean-Louis Boudart 
jeanlouis.boud...@gmail.com wrote:


+1 on the release as is too
Works perfectly in easyant :)


2013/3/9 Stefan Bodewig bode...@apache.org


+1 on the release as is.

On 2013-03-08, Antoine Levy Lambert wrote:


You can veto the release if it matters that much to you and I would
then have to drop and recreate the 1.9.0 label and do a new build.

Maybe I'm picking nits: you can't veto a release, this is a majority
vote.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://incubator.apache.org/easyant/




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [ANNOUNCE] Apache Ant 1.9.0 Released

2013-03-11 Thread Michael Clarke
From the release notes:
 - support for @Ignore annotation and requirement of JUnit 4.11

This isn't quite true: we now support @Ignore in JUnit4 but should be
able to support all JUnit versions. The change in JUnit JAR in the
optional directory was to allow testing of Assume failures with a
specified message so only impacts Ant's unit tests, not tests executed
by Ant. I've been using the Nightly Build version of the JUnit task to
execute tests running with JUnit 4.2 for the past week without issue.
Could we therefore update the homepage key features note to make this
clear. I'd suggest just removing the bullet point about JUnit
versions.

Thanks
Michael

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [ANNOUNCE] Apache Ant 1.9.0 Released

2013-03-11 Thread Antoine Levy Lambert
Apologies for my mistake.

I have just updated the homepage.

regards,

Antoine
On Mar 11, 2013, at 4:40 AM, Michael Clarke wrote:

 From the release notes:
 - support for @Ignore annotation and requirement of JUnit 4.11
 
 This isn't quite true: we now support @Ignore in JUnit4 but should be
 able to support all JUnit versions. The change in JUnit JAR in the
 optional directory was to allow testing of Assume failures with a
 specified message so only impacts Ant's unit tests, not tests executed
 by Ant. I've been using the Nightly Build version of the JUnit task to
 execute tests running with JUnit 4.2 for the past week without issue.
 Could we therefore update the homepage key features note to make this
 clear. I'd suggest just removing the bullet point about JUnit
 versions.
 
 Thanks
 Michael
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-11 Thread Peter Reilly
+1
Peter


On Sun, Mar 10, 2013 at 9:30 AM, Jean-Louis Boudart 
jeanlouis.boud...@gmail.com wrote:

 +1 on the release as is too
 Works perfectly in easyant :)


 2013/3/9 Stefan Bodewig bode...@apache.org

  +1 on the release as is.
 
  On 2013-03-08, Antoine Levy Lambert wrote:
 
   You can veto the release if it matters that much to you and I would
   then have to drop and recreate the 1.9.0 label and do a new build.
 
  Maybe I'm picking nits: you can't veto a release, this is a majority
  vote.
 
  Stefan
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
  For additional commands, e-mail: dev-h...@ant.apache.org
 
 


 --
 Jean Louis Boudart
 Independent consultant
 Apache EasyAnt commiter http://incubator.apache.org/easyant/



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-10 Thread Jean-Louis Boudart
+1 on the release as is too
Works perfectly in easyant :)


2013/3/9 Stefan Bodewig bode...@apache.org

 +1 on the release as is.

 On 2013-03-08, Antoine Levy Lambert wrote:

  You can veto the release if it matters that much to you and I would
  then have to drop and recreate the 1.9.0 label and do a new build.

 Maybe I'm picking nits: you can't veto a release, this is a majority
 vote.

 Stefan

 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org




-- 
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://incubator.apache.org/easyant/


[RESULT] [VOTE] Release Ant 1.9.0 [2nd attempt]

2013-03-10 Thread Antoine Levy Lambert
Hi,

the release vote has passed with 5 +1's and no other votes.

Also we need to update the WHATSNEW [on the web site only, none in the release 
artefacts] to mention the fact that 1.9.0 requires Java 1.5.

I am going to start copying the artifacts and updating the web site.

Regards,

Antoine
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[ANNOUNCE] Apache Ant 1.9.0 Released

2013-03-10 Thread Antoine Levy Lambert

Hi,

I am pleased to announce the release of Apache Ant 1.9.0.


Apache Ant is a Java based build tool.

- Version 1.9.0 is the first Ant release which requires at least Java 1.5.
- support for @Ignore annotation and requirement of JUnit 4.11
- the zip, bzip2 and tar are improved
- removal of the Perforce Ant tasks; users of these tasks can use the tasks 
supplied by Perforce Inc. instead, which contain more functionality and connect 
natively to the Perforce servers
- numerous bug fixes and improvements as documented in Bugzilla and in the 
release notes



Source and binary distributions are available from the Apache Ant
download site:

http://ant.apache.org/bindownload.cgi

and

http://ant.apache.org/srcdownload.cgi

Please verify signatures using the KEYS file available at the above
location when downloading the release.

For complete information on Ant, including instructions on how to submit
bug reports, patches, or suggestions for improvement, see the Apache Ant
website:

http://ant.apache.org/index.html

Antoine Levy-Lambert, on behalf of the Apache Ant community
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-09 Thread Stefan Bodewig
+1 on the release as is.

On 2013-03-08, Antoine Levy Lambert wrote:

 You can veto the release if it matters that much to you and I would
 then have to drop and recreate the 1.9.0 label and do a new build.

Maybe I'm picking nits: you can't veto a release, this is a majority
vote.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Jesse Glick

“Changes that could break older environments” fails to list the Java 5 
requirement!

Typo in WHATSNEW: “NullPointerExcpetion”

Otherwise, +1.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Bruce Atherton
Good catch, Jesse. I have to admit I find the lack of a mention of 
requiring Java 5 troubling. That is definitely a difference people are 
going to care about.


Is it possible to sneak that edit in to the WHATSNEW file (in both the 
bin and src packages) without a whole new revote?


On 13-03-08 06:55 AM, Jesse Glick wrote:
“Changes that could break older environments” fails to list the Java 5 
requirement!


Typo in WHATSNEW: “NullPointerExcpetion”

Otherwise, +1.



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Antoine Levy Lambert
Hello Bruce,

the WHATSNEW is included in the bin and the src package so to change it a new 
vote would be required. In fact a new build would be required.

You can veto the release if it matters that much to you and I would then have 
to drop and recreate the 1.9.0 label and do a new build.

Otherwise, we can include the mention that the new release requires Java 1.5 in 
the README.html and in the emails sent to announce the release, as well as on 
the Ant web site.

Regards,

Antoine


On Mar 8, 2013, at 3:49 PM, Bruce Atherton wrote:

 Good catch, Jesse. I have to admit I find the lack of a mention of requiring 
 Java 5 troubling. That is definitely a difference people are going to care 
 about.
 
 Is it possible to sneak that edit in to the WHATSNEW file (in both the bin 
 and src packages) without a whole new revote?
 
 On 13-03-08 06:55 AM, Jesse Glick wrote:
 “Changes that could break older environments” fails to list the Java 5 
 requirement!
 
 Typo in WHATSNEW: “NullPointerExcpetion”
 
 Otherwise, +1.
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-08 Thread Bruce Atherton

Yes, that is what I thought.

I think your answer is a good compromise. +1 on the vote.

On 08/03/2013 2:10 PM, Antoine Levy Lambert wrote:

Hello Bruce,

the WHATSNEW is included in the bin and the src package so to change it a new 
vote would be required. In fact a new build would be required.

You can veto the release if it matters that much to you and I would then have 
to drop and recreate the 1.9.0 label and do a new build.

Otherwise, we can include the mention that the new release requires Java 1.5 in 
the README.html and in the emails sent to announce the release, as well as on 
the Ant web site.

Regards,

Antoine


On Mar 8, 2013, at 3:49 PM, Bruce Atherton wrote:


Good catch, Jesse. I have to admit I find the lack of a mention of requiring 
Java 5 troubling. That is definitely a difference people are going to care 
about.

Is it possible to sneak that edit in to the WHATSNEW file (in both the bin and 
src packages) without a whole new revote?

On 13-03-08 06:55 AM, Jesse Glick wrote:

“Changes that could break older environments” fails to list the Java 5 
requirement!

Typo in WHATSNEW: “NullPointerExcpetion”

Otherwise, +1.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-07 Thread Maarten Coene
+1

Maarten





 From: Antoine Levy Lambert anto...@gmx.de
To: Ant Developers List dev@ant.apache.org 
Sent: Thursday, March 7, 2013 2:47 AM
Subject: Re: [VOTE] Ant 1.9.0 release [2nd attempt]
 
Adding that I had forgotten to put the .asc files, this is now uploaded too.


On Mar 5, 2013, at 11:16 PM, Antoine Levy Lambert wrote:

 Hi,
 
 I have uploaded candidate artifacts a second time for an ant 1.9.0 release to 
 : http://people.apache.org/~antoine/dist/ after having incorporated the 
 patches of Michael Clarke concerning JUnit.
 
 Let's vote on releasing Ant 1.9.0 a second time.
 
 Let' start with my own +1
 
 Regards,
 
 Antoine


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-06 Thread Antoine Levy Lambert
Adding that I had forgotten to put the .asc files, this is now uploaded too.


On Mar 5, 2013, at 11:16 PM, Antoine Levy Lambert wrote:

 Hi,
 
 I have uploaded candidate artifacts a second time for an ant 1.9.0 release to 
 : http://people.apache.org/~antoine/dist/ after having incorporated the 
 patches of Michael Clarke concerning JUnit.
 
 Let's vote on releasing Ant 1.9.0 a second time.
 
 Let' start with my own +1
 
 Regards,
 
 Antoine


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-05 Thread Antoine Levy Lambert
I did not find the time to make a new build last night, it will be for my NYC 
evening.

Regards,

Antoine
On Mar 4, 2013, at 11:43 PM, Antoine Levy Lambert wrote:

 In fact I found out that I need to add ham crest on the class path, this was 
 probably meant by the patch but I did not notice that.
 
 Regards,
 
 Antoine
 On Mar 4, 2013, at 11:25 PM, Antoine Levy Lambert wrote:
 
 Hello Jesse,
 
 in fact the patch is failing one test :
 
 testTestMethods in junit-test.xml
 
 The test bad in T2.java runs [or at least something is reported as failing ] 
 although only ok is included.
 
 
   /junit
 /target
 
 
 
 Regards,
 
 Antoine
 On Mar 4, 2013, at 4:55 PM, Jesse Glick wrote:
 
 -0. My main reservation is that an important patch, JUnit @Ignore support 
 [1], is outstanding. (I promised Michael Clarke it would get reviewed.) It 
 could be pushed back to 1.9.1 of course, but that could be a long way off.
 
 [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=43969
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-05 Thread Jesse Glick

On 03/04/2013 11:25 PM, Antoine Levy Lambert wrote:

in fact the patch is failing one test :

testTestMethods in junit-test.xml


Now fixed? Reports:

skipping tests since it fails when using JUnit 4

But there is one genuine failure I know about, which predates @Ignore support:

https://builds.apache.org/job/Ant-Build-Matrix/jdk=JDK%201.7%20(latest),label=Ubuntu/lastCompletedBuild/testReport/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/

Reproducible locally when running on Java 7. Not yet sure what it means but it 
looks bad.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-05 Thread Jesse Glick

On 03/05/2013 08:45 PM, Jesse Glick wrote:

Reproducible locally when running on Java 7. Not yet sure what it means but it 
looks bad.


https://issues.apache.org/bugzilla/show_bug.cgi?id=54641


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-05 Thread Antoine Levy Lambert
Hi,

yes, I also noticed the failure of this XMLResultAggregatorTest and came to the 
conclusion that the junitreport stylesheet needed to be changed.

Regards,

Antoine
On Mar 5, 2013, at 9:16 PM, Jesse Glick wrote:

 On 03/05/2013 08:45 PM, Jesse Glick wrote:
 Reproducible locally when running on Java 7. Not yet sure what it means but 
 it looks bad.
 
 https://issues.apache.org/bugzilla/show_bug.cgi?id=54641
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[VOTE] Ant 1.9.0 release [2nd attempt]

2013-03-05 Thread Antoine Levy Lambert
Hi,

I have uploaded candidate artifacts a second time for an ant 1.9.0 release to : 
http://people.apache.org/~antoine/dist/ after having incorporated the patches 
of Michael Clarke concerning JUnit.

Let's vote on releasing Ant 1.9.0 a second time.

Let' start with my own +1

Regards,

Antoine

Re: [VOTE] Ant 1.9.0 release

2013-03-04 Thread Conor MacNeill
Nice work Antoine,

+1

Conor


On 4 March 2013 15:34, Antoine Levy Lambert anto...@gmx.de wrote:

 Hi,

 I have uploaded candidate artefacts for an ant 1.9.0 release to :
 http://people.apache.org/~antoine/dist/

 Let's vote on releasing these.

 Let' start with my own +1

 I ran the build on MacOS with JDK 1.6 and there were no errors/failures in
 the tests.

 On MacOS with JDK 1.7 two tests are failing :

 -  org.apache.tools.ant.taskdefs.optional.junit.XMLResultAggregatorTest
 fails with an error (couldn't compile stylesheet), this is similar to a bug
 present in the eclipse bugzilla [1]
  - org.apache.tools.ant.taskdefs.ExecuteJavaTest has one failure in
 testNoTimeOutForked process should not have been killed

 The Windows [3]  and Linux [4] build configurations on the Jetbrains
 server referenced from our Nightly+Continuous Buids page [2] are now
 successful

 The Ant JDK build matrix on builds.apache.org is failing with errors
 which seem to come from the server environment or the setup in Jenkins,
 particularly going out of memory.
 I do not think that I have the karma to change the setup of the builds and
 add some VM args - which usually are not needed anyway.

 Regards,

 Antoine

 [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=384757
 [2] http://ant.apache.org/nightlies.html
 [3]
 http://teamcity.jetbrains.com/viewLog.html?buildTypeId=bt133buildId=lastFinished
 [4] http://teamcity.jetbrains.com/viewType.html?buildTypeId=bt134
 [5] https://builds.apache.org/job/Ant-Build-Matrix/




Re: [VOTE] Ant 1.9.0 release

2013-03-04 Thread Jesse Glick
-0. My main reservation is that an important patch, JUnit @Ignore support [1], is outstanding. (I promised Michael Clarke it would get reviewed.) It could be pushed back 
to 1.9.1 of course, but that could be a long way off.


[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=43969


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-04 Thread Antoine Levy Lambert
Hello Jesse,

I will incorporate the patch for JUnit support and do another build.

Regards,

Antoine
On Mar 4, 2013, at 4:55 PM, Jesse Glick wrote:

 -0. My main reservation is that an important patch, JUnit @Ignore support 
 [1], is outstanding. (I promised Michael Clarke it would get reviewed.) It 
 could be pushed back to 1.9.1 of course, but that could be a long way off.
 
 [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=43969
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-04 Thread Antoine Levy Lambert
Hello Jesse,

in fact the patch is failing one test :

testTestMethods in junit-test.xml

The test bad in T2.java runs [or at least something is reported as failing ] 
although only ok is included.

Regards,

Antoine

 echo file=${input}/T1.javapublic class T1 extends
junit.framework.TestCase {
public void testOK() {}
public void testBad() {throw new 
RuntimeException(failed);}
}/echo
echo file=${input}/T2.java
import org.junit.Test;
public class T2 {
@Test 
public void ok() {}
@Test 
public void bad() {
throw new RuntimeException(failed);}
}/echo
javac srcdir=${input} destdir=${output} includes=T1.java,T2.java 
source=5 includeantruntime=false
  classpath
path refid=junit /
  /classpath
/javac
junit fork=true printsummary=true haltonerror=true
  classpath
pathelement location=${output} /
path refid=junit /
  /classpath
  test name=T1 methods=testOK /
  test name=T2 methods=ok /
/junit
  /target



Regards,

Antoine
On Mar 4, 2013, at 4:55 PM, Jesse Glick wrote:

 -0. My main reservation is that an important patch, JUnit @Ignore support 
 [1], is outstanding. (I promised Michael Clarke it would get reviewed.) It 
 could be pushed back to 1.9.1 of course, but that could be a long way off.
 
 [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=43969
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] Ant 1.9.0 release

2013-03-04 Thread Antoine Levy Lambert
In fact I found out that I need to add ham crest on the class path, this was 
probably meant by the patch but I did not notice that.

Regards,

Antoine
On Mar 4, 2013, at 11:25 PM, Antoine Levy Lambert wrote:

 Hello Jesse,
 
 in fact the patch is failing one test :
 
 testTestMethods in junit-test.xml
 
 The test bad in T2.java runs [or at least something is reported as failing ] 
 although only ok is included.
 
 
/junit
  /target
 
 
 
 Regards,
 
 Antoine
 On Mar 4, 2013, at 4:55 PM, Jesse Glick wrote:
 
 -0. My main reservation is that an important patch, JUnit @Ignore support 
 [1], is outstanding. (I promised Michael Clarke it would get reviewed.) It 
 could be pushed back to 1.9.1 of course, but that could be a long way off.
 
 [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=43969
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-03-03 Thread Stefan Bodewig
On 2013-02-19, Antoine Levy Lambert wrote:

 I am currently looking at the test failures of Ant under linux with
 Oracle JDK 1.6 here [1].

 These tests are referenced from the Nightly+ Continuous Builds page
 [2] under Apache Ant - Core Trunk (Linux)

I'd rather work with https://builds.apache.org/job/Ant-Build-Matrix/
which isn't really green (or blue) either.  We may want to fix the
nightly builds page.

 I would like to fix this so that we have a set of green lights before
 doing the release.

+1 unless what you see is really due to environmental issues on the
server.  You shouldn't waste your time debugging a remote system you
don't have access to, IMHO.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-03-03 Thread Antoine Levy Lambert
Hello Stefan,

I have found out that the root cause of the test failures found is the java vm 
running with file.encoding set to ASCII.

The  tests that fail are written in such a way that they assume that Ant is 
running with file.encoding=UTF-8 which is the default it seems in a lot of Java 
1.6 VMs (but not all).

Also, by default StringResource instances have a null encoding, which works 
when the encoding of the VM is UTF-8. 

I am making a change to change the default encoding of StringResource to 
UTF-8 which seems to lead to better results when the VM is running under 
ASCII encoding ( ANSI_X3.4-1968 precisely).

Also, I found out that the contains/ selector needs an encoding attribute to 
have a chance to do its job when the encoding of the files to select is 
different from the default encoding of the JVM.

I am addressing that by adding an encoding attribute on the contains selector.

Regards,

Antoine

On Mar 3, 2013, at 5:19 AM, Stefan Bodewig wrote:

 On 2013-02-19, Antoine Levy Lambert wrote:
 
 I am currently looking at the test failures of Ant under linux with
 Oracle JDK 1.6 here [1].
 
 These tests are referenced from the Nightly+ Continuous Builds page
 [2] under Apache Ant - Core Trunk (Linux)
 
 I'd rather work with https://builds.apache.org/job/Ant-Build-Matrix/
 which isn't really green (or blue) either.  We may want to fix the
 nightly builds page.
 
 I would like to fix this so that we have a set of green lights before
 doing the release.
 
 +1 unless what you see is really due to environmental issues on the
 server.  You shouldn't waste your time debugging a remote system you
 don't have access to, IMHO.
 
 Stefan
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[VOTE] Ant 1.9.0 release

2013-03-03 Thread Antoine Levy Lambert
Hi,

I have uploaded candidate artefacts for an ant 1.9.0 release to : 
http://people.apache.org/~antoine/dist/

Let's vote on releasing these.

Let' start with my own +1

I ran the build on MacOS with JDK 1.6 and there were no errors/failures in the 
tests.

On MacOS with JDK 1.7 two tests are failing :

-  org.apache.tools.ant.taskdefs.optional.junit.XMLResultAggregatorTest fails 
with an error (couldn't compile stylesheet), this is similar to a bug present 
in the eclipse bugzilla [1]
 - org.apache.tools.ant.taskdefs.ExecuteJavaTest has one failure in 
testNoTimeOutForked process should not have been killed

The Windows [3]  and Linux [4] build configurations on the Jetbrains server 
referenced from our Nightly+Continuous Buids page [2] are now successful

The Ant JDK build matrix on builds.apache.org is failing with errors which seem 
to come from the server environment or the setup in Jenkins, particularly going 
out of memory.
I do not think that I have the karma to change the setup of the builds and add 
some VM args - which usually are not needed anyway.

Regards,

Antoine 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=384757
[2] http://ant.apache.org/nightlies.html
[3] 
http://teamcity.jetbrains.com/viewLog.html?buildTypeId=bt133buildId=lastFinished
[4] http://teamcity.jetbrains.com/viewType.html?buildTypeId=bt134
[5] https://builds.apache.org/job/Ant-Build-Matrix/



RE: Ant 1.9.0

2013-02-19 Thread Justin Georgeson
Late to the thread here, but I just upgraded to 1.8.4 and have an issue with 
the javac task and package-info.class. We have a number of javac tasks with 
compilerarg line=-proc:only/ and those are generating package-info.class 
files. I don't see a task attribute or nested element to directly tell Ant that 
I only want annotations processing and not actual compilation of class files. I 
added a destdir attribute to those javac invocations, but it'd be nice if the 
task checked for that compiler arg or had an native attribute so that it 
wouldn't create the package-info.class files.

-Original Message-
From: Antoine Levy Lambert [mailto:anto...@gmx.de] 
Sent: Monday, February 18, 2013 10:17 AM
To: Ant Developers List
Subject: Re: Ant 1.9.0

Hello,

after a few weeks of very hard work at my day job I have a quiet day to look at 
these patches.

I also need to look at possible test failures running the ant test suite on my 
MAC with Java 1.7

Regards,

Antoine

On Feb 5, 2013, at 6:16 PM, Jesse Glick wrote:

 On 01/30/2013 10:09 PM, Antoine Levy Lambert wrote:
 Are there other bugs - ideally with patches - that the community needs?
 
 Those with PatchAvailable [1] should be checked. (Pity that we cannot just 
 get pull requests; coming from the land of GitHub this feels really 
 primitive.) There were a fair number recently, e.g. the 54298-54305 series.
 
 I cannot see myself spending much time on this now unfortunately, but if you 
 are willing to put together a 1.9.0, +1 to the effort (and incidentally a 
 belated +1 for removing proprietary tasks).
 
 
 [1] 
 https://issues.apache.org/bugzilla/buglist.cgi?keywords=PatchAvailable
 keywords_type=allwordsbug_status=NEWbug_status=ASSIGNEDbug_status=
 REOPENEDbug_status=NEEDINFOproduct=Antlist_id=95004
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, 
e-mail: dev-h...@ant.apache.org

--
This e-mail, including any attached files, may contain confidential and 
privileged information for the sole use of the intended recipient.  Any review, 
use, distribution, or disclosure by others is strictly prohibited.  If you are 
not the intended recipient (or authorized to receive information for the 
intended recipient), please contact the sender by reply e-mail and delete all 
copies of this message.

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-02-19 Thread Jesse Glick

On 02/19/2013 10:31 AM, Justin Georgeson wrote:

have an issue with the javac task and package-info.class


Please use Bugzilla to report things like this.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



RE: Ant 1.9.0

2013-02-19 Thread Justin Georgeson
Indeed

https://issues.apache.org/bugzilla/show_bug.cgi?id=54583

-Original Message-
From: Jesse Glick [mailto:jgl...@cloudbees.com] 
Sent: Tuesday, February 19, 2013 12:34 PM
To: dev@ant.apache.org
Subject: Re: Ant 1.9.0

On 02/19/2013 10:31 AM, Justin Georgeson wrote:
 have an issue with the javac task and package-info.class

Please use Bugzilla to report things like this.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, 
e-mail: dev-h...@ant.apache.org


--
This e-mail, including any attached files, may contain confidential and 
privileged information for the sole use of the intended recipient.  Any review, 
use, distribution, or disclosure by others is strictly prohibited.  If you are 
not the intended recipient (or authorized to receive information for the 
intended recipient), please contact the sender by reply e-mail and delete all 
copies of this message.


Re: Ant 1.9.0

2013-02-18 Thread Antoine Levy Lambert
Hello,

after a few weeks of very hard work at my day job I have a quiet day to look at 
these patches.

I also need to look at possible test failures running the ant test suite on my 
MAC with Java 1.7

Regards,

Antoine

On Feb 5, 2013, at 6:16 PM, Jesse Glick wrote:

 On 01/30/2013 10:09 PM, Antoine Levy Lambert wrote:
 Are there other bugs - ideally with patches - that the community needs?
 
 Those with PatchAvailable [1] should be checked. (Pity that we cannot just 
 get pull requests; coming from the land of GitHub this feels really 
 primitive.) There were a fair number recently, e.g. the 54298–54305 series.
 
 I cannot see myself spending much time on this now unfortunately, but if you 
 are willing to put together a 1.9.0, +1 to the effort (and incidentally a 
 belated +1 for removing proprietary tasks).
 
 
 [1] 
 https://issues.apache.org/bugzilla/buglist.cgi?keywords=PatchAvailablekeywords_type=allwordsbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFOproduct=Antlist_id=95004
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-02-18 Thread Antoine Levy Lambert
Hi,

I am currently looking at the test failures of Ant under linux with Oracle JDK 
1.6 here [1].

These tests are referenced from the Nightly+ Continuous Builds page [2] under 
Apache Ant - Core Trunk (Linux)

It looks like the OS/JVM combination does not read properly the XML entities or 
the non-ascii characters in the build files.

I would like to fix this so that we have a set of green lights before doing the 
release.

If someone has some ideas on the root cause of the test failures and the best 
way to address that I am interested.

Also I did not look yet at the FindBugs build configuration which is also 
failing.



Regards,

Antoine


[1] http://teamcity.jetbrains.com/viewType.html?buildTypeId=bt134
[2] http://ant.apache.org/nightlies.html


On Feb 18, 2013, at 11:17 AM, Antoine Levy Lambert wrote:

 Hello,
 
 after a few weeks of very hard work at my day job I have a quiet day to look 
 at these patches.
 
 I also need to look at possible test failures running the ant test suite on 
 my MAC with Java 1.7
 
 Regards,
 
 Antoine
 
 On Feb 5, 2013, at 6:16 PM, Jesse Glick wrote:
 
 On 01/30/2013 10:09 PM, Antoine Levy Lambert wrote:
 Are there other bugs - ideally with patches - that the community needs?
 
 Those with PatchAvailable [1] should be checked. (Pity that we cannot just 
 get pull requests; coming from the land of GitHub this feels really 
 primitive.) There were a fair number recently, e.g. the 54298–54305 series.
 
 I cannot see myself spending much time on this now unfortunately, but if you 
 are willing to put together a 1.9.0, +1 to the effort (and incidentally a 
 belated +1 for removing proprietary tasks).
 
 
 [1] 
 https://issues.apache.org/bugzilla/buglist.cgi?keywords=PatchAvailablekeywords_type=allwordsbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFOproduct=Antlist_id=95004
 
 
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 



Re: Ant 1.9.0

2013-02-05 Thread Jesse Glick

On 01/30/2013 10:09 PM, Antoine Levy Lambert wrote:

Are there other bugs - ideally with patches - that the community needs?


Those with PatchAvailable [1] should be checked. (Pity that we cannot just get pull requests; coming from the land of GitHub this feels really primitive.) There were a 
fair number recently, e.g. the 54298–54305 series.


I cannot see myself spending much time on this now unfortunately, but if you are willing to put together a 1.9.0, +1 to the effort (and incidentally a belated +1 for 
removing proprietary tasks).



[1] 
https://issues.apache.org/bugzilla/buglist.cgi?keywords=PatchAvailablekeywords_type=allwordsbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFOproduct=Antlist_id=95004



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-02-04 Thread B. Wing

Regarding bugs requested from the community I would definitely like to see
https://issues.apache.org/bugzilla/show_bug.cgi?id=54408

I submitted this bug with patch, and if someone can review my changes I'd 
be happy to revise based on suggestions.


Thanks,
Ben Wing

On Wed, 30 Jan 2013, Antoine Levy Lambert wrote:


Date: Wed, 30 Jan 2013 22:09:33 -0500
From: Antoine Levy Lambert anto...@gmx.de
Reply-To: Ant Developers List dev@ant.apache.org
To: Ant Developers List dev@ant.apache.org
Subject: Ant 1.9.0

Hi,

I would be interested to prepare soon an Ant 1.9.0 release.

In WHATSNEW I see we already have 17 fixed bugs.

Are there other bugs - ideally with patches - that the community needs ?

Also, Jan Mat?rne had proposed previously [1] to remove the Perforce Ant tasks 
from Ant due to the availability of better tasks supplied by Perforce.

Now would be a good time to remove them.

Do we need a vote for that ?

Best regards,

Antoine

[1] 
http://mail-archives.apache.org/mod_mbox/ant-dev/201012.mbox/%3C000601cb97a0$970bde10$c5239a30$@de%3E


dic...@freeshell.org
SDF Public Access UNIX System - http://freeshell.org

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-02-01 Thread Stefan Bodewig
Hi

On 2013-01-31, Antoine Levy Lambert wrote:

 I would be interested to prepare soon an Ant 1.9.0 release.

Obviously I've not been very active here lately, and to be honest, I
don't expect this to change anytime soon.  Thank you for taking this
forward.

Matt, do you expect the Java5ification to break existing public APIs?
If not, we could as well create a release now with the rather
incompletely migration and tak additional steps in later point releases.

Cheers

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-02-01 Thread Matt Benson
I don't think I've affected any APIs as yet.  This would be acceptable.

Matt


On Fri, Feb 1, 2013 at 9:19 AM, Stefan Bodewig bode...@apache.org wrote:

 Hi

 On 2013-01-31, Antoine Levy Lambert wrote:

  I would be interested to prepare soon an Ant 1.9.0 release.

 Obviously I've not been very active here lately, and to be honest, I
 don't expect this to change anytime soon.  Thank you for taking this
 forward.

 Matt, do you expect the Java5ification to break existing public APIs?
 If not, we could as well create a release now with the rather
 incompletely migration and tak additional steps in later point releases.

 Cheers

 Stefan

 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org




Re: Ant 1.9.0

2013-01-31 Thread Matt Benson
Hi Antoine,
  I had made a start towards upgrading to Java 5 syntax in the Ant codebase
some months back.  At some point we started getting odd failures in Gump
which I wasn't able to understand.  It might be nice to figure this out and
finish the Java 5-ization for 1.9.0.

br,
Matt


On Wed, Jan 30, 2013 at 9:09 PM, Antoine Levy Lambert anto...@gmx.dewrote:

 Hi,

 I would be interested to prepare soon an Ant 1.9.0 release.

 In WHATSNEW I see we already have 17 fixed bugs.

 Are there other bugs - ideally with patches - that the community needs ?

 Also, Jan Matèrne had proposed previously [1] to remove the Perforce Ant
 tasks from Ant due to the availability of better tasks supplied by Perforce.

 Now would be a good time to remove them.

 Do we need a vote for that ?

 Best regards,

 Antoine

 [1]
 http://mail-archives.apache.org/mod_mbox/ant-dev/201012.mbox/%3C000601cb97a0$970bde10$c5239a30$@de%3E


Re: Ant 1.9.0

2013-01-31 Thread Bruce Atherton
We've discussed this before[1] and already voted in favour of removing 
the commercial tasks from Ant some time ago[2]. A complication was that 
we wanted to create AntLibs for them if we couldn't get the vendors to 
support them directly so that there was minimal upset for our users, but 
apart from the VSS tasks that didn't happen. I did contact all the 
vendors at the time but I got virtually no response. The only company 
that did respond, as I recall, was Perforce. Perhaps that is why they 
now provide decent tasks themselves.


So this is one instance where what we wanted to happen has happened. +1 
to removing the tasks, with a document redirect on where to get the 
tasks now.


[1] http://mail-archives.apache.org/mod_mbox/ant-dev/201005.mbox/browser
[2] http://mail-archives.apache.org/mod_mbox/ant-dev/201006.mbox/browser

On 30/01/2013 7:09 PM, Antoine Levy Lambert wrote:

Hi,

I would be interested to prepare soon an Ant 1.9.0 release.

In WHATSNEW I see we already have 17 fixed bugs.

Are there other bugs - ideally with patches - that the community needs ?

Also, Jan Matèrne had proposed previously [1] to remove the Perforce Ant tasks 
from Ant due to the availability of better tasks supplied by Perforce.

Now would be a good time to remove them.

Do we need a vote for that ?

Best regards,

Antoine

[1] 
http://mail-archives.apache.org/mod_mbox/ant-dev/201012.mbox/%3C000601cb97a0$970bde10$c5239a30$@de%3E



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-01-31 Thread Antoine Levy Lambert
Hello Bruce, 

I can see myself implementing the removal of the Perforce Ant tasks, this 
should be pretty straightforward.

I will work on this this week-end.

Regards,

Antoine
On Jan 31, 2013, at 12:40 PM, Bruce Atherton wrote:

 We've discussed this before[1] and already voted in favour of removing the 
 commercial tasks from Ant some time ago[2]. A complication was that we wanted 
 to create AntLibs for them if we couldn't get the vendors to support them 
 directly so that there was minimal upset for our users, but apart from the 
 VSS tasks that didn't happen. I did contact all the vendors at the time but I 
 got virtually no response. The only company that did respond, as I recall, 
 was Perforce. Perhaps that is why they now provide decent tasks themselves.
 
 So this is one instance where what we wanted to happen has happened. +1 to 
 removing the tasks, with a document redirect on where to get the tasks now.
 
 [1] http://mail-archives.apache.org/mod_mbox/ant-dev/201005.mbox/browser
 [2] http://mail-archives.apache.org/mod_mbox/ant-dev/201006.mbox/browser
 
 On 30/01/2013 7:09 PM, Antoine Levy Lambert wrote:
 Hi,
 
 I would be interested to prepare soon an Ant 1.9.0 release.
 
 In WHATSNEW I see we already have 17 fixed bugs.
 
 Are there other bugs - ideally with patches - that the community needs ?
 
 Also, Jan Matèrne had proposed previously [1] to remove the Perforce Ant 
 tasks from Ant due to the availability of better tasks supplied by Perforce.
 
 Now would be a good time to remove them.
 
 Do we need a vote for that ?
 
 Best regards,
 
 Antoine
 
 [1] 
 http://mail-archives.apache.org/mod_mbox/ant-dev/201012.mbox/%3C000601cb97a0$970bde10$c5239a30$@de%3E
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-01-31 Thread Antoine Levy Lambert
Hello Matt,

I have seen that you started upgrading to Java 5 syntax in the Ant codebase.

I do not see myself going systematically in the codebase to do that because I 
do not have the time to do it.

I will look to see whether there are failures in Gump.

I also got some failures running the unit tests in Java 1.7 locally on my Mac, 
I will need to dig into that and see whether the errors are reproduceable …

Regards,

Antoine


On Jan 31, 2013, at 10:31 AM, Matt Benson wrote:

 Hi Antoine,
  I had made a start towards upgrading to Java 5 syntax in the Ant codebase
 some months back.  At some point we started getting odd failures in Gump
 which I wasn't able to understand.  It might be nice to figure this out and
 finish the Java 5-ization for 1.9.0.
 
 br,
 Matt
 
 
 On Wed, Jan 30, 2013 at 9:09 PM, Antoine Levy Lambert anto...@gmx.dewrote:
 
 Hi,
 
 I would be interested to prepare soon an Ant 1.9.0 release.
 
 In WHATSNEW I see we already have 17 fixed bugs.
 
 Are there other bugs - ideally with patches - that the community needs ?
 
 Also, Jan Matèrne had proposed previously [1] to remove the Perforce Ant
 tasks from Ant due to the availability of better tasks supplied by Perforce.
 
 Now would be a good time to remove them.
 
 Do we need a vote for that ?
 
 Best regards,
 
 Antoine
 
 [1]
 http://mail-archives.apache.org/mod_mbox/ant-dev/201012.mbox/%3C000601cb97a0$970bde10$c5239a30$@de%3E


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ant 1.9.0

2013-01-31 Thread Bruce Atherton

Thanks very much, Antoine. It's appreciated.

On 13-01-31 06:11 PM, Antoine Levy Lambert wrote:

Hello Bruce,

I can see myself implementing the removal of the Perforce Ant tasks, this 
should be pretty straightforward.

I will work on this this week-end.

Regards,

Antoine




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org