1
1
count(if(a=1, 1, null)) syntax support
when does calcite support count(if(a=1, 1, null)) syntax ? spark, hive, clickhouse, impala, presto support the syntax for a long time.
[jira] [Created] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'
Benchao Li created CALCITE-5169:
---
Summary: 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'
Key: CALCITE-5169
URL: https://issues.apache.org/jira/browse/CALCITE-5169
Project: Calcite
Issue Type: Improvement
Components: core
Affects Versions: 1.30.0
Reporter: Benchao Li
Assignee: Benchao Li
Fix For: 1.31.0
As described in the title, {{xx < 1 OR xx > 1}} should be simplified to {{xx <>
1}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
Re: count(if(a=1, 1, null)) syntax support
IF was added in https://issues.apache.org/jira/browse/CALCITE-3731 and will be part of 1.27 release. IF is a dialect-specific function, enabled in bigquery, hive and spark function tables. There are several other ways you can achieve the same effect: * COUNT(*) FILTER (WHERE a = 1) * COUNT(CASE a WHEN 1 THEN 1 END) * COUNT(CASE WHEN a = 1 THEN 1 END) * COUNTIF(a = 1) // from 1.27, and only in the BigQuery dialect Julian On Sat, Feb 20, 2021 at 10:39 AM you Zhuang wrote: > > when does calcite support count(if(a=1, 1, null)) syntax ? spark, hive, > clickhouse, impala, presto support the syntax for a long time.
Re: count(if(a=1, 1, null)) syntax support
Hi,you Zhuang I find clacite have SqlIfFunction,but it don't accomplish. you Zhuang 于2021年2月21日周日 上午2:39写道： > when does calcite support count(if(a=1, 1, null)) syntax ? spark, hive, > clickhouse, impala, presto support the syntax for a long time. >
GROUP BY 1?
Hi Calcite community, I'm trying to validate a SQL like the one below. SELECT user_id, COUNT(1) cnt FROM schema.table_name GROUP BY 1; It looks like in the default configuration, GROUP BY 1 is not considered valid. It complains user_id is not being grouped. Is there a quick configuration that enables syntax like that? I'm looking at SqlParser.Config, but none of them seems to be relevant to this. Thanks. Thomas
[jira] [Created] (CALCITE-4364) "a in (1, 2) and a = 1" should be simplified to "a=1"
Danny Chen created CALCITE-4364:
---
Summary: "a in (1, 2) and a = 1" should be simplified to "a=1"
Key: CALCITE-4364
URL: https://issues.apache.org/jira/browse/CALCITE-4364
Project: Calcite
Issue Type: Bug
Components: core
Affects Versions: 1.26.0
Reporter: Danny Chen
Fix For: 1.27.0
Check this test in {{RexProgramTest}}:
```java
@Test void testSimplifyInAnd() {
// deptno in (20, 10) and deptno = 10
// ==>
// deptno = 10
final RexNode e =
and(
in(vInt(), literal(20), literal(10)),
eq(vInt(), literal(10)));
checkSimplify(e, "=(?0.int0, 10)");
}
```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: GROUP BY 1?
I figured it out. When initializing a SqlValidator, we need to pass in a SqlValidator.Config which has a method called withConformance where we can pass in a SqlConformance instance which has a config isGroupByOrdinal. Thomas On Mon, Dec 26, 2022 at 5:48 AM Thomas Wang wrote: > Hi Calcite community, > > I'm trying to validate a SQL like the one below. > > SELECT user_id, COUNT(1) cnt FROM schema.table_name GROUP BY 1; > > It looks like in the default configuration, GROUP BY 1 is not considered > valid. It complains user_id is not being grouped. > > Is there a quick configuration that enables syntax like that? I'm looking > at SqlParser.Config, but none of them seems to be relevant to this. > > Thanks. > > Thomas >
[jira] [Created] (CALCITE-1865) select count(1) from (select sum(1) .... without group by failed
zhou degao created CALCITE-1865: --- Summary: select count(1) from (select sum(1) without group by failed Key: CALCITE-1865 URL: https://issues.apache.org/jira/browse/CALCITE-1865 Project: Calcite Issue Type: Bug Reporter: zhou degao Assignee: Julian Hyde sqlline> !connect jdbc:calcite:model=core/target/test-classes/test-mysql-model.j son admin admin; 0: jdbc:calcite:model=core/target/test-classe> select count(1) from (select sum( 1) from R_DATABASE ) a; Error: Error while executing SQL "select count(1) from (select sum(1) from R_DAT ABASE ) a": while executing SQL [SELECT COUNT(*) FROM (SELECT FROM `codedata`.`R_DATABASE` GROUP BY ()) AS `t`] (state=,code=0) java.sql.SQLException: Error while executing SQL "select count(1) from (select s um(1) from R_DATABASE ) a": while executing SQL [SELECT COUNT(*) FROM (SELECT FROM `codedata`.`R_DATABASE` GROUP BY ()) AS `t`] at org.apache.calcite.avatica.Helper.createException(Helper.java:56) at org.apache.calcite.avatica.Helper.createException(Helper.java:41) at org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaSt atement.java:156) at org.apache.calcite.avatica.AvaticaStatement.execute(AvaticaStatement. java:209) at sqlline.Commands.execute(Commands.java:822) at sqlline.Commands.sql(Commands.java:732) at sqlline.SqlLine.dispatch(SqlLine.java:813) at sqlline.SqlLine.begin(SqlLine.java:686) at sqlline.SqlLine.start(SqlLine.java:398) at sqlline.SqlLine.main(SqlLine.java:291) Caused by: java.lang.RuntimeException: while executing SQL [SELECT COUNT(*) FROM (SELECT FROM `codedata`.`R_DATABASE` GROUP BY ()) AS `t`] at org.apache.calcite.runtime.ResultSetEnumerable.enumerator(ResultSetEn umerable.java:154) at org.apache.calcite.linq4j.AbstractEnumerable.iterator(AbstractEnumera ble.java:33) at org.apache.calcite.avatica.MetaImpl.createCursor(MetaImpl.java:81) at org.apache.calcite.avatica.AvaticaResultSet.execute(AvaticaResultSet. java:196) at org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.jav a:67) at org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.jav a:44) at org.apache.calcite.avatica.AvaticaConnection$1.execute(AvaticaConnect ion.java:607) at org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMeta Impl.java:600) at org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInterna l(AvaticaConnection.java:615) at org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaSt atement.java:148) ... 7 more Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have a n error in your SQL syntax; check the manual that corresponds to your MySQL serv er version for the right syntax to use near 'FROM `codedata`.`R_DATABASE` GROUP BY ()) AS `t`' at line 3 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Sou rce) at java.lang.reflect.Constructor.newInstance(Unknown Source) at com.mysql.jdbc.Util.handleNewInstance(Util.java:411) at com.mysql.jdbc.Util.getInstance(Util.java:386) at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1052) at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4096) at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4028) at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2490) at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2651) at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2677) at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2627) at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:841) at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:681) at org.apache.commons.dbcp.DelegatingStatement.execute(DelegatingStateme nt.java:264) at org.apache.commons.dbcp.DelegatingStatement.execute(DelegatingStateme nt.java:264) at org.apache.calcite.runtime.ResultSetEnumerable.enumerator(ResultSetEn umerable.java:144) ... 16 more 0: jdbc:calcite:model=core/target/test-classe> -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CALCITE-5380) CompositeSingleOperandTypeChecker fails with index (1) must be less than size (1)
Sergey Nuyanzin created CALCITE-5380:
Summary: CompositeSingleOperandTypeChecker fails with index (1)
must be less than size (1)
Key: CALCITE-5380
URL: https://issues.apache.org/jira/browse/CALCITE-5380
Project: Calcite
Issue Type: Improvement
Components: core
Affects Versions: 1.33.0
Reporter: Sergey Nuyanzin
I try to check main branch against existing Flink tests.
One of the things I faced is that existing Flink function
{code:java}
public class SqlListAggFunction extends SqlAggFunction {
public SqlListAggFunction() {
super(
"LISTAGG",
null,
SqlKind.LISTAGG,
ReturnTypes.ARG0_NULLABLE,
null,
OperandTypes.or(
OperandTypes.CHARACTER,
OperandTypes.sequence(
"'LISTAGG(, )'",
OperandTypes.CHARACTER,
OperandTypes.and(OperandTypes.CHARACTER,
OperandTypes.LITERAL))),
SqlFunctionCategory.SYSTEM,
false,
false);
}
@Override
public List getParameterTypes(RelDataTypeFactory typeFactory) {
return ImmutableList.of(
typeFactory.createTypeWithNullability(
typeFactory.createSqlType(SqlTypeName.VARCHAR), true));
}
@Override
public RelDataType getReturnType(RelDataTypeFactory typeFactory) {
return typeFactory.createSqlType(SqlTypeName.VARCHAR);
}
}
{code}
started to fail with
{noformat}
org.apache.flink.table.api.ValidationException: SQL validation failed. index
(1) must be less than size (1)
at
org.apache.flink.table.planner.calcite.FlinkPlannerImpl.org$apache$flink$table$planner$calcite$FlinkPlannerImpl$$validate(FlinkPlannerImpl.scala:186)
at
org.apache.flink.table.planner.calcite.FlinkPlannerImpl.validate(FlinkPlannerImpl.scala:113)
at
org.apache.flink.table.planner.operations.SqlToOperationConverter.convert(SqlToOperationConverter.java:263)
at
org.apache.flink.table.planner.delegation.ParserImpl.parse(ParserImpl.java:106)
at
org.apache.flink.table.api.internal.TableEnvironmentImpl.sqlQuery(TableEnvironmentImpl.java:734)
at
org.apache.flink.table.api.stream.ExplainTest.testMiniBatchIntervalInfer(ExplainTest.scala:150)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at or
grouping() function occurs value large than 1
Hi
After AggregateExpandDistinctAggregatesRule, I got a plan like this:
The $10 in the project node is $g=[GROUPING($0, $1, $2, $3, $4, $5, $6,
$7, $8)]) and we can see it is compared with value 1/2/3, but I check the
def of grouping(), both pg and oracle, the value of grouping is 0 or 1.
pg:https://www.postgresqltutorial.com/postgresql-grouping-sets/
oracle:
https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
```
EnumerableProject(xx=[$0], xx=[$1], xx=[$2], xx=[$3], xx=[$4], xx=[$5],
xx=[$6], $f7=[$7], $f8=[$8], gid=[$9], $g_1=[=($10, 1)], $g_2=[=($10, 2)],
$g_3=[=($10, 3)])
EnumerableHashAggregate(group=[{0, 1, 2, 3, 4, 5, 6, 7, 8}],
groups=[[{0, 1, 2, 3, 4, 5, 6, 7}, {0, 1, 2, 3, 4, 5, 6, 8}, {0, 1, 2, 3,
4, 5, 6}]], dim_type=[grouping_id()], $g=[GROUPING($0, $1, $2, $3, $4, $5,
$6, $7, $8)])
```
Regards!
Aron Tao
[VOTE] Release apache-calcite-1.21.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.21.0, release candidate 1. Thanks to everyone who has contributed to this release. Since RC 0, we have fixed the following issues: * [CALCITE-3322] Remove duplicate test case in RelMetadataTest (沈洪) * [CALCITE-3321] BigQuery does not have correct casing rules (Lindsey Meyer) * Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule * Removed spurious *.xml.xxx files from the release artifacts You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=adc1532de853060d24fd0129257a3fae306fb55c Its hash is adc1532de853060d24fd0129257a3fae306fb55c. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.sha256 f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f4e A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1067 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/zabetak.asc Please vote on releasing this package as Apache Calcite 1.21.0. The vote is open for the next 96 hours (due to the weekend) and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.21.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding)
[DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
The release process for apache-calcite-1.21.0 is now complete. You can now commit again to the master. Once again, I would like to thank again all the members of the community that helped in getting 1.21.0 out the door. A special mention for the reviewers who helped getting in some great features dedicating a significant amount of their time. During the vote various issues were raised. Spurious .xml files were present in release candidate 0; I have the impression that they came up due to the dry run that I did just before the release (without performing a git clean). As it is not indicated in the documentation I am thinking to add a small notice. The build fails for certain locales due to CALCITE-2816; we agree that the build problem must be solved for 1.22.0. There are intermittent failures in the Pig module; CALCITE-3336 was logged and we should continue further discussions there. There were some small issues with the release notes (passive voice, and backticks); I took care of them in https://github.com/apache/calcite/commit/034bd7942c35d5b6c948dc6863a9a086fb82386c . There was a comment that adc1532de does not have tag calcite-1.21.0 but if I am not looking at the wrong place I think its there. The checksum hash that was communicated in the vote email was wrong; given that the correct one was send along with the artifacts and people used this for the checks I assume there is no problem. There are some minor problems with README and README.md files; I will update them in the following days. The instructions in "Publishing a release" related with the release announcement, and the Javadoc generation are slightly confusing. In order to generate the Javadoc we must be in the tag calcite-1.21.0 and not in the branch-1.21 and on the other hand the release announcement should be committed in the branch-1.21. It may be worth adding a few more details there. If I missed something else worth mentioning feel free to include it. Best, Stamatis
[VOTE] Release apache-calcite-1.22.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.22.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.sha512 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f *apache-calcite-1.22.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1078 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/danny0405.asc Please vote on releasing this package as Apache Calcite 1.22.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.22.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Best, Danny Chan
[VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.23.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 Tag: https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 (revision 39622) The hashes of the artifacts are as follows: 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 *apache-calcite-1.23.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ Release artifacts are signed with the following key: https://dist.apache.org/repos/dist/release/calcite/KEYS N.B. To create the jars and test Apache Calcite: "./gradlew build". If you do not have a Java environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker-compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite 1.23.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.23.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Thanks, Haisheng Yuan
Re: grouping() function occurs value large than 1
GROUPING is defined in the SQL standard. If it has N arguments, it
returns an integer bitmask with N bits.
PostgreSQL has the same behavior: see example in
https://www.postgresql.org/docs/9.5/functions-aggregate.html.
Julian
On Tue, Dec 8, 2020 at 12:30 AM JiaTao Tao wrote:
>
> Hi
> After AggregateExpandDistinctAggregatesRule, I got a plan like this:
> The $10 in the project node is $g=[GROUPING($0, $1, $2, $3, $4, $5, $6,
> $7, $8)]) and we can see it is compared with value 1/2/3, but I check the
> def of grouping(), both pg and oracle, the value of grouping is 0 or 1.
>
> pg:https://www.postgresqltutorial.com/postgresql-grouping-sets/
> oracle:
> https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
>
> ```
> EnumerableProject(xx=[$0], xx=[$1], xx=[$2], xx=[$3], xx=[$4], xx=[$5],
> xx=[$6], $f7=[$7], $f8=[$8], gid=[$9], $g_1=[=($10, 1)], $g_2=[=($10, 2)],
> $g_3=[=($10, 3)])
> EnumerableHashAggregate(group=[{0, 1, 2, 3, 4, 5, 6, 7, 8}],
> groups=[[{0, 1, 2, 3, 4, 5, 6, 7}, {0, 1, 2, 3, 4, 5, 6, 8}, {0, 1, 2, 3,
> 4, 5, 6}]], dim_type=[grouping_id()], $g=[GROUPING($0, $1, $2, $3, $4, $5,
> $6, $7, $8)])
> ```
>
>
> Regards!
>
> Aron Tao
Re: grouping() function occurs value large than 1
Hi Julian
I see, thanks, maybe use grouping id is better? Cuz seems not every engine
has this grouping behavior, in the doc of oracle[ref1]:
The expr in the GROUPING function must match one of the expressions in the
GROUP BY clause. The function returns a value of 1 if the value of expr in
the row is a null representing the set of all values. Otherwise, it returns
zero.
ref1:
https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
Regards!
Aron Tao
Julian Hyde 于2020年12月9日周三 上午9:28写道：
> GROUPING is defined in the SQL standard. If it has N arguments, it
> returns an integer bitmask with N bits.
>
> PostgreSQL has the same behavior: see example in
> https://www.postgresql.org/docs/9.5/functions-aggregate.html.
>
> Julian
>
> On Tue, Dec 8, 2020 at 12:30 AM JiaTao Tao wrote:
> >
> > Hi
> > After AggregateExpandDistinctAggregatesRule, I got a plan like this:
> > The $10 in the project node is $g=[GROUPING($0, $1, $2, $3, $4, $5, $6,
> > $7, $8)]) and we can see it is compared with value 1/2/3, but I check the
> > def of grouping(), both pg and oracle, the value of grouping is 0 or 1.
> >
> > pg:https://www.postgresqltutorial.com/postgresql-grouping-sets/
> > oracle:
> >
> https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
> >
> > ```
> > EnumerableProject(xx=[$0], xx=[$1], xx=[$2], xx=[$3], xx=[$4], xx=[$5],
> > xx=[$6], $f7=[$7], $f8=[$8], gid=[$9], $g_1=[=($10, 1)], $g_2=[=($10,
> 2)],
> > $g_3=[=($10, 3)])
> > EnumerableHashAggregate(group=[{0, 1, 2, 3, 4, 5, 6, 7, 8}],
> > groups=[[{0, 1, 2, 3, 4, 5, 6, 7}, {0, 1, 2, 3, 4, 5, 6, 8}, {0, 1, 2, 3,
> > 4, 5, 6}]], dim_type=[grouping_id()], $g=[GROUPING($0, $1, $2, $3, $4,
> $5,
> > $6, $7, $8)])
> > ```
> >
> >
> > Regards!
> >
> > Aron Tao
>
Re: grouping() function occurs value large than 1
GROUPING_ID is problematic for both optimizers and humans, because if the
columns are permuted the value changes, and that causes problems. I think
GROUPING is working well for our purposes.
Of course you can use whichever you like in your queries.
Julian
> On Dec 8, 2020, at 19:00, JiaTao Tao wrote:
>
> Hi Julian
> I see, thanks, maybe use grouping id is better? Cuz seems not every engine
> has this grouping behavior, in the doc of oracle[ref1]:
>
> The expr in the GROUPING function must match one of the expressions in the
> GROUP BY clause. The function returns a value of 1 if the value of expr in
> the row is a null representing the set of all values. Otherwise, it returns
> zero.
>
>
>
> ref1:
> https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
>
> Regards!
>
> Aron Tao
>
>
> Julian Hyde 于2020年12月9日周三 上午9:28写道：
>
>> GROUPING is defined in the SQL standard. If it has N arguments, it
>> returns an integer bitmask with N bits.
>>
>> PostgreSQL has the same behavior: see example in
>> https://www.postgresql.org/docs/9.5/functions-aggregate.html.
>>
>> Julian
>>
>>> On Tue, Dec 8, 2020 at 12:30 AM JiaTao Tao wrote:
>>>
>>> Hi
>>> After AggregateExpandDistinctAggregatesRule, I got a plan like this:
>>> The $10 in the project node is $g=[GROUPING($0, $1, $2, $3, $4, $5, $6,
>>> $7, $8)]) and we can see it is compared with value 1/2/3, but I check the
>>> def of grouping(), both pg and oracle, the value of grouping is 0 or 1.
>>>
>>> pg:https://www.postgresqltutorial.com/postgresql-grouping-sets/
>>> oracle:
>>>
>> https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
>>>
>>> ```
>>> EnumerableProject(xx=[$0], xx=[$1], xx=[$2], xx=[$3], xx=[$4], xx=[$5],
>>> xx=[$6], $f7=[$7], $f8=[$8], gid=[$9], $g_1=[=($10, 1)], $g_2=[=($10,
>> 2)],
>>> $g_3=[=($10, 3)])
>>> EnumerableHashAggregate(group=[{0, 1, 2, 3, 4, 5, 6, 7, 8}],
>>> groups=[[{0, 1, 2, 3, 4, 5, 6, 7}, {0, 1, 2, 3, 4, 5, 6, 8}, {0, 1, 2, 3,
>>> 4, 5, 6}]], dim_type=[grouping_id()], $g=[GROUPING($0, $1, $2, $3, $4,
>> $5,
>>> $6, $7, $8)])
>>> ```
>>>
>>>
>>> Regards!
>>>
>>> Aron Tao
>>
Re: grouping() function occurs value large than 1
Got it, thanks Julian!
Regards!
Aron Tao
Julian Hyde 于2020年12月9日周三 下午2:26写道：
> GROUPING_ID is problematic for both optimizers and humans, because if the
> columns are permuted the value changes, and that causes problems. I think
> GROUPING is working well for our purposes.
>
> Of course you can use whichever you like in your queries.
>
> Julian
>
> > On Dec 8, 2020, at 19:00, JiaTao Tao wrote:
> >
> > Hi Julian
> > I see, thanks, maybe use grouping id is better? Cuz seems not every
> engine
> > has this grouping behavior, in the doc of oracle[ref1]:
> >
> > The expr in the GROUPING function must match one of the expressions in
> the
> > GROUP BY clause. The function returns a value of 1 if the value of expr
> in
> > the row is a null representing the set of all values. Otherwise, it
> returns
> > zero.
> >
> >
> >
> > ref1:
> >
> https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
> >
> > Regards!
> >
> > Aron Tao
> >
> >
> > Julian Hyde 于2020年12月9日周三 上午9:28写道：
> >
> >> GROUPING is defined in the SQL standard. If it has N arguments, it
> >> returns an integer bitmask with N bits.
> >>
> >> PostgreSQL has the same behavior: see example in
> >> https://www.postgresql.org/docs/9.5/functions-aggregate.html.
> >>
> >> Julian
> >>
> >>> On Tue, Dec 8, 2020 at 12:30 AM JiaTao Tao
> wrote:
> >>>
> >>> Hi
> >>> After AggregateExpandDistinctAggregatesRule, I got a plan like this:
> >>> The $10 in the project node is $g=[GROUPING($0, $1, $2, $3, $4, $5,
> $6,
> >>> $7, $8)]) and we can see it is compared with value 1/2/3, but I check
> the
> >>> def of grouping(), both pg and oracle, the value of grouping is 0 or 1.
> >>>
> >>> pg:https://www.postgresqltutorial.com/postgresql-grouping-sets/
> >>> oracle:
> >>>
> >>
> https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions064.htm#SQLRF00647
> >>>
> >>> ```
> >>> EnumerableProject(xx=[$0], xx=[$1], xx=[$2], xx=[$3], xx=[$4], xx=[$5],
> >>> xx=[$6], $f7=[$7], $f8=[$8], gid=[$9], $g_1=[=($10, 1)], $g_2=[=($10,
> >> 2)],
> >>> $g_3=[=($10, 3)])
> >>> EnumerableHashAggregate(group=[{0, 1, 2, 3, 4, 5, 6, 7, 8}],
> >>> groups=[[{0, 1, 2, 3, 4, 5, 6, 7}, {0, 1, 2, 3, 4, 5, 6, 8}, {0, 1, 2,
> 3,
> >>> 4, 5, 6}]], dim_type=[grouping_id()], $g=[GROUPING($0, $1, $2, $3, $4,
> >> $5,
> >>> $6, $7, $8)])
> >>> ```
> >>>
> >>>
> >>> Regards!
> >>>
> >>> Aron Tao
> >>
>
[VOTE] Release apache-calcite-1.18.0 (release candidate 1)
OK, let's try again. I have created a build for Apache Calcite 1.18.0, release candidate 1. Thanks to everyone who has contributed to this release. Since RC 0, we have fixed the following issues: * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions containing nulls * [CALCITE-2670] Combine similar JSON aggregate functions in operator table * [CALCITE-2468] Validator throws IndexOutOfBoundsException when trying to infer operand type from STRUCT return type (Rong Rong) You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1 Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1 The hashes of the artifacts are as follows: src.tar.gz.sha256 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7 A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1050 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jhyde.asc Please vote on releasing this package as Apache Calcite 1.18.0. The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th) and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.18.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Julian
[VOTE] Release apache-calcite-1.19.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.19.0, release candidate 1. Thanks to everyone who has contributed to this release. Since RC 0, we have fixed the following issues: * [CALCITE-2925] Exclude maven-wrapper.jar from source distribution You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.19/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=ad11340e5c5abddaa6f2729c9faa2043c4643a8d Its hash is ad11340e5c5abddaa6f2729c9faa2043c4643a8d. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.19.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.sha256 8dbe7e81d955019d78e7de270089fb42726c827f719bfd5a5d11f734fac7face A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1055/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/krisden.asc Please vote on releasing this package as Apache Calcite 1.19.0. The vote is open for the next 96 hours (due to the weekend) and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.19.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Kevin Risden
[VOTE] Release apache-calcite-1.6.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.6.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.6/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/c4d346b0a413a1a62e028dd3be40071523203a58 Its hash is c4d346b0a413a1a62e028dd3be40071523203a58. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.6.0-rc1 The hashes of the artifacts are as follows: src.tar.gz.md5 752fb7a862466d37a7a7e11c8c4d3550 src.tar.gz.sha1 3cf4a5ac4617f8589e675962bbe470b7e8e5ce49 src.zip.md5 7af8bdab7980f65bdbb86769c0419a29 src.zip.sha1 ba36a5e097d5415f21108810753e481948b6c14a A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1012 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jhyde.asc Please vote on releasing this package as Apache Calcite 1.6.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.6.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Julian
[VOTE] apache-calcite-avatica-1.7.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite Avatica 1.7.0, release candidate 1. Thanks to everyone who has contributed to this release. This is the first release candidate for a release that enables us to split the Avatica project away from the "traditional" Apache Calcite build. The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/48b7de5a1e9e0dc9a81f57b084227b0b075cbb65 Its hash is 48b7de5a1e9e0dc9a81f57b084227b0b075cbb65. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.7.0-rc0/ The hashes of the artifacts are as follows: src.tar.gz.md5 4aa7bd2ac8cd5efb0fccd37c97e42af0 src.tar.gz.sha1 6346b4afa1a4404538151bb6c081ea35d8af35ca src.zip.md5 3897b59f52da105b7e9835ea6ad0796d src.zip.sha1 699e2c877eb9d8304012f93a1a95e6ec3b5aacdc A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1014 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/elserj.asc CALCITE-1139, CALCITE-1140, CALCITE-1141, CALCITE-1142, CALCITE-1143, CALCITE-1144 were added since 1.7.0-rc0. Please vote on releasing this package as Apache Calcite Avatica 1.7.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite Avatica 1.7.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) - Josh
Calcite-Avatica-Master-JDK-1.7 - Build # 1 - Failure
The Apache Jenkins build system has built Calcite-Avatica-Master-JDK-1.7 (build #1) Status: Failure Check console output at https://builds.apache.org/job/Calcite-Avatica-Master-JDK-1.7/1/ to view the results.
[VOTE] Release apache-calcite-1.8.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.8.0, release candidate 1. Bugs 1277, 1279, 1276, 1281, 1274 have been fixed since RC0. Thanks to everyone who has contributed to this release. It includes two new adapters (Druid and Elasticsearch), several important SQL enhancements, and a couple of dozen other features and bug-fixes. You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.8/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/aeb6bf146544bf9a4c030df644eda8fe5a370f52 Its hash is aeb6bf146544bf9a4c030df644eda8fe5a370f52. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.8.0-rc1 The hashes of the artifacts are as follows: src.tar.gz.md5 b25d0c148bfe200c16471396d92ec46d src.tar.gz.sha1 4246c20cbaa06534b628adcb1d5e3af14de4a864 src.zip.md5 3e07c794ccb145338376cd9bf84059d5 src.zip.sha1 8535ff058323cd44a9fa8d508dc412eb8075a52f A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1022 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jhyde.asc Please vote on releasing this package as Apache Calcite 1.8.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.8.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Julian
[VOTE] Release apache-calcite-1.9.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.9.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.9.0/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/08c56b1 Its hash is 08c56b158ffcfcf205a919cc9fff77a692e649f6. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.9.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.md5 b3b6a15671b1e8ffd7f989398e050de4 src.tar.gz.sha1 8f17b2d7896bac6123ae4a1491e04f4960094a59 src.zip.md5 7c66353701d1924a9e2656bd76e570cb src.zip.sha1 8a5c7d27b0240cbcacd565eadf451de9dff6d2fa A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1024 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jcamacho.asc Please vote on releasing this package as Apache Calcite 1.9.0. The vote is open for the next 96 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.9.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Jesús
[VOTE] Release apache-calcite-1.10.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.10.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.10.0/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/448dd85 Its hash is 448dd85832819b4d22682ffe7908d8058da7c778. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.10.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.md5 de926cf5e44930950ef91e953d640eed src.tar.gz.sha1 5edb81494aa7e7c31dd4ee6aefdf549c95027a0a src.zip.md5 5e19f9abbd293986d56c0490af241ed6 src.zip.sha1 1dad2cfa73f459067c23993c3f8ae1b2c45f8b5b A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1027 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jcamacho.asc Please vote on releasing this package as Apache Calcite 1.10.0. The vote is open for the next 96 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.10.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Jesús
[VOTE] Release apache-calcite-1.12.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.12.0, release candidate 1. The only changes since release candidate 0 are: * fixes to issues CALCITE-1715 and CALCITE-1716, * corresponding modifications to the release history, * some unrelated changes on in the avatica sub-project. Thanks to everyone who has contributed to this release. Thanks to everyone who has contributed to this release. It is almost 3 months and over 100 commits since 1.11, and we now have JDK9 support, new file and Pig adapters, syntax extensions for streaming queries, and planning improvements for Druid and sub-queries. You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.12/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/ea7ace18cdc26027be690b00f1fcc191aaa87e45 Its hash is ea7ace18cdc26027be690b00f1fcc191aaa87e45. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.12.0-rc1 The hashes of the artifacts are as follows: apache-calcite-1.12.0-src.tar.gz:MD5 = FF 47 B6 B0 D8 00 40 77 7E 15 2C BF A7 85 50 0F apache-calcite-1.12.0-src.tar.gz: SHA1 = 17AC D6BB DCC7 FB4F 5810 FB08 D1D2 9BC1 A84F D068 apache-calcite-1.12.0-src.tar.gz: RMD160 = E675 DA12 EC13 A3E9 BC2C 2F76 9AAC CBE8 4123 010B apache-calcite-1.12.0-src.tar.gz: SHA224 = 016F67DA 7F54D91C 88D1BF8A 28F94351 EAC822CC E93443B7 CFBE9950 apache-calcite-1.12.0-src.tar.gz: SHA256 = 166683A5 8C09F573 B4D7CAB9 59145E91 49735DD3 691569BE AF1ED726 B56CF3C0 apache-calcite-1.12.0-src.tar.gz: SHA384 = E6B23FC3 551273D6 74CCCE8B 7E45B919 A94238EE 6A319A96 1AD9030B 0D1D6886 B9725D84 53591D4C 5D5F16FD 1858FCAD apache-calcite-1.12.0-src.tar.gz: SHA512 = 64442146 62171446 938DB1D8 7EEA1AEF 3CEA7D66 9751F40C 4CB84C4B 17876A7B 524FABC7 5CF48D23 7FE859A9 6E2C7AAA B60BBD3B 8B1C92EC CBA57112 B17D020A apache-calcite-1.12.0-src.zip:MD5 = 24 0B 43 FC 93 52 C6 64 66 5F F7 AF 25 B2 69 2D apache-calcite-1.12.0-src.zip: SHA1 = 698B 4B8F 8448 B5F7 1B9C 824B 8DAC F72D 1640 2D19 apache-calcite-1.12.0-src.zip: RMD160 = CB6E 900A 7C18 1F04 35E7 773F E26B C02B 9CA6 DC5A apache-calcite-1.12.0-src.zip: SHA224 = 9F82E7E8 BF087360 580FFE74 297C3369 C1CEB466 CC457CC4 CC103A75 apache-calcite-1.12.0-src.zip: SHA256 = 1DA0075B 0579E571 05716531 BF134538 46115C0A 8272957F DCC4C226 066E92F4 apache-calcite-1.12.0-src.zip: SHA384 = 6A4E9484 95F719BD E970B4C4 7E100D57 BC631AE9 0F7CA812 A25D1121 125F9701 345DE3D7 2CDCDD07 8A13B3AA 266D049E apache-calcite-1.12.0-src.zip: SHA512 = 866333D6 8806B219 F8E11565 5A0F918D B85F11DE 78B0DD52 342CC9C8 D67749BC 5D6FCCBA CCFF8B41 BE724CFF 0A133A46 7F95043A 483C7686 4CD9DC84 B440A8D6 A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1032 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jhyde.asc Please vote on releasing this package as Apache Calcite 1.12.0. The vote is open for the next 72 hours (that is, until 8pm Pacific on Thursday) and passes if a majority of at least three +1 PMC votes is cast. [ ] +1 Release this package as Apache Calcite 1.12.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Julian
[VOTE] Release apache-calcite-1.15.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.15.0, release candidate 1. Changes since the previous release candidate: fixed the show-stopper CALCITE-2074, fixed the two minor issues raised in the last vote (CALCITE-2070 and a doc fix to watch out for scott.tmp), and also fixed CALCITE-2069, CALCITE-1808, CALCITE-2078. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.15/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/a2aa00e5b276a30e301ecbf0953e2cbf3a51b605 Its hash is a2aa00e5b276a30e301ecbf0953e2cbf3a51b605. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.15.0-rc1 The hashes of the artifacts are as follows: src.tar.gz.md5 cfa3abcac0cac05f614d9598cb1c67de src.tar.gz.sha256 916ece8bbfd6ec6d51e41aa0922eb55e913e048e9c0b37a905ca1890d29698f0 src.zip.md5 51ca29f949889c830f2aa6fe263cde9b src.zip.sha256 8371c925206e7d00c37238aab70e5ecb29ddb3b296a4184746ee64c3b7dcaabf A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1040 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jhyde.asc Please vote on releasing this package as Apache Calcite 1.15.0. The vote is open for the next 72 hours (i.e. ending at 23:59 Pacific on Fri 8th Dec) and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.15.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Julian
[VOTE] Release Apache Calcite 1.30.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.30.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.30.0-rc1/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f14cf4c32b9079984a988bbad40230aa6a59b127 Its hash is f14cf4c32b9079984a988bbad40230aa6a59b127 Tag: https://github.com/apache/calcite/tree/calcite-1.30.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc1 (revision 52897) The hashes of the artifacts are as follows: 25527b5dfd3c28d4ac3c9d9a40b94dbcbce7feb17cc198ebe7c36a30c2df69a27ee5e4defab4edff1e1bc65c076bd0725bd8c378913d1d23f3d80f732e3e097f *apache-calcite-1.30.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1150/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/COMMITTER_ID.asc https://www.apache.org/dist/calcite/KEYS To create the jars and test Apache Calcite: "gradle build" (requires an appropriate Gradle/JDK installation) Please vote on releasing this package as Apache Calcite 1.30.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.30.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Best, Liya Fan
[VOTE] Release Apache Calcite 1.31.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.31.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.31.0-rc1/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4912aabe66fa06a30ea688c4bc2bf06dc05ee677 Its hash is 4912aabe66fa06a30ea688c4bc2bf06dc05ee677 Tag: https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc1 (revision 56015) The hashes of the artifacts are as follows: 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c *apache-calcite-1.31.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1168/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/sereda.asc https://www.apache.org/dist/calcite/KEYS To create the jars and test Apache Calcite: "gradle build" (requires an appropriate Gradle/JDK installation) Please vote on releasing this package as Apache Calcite 1.31.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.31.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (non-binding)
[CANCELLED] Release Apache Calcite 1.31.0 (release candidate 1)
Hello, Due to checksum mismatches, voting for RC1 is cancelled. I will send another vote for RC2 shortly. Regards, Andrei.
[VOTE] Release Apache Calcite 1.37.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite 1.37.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=53fd905eb4c730b4bedd49fa6569d5b0de47f021 Its hash is 53fd905eb4c730b4bedd49fa6569d5b0de47f021 Tag: https://github.com/apache/calcite/tree/calcite-1.37.0-rc0 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.37.0-rc0 (revision 68720) The hashes of the artifacts are as follows: b044fb94fd60710142edfe348ff20bbdc7e43f3d70a68b6520b65dc8fb2fe53f0ecf6b5d03b199b3212e9064a7dd04fb3995a9cd09cb8864a7bfdb5617feefbb *apache-calcite-1.37.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1225/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/snuyanzin.asc https://www.apache.org/dist/calcite/KEYS To create the jars and test Apache Calcite: "gradle build" (requires an appropriate Gradle/JDK installation) Please vote on releasing this package as Apache Calcite 1.37.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.37.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) -- Best regards, Sergey
[jira] [Created] (CALCITE-2505) RexSimplify: isFalse(isNotDistinctFrom(vBool(0), vBool(1))) causes AssertionError: wrong operand count 1 for IS DISTINCT FROM
Vladimir Sitnikov created CALCITE-2505:
--
Summary: RexSimplify: isFalse(isNotDistinctFrom(vBool(0),
vBool(1))) causes AssertionError: wrong operand count 1 for IS DISTINCT FROM
Key: CALCITE-2505
URL: https://issues.apache.org/jira/browse/CALCITE-2505
Project: Calcite
Issue Type: Bug
Components: core
Affects Versions: 1.17.0
Reporter: Vladimir Sitnikov
Assignee: Julian Hyde
{noformat}java.lang.AssertionError: wrong operand count 1 for IS DISTINCT FROM
at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
at
org.apache.calcite.sql.SqlBinaryOperator.validRexOperands(SqlBinaryOperator.java:219)
at org.apache.calcite.rex.RexCall.(RexCall.java:63)
at org.apache.calcite.rex.RexBuilder.makeCall(RexBuilder.java:242)
at org.apache.calcite.rex.RexSimplify.simplifyNot(RexSimplify.java:373)
at org.apache.calcite.rex.RexSimplify.simplify_(RexSimplify.java:185)
at org.apache.calcite.rex.RexSimplify.simplifyIs2(RexSimplify.java:468)
at org.apache.calcite.rex.RexSimplify.simplifyIs(RexSimplify.java:414)
at org.apache.calcite.rex.RexSimplify.simplify_(RexSimplify.java:202)
at
org.apache.calcite.rex.RexSimplify.lambda$simplify$0(RexSimplify.java:175)
at org.apache.calcite.rex.RexSimplify.verify(RexSimplify.java:1121)
at
org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:175){noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
Hello, Local Calcite build with tests enabled on Linux: OK Calcite-based system (Zoomdata) test suite: OK +1 (non-binding) On Fri, Sep 6, 2019 at 7:42 PM Stamatis Zampetakis wrote: > Hi all, > > I have created a build for Apache Calcite 1.21.0, release candidate 1. > > Thanks to everyone who has contributed to this release. > > Since RC 0, we have fixed the following issues: > * [CALCITE-3322] Remove duplicate test case in RelMetadataTest (沈洪) > * [CALCITE-3321] BigQuery does not have correct casing rules (Lindsey > Meyer) > * Remove the useless JdbcConvention out in descriptionPrefix for > JdbcToEnumerableConverterRule > * Removed spurious *.xml.xxx files from the release artifacts > > You can read the release notes here: > https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=adc1532de853060d24fd0129257a3fae306fb55c > > Its hash is adc1532de853060d24fd0129257a3fae306fb55c. > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc1/ > > The hashes of the artifacts are as follows: > src.tar.gz.sha256 > f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f4e > > A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachecalcite-1067 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/zabetak.asc > > Please vote on releasing this package as Apache Calcite 1.21.0. > > The vote is open for the next 96 hours (due to the weekend) and passes if a > majority of > at least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.21.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > -- Best regards, Anton.
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
Hi Stamatis,
thank you for your effort!
+1 (non-binding)
I found some minor issues I described below and the failing Test from the last
RC but as its addressed for the next release, so I think it's reasonable
addressed.
I checked:
- Checksum and Signature correct
- Checked LICENSE and NOTICE
- Checked diff between rc0 / rc1 as expected (no pom.xml.??? files)
- Run build as described in "howto.md" (mvnw install) on "java version
"1.8.0_181" (Hotspot) on OS X fails (see below)
- Run build as "mvnw install" exceeds if OsAdapterTest is removed
- Checked no unexpected binaries
- Checked License headers with rat
Minor Issues:
- README is not up to date as it says that README.md contains "examples of
running calcite" which it doesn’t
- Information on how to build the project is only available on the homepage not
in one of the readmes or doc files (a link to "howto.md" in the README or
README.md would be good, I think)
Test fails:
- As expected the OsAdapterTest has some issues (see CALCITE-2816)
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while parsing
value [0...
[ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL
"select disti...
[INFO]
[ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24
- In one run the following fails, but succeeds at second run. I log a jira if
it ever happens again (checked in IDE and worked fine there)
[ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 4.375 s
<<< FAILURE! - in org.apache.calcite.test.PigRelBuilderStyleTest
[ERROR]
testImplWithCountWithoutGroupBy(org.apache.calcite.test.PigRelBuilderStyleTest)
Time elapsed: 2.712 s <<< ERROR!
org.apache.pig.impl.logicalLayer.FrontendException: Unable to open iterator for
alias t
at
org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270)
at
org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130)
Caused by: org.apache.pig.PigException: Unable to store alias t
at
org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270)
at
org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130)
Caused by: org.apache.pig.impl.logicalLayer.FrontendException: Error processing
rule LoadTypeCastInserter
at
org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270)
at
org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130)
Caused by: java.lang.NullPointerException
at
org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270)
at
org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130)
Julian
Am 09.09.19, 02:02 schrieb "Anton Haidai" :
Hello,
Local Calcite build with tests enabled on Linux: OK
Calcite-based system (Zoomdata) test suite: OK
+1 (non-binding)
On Fri, Sep 6, 2019 at 7:42 PM Stamatis Zampetakis
wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.21.0, release candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> Since RC 0, we have fixed the following issues:
> * [CALCITE-3322] Remove duplicate test case in RelMetadataTest (沈洪)
> * [CALCITE-3321] BigQuery does not have correct casing rules (Lindsey
> Meyer)
> * Remove the useless JdbcConvention out in descriptionPrefix for
> JdbcToEnumerableConverterRule
> * Removed spurious *.xml.xxx files from the release artifacts
>
> You can read the release notes here:
>
https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md
>
> The commit to be voted upon:
>
>
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=adc1532de853060d24fd0129257a3fae306fb55c
>
> Its hash is adc1532de853060d24fd0129257a3fae306fb55c.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc1/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f4e
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1067
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/zabetak.asc
>
> Please vote on releasing this package a
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
Julian, It’s not one that I’ve seen before. Please log a JIRA and describe it as intermittent. Someone will find & comment on it if it happens to them. > On Sep 9, 2019, at 7:55 AM, Julian Feinauer > wrote: > > Hi Stamatis, > > thank you for your effort! > > +1 (non-binding) > > I found some minor issues I described below and the failing Test from the > last RC but as its addressed for the next release, so I think it's reasonable > addressed. > > I checked: > - Checksum and Signature correct > - Checked LICENSE and NOTICE > - Checked diff between rc0 / rc1 as expected (no pom.xml.??? files) > - Run build as described in "howto.md" (mvnw install) on "java version > "1.8.0_181" (Hotspot) on OS X fails (see below) > - Run build as "mvnw install" exceeds if OsAdapterTest is removed > - Checked no unexpected binaries > - Checked License headers with rat > > Minor Issues: > - README is not up to date as it says that README.md contains "examples of > running calcite" which it doesn’t > - Information on how to build the project is only available on the homepage > not in one of the readmes or doc files (a link to "howto.md" in the README or > README.md would be good, I think) > > Test fails: > - As expected the OsAdapterTest has some issues (see CALCITE-2816) > [INFO] Results: > [INFO] > [ERROR] Errors: > [ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while > parsing value [0... > [ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL > "select disti... > [INFO] > [ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24 > > - In one run the following fails, but succeeds at second run. I log a jira if > it ever happens again (checked in IDE and worked fine there) > [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 4.375 > s <<< FAILURE! - in org.apache.calcite.test.PigRelBuilderStyleTest > [ERROR] > testImplWithCountWithoutGroupBy(org.apache.calcite.test.PigRelBuilderStyleTest) > Time elapsed: 2.712 s <<< ERROR! > org.apache.pig.impl.logicalLayer.FrontendException: Unable to open iterator > for alias t > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: org.apache.pig.PigException: Unable to store alias t > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: org.apache.pig.impl.logicalLayer.FrontendException: Error > processing rule LoadTypeCastInserter > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: java.lang.NullPointerException > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > > Julian > > Am 09.09.19, 02:02 schrieb "Anton Haidai" : > >Hello, > >Local Calcite build with tests enabled on Linux: OK >Calcite-based system (Zoomdata) test suite: OK > >+1 (non-binding) > >On Fri, Sep 6, 2019 at 7:42 PM Stamatis Zampetakis >wrote: > >> Hi all, >> >> I have created a build for Apache Calcite 1.21.0, release candidate 1. >> >> Thanks to everyone who has contributed to this release. >> >> Since RC 0, we have fixed the following issues: >> * [CALCITE-3322] Remove duplicate test case in RelMetadataTest (沈洪) >> * [CALCITE-3321] BigQuery does not have correct casing rules (Lindsey >> Meyer) >> * Remove the useless JdbcConvention out in descriptionPrefix for >> JdbcToEnumerableConverterRule >> * Removed spurious *.xml.xxx files from the release artifacts >> >> You can read the release notes here: >> https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md >> >> The commit to be voted upon: >> >> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=adc1532de853060d24fd0129257a3fae306fb55c >> >> Its hash is adc1532de853060d24fd0129257a3fae306fb55c. >> >> The artifacts to be voted on
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
+1 (binding) Checked LICENSE, NOTICE, checksums, compiled and ran tests on JDK 11/Ubuntu, ran RAT. Checked that tar contents match git commit. One minor thing: I was surprised that commit adc1532de does not have tag calcite-1.21.0. Not a blocker for the release, but worth fixing. The release notes are written in passive voice (e.g. “The parser has been enhanced …”). Consider converting to active voice; it makes it more direct. (Scientific writing requires passive voice, but the rest of the world is agreed that active voice is superior.) If you need a subject for the sentence, use “Calcite”, e.g. “Calcite now parses…”. Also, please put back-ticks around SQL keywords like MATCH_RECOGNIZE or java types like SemiJoin. Not a blocker for the release; can be fixed afterwards. I want to say thank you to non-committers like Anton for voting on the release. You are an important part of our quality control, so your time & diligence is appreciated. Julian > On Sep 9, 2019, at 7:55 AM, Julian Feinauer > wrote: > > Hi Stamatis, > > thank you for your effort! > > +1 (non-binding) > > I found some minor issues I described below and the failing Test from the > last RC but as its addressed for the next release, so I think it's reasonable > addressed. > > I checked: > - Checksum and Signature correct > - Checked LICENSE and NOTICE > - Checked diff between rc0 / rc1 as expected (no pom.xml.??? files) > - Run build as described in "howto.md" (mvnw install) on "java version > "1.8.0_181" (Hotspot) on OS X fails (see below) > - Run build as "mvnw install" exceeds if OsAdapterTest is removed > - Checked no unexpected binaries > - Checked License headers with rat > > Minor Issues: > - README is not up to date as it says that README.md contains "examples of > running calcite" which it doesn’t > - Information on how to build the project is only available on the homepage > not in one of the readmes or doc files (a link to "howto.md" in the README or > README.md would be good, I think) > > Test fails: > - As expected the OsAdapterTest has some issues (see CALCITE-2816) > [INFO] Results: > [INFO] > [ERROR] Errors: > [ERROR] OsAdapterTest.testPs:156->lambda$testPs$3:158 » Runtime while > parsing value [0... > [ERROR] OsAdapterTest.testPsDistinct:177 » SQL Error while executing SQL > "select disti... > [INFO] > [ERROR] Tests run: 60, Failures: 0, Errors: 2, Skipped: 24 > > - In one run the following fails, but succeeds at second run. I log a jira if > it ever happens again (checked in IDE and worked fine there) > [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 4.375 > s <<< FAILURE! - in org.apache.calcite.test.PigRelBuilderStyleTest > [ERROR] > testImplWithCountWithoutGroupBy(org.apache.calcite.test.PigRelBuilderStyleTest) > Time elapsed: 2.712 s <<< ERROR! > org.apache.pig.impl.logicalLayer.FrontendException: Unable to open iterator > for alias t > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: org.apache.pig.PigException: Unable to store alias t > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: org.apache.pig.impl.logicalLayer.FrontendException: Error > processing rule LoadTypeCastInserter > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > Caused by: java.lang.NullPointerException > at > org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:270) > at > org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithCountWithoutGroupBy(PigRelBuilderStyleTest.java:130) > > Julian > > Am 09.09.19, 02:02 schrieb "Anton Haidai" : > >Hello, > >Local Calcite build with tests enabled on Linux: OK >Calcite-based system (Zoomdata) test suite: OK > >+1 (non-binding) > >On Fri, Sep 6, 2019 at 7:42 PM Stamatis Zampetakis >wrote: > >> Hi all, >> >> I have created a build for Apache Calcite 1.21.0, release candidate 1. >> >> Thanks to everyone who has contributed to this release. >> >> Since RC 0
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
+1 Binding Environment: maven:latest docker container (Maven 3.6.1, JDK11, Debian 9/stretch) Verified SHA256 - OK Verified GPG signature - OK ./mvnw -DskipTests clean install and ./mvnw test - OK Checked LICENSE - OK Checked NOTICE - OK Checked README - OK Checked Release Notes - OK Francis On 7/09/2019 2:42 am, Stamatis Zampetakis wrote: Hi all, I have created a build for Apache Calcite 1.21.0, release candidate 1. Thanks to everyone who has contributed to this release. Since RC 0, we have fixed the following issues: * [CALCITE-3322] Remove duplicate test case in RelMetadataTest (沈洪) * [CALCITE-3321] BigQuery does not have correct casing rules (Lindsey Meyer) * Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule * Removed spurious *.xml.xxx files from the release artifacts You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.21.0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=adc1532de853060d24fd0129257a3fae306fb55c Its hash is adc1532de853060d24fd0129257a3fae306fb55c. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.21.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.sha256 f9b37fc08f20e8fa7ec8035172852468359fb855e007943fc087ba310f4e A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1067 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/zabetak.asc Please vote on releasing this package as Apache Calcite 1.21.0. The vote is open for the next 96 hours (due to the weekend) and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.21.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding)
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
+1 Binding Environment: maven:latest docker container (Maven 3.5.3, JDK8, MacOSX) Checked LICENSE - OK Checked NOTICE - OK Checked README - OK Verified SHA256 - OK Verified GPG signature - OK ./mvn -DskipTests clean install and ./mvn test - OK Checked Release Notes - OK Best, Danny Chan 在 2019年9月7日 +0800 AM12:42，dev@calcite.apache.org，写道： > > +1 Binding > > Environment: maven:latest docker container (Maven 3.6.1, JDK11, Debian > 9/stretch) > > Verified SHA256 - OK > Verified GPG signature - OK > ./mvnw -DskipTests clean install and ./mvnw test - OK > Checked LICENSE - OK > Checked NOTICE - OK > Checked README - OK > Checked Release Notes - OK
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
+1 (non-binding) Environment: Mac OS X 10.12.6, JDK 1.8.0_201, Maven 3.5.0 - Checked signatures and checksums - OK - Checked release note - OK - Ran unit tests (mvn clean install) - OK Best, Chunwei On Tue, Sep 10, 2019 at 10:14 AM Danny Chan wrote: > +1 Binding > > Environment: maven:latest docker container (Maven 3.5.3, JDK8, MacOSX) > > Checked LICENSE - OK > Checked NOTICE - OK > Checked README - OK > Verified SHA256 - OK > Verified GPG signature - OK > ./mvn -DskipTests clean install and ./mvn test - OK > Checked Release Notes - OK > > Best, > Danny Chan > 在 2019年9月7日 +0800 AM12:42，dev@calcite.apache.org，写道： > > > > +1 Binding > > > > Environment: maven:latest docker container (Maven 3.6.1, JDK11, Debian > > 9/stretch) > > > > Verified SHA256 - OK > > Verified GPG signature - OK > > ./mvnw -DskipTests clean install and ./mvnw test - OK > > Checked LICENSE - OK > > Checked NOTICE - OK > > Checked README - OK > > Checked Release Notes - OK >
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
+1 There are OsAdapterTest.testPs and testPsDistinct failures, however they are well known. Vladimir
Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
+1 (non-binding) Minor correction: sha256 of source distribution (apache-calcite-1.21.0-src.tar.gz) is ccd10264f89a84bc750837cc2d0e66b7d74a81dd825d0a88f501153d4745eee3 Environment: Mac OS X Java version: 11.0.4, vendor: AdoptOpenJDK Maven 3.6.1 mvn clean install - OK sh256 check - OK GPG check - OK Release notes - OK On Tue, Sep 10, 2019 at 11:25 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > +1 > > There are OsAdapterTest.testPs and testPsDistinct failures, however they > are well known. > > Vladimir >
[RESULT] [VOTE] Release apache-calcite-1.21.0 (release candidate 1)
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 4 binding +1s: Julian H., Francis, Vladimir, Stamatis 6 non-binding +1s: Anton, Julian F., Haisheng, Danny, Chunwei, Andrei No 0s or -1s. Therefore I am delighted to announce that the proposal to release Apache Calcite 1.21.0 has passed. Thanks everyone. We’ll now roll the release out to the mirrors. There was some feedback during voting. I shall open a separate thread to discuss. Stamatis
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
Stamatis, thanks for your work on this. Stamatis>The checksum hash that was communicated in the vote email was wrong Stamatis>given Stamatis>that the correct one was send along with the artifacts and people used this Stamatis>for the checks I assume there is no problem. I'm inclined that we should vote with -1 (or wait for RM to send the updated checksum) when checksum in the mail does not match to the checksum of the archive. Well, it is OK, if release manager sends updates, however it should not be the case that actual checksum differs from the one that was suggested in the vote mail. Different checksums might mean there's MITM attempt, and it sounds wrong that we "kind of ignore it". Even though I agree the impact in this case was quite low (e.g. I've personally verified PGP signature and ensured it was SHA512 based), we would probably want to refrain from repeating that practice. I would like to follow https://reproducible-builds.org/ to simplify release validation. Vladimir
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
+1 to everything Vladmir said. Thanks for the release Stamatis! I do agree that the checksum issue shouldn't be ignored although an update from the RM to the vote thread should be sufficient. Really, we rely on the email of the RM not being compromised anyway if we assume we can have a MITM between us and the hosted files. -- Michael Mior mm...@apache.org Le jeu. 12 sept. 2019 à 06:59, Vladimir Sitnikov a écrit : > > Stamatis, thanks for your work on this. > > Stamatis>The checksum hash that was communicated in the vote email was wrong > Stamatis>given > Stamatis>that the correct one was send along with the artifacts and people > used this > Stamatis>for the checks I assume there is no problem. > > I'm inclined that we should vote with -1 (or wait for RM to send the > updated checksum) when checksum in the mail does not match to the checksum > of the archive. > > Well, it is OK, if release manager sends updates, however it should not be > the case that actual checksum > differs from the one that was suggested in the vote mail. > > Different checksums might mean there's MITM attempt, and it sounds wrong > that we "kind of ignore it". > Even though I agree the impact in this case was quite low (e.g. I've > personally verified PGP signature and ensured it was SHA512 based), we > would probably want to refrain from repeating that practice. > > I would like to follow https://reproducible-builds.org/ to simplify release > validation. > > Vladimir
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
Yes, I screwed up. Everyone who voted screwed up. I should have voted ‘-1’ because the hash of the artifacts I got from svn did not match the hash in the email. Let’s all do better next time. Still, no harm done. We know now that we were voting on the correct artifacts. We have a valid release. Julian > On Sep 12, 2019, at 5:54 AM, Michael Mior wrote: > > +1 to everything Vladmir said. Thanks for the release Stamatis! I do > agree that the checksum issue shouldn't be ignored although an update > from the RM to the vote thread should be sufficient. Really, we rely > on the email of the RM not being compromised anyway if we assume we > can have a MITM between us and the hosted files. > -- > Michael Mior > mm...@apache.org > > Le jeu. 12 sept. 2019 à 06:59, Vladimir Sitnikov > a écrit : >> >> Stamatis, thanks for your work on this. >> >> Stamatis>The checksum hash that was communicated in the vote email was wrong >> Stamatis>given >> Stamatis>that the correct one was send along with the artifacts and people >> used this >> Stamatis>for the checks I assume there is no problem. >> >> I'm inclined that we should vote with -1 (or wait for RM to send the >> updated checksum) when checksum in the mail does not match to the checksum >> of the archive. >> >> Well, it is OK, if release manager sends updates, however it should not be >> the case that actual checksum >> differs from the one that was suggested in the vote mail. >> >> Different checksums might mean there's MITM attempt, and it sounds wrong >> that we "kind of ignore it". >> Even though I agree the impact in this case was quite low (e.g. I've >> personally verified PGP signature and ensured it was SHA512 based), we >> would probably want to refrain from repeating that practice. >> >> I would like to follow https://reproducible-builds.org/ to simplify release >> validation. >> >> Vladimir
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
I noticed the problem thanks to Andrei but I underestimated its importance. Sorry about that! On Thu, Sep 12, 2019 at 4:35 PM Julian Hyde wrote: > Yes, I screwed up. Everyone who voted screwed up. I should have voted ‘-1’ > because the hash of the artifacts I got from svn did not match the hash in > the email. Let’s all do better next time. > > Still, no harm done. We know now that we were voting on the correct > artifacts. We have a valid release. > > Julian > > > > On Sep 12, 2019, at 5:54 AM, Michael Mior wrote: > > > > +1 to everything Vladmir said. Thanks for the release Stamatis! I do > > agree that the checksum issue shouldn't be ignored although an update > > from the RM to the vote thread should be sufficient. Really, we rely > > on the email of the RM not being compromised anyway if we assume we > > can have a MITM between us and the hosted files. > > -- > > Michael Mior > > mm...@apache.org > > > > Le jeu. 12 sept. 2019 à 06:59, Vladimir Sitnikov > > a écrit : > >> > >> Stamatis, thanks for your work on this. > >> > >> Stamatis>The checksum hash that was communicated in the vote email was > wrong > >> Stamatis>given > >> Stamatis>that the correct one was send along with the artifacts and > people > >> used this > >> Stamatis>for the checks I assume there is no problem. > >> > >> I'm inclined that we should vote with -1 (or wait for RM to send the > >> updated checksum) when checksum in the mail does not match to the > checksum > >> of the archive. > >> > >> Well, it is OK, if release manager sends updates, however it should not > be > >> the case that actual checksum > >> differs from the one that was suggested in the vote mail. > >> > >> Different checksums might mean there's MITM attempt, and it sounds wrong > >> that we "kind of ignore it". > >> Even though I agree the impact in this case was quite low (e.g. I've > >> personally verified PGP signature and ensured it was SHA512 based), we > >> would probably want to refrain from repeating that practice. > >> > >> I would like to follow https://reproducible-builds.org/ to simplify > release > >> validation. > >> > >> Vladimir > >
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
Nice summary of the release problems, Stamatis ! Maybe we should put the precautions to the website so that other RM can follow in the next releases ~ Best, Danny Chan 在 2019年9月12日 +0800 AM7:54，Stamatis Zampetakis ，写道： > The release process for apache-calcite-1.21.0 is now complete. > > You can now commit again to the master. > > Once again, I would like to thank again all the members of the community > that helped in getting 1.21.0 out the door. A special mention for the > reviewers who helped getting in some great features dedicating a > significant amount of their time. > > During the vote various issues were raised. > > Spurious .xml files were present in release candidate 0; I have the > impression that they came up due to the dry run that I did just before the > release (without performing a git clean). As it is not indicated in the > documentation I am thinking to add a small notice. > > The build fails for certain locales due to CALCITE-2816; we agree that the > build problem must be solved for 1.22.0. > > There are intermittent failures in the Pig module; CALCITE-3336 was logged > and we should continue further discussions there. > > There were some small issues with the release notes (passive voice, and > backticks); I took care of them in > https://github.com/apache/calcite/commit/034bd7942c35d5b6c948dc6863a9a086fb82386c > . > > There was a comment that adc1532de does not have tag calcite-1.21.0 but if > I am not looking at the wrong place I think its there. > > The checksum hash that was communicated in the vote email was wrong; given > that the correct one was send along with the artifacts and people used this > for the checks I assume there is no problem. > > There are some minor problems with README and README.md files; I will > update them in the following days. > > The instructions in "Publishing a release" related with the release > announcement, and the Javadoc generation are slightly confusing. In order > to generate the Javadoc we must be in the tag calcite-1.21.0 and not in the > branch-1.21 and on the other hand the release announcement should be > committed in the branch-1.21. It may be worth adding a few more details > there. > > If I missed something else worth mentioning feel free to include it. > > Best, > Stamatis
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
Stamatis, Can you mark 1.21 as released in JIRA [1]. I don’t recall whether we ever made officially added this task to an RM’s responsibilities. I don’t mind doing it if you don’t have karma. Thank you, again, for being RM. Julian [1] https://issues.apache.org/jira/projects/CALCITE?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page&status=released-unreleased <https://issues.apache.org/jira/projects/CALCITE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page&status=released-unreleased> > On Sep 15, 2019, at 7:38 PM, Danny Chan wrote: > > Nice summary of the release problems, Stamatis ! Maybe we should put the > precautions to the website so that other RM can follow in the next releases ~ > > Best, > Danny Chan > 在 2019年9月12日 +0800 AM7:54，Stamatis Zampetakis ，写道： >> The release process for apache-calcite-1.21.0 is now complete. >> >> You can now commit again to the master. >> >> Once again, I would like to thank again all the members of the community >> that helped in getting 1.21.0 out the door. A special mention for the >> reviewers who helped getting in some great features dedicating a >> significant amount of their time. >> >> During the vote various issues were raised. >> >> Spurious .xml files were present in release candidate 0; I have the >> impression that they came up due to the dry run that I did just before the >> release (without performing a git clean). As it is not indicated in the >> documentation I am thinking to add a small notice. >> >> The build fails for certain locales due to CALCITE-2816; we agree that the >> build problem must be solved for 1.22.0. >> >> There are intermittent failures in the Pig module; CALCITE-3336 was logged >> and we should continue further discussions there. >> >> There were some small issues with the release notes (passive voice, and >> backticks); I took care of them in >> https://github.com/apache/calcite/commit/034bd7942c35d5b6c948dc6863a9a086fb82386c >> . >> >> There was a comment that adc1532de does not have tag calcite-1.21.0 but if >> I am not looking at the wrong place I think its there. >> >> The checksum hash that was communicated in the vote email was wrong; given >> that the correct one was send along with the artifacts and people used this >> for the checks I assume there is no problem. >> >> There are some minor problems with README and README.md files; I will >> update them in the following days. >> >> The instructions in "Publishing a release" related with the release >> announcement, and the Javadoc generation are slightly confusing. In order >> to generate the Javadoc we must be in the tag calcite-1.21.0 and not in the >> branch-1.21 and on the other hand the release announcement should be >> committed in the branch-1.21. It may be worth adding a few more details >> there. >> >> If I missed something else worth mentioning feel free to include it. >> >> Best, >> Stamatis
Re: [DISCUSS] Release apache-calcite-1.21.0 (release candidate 1)
Done, thanks for noticing. I will add it also to the RM instructions along with some other minor improvements. Best, Stamatis On Tue, Sep 17, 2019 at 11:26 PM Julian Hyde wrote: > Stamatis, > > Can you mark 1.21 as released in JIRA [1]. > > I don’t recall whether we ever made officially added this task to an RM’s > responsibilities. I don’t mind doing it if you don’t have karma. > > Thank you, again, for being RM. > > Julian > > [1] > https://issues.apache.org/jira/projects/CALCITE?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page&status=released-unreleased > < > https://issues.apache.org/jira/projects/CALCITE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page&status=released-unreleased > > > > > On Sep 15, 2019, at 7:38 PM, Danny Chan wrote: > > > > Nice summary of the release problems, Stamatis ! Maybe we should put the > precautions to the website so that other RM can follow in the next releases > ~ > > > > Best, > > Danny Chan > > 在 2019年9月12日 +0800 AM7:54，Stamatis Zampetakis ，写道： > >> The release process for apache-calcite-1.21.0 is now complete. > >> > >> You can now commit again to the master. > >> > >> Once again, I would like to thank again all the members of the community > >> that helped in getting 1.21.0 out the door. A special mention for the > >> reviewers who helped getting in some great features dedicating a > >> significant amount of their time. > >> > >> During the vote various issues were raised. > >> > >> Spurious .xml files were present in release candidate 0; I have the > >> impression that they came up due to the dry run that I did just before > the > >> release (without performing a git clean). As it is not indicated in the > >> documentation I am thinking to add a small notice. > >> > >> The build fails for certain locales due to CALCITE-2816; we agree that > the > >> build problem must be solved for 1.22.0. > >> > >> There are intermittent failures in the Pig module; CALCITE-3336 was > logged > >> and we should continue further discussions there. > >> > >> There were some small issues with the release notes (passive voice, and > >> backticks); I took care of them in > >> > https://github.com/apache/calcite/commit/034bd7942c35d5b6c948dc6863a9a086fb82386c > >> . > >> > >> There was a comment that adc1532de does not have tag calcite-1.21.0 but > if > >> I am not looking at the wrong place I think its there. > >> > >> The checksum hash that was communicated in the vote email was wrong; > given > >> that the correct one was send along with the artifacts and people used > this > >> for the checks I assume there is no problem. > >> > >> There are some minor problems with README and README.md files; I will > >> update them in the following days. > >> > >> The instructions in "Publishing a release" related with the release > >> announcement, and the Javadoc generation are slightly confusing. In > order > >> to generate the Javadoc we must be in the tag calcite-1.21.0 and not in > the > >> branch-1.21 and on the other hand the release announcement should be > >> committed in the branch-1.21. It may be worth adding a few more details > >> there. > >> > >> If I missed something else worth mentioning feel free to include it. > >> > >> Best, > >> Stamatis > >
[VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite Avatica 1.16.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 Tag: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 (revision 37181) The hashes of the artifacts are as follows: 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 *apache-calcite-avatica-1.16.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc https://www.apache.org/dist/calcite/KEYS N.B. To create the jars and test Apache Calcite Avatica: "./gradlew build -PskipSigning". If you do not have a Java environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker-compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite Avatica 1.16.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.16.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
Hi fellow, can you help to verify this release if you have time ? We plan to release at this Friday and there is no much time left. Best, Danny Chan 在 2020年2月25日 +0800 PM12:56，Danny Chan ，写道： > Hi all, > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > Thanks to everyone who has contributed to this release. > You can read the release notes here: > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > > The commit to be voted upon: > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 > > Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ > > The hashes of the artifacts are as follows: > src.tar.gz.sha512 > > 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f > *apache-calcite-1.22.0-src.tar.gz > > A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachecalcite-1078 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/danny0405.asc > > Please vote on releasing this package as Apache Calcite 1.22.0. > > The vote is open for the next 72 hours and passes if a majority of > at least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.22.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Here is my vote: > > +1 (binding) > > Best, > Danny Chan
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
> I have created a build for Apache Calcite 1.22.0, release candidate 0. Should be candidate 1? : ) +1 (non-binding) macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4 * Went over release note OK * Run Calcite tests with the RC OK Best, Chunwei On Tue, Feb 25, 2020 at 5:04 PM Danny Chan wrote: > Hi fellow, can you help to verify this release if you have time ? We plan > to release at this Friday and there is no much time left. > > Best, > Danny Chan > 在 2020年2月25日 +0800 PM12:56，Danny Chan ，写道： > > Hi all, > > > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > > > > The commit to be voted upon: > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 > > > > Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. > > > > The artifacts to be voted on are located here: > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ > > > > The hashes of the artifacts are as follows: > > src.tar.gz.sha512 > > > > > 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f > *apache-calcite-1.22.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1078 > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/danny0405.asc > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > The vote is open for the next 72 hours and passes if a majority of > > at least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > Here is my vote: > > > > +1 (binding) > > > > Best, > > Danny Chan >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
Oops thanks for the correction. Chunwei Lei 于2020年2月25日 周二下午6:35写道： > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > Should be candidate 1? : ) > > > +1 (non-binding) > > macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4 > * Went over release note OK > * Run Calcite tests with the RC OK > > > Best, > Chunwei > > > On Tue, Feb 25, 2020 at 5:04 PM Danny Chan wrote: > > > Hi fellow, can you help to verify this release if you have time ? We plan > > to release at this Friday and there is no much time left. > > > > Best, > > Danny Chan > > 在 2020年2月25日 +0800 PM12:56，Danny Chan ，写道： > > > Hi all, > > > > > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > > > > > Thanks to everyone who has contributed to this release. > > > You can read the release notes here: > > > > > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > > > > > > The commit to be voted upon: > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 > > > > > > Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. > > > > > > The artifacts to be voted on are located here: > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ > > > > > > The hashes of the artifacts are as follows: > > > src.tar.gz.sha512 > > > > > > > > > 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f > > *apache-calcite-1.22.0-src.tar.gz > > > > > > A staged Maven repository is available for review at: > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1078 > > > > > > Release artifacts are signed with the following key: > > > https://people.apache.org/keys/committer/danny0405.asc > > > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > > > The vote is open for the next 72 hours and passes if a majority of > > > at least three +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > Best, > > > Danny Chan > > >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
Thanks for pushing through this huge release, Danny! Checked GPG signature - OK Checked hash - OK Ran tests per HOWTO (./gradlew check) - OK Release notes (quick skim) - OK Maven artifacts (spot checked a few files on nexus) - OK Environment (gradle:latest docker container): Gradle 6.1.1 (via gradlew) Ubuntu 18.04.4 LTS openjdk version "1.8.0_232" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode) Great work, Danny! My vote is +1 (binding) Francis On 25/02/2020 3:56 pm, Danny Chan wrote: Hi all, I have created a build for Apache Calcite 1.22.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ The hashes of the artifacts are as follows: src.tar.gz.sha512 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f *apache-calcite-1.22.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1078 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/danny0405.asc Please vote on releasing this package as Apache Calcite 1.22.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.22.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Best, Danny Chan
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
I am building the RC I found this warning in logs, it looks like a serious LICENSE problem Enrico > Task :release:license Dependencies of license category B are not allowed for SOURCE artifacts === OFL-1.1 * font-awesome:font-awesome-font:4.2.0 Il giorno mar 25 feb 2020 alle ore 11:53 Danny Chan ha scritto: > > Oops thanks for the correction. > > Chunwei Lei 于2020年2月25日 周二下午6:35写道： > > > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > Should be candidate 1? : ) > > > > > > +1 (non-binding) > > > > macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4 > > * Went over release note OK > > * Run Calcite tests with the RC OK > > > > > > Best, > > Chunwei > > > > > > On Tue, Feb 25, 2020 at 5:04 PM Danny Chan wrote: > > > > > Hi fellow, can you help to verify this release if you have time ? We plan > > > to release at this Friday and there is no much time left. > > > > > > Best, > > > Danny Chan > > > 在 2020年2月25日 +0800 PM12:56，Danny Chan ，写道： > > > > Hi all, > > > > > > > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > > > > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > > > > > > > > The commit to be voted upon: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 > > > > > > > > Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. > > > > > > > > The artifacts to be voted on are located here: > > > > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ > > > > > > > > The hashes of the artifacts are as follows: > > > > src.tar.gz.sha512 > > > > > > > > > > > > > 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f > > > *apache-calcite-1.22.0-src.tar.gz > > > > > > > > A staged Maven repository is available for review at: > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1078 > > > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/danny0405.asc > > > > > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > > > > > The vote is open for the next 72 hours and passes if a majority of > > > > at least three +1 PMC votes are cast. > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > [ ] -1 Do not release this package because... > > > > > > > > Here is my vote: > > > > > > > > +1 (binding) > > > > > > > > Best, > > > > Danny Chan > > > > >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
I also found this, but look at the info it seems expected, this is done by the Gradle plugin, maybe @Vladimir Sitnikov can answer the question better ~ Best, Danny Chan 在 2020年2月25日 +0800 PM7:51，Enrico Olivelli ，写道： > I am building the RC > I found this warning in logs, it looks like a serious LICENSE problem > > Enrico > > > Task :release:license > Dependencies of license category B are not allowed for SOURCE artifacts > === > > OFL-1.1 > * font-awesome:font-awesome-font:4.2.0 > > Il giorno mar 25 feb 2020 alle ore 11:53 Danny Chan > ha scritto: > > > > Oops thanks for the correction. > > > > Chunwei Lei 于2020年2月25日 周二下午6:35写道： > > > > > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > > Should be candidate 1? : ) > > > > > > > > > +1 (non-binding) > > > > > > macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4 > > > * Went over release note OK > > > * Run Calcite tests with the RC OK > > > > > > > > > Best, > > > Chunwei > > > > > > > > > On Tue, Feb 25, 2020 at 5:04 PM Danny Chan wrote: > > > > > > > Hi fellow, can you help to verify this release if you have time ? We > > > > plan > > > > to release at this Friday and there is no much time left. > > > > > > > > Best, > > > > Danny Chan > > > > 在 2020年2月25日 +0800 PM12:56，Danny Chan ，写道： > > > > > Hi all, > > > > > > > > > > I have created a build for Apache Calcite 1.22.0, release candidate 0. > > > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > You can read the release notes here: > > > > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > > > > > > > > > > The commit to be voted upon: > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=f24e1d4bd4e235d45d919b7bc59ed7eeadc80464 > > > > > > > > > > Its hash is f24e1d4bd4e235d45d919b7bc59ed7eeadc80464. > > > > > > > > > > The artifacts to be voted on are located here: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc1/ > > > > > > > > > > The hashes of the artifacts are as follows: > > > > > src.tar.gz.sha512 > > > > > > > > > > > > > > > > > 3da2eaef4aedf4f7c0997594c3bc89d6ca30925be80d0376be72053b7fe371a2d77a37d410d88391059c09ce7c9f50a0cadd89daba550a0d8380811d7ef3cc9f > > > > *apache-calcite-1.22.0-src.tar.gz > > > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1078 > > > > > > > > > > Release artifacts are signed with the following key: > > > > > https://people.apache.org/keys/committer/danny0405.asc > > > > > > > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > > > > > > > The vote is open for the next 72 hours and passes if a majority of > > > > > at least three +1 PMC votes are cast. > > > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > Here is my vote: > > > > > > > > > > +1 (binding) > > > > > > > > > > Best, > > > > > Danny Chan > > > > > > >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
I have already surfaced the case in 1.20.0 release: https://lists.apache.org/thread.html/33694a2e754ff63e49e5fd05d52be1f72773c15f4a66adf766223b86%40%3Cdev.calcite.apache.org%3E Technically speaking, Calcite release artifacts violate ASF licensing policy. Then it is up to the release manager to decide if the release is valid or not. Vladimir
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
-1 (non binding) Good news: I am able to build and run tests locally Bad news: - I have found a regression in Bind Variable handling in "UPDATE" statements due to https://issues.apache.org/jira/browse/CALCITE-3672 see the separate email Thread "Problems on RC with HerdDB: was: [VOTE] Release apache-calcite-1.22.0 (release candidate 0)" - IMHO the "license" issue is a blocker for a release, but it is up to the PMC to accept or not it Thank you Danny for driving this release, it is very hard Enrico Il giorno mar 25 feb 2020 alle ore 14:36 Vladimir Sitnikov ha scritto: > > I have already surfaced the case in 1.20.0 release: > https://lists.apache.org/thread.html/33694a2e754ff63e49e5fd05d52be1f72773c15f4a66adf766223b86%40%3Cdev.calcite.apache.org%3E > > Technically speaking, Calcite release artifacts violate ASF licensing > policy. > Then it is up to the release manager to decide if the release is valid or > not. > > Vladimir
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
Hello, Local Calcite build with tests enabled on Linux: *OK* Calcite-based system (Zoomdata) test suite: *OK** ***FYI: *EnumerableTableScanRule* changes related to CALCITE-3769 caused a massive regression on our test suite because the rule produced *BindableTableScan* instead of *EnumerableTableScan* for our custom table classes (which is a bit strange for a rule with this name). So we were forced to revert this rule to 1.21 state. +1 (non-binding) On Tue, Feb 25, 2020 at 4:47 PM Enrico Olivelli wrote: > -1 (non binding) > > Good news: I am able to build and run tests locally > > Bad news: > - I have found a regression in Bind Variable handling in "UPDATE" > statements due to > https://issues.apache.org/jira/browse/CALCITE-3672 > see the separate email Thread "Problems on RC with HerdDB: was: [VOTE] > Release apache-calcite-1.22.0 (release candidate 0)" > - IMHO the "license" issue is a blocker for a release, but it is up to > the PMC to accept or not it > > Thank you Danny for driving this release, it is very hard > > Enrico > > > Il giorno mar 25 feb 2020 alle ore 14:36 Vladimir Sitnikov > ha scritto: > > > > I have already surfaced the case in 1.20.0 release: > > > https://lists.apache.org/thread.html/33694a2e754ff63e49e5fd05d52be1f72773c15f4a66adf766223b86%40%3Cdev.calcite.apache.org%3E > > > > Technically speaking, Calcite release artifacts violate ASF licensing > > policy. > > Then it is up to the release manager to decide if the release is valid or > > not. > > > > Vladimir > -- Best regards, Anton.
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
-1 The consensus on the thread of the 1.20 RC 0 vote was that we would fix it by next release, i.e. 1.21. We can't make another release containing category B artifacts. I have logged https://issues.apache.org/jira/browse/CALCITE-3822 to track this. Julian On Tue, Feb 25, 2020 at 7:29 AM Anton Haidai wrote: > > Hello, > > Local Calcite build with tests enabled on Linux: *OK* > Calcite-based system (Zoomdata) test suite: *OK** > > ***FYI: *EnumerableTableScanRule* changes related to CALCITE-3769 caused a > massive regression on our test suite because the rule produced > *BindableTableScan* instead of *EnumerableTableScan* for our custom table > classes (which is a bit strange for a rule with this name). So we were > forced to revert this rule to 1.21 state. > > +1 (non-binding) > > On Tue, Feb 25, 2020 at 4:47 PM Enrico Olivelli wrote: > > > -1 (non binding) > > > > Good news: I am able to build and run tests locally > > > > Bad news: > > - I have found a regression in Bind Variable handling in "UPDATE" > > statements due to > > https://issues.apache.org/jira/browse/CALCITE-3672 > > see the separate email Thread "Problems on RC with HerdDB: was: [VOTE] > > Release apache-calcite-1.22.0 (release candidate 0)" > > - IMHO the "license" issue is a blocker for a release, but it is up to > > the PMC to accept or not it > > > > Thank you Danny for driving this release, it is very hard > > > > Enrico > > > > > > Il giorno mar 25 feb 2020 alle ore 14:36 Vladimir Sitnikov > > ha scritto: > > > > > > I have already surfaced the case in 1.20.0 release: > > > > > https://lists.apache.org/thread.html/33694a2e754ff63e49e5fd05d52be1f72773c15f4a66adf766223b86%40%3Cdev.calcite.apache.org%3E > > > > > > Technically speaking, Calcite release artifacts violate ASF licensing > > > policy. > > > Then it is up to the release manager to decide if the release is valid or > > > not. > > > > > > Vladimir > > > > > -- > Best regards, > Anton.
[CANCEL] [VOTE] Release apache-calcite-1.22.0 (release candidate 1)
The vote for Apache Calcite 1.2120 release candidate 1 was cancelled due to the invalid LICENCE, see https://issues.apache.org/jira/browse/CALCITE-3822 for details. Thanks to all who voted. A new release will be tagged as 1.22.0-rc2 and will be available for voting soon. Best, Danny Chan
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hello everyone, - Local Calcite build with tests (Windows10 + JDK8): OK - Calcite-based application test suite: OK However, the patch to correct the issue on RC0 [1] is a breaking change (for some scenarios) that introduced a regression in my downstream project that required a (temporary) quick-fix [2] (thanks Haisheng Yuan for your help and reactivity). There is still some discussion going on in the Jira ticket [1], and even though I am not 100% convinced on the direction that was taken, I cannot provide a better alternative at this time (and in any case with the quick-fix this is not a blocking issue on my side). +0 (non binding) Best regards, Ruben [1] https://issues.apache.org/jira/browse/CALCITE-3997 [2] https://github.com/apache/calcite/commit/05376d6bff11ccef690addb4f9c40ab16dd20bec Le sam. 16 mai 2020 à 06:02, Haisheng Yuan a écrit : > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Tag: > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > (revision 39622) > > The hashes of the artifacts are as follows: > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > *apache-calcite-1.23.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/release/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite: "./gradlew build". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite 1.23.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.23.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Thanks, > Haisheng Yuan >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hello, Local Calcite build with tests enabled on Linux: *OK* Calcite-based system (Zoomdata) test suite: *OK* Vote: +1 (non-binding) On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan wrote: > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Tag: > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > (revision 39622) > > The hashes of the artifacts are as follows: > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > *apache-calcite-1.23.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/release/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite: "./gradlew build". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite 1.23.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.23.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Thanks, > Haisheng Yuan > -- Best regards, Anton.
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
+1 (non binding) Local tests passes on Linux (Fedora 31) + JDK14 Checksums and signatures looks good. All tests are passing on HerdDB. Thank you very much Haisheng ! Enrico Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai < anton.hai...@gmail.com> ha scritto: > Hello, > > Local Calcite build with tests enabled on Linux: *OK* > Calcite-based system (Zoomdata) test suite: *OK* > > Vote: > +1 (non-binding) > > On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan wrote: > > > Hi all, > > > > I have created a build for Apache Calcite 1.23.0, release > > candidate 1. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > The commit to be voted upon: > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > Tag: > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > (revision 39622) > > > > The hashes of the artifacts are as follows: > > > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > *apache-calcite-1.23.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > > N.B. > > To create the jars and test Apache Calcite: "./gradlew build". > > > > If you do not have a Java environment available, you can run the tests > > using docker. To do so, install docker and docker-compose, then run > > "docker-compose run test" from the root of the directory. > > > > Please vote on releasing this package as Apache Calcite 1.23.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > +1 (binding) > > > > Thanks, > > Haisheng Yuan > > > > > -- > Best regards, > Anton. >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hello, Thanks for driving this Haisheng! I was checking the differences between RC0 and RC1: https://github.com/apache/calcite/compare/calcite-1.23.0-rc0...calcite-1.23.0-rc1 and the change for CALCITE-3997 [1] seems a bit risky for this stage of the release, thus I would like to invite more people to have a look. If there are things to be discussed let's do it under the respective JIRA. I will continue testing and vote later on. Best, Stamatis [1] https://github.com/apache/calcite/commit/7be30db36d449e0a7fcc76b7d4647e141f4bc72d On Sun, May 17, 2020 at 1:45 PM Enrico Olivelli wrote: > +1 (non binding) > Local tests passes on Linux (Fedora 31) + JDK14 > Checksums and signatures looks good. > > All tests are passing on HerdDB. > Thank you very much Haisheng ! > > Enrico > > Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai < > anton.hai...@gmail.com> ha scritto: > > > Hello, > > > > Local Calcite build with tests enabled on Linux: *OK* > > Calcite-based system (Zoomdata) test suite: *OK* > > > > Vote: > > +1 (non-binding) > > > > On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan wrote: > > > > > Hi all, > > > > > > I have created a build for Apache Calcite 1.23.0, release > > > candidate 1. > > > > > > Thanks to everyone who has contributed to this release. > > > > > > You can read the release notes here: > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > > > The commit to be voted upon: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > Tag: > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > > > The artifacts to be voted on are located here: > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > > (revision 39622) > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > > *apache-calcite-1.23.0-src.tar.gz > > > > > > A staged Maven repository is available for review at: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > > > > Release artifacts are signed with the following key: > > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > > > > N.B. > > > To create the jars and test Apache Calcite: "./gradlew build". > > > > > > If you do not have a Java environment available, you can run the tests > > > using docker. To do so, install docker and docker-compose, then run > > > "docker-compose run test" from the root of the directory. > > > > > > Please vote on releasing this package as Apache Calcite 1.23.0. > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > > least three +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > [ ] -1 Do not release this package because... > > > > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > Thanks, > > > Haisheng Yuan > > > > > > > > > -- > > Best regards, > > Anton. > > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks for making this release available for voting, Haisheng! Verified GPG signature - OK Verified SHA512 - OK Ran tests per HOWTO (./gradlew check) - OK Quickly skimmed release notes - OK Spotted checked a few JARs in the Maven repository - OK Environment (OpenJDK:latest docker container): Gradle 6.3 (via gradlew) Debian GNU/Linux 8 openjdk version "1.8.0_111" OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14) OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) My vote is: +1 (binding) Francis On 16/05/2020 2:02 pm, Haisheng Yuan wrote: Hi all, I have created a build for Apache Calcite 1.23.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 Tag: https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 (revision 39622) The hashes of the artifacts are as follows: 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 *apache-calcite-1.23.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ Release artifacts are signed with the following key: https://dist.apache.org/repos/dist/release/calcite/KEYS N.B. To create the jars and test Apache Calcite: "./gradlew build". If you do not have a Java environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker-compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite 1.23.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.23.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Thanks, Haisheng Yuan
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks for work, Haisheng! Environment: Windows-10/Mac-OS JDK version: 1.8.0_241 Release notes: OK Build with tests: OK Checksums and signatures: OK Vote: +1 (non-binding) Haisheng Yuan 于2020年5月16日周六 下午12:02写道： > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Tag: > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > (revision 39622) > > The hashes of the artifacts are as follows: > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > *apache-calcite-1.23.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/release/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite: "./gradlew build". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite 1.23.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.23.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Thanks, > Haisheng Yuan >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks, Haisheng ~ Local Calcite build with tests enabled on Linux: *OK* Calcite-based system test suite: *OK* Vote: +1 (non-binding) Francis Chuang 于2020年5月18日周一 下午2:00写道： > Thanks for making this release available for voting, Haisheng! > > Verified GPG signature - OK > Verified SHA512 - OK > Ran tests per HOWTO (./gradlew check) - OK > Quickly skimmed release notes - OK > Spotted checked a few JARs in the Maven repository - OK > > Environment (OpenJDK:latest docker container): > Gradle 6.3 (via gradlew) > Debian GNU/Linux 8 > openjdk version "1.8.0_111" > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14) > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) > > My vote is: +1 (binding) > > Francis > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote: > > Hi all, > > > > I have created a build for Apache Calcite 1.23.0, release > > candidate 1. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > The commit to be voted upon: > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > Tag: > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > (revision 39622) > > > > The hashes of the artifacts are as follows: > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > *apache-calcite-1.23.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > > N.B. > > To create the jars and test Apache Calcite: "./gradlew build". > > > > If you do not have a Java environment available, you can run the tests > > using docker. To do so, install docker and docker-compose, then run > > "docker-compose run test" from the root of the directory. > > > > Please vote on releasing this package as Apache Calcite 1.23.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > +1 (binding) > > > > Thanks, > > Haisheng Yuan > > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks, Haisheng! Environment: Mac-OS Mojave (10.14.6) JDK version: 1.8.0_211 Release notes: OK Build with tests: OK Checksums and signatures: OK Vote: +1 (non-binding) Best, Forward XING JIN 于2020年5月19日周二 上午10:53写道： > Thanks, Haisheng ~ > > Local Calcite build with tests enabled on Linux: *OK* > Calcite-based system test suite: *OK* > > Vote: > +1 (non-binding) > > Francis Chuang 于2020年5月18日周一 下午2:00写道： > > > Thanks for making this release available for voting, Haisheng! > > > > Verified GPG signature - OK > > Verified SHA512 - OK > > Ran tests per HOWTO (./gradlew check) - OK > > Quickly skimmed release notes - OK > > Spotted checked a few JARs in the Maven repository - OK > > > > Environment (OpenJDK:latest docker container): > > Gradle 6.3 (via gradlew) > > Debian GNU/Linux 8 > > openjdk version "1.8.0_111" > > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14) > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) > > > > My vote is: +1 (binding) > > > > Francis > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote: > > > Hi all, > > > > > > I have created a build for Apache Calcite 1.23.0, release > > > candidate 1. > > > > > > Thanks to everyone who has contributed to this release. > > > > > > You can read the release notes here: > > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > > > The commit to be voted upon: > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > Tag: > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > > > The artifacts to be voted on are located here: > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > > (revision 39622) > > > > > > The hashes of the artifacts are as follows: > > > > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > > *apache-calcite-1.23.0-src.tar.gz > > > > > > A staged Maven repository is available for review at: > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > > > > Release artifacts are signed with the following key: > > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > > > > N.B. > > > To create the jars and test Apache Calcite: "./gradlew build". > > > > > > If you do not have a Java environment available, you can run the tests > > > using docker. To do so, install docker and docker-compose, then run > > > "docker-compose run test" from the root of the directory. > > > > > > Please vote on releasing this package as Apache Calcite 1.23.0. > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > > least three +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > [ ] -1 Do not release this package because... > > > > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > Thanks, > > > Haisheng Yuan > > > > > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks Haisheng for driving this! Verified GPG signature - OK Verified SHA512 - OK Release notes - OK Diff the files in the release artifact and tag - ok As for Calcite 3997, it only affects the Physical node, I’m fine with that ~ So +1 (binding) ~ Gradle 6.3 (via gradlew) Mac OS High Sierra JDK version "1.8.0_151" Forward Xu 于2020年5月20日 周三上午9:38写道： > Thanks, Haisheng! > > > Environment: Mac-OS Mojave (10.14.6) > > JDK version: 1.8.0_211 > > > Release notes: OK > > Build with tests: OK > > Checksums and signatures: OK > > > Vote: > > +1 (non-binding) > > > Best, > > Forward > > XING JIN 于2020年5月19日周二 上午10:53写道： > > > Thanks, Haisheng ~ > > > > Local Calcite build with tests enabled on Linux: *OK* > > Calcite-based system test suite: *OK* > > > > Vote: > > +1 (non-binding) > > > > Francis Chuang 于2020年5月18日周一 下午2:00写道： > > > > > Thanks for making this release available for voting, Haisheng! > > > > > > Verified GPG signature - OK > > > Verified SHA512 - OK > > > Ran tests per HOWTO (./gradlew check) - OK > > > Quickly skimmed release notes - OK > > > Spotted checked a few JARs in the Maven repository - OK > > > > > > Environment (OpenJDK:latest docker container): > > > Gradle 6.3 (via gradlew) > > > Debian GNU/Linux 8 > > > openjdk version "1.8.0_111" > > > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14) > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) > > > > > > My vote is: +1 (binding) > > > > > > Francis > > > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote: > > > > Hi all, > > > > > > > > I have created a build for Apache Calcite 1.23.0, release > > > > candidate 1. > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > You can read the release notes here: > > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > > > > > The commit to be voted upon: > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > > > Tag: > > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > > > > > The artifacts to be voted on are located here: > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > > > (revision 39622) > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > > > *apache-calcite-1.23.0-src.tar.gz > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > > > > > > Release artifacts are signed with the following key: > > > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > > > > > > N.B. > > > > To create the jars and test Apache Calcite: "./gradlew build". > > > > > > > > If you do not have a Java environment available, you can run the > tests > > > > using docker. To do so, install docker and docker-compose, then run > > > > "docker-compose run test" from the root of the directory. > > > > > > > > Please vote on releasing this package as Apache Calcite 1.23.0. > > > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > > > least three +1 PMC votes are cast. > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > [ ] -1 Do not release this package because... > > > > > > > > > > > > Here is my vote: > > > > > > > > +1 (binding) > > > > > > > > Thanks, > > > > Haisheng Yuan > > > > > > > > > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper * Checked signatures and checksums OK * Build (./gradlew clean assemble) on git repo and source artifacts OK * Run unit tests (./gradlew clean test) on git repo and source artifacts OK * Run slow tests (./gradlew clean testSlow) on git repo and source artifacts OK * Checked diff between git commit and source artifacts Apart from some differences in the licenses I see that the git tag has a folder site/fonts while the source artifacts do not. * Went over release note OK The following issues should be added in the breaking changes section: https://issues.apache.org/jira/browse/CALCITE-3825 https://issues.apache.org/jira/browse/CALCITE-3938 There are few typos and other minor improvements (like quoting SQL keywords and java classes) for the release note but all these can be done post-release. My only concern for casting my vote is the site/fonts folder that is present on the repo. I don't remember seeing this in the previous releases. Can somebody clarify if this is normal? Thanks again for your effort Haisheng! Best, Stamatis On Wed, May 20, 2020 at 3:13 PM Danny Chan wrote: > Thanks Haisheng for driving this! > > Verified GPG signature - OK > Verified SHA512 - OK > Release notes - OK > Diff the files in the release artifact and tag - ok > > As for Calcite 3997, it only affects the Physical node, I’m fine with that > ~ > > So +1 (binding) ~ > > Gradle 6.3 (via gradlew) > Mac OS High Sierra > JDK version "1.8.0_151" > > Forward Xu 于2020年5月20日 周三上午9:38写道： > > > Thanks, Haisheng! > > > > > > Environment: Mac-OS Mojave (10.14.6) > > > > JDK version: 1.8.0_211 > > > > > > Release notes: OK > > > > Build with tests: OK > > > > Checksums and signatures: OK > > > > > > Vote: > > > > +1 (non-binding) > > > > > > Best, > > > > Forward > > > > XING JIN 于2020年5月19日周二 上午10:53写道： > > > > > Thanks, Haisheng ~ > > > > > > Local Calcite build with tests enabled on Linux: *OK* > > > Calcite-based system test suite: *OK* > > > > > > Vote: > > > +1 (non-binding) > > > > > > Francis Chuang 于2020年5月18日周一 下午2:00写道： > > > > > > > Thanks for making this release available for voting, Haisheng! > > > > > > > > Verified GPG signature - OK > > > > Verified SHA512 - OK > > > > Ran tests per HOWTO (./gradlew check) - OK > > > > Quickly skimmed release notes - OK > > > > Spotted checked a few JARs in the Maven repository - OK > > > > > > > > Environment (OpenJDK:latest docker container): > > > > Gradle 6.3 (via gradlew) > > > > Debian GNU/Linux 8 > > > > openjdk version "1.8.0_111" > > > > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14) > > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) > > > > > > > > My vote is: +1 (binding) > > > > > > > > Francis > > > > > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote: > > > > > Hi all, > > > > > > > > > > I have created a build for Apache Calcite 1.23.0, release > > > > > candidate 1. > > > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > > > You can read the release notes here: > > > > > > > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > > > > > > > The commit to be voted upon: > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > > > > > Tag: > > > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > > > > > > > The artifacts to be voted on are located here: > > > > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > > > > (revision 39622) > > > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > > > > > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Indeed there is an extra site/fonts in the git tag. I didn't see it in the last two releases (the diff on licenses are normal). So the question is, does it matter for the diff on site/? At least the artifact has the same source code as the tag (thus can build the same jar, behave the same when run same queries, etc.) Also the site/ seems not related to javadoc either. -Rui On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis wrote: > 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper > > * Checked signatures and checksums OK > * Build (./gradlew clean assemble) on git repo and source artifacts OK > * Run unit tests (./gradlew clean test) on git repo and source artifacts > OK > * Run slow tests (./gradlew clean testSlow) on git repo and source > artifacts OK > * Checked diff between git commit and source artifacts > Apart from some differences in the licenses I see that the git tag has a > folder site/fonts while the source artifacts do not. > * Went over release note OK > > The following issues should be added in the breaking changes section: > https://issues.apache.org/jira/browse/CALCITE-3825 > https://issues.apache.org/jira/browse/CALCITE-3938 > > There are few typos and other minor improvements (like quoting SQL keywords > and java classes) for the release note but all these can be done > post-release. > > My only concern for casting my vote is the site/fonts folder that is > present on the repo. I don't remember seeing this in the previous releases. > Can somebody clarify if this is normal? > > Thanks again for your effort Haisheng! > > Best, > Stamatis > > On Wed, May 20, 2020 at 3:13 PM Danny Chan wrote: > > > Thanks Haisheng for driving this! > > > > Verified GPG signature - OK > > Verified SHA512 - OK > > Release notes - OK > > Diff the files in the release artifact and tag - ok > > > > As for Calcite 3997, it only affects the Physical node, I’m fine with > that > > ~ > > > > So +1 (binding) ~ > > > > Gradle 6.3 (via gradlew) > > Mac OS High Sierra > > JDK version "1.8.0_151" > > > > Forward Xu 于2020年5月20日 周三上午9:38写道： > > > > > Thanks, Haisheng! > > > > > > > > > Environment: Mac-OS Mojave (10.14.6) > > > > > > JDK version: 1.8.0_211 > > > > > > > > > Release notes: OK > > > > > > Build with tests: OK > > > > > > Checksums and signatures: OK > > > > > > > > > Vote: > > > > > > +1 (non-binding) > > > > > > > > > Best, > > > > > > Forward > > > > > > XING JIN 于2020年5月19日周二 上午10:53写道： > > > > > > > Thanks, Haisheng ~ > > > > > > > > Local Calcite build with tests enabled on Linux: *OK* > > > > Calcite-based system test suite: *OK* > > > > > > > > Vote: > > > > +1 (non-binding) > > > > > > > > Francis Chuang 于2020年5月18日周一 下午2:00写道： > > > > > > > > > Thanks for making this release available for voting, Haisheng! > > > > > > > > > > Verified GPG signature - OK > > > > > Verified SHA512 - OK > > > > > Ran tests per HOWTO (./gradlew check) - OK > > > > > Quickly skimmed release notes - OK > > > > > Spotted checked a few JARs in the Maven repository - OK > > > > > > > > > > Environment (OpenJDK:latest docker container): > > > > > Gradle 6.3 (via gradlew) > > > > > Debian GNU/Linux 8 > > > > > openjdk version "1.8.0_111" > > > > > OpenJDK Runtime Environment (build > 1.8.0_111-8u111-b14-2~bpo8+1-b14) > > > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) > > > > > > > > > > My vote is: +1 (binding) > > > > > > > > > > Francis > > > > > > > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote: > > > > > > Hi all, > > > > > > > > > > > > I have created a build for Apache Calcite 1.23.0, release > > > > > > candidate 1. > > > > > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > > > > > You can read the release notes here: > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > &g
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
I built the site both from the repo (git tag) and apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot checked. From what I could tell, there wasn't an obvious difference (random clicks were limited though). My personal opinion is that the 1.23.0 rc1 can continue. If someone knows the exact impact of this diff, we could add it to the release note, in the category of "known issues". -Rui On Wed, May 20, 2020 at 9:33 PM Rui Wang wrote: > Indeed there is an extra site/fonts in the git tag. I didn't see it in the > last two releases (the diff on licenses are normal). > > So the question is, does it matter for the diff on site/? At least the > artifact has the same source code as the tag (thus can build the same jar, > behave the same when run same queries, etc.) Also the site/ seems not > related to javadoc either. > > > -Rui > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis > wrote: > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper >> >> * Checked signatures and checksums OK >> * Build (./gradlew clean assemble) on git repo and source artifacts OK >> * Run unit tests (./gradlew clean test) on git repo and source artifacts >> OK >> * Run slow tests (./gradlew clean testSlow) on git repo and source >> artifacts OK >> * Checked diff between git commit and source artifacts >> Apart from some differences in the licenses I see that the git tag has a >> folder site/fonts while the source artifacts do not. >> * Went over release note OK >> >> The following issues should be added in the breaking changes section: >> https://issues.apache.org/jira/browse/CALCITE-3825 >> https://issues.apache.org/jira/browse/CALCITE-3938 >> >> There are few typos and other minor improvements (like quoting SQL >> keywords >> and java classes) for the release note but all these can be done >> post-release. >> >> My only concern for casting my vote is the site/fonts folder that is >> present on the repo. I don't remember seeing this in the previous >> releases. >> Can somebody clarify if this is normal? >> >> Thanks again for your effort Haisheng! >> >> Best, >> Stamatis >> >> On Wed, May 20, 2020 at 3:13 PM Danny Chan wrote: >> >> > Thanks Haisheng for driving this! >> > >> > Verified GPG signature - OK >> > Verified SHA512 - OK >> > Release notes - OK >> > Diff the files in the release artifact and tag - ok >> > >> > As for Calcite 3997, it only affects the Physical node, I’m fine with >> that >> > ~ >> > >> > So +1 (binding) ~ >> > >> > Gradle 6.3 (via gradlew) >> > Mac OS High Sierra >> > JDK version "1.8.0_151" >> > >> > Forward Xu 于2020年5月20日 周三上午9:38写道： >> > >> > > Thanks, Haisheng! >> > > >> > > >> > > Environment: Mac-OS Mojave (10.14.6) >> > > >> > > JDK version: 1.8.0_211 >> > > >> > > >> > > Release notes: OK >> > > >> > > Build with tests: OK >> > > >> > > Checksums and signatures: OK >> > > >> > > >> > > Vote: >> > > >> > > +1 (non-binding) >> > > >> > > >> > > Best, >> > > >> > > Forward >> > > >> > > XING JIN 于2020年5月19日周二 上午10:53写道： >> > > >> > > > Thanks, Haisheng ~ >> > > > >> > > > Local Calcite build with tests enabled on Linux: *OK* >> > > > Calcite-based system test suite: *OK* >> > > > >> > > > Vote: >> > > > +1 (non-binding) >> > > > >> > > > Francis Chuang 于2020年5月18日周一 下午2:00写道： >> > > > >> > > > > Thanks for making this release available for voting, Haisheng! >> > > > > >> > > > > Verified GPG signature - OK >> > > > > Verified SHA512 - OK >> > > > > Ran tests per HOWTO (./gradlew check) - OK >> > > > > Quickly skimmed release notes - OK >> > > > > Spotted checked a few JARs in the Maven repository - OK >> > > > > >> > > > > Environment (OpenJDK:latest docker container): >> > > > > Gradle 6.3 (via gradlew) >> > > > > Debian GNU/Linux 8 >> > > > > openjdk version "1.8.0_111" >> > > > > OpenJDK Runtime Environme
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Maybe I'm mistaken, but the source tarball doesn't seem to be signed: $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc apache-calcite-1.23.0-src.tar.gz gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF gpg: Can't check signature: No public key I have imported Haisheng's keys successfully: $ gpg --recv-keys "A663 E308 27C3 5F7C F578 B4F0 41CA B58D 1DA9 7F7D" gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan " not changed gpg: Total number processed: 1 gpg: unchanged: 1 Julian On Wed, May 20, 2020 at 10:12 PM Rui Wang wrote: > > I built the site both from the repo (git tag) and > apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot > checked. From what I could tell, there wasn't an obvious difference (random > clicks were limited though). > > My personal opinion is that the 1.23.0 rc1 can continue. If someone knows > the exact impact of this diff, we could add it to the release note, in the > category of "known issues". > > > -Rui > > On Wed, May 20, 2020 at 9:33 PM Rui Wang wrote: > > > Indeed there is an extra site/fonts in the git tag. I didn't see it in the > > last two releases (the diff on licenses are normal). > > > > So the question is, does it matter for the diff on site/? At least the > > artifact has the same source code as the tag (thus can build the same jar, > > behave the same when run same queries, etc.) Also the site/ seems not > > related to javadoc either. > > > > > > -Rui > > > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis > > wrote: > > > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper > >> > >> * Checked signatures and checksums OK > >> * Build (./gradlew clean assemble) on git repo and source artifacts OK > >> * Run unit tests (./gradlew clean test) on git repo and source artifacts > >> OK > >> * Run slow tests (./gradlew clean testSlow) on git repo and source > >> artifacts OK > >> * Checked diff between git commit and source artifacts > >> Apart from some differences in the licenses I see that the git tag has a > >> folder site/fonts while the source artifacts do not. > >> * Went over release note OK > >> > >> The following issues should be added in the breaking changes section: > >> https://issues.apache.org/jira/browse/CALCITE-3825 > >> https://issues.apache.org/jira/browse/CALCITE-3938 > >> > >> There are few typos and other minor improvements (like quoting SQL > >> keywords > >> and java classes) for the release note but all these can be done > >> post-release. > >> > >> My only concern for casting my vote is the site/fonts folder that is > >> present on the repo. I don't remember seeing this in the previous > >> releases. > >> Can somebody clarify if this is normal? > >> > >> Thanks again for your effort Haisheng! > >> > >> Best, > >> Stamatis > >> > >> On Wed, May 20, 2020 at 3:13 PM Danny Chan wrote: > >> > >> > Thanks Haisheng for driving this! > >> > > >> > Verified GPG signature - OK > >> > Verified SHA512 - OK > >> > Release notes - OK > >> > Diff the files in the release artifact and tag - ok > >> > > >> > As for Calcite 3997, it only affects the Physical node, I’m fine with > >> that > >> > ~ > >> > > >> > So +1 (binding) ~ > >> > > >> > Gradle 6.3 (via gradlew) > >> > Mac OS High Sierra > >> > JDK version "1.8.0_151" > >> > > >> > Forward Xu 于2020年5月20日 周三上午9:38写道： > >> > > >> > > Thanks, Haisheng! > >> > > > >> > > > >> > > Environment: Mac-OS Mojave (10.14.6) > >> > > > >> > > JDK version: 1.8.0_211 > >> > > > >> > > > >> > > Release notes: OK > >> > > > >> > > Build with tests: OK > >> > > > >> > > Checksums and signatures: OK > >> > > > >> > > > >> > > Vote: > >> > > > >> > > +1 (non-binding) > >> > > > >> > > > >> > > Best, > >> > > > >> > > Forward > >> > > > >> > > XING JIN 于2020年5月19日周二 上午10:53写道： > >>
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
-1 because of signature issues noted in previous email (hoping I'm mistaken). Downloaded, checked build instructions, LICENSE, NOTICE, ran RAT, compiled and ran tests using gradlew (Ubuntu 20.04 and JDK 14), compared contents of source distro with contents of git. * howto.md doesn't mention JDK 14 as a valid release * the line 'cd calcite-1.23.0' should be 'cd apache-calcite-1.23.0-src' * the first line printed by gradle is ':jar: No valid plugin descriptors were found in META-INF/gradle-plugins'; I don't know whether this is bad, but it looks bad * following the instructions in howto.md builds a release '1.23.0-SNAPSHOT'; instructions should say how to build '1.23.0' * LICENSE file in the source distro has a few extra lines compared to the one in git * in release notes: ** 'fastest version of Calcite' is a bit hyperbolic; I would state that there have been performance improvements in the planner engine and hyperlink to a JIRA case ** I think quite a few of the 'new features' that extend an existing component to a new class (e.g supporting Exchange in RelFieldTrimmer) should be listed as bug-fixes; ** all class names need to be in back-ticks; all SQL keywords need to be upper-case and in back-ticks; ** I don't like the long lines - can we go back to breaking at 80? ** In 'it's worth mentioning the following', remove JIRA case numbers so that the paragraph reads like prose rather than a list. On Thu, May 21, 2020 at 10:57 AM Julian Hyde wrote: > > Maybe I'm mistaken, but the source tarball doesn't seem to be signed: > > $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc > apache-calcite-1.23.0-src.tar.gz > gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT > gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF > gpg: Can't check signature: No public key > > I have imported Haisheng's keys successfully: > > $ gpg --recv-keys "A663 E308 27C3 5F7C F578 B4F0 41CA B58D 1DA9 7F7D" > gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan " not changed > gpg: Total number processed: 1 > gpg: unchanged: 1 > > Julian > > On Wed, May 20, 2020 at 10:12 PM Rui Wang wrote: > > > > I built the site both from the repo (git tag) and > > apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot > > checked. From what I could tell, there wasn't an obvious difference (random > > clicks were limited though). > > > > My personal opinion is that the 1.23.0 rc1 can continue. If someone knows > > the exact impact of this diff, we could add it to the release note, in the > > category of "known issues". > > > > > > -Rui > > > > On Wed, May 20, 2020 at 9:33 PM Rui Wang wrote: > > > > > Indeed there is an extra site/fonts in the git tag. I didn't see it in the > > > last two releases (the diff on licenses are normal). > > > > > > So the question is, does it matter for the diff on site/? At least the > > > artifact has the same source code as the tag (thus can build the same jar, > > > behave the same when run same queries, etc.) Also the site/ seems not > > > related to javadoc either. > > > > > > > > > -Rui > > > > > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis > > > wrote: > > > > > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper > > >> > > >> * Checked signatures and checksums OK > > >> * Build (./gradlew clean assemble) on git repo and source artifacts OK > > >> * Run unit tests (./gradlew clean test) on git repo and source artifacts > > >> OK > > >> * Run slow tests (./gradlew clean testSlow) on git repo and source > > >> artifacts OK > > >> * Checked diff between git commit and source artifacts > > >> Apart from some differences in the licenses I see that the git tag has a > > >> folder site/fonts while the source artifacts do not. > > >> * Went over release note OK > > >> > > >> The following issues should be added in the breaking changes section: > > >> https://issues.apache.org/jira/browse/CALCITE-3825 > > >> https://issues.apache.org/jira/browse/CALCITE-3938 > > >> > > >> There are few typos and other minor improvements (like quoting SQL > > >> keywords > > >> and java classes) for the release note but all these can be done > > >> post-release. > > >> > > >> My only concern for casting my vote is the site/fonts folder that is > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
>-1 because of signature issues noted in previous email (hoping I'm mistaken). I think you are confused because Haisheng uses multiple keys. https://people.apache.org/keys/committer/ lists two keys, and https://dist.apache.org/repos/dist/release/calcite/KEYS does include the key that signs the release (ECA9...). Please double-check. >* LICENSE file in the source distro has a few extra lines compared to the one in git I see lots of people list the difference. What do you expect? If the difference is ok, then why list it? If the difference is not ok, then where is the reasoning? Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
OK, I imported Haisheng's key from KEYS and now it checks out. The message "no public key" was confusing - I thought it meant that the file was not signed, whereas gpg meant that it did not recognize the key. Changing my vote to +1. Haisheng, can you please get one or two people to sign your key, so that you are in the web of trust. It does not need to happen before the release, but before we announce. The difference in LICENSE is concerning because this is a source distro. All files should match those in the source repo at that precise commit. Could this version of LICENSE be the committed one? Julian On Thu, May 21, 2020 at 12:08 PM Vladimir Sitnikov wrote: > > >-1 because of signature issues noted in previous email (hoping I'm > mistaken). > > I think you are confused because Haisheng uses multiple keys. > https://people.apache.org/keys/committer/ lists two keys, and > https://dist.apache.org/repos/dist/release/calcite/KEYS does include the > key that signs the release (ECA9...). > > Please double-check. > > >* LICENSE file in the source distro has a few extra lines compared to > the one in git > > I see lots of people list the difference. What do you expect? > If the difference is ok, then why list it? > If the difference is not ok, then where is the reasoning? > > Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks. To Julian and Stamatis, Can you help sign my keys? 3CD22ABAC50DDCEF 41CAB58D1DA97F7D We can hangout if it is required. Thanks, Haisheng On 2020/05/22 00:25:15, Julian Hyde wrote: > OK, I imported Haisheng's key from KEYS and now it checks out. The > message "no public key" was confusing - I thought it meant that the > file was not signed, whereas gpg meant that it did not recognize the > key. > > Changing my vote to +1. > > Haisheng, can you please get one or two people to sign your key, so > that you are in the web of trust. It does not need to happen before > the release, but before we announce. > > The difference in LICENSE is concerning because this is a source > distro. All files should match those in the source repo at that > precise commit. Could this version of LICENSE be the committed one? > > Julian > > > On Thu, May 21, 2020 at 12:08 PM Vladimir Sitnikov > wrote: > > > > >-1 because of signature issues noted in previous email (hoping I'm > > mistaken). > > > > I think you are confused because Haisheng uses multiple keys. > > https://people.apache.org/keys/committer/ lists two keys, and > > https://dist.apache.org/repos/dist/release/calcite/KEYS does include the > > key that signs the release (ECA9...). > > > > Please double-check. > > > > >* LICENSE file in the source distro has a few extra lines compared to > > the one in git > > > > I see lots of people list the difference. What do you expect? > > If the difference is ok, then why list it? > > If the difference is not ok, then where is the reasoning? > > > > Vladimir >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Julian>It does not need to happen before Julian>the release, but before we announce. Cross-signing is not required at all. Julian>All files should match those in the source repo at that Julian>precise commit. Julian> Could this version of LICENSE be the committed one? Long story short: LICENSE file is a build artifact rather than an opaque blob. The license for the release artifact must include the licenses of all the bundled dependencies. That becomes extremely fragile if the license text is maintained manually. In the past there were multiple license violations in both Calcite and Calcite Avatica releases. The violations included: "missing license, copyright", "forbidden dependency bundled in the release". --- GitHub uses /LICENSE file to show the repository license in the summary line (right above the source tree), so adding extra content might confuse GitHub which would be devastating. Here's a sample project: https://github.com/embox/embox The license is BSD-2-Clause, however, GitHub is confused, and it shows "view license" rather than "BSD-2-Clause" --- It might be worth including the expected contents of the "release license" under /src/*/test/resources/EXPECTED_LICENSE It would protect from unexpected third-party dependencies bundling. As usual, PRs are welcome. Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE bundled with the distribution? On Fri, May 22, 2020 at 12:45 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Julian>It does not need to happen before > Julian>the release, but before we announce. > > Cross-signing is not required at all. > > Julian>All files should match those in the source repo at that > Julian>precise commit. > Julian> Could this version of LICENSE be the committed one? > > Long story short: LICENSE file is a build artifact rather than an opaque > blob. > > The license for the release artifact must include the licenses of all the > bundled dependencies. > That becomes extremely fragile if the license text is maintained manually. > > In the past there were multiple license violations in both Calcite and > Calcite Avatica releases. > The violations included: "missing license, copyright", "forbidden > dependency bundled in the release". > > --- > > GitHub uses /LICENSE file to show the repository license in the summary > line (right above the source tree), > so adding extra content might confuse GitHub which would be devastating. > > Here's a sample project: https://github.com/embox/embox > The license is BSD-2-Clause, however, GitHub is confused, and it shows > "view license" rather than "BSD-2-Clause" > > --- > > It might be worth including the expected contents of the "release license" > under /src/*/test/resources/EXPECTED_LICENSE > It would protect from unexpected third-party dependencies bundling. > As usual, PRs are welcome. > > Vladimir >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Laurent> I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE Laurent> bundled with the distribution? Which distribution do you mean? Of course, Calcite source release bundles third-party dependencies (e.g. site/js/*.js files). Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
My keys are signed by Stamatis, thanks for helping, Stamatis! Now the keys link worked, https://people.apache.org/keys/committer/hyuan.asc No more action is needed, Julian. Thanks, Haisheng On 2020/05/22 00:25:15, Julian Hyde wrote: > OK, I imported Haisheng's key from KEYS and now it checks out. The > message "no public key" was confusing - I thought it meant that the > file was not signed, whereas gpg meant that it did not recognize the > key. > > Changing my vote to +1. > > Haisheng, can you please get one or two people to sign your key, so > that you are in the web of trust. It does not need to happen before > the release, but before we announce. > > The difference in LICENSE is concerning because this is a source > distro. All files should match those in the source repo at that > precise commit. Could this version of LICENSE be the committed one? > > Julian > > > On Thu, May 21, 2020 at 12:08 PM Vladimir Sitnikov > wrote: > > > > >-1 because of signature issues noted in previous email (hoping I'm > > mistaken). > > > > I think you are confused because Haisheng uses multiple keys. > > https://people.apache.org/keys/committer/ lists two keys, and > > https://dist.apache.org/repos/dist/release/calcite/KEYS does include the > > key that signs the release (ECA9...). > > > > Please double-check. > > > > >* LICENSE file in the source distro has a few extra lines compared to > > the one in git > > > > I see lots of people list the difference. What do you expect? > > If the difference is ok, then why list it? > > If the difference is not ok, then where is the reasoning? > > > > Vladimir >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
I meant the source distribution here. I guess I didn't realize Calcite source tree has embedded copies of some 3rd party css/js, but since those are not fetched dynamically and are part of the source tree, I think the committed LICENCE file should include those vs altering it at release time. As for Github, I think this is a non-issue because I've seen lots of variations on the LICENSE file, and github seems pretty lenient about it. I actually tried licensee ( https://github.com/licensee/licensee, used by Github itself) on the source distribution and it has no issue identifying the license. Also, although jekyll, is mentioned as a dependency, I don't see it bundled, and because there's no version associated with it, the license file is under licenses/jekyll-. On Fri, May 22, 2020 at 9:34 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Laurent> I'm slightly confused. Are any of MIT dependencies mentioned in > LICENSE > Laurent> bundled with the distribution? > > Which distribution do you mean? > Of course, Calcite source release bundles third-party dependencies (e.g. > site/js/*.js files). > > Vladimir >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Vote: +1 (binding) - Local Calcite builds (./gradlew clean build && ./gradlew testSlow) on MacOS and JDK8/11/14: OK - tarball content and signature: OK On Fri, May 15, 2020 at 9:02 PM Haisheng Yuan wrote: > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > Tag: > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > (revision 39622) > > The hashes of the artifacts are as follows: > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > *apache-calcite-1.23.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/release/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite: "./gradlew build". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite 1.23.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.23.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Thanks, > Haisheng Yuan >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Laurent>As for Github, I think this is a non-issue I have provided an example: https://github.com/embox/embox It is an example when GitHub fails to detect the license. It is really sad to hear that "you think it is a non-issue" even in case you have seen the failure case. Laurent>on the source distribution and it has no issue identifying the license. The license might vary over time, and it would be very bad to end up with improperly detected license in GitHub. Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
My intent was not to cause sadness, sorry about that. I should have elaborated a bit more why I don't think Github is that much of an issue: - LICENSE file at the root of the project is the source of truth, not Github mention. It is a nice to have the correct license for Github for sure, but it seems more important to me to have LICENSE includes the 3rd party dependencies present in our source tree than having the license displayed at the top of the github UI. - As for the embox project you mentioned, it's probably because the license is short and BSD licenses have very similar texts. Here's what license says about the project: $ licensee detect https://github.com/embox/embox License:NOASSERTION Matched files: COPYRIGHT COPYRIGHT: Content hash: 77dc7c8c10d1ed9bc1546f2d6bba18a809e235c7 License: NOASSERTION Closest non-matching licenses: BSD-2-Clause similarity: 89.59% BSD-3-Clause similarity: 83.54% BSD-4-Clause similarity: 77.82% $ licensee license-path https://github.com/embox/embox COPYRIGHT Here's now what licensee says the LICENSE file from the source distribution tarball: $ licensee detect ./apache-calcite-1.23.0-src License:Apache-2.0 Matched files: LICENSE LICENSE: Content hash: ab3901051663cb8ee5dea9ebdff406ad136910e3 Confidence:100.00% Matcher: Licensee::Matchers::Exact License: Apache-2.0 $ licensee license-path ./apache-calcite-1.23.0-src /xxx/apache-calcite-1.23.0-src/LICENSE It seems that adding several mentions at the bottom, licensee has no trouble identifying the apache license because the text is so large and so distinctive. It is corroborated by my own personal experience of checking license for many many dependencies and comparing between Maven pom.xml, github mention, and actual LICENSE/source file headers than when people are using ASL 2.0, even with copyright mention + extra stuff after the main text, Github gets it right. On Fri, May 22, 2020 at 12:32 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Laurent>As for Github, I think this is a non-issue > > I have provided an example: https://github.com/embox/embox > It is an example when GitHub fails to detect the license. > > It is really sad to hear that "you think it is a non-issue" even in case > you have seen the failure case. > > Laurent>on the source distribution and it has no issue identifying the > license. > > The license might vary over time, and it would be very bad to end up with > improperly detected license in GitHub. > > Vladimir >
[RESULT] [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 5 binding +1s: Haisheng, Francis, Danny, Julian Hyde, Laurent 5 non-binding +1s: Anton, Enrico, Feng Zhu, Xing Jin, Forward Xu 1 non-binding +0s: Ruben Q L Therefore I am delighted to announce that the proposal to release Apache Calcite 1.23.0 has passed. Thanks everyone. We’ll now roll the release out to the mirrors. The release notes will be updated afterwards according to the feedback. Thanks, Haisheng
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hi, I had the following error when executing the command: ./gradlew publishDist -Prc=1 -Pasf > Task :releaseRepository Initialized stagingRepositoryId orgapachecalcite-1089 for repository nexus <==---> 50% EXECUTING [1m 17s] GET request failed. 404: Not Found, body: [errors:[[id:*, msg:No such repository: orgapachecalcite-1089]]] Requested operation was executed successfully in attempt 117 (maximum allowed 601) > Task :createReleaseTag Created tag calcite-1.23.0 -> Ref[refs/tags/calcite-1.23.0=7c3001d97497ca60b8e2039e8f3c96ca8672fae8(-1)] > Task :pushReleaseTag Pushing tag to Git remote release-origin: https://github.com/apache/calcite.git Message from release-origin: refs/tags/calcite-1.23.0: OK, 7c3001d97497ca60b8e2039e8f3c96ca8672fae8 (fastForward) BUILD SUCCESSFUL in 5m 0s 4 actionable tasks: 4 executed ~ But it said build successful. Is there anything I can do for the 404 Not Found error? Thanks, Haisheng On 2020/05/22 20:37:35, Laurent Goujon wrote: > My intent was not to cause sadness, sorry about that. > > I should have elaborated a bit more why I don't think Github is that much > of an issue: > - LICENSE file at the root of the project is the source of truth, not > Github mention. It is a nice to have the correct license for Github for > sure, but it seems more important to me to have LICENSE includes the 3rd > party dependencies present in our source tree than having the license > displayed at the top of the github UI. > > - As for the embox project you mentioned, it's probably because the license > is short and BSD licenses have very similar texts. Here's what license says > about the project: > > $ licensee detect https://github.com/embox/embox > License:NOASSERTION > Matched files: COPYRIGHT > COPYRIGHT: > Content hash: 77dc7c8c10d1ed9bc1546f2d6bba18a809e235c7 > License: NOASSERTION > Closest non-matching licenses: > BSD-2-Clause similarity: 89.59% > BSD-3-Clause similarity: 83.54% > BSD-4-Clause similarity: 77.82% > > $ licensee license-path https://github.com/embox/embox > COPYRIGHT > > Here's now what licensee says the LICENSE file from the source distribution > tarball: > > $ licensee detect ./apache-calcite-1.23.0-src > License:Apache-2.0 > Matched files: LICENSE > LICENSE: > Content hash: ab3901051663cb8ee5dea9ebdff406ad136910e3 > Confidence:100.00% > Matcher: Licensee::Matchers::Exact > License: Apache-2.0 > > $ licensee license-path ./apache-calcite-1.23.0-src > /xxx/apache-calcite-1.23.0-src/LICENSE > > It seems that adding several mentions at the bottom, licensee has no > trouble identifying the apache license because the text is so large and so > distinctive. It is corroborated by my own personal experience of checking > license for many many dependencies and comparing between Maven pom.xml, > github mention, and actual LICENSE/source file headers than when people are > using ASL 2.0, even with copyright mention + extra stuff after the main > text, Github gets it right. > > On Fri, May 22, 2020 at 12:32 PM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > > Laurent>As for Github, I think this is a non-issue > > > > I have provided an example: https://github.com/embox/embox > > It is an example when GitHub fails to detect the license. > > > > It is really sad to hear that "you think it is a non-issue" even in case > > you have seen the failure case. > > > > Laurent>on the source distribution and it has no issue identifying the > > license. > > > > The license might vary over time, and it would be very bad to end up with > > improperly detected license in GitHub. > > > > Vladimir > > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
>But it said build successful. Is there anything I can do for the 404 Not Found error? It means "staging repository no longer exists as it has just been released". I've raised https://github.com/gradle-nexus/publish-plugin/issues/29 to heal that. However, gradle-nexus/publish-plugin is not yet ready for use, so 404 will be there for a while. Currently, we use https://github.com/Codearte/gradle-nexus-staging-plugin + https://github.com/marcphilipp/nexus-publish-plugin, however, I'm not eager to analyze and fix those because they both will be superseded by a single gradle-nexus/publish-plugin Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hi Vladimir, Thanks for your explanation. And thanks a lot for providing such an amazing release tool for us! Cheers, Haisheng On 2020/05/23 16:28:52, Vladimir Sitnikov wrote: > >But it said build successful. Is there anything I can do for the 404 Not > Found error? > > It means "staging repository no longer exists as it has just been released". > > I've raised https://github.com/gradle-nexus/publish-plugin/issues/29 to > heal that. > However, gradle-nexus/publish-plugin is not yet ready for use, so 404 will > be there for a while. > > Currently, we use https://github.com/Codearte/gradle-nexus-staging-plugin + > https://github.com/marcphilipp/nexus-publish-plugin, > however, I'm not eager to analyze and fix those because they both will be > superseded by a single gradle-nexus/publish-plugin > > Vladimir >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
> * the first line printed by gradle is ':jar: No valid plugin > descriptors were found in META-INF/gradle-plugins'; I don't know > whether this is bad, but it looks bad Looks like it is expected: https://github.com/gradle/gradle/issues/9758 On 2020/05/21 18:41:41, Julian Hyde wrote: > -1 because of signature issues noted in previous email (hoping I'm mistaken). > > Downloaded, checked build instructions, LICENSE, NOTICE, ran RAT, > compiled and ran tests using gradlew (Ubuntu 20.04 and JDK 14), > compared contents of source distro with contents of git. > > * howto.md doesn't mention JDK 14 as a valid release > * the line 'cd calcite-1.23.0' should be 'cd apache-calcite-1.23.0-src' > * the first line printed by gradle is ':jar: No valid plugin > descriptors were found in META-INF/gradle-plugins'; I don't know > whether this is bad, but it looks bad > * following the instructions in howto.md builds a release > '1.23.0-SNAPSHOT'; instructions should say how to build '1.23.0' > * LICENSE file in the source distro has a few extra lines compared to > the one in git > * in release notes: > ** 'fastest version of Calcite' is a bit hyperbolic; I would state > that there have been performance improvements in the planner engine > and hyperlink to a JIRA case > ** I think quite a few of the 'new features' that extend an existing > component to a new class (e.g supporting Exchange in RelFieldTrimmer) > should be listed as bug-fixes; > ** all class names need to be in back-ticks; all SQL keywords need to > be upper-case and in back-ticks; > ** I don't like the long lines - can we go back to breaking at 80? > ** In 'it's worth mentioning the following', remove JIRA case numbers > so that the paragraph reads like prose rather than a list. > > > On Thu, May 21, 2020 at 10:57 AM Julian Hyde wrote: > > > > Maybe I'm mistaken, but the source tarball doesn't seem to be signed: > > > > $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc > > apache-calcite-1.23.0-src.tar.gz > > gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT > > gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF > > gpg: Can't check signature: No public key > > > > I have imported Haisheng's keys successfully: > > > > $ gpg --recv-keys "A663 E308 27C3 5F7C F578 B4F0 41CA B58D 1DA9 7F7D" > > gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan " not changed > > gpg: Total number processed: 1 > > gpg: unchanged: 1 > > > > Julian > > > > On Wed, May 20, 2020 at 10:12 PM Rui Wang wrote: > > > > > > I built the site both from the repo (git tag) and > > > apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot > > > checked. From what I could tell, there wasn't an obvious difference > > > (random > > > clicks were limited though). > > > > > > My personal opinion is that the 1.23.0 rc1 can continue. If someone knows > > > the exact impact of this diff, we could add it to the release note, in the > > > category of "known issues". > > > > > > > > > -Rui > > > > > > On Wed, May 20, 2020 at 9:33 PM Rui Wang wrote: > > > > > > > Indeed there is an extra site/fonts in the git tag. I didn't see it in > > > > the > > > > last two releases (the diff on licenses are normal). > > > > > > > > So the question is, does it matter for the diff on site/? At least the > > > > artifact has the same source code as the tag (thus can build the same > > > > jar, > > > > behave the same when run same queries, etc.) Also the site/ seems not > > > > related to javadoc either. > > > > > > > > > > > > -Rui > > > > > > > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis > > > > wrote: > > > > > > > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper > > > >> > > > >> * Checked signatures and checksums OK > > > >> * Build (./gradlew clean assemble) on git repo and source artifacts OK > > > >> * Run unit tests (./gradlew clean test) on git repo and source > > > >> artifacts > > > >> OK > > > >> * Run slow tests (./gradlew clean testSlow) on git repo and source > > > >> artifacts OK > > > >> * Checked diff between git commit and source artifac
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
>Looks like it is expected:
>https://github.com/gradle/gradle/issues/9758
It is not expected.
The way to fix it is to apply the following patch:
--- a/buildSrc/build.gradle.kts
+++ b/buildSrc/build.gradle.kts
@@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
plugins {
-java
`kotlin-dsl` apply false
id("com.github.autostyle")
id("com.github.vlsi.gradle-extensions")
@@ -75,6 +74,6 @@ fun Project.applyKotlinProjectConventions() {
dependencies {
subprojects.forEach {
-runtimeOnly(project(it.path))
+"runtimeOnly"(project(it.path))
}
}
Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Vote: +1 (non-binding)
CALCITE-3819 <https://issues.apache.org/jira/browse/CALCITE-3819> really
helps infinite planning in our use case. And I'm looking forward
to CALCITE-3997.
---
Environment: Mac-OS
JDK version: 1.8.0_212
Build with tests: OK
Regards!
Aron Tao
Vladimir Sitnikov 于2020年5月24日周日 上午4:35写道：
> >Looks like it is expected:
> >https://github.com/gradle/gradle/issues/9758
>
> It is not expected.
>
> The way to fix it is to apply the following patch:
>
> --- a/buildSrc/build.gradle.kts
> +++ b/buildSrc/build.gradle.kts
> @@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props
> import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
>
> plugins {
> -java
> `kotlin-dsl` apply false
> id("com.github.autostyle")
> id("com.github.vlsi.gradle-extensions")
> @@ -75,6 +74,6 @@ fun Project.applyKotlinProjectConventions() {
>
> dependencies {
> subprojects.forEach {
> -runtimeOnly(project(it.path))
> +"runtimeOnly"(project(it.path))
> }
> }
>
> Vladimir
>
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Haisheng
I still can't see Calcite 1.23.0 on Maven Central
https://search.maven.org/search?q=a:calcite-core
did the release procedure complete successfully?
Enrico
Il giorno dom 24 mag 2020 alle ore 14:35 JiaTao Tao ha
scritto:
> Vote: +1 (non-binding)
>
> CALCITE-3819 <https://issues.apache.org/jira/browse/CALCITE-3819> really
> helps infinite planning in our use case. And I'm looking forward
> to CALCITE-3997.
>
> ---
> Environment: Mac-OS
> JDK version: 1.8.0_212
> Build with tests: OK
>
>
> Regards!
>
> Aron Tao
>
>
> Vladimir Sitnikov 于2020年5月24日周日 上午4:35写道：
>
> > >Looks like it is expected:
> > >https://github.com/gradle/gradle/issues/9758
> >
> > It is not expected.
> >
> > The way to fix it is to apply the following patch:
> >
> > --- a/buildSrc/build.gradle.kts
> > +++ b/buildSrc/build.gradle.kts
> > @@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props
> > import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
> >
> > plugins {
> > -java
> > `kotlin-dsl` apply false
> > id("com.github.autostyle")
> > id("com.github.vlsi.gradle-extensions")
> > @@ -75,6 +74,6 @@ fun Project.applyKotlinProjectConventions() {
> >
> > dependencies {
> > subprojects.forEach {
> > -runtimeOnly(project(it.path))
> > +"runtimeOnly"(project(it.path))
> > }
> > }
> >
> > Vladimir
> >
>
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
ASF releases are shared with repository.apache.org: https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom It might be there are issues with ASF Nexus and Sonatype Nexus sync. Vladimir
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Vladimir o Haisheng could you please open a ticket to INFRA ? I can do it myself, with your permission (I am not in Calcite PMC/committers group) Otherwise it is not possible to use Calcite 1.23.0 from downstream projects Enrico Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov < sitnikov.vladi...@gmail.com> ha scritto: > ASF releases are shared with repository.apache.org: > > https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom > > It might be there are issues with ASF Nexus and Sonatype Nexus sync. > > Vladimir >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Hi Enrico, Thanks for reporting the issue. I have created a JIRA ticket: https://issues.apache.org/jira/browse/INFRA-20326 Thanks, Haisheng On 2020/05/26 09:20:14, Enrico Olivelli wrote: > Vladimir o Haisheng > could you please open a ticket to INFRA ? > I can do it myself, with your permission (I am not in Calcite > PMC/committers group) > > Otherwise it is not possible to use Calcite 1.23.0 from downstream projects > > Enrico > > Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> ha scritto: > > > ASF releases are shared with repository.apache.org: > > > > https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom > > > > It might be there are issues with ASF Nexus and Sonatype Nexus sync. > > > > Vladimir > > >
Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)
Now it is back to normal: https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.23.0/ On 2020/05/26 14:00:50, Haisheng Yuan wrote: > Hi Enrico, > > Thanks for reporting the issue. > > I have created a JIRA ticket: > https://issues.apache.org/jira/browse/INFRA-20326 > > Thanks, > Haisheng > > On 2020/05/26 09:20:14, Enrico Olivelli wrote: > > Vladimir o Haisheng > > could you please open a ticket to INFRA ? > > I can do it myself, with your permission (I am not in Calcite > > PMC/committers group) > > > > Otherwise it is not possible to use Calcite 1.23.0 from downstream projects > > > > Enrico > > > > Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov < > > sitnikov.vladi...@gmail.com> ha scritto: > > > > > ASF releases are shared with repository.apache.org: > > > > > > https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom > > > > > > It might be there are issues with ASF Nexus and Sonatype Nexus sync. > > > > > > Vladimir > > > > > >
