Re: Review Request 15175: Added a verifyElementInList utility function
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28085 --- Easier to do if a in [1,2,3]: , no? - Prasanna Santhanam On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: Review Request 15175: Added a verifyElementInList utility function
On Nov. 4, 2013, 8:21 a.m., Prasanna Santhanam wrote: Easier to do if a in [1,2,3]: , no? 1. Purpose is to check whether the input is list and whether it is empty as well. 2. If it is not a list, then a in None will lead to exception. 3. Purpose is also to provide a generic api to check the element presence at a given position as well. a in [1,2,3] will check, if a is in the list but which position we are expecting this element to be? so position is also required, generally we are verifying the first element so we keyworded the pos=0 to make it easier. 4. Provide custom error codes and messages for log and further processing. 5. This will benefit the case to remove multiple asserts in to one single line of code with new utility and make it cleaner to maintain at one place. self.assertEqual( isinstance(list_network_offerings_response, list), True, listNetworkOfferings returned invalid object in response. ) self.assertNotEqual( len(list_network_offerings_response), 0, listNetworkOfferings returned empty list. ) self.assertEqual( list_network_offerings_response[0].state, Enabled, The network offering state should get updated to Enabled. ) - Santhosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28085 --- On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/#review28084 --- api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java https://reviews.apache.org/r/15173/#comment54664 Is the customized flag required? Since you have made cpu/memory as optional. api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java https://reviews.apache.org/r/15173/#comment54666 Please keep the cpu related parameters together for better readability api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java https://reviews.apache.org/r/15173/#comment54665 typo feild api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java https://reviews.apache.org/r/15173/#comment54667 Please follow identical naming convention. rootdisksize - rootDiskSize api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java https://reviews.apache.org/r/15173/#comment54668 Where is the check to see if the service offering is dynamic or not? If a static service offering is specified and also the values of cpu/memory is provided it should fail with exception api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java https://reviews.apache.org/r/15173/#comment54672 For root disk size should there be any validation based on template size? engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java https://reviews.apache.org/r/15173/#comment54669 Can we have a consistent naming for the parameters? engine/components-api/src/com/cloud/configuration/ConfigurationManager.java https://reviews.apache.org/r/15173/#comment54670 Why is vmId manadatory here? engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java https://reviews.apache.org/r/15173/#comment54671 Isn't root disk size optional for deploy vm using template? From this change looks like mandatory. engine/schema/src/com/cloud/service/ServiceOfferingVO.java https://reviews.apache.org/r/15173/#comment54673 Why do you need this field? If any of cpu/memory is not specified then 'isDynamic' can be inferred. engine/schema/src/com/cloud/service/ServiceOfferingVO.java https://reviews.apache.org/r/15173/#comment54675 Again this is not required engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java https://reviews.apache.org/r/15173/#comment54674 ordering of parameter is not correct. optional parameters should be at the end - Koushik Das On Nov. 1, 2013, 5:40 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 1, 2013, 5:40 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java b1bfcfb api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/configuration/ConfigurationManager.java 03a549f engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 0821c81 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d
[ANNOUNCE] New Committer: Nguyen Anh Tu
The Project Management Committee (PMC) for Apache CloudStack has asked Nguyen Anh Tu to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Nguyen! -- Prasanna., on behalf of the Apache CloudStack PMC Powered by BigRock.com
Re: Review Request 14738: Testscript for DeployVM User data enhancement
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14738/#review28087 --- Ship it! Looks good to me. - sanjeev n On Oct. 31, 2013, 1:11 a.m., suresh sadhu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14738/ --- (Updated Oct. 31, 2013, 1:11 a.m.) Review request for cloudstack, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri. Bugs: cloudstack-2272 https://issues.apache.org/jira/browse/cloudstack-2272 Repository: cloudstack-git Description --- This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data) Diffs - test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION Diff: https://reviews.apache.org/r/14738/diff/ Testing --- yes Thanks, suresh sadhu
Re: [SOLVED]: RE: Issues deploying with marvin
On Thu, Oct 31, 2013 at 06:37:53PM +, Santhosh Edukulla wrote: Instead of going through these many steps, I believe the other quick solution would be to change sdist argument to install wherever its referencing python setup.py, under cs/tools/marvin/pom.xml and run maven command with clean install and other arguments. I am assuming it should fix the problem. Only problem, we would be assuming that the user running mvn also has root access to install python packages on the system in this case. Also, added tag solved to the subject line as well. Santhosh From: Will Stevens [williamstev...@gmail.com] Sent: Wednesday, October 30, 2013 12:55 PM To: dev@cloudstack.apache.org Cc: Sebastien Goasguen Subject: Re: Issues deploying with marvin ...Workaround included... The issue that I run into by not using the 'developer' profile when I do a 'clean install' is that the 'py' files do not get updated in the tools/marvin/marvin/cloudstackAPI/ directory. This is only a problem when there are changes, but that happens often enough to warrant a work around... This leads to the original error in this thread when this command runs: python ../marvin/marvin/deployDataCenter.py -i devcloud.cfg Throws an error similar to: NameError: global name 'addImageStore' is not defined (because the file 'tools/marvin/marvin/cloudstackAPI/addImageStore.py' is not present) The following workflow works for me to get around this issue... Run: mvn -P developer,systemvm -Dnonoss clean install (this will fail because of the hard linking of the files between the guest os and the host os's file system, however, it seems to populate the 'py' files or at least sets everything up so they will be populated correctly...) Next run (same thing without the developer profile): mvn -P systemvm -Dnonoss clean install (this finishes and gives you a clean build) Now you can do the deploy db with the developer profile: mvn -P developer -pl developer,tools/devcloud -Ddeploydb (this works) Then startup the server: export MAVEN_OPTS=-Xmx1024m -XX:MaxPermSize=512m -Xdebug -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n mvn -pl :cloud-client-ui jetty:run -D nonoss (wait for the server to come up) Then run deploy server with the developer profile: export MAVEN_OPTS= mvn -P developer -pl tools/devcloud -Ddeploysvr (this now finds everything it needs and completes) I hope this helps others get past this if they have similar problems... Cheers... On Wed, Oct 30, 2013 at 8:56 AM, Will Stevens williamstev...@gmail.comwrote: Yes. I believe the linking is failing because the host os and the guest os are different. Ws On Wednesday, October 30, 2013, Santhosh Edukulla wrote: Based upon the error log below, it seems hard link creation is failing. hard linking CHANGES.txt - Marvin-0.1.0 error: Operation not permitted It seems some body earlier has faced a similar issue when using the similar workflow and were not able to create hard links on mounted devices. They were able to overcome this as well. Check the link below. http://stackoverflow.com/questions/7719380/python-setup-py-sdist-error-operation-not-permitted Thanks! Santhosh -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Wednesday, October 30, 2013 3:48 PM To: Sebastien Goasguen Cc: dev@cloudstack.apache.org; Prasanna Santhanam Subject: Re: Issues deploying with marvin Never tried this with shared dir on vmware fusion but I expect the failure is outside marvin really as Will mentioned. I'm sure this would fail with vbox shared dirs as well. mvn is simply calling 'python setup.py sdist' when doing the build as the user who runs mvn. If that user has permissions to write to your shared-fusion dir, this should ideally have worked. On Wed, Oct 30, 2013 at 04:05:39AM -0400, Sebastien Goasguen wrote: I am adding Prasanna to the thread as he is the main Marvin developer -sebastien On Oct 29, 2013, at 1:02 PM, Will Stevens wstev...@cloudops.com mailto:wstev...@cloudops.com wrote: I believe the issues I am running into stem from the fact that the CS code is in a shared directory from my Mac to VMware Fusion. Because of this the 'ln' command is failing when building marvin... I may have to find a work around for this problem in order to build the developer profile. Will On Tue, Oct 29, 2013 at 11:59 AM, Will Stevens wstev...@cloudops.com mailto:wstev...@cloudops.comwrote: I will pull and make this change because apparently this has been in for a little while... I will update this if with more news when I have it. On Tue, Oct 29, 2013 at 11:57 AM, Will Stevens
Re: Review Request 15175: Added a verifyElementInList utility function
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28088 --- Just thinking aloud, could we not provide customized-assert for this rather than utility functions? I'm thinking something like: self.assertElementInList(a, [1,2,3], msg=a is not in list) - Prasanna Santhanam On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: Review Request 15175: Added a verifyElementInList utility function
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28089 --- Also your patch failed to apply for me on latest master: ~/workspace/cloudstack/incubator-cloudstack(branch:master) » git am patch/element.patch Applying: Added a verifyElementInList utility function /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:27: trailing whitespace. @Description: /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:33: trailing whitespace. at a given pos /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:34: trailing whitespace. @Input: /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:36: trailing whitespace. II : Element to verify whether it exists in the list error: patch failed: tools/marvin/marvin/codes.py:39 error: tools/marvin/marvin/codes.py: patch does not apply error: patch failed: tools/marvin/marvin/integration/lib/utils.py:353 error: tools/marvin/marvin/integration/lib/utils.py: patch does not apply Patch failed at 0001 Added a verifyElementInList utility function When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. - Prasanna Santhanam On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: [ANNOUNCE] New Committer: Nguyen Anh Tu
Well done Nguyen ! -Sebastien On 4 Nov 2013, at 09:33, Prasanna Santhanam t...@apache.org wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Nguyen Anh Tu to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Nguyen! -- Prasanna., on behalf of the Apache CloudStack PMC Powered by BigRock.com
Re: Review Request 15080: CLOUDSTACK-4855: Throttle based on the # of outstanding requests to the directly managed HV host (direct agents)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15080/#review28091 --- Commit 269a4ef11ee151fa408a7dd1f2e69cd1f7f05191 in branch refs/heads/master from Koushik Das [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=269a4ef ] CLOUDSTACK-4855: Throttle based on the # of outstanding requests to the directly managed HV host (direct agents) Cloudstack sends requests to directly managed HV hosts (direct agents) using the direct agent thread pool. The size of the pool is determined by global config direct.agent.pool.size defaulted to 500. Currently there is no restriction on the number of threads a direct agent can use from this shared thread pool to send requests to the host. This is fine as long as the host is responding to requests in a reasonable amount of time. But if there is a considerable delay in getting response, the thread remain blocked for that much time. As more commands are send to the slow host threads keep getting blocked. This can eventually lead to a situation where requests to healthy hosts cannot be processed as there are not enough free threads. The problem being addressed here is to localize the impact of few bad hosts, so that entire management server is not affected. One such way is to throttle based on the # of outstanding requests on per host basis. The outstanding requests to a host will be a % of direct agent pool size. This is configurable based on direct.agent.thread.cap. The default value is 0.1 or 10%, a value of 1 would mean the old behavior where there is no upper cap. This will ensure that the impacted host will be bound by a upper cap on the number of threads it can use to process requests and not the entire pool. - ASF Subversion and Git Services On Oct. 30, 2013, 10:51 a.m., Koushik Das wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15080/ --- (Updated Oct. 30, 2013, 10:51 a.m.) Review request for cloudstack, Alex Huang, Chiradeep Vittal, and Darren Shepherd. Bugs: CLOUDSTACK-4855 https://issues.apache.org/jira/browse/CLOUDSTACK-4855 Repository: cloudstack-git Description --- Cloudstack sends requests to directly managed HV hosts (direct agents) using the direct agent thread pool. The size of the pool is determined by global config direct.agent.pool.size defaulted to 500. Currently there is no restriction on the number of threads a direct agent can use from this shared thread pool to send requests to the host. This is fine as long as the host is responding to requests in a reasonable amount of time. But if there is a considerable delay in getting response, the thread remain blocked for that much time. As more commands are send to the slow host threads keep getting blocked. This can eventually lead to a situation where requests to healthy hosts cannot be processed as there are not enough free threads. The problem being addressed here is to localize the impact of few bad hosts, so that entire management server is not affected. One such way is to throttle based on the # of outstanding requests on per host basis. The outstanding requests to a host will be a % of direct agent pool size. This is configurable based on direct.agent.thread.cap. This will ensure that the impacted host will be bound by a upper cap on the number of threads it can use to process requests and not the entire pool. Note: The reason for checking the outstanding request count in the Task.run() method is to take into account cron jobs that gets scheduled at agent startup. Diffs - engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java ff35255 engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 3e684cc engine/orchestration/src/com/cloud/agent/manager/DirectAgentAttache.java 7d3f765 Diff: https://reviews.apache.org/r/15080/diff/ Testing --- Verified by tweaking the per agent upper cap to a value of 1 and checked that the requests are getting scheduled but the executor thread simply bails out. Thanks, Koushik Das
Re: Review Request 15175: Added a verifyElementInList utility function
On Nov. 4, 2013, 8:48 a.m., Prasanna Santhanam wrote: Also your patch failed to apply for me on latest master: ~/workspace/cloudstack/incubator-cloudstack(branch:master) » git am patch/element.patch Applying: Added a verifyElementInList utility function /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:27: trailing whitespace. @Description: /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:33: trailing whitespace. at a given pos /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:34: trailing whitespace. @Input: /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:36: trailing whitespace. II : Element to verify whether it exists in the list error: patch failed: tools/marvin/marvin/codes.py:39 error: tools/marvin/marvin/codes.py: patch does not apply error: patch failed: tools/marvin/marvin/integration/lib/utils.py:353 error: tools/marvin/marvin/integration/lib/utils.py: patch does not apply Patch failed at 0001 Added a verifyElementInList utility function When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. This patch already is applied to master and i could see it there, may be the status was not changed or not marked with ship it. - Santhosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28089 --- On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: [DISCUSS] port of sdn gateway to 4.2.1
H Chip, The scope in functional sense is small but not in kloc sense. I am going to have to do the backport anyway, because we (SBP) are going to run with it. It is not going to be a cherry-pick exercise is my experience in the past, so hence the question on the list. I have tested this in master and am running it in a patched 4.1.1. The question is If it is just Schuberg Philis running vpc gateways on SDN and there is no interest in this for the rest of the community, or is there. Also this is the final of a multistage patch that started out a long time ago. So with a favorable advocate this would be a 'fix' of the 4.2 code. I won't kill anybody over it; it's only a matter of principle, nothing more. I am not looking to change consensus unless we are going for quicker and smaller iterations;) regards, Daan On Mon, Nov 4, 2013 at 8:15 AM, Chip Childers chipchild...@apache.org wrote: On Sun, Nov 03, 2013 at 08:12:00PM +0100, Daan Hoogland wrote: H Abhinandan, At the moment a patch for pluging vpc private gateways is in master/4.3. At Schuberg Philis we have it running as a special in 4.1.1 as well. Is it alright to port this to the public branch of 4.2.1? otherwise we will (need to) make a private branch (again). regards, Daan The general consensus has been that minor releases are bug-fix only. Would you consider this that? Or is the scope of the patch itself small enough (and low risk enough) that we should do it anyway? Or... do we change our previous consensus?
Re: [ANNOUNCE] New Committer: Nguyen Anh Tu
welcome Nguyen. On Mon, Nov 4, 2013 at 10:02 AM, Sebastien Goasguen run...@gmail.com wrote: Well done Nguyen ! -Sebastien On 4 Nov 2013, at 09:33, Prasanna Santhanam t...@apache.org wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Nguyen Anh Tu to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Nguyen! -- Prasanna., on behalf of the Apache CloudStack PMC Powered by BigRock.com
Re: Review Request 15175: Added a verifyElementInList utility function
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28095 --- Ship it! Ship It! - Santhosh Edukulla On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/#review28094 --- api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java https://reviews.apache.org/r/15018/#comment54677 Why is this change required for CPU sockets? core/src/com/cloud/agent/api/StartupRoutingCommand.java https://reviews.apache.org/r/15018/#comment54678 Why Integer and not int? plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java https://reviews.apache.org/r/15018/#comment54679 Why Integer? Can this be null? server/src/com/cloud/api/query/QueryManagerImpl.java https://reviews.apache.org/r/15018/#comment54680 This change doesn't look related setup/db/db/schema-421to430.sql https://reviews.apache.org/r/15018/#comment54681 Simply drop and recreate the view - Koushik Das On Oct. 31, 2013, 10:14 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/ --- (Updated Oct. 31, 2013, 10:14 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4908 https://issues.apache.org/jira/browse/CLOUDSTACK-4908 Repository: cloudstack-git Description --- CLOUDSTACK-4908: CPU socket count of host Adding cpu socket count of the host in hostresponse Diffs - api/src/com/cloud/host/Host.java 17b0ba8 api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3 api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276 engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db engine/schema/src/com/cloud/host/HostVO.java c814b94 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15 server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249 server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9 server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193 setup/db/db/schema-421to430.sql 803f1d9 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3 Diff: https://reviews.apache.org/r/15018/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 14738: Testscript for DeployVM User data enhancement
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14738/#review28097 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Oct. 31, 2013, 1:11 a.m., suresh sadhu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14738/ --- (Updated Oct. 31, 2013, 1:11 a.m.) Review request for cloudstack, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri. Bugs: cloudstack-2272 https://issues.apache.org/jira/browse/cloudstack-2272 Repository: cloudstack-git Description --- This script validates VM-deployment with user-data of size more than 2048(which includes deployment as well as validation part after applying the user-data) Diffs - test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION Diff: https://reviews.apache.org/r/14738/diff/ Testing --- yes Thanks, suresh sadhu
Re: [ANNOUNCE] New Committer: Nguyen Anh Tu
Congrats Tuna :-) Cheers, Hugo On 4 nov. 2013, at 11:12, Daan Hoogland daan.hoogl...@gmail.com wrote: welcome Nguyen. On Mon, Nov 4, 2013 at 10:02 AM, Sebastien Goasguen run...@gmail.com wrote: Well done Nguyen ! -Sebastien On 4 Nov 2013, at 09:33, Prasanna Santhanam t...@apache.org wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Nguyen Anh Tu to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Nguyen! -- Prasanna., on behalf of the Apache CloudStack PMC Powered by BigRock.com
Re: [ANNOUNCE] New Committer: Nguyen Anh Tu
Congrats Nguyen! On 04-Nov-2013, at 5:42 PM, Hugo Trippaers h...@trippaers.nlmailto:h...@trippaers.nl wrote: Congrats Tuna :-) Cheers, Hugo On 4 nov. 2013, at 11:12, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: welcome Nguyen. On Mon, Nov 4, 2013 at 10:02 AM, Sebastien Goasguen run...@gmail.commailto:run...@gmail.com wrote: Well done Nguyen ! -Sebastien On 4 Nov 2013, at 09:33, Prasanna Santhanam t...@apache.orgmailto:t...@apache.org wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Nguyen Anh Tu to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Nguyen! -- Prasanna., on behalf of the Apache CloudStack PMC Powered by BigRock.comhttp://BigRock.com
RE: [Merge] hyperv branch to master
The changes have been merged to the master branch. Regards, Devdeep -Original Message- From: Devdeep Singh [mailto:devdeep.si...@citrix.com] Sent: Thursday, October 31, 2013 3:38 PM To: dev@cloudstack.apache.org Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar Subject: RE: [Merge] hyperv branch to master Thanks Darren. I'll start working on getting it merged into the master. I hope to finish it by Friday. Regards, Devdeep -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: Tuesday, October 29, 2013 10:45 PM To: dev@cloudstack.apache.org Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar Subject: Re: [Merge] hyperv branch to master +1 When you merge you will get a conflict in the spring configuration. componentContext.xml and others are gone now in master. You will need to update to the new style. The easiest will be to refer to XenServer spring config for an example of how to do it. You can largely copy and paste the contents of plugins/hypervisors/xen/resources/META-INF/cloudstack and replace xenserver with hyperv. You can also refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions for more in depth explaination of the changes. Darren On Tue, Oct 29, 2013 at 9:35 AM, David Nalley da...@gnsa.us wrote: On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh devdeep.si...@citrix.com wrote: Hi, I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4]. I know this has been discussed several times, but what was the decision about making the agent code live in its own repo? It's C#, might need to be signed to actually run easily on Windows, etc. --David
checkstyle
Hey,
Just added a very basic checkstyle configuration to maven. The configuration
file is in parents/checkstyle and it checks just a few very basic things, like
trailing whitespace and tabs where there should be spaces.
I’ve enabled it for a single plugin to just the impact on build time and the
amount of generated errors. Quite considerable, but i hope other parts of the
code are better ;-)
You can enable check style for your plugin by adding the following to your
build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a mandatory
part of the build process. Meaning a compile with not succeed when check style
reports errors.
Cheers,
Hugo
Re: checkstyle
I think it'd be fairly painful to make it mandatory - maybe see if we can set
that as a goal for 6 months out?
On Nov 4, 2013, at 6:29 AM, Hugo Trippaers
h...@trippaers.nlmailto:h...@trippaers.nl
wrote:
Hey,
Just added a very basic checkstyle configuration to maven. The configuration
file is in parents/checkstyle and it checks just a few very basic things, like
trailing whitespace and tabs where there should be spaces.
I’ve enabled it for a single plugin to just the impact on build time and the
amount of generated errors. Quite considerable, but i hope other parts of the
code are better ;-)
You can enable check style for your plugin by adding the following to your
build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a mandatory
part of the build process. Meaning a compile with not succeed when check style
reports errors.
Cheers,
Hugo
Stratosechttp://stratosec.co/ - Compliance as a Service
o: 415.315.9385
@johnlkinsellahttp://twitter.com/johnlkinsella
Re: Wiki issues: Redirect loop
What URL are you trying to hit? https://cwiki.apache.org/confluence/display/CLOUDSTACK/Home seems fine here in FF25, OSX Chrome 6.1 and Chrome 30... On Nov 3, 2013, at 3:31 PM, Ian Duffy i...@ianduffy.ie wrote: Hi, I'm unable to access the wiki. Chrome keeps reporting a redirect loop. Anybody know whats causing that? Thanks! Ian
Re: checkstyle
Hey John,
That would be my idea.
Make it mandatory for new (maven) projects coming into the code base and slowly
start working on fixing the existing projects. The current checkstyle setting
is very relaxed, just a few basic checks. Stuff that we could technically fix
with a few well written regular expressions even. Over time we can start
implementing parts of our code style in the checkstyle config, but that is long
term planning.
Cheers,
Hugo
On 4 nov. 2013, at 16:28, John Kinsella j...@stratosec.co wrote:
I think it'd be fairly painful to make it mandatory - maybe see if we can set
that as a goal for 6 months out?
On Nov 4, 2013, at 6:29 AM, Hugo Trippaers
h...@trippaers.nlmailto:h...@trippaers.nl
wrote:
Hey,
Just added a very basic checkstyle configuration to maven. The configuration
file is in parents/checkstyle and it checks just a few very basic things,
like trailing whitespace and tabs where there should be spaces.
I’ve enabled it for a single plugin to just the impact on build time and the
amount of generated errors. Quite considerable, but i hope other parts of the
code are better ;-)
You can enable check style for your plugin by adding the following to your
build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a
mandatory part of the build process. Meaning a compile with not succeed when
check style reports errors.
Cheers,
Hugo
Stratosechttp://stratosec.co/ - Compliance as a Service
o: 415.315.9385
@johnlkinsellahttp://twitter.com/johnlkinsella
Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/#review28107 --- Commit 5cc9b1de661f3189dcd1e3eb65d7e1d15c05e9e6 in branch refs/heads/4.2 from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cc9b1d ] CLOUDSTACK-3216 /var/log/cloud.log did not have a logrotate script, here is a basic one. - ASF Subversion and Git Services On July 27, 2013, 1:09 p.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/ --- (Updated July 27, 2013, 1:09 p.m.) Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and Hugo Trippaers. Bugs: 3216 https://issues.apache.org/jira/browse/3216 Repository: cloudstack-git Description --- Issue: == logrotate.conf and logrotate config files in logrotate.d folder are having x permission. hence logrotate daemon not able to use this config logrotate reports the error as /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d Ignoring apache2 because of bad file mode. reading config file apt reading config file aptitude reading config file conntrackd Ignoring dnsmasq because of bad file mode. reading config file dpkg Ignoring haproxy because of bad file mode. reading config file monit Ignoring ppp because of bad file mode. Ignoring rsyslog because of bad file mode. == Fix: === while generating the cloudscripts.tgz file, I had modified to include the logrotate.conf and logrotate config files under logrotate.d with 644 permission which will fix the issue. this is will fix the bad file mode error. Diffs - patches/pom.xml 00eec02 Diff: https://reviews.apache.org/r/12994/diff/ Testing --- 1. after generating new systemvm.iso tested the new router/ssvm/console proxy. logrotate -d -v /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d reading config file apache2 reading config file apt reading config file aptitude reading config file conntrackd reading config file dnsmasq reading config file dpkg reading config file haproxy reading config file monit reading config file ppp reading config file rsyslog 2. Verified after launching the VR, new instances are getting IP and hostname properly. Thanks, Rajesh Battala
Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/#review28106 --- Commit 70330f5cf32f4a0463edf5024cf841e0e678f423 in branch refs/heads/master from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=70330f5 ] CLOUDSTACK-3216 /var/log/cloud.log did not have a logrotate script, here is a basic one. - ASF Subversion and Git Services On July 27, 2013, 1:09 p.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/ --- (Updated July 27, 2013, 1:09 p.m.) Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and Hugo Trippaers. Bugs: 3216 https://issues.apache.org/jira/browse/3216 Repository: cloudstack-git Description --- Issue: == logrotate.conf and logrotate config files in logrotate.d folder are having x permission. hence logrotate daemon not able to use this config logrotate reports the error as /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d Ignoring apache2 because of bad file mode. reading config file apt reading config file aptitude reading config file conntrackd Ignoring dnsmasq because of bad file mode. reading config file dpkg Ignoring haproxy because of bad file mode. reading config file monit Ignoring ppp because of bad file mode. Ignoring rsyslog because of bad file mode. == Fix: === while generating the cloudscripts.tgz file, I had modified to include the logrotate.conf and logrotate config files under logrotate.d with 644 permission which will fix the issue. this is will fix the bad file mode error. Diffs - patches/pom.xml 00eec02 Diff: https://reviews.apache.org/r/12994/diff/ Testing --- 1. after generating new systemvm.iso tested the new router/ssvm/console proxy. logrotate -d -v /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d reading config file apache2 reading config file apt reading config file aptitude reading config file conntrackd reading config file dnsmasq reading config file dpkg reading config file haproxy reading config file monit reading config file ppp reading config file rsyslog 2. Verified after launching the VR, new instances are getting IP and hostname properly. Thanks, Rajesh Battala
Re: checkstyle
On Mon, Nov 04, 2013 at 04:33:07PM +0100, Hugo Trippaers wrote: Hey John, That would be my idea. Make it mandatory for new (maven) projects coming into the code base and slowly start working on fixing the existing projects. The current checkstyle setting is very relaxed, just a few basic checks. Stuff that we could technically fix with a few well written regular expressions even. Over time we can start implementing parts of our code style in the checkstyle config, but that is long term planning. Cheers, Hugo We've had people correct the whitespace issues in bulk previously, but then someone does a merge and it goes to hell again. I'd actually be +1 on a quick fix of the code, then the enforcement of the rules. That is... only for the things that can be easily regex-fixed. -chip
Re: [Merge] Palo Alto Networks firewall integration to master
On Mon, Nov 04, 2013 at 10:49:29AM -0500, Will Stevens wrote: Anything I can do to help get this patch into 4.3.0? Thanks, Will If it's in master, it'll be in 4.3... so help by testing during the 4.3 test cycle! -chip
Re: [Merge] Palo Alto Networks firewall integration to master
Anything I can do to help get this patch into 4.3.0? Thanks, Will On Fri, Nov 1, 2013 at 2:47 PM, Sheng Yang sh...@yasker.org wrote: Nice work Will! I've checked the code, it included the UI part and unit test as well. Really impressed! Just one comment: you can git-format-patch to generate the patch. It would includes author and description information automatically, which is easier for applying. +1! --Sheng On Thu, Oct 31, 2013 at 1:50 PM, Will Stevens wstev...@cloudops.com wrote: Hi, I would like to merge support for Palo Alto Network's firewall appliances to the master branch. Development for this has been done by Will Stevens at CloudOps on branch [1]. There was an introduction [2], a proposal [3], and a discussion [4] on the mailing list regarding this feature. Checklist: Jira ticket for the feature is here [5]. The FS can be found at [6]. Unit tests for the feature are available at [7] and [8]. I have developed the unit tests with a flag to output additional detail in the console [9]. Here is the result of the tests without detail [10] and here is the result of the tests with detail [11]. This plugin communicates to the Palo Alto Networks firewall appliances through an API documented at [12] with a training manual [13]. This plugin depends on a modification to core to remove a limitation which was discussed here [14], with this jira issue [15] and has been approved here [16]. This plugin is being reviewed at [17] according to this patch [18]. There are no 3rd party libraries needed for this plugin, however it does depend on a 3rd party API [12][13] to orchestrate the configuration on the appliance. The plugin is currently being built via the 'nonoss' flag. It should be moved into either the 'noredist' or core because it appears that 'nonoss' will be going away [19] and 'noredist' has been merged [20]. I would appreciate input on which build this should be put into given its interaction with an 3rd party appliance. Here are the slides for a presentation [21] given about this integration at the CloudStack Collaboration Conference in Santa Clara, CA. [1] https://github.com/cloudops/cs_palo_alto/tree/palo_alto [2] http://markmail.org/message/hukydzwkec3dwuxq?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto [3] http://markmail.org/message/odbg2icft7esj3ut?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto [4] http://markmail.org/message/n5276i4hfh7ek57o?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto [5] https://issues.apache.org/jira/browse/CLOUDSTACK-1275 [6] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration [7] https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java [8] https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java [9] https://github.com/cloudops/cs_palo_alto/blob/palo_alto/plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java#L156 [10] https://cwiki.apache.org/confluence/download/attachments/30753712/palo_alto_tests_without_logging.txt?version=1modificationDate=1383248404474 [11] https://cwiki.apache.org/confluence/download/attachments/30753712/palo_alto_tests_with_logging.txt?version=1modificationDate=1383248432061 [12] https://cwiki.apache.org/confluence/download/attachments/30753712/XML-API-5-1.0-RevA.pdf?version=1modificationDate=1366305634000 [13] https://cwiki.apache.org/confluence/download/attachments/30753712/XML_API_Training.pdf?version=1modificationDate=1366305635000 [14] http://markmail.org/message/374hyn7ko6zrb2cf?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+supported+source+nat+types [15] https://issues.apache.org/jira/browse/CLOUDSTACK-4991 [16] https://reviews.apache.org/r/15047/ [17] https://reviews.apache.org/r/15050/ [18] https://reviews.apache.org/r/15050/diff/ [19] http://markmail.org/message/37qcg4lgudmf57ws?q=DISCUSS%5D+rename+nonoss+to+noredist [20] http://markmail.org/message/zqkiuod5qabcyra6?q=%5BMERGE%5D+changing+nonoss+to+noredist [21] https://cwiki.apache.org/confluence/download/attachments/30753712/CS_PA_Integration.pptx?version=1modificationDate=1383250830719 Cheers, Will
Re: [Merge] Palo Alto Networks firewall integration to master
Well its not in master yet. That is the intent of this thread... I can definitely do some testing for the 4.3 test cycle. Will On Mon, Nov 4, 2013 at 10:56 AM, Chip Childers chipchild...@apache.orgwrote: On Mon, Nov 04, 2013 at 10:49:29AM -0500, Will Stevens wrote: Anything I can do to help get this patch into 4.3.0? Thanks, Will If it's in master, it'll be in 4.3... so help by testing during the 4.3 test cycle! -chip
Re: [Merge] Palo Alto Networks firewall integration to master
On Mon, Nov 04, 2013 at 10:59:30AM -0500, Will Stevens wrote: Well its not in master yet. That is the intent of this thread... I can definitely do some testing for the 4.3 test cycle. Will Shoot, I misread Sheng's email. Sorry about that. I thought he said that he Checked *in* the code, not Checked out. Duh... my bad. Sheng, as the reviewer, want to handle the commit?
[DISCUSS] Add 'Other' category to gen_toc.py for apidoc
I would like to be able to leverage the existing apidoc tools to generate apidoc for my plugin’s exposed APIs. However, gen_toc.py expects all APIs to fall into one of the hard coded ‘known_categories’. Since my APIs don’t fall into one of the existing categories, gen_toc.py fails with the error: Exception: Need to add a category for my api to gen_toc.py:known_categories What are people’s thoughts on adding a category called ‘Other’ for APIs which do not fall into one of the hard coded categories? I’ve tested this locally by adding the following to gen_toc.py: To the end of the known_categories hash: 'Other' : ‘Other’ At end end of choose_category(fn): return known_categories['Other’] I think there is a lot to be done with the apidoc tools moving forward to allow third party plugins to use the tools, but this would be a quick fix that would at least make the tools usable for now. -Chris -- Chris Suich chris.su...@netapp.commailto:chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat
Review Request 15208: Added bug fix for 5032
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/ --- Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Added custom assertElementInList to cloudstackTestCase, this will help users to simplify their asserts. Allows custom message to be dumped for assert Diffs - tools/marvin/marvin/cloudstackTestCase.py 85ef542 tools/marvin/marvin/integration/lib/utils.py d53c1ae Diff: https://reviews.apache.org/r/15208/diff/ Testing --- Thanks, Santhosh Edukulla
Re: [DISCUSS] Add 'Other' category to gen_toc.py for apidoc
On Mon, Nov 04, 2013 at 04:19:12PM +, SuichII, Christopher wrote: I would like to be able to leverage the existing apidoc tools to generate apidoc for my plugin’s exposed APIs. However, gen_toc.py expects all APIs to fall into one of the hard coded ‘known_categories’. Since my APIs don’t fall into one of the existing categories, gen_toc.py fails with the error: Exception: Need to add a category for my api to gen_toc.py:known_categories What are people’s thoughts on adding a category called ‘Other’ for APIs which do not fall into one of the hard coded categories? I’ve tested this locally by adding the following to gen_toc.py: To the end of the known_categories hash: 'Other' : ‘Other’ At end end of choose_category(fn): return known_categories['Other’] I think there is a lot to be done with the apidoc tools moving forward to allow third party plugins to use the tools, but this would be a quick fix that would at least make the tools usable for now. -Chris I've not been a fan of that particular configuration file personally. IMO, if that works, then great. We should revisit removing that config file requirement altogether though. -chip
Link between a snapshot and it's filename on disk
Hello, I'm don't seem to be able to match a snapshot from the UI with the file on disk in the secondary storage. I managed to find it by looking at timestamps, but otherwise there is no apparent (to me) link. Can anyone advise how I could find a snapshot's file on disk? For example I have a snapshot with name detached_fff_20131104155235 and ID bf08aea6-20d0-445f-b9e7-1039cea8d0a2. In the secondary storage the coresponding filename on disk is 622ddb9e-86f8-4040-883b-955f3cfdb936.vhd (found by timestamp match).. to me it wuld have made sense to have the filename match the ID. Pointers? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
Re: Link between a snapshot and it's filename on disk
On 04.11.2013 16:30, Nux! wrote: Hello, I'm don't seem to be able to match a snapshot from the UI with the file on disk in the secondary storage. I managed to find it by looking at timestamps, but otherwise there is no apparent (to me) link. Can anyone advise how I could find a snapshot's file on disk? For example I have a snapshot with name detached_fff_20131104155235 and ID bf08aea6-20d0-445f-b9e7-1039cea8d0a2. In the secondary storage the coresponding filename on disk is 622ddb9e-86f8-4040-883b-955f3cfdb936.vhd (found by timestamp match).. to me it wuld have made sense to have the filename match the ID. Pointers? Lucian BTW, this is related to https://issues.apache.org/jira/browse/CLOUDSTACK-5035 I was advising Diogo to run qemu-img info on the file, if he could find it. :) Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
Re: Review Request 15208: Added bug fix for 5032
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/#review28116 --- I assume you mean to say that this pertains to jira issue CLOUDSTACK-5032!?! can you put that in the bugs field and make the tile more descriptive? Thanks - daan Hoogland On Nov. 4, 2013, 4:24 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/ --- (Updated Nov. 4, 2013, 4:24 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Added custom assertElementInList to cloudstackTestCase, this will help users to simplify their asserts. Allows custom message to be dumped for assert Diffs - tools/marvin/marvin/cloudstackTestCase.py 85ef542 tools/marvin/marvin/integration/lib/utils.py d53c1ae Diff: https://reviews.apache.org/r/15208/diff/ Testing --- Thanks, Santhosh Edukulla
Coverity static code analysis
Hey all, At CloudOpen in Edinburgh i joined a presentation on Coverity, a static code analysis tool. Some of you may have heard of it already, it is famous for doing the code analysis on the Linux kernel for quite some years already. They added support for the java language quite a while back. The presenter dropped by our CloudStack booth and we had a nice chat on static code analysis. You might have guessed the next step, i added CloudStack to the Coverity scanning service at scan.coverity.com: http://scan.coverity.com/projects/943. - 1.044.609 lines of code - 6.70 defect density - 6997 outstanding defects The reasoning is obviously that anything that will help us improve quality should be considered. However just adding the CloudStack sources to the scan isn’t going to solve anything. For that we all need to pitch in an help out with getting the scan results triaged, assigned and fixed. So signup en-masse and go fix ;-) Note to new and aspiring CloudStack developers, don’t know where to start but you want to help out? This is a great way to get to know the code and the community. Have a look at one of the open items on Coverity, fix it and submit it for review at reviews.apache.org. Cheers, Hugo
RE: checkstyle
How does it compare to previous versions for CloudStack? E.g.
http://markmail.org/message/yz6qa2v47cdeic4d
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: 04 November 2013 14:30
To: dev@cloudstack.apache.org
Subject: checkstyle
Hey,
Just added a very basic checkstyle configuration to maven. The configuration
file is in parents/checkstyle and it checks just a few very basic things, like
trailing whitespace and tabs where there should be spaces.
I've enabled it for a single plugin to just the impact on build time and the
amount of generated errors. Quite considerable, but i hope other parts of
the code are better ;-)
You can enable check style for your plugin by adding the following to your
build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a
mandatory part of the build process. Meaning a compile with not succeed
when check style reports errors.
Cheers,
Hugo
Re: checkstyle
On Nov 4, 2013, at 7:54 AM, Chip Childers chipchild...@apache.org wrote: On Mon, Nov 04, 2013 at 04:33:07PM +0100, Hugo Trippaers wrote: Hey John, That would be my idea. Make it mandatory for new (maven) projects coming into the code base and slowly start working on fixing the existing projects. The current checkstyle setting is very relaxed, just a few basic checks. Stuff that we could technically fix with a few well written regular expressions even. Over time we can start implementing parts of our code style in the checkstyle config, but that is long term planning. Cheers, Hugo We've had people correct the whitespace issues in bulk previously, but then someone does a merge and it goes to hell again. I'd actually be +1 on a quick fix of the code, then the enforcement of the rules. That is... only for the things that can be easily regex-fixed. Makes sense I guess, +1 from me too. Only thing that's really nails-on-chalkboard to me is fixing formatting and code changes in the same commit, but I haven't seen that in ACS…
Not able to view the console of the VM. Getting Timeout error
Hi, I wanted to know the flow of the request to connect to a particular provisioned VM. Is it the following? My local browser - Console Proxy VM - Host -Provisioned VM I have done setup of the cloudstack but on clicking on view console, I am getting timeout error. Some pointers would really be helpful. Thanks, Jitendra
Re: [New Feature FS] SSL Offload Support for Cloudstack
Hi All, I would like to get this code into 4.3. Is it possible for this to be reviewed? Is there anything needed from my side? I would be glad to provide more information. Thanks, -Syed On Wed 30 Oct 2013 03:25:12 PM EDT, Syed Ahmed wrote: Hi All, I have the patch for adding SSL termination support at https://reviews.apache.org/r/14976/ . It would be great if this can be reviewed. Thanks, -Syed On 13-10-15 03:01 AM, Murali Reddy wrote: On 11/10/13 9:31 PM, Syed Ahmed sah...@cloudops.com wrote: Thanks for your valuable feedback Murali. Here are my comments. IMO, its better we introduce new api's say registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalancer than force fit existing API's for associate/dis-associate certificates. Personally, I was going to do it this way. But I am not sure how good of an idea it is to add a new api just for this feature as I can see assignToLoadbalancer is semantically similar. But if everyone agrees I have no problem with it. CloudStack already has distinct API's for each of the LB sub-functionality (health check, stickiness etc) [1]. We are not adding any redundant API, so resulting API are much cleaner just managing SSL termination for a LB rule. On second thought may be an CloudStack usage event on assigning certificate seems good enough to me. So what I got from your earlier post was that when adding a network offering the provider can choose to enable SSL Termination or not as it is a value added service. I was thinking of adding SSL termination under supportedservices for the createNetworkOffering API call. And when someone calls the API to assign a cert to LB we can check if this network offering has SSL termination enabled. Does this make sense? So there is notion of network service and network service capability [2]. I would attribute 'SSL termination' as capability of LB service. createNetworkOffering API take a capability list. It does make sense to check if the network offering has SSL termination enabled when API to assign a cert to LB is called. Also note that, 'Network Elements' declare their capabilities for the supported services. So it can verified that service provider for LB actually supports 'SSL termination' capability while creating network offering. Also when you say usage event, what does this imply? I am sorry I am not familiar with that term. Can you please elaborate. Its an event generated and persisted in the DB for every resource consumption and release. These events are used for billing etc. Please check publishUsageEvent calls in the code. [1] http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_User.html [2] api/src/com/cloud/network/Network.java
Re: Coverity static code analysis
On Nov 4, 2013, at 11:39 AM, Hugo Trippaers h...@trippaers.nl wrote: Hey all, At CloudOpen in Edinburgh i joined a presentation on Coverity, a static code analysis tool. Some of you may have heard of it already, it is famous for doing the code analysis on the Linux kernel for quite some years already. They added support for the java language quite a while back. The presenter dropped by our CloudStack booth and we had a nice chat on static code analysis. You might have guessed the next step, i added CloudStack to the Coverity scanning service at scan.coverity.com: http://scan.coverity.com/projects/943. - 1.044.609 lines of code why does Ohloh lists 4.2 M loc when coverty only 1M ? - 6.70 defect density - 6997 outstanding defects The reasoning is obviously that anything that will help us improve quality should be considered. However just adding the CloudStack sources to the scan isn’t going to solve anything. For that we all need to pitch in an help out with getting the scan results triaged, assigned and fixed. So signup en-masse and go fix ;-) Note to new and aspiring CloudStack developers, don’t know where to start but you want to help out? This is a great way to get to know the code and the community. Have a look at one of the open items on Coverity, fix it and submit it for review at reviews.apache.org. Cheers, Hugo
Re: checkstyle
The search-fu is weak in this one..
Did you ever get to commit that file Donal? I’d be very much interested :-)
Cheers,
Hugo
On 4 nov. 2013, at 17:48, Donal Lafferty donal.laffe...@citrix.com wrote:
How does it compare to previous versions for CloudStack? E.g.
http://markmail.org/message/yz6qa2v47cdeic4d
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: 04 November 2013 14:30
To: dev@cloudstack.apache.org
Subject: checkstyle
Hey,
Just added a very basic checkstyle configuration to maven. The configuration
file is in parents/checkstyle and it checks just a few very basic things,
like
trailing whitespace and tabs where there should be spaces.
I've enabled it for a single plugin to just the impact on build time and the
amount of generated errors. Quite considerable, but i hope other parts of
the code are better ;-)
You can enable check style for your plugin by adding the following to your
build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a
mandatory part of the build process. Meaning a compile with not succeed
when check style reports errors.
Cheers,
Hugo
Re: [DISCUSS] Add 'Other' category to gen_toc.py for apidoc
Agreed. I’m not a fan of how this is working right now, but this late in the cycle I think trying to rework all of this is a scary idea. It would be a good thing to look for post-4.3. -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat On Nov 4, 2013, at 11:29 AM, Chip Childers chipchild...@apache.org wrote: On Mon, Nov 04, 2013 at 04:19:12PM +, SuichII, Christopher wrote: I would like to be able to leverage the existing apidoc tools to generate apidoc for my plugin’s exposed APIs. However, gen_toc.py expects all APIs to fall into one of the hard coded ‘known_categories’. Since my APIs don’t fall into one of the existing categories, gen_toc.py fails with the error: Exception: Need to add a category for my api to gen_toc.py:known_categories What are people’s thoughts on adding a category called ‘Other’ for APIs which do not fall into one of the hard coded categories? I’ve tested this locally by adding the following to gen_toc.py: To the end of the known_categories hash: 'Other' : ‘Other’ At end end of choose_category(fn): return known_categories['Other’] I think there is a lot to be done with the apidoc tools moving forward to allow third party plugins to use the tools, but this would be a quick fix that would at least make the tools usable for now. -Chris I've not been a fan of that particular configuration file personally. IMO, if that works, then great. We should revisit removing that config file requirement altogether though. -chip
RE: checkstyle
I'm not a committer, so it was easiest to post a rules file on the cwiki
There's a link from the blog post
http://dlafferty.blogspot.co.uk/2013/07/apache-cloudstack-java-coding.html
Direct link:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Developer+Tools
;)
DL
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: 04 November 2013 16:54
To: dev@cloudstack.apache.org
Subject: Re: checkstyle
The search-fu is weak in this one..
Did you ever get to commit that file Donal? I'd be very much interested :-)
Cheers,
Hugo
On 4 nov. 2013, at 17:48, Donal Lafferty donal.laffe...@citrix.com wrote:
How does it compare to previous versions for CloudStack? E.g.
http://markmail.org/message/yz6qa2v47cdeic4d
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: 04 November 2013 14:30
To: dev@cloudstack.apache.org
Subject: checkstyle
Hey,
Just added a very basic checkstyle configuration to maven. The
configuration file is in parents/checkstyle and it checks just a few
very basic things, like trailing whitespace and tabs where there should be
spaces.
I've enabled it for a single plugin to just the impact on build time
and the amount of generated errors. Quite considerable, but i hope
other parts of the code are better ;-)
You can enable check style for your plugin by adding the following to
your build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a
mandatory part of the build process. Meaning a compile with not
succeed when check style reports errors.
Cheers,
Hugo
Re: Coverity static code analysis
I'll guess Coverity counts executable lines. LOC can be a little tricky to calculate…comments, whitespace, things like include statements usually don't count (from a licensing POV). John On Nov 4, 2013, at 8:55 AM, Sebastien Goasguen run...@gmail.commailto:run...@gmail.com wrote: On Nov 4, 2013, at 11:39 AM, Hugo Trippaers h...@trippaers.nlmailto:h...@trippaers.nl wrote: Hey all, At CloudOpen in Edinburgh i joined a presentation on Coverity, a static code analysis tool. Some of you may have heard of it already, it is famous for doing the code analysis on the Linux kernel for quite some years already. They added support for the java language quite a while back. The presenter dropped by our CloudStack booth and we had a nice chat on static code analysis. You might have guessed the next step, i added CloudStack to the Coverity scanning service at scan.coverity.comhttp://scan.coverity.com: http://scan.coverity.com/projects/943. - 1.044.609 lines of code why does Ohloh lists 4.2 M loc when coverty only 1M ? - 6.70 defect density - 6997 outstanding defects The reasoning is obviously that anything that will help us improve quality should be considered. However just adding the CloudStack sources to the scan isn’t going to solve anything. For that we all need to pitch in an help out with getting the scan results triaged, assigned and fixed. So signup en-masse and go fix ;-) Note to new and aspiring CloudStack developers, don’t know where to start but you want to help out? This is a great way to get to know the code and the community. Have a look at one of the open items on Coverity, fix it and submit it for review at reviews.apache.orghttp://reviews.apache.org. Cheers, Hugo Stratosechttp://stratosec.co/ - Compliance as a Service o: 415.315.9385 @johnlkinsellahttp://twitter.com/johnlkinsella
Re: Review Request 15208: Added fix for bug 5032. Provides custom assert facility to test features. Added the new assert to cloudstackTestCase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/ --- (Updated Nov. 4, 2013, 5:22 p.m.) Review request for cloudstack and Prasanna Santhanam. Summary (updated) - Added fix for bug 5032. Provides custom assert facility to test features. Added the new assert to cloudstackTestCase Bugs: CLOUDSTACK-5032 https://issues.apache.org/jira/browse/CLOUDSTACK-5032 Repository: cloudstack-git Description (updated) --- Added custom assert by name assertElementInList to cloudstackTestCase, this will help users to simplify their asserts. Allows users to dump custom message for these asserts. Changed the Interface for verifyElementInList to take additional argument. Diffs - tools/marvin/marvin/cloudstackTestCase.py 85ef542 tools/marvin/marvin/integration/lib/utils.py d53c1ae Diff: https://reviews.apache.org/r/15208/diff/ Testing --- Thanks, Santhosh Edukulla
Re: checkstyle
Hi,
It is great to have a code standard, it is even better when it is
maintained, but when checkstyle reports error after several minutes
building the code, while the code should be ok and it reports an issue as
important as a trailing white space, then I believe anyone would more
likely call it a pain in the A than a useful tool.
What about a non-enforcing configuration, or activation only in a profile?
And then jenkins could send the usual error messages when it breaks, and we
can fix it later.
On Mon, Nov 4, 2013 at 4:33 PM, Hugo Trippaers h...@trippaers.nl wrote:
Hey John,
That would be my idea.
Make it mandatory for new (maven) projects coming into the code base and
slowly start working on fixing the existing projects. The current
checkstyle setting is very relaxed, just a few basic checks. Stuff that we
could technically fix with a few well written regular expressions even.
Over time we can start implementing parts of our code style in the
checkstyle config, but that is long term planning.
Cheers,
Hugo
On 4 nov. 2013, at 16:28, John Kinsella j...@stratosec.co wrote:
I think it'd be fairly painful to make it mandatory - maybe see if we
can set that as a goal for 6 months out?
On Nov 4, 2013, at 6:29 AM, Hugo Trippaers h...@trippaers.nlmailto:
h...@trippaers.nl
wrote:
Hey,
Just added a very basic checkstyle configuration to maven. The
configuration file is in parents/checkstyle and it checks just a few very
basic things, like trailing whitespace and tabs where there should be
spaces.
I’ve enabled it for a single plugin to just the impact on build time and
the amount of generated errors. Quite considerable, but i hope other parts
of the code are better ;-)
You can enable check style for your plugin by adding the following to
your build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this a
mandatory part of the build process. Meaning a compile with not succeed
when check style reports errors.
Cheers,
Hugo
Stratosechttp://stratosec.co/ - Compliance as a Service
o: 415.315.9385
@johnlkinsellahttp://twitter.com/johnlkinsella
--
EOF
RE: checkstyle
Hi Laszlo,
Try building only the maven project you've modified. That will identify
problems with your code much more quickly.
If formatting is a specific problem, launch checkstyle directly: there's a
plugin for Eclipse (see
http://dlafferty.blogspot.co.uk/2013/07/apache-cloudstack-java-coding.html)
DL
-Original Message-
From: Laszlo Hornyak [mailto:laszlo.horn...@gmail.com]
Sent: 04 November 2013 17:49
To: dev@cloudstack.apache.org
Subject: Re: checkstyle
Hi,
It is great to have a code standard, it is even better when it is maintained,
but
when checkstyle reports error after several minutes building the code, while
the code should be ok and it reports an issue as important as a trailing white
space, then I believe anyone would more likely call it a pain in the A than a
useful tool.
What about a non-enforcing configuration, or activation only in a profile?
And then jenkins could send the usual error messages when it breaks, and
we can fix it later.
On Mon, Nov 4, 2013 at 4:33 PM, Hugo Trippaers h...@trippaers.nl wrote:
Hey John,
That would be my idea.
Make it mandatory for new (maven) projects coming into the code base
and slowly start working on fixing the existing projects. The current
checkstyle setting is very relaxed, just a few basic checks. Stuff
that we could technically fix with a few well written regular expressions
even.
Over time we can start implementing parts of our code style in the
checkstyle config, but that is long term planning.
Cheers,
Hugo
On 4 nov. 2013, at 16:28, John Kinsella j...@stratosec.co wrote:
I think it'd be fairly painful to make it mandatory - maybe see if
we
can set that as a goal for 6 months out?
On Nov 4, 2013, at 6:29 AM, Hugo Trippaers h...@trippaers.nlmailto:
h...@trippaers.nl
wrote:
Hey,
Just added a very basic checkstyle configuration to maven. The
configuration file is in parents/checkstyle and it checks just a few
very basic things, like trailing whitespace and tabs where there
should be spaces.
I've enabled it for a single plugin to just the impact on build time
and
the amount of generated errors. Quite considerable, but i hope other
parts of the code are better ;-)
You can enable check style for your plugin by adding the following
to
your build plugins config in maven:
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-checkstyle-plugin/artifactId
version${cs.checkstyle.version}/version
dependencies
dependency
groupIdorg.apache.cloudstack/groupId
artifactIdcheckstyle/artifactId
version0.0.1-SNAPSHOT/version
/dependency
/dependencies
executions
execution
phaseprocess-sources/phase
goals
goalcheck/goal
/goals
/execution
/executions
configuration
failsOnErrortrue/failsOnError
configLocationtooling/checkstyle.xml/configLocation
consoleOutputtrue/consoleOutput
includeTestSourceDirectorytrue/includeTestSourceDirectory
sourceDirectory${project.basedir}/sourceDirectory
includes**\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat/includes
excludes**\/target\/,**\/bin\//excludes
/configuration
/plugin
For now its voluntary, but i would like your opinion on making this
a
mandatory part of the build process. Meaning a compile with not
succeed when check style reports errors.
Cheers,
Hugo
Stratosechttp://stratosec.co/ - Compliance as a Service
o: 415.315.9385
@johnlkinsellahttp://twitter.com/johnlkinsella
--
EOF
Re: haPlanners error in fresh 4.2 checkout
I still have this issue Any update on this? Thanks Alex Ough On Fri, Nov 1, 2013 at 4:41 AM, sebgoa run...@gmail.com wrote: I deleted my local 4.2 branch and did a brand new checkout, same result. latest 4.2 does not work for me -same error as below - On Oct 31, 2013, at 8:34 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: I too faced this issue today. Is there any resolution for this? Thanks, ~Talluri On 31/10/13 2:35 pm, sebgoa run...@gmail.com wrote: On Oct 29, 2013, at 7:56 PM, Nitin Mehta nitin.me...@citrix.com wrote: Yeah, that should have cleaned the workspace. Did you see what Prachi recommended below ? Yes and it's there. I do a fresh 4.2 checkout it compiles fine with: mvn -Pdeveloper -Dsimulator -DskipTests clean install But when I run with: mvn -pl client jetty:run I get this: 2013-10-31 10:01:31.403:INFO::Started SelectChannelConnector@0.0.0.0:8080 [INFO] Started Jetty Server Exception in thread Timer-2 org.springframework.beans.factory.BeanExpressionException: Expression parsing failed; nested exception is org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object of type 'org.springframework.beans.factory.config.BeanExpressionContext' at org.springframework.context.expression.StandardBeanExpressionResolver.eval uate(StandardBeanExpressionResolver.java:142) at org.springframework.beans.factory.support.AbstractBeanFactory.evaluateBean DefinitionString(AbstractBeanFactory.java:1299) at org.springframework.beans.factory.support.BeanDefinitionValueResolver.eval uate(BeanDefinitionValueResolver.java:210) at org.springframework.beans.factory.support.BeanDefinitionValueResolver.reso lveValueIfNecessary(BeanDefinitionValueResolver.java:182) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto ry.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto ry.populateBean(AbstractAutowireCapableBeanFactory.java:1118) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFacto ry.configureBean(AbstractAutowireCapableBeanFactory.java:314) at com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Compone ntContext.java:71) at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:54) at java.util.TimerThread.mainLoop(Timer.java:555) at java.util.TimerThread.run(Timer.java:505) Caused by: org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object of type 'org.springframework.beans.factory.config.BeanExpressionContext' at org.springframework.expression.spel.ast.PropertyOrFieldReference.readPrope rty(PropertyOrFieldReference.java:208) at org.springframework.expression.spel.ast.PropertyOrFieldReference.getValueI nternal(PropertyOrFieldReference.java:72) at org.springframework.expression.spel.ast.CompoundExpression.getValueInterna l(CompoundExpression.java:52) at org.springframework.expression.spel.ast.SpelNodeImpl.getValue(SpelNodeImpl .java:93) at org.springframework.expression.spel.standard.SpelExpression.getValue(SpelE xpression.java:88) at org.springframework.context.expression.StandardBeanExpressionResolver.eval uate(StandardBeanExpressionResolver.java:139) ... 10 more ERROR [cloud.api.ApiServlet] (770998563@qtp-534473248-6:) unknown exception writing api response java.lang.NullPointerException at com.cloud.api.ApiServer.loginUser(ApiServer.java:770) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:211) at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71) at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216 ) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCo llection.java:230) at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java: 114) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at
Re: Not able to view the console of the VM. Getting Timeout error
Hi Jitendra, Have you tried restarting your Console Proxy System VM? If so, and you still have issues - please bring up your management log and try the steps again, hopefully you will receive an informative error (just post it here for more assistance). Marty On Mon, Nov 4, 2013 at 4:45 PM, jitendra shelar jitendra.shelar...@gmail.com wrote: Hi, I wanted to know the flow of the request to connect to a particular provisioned VM. Is it the following? My local browser - Console Proxy VM - Host -Provisioned VM I have done setup of the cloudstack but on clicking on view console, I am getting timeout error. Some pointers would really be helpful. Thanks, Jitendra
Re: Link between a snapshot and it's filename on disk
You can also look up the path in the database if required, Marty On Mon, Nov 4, 2013 at 4:35 PM, Nux! n...@li.nux.ro wrote: On 04.11.2013 16:30, Nux! wrote: Hello, I'm don't seem to be able to match a snapshot from the UI with the file on disk in the secondary storage. I managed to find it by looking at timestamps, but otherwise there is no apparent (to me) link. Can anyone advise how I could find a snapshot's file on disk? For example I have a snapshot with name detached_fff_20131104155235 and ID bf08aea6-20d0-445f-b9e7-1039cea8d0a2. In the secondary storage the coresponding filename on disk is 622ddb9e-86f8-4040-883b-955f3cfdb936.vhd (found by timestamp match).. to me it wuld have made sense to have the filename match the ID. Pointers? Lucian BTW, this is related to https://issues.apache.org/ jira/browse/CLOUDSTACK-5035 I was advising Diogo to run qemu-img info on the file, if he could find it. :) Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
DevCloud Error
Hi, I feel like I may have missed an e-mail related to this error, but can't seem to locate it in my e-mail. Anyone know why I get this error when running the following: cd documents/cloudstack/src/cloudstack/tools/devcloud ; python ../marvin/marvin/deployDataCenter.py -i devcloud.cfg Traceback (most recent call last): File ../marvin/marvin/deployDataCenter.py, line 19, in module import configGenerator File /Users/mtutkowski/Documents/CloudStack/src/CloudStack/tools/marvin/marvin/configGenerator.py, line 22, in module from marvin.codes import * ImportError: No module named codes Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: DevCloud Error
Here was the last from the thread you're thinking of, no resolution follow up, so I don't know if it fixed things previously: Hi Min, 1/ I just pulled the latest code from master and used marvin, it went fine. Are you still facing this issue? Make sure your local setup is clean and marvin installed with latest pull. 2/ It seems you don't have codes.py file available under python/site-packages/.../marvin folder? Ideally it will get installed when you run your build. If its still an issue, run python setup.py install from tools/marvin/ folder and see if it works around. Thanks! Santhosh On Nov 4, 2013, at 3:27 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I feel like I may have missed an e-mail related to this error, but can't seem to locate it in my e-mail. Anyone know why I get this error when running the following: cd documents/cloudstack/src/cloudstack/tools/devcloud ; python ../marvin/marvin/deployDataCenter.py -i devcloud.cfg Traceback (most recent call last): File ../marvin/marvin/deployDataCenter.py, line 19, in module import configGenerator File /Users/mtutkowski/Documents/CloudStack/src/CloudStack/tools/marvin/marvin/configGenerator.py, line 22, in module from marvin.codes import * ImportError: No module named codes Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: DevCloud Error
Thanks, Travis! On Mon, Nov 4, 2013 at 1:47 PM, Travis Graham tgra...@tgraham.us wrote: Here was the last from the thread you're thinking of, no resolution follow up, so I don't know if it fixed things previously: Hi Min, 1/ I just pulled the latest code from master and used marvin, it went fine. Are you still facing this issue? Make sure your local setup is clean and marvin installed with latest pull. 2/ It seems you don't have codes.py file available under python/site-packages/.../marvin folder? Ideally it will get installed when you run your build. If its still an issue, run python setup.py install from tools/marvin/ folder and see if it works around. Thanks! Santhosh On Nov 4, 2013, at 3:27 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I feel like I may have missed an e-mail related to this error, but can't seem to locate it in my e-mail. Anyone know why I get this error when running the following: cd documents/cloudstack/src/cloudstack/tools/devcloud ; python ../marvin/marvin/deployDataCenter.py -i devcloud.cfg Traceback (most recent call last): File ../marvin/marvin/deployDataCenter.py, line 19, in module import configGenerator File /Users/mtutkowski/Documents/CloudStack/src/CloudStack/tools/marvin/marvin/configGenerator.py, line 22, in module from marvin.codes import * ImportError: No module named codes Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
RE: haPlanners error in fresh 4.2 checkout
I don't see this on 4.2 anymore, so it's hard to debug. But when I saw this, the 'haPlanners' property was missing from my setup's nonOssComponentContext.xml Are you guys using Simulator? I think there is one version for Simulator too - Do you see this property defined in your client/tomcatconf/simulatorComponentContext.xml.in? If it is not there, adding it in this file and recompiling should solve this. Nitin - have you added it to simulatorComponentContext.xml? Prachi -Original Message- From: Alex Ough [mailto:alex.o...@sungard.com] Sent: Monday, November 04, 2013 11:29 AM To: dev@cloudstack.apache.org Subject: Re: haPlanners error in fresh 4.2 checkout I still have this issue Any update on this? Thanks Alex Ough On Fri, Nov 1, 2013 at 4:41 AM, sebgoa run...@gmail.com wrote: I deleted my local 4.2 branch and did a brand new checkout, same result. latest 4.2 does not work for me -same error as below - On Oct 31, 2013, at 8:34 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: I too faced this issue today. Is there any resolution for this? Thanks, ~Talluri On 31/10/13 2:35 pm, sebgoa run...@gmail.com wrote: On Oct 29, 2013, at 7:56 PM, Nitin Mehta nitin.me...@citrix.com wrote: Yeah, that should have cleaned the workspace. Did you see what Prachi recommended below ? Yes and it's there. I do a fresh 4.2 checkout it compiles fine with: mvn -Pdeveloper -Dsimulator -DskipTests clean install But when I run with: mvn -pl client jetty:run I get this: 2013-10-31 10:01:31.403:INFO::Started SelectChannelConnector@0.0.0.0:8080 [INFO] Started Jetty Server Exception in thread Timer-2 org.springframework.beans.factory.BeanExpressionException: Expression parsing failed; nested exception is org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object of type 'org.springframework.beans.factory.config.BeanExpressionContext' at org.springframework.context.expression.StandardBeanExpressionResolver. eval uate(StandardBeanExpressionResolver.java:142) at org.springframework.beans.factory.support.AbstractBeanFactory.evaluate Bean DefinitionString(AbstractBeanFactory.java:1299) at org.springframework.beans.factory.support.BeanDefinitionValueResolver. eval uate(BeanDefinitionValueResolver.java:210) at org.springframework.beans.factory.support.BeanDefinitionValueResolver. reso lveValueIfNecessary(BeanDefinitionValueResolver.java:182) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanF acto ry.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanF acto ry.populateBean(AbstractAutowireCapableBeanFactory.java:1118) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanF acto ry.configureBean(AbstractAutowireCapableBeanFactory.java:314) at com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Com pone ntContext.java:71) at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:54) at java.util.TimerThread.mainLoop(Timer.java:555) at java.util.TimerThread.run(Timer.java:505) Caused by: org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object of type 'org.springframework.beans.factory.config.BeanExpressionContext' at org.springframework.expression.spel.ast.PropertyOrFieldReference.readP rope rty(PropertyOrFieldReference.java:208) at org.springframework.expression.spel.ast.PropertyOrFieldReference.getVa lueI nternal(PropertyOrFieldReference.java:72) at org.springframework.expression.spel.ast.CompoundExpression.getValueInt erna l(CompoundExpression.java:52) at org.springframework.expression.spel.ast.SpelNodeImpl.getValue(SpelNode Impl .java:93) at org.springframework.expression.spel.standard.SpelExpression.getValue(S pelE xpression.java:88) at org.springframework.context.expression.StandardBeanExpressionResolver. eval uate(StandardBeanExpressionResolver.java:139) ... 10 more ERROR [cloud.api.ApiServlet] (770998563@qtp-534473248-6:) unknown exception writing api response java.lang.NullPointerException at com.cloud.api.ApiServer.loginUser(ApiServer.java:770) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:211) at com.cloud.api.ApiServlet.doPost(ApiServlet.java:71) at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
Re: Marvin deploy failed on master
Thanks Santhosh. Using #2 fixed the issue. -min On 11/2/13 5:48 AM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Hi Min, 1/ I just pulled the latest code from master and used marvin, it went fine. Are you still facing this issue? Make sure your local setup is clean and marvin installed with latest pull. 2/ It seems you don't have codes.py file available under python/site-packages/.../marvin folder? Ideally it will get installed when you run your build. If its still an issue, run python setup.py install from tools/marvin/ folder and see if it works around. Thanks! Santhosh From: Min Chen [min.c...@citrix.com] Sent: Friday, November 01, 2013 8:10 PM To: dev@cloudstack.apache.org Subject: Marvin deploy failed on master Hi there, Mavin deployment failed on master, localhost:devcloud minc$ python ../marvin/marvin/deployDataCenter.py -i min_xenvm_sec2.cfg Traceback (most recent call last): File ../marvin/marvin/deployDataCenter.py, line 19, in module import configGenerator File /Users/minc/dev/cloud-asf/tools/marvin/marvin/configGenerator.py, line 22, in module from marvin.codes import * ImportError: No module named codes This seems related to recent commit 0b617a13fdf3b8108c2fd940e982b2e58bf9c3e7. Anybody else encountered the similar issue? Thanks -min
Cluster Settings Error
Hi, I see when you click on the Settings tab of a cluster that an error is displayed: http://i.imgur.com/k7oPoEp.jpg Anyone know if there is a JIRA ticket pending for this (I didn't see one)? Thanks, -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Cluster Settings Error
The screen shot appears to have the Affinity button selected, but I'm really looking at a cluster (the mouse was probably over the Affinity button when I took the screen shot). On Mon, Nov 4, 2013 at 3:14 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I see when you click on the Settings tab of a cluster that an error is displayed: http://i.imgur.com/k7oPoEp.jpg Anyone know if there is a JIRA ticket pending for this (I didn't see one)? Thanks, -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Review Request 15068: Change labels for VLAN to vNet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15068/#review28144 --- Ship it! Ship It! - Jessica Wang On Nov. 1, 2013, 4:52 p.m., Chris Cameron wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15068/ --- (Updated Nov. 1, 2013, 4:52 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, Pranav Saxena, and Toshiaki Hatano. Repository: cloudstack-git Description --- We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack. Diffs - client/WEB-INF/classes/resources/messages.properties 3210aca ui/dictionary.jsp 35cba22 ui/scripts/network.js 12e5389 ui/scripts/system.js 479883c Diff: https://reviews.apache.org/r/15068/diff/ Testing --- Checked through the GUI for changed elements. Thanks, Chris Cameron
Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/#review28145 --- Commit 70330f5cf32f4a0463edf5024cf841e0e678f423 in branch refs/heads/ui-restyle from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=70330f5 ] CLOUDSTACK-3216 /var/log/cloud.log did not have a logrotate script, here is a basic one. - ASF Subversion and Git Services On July 27, 2013, 1:09 p.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/ --- (Updated July 27, 2013, 1:09 p.m.) Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and Hugo Trippaers. Bugs: 3216 https://issues.apache.org/jira/browse/3216 Repository: cloudstack-git Description --- Issue: == logrotate.conf and logrotate config files in logrotate.d folder are having x permission. hence logrotate daemon not able to use this config logrotate reports the error as /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d Ignoring apache2 because of bad file mode. reading config file apt reading config file aptitude reading config file conntrackd Ignoring dnsmasq because of bad file mode. reading config file dpkg Ignoring haproxy because of bad file mode. reading config file monit Ignoring ppp because of bad file mode. Ignoring rsyslog because of bad file mode. == Fix: === while generating the cloudscripts.tgz file, I had modified to include the logrotate.conf and logrotate config files under logrotate.d with 644 permission which will fix the issue. this is will fix the bad file mode error. Diffs - patches/pom.xml 00eec02 Diff: https://reviews.apache.org/r/12994/diff/ Testing --- 1. after generating new systemvm.iso tested the new router/ssvm/console proxy. logrotate -d -v /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d reading config file apache2 reading config file apt reading config file aptitude reading config file conntrackd reading config file dnsmasq reading config file dpkg reading config file haproxy reading config file monit reading config file ppp reading config file rsyslog 2. Verified after launching the VR, new instances are getting IP and hostname properly. Thanks, Rajesh Battala
Re: haPlanners error in fresh 4.2 checkout
I added the property and the server starts ok after being rebuilt. Thank Prachi for your help. Alex Ough On Mon, Nov 4, 2013 at 4:02 PM, Prachi Damle prachi.da...@citrix.comwrote: I don't see this on 4.2 anymore, so it's hard to debug. But when I saw this, the 'haPlanners' property was missing from my setup's nonOssComponentContext.xml Are you guys using Simulator? I think there is one version for Simulator too - Do you see this property defined in your client/tomcatconf/simulatorComponentContext.xml.in? If it is not there, adding it in this file and recompiling should solve this. Nitin - have you added it to simulatorComponentContext.xml? Prachi -Original Message- From: Alex Ough [mailto:alex.o...@sungard.com] Sent: Monday, November 04, 2013 11:29 AM To: dev@cloudstack.apache.org Subject: Re: haPlanners error in fresh 4.2 checkout I still have this issue Any update on this? Thanks Alex Ough On Fri, Nov 1, 2013 at 4:41 AM, sebgoa run...@gmail.com wrote: I deleted my local 4.2 branch and did a brand new checkout, same result. latest 4.2 does not work for me -same error as below - On Oct 31, 2013, at 8:34 PM, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: I too faced this issue today. Is there any resolution for this? Thanks, ~Talluri On 31/10/13 2:35 pm, sebgoa run...@gmail.com wrote: On Oct 29, 2013, at 7:56 PM, Nitin Mehta nitin.me...@citrix.com wrote: Yeah, that should have cleaned the workspace. Did you see what Prachi recommended below ? Yes and it's there. I do a fresh 4.2 checkout it compiles fine with: mvn -Pdeveloper -Dsimulator -DskipTests clean install But when I run with: mvn -pl client jetty:run I get this: 2013-10-31 10:01:31.403:INFO::Started SelectChannelConnector@0.0.0.0:8080 [INFO] Started Jetty Server Exception in thread Timer-2 org.springframework.beans.factory.BeanExpressionException: Expression parsing failed; nested exception is org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object of type 'org.springframework.beans.factory.config.BeanExpressionContext' at org.springframework.context.expression.StandardBeanExpressionResolver. eval uate(StandardBeanExpressionResolver.java:142) at org.springframework.beans.factory.support.AbstractBeanFactory.evaluate Bean DefinitionString(AbstractBeanFactory.java:1299) at org.springframework.beans.factory.support.BeanDefinitionValueResolver. eval uate(BeanDefinitionValueResolver.java:210) at org.springframework.beans.factory.support.BeanDefinitionValueResolver. reso lveValueIfNecessary(BeanDefinitionValueResolver.java:182) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanF acto ry.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanF acto ry.populateBean(AbstractAutowireCapableBeanFactory.java:1118) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanF acto ry.configureBean(AbstractAutowireCapableBeanFactory.java:314) at com.cloud.utils.component.ComponentContext.initComponentsLifeCycle(Com pone ntContext.java:71) at com.cloud.servlet.CloudStartupServlet$1.run(CloudStartupServlet.java:54) at java.util.TimerThread.mainLoop(Timer.java:555) at java.util.TimerThread.run(Timer.java:505) Caused by: org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 0): Field or property 'haPlanners' cannot be found on object of type 'org.springframework.beans.factory.config.BeanExpressionContext' at org.springframework.expression.spel.ast.PropertyOrFieldReference.readP rope rty(PropertyOrFieldReference.java:208) at org.springframework.expression.spel.ast.PropertyOrFieldReference.getVa lueI nternal(PropertyOrFieldReference.java:72) at org.springframework.expression.spel.ast.CompoundExpression.getValueInt erna l(CompoundExpression.java:52) at org.springframework.expression.spel.ast.SpelNodeImpl.getValue(SpelNode Impl .java:93) at org.springframework.expression.spel.standard.SpelExpression.getValue(S pelE xpression.java:88) at org.springframework.context.expression.StandardBeanExpressionResolver. eval uate(StandardBeanExpressionResolver.java:139) ... 10 more ERROR [cloud.api.ApiServlet] (770998563@qtp-534473248-6:) unknown exception writing api response java.lang.NullPointerException at com.cloud.api.ApiServer.loginUser(ApiServer.java:770) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:211) at
Re: [Merge] Palo Alto Networks firewall integration to master
Sure, I would be glad to commit it for 4.3 release. --Sheng On Mon, Nov 4, 2013 at 8:19 AM, Chip Childers chipchild...@apache.orgwrote: On Mon, Nov 04, 2013 at 10:59:30AM -0500, Will Stevens wrote: Well its not in master yet. That is the intent of this thread... I can definitely do some testing for the 4.3 test cycle. Will Shoot, I misread Sheng's email. Sorry about that. I thought he said that he Checked *in* the code, not Checked out. Duh... my bad. Sheng, as the reviewer, want to handle the commit?
Re: Review Request 15050: Add Palo Alto Networks Firewall Integration
On Nov. 4, 2013, 10:44 p.m., Sheng Yang wrote: Hi Will, I think you need to rebase the patch to the latest MASTER, the current patch cannot apply to MASTER now. Also, you can add description to the patch(e.g. the description you added in the review board) By applying, I meant using git-am. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#review28146 --- On Nov. 1, 2013, 9:10 p.m., Will Stevens wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/ --- (Updated Nov. 1, 2013, 9:10 p.m.) Review request for cloudstack and Sheng Yang. Bugs: CLOUDSTACK-1275 https://issues.apache.org/jira/browse/CLOUDSTACK-1275 Repository: cloudstack-git Description --- More information in the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration This patch adds a network plugin which adds support for the Palo Alto Networks firewall (their appliance and their VM series firewall). Features supported are: - List/Add/Delete Palo Alto service provider - List/Add/Delete Palo Alto network service offering - List/Add/Delete Palo Alto network with above service offering - Add instance to the new network (creates the public IP and private gateway/cidr on the PA as well as the source nat rule) - List/Add/Delete Ingress Firewall rule - List/Add/Delete Egress Firewall rule - List/Add/Delete Port Forwarding rule - List/Add/Delete Static Nat rule - Supports Palo Alto Networks 'Log Forwarding' profile globally per device (additional docs to come) - Supports Palo Alto Networks 'Security Profile Groups' functionality globally per device (additional docs to come) Knowns limitations: - Only supports one public IP range in CloudStack. - Currently not verifying SSL certificates when creating a connection between CloudStack and the Palo Alto Networks firewall. - Currently not tracking usage on Public IPs. Diffs - api/src/com/cloud/network/Network.java 49f380b api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java 4983255 api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java 0b7836d api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 29ce2e3 client/WEB-INF/classes/resources/messages.properties c075bf8 client/pom.xml fd1f13a client/tomcatconf/commands.properties.in 96e841a client/tomcatconf/nonossComponentContext.xml.in 0502bbc plugins/network-elements/palo-alto/pom.xml PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListExternalFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/response/PaloAltoFirewallResponse.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoExternalFirewallElement.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoFirewallElementService.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/resource/PaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java PRE-CREATION plugins/pom.xml ca41dff server/src/com/cloud/api/ApiResponseHelper.java f4ca112 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1 ui/dictionary.jsp 80aab6f ui/scripts/docs.js 3a4f8ca ui/scripts/system.js 0af3952 Diff: https://reviews.apache.org/r/15050/diff/ Testing --- I have tested all of the functionality listed under 'supported
Re: Review Request 15050: Add Palo Alto Networks Firewall Integration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#review28146 --- Hi Will, I think you need to rebase the patch to the latest MASTER, the current patch cannot apply to MASTER now. Also, you can add description to the patch(e.g. the description you added in the review board) - Sheng Yang On Nov. 1, 2013, 9:10 p.m., Will Stevens wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/ --- (Updated Nov. 1, 2013, 9:10 p.m.) Review request for cloudstack and Sheng Yang. Bugs: CLOUDSTACK-1275 https://issues.apache.org/jira/browse/CLOUDSTACK-1275 Repository: cloudstack-git Description --- More information in the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration This patch adds a network plugin which adds support for the Palo Alto Networks firewall (their appliance and their VM series firewall). Features supported are: - List/Add/Delete Palo Alto service provider - List/Add/Delete Palo Alto network service offering - List/Add/Delete Palo Alto network with above service offering - Add instance to the new network (creates the public IP and private gateway/cidr on the PA as well as the source nat rule) - List/Add/Delete Ingress Firewall rule - List/Add/Delete Egress Firewall rule - List/Add/Delete Port Forwarding rule - List/Add/Delete Static Nat rule - Supports Palo Alto Networks 'Log Forwarding' profile globally per device (additional docs to come) - Supports Palo Alto Networks 'Security Profile Groups' functionality globally per device (additional docs to come) Knowns limitations: - Only supports one public IP range in CloudStack. - Currently not verifying SSL certificates when creating a connection between CloudStack and the Palo Alto Networks firewall. - Currently not tracking usage on Public IPs. Diffs - api/src/com/cloud/network/Network.java 49f380b api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java 4983255 api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java 0b7836d api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 29ce2e3 client/WEB-INF/classes/resources/messages.properties c075bf8 client/pom.xml fd1f13a client/tomcatconf/commands.properties.in 96e841a client/tomcatconf/nonossComponentContext.xml.in 0502bbc plugins/network-elements/palo-alto/pom.xml PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListExternalFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/response/PaloAltoFirewallResponse.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoExternalFirewallElement.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoFirewallElementService.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/resource/PaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java PRE-CREATION plugins/pom.xml ca41dff server/src/com/cloud/api/ApiResponseHelper.java f4ca112 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1 ui/dictionary.jsp 80aab6f ui/scripts/docs.js 3a4f8ca ui/scripts/system.js 0af3952 Diff: https://reviews.apache.org/r/15050/diff/ Testing --- I have tested all of the functionality listed under 'supported features'. Unit tests are in file 24 and 25 of this patch. The details of the tests can
Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions
All, Among the 2 approaches, I uploaded the implemented codes of the first approach, master-slave architecture, here. https://github.com/alexoughsg/albatross And here is the design doc in the wiki. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions Please review them and let me know what you think if you're interested! Thanks Alex Ough On Thu, Oct 31, 2013 at 6:51 PM, Alex Ough alex.o...@sungard.com wrote: Great! Thanks a lot, Daan. On Thu, Oct 31, 2013 at 4:58 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: you are added to jira, Alex On Thu, Oct 31, 2013 at 8:31 PM, Alex Ough alex.o...@sungard.com wrote: Thanks Chip, and can you also give a permission in Jira so that I can assign myself in its jira? Alex Ough On Thu, Oct 31, 2013 at 2:00 PM, Chip Childers chipchild...@apache.org wrote: Permission added. On Wed, Oct 30, 2013 at 12:19:23PM -0500, Alex Ough wrote: And I'd like to write the design document in the wiki page, but I don't seem to have a permission to create pages. So can anyone give me the permission? My account in the wiki is alex.o...@sungard.com Thanks in advance. Alex Ough On Tue, Oct 29, 2013 at 3:38 PM, Alex Ough alex.o...@sungard.com wrote: I created a jira for this feature. https://issues.apache.org/jira/browse/CLOUDSTACK-4992 But it doesn't allow for me to assign it to myself, so any permission do I need for this? If so, can anyone give me this permission? If there is anything missing, let me know. Thanks Alex Ough On Fri, Oct 18, 2013 at 9:30 AM, Kishan Kavala kishan.kav...@citrix.comwrote: -Original Message- From: Alex Ough [mailto:alex.o...@sungard.com] Sent: Thursday, 17 October 2013 11:25 PM To: dev@cloudstack.apache.org; u...@cloudstack.apache.org Subject: Fwd: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions All, Currently, under the environment of cloudstack with multiple regions, each region has its own management server running with a separate database. So if we want to support multiple regions and provide one point of entry for a customer, we need to duplicate domain/account/user information of that customer to all of the databases of regions the customer accesses, which will cause data discrepancies when users update those data independently in each management server. So I'd like to provide a way to sync up the data using the messaging system introduced in 4.1.0. Using the events from each management server, updates from each region can be propagated to the rest regions and they can be executed accordingly. I hope you guys have a chance to think about this and give some feedbacks if interested. Thanks in advance. Alex Ough [KK] Alex, it was discussed sometime back. Related thread [1]. Sync up using messaging system is the right way to go. [1] http://www.mail-archive.com/cloudstack-dev@incubator.apache.org/msg20193.html
does master even work? Can't start SSVM/CP
I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren
Re: does master even work? Can't start SSVM/CP
For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Creating cluster-level config keys/values
Hi, Does anyone know if this document is out of date? https://cwiki.apache.org/confluence/display/CLOUDSTACK/Adding+a+global+config+-+configurable+at+different+scopes I'm trying to add a key/value pair at the cluster level, but these directions don't seem in sync with master. Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: does master even work? Can't start SSVM/CP
Darren, your issue should be resolved. I checked in a fix for that. Also tested and able to start SSVM using Xen and NFS (or S3). Thanks -min From: Mike Tutkowski mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com Date: Monday, November 4, 2013 3:33 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Min Chen min.c...@citrix.commailto:min.c...@citrix.com, Edison Su edison...@citrix.commailto:edison...@citrix.com Subject: Re: does master even work? Can't start SSVM/CP For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.commailto:darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play™
Re: does master even work? Can't start SSVM/CP
The big thing that is different about my environment is that my mgmt server can't mount NFS. Otherwise it would work. Darren On Mon, Nov 4, 2013 at 4:33 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: does master even work? Can't start SSVM/CP
What is the commit? Darren On Mon, Nov 4, 2013 at 4:35 PM, Min Chen min.c...@citrix.com wrote: Darren, your issue should be resolved. I checked in a fix for that. Also tested and able to start SSVM using Xen and NFS (or S3). Thanks -min From: Mike Tutkowski mike.tutkow...@solidfire.commailto: mike.tutkow...@solidfire.com Date: Monday, November 4, 2013 3:33 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Min Chen min.c...@citrix.commailto:min.c...@citrix.com, Edison Su edison...@citrix.commailto:edison...@citrix.com Subject: Re: does master even work? Can't start SSVM/CP For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.commailto:darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play™
Re: does master even work? Can't start SSVM/CP
The last commit is eb9cfffd246267bbb5fe4befeb9afeaaf366874a Thanks -min On 11/4/13 3:36 PM, Darren Shepherd darren.s.sheph...@gmail.com wrote: What is the commit? Darren On Mon, Nov 4, 2013 at 4:35 PM, Min Chen min.c...@citrix.com wrote: Darren, your issue should be resolved. I checked in a fix for that. Also tested and able to start SSVM using Xen and NFS (or S3). Thanks -min From: Mike Tutkowski mike.tutkow...@solidfire.commailto: mike.tutkow...@solidfire.com Date: Monday, November 4, 2013 3:33 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Min Chen min.c...@citrix.commailto:min.c...@citrix.com, Edison Su edison...@citrix.commailto:edison...@citrix.com Subject: Re: does master even work? Can't start SSVM/CP For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.commailto:darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play
Re: does master even work? Can't start SSVM/CP
If you are not using S3 as secondary storage, it should work. For S3, it still requires mount on MS to start ssvm though to copy from S3 to NFS cache. Thanks -min On 11/4/13 3:38 PM, Min Chen min.c...@citrix.com wrote: The last commit is eb9cfffd246267bbb5fe4befeb9afeaaf366874a Thanks -min On 11/4/13 3:36 PM, Darren Shepherd darren.s.sheph...@gmail.com wrote: What is the commit? Darren On Mon, Nov 4, 2013 at 4:35 PM, Min Chen min.c...@citrix.com wrote: Darren, your issue should be resolved. I checked in a fix for that. Also tested and able to start SSVM using Xen and NFS (or S3). Thanks -min From: Mike Tutkowski mike.tutkow...@solidfire.commailto: mike.tutkow...@solidfire.com Date: Monday, November 4, 2013 3:33 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Min Chen min.c...@citrix.commailto:min.c...@citrix.com, Edison Su edison...@citrix.commailto:edison...@citrix.com Subject: Re: does master even work? Can't start SSVM/CP For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.commailto:darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play
Re: Cluster Settings Error
This is part of the stack trace I'm seeing: java.lang.NullPointerException at com.cloud.server.ConfigurationServerImpl.getConfigListByScope(ConfigurationServerImpl.java:778) at com.cloud.server.ManagementServerImpl.searchForConfigurations(ManagementServerImpl.java:1674) at sun.reflect.GeneratedMethodAccessor308.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at com.sun.proxy.$Proxy233.searchForConfigurations(Unknown Source) at org.apache.cloudstack.api.command.admin.config.ListCfgsByCmd.execute(ListCfgsByCmd.java:115) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:527) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:370) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:322) at com.cloud.api.ApiServlet.access$000(ApiServlet.java:52) at com.cloud.api.ApiServlet$1.run(ApiServlet.java:114) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:111) at com.cloud.api.ApiServlet.doGet(ApiServlet.java:73) On Mon, Nov 4, 2013 at 3:15 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: The screen shot appears to have the Affinity button selected, but I'm really looking at a cluster (the mouse was probably over the Affinity button when I took the screen shot). On Mon, Nov 4, 2013 at 3:14 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I see when you click on the Settings tab of a cluster that an error is displayed: http://i.imgur.com/k7oPoEp.jpg Anyone know if there is a JIRA ticket pending for this (I didn't see one)? Thanks, -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: does master even work? Can't start SSVM/CP
Yep, thanks. Its working now. Darren On Mon, Nov 4, 2013 at 4:40 PM, Min Chen min.c...@citrix.com wrote: If you are not using S3 as secondary storage, it should work. For S3, it still requires mount on MS to start ssvm though to copy from S3 to NFS cache. Thanks -min On 11/4/13 3:38 PM, Min Chen min.c...@citrix.com wrote: The last commit is eb9cfffd246267bbb5fe4befeb9afeaaf366874a Thanks -min On 11/4/13 3:36 PM, Darren Shepherd darren.s.sheph...@gmail.com wrote: What is the commit? Darren On Mon, Nov 4, 2013 at 4:35 PM, Min Chen min.c...@citrix.com wrote: Darren, your issue should be resolved. I checked in a fix for that. Also tested and able to start SSVM using Xen and NFS (or S3). Thanks -min From: Mike Tutkowski mike.tutkow...@solidfire.commailto: mike.tutkow...@solidfire.com Date: Monday, November 4, 2013 3:33 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Min Chen min.c...@citrix.commailto:min.c...@citrix.com, Edison Su edison...@citrix.commailto:edison...@citrix.com Subject: Re: does master even work? Can't start SSVM/CP For what it's worth, I rebased on top of master today and was able to create an environment from scratch using a XenServer host. On Mon, Nov 4, 2013 at 4:30 PM, Darren Shepherd darren.s.sheph...@gmail.commailto:darren.s.sheph...@gmail.com wrote: I can't get an environment setup on master, basically everytime it goes to start the SSVM or CP it tries to stage the template, then that fails because the command is routed to LocalHostEndpoint and my mgmt server can't mount NFS. Isn't there some special logic somewhere that knows the system VM template is already pre-staged on NFS? Darren -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/#review28156 --- Commit 57678257a123da1f74fa2a81407beb94450444b3 in branch refs/heads/master from Jessica Wang [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5767825 ] CLOUDSTACK-4908: UI Infrastructure Sockets view all calculate Hosts for each hypervisor. - ASF Subversion and Git Services On Oct. 31, 2013, 10:14 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/ --- (Updated Oct. 31, 2013, 10:14 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4908 https://issues.apache.org/jira/browse/CLOUDSTACK-4908 Repository: cloudstack-git Description --- CLOUDSTACK-4908: CPU socket count of host Adding cpu socket count of the host in hostresponse Diffs - api/src/com/cloud/host/Host.java 17b0ba8 api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3 api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276 engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db engine/schema/src/com/cloud/host/HostVO.java c814b94 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15 server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249 server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9 server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193 setup/db/db/schema-421to430.sql 803f1d9 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3 Diff: https://reviews.apache.org/r/15018/diff/ Testing --- Thanks, Harikrishna Patnala
Re: [Merge] Palo Alto Networks firewall integration to master
Sheng, I will rebuild the patch for the latest master. The latest master has depreciated the 'nonoss' flag in favour of 'noredist'. I was building in nonoss previously. I am guessing I should use the noredist flag now? Cheers, Will On Monday, November 4, 2013, Sheng Yang wrote: Sure, I would be glad to commit it for 4.3 release. --Sheng On Mon, Nov 4, 2013 at 8:19 AM, Chip Childers chipchild...@apache.orgjavascript:; wrote: On Mon, Nov 04, 2013 at 10:59:30AM -0500, Will Stevens wrote: Well its not in master yet. That is the intent of this thread... I can definitely do some testing for the 4.3 test cycle. Will Shoot, I misread Sheng's email. Sorry about that. I thought he said that he Checked *in* the code, not Checked out. Duh... my bad. Sheng, as the reviewer, want to handle the commit?
Re: Review Request 14426: Tests for Netscaler support as external LB Provider in VPC
On Oct. 31, 2013, 8:53 a.m., Santhosh Edukulla wrote: Ship It! master af4f78ecc 4.2 d5cca46ae - Sowmya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14426/#review27877 --- On Oct. 28, 2013, 7:03 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14426/ --- (Updated Oct. 28, 2013, 7:03 a.m.) Review request for cloudstack, Rajesh Battala, Santhosh Edukulla, and Sowmya Krishnan. Bugs: CLOUDSTACK-4776 https://issues.apache.org/jira/browse/CLOUDSTACK-4776 Repository: cloudstack-git Description --- Created tests for Netscaler as external LB provider in VPC Used ddt to achieve this without adding new tests but modifying the existing tests Created new network_offering_vpcNS Handled addition on NS as optional in setup - if NS addition fails, the non-NS tests still work and NS tests alone will be skipped Removed the creation of vpc Offering for each test, instead, using Default offering test_03_create_network_netscaler is no more valid - removed it. I am adding new tests for NS as external LB provider. So this is not needed. Diffs - test/integration/component/test_vpc_network.py 1d0b2d2 Diff: https://reviews.apache.org/r/14426/diff/ Testing --- Tested script locally. Long running script... Latest run looks good so far. output so far: Test create network in VPC ... ok Test create network in VPC ... ok Test create network in VPC mismatched services (Should fail) ... ok Test create network in VPC mismatched services (Should fail) ... ok Test create multiple networks with LB service (Should fail) ... ok Test create multiple networks with LB service (Should fail) ... ok Test create network with external LB devices ... ok Test create network with redundant router capability ... SKIP: skipped - RvR didn't support VPC currently Test create network services not supported by VPC (Should fail) ... ok Test create network without sourceNAT service in VPC (should fail) ... ok Test create network with shared network offering ... ok Test create network with shared network offering ... ok Test create network with conserve mode ON ... ok Test create network with conserve mode ON ... ok Test network gc after shutdown of vms in the network ... FAIL Test network rules after starting a VpcVr that was shutdown after network.gc ... ok Test Stop all the Vms that are part of the a Network ... ok Test create network outside cidr range of VPC ... ok Test create network outside cidr range of VPC ... ok Test create network outside cidr range of VPC ... ok Test create network inside cidr range of VPC ... ok Test create network inside cidr range of VPC ... ok Test create network overlapping cidr range of VPC ... Thanks, Sowmya Krishnan
RE: Review Request 14426: Tests for Netscaler support as external LB Provider in VPC
-Original Message- From: Santhosh Edukulla [mailto:nore...@reviews.apache.org] On Behalf Of Santhosh Edukulla Sent: Thursday, October 31, 2013 2:23 PM To: Rajesh Battala; Santhosh Edukulla; Sowmya Krishnan Cc: Prasanna Santhanam; cloudstack Subject: Re: Review Request 14426: Tests for Netscaler support as external LB Provider in VPC On Oct. 16, 2013, 4:43 p.m., Santhosh Edukulla wrote: Sowmya, Is it ok if we do a code walkthrough? Let me know i can create a gtm. Also,please add the path to test plan for this feature along with feature owner information, i will invite him\her as well. santhosh Sowmya Krishnan wrote: Sure. Test plan is here: https://cwiki.apache.org/confluence/x/xIzlAQ I had done the testing for the feature and dev was done by Rajesh(already added as reviewer for this patch) Prasanna Santhanam wrote: Any meeting notes or corrections from this review meeting? Santhosh Edukulla wrote: There were few review comments. We are doing the review again tomorrow. Sowmya Krishnan wrote: Did few more changes to the patch: 1. Edited Comments/Description for many tests. It was just wrong/copy- paste of first test. 2. Removed commented code Following based on review comments: 1. Replaced global for Netscaler configuration in setUpClass() with class attribute: ns_configured. Another option to this was to add an attribute to services class. But that wouldn't work with the current design of tests since we re-initialize services() class attributes in setUp() which runs before every test. So the value assigned in setUpClass will be lost. Hence followed this approach. 2. Removed non-functioning if statements 3. Removed VPC creation from test_10_create_network_with_conserve_mode 4. Few naming convention changes Apart from these, few generic discussions came up, mostly around handling exceptions for API calls which we presently don't religiously follow across all tests. Filed couple of tickets to track those issues (something to be fixed across all tests): CLOUDSTACK-4972, CLOUDSTACK-4974 1. If you are done with it , may be you can close the review. https://reviews.apache.org/r/14426/ Thanks for reminder. Done. 2. Also, change the summary of the review to reflect ddt usage. netscalar as external lb still requires more test cases for automation i believe. Yes. More tests are to be automated. I've already filed a task ticket to track this: CLOUDSTACK-4776. All patches for this feature test can be updated through this ticket. - Santhosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14426/#review27068 --- On Oct. 28, 2013, 7:03 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14426/ --- (Updated Oct. 28, 2013, 7:03 a.m.) Review request for cloudstack, Rajesh Battala, Santhosh Edukulla, and Sowmya Krishnan. Bugs: CLOUDSTACK-4776 https://issues.apache.org/jira/browse/CLOUDSTACK-4776 Repository: cloudstack-git Description --- Created tests for Netscaler as external LB provider in VPC Used ddt to achieve this without adding new tests but modifying the existing tests Created new network_offering_vpcNS Handled addition on NS as optional in setup - if NS addition fails, the non-NS tests still work and NS tests alone will be skipped Removed the creation of vpc Offering for each test, instead, using Default offering test_03_create_network_netscaler is no more valid - removed it. I am adding new tests for NS as external LB provider. So this is not needed. Diffs - test/integration/component/test_vpc_network.py 1d0b2d2 Diff: https://reviews.apache.org/r/14426/diff/ Testing --- Tested script locally. Long running script... Latest run looks good so far. output so far: Test create network in VPC ... ok Test create network in VPC ... ok Test create network in VPC mismatched services (Should fail) ... ok Test create network in VPC mismatched services (Should fail) ... ok Test create multiple networks with LB service (Should fail) ... ok Test create multiple networks with LB service (Should fail) ... ok Test create network with external LB devices ... ok Test create network with redundant router capability ... SKIP: skipped - RvR didn't support VPC currently Test create network services not supported by VPC (Should fail) ... ok Test create network without sourceNAT service in VPC (should fail) ... ok Test create network with shared network offering
Wiki access
Can someone please grant me edit access to wiki? Username: sowmyak Thanks, Sowmya
Review Request 15238: CLOUDSTACK-5039: bugfix: live migration failed : Domain not found: no domain with matching uuid 'uuid'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/ --- Review request for cloudstack, Marcus Sorensen, Toshiaki Hatano, and Wido den Hollander. Bugs: CLOUDSTACK-5039 https://issues.apache.org/jira/browse/CLOUDSTACK-5039 Repository: cloudstack-git Description --- * Issue to be solved: Live migration failed with following error message: 2013-11-05 04:39:29,345 DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-1:null) Can't migrate domain: Domain not found: no domain with matching uuid '87c06b76-5ee6-3f1b-8c89-54e75de6bd3d' It seems CloudStack doesn't specify correct UUID. This commit revert the domain lookup code change made in the commit ( https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=203587a06f63f23d487ae65dcf5c397cd2702166;hp=94ee9ae676ef8d0202e7fa617e712352a934ffcb;hb=a709f34f;hpb=5410901aebed4ada581b853e0ca02d9f855a68f1 ). Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2 Diff: https://reviews.apache.org/r/15238/diff/ Testing --- I confirmed live migration works. Thanks, Yoshikazu Nojima
Re: Review Request 15238: CLOUDSTACK-5039: bugfix: live migration failed : Domain not found: no domain with matching uuid 'uuid'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/#review28175 --- Ship it! I can't remember why, exactly, but I seem to remember we switched everything over to domain lookups by name awhile back (maybe in 4.1). I think it was just because it seemed like a convoluted abstraction to take the vmname, convert it to a uuid, and then lookup by that. We may not even register a uuid any longer, I don't remember. - Marcus Sorensen On Nov. 5, 2013, 5:17 a.m., Yoshikazu Nojima wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/ --- (Updated Nov. 5, 2013, 5:17 a.m.) Review request for cloudstack, Marcus Sorensen, Toshiaki Hatano, and Wido den Hollander. Bugs: CLOUDSTACK-5039 https://issues.apache.org/jira/browse/CLOUDSTACK-5039 Repository: cloudstack-git Description --- * Issue to be solved: Live migration failed with following error message: 2013-11-05 04:39:29,345 DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-1:null) Can't migrate domain: Domain not found: no domain with matching uuid '87c06b76-5ee6-3f1b-8c89-54e75de6bd3d' It seems CloudStack doesn't specify correct UUID. This commit revert the domain lookup code change made in the commit ( https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=203587a06f63f23d487ae65dcf5c397cd2702166;hp=94ee9ae676ef8d0202e7fa617e712352a934ffcb;hb=a709f34f;hpb=5410901aebed4ada581b853e0ca02d9f855a68f1 ). Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2 Diff: https://reviews.apache.org/r/15238/diff/ Testing --- I confirmed live migration works. Thanks, Yoshikazu Nojima
NFS vs Swift
HI All, We are currently running CloudStack 3.07 with NFS Secondary Storage which we have had continuing issues with. Has anyone migrated from NFS to swift? Pros / Cons – any tips would be most helpful. Thanks in advance Damien Damien Mannix Cloud Systems Administrator ITS Research Services 317 Doug McDonell Building, University of Melbourne email: damien.man...@unimelb.edu.au NSP Support please email: nsp-h...@nectar.org.au Mobile: +61 (0) 481 005 367
[ACS43] Schedule reminder : feature freeze this Friday 11/08
Folks Friday 11/8 is the feature freeze date for ACS 4.3. If your contribution is unlikely to make it to 4.3 feature freeze on 11/8 please move them out of 4.3 release to 'Future'. Do remember that we have a 72 hour notice period to solicit feedback for MERGE requests. So the absolute last day for merge requests for 4.3 features/ improvements is tomorrow 11/05. Contributors if you have patches in reviewboard that you had planned for 4.3 make sure to follow up with reviewers. The contribution has to be in master after satisfying any merge concerns / review comments by 11/08 to be included in 4.3.0 release. For detailed branch merge requirement check [1] [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Expectations Thanks Animesh
Re: [Merge] Palo Alto Networks firewall integration to master
On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens wstev...@cloudops.com wrote: Sheng, I will rebuild the patch for the latest master. The latest master has depreciated the 'nonoss' flag in favour of 'noredist'. I was building in nonoss previously. I am guessing I should use the noredist flag now? Will - what is causing this to be noredist/nonoss? My quick perusal of your patch didn't surface anything that would push it into that category. --David
Re: Review Request 15078: Fixed some html validation errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15078/ --- (Updated Nov. 5, 2013, 6:29 a.m.) Review request for cloudstack and Jessica Wang. Changes --- uploading the patch again. Repository: cloudstack-git Description --- Fixed some html validation errors. language tag in script is deprecated. used type script tag after /html is invalid. moved the localized messages dictionary inside html body. Diffs (updated) - ui/dictionary.jsp ed269c8 ui/index.jsp 56a4b27 Diff: https://reviews.apache.org/r/15078/diff/ Testing --- manually verified Thanks, Rajani Karuturi
Re: Documentation: Where are the page numbers in the PDFs? Publican changes?
On Nov 1, 2013, at 3:10 AM, Ryan Lei ryan...@cht.com.tw wrote: Quick question. Ever since ACS 4.1.1, the PDFs downloaded from the doc website no longer have a page number at the bottom-left or bottom-right corner of a page. This may make the printed version hard to navigate through the pages! Also, many words, tables, and figures get truncated when they appear at the bottom of the page. Has anything happened to Publican since the 4.1.0 release? Can't believe we did not catch this earlier :( I don't know what's wrong with it, but you are right it's totally messed up. I believe there was a move to publican 3.0.0 that might have caused it. Please file a bug, and if you know the solution tell us. I will look into it as well. Maybe jzb has free time today copying him. -sebastien Thanks --- Yu-Heng (Ryan) Lei, Associate Researcher Chunghwa Telecom Laboratories / Cloud Computing Laboratory ryan...@cht.com.twhttps://email.cht.com.tw/owa/redir.aspx?C=-wE1FEC3G0SWYpVkiWo8SsDdf3ZqO9AIuAPTzRnFYCUi-z4YljtI_hyVKkNHfn9F1Bn-vUWJnQ4.URL=mailto%3aryanlei%40cht.com.tw or ryanlei750...@gmail.com
Re: NFS vs Swift
On Nov 5, 2013, at 12:44 AM, Damien Mannix damien.man...@unimelb.edu.au wrote: HI All, We are currently running CloudStack 3.07 with NFS Secondary Storage which we have had continuing issues with. Has anyone migrated from NFS to swift? Pros / Cons – any tips would be most helpful. Thanks in advance Damien Damien, 3.07 is not an official apache cloudstack release, you might be referring to a cloudplatform commercial version ? I would recommend to upgrade to 4.1.1 or 4.2.0 In 4.2 there is much better support for S3 backed secondary storage including Ceph radoggw, RiakCS and glusterfs. Basically any S3 object store can be used. That said having issues with NFS seems strange, I would personally first try to solve the NFS issues send us some logs if you want. Damien Mannix Cloud Systems Administrator ITS Research Services 317 Doug McDonell Building, University of Melbourne email: damien.man...@unimelb.edu.au NSP Support please email: nsp-h...@nectar.org.au Mobile: +61 (0) 481 005 367
Re: Question: Error when creating templates from ROOT volumes in the Simulator
Pinging Prasanna on this, On Oct 31, 2013, at 5:07 PM, David Grizzanti david.grizza...@sungard.com wrote: Hi All, I have been seeing an issue with the Simulator that I was hoping someone could provide some insight into. Some background. I'm running from the 4.2.0 tag on rhel 6.3, building from source/enabling the simulator. Overall, most operations seem to work fine, however, I noticed that when creating a template from the ROOT volume on a VM, the template can't then be used to create a subsequent VM. The reason for this seems to be that the size of the template is set to 0. After digging through the database a bit, I discovered that the size and physical_size columns in the template_store_ref table are set to 0 for these templates. If I correct those values for my entry after the fact, everything appears to work. I dug around in the code a bit as well, but nothing obvious was jumping out at me as to why this was happening. Any thoughts? Thanks! -- David Grizzanti Software Engineer Sungard Availability Services e: david.grizza...@sungard.com w: 215.446.1431 c: 570.575.0315
