Re: [ACS4.2.1] Code complete
Abhi, Can we test first and get the results from BVT before cutting the RC ? -sebastien On Nov 6, 2013, at 1:46 AM, Abhinandan Prateek abhinandan.prat...@citrix.com wrote: ACS 4.2.1 has now very few open tickets. These are expected to be closed this week. The docs are also getting updated. I am planning to create a RC build tomorrow. Do ping back if anything should hold it. -abhi
template inheritance from domains to subdomains, new feature?
Hi, Have a look at the following structure: BASE_DOMAIN \_ CHILD_1 \_ CHILD_2 Assuming I'm using an account created in BASE_DOMAIN, I'm trying to find a way to publish templates from that account so that they're also accessible to accounts created on the child subdomains - is there any way to do this and set up some sort of inheritance for the templates? The default behavior seems to be total isolation - if you create a template via an account from the BASE_DOMAIN, the subdomains are not able to access it (and the other way around, if you create it from an account in the child domains, the BASE_DOMAIN account is not able to access them) I don't want to declare the templates as public as everyone will be able to access them. If this is not possible by design I'm considering creating a feature request because this is a critical feature to be used in shared cloud environments. Thanks, Octavian -- Octavian Popescu Manager, Hosting Solution Design +420-225-352673
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 6, 2013, 9:08 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Changes --- Add the sql changes to create usage_event_details table. fixed the updatehostcapcity function in capacity manager. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs (updated) - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/configuration/ConfigurationManager.java 03a549f engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 8d841d8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/src/com/cloud/deploy/ImplicitDedicationPlanner.java e73bc72 plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java b6269eb server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java e82aaba server/src/com/cloud/network/NetworkModelImpl.java df9f651 server/src/com/cloud/network/element/CloudZonesNetworkElement.java 01de923 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 80a4036 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3147f1f server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingDaoImplTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 26e4abf Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Not tested. Thanks, bharat kumar
[JENKINS] Preparing for the 4.3 branch
I’ve setup all the jenkins jobs for the release branch and a pipeline view. When the branch is cut we only need to enable the jobs. http://jenkins.buildacloud.org/view/4.3/ http://jenkins.buildacloud.org/view/cloudstack-4.3-pipeline/ Cheers, Hugo
Re: [JENKINS] Preparing for the 4.3 branch
On Wed, Nov 06, 2013 at 11:15:33AM +0100, Hugo Trippaers wrote: I?ve setup all the jenkins jobs for the release branch and a pipeline view. When the branch is cut we only need to enable the jobs. http://jenkins.buildacloud.org/view/4.3/ http://jenkins.buildacloud.org/view/cloudstack-4.3-pipeline/ Thanks Hugo! I wrote up some documentation on how this was being done in the past. The views, what they mean and nomenclature of jobs etc. https://cwiki.apache.org/confluence/x/u4wTAg Cheers, Hugo -- Prasanna., Powered by BigRock.com
Review Request 15263: Added fix for bug 5056.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15263/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5056 https://issues.apache.org/jira/browse/CLOUDSTACK-5056 Repository: cloudstack-git Description --- 1. The library( remoteSSHClient ) in its current form has some issues. Fixed few of them. As part of that, did clean up of the code. 2. Added tcp timeout flag as an additional parameter to help establish the tcp connections and retry if failed. It retries even otherwise failed. 3. Renamed few variables and maintained uniform usage and convention. 4. Added few new member functions runCommand,createConnection 5. Current, way of creating connection and raising exception from constructor along with return was removed and added a new way of handling it. 6. Currently, result list was returned for execute command, but we dont know the status of command execution, whether the output contains error or output etc. Now, provided more information in the return with new implementation. 7. Added few codes for proper return status. TODO: 1. Remove establishing connection from constructor altogether. This will effect the current modules using it. 2. Need to change is_server_ssh_ready function for proper and adequate checks, currently the name and functionality is little different. It can add more adequate checks before returning ssh object. Diffs - tools/marvin/marvin/codes.py b6580d0 tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15263/diff/ Testing --- Thanks, Santhosh Edukulla
Re: Error adding host to cluster - cloudstack 4.2
Aakash, attached files get trunked…can you post on something like pastebin.com Are you using virtual box on windows and running the mgt server on windows itself ? How about moving to linux ? ;) On Nov 5, 2013, at 8:13 PM, Aakash Kumar junkaak...@gmail.com wrote: Got Below Exception , com.cloud.utils.exception.CloudRuntimeException: callHostPlugin failed for cmd: setIptables with args due to There was a failure communicating with the plugin. Details , Using Devcloud2 with development env on windows Please Find attached log file
Need edit access to Apache Jira
Hi , I am not able to close issues that I have verified in issues.apache.org . My user name is pavanb. Can you please give those permissions to my id. Regards, Pavan
Edit access to ASF Jira
Hi, Please provide me the edit access to ASF jira .I am not having option to close the bugs in ASF jira which are not assigned to me. Thanks, Manasa
Re: Review Request 15263: Added fix for bug 5056.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15263/ --- (Updated Nov. 6, 2013, 1:44 p.m.) Review request for cloudstack and Girish Shilamkar. Changes --- Added few corrections. Bugs: CLOUDSTACK-5056 https://issues.apache.org/jira/browse/CLOUDSTACK-5056 Repository: cloudstack-git Description --- 1. The library( remoteSSHClient ) in its current form has some issues. Fixed few of them. As part of that, did clean up of the code. 2. Added tcp timeout flag as an additional parameter to help establish the tcp connections and retry if failed. It retries even otherwise failed. 3. Renamed few variables and maintained uniform usage and convention. 4. Added few new member functions runCommand,createConnection 5. Current, way of creating connection and raising exception from constructor along with return was removed and added a new way of handling it. 6. Currently, result list was returned for execute command, but we dont know the status of command execution, whether the output contains error or output etc. Now, provided more information in the return with new implementation. 7. Added few codes for proper return status. TODO: 1. Remove establishing connection from constructor altogether. This will effect the current modules using it. 2. Need to change is_server_ssh_ready function for proper and adequate checks, currently the name and functionality is little different. It can add more adequate checks before returning ssh object. Diffs - tools/marvin/marvin/codes.py b6580d0 tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15263/diff/ Testing --- File Attachments (updated) Added New File https://reviews.apache.org/media/uploaded/files/2013/11/06/0001-Added-fix-for-bug-5056.patch Thanks, Santhosh Edukulla
Re: Bug? Should we allow detaching volumes when VMs have snapshots
Bumping this. I believe we need the imput of a VMWare expert, please. -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat On Nov 5, 2013, at 1:46 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: OK, well, depending on if we can or can't get a VMware person to chime in on this issue, we may have to disallow disks from being detached from VMware VMs with snapshots in 4.3. On Tue, Nov 5, 2013 at 11:44 AM, SuichII, Christopher chris.su...@netapp.com wrote: Correct. #6 FAILS with VMWare and SUCCEEDS with Xen -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat On Nov 5, 2013, at 1:35 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I assume 6 fails with VMware, as well? Is Xen OK with 6? On Tue, Nov 5, 2013 at 11:26 AM, SuichII, Christopher chris.su...@netapp.com wrote: FWIW, after looking into this more with Xen, when the VM is restored in step 4, it simply no longer has the volume attached, so this appears to really be a VMWare issue. Any VMWare experts out there know how we can handle this? -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat On Nov 5, 2013, at 1:05 PM, SuichII, Christopher chris.su...@netapp.com wrote: We currently don’t allow volumes to be attached to VMs with snapshots and allowing volumes to be detached causes quite a bug: 1) Attach a data disk to a VM 2) Snapshot the VM 3) Detach the data disk 4) Attempt to restore the VM from the snapshot — FAILS since the data disk is no longer there, although it is expected to be 5) Attempt to re-attach the volume to the VM — FAILS since you cannot attach volumes to VMs with snapshots 6) Attempt to delete the VM snapshot — FAILS since the data disk is no longer there, although it is expected to be I have verified the above steps on VMWare, however Xen does not appear to fail on step 4, presumably because VMWare handles snapshots quite differently than Xen. Does anyone else have any thoughts on whether this is a bug or not? IMO, on VMWare, this set of steps can get users into a state where they can no longer attach new data disks to their VM, so it appears to be a bug of some kind. -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Review Request 15264: Fix for 1125389 RV: Bad use of return value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15264/ --- (Updated Nov. 6, 2013, 2:08 p.m.) Review request for cloudstack and Hugo Trippaers. Changes --- Added cloudstack as review group Bugs: 1125389 https://issues.apache.org/jira/browse/1125389 Repository: cloudstack-git Description --- In org.?apache.?cloudstack.?network.?contrail.?management.?ContrailManagerImpl.?getPhysicalNetworkName(com.?cloud.?network.?dao.?PhysicalNetworkVO): The return value of this method should be checked. (From FindBugs™ description) (CWE-440) Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java ae9bba9 Diff: https://reviews.apache.org/r/15264/diff/ Testing --- Thanks, Wilder Rodrigues
Re: Review Request 15264: Fix for 1125389 RV: Bad use of return value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15264/#review28264 --- Ship it! commit 56070c644b026003b155bdb69b356a286e122a46 Author: wilderrodrigues wrodrig...@schubergphilis.com Date: Wed Nov 6 14:18:31 2013 +0100 Fix for 1125389 RV: Bad use of return value - make sure the replace call is done after replaceAll and the correct value is returned Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Nov. 6, 2013, 2:08 p.m., Wilder Rodrigues wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15264/ --- (Updated Nov. 6, 2013, 2:08 p.m.) Review request for cloudstack and Hugo Trippaers. Bugs: 1125389 https://issues.apache.org/jira/browse/1125389 Repository: cloudstack-git Description --- In org.?apache.?cloudstack.?network.?contrail.?management.?ContrailManagerImpl.?getPhysicalNetworkName(com.?cloud.?network.?dao.?PhysicalNetworkVO): The return value of this method should be checked. (From FindBugs™ description) (CWE-440) Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java ae9bba9 Diff: https://reviews.apache.org/r/15264/diff/ Testing --- Thanks, Wilder Rodrigues
Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15241/ --- (Updated Nov. 6, 2013, 2:37 p.m.) Review request for cloudstack and Girish Shilamkar. Repository: cloudstack-git Description --- It was told that reporting results for a given test run with same module names is confusing. Renamed them with few prefixes to avoid confusion. Note: There are still files with name as below for cpu limits related testing and similarly available for memory as well. Need to check the difference between these two contents. That will be different check again. test_cpu_project_limits.py test_cpu_limits.py Diffs - test/integration/component/cpu_limits/test_cpu_project_limits.py PRE-CREATION test/integration/component/cpu_limits/test_project_limits.py 63d1a98 test/integration/component/memory_limits/test_mem_project_limits.py PRE-CREATION test/integration/component/memory_limits/test_project_limits.py 1c0ed92 Diff: https://reviews.apache.org/r/15241/diff/ Testing --- Thanks, Santhosh Edukulla
Re: [jira] [Commented] (CLOUDSTACK-4550) [DOC] When upgrading KVM agents to 4.2(.1?) perform bridge renaming to have migration work
The guest.network.device and private.network.device should be something
like cloudbr0 or cloudbr1
Please follow the official documents.
2013/11/6 hayou (JIRA) j...@apache.org
[
https://issues.apache.org/jira/browse/CLOUDSTACK-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814945#comment-13814945]
hayou commented on CLOUDSTACK-4550:
---
not really Wei Zhou ;).
I have the same error on my management :
{quote}
2013-11-06 16:02:15,989 ERROR [cloud.vm.VirtualMachineManagerImpl]
(Job-Executor-163:job-399 = [ a47926cf-d712-4bc1-926b-3a8ac43d9e40 ])
Unable to migrate due to Cannot get interface MTU on 'brbond0.110-110': No
such device
{quote}
I type /usr/bin/cloudstack-agent-upgrade on my 2 hypervisors then reboot.
Here is my agent properties :
{quote}
guest.network.device=cloudVirBr100
workers=5
private.network.device=cloudVirBr100
port=8250
resource=com.cloud.hypervisor.kvm.resource.LibvirtComputingResource
pod=1
network.bridge.name.schema=3.0
zone=1
guid=8b928279-d5af-30a9-bc27-6e872a065372
cluster=1
public.network.device=cloudVirBrPub
local.storage.uuid=9342a19c-7822-4a4b-9e83-543742528a81
domr.scripts.dir=scripts/network/domr/kvm
host=172.
LibvirtComputingResource.id=4
{quote}
[DOC] When upgrading KVM agents to 4.2(.1?) perform bridge renaming to
have migration work
--
Key: CLOUDSTACK-4550
URL:
https://issues.apache.org/jira/browse/CLOUDSTACK-4550
Project: CloudStack
Issue Type: Bug
Security Level: Public(Anyone can view this level - this is the
default.)
Components: Doc, KVM, Upgrade
Affects Versions: 4.2.0
Reporter: Prasanna Santhanam
Priority: Critical
Attachments: bridge.jpg
See CLOUDSTACK-4405 for the original bug. This is the doc to be prepared
as
part of upgrade in release notes once the fix for the bug is verified to
work
After network bridges being renamed from cloudVirBrVLAN to brem1-VLAN to
support the same VLAN on multiple physical networks the migration of VMs
from hosts prior the upgrade to the ones added after the upgrade will fail.
In order to fix this rename the bridges is required to allow migration
to work.
This can be done by running the cloudstack-agent-upgrade script. The
original bug is still undergoing testing, but these are the initial
instructions
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Review Request 15268: Fix for 1125376 NP: Null pointer dereference - make sure the equals implementation is compliant with the contract.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15268/ --- Review request for cloudstack and Hugo Trippaers. Bugs: 1125376, NP:, Null, dereference, and pointer https://issues.apache.org/jira/browse/1125376 https://issues.apache.org/jira/browse/NP: https://issues.apache.org/jira/browse/Null https://issues.apache.org/jira/browse/dereference https://issues.apache.org/jira/browse/pointer Repository: cloudstack-git Description --- 1125376 NP: Null pointer dereference In org.?apache.?cloudstack.?network.?contrail.?model.?ModelObject$ModelReference.?equals(java.?lang.?Object): This implementation of equals(Object) violates the contract defined by java.lang.Object.equals() because it does not check for null being passed as the argument. (From FindBugs™ description) (CWE-476) Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac Diff: https://reviews.apache.org/r/15268/diff/ Testing --- Thanks, Wilder Rodrigues
Re: [PROPOSAL] Service monitoring tool in virtual router
Please find below update FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Monitoring+VR+services Thanks, Jayapal On 05-Oct-2013, at 6:54 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: A shell script can be used. Few thoughts below: 1. Collect the process id of all daemons you wanted to monitor using pidof of command and then use kill command to check if the pid you got is valid. Using kill we can send a signal 0, then check the status using echo $? . For sending a notification use linux syslog call ( man 3 syslogd) or logger command to send to syslog. If wanted to send email then you may also have to look for firewall not allowing outbound smtp port communiation. Even for snmp this holds same( i mean if any blocking through firewall rules ). Using syslog may be good as it by default exposes various debug log levels through its api call. Now, to keep the monitor script up always up and runninig. Keep the monitor script run continuosly through cron or at at regular\scheduled intervals. This way even if monitor script goes down, the next xth interval, it is up again. With this there is a catch though, we may got multiple pids for a given daemon provided if there are multiple daemons spawned by same\multiple applications, if this scenario is not common then its ok, otherwise we may have to track it differently maintaining state of each spawned daemon and see if it exists. If multiple applications launch the same daemon, you may also wanted to say its application which got killed. EX: A launched httpd, and during its exit logic, it is killing all daemons it launched, then you may wanted to add A is not available, rather than just http is not available. 2. Using netstat command : Check for available, listening and active ports on local host, provided all the daemons you wanted to monitor are running on standard ports or if we know the listening ports of those deamons to be monitored. Again, this script can be added through cron\at to be scheduled to run x units, if it gets killed the next x units after the monitor script is up again. Also, there could be many other approaches as well. Thanks! Santhosh From: Jayapal Reddy Uradi [jayapalreddy.ur...@citrix.com] Sent: Saturday, October 05, 2013 5:17 AM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [PROPOSAL] Service monitoring tool in virtual router Hi, +users list If any one is already using any tools for monitoring then please share your ideas. Also share the cases where you experienced service crashes. Thanks, Jayapal On 05-Oct-2013, at 4:12 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Well just make sure that your script is resilient to its own crashes as well. On 10/4/13 1:59 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Hi, I am planning to write script utility to monitor processes and restart on the event of failure. It will also logs the events. Thanks, Jayapal On 02-Oct-2013, at 3:25 AM, Simon Weller swel...@ena.com wrote: supervisord maybe? - Original Message - From: Chiradeep Vittal chiradeep.vit...@citrix.com To: dev@cloudstack.apache.org Sent: Tuesday, October 1, 2013 4:45:56 PM Subject: Re: [PROPOSAL] Service monitoring tool in virtual router Got it. Any other OSS tool out there similar to monit? On 10/1/13 8:24 AM, David Nalley da...@gnsa.us wrote: On Thu, Sep 26, 2013 at 1:27 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: SNMP wouldn't restart a failed process nor would it generate alerts. It is simply too generic for the requirements outlined here. The proposal does not talk about modifying monit, just using it. That wouldn't trigger the AGPL. Let me restate my objection to anything AGPL. People are largely comfortable with GPLv2 software - Linux is ubiquitous. Many legal departments routinely prohibit GPLv3 software (we actually saw this when CS was GPLv3 licensed.) But the Affero GPL license is anathema in many corporate environments, and by forcing it on folks in the default System VM I fear it will hurt adoption of CloudStack. --David
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 6, 2013, 4:17 p.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs (updated) - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 8d841d8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 80a4036 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 26e4abf Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Not tested. Thanks, bharat kumar
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 6, 2013, 4:19 p.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 8d841d8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 80a4036 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 26e4abf Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Not tested. Thanks, bharat kumar
Re: [New Feature FS] SSL Offload Support for Cloudstack
Hi All, Many thanks to Darren and Murali for reviewing my code. I feel that the code is in a good condition to be merged into the master. I see that the code freeze is at the end of this week. Is it possible for my patch to be merged by then? Is it a hard deadline? Thanks, -Syed On Mon 04 Nov 2013 11:45:15 AM EST, Syed Ahmed wrote: Hi All, I would like to get this code into 4.3. Is it possible for this to be reviewed? Is there anything needed from my side? I would be glad to provide more information. Thanks, -Syed On Wed 30 Oct 2013 03:25:12 PM EDT, Syed Ahmed wrote: Hi All, I have the patch for adding SSL termination support at https://reviews.apache.org/r/14976/ . It would be great if this can be reviewed. Thanks, -Syed On 13-10-15 03:01 AM, Murali Reddy wrote: On 11/10/13 9:31 PM, Syed Ahmed sah...@cloudops.com wrote: Thanks for your valuable feedback Murali. Here are my comments. IMO, its better we introduce new api's say registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalancer than force fit existing API's for associate/dis-associate certificates. Personally, I was going to do it this way. But I am not sure how good of an idea it is to add a new api just for this feature as I can see assignToLoadbalancer is semantically similar. But if everyone agrees I have no problem with it. CloudStack already has distinct API's for each of the LB sub-functionality (health check, stickiness etc) [1]. We are not adding any redundant API, so resulting API are much cleaner just managing SSL termination for a LB rule. On second thought may be an CloudStack usage event on assigning certificate seems good enough to me. So what I got from your earlier post was that when adding a network offering the provider can choose to enable SSL Termination or not as it is a value added service. I was thinking of adding SSL termination under supportedservices for the createNetworkOffering API call. And when someone calls the API to assign a cert to LB we can check if this network offering has SSL termination enabled. Does this make sense? So there is notion of network service and network service capability [2]. I would attribute 'SSL termination' as capability of LB service. createNetworkOffering API take a capability list. It does make sense to check if the network offering has SSL termination enabled when API to assign a cert to LB is called. Also note that, 'Network Elements' declare their capabilities for the supported services. So it can verified that service provider for LB actually supports 'SSL termination' capability while creating network offering. Also when you say usage event, what does this imply? I am sorry I am not familiar with that term. Can you please elaborate. Its an event generated and persisted in the DB for every resource consumption and release. These events are used for billing etc. Please check publishUsageEvent calls in the code. [1] http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_User.html [2] api/src/com/cloud/network/Network.java
the plea to openstack
http://stochasticresonance.wordpress.com/2013/11/04/openstack-a-plea/ I thought this was an interesting read. There might be some things CloudStack could learn or issues it could avoid by keeping some of his points in mind.
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 6, 2013, 4:57 p.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs (updated) - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 8d841d8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 80a4036 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 26e4abf Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Not tested. Thanks, bharat kumar
What is the cloudstack branch that has same codes with CloudPlatform-4.2.0-2-rhel6.4?
Is it master or any other branch? Thanks Alex Ough
Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs
On 06/11/13 12:40 AM, Syed Ahmed sah...@cloudops.com wrote: On Nov. 5, 2013, 9:43 a.m., Murali Reddy wrote: api/src/com/cloud/network/lb/LoadBalancingRule.java, lines 42-43 https://reviews.apache.org/r/14976/diff/3/?file=374393#file374393line42 can you please add new constructors which takes ssl cert and protocol. If we extend same constructor then its resulting unnecessary changes in internal lb, elastic lb code as well. I have added an new constructor and removed all reverted all the invocations in internal lb and elastic lb code. I am sorry but I am not aware of the difference between different LB types in cloudstack. Is there some place where I can find more info on this ? On Nov. 5, 2013, 9:43 a.m., Syed Ahmed wrote: - i dont see certificate details in the load balancer response obtained from listLoadBalancerRules.Does it make sense to give the certificate details if there is a cert assigined to load balancer rule? - i dont see code to add a network offering with 'SslTermination'capability. Also list network offering, should show if LB service with SSL termination is supported by the offering. - Please add Apache license header to all files. 1) I was looking at the listLoadBalancerRules API and it does not list other things bound to the lb rule like stickiness policy or health check policy so I assumed that SSL certs being something like health check will not be in the response. If it makes sense to add them, I will gladly do so. Yes, you are right. I was assuming that in load balancer response, there should be details of associated stickiness policy etc, but looks like lb response need to be fixed across the board. If its not too much of a change please add the certificate details associated with lb rule in the lb rule response. 2) So what you are saying is that Ssltermination will be a service offering like DNS, DHCP etc? Right now, if you see the NetscalerElement.java, I have just added the SslTermination capability as true. Does this suffice? So there is network service and network service capabilities. I meant 'ssltermination' to be a capability of lb service. When you create network offering, you can say 'LB' service and service capability 'ssltermination' is enabled by the network offering. So in only networks created with such network offering, SSL termination functionality can be available. Also, there need to be service capability matched against the advertised capabilities of network service provider. For eg. If one creates network offering which says LB service with SslCapability enabled with virtual router providing LB service should fail because VR does not advertise the capabilities in VirtualRouter Network Element. Same should succeed if NetScaler is chosen as service provider because NetScaler element advertised the capability. 3) Done
Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28272 --- patch does not apply on master. please rebase with latest master and update the patch - Murali Reddy On Nov. 6, 2013, 12:54 a.m., Syed Ahmed wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 6, 2013, 12:54 a.m.) Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang. Bugs: CLOUDSTACK-4821 https://issues.apache.org/jira/browse/CLOUDSTACK-4821 Repository: cloudstack-git Description --- This is the second patch for SSL termination support. This patch impletements the assginement of certificate to loadbalancers. Support for netscaler is also added. Due to the version of netscaler API in CS, I could not add support for certificate chain. This should not be a big change however. We can discuss this. NOTE: Because I cannot diff with my local branch, this patch also includes the first patch which includes certificate management logic ... sorry Diffs - api/src/com/cloud/agent/api/to/LoadBalancerTO.java df2f8a8 api/src/com/cloud/event/EventTypes.java a762606 api/src/com/cloud/network/Network.java 49f380b api/src/com/cloud/network/lb/CertService.java PRE-CREATION api/src/com/cloud/network/lb/LoadBalancingRule.java 4b37782 api/src/com/cloud/network/lb/LoadBalancingRulesService.java 59d5c8d api/src/com/cloud/network/lb/SslCert.java PRE-CREATION api/src/org/apache/cloudstack/api/ApiConstants.java c75e6a0 api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java a368436 api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 2a3520b client/tomcatconf/nonossComponentContext.xml.in 9d1da95 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 3a51e8a engine/components-api/src/com/cloud/network/lb/LoadBalancingRulesManager.java 3e32585 engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerVO.java fee88cf engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java ab414de plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java b6269eb plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java 82f90fb plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java d63b14f plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java fe072e1 server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java dd48930 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java c685ee3 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 3dfcad5 server/src/com/cloud/server/ManagementServerImpl.java 699f469 server/src/org/apache/cloudstack/network/lb/ApplicationLoadBalancerManagerImpl.java 2385edc server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68 server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java PRE-CREATION server/test/org/apache/cloudstack/network/lb/CertServiceTest.java PRE-CREATION server/test/resources/certs/bad_format_cert.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.key
Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28273 --- patch does not apply on master. please rebase with latest master and update the patch - Murali Reddy On Nov. 6, 2013, 12:54 a.m., Syed Ahmed wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 6, 2013, 12:54 a.m.) Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang. Bugs: CLOUDSTACK-4821 https://issues.apache.org/jira/browse/CLOUDSTACK-4821 Repository: cloudstack-git Description --- This is the second patch for SSL termination support. This patch impletements the assginement of certificate to loadbalancers. Support for netscaler is also added. Due to the version of netscaler API in CS, I could not add support for certificate chain. This should not be a big change however. We can discuss this. NOTE: Because I cannot diff with my local branch, this patch also includes the first patch which includes certificate management logic ... sorry Diffs - api/src/com/cloud/agent/api/to/LoadBalancerTO.java df2f8a8 api/src/com/cloud/event/EventTypes.java a762606 api/src/com/cloud/network/Network.java 49f380b api/src/com/cloud/network/lb/CertService.java PRE-CREATION api/src/com/cloud/network/lb/LoadBalancingRule.java 4b37782 api/src/com/cloud/network/lb/LoadBalancingRulesService.java 59d5c8d api/src/com/cloud/network/lb/SslCert.java PRE-CREATION api/src/org/apache/cloudstack/api/ApiConstants.java c75e6a0 api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java a368436 api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 2a3520b client/tomcatconf/nonossComponentContext.xml.in 9d1da95 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 3a51e8a engine/components-api/src/com/cloud/network/lb/LoadBalancingRulesManager.java 3e32585 engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerVO.java fee88cf engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java ab414de plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java b6269eb plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java 82f90fb plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java d63b14f plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java fe072e1 server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java dd48930 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java c685ee3 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 3dfcad5 server/src/com/cloud/server/ManagementServerImpl.java 699f469 server/src/org/apache/cloudstack/network/lb/ApplicationLoadBalancerManagerImpl.java 2385edc server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68 server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java PRE-CREATION server/test/org/apache/cloudstack/network/lb/CertServiceTest.java PRE-CREATION server/test/resources/certs/bad_format_cert.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.key
Re: What is the cloudstack branch that has same codes with CloudPlatform-4.2.0-2-rhel6.4?
4.2 but specifically the 4.2.0 tag On Nov 6, 2013, at 9:18 AM, Alex Ough alex.o...@sungard.com wrote: Is it master or any other branch? Thanks Alex Ough
Re: Need edit access to Apache Jira
I also need write access, at least to be able to assign issues to myself. My username is kocka. Thx! On Wed, Nov 6, 2013 at 1:07 PM, Pavan Bandarupally pavan.bandarupa...@citrix.com wrote: Hi , I am not able to close issues that I have verified in issues.apache.org . My user name is pavanb. Can you please give those permissions to my id. Regards, Pavan -- EOF
Re: What is the cloudstack branch that has same codes with CloudPlatform-4.2.0-2-rhel6.4?
OK, thanks! On Wed, Nov 6, 2013 at 11:25 AM, Chip Childers chip.child...@gmail.comwrote: 4.2 but specifically the 4.2.0 tag On Nov 6, 2013, at 9:18 AM, Alex Ough alex.o...@sungard.com wrote: Is it master or any other branch? Thanks Alex Ough
Re: [New Feature FS] SSL Offload Support for Cloudstack
Just want to mention that if certificates are managed, this would be fairly simple to add to VPC routers as well. The haproxy loadbalancer config would just need to be passed the cert and a slightly different config. So hopefully it has been implemented in such a way that it's easy to reuse for VPC, the certs aren't tied to netscaler objects or something like that. On Wed, Nov 6, 2013 at 9:25 AM, Syed Ahmed sah...@cloudops.com wrote: Hi All, Many thanks to Darren and Murali for reviewing my code. I feel that the code is in a good condition to be merged into the master. I see that the code freeze is at the end of this week. Is it possible for my patch to be merged by then? Is it a hard deadline? Thanks, -Syed On Mon 04 Nov 2013 11:45:15 AM EST, Syed Ahmed wrote: Hi All, I would like to get this code into 4.3. Is it possible for this to be reviewed? Is there anything needed from my side? I would be glad to provide more information. Thanks, -Syed On Wed 30 Oct 2013 03:25:12 PM EDT, Syed Ahmed wrote: Hi All, I have the patch for adding SSL termination support at https://reviews.apache.org/r/14976/ . It would be great if this can be reviewed. Thanks, -Syed On 13-10-15 03:01 AM, Murali Reddy wrote: On 11/10/13 9:31 PM, Syed Ahmed sah...@cloudops.com wrote: Thanks for your valuable feedback Murali. Here are my comments. IMO, its better we introduce new api's say registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalancer than force fit existing API's for associate/dis-associate certificates. Personally, I was going to do it this way. But I am not sure how good of an idea it is to add a new api just for this feature as I can see assignToLoadbalancer is semantically similar. But if everyone agrees I have no problem with it. CloudStack already has distinct API's for each of the LB sub-functionality (health check, stickiness etc) [1]. We are not adding any redundant API, so resulting API are much cleaner just managing SSL termination for a LB rule. On second thought may be an CloudStack usage event on assigning certificate seems good enough to me. So what I got from your earlier post was that when adding a network offering the provider can choose to enable SSL Termination or not as it is a value added service. I was thinking of adding SSL termination under supportedservices for the createNetworkOffering API call. And when someone calls the API to assign a cert to LB we can check if this network offering has SSL termination enabled. Does this make sense? So there is notion of network service and network service capability [2]. I would attribute 'SSL termination' as capability of LB service. createNetworkOffering API take a capability list. It does make sense to check if the network offering has SSL termination enabled when API to assign a cert to LB is called. Also note that, 'Network Elements' declare their capabilities for the supported services. So it can verified that service provider for LB actually supports 'SSL termination' capability while creating network offering. Also when you say usage event, what does this imply? I am sorry I am not familiar with that term. Can you please elaborate. Its an event generated and persisted in the DB for every resource consumption and release. These events are used for billing etc. Please check publishUsageEvent calls in the code. [1] http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_User.html [2] api/src/com/cloud/network/Network.java
Re: Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
On Nov. 3, 2013, 7:45 p.m., daan Hoogland wrote: can you test and submit for master as well? d6420cd91ebb493e8b9d4220e95b7a3250272db3 do you want me to submit a separate review for the master fix? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15181/#review28081 --- On Nov. 1, 2013, 3:52 p.m., David Grizzanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15181/ --- (Updated Nov. 1, 2013, 3:52 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-5023 https://issues.apache.org/jira/browse/CLOUDSTACK-5023 Repository: cloudstack-git Description --- CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled Added logic so that a correct zoneID is passed when generating usage events while deleting port forwarding rules: - Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab zone id and pass to publishUsageEvent Diffs - server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08 Diff: https://reviews.apache.org/r/15181/diff/ Testing --- Tested on 4.2.0 tag Thanks, David Grizzanti
Re: Review Request 15050: Add Palo Alto Networks Firewall Integration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#review28280 --- Ship it! Ship It! - Sheng Yang On Nov. 6, 2013, 3:42 a.m., Will Stevens wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/ --- (Updated Nov. 6, 2013, 3:42 a.m.) Review request for cloudstack and Sheng Yang. Bugs: CLOUDSTACK-1275 https://issues.apache.org/jira/browse/CLOUDSTACK-1275 Repository: cloudstack-git Description --- More information in the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration This patch adds a network plugin which adds support for the Palo Alto Networks firewall (their appliance and their VM series firewall). Features supported are: - List/Add/Delete Palo Alto service provider - List/Add/Delete Palo Alto network service offering - List/Add/Delete Palo Alto network with above service offering - Add instance to the new network (creates the public IP and private gateway/cidr on the PA as well as the source nat rule) - List/Add/Delete Ingress Firewall rule - List/Add/Delete Egress Firewall rule - List/Add/Delete Port Forwarding rule - List/Add/Delete Static Nat rule - Supports Palo Alto Networks 'Log Forwarding' profile globally per device (additional docs to come) - Supports Palo Alto Networks 'Security Profile Groups' functionality globally per device (additional docs to come) Knowns limitations: - Only supports one public IP range in CloudStack. - Currently not verifying SSL certificates when creating a connection between CloudStack and the Palo Alto Networks firewall. - Currently not tracking usage on Public IPs. Diffs - api/src/com/cloud/network/Network.java bda3326 api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java 4983255 api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java 0b7836d api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 29ce2e3 client/WEB-INF/classes/resources/messages.properties d548527 client/pom.xml 54cb667 client/tomcatconf/commands.properties.in 8cbe972 plugins/network-elements/palo-alto/pom.xml PRE-CREATION plugins/network-elements/palo-alto/resources/META-INF/cloudstack/paloalto/module.properties PRE-CREATION plugins/network-elements/palo-alto/resources/META-INF/cloudstack/paloalto/spring-paloalto-context.xml PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListExternalFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/response/PaloAltoFirewallResponse.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoExternalFirewallElement.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoFirewallElementService.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/resource/PaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java PRE-CREATION plugins/pom.xml 4f193bc server/src/com/cloud/api/ApiResponseHelper.java 769d345 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa ui/dictionary.jsp 85f24c6 ui/scripts/docs.js 3a4f8ca ui/scripts/system.js 1579d16 Diff: https://reviews.apache.org/r/15050/diff/ Testing --- I have tested all of the functionality listed under 'supported features'. Unit tests are in file 24 and 25 of this patch. The details of the tests can be found in the
Re: Review Request 15050: Add Palo Alto Networks Firewall Integration
On Nov. 6, 2013, 6:08 p.m., Sheng Yang wrote: Ship It! Committed to MASTER. Thank you Will! - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#review28280 --- On Nov. 6, 2013, 3:42 a.m., Will Stevens wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/ --- (Updated Nov. 6, 2013, 3:42 a.m.) Review request for cloudstack and Sheng Yang. Bugs: CLOUDSTACK-1275 https://issues.apache.org/jira/browse/CLOUDSTACK-1275 Repository: cloudstack-git Description --- More information in the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration This patch adds a network plugin which adds support for the Palo Alto Networks firewall (their appliance and their VM series firewall). Features supported are: - List/Add/Delete Palo Alto service provider - List/Add/Delete Palo Alto network service offering - List/Add/Delete Palo Alto network with above service offering - Add instance to the new network (creates the public IP and private gateway/cidr on the PA as well as the source nat rule) - List/Add/Delete Ingress Firewall rule - List/Add/Delete Egress Firewall rule - List/Add/Delete Port Forwarding rule - List/Add/Delete Static Nat rule - Supports Palo Alto Networks 'Log Forwarding' profile globally per device (additional docs to come) - Supports Palo Alto Networks 'Security Profile Groups' functionality globally per device (additional docs to come) Knowns limitations: - Only supports one public IP range in CloudStack. - Currently not verifying SSL certificates when creating a connection between CloudStack and the Palo Alto Networks firewall. - Currently not tracking usage on Public IPs. Diffs - api/src/com/cloud/network/Network.java bda3326 api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java 4983255 api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java 0b7836d api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 29ce2e3 client/WEB-INF/classes/resources/messages.properties d548527 client/pom.xml 54cb667 client/tomcatconf/commands.properties.in 8cbe972 plugins/network-elements/palo-alto/pom.xml PRE-CREATION plugins/network-elements/palo-alto/resources/META-INF/cloudstack/paloalto/module.properties PRE-CREATION plugins/network-elements/palo-alto/resources/META-INF/cloudstack/paloalto/spring-paloalto-context.xml PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListExternalFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/api/response/PaloAltoFirewallResponse.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoExternalFirewallElement.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/element/PaloAltoFirewallElementService.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/resource/PaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/MockablePaloAltoResource.java PRE-CREATION plugins/network-elements/palo-alto/test/com/cloud/network/resource/PaloAltoResourceTest.java PRE-CREATION plugins/pom.xml 4f193bc server/src/com/cloud/api/ApiResponseHelper.java 769d345 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa ui/dictionary.jsp 85f24c6 ui/scripts/docs.js 3a4f8ca ui/scripts/system.js 1579d16 Diff: https://reviews.apache.org/r/15050/diff/ Testing --- I have tested all of the functionality listed under 'supported features'. Unit tests are in file
Re: [Merge] Palo Alto Networks firewall integration to master
Looks good to me. Applied to MASTER branch. Thanks! --Sheng On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens wstev...@cloudops.com wrote: @Sheng: This should be ready to go now. I built the patch from tonight's master and I included a more detailed commit message as you requested. Let me know if you have any questions/problems... @David: As per this discussion (and a previous one [1]), I have moved this code from being built with the depreciated 'nonoss' flag to core since it does not depend on any 3rd party libraries at build or runtime. Cheers, Will [1] http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens wstev...@cloudops.com wrote: Thanks for that David. You are absolutely correct, this plugin has no dependencies on any 3rd party code at build or runtime. Everything the plugin requires is built into the plugin. I was unclear if its dependance on a 3rd party API and appliance to be functional was relevant. I think you are right. I think it should probably be in the core build. I will make that change when I merge in the latest master for Sheng and rebuild the patch. Thanks, Will On Tue, Nov 5, 2013 at 10:19 AM, David Nalley da...@gnsa.us wrote: So perhaps a bit of history. nonoss/noredist is for targets that aren't built 'by default' (e.g. you must explicitly turn them on). We do this because the ASF wants the default build to be truly unencumbered and where there are dependencies on non-open source, or non-Apache compatible code, we typically turn them off. In example: historically, Netscaler libraries were not open source, and we had a dependency on those libraries, so we placed the netscaler plugin into the nonoss. Since then the netscaler libraries have been open sourced, and we could move those out of noredist. So - is there third party code that you have as a build or runtime dependency? If so what is the license for that third party code? (My really fast perusal didn't catch anything that was immediately troubling) --David On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens wstev...@cloudops.com wrote: Its dependence on a third party API and appliance, similar to the srx and netscaler. I am not convinced it should be in noredist, but I was following the same model as other similar plugins. Feedback on this would be helpful. Ws On Tuesday, November 5, 2013, David Nalley wrote: On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens wstev...@cloudops.com javascript:; wrote: Sheng, I will rebuild the patch for the latest master. The latest master has depreciated the 'nonoss' flag in favour of 'noredist'. I was building in nonoss previously. I am guessing I should use the noredist flag now? Will - what is causing this to be noredist/nonoss? My quick perusal of your patch didn't surface anything that would push it into that category. --David
Re: JavaScript Question
This is just a guess, but I'm thinking if the checkbox is not visible, then
:checked always returns false (which would be weird).
I do make the checkbox visible before using :checked, but it's possible
this visibility change doesn't take effect until after the event handler
finishes.
Any thoughts on this from people who do a lot of JavaScript (or anyone
else, of course). :)
$isCustomizedIops.css('display', 'inline-block');
if
($isCustomizedIops.is(':checked')) {
$minIops.hide();
$maxIops.hide();
} else {
$minIops.css('display', 'inline-block');
$maxIops.css('display', 'inline-block');
}
On Tue, Nov 5, 2013 at 10:50 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Hi,
Does anyone know why this checkbox of mine always returns false?
if ($isCustomizedIops.is(':checked')) {
// do some stuff
}
That code is part of an event handler for a combobox (when the combobox
changes to a certain state, I want to see if the checkbox that is revealed
is in the checked state):
args.$select.change(function() {
var $isCustomizedIops = $form.find('.form-item[rel=isCustomizedIops]');
if ($isCustomizedIops.is(':checked')) {
// do some stuff
}
}
The checkbox is set up like this:
isCustomizedIops: {
label: 'label.custom.disk.iops',
docID:
'helpDiskOfferingCustomDiskIops',
isBoolean: true,
isReverse: true,
isChecked: false
},
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*
Re: [Merge] Palo Alto Networks firewall integration to master
Great! Thank you Sheng... On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang sh...@yasker.org wrote: Looks good to me. Applied to MASTER branch. Thanks! --Sheng On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens wstev...@cloudops.com wrote: @Sheng: This should be ready to go now. I built the patch from tonight's master and I included a more detailed commit message as you requested. Let me know if you have any questions/problems... @David: As per this discussion (and a previous one [1]), I have moved this code from being built with the depreciated 'nonoss' flag to core since it does not depend on any 3rd party libraries at build or runtime. Cheers, Will [1] http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Palo+Alto On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens wstev...@cloudops.com wrote: Thanks for that David. You are absolutely correct, this plugin has no dependencies on any 3rd party code at build or runtime. Everything the plugin requires is built into the plugin. I was unclear if its dependance on a 3rd party API and appliance to be functional was relevant. I think you are right. I think it should probably be in the core build. I will make that change when I merge in the latest master for Sheng and rebuild the patch. Thanks, Will On Tue, Nov 5, 2013 at 10:19 AM, David Nalley da...@gnsa.us wrote: So perhaps a bit of history. nonoss/noredist is for targets that aren't built 'by default' (e.g. you must explicitly turn them on). We do this because the ASF wants the default build to be truly unencumbered and where there are dependencies on non-open source, or non-Apache compatible code, we typically turn them off. In example: historically, Netscaler libraries were not open source, and we had a dependency on those libraries, so we placed the netscaler plugin into the nonoss. Since then the netscaler libraries have been open sourced, and we could move those out of noredist. So - is there third party code that you have as a build or runtime dependency? If so what is the license for that third party code? (My really fast perusal didn't catch anything that was immediately troubling) --David On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens wstev...@cloudops.com wrote: Its dependence on a third party API and appliance, similar to the srx and netscaler. I am not convinced it should be in noredist, but I was following the same model as other similar plugins. Feedback on this would be helpful. Ws On Tuesday, November 5, 2013, David Nalley wrote: On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens wstev...@cloudops.com javascript:; wrote: Sheng, I will rebuild the patch for the latest master. The latest master has depreciated the 'nonoss' flag in favour of 'noredist'. I was building in nonoss previously. I am guessing I should use the noredist flag now? Will - what is causing this to be noredist/nonoss? My quick perusal of your patch didn't surface anything that would push it into that category. --David
Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs
On 13-11-06 12:18 PM, Murali Reddy wrote: On 06/11/13 12:40 AM, Syed Ahmed sah...@cloudops.com wrote: On Nov. 5, 2013, 9:43 a.m., Murali Reddy wrote: api/src/com/cloud/network/lb/LoadBalancingRule.java, lines 42-43 https://reviews.apache.org/r/14976/diff/3/?file=374393#file374393line42 can you please add new constructors which takes ssl cert and protocol. If we extend same constructor then its resulting unnecessary changes in internal lb, elastic lb code as well. I have added an new constructor and removed all reverted all the invocations in internal lb and elastic lb code. I am sorry but I am not aware of the difference between different LB types in cloudstack. Is there some place where I can find more info on this ? On Nov. 5, 2013, 9:43 a.m., Syed Ahmed wrote: - i dont see certificate details in the load balancer response obtained from listLoadBalancerRules.Does it make sense to give the certificate details if there is a cert assigined to load balancer rule? - i dont see code to add a network offering with 'SslTermination'capability. Also list network offering, should show if LB service with SSL termination is supported by the offering. - Please add Apache license header to all files. 1) I was looking at the listLoadBalancerRules API and it does not list other things bound to the lb rule like stickiness policy or health check policy so I assumed that SSL certs being something like health check will not be in the response. If it makes sense to add them, I will gladly do so. Yes, you are right. I was assuming that in load balancer response, there should be details of associated stickiness policy etc, but looks like lb response need to be fixed across the board. If its not too much of a change please add the certificate details associated with lb rule in the lb rule response. I am a but reticent on adding this with this patch as the createLoadBalancerResponse() in ApiResponseHelper does not take other parameters and I don't see any use of DAO objects in that class. I am guessing this is a design decision and I don't want to mess with the existing practices by polluting ApiResponseHelper. I will fix all the LB responses in another patch if that is OK with you. 2) So what you are saying is that Ssltermination will be a service offering like DNS, DHCP etc? Right now, if you see the NetscalerElement.java, I have just added the SslTermination capability as true. Does this suffice? So there is network service and network service capabilities. I meant 'ssltermination' to be a capability of lb service. When you create network offering, you can say 'LB' service and service capability 'ssltermination' is enabled by the network offering. So in only networks created with such network offering, SSL termination functionality can be available. Also, there need to be service capability matched against the advertised capabilities of network service provider. For eg. If one creates network offering which says LB service with SslCapability enabled with virtual router providing LB service should fail because VR does not advertise the capabilities in VirtualRouter Network Element. Same should succeed if NetScaler is chosen as service provider because NetScaler element advertised the capability. Right now SslTermination is a LB capability and is enabled by default in NetScaler. We had decided that instead of having enable/disable for this functionality, we would be billing based on the events generated when certs are assigned to the LB rules. This was to simplify the implementation and not end up with cases like you mentioned above. Now the problem here is if I try to assign a certificate to lets say an F5 loadbalancer. It should error out saying that Ssl termination is not supported ( yet ). One way I see that is to check for certificate when calling canHandleRule() in the F5's element. But this has to be done for all loadbalancers. Is there a better way of doing this? 3) Done
Re: Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
On Nov. 3, 2013, 7:45 p.m., daan Hoogland wrote: can you test and submit for master as well? d6420cd91ebb493e8b9d4220e95b7a3250272db3 David Grizzanti wrote: do you want me to submit a separate review for the master fix? master seems a bit different in terms of the simulator and the usage event configuration (Spring configurations were moved around). I'll close this review and open a new one once I have the master patch working. Will keep the Jira open though and update with a comment. Thanks! - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15181/#review28081 --- On Nov. 1, 2013, 3:52 p.m., David Grizzanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15181/ --- (Updated Nov. 1, 2013, 3:52 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-5023 https://issues.apache.org/jira/browse/CLOUDSTACK-5023 Repository: cloudstack-git Description --- CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled Added logic so that a correct zoneID is passed when generating usage events while deleting port forwarding rules: - Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab zone id and pass to publishUsageEvent Diffs - server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08 Diff: https://reviews.apache.org/r/15181/diff/ Testing --- Tested on 4.2.0 tag Thanks, David Grizzanti
Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15280/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5062 https://issues.apache.org/jira/browse/CLOUDSTACK-5062 Repository: cloudstack-git Description --- CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules: - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e Diff: https://reviews.apache.org/r/15280/diff/ Testing --- Testing only on 4.2 Thanks, David Grizzanti
RE: [JENKINS] Preparing for the 4.3 branch
Thanks Hugo for taking care of these. Do you mind taking a moment to update Release Management wiki page [1] on what it takes to set up Jenkins build jobs for a new release. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Management -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Wednesday, November 06, 2013 2:16 AM To: dev@cloudstack.apache.org Subject: [JENKINS] Preparing for the 4.3 branch I've setup all the jenkins jobs for the release branch and a pipeline view. When the branch is cut we only need to enable the jobs. http://jenkins.buildacloud.org/view/4.3/ http://jenkins.buildacloud.org/view/cloudstack-4.3-pipeline/ Cheers, Hugo
RE: [JENKINS] Preparing for the 4.3 branch
Prasanna I have added a link to your newly added wiki page, but need more information for a beginner to clone the build jobs for a new release -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Wednesday, November 06, 2013 11:41 AM To: dev@cloudstack.apache.org Subject: RE: [JENKINS] Preparing for the 4.3 branch Thanks Hugo for taking care of these. Do you mind taking a moment to update Release Management wiki page [1] on what it takes to set up Jenkins build jobs for a new release. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Managemen t -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Wednesday, November 06, 2013 2:16 AM To: dev@cloudstack.apache.org Subject: [JENKINS] Preparing for the 4.3 branch I've setup all the jenkins jobs for the release branch and a pipeline view. When the branch is cut we only need to enable the jobs. http://jenkins.buildacloud.org/view/4.3/ http://jenkins.buildacloud.org/view/cloudstack-4.3-pipeline/ Cheers, Hugo
Re: the plea to openstack
Agreed it's a very good read. -Sebastien On 6 Nov 2013, at 17:34, Marcus Sorensen shadow...@gmail.com wrote: http://stochasticresonance.wordpress.com/2013/11/04/openstack-a-plea/ I thought this was an interesting read. There might be some things CloudStack could learn or issues it could avoid by keeping some of his points in mind.
RE: Master : Automation result on KVM and vmware
Thanks Likitha for fixing VMware blocker https://issues.apache.org/jira/browse/CLOUDSTACK-5051 Automation executed in vmware, below issues observed with vmware run. https://issues.apache.org/jira/browse/CLOUDSTACK-5047 https://issues.apache.org/jira/browse/CLOUDSTACK-5045 https://issues.apache.org/jira/browse/CLOUDSTACK-4833 https://issues.apache.org/jira/browse/CLOUDSTACK-5063 https://issues.apache.org/jira/browse/CLOUDSTACK-4835 Regards, Rayees -Original Message- From: Rayees Namathponnan Sent: Tuesday, November 05, 2013 7:52 PM To: dev@cloudstack.apache.org Subject: RE: Master : Automation result on KVM and vmware Thanks Min for fixing vmware blocker https://issues.apache.org/jira/browse/CLOUDSTACK-5046 Found another automation blocker in vmware https://issues.apache.org/jira/browse/CLOUDSTACK-5051 Regards, Rayees -Original Message- From: Rayees Namathponnan [mailto:rayees.namathpon...@citrix.com] Sent: Tuesday, November 05, 2013 4:13 PM To: dev@cloudstack.apache.org Subject: Master : Automation result on KVM and vmware Hi All, I have executed automation with latest master build on KVM and VMware. VMware automation completed broken due to https://issues.apache.org/jira/browse/CLOUDSTACK-5046 Below issues found with KVM runs https://issues.apache.org/jira/browse/CLOUDSTACK-5050 https://issues.apache.org/jira/browse/CLOUDSTACK-5049 https://issues.apache.org/jira/browse/CLOUDSTACK-5047 https://issues.apache.org/jira/browse/CLOUDSTACK-5046 https://issues.apache.org/jira/browse/CLOUDSTACK-5045 https://issues.apache.org/jira/browse/CLOUDSTACK-4835 Regards, Rayees
Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 6, 2013, 8:15 p.m.) Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang. Changes --- Final patch with the master. Bugs: CLOUDSTACK-4821 https://issues.apache.org/jira/browse/CLOUDSTACK-4821 Repository: cloudstack-git Description --- This is the second patch for SSL termination support. This patch impletements the assginement of certificate to loadbalancers. Support for netscaler is also added. Due to the version of netscaler API in CS, I could not add support for certificate chain. This should not be a big change however. We can discuss this. NOTE: Because I cannot diff with my local branch, this patch also includes the first patch which includes certificate management logic ... sorry Diffs (updated) - CHANGES 054e7b0 api/src/com/cloud/agent/api/to/LoadBalancerTO.java df2f8a8 api/src/com/cloud/event/EventTypes.java d9f80eb api/src/com/cloud/network/Network.java 318ac19 api/src/com/cloud/network/lb/CertService.java PRE-CREATION api/src/com/cloud/network/lb/LoadBalancingRule.java 4b37782 api/src/com/cloud/network/lb/LoadBalancingRulesService.java 59d5c8d api/src/com/cloud/network/lb/SslCert.java PRE-CREATION api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java a368436 api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION client/tomcatconf/commands.properties.in 087d8b9 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 3a51e8a engine/components-api/src/com/cloud/network/lb/LoadBalancingRulesManager.java 3e32585 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerVO.java fee88cf engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 5c6f2e7 plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java b6269eb plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java 82f90fb plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java 8101864 plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java fe072e1 server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml 5e37908 server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 6ca40c0 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 0d43478 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/server/ManagementServerImpl.java 79b20d0 server/src/org/apache/cloudstack/network/lb/ApplicationLoadBalancerManagerImpl.java b7cd231 server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68 server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java PRE-CREATION server/test/org/apache/cloudstack/network/lb/CertServiceTest.java PRE-CREATION server/test/resources/certs/bad_format_cert.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.crt PRE-CREATION server/test/resources/certs/dsa_self_signed.key PRE-CREATION server/test/resources/certs/expired_cert.crt PRE-CREATION server/test/resources/certs/non_x509_pem.crt PRE-CREATION server/test/resources/certs/root_chain.crt PRE-CREATION server/test/resources/certs/rsa_ca_signed.crt PRE-CREATION
RE: the plea to openstack
The Conway Law reference is a good to keep in mind as we enter the next collab conference. (http://en.wikipedia.org/wiki/Conway's_law) -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: 06 November 2013 20:02 To: dev@cloudstack.apache.org Subject: Re: the plea to openstack Agreed it's a very good read. -Sebastien On 6 Nov 2013, at 17:34, Marcus Sorensen shadow...@gmail.com wrote: http://stochasticresonance.wordpress.com/2013/11/04/openstack-a-plea/ I thought this was an interesting read. There might be some things CloudStack could learn or issues it could avoid by keeping some of his points in mind.
RE: ComponentContext :: getComponent() ?
I used to call getComponent() to get the current list of AffinityGroupProcessors enabled by the admin. The injected processor list was added later to the class, I think I can use that for this purpose. Thanks, Prachi -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: Tuesday, November 05, 2013 10:09 PM To: dev@cloudstack.apache.org Subject: Re: ComponentContext :: getComponent() ? All other uses of getComponent() you listed should work fine. In org.apache.cloudstack.affinity.AffinityGroupServiceImpl, why do you even call getComponent()? You already have a list of AffinityGroupProcessors injected to the class. Can't you just loop through those? Darren On Tue, Nov 5, 2013 at 5:49 PM, Prachi Damle prachi.da...@citrix.comwrote: Thanks Darren, it is the listAffinityGroupTypes API, specific code is in AffinityGroupServiceImpl :: listAffinityGroupTypes() Code lists the beans implementing 'AffinityGroupProcessor' adapter interface. I also dug up few other callers that rely on ComponentContext :: getComponent()... com.cloud.baremetal.networkservice.BareMetalResourceBase.fullSync() com.cloud.network.NetworkStateListener.pubishOnEventBus(String, String, Network, State, State) com.cloud.storage.listener.SnapshotStateListener.pubishOnEventBus(String, String, Snapshot, State, State) com.cloud.vm.UserVmStateListener.pubishOnEventBus(String, String, VirtualMachine, State, State) com.cloud.storage.listener.VolumeStateListener.pubishOnEventBus(String, String, Volume, State, State) com.cloud.event.AlertGenerator.publishAlertOnEventBus(String, long, Long, String, String) com.cloud.event.ActionEventUtils.publishOnEventBus(long, long, String, String, State, String) com.cloud.event.UsageEventUtils.publishUsageEvent(String, Long, Long, String, String) -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: Tuesday, November 05, 2013 4:40 PM To: dev@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: ComponentContext :: getComponent() ? Can you point me to the code that is failing. The short of it is that you shouldn't use ComponentContext. If you show me the failing code I can offer a better solution or if needed a work around. Darren On Nov 5, 2013, at 4:18 PM, Prachi Damle prachi.da...@citrix.com wrote: Hi, Before the Spring modularization, we have some usecases that were using the com.cloud.utils.component.ComponentContext class directly to inject or to find a bean of given type or name by invoking ComponentContext :: getComponent(). How should these usecases be ported now after the modularization changes? What should we use instead of ComponentContext, to say find beans of certain type. This is the root cause for bug https://issues.apache.org/jira/browse/CLOUDSTACK-5045 as the code is still relying on ComponentContext Thanks, Prachi
RE: ComponentContext :: getComponent() ?
But in general, is there a way to get hold of a particular bean by name or type? -Original Message- From: Prachi Damle Sent: Wednesday, November 06, 2013 1:19 PM To: dev@cloudstack.apache.org Subject: RE: ComponentContext :: getComponent() ? I used to call getComponent() to get the current list of AffinityGroupProcessors enabled by the admin. The injected processor list was added later to the class, I think I can use that for this purpose. Thanks, Prachi -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: Tuesday, November 05, 2013 10:09 PM To: dev@cloudstack.apache.org Subject: Re: ComponentContext :: getComponent() ? All other uses of getComponent() you listed should work fine. In org.apache.cloudstack.affinity.AffinityGroupServiceImpl, why do you even call getComponent()? You already have a list of AffinityGroupProcessors injected to the class. Can't you just loop through those? Darren On Tue, Nov 5, 2013 at 5:49 PM, Prachi Damle prachi.da...@citrix.comwrote: Thanks Darren, it is the listAffinityGroupTypes API, specific code is in AffinityGroupServiceImpl :: listAffinityGroupTypes() Code lists the beans implementing 'AffinityGroupProcessor' adapter interface. I also dug up few other callers that rely on ComponentContext :: getComponent()... com.cloud.baremetal.networkservice.BareMetalResourceBase.fullSync() com.cloud.network.NetworkStateListener.pubishOnEventBus(String, String, Network, State, State) com.cloud.storage.listener.SnapshotStateListener.pubishOnEventBus(Stri ng, String, Snapshot, State, State) com.cloud.vm.UserVmStateListener.pubishOnEventBus(String, String, VirtualMachine, State, State) com.cloud.storage.listener.VolumeStateListener.pubishOnEventBus(String , String, Volume, State, State) com.cloud.event.AlertGenerator.publishAlertOnEventBus(String, long, Long, String, String) com.cloud.event.ActionEventUtils.publishOnEventBus(long, long, String, String, State, String) com.cloud.event.UsageEventUtils.publishUsageEvent(String, Long, Long, String, String) -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: Tuesday, November 05, 2013 4:40 PM To: dev@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: ComponentContext :: getComponent() ? Can you point me to the code that is failing. The short of it is that you shouldn't use ComponentContext. If you show me the failing code I can offer a better solution or if needed a work around. Darren On Nov 5, 2013, at 4:18 PM, Prachi Damle prachi.da...@citrix.com wrote: Hi, Before the Spring modularization, we have some usecases that were using the com.cloud.utils.component.ComponentContext class directly to inject or to find a bean of given type or name by invoking ComponentContext :: getComponent(). How should these usecases be ported now after the modularization changes? What should we use instead of ComponentContext, to say find beans of certain type. This is the root cause for bug https://issues.apache.org/jira/browse/CLOUDSTACK-5045 as the code is still relying on ComponentContext Thanks, Prachi
Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions
I'm having a difficulty finding documents about how to develop a plug-in. Anyone to help me find one? Thanks in advance. Alex Ough On Tue, Nov 5, 2013 at 2:18 PM, Alex Ough alex.o...@sungard.com wrote: OK. 1) Do you mean the plug-in? If so, let me find out how to develop a plug-in and work on this. 2) Sure, let me add more information in the document. Thanks for your suggestions. Alex Ough On Tue, Nov 5, 2013 at 11:41 AM, Chip Childers chipchild...@apache.orgwrote: Alex, I've moved your page to the Designs not committed to a release parent (instead of the 4.3 designs page), to align with both the Jira record *and* the fact that feature freeze is about to happen for 4.3. As for the proposal itself, I have a couple of suggestions: 1) I'd like to see the implementation be part of the ACS runtime. Having a separate python app for this sync feature seems like an admin burden. 2) As far as the design document itself, I think that we need to see more details on the proposed approach to sync, failure condition handling, etc... -chip On Mon, Nov 4, 2013 at 3:16 PM, Alex Ough alex.o...@sungard.com wrote: All, Among the 2 approaches, I uploaded the implemented codes of the first approach, master-slave architecture, here. https://github.com/alexoughsg/albatross And here is the design doc in the wiki. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions Please review them and let me know what you think if you're interested! Thanks Alex Ough On Thu, Oct 31, 2013 at 6:51 PM, Alex Ough alex.o...@sungard.com wrote: Great! Thanks a lot, Daan. On Thu, Oct 31, 2013 at 4:58 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: you are added to jira, Alex On Thu, Oct 31, 2013 at 8:31 PM, Alex Ough alex.o...@sungard.com wrote: Thanks Chip, and can you also give a permission in Jira so that I can assign myself in its jira? Alex Ough On Thu, Oct 31, 2013 at 2:00 PM, Chip Childers chipchild...@apache.org wrote: Permission added. On Wed, Oct 30, 2013 at 12:19:23PM -0500, Alex Ough wrote: And I'd like to write the design document in the wiki page, but I don't seem to have a permission to create pages. So can anyone give me the permission? My account in the wiki is alex.o...@sungard.com Thanks in advance. Alex Ough On Tue, Oct 29, 2013 at 3:38 PM, Alex Ough alex.o...@sungard.com wrote: I created a jira for this feature. https://issues.apache.org/jira/browse/CLOUDSTACK-4992 But it doesn't allow for me to assign it to myself, so any permission do I need for this? If so, can anyone give me this permission? If there is anything missing, let me know. Thanks Alex Ough On Fri, Oct 18, 2013 at 9:30 AM, Kishan Kavala kishan.kav...@citrix.comwrote: -Original Message- From: Alex Ough [mailto:alex.o...@sungard.com] Sent: Thursday, 17 October 2013 11:25 PM To: dev@cloudstack.apache.org; u...@cloudstack.apache.org Subject: Fwd: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions All, Currently, under the environment of cloudstack with multiple regions, each region has its own management server running with a separate database. So if we want to support multiple regions and provide one point of entry for a customer, we need to duplicate domain/account/user information of that customer to all of the databases of regions the customer accesses, which will cause data discrepancies when users update those data independently in each management server. So I'd like to provide a way to sync up the data using the messaging system introduced in 4.1.0. Using the events from each management server, updates from each region can be propagated to the rest regions and they can be executed accordingly. I hope you guys have a chance to think about this and give some feedbacks if interested. Thanks in advance. Alex Ough [KK] Alex, it was discussed sometime back. Related thread [1]. Sync up using messaging system is the right way to go. [1] http://www.mail-archive.com/cloudstack-dev@incubator.apache.org/msg20193.html
RE: JavaScript Question - $isCustomizedIops.is(':checked')
Mike,
Your $isCustomizedIops is something like:
div class=form-item
div class=name
labelCustom disk iops/label
/div
div class=vale
input type=checkbox checked=checked
/div
/div
So, if you want to know whether the checkbox is checked or not, you should use
($isCustomizedIops.find('input[type=checkbox]').is(':checked')
instead of
($isCustomizedIops.is(':checked')
Jessica
-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Wednesday, November 06, 2013 10:10 AM
To: dev@cloudstack.apache.org
Subject: Re: JavaScript Question
This is just a guess, but I'm thinking if the checkbox is not visible, then
:checked always returns false (which would be weird).
I do make the checkbox visible before using :checked, but it's possible
this visibility change doesn't take effect until after the event handler
finishes.
Any thoughts on this from people who do a lot of JavaScript (or anyone
else, of course). :)
$isCustomizedIops.css('display', 'inline-block');
if
($isCustomizedIops.is(':checked')) {
$minIops.hide();
$maxIops.hide();
} else {
$minIops.css('display', 'inline-block');
$maxIops.css('display', 'inline-block');
}
On Tue, Nov 5, 2013 at 10:50 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Hi,
Does anyone know why this checkbox of mine always returns false?
if ($isCustomizedIops.is(':checked')) {
// do some stuff
}
That code is part of an event handler for a combobox (when the combobox
changes to a certain state, I want to see if the checkbox that is revealed
is in the checked state):
args.$select.change(function() {
var $isCustomizedIops = $form.find('.form-item[rel=isCustomizedIops]');
if ($isCustomizedIops.is(':checked')) {
// do some stuff
}
}
The checkbox is set up like this:
isCustomizedIops: {
label: 'label.custom.disk.iops',
docID:
'helpDiskOfferingCustomDiskIops',
isBoolean: true,
isReverse: true,
isChecked: false
},
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*
Re: [New Feature FS] SSL Offload Support for Cloudstack
Yes, the certificates are managed separately from the Netscaler on cloudstack and get passed to the resource. Any other LB can implement the termination feature and use the certificates. On Wed 06 Nov 2013 12:36:26 PM EST, Marcus Sorensen wrote: Just want to mention that if certificates are managed, this would be fairly simple to add to VPC routers as well. The haproxy loadbalancer config would just need to be passed the cert and a slightly different config. So hopefully it has been implemented in such a way that it's easy to reuse for VPC, the certs aren't tied to netscaler objects or something like that. On Wed, Nov 6, 2013 at 9:25 AM, Syed Ahmed sah...@cloudops.com wrote: Hi All, Many thanks to Darren and Murali for reviewing my code. I feel that the code is in a good condition to be merged into the master. I see that the code freeze is at the end of this week. Is it possible for my patch to be merged by then? Is it a hard deadline? Thanks, -Syed On Mon 04 Nov 2013 11:45:15 AM EST, Syed Ahmed wrote: Hi All, I would like to get this code into 4.3. Is it possible for this to be reviewed? Is there anything needed from my side? I would be glad to provide more information. Thanks, -Syed On Wed 30 Oct 2013 03:25:12 PM EDT, Syed Ahmed wrote: Hi All, I have the patch for adding SSL termination support at https://reviews.apache.org/r/14976/ . It would be great if this can be reviewed. Thanks, -Syed On 13-10-15 03:01 AM, Murali Reddy wrote: On 11/10/13 9:31 PM, Syed Ahmed sah...@cloudops.com wrote: Thanks for your valuable feedback Murali. Here are my comments. IMO, its better we introduce new api's say registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalancer than force fit existing API's for associate/dis-associate certificates. Personally, I was going to do it this way. But I am not sure how good of an idea it is to add a new api just for this feature as I can see assignToLoadbalancer is semantically similar. But if everyone agrees I have no problem with it. CloudStack already has distinct API's for each of the LB sub-functionality (health check, stickiness etc) [1]. We are not adding any redundant API, so resulting API are much cleaner just managing SSL termination for a LB rule. On second thought may be an CloudStack usage event on assigning certificate seems good enough to me. So what I got from your earlier post was that when adding a network offering the provider can choose to enable SSL Termination or not as it is a value added service. I was thinking of adding SSL termination under supportedservices for the createNetworkOffering API call. And when someone calls the API to assign a cert to LB we can check if this network offering has SSL termination enabled. Does this make sense? So there is notion of network service and network service capability [2]. I would attribute 'SSL termination' as capability of LB service. createNetworkOffering API take a capability list. It does make sense to check if the network offering has SSL termination enabled when API to assign a cert to LB is called. Also note that, 'Network Elements' declare their capabilities for the supported services. So it can verified that service provider for LB actually supports 'SSL termination' capability while creating network offering. Also when you say usage event, what does this imply? I am sorry I am not familiar with that term. Can you please elaborate. Its an event generated and persisted in the DB for every resource consumption and release. These events are used for billing etc. Please check publishUsageEvent calls in the code. [1] http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_User.html [2] api/src/com/cloud/network/Network.java
Re: JavaScript Question - $isCustomizedIops.is(':checked')
Thanks, Jessica! That did the trick. :)
On Wed, Nov 6, 2013 at 3:10 PM, Jessica Wang jessica.w...@citrix.comwrote:
Mike,
Your $isCustomizedIops is something like:
div class=form-item
div class=name
labelCustom disk iops/label
/div
div class=vale
input type=checkbox checked=checked
/div
/div
So, if you want to know whether the checkbox is checked or not, you should
use
($isCustomizedIops.find('input[type=checkbox]').is(':checked')
instead of
($isCustomizedIops.is(':checked')
Jessica
-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Wednesday, November 06, 2013 10:10 AM
To: dev@cloudstack.apache.org
Subject: Re: JavaScript Question
This is just a guess, but I'm thinking if the checkbox is not visible, then
:checked always returns false (which would be weird).
I do make the checkbox visible before using :checked, but it's possible
this visibility change doesn't take effect until after the event handler
finishes.
Any thoughts on this from people who do a lot of JavaScript (or anyone
else, of course). :)
$isCustomizedIops.css('display', 'inline-block');
if
($isCustomizedIops.is(':checked')) {
$minIops.hide();
$maxIops.hide();
} else {
$minIops.css('display', 'inline-block');
$maxIops.css('display', 'inline-block');
}
On Tue, Nov 5, 2013 at 10:50 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Hi,
Does anyone know why this checkbox of mine always returns false?
if ($isCustomizedIops.is(':checked')) {
// do some stuff
}
That code is part of an event handler for a combobox (when the combobox
changes to a certain state, I want to see if the checkbox that is
revealed
is in the checked state):
args.$select.change(function() {
var $isCustomizedIops =
$form.find('.form-item[rel=isCustomizedIops]');
if ($isCustomizedIops.is(':checked')) {
// do some stuff
}
}
The checkbox is set up like this:
isCustomizedIops: {
label: 'label.custom.disk.iops',
docID:
'helpDiskOfferingCustomDiskIops',
isBoolean: true,
isReverse: true,
isChecked: false
},
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play
*(tm)*
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*
write access on cwiki
Hi All, I need to upload 4.2.1 BVT result on cwiki,; but I don't have edit access, someone please provide me the write access on cwiki ? Regards, Rayees
4.2.1 BVT automation results
Hi All, 4.2.1 BVT automation results published to cwiki; you can see the results below https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2.1+Automation+Result Regards, Rayees
RE: [New Feature FS] SSL Offload Support for Cloudstack
Darren, Murali Can you review the final patch and if acceptable merge into master. Syed the deadline is hard. I will cut the branch on 11/08 late night or early morning next day Animesh -Original Message- From: Syed Ahmed [mailto:sah...@cloudops.com] Sent: Wednesday, November 06, 2013 8:26 AM To: dev@cloudstack.apache.org Cc: Murali Reddy; Darren Shepherd Subject: Re: [New Feature FS] SSL Offload Support for Cloudstack Hi All, Many thanks to Darren and Murali for reviewing my code. I feel that the code is in a good condition to be merged into the master. I see that the code freeze is at the end of this week. Is it possible for my patch to be merged by then? Is it a hard deadline? Thanks, -Syed On Mon 04 Nov 2013 11:45:15 AM EST, Syed Ahmed wrote: Hi All, I would like to get this code into 4.3. Is it possible for this to be reviewed? Is there anything needed from my side? I would be glad to provide more information. Thanks, -Syed On Wed 30 Oct 2013 03:25:12 PM EDT, Syed Ahmed wrote: Hi All, I have the patch for adding SSL termination support at https://reviews.apache.org/r/14976/ . It would be great if this can be reviewed. Thanks, -Syed On 13-10-15 03:01 AM, Murali Reddy wrote: On 11/10/13 9:31 PM, Syed Ahmed sah...@cloudops.com wrote: Thanks for your valuable feedback Murali. Here are my comments. IMO, its better we introduce new api's say registerCertifcateToLoadbalancer/deregisterCertifcateToLoadbalance r than force fit existing API's for associate/dis-associate certificates. Personally, I was going to do it this way. But I am not sure how good of an idea it is to add a new api just for this feature as I can see assignToLoadbalancer is semantically similar. But if everyone agrees I have no problem with it. CloudStack already has distinct API's for each of the LB sub-functionality (health check, stickiness etc) [1]. We are not adding any redundant API, so resulting API are much cleaner just managing SSL termination for a LB rule. On second thought may be an CloudStack usage event on assigning certificate seems good enough to me. So what I got from your earlier post was that when adding a network offering the provider can choose to enable SSL Termination or not as it is a value added service. I was thinking of adding SSL termination under supportedservices for the createNetworkOffering API call. And when someone calls the API to assign a cert to LB we can check if this network offering has SSL termination enabled. Does this make sense? So there is notion of network service and network service capability [2]. I would attribute 'SSL termination' as capability of LB service. createNetworkOffering API take a capability list. It does make sense to check if the network offering has SSL termination enabled when API to assign a cert to LB is called. Also note that, 'Network Elements' declare their capabilities for the supported services. So it can verified that service provider for LB actually supports 'SSL termination' capability while creating network offering. Also when you say usage event, what does this imply? I am sorry I am not familiar with that term. Can you please elaborate. Its an event generated and persisted in the DB for every resource consumption and release. These events are used for billing etc. Please check publishUsageEvent calls in the code. [1] http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_User.html [2] api/src/com/cloud/network/Network.java
Re: [PROPOSAL] Liaison with ETSI NFV ISG
+1 On Nov 5, 2013, at 11:58 AM, Sebastien Goasguen run...@gmail.com wrote: I volunteer you. We need to do this. -Sebastien On 5 Nov 2013, at 20:28, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Network Functions Virtualisation (NFV) is an effort to utilize server virtualization in conjunction with industry standard servers, network hardware switches and storage hardware to achieve significant time and costs reductions in the Telecommunication industry. ETSI [1] has a group (NFV ISG [2]) that is trying to develop guidelines and frameworks around NFV (note: not standards). They have published a White Paper [3] which makes very interesting reading. Among other things, the group identifies The NFVI (Network Functions Virtualisation Infrastructure), which provides the virtual resources required to support the execution of the Virtualised Network Functions. It includes Commercial-Off-The-Shelf (COTS) hardware, accelerator components where necessary, and a software layer which virtualises and abstracts the underlying hardware. This software layer is assumed to be a form of IAAS software. Currently the group members use OpenStack as an example, but it should be our (the CloudStack community) goal to popularize and encourage the adoption of CloudStack as well. The white paper [3] also goes on to say: We are interested to ensure that the Open Source community actively engages in NFV to help create virtualised network capabilitiesŠ ...we intend to actively collaborate with existing reference open-source initiatives in the areas relevant to NFV, as well as to encourage and support new ones aligned with the NFV goals, especially when addressing new issues identified by the NFV community. One way to improve visibility and collaborate actively with this community is to have a liaison with the ISG. The liaison can contribute to the activities of the various working groups (e.g., Management and Orchestration MANO WG) and convey the activities and requirements of the NFV ISG back to the CloudStack community. If the community is OK with the Liaison idea, then we could solicit volunteers on this list to act as the Liaison(s) Comments? [1] http://en.wikipedia.org/wiki/ETSI [2] http://www.etsi.org/technologies-clusters/technologies/nfv [3] http://portal.etsi.org/NFV/NFV_White_Paper2.pdf
Re: [PROPOSAL] Liaison with ETSI NFV ISG
While I appreciate the confidence, there are weekly calls to attend. The particularly interesting one (MANO WG) happens on Wednesdays at 6am PST. I've tried but there's very little chance that I can attend these meetings. Anybody in a more agreeable timezone? On 11/6/13 3:34 PM, John Kinsella j...@stratosec.co wrote: +1 On Nov 5, 2013, at 11:58 AM, Sebastien Goasguen run...@gmail.com wrote: I volunteer you. We need to do this. -Sebastien On 5 Nov 2013, at 20:28, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Network Functions Virtualisation (NFV) is an effort to utilize server virtualization in conjunction with industry standard servers, network hardware switches and storage hardware to achieve significant time and costs reductions in the Telecommunication industry. ETSI [1] has a group (NFV ISG [2]) that is trying to develop guidelines and frameworks around NFV (note: not standards). They have published a White Paper [3] which makes very interesting reading. Among other things, the group identifies The NFVI (Network Functions Virtualisation Infrastructure), which provides the virtual resources required to support the execution of the Virtualised Network Functions. It includes Commercial-Off-The-Shelf (COTS) hardware, accelerator components where necessary, and a software layer which virtualises and abstracts the underlying hardware. This software layer is assumed to be a form of IAAS software. Currently the group members use OpenStack as an example, but it should be our (the CloudStack community) goal to popularize and encourage the adoption of CloudStack as well. The white paper [3] also goes on to say: We are interested to ensure that the Open Source community actively engages in NFV to help create virtualised network capabilitiesŠ ...we intend to actively collaborate with existing reference open-source initiatives in the areas relevant to NFV, as well as to encourage and support new ones aligned with the NFV goals, especially when addressing new issues identified by the NFV community. One way to improve visibility and collaborate actively with this community is to have a liaison with the ISG. The liaison can contribute to the activities of the various working groups (e.g., Management and Orchestration MANO WG) and convey the activities and requirements of the NFV ISG back to the CloudStack community. If the community is OK with the Liaison idea, then we could solicit volunteers on this list to act as the Liaison(s) Comments? [1] http://en.wikipedia.org/wiki/ETSI [2] http://www.etsi.org/technologies-clusters/technologies/nfv [3] http://portal.etsi.org/NFV/NFV_White_Paper2.pdf
Re: [PROPOSAL] Service monitoring tool in virtual router
Thx for putting this together, Jayapal. A few comments: I'd really like to have a config flag to specify if things should be restarted automatically or not. Worst case, track the restarts - if a service is restarted more than X times in Y seconds, something's obviously wrong so stop tail-chasing[1]. Personally I'm much more interested in knowing there's a problem and then taking whatever happens to be the appropriate actions for our situation. Regarding communicating with a monitoring system - what makes more sense to me is setting up a solid framework that provides folks flexibility to use various monitoring tools, from sending an email to contacting pager duty or whatever. So, to me there's 3 parts to that: 1) At VR creation, ACS calls defined hook-script which knows how to contact monitoring system to tell it about system to monitor 2) At boot, VR sends API query to which the mgmt server responds with a URL for an install script - VR runs that to download/setup appropriate monitoring agent 3) VR has standardized scripts for agent to call to find out what should be running, and then agent can go check for itself. With a setup like this, you can support SNMP, Opsview/Nagios, Monit, NSA, Zenoss, HPOV, Tivoli, etc etc etc. I'll happily write the Opsview/Nagios module (I'm thinking module is hosted outside ACS, but I guess it could be a plugin - see earlier licensing points). Thoughts? Just my 2c. Happy to tweak wiki if folks lean towards this. John 1: Aside - this applies to SSVM creation currently - that hamster[2] keeps trying to spin that create SSVM wheel.. 2: Apache CloudHamster, CloudMonkey's furry monitoring friend? On Nov 6, 2013, at 7:58 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Please find below update FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Monitoring+VR+services Thanks, Jayapal On 05-Oct-2013, at 6:54 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: A shell script can be used. Few thoughts below: 1. Collect the process id of all daemons you wanted to monitor using pidof of command and then use kill command to check if the pid you got is valid. Using kill we can send a signal 0, then check the status using echo $? . For sending a notification use linux syslog call ( man 3 syslogd) or logger command to send to syslog. If wanted to send email then you may also have to look for firewall not allowing outbound smtp port communiation. Even for snmp this holds same( i mean if any blocking through firewall rules ). Using syslog may be good as it by default exposes various debug log levels through its api call. Now, to keep the monitor script up always up and runninig. Keep the monitor script run continuosly through cron or at at regular\scheduled intervals. This way even if monitor script goes down, the next xth interval, it is up again. With this there is a catch though, we may got multiple pids for a given daemon provided if there are multiple daemons spawned by same\multiple applications, if this scenario is not common then its ok, otherwise we may have to track it differently maintaining state of each spawned daemon and see if it exists. If multiple applications launch the same daemon, you may also wanted to say its application which got killed. EX: A launched httpd, and during its exit logic, it is killing all daemons it launched, then you may wanted to add A is not available, rather than just http is not available. 2. Using netstat command : Check for available, listening and active ports on local host, provided all the daemons you wanted to monitor are running on standard ports or if we know the listening ports of those deamons to be monitored. Again, this script can be added through cron\at to be scheduled to run x units, if it gets killed the next x units after the monitor script is up again. Also, there could be many other approaches as well. Thanks! Santhosh From: Jayapal Reddy Uradi [jayapalreddy.ur...@citrix.com] Sent: Saturday, October 05, 2013 5:17 AM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [PROPOSAL] Service monitoring tool in virtual router Hi, +users list If any one is already using any tools for monitoring then please share your ideas. Also share the cases where you experienced service crashes. Thanks, Jayapal On 05-Oct-2013, at 4:12 AM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Well just make sure that your script is resilient to its own crashes as well. On 10/4/13 1:59 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Hi, I am planning to write script utility to monitor processes and restart on the event of failure. It will also logs the events. Thanks, Jayapal On 02-Oct-2013, at 3:25 AM, Simon Weller swel...@ena.com wrote: supervisord maybe? - Original Message -
Review Request 15296: CLOUDSTACK-5067 Bugfix: two NICs connected to Public network exist in VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15296/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5067 https://issues.apache.org/jira/browse/CLOUDSTACK-5067 Repository: cloudstack-git Description --- This is a patch to fix the bug CLOUDSTACK-5067 Bugfix: two NICs connected to Public network exist in VR. It seems it is caused by wrong handling of IpAssocCommand. IpAssocCommand is processed inappropriately in the method LibvirtComputingResource#execute(IpAssocCommand). It hotplugs unnecessary vNIC by mistake. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2049 It is caused by isolation method notation mismatch in this line. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2047 It expects isolation method is expressed in broadcast uri style like vlan://1234, vlan://untagged, but untagged is passed. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2033 FYI: Notation change is conducted in this commit. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=74f02c0c639d125f435b3b3f278fe3985f09c7ca;hp=203587a06f63f23d487ae65dcf5c397cd2702166;hb=2614b00c;hpb=62b0ad03c871c7100433b39593a82d393879124e Further, current code cannot retrieve VNI(VXLAN ID) from bridge name. This patch extends getVlanIdFromBridge to getBroadcastUriFromBridge to support vxlan. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2 Diff: https://reviews.apache.org/r/15296/diff/ Testing --- I deployed VR, and confirmed it has one NIC connected to Public network. Thanks, Yoshikazu Nojima
Re: Review Request 15296: CLOUDSTACK-5067 Bugfix: two NICs connected to Public network exist in VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15296/ --- (Updated Nov. 7, 2013, 1:11 a.m.) Review request for cloudstack, daan Hoogland, Marcus Sorensen, Hugo Trippaers, and Toshiaki Hatano. Changes --- I add reviewers. Bugs: CLOUDSTACK-5067 https://issues.apache.org/jira/browse/CLOUDSTACK-5067 Repository: cloudstack-git Description --- This is a patch to fix the bug CLOUDSTACK-5067 Bugfix: two NICs connected to Public network exist in VR. It seems it is caused by wrong handling of IpAssocCommand. IpAssocCommand is processed inappropriately in the method LibvirtComputingResource#execute(IpAssocCommand). It hotplugs unnecessary vNIC by mistake. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2049 It is caused by isolation method notation mismatch in this line. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2047 It expects isolation method is expressed in broadcast uri style like vlan://1234, vlan://untagged, but untagged is passed. https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2033 FYI: Notation change is conducted in this commit. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=74f02c0c639d125f435b3b3f278fe3985f09c7ca;hp=203587a06f63f23d487ae65dcf5c397cd2702166;hb=2614b00c;hpb=62b0ad03c871c7100433b39593a82d393879124e Further, current code cannot retrieve VNI(VXLAN ID) from bridge name. This patch extends getVlanIdFromBridge to getBroadcastUriFromBridge to support vxlan. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2 Diff: https://reviews.apache.org/r/15296/diff/ Testing --- I deployed VR, and confirmed it has one NIC connected to Public network. Thanks, Yoshikazu Nojima
Re: Bug? Should we allow detaching volumes when VMs have snapshots
We should dis-allow detaching volume from VM when it has VM snapshots. VMware keeps VM snapshot meta information at VM basis, disk membership change behind its back will cause problem and it does not provide official API to manipulate at volume level for a VM snapshot. This is a bug Kelven On 11/6/13, 5:58 AM, SuichII, Christopher chris.su...@netapp.com wrote: Bumping this. I believe we need the imput of a VMWare expert, please. -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms Cloud Solutions Citrix, Cisco Red Hat On Nov 5, 2013, at 1:46 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: OK, well, depending on if we can or can't get a VMware person to chime in on this issue, we may have to disallow disks from being detached from VMware VMs with snapshots in 4.3. On Tue, Nov 5, 2013 at 11:44 AM, SuichII, Christopher chris.su...@netapp.com wrote: Correct. #6 FAILS with VMWare and SUCCEEDS with Xen -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms Cloud Solutions Citrix, Cisco Red Hat On Nov 5, 2013, at 1:35 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I assume 6 fails with VMware, as well? Is Xen OK with 6? On Tue, Nov 5, 2013 at 11:26 AM, SuichII, Christopher chris.su...@netapp.com wrote: FWIW, after looking into this more with Xen, when the VM is restored in step 4, it simply no longer has the volume attached, so this appears to really be a VMWare issue. Any VMWare experts out there know how we can handle this? -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms Cloud Solutions Citrix, Cisco Red Hat On Nov 5, 2013, at 1:05 PM, SuichII, Christopher chris.su...@netapp.com wrote: We currently don¹t allow volumes to be attached to VMs with snapshots and allowing volumes to be detached causes quite a bug: 1) Attach a data disk to a VM 2) Snapshot the VM 3) Detach the data disk 4) Attempt to restore the VM from the snapshot ‹ FAILS since the data disk is no longer there, although it is expected to be 5) Attempt to re-attach the volume to the VM ‹ FAILS since you cannot attach volumes to VMs with snapshots 6) Attempt to delete the VM snapshot ‹ FAILS since the data disk is no longer there, although it is expected to be I have verified the above steps on VMWare, however Xen does not appear to fail on step 4, presumably because VMWare handles snapshots quite differently than Xen. Does anyone else have any thoughts on whether this is a bug or not? IMO, on VMWare, this set of steps can get users into a state where they can no longer attach new data disks to their VM, so it appears to be a bug of some kind. -Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms Cloud Solutions Citrix, Cisco Red Hat -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *�* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *�*
Re: write access on cwiki
On Wed, Nov 06, 2013 at 10:54:42PM +, Rayees Namathponnan wrote: Hi All, I need to upload 4.2.1 BVT result on cwiki,; but I don't have edit access, someone please provide me the write access on cwiki ? looks like you already have access. Regards, Rayees -- Prasanna., Powered by BigRock.com
Re: Need edit access to Apache Jira
On Wed, Nov 06, 2013 at 06:29:28PM +0100, Laszlo Hornyak wrote: I also need write access, at least to be able to assign issues to myself. My username is kocka. Thx! Given. you don't seem to have an account on cwiki.a.o though On Wed, Nov 6, 2013 at 1:07 PM, Pavan Bandarupally pavan.bandarupa...@citrix.com wrote: Hi , I am not able to close issues that I have verified in issues.apache.org . My user name is pavanb. Can you please give those permissions to my id. I could not find your userid on issues.a.o Regards, Pavan -- EOF -- Prasanna., Powered by BigRock.com
Re: Edit access to ASF Jira
On Wed, Nov 06, 2013 at 12:09:44PM +, Manasa Veloori (3P) wrote: Hi, Please provide me the edit access to ASF jira .I am not having option to close the bugs in ASF jira which are not assigned to me. you now have access. Thanks, Manasa -- Prasanna., Powered by BigRock.com
Re: [JENKINS] Preparing for the 4.3 branch
Animesh, I've included a short link to a jenkins tutorial on creating and cloning jobs and also on basic administration. Is there anything specific you were looking for? Typically, the master-view jobs are cloned into the targeted release branch view eg: 4.3 will have jobs cloned from master one-by-one. This is a manual process as of now that you will have to do using the jenkins ui. Perhaps when we move to a git based model we could automate this. On Wed, Nov 06, 2013 at 07:46:16PM +, Animesh Chaturvedi wrote: Prasanna I have added a link to your newly added wiki page, but need more information for a beginner to clone the build jobs for a new release -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Wednesday, November 06, 2013 11:41 AM To: dev@cloudstack.apache.org Subject: RE: [JENKINS] Preparing for the 4.3 branch Thanks Hugo for taking care of these. Do you mind taking a moment to update Release Management wiki page [1] on what it takes to set up Jenkins build jobs for a new release. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Managemen t -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Wednesday, November 06, 2013 2:16 AM To: dev@cloudstack.apache.org Subject: [JENKINS] Preparing for the 4.3 branch I've setup all the jenkins jobs for the release branch and a pipeline view. When the branch is cut we only need to enable the jobs. http://jenkins.buildacloud.org/view/4.3/ http://jenkins.buildacloud.org/view/cloudstack-4.3-pipeline/ Cheers, Hugo -- Prasanna., Powered by BigRock.com
RE: write access on cwiki
Edison helped me on this, Thanks. -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Wednesday, November 06, 2013 8:35 PM To: dev@cloudstack.apache.org Subject: Re: write access on cwiki On Wed, Nov 06, 2013 at 10:54:42PM +, Rayees Namathponnan wrote: Hi All, I need to upload 4.2.1 BVT result on cwiki,; but I don't have edit access, someone please provide me the write access on cwiki ? looks like you already have access. Regards, Rayees -- Prasanna., Powered by BigRock.com
[ASF4.2.1] BVT automation results
Thanks Rayees, It appears that pass rate is more than 98%. Rayees, any analysis on failed test cases ? On 07/11/13 4:37 am, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi All, 4.2.1 BVT automation results published to cwiki; you can see the results below https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2.1+Automation+Re sult Regards, Rayees
Re: S3 as secondary storage is broken in master
Min,
I ran my basic regression test for KVM, and the original bug I
fixed in the commit you mention seems to be back. I'm not sure if
it's related to your check-in, and I don't see any currently obvious
reason why it would be so, but I'm investigating. Here's the log from
latest master, you can see the CopyCommand is falling through to not
implemented yet
2013-11-06 22:01:44,682 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Request:Seq 1-384630832: { Cmd ,
MgmtId: 52241639751, via: 1, Ver: v1, Flags: 100111,
[{org.apache.cloudstack.storage.command.CopyCommand:{srcTO:{org.apache.cloudstack.storage.to.TemplateObjectTO:{path:template/tmpl/1/201/d4201b3a-9fcf-35d1-986b-133cfd64779c.qcow2,origUrl:http://marcus.mlsorensen.com/cloudstack-extras/tiny-centos-63.qcow2,uuid:c27d031a-b695-41d7-9996-5b8e7688c489,id:201,format:QCOW2,accountId:1,checksum:44cd0e6330a59f031460bc18a40c95a2,hvm:true,displayText:tiny,imageDataStore:{com.cloud.agent.api.to.NfsTO:{_url:nfs://172.17.10.10:/nfs/secondary,_role:Image}},name:201-1-2379913e-f51c-3e53-a0e5-f780c4782b16,hypervisorType:KVM}},destTO:{org.apache.cloudstack.storage.to.VolumeObjectTO:{uuid:94812f0c-c247-46d9-8689-c1600d09b9ae,volumeType:ROOT,dataStore:{org.apache.cloudstack.storage.to.PrimaryDataStoreTO:{uuid:c6669280-c5ad-4e91-8cab-5d7cb2f1455b,id:2,poolType:CLVM,host:localhost,path:vg0,port:0}},name:ROOT-6,size:1073741824,volumeId:6,vmName:i-1-6-VM,accountId:1,format:QCOW2,id:6,hypervisorType:KVM}},executeInSequence:true,wait:10800}}]
}
2013-11-06 22:01:44,683 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Processing command:
org.apache.cloudstack.storage.command.CopyCommand
2013-11-06 22:01:44,684 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Seq 1-384630832: { Ans: , MgmtId:
52241639751, via: 1, Ver: v1, Flags: 110,
[{com.cloud.agent.api.Answer:{result:false,details:not
implemented yet,wait:0}}] }
On Sat, Nov 2, 2013 at 11:31 PM, Min Chen min.c...@citrix.com wrote:
Checked in fix 99ead3419c80fc7135a95f34ced7650eda3572fd to master.
Thanks
-min
From: Marcus Sorensen shadow...@gmail.com
Date: Saturday, November 2, 2013 9:25 AM
To: Min Chen min.c...@citrix.com
Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org, SuichII,
Christopher chris.su...@netapp.com, Edison Su edison...@citrix.com
Subject: Re: S3 as secondary storage is broken in master
OK. I was thinking that S3 was acting as secondary storage now but really it
still requires NFS as the intermediary, hence the image cache. In that
case your suggestion would work.
On Nov 2, 2013 10:10 AM, Min Chen min.c...@citrix.com wrote:
No, Marcus. That piece of code worked in 4.2 for S3. Note that image ache
store is also NfsTO.
Thanks
-min
Sent from my iPhone
On Nov 2, 2013, at 7:18 AM, Marcus Sorensen shadow...@gmail.com
wrote:
My only issue is that I believe copyTemplateToPrimaryStorage fails if
the source datastore is not NfsTO, so I'm not sure if this change will
do anything, or where S3 copy is actually handled. se
copyTemplateToPrimaryStorage:
KVM:
if (!(imageStore instanceof NfsTO)) {
return new CopyCmdAnswer(unsupported protocol);
}
Xen (all logic wrapped in this if statement):
if ((srcStore instanceof NfsTO) (srcData.getObjectType()
== DataObjectType.TEMPLATE)) {
VMware:
if (!(srcStore instanceof NfsTO)) {
return new CopyCmdAnswer(unsupported protocol);
}
This line of code has a history. In 4.2 it didn't work for S3, either.
It specifically only allowed NFS:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE)
(srcDataStore instanceof NfsTO) (destData.getDataStore().getRole()
== DataStoreRole.Primary)) {
Then for a short while it was changed during some refactoring Chris
and Edison were working on:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE)
(destData.getObjectType() == DataObjectType.TEMPLATE
destData.getDataStore().getRole() == DataStoreRole.Primary)) {
That broke CLVM, so I changed it to:
if (srcData.getObjectType() == DataObjectType.TEMPLATE
srcData.getDataStore().getRole() == DataStoreRole.Image
destData.getDataStore().getRole() == DataStoreRole.Primary) {
On Fri, Nov 1, 2013 at 10:34 PM, Min Chen min.c...@citrix.com wrote:
Hi Marcus,
Your commit a504c004bf10555e5ea67ec89fe7bf6f00fe4622 broke S3
functionality.
With S3 as secondary storage, system vm cannot be started. Since for
S3,
copy template to primary will be from an ImageCache store. Your
following
line of code :
if (srcData.getObjectType() == DataObjectType.TEMPLATE
srcData.getDataStore().getRole() == DataStoreRole.Image
destData.getDataStore().getRole() == DataStoreRole.Primary) {
//copy template to primary storage
return processor.copyTemplateToPrimaryStorage(cmd);
}
will not cover this case. I saw that you mentioned about this commit in
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 7, 2013, 5:22 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 8d841d8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 80a4036 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 26e4abf Diff: https://reviews.apache.org/r/15173/diff/ Testing (updated) --- Tested on master. Thanks, bharat kumar
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 7, 2013, 5:50 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Changes --- rebased with master Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs (updated) - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 8ab6c5e api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ab626c8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java a31d06f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 9e69962 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 980650d Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: S3 as secondary storage is broken in master
nevermind, I was pointing the test at the wrong revision
On Wed, Nov 6, 2013 at 10:17 PM, Marcus Sorensen shadow...@gmail.com wrote:
Min,
I ran my basic regression test for KVM, and the original bug I
fixed in the commit you mention seems to be back. I'm not sure if
it's related to your check-in, and I don't see any currently obvious
reason why it would be so, but I'm investigating. Here's the log from
latest master, you can see the CopyCommand is falling through to not
implemented yet
2013-11-06 22:01:44,682 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Request:Seq 1-384630832: { Cmd ,
MgmtId: 52241639751, via: 1, Ver: v1, Flags: 100111,
[{org.apache.cloudstack.storage.command.CopyCommand:{srcTO:{org.apache.cloudstack.storage.to.TemplateObjectTO:{path:template/tmpl/1/201/d4201b3a-9fcf-35d1-986b-133cfd64779c.qcow2,origUrl:http://marcus.mlsorensen.com/cloudstack-extras/tiny-centos-63.qcow2,uuid:c27d031a-b695-41d7-9996-5b8e7688c489,id:201,format:QCOW2,accountId:1,checksum:44cd0e6330a59f031460bc18a40c95a2,hvm:true,displayText:tiny,imageDataStore:{com.cloud.agent.api.to.NfsTO:{_url:nfs://172.17.10.10:/nfs/secondary,_role:Image}},name:201-1-2379913e-f51c-3e53-a0e5-f780c4782b16,hypervisorType:KVM}},destTO:{org.apache.cloudstack.storage.to.VolumeObjectTO:{uuid:94812f0c-c247-46d9-8689-c1600d09b9ae,volumeType:ROOT,dataStore:{org.apache.cloudstack.storage.to.PrimaryDataStoreTO:{uuid:c6669280-c5ad-4e91-8cab-5d7cb2f1455b,id:2,poolType:CLVM,host:localhost,path:vg0,port:0}},name:ROOT-6,size:1073741824,volumeId:6,vmName:i-1-6-VM,accountId:1,format:QCOW2,id:6,hypervisorType:KVM}},executeInSequence:true,wait:10800}}]
}
2013-11-06 22:01:44,683 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Processing command:
org.apache.cloudstack.storage.command.CopyCommand
2013-11-06 22:01:44,684 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Seq 1-384630832: { Ans: , MgmtId:
52241639751, via: 1, Ver: v1, Flags: 110,
[{com.cloud.agent.api.Answer:{result:false,details:not
implemented yet,wait:0}}] }
On Sat, Nov 2, 2013 at 11:31 PM, Min Chen min.c...@citrix.com wrote:
Checked in fix 99ead3419c80fc7135a95f34ced7650eda3572fd to master.
Thanks
-min
From: Marcus Sorensen shadow...@gmail.com
Date: Saturday, November 2, 2013 9:25 AM
To: Min Chen min.c...@citrix.com
Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org, SuichII,
Christopher chris.su...@netapp.com, Edison Su edison...@citrix.com
Subject: Re: S3 as secondary storage is broken in master
OK. I was thinking that S3 was acting as secondary storage now but really it
still requires NFS as the intermediary, hence the image cache. In that
case your suggestion would work.
On Nov 2, 2013 10:10 AM, Min Chen min.c...@citrix.com wrote:
No, Marcus. That piece of code worked in 4.2 for S3. Note that image ache
store is also NfsTO.
Thanks
-min
Sent from my iPhone
On Nov 2, 2013, at 7:18 AM, Marcus Sorensen shadow...@gmail.com
wrote:
My only issue is that I believe copyTemplateToPrimaryStorage fails if
the source datastore is not NfsTO, so I'm not sure if this change will
do anything, or where S3 copy is actually handled. se
copyTemplateToPrimaryStorage:
KVM:
if (!(imageStore instanceof NfsTO)) {
return new CopyCmdAnswer(unsupported protocol);
}
Xen (all logic wrapped in this if statement):
if ((srcStore instanceof NfsTO) (srcData.getObjectType()
== DataObjectType.TEMPLATE)) {
VMware:
if (!(srcStore instanceof NfsTO)) {
return new CopyCmdAnswer(unsupported protocol);
}
This line of code has a history. In 4.2 it didn't work for S3, either.
It specifically only allowed NFS:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE)
(srcDataStore instanceof NfsTO) (destData.getDataStore().getRole()
== DataStoreRole.Primary)) {
Then for a short while it was changed during some refactoring Chris
and Edison were working on:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE)
(destData.getObjectType() == DataObjectType.TEMPLATE
destData.getDataStore().getRole() == DataStoreRole.Primary)) {
That broke CLVM, so I changed it to:
if (srcData.getObjectType() == DataObjectType.TEMPLATE
srcData.getDataStore().getRole() == DataStoreRole.Image
destData.getDataStore().getRole() == DataStoreRole.Primary) {
On Fri, Nov 1, 2013 at 10:34 PM, Min Chen min.c...@citrix.com wrote:
Hi Marcus,
Your commit a504c004bf10555e5ea67ec89fe7bf6f00fe4622 broke S3
functionality.
With S3 as secondary storage, system vm cannot be started. Since for
S3,
copy template to primary will be from an ImageCache store. Your
following
line of code :
if (srcData.getObjectType() == DataObjectType.TEMPLATE
srcData.getDataStore().getRole() == DataStoreRole.Image
destData.getDataStore().getRole() == DataStoreRole.Primary) {
//copy template to primary storage
Ask for help with the snapshot of volume feature
Hello,everyone, I'm a coder from Beijing in China,and it is the first time that I ask for help here. I'm learning cs4.0.2,and I found the snapshot of volume feature has 2 parts:creating snapshot and backupping snapshot.In backupping snapshot parts,I'm confused of the -s $snapshotName parameter in the command $qemu_img convert -f qcow2 -O qcow2 -s $snapshotname $disk $destPath/$destName. my testing steps as follows:(test-vm is always running) 1??Create a_snapshot on test-vm with the libvirt api domain.snapshotCreateXML(). 2??Write /a.txt on the test-vm 3 qemu-img convert -f qcow2 -O qcow2 -s a_snapshot test-vm.disk /tmp/testvm_a_ss?? (test-vm.disk is the source disk of test-vm on the primary storage) 4??define a test-vm-ss xml in /etc/libvirt/qemu with /tmp/testvm_a_ss as its source. 5virsh define test-vm-ss;virsh start test-vm-ss?? As my results,and confused, I found the a.txt on the test-vm-ss vm. Does the -s a_snapshot parameter work? Thank you very much!I'm sorry for my English ability,but I'm looking forward to your help very much.
Re: S3 as secondary storage is broken in master
Hi Marcus,
I am not sure that my last commit
99ead3419c80fc7135a95f34ced7650eda3572fd will cause this, since it is just
checking srcTO is an Image or an ImageCache store. In your case, it is
Image store, so the same old code will kick in. But I do see an issue in
current code compared to what we have in 4.2, in 4.2, we used to check
both srcTO object type and destTO object type, only both are
TemplateObject, it will go to the control. Now in master, not sure you or
Chris changed this by removing the check on destTO object type. Then in
this case, you are actually copying a Template on secondary to a Volume on
Primary, it will also get into the control of
processor.copyTemplateToPrimaryStorage(cmd), which seems incorrect.
Thanks
-min
On 11/6/13 9:17 PM, Marcus Sorensen shadow...@gmail.com wrote:
Min,
I ran my basic regression test for KVM, and the original bug I
fixed in the commit you mention seems to be back. I'm not sure if
it's related to your check-in, and I don't see any currently obvious
reason why it would be so, but I'm investigating. Here's the log from
latest master, you can see the CopyCommand is falling through to not
implemented yet
2013-11-06 22:01:44,682 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Request:Seq 1-384630832: { Cmd ,
MgmtId: 52241639751, via: 1, Ver: v1, Flags: 100111,
[{org.apache.cloudstack.storage.command.CopyCommand:{srcTO:{org.apach
e.cloudstack.storage.to.TemplateObjectTO:{path:template/tmpl/1/201/d42
01b3a-9fcf-35d1-986b-133cfd64779c.qcow2,origUrl:http://marcus.mlsorens
en.com/cloudstack-extras/tiny-centos-63.qcow2,uuid:c27d031a-b695-41d7-
9996-5b8e7688c489,id:201,format:QCOW2,accountId:1,checksum:44c
d0e6330a59f031460bc18a40c95a2,hvm:true,displayText:tiny,imageDataS
tore:{com.cloud.agent.api.to.NfsTO:{_url:nfs://172.17.10.10:/nfs/sec
ondary,_role:Image}},name:201-1-2379913e-f51c-3e53-a0e5-f780c4782b
16,hypervisorType:KVM}},destTO:{org.apache.cloudstack.storage.to.V
olumeObjectTO:{uuid:94812f0c-c247-46d9-8689-c1600d09b9ae,volumeType
:ROOT,dataStore:{org.apache.cloudstack.storage.to.PrimaryDataStoreTO
:{uuid:c6669280-c5ad-4e91-8cab-5d7cb2f1455b,id:2,poolType:CLVM,
host:localhost,path:vg0,port:0}},name:ROOT-6,size:107374182
4,volumeId:6,vmName:i-1-6-VM,accountId:1,format:QCOW2,id:6,
hypervisorType:KVM}},executeInSequence:true,wait:10800}}]
}
2013-11-06 22:01:44,683 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Processing command:
org.apache.cloudstack.storage.command.CopyCommand
2013-11-06 22:01:44,684 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-5:null) Seq 1-384630832: { Ans: , MgmtId:
52241639751, via: 1, Ver: v1, Flags: 110,
[{com.cloud.agent.api.Answer:{result:false,details:not
implemented yet,wait:0}}] }
On Sat, Nov 2, 2013 at 11:31 PM, Min Chen min.c...@citrix.com wrote:
Checked in fix 99ead3419c80fc7135a95f34ced7650eda3572fd to master.
Thanks
-min
From: Marcus Sorensen shadow...@gmail.com
Date: Saturday, November 2, 2013 9:25 AM
To: Min Chen min.c...@citrix.com
Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org, SuichII,
Christopher chris.su...@netapp.com, Edison Su edison...@citrix.com
Subject: Re: S3 as secondary storage is broken in master
OK. I was thinking that S3 was acting as secondary storage now but
really it
still requires NFS as the intermediary, hence the image cache. In that
case your suggestion would work.
On Nov 2, 2013 10:10 AM, Min Chen min.c...@citrix.com wrote:
No, Marcus. That piece of code worked in 4.2 for S3. Note that image
ache
store is also NfsTO.
Thanks
-min
Sent from my iPhone
On Nov 2, 2013, at 7:18 AM, Marcus Sorensen shadow...@gmail.com
wrote:
My only issue is that I believe copyTemplateToPrimaryStorage fails
if
the source datastore is not NfsTO, so I'm not sure if this change
will
do anything, or where S3 copy is actually handled. se
copyTemplateToPrimaryStorage:
KVM:
if (!(imageStore instanceof NfsTO)) {
return new CopyCmdAnswer(unsupported protocol);
}
Xen (all logic wrapped in this if statement):
if ((srcStore instanceof NfsTO) (srcData.getObjectType()
== DataObjectType.TEMPLATE)) {
VMware:
if (!(srcStore instanceof NfsTO)) {
return new CopyCmdAnswer(unsupported protocol);
}
This line of code has a history. In 4.2 it didn't work for S3,
either.
It specifically only allowed NFS:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE)
(srcDataStore instanceof NfsTO)
(destData.getDataStore().getRole()
== DataStoreRole.Primary)) {
Then for a short while it was changed during some refactoring Chris
and Edison were working on:
if ((srcData.getObjectType() == DataObjectType.TEMPLATE)
(destData.getObjectType() == DataObjectType.TEMPLATE
destData.getDataStore().getRole() == DataStoreRole.Primary)) {
That broke CLVM, so I changed it to:
if (srcData.getObjectType() == DataObjectType.TEMPLATE
Re: Marvin deploy failed on master
Ran into this as well. Is it something we need to put into the mvn install of the tools? On Tue, Nov 5, 2013 at 3:10 PM, Will Stevens wstev...@cloudops.com wrote: I also ran into this issue on a clean install. #2 fixed my issue... Thanks, Will On Mon, Nov 4, 2013 at 5:14 PM, Min Chen min.c...@citrix.com wrote: Thanks Santhosh. Using #2 fixed the issue. -min On 11/2/13 5:48 AM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Hi Min, 1/ I just pulled the latest code from master and used marvin, it went fine. Are you still facing this issue? Make sure your local setup is clean and marvin installed with latest pull. 2/ It seems you don't have codes.py file available under python/site-packages/.../marvin folder? Ideally it will get installed when you run your build. If its still an issue, run python setup.py install from tools/marvin/ folder and see if it works around. Thanks! Santhosh From: Min Chen [min.c...@citrix.com] Sent: Friday, November 01, 2013 8:10 PM To: dev@cloudstack.apache.org Subject: Marvin deploy failed on master Hi there, Mavin deployment failed on master, localhost:devcloud minc$ python ../marvin/marvin/deployDataCenter.py -i min_xenvm_sec2.cfg Traceback (most recent call last): File ../marvin/marvin/deployDataCenter.py, line 19, in module import configGenerator File /Users/minc/dev/cloud-asf/tools/marvin/marvin/configGenerator.py, line 22, in module from marvin.codes import * ImportError: No module named codes This seems related to recent commit 0b617a13fdf3b8108c2fd940e982b2e58bf9c3e7. Anybody else encountered the similar issue? Thanks -min
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 7, 2013, 6:24 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs (updated) - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 8ab6c5e api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ab626c8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java a31d06f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 9e69962 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 980650d Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Tested on master. Thanks, bharat kumar
RE: [PROPOSAL] Service monitoring tool in virtual router
Jayapal, I have gone through the FS posted @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/Monitoring+VR+services Following are the few review comments: 1. First line in the Introduction section says Virtual router has running services which needs to run always until cloudsack disable it. What is the meaning of disable by cloudstack ? If cloudstack disables few services how the monitoring tool differentiate whether the service is disabled by cloudstack admin or its due to some failure? 2. Is monitoring VR services is optional or will be monitored always? Any ways to set whether to enable this feature or not? 3. Is service monitoring frequency configurable? If yes how do we configure? FS says the default value is 5 secs. 4. FS says monitoring VR services has two tasks. 1. monitoring services in VR 2. sending alerts from router to external receivers What external receivers we will be supporting? Also please specify what all the ways the monitoring tool indicates the failure? Are we going to use exiting Cloudstack Alerts and Events framework to indicate the failure? 5. If multiple instances of the same processes are running do we monitor all the instances of the same process? 6. After how many restarts the monitoring service decides that something is wrong with the process in bringing it up? 7. After N no.of restarts if the process is still not running are we going to remove it from the monitoring processes list? If yes how the tools informs the admin that it is not able to restart the process? Or it will be restarting the process forever? 8. Is there way for the admin to specify the tool to monitor only particular services? 9. Apart from dnsmasq,haproxy,sshd,apache webserver services are we not monitoring the password service(socat)? Socat process is not mentioned in the Monitoring Services section in the FS 10. Is this supported in RVR case as well? 11. Specify the hypervisors supported for this feature? 12. As per my understanding this tool will be part of systemvm.iso. After upgrade from pre 4.3 release to 4.3 iso will be pushed to the hypervisors. So stop, start VR is required for the exiting VRs to get this service. Please confirm. 13. Please specify the expected date for confirming the scope for failure notifications. Scope is not clear from sending alerts from router section in FS Thanks, Sanjeev -Original Message- From: John Kinsella [mailto:j...@stratosec.co] Sent: Thursday, November 07, 2013 6:26 AM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [PROPOSAL] Service monitoring tool in virtual router Thx for putting this together, Jayapal. A few comments: I'd really like to have a config flag to specify if things should be restarted automatically or not. Worst case, track the restarts - if a service is restarted more than X times in Y seconds, something's obviously wrong so stop tail-chasing[1]. Personally I'm much more interested in knowing there's a problem and then taking whatever happens to be the appropriate actions for our situation. Regarding communicating with a monitoring system - what makes more sense to me is setting up a solid framework that provides folks flexibility to use various monitoring tools, from sending an email to contacting pager duty or whatever. So, to me there's 3 parts to that: 1) At VR creation, ACS calls defined hook-script which knows how to contact monitoring system to tell it about system to monitor 2) At boot, VR sends API query to which the mgmt server responds with a URL for an install script - VR runs that to download/setup appropriate monitoring agent 3) VR has standardized scripts for agent to call to find out what should be running, and then agent can go check for itself. With a setup like this, you can support SNMP, Opsview/Nagios, Monit, NSA, Zenoss, HPOV, Tivoli, etc etc etc. I'll happily write the Opsview/Nagios module (I'm thinking module is hosted outside ACS, but I guess it could be a plugin - see earlier licensing points). Thoughts? Just my 2c. Happy to tweak wiki if folks lean towards this. John 1: Aside - this applies to SSVM creation currently - that hamster[2] keeps trying to spin that create SSVM wheel.. 2: Apache CloudHamster, CloudMonkey's furry monitoring friend? On Nov 6, 2013, at 7:58 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Please find below update FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Monitoring+VR+s ervices Thanks, Jayapal On 05-Oct-2013, at 6:54 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: A shell script can be used. Few thoughts below: 1. Collect the process id of all daemons you wanted to monitor using pidof of command and then use kill command to check if the pid you got is valid. Using kill we can send a signal 0, then check the status using echo $? . For sending a notification use linux syslog
Re: Ping to shared network gateway failing
Hi Santosh, Do you mean creating gateway through API or is this a physical setup requirement to be served before running the test case? Regards, Gaurav On Wed, Nov 6, 2013 at 4:52 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: In shared network, we need to explicitly create the gateway. The ip available to vm as gateway need to be physically existing as gateway device. Santhosh From: Gaurav Aradhye [gaurav.arad...@clogeny.com] Sent: Wednesday, November 06, 2013 5:55 AM To: dev@cloudstack.apache.org Cc: Girish Shilamkar Subject: Ping to shared network gateway failing HI all, I am facing an issue while running few test cases involving shared network test cases. Virtual Machine is deployed in shared network and isolated network. One of the test case step is to check whether the network gateway is reachable from the virtual machine. Although the ping to gateway of Isolated network succeeds, ping to shared network gateway always fails. I tried deploying the VM with only shared network, the issue persists. Can't reach the shared network gateway through the VM. Can anybody guide me on this? IMO, gateway should always be reachable from VM if that VM is part of that network. Regards, Gaurav
Re: Review Request 15173: Dynamic compute offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/#review28355 --- Ship it! Ship It! - Koushik Das On Nov. 7, 2013, 6:24 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 7, 2013, 6:24 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 8ab6c5e api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ab626c8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java a31d06f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 9e69962 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 980650d Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 15173: Dynamic compute offering.
On Nov. 7, 2013, 7:17 a.m., Koushik Das wrote: Ship It! commit 7095ea2b5e497620c8c879517565046e3b46e493 - Koushik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/#review28355 --- On Nov. 7, 2013, 6:24 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15173/ --- (Updated Nov. 7, 2013, 6:24 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-4738 https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4738 Dynamic compute Offering. Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. Diffs - api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e api/src/com/cloud/vm/UserVmService.java 0b142e8 api/src/org/apache/cloudstack/api/ApiConstants.java 8ab6c5e api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ab626c8 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 server/src/com/cloud/configuration/ConfigurationManagerImpl.java a31d06f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/vm/UserVmManagerImpl.java 9e69962 server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f server/test/com/cloud/vm/UserVmManagerTest.java df676d3 server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION server/test/resources/createNetworkOffering.xml 9d684ba setup/db/db/schema-421to430.sql 980650d Diff: https://reviews.apache.org/r/15173/diff/ Testing --- Tested on master. Thanks, bharat kumar
Review Request 15298: Fix for issues on Coverity related to IDs 1125383 [82, 80, 79, 78, 77, 76, 75, 74]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/ --- Review request for cloudstack and Hugo Trippaers. Bugs: 1125374, 1125375, 1125376, 1125377, 1125378, 1125379, 1125380, 1125382, and 1125383 https://issues.apache.org/jira/browse/1125374 https://issues.apache.org/jira/browse/1125375 https://issues.apache.org/jira/browse/1125376 https://issues.apache.org/jira/browse/1125377 https://issues.apache.org/jira/browse/1125378 https://issues.apache.org/jira/browse/1125379 https://issues.apache.org/jira/browse/1125380 https://issues.apache.org/jira/browse/1125382 https://issues.apache.org/jira/browse/1125383 Repository: cloudstack-git Description --- Several bugs reported on coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs 1125383, 1125382, 1125380, 1125379, 1125378, 1125377, 1125376, 1125375, 1125374. Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method. For the bug 1125374, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a s. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5 Diff: https://reviews.apache.org/r/15298/diff/ Testing --- Thanks, Wilder Rodrigues
Re: Review Request 15298: Fix for issues on Coverity related to IDs 1125383 [82, 80, 79, 78, 77, 76, 75, 74]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/ --- (Updated Nov. 7, 2013, 7:24 a.m.) Review request for cloudstack and Hugo Trippaers. Changes --- Changing the ID of the Coverity issue that contained a type. Bugs: 1125374, 1125375, 1125376, 1125377, 1125378, 1125379, 1125380, 1125382, and 1125383 https://issues.apache.org/jira/browse/1125374 https://issues.apache.org/jira/browse/1125375 https://issues.apache.org/jira/browse/1125376 https://issues.apache.org/jira/browse/1125377 https://issues.apache.org/jira/browse/1125378 https://issues.apache.org/jira/browse/1125379 https://issues.apache.org/jira/browse/1125380 https://issues.apache.org/jira/browse/1125382 https://issues.apache.org/jira/browse/1125383 Repository: cloudstack-git Description (updated) --- Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs 1125383, 1125382, 1125380, 1125379, 1125378, 1125377, 1125376, 1125375, 1125374. Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method. For the bug 1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a s. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5 Diff: https://reviews.apache.org/r/15298/diff/ Testing --- Thanks, Wilder Rodrigues
Re: Review Request 15298: Fix for issues on Coverity related to IDs 1125383 [82, 80, 79, 78, 77, 76, 75, 74]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/#review28357 --- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java https://reviews.apache.org/r/15298/#comment55184 Can you replace the tabs with spaces please? - Hugo Trippaers On Nov. 7, 2013, 7:24 a.m., Wilder Rodrigues wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/ --- (Updated Nov. 7, 2013, 7:24 a.m.) Review request for cloudstack and Hugo Trippaers. Bugs: 1125374, 1125375, 1125376, 1125377, 1125378, 1125379, 1125380, 1125382, and 1125383 https://issues.apache.org/jira/browse/1125374 https://issues.apache.org/jira/browse/1125375 https://issues.apache.org/jira/browse/1125376 https://issues.apache.org/jira/browse/1125377 https://issues.apache.org/jira/browse/1125378 https://issues.apache.org/jira/browse/1125379 https://issues.apache.org/jira/browse/1125380 https://issues.apache.org/jira/browse/1125382 https://issues.apache.org/jira/browse/1125383 Repository: cloudstack-git Description --- Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs 1125383, 1125382, 1125380, 1125379, 1125378, 1125377, 1125376, 1125375, 1125374. Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method. For the bug 1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a s. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5 Diff: https://reviews.apache.org/r/15298/diff/ Testing --- Thanks, Wilder Rodrigues
Re: Review Request 15298: Fix for issues on Coverity related to IDs cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15298/ --- (Updated Nov. 7, 2013, 7:35 a.m.) Review request for cloudstack and Hugo Trippaers. Changes --- removing bug IDs because they are not jira, but coverity Summary (updated) - Fix for issues on Coverity related to IDs cv_1125383 [82, 80, 79, 78, 77, 76, 75, 74] Repository: cloudstack-git Description (updated) --- Several bugs reported on Coverity have been fixed on this path. The ID are: Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374. Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method. For the bug cv_1125376, although it has been submitted in a previous patch, there was a typo on the return key word, which contained a s. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 8cb4e8d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 455e601 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java 71d28ac plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java f22c7c5 Diff: https://reviews.apache.org/r/15298/diff/ Testing --- Thanks, Wilder Rodrigues
Re: Review Request 15264: Fix for cv_1125389 RV: Bad use of return value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15264/ --- (Updated Nov. 7, 2013, 7:37 a.m.) Review request for cloudstack and Hugo Trippaers. Changes --- prefixing bug IDs with cv_ because they are from Coverity and not from Jira. Summary (updated) - Fix for cv_1125389 RV: Bad use of return value Repository: cloudstack-git Description --- In org.?apache.?cloudstack.?network.?contrail.?management.?ContrailManagerImpl.?getPhysicalNetworkName(com.?cloud.?network.?dao.?PhysicalNetworkVO): The return value of this method should be checked. (From FindBugs™ description) (CWE-440) Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java ae9bba9 Diff: https://reviews.apache.org/r/15264/diff/ Testing --- Thanks, Wilder Rodrigues
RE: Ping to shared network gateway failing
1.I believe we already have sharednetwork created with gateway ip configured along with other parameters through API in your testing. This IP( gateway IP ) need to be already assigned to a gateway device and reachable. 2. During the VM creation, this ip of gateway is available to VM as part of its route configuration. May be you wanted to check the IP used in creating shared network in step1 is existing and reachable. Regards, Santhosh From: Gaurav Aradhye [gaurav.arad...@clogeny.com] Sent: Thursday, November 07, 2013 1:28 AM To: dev@cloudstack.apache.org Cc: Girish Shilamkar Subject: Re: Ping to shared network gateway failing Hi Santosh, Do you mean creating gateway through API or is this a physical setup requirement to be served before running the test case? Regards, Gaurav On Wed, Nov 6, 2013 at 4:52 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: In shared network, we need to explicitly create the gateway. The ip available to vm as gateway need to be physically existing as gateway device. Santhosh From: Gaurav Aradhye [gaurav.arad...@clogeny.com] Sent: Wednesday, November 06, 2013 5:55 AM To: dev@cloudstack.apache.org Cc: Girish Shilamkar Subject: Ping to shared network gateway failing HI all, I am facing an issue while running few test cases involving shared network test cases. Virtual Machine is deployed in shared network and isolated network. One of the test case step is to check whether the network gateway is reachable from the virtual machine. Although the ping to gateway of Isolated network succeeds, ping to shared network gateway always fails. I tried deploying the VM with only shared network, the issue persists. Can't reach the shared network gateway through the VM. Can anybody guide me on this? IMO, gateway should always be reachable from VM if that VM is part of that network. Regards, Gaurav
