Re: Trouble with deployDataCenter.py
On Mon, Jun 03, 2013 at 01:10:20PM -0400, Will Stevens wrote: > Thanks Mike. Ya, I also did the same change locally and then did the > following to not track the hack in my branch. > > git update-index --assume-unchanged > tools/marvin/marvin/cloudstackConnection.py > > Thanks for submitting a patch for that. > > Cheers, > Devcloud is actually fine. What's happening in your case is that your marvin installation is out of date. This often will happen as and when new changes are introduced to marvin or new cloudstack APIs are added to the server. To sync all the changes, similar to how cloudmonkey does it you'll need to sync marvin. There is a maven target for this: See the section on "Sync Marvin APIs" https://cwiki.apache.org/confluence/x/QQzMAQ -- Prasanna., Powered by BigRock.com
Re: [VOTE] Pushback 4.2.0 Feature Freeze
+0 - similar concerns as Sebastien. I hope that we also don't introduce any new unproposed features, or architectural changes to 4.2 at the end of the cycle, which this extension still is. Also - it's probably worth discussing a time based release with milestones beyond which feature proposals are frozen and ones after which the code is frozen. -- Prasanna., On Mon, Jun 03, 2013 at 05:33:10PM -0400, Sebastien Goasguen wrote: > -0 [binding] > > I am torn between sticking to the schedule and delay to make sure we can > merge things cleanly. > Would rather not merge and release on-time, but it would be a pitty. > > On Jun 3, 2013, at 5:09 PM, Kevin Kluge wrote: > > > +1 [ binding ] > > > > I've been concerned that releases every four months were too > > aggressive for people to absorb given the complexity of some > > deployments and upgrades. With the current 4.1 delay and 4.2 plan > > we would expect two major releases within two months of each > > other. I'd prefer a bigger date shift for 4.2, but I see little > > appetite for that in these discussions. So I will +1 this > > proposal as a reasonable compromise. > > > > FWIW I doubt we'll get many more features in 4.2 with this. As > > Animesh noted the feature proposal date has passed so we have an > > upper bound on the additional changes for this four weeks. I > > believe this proposal will improve the quality of 4.2 on its > > planned release date as a result. > > > > -kevin > > Powered by BigRock.com
Re: netscaler jars hosted in maven central
On Mon, Jun 03, 2013 at 02:13:19PM +, Vijay Venkatachalam wrote: > Hi, > > The Apache licensed netscaler jars are now hosted in maven central. > It is possible to make the netscaler plug-in as part of the OSS. > > Please check the details below. > > Nitro jar entry > *** > com.citrix.netscaler.nitro > nitro > 10.0.e > > SDX Nitro jar entry > * > com.citrix.netscaler.nitro > sdx_nitro > 10.0 > > I would not be able to work on the OSS upgrade of the NetScaler plugin in the > immediate future. > > But here are my thoughts. > > It is better to split the OSS migration into 2 tasks. > 1. Upgrading the netscaler plugin to use the maven central repository jars > and testing it. > >>>The current cloudstack netscaler plugin code is compiled with Nitro > jar 10.0.e and SDX jar 9.3. > >>> So during the OSS migration please anticipate compilation problems > for SDX related code. > >>> Someone who is familiar with NetScaler plugin can get this done. May > be Murali or Rajesh B.? > 2. Moving the netscaler plugin to OSS. > >>> If I remember right Prasanna volunteered for this long time back. > Good news! Can you please open JIRA bugs for this so we don't forget? -- Prasanna., Powered by BigRock.com
Re: wrong dns server config?
On Mon, Jun 03, 2013 at 01:51:26PM -0400, Shane Witbeck wrote: > I was troubleshooting my ssvm the other day and found '4.4.4.4' > defined as the secondary dns server in /tools/devcloud/devcloud.cfg > and in some other scripts. > > Should this be '8.8.4.4' instead since '8.8.8.8' is the one of the > google dns [1]? > Hmmm - possibly. want to submit a patch? > > Thanks, > Shane > > [1] https://developers.google.com/speed/public-dns/ -- Prasanna., Powered by BigRock.com
Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)
On Tue, Jun 04, 2013 at 11:26:01AM +0900, Hiroaki KAWAI wrote:
> HI,
>
> I looked into tomcat6.spec file, the catalina.out
> stuff seems to be handled in rpm installation process.
>
> %install
> :
> /bin/touch ${RPM_BUILD_ROOT}%{logdir}/catalina.out
> :
>
> %files
> :
> %attr(0644,tomcat,tomcat) %{logdir}/catalina.out
> :
>
>
> So I'd like to suggest to do as such in our cloudstack spec file, too.
>
Thanks, this is more elegant for RPMs. I'm trying the fix now. But the
hack I put in should work for debian packages too.
--
Prasanna.,
Powered by BigRock.com
Re: Review Request: CLOUDSTACK-2758: touch file for tomcat6 package change CVS 2013-1976
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11620/#review21410 --- Ship it! D'oh. was testing the same thing. You were clearly faster. LGTM. Please apply to master. - Prasanna Santhanam On June 4, 2013, 6:11 a.m., Hiroaki Kawai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11620/ > --- > > (Updated June 4, 2013, 6:11 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Hugo Trippaers. > > > Description > --- > > This patch is a proposal for a better fix as is the same in tomcat6 spec file. > > > This addresses bug CLOUDSTACK-2758. > > > Diffs > - > > client/tomcatconf/classpath.conf.in f2aeeba > packaging/centos63/cloud.spec 83ccae8 > > Diff: https://reviews.apache.org/r/11620/diff/ > > > Testing > --- > > I've tested on fresh centos 6.4 installation > * install centos 6.4 > * yum upgrade -y > * yum install mysql-server > * cloudstack-setup-database > * cloudstack-setup-management > > The management server started up and I could open the webUI. > > > Thanks, > > Hiroaki Kawai > >
Re: StoragePoolForMigrationResponse and StoragePoolResponse
On Fri, May 31, 2013 at 06:28:39PM +0530, Prasanna Santhanam wrote: > On Fri, May 31, 2013 at 12:24:20PM +, Pranav Saxena wrote: > > Hey Prasanna , > > > > I see that the response object name is > > findstoragepoolsformigrationresponse , which is correct as shown > > below . Are you referring to this API or something else ? > > > > http://MSIP:8096/client/api?command=findStoragePoolsForMigration > > > > > cloud-stack-version="4.2.0-SNAPSHOT"> > > > > > > > > No that's what is shown to the user. I meant the class within > org.apache.cloudstack.api.response > Fixed with 0401774a09483354f5b8532a30943351755da93f -- Prasanna., Powered by BigRock.com
Re: Is it nessesary to test getBase64Keystore 100000 times in ConfigurationServerImplTest.java
On Tue, Jun 04, 2013 at 01:23:10PM +0200, Laszlo Hornyak wrote:
> Hi,
>
> Not anymore, but that was where the code broke because of a resource leak.
> Please just remove that test!
>
Yup - removed y'day with 22bda5c3c960e1e6897b3b0aaacdf91add97976d
>
> On Mon, Jun 3, 2013 at 8:19 AM, Wei ZHOU wrote:
>
> > The build of latest master branch spent much more time on
> > ConfigurationServerImplTest.java, which includes test getBase64Keystore
> > 10 times.
> >
> > Is it neccesary?
> >
> > [root@weizhou-centos incubator-cloudstack]# git diff
> > 2f29185943ac0412aa501b59493837b4055642e0
> > 4894187991d581b72807b4282b7a29a48a8031e5
> > +@Test
> > +public void testGetBase64KeystoreZillionTimes() throws IOException {
> > +File temp = File.createTempFile("keystore", "");
> > +try {
> > +// may cause IOException with the original implementation
> > because of too many open files
> > +for (int i = 0; i < 10; i++) {
> > +FileUtils.writeStringToFile(temp,
> > Base64.encodeBase64String(TEST.getBytes()));
> > +final String keystore =
> > ConfigurationServerImpl.getBase64Keystore(temp.getPath());
> > +// let's decode it to make sure it makes sense
> > +Base64.decodeBase64(keystore);
> > +}
> > +} finally {
> > +temp.delete();
> > +}
> > +}
> >
>
>
>
> --
>
> EOF
--
Prasanna.,
Powered by BigRock.com
Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)
On Tue, Jun 04, 2013 at 09:16:29PM -0500, Joe Brockmeier wrote: > On Tue, Jun 4, 2013, at 12:49 AM, Prasanna Santhanam wrote: > > Thanks, this is more elegant for RPMs. I'm trying the fix now. But the > > hack I put in should work for debian packages too. > > Are we sure on this? If the fix is good for 4.1.1, we can respin and > start the VOTE Wednesday.z > Joe, someone has to fix this for debian systems. I'm not too familiar with the packaging for debian. Kawai-san, can you please push your fix to master and give Joe the commit-SHA? Once these two are in, we can spin the VOTE again. -- Prasanna., Powered by BigRock.com
Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)
On Wed, Jun 05, 2013 at 03:38:17PM +0900, Hiroaki KAWAI wrote:
> Hum... interesting. In Ubuntu tomcat6, the catalina.out
> is handled in init script.
>
> 1. Download tomcat6_6.0.35-6.debian.tar.gz from
> http://packages.ubuntu.com/raring/tomcat6
> 2. untar it and look into the init script
>
> :
> touch "$CATALINA_PID" "$CATALINA_BASE"/logs/catalina.out
> chown $TOMCAT6_USER "$CATALINA_PID" "$CATALINA_BASE"/logs/catalina.out
> :
>
>
> I'd like to put a patch in reviewboard soon.
Pushed your RPM patch to master, please let Joe know when you fix DEBs
so he can spin a 4.1.1 VOTE.
commit 78196384ae905ddf01b1b2f76b9d397aa4117482
Author: Hiroaki KAWAI
Date: Tue Jun 4 12:41:09 2013 +0900
CLOUDSTACK-2758: touch file for tomcat6 package change CVS 2013-1976
catalina.out must be prepared by package installation.
Signed-off-by: Prasanna Santhanam
Thanks,
--
Prasanna.,
Powered by BigRock.com
Re: Review Request: fix copy template/iso tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11653/#review21479 --- Ship it! 2c84866 - Prasanna Santhanam On June 5, 2013, 12:39 p.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11653/ > --- > > (Updated June 5, 2013, 12:39 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > copy template/iso test is not able to get destination zone id. > > > This addresses bug CLOUDSTACK-2858. > > > Diffs > - > > test/integration/smoke/test_iso.py c645d3b > test/integration/smoke/test_templates.py 8b83f5e > > Diff: https://reviews.apache.org/r/11653/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
networkACLList
Isn't it redundant to call the API create/list/delete (NetworkACLList) That expands to create/list/delete-NetworkAccessControlListList? Should that be a Group/Container instead? Thanks, -- Prasanna., Powered by BigRock.com
Re: Review Request: fix test_service_offerings.py script for missing account details in the services dict
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11651/#review21483 --- Ship it! Ship It! - Prasanna Santhanam On June 5, 2013, 11:33 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11651/ > --- > > (Updated June 5, 2013, 11:33 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > fix test_service_offerings.py script for missing account details in the > services dict > > > This addresses bug CLOUDSTACK-2851. > > > Diffs > - > > test/integration/smoke/test_service_offerings.py 3d3b946 > > Diff: https://reviews.apache.org/r/11651/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: networkACLList
On Wed, Jun 05, 2013 at 05:43:31PM +, Kishan Kavala wrote: > Agree that it is redundant. They should be create/list/delete > NetworkACL. But these API names are already used for rules (ACL > items) within the ACL List. > This cannot be fixed without breaking backward compatibility. I was talking about the new API (NetworkACLList) that groups the NetworkACLs. We can always rename that to something sensible before it gets out and we think about backward compat issues. -- Prasanna., Powered by BigRock.com
Re: KVM development, libvirt
On Wed, Jun 05, 2013 at 05:39:16PM +, Edison Su wrote: > I think we miss a VOTE from Jenkins, the vote from Jenkins should > be taken as highest priority in each release. This kind of > regression should be easily identified in Jenkins(If we have a > regression test for each environment). > +1 - need more people focussed on cloudstack-infra in general. > > -Original Message- > > From: Marcus Sorensen [mailto:shadow...@gmail.com] > > Sent: Wednesday, June 05, 2013 9:03 AM > > To: dev@cloudstack.apache.org > > Subject: KVM development, libvirt > > > >It looks like a bug was probably introduced into 4.1, where stock Ubuntu > > 12.04 doesn't support part of the libvirt xml format for system vms. I feel > > bad > > that it got in there, but I think it highlights an issue that needs to be > > addressed within our development. Libvirt versioning is somewhat of a > > moving target. Features are introduced rapidly, and versions vary quite a > > bit > > between distributions and releases of those distributions. Despite this, > > we've largely ignored what libvirt we are targeting, assuming "whatever is > > on > > the distribution". There is the occasional discussion about this or that > > being > > available in libvirt x.x.x during the development cycle, but when it comes > > to > > qualifying the release we don't pay attention to it. > > We should. Looking at the vote for 4.1.0, several people call out which > > OS/distribution they use, but I'd like to see the libvirt version as well. At the very least - we should test for the versions of OS we decide to support. I use a base CentOS and install all packages from bare OS to cloudstack management / agent start. But I haven't been able to automate the kickstarts for Ubuntu. If *anyone* has got that working, please enlighten the list, then I can include ubuntu tests for packaging on the test infrastructure so we don't have to constantly test these things manually. > > > > Here are some initial thoughts, please add to these if you can: > > > > 1) When voting for a release, should we require a minimum number of votes > > FOR EACH supported OS? Meaning that we require positive test results from > > every OS listed as supported? In retrospect this seems like a no-brainer, > > however it may change the bylaws. > > I think we need to have that included for hypervisors too. I often find that XCP becomes the bastard child in these situations. It would be nice to have people include their version of hypervisor/OS but since most are testing devcloud as recommended in our test procedure I daresay we'll catch much. All this needs to be automated. (Any cloudstack clouds out there want to provide some tenant accounts where I can run some packaging tests for different OSes?) > > > > 2) Do we want to pull libvirt out as a standalone dependency? Meaning that > > we code to a specific version and make that more visible. This could be a > > "least common denominator" type thing where we pick the lowest version > > from all supported OSes, or it could be independent of distribution, > > whatever we decide, but we would make an effort to call out the version and > > treat it independently of OS. > > > > 3) I can think of a few things we could do in packaging to help catch > > versioning, but I'm not sure they would entirely address the issues. Please bring them forward. -- Prasanna., Powered by BigRock.com
[DISCUSS] code-freeze and integration tests
Hi, I would like to get everyone's opinions on the timeline and policies for bringing in automated tests into the repo. Integration tests are written in marvin by various people today within and without Citrix. Similar to docs I'd like to propose that tests can be committed to the repository beyond the freeze date. Right now all tests are being committed to master since that's the branch that we cut our releases out of. But after the branch for a release has been cut tests will be committed to both release branch and master if everyone agrees this is a good thing. Thoughts? -- Prasanna., Powered by BigRock.com
Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)
On Thu, Jun 06, 2013 at 08:01:10AM +0900, Hiroaki KAWAI wrote: > It took time to investigate what's happening on Ubuntu. Thanks for taking the time to investigate! > > On Ubuntu, we don't have apparent problem with current setup. > We don't have to touch catalina.out simply because it is > not used. > # Cloudstack java stdout is sent to /dev/null. > > In tomcat6, java stdout,stderr is redirected to catalina.out > (in /usr/share/tomcat6/bin/catalina.sh) Does /usr/share/cloudstack-management/ link to /usr/share/tomcat6? This is the case with RPMs at least. In which case the permission should be for cloud:cloud and not tomcat:tomcat as the init script might have done? > So, the init script touches catalina.out before invoking > catalina.sh. Additionally, there's logrotate configuration > in tomcat6 package, which will be installed at > /etc/logrotate.d/tomcat6 during postinstall. > > IMHO, it is preferable to have our catalina.out, but > there's no need to fix it in haste. Yes this time we better test it before release or it's going to be embarassing to have a supported OS not work. -- Prasanna., Powered by BigRock.com
systemvm.iso not updated in packages
systemvm.iso doesn't update on the packages even now after following fixes. Anyone know why this happens despite a clean build? CLOUDSTACK-2398 is posted. commit 55db2fe6d12338bcd5b486052e37a9cad174 Date: Mon Jun 3 14:05:15 2013 +0530 mvn clean does not do a complete clean Retains the systevm.iso from the previous run causing systemvm.iso to never update itself. Do a complete clean install for all profiles specified in mvn. Signed-off-by: Prasanna Santhanam commit 800cd391d5ff2baf02f7eed137f4f50edb126a4c Author: Marcus Sorensen Date: Thu May 30 11:47:13 2013 -0600 RPM build - run mvn clean before building packages, to get a build from fresh source Signed-off-by: Marcus Sorensen 1369936033 -0600 On Thu, May 30, 2013 at 11:44:05AM -0600, Marcus Sorensen wrote: > Yes, I don't think it's a blocker either, now that I know what's going > on. I'll get that added. > > On Thu, May 30, 2013 at 11:21 AM, Prachi Damle > wrote: > > Marcus, > > > > After a clean build did your problem disappear? I don't see a reason for a > > NoSuchMethodError popping up, except that as you say cleaning the > > repository is needed. > > > > -Prachi > > > > -Original Message- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Thursday, May 30, 2013 9:48 AM > > To: dev@cloudstack.apache.org > > Cc: Prachi Damle > > Subject: Re: [VOTE] Release Apache CloudStack 4.1.0 (fifth round) > > > > On Thu, May 30, 2013 at 10:23:31AM -0600, Marcus Sorensen wrote: > >> I think we need to add an 'mvn clean' to the cloud.spec prior to > >> building. Normally, I can build RPMs, do a pull or change some code, > >> then build RPMs, and the changes are reflected and everything is fine. > >> However, after running 'git clean -fxd', then rebuilding the same > >> code, reinstalling, the problem is gone. So apparently there is the > >> possibility that some artifacts from a previous build will get into a > >> new build, and for whatever reason this particular change in > >> VolumeReservationVO is surfacing that. > > > > Yes, for debian we do mvn clean install. > > > > IMO this isn't a release blocker though. Want to fix it in master and > > 4.1 just to it's there for the next time? > > > >> On Thu, May 30, 2013 at 10:02 AM, Chip Childers > >> wrote: > >> > cc'ing prachi > >> > > >> > On Thu, May 30, 2013 at 09:59:01AM -0600, Marcus Sorensen wrote: > >> >> Uh, we may have a problem. I deployed a fresh 4.1 two days ago, it > >> >> worked, and then I deployed current 4.1 on a separate test system > >> >> (on top of existing, but redeployed the db) and got this: > >> >> > >> >> 2013-05-30 09:51:30,975 ERROR [cloud.async.AsyncJobManagerImpl] > >> >> (Job-Executor-19:job-19) Unexpected exception while executing > >> >> org.apache.cloudstack.api.command.user.vm.DeployVMCmd > >> >> java.lang.NoSuchMethodError: > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.VolumeReservationV > >> >> O.(JJJLjava/lang/Long;)V at > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD > >> >> aoImpl.saveVolumeReservation(VMReservationDaoImpl.java:99) > >> >> at > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD > >> >> aoImpl.persist(VMReservationDaoImpl.java:88) > >> >> > >> >> > >> >> No such method? Did I just botch the reinstall (built RPMs, force > >> >> installed)? I think this has something to do with the updates from > >> >> > >> >> CLOUDSTACK-2568 > >> >> > >> >> So maybe Prachi can shed some light on this. I looked through the > >> >> mailing list and there's at least one other mention of it. > >> >> > >> >> > >> >> On Thu, May 30, 2013 at 9:07 AM, David Nalley wrote: > >> >> > On Tue, May 28, 2013 at 9:47 AM, Chip Childers > >> >> > wrote: > >> >> >> Hi All, > >> >> >> > >> >> >> I've created a 4.1.0 release, with the following artifacts up > >> >> >> for a vote. > >> >> >> > >> >> > > >> >> > +1 > >> >> > > >> >> > Checked sigs and hashes > >> >> > Built > >> >> > Packaged RPMs for EL6.4 (using nonoss profile) Did some basic > >> >> > testing > >> >> > > >> >> > --David > >> >> > >> -- Prasanna., Powered by BigRock.com
Re: Template of systemvm
On Thu, Jun 06, 2013 at 03:13:21PM +0900, Takaaki Suzuki wrote: > Hi all > > I want to download the system VM template from > "jenkins.cloudstack.org" (URL: > http://jenkins.cloudstack.org/job/build-systemvm-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvmtemplate-2013-06-04-master-kvm.qcow2.bz2) > > but, the connection is extremely slow. Does anyone know of other > mirror servers or resources? Any idea what's happening with the > jenkins server? > Currently, that's the only location. We don't have mirrors for the system VM images. The jenkins instance is experiencing high load avgs. -- Prasanna., Powered by BigRock.com
Re: KVM development, libvirt
On Thu, Jun 06, 2013 at 08:29:26AM +0200, Ove Ewerlid wrote: > On 06/06/2013 07:10 AM, Prasanna Santhanam wrote: > >On Wed, Jun 05, 2013 at 05:39:16PM +, Edison Su wrote: > >>I think we miss a VOTE from Jenkins, the vote from Jenkins should > >>be taken as highest priority in each release. This kind of > >>regression should be easily identified in Jenkins(If we have a > >>regression test for each environment). > >> > > > >+1 - need more people focussed on cloudstack-infra in general. > > The 41 regression with local storage, that required 2 or more hosts > to duplicate, would be one example of an issue that would be > detected by automatic testing provided the testing is done on a > sufficiently big test fixture. > > Q: How many hosts are used in daily testing now? 3 (2 in a cluster, 1 in a second pod) and 1 in a second zone - totalling 4 hosts in the test rig. But I don't enable local storage on it. It's occupied testing XCP, Xen and KVM with shared storage. The more configurations the longer the test run time. -- Prasanna., Powered by BigRock.com
Re: KVM development, libvirt
On Thu, Jun 06, 2013 at 09:04:55AM +0200, Ove Ewerlid wrote: > On 06/06/2013 08:37 AM, Prasanna Santhanam wrote: > >On Thu, Jun 06, 2013 at 08:29:26AM +0200, Ove Ewerlid wrote: > >>On 06/06/2013 07:10 AM, Prasanna Santhanam wrote: > >>>On Wed, Jun 05, 2013 at 05:39:16PM +, Edison Su wrote: > >>>>I think we miss a VOTE from Jenkins, the vote from Jenkins should > >>>>be taken as highest priority in each release. This kind of > >>>>regression should be easily identified in Jenkins(If we have a > >>>>regression test for each environment). > >>>> > >>> > >>>+1 - need more people focussed on cloudstack-infra in general. > >> > >>The 41 regression with local storage, that required 2 or more hosts > >>to duplicate, would be one example of an issue that would be > >>detected by automatic testing provided the testing is done on a > >>sufficiently big test fixture. > >> > >>Q: How many hosts are used in daily testing now? > > > >3 (2 in a cluster, 1 in a second pod) and 1 in a second zone - > >totalling 4 hosts in the test rig. > > > >But I don't enable local storage on it. It's occupied testing XCP, > >Xen and KVM with shared storage. The more configurations the longer > >the test run time. > > > > Not sure if you use multiple run queues, one queue with a more > extensive job that runs ones per day to capture issues in a larger > test fixture that is not suitable to build for every single commit. > This test needs to complete within 24 hours. > We don't run tests for every commit. The tests run every four-five hours for the three hypervisors. So each test run has collated a group of commits made during the time window. Each test run splits into multiple sub-jobs that are running in parallel. The extensive jobs that test for regression run on Wednesday and Saturday. These can take ~6hours to finish. ASCII representation of how the jobs split up: test-matrix |___ test-packaging (new centos VM with latest packaged CloudStack) |___ test-environment-refresh (kickstarts fresh hypervisors) |_test-setup-advanced-zone |test-smoke-matrix (Weekdays, except Wed) |___ test#1 |___ test#2 |___ test#3 |___ |___ test#n |test-regression-matrix (Wed, Sat) HTH -- Prasanna.,
Re: Template of systemvm
On Thu, Jun 06, 2013 at 10:21:33AM +0200, Wido den Hollander wrote: > > > On 06/06/2013 08:23 AM, Prasanna Santhanam wrote: > >On Thu, Jun 06, 2013 at 03:13:21PM +0900, Takaaki Suzuki wrote: > >>Hi all > >> > >>I want to download the system VM template from > >>"jenkins.cloudstack.org" (URL: > >>http://jenkins.cloudstack.org/job/build-systemvm-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvmtemplate-2013-06-04-master-kvm.qcow2.bz2) > >> > >>but, the connection is extremely slow. Does anyone know of other > >>mirror servers or resources? Any idea what's happening with the > >>jenkins server? > >> > > > >Currently, that's the only location. We don't have mirrors for the > >system VM images. The jenkins instance is experiencing high load > >avgs. > > I was already hosting some of these templates on my CloudStack > mirror: http://cloudstack.apt-get.eu/systemvm/ > > I just added two extra. Right now this is all done manually, so if > one is missing that's due to me not downloading them. > Thanks Wido! More the mirrors better since these are large downloads. -- Prasanna., Powered by BigRock.com
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11067/#review21511 --- Unable to apply this :( ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » git am -s patch/11067.patch tsp@cloud-2 Applying: CLOUDSTACK-2254: Automation: Add automation for Affinity and Anti Affinity rules /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:16: trailing whitespace. def setUpClass(cls): /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:53: trailing whitespace. /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:70: trailing whitespace. /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:77: trailing whitespace. /Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:78: trailing whitespace. def create_aff_grp(self, api_client=None, aff_grp=None, error: test/integration/component/test_affinity_groups.py: does not exist in index Patch failed at 0001 CLOUDSTACK-2254: Automation: Add automation for Affinity and Anti Affinity rules - Prasanna Santhanam On May 29, 2013, 7:56 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11067/ > --- > > (Updated May 29, 2013, 7:56 a.m.) > > > Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and > sangeetha hariharan. > > > Description > --- > > Add testcases for Affinity/Anti-Affinity Rules > > > This addresses bug CLOUDSTACK-2254. > > > Diffs > - > > test/integration/component/test_affinity_groups.py PRE-CREATION > > Diff: https://reviews.apache.org/r/11067/diff/ > > > Testing > --- > > The tests which are not skipped are working. > > > Thanks, > > Girish Shilamkar > >
Re: networkACLList
ACL Group, ACL container, ACL collection sounds a lot better than ACL List. "Access Control List List" just reads odd. Feel free to ignore my nitpick though :) On Thu, Jun 06, 2013 at 11:11:50AM +, Kishan Kavala wrote: > Preferred API name is NetworkACL, which cannot be used (NetworkACL > is already used to for items within the List). Now naming the API > NetworkACLList / Group / Container, when you expand, all of them are > equally redundant. > > > -Original Message----- > > From: Prasanna Santhanam [mailto:t...@apache.org] > > Sent: Thursday, 6 June 2013 8:03 AM > > To: dev@cloudstack.apache.org > > Subject: Re: networkACLList > > > > On Wed, Jun 05, 2013 at 05:43:31PM +, Kishan Kavala wrote: > > > Agree that it is redundant. They should be create/list/delete > > > NetworkACL. But these API names are already used for rules (ACL > > > items) within the ACL List. > > > This cannot be fixed without breaking backward compatibility. > > > > I was talking about the new API (NetworkACLList) that groups the > > NetworkACLs. We can always rename that to something sensible before it > > gets out and we think about backward compat issues. > > > > -- > > Prasanna., > > > > > > Powered by BigRock.com -- Prasanna., Powered by BigRock.com
Re: KVM development, libvirt
On Thu, Jun 06, 2013 at 10:48:14PM -0600, Marcus Sorensen wrote: > Ok. Do we need to call a vote or something to change our rules to > solidify that we should require at least two votes from each supported > platform, whether they be automated tests or contributor tests? > I'd encourage that. That'll need a change to our release testing/voting steps which works from the source release only. I'd personally prefer a jenkins automated package test. -- Prasanna., Powered by BigRock.com
Re: Review Request: Fix for test case failure test_network.py:test_delete_account - CLOUDSTACK-2898
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11713/#review21612 --- no diff here. did you forget to attach? - Prasanna Santhanam On June 7, 2013, 6:08 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11713/ > --- > > (Updated June 7, 2013, 6:08 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > https://issues.apache.org/jira/browse/CLOUDSTACK-2898 > > In this test case we need to capture "cloudstackAPIException" before > capturing more generic exceptions > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11713/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: KVM development, libvirt
On Fri, Jun 07, 2013 at 11:26:22AM -0400, John Burwell wrote: > Prasanna, > > What if we made passing the Jenkins tests a pre-requisite to open > voting? In such a scenario, the test report from the Jenkins build > would be attached to the voting email. > Absolutely, We already do check that all jobs on Jenkins are "blue" before cutting the RC. So adding those additional package tests into jenkins for supported platforms will add to the release manager's checklist. -- Prasanna., > On Jun 7, 2013, at 9:09 AM, Prasanna Santhanam wrote: > > > On Thu, Jun 06, 2013 at 10:48:14PM -0600, Marcus Sorensen wrote: > >> Ok. Do we need to call a vote or something to change our rules to > >> solidify that we should require at least two votes from each supported > >> platform, whether they be automated tests or contributor tests? > >> > > > > I'd encourage that. That'll need a change to our release > > testing/voting steps which works from the source release only. > > > > I'd personally prefer a jenkins automated package test. > > > > -- > > Prasanna., > > > > > > Powered by BigRock.com > > Powered by BigRock.com
reminder: @author tags in codebase
The latest list is on the bug report: https://issues.apache.org/jira/browse/CLOUDSTACK-1253 Please consider removing them (and fixing your IDE) if you own the code. Thanks, -- Prasanna., Powered by BigRock.com
Re: [DISCUSS] code-freeze and integration tests
On Thu, Jun 06, 2013 at 10:50:03AM +0530, Prasanna Santhanam wrote: > Hi, > > I would like to get everyone's opinions on the timeline and policies > for bringing in automated tests into the repo. Integration tests are > written in marvin by various people today within and without Citrix. > Similar to docs I'd like to propose that tests can be committed to the > repository beyond the freeze date. > > Right now all tests are being committed to master since that's the > branch that we cut our releases out of. But after the branch for a > release has been cut tests will be committed to both release branch > and master if everyone agrees this is a good thing. > > Thoughts? Looks like we have a consensus then to bring in tests post-freeze. I'll end this discussion without a VOTE then. Thanks everyone! -- Prasanna., Powered by BigRock.com
Re: ASF repo is down ?
Infra is upgrading services this weekend. Follow asfinfrabot on updates OR http://monitoring.apache.org On Sat, Jun 08, 2013 at 05:55:45PM +0200, Ove Ewerlid wrote: > On 06/08/2013 05:37 PM, Rayees Namathponnan wrote: > >Unable to access https://git-wip-us.apache.org/repos/asf?p=cloudstack.git, > >is it down ? > > > >Regards, > >Rayees > > > > Just tested, the service returns "503 Service Temporarily Unavailable". > > [oewerlid@amd-a cloudstack]$ git pull > error: The requested URL returned error: 503 Service Temporarily > Unavailable while accessing > https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/ref\ > s?service=git-upload-pack > fatal: HTTP request failed > You have new mail in /var/spool/mail/oewerlid > [oewerlid@amd-a cloudstack]$ > > > -- > Ove Everlid > System Administrator / Architect / SDN & Linux hacker > Mobile: +46706662363 > Office: +4618656913 (note EMEA Time Zone) -- Prasanna., Powered by BigRock.com
Regression failures
The regression failure rate has been quite high and the failures are mostly related to test scripts. Let's please focus with high priority on fixing as many as we can by the next run ie Wednesday. I would like to see the failure rates reduce by the 4.2 release cut on 6/28 http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-regression-matrix/23/testReport/? Our BVTs are more or less well sorted now. Rayees and Talluri will be focussing if there are any remaining failures and reporting bugs and applying patches where they can. Girish and I will be working on the regression failures. There are too many of them so I won't be filing bugs. Instead, please watch the jenkins report and pick the fixes you intend to make. If you intend to work on a fix, please file a bug report and work on the patch so we don't have overlaps. After that we need to focus on reducing the lag in the runs which are at about 7hr now. The more tests we add, the slower this gets. We might think about consolidating all our infrastructure to accomadate runs on all hypervisors. Thanks, -- Prasanna., Powered by BigRock.com
Re: What are the standard commands to setup 4.1 development environment
On Mon, Jun 10, 2013 at 03:52:19PM +0800, Ryan Lei wrote: > CloudStack 4.1 has been released, but I see two "versions" of instructions > in setting up the oss development environment. > > (1) From the official website: > http://cloudstack.apache.org/develop/environment.html > > # Compile > $ mvn -P developer clean install > # Deploy both the management server and the database > $ mvn -P developer -pl developer,tools/devcloud -Ddeploydb > # Deploy the database again (??, devcloud involved?) > $ mvn -P developer -pl tools/devcloud -Ddeploysvr > # Start the Jetty server > $ mvn -pl :cloud-client-ui jetty:run > > (2) From INSTALL.md in the source code: > > # Compile > $ mvn clean install -P systemvm,developer > # Deploy both the management server and the database > $ mvn -P developer -pl developer -Ddeploydb > # Export this if using remote debugging > $ export MAVEN_OPTS="-Xmx1024m -XX:MaxPermSize=500m -Xdebug > -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n" > # Start the Jetty server > $ mvn -pl :cloud-client-ui jetty:run > > I'm using a physical host for XCP/XenServer, not devcloud, with CloudStack > + MySQL running on a separate CentOS VM. > I previously used version (2) to compile git 4.1 branch, but I used > "-DskipTests=true" in the compile step to save time. Is this the right way? > What does the "-P systemvm" actually mean in the command? (2) will work against 4.1. The systemvm profile builds the systemvm.iso which is used to patch scripts on the systemVMs. To use an external host, you can skip deploysvr step and add your hosts from the UI. In build/replace.properties you will need to specify the DBHOST to point to your mysql instance. Or else deploydb assumes you are running the db on localhost. In (1) the order of steps are wrong. One should do jetty:run before doing -Ddeploysvr. HTH -- Prasanna., Powered by BigRock.com
Re: What are the standard commands to setup 4.1 development environment
On Mon, Jun 10, 2013 at 04:52:22PM +0800, Ryan Lei wrote: > Thanks for the quick explanation. > Then should the cloud-install-sys-tmplt script be run before or after the > systemvm profile? Or does it matter at all? The install-sys-tmplt script still will need to be run (before you launch the management server). That will place the systemVM images (from which systemvms become systemVMs) on your secondary storage. It is from these that they will be spawned and then systemv.iso patches the latest scripts -- Prasanna., Powered by BigRock.com
VPC and shared networks
Can we create shared networks inside a VPC? If yes - why does the UI filter out the network offerings in the VPC dialog on listing networks using forvpc=true & guestiptype=Isolated? If no - we can get rid of a test suite - TestVMLifeCycleSharedNwVPC. But was it supported before and dropped recently? I was able to create a networkoffering with vpc=true and guestIpType=Shared, but the VPC network creation fails with """ Network offering can't be used for VPC networks """ -- Prasanna., Powered by BigRock.com
Re: VPC and shared networks
On Mon, Jun 10, 2013 at 03:39:08PM +0530, Prasanna Santhanam wrote: > Can we create shared networks inside a VPC? If yes - why does the UI > filter out the network offerings in the VPC dialog on listing networks > using forvpc=true & guestiptype=Isolated? > > If no - we can get rid of a test suite - TestVMLifeCycleSharedNwVPC. > But was it supported before and dropped recently? I was able to create > a networkoffering with vpc=true and guestIpType=Shared, but the VPC > network creation fails with > > """ > Network offering can't be used for VPC networks > """ > Filed: CLOUDSTACK-2920 Powered by BigRock.com
[OFFLINE] 6/12 and 6/13
Will be away mid-week and won't be able to make it to the meeting and/or check emails. Thanks, -- Prasanna., Powered by BigRock.com
Review Request: Fix systemVM template job
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11802/ --- Review request for cloudstack, Chiradeep Vittal and Rohit Yadav. Description --- Putting this here since git-asf is down at the moment: When both systemvmtemplate64 and systemvmtemplate are present the pattern match can fail and return the hdd path of the 64-bit template. Do a perfect match by including the path separator (/) in the grep expression Diffs - tools/appliance/build.sh 0216c06 Diff: https://reviews.apache.org/r/11802/diff/ Testing --- System VM job is able to run manually Thanks, Prasanna Santhanam
Re: haproxy on VMWare systemVM template
On Mon, Jun 10, 2013 at 09:50:09PM +, Chiradeep Vittal wrote: > The jenkins build of the systemvm has been failing for a couple of days. > Can someone clean it up? Looks like the 64-bit job was enabled and left a hdd hanging. There was a mistake in the grep pattern that returned the hung disk to the 32-bit job. I fixed that but it's hung on a git fetch now. So I've put a review here : https://reviews.apache.org/r/11802/ When git comes back up, please apply it. Going home now. -- Prasanna., Powered by BigRock.com
Re: Review Request: Automation: Network life cycle tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11835/#review21797 --- test/integration/smoke/test_network.py <https://reviews.apache.org/r/11835/#comment44975> account is not derefenced as account.account anymore. Was this change unintended? All instances of account.account were changed to account only sometime back in all the tests - Prasanna Santhanam On June 12, 2013, 2:11 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11835/ > --- > > (Updated June 12, 2013, 2:11 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan. > > > Description > --- > > Changed code related to verifying round robin of ip address allocation. > > > Diffs > - > > test/integration/smoke/test_network.py a65748d > > Diff: https://reviews.apache.org/r/11835/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11067/#review21798 --- Girish, I'm only able to apply patch 1 that adds the test_affinity_groups module. Subsequent patches fail. Can you squash all the patches starting from the first patch that adds the tests for affinity groups into one patch please? Sorry for the delays. - Prasanna Santhanam On June 10, 2013, 10:03 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11067/ > --- > > (Updated June 10, 2013, 10:03 a.m.) > > > Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and > sangeetha hariharan. > > > Description > --- > > Add testcases for Affinity/Anti-Affinity Rules > > > This addresses bug CLOUDSTACK-2254. > > > Diffs > - > > test/integration/component/test_affinity_groups.py PRE-CREATION > > Diff: https://reviews.apache.org/r/11067/diff/ > > > Testing > --- > > The tests which are not skipped are working. > > > Thanks, > > Girish Shilamkar > >
Re: Review Request: fix the occurences of account.account. to account.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11677/#review21799 --- Fails to apply :( ~/workspace/cloudstack/incubator-cloudstack/patch(branch:master*) » git am -s 11677.patch Applying: CLOUDSTACK-2363: fix to conform to the lib changes error: patch failed: test/integration/component/test_advancedsg_networks.py:726 error: test/integration/component/test_advancedsg_networks.py: patch does not apply error: patch failed: test/integration/component/test_shared_networks.py:2309 error: test/integration/component/test_shared_networks.py: patch does not apply Patch failed at 0001 CLOUDSTACK-2363: fix to conform to the lib changes When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". - Prasanna Santhanam On June 6, 2013, 4:34 p.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11677/ > --- > > (Updated June 6, 2013, 4:34 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > fix the occurences of account.account. to account. > > > Diffs > - > > test/integration/component/test_advancedsg_networks.py e24254d > test/integration/component/test_custom_hostname.py a85f619 > test/integration/component/test_netscaler_configs.py 1c67bc4 > test/integration/component/test_netscaler_lb.py 80b3f0b > test/integration/component/test_netscaler_lb_algo.py 4a2d1fe > test/integration/component/test_netscaler_lb_sticky.py 7f391d0 > test/integration/component/test_shared_networks.py 5f96419 > > Diff: https://reviews.apache.org/r/11677/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request: fix the occurences of account.account. to account.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11677/#review21800 --- Ship it! 862b955 - Prasanna Santhanam On June 6, 2013, 4:34 p.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11677/ > --- > > (Updated June 6, 2013, 4:34 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > fix the occurences of account.account. to account. > > > Diffs > - > > test/integration/component/test_advancedsg_networks.py e24254d > test/integration/component/test_custom_hostname.py a85f619 > test/integration/component/test_netscaler_configs.py 1c67bc4 > test/integration/component/test_netscaler_lb.py 80b3f0b > test/integration/component/test_netscaler_lb_algo.py 4a2d1fe > test/integration/component/test_netscaler_lb_sticky.py 7f391d0 > test/integration/component/test_shared_networks.py 5f96419 > > Diff: https://reviews.apache.org/r/11677/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request: add zone wide primary storage tests
> On May 31, 2013, 4:43 a.m., Prasanna Santhanam wrote: > > test/integration/smoke/test_zwps.py, line 127 > > <https://reviews.apache.org/r/11462/diff/2/?file=297285#file297285line127> > > > > This test is not required. If I deploy a zone with zone-wide storage > > then the regular deployVM test will be sufficient. > > SrikanteswaraRao Talluri wrote: > Above suggestion is enough for deploy VM when there is only zone-wide > storage, the case added here is a case where there are multiple primaries > and if you want to choose where your VM to be on ZWPS. > > For testing VM life cycle tests on different scoped(CLUSTER, ZONE, HOST) > primary storages, if we have a zone deployed with just that specific scoped > storage, I agree , just running VM life cycle would suffice. Can I run this test on any configuration of advanced zone and NFS storage? Will this need to have a zone-wide primary storage added to work? - Prasanna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11462/#review21227 --- On May 28, 2013, 3:24 p.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11462/ > --- > > (Updated May 28, 2013, 3:24 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi. > > > Description > --- > > Added few basic zone wide primary storage tests. > > > This addresses bug CLOUDSTACK-2710. > > > Diffs > - > > test/integration/smoke/test_primary_storage.py 598654d > test/integration/smoke/test_zwps.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py ec1c34e > > Diff: https://reviews.apache.org/r/11462/diff/ > > > Testing > --- > > done. > teardown() fails as there is a bug while moving a storagepool into > maintenance. > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Git question about applying patch files
The 'cleanest cleanest' way is to use rebase as Sheng recommends but I know people who've used git successfully with just doing merge. It's (rebase) one of those features of git you discover only after using-abusing it for long enough. But if you're adventurous .. :) Do NOT do a rebase if you've done merges until now on your branch. Here's a nice post explaining how to work with rebase for those hesitant to use it: http://mettadore.com/analysis/a-simple-git-rebase-workflow-explained/ -- Prasanna., On Thu, Jun 13, 2013 at 01:50:15AM -0400, John Burwell wrote: > Mike, > > The cleanest way have found to create these patches is actually > create a temporary work branch from master, merge the feature branch > into it with the squashed option, and then generate the patch. This > gist (https://gist.github.com/jburwell/5771480) is the shell script > I used to generate the S3-backed Secondary Storage patch submissions > to Review Board. It should be fairly easy to adapt by adjusting the > FEATURE_BRANCH and WORK_HOME values. > > Thanks, > -John > > On Jun 12, 2013, at 6:25 PM, Mike Tutkowski > wrote: > > > I have a branch, solidfire_plugin, off of master in my local repo. > > > > I wanted to submit a patch to Review Board. > > > > Essentially, I followed these steps (where upstream is the official CS > > repo): > > > > git checkout master > > > > git fetch upstream > > > > git reset --hard upstream/master > > > > git checkout solidfire_plugin > > > > git merge master > > > > git format-patch master --stdout > solidfire_plugin.patch (this collected > > six commits worth of work) > > > > git checkout master > > > > git am solidfire_plugin.patch > > This final command lead to this error message (below). I was surprised > > because I had just performed a merge from master to solidfire_plugin before > > generating the patch file (so I was thinking the patch file should cleanly > > apply on master). > > > > Any thoughts on this? > > > > Thanks! > > > > mtutkowski-lt:cloudstack mtutkowski$ git am solidfire_plugin_a.patch > > Applying: SolidFire plug-in and enhancements to the storage plug-in > > framework > > /Users/mtutkowski/documents/cloudstack/src/cloudstack/.git/rebase-apply/patch:60: > > trailing whitespace. > > > > /Users/mtutkowski/documents/cloudstack/src/cloudstack/.git/rebase-apply/patch:62: > > trailing whitespace. > > > > /Users/mtutkowski/documents/cloudstack/src/cloudstack/.git/rebase-apply/patch:64: > > trailing whitespace. > > > > /Users/mtutkowski/documents/cloudstack/src/cloudstack/.git/rebase-apply/patch:66: > > trailing whitespace. > > > > /Users/mtutkowski/documents/cloudstack/src/cloudstack/.git/rebase-apply/patch:68: > > trailing whitespace. > > > > error: patch failed: api/src/com/cloud/offering/DiskOffering.java:46 > > error: api/src/com/cloud/offering/DiskOffering.java: patch does not apply > > error: patch failed: api/src/com/cloud/storage/Volume.java:120 > > error: api/src/com/cloud/storage/Volume.java: patch does not apply > > error: patch failed: api/src/org/apache/cloudstack/api/ApiConstants.java:49 > > error: api/src/org/apache/cloudstack/api/ApiConstants.java: patch does not > > apply > > error: patch failed: > > api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java:52 > > error: > > api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java: > > patch does not apply > > error: patch failed: > > api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java:67 > > error: > > api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java: > > patch does not apply > > error: patch failed: > > api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java:51 > > error: > > api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java: patch > > does not apply > > error: patch failed: > > api/src/org/apache/cloudstack/api/response/VolumeResponse.java:79 > > error: api/src/org/apache/cloudstack/api/response/VolumeResponse.java: > > patch does not apply > > error: patch failed: client/WEB-INF/classes/resources/messages.properties:14 > > error: client/WEB-INF/classes/resources/messages.properties: patch does not > > apply > > error: patch failed: client/pom.xml:22 > > error: client/pom.xml: patch does not apply > > error: patch failed: client/tomcatconf/applicationContext.xml.in:798 > > error: client/tomcatconf/applicationContext.xml.in: patch does not apply > > error: patch failed: > > core/src/com/cloud/agent/api/AttachVolumeCommand.java:23 > > error: core/src/com/cloud/agent/api/AttachVolumeCommand.java: patch does > > not apply > > error: patch failed: > > core/test/org/apache/cloudstack/api/agent/test/AttachVolumeAnswerTest.java:28 > > error: > > core/test/org/apache/cloudstack/api/agent/test/AttachVolumeAnswerTest.java: > > patch does not apply > > error: patch failed: > > core/test/org/apache/cloudstack/api/agent/test/AttachVolumeCommandTest.java:27 > > error: > > c
Re: Review Request: Automation: Network life cycle tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11835/#review21859 --- Ship it! ed1980c7417216efa541c978d4233391d1659b79 - Prasanna Santhanam On June 13, 2013, 10:30 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11835/ > --- > > (Updated June 13, 2013, 10:30 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan. > > > Description > --- > > Changed code related to verifying round robin of ip address allocation. > > > Diffs > - > > test/integration/smoke/test_network.py 1c867fa > > Diff: https://reviews.apache.org/r/11835/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Automation analysis improvement
Indeed - expunge, storage, account cleanups are set to 60s on all automated test environments I've setup. The cleanup process works as below: setUpClass() -> creates user account, creates user resources testXxx() -> test steps and verify within the account tearDownClass() -> cleanup resources acquired in setUpClass() The way this is done is to collect a list of resource objects in setUpClass#_cleanup (like [account, vm, offering]). In tearDownClass we simply process that list calling delete on each item. Usually, just the account is enough since the account GC thread will take care of the rest. Rayees - if you've identified these tests then please submit a patch if they flout the process I've explained above. I've fixed some before, but there's probably more. Thanks, -- Prasanna., On Fri, Jun 14, 2013 at 11:08:42AM -0700, Ahmad Emneina wrote: > I'm +1 on this. I feel global setting (relating to expunge and > cleanup) should be set to aggressively expunge deleted resources, > then delete the user resources... before deleting the account. That > way we can verify garbage collection of resources is working > properly. > > Ahmad > > On Jun 14, 2013, at 10:21 AM, Chiradeep Vittal > wrote: > > > +1 > > > > On 6/14/13 8:54 AM, "Rayees Namathponnan" > > wrote: > > > >> Many of the automation test cases are not tearing down the account > >> properly; due to this resources are not getting released and followed > >> test cases getting failed during VM deployment itself. > >> > >> During automation run accounts are created with random number without any > >> reference for test case (eg : test-N5QD8N), and it's hard to identify > >> which test case not tearing down the account after complete the test. > >> > >> Here my suggestion; we should create account name with test case name > >> (eg : test- VPCOffering-N5QD8N) > >> > >> Any thoughts ? > >> > >> Regards, > >> Rayees > > Powered by BigRock.com
Infra Issues from the IRC meeting (Wed, Jun 12)
Saw a few infra topics being discussed in the meeting and there was talk of bringing it to the list so I'm taking this opportunity to explain some things behind it. > 17:22:44 [Animesh]: I will send out my weekly reminder today on status and > include Sudha's test results > 17:23:28 [topcloud]: one thing that concerns me is that the bvt continues to > be at < 100% pass rate > 17:23:41 [topcloud]: is there anything we're doing about this? yes - I've fixed most tests. Some have existed because of bugs in packaging, systemvm templates that I see patches for now. > 17:25:20 [chipc]: topcloud: was BVT ever at 100% ? > 17:25:32 [chipc]: (real question, not sarcasm) It was - 100% - when the project was first proposed. But more tests have come in since then. > 17:26:41 [chipc]: once we get it back to 100%, I say we block all changes > when it drops to <100% > 17:26:49 [topcloud]: +1 +1 - this is what I've been driving towards but haven't announced some changes I've made in the past weeks because it's pointless to have tests fail soon as I announce we are 100%. We shouldn't wait for one run, but at least 10 to ensure that the bvt is indeed stable enough to be trusted as a 'gating' system for master stability. There's also a couple of issues here - 1. Does everyone know where the tests run? 2. Do people know how to spot the failures? 3. Do people know how to find the logs for the failures? If the answer is no to all this, I have more documentation on my hands. > 17:28:07 [Animesh]: agreed bvt also shows progress towards release readines > 17:28:07 [chipc]: topcloud: +1 > 17:28:32 [chipc]: Animesh: BVT should show that master is stable, regardless > of release timeframes > 17:28:33 [chipc]: IMO that is > 17:28:44 [chipc]: master should only see good /tested code Which is why the BVT runs on master at all times on jenkins.buildacloud.org. There is also ability to run it against a feature branch but I would rather defer that to the release manager for now since it's tied with hardware resources and jenkins schedules. That feature should strictly be reserved for architecture changes in MERGE requests. > 17:43:27 [topcloud]: sorry...to bring back this topic but is bvt running on > apache infra? > 17:43:35 [chipc]: no > 17:43:57 [topcloud]: chipc: is there any talk about bringing it into apache > infra? It was brought up with the ASF infra back in January and the suggestion was to donate hardware to the ASF to manage. So if we're prepared to do that, great! But it certainly can't just be Citrix :) I'd prefer individual project related test hardware and resources to stay in the control of the project. Infrastructure is constantly changed to allow features and enhancements to be tested so it's best to have it in the core group. Which is why jenkins.buildacloud.org came to existence. This is similar to how cloudbees operates or (*gasp*) openstack-infra [1][2] operates. Ideally, I'd like those interested in infra activities to form a separate group for cloudstack-infra related topics. The group's focus will be to maintain, test and add to the infrastructure of this project. But that's in the future. Without such a group, building an IaaS cloud is not much fun :) > 17:44:17 [topcloud]: i can't imagine apache wanting bvt to only run inside > citrix all the time. It doesn't run within Citrix. It runs in a DC in Fremont. There are other environments within Citrix however that run their own tests for their needs - eg: object_store tests, cloudplatform tests, customer related issue tests etc. /me beginning to think more doc work is on my way :/ > 17:46:27 [chipc]: but generally, the ASF build infra is a bit overloaded +1000 > 17:46:51 [jzb]: topcloud: when you say "in Citrix" - it's still visible > outside Citrix, yes? > 17:46:52 [chipc]: so frankly, CTXS donating an environment to run it, > publicly visible to everyone, is quite helpful > 17:46:58 [chipc]: jzb: it is We need more people to donate hardware/virtual resources for testing :) CTXS has been gracious to provide quite a few resources already IMO. > 17:47:18 [chipc]: actually, I think it is... > 17:47:34 [topcloud]: jzb: yeah it's still visible but it really should be > runnable by everyone. Not quite. It's a gating system. It runs automatically and shouldn't be runnable by everyone at will. I'm still waiting to implement devcloud tests based on that gerrit converstaion (which went nowhere) we had many months back. DevCloud stuff can be run at will. > 17:47:37 [jzb]: I'm all for building up Apache infra, but I also > think having vendors donate publicly visible resources that are > usable by the community is acceptable. +1 > 17:47:53 [jzb]: in fact, we probably ought to be hitting up some of > our ISP friends for more. +1 - who are our ISP friends? Would like to get help on this. > 17:49:49 [ke4qqq]: so tsp (along with abayer and roman) are working > on a publicly accessible jenkins instance in fremont This is basically to dogfood all inst
Re: Summary of IRC meeting in #cloudstack-meeting, Wed Jun 12 17:08:56 2013
On Fri, Jun 14, 2013 at 11:24:11AM +0100, Noah Slater wrote: > While we're talking about bot etiquette... ;) If people used #info and > #action, important takeaway points would be included at the top of the > email. As it is, it's a bit hard to read through the logs if you just want > to get a jist. Yeah - we usually use them but looks like it was missed this time. Took some time to glean out the important bits from this meeting. -- Prasanna., Powered by BigRock.com
Re: [MERGE]object_store branch into master [Second round]
On Sat, Jun 15, 2013 at 03:07:39AM +, Edison Su wrote: > Hi all, > The second round, call for merge object_store branch into master, is > coming! > The issues fixed: >1. All the major issues addressed by John are fixed: > 1.1 A cache storage replacement algorithm is added: > StorageCacheReplacementAlgorithmLRU, based on the reference count and least > recently used. > 1.2 A new S3 transport is added, can upload > 5G template > into S3 directly. > 1.3 Retry, if S3 upload failed. > 1.4 some comments from https://reviews.apache.org/r/11277/, > mostly, the coding style, are addressed and clean up some unused code. > 2. DB upgrade path from 4.1 to 4.2 > 3. Bug fix > > The size of the patch is even bigger now, around 10 LOC, you > can find about the patch from > https://reviews.apache.org/r/11277/diff/2/. > Comments/feedback are welcome. Thanks. Awesome work - looking forward to this. Great discussions in the past few weeks. Some of the better topic threads we've had in the recent past! -- Prasanna., Powered by BigRock.com
Re: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11874/#review21937 --- Ship it! Ship It! - Prasanna Santhanam On June 14, 2013, 10:09 a.m., Rajesh Battala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11874/ > --- > > (Updated June 14, 2013, 10:09 a.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > --- > > Issue: .There are two ssvm_check scripts(duplicates). > > ./services/console-proxy/server/scripts/ssvm-check.sh > ./services/secondary-storage/scripts/ssvm-check.sh > > When building the code, these scripts will go to systemvm.zip, systemvm.zip > will be packaged into systemvm.iso. > > systemvm-descriptor.xml will define what all the scripts should package. > As per the descriptor xml, the ssvm-check script under console-proxy is > getting into systemvm.zip. > > I had verified the ssvm-check script with the fix under console-proxy. The > systemvm.zip is getting update properly and making into systemvm.iso. > And ssvm is getting the right script now. > > Changes made in script under > ./services/secondary-storage/scripts/ssvm-check.sh is not getting into > systemvm.iso > > Fixed: > Modified systemvm-descriptor.xml to pick the ssvm-check.sh form > ./services/secondary-storage/scripts/ssvm-check.sh > removed the duplicate file which is creating confusion > (./services/console-proxy/server/scripts/ssvm-check.sh) > > > This addresses bug CLOUDSTACK-3004. > > > Diffs > - > > services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 > services/console-proxy/server/systemvm-descriptor.xml e34026b > > Diff: https://reviews.apache.org/r/11874/diff/ > > > Testing > --- > > Tested by generating the systemvm.zip , the ssvm-check file is getting copied > into the zip from the ./services/secondary-storage/scripts/ssvm-check.sh > > > Thanks, > > Rajesh Battala > >
Test Result for test-smoke-matrix #469
Test Run: #469 Total:96 Fail :17 Skip :2 name passfailskip test_portable_publicip/ 0 2 0 test_ssvm/6 4 0 test_templates/ 7 0 1 test_deploy_vm_with_userdata/ 2 0 0 test_guest_vlan_range/1 0 0 test_internal_lb/ 1 0 0 test_scale_vm/0 1 0 test_iso/ 4 1 1 test_vm_snapshots/0 3 0 test_disk_offerings/ 3 0 0 test_non_contigiousvlan/ 1 0 0 test_network/ 7 3 0 test_volumes/ 9 0 0 test_regions/ 1 0 0 test_secondary_storage/ 1 1 0 test_network_acl/ 1 0 0 test_global_settings/ 1 0 0 test_nic/ 1 0 0 test_vm_life_cycle/ 9 1 0 test_pvlan/ 1 0 0 test_service_offerings/ 4 0 0 test_deploy_vms_with_varied_deploymentplanners/ 2 1 0 test_routers/10 0 0 test_deploy_vm/ 1 0 0 test_privategw_acl/ 1 0 0 test_public_ip_range/ 1 0 0 test_resource_detail/ 1 0 0 test_affinity_groups/ 1 0 0 Regressions name durationage integration.smoke.test_secondary_storage.TestSecStorageServices.test_01_sys_vm_start 0.184 1 Failures name durationage integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire.test_createPortablePublicIPAcquire 0.001159 integration.smoke.test_portable_publicip.TestPortablePublicIPRange.test_createPortablePublicIPRange 0.001159 integration.smoke.test_ssvm.TestSSVMs.test_03_ssvm_internals 3.089293 integration.smoke.test_ssvm.TestSSVMs.test_05_stop_ssvm 77.836293 integration.smoke.test_ssvm.TestSSVMs.test_07_reboot_ssvm 82.731293 integration.smoke.test_ssvm.TestSSVMs.test_09_destroy_ssvm 200.867293 integration.smoke.test_scale_vm.TestScaleVm.test_01_scale_vm 0.115206 integration.smoke.test_iso.TestISO.test_04_extract_Iso 5.169 1 integration.smoke.test_vm_snapshots.TestVmSnapshot.test_01_create_vm_snapshots 1654.14 integration.smoke.test_vm_snapshots.TestVmSnapshot.test_02_revert_vm_snapshots 1653.77 4 integration.smoke.test_vm_snapshots.TestVmSnapshot.test_03_delete_vm_snapshots 0.061 4 integration.smoke.test_network.TestLoadBalancingRule.test_02_create_lb_rule_non_nat 15.401 12 integration.smoke.test_network.TestPortForwarding.test_02_port_fwd_on_non_src_nat 20.419 27 integration.smoke.test_network.TestRebootRouter.test_reboot_router 267.101137 integration.smoke.test_vm_life_cycle.TestVMLifeCycle.test_09_expunge_vm 5.11 27 integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners.test_deployvm_userdispersing 116.184 55 Fixed name durationage integ
Re: Test Result for test-smoke-matrix #469
This is the sample output for the detail requested by Sudha to automated tests running on jenkins. The email is automated, but generated on my laptop and I choose to send it. If there's further fields to be tweaked, feel free to contribute/request them @ https://github.com/vogxn/jenkins2email On Sat, Jun 15, 2013 at 07:02:25PM +0530, Prasanna Santhanam wrote: > > detailed report @ > http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/469/testReport/ > > Thanks, > -- Prasanna., Powered by BigRock.com
Re: Review Request: Fix test case issue reported in CLOUDSTACK-3020
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11897/#review21954 --- Doesn't the displayname become the uuid hence the id when no custom instance name is given? It seems the assertEqual is correct, but the assertion message should be "DisplayName should be UUID when no custom hostname is provided" - Prasanna Santhanam On June 16, 2013, 12:19 a.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11897/ > --- > > (Updated June 16, 2013, 12:19 a.m.) > > > Review request for cloudstack and tom pierce. > > > Description > --- > > Fixing test case assert issue with > TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11897/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: OS type not passing while creating template in "test_accounts.TesttemplateHierarchy"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11898/#review21955 --- Ship it! 2f345c5 - Prasanna Santhanam On June 16, 2013, 5:12 a.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11898/ > --- > > (Updated June 16, 2013, 5:12 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test case test_accounts.TesttemplateHierarchy failed with below error > > File > "/Repo_30X/ipcl/cloudstack/test/integration/component/test_accounts.py", line > 887, in setUpClass > domainid=cls.domain_1.id > File > "/usr/local/lib/python2.7/site-packages/marvin/integration/lib/base.py", line > 822, in register > "Unable to find Ostype is required for registering template") > Exception: Unable to find Ostype is required for registering template > > > This is because we are not passing ostype, while created template ; fixed > this. > > > Diffs > - > > test/integration/component/test_accounts.py 3f106c3 > > Diff: https://reviews.apache.org/r/11898/diff/ > > > Testing > --- > > Test this, but below issue need to get fixedto pass this test case. > https://issues.apache.org/jira/browse/CLOUDSTACK-3021 > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Fix test case issue reported in CLOUDSTACK-3020
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11897/ --- (Updated June 16, 2013, 5:56 a.m.) Review request for cloudstack and Prasanna Santhanam. Changes --- correcting reviewer Description --- Fixing test case assert issue with TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration Diffs - Diff: https://reviews.apache.org/r/11897/diff/ Testing --- Tested Thanks, Rayees Namathponnan
Re: Review Request: Removed-junk-characters-from-test_netscaler_lb.py.patch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11901/#review21964 --- I think you've forgotten to attach the diff - Prasanna Santhanam On June 16, 2013, 4:52 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11901/ > --- > > (Updated June 16, 2013, 4:52 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test case failed, due to some junk character in script > > Traceback (most recent call last): > File "/usr/local/lib/python2.7/unittest/case.py", line 318, in run > testMethod() > File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 413, in > loadTestsFromName > addr.filename, addr.module) > File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in > importFromPath > return self.importFromDir(dir_path, fqname) > File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in > importFromDir > mod = load_module(part_fqname, fh, filename, desc) > File > "/Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py", > line 1089 > SyntaxError: Non-ASCII character '\xe2' in file > /Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py on > line 1089, but no encoding declared; see > http://www.python.org/peps/pep-0263.html for details > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11901/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Fix-all-occurrences-of-account.account-from-test_netscaler_configs.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11900/#review21966 --- Same here. Diff has not been uploaded - Prasanna Santhanam On June 16, 2013, 4:19 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11900/ > --- > > (Updated June 16, 2013, 4:19 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test cases test_netscaler_configs.py, failed due issue with account instance > create , > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11900/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Automation: Memory limits tests from Resource Limits Tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/#review21967 --- Gaurav, I think this diff suffers from the same problems as the previous diff for memory limit tests. The patch is incomplete as it doesn't include changes to the library for memory limit objects - Resources, get_resouce_type etc. 1. Please split each class into a different module. This allows them to be processed in parallel as they have no dependency between each other. VPC related suites suffer the same problem. It takes over 3 hrs to run them because we've put too many tests into the same suite 2. You can organize the tests into test/integration/component/memory_limits/test_domain_limits.py|test_project_limits.py etc. The test discoverer will drill down to find the tests to be run 3. There are a lot of repeated use of small methods like checkUpdateResourceCount, createInstance etc. This is good for refactoring but it makes it harder for someone reading the test to quickly understand what each method is doing. Instead looking at VM.create, ResourceCount.update will make it easier to look in one place - the libraries. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45284> The entity 'Resource' needs to be added to integration.lib.base test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45285> get_resource_type is missing in utils test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45286> remove the `pass` here test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45288> Do we need this method? I think keeping the VM creation step (VirtualMachine.create, asserts1, assert2) is easier than refactoring this into a test specific method for each test suite. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45287> account reference is account.account test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45289> Same here, anyone reading the test should be able to make sense of Network.list followed by assert faster than having to hunt down what get_network does each time. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45290> what if networks is an empty list? [] test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45291> account dereferences as account.name only. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45292> account dereferences as account.name only. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45293> This calls listHosts and not findHostSuitableForMigration I think? test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45295> Does it make sense to break this test down into smaller steps? class Test_LimitsInVmLifeCycle(): test_migrate_limitcheck test_stop_limitcheck test_reboot_limitcheck Putting in so many life cycle operations into the same test is complicating it. test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45294> When you use an rtype can you also add a comment? checkUpdatedResourceCount(account, rtype=9)#RAM test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45296> Reuse service offerings? test/integration/component/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment45297> I'm confused - are we checking the RAM usage or are we updating the resource count for memory usage? The comment in the test confuses me. - Prasanna Santhanam On June 4, 2013, 11:39 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11626/ > ------- > > (Updated June 4, 2013, 11:39 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Adding resource limit tests related to Memory. Changes suggested in CPU > resource limit tests which are applicable here are incorporated too. > > Updated test plan is available here: > https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=
Re: Review Request: Automation: Memory limits tests from Resource Limits Tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/#review21970 --- I've reviewed the first two suites of this large module but the others suffer the same issues. Please fix them and upload a new patch. Thanks - Prasanna Santhanam On June 4, 2013, 11:39 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11626/ > --- > > (Updated June 4, 2013, 11:39 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Adding resource limit tests related to Memory. Changes suggested in CPU > resource limit tests which are applicable here are incorporated too. > > Updated test plan is available here: > https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000 > > > Diffs > - > > test/integration/component/test_memory_limits.py PRE-CREATION > > Diff: https://reviews.apache.org/r/11626/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> On June 17, 2013, 5:06 a.m., Abhinandan Prateek wrote: > > This is a old patch, is it still valid ? Hmm - quite embarrassing it is over 3 months old. We may have missed a contributor :( However should be valid still because the secondary storage host still shows 'Alert' on all installs. - Prasanna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/#review21971 --- On May 31, 2013, 1:01 a.m., roxanne chang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9818/ > --- > > (Updated May 31, 2013, 1:01 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and edison su. > > > Description > --- > > Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status > [https://issues.apache.org/jira/browse/CLOUDSTACK-1594] > > In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if > the host type is Secondary storage VM, the logic is to set secondarystorage > host, at this time, secondarystorage host stauts should become Up. > > The secondary storage host always remains Alert status, because before the > secondary storage vm is deployed, the secondary storage host is created. The > tricky way (in the end of file AgentManagerImpl.java, function > NotifiMonitorsOfConnection) will try to disconnect secondary storage, > therefore the secondary storage host becomes Alert status. The code should > take SSVM into consider, not only Answer reponse. > > File ResourceManagerImpl.java, function discoverHostsFull, in the end will > call discoverer.postDiscovery, in file > SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not > needed since its use to make secondary storage host wait for SSVM is already > done in SecondaryStorageManagerImpl. This makes why secondary storage host > always remains Alert status. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594. > > > Diffs > - > > server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 > server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java > 3ca74a3 > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > 46ac7af > > Diff: https://reviews.apache.org/r/9818/diff/ > > > Testing > --- > > Test 4.0.0, 4.2.0 in basic mode, works well. > > > Thanks, > > roxanne chang > >
Re: systemvm.iso not updated in packages
Applied yet another fix for this from Rajesh: commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3 Author: Rajesh Battala Date: Sat Jun 15 11:21:46 2013 +0530 CLOUDSTACK-3004: remove duplicate ssvm-check.sh ssvm_check.sh remove the duplicate file from consoleproxy and include the script from secondary storage folder while packing iso Signed-off-by: Prasanna Santhanam On Thu, Jun 06, 2013 at 11:02:39AM +0530, Prasanna Santhanam wrote: > systemvm.iso doesn't update on the packages even now after following fixes. > Anyone know why this happens despite a clean build? > > CLOUDSTACK-2398 is posted. > > commit 55db2fe6d12338bcd5b486052e37a9cad174 > Date: Mon Jun 3 14:05:15 2013 +0530 > > mvn clean does not do a complete clean > > Retains the systevm.iso from the previous run causing systemvm.iso to > never update itself. Do a complete clean install for all profiles > specified in mvn. > > Signed-off-by: Prasanna Santhanam > > commit 800cd391d5ff2baf02f7eed137f4f50edb126a4c > Author: Marcus Sorensen > Date: Thu May 30 11:47:13 2013 -0600 > > RPM build - run mvn clean before building packages, to get a build from > fresh > source > > Signed-off-by: Marcus Sorensen 1369936033 -0600 > > > On Thu, May 30, 2013 at 11:44:05AM -0600, Marcus Sorensen wrote: > > Yes, I don't think it's a blocker either, now that I know what's going > > on. I'll get that added. > > > > On Thu, May 30, 2013 at 11:21 AM, Prachi Damle > > wrote: > > > Marcus, > > > > > > After a clean build did your problem disappear? I don't see a reason for > > > a NoSuchMethodError popping up, except that as you say cleaning the > > > repository is needed. > > > > > > -Prachi > > > > > > -Original Message- > > > From: Chip Childers [mailto:chip.child...@sungard.com] > > > Sent: Thursday, May 30, 2013 9:48 AM > > > To: dev@cloudstack.apache.org > > > Cc: Prachi Damle > > > Subject: Re: [VOTE] Release Apache CloudStack 4.1.0 (fifth round) > > > > > > On Thu, May 30, 2013 at 10:23:31AM -0600, Marcus Sorensen wrote: > > >> I think we need to add an 'mvn clean' to the cloud.spec prior to > > >> building. Normally, I can build RPMs, do a pull or change some code, > > >> then build RPMs, and the changes are reflected and everything is fine. > > >> However, after running 'git clean -fxd', then rebuilding the same > > >> code, reinstalling, the problem is gone. So apparently there is the > > >> possibility that some artifacts from a previous build will get into a > > >> new build, and for whatever reason this particular change in > > >> VolumeReservationVO is surfacing that. > > > > > > Yes, for debian we do mvn clean install. > > > > > > IMO this isn't a release blocker though. Want to fix it in master and > > > 4.1 just to it's there for the next time? > > > > > >> On Thu, May 30, 2013 at 10:02 AM, Chip Childers > > >> wrote: > > >> > cc'ing prachi > > >> > > > >> > On Thu, May 30, 2013 at 09:59:01AM -0600, Marcus Sorensen wrote: > > >> >> Uh, we may have a problem. I deployed a fresh 4.1 two days ago, it > > >> >> worked, and then I deployed current 4.1 on a separate test system > > >> >> (on top of existing, but redeployed the db) and got this: > > >> >> > > >> >> 2013-05-30 09:51:30,975 ERROR [cloud.async.AsyncJobManagerImpl] > > >> >> (Job-Executor-19:job-19) Unexpected exception while executing > > >> >> org.apache.cloudstack.api.command.user.vm.DeployVMCmd > > >> >> java.lang.NoSuchMethodError: > > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.VolumeReservationV > > >> >> O.(JJJLjava/lang/Long;)V at > > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD > > >> >> aoImpl.saveVolumeReservation(VMReservationDaoImpl.java:99) > > >> >> at > > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD > > >> >> aoImpl.persist(VMReservationDaoImpl.java:88) > > >> >> > > >> >> > > >> >> No such method? Did I just botch the reinstall (built RPMs, force > > >> >> installed)? I think this has something to do with the updates from > > >> >> > > >> >> CLOUDSTACK-2568 > > >> >> > > >> >> So maybe Prachi can shed some light on this. I looked through the > > >> >> mailing list and there's at least one other mention of it. > > >> >> > > >> >> > > >> >> On Thu, May 30, 2013 at 9:07 AM, David Nalley wrote: > > >> >> > On Tue, May 28, 2013 at 9:47 AM, Chip Childers > > >> >> > wrote: > > >> >> >> Hi All, > > >> >> >> > > >> >> >> I've created a 4.1.0 release, with the following artifacts up > > >> >> >> for a vote. > > >> >> >> > > >> >> > > > >> >> > +1 > > >> >> > > > >> >> > Checked sigs and hashes > > >> >> > Built > > >> >> > Packaged RPMs for EL6.4 (using nonoss profile) Did some basic > > >> >> > testing > > >> >> > > > >> >> > --David > > >> >> > > >> > > -- > Prasanna., > > > Powered by BigRock.com -- Prasanna., Powered by BigRock.com
Re: Review Request: Automation: Memory limits tests from Resource Limits Tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/#review21973 --- If a lot of tests are generatable from the same class, we should explore using something like DDT http://ddt.readthedocs.org/en/latest/example.html Do you think it's possible? - Prasanna Santhanam On June 4, 2013, 11:39 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11626/ > --- > > (Updated June 4, 2013, 11:39 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Adding resource limit tests related to Memory. Changes suggested in CPU > resource limit tests which are applicable here are incorporated too. > > Updated test plan is available here: > https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000 > > > Diffs > - > > test/integration/component/test_memory_limits.py PRE-CREATION > > Diff: https://reviews.apache.org/r/11626/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: jenkins jobs for new docs guide
On Sun, Jun 16, 2013 at 05:10:09PM -0400, Sebastien Goasguen wrote: > Hi, > > I have been working on some new doc guides: > > -the gsoc one is in master : docs/publican-gsoc-2013.cfg > > -in the ACS101 branch under docs/acs101/publican.cfg (tons of new goodies in > there libcloud, jclouds-cli, knife-cs, whir etc) > > Hugo mentioned to me that we should have some jenkins jobs to build > those, any takers ? ( I no squat about jenkins) It's quite easy. Once you are logged in. Go to the view under which you create a job. Then click "New Job", then select "copy from existing job". In your case you can use the doc jobs that Hugo setup for midonet/nicira. Then tweak the configuration shell script to build acs101! Easy! :) -- Prasanna., Powered by BigRock.com
Re: [DISCUSS] Issue with cloudmonkey-4.1.0-0 on pypi
On Sun, Jun 09, 2013 at 10:26:43AM -0400, David Nalley wrote: > On Sun, Jun 9, 2013 at 7:51 AM, Rohit Yadav wrote: > > Hi, > > > > I was about to test CloudStack but the cloudmonkey-4.1.0-0 release on pypi > > does not bundle failsafe api cache so when I install it I don't get any api > > commands. The autodiscovery using sync is useful but only with the > > ApiDiscovery plugin which works only for 4.2 and later. For 4.1 and below I > > think we should, in that case, bundle the cache for all the apis. Or maybe > > just oss components/plugins? > > > > I'll wait for Chip and others to comment if we want to ship it as it is or > > bundle the cache against 4.1 release? > > > > Cheers. > > Honestly - this is exactly why I've been suggesting[1] that we break > CloudMonkey (and Marvin) out of the main repo and giving it it's own > lifecycle. It's far easier/faster to iterate cloudmonkey than all of > CloudStack and tying it to the slower lifecycle of ACS will continue > to trouble it IMO. > > --David > > [1] http://markmail.org/message/wir5vfawex3y22ot I haven't given breaking out the project much thought. But it's certainly a possibility: a) However, there are parts of the codebase (checkin tests) that depend on marvin. b) I need to come up with a easier way to update marvin across cloudstack providers to enable auto-upating marvin's libraries like cloudmonkey can. For this I've made a couple enhancements to apidiscovery but it's not in master yet and I don't have it fully figured out. Need some time to think through this. -- Prasanna., Powered by BigRock.com
Re: [DISCUSS} review flow
On Mon, Jun 17, 2013 at 09:07:54AM +, Daan Hoogland wrote: > H, > > Even though the rebase of both patches where without conflicts for a > change, this morning, I would really like to have them 'shipped'. Of > course I don't mind doing more work on them as I am taking > responsibility for the code but I am not looking forward to a > permanent rebase re-apply job to keep my users satisfied. > > More generally: What is the problem I should be addressing? > > 1. Is there something in my way of working that obstructs a > ready acceptance of the code? > > 2. Is this a common problem with a certain type of issues that > I happen to have addressed twice now? > > 3. Is a workflow for closing (accepting/refusing) review > requests missing? > On the third possibility; I noticed that review requests dating as > far back as to September 11th (no pun) are open for cloudstack. Some > are not updated for more than 6 months. I don't mind if you guys > refuse my code, but I don't want open ends like that. Do you have a > policy or any ideas on that? > > Please note that this is not a complaint about the people who have > commented on my code. I have appreciated and seriously addressed > their input. > Hi, Thanks for your patience. But reviewboard hasn't been recieving much love possibly because folks are busy with Collab presentations etc. And 4.2 is looming around ther corner. This isn't an excuse though. Sometimes there's few folks who understand the full scale of changes to specific parts of cloudstack because those critical pieces are poorly documented. In such cases reviews get delayed. Usually, if you remind the list when your review hasn't recieved attention should get someone to take a look at it. [1] Just as you've done here. As for improving the process for speedier reviews I think it's great if more eyeballs are laid on patches. It doesn't just have to be just committers taking a look. So feel free to jump in! Appreciate your thoughts on improving the process! [1] https://cwiki.apache.org/confluence/x/sSbVAQ -- Prasanna., Powered by BigRock.com
Re: Infra Issues from the IRC meeting (Wed, Jun 12)
On Sat, Jun 15, 2013 at 01:48:57PM -0400, Chip Childers wrote: > > There's also a couple of issues here - > > 1. Does everyone know where the tests run? > Nope > > 2. Do people know how to spot the failures? > Nope > > 3. Do people know how to find the logs for the failures? > Nope > > > > If the answer is no to all this, I have more documentation on my > > hands. I'll have the documentation draft up soon. Thanks for pointing this out. All the logs show up under the test-matrix(-extended) job on the cloudstack-qa view. You can drill down from the "Test Result" shown by jenkins to see the stacktrace of the failure. For the management server log, it's a little hidden - it goes under the profile (hypervisor, ms-distro). For now I'm pulling in management server logs. Will expose the kvm agent debug logs too. > > Ideally, I'd like those interested in infra activities to form a > > separate group for cloudstack-infra related topics. The group's focus > > will be to maintain, test and add to the infrastructure of this > > project. But that's in the future. Without such a group, building an > > IaaS cloud is not much fun :) > > +1 - and at least for now, perhaps we start getting more organized > around this via dev@cs.a.o using [INFRA] tags. Will start using the tag as a start. > > Some thoughts I have are: I know that some stuff is being put to use for > the project in Fremont, but I don't know what it is. I also don't > know what hardware donations might be helpful for the environment, so > that perhaps I could help find something. > Since every $company deploys cloudstack a different way, ideally the environment should be a small mirror of what is used in production by $company. That environment can be behind a firewall. What is required is a jenkins slave that can be either hooked in through jnlp or SSH to the jenkins.buildacloud.org instance. It will be labelled as a test slave there and when we need to run tests, we can utilize it for running tests. The auth keys can be shared among those interested to work towards maintaining that infra. > In all seriousness, if there is a need, I could take up the question at > $dayjob to provide some testing resources within one of our labs as > well. I actually think this would be easier to do then a "donation" of > hardware that's not really a "donation" to the ASF. The question is: > *what's needed* that we don't have already? > Right - donations are (IIUC) only reqd if the ASF infra is going to manage this. But if there's a group of people within the project managing this infra and not have it flout any infra rules we're good to go and get started independantly on this. We have a single dedicated enviornment that I cycle through deployment styles that are oft used within Citrix. But obviously others are using it differently. With perhaps RBD /Ceph, Object stores, OVS, Nicira, etc. These are not tested. For specifics on setup and internal resources like - NFS, code repositories, images repositories, pypi mirrors/caches, log gathering etc - we can start a separate thread if there is interest. > > > > > 17:44:17 [topcloud]: i can't imagine apache wanting bvt to only run > > > inside citrix all the time. > > It doesn't run within Citrix. It runs in a DC in Fremont. There are > > other environments within Citrix however that run their own tests for > > their needs - eg: object_store tests, cloudplatform tests, customer > > related issue tests etc. > > > > /me beginning to think more doc work is on my way :/ > > Well, really, the key is for us to all know about which infra is being > shared for the use of the project. Stuff that's inside a corp that we > can't all see isn't worth documenting for the project itself. > But it should be if the infra is exposing all troubleshooting tools, logs to fix cloudstack bugs. If it's running custom builds etc, then I agree it would not be of much use. -- Prasanna., Powered by BigRock.com
Re: Review Request: remove dead allocations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11324/ --- (Updated June 17, 2013, 1:40 p.m.) Review request for cloudstack and Devdeep Singh. Changes --- devdeep (ping) Description --- code allocates a collection, and then immediately overwrites the reference variable holding that collection. That original collection is just a dead allocation, and is not needed - patch removes. Diffs - api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java b2d77b8 api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980 api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 75bcce0 api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12 api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241 Diff: https://reviews.apache.org/r/11324/diff/ Testing --- Thanks, Dave Brosius
Re: Review Request: set rpcProvider field correctly in constructor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11325/#review21980 --- Ship it! 3a02942 - Prasanna Santhanam On May 22, 2013, 6:25 a.m., Dave Brosius wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11325/ > --- > > (Updated May 22, 2013, 6:25 a.m.) > > > Review request for cloudstack. > > > Description > --- > > code does > > rpcProvider = rpcProvider; which is a NOP, due to missing 'this." - patch > adds that. > > > Diffs > - > > > engine/storage/src/org/apache/cloudstack/storage/HypervisorHostEndPointRpcServer.java > bc21776 > > Diff: https://reviews.apache.org/r/11325/diff/ > > > Testing > --- > > > Thanks, > > Dave Brosius > >
Re: Review Request: Automation: (vpc network pf and lb rules) - Corrected code related to cleanup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11909/#review21981 --- Ship it! Applied but the test will fail because of a regression in the NetworkACL code. Details in CLOUDSTACK-2915 - Prasanna Santhanam On June 17, 2013, 2:03 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11909/ > --- > > (Updated June 17, 2013, 2:03 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Corrected code related to cleanup of VPC offering. self.vpc_off was added > twice instead of vpc_off. That may lead to error in the cleanup process > eventually leading to accounts and vpc offerings not being cleaned up. > > > Diffs > - > > test/integration/component/test_vpc_network_lbrules.py 66d6c4d > test/integration/component/test_vpc_network_pfrules.py 92b04ad > > Diff: https://reviews.apache.org/r/11909/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review21982 --- Since XCP shares the same resource (XcpOssResource<-CitrixResourceBase) can the command ScaleVmCommand be implemented for XCP too? server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/11910/#comment45300> can this be made case insensitive? so comparisons can compare as equalIgnoreCase? server/test/com/cloud/vm/VirtualMachineManagerImplTest.java <https://reviews.apache.org/r/11910/#comment45301> Can you remove the wildcard import? - Prasanna Santhanam On June 17, 2013, 2:44 p.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11910/ > --- > > (Updated June 17, 2013, 2:44 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Description > --- > > CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable > dynamic scaling of vm > > CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of > XS tools in the template > This should also take care of updation of VM after XS tools are installed in > the vm and set memory values accordingly to support dynamic scaling after > stop start of VM > > > This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. > > > Diffs > - > > api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b > api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 > api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c > api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 > api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java > 284d553 > > api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java > c9da0c2 > api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 > api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a > api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a > core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 > engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 > engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc > > engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java > 4d162bb > plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 5e8283a > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java > 8e37809 > server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c > server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d > server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd > server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f > server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 > server/src/com/cloud/storage/TemplateProfile.java 0b55f1f > server/src/com/cloud/template/TemplateAdapter.java 9a2d877 > server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e > server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 > server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e > setup/db/db/schema-410to420.sql 272fc42 > > Diff: https://reviews.apache.org/r/11910/diff/ > > > Testing > --- > > Tested locally > > > Thanks, > > Harikrishna Patnala > >
Re: [ANNOUNCE] New committer: Jayapal Reddy Uradi
On Mon, Jun 17, 2013 at 11:30:16AM -0400, Chip Childers wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Jayapal Reddy Uradi to become a committer and we are > pleased to announce that they have accepted. > > Being a committer allows many contributors to contribute more > autonomously. For developers, it makes it easier to submit changes and > eliminates the need to have contributions reviewed via the patch > submission process. Whether contributions are development-related or > otherwise, it is a recognition of a contributor's participation in the > project and commitment to the project and the Apache Way. > > Please join me in congratulating Jayapal! > > -chip > on behalf of the CloudStack PMC Congrats Jayapal! -- Prasanna., Powered by BigRock.com
Re: systemvm.iso not updated in packages
On Mon, Jun 17, 2013 at 12:08:54PM -0400, Chip Childers wrote: > On Mon, Jun 17, 2013 at 11:05:43AM +0530, Prasanna Santhanam wrote: > > Applied yet another fix for this from Rajesh: > > > > commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3 > > Author: Rajesh Battala > > Date: Sat Jun 15 11:21:46 2013 +0530 > > > > CLOUDSTACK-3004: remove duplicate ssvm-check.sh > > > > ssvm_check.sh remove the duplicate file from consoleproxy and include > > the > > script from secondary storage folder while packing iso > > > > Signed-off-by: Prasanna Santhanam > > Should this go into 4.1? Yes it should, I put in 4.1.1 as a fix version for that bug - the test has run but it doesn't seem to have fixed the issue in ssvm-check.sh. Will take a look tomorrow after couple more runs. -- Prasanna., Powered by BigRock.com
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
> On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: > > Since XCP shares the same resource (XcpOssResource<-CitrixResourceBase) can > > the command ScaleVmCommand be implemented for XCP too? > > Any comments about adding the XCP support? > On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 1818 > > <https://reviews.apache.org/r/11910/diff/1/?file=306800#file306800line1818> > > > > can this be made case insensitive? so comparisons can compare as > > equalIgnoreCase? > > > > Harikrishna Patnala wrote: > Hi Prasanna, > There are no comparisons for this, as IsScalable is name of a value. We > retrieve the value corresponding to the name "IsScalable" and do comparisons > on that value at some places. We persist the "name" as a string "IsScalable" and retrieve it using that key from that table for vm_detail. What I meant was you fetch that by using a uniform casing > On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: > > server/test/com/cloud/vm/VirtualMachineManagerImplTest.java, line 77 > > <https://reviews.apache.org/r/11910/diff/1/?file=306802#file306802line77> > > > > Can you remove the wildcard import? > > Harikrishna Patnala wrote: > This is due to auto import 'll fix this. > Thankyou Thanks, don't forget to fix your IDE :) - Prasanna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review21982 --- On June 17, 2013, 6:37 p.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11910/ > --- > > (Updated June 17, 2013, 6:37 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Description > --- > > CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable > dynamic scaling of vm > > CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of > XS tools in the template > This should also take care of updation of VM after XS tools are installed in > the vm and set memory values accordingly to support dynamic scaling after > stop start of VM > > > This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. > > > Diffs > - > > api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b > api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 > api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c > api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 > api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java > 284d553 > > api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java > c9da0c2 > api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 > api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a > api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a > core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 > engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 > engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc > > engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java > 4d162bb > plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 5e8283a > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java > 8e37809 > server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c > server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d > server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd > server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f > server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 > server/src/com/cloud/storage/TemplateProfile.java 0b55f1f > server/src/com/cloud/template/TemplateAdapter.java 9a2d877 > server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e > server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 > server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e > setup/db/db/schema-410to420.sql 272fc42 > > Diff: https://reviews.apache.org/r/11910/diff/ > > > Testing > --- > > Tested locally > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request: Test suite test_shared_networks.py not executing since missing import attr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11917/#review22042 --- You forgot the diff (again) - Prasanna Santhanam On June 17, 2013, 9:21 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11917/ > --- > > (Updated June 17, 2013, 9:21 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test suite test_shared_networks.py not executing since missing import attr > > added > > from nose.plugins.attrib import attr > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11917/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Update test case and framework to add test name in account
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11921/#review22044 --- We shouldn't depend on the test case author to include the 'testname' key in the data dict . The change should happen within the logger of cloudstack and in marvin's integration.lib.utils:random_gen(). It's the random_gen method that adds prefixes to accountnames, networknames etc. - Prasanna Santhanam On June 18, 2013, 4:28 a.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11921/ > --- > > (Updated June 18, 2013, 4:28 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > During test cases analysis, its hard to find account name created for which > test case, so we need to add test case as part of account > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11921/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Update test case and framework to add test name in account
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11921/#review22045 --- Also - can you upload your diff as opposed to attach a file in reviewboard? It makes it easier to review the diff line by line. Thanks - Prasanna Santhanam On June 18, 2013, 4:28 a.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11921/ > --- > > (Updated June 18, 2013, 4:28 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > During test cases analysis, its hard to find account name created for which > test case, so we need to add test case as part of account > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11921/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: remove dead allocations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11324/#review22047 --- Ship it! 93938ca716f85c24f2d9fb07c5856055f0061415 - Prasanna Santhanam On June 17, 2013, 1:40 p.m., Dave Brosius wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11324/ > --- > > (Updated June 17, 2013, 1:40 p.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Description > --- > > code allocates a collection, and then immediately overwrites the reference > variable holding that collection. That original collection is just a dead > allocation, and is not needed - patch removes. > > > Diffs > - > > > api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java > b2d77b8 > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 69c6980 > > api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java > 75bcce0 > api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12 > > api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java > f0fc241 > > Diff: https://reviews.apache.org/r/11324/diff/ > > > Testing > --- > > > Thanks, > > Dave Brosius > >
Re: Review Request: Removed-junk-characters-from-test_netscaler_lb.py.patch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11901/#review22048 --- Ship it! 85ed2160876826fa28088a716657f6c7bcbf84ec - Prasanna Santhanam On June 17, 2013, 11:47 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11901/ > --- > > (Updated June 17, 2013, 11:47 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test case failed, due to some junk character in script > > Traceback (most recent call last): > File "/usr/local/lib/python2.7/unittest/case.py", line 318, in run > testMethod() > File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 413, in > loadTestsFromName > addr.filename, addr.module) > File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in > importFromPath > return self.importFromDir(dir_path, fqname) > File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in > importFromDir > mod = load_module(part_fqname, fh, filename, desc) > File > "/Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py", > line 1089 > SyntaxError: Non-ASCII character '\xe2' in file > /Repo_30X/ipcl/cloudstack/test/integration/component/test_netscaler_lb.py on > line 1089, but no encoding declared; see > http://www.python.org/peps/pep-0263.html for details > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11901/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Test suite test_shared_networks.py not executing since missing import attr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11917/#review22049 --- Ship it! 76520e8 - Prasanna Santhanam On June 18, 2013, 6:07 a.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11917/ > --- > > (Updated June 18, 2013, 6:07 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test suite test_shared_networks.py not executing since missing import attr > > added > > from nose.plugins.attrib import attr > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11917/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request: Test Snapshot Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11904/#review22054 --- This test actually passes on jenkins. What are we changing here? - Prasanna Santhanam On June 17, 2013, 6:37 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11904/ > --- > > (Updated June 17, 2013, 6:37 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao > Talluri. > > > Description > --- > > Secondary Storage vm type has been modified from "SecondaryStorage" to > "SecondaryStorageVM" in host table in Cloud db. > Modified the same in the test. > > > Diffs > - > > test/integration/component/test_snapshots.py 014b55a > > Diff: https://reviews.apache.org/r/11904/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
VM snapshots on KVM
Hi, It looks like VM snapshotting is supported on KVM [0] and yet the test_vm_snapshots has never passed for the KVM environment [1][2][3]. It works for XCP and Xen however. Is there something special that needs to happen for guests on KVM to perform the VM snapshot? [0] https://cwiki.apache.org/confluence/x/4wLMAQ [1] http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/477/suite=test_vm_snapshots/ [2] http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/474/suite=test_vm_snapshots/ [3] http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/480/suite=test_vm_snapshots/ -- Prasanna., Powered by BigRock.com
Re: getting started
On Tue, Jun 18, 2013 at 01:06:27PM +0200, Bogdan Cojocar wrote: > Hi everyone, > > My name is Bogdan. I am a software engineer working in the automotive > industry. I am also passionate aboute cloud computing and I want to > contribute to the CloudStack project by code. > > I saw thaI have no rights to assign myself jira open issues. What is the > procedure with this? Bassically I want to know how can I start. > > Thanks and regards, > Bogdan Well you can start by letting me know your JIRA id and I can give you karma to assign bugs to yourself. Then you can checkout various wiki articles on: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Index -- Prasanna., Powered by BigRock.com
Re: getting started
On Tue, Jun 18, 2013 at 01:20:18PM +0200, Bogdan Cojocar wrote: > My jira id is bogdan2000 > Given you JIRA permissions. Thanks, -- Prasanna., Powered by BigRock.com
Re: Review Request: Fix-all-occurrences-of-account.account-from-test_netscaler_configs.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11900/#review22063 --- hmm - patch failed to apply ~/workspace/cloudstack/incubator-cloudstack/patch(branch:master*) » git am -s netscaler.patch tsp@cloud-2 Applying: Fix all occurrences of account.account from test_netscaler_configs.py error: patch failed: test/integration/component/test_netscaler_configs.py:725 error: test/integration/component/test_netscaler_configs.py: patch does not apply Patch failed at 0001 Fix all occurrences of account.account from test_netscaler_configs.py When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". - Prasanna Santhanam On June 18, 2013, 2:32 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11900/ > --- > > (Updated June 18, 2013, 2:32 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar. > > > Description > --- > > Test cases test_netscaler_configs.py, failed due issue with account instance > create , > > > Diffs > - > > > Diff: https://reviews.apache.org/r/11900/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: [DISCUSS] Issue with cloudmonkey-4.1.0-0 on pypi
On Tue, Jun 18, 2013 at 11:08:57AM -0400, David Nalley wrote: > > > OK - are your concerns CM-related? or Marvin only? Marvin only at this point. > > Any problems I am not seeing with breaking out CloudMonkey? Cloudmonkey has become independant of Marvin. Both can exist independantly > > Anyone else have concerns here about breaking out CloudMonkey? > > --David -- Prasanna., Powered by BigRock.com
Re: Review Request: Fix for regression issue: CLOUDSTACK - 3021
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11935/#review22100 --- Ship it! b6850c28dc664e88c0128ddbae7c3ee468290350 - Prasanna Santhanam On June 18, 2013, 1:39 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11935/ > --- > > (Updated June 18, 2013, 1:39 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Fix for issue: https://issues.apache.org/jira/browse/CLOUDSTACK-3021 > Changed order of cleanup list of resources in order to remove them properly > (first child then parent) > > > Diffs > - > > test/integration/component/test_accounts.py ec135b1 > > Diff: https://reviews.apache.org/r/11935/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: ????: VM snapshots on KVM
On Wed, Jun 19, 2013 at 10:45:53AM +0800, Mice Xia wrote: > > codes for vm snapshot for KVM has not been merged due to it depends > on a new version libvirt-java. Sorry if this was already mentioned before. Is the libvirt-java release for this fix not out yet? Can you add this note to the design doc for now mentioning the version of libvirt-java etc? > can we skip the tests for KVM right now? We can, but I'll keep it for when libvirt-java is released. I don't mind the tests failing for now. -- Prasanna., Powered by BigRock.com
Re: [GSOC]CloudStack deployment questions
On Tue, Jun 18, 2013 at 10:45:27PM -0400, Han,Meng wrote: > Hi all, > > I have a few questions about CloudStack deployment. > > 1. I am trying to deploy CloudStack, use CloudStack to start a > cluster and run hadoop on it. Now I have only one computer with > virtulization extension support in hardware and the OS is ubuntu > 12.04. I'm no hadoop person but if you require large swaths of storage you are going to use I imagine that will be external to your development environment. Is this true? > > what would be a good deployment suit? > > Devcloud? It seems like the tiny linux guest VM in devcloud won't be > sufficient to play with hadoop. You can register a VM of your choice in devcloud from the UI. If devcloud is unsuitable, tell us what is missing and we can see if it can be tailored to fit your use case. > > Install Xenserver on my desktop, using one VM as the management > server and other VMs as guest VMs. > > Install management server on my ubuntu desktop. Using KVM to > provision guest VMs. This is the guide I found for this solution: > http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Quick_Install_Guide/index.html > > Or anything else? > You can run all the management server code from your laptop as a development environment and add an external hypervisor host (Either Xen/KVM) to it. The guests, system VMs etc will then be deployed on your host and not eat up any memory on your laptop. Management server does require quite a bit of memory to run and having Hypervisor + Management server + storage + kitchen sink will slow it down (unless you just need devcloud). > > 2. When I try to deploy management server on my desktop. I > encountered below error when running the command "mvn -P developer > -pl developer,tools/devcloud -Ddeploydb" in this tutorial: > https://cwiki.apache.org/CLOUDSTACK/devcloud.html Did mvn -Pdeveloper -Dsystevm clean install succeed for you? > > > > WARNING: Provided file does not exist: > /home/meng/cloudstack/developer/../utils/conf/db.properties.override > > Initializing database=cloud with host=localhost port=3306 > username=cloud password=cloud > > Running query: drop database if exists `cloud` > SQL exception in trying initDB: java.sql.SQLException: Access denied > for user 'root'@'localhost' (using password: NO) > Does your mysql instance have a root password? If so you'll have to put that into db.properties.override file under utils/conf. I see the wiki(s) are missing this info, so we'll need to edit that with this step if it works for you. let us know. > > I am running the mvn command as root. Mysql is setup locally. > > -- Prasanna., Powered by BigRock.com
Re: Review Request: CLOUDSATCK-1758: Update ssh key location for vmware
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11956/#review22111 --- Ship it! 6e63bb7 - Prasanna Santhanam On June 19, 2013, 6:31 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11956/ > --- > > (Updated June 19, 2013, 6:31 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Update ssh key location for vmware > > > This addresses bug CLOUDSTACK-1758. > > > Diffs > - > > tools/marvin/marvin/integration/lib/utils.py 6892c41 > > Diff: https://reviews.apache.org/r/11956/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request: CLOUDSTACK-1758: SSVM tests failed due to ssh error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11962/#review22121 --- Ship it! 5140473 - Prasanna Santhanam On June 19, 2013, 2:50 p.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11962/ > --- > > (Updated June 19, 2013, 2:50 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > Additional fixes were needed which were found during further testing. > > > This addresses bug CLOUDSTACK-1758. > > > Diffs > - > > test/integration/smoke/test_ssvm.py d637f96 > > Diff: https://reviews.apache.org/r/11962/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Test halting build every now and then
We should start a bounty on this one. @ke4qqq/@chipc - want to reward the fix at #CCC13? :) On Fri, Jun 14, 2013 at 01:57:28PM -0400, Shane Witbeck wrote: > I actually opened an issue for this: > > https://issues.apache.org/jira/browse/CLOUDSTACK-2863 > > I've seen the failure using both wireless and ether on Mac OS X (10.8.4) from > Terminal. > > > Thanks, > Shane > > > On Friday, June 14, 2013 at 10:36 AM, Daan Hoogland wrote: > > > localhost > -- Prasanna., Powered by BigRock.com
Re: [GSOC]CloudStack deployment questions
On Wed, Jun 19, 2013 at 10:53:37AM -0400, Han,Meng wrote: > > > >You can run all the management server code from your laptop as a > >development environment and add an external hypervisor host (Either > >Xen/KVM) to it. The guests, system VMs etc will then be deployed on > >your host and not eat up any memory on your laptop. Management server > >does require quite a bit of memory to run and having Hypervisor + > >Management server + storage + kitchen sink will slow it down (unless > >you just need devcloud). > > I will add another hypervisor host. Is there any network requirement > for the management server and hypervisor host? > > May I know how does the management server know the hypervisor host > and include it to its management? > That's what CloudStack is for. It 'discovers' the hypervisor through its discoverers - XenDisoverer talks to XAPI to manage Xenservers, KVM talks via SSH/libvirt and VmWare talks through the vmware SDK. It's all abstracted so you don't have to understand the mechanics of what's going on underneath. Your hypervisor host needs to be prepared with the OS+hypervisor-software of your choice. It will need to have one NIC that the management server (your laptop) can reach. You will need some storage (NFS) where you can pre-seed the systemVM template which is used to launch service VMs that cloudstack uses for management purposes. All this and more is in the installation guide - let us know if there's anything missing and you haven't been able to figure out about the installation. > >> > >>> WARNING: Provided file does not exist: > >>/home/meng/cloudstack/developer/../utils/conf/db.properties.override > >>> Initializing database=cloud with host=localhost port=3306 > >>username=cloud password=cloud > >>> Running query: drop database if exists `cloud` > >>SQL exception in trying initDB: java.sql.SQLException: Access denied > >>for user 'root'@'localhost' (using password: NO) > >> > >Does your mysql instance have a root password? If so you'll have to > >put that into db.properties.override file under utils/conf. > > > >I see the wiki(s) are missing this info, so we'll need to edit that > >with this step if it works for you. > > > > I create a file named db.properties.override under utils/conf. Put > my root password inside it and it works! > Cool! Do you mind updating the wiki @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+on+master+branch > > The command "mvn -pl :cloud-client-ui jetty:run" gives me a > error:[INFO] Couldn't find specified project dir: > /home/meng/cloudstack/:cloud-client-ui > > I notice that there is no cloud-client-ui directory under > cloudstack. So I switched to "mvn -pl client jetty:run", however it > told me the maven-jetty-plugin does not exist. Yes, client will work. > > [INFO] Searching repository for plugin with prefix: 'jetty'. > [INFO] > > [ERROR] BUILD ERROR > [INFO] > > [INFO] The plugin 'org.apache.maven.plugins:maven-jetty-plugin' does > not exist or no valid version could be found > > Any light on this? Odd, the jetty plugin should be downloaded automatically from repo.maven.org. If your mvn clean install step worked I'm guessing you're not behind any sort of http_proxy? -- Prasanna., Powered by BigRock.com
Re: Review Request: Adding base support for NVP security groups to the NVP API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11981/#review22157 --- Minor nitpick : our code conventions recommend the method naming to not use underscore. so it's lowerCaseAndNoUnderscores() http://cloudstack.apache.org/develop/coding-conventions.html - Prasanna Santhanam On June 19, 2013, 9:28 p.m., Adrian Steer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11981/ > --- > > (Updated June 19, 2013, 9:28 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Description > --- > > This is initial version of API implementation of security groups within the > NVP API > > > Diffs > - > > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java > c571458 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java > 12fa6c0 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/11981/diff/ > > > Testing > --- > > Compile testing > > > Thanks, > > Adrian Steer > >
Re: Some commands didn't show up in the marvin test API
On Wed, Jun 19, 2013 at 05:46:06PM -0700, Sheng Yang wrote: > Hi, > > I just found out that some commands (e.g. AddBaremetalHostCmd, > AddBaremetalKickStartPxeCmd) didn't show in the marvin's > API(tools/marvin/marvin/cloudstackAPI), make it hard for me to write marvin > test case for them. > > The baremetal function is disabled for master but these commands are still > there in master, so they should show up for marvin. > > Any ideas? The marvin build is done using the OSS profile on which these commands are disabled. If you use the nonoss profile then you can do: $ mvn -Dnonoss clean install (this should build apidocs commands.xml using nonoss APIs) Then marvin will have the APIs from nonoss in it. OR You can do a sync using -Dmarvin.sync as $ sudo mvn -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin against a running mgmt server where all your APIs are exposed in listApis call from ApiDiscovery service. This requires pip to be installed on your machine. -- Prasanna., Powered by BigRock.com
Re: TemplateAdapterBase broken
Edison burning the midnight oil. He's fixed it in the subsequent commit however. On Thu, Jun 20, 2013 at 08:38:47AM +, Daan Hoogland wrote: > A conflict was checked in with 97f8c52. > > Regards, -- Prasanna., Powered by BigRock.com
Re: TemplateAdapterBase broken
On Thu, Jun 20, 2013 at 11:20:54AM +0200, Daan Hoogland wrote: > On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam wrote: > > > He's fixed it in the subsequent > > commit however > > > > Yeah, I apologized for the early noise making ;) Not at all. Prompted me to look at other broken stuff post the object_store merge. :) usual suspects: apidocs, simulator, marvin are broken -- Prasanna., Powered by BigRock.com
NonOSS build fails?
Does anyone have problem building non oss? The build is failing at: http://jenkins.buildacloud.org/view/master/job/build-master-nonoss/503/console Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Compilation failure [ERROR] /var/lib/jenkins/workspace/build-master-nonoss/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java:[545,39] createPreHostIso(java.lang.Long,java.lang.String,java.lang.String,com.cloud.storage.Storage.ImageFormat,boolean,boolean,com.cloud.storage.Storage.TemplateType,java.lang.String,java.util.Date,boolean,int,long,java.lang.String,java.lang.String,boolean,long,boolean,com.cloud.hypervisor.Hypervisor.HypervisorType,java.lang.String,java.util.Map,boolean,boolean) in com.cloud.storage.VMTemplateVO cannot be applied to (java.lang.Long,java.lang.String,java.lang.String,com.cloud.storage.Storage.ImageFormat,boolean,boolean,com.cloud.storage.Storage.TemplateType,,,boolean,int,long,,java.lang.String,boolean,int,boolean,com.cloud.hypervisor.Hypervisor.HypervisorType) -- Prasanna., Powered by BigRock.com
Re: easy bug to fix for new comer
cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done. On Thu, Jun 20, 2013 at 01:42:36PM +, Daan Hoogland wrote: > Sure, > > One file at a time! > > -Original Message- > From: Sebastien Goasguen [mailto:run...@gmail.com] > Sent: donderdag 20 juni 2013 14:35 > To: dev@cloudstack.apache.org > Subject: easy bug to fix for new comer > > Hi, > > Here is an easy bug to fix for a newcomer to cloudstack: > > https://issues.apache.org/jira/browse/CLOUDSTACK-3096 > > install pep8 on your machine > git clone cloudstack repo > go to the marvin directory > > run pep8 like I show in the bug. > > edit the python scripts to fix the errors > > once pep8 is clean, git commit everything, create a patch and send to review > board. > > Any takers ? > > -Sebastien -- Prasanna., Powered by BigRock.com
Re: TemplateAdapterBase broken
On Thu, Jun 20, 2013 at 03:01:28PM +0530, Prasanna Santhanam wrote: > On Thu, Jun 20, 2013 at 11:20:54AM +0200, Daan Hoogland wrote: > > On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam > > wrote: > > > > > He's fixed it in the subsequent > > > commit however > > > > > > > Yeah, I apologized for the early noise making ;) > > Not at all. Prompted me to look at other broken stuff post the > object_store merge. :) > > usual suspects: apidocs, simulator, marvin are broken > Fixed the simulator to get systemVMs running, checkin tests are however still blocked because the built-in template doesn't go to Ready state. Still a TODO. Powered by BigRock.com
Re: fixPath (was: committer wanted for review)
On Thu, Jun 20, 2013 at 06:07:05PM -0400, John Burwell wrote: > Edison, > > As I mentioned in a previous email, it feels like a good place for > Path value object that encapsulates behavior. I propose we throw > this topic on the board for Sunday's Storage Architecture session, > and bring the resulting proposals back to the ML. > > To my mind, we overuse String throughout the codebase when we > should either be using richer types provided by the Java runtime > (e.g. java.net.URI) or defining custom value objects. In addition > to better levering the type checking of the compiler and potentially > exploiting polymorphism, rich value objects allow business rules to > be neatly encapsulated -- DRYing out the code base and allowing them > to reliably unit tested. +1 to the rant. String is over-(ab)-used. Sometimes even to do XML. Happy to help moving all that if there's a plan you guys work out Sunday. Please bring it back to the lists. -- Prasanna., Powered by BigRock.com
