Re: [Discuss] plugins release

[David Barth]

Hey guys,

Alex has a set of fixes for ubuntu code in the following plugins:

   - https://github.com/apache/cordova-plugin-inappbrowser/pull/174
   - https://github.com/apache/cordova-plugin-battery-status/pull/38
   - https://github.com/cordova-ubuntu/cordova-plugin-geolocation/pull/2

Should we get another review from plugin maintainers or should i merge to
get that in time for the release ?

David



On Wed, Sep 7, 2016 at 4:47 PM, julio cesar sanchez 
wrote:

> Or maybe we should wait for the corodvaDependencies update? I think there
> are PRs for all the plugins
>
> 2016-09-07 16:21 GMT+02:00 Steven Gill :
>
> > Yes. I'll move forward with it
> >
> > On Sep 7, 2016 6:25 AM, "julio cesar sanchez" 
> > wrote:
> >
> > > Issues won't stop coming, should we do the release this week?
> > >
> > > 2016-08-29 13:26 GMT+02:00 Kerri Shotts :
> > >
> > > > I've got iPads that support multitasking, so I'll take a look.
> > > >
> > > > ~ Kerri
> > > >
> > > >
> > > >
> > > > On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar sanchez" <
> > > > jcesarmob...@gmail.com> wrote:
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > If somebody with an iPad that supports multitasking can test this
> PR...
> > > > https://github.com/apache/cordova-plugin-statusbar/pull/62
> > > >
> > > > I have reviewed the code and looks good, bud I don't have an iPad
> that
> > > > supports multitasking to test it, and I don't trust the simulator in
> > this
> > > > case as I tried to fix that issue in a different way, got it working
> on
> > > the
> > > > simulator but the reporter said that it didn't work as expected on a
> > real
> > > > device.
> > > >
> > > > 2016-08-25 0:54 GMT+02:00 julio cesar sanchez :
> > > >
> > > > > PRs to review
> > > > > https://github.com/apache/cordova-plugin-contacts/pull/131
> > > > > https://github.com/apache/cordova-plugin-camera/pull/229
> > > > >
> > > > > 2016-08-24 20:20 GMT+02:00 Steven Gill :
> > > > >
> > > > >> Hey Scott,
> > > > >>
> > > > >> Thanks for pointing out the PR. I'll take a look.
> > > > >>
> > > > >> The reality of the situation is that cordova has many repos and
> not
> > > > enough
> > > > >> committers currently. This leads to PRs sitting unreviewed. Plugin
> > PRs
> > > > are
> > > > >> unique in that they can involve various different native language
> > > > changes.
> > > > >> This could require more than 1 committer needing to review. For
> > > example,
> > > > >> some committers are more experienced with android vs ios, so they
> > > won't
> > > > be
> > > > >> able to review the ios portion of the plugin PR. Another issue
> with
> > > > plugin
> > > > >> PRs is that they may try to add a new feature (without discussion)
> > and
> > > > may
> > > > >> not add similar functionality for other platforms that support the
> > > > plugin.
> > > > >> And of course lots of PRs don't include tests.
> > > > >>
> > > > >> The name being attached to component doesn't mean anything. Issues
> > by
> > > > >> default go unassigned.
> > > > >>
> > > > >> I can only speak on behalf of the regular Adobe cordova commiters
> (4
> > > of
> > > > >> us). Our focus is usually spent on platforms + tools fixes and
> > > > >> improvements.
> > > > >>
> > > > >> The best way to get attention for your PR is to post it to slack +
> > > > here. I
> > > > >> usually do a review of PRs when I do a plugins release, but I
> won't
> > be
> > > > >> able
> > > > >> to go through them all. This is why I ask for people to bring some
> > to
> > > my
> > > > >> attention during releases.
> > > > >>
> > > > >> Lastly, we would love to help onboard new committers to help
> manage
> > > > >> plugins. If you are interested in such a role, LMK!
> > > > >>
> > > > >> Cheers,
> > > > >> -Steve
> > > > >>
> > > > >> On Wed, Aug 24, 2016 at 6:14 AM, Scott Bradshaw
> > > > >> wrote:
> > > > >>
> > > > >> > Hi Steven - Can you look at camera PR 197
> > > > >> > ? This
> > > > >> addresses
> > > > >> > a major bug in the Android camera plugin where it won't rotate
> > > > pictures
> > > > >> > chosen from the library. This bug has been around since Android
> > 4.4
> > > > was
> > > > >> > released.  I worked on this at the beginning of the year, but
> it's
> > > > just
> > > > >> > sitting there.  I'm new to Cordova, so I don't know exactly what
> > the
> > > > >> > process is to get someone to look at it. I've joined Slack to
> find
> > > > >> someone
> > > > >> > to look at it, but no luck. Your name appears to be a attached
> > > > >> > > > com.atlassian.jira.jira-projects-plugin:components-panel>
> > > > >> > to most of the plugins, including camera. This also isn't the
> only
> > > PR
> > > > >> out
> > > > >> > there for camera. Several are just sitting there waiting for
> > review.
> > > > At
> > > > >> > what point do they get reviewed?
> > > > >> >
> > > > >> > On Wed, Aug 24, 2016 

[GitHub] cordova-plugin-inappbrowser issue #174: CB-3360 Fix Oxide version & support ...

[david-barth-canonical]

Github user david-barth-canonical commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/174
  
Just to confirm LGTM and +1 from me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

[David Barth]

Oh thanks. But actually I had messed up the 4.3.3 annoucement which want's
published, and this ended up in the 4.3.4 announcement message.

I've pushed an update on master now: see
https://github.com/apache/cordova-docs/blob/master/www/_posts/2016-06-14-cordova-ubuntu-4.3.4.md


On Wed, Jun 15, 2016 at 12:03 AM, Steven Gill <stevengil...@gmail.com>
wrote:

>
> http://cordova.apache.org/announcements/2016/06/14/cordova-ubuntu-4.3.4.html
>
> On Tue, Jun 14, 2016 at 1:29 PM, Shazron <shaz...@gmail.com> wrote:
>
> > Thanks Steve,
> > David - none of us have privileges to do anything on the Github mirrors.
> > You would act on them by committing to the Apache repos. The pull request
> > emails to dev@ have instructions for each pull request on how to
> proceed.
> >
> >
> > On Tue, Jun 14, 2016 at 1:24 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > I merged the PRs in.
> > >
> > > Building and deploying site now. I'll post here once it is live.
> > >
> > > -Steve
> > >
> > > On Tue, Jun 14, 2016 at 2:32 AM, David Barth <
> david.ba...@canonical.com>
> > > wrote:
> > >
> > > > Pinging this old thread to indicate that :
> > > >
> > > > 1. The release has been voted and is now available publicly
> > > >
> > > > I would need a green light to either merge and publish that
> > announcement
> > > > blog post:
> > > > https://github.com/apache/cordova-docs/pull/607
> > > >
> > > > and the documentation update that accompanies it:
> > > > https://github.com/apache/cordova-docs/pull/610
> > > >
> > > > Can you guys review the pull-requests (I don't have rights to merge
> it
> > > > right now in Github)
> > > >
> > > > Thanks
> > > >
> > > > David
> > > >
> > > > On Wed, Jun 8, 2016 at 4:39 PM, David Barth <
> david.ba...@canonical.com
> > >
> > > > wrote:
> > > >
> > > > >
> > > > > On Tue, Jun 7, 2016 at 2:36 AM, Shazron <shaz...@gmail.com> wrote:
> > > > >
> > > > >> Time to wrap up the vote, David?
> > > > >>
> > > > >
> > > > > Indeed. Thanks for the feedback.
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

[David Barth]

Pinging this old thread to indicate that :

1. The release has been voted and is now available publicly

I would need a green light to either merge and publish that announcement
blog post:
https://github.com/apache/cordova-docs/pull/607

and the documentation update that accompanies it:
https://github.com/apache/cordova-docs/pull/610

Can you guys review the pull-requests (I don't have rights to merge it
right now in Github)

Thanks

David

On Wed, Jun 8, 2016 at 4:39 PM, David Barth <david.ba...@canonical.com>
wrote:

>
> On Tue, Jun 7, 2016 at 2:36 AM, Shazron <shaz...@gmail.com> wrote:
>
>> Time to wrap up the vote, David?
>>
>
> Indeed. Thanks for the feedback.
>
>
>

Re: [Vote] 4.3.4 Ubuntu Release

[David Barth]

Thanks everyone.

The vote has now closed. The results are:

Positive Binding Votes: 3

David Barth
Shazron Abdullah
Jesse MacFadyen

Negative Binding Votes: 0

The vote has passed.

On Fri, Jun 3, 2016 at 9:27 PM, Jesse <purplecabb...@gmail.com> wrote:

> +1
>
> - verified archive sigs, and git tag
> - created project, added cordova-ubuntu, and added a plugin without issue (
> on OSX )
>
>
> @purplecabbage
> risingj.com
>
> On Fri, May 27, 2016 at 10:16 PM, Shazron <shaz...@gmail.com> wrote:
>
> > +1
> >
> > - verified archive sigs, and git tag
> > - created the platform on ubuntu 16.04
> > - built a project on ubuntu
> > (couldn't test on device since I don't have an UbuntuTouch device)
> >
> > On Thu, May 26, 2016 at 9:42 AM, David Barth <david.ba...@canonical.com>
> > wrote:
> >
> > > Hey,
> > >
> > > Please review and vote on this 4.3.4 Ubuntu Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-11294
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-11294/
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-ubuntu: 4.3.4 (a12a3d13da)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add
> > > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.4
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> to
> > > npm, and post the blog post.
> > >
> > > Voting guidelines:
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > > <
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > > >
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran the release process at
> > >
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> > > * Created and ran hello world project on device
> > > * Ran ubuntu-demo app from
> https://github.com/cordova-ubuntu/ubuntu-demo
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

[David Barth]

On Tue, Jun 7, 2016 at 2:36 AM, Shazron  wrote:

> Time to wrap up the vote, David?
>

Indeed. Thanks for the feedback.

[GitHub] cordova-docs pull request #610: CB 11328 - Ubuntu platform documentation upd...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-docs/pull/610

CB 11328 - Ubuntu platform documentation update

Update the platform guide to reflect the status as of cordova-ubuntu@4.3.4


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-docs CB-11328

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #610


commit 013903be2af809d47c5b64dbd1232c61dbbdd06f
Author: David Barth <david.ba...@canonical.com>
Date:   2016-06-01T16:00:23Z

update plugin support information for Ubuntu

commit b5d73b795a4d3167359bdd4324410b9684a2
Author: David Barth <david.ba...@canonical.com>
Date:   2016-06-01T16:00:54Z

Update of the Ubuntu platform guide

commit a7390bcb5194e394f41fdb07653fcbb7d7115600
Author: David Barth <david.ba...@canonical.com>
Date:   2016-06-01T16:07:00Z

typos

commit 725248cf5bd023a043360fad4e75534592721c11
Author: David Barth <david.ba...@canonical.com>
Date:   2016-06-02T09:30:47Z

add details on debugging and publishing an app for Ubuntu




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.3.4 Ubuntu Release

[David Barth]

Hey,

Please review and vote on this 4.3.4 Ubuntu Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11294

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-11294/

The package was published from its corresponding git tag:
cordova-ubuntu: 4.3.4 (a12a3d13da)

Note that you can test it out via:

cordova platform add
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.4

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
 https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md


Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran the release process at
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
* Created and ran hello world project on device
* Ran ubuntu-demo app from https://github.com/cordova-ubuntu/ubuntu-demo

[GitHub] cordova-docs pull request: Cordova Ubuntu 4.3.4 release announceme...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-docs/pull/607

Cordova Ubuntu 4.3.4 release announcement



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-docs 
cordova-ubuntu-4.3.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/607.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #607


commit 159a63941af3c12fe52c77cb876b67e2109965b4
Author: David Barth <david.ba...@canonical.com>
Date:   2016-05-26T14:08:08Z

Cordova Ubuntu 4.3.4 release announcement




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

[david-barth-canonical]

Github user david-barth-canonical commented on the pull request:

https://github.com/apache/cordova-docs/pull/497#issuecomment-221223223
  
Yeah, probably. I'll redo an announcement for 4.3.4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-docs/pull/497


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova-Ubuntu Release 4.3.4

[David Barth]

Hey,

Just a quick note to say I'm going to do another minor release of
cordova-ubuntu to fix some bugs.

It will still be on the 4.3.x line, ie a bit outdated, but to keep a safe
fallback while we get 6.x ready for developers to use.

I will use https://issues.apache.org/jira/browse/CB-11294
 for this release.

David

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/35

CB-11256 (was Fix due to Qt SystemInfo API updates)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-plugin-battery-status 
fix-systeminfo-api-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 515b4ca6e9d9bafe378874968081b3f3f9dd7cb3
Author: Alexandre Abreu <alexandre.ab...@canonical.com>
Date:   2016-05-09T16:10:50Z

Fix due to Qt SystemInfo API updates




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-lib/pull/438


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-lib/pull/438

Fix plugin platform_www & cordova_plugins.json copy



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-lib 
fix-cordova-plugins-copy

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/438.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #438


commit b6ad96ffd5ef88b3c3d5fb5a0a689ae1a40cc8df
Author: Alexandre Abreu <alexandre.ab...@canonical.com>
Date:   2016-05-09T13:21:23Z

Fix plugin platform_www & cordova_plugins.json copy




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-docs/pull/497

Add Cordova Ubuntu 4.3.3 blog post

Blog post to announce cordova-ubuntu 4.3.3

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-docs cordova-ubuntu-4.3.3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #497


commit caafe227cc02b6a0b33187054f43f41c2adba716
Author: David Barth <david.ba...@canonical.com>
Date:   2016-02-09T16:17:13Z

Add Cordova Ubuntu 4.3.3 blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] 4.3.3 Ubuntu Release

[David Barth]

The vote has now closed. The results are:

Positive Binding Votes: 3

David Barth
Steven Gill
Jesse MacFadyen

Negative Binding Votes: 0

The vote has passed.

On Tue, Feb 9, 2016 at 10:04 AM, David Barth <david.ba...@canonical.com>
wrote:

> \o/ Thank you Jesse.
>
> The warning is not a regression. We're fixing that in next release with
> the move to the new PlatformAPI.
>
> On Mon, Feb 8, 2016 at 8:56 PM, Jesse <purplecabb...@gmail.com> wrote:
>
>> +1
>>
>> ran coho verify-archive
>> added to a project
>>
>> I did get a warning, although I don't think this blocks the vote.
>> ===
>> missing icon element in config.xml
>> Error: icon does not exist:
>> /Tests/UbuntuVote/platforms/ubuntu/www/www/img/logo.png
>>
>>
>> @purplecabbage
>> risingj.com
>>
>> On Mon, Feb 8, 2016 at 5:31 AM, David Barth <david.ba...@canonical.com>
>> wrote:
>>
>> > Thanks Steven,
>> >
>> > I need one more vote. Anyone else can run a quick: platform add / rm ?
>> >
>> > On Fri, Feb 5, 2016 at 7:34 PM, Steven Gill <stevengil...@gmail.com>
>> > wrote:
>> >
>> > > +1
>> > >
>> > > ran coho verify archive
>> > > added fine to a project. Can't build due to lack of environment.
>> > >
>> > > On Fri, Feb 5, 2016 at 8:15 AM, David Barth <
>> david.ba...@canonical.com>
>> > > wrote:
>> > >
>> > > > Any feedback on the release? I need your votes ! :)
>> > > >
>> > > > On Thu, Jan 28, 2016 at 5:25 PM, David Barth <
>> > david.ba...@canonical.com>
>> > > > wrote:
>> > > >
>> > > > > Please review and vote on this 4.3.3 Ubuntu Release
>> > > > > by replying to this email (and keep discussion on the DISCUSS
>> thread)
>> > > > >
>> > > > > Release issue: https://issues.apache.org/jira/browse/CB-10453
>> > > > >
>> > > > > The archive has been published to dist/dev:
>> > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
>> > > > >
>> > > > > The package was published from its corresponding git tag:
>> > > > > cordova-ubuntu: 4.3.3 (81381a5f11)
>> > > > >
>> > > > > Note that you can test it out via:
>> > > > >
>> > > > > cordova platform add
>> > > > > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3
>> > > > >
>> > > > > Upon a successful vote I will upload the archive to dist/,
>> publish it
>> > > to
>> > > > > npm, and post the blog post.
>> > > > >
>> > > > > Voting guidelines: https://github.com/apache/cordova
>> > > > > -coho/blob/master/docs/release-voting.md
>> > > > > <
>> > > >
>> > >
>> >
>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>> >
>> > > > >
>> > > > > Voting will go on for a minimum of 48 hours.
>> > > > >
>> > > > > I vote +1:
>> > > > > * Ran the procedure at
>> > > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
>> > > > > * Ran mobile-spec
>> > > > > * Created and ran hello world project on device
>> > > > >
>> > > > > Most of all, I verified that the test applications continue to run
>> > with
>> > > > > the upcoming Oxide-1.12 release which ceased to work with a
>> > deprecated
>> > > > load
>> > > > > signal cordova-ubuntu had been using so far.
>> > > > >
>> > > > > See https://issues.apache.org/jira/browse/CB-10470
>> > > > >
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
>

Re: [Vote] 4.3.3 Ubuntu Release

[David Barth]

\o/ Thank you Jesse.

The warning is not a regression. We're fixing that in next release with the
move to the new PlatformAPI.

On Mon, Feb 8, 2016 at 8:56 PM, Jesse <purplecabb...@gmail.com> wrote:

> +1
>
> ran coho verify-archive
> added to a project
>
> I did get a warning, although I don't think this blocks the vote.
> ===
> missing icon element in config.xml
> Error: icon does not exist:
> /Tests/UbuntuVote/platforms/ubuntu/www/www/img/logo.png
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Feb 8, 2016 at 5:31 AM, David Barth <david.ba...@canonical.com>
> wrote:
>
> > Thanks Steven,
> >
> > I need one more vote. Anyone else can run a quick: platform add / rm ?
> >
> > On Fri, Feb 5, 2016 at 7:34 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > > ran coho verify archive
> > > added fine to a project. Can't build due to lack of environment.
> > >
> > > On Fri, Feb 5, 2016 at 8:15 AM, David Barth <david.ba...@canonical.com
> >
> > > wrote:
> > >
> > > > Any feedback on the release? I need your votes ! :)
> > > >
> > > > On Thu, Jan 28, 2016 at 5:25 PM, David Barth <
> > david.ba...@canonical.com>
> > > > wrote:
> > > >
> > > > > Please review and vote on this 4.3.3 Ubuntu Release
> > > > > by replying to this email (and keep discussion on the DISCUSS
> thread)
> > > > >
> > > > > Release issue: https://issues.apache.org/jira/browse/CB-10453
> > > > >
> > > > > The archive has been published to dist/dev:
> > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
> > > > >
> > > > > The package was published from its corresponding git tag:
> > > > > cordova-ubuntu: 4.3.3 (81381a5f11)
> > > > >
> > > > > Note that you can test it out via:
> > > > >
> > > > > cordova platform add
> > > > > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3
> > > > >
> > > > > Upon a successful vote I will upload the archive to dist/, publish
> it
> > > to
> > > > > npm, and post the blog post.
> > > > >
> > > > > Voting guidelines: https://github.com/apache/cordova
> > > > > -coho/blob/master/docs/release-voting.md
> > > > > <
> > > >
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md>
> > > > >
> > > > > Voting will go on for a minimum of 48 hours.
> > > > >
> > > > > I vote +1:
> > > > > * Ran the procedure at
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> > > > > * Ran mobile-spec
> > > > > * Created and ran hello world project on device
> > > > >
> > > > > Most of all, I verified that the test applications continue to run
> > with
> > > > > the upcoming Oxide-1.12 release which ceased to work with a
> > deprecated
> > > > load
> > > > > signal cordova-ubuntu had been using so far.
> > > > >
> > > > > See https://issues.apache.org/jira/browse/CB-10470
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: [Vote] 4.3.3 Ubuntu Release

[David Barth]

Thanks Steven,

I need one more vote. Anyone else can run a quick: platform add / rm ?

On Fri, Feb 5, 2016 at 7:34 PM, Steven Gill <stevengil...@gmail.com> wrote:

> +1
>
> ran coho verify archive
> added fine to a project. Can't build due to lack of environment.
>
> On Fri, Feb 5, 2016 at 8:15 AM, David Barth <david.ba...@canonical.com>
> wrote:
>
> > Any feedback on the release? I need your votes ! :)
> >
> > On Thu, Jan 28, 2016 at 5:25 PM, David Barth <david.ba...@canonical.com>
> > wrote:
> >
> > > Please review and vote on this 4.3.3 Ubuntu Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-10453
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-ubuntu: 4.3.3 (81381a5f11)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add
> > > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> to
> > > npm, and post the blog post.
> > >
> > > Voting guidelines: https://github.com/apache/cordova
> > > -coho/blob/master/docs/release-voting.md
> > > <
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md>
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran the procedure at
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> > > * Ran mobile-spec
> > > * Created and ran hello world project on device
> > >
> > > Most of all, I verified that the test applications continue to run with
> > > the upcoming Oxide-1.12 release which ceased to work with a deprecated
> > load
> > > signal cordova-ubuntu had been using so far.
> > >
> > > See https://issues.apache.org/jira/browse/CB-10470
> > >
> > >
> > >
> >
>

Re: [Vote] 4.3.3 Ubuntu Release

[David Barth]

Any feedback on the release? I need your votes ! :)

On Thu, Jan 28, 2016 at 5:25 PM, David Barth <david.ba...@canonical.com>
wrote:

> Please review and vote on this 4.3.3 Ubuntu Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10453
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
>
> The package was published from its corresponding git tag:
> cordova-ubuntu: 4.3.3 (81381a5f11)
>
> Note that you can test it out via:
>
> cordova platform add
> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines: https://github.com/apache/cordova
> -coho/blob/master/docs/release-voting.md
> <https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md>
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran the procedure at
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> * Ran mobile-spec
> * Created and ran hello world project on device
>
> Most of all, I verified that the test applications continue to run with
> the upcoming Oxide-1.12 release which ceased to work with a deprecated load
> signal cordova-ubuntu had been using so far.
>
> See https://issues.apache.org/jira/browse/CB-10470
>
>
>

Re: [DISCUSS] Cordova-Ubuntu Release

[David Barth]

This should be good now.

On Tue, Feb 2, 2016 at 1:47 AM, Steven Gill <stevengil...@gmail.com> wrote:

> Hey David,
>
> I think you need to add your gpg key to dist/keys
>
> Can you run through
> https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg.md
> up to the point of adding your key to dist/keys?
>
> I was trying to verify your archive and ran into it not being able to find
> the public key.
>
> On Wed, Jan 27, 2016 at 7:50 AM, Mefire O. <ommen...@microsoft.com> wrote:
>
> > +1
> >
> > On Jan 27, 2016 7:19 AM, Steven Gill <stevengil...@gmail.com> wrote:
> > +1
> > On Jan 27, 2016 4:28 AM, "David Barth" <david.ba...@canonical.com>
> wrote:
> >
> > > Hi,
> > >
> > > I need to do another quick interim release of Cordova-Ubuntu to
> address a
> > > significant bug with the use of a deprecated Oxide API.
> > >
> > > This should become cordova-ubuntu@4.3.3
> > >
> > > Does anyone have any reason to delay a cordova-ubuntu platform release?
> > > Any outstanding patches to land?
> > >
> > > I am starting the release process today.
> > >
> > > David
> > >
> >
>

[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/21

Set of fixes for Cordova-Ubuntu 4.3.3



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21


commit 8136602f23a004cf5dc7c80aeffbc4d7ca8f6159
Author: Peter Bakondy <pbako...@gmail.com>
Date:   2016-01-20T10:07:54Z

fix typo

commit 31ba4b18ca7c8abac37962ecfa0cd310bc4a3288
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2016-01-20T11:02:03Z

Merge pull request #7 from pbakondy/master

fix typo

commit 0c2c3e222d9e2b2928d92fa2dc8fafb0bb89f1a3
Author: Alexandre Abreu <alexandre.ab...@canonical.com>
Date:   2016-01-26T16:25:39Z

Fix reliance on deprecated Oxide's onLoadingChanged signal

commit 876674b37167524dbd0ad9100e45504d5632dff8
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2016-01-26T18:47:47Z

Merge pull request #8 from AlexandreAbreu/fix-loading-changed

Fix reliance on deprecated Oxide's onLoadingChanged signal

commit af17a8628613d70368cbf5e53f48e732f12c9cb2
Author: Alexandre Abreu <alexandre.ab...@canonical.com>
Date:   2016-01-26T21:17:25Z

Fix debugging enabled flag & remove webkit specific bit

commit 827212f339cc75ec25b1078c7355f3152763bbfa
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2016-01-27T08:42:30Z

Merge pull request #9 from AlexandreAbreu/fix-devtools

Fix debugging enabled flag & remove webkit specific bit




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.3.3 Ubuntu Release

[David Barth]

Please review and vote on this 4.3.3 Ubuntu Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10453

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10453/

The package was published from its corresponding git tag:
cordova-ubuntu: 4.3.3 (81381a5f11)

Note that you can test it out via:

cordova platform add
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/
release-voting.md


Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran the procedure at
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
* Ran mobile-spec
* Created and ran hello world project on device

Most of all, I verified that the test applications continue to run with the
upcoming Oxide-1.12 release which ceased to work with a deprecated load
signal cordova-ubuntu had been using so far.

See https://issues.apache.org/jira/browse/CB-10470

[DISCUSS] Cordova-Ubuntu Release

[David Barth]

Hi,

I need to do another quick interim release of Cordova-Ubuntu to address a
significant bug with the use of a deprecated Oxide API.

This should become cordova-ubuntu@4.3.3

Does anyone have any reason to delay a cordova-ubuntu platform release?
Any outstanding patches to land?

I am starting the release process today.

David

Re: [DISCUSS] Cordova 6.0.0 Release!

[David Barth]

+1

On Fri, Jan 22, 2016 at 9:24 PM, Steven Gill  wrote:

> any objections or concerns? Some PRs or issues that need to get fixed
> before I do this?
>
> I want to try to get the vote out either later today or Monday.
>
> -Steve
>

Re: [DISCUSS] Old platforms support deprecation

[David Barth]

On Mon, Jan 25, 2016 at 8:16 PM, Steven Gill  wrote:

> Nikhil, sounds reasonable.
>
> I originally misunderstood Vlads message. He isn't proposing the
> PlatformAPI Polyfill for deprecation. This is the code which is used by
> platforms that haven't released a platform API implementation.
>
> He is suggesting removing code from cordova-lib that supports
> * cordova-android < 5
> * cordova-ios < 4
> * cordova-windows < 4.3.0
> * cordova-osx < 4
>
> Platforms that haven't implemented PlatformAPI Pollyfill
> * Browser
> * BlackBerry
> * WP8 (In deprecation mode)
> * WebOS
> * Ubuntu
>

Just to chime in for Ubuntu to say that we're moving to the new
PlatformAPI, but not ready just yet.

David

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.2 blog post

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-docs/pull/452

Add Cordova Ubuntu 4.3.2 blog post



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-docs 
cordova-ubuntu-4.3.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #452


commit cc5aa1e7ed2ae9c3f3e51e2af98f5f045dd3ee03
Author: David Barth <david.ba...@canonical.com>
Date:   2016-01-08T10:41:33Z

Add Cordova Ubuntu 4.3.2 blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu Release

[David Barth]

Hey,

I need help updating the SVN repo.

I was able to push to dist-dev, but removing the previous 4.3.1 from dist
returns an error for me ("forbidden by the server")


On Tue, Dec 22, 2015 at 12:25 AM, Shazron <shaz...@gmail.com> wrote:

> Ah I installed cordova from the debian package as in the Setup Guide
> Once I installed it from npm, it's fine.
>
> On Mon, Dec 21, 2015 at 3:13 PM, Shazron <shaz...@gmail.com> wrote:
> > It was fine on OS X, so it might be something with my Ubuntu setup...
> >
> > On Mon, Dec 21, 2015 at 3:10 PM, Shazron <shaz...@gmail.com> wrote:
> >> I tried and got an error:
> >>
> >> ---
> >> $ cordova platform add
> >> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2
> >> git cloning:
> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2
> >> Unable to fetch platform
> >> null@https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2:
> >> Error: Command failed: /bin/sh -c git clone
> >> "https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2;
> >> "/home/admin_/.cordova/lib/tmp/tmp_cordova_git_14508_1450738848943"
> >> Cloning into
> '/home/admin_/.cordova/lib/tmp/tmp_cordova_git_14508_1450738848943'...
> >> fatal:
> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2/info/refs
> >> not valid: is this a git repository?
> >> ---
> >>
> >> Do you think I'm missing something?
> >> cordova --version gives 4.3.1
> >>
> >> I'm not running locally linked cordova-lib copies, just whatever was
> >> released by the CLI.
> >>
> >> On Fri, Dec 18, 2015 at 3:35 AM, David Barth <david.ba...@canonical.com>
> wrote:
> >>> Hmm, indeed...
> >>>
> >>> This is the same node_modules problem that affects other releases I
> think.
> >>>
> >>> I have used your recommendation to re-install the dependencies and
> >>> re-uploaded an archive with the missing files :
> >>> https://dist.apache.org/repos/dist/dev/cordova/CB-10210/
> >>>
> >>> Then I verified on the list archive that it seems to be an accepted
> >>> practice to add the node_modules into git. I moved the tag for 4.3.2
> up to
> >>> the commit with the additional node_modules files.
> >>>
> >>> Check your local clone : git rev-parse 4.3.2" in cordova-ubuntu should
> >>> reply with "2e019a849a75ade3af9fb3db3ef7c6a6dca47475". If it is wrong,
> do
> >>> "git fetch --tags".
> >>>
> >>> I then verified that this command would succeed :
> >>> cordova -d platform add
> >>> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2
> --verbose
> >>>
> >>> You may still see some "missing icon in config.xml" warnings unless
> you use
> >>> the -dev branch of cordova-lib which includes my fixes.
> >>>
> >>>
> >>> On Thu, Dec 17, 2015 at 9:10 PM, Shazron <shaz...@gmail.com> wrote:
> >>>
> >>>> Note that:
> >>>> cordova platform add https://github.com/apache/cordova-ubuntu#4.3.2
> >>>>
> >>>> will not work yet, the tag hasn't been mirrored to Github. Do a:
> >>>> cordova platform add
> >>>> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2
> >>>>
> >>>> instead.
> >>>>
> >>>> ---
> >>>> On both OS X 10.11 and Ubuntu 15.10:
> >>>>
> >>>> I get an exception:
> >>>> https://gist.github.com/shazron/b8449933e532d4185084
> >>>>
> >>>> This does not happen on ubuntu@4.3.1 (default)
> >>>>
> >>>>
> >>>> On Thu, Dec 17, 2015 at 3:18 AM, David Barth <
> david.ba...@canonical.com>
> >>>> wrote:
> >>>> > Hi,
> >>>> >
> >>>> > I would like to do a quick interim release for cordova-ubuntu, in
> order
> >>>> to
> >>>> > fix the default framework used.
> >>>> >
> >>>> > This bug is referenced here:
> >>>> https://issues.apache.org/jira/browse/CB-10119
> >>>> > <https://issues.apache.org/jira/browse/CB-10119>
> >>>> >
> >>>> > I have created the release task here and am proceeding with the
> release
> >>>> > workflow atm:
> >>>> > https://issues.apache.org/jira/browse/CB-10210
> >>>> >
> >>>> > Let me know if you have patches you would like to add / include.
> >>>> >
> >>>> > David
> >>>>
> >>>> -
> >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >>>> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>>>
> >>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [Vote] 4.3.2 Ubuntu Release (attempt 2)

[David Barth]

I double checked and I think I can now technically conclude the vote
positively, though i'm not officially listed on the PMC page yet (
http://people.apache.org/committers-by-project.html#cordova-pmc)

The vote has now closed. The results are:

Positive Binding Votes: 3

David Barth
Shazron Abdullah
Jesse MacFadyen

Negative Binding Votes: 0

The vote has passed.


On Tue, Jan 5, 2016 at 1:39 AM, Jesse <purplecabb...@gmail.com> wrote:

> +1
>
> Created a project, and did a brief code review
>
> Saw a non-blocker issue:
>
> *Error: icon does not exist:
> /Tests/TestUbuntu/platforms/ubuntu/www/www/img/logo.png*
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Jan 4, 2016 at 1:02 AM, David Barth <david.ba...@canonical.com>
> wrote:
>
> > Thanks Shazron.
> >
> > And hi guys! :) I would like to resume the voting process on this thread.
> >
> > Thanks
> >
> >
> > On Tue, Dec 22, 2015 at 2:04 AM, Shazron <shaz...@gmail.com> wrote:
> >
> > > +1
> > >
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and subdependencies
> > > have Apache-compatible licenses
> > > * added platform and built using master versions of the CLI and
> > > cordova-lib (on OS X and Ubuntu 15)
> > >
> > >
> > > On Mon, Dec 21, 2015 at 3:33 AM, David Barth <
> david.ba...@canonical.com>
> > > wrote:
> > > > Please review and vote on this 4.3.2 Android Release
> > > > by replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > > Release issue: https://issues.apache.org/jira/browse/CB-10210
> > > >
> > > > The archive has been published to dist/dev:
> > > > https://dist.apache.org/repos/dist/dev/cordova/CB-10210/
> > > >
> > > > The package was published from its corresponding git tag:
> > > > cordova-ubuntu: 4.3.2 (2e019a849a)
> > > >
> > > > Note that you can test it out via:
> > > >
> > > > cordova platform add
> > > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu
> > > > .git#4.3.2
> > > >
> > > > Upon a successful vote I will upload the archive to dist/, publish it
> > to
> > > > npm, and post the blog post.
> > > >
> > > > Voting guidelines:
> > > >
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > > >
> > > > Voting will go on for a minimum of 48 hours.
> > > >
> > > > I vote +1:
> > > > * Ran coho audit-license-headers over the relevant repos
> > > > * Ran coho check-license to ensure all dependencies and
> subdependencies
> > > > have Apache-compatible licenses
> > > > * Ensured continuous build was green when repo was tagged
> > > > * Ran mobile-spec
> > > > * Created and ran hello world project on device
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

Re: [Vote] 4.3.2 Ubuntu Release (attempt 2)

[David Barth]

Thanks Shazron.

And hi guys! :) I would like to resume the voting process on this thread.

Thanks


On Tue, Dec 22, 2015 at 2:04 AM, Shazron <shaz...@gmail.com> wrote:

> +1
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * added platform and built using master versions of the CLI and
> cordova-lib (on OS X and Ubuntu 15)
>
>
> On Mon, Dec 21, 2015 at 3:33 AM, David Barth <david.ba...@canonical.com>
> wrote:
> > Please review and vote on this 4.3.2 Android Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10210
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-10210/
> >
> > The package was published from its corresponding git tag:
> > cordova-ubuntu: 4.3.2 (2e019a849a)
> >
> > Note that you can test it out via:
> >
> > cordova platform add
> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu
> > .git#4.3.2
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * Ran mobile-spec
> > * Created and ran hello world project on device
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [Vote] 4.3.2 Ubuntu Release

[David Barth]

This vote is closed. The vote did not pass. See the 2nd attempt vote thread
as a follow-up.

David

On Fri, Dec 18, 2015 at 9:36 PM, Carlos Santana <csantan...@gmail.com>
wrote:

> David
> Close this vote and start a new  a new thread with attempt 2 [VOTE] 4.3.2
> Ubuntu release  (attempt 2)
>
>
> On Fri, Dec 18, 2015 at 6:36 AM David Barth <david.ba...@canonical.com>
> wrote:
>
> > I will ask for a re-vote on this, as I have pushed an updated archive
> with
> > the missing node_modules. I also made a git commit (tag moved forward as
> > well) with the missing directory as well.
> >
> > On Thu, Dec 17, 2015 at 11:12 PM, Shazron <shaz...@gmail.com> wrote:
> >
> > > -1
> > > See the exception I posted in the [DISCUSS] thread.
> > >
> > > On Thu, Dec 17, 2015 at 11:08 AM, David Barth <
> david.ba...@canonical.com
> > >
> > > wrote:
> > > > Please review and vote on this 4.3.2 Ubuntu Release
> > > > by replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > > Release issue: https://issues.apache.org/jira/browse/CB-10210
> > > >
> > > > The archive has been published to dist/dev:
> > > > https://dist.apache.org/repos/dist/dev/cordova/CB-10210/
> > > >
> > > > The package was published from its corresponding git tag:
> > > > cordova-ubuntu: 4.3.2 (f76881)
> > > >
> > > > Note that you can test it out via:
> > > >
> > > > cordova platform add
> > https://github.com/apache/cordova-ubuntu#4.3.2
> > > >
> > > > Upon a successful vote I will upload the archive to dist/, publish it
> > to
> > > > npm, and post the blog post.
> > > >
> > > > Voting guidelines:
> > > >
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > > >
> > > > Voting will go on for a minimum of 48 hours.
> > > >
> > > > I vote +1:
> > > > * Ran coho audit-license-headers over the relevant repos
> > > > * Ran coho check-license to ensure all dependencies and
> subdependencies
> > > > have Apache-compatible licenses
> > > > * Ensured continuous build was green when repo was tagged
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

[Vote] 4.3.2 Ubuntu Release (attempt 2)

[David Barth]

Please review and vote on this 4.3.2 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10210

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10210/

The package was published from its corresponding git tag:
cordova-ubuntu: 4.3.2 (2e019a849a)

Note that you can test it out via:

cordova platform add https://git-wip-us.apache.org/repos/asf/cordova-ubuntu
.git#4.3.2

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* Ran mobile-spec
* Created and ran hello world project on device

Re: [DISCUSS] Cordova-Ubuntu Release

[David Barth]

Hmm, indeed...

This is the same node_modules problem that affects other releases I think.

I have used your recommendation to re-install the dependencies and
re-uploaded an archive with the missing files :
https://dist.apache.org/repos/dist/dev/cordova/CB-10210/

Then I verified on the list archive that it seems to be an accepted
practice to add the node_modules into git. I moved the tag for 4.3.2 up to
the commit with the additional node_modules files.

Check your local clone : git rev-parse 4.3.2" in cordova-ubuntu should
reply with "2e019a849a75ade3af9fb3db3ef7c6a6dca47475". If it is wrong, do
"git fetch --tags".

I then verified that this command would succeed :
cordova -d platform add
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2 --verbose

You may still see some "missing icon in config.xml" warnings unless you use
the -dev branch of cordova-lib which includes my fixes.


On Thu, Dec 17, 2015 at 9:10 PM, Shazron <shaz...@gmail.com> wrote:

> Note that:
> cordova platform add https://github.com/apache/cordova-ubuntu#4.3.2
>
> will not work yet, the tag hasn't been mirrored to Github. Do a:
> cordova platform add
> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2
>
> instead.
>
> ---
> On both OS X 10.11 and Ubuntu 15.10:
>
> I get an exception:
> https://gist.github.com/shazron/b8449933e532d4185084
>
> This does not happen on ubuntu@4.3.1 (default)
>
>
> On Thu, Dec 17, 2015 at 3:18 AM, David Barth <david.ba...@canonical.com>
> wrote:
> > Hi,
> >
> > I would like to do a quick interim release for cordova-ubuntu, in order
> to
> > fix the default framework used.
> >
> > This bug is referenced here:
> https://issues.apache.org/jira/browse/CB-10119
> > <https://issues.apache.org/jira/browse/CB-10119>
> >
> > I have created the release task here and am proceeding with the release
> > workflow atm:
> > https://issues.apache.org/jira/browse/CB-10210
> >
> > Let me know if you have patches you would like to add / include.
> >
> > David
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [Vote] 4.3.2 Ubuntu Release

[David Barth]

I will ask for a re-vote on this, as I have pushed an updated archive with
the missing node_modules. I also made a git commit (tag moved forward as
well) with the missing directory as well.

On Thu, Dec 17, 2015 at 11:12 PM, Shazron <shaz...@gmail.com> wrote:

> -1
> See the exception I posted in the [DISCUSS] thread.
>
> On Thu, Dec 17, 2015 at 11:08 AM, David Barth <david.ba...@canonical.com>
> wrote:
> > Please review and vote on this 4.3.2 Ubuntu Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10210
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-10210/
> >
> > The package was published from its corresponding git tag:
> > cordova-ubuntu: 4.3.2 (f76881)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-ubuntu#4.3.2
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-ubuntu pull request: CB-10119 - Can't install click chroot...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/20

CB-10119 - Can't install click chroot 14.10

Fix for CB-10119, switching the default framework to 15.04
Also a fix for check_reqs which was referencing a function that has been 
removed since.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu 4.3.2-pre

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 9a10c78bb75ec7c5a9175d960803f4c265ae92ef
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-19T08:30:04Z

Set VERSION to 4.4.0-dev (via coho)

commit 178832e268b6cb66f16e02ce718063692d6893b3
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-19T15:31:24Z

fix for update script

commit 4efeff2c275709ff617c8d68c05ab5a187f24f91
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-19T15:31:24Z

add www sub-directory to let the unit tests run properly

(cherry picked from commit 0f97fd32eaadcc03e918c9598205125ec215b492)

commit 2700423ec06c146800e1c58c1bda770320b3b1f3
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-24T10:57:58Z

Merge branch 'master' of 
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu

commit d9456a90e1b2824b0059ceecaff65b3b316e20cd
Author: Alexandre Abreu <alexandre.ab...@canonical.com>
Date:   2015-12-07T21:30:55Z

Fix nodejs deps install which refers to an invalid ubuntu deps check 
function

commit 418947792d573812a3056092221f39ea99dfddf6
Author: David Barth <david.ba...@canonical.com>
Date:   2015-12-09T13:44:40Z

Merge branch 'master' of 
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu

commit 15141640f16ae94657de652d1a478c0a571b8e46
Author: David Barth <david.ba...@canonical.com>
Date:   2015-12-11T16:00:12Z

CB-10119 - default framework upgraded to 15.04

commit cc2cec984b188269f7a0d2fa4dfb487a36124d6c
Author: David Barth <david.ba...@canonical.com>
Date:   2015-12-11T16:07:24Z

update RELEASENOTES

commit e854a04b553767e0f6625ba61e83e90a64f5bc97
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2015-12-11T16:17:10Z

Merge pull request #6 from AlexandreAbreu/fix-build-ubuntu-deps

Fix nodejs deps install which refers to an invalid ubuntu deps check …

commit 70c5c51eec3cdcbb90948d3509a143f058b501d2
Author: David Barth <david.ba...@canonical.com>
Date:   2015-12-11T16:19:23Z

update RELEASENOTES




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.3.2 Ubuntu Release

[David Barth]

Please review and vote on this 4.3.2 Ubuntu Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10210

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10210/

The package was published from its corresponding git tag:
cordova-ubuntu: 4.3.2 (f76881)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ubuntu#4.3.2

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged

[DISCUSS] Cordova-Ubuntu Release

[David Barth]

Hi,

I would like to do a quick interim release for cordova-ubuntu, in order to
fix the default framework used.

This bug is referenced here: https://issues.apache.org/jira/browse/CB-10119


I have created the release task here and am proceeding with the release
workflow atm:
https://issues.apache.org/jira/browse/CB-10210

Let me know if you have patches you would like to add / include.

David

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/349#discussion_r46569876
  
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
 }).join('');
 }
 
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+ 
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+   var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+   if (platform) {
+   var param = 
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+   if (param && param.attrib) {
+   class_name = param.attrib.value;
+   return class_name;
+   }
+   }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+   match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
+if (match && match.length > 0)
+   class_name = match[0].substr(15);
+   else
+class_name = toCamelCase(class_name);
+}
+
+return class_name;
+}
--- End diff --

There is a new PR at https://github.com/apache/cordova-lib/pull/349 with
your suggested fixes. Thanks for the review.

On Thu, Dec 3, 2015 at 12:45 AM, Tim Barham <notificati...@github.com>
wrote:

> In cordova-lib/src/plugman/platforms/ubuntu.js
> <https://github.com/apache/cordova-lib/pull/349#discussion_r46494465>:
>
> > +// fallback to guess work, based on the plugin package name
> > +
> > +if (plugin_id.match(/\.[^.]+$/)) {
> > +// old-style plugin name
> > +class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
> > +class_name = toCamelCase(class_name);
> > +} else {
> > +   match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
> > +if (match && match.length > 0)
> > +   class_name = match[0].substr(15);
> > +   else
> > +    class_name = toCamelCase(class_name);
> > +}
> > +
> > +return class_name;
> > +}
>
> Thanks @david-barth-canonical <https://github.com/david-barth-canonical>!
> Some comments:
>
>- Generally the Cordova codebase uses curly braces even around single
>line blocks.
>- There are some tabs in there that should be converted to spaces.
>- The match variable needs a var.
>- Should be calling toCamelCase() for the scenario where we match
>cordova-plugin-...
>- Where we don't match cordova-plugin-..., class_name is not defined
>(should be using plugin_id).
>- Since we will always end up calling toCamelCase(), the logic for the
>second half of this method can be simplified to:
>
> // fallback to guess work, based on the plugin package name
> if (plugin_id.match(/\.[^.]+$/)) {
> // old-style plugin name
> class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
> } else {
> var match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
> if (match && match.length > 0) {
> class_name = match[0].substr(15);
> } else {
> class_name = plugin_id;
> }
> }
>
> return toCamelCase(class_name);
>
> Also, since the original PR has been merged, can you recreate this as a
> new PR which will just include the changes in your last commit (and 
changes
> in response to feedback, of course).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-lib/pull/349/files#r46494465>.
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

Shouldn't that be just pinned versions in package.json ?

Can you share the install issues you had. I can compare and adjust quickly
with a couple LXD containers.

On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana <csantan...@gmail.com> wrote:

> We should check into git repo node_modules
> while recreating the archive I saw differences, I think this was due to the
> npm version I used.
> But adding from git is broken, since git doesn't node_modules (i.e.
> shelljs, and others)
> But this should not stop the release since the dist archive contains the
> node_modules and from npm will have node_modules
>
>
> On Wed, Dec 2, 2015 at 1:55 PM Steven Gill <stevengil...@gmail.com> wrote:
>
> > Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu.
> We
> > need one other committer to give a +1 so I can wrapnit up and publish
> > On Dec 2, 2015 10:47 AM, "David Barth" <david.ba...@canonical.com>
> wrote:
> >
> > > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> > As
> > > > far
> > > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > > cordova@5.x. The platform API changes aren't necessary to work with
> > > > cordova@5.x
> > > >
> > >
> > > It worked for most commands, except with options like build --device.
> > This
> > > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> > >
> > >
> > > >
> > > > We probably won't do a update to cordova@4.x unless a security
> concern
> > > > comes up.
> > > >
> > >
> > > Ok, makes sense. Anyway, I have a distro-patched version available in
> an
> > > Ubuntu PPA (personal archive) at :
> > > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people
> > who
> > > want a quick start for Ubuntu only.
> > >
> > > I imagine it will be resolved by next month, and then I can propose a
> > > debian package with cordova-cli 5 or 6 as well.
> > >
> > >
> > > > Good idea to improve CB-9590. We are hoping to get cordova@6 out
> next
> > > week
> > > > sometime. If we can get the fixes in by then, great!
> > > >
> > >
> > > Ok
> > >
> > >
> > > >
> > > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib
> (master).
> > If
> > > > thinks look good, we should get you and one other person to vote on
> the
> > > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > > >
> > >
> > > I have finally been able to test with both cordova-cli @4.3.1 and
> master,
> > > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS,
> > to:
> > >
> > > platform add ubuntu
> > > build --device
> > > run --device
> > >
> > > It is still not super pretty but there are no regressions and bugs are
> > > fixed.
> > >
> > > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> > >
> > > David
> > >
> >
>

Re: [NOTICE] David Barth has become a committer

[David Barth]

There is an emulator : see https://wiki.ubuntu.com/Touch/Emulator
<https://wiki.ubuntu.com/Touch/Emulator> for reference.

The trick for testing on a device is to either have an old Nexus 4 around,
or get a BQ or Meizu pre-installed.

On Wed, Dec 2, 2015 at 3:40 PM, Carlos Santana <csantan...@gmail.com> wrote:

> There is no Ubuntu simulator/emulator?
> I think I tried to look for one but didn't find. Then I was looking for a
> cheap phone for testing and was not able to find one that I could buy
> locally.
> Any lottery process to get a Free Ubuntu Phone for dev/testing? :-)
>
> On Wed, Dec 2, 2015 at 4:58 AM David Barth <david.ba...@canonical.com>
> wrote:
>
> > Thanks everyone for the kind welcome messages.
> >
> > Yeah, Ubuntu is here, either as a host platform for cordova-android or
> as a
> > target with cordova-ubuntu (desktop, device or as a converged platform).
> So
> > let me know if you have questions or issues you'd like me to look at.
> >
> > David
> >
> > On Wed, Dec 2, 2015 at 5:23 AM, Carlos Santana <csantan...@gmail.com>
> > wrote:
> >
> > > Great idea Steve to do the announcements here. A lot of benefits I
> think
> > > come out of it.
> > >
> > > Welcome David !  Ubuntu is back !!
> > >
> > >
> > > On Tue, Dec 1, 2015 at 4:31 PM Ryan J. Salva <rsa...@microsoft.com>
> > wrote:
> > >
> > > > Congratulations and welcome, David!
> > > >
> > > >
> > > >
> > > > Ryan J. Salva  |  Principal Program Manager Lead
> > > > Visual Studio Tools for Apache Cordova
> > > > rsa...@microsoft.com
> > > > 425 706 5270 office
> > > > 206 612 5079 mobile
> > > >
> > > > Has someone helped you today? Let them (and their manager) know with
> > > Kudos.
> > > >
> > > > 
> > > > From: Jesse <purplecabb...@gmail.com>
> > > > Sent: Tuesday, December 1, 2015 1:04 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [NOTICE] David Barth has become a committer
> > > >
> > > > Congrats and welcome David!
> > > >
> > > >
> > > > @purplecabbage
> > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7crsalva%40microsoft.com%7c7473b4c746db438ffa6508d2fa931136%7c72f988bf86f141af91ab2d7cd011db47%7c1=j9utNOtN6Kv84TbpyhCbaSbLX5z7J4KEQw5g41V3TMw%3d
> > > >
> > > > On Tue, Dec 1, 2015 at 1:03 PM, Steven Gill <stevengil...@gmail.com>
> > > > wrote:
> > > >
> > > > > Hey everyone!
> > > > >
> > > > > Just wanted to start sending out notices to the dev mailing list
> when
> > > we
> > > > > accept a new committer.
> > > > >
> > > > > David Barth from Canonical has recently been voted in as a
> committer!
> > > He
> > > > is
> > > > > primarily working on cordova-ubuntu.
> > > > >
> > > > > Congrats!
> > > > >
> > > > > Cheers,
> > > > > -Steve
> > > > >
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill  wrote:

> Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> far
> as I know, cordova-ubuntu should work the same with cordova@4.x and
> cordova@5.x. The platform API changes aren't necessary to work with
> cordova@5.x
>

It worked for most commands, except with options like build --device. This
is now fixed in 5.4 thanks to the recent cordova-lib commit.


>
> We probably won't do a update to cordova@4.x unless a security concern
> comes up.
>

Ok, makes sense. Anyway, I have a distro-patched version available in an
Ubuntu PPA (personal archive) at :
https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people who
want a quick start for Ubuntu only.

I imagine it will be resolved by next month, and then I can propose a
debian package with cordova-cli 5 or 6 as well.


> Good idea to improve CB-9590. We are hoping to get cordova@6 out next week
> sometime. If we can get the fixes in by then, great!
>

Ok


>
> Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> thinks look good, we should get you and one other person to vote on the
> vote thread for cordova-ubuntu so I can officially release it on npm.
>

I have finally been able to test with both cordova-cli @4.3.1 and master,
ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS, to:

platform add ubuntu
build --device
run --device

It is still not super pretty but there are no regressions and bugs are
fixed.

So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.

David

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/294#discussion_r46471716
  
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
 }).join('');
 }
 
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+ 
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+   var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+   if (platform) {
+   var param = 
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+   if (param && param.attrib) {
+   class_name = param.attrib.value;
+   return class_name;
+   }
+   }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+class_name = 
plugin_id.match(/cordova\-plugin\-([\w\-]+)$/)[0].substr(15);
--- End diff --

Thanks! I updated the branch to take that into account. I was forcing 
plugins to upgrade to adding their class name to the XML file, but there is a 
more gradual way ;)

If that PR can't be re-opened I opened 
https://github.com/apache/cordova-lib/pull/349 . Otherwise feel free to close 
this other one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-ubuntu 4.3.1

[David Barth]

+1

On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill  wrote:

> Please review and vote on this 4.3.1 Ubuntu Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10030
>
> The archive has been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10030
>
> The package was published from its corresponding git tag:
> cordova-ubuntu: 4.3.1 (745697f422)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ubuntu#4.3.1
>
> Upon a successful vote I will upload the archive to dist/ and publish it
> to npm.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
>

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-lib/pull/349

Cb 9590 - Ubuntu support for the new plugin naming convention

Re-opening the pull request with hopefully a better fix that can handle all 
situations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9590

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #349


commit 187711dd7fb7cd21e9ea276239b2e8b87a9e1ee6
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-01T17:40:35Z

Ubuntu support for the new plugin naming convention

commit afde15c7e6748dfedbdd9816df199c14f2f7596e
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-04T11:41:13Z

more robust class name detection

commit 1ae6a8631a92f58020c3b0139931d784843c281e
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-03T17:13:49Z

take plugin class name from the plugin.xml to avoid class name guess work

commit 1bbf544f3f3cff709d9ee1618b585d4c57e8e62c
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-19T17:00:35Z

happier jshint

commit 877404bbcb2d84cbb9cade8e692396237cc586f3
Author: David Barth <david.ba...@canonical.com>
Date:   2015-12-02T20:18:28Z

don't crash when parsing general plugin names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [NOTICE] David Barth has become a committer

[David Barth]

Thanks everyone for the kind welcome messages.

Yeah, Ubuntu is here, either as a host platform for cordova-android or as a
target with cordova-ubuntu (desktop, device or as a converged platform). So
let me know if you have questions or issues you'd like me to look at.

David

On Wed, Dec 2, 2015 at 5:23 AM, Carlos Santana <csantan...@gmail.com> wrote:

> Great idea Steve to do the announcements here. A lot of benefits I think
> come out of it.
>
> Welcome David !  Ubuntu is back !!
>
>
> On Tue, Dec 1, 2015 at 4:31 PM Ryan J. Salva <rsa...@microsoft.com> wrote:
>
> > Congratulations and welcome, David!
> >
> >
> >
> > Ryan J. Salva  |  Principal Program Manager Lead
> > Visual Studio Tools for Apache Cordova
> > rsa...@microsoft.com
> > 425 706 5270 office
> > 206 612 5079 mobile
> >
> > Has someone helped you today? Let them (and their manager) know with
> Kudos.
> >
> > 
> > From: Jesse <purplecabb...@gmail.com>
> > Sent: Tuesday, December 1, 2015 1:04 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [NOTICE] David Barth has become a committer
> >
> > Congrats and welcome David!
> >
> >
> > @purplecabbage
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7crsalva%40microsoft.com%7c7473b4c746db438ffa6508d2fa931136%7c72f988bf86f141af91ab2d7cd011db47%7c1=j9utNOtN6Kv84TbpyhCbaSbLX5z7J4KEQw5g41V3TMw%3d
> >
> > On Tue, Dec 1, 2015 at 1:03 PM, Steven Gill <stevengil...@gmail.com>
> > wrote:
> >
> > > Hey everyone!
> > >
> > > Just wanted to start sending out notices to the dev mailing list when
> we
> > > accept a new committer.
> > >
> > > David Barth from Canonical has recently been voted in as a committer!
> He
> > is
> > > primarily working on cordova-ubuntu.
> > >
> > > Congrats!
> > >
> > > Cheers,
> > > -Steve
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana <csantan...@gmail.com> wrote:

> David do we need to have the CB-9618 fix in cordova-lib before continuing
> vote?
>

Not strictly speaking. You can manage to prep, build and run an app on
Ubuntu if you add some symlinks or fake icon file to pass the check.


> If that so, do you think you have PR ready soon to review and get into
> master to be able to have a cli that support new ubuntu 4.3.1
>

In any case, I have re-opened a pull request with the change:
https://github.com/apache/cordova-lib/pull/347 We can see that in parallel.

David


> On Tue, Dec 1, 2015 at 4:02 PM Steven Gill <stevengil...@gmail.com> wrote:
>
> > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> > far
> > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > cordova@5.x. The platform API changes aren't necessary to work with
> > cordova@5.x
> >
> > We probably won't do a update to cordova@4.x unless a security concern
> > comes up.
> >
> > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> week
> > sometime. If we can get the fixes in by then, great!
> >
> > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> > thinks look good, we should get you and one other person to vote on the
> > vote thread for cordova-ubuntu so I can officially release it on npm.
> >
> > When making changes to cordova-lib, make sure to send them as PRs still
> so
> > people can review them. Especially if the change can possible affect
> other
> > platforms.
> >
> >
> >
> >
> >
> > On Tue, Dec 1, 2015 at 9:08 AM, David Barth <david.ba...@canonical.com>
> > wrote:
> >
> > > Re-doing a round of testing right now.
> > >
> > > But, to be frank that icon fix in cordova-lib is quite needed,
> otherwise
> > > the icon "errors" make it unnecessarily complicated to prepare a
> project
> > > for building. ie
> > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
> > >
> > > At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> > > cordova@4.3.1 and pin the 2 releases together if that's still
> possible.
> > > Being fully compatible with the newest cordova@5.3.x is still on my
> todo
> > > list, because of the raw api changes.
> > >
> > > I'll be improving
> > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just
> next
> > > based on the last PR comment.
> > >
> > > David
> > >
> > > On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <stevengil...@gmail.com>
> > > wrote:
> > >
> > > > bump. Vote thread is going and needs two votes. David can you test it
> > > with
> > > > master cli and confirm it is all working?
> > > >
> > > > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <stevengil...@gmail.com
> >
> > > > wrote:
> > > >
> > > > > Starting the vote for this
> > > > >
> > > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> > > david.ba...@canonical.com>
> > > > > wrote:
> > > > >
> > > > >> Hey,
> > > > >>
> > > > >> I would like to update the 4.x series of cordova-ubuntu with a
> > couple
> > > of
> > > > >> fixes, and make it the last in the series supporting the
> cordova-cli
> > > > 4.3.1
> > > > >> branch as well
> > > > >>
> > > > >>- Cb 9868 - Should propose to install missing Ubuntu
> dependencies
> > > on
> > > > >>platform add <
> > > > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > > > >>- Cb 9694 - Add support for HTTP urls
> > > > >><https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> > > > >>- Cb 9806 - Add icon to project defaults
> > > > >><https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> > > > >>
> > > > >> So here is the traditional:
> > > > >>
> > > > >> Does anyone have any reason to delay a cordova-ubuntu platform
> > > release?
> > > > >> Any outstanding patches to land?
> > > > >>
> > > > >> If not, I will start the release tomorrow.
> > > > >>
> > > > >> David
> > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

Re-doing a round of testing right now.

But, to be frank that icon fix in cordova-lib is quite needed, otherwise
the icon "errors" make it unnecessarily complicated to prepare a project
for building. ie
https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618

At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
cordova@4.3.1 and pin the 2 releases together if that's still possible.
Being fully compatible with the newest cordova@5.3.x is still on my todo
list, because of the raw api changes.

I'll be improving
https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just next
based on the last PR comment.

David

On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill <stevengil...@gmail.com> wrote:

> bump. Vote thread is going and needs two votes. David can you test it with
> master cli and confirm it is all working?
>
> On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
> > Starting the vote for this
> >
> > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <david.ba...@canonical.com>
> > wrote:
> >
> >> Hey,
> >>
> >> I would like to update the 4.x series of cordova-ubuntu with a couple of
> >> fixes, and make it the last in the series supporting the cordova-cli
> 4.3.1
> >> branch as well
> >>
> >>- Cb 9868 - Should propose to install missing Ubuntu dependencies on
> >>platform add <
> https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> >>- Cb 9694 - Add support for HTTP urls
> >><https://github.com/cordova-ubuntu/cordova-ubuntu/pull/3>
> >>- Cb 9806 - Add icon to project defaults
> >><https://github.com/cordova-ubuntu/cordova-ubuntu/pull/2>
> >>
> >> So here is the traditional:
> >>
> >> Does anyone have any reason to delay a cordova-ubuntu platform release?
> >> Any outstanding patches to land?
> >>
> >> If not, I will start the release tomorrow.
> >>
> >> David
> >>
> >
> >
>

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

[David Barth]

On Fri, Nov 20, 2015 at 2:31 AM, Steven Gill  wrote:

> [...]
> @David, I can review those changes. Can you send it as PRs and send me the
> links. They can go out in the next tools release (soon)!
>

Sure,

Pull-requests, re-opened here:
https://github.com/apache/cordova-lib/pull/294

and here: https://github.com/apache/cordova-lib/pull/299

David

[GitHub] cordova-ubuntu pull request: Cordova-Ubuntu Platform Release 4.3.1...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/19

Cordova-Ubuntu Platform Release 4.3.1 

From the RELEASENOTES.md

* default icon name www/img/logo.png
* add defaut icon parameter to config.xml
* use QUrl::fromLocalFile()
* set mainUrl when the file exists
* fix critical issue introduced by general URL support changes earlier
* check if content src points to a url or local file
* fix typo
* better info msg
* don't check deps at create time and propose to auto-install once at build 
time; this is for the native/desktop build

See release preparation logs at 
https://issues.apache.org/jira/browse/CB-10030

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu 4.3.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
Author: Alberto Mardegan <ma...@users.sourceforge.net>
Date:   2015-10-08T06:36:31Z

build: fix mechanism for additional dependencies

Instead of expecting plugins to store their configuration files in
a "configs/" directory, read the dependencies from the config.xml file.
The reason why the old method does not work is that the 
element of the plugin.xml file doesn't support a "target-dir" attribute.

By using the  element, instead, we don't need to do any
changes to cordova lib, and all the plugin configuration can now be
stored in the plugin.xml file.

Example:


  




  ["signond", "libsignon-qt5"]
  ["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]

      
    

commit 576fca86f5bc51df285ad5b3a94332039bf75161
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-30T16:20:19Z

add defaut icon parameter to config.xml

commit 7a5ac6dbc046bb9fd75c5de313723ee90907f7d6
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2015-10-27T11:24:55Z

Merge pull request #1 from mardy/additional-dependencies

build: fix mechanism for additional plugin dependencies

commit 33f61c7fb7d2370c907beec51a604026b62a57ea
Author: David Barth <david.ba...@canonical.com>
Date:   2015-10-28T14:30:39Z

default icon name www/img/logo.png

commit aaf201b289119f498866b4dbc16e6c581b15c2ac
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T16:42:04Z

Merge branch 'master' of 
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu

commit 75819c8186476c7d7534e6e19c6faebecd7fc9cd
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-30T14:51:05Z

check if content src points to a url or local file

commit 86e994affa1d7406295952bfac2d2af634485d2c
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T15:07:06Z

fix critical issue introduced by general URL support changes earlier

commit ac27c286c124776c2c4b938ccf86f2beaa20ac7e
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T16:02:26Z

set mainUrl when the file exists

commit 6fe31e7cb0568bee263cdf4c39c829f9e9bf4c97
Author: David Barth <david.ba...@canonical.com>
Date:   2015-10-28T18:50:38Z

don't check deps at create time and propose to auto-install once at build 
time; this is for the native/desktop build

commit 8eeea8d71dabfa43bbaab240ecf666d1e89efa88
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T15:06:16Z

better info msg

commit eea201221e2cc2cdaef06a9187f4c7f0a8af754d
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-18T10:29:12Z

Merge remote-tracking branch 'apache/master'

commit 91f655d03047583919582e841fb51c1f0df1ff63
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-18T11:19:02Z

Set VERSION to 4.4.0-dev (via coho)

commit 63d740326f2191de3bf568a06d8013395733ca2c
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-18T11:19:04Z

Update JS snapshot to version 4.4.0-dev (via coho)

commit 6630211fd507766176b2f1a1ba9a7619339a486a
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-18T13:51:34Z

fix typo

commit 51f8f3ce5204beb731d0ea8c708c9c0c533232c1
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2015-11-18T13:52:56Z

Merge pull request #4 from cordova-ubuntu/CB-9868
    
    Cb 9868 - Should propose to install missing Ubuntu dependencies on platform 
add

commit cf5bbb6343aab3f0662550554c580bc464dc95d2
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-18T13:56:36Z

use QUrl::fromLocalFi

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

[David Barth]

Yeah, +1 for https://issues.apache.org/jira/browse/CB-9987 to help manage
the transition of platforms to the 5.x world


On Tue, Nov 17, 2015 at 3:24 AM, Steven Gill  wrote:

> Need to do a patch release for Lib & CLI.
>
> Fixing these 3 issues:
> https://issues.apache.org/jira/browse/CB-9976
> https://issues.apache.org/jira/browse/CB-9987
> https://issues.apache.org/jira/browse/CB-9975
>
> Thoughts?
>

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

[David Barth]

And if there is a release, there are 2 fixes i'd love to get in for Ubuntu:

https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 - to be
compaitble with the new registry at last
https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618 - fix the www
non-sense in icon paths

I can re-do pull-requests if those 2 are eligible for that patch release.
Let me know

David

On Tue, Nov 17, 2015 at 6:24 PM, David Barth <david.ba...@canonical.com>
wrote:

> Yeah, +1 for https://issues.apache.org/jira/browse/CB-9987 to help manage
> the transition of platforms to the 5.x world
>
>
> On Tue, Nov 17, 2015 at 3:24 AM, Steven Gill <stevengil...@gmail.com>
> wrote:
>
>> Need to do a patch release for Lib & CLI.
>>
>> Fixing these 3 issues:
>> https://issues.apache.org/jira/browse/CB-9976
>> https://issues.apache.org/jira/browse/CB-9987
>> https://issues.apache.org/jira/browse/CB-9975
>>
>> Thoughts?
>>
>
>

[DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

Hey,

I would like to update the 4.x series of cordova-ubuntu with a couple of
fixes, and make it the last in the series supporting the cordova-cli 4.3.1
branch as well

   - Cb 9868 - Should propose to install missing Ubuntu dependencies on
   platform add 
   - Cb 9694 - Add support for HTTP urls
   
   - Cb 9806 - Add icon to project defaults
   

So here is the traditional:

Does anyone have any reason to delay a cordova-ubuntu platform release?
Any outstanding patches to land?

If not, I will start the release tomorrow.

David

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: check if content src points to a url ...

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/18

Cb 9694 - Add support for HTTP urls

The cordova-ubuntu container currently does not support loading the app 
from a network URL, only local file URLs. This prevents features like 
livereloading to work.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB-9694

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
Author: Alberto Mardegan <ma...@users.sourceforge.net>
Date:   2015-10-08T06:36:31Z

build: fix mechanism for additional dependencies

Instead of expecting plugins to store their configuration files in
a "configs/" directory, read the dependencies from the config.xml file.
The reason why the old method does not work is that the 
element of the plugin.xml file doesn't support a "target-dir" attribute.

By using the  element, instead, we don't need to do any
changes to cordova lib, and all the plugin configuration can now be
stored in the plugin.xml file.

Example:


  




  ["signond", "libsignon-qt5"]
  ["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]

      
    

commit 7a5ac6dbc046bb9fd75c5de313723ee90907f7d6
Author: david-barth-canonical <david.ba...@canonical.com>
Date:   2015-10-27T11:24:55Z

Merge pull request #1 from mardy/additional-dependencies

build: fix mechanism for additional plugin dependencies

commit aaf201b289119f498866b4dbc16e6c581b15c2ac
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T16:42:04Z

Merge branch 'master' of 
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu

commit 43e1c34f377d888599968cd42ee06751de09568b
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-30T14:51:05Z

check if content src points to a url or local file

commit 429971412c5903665942861552f3906a1f31ba71
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T15:07:06Z

fix critical issue introduced by general URL support changes earlier

commit 606cc331d5dc9410906ef3ddc7818555005834f0
Author: David Barth <david.ba...@canonical.com>
Date:   2015-11-12T16:02:26Z

set mainUrl when the file exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on the pull request:

https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772
  
I have update the pull request to add support for taking the class name 
from the plugin.xml file. For plugins using one of the 2 existing naming 
conventions, we can fallback to "guess work", otherwise new plugins using 
arbitrary names can just specify the 'package-ubuntu' parameter (like iOS or 
Android) to specify the class name directly. 
I decided to go ahead and keep on adding code to the cordova-lib for now, 
but will start adding support for that preparation step in cordova-ubuntu 
direclty. In 2 steps, I imagine we can migrate core plugins to using the new 
parameter and deprecate the specific code from the ubuntu/install stage in 
cordova-lib eventually. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on the pull request:

https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166
  
ok, i understand the problem now. In particular, the code to guess the
classname is nice, but other platforms resort to encapsulating this
information into the plugin.xml file which is safer.
We have some new code in cordova-ubuntu to handle dependencies, so I wonder
how much of that logic needs to be updated in cordova-lib, rather than
directly in cordova-ubuntu? See mardy's new branch

https://github.com/mardy/cordova-ubuntu/commit/d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50

On Thu, Oct 15, 2015 at 6:26 PM, Tim Barham <notificati...@github.com>
wrote:

    > @david-barth-canonical <https://github.com/david-barth-canonical> - I
> think @stevengill <https://github.com/stevengill>'s point is that the
> intent of your change is to strip the cordova-plugin from the start of
> the plugin name to generate the class name, to get the equivalent of the
> old functionality. That logic won't work with plugins that don't start 
with
> cordova-plugin-. Perhaps an alternative would be to look for -plugin- in
> the name, and take everything after that (?otherwise just use the whole
> name).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-lib/pull/294#issuecomment-148444797>.
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/16

add defaut icon parameter to config.xml



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB-9806

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 576fca86f5bc51df285ad5b3a94332039bf75161
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-30T16:20:19Z

add defaut icon parameter to config.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ubuntu pull request: check if content src points to a url ...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/14

check if content src points to a url or local file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB-9694

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit aa53b6652f56fbfcbc824140aee6457174316c15
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-30T14:51:05Z

check if content src points to a url or local file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

[david-barth-canonical]

Github user david-barth-canonical commented on the pull request:

https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241
  
Yes, makes sense. Icon management needs more tweaks, but this way it will 
work better already Thanks for the review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on the pull request:

https://github.com/apache/cordova-lib/pull/294#issuecomment-138310314
  
It does work both with old style plugin names, like 
"org.apache.cordova.battery-status" and new style names 
"cordova-plugin-media-capture". I can add and build a demo application  with 
the 2 of those here on my system.

The facebookconnect plugin failed compilation in my tests, but it seems 
more due to the absence of  ubuntu platform support code.

If there are still issues, can you give an example or a log of where it 
fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9618

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-lib/pull/298


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-lib/pull/299

icon parameter should not be relative to the www directory on Ubuntu



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9618

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #299


commit 4aa92493c36fef07415a0d0e6690464b2d21bd51
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-07T15:38:27Z

change iconPath to be relative to the project root directory, only; ie not 
to the www sub-directory anymore




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-lib/pull/294

CB-9590 - Ubuntu support for the new plugin naming convention

This patch allows ubuntu users to add plugins using the new naming 
convention and build properly. This also leaves support in place for the old 
style plugin names, during the transition.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9590

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294


commit 187711dd7fb7cd21e9ea276239b2e8b87a9e1ee6
Author: David Barth <david.ba...@canonical.com>
Date:   2015-09-01T17:40:35Z

Ubuntu support for the new plugin naming convention




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: 3.3.0 Release

[David Barth]

Le 12/12/2013 03:21, Carlos Santana a écrit :

CLI design contract is to just run platforms/platfomid/bin/create nothing
about running npm install on platform repo files.

If your platform scripts have dependencies platform is responsible to
satisfy its dependencies.

BlackBerry and Android have dependencies on npm modules, both handle
differently

Android include npm dependencies in the repo
https://github.com/apache/cordova-android/tree/master/bin/node_modules

BlackBerry runs npm install to install on demand as part of create script
https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/create#L38

hope this clarifies

Thanks Carlos, it does.

David

Re: 3.3.0 Release

[David Barth]

Le 11/12/2013 23:49, Steven Gill a écrit :

The master branch on CLI now depends on the correct plugman. That problem
should be good.

I will review the two pull requests and merge in if they look good.

And there is a 3rd one to make it run more reliably:
https://github.com/Zaspire/cordova-ubuntu/commit/faff5d6f1d710426181ea966bf88214ff076d91f


I am not sure about the CLI not honoring the dependencies expressed in
package.json. I don't think the CLI has any logic to do that. I think it
should be handled in a platform level script. Maybe force npm install
before the create command runs? Maybe create an init script like
blackberry10 has and run that while running check reqs? Others might have
better suggestions for this one.
Carlos clarified things. The pull requests above are going in the same 
direction, ie ensuring the installation of dependencies by the platform 
scripts themselves.




Other platforms ran into the permission issue you mentioned. I think
https://issues.apache.org/jira/browse/CB-3812 should have fixed it. Maybe
others can chime in with some suggestions here too.
Yes, I couldn't re-install support for android in a test example either. 
This will help.


David

Re: 3.3.0 Release

[David Barth]

Le 12/12/2013 14:34, David Barth a écrit :


Other platforms ran into the permission issue you mentioned. I think
https://issues.apache.org/jira/browse/CB-3812 should have fixed it. 
Maybe

others can chime in with some suggestions here too.
Yes, I couldn't re-install support for android in a test example 
either. This will help.


Switching to shelljs@2.0.6 fixes the issue

So, from a runtime perspective, we're just a few pull request from a +1 
here for Ubuntu.

https://github.com/apache/cordova-ubuntu/pull/4

I'll send 2 more pull requests for the doc. Not sure if that is tagged 
the same day.


David

Re: 3.3.0 Release

[David Barth]

Le 10/12/2013 19:37, Steven Gill a écrit :

Lets start the final round of tagging today!
https://issues.apache.org/jira/browse/CB-5538
+1, but we're still chasing down some dependency and chmod +x issues on 
the Ubuntu part. Will update this thread shortly.


David

Re: 3.3.0 Release

[David Barth]

Le 11/12/2013 16:39, David Barth a écrit :

Le 10/12/2013 19:37, Steven Gill a écrit :

Lets start the final round of tagging today!
https://issues.apache.org/jira/browse/CB-5538
+1, but we're still chasing down some dependency and chmod +x issues 
on the Ubuntu part. Will update this thread shortly.
Maxim added a workaround in those pull request to ensure that the 
dependencies for the ubuntu commands are satisfied:


https://github.com/apache/cordova-ubuntu/pull/2
https://github.com/apache/cordova-ubuntu/pull/1

Somehow, cordova-cli is not honoring the dependencies expressed in the 
package.json file here:


https://github.com/apache/cordova-ubuntu/blob/master/bin/package.json

maybe they should move one directory above, but I'm not so keen on 
changing that this late.


Please note also that the rc1 cordova-cli in the NPM registry still 
points to an old plugman version that does not support ubuntu.


Let me know if i'm missing something here.

I'll send an update when the remaining command permission issue is 
fixed. https://issues.apache.org/jira/browse/CB-5629


David

Pull request: Add Ubuntu to the README.md file

[David Barth]

Hi,

In preparation for the 3.3 release, here is a quick pull request to add 
Ubuntu to the README.md file, along with some release notes elements


https://github.com/apache/cordova-cli/pull/106

(namely no cross-compilation support from cordova-cli yet, but coming 
soon hopefully)


David