[ANNOUNCEMENT] Cordova Tooling & Template Release

[Bryan Ellis]

We have just released a major update to our Cordova tooling & template!
- cordova-fetch@3.0.0
- cordova-js@6.0.0
- cordova-serve@4.0.0
- cordova-node-xcode@3.0.0
- cordova-app-hello-world@5.0.0

You can view the release blog post at
https://cordova.apache.org/news/2020/04/13/tools-template-release.html

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Jan Piotrowski]

Best create a new one, as it has been quite some time and we probably
don't want everyone have to read these 13 mails again.

(You have my +1)

J

Am Di., 13. Aug. 2019 um 14:48 Uhr schrieb julio cesar sanchez
:
>
> As it looks like we didn't agree in the squash + merge, can we agree now?
> Or should I create a new thread to discuss it again?
>
>
> El jue., 23 ago. 2018 a las 16:24, Jan Piotrowski ()
> escribió:
>
> > Here is the PR on GitHub templates, our usage of them and actual
> > drafts for all templates:
> > https://github.com/apache/cordova-contribute/pull/3
> >
> > Please keep all further discussion on the issue and pull request
> > template in this Pull Request. Thank you.
> > Am Di., 21. Aug. 2018 um 20:21 Uhr schrieb :
> > >
> > > Sounds pretty good to me. A few thoughts:
> > >
> > > - The support question template should refer people to a proper support
> > > site like Stack Overflow.
> > > - Merge convention should be: if multiple commits make the history more
> > > meaningful, do a merge commit, else squash and rebase.
> > > - the templates will probably require different information to be
> > provided,
> > > depending on the repository. cordova-lib is usually platform independent,
> > > for example.
> > >
> > > Shazron  schrieb am Mi., 8. Aug. 2018, 06:52:
> > >
> > > > Agree with all 3 points by Jan.
> > > >
> > > > @Chris Brody I think we should make use of Github Milestones to track
> > > > related issues.
> > > > On Wed, Aug 8, 2018 at 6:59 AM Jan Piotrowski 
> > > > wrote:
> > > > >
> > > > > Update to my initial email:
> > > > >
> > > > > I just noticed we actually _do_ have an issue template in use in the
> > > > > cordovs-docs repository:
> > > > >
> > > >
> > https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md
> > > > >
> > > > > J
> > > > >
> > > > > 2018-08-07 23:18 GMT+02:00 julio cesar sanchez <
> > jcesarmob...@gmail.com>:
> > > > > > I think us as committers should decide if the commits make sense to
> > > > keep
> > > > > > all of them or squash them into one. But bug fixes should usually
> > be
> > > > only
> > > > > > one commit, and major refactors are not usually sent by non
> > committers
> > > > > >
> > > > > > El El mar, 7 ago 2018 a las 23:02, Chris Brody <
> > chris.br...@gmail.com>
> > > > > > escribió:
> > > > > >
> > > > > >> > > I would favor a place where a contributor can mark if s/he
> > would
> > > > > >> > > recommend the committer should *not* use the squash option.
> > > > > >> >
> > > > > >> > That of course could be defined in the contributor guidelines
> > or PR
> > > > > >> > template (although there it might be a bit confusing to new
> > users
> > > > that
> > > > > >> > don't know what this is talking about). Do you know how other
> > > > project
> > > > > >> > handle that?
> > > > > >>
> > > > > >> Haven't seen anything like this before.
> > > > > >>
> > > > > >> > In the end it is always the decision of the committer how
> > > > contributed
> > > > > >> > code makes it into the code base, so having good guidelines for
> > us
> > > > > >> > would probably be the best solution, right?
> > > > > >>
> > > > > >> Yes. General common sense may prove to be the major principle, as
> > I
> > > > > >> think it has in the past. For example:
> > > > > >> * Someone raises a PR with bug fixes and major refactoring in
> > separate
> > > > > >> commits (should not be squashed)
> > > > > >> * Someone else raises a PR with a single fix, but with extra
> > commits
> > > > > >> to fix issues with the first commit (*should* be squashed)
> > > > > >>
> > > > > >> I wonder if we can track these discussions in a better way,
> > somehow. I
> > > > > >> have no time to help with these things right now. I think better
> > > > > >> tracking could help ensure these important tasks do not get
> > forgotten.
> > > > > >>
> > > > > >>
> > -
> > > > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > > >>
> > > > > >>
> > > > >
> > > > > -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > >
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[julio cesar sanchez]

As it looks like we didn't agree in the squash + merge, can we agree now?
Or should I create a new thread to discuss it again?


El jue., 23 ago. 2018 a las 16:24, Jan Piotrowski ()
escribió:

> Here is the PR on GitHub templates, our usage of them and actual
> drafts for all templates:
> https://github.com/apache/cordova-contribute/pull/3
>
> Please keep all further discussion on the issue and pull request
> template in this Pull Request. Thank you.
> Am Di., 21. Aug. 2018 um 20:21 Uhr schrieb :
> >
> > Sounds pretty good to me. A few thoughts:
> >
> > - The support question template should refer people to a proper support
> > site like Stack Overflow.
> > - Merge convention should be: if multiple commits make the history more
> > meaningful, do a merge commit, else squash and rebase.
> > - the templates will probably require different information to be
> provided,
> > depending on the repository. cordova-lib is usually platform independent,
> > for example.
> >
> > Shazron  schrieb am Mi., 8. Aug. 2018, 06:52:
> >
> > > Agree with all 3 points by Jan.
> > >
> > > @Chris Brody I think we should make use of Github Milestones to track
> > > related issues.
> > > On Wed, Aug 8, 2018 at 6:59 AM Jan Piotrowski 
> > > wrote:
> > > >
> > > > Update to my initial email:
> > > >
> > > > I just noticed we actually _do_ have an issue template in use in the
> > > > cordovs-docs repository:
> > > >
> > >
> https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md
> > > >
> > > > J
> > > >
> > > > 2018-08-07 23:18 GMT+02:00 julio cesar sanchez <
> jcesarmob...@gmail.com>:
> > > > > I think us as committers should decide if the commits make sense to
> > > keep
> > > > > all of them or squash them into one. But bug fixes should usually
> be
> > > only
> > > > > one commit, and major refactors are not usually sent by non
> committers
> > > > >
> > > > > El El mar, 7 ago 2018 a las 23:02, Chris Brody <
> chris.br...@gmail.com>
> > > > > escribió:
> > > > >
> > > > >> > > I would favor a place where a contributor can mark if s/he
> would
> > > > >> > > recommend the committer should *not* use the squash option.
> > > > >> >
> > > > >> > That of course could be defined in the contributor guidelines
> or PR
> > > > >> > template (although there it might be a bit confusing to new
> users
> > > that
> > > > >> > don't know what this is talking about). Do you know how other
> > > project
> > > > >> > handle that?
> > > > >>
> > > > >> Haven't seen anything like this before.
> > > > >>
> > > > >> > In the end it is always the decision of the committer how
> > > contributed
> > > > >> > code makes it into the code base, so having good guidelines for
> us
> > > > >> > would probably be the best solution, right?
> > > > >>
> > > > >> Yes. General common sense may prove to be the major principle, as
> I
> > > > >> think it has in the past. For example:
> > > > >> * Someone raises a PR with bug fixes and major refactoring in
> separate
> > > > >> commits (should not be squashed)
> > > > >> * Someone else raises a PR with a single fix, but with extra
> commits
> > > > >> to fix issues with the first commit (*should* be squashed)
> > > > >>
> > > > >> I wonder if we can track these discussions in a better way,
> somehow. I
> > > > >> have no time to help with these things right now. I think better
> > > > >> tracking could help ensure these important tasks do not get
> forgotten.
> > > > >>
> > > > >>
> -
> > > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > >>
> > > > >>
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[ANNOUNCEMENT] Tools and Template Release

[Bryan Ellis]

We have just released an update to our tools and template!
- cordova-app-hello-world@4.0.0
- cordova-fetch@2.0.0
- cordova-js@5.0.0
- cordova-serve@3.0.0

You can view the release blog post at
https://cordova.apache.org/news/2018/12/25/tools-release.html

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Jan Piotrowski]

Here is the PR on GitHub templates, our usage of them and actual
drafts for all templates:
https://github.com/apache/cordova-contribute/pull/3

Please keep all further discussion on the issue and pull request
template in this Pull Request. Thank you.
Am Di., 21. Aug. 2018 um 20:21 Uhr schrieb :
>
> Sounds pretty good to me. A few thoughts:
>
> - The support question template should refer people to a proper support
> site like Stack Overflow.
> - Merge convention should be: if multiple commits make the history more
> meaningful, do a merge commit, else squash and rebase.
> - the templates will probably require different information to be provided,
> depending on the repository. cordova-lib is usually platform independent,
> for example.
>
> Shazron  schrieb am Mi., 8. Aug. 2018, 06:52:
>
> > Agree with all 3 points by Jan.
> >
> > @Chris Brody I think we should make use of Github Milestones to track
> > related issues.
> > On Wed, Aug 8, 2018 at 6:59 AM Jan Piotrowski 
> > wrote:
> > >
> > > Update to my initial email:
> > >
> > > I just noticed we actually _do_ have an issue template in use in the
> > > cordovs-docs repository:
> > >
> > https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md
> > >
> > > J
> > >
> > > 2018-08-07 23:18 GMT+02:00 julio cesar sanchez :
> > > > I think us as committers should decide if the commits make sense to
> > keep
> > > > all of them or squash them into one. But bug fixes should usually be
> > only
> > > > one commit, and major refactors are not usually sent by non committers
> > > >
> > > > El El mar, 7 ago 2018 a las 23:02, Chris Brody 
> > > > escribió:
> > > >
> > > >> > > I would favor a place where a contributor can mark if s/he would
> > > >> > > recommend the committer should *not* use the squash option.
> > > >> >
> > > >> > That of course could be defined in the contributor guidelines or PR
> > > >> > template (although there it might be a bit confusing to new users
> > that
> > > >> > don't know what this is talking about). Do you know how other
> > project
> > > >> > handle that?
> > > >>
> > > >> Haven't seen anything like this before.
> > > >>
> > > >> > In the end it is always the decision of the committer how
> > contributed
> > > >> > code makes it into the code base, so having good guidelines for us
> > > >> > would probably be the best solution, right?
> > > >>
> > > >> Yes. General common sense may prove to be the major principle, as I
> > > >> think it has in the past. For example:
> > > >> * Someone raises a PR with bug fixes and major refactoring in separate
> > > >> commits (should not be squashed)
> > > >> * Someone else raises a PR with a single fix, but with extra commits
> > > >> to fix issues with the first commit (*should* be squashed)
> > > >>
> > > >> I wonder if we can track these discussions in a better way, somehow. I
> > > >> have no time to help with these things right now. I think better
> > > >> tracking could help ensure these important tasks do not get forgotten.
> > > >>
> > > >> -
> > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >>
> > > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[raphinesse]

Sounds pretty good to me. A few thoughts:

- The support question template should refer people to a proper support
site like Stack Overflow.
- Merge convention should be: if multiple commits make the history more
meaningful, do a merge commit, else squash and rebase.
- the templates will probably require different information to be provided,
depending on the repository. cordova-lib is usually platform independent,
for example.

Shazron  schrieb am Mi., 8. Aug. 2018, 06:52:

> Agree with all 3 points by Jan.
>
> @Chris Brody I think we should make use of Github Milestones to track
> related issues.
> On Wed, Aug 8, 2018 at 6:59 AM Jan Piotrowski 
> wrote:
> >
> > Update to my initial email:
> >
> > I just noticed we actually _do_ have an issue template in use in the
> > cordovs-docs repository:
> >
> https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md
> >
> > J
> >
> > 2018-08-07 23:18 GMT+02:00 julio cesar sanchez :
> > > I think us as committers should decide if the commits make sense to
> keep
> > > all of them or squash them into one. But bug fixes should usually be
> only
> > > one commit, and major refactors are not usually sent by non committers
> > >
> > > El El mar, 7 ago 2018 a las 23:02, Chris Brody 
> > > escribió:
> > >
> > >> > > I would favor a place where a contributor can mark if s/he would
> > >> > > recommend the committer should *not* use the squash option.
> > >> >
> > >> > That of course could be defined in the contributor guidelines or PR
> > >> > template (although there it might be a bit confusing to new users
> that
> > >> > don't know what this is talking about). Do you know how other
> project
> > >> > handle that?
> > >>
> > >> Haven't seen anything like this before.
> > >>
> > >> > In the end it is always the decision of the committer how
> contributed
> > >> > code makes it into the code base, so having good guidelines for us
> > >> > would probably be the best solution, right?
> > >>
> > >> Yes. General common sense may prove to be the major principle, as I
> > >> think it has in the past. For example:
> > >> * Someone raises a PR with bug fixes and major refactoring in separate
> > >> commits (should not be squashed)
> > >> * Someone else raises a PR with a single fix, but with extra commits
> > >> to fix issues with the first commit (*should* be squashed)
> > >>
> > >> I wonder if we can track these discussions in a better way, somehow. I
> > >> have no time to help with these things right now. I think better
> > >> tracking could help ensure these important tasks do not get forgotten.
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > >>
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Shazron]

Agree with all 3 points by Jan.

@Chris Brody I think we should make use of Github Milestones to track
related issues.
On Wed, Aug 8, 2018 at 6:59 AM Jan Piotrowski  wrote:
>
> Update to my initial email:
>
> I just noticed we actually _do_ have an issue template in use in the
> cordovs-docs repository:
> https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md
>
> J
>
> 2018-08-07 23:18 GMT+02:00 julio cesar sanchez :
> > I think us as committers should decide if the commits make sense to keep
> > all of them or squash them into one. But bug fixes should usually be only
> > one commit, and major refactors are not usually sent by non committers
> >
> > El El mar, 7 ago 2018 a las 23:02, Chris Brody 
> > escribió:
> >
> >> > > I would favor a place where a contributor can mark if s/he would
> >> > > recommend the committer should *not* use the squash option.
> >> >
> >> > That of course could be defined in the contributor guidelines or PR
> >> > template (although there it might be a bit confusing to new users that
> >> > don't know what this is talking about). Do you know how other project
> >> > handle that?
> >>
> >> Haven't seen anything like this before.
> >>
> >> > In the end it is always the decision of the committer how contributed
> >> > code makes it into the code base, so having good guidelines for us
> >> > would probably be the best solution, right?
> >>
> >> Yes. General common sense may prove to be the major principle, as I
> >> think it has in the past. For example:
> >> * Someone raises a PR with bug fixes and major refactoring in separate
> >> commits (should not be squashed)
> >> * Someone else raises a PR with a single fix, but with extra commits
> >> to fix issues with the first commit (*should* be squashed)
> >>
> >> I wonder if we can track these discussions in a better way, somehow. I
> >> have no time to help with these things right now. I think better
> >> tracking could help ensure these important tasks do not get forgotten.
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Jan Piotrowski]

Update to my initial email:

I just noticed we actually _do_ have an issue template in use in the
cordovs-docs repository:
https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md

J

2018-08-07 23:18 GMT+02:00 julio cesar sanchez :
> I think us as committers should decide if the commits make sense to keep
> all of them or squash them into one. But bug fixes should usually be only
> one commit, and major refactors are not usually sent by non committers
>
> El El mar, 7 ago 2018 a las 23:02, Chris Brody 
> escribió:
>
>> > > I would favor a place where a contributor can mark if s/he would
>> > > recommend the committer should *not* use the squash option.
>> >
>> > That of course could be defined in the contributor guidelines or PR
>> > template (although there it might be a bit confusing to new users that
>> > don't know what this is talking about). Do you know how other project
>> > handle that?
>>
>> Haven't seen anything like this before.
>>
>> > In the end it is always the decision of the committer how contributed
>> > code makes it into the code base, so having good guidelines for us
>> > would probably be the best solution, right?
>>
>> Yes. General common sense may prove to be the major principle, as I
>> think it has in the past. For example:
>> * Someone raises a PR with bug fixes and major refactoring in separate
>> commits (should not be squashed)
>> * Someone else raises a PR with a single fix, but with extra commits
>> to fix issues with the first commit (*should* be squashed)
>>
>> I wonder if we can track these discussions in a better way, somehow. I
>> have no time to help with these things right now. I think better
>> tracking could help ensure these important tasks do not get forgotten.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[julio cesar sanchez]

I think us as committers should decide if the commits make sense to keep
all of them or squash them into one. But bug fixes should usually be only
one commit, and major refactors are not usually sent by non committers

El El mar, 7 ago 2018 a las 23:02, Chris Brody 
escribió:

> > > I would favor a place where a contributor can mark if s/he would
> > > recommend the committer should *not* use the squash option.
> >
> > That of course could be defined in the contributor guidelines or PR
> > template (although there it might be a bit confusing to new users that
> > don't know what this is talking about). Do you know how other project
> > handle that?
>
> Haven't seen anything like this before.
>
> > In the end it is always the decision of the committer how contributed
> > code makes it into the code base, so having good guidelines for us
> > would probably be the best solution, right?
>
> Yes. General common sense may prove to be the major principle, as I
> think it has in the past. For example:
> * Someone raises a PR with bug fixes and major refactoring in separate
> commits (should not be squashed)
> * Someone else raises a PR with a single fix, but with extra commits
> to fix issues with the first commit (*should* be squashed)
>
> I wonder if we can track these discussions in a better way, somehow. I
> have no time to help with these things right now. I think better
> tracking could help ensure these important tasks do not get forgotten.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Chris Brody]

> > I would favor a place where a contributor can mark if s/he would
> > recommend the committer should *not* use the squash option.
>
> That of course could be defined in the contributor guidelines or PR
> template (although there it might be a bit confusing to new users that
> don't know what this is talking about). Do you know how other project
> handle that?

Haven't seen anything like this before.

> In the end it is always the decision of the committer how contributed
> code makes it into the code base, so having good guidelines for us
> would probably be the best solution, right?

Yes. General common sense may prove to be the major principle, as I
think it has in the past. For example:
* Someone raises a PR with bug fixes and major refactoring in separate
commits (should not be squashed)
* Someone else raises a PR with a single fix, but with extra commits
to fix issues with the first commit (*should* be squashed)

I wonder if we can track these discussions in a better way, somehow. I
have no time to help with these things right now. I think better
tracking could help ensure these important tasks do not get forgotten.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Jan Piotrowski]

All very good points Chris.

>> > 3. Merge Conventions / Protected Branch:

> Nice idea. The one exception is that committers sometimes have to tag
> and push individual commits when making releases.

We will definitely have to check how this works with current workflows
defined in coho and in other places.

> I would favor a place where a contributor can mark if s/he would
> recommend the committer should *not* use the squash option.

That of course could be defined in the contributor guidelines or PR
template (although there it might be a bit confusing to new users that
don't know what this is talking about). Do you know how other project
handle that?
In the end it is always the decision of the committer how contributed
code makes it into the code base, so having good guidelines for us
would probably be the best solution, right?

-J

2018-08-07 21:36 GMT+02:00 Chris Brody :
>> 1. Issue template:
>> [...]
>> I think we should definitely use this for Bug Report, Feature Request,
>> Support Question. What sections should we suggest in our templates?
>
> All suggestions look good, should probably give proper attribution.
>
>> 2. Pull Request template:
>>
>> I think we can drop the JIRA/issue requirement from the checklist
>> completely - as a PR on Github is always the starting point of code
>> changes now. If there is an (Github) issue the PR resolves, it should
>> of course be linked (`closes #123` or similar), but this is not a
>> requirement.
>>
>> Similar about commit message conventions - I don't think we need an
>> issue ID in there as all code changes will be done via PRs which via
>> "squash + merge" will include PR ID in the commit message (again
>> fastlane as an example:
>> https://github.com/fastlane/fastlane/commits/master)
>>
>> I would suggest we use something similar to this, which explicitly
>> asks for running the tests and writing documentation:
>> https://github.com/fastlane/fastlane/blob/master/.github/PULL_REQUEST_TEMPLATE.md
>>
>> What do you think regarding PR template?
>
> Looks nice in general, again we should probably give proper
> attribution upon reuse.
>
> It might be good to require a checkbox for developers certificate of
> origin (developercertificate.org) like at:
> https://github.com/papercss/papercss/blob/master/.github/PULL_REQUEST_TEMPLATE.md
>
>> 3. Merge Conventions / Protected Branch:
>>
>> Connected to all that is my suggestion to protect the `master` branch
>> so that by default nobody can commit there - all changes have to be
>> made via Pull Requests.
>
> Nice idea. The one exception is that committers sometimes have to tag
> and push individual commits when making releases.
>
> A possible workaround would be to say that we always start a release
> branch before publishing an actual release, like they seem to do in
> Node.js. Could keep things a little cleaner.
>
>> Pull Requests are by default merged via the
>> "Squash + Merge" button / functionality so that all commits are
>> squashed into one clean commit per change. This also enforces the
>> commit message structure I posted above. (Of course committers can
>> choose to _not_ use Squash + Merge if appropriate for the PR - e.g.
>> when cherry picking commits from a release branch or similar).
>
> I would favor a place where a contributor can mark if s/he would
> recommend the committer should *not* use the squash option.
>
> I am starting to favor a choice between squash merge and merge commit.
> I think these choices keep things a little more clear in the history
> and would reliably mark the PR, unlike "rebase merge".
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Chris Brody]

> > It might be good to require a checkbox for developers certificate of
> > origin (developercertificate.org) like at:
> > https://github.com/papercss/papercss/blob/master/.github/PULL_REQUEST_TEMPLATE.md
>
> If we were going to require something like this, I think we would have
> to go back to the ASF ICLA again. We had finally moved away from

idea withdrawn

(I continue to stand by my other comments regarding the issue
template, PR template, and merge conventions)

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Darryl Pogue]

On Tue, Aug 7, 2018 at 12:36 PM Chris Brody  wrote:
>
> > I would suggest we use something similar to this, which explicitly
> > asks for running the tests and writing documentation:
> > https://github.com/fastlane/fastlane/blob/master/.github/PULL_REQUEST_TEMPLATE.md
> >
> > What do you think regarding PR template?
>
> Looks nice in general, again we should probably give proper
> attribution upon reuse.
>
> It might be good to require a checkbox for developers certificate of
> origin (developercertificate.org) like at:
> https://github.com/papercss/papercss/blob/master/.github/PULL_REQUEST_TEMPLATE.md

If we were going to require something like this, I think we would have
to go back to the ASF ICLA again. We had finally moved away from
requiring that for pull requests using the act of opening a pull
request as intent to contribute, but previously it was required to all
PRs and there were a bunch of people who never signed it leading to
PRs with valid bugfixes staying open and getting stale because we
weren't allowed to merge them for policy reasons.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Chris Brody]

> 1. Issue template:
> [...]
> I think we should definitely use this for Bug Report, Feature Request,
> Support Question. What sections should we suggest in our templates?

All suggestions look good, should probably give proper attribution.

> 2. Pull Request template:
>
> I think we can drop the JIRA/issue requirement from the checklist
> completely - as a PR on Github is always the starting point of code
> changes now. If there is an (Github) issue the PR resolves, it should
> of course be linked (`closes #123` or similar), but this is not a
> requirement.
>
> Similar about commit message conventions - I don't think we need an
> issue ID in there as all code changes will be done via PRs which via
> "squash + merge" will include PR ID in the commit message (again
> fastlane as an example:
> https://github.com/fastlane/fastlane/commits/master)
>
> I would suggest we use something similar to this, which explicitly
> asks for running the tests and writing documentation:
> https://github.com/fastlane/fastlane/blob/master/.github/PULL_REQUEST_TEMPLATE.md
>
> What do you think regarding PR template?

Looks nice in general, again we should probably give proper
attribution upon reuse.

It might be good to require a checkbox for developers certificate of
origin (developercertificate.org) like at:
https://github.com/papercss/papercss/blob/master/.github/PULL_REQUEST_TEMPLATE.md

> 3. Merge Conventions / Protected Branch:
>
> Connected to all that is my suggestion to protect the `master` branch
> so that by default nobody can commit there - all changes have to be
> made via Pull Requests.

Nice idea. The one exception is that committers sometimes have to tag
and push individual commits when making releases.

A possible workaround would be to say that we always start a release
branch before publishing an actual release, like they seem to do in
Node.js. Could keep things a little cleaner.

> Pull Requests are by default merged via the
> "Squash + Merge" button / functionality so that all commits are
> squashed into one clean commit per change. This also enforces the
> commit message structure I posted above. (Of course committers can
> choose to _not_ use Squash + Merge if appropriate for the PR - e.g.
> when cherry picking commits from a release branch or similar).

I would favor a place where a contributor can mark if s/he would
recommend the committer should *not* use the squash option.

I am starting to favor a choice between squash merge and merge commit.
I think these choices keep things a little more clear in the history
and would reliably mark the PR, unlike "rebase merge".

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Jan Piotrowski]

Thanks all, but handling the migration of JIRA issues to Github is
not really the topic of this discussion.
Either use the other "[DISCUSS] [JIRA -> GitHub Issues] The way
forward" thread where I had defined this as "d) Define and execute
issue migration from JIRA to GitHub" or create a new thread.
Thank you.

Any feedback about the 3 topics I mentioned in my initial email in this thread?

J

2018-08-07 19:45 GMT+02:00 julio cesar sanchez :
> I wouldn't do 2, most people won't create a new issue, but that doesn't
> mean the issue doesn't exist.
>
> Anyway, I think there is another thread about the migration, this is for
> the templates.
>
>
> El mar., 7 ago. 2018 a las 19:04, Chris Brody ()
> escribió:
>
>> Options I can think of:
>>
>> 1: make and use an auto-migration script
>> 2: use quick filters to close issues in bulk with a message that the
>> OP should manually raise on GitHub if so desired
>> 3: continue with JIRA issues for a while
>>
>> I would vote for the easiest way possible to end use of JIRA issues
>> (probably option 2).
>> On Tue, Aug 7, 2018 at 12:59 PM gandhi rajan 
>> wrote:
>> >
>> > Hi Jan,
>> >
>> > I like your suggestions. But curious to understand how to take care of
>> > existing issues which are currently available in JIRA? Should it be
>> ported
>> > to respective git repos or will continue to remain as is till it's
>> closed?
>> >
>> > On Tuesday, August 7, 2018, Jan Piotrowski  wrote:
>> >
>> > > Now that Github Issues are enabled on all repositories, it makes sense
>> > > to create a (or several) new Issue and PR template(s) that doesn't
>> > > point to JIRA any more and also uses the current state of the art.
>> > >
>> > > Current Cordova issue and PR template:
>> > > - no issue template
>> > > - https://github.com/apache/cordova-android/blob/master/.
>> > > github/PULL_REQUEST_TEMPLATE.md
>> > >
>> > >
>> > > 1. Issue template:
>> > >
>> > > Github supports multiple issue templates for some time now, which
>> > > first lets users choose what type of issue they want to create:
>> > >
>> https://help.github.com/articles/about-issue-and-pull-request-templates/
>> > >
>> > > The template selection can look like this:
>> > > https://github.com/fastlane/fastlane/issues/new/choose
>> > > https://github.com/babel/babel/issues/new/choose
>> > >
>> > > I think we should definitely use this for Bug Report, Feature Request,
>> > > Support Question. What sections should we suggest in our templates?
>> > >
>> > > Here are some additinal issue templates from around the web:
>> > >
>> https://github.com/stevemao/github-issue-templates/tree/master/emoji-guide
>> > > https://github.com/devspace/awesome-github-templates
>> > >
>> > >
>> > > 2. Pull Request template:
>> > >
>> > > I think we can drop the JIRA/issue requirement from the checklist
>> > > completely - as a PR on Github is always the starting point of code
>> > > changes now. If there is an (Github) issue the PR resolves, it should
>> > > of course be linked (`closes #123` or similar), but this is not a
>> > > requirement.
>> > >
>> > > Similar about commit message conventions - I don't think we need an
>> > > issue ID in there as all code changes will be done via PRs which via
>> > > "squash + merge" will include PR ID in the commit message (again
>> > > fastlane as an example:
>> > > https://github.com/fastlane/fastlane/commits/master)
>> > >
>> > > I would suggest we use something similar to this, which explicitly
>> > > asks for running the tests and writing documentation:
>> > > https://github.com/fastlane/fastlane/blob/master/.github/
>> > > PULL_REQUEST_TEMPLATE.md
>> > >
>> > > What do you think regarding PR template?
>> > >
>> > >
>> > > 3. Merge Conventions / Protected Branch:
>> > >
>> > > Connected to all that is my suggestion to protect the `master` branch
>> > > so that by default nobody can commit there - all changes have to be
>> > > made via Pull Requests. Pull Requests are by default merged via the
>> > > "Squash + Merge" button / functionality so that all commits are
>> > > squashed into one clean

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[julio cesar sanchez]

I wouldn't do 2, most people won't create a new issue, but that doesn't
mean the issue doesn't exist.

Anyway, I think there is another thread about the migration, this is for
the templates.


El mar., 7 ago. 2018 a las 19:04, Chris Brody ()
escribió:

> Options I can think of:
>
> 1: make and use an auto-migration script
> 2: use quick filters to close issues in bulk with a message that the
> OP should manually raise on GitHub if so desired
> 3: continue with JIRA issues for a while
>
> I would vote for the easiest way possible to end use of JIRA issues
> (probably option 2).
> On Tue, Aug 7, 2018 at 12:59 PM gandhi rajan 
> wrote:
> >
> > Hi Jan,
> >
> > I like your suggestions. But curious to understand how to take care of
> > existing issues which are currently available in JIRA? Should it be
> ported
> > to respective git repos or will continue to remain as is till it's
> closed?
> >
> > On Tuesday, August 7, 2018, Jan Piotrowski  wrote:
> >
> > > Now that Github Issues are enabled on all repositories, it makes sense
> > > to create a (or several) new Issue and PR template(s) that doesn't
> > > point to JIRA any more and also uses the current state of the art.
> > >
> > > Current Cordova issue and PR template:
> > > - no issue template
> > > - https://github.com/apache/cordova-android/blob/master/.
> > > github/PULL_REQUEST_TEMPLATE.md
> > >
> > >
> > > 1. Issue template:
> > >
> > > Github supports multiple issue templates for some time now, which
> > > first lets users choose what type of issue they want to create:
> > >
> https://help.github.com/articles/about-issue-and-pull-request-templates/
> > >
> > > The template selection can look like this:
> > > https://github.com/fastlane/fastlane/issues/new/choose
> > > https://github.com/babel/babel/issues/new/choose
> > >
> > > I think we should definitely use this for Bug Report, Feature Request,
> > > Support Question. What sections should we suggest in our templates?
> > >
> > > Here are some additinal issue templates from around the web:
> > >
> https://github.com/stevemao/github-issue-templates/tree/master/emoji-guide
> > > https://github.com/devspace/awesome-github-templates
> > >
> > >
> > > 2. Pull Request template:
> > >
> > > I think we can drop the JIRA/issue requirement from the checklist
> > > completely - as a PR on Github is always the starting point of code
> > > changes now. If there is an (Github) issue the PR resolves, it should
> > > of course be linked (`closes #123` or similar), but this is not a
> > > requirement.
> > >
> > > Similar about commit message conventions - I don't think we need an
> > > issue ID in there as all code changes will be done via PRs which via
> > > "squash + merge" will include PR ID in the commit message (again
> > > fastlane as an example:
> > > https://github.com/fastlane/fastlane/commits/master)
> > >
> > > I would suggest we use something similar to this, which explicitly
> > > asks for running the tests and writing documentation:
> > > https://github.com/fastlane/fastlane/blob/master/.github/
> > > PULL_REQUEST_TEMPLATE.md
> > >
> > > What do you think regarding PR template?
> > >
> > >
> > > 3. Merge Conventions / Protected Branch:
> > >
> > > Connected to all that is my suggestion to protect the `master` branch
> > > so that by default nobody can commit there - all changes have to be
> > > made via Pull Requests. Pull Requests are by default merged via the
> > > "Squash + Merge" button / functionality so that all commits are
> > > squashed into one clean commit per change. This also enforces the
> > > commit message structure I posted above. (Of course committers can
> > > choose to _not_ use Squash + Merge if appropriate for the PR - e.g.
> > > when cherry picking commits from a release branch or similar).
> > >
> > > What do you think about this suggestion?
> > >
> > >
> > > Did I miss anything that is connected to these 3 topics?
> > >
> > > -J
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
> > --
> > Regards,
> > Gandhi
> >
> > "The best way to find urself is to lose urself in the service of others
> !!!"
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Chris Brody]

Options I can think of:

1: make and use an auto-migration script
2: use quick filters to close issues in bulk with a message that the
OP should manually raise on GitHub if so desired
3: continue with JIRA issues for a while

I would vote for the easiest way possible to end use of JIRA issues
(probably option 2).
On Tue, Aug 7, 2018 at 12:59 PM gandhi rajan  wrote:
>
> Hi Jan,
>
> I like your suggestions. But curious to understand how to take care of
> existing issues which are currently available in JIRA? Should it be ported
> to respective git repos or will continue to remain as is till it's closed?
>
> On Tuesday, August 7, 2018, Jan Piotrowski  wrote:
>
> > Now that Github Issues are enabled on all repositories, it makes sense
> > to create a (or several) new Issue and PR template(s) that doesn't
> > point to JIRA any more and also uses the current state of the art.
> >
> > Current Cordova issue and PR template:
> > - no issue template
> > - https://github.com/apache/cordova-android/blob/master/.
> > github/PULL_REQUEST_TEMPLATE.md
> >
> >
> > 1. Issue template:
> >
> > Github supports multiple issue templates for some time now, which
> > first lets users choose what type of issue they want to create:
> > https://help.github.com/articles/about-issue-and-pull-request-templates/
> >
> > The template selection can look like this:
> > https://github.com/fastlane/fastlane/issues/new/choose
> > https://github.com/babel/babel/issues/new/choose
> >
> > I think we should definitely use this for Bug Report, Feature Request,
> > Support Question. What sections should we suggest in our templates?
> >
> > Here are some additinal issue templates from around the web:
> > https://github.com/stevemao/github-issue-templates/tree/master/emoji-guide
> > https://github.com/devspace/awesome-github-templates
> >
> >
> > 2. Pull Request template:
> >
> > I think we can drop the JIRA/issue requirement from the checklist
> > completely - as a PR on Github is always the starting point of code
> > changes now. If there is an (Github) issue the PR resolves, it should
> > of course be linked (`closes #123` or similar), but this is not a
> > requirement.
> >
> > Similar about commit message conventions - I don't think we need an
> > issue ID in there as all code changes will be done via PRs which via
> > "squash + merge" will include PR ID in the commit message (again
> > fastlane as an example:
> > https://github.com/fastlane/fastlane/commits/master)
> >
> > I would suggest we use something similar to this, which explicitly
> > asks for running the tests and writing documentation:
> > https://github.com/fastlane/fastlane/blob/master/.github/
> > PULL_REQUEST_TEMPLATE.md
> >
> > What do you think regarding PR template?
> >
> >
> > 3. Merge Conventions / Protected Branch:
> >
> > Connected to all that is my suggestion to protect the `master` branch
> > so that by default nobody can commit there - all changes have to be
> > made via Pull Requests. Pull Requests are by default merged via the
> > "Squash + Merge" button / functionality so that all commits are
> > squashed into one clean commit per change. This also enforces the
> > commit message structure I posted above. (Of course committers can
> > choose to _not_ use Squash + Merge if appropriate for the PR - e.g.
> > when cherry picking commits from a release branch or similar).
> >
> > What do you think about this suggestion?
> >
> >
> > Did I miss anything that is connected to these 3 topics?
> >
> > -J
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>
> --
> Regards,
> Gandhi
>
> "The best way to find urself is to lose urself in the service of others !!!"

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[gandhi rajan]

Hi Jan,

I like your suggestions. But curious to understand how to take care of
existing issues which are currently available in JIRA? Should it be ported
to respective git repos or will continue to remain as is till it's closed?

On Tuesday, August 7, 2018, Jan Piotrowski  wrote:

> Now that Github Issues are enabled on all repositories, it makes sense
> to create a (or several) new Issue and PR template(s) that doesn't
> point to JIRA any more and also uses the current state of the art.
>
> Current Cordova issue and PR template:
> - no issue template
> - https://github.com/apache/cordova-android/blob/master/.
> github/PULL_REQUEST_TEMPLATE.md
>
>
> 1. Issue template:
>
> Github supports multiple issue templates for some time now, which
> first lets users choose what type of issue they want to create:
> https://help.github.com/articles/about-issue-and-pull-request-templates/
>
> The template selection can look like this:
> https://github.com/fastlane/fastlane/issues/new/choose
> https://github.com/babel/babel/issues/new/choose
>
> I think we should definitely use this for Bug Report, Feature Request,
> Support Question. What sections should we suggest in our templates?
>
> Here are some additinal issue templates from around the web:
> https://github.com/stevemao/github-issue-templates/tree/master/emoji-guide
> https://github.com/devspace/awesome-github-templates
>
>
> 2. Pull Request template:
>
> I think we can drop the JIRA/issue requirement from the checklist
> completely - as a PR on Github is always the starting point of code
> changes now. If there is an (Github) issue the PR resolves, it should
> of course be linked (`closes #123` or similar), but this is not a
> requirement.
>
> Similar about commit message conventions - I don't think we need an
> issue ID in there as all code changes will be done via PRs which via
> "squash + merge" will include PR ID in the commit message (again
> fastlane as an example:
> https://github.com/fastlane/fastlane/commits/master)
>
> I would suggest we use something similar to this, which explicitly
> asks for running the tests and writing documentation:
> https://github.com/fastlane/fastlane/blob/master/.github/
> PULL_REQUEST_TEMPLATE.md
>
> What do you think regarding PR template?
>
>
> 3. Merge Conventions / Protected Branch:
>
> Connected to all that is my suggestion to protect the `master` branch
> so that by default nobody can commit there - all changes have to be
> made via Pull Requests. Pull Requests are by default merged via the
> "Squash + Merge" button / functionality so that all commits are
> squashed into one clean commit per change. This also enforces the
> commit message structure I posted above. (Of course committers can
> choose to _not_ use Squash + Merge if appropriate for the PR - e.g.
> when cherry picking commits from a release branch or similar).
>
> What do you think about this suggestion?
>
>
> Did I miss anything that is connected to these 3 topics?
>
> -J
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

-- 
Regards,
Gandhi

"The best way to find urself is to lose urself in the service of others !!!"

[DISCUSS] [Github Issues] Issue and PR template + Merge Conventions / Protected Branch

[Jan Piotrowski]

Now that Github Issues are enabled on all repositories, it makes sense
to create a (or several) new Issue and PR template(s) that doesn't
point to JIRA any more and also uses the current state of the art.

Current Cordova issue and PR template:
- no issue template
- 
https://github.com/apache/cordova-android/blob/master/.github/PULL_REQUEST_TEMPLATE.md


1. Issue template:

Github supports multiple issue templates for some time now, which
first lets users choose what type of issue they want to create:
https://help.github.com/articles/about-issue-and-pull-request-templates/

The template selection can look like this:
https://github.com/fastlane/fastlane/issues/new/choose
https://github.com/babel/babel/issues/new/choose

I think we should definitely use this for Bug Report, Feature Request,
Support Question. What sections should we suggest in our templates?

Here are some additinal issue templates from around the web:
https://github.com/stevemao/github-issue-templates/tree/master/emoji-guide
https://github.com/devspace/awesome-github-templates


2. Pull Request template:

I think we can drop the JIRA/issue requirement from the checklist
completely - as a PR on Github is always the starting point of code
changes now. If there is an (Github) issue the PR resolves, it should
of course be linked (`closes #123` or similar), but this is not a
requirement.

Similar about commit message conventions - I don't think we need an
issue ID in there as all code changes will be done via PRs which via
"squash + merge" will include PR ID in the commit message (again
fastlane as an example:
https://github.com/fastlane/fastlane/commits/master)

I would suggest we use something similar to this, which explicitly
asks for running the tests and writing documentation:
https://github.com/fastlane/fastlane/blob/master/.github/PULL_REQUEST_TEMPLATE.md

What do you think regarding PR template?


3. Merge Conventions / Protected Branch:

Connected to all that is my suggestion to protect the `master` branch
so that by default nobody can commit there - all changes have to be
made via Pull Requests. Pull Requests are by default merged via the
"Squash + Merge" button / functionality so that all commits are
squashed into one clean commit per change. This also enforces the
commit message structure I posted above. (Of course committers can
choose to _not_ use Squash + Merge if appropriate for the PR - e.g.
when cherry picking commits from a release branch or similar).

What do you think about this suggestion?


Did I miss anything that is connected to these 3 topics?

-J

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/266


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios issue #266: CB-11729 - template file MainViewController.m has de...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/266
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) is 56.50% 
(diff: 100%)
> Merging [#266](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #266   diff @@
==
  Files12 12  
  Lines  1230   1230  
  Methods 198198  
  Messages  0  0  
  Branches193193  
==
  Hits695695  
  Misses  535535  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[636113f...d71cb97](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...d71cb97fa31c8e59df10dffa3fc6cb927e2deb42?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/266

CB-11729 - template file MainViewController.m has deprecated override 
shouldAutorotateToInterfaceOrientation

### Platforms affected
iOS

### What does this PR do?

Remove unused selector in MainViewController subclass, add in comments the 
new overrides available.

### What testing has been done on this change?

Local build

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-11729

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #266


commit d71cb97fa31c8e59df10dffa3fc6cb927e2deb42
Author: Shazron Abdullah <shaz...@apache.org>
Date:   2016-10-07T23:26:36Z

CB-11729 - template file MainViewController.m has deprecated override 
shouldAutorotateToInterfaceOrientation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device issue #56: CB-11917 - Remove pull request template che...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-device/pull/56
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-device/pull/56/commits/2b2ac3210277ce72a4a1319ae0bced79df4ce882)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/17//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console issue #20: CB-11917 - Remove pull request template ch...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-console/pull/20
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-console/pull/20/commits/a2f5c0960cc9a3bdd653bfbda8eff6c2ec5b140a)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/114//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs issue #87: CB-11917 - Remove pull request template ch...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-dialogs/pull/87
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-dialogs/pull/87/commits/0f13c5b11b19bff8ab4724f9cb977e839ab6abbe)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/41//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration issue #50: CB-11917 - Remove pull request template ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-vibration/pull/50
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-vibration/pull/50/commits/b6046588cb67cb3ff3afdb2e16d6402de20aa29a)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/19//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file issue #196: CB-11917 - Remove pull request template chec...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/196
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/196/commits/0636e453859bc6a372210933dd0a6fc23180e68e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/43//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #66: CB-11917 - Remove pull request template ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/66
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/66/commits/188b0d7ea6546490d069419f021058eb30534064)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/28//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #237: CB-11917 - Remove pull request template ch...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/237
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/237/commits/24c15cb9bd5e54ecf1a5c31d1203ed22a1159937)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/83//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #118: CB-11917 - Remove pull request template che...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/118
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-media/pull/118/commits/fec77201efdef0c7cfb6372b1110b0d1de450365)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/81//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts issue #137: CB-11917 - Remove pull request template ...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/137
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/137/commits/c3d06a6cb1995267ae50abb303b874e57336b9a7)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/40//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #612: CB-11412 Added docs for template use and cre...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #612: CB-11412 Added docs for template use and cre...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/612#discussion_r73905774
  
--- Diff: www/_data/redirects.yml ---
@@ -348,6 +348,7 @@ docs-global:
 "guide_appdev_privacy_index.md.html": "guide/appdev/privacy/index.html"
 "guide_appdev_whitelist_index.md.html": 
"guide/appdev/whitelist/index.html"
 "guide_cli_index.md.html": "guide/cli/index.html"
+"guide_cli_template.md.html": "guide/cli/template.html"
--- End diff --

Did this link exist in the past? If not, the redirect isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #458: CB-11412 template support for www folders

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/458


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #313: Support project template with aar for bui...

[HenryPing]

Github user HenryPing closed the pull request at:

https://github.com/apache/cordova-android/pull/313


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #313: Support project template with aar for bui...

[HenryPing]

GitHub user HenryPing opened a pull request:

https://github.com/apache/cordova-android/pull/313

Support project template with aar for building app with custom plugins



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adobe-marketing-cloud-mobile/aemm-android aar

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #313


commit eaef4d47a23faafa4ce4e764c0d04fa882da920c
Author: Steve Gill <stevengil...@gmail.com>
Date:   2016-01-21T00:18:52Z

Update JS snapshot to version 5.1.0 (via coho)

commit 2bf47422ce7b307bc780c09bf130554a6d988322
Author: Steve Gill <stevengil...@gmail.com>
Date:   2016-02-24T19:50:06Z

Update JS snapshot to version 5.1.1 (via coho)

commit 9aa758a1d1980c4ac0ec2b2e24cb84a20301a2c0
Author: riknoll <richard.b.kn...@gmail.com>
Date:   2016-02-03T21:12:21Z

CB-10498: Resume event should be sticky if it has a plugin result

commit bf74f97e7f54a4dbfa690a92fa657a4190ccfeae
Author: Steve Gill <stevengil...@gmail.com>
Date:   2016-02-24T19:50:06Z

Set VERSION to 5.1.1 (via coho)

commit 41ac464aca1fb8fae3871b433c1f2c24a1119b91
Author: Steve Gill <stevengil...@gmail.com>
Date:   2016-02-25T19:33:16Z

Set VERSION to 5.1.1 (via coho)

commit 765a93b3e749e1be2b72e275133c83c406c8e84e
Author: Steve Gill <stevengil...@gmail.com>
Date:   2016-02-25T19:33:16Z

Update JS snapshot to version 5.1.1 (via coho)

commit f485c1ec7ccecdb8cd61c4433982b3073588cbca
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-05-24T22:15:32Z

Set version to 0.1.0-dev

commit 14ad2966760bb5e9ec0a0c7e01e8d26d1c2c5955
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-05-24T23:03:31Z

Reverting version change

- Turns out the version is used for plugin dependency management

commit f449bd8dc1f90a74fbbfb773583975661ef69f8b
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-05-24T23:35:05Z

First crack at getting "platform add" working

- Use "cordova platform add  --verbose" in a vanilla 
cordova project
- Build doesn't work yet due to transitive dependency issues
- This is an in-progress non-working version of aemm-lib-release.aar

commit ea528d7232a95733cb4da43ba804cff270a3c37f
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-05-27T22:28:50Z

Use our custom version of cordova.js

commit 730c93abd93c6c339a2d19245148a94e438d7448
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T01:38:57Z

Resolve issues with transitive dependencies

- dependencies.gradle lists all our dependencies. We use it when creating 
the AAR and again when building the cordova project.
- update AAR
- side step project.properties issues

commit 7cc32fe72469647034944989d596fd5ee34675b0
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T18:02:44Z

Add mobile-services jar (and un-gitignore it)

commit 391a28fa0c0ad96ffa87571a7df2ed08bcfff102
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T18:25:51Z

Replace corrupt aar

commit 5d86466a1e431292eca99ae4f11dafd577c63adf
Author: mttmllns <mttml...@users.noreply.github.com>
Date:   2016-06-01T20:46:49Z

Try to replace corrupt aar again

commit e3d6119e6ea89d51958fba93c7a4f13b6bf67d28
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T20:50:27Z

Delete aars...

commit 4e1ee89b51a28425e4378581c39f2a67f48860c9
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T20:51:27Z

Corrupt aar again...

commit b4de460239ee9422ca687f2c1893c48aba8ac399
Author: mttmllns <mttml...@users.noreply.github.com>
Date:   2016-06-01T20:53:31Z

More corrupt aar tweaks...

commit 95b843df62fcf8d8d820a15003a613497f2cc862
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T21:09:12Z

Delete binaries

commit a1e259435cab507107810705d9f130e91f4f2c26
Author: Matt Mullins <mmull...@adobe.com>
Date:   2016-06-01T21:09:47Z

Hopefully last corrupt aar/jar fix

commit da75c22834a250d990592225fd2b651a77ce7ae3
Author: Henry Ping <p...@adobe.com>
Date:   2016-06-09T22:54:21Z

Added missing java/resource files from the template to the APK.

commit 3b7c98c77388d6f126588ba78aaac13c8d5e7b15
Author: Henry Ping <p...@adobe.com>
Date:   2016-06-10T21:22:20Z

Updated aemm-lib-release.aar pointing to publication with various cordova 
plugins to ease the testing.

commit 776bc9683ea584aee91ec635a60d6b5d26fd2a96
Author: Henry Ping <p...@adobe.com>
Date:   2016-06-15T23:54:54Z

- Updated aemm-lib-release.aar from 
https://git.corp.adobe.com/mmullins/viewer-android/commit/a813e58e66809983747fa2

[GitHub] cordova-lib issue #458: CB-11412 template support for www folders

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/458
  
Failures on windows?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #458: CB-11412 template support for www folders

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/458
  
## [Current coverage][cc-pull] is **80.59%**
> Merging [#458][cc-pull] into [master][cc-base-branch] will increase 
coverage by **0.01%**

```diff
@@ master   #458   diff @@
==
  Files68 68  
  Lines  5377   5380 +3   
  Methods 851851  
  Messages  0  0  
  Branches   1039   1038 -1   
==
+ Hits   4333   4336 +3   
  Misses 1044   1044  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[0c6f88d...086c991][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/0c6f88d2b136cf78ce57f323b75600a9b284e58a...086c9913682cd82d1d364621f4dfa8322985e263
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/458?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #458: CB-11412 template support for www folders

[carynbear]

GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-lib/pull/458

CB-11412 template support for www folders

@stevengill yay but also need to merge the cordova-cli!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-lib CB-11412-remove-linking

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/458.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #458


commit 086c9913682cd82d1d364621f4dfa8322985e263
Author: carynbear <caryn.t...@berkeley.edu>
Date:   2016-06-24T21:22:17Z

CB-11412 template support for www folders




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/456


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #612: CB-11412 Added docs for template use and cre...

[carynbear]

GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-docs/pull/612

CB-11412 Added docs for template use and create



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-docs CB-11412

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612


commit cbf0b722b22b8e445db1f1517de279134f6436c0
Author: carynbear <caryn.t...@berkeley.edu>
Date:   2016-06-17T17:53:55Z

CB-11412 Added docs for template use and create




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67084182
  
--- Diff: cordova-lib/src/cordova/create.js ---
@@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, 
fetchOpt) {
 www: import_from_path
 };
 
-// Keep going into child "www" folder if exists in stock app 
package.
+// Keep going into child "www" folder if exists in stock app 
package; used to find config.xml
 while (fs.existsSync(path.join(paths.www, 'www'))) {
 paths.root = paths.www;
 paths.www = path.join(paths.root, 'www');
 }
 
-// find config.xml
+// find config.xml OR get stock config.xml, used if template does 
not contain config.xml
 if (fs.existsSync(path.join(paths.root, 'config.xml'))) {
 paths.configXml = path.join(paths.root, 'config.xml');
-paths.configXmlLinkable = true;
 } else {
-try {
-paths.configXml =
-path.join(require('cordova-app-hello-world').dirname,
-'config.xml');
-} catch (e) {
-// Falling back on npm@2 path hierarchy
-// TODO: Remove fallback after cordova-app-hello-world 
release
-paths.configXml =
-path.join(__dirname, '..', '..', 'node_modules',
-'cordova-app-hello-world', 'config.xml');
-}
-}
-if (fs.existsSync(path.join(paths.root, 'merges'))) {
-paths.merges = path.join(paths.root, 'merges');
-} else {
-// No merges by default
-}
-if (fs.existsSync(path.join(paths.root, 'hooks'))) {
-paths.hooks = path.join(paths.root, 'hooks');
-paths.hooksLinkable = true;
-} else {
-try {
-paths.hooks =
-path.join(require('cordova-app-hello-world').dirname,
-'hooks');
-} catch (e) {
-// Falling back on npm@2 path hierarchy
-// TODO: Remove fallback after cordova-app-hello-world 
release
-paths.hooks =
-path.join(__dirname, '..', '..', 'node_modules',
-'cordova-app-hello-world', 'hooks');
-}
+paths.configXml = 
path.join(require('cordova-app-hello-world').dirname, 'config.xml');
 }
 
+// get stock www; used if template does not contain www
+paths.www = path.join(require('cordova-app-hello-world').dirname, 
'www');
+
+// get stock hooks; used if template does not contain hooks
+paths.hooks = 
path.join(require('cordova-app-hello-world').dirname, 'hooks');
+
+
 var dirAlreadyExisted = fs.existsSync(dir);
 if (!dirAlreadyExisted) {
 fs.mkdirSync(dir);
 }
 
-
-var tryToLink = !!cfg.lib.www.link;
-function copyOrLink(src, dst, linkable) {
-if (src) {
-if (tryToLink && linkable) {
-fs.symlinkSync(src, dst, 'dir');
-} else {
-shell.mkdir(dst);
-shell.cp('-R', path.join(src, '*'), dst);
-}
-}
-}
-
-    /*
-Copies template files, and directories into a Cordova project 
directory.
-Files, and directories not copied include: www, mergers,platforms,
-plugins, hooks, and config.xml. A template directory, and platform
-directory must be passed.
-
-    templateDir - Template directory
-projectDir - Project directory
- */
-function copyTemplateFiles(templateDir, projectDir) {
-var templateFiles; // Current file
-
-templateFiles = fs.readdirSync(templateDir);
-
-// Remove directories, and files that are automatically copied
-templateFiles = templateFiles.filter(
-function (value) {
-return !(value === 'www' || value === 'mergers' ||
-value === 'config.xml' || value === 'hooks');
-}
-);
-
    -    // Copy each template file
-for (var i = 0; i < templateFiles.length; i++)
-shell.cp('-R', path.resolve(templateDir, 
templateFiles[i]), projectDir);
-}
-
 try {
-copyOrLink(paths.w

[GitHub] cordova-lib issue #456: CB-11412 improve template implementation

[carynbear]

Github user carynbear commented on the issue:

https://github.com/apache/cordova-lib/pull/456
  
@stevengill fixed up the little details


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[carynbear]

Github user carynbear commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67077463
  
--- Diff: 
cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt
 ---
@@ -0,0 +1 @@
+blah
--- End diff --

no


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[carynbear]

Github user carynbear commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67077366
  
--- Diff: cordova-lib/spec-cordova/create.spec.js ---
@@ -121,6 +122,36 @@ describe('create end-to-end', function() {
 // expect(configXml.name()).toEqual('TestBase');
 }
 
+function checkSubDir() {
+// Check if top level dirs exist.
+var dirs = ['hooks', 'platforms', 'plugins', 'www'];
+dirs.forEach(function(d) {
+expect(path.join(project, d)).toExist();
+});
+expect(path.join(project, 'hooks', 'README.md')).toExist();
+
+//index.js and template folder should not exist (inner files 
should be copied to the project folder)
+expect(path.join(project, 'index.js')).not.toExist();
+expect(path.join(project, 'template')).not.toExist();
--- End diff --

correct


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #456: CB-11412 improve template implementation

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/456
  
LGTM!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67077184
  
--- Diff: cordova-lib/src/cordova/create.js ---
@@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, 
fetchOpt) {
 www: import_from_path
 };
 
-// Keep going into child "www" folder if exists in stock app 
package.
+// Keep going into child "www" folder if exists in stock app 
package; used to find config.xml
 while (fs.existsSync(path.join(paths.www, 'www'))) {
 paths.root = paths.www;
 paths.www = path.join(paths.root, 'www');
 }
 
-// find config.xml
+// find config.xml OR get stock config.xml, used if template does 
not contain config.xml
 if (fs.existsSync(path.join(paths.root, 'config.xml'))) {
 paths.configXml = path.join(paths.root, 'config.xml');
-paths.configXmlLinkable = true;
 } else {
-try {
-paths.configXml =
-path.join(require('cordova-app-hello-world').dirname,
-'config.xml');
-} catch (e) {
-// Falling back on npm@2 path hierarchy
-// TODO: Remove fallback after cordova-app-hello-world 
release
-paths.configXml =
-path.join(__dirname, '..', '..', 'node_modules',
-'cordova-app-hello-world', 'config.xml');
-}
-}
-if (fs.existsSync(path.join(paths.root, 'merges'))) {
-paths.merges = path.join(paths.root, 'merges');
-} else {
-// No merges by default
-}
-if (fs.existsSync(path.join(paths.root, 'hooks'))) {
-paths.hooks = path.join(paths.root, 'hooks');
-paths.hooksLinkable = true;
-} else {
-try {
-paths.hooks =
-path.join(require('cordova-app-hello-world').dirname,
-'hooks');
-} catch (e) {
-// Falling back on npm@2 path hierarchy
-// TODO: Remove fallback after cordova-app-hello-world 
release
-paths.hooks =
-path.join(__dirname, '..', '..', 'node_modules',
-'cordova-app-hello-world', 'hooks');
-}
+paths.configXml = 
path.join(require('cordova-app-hello-world').dirname, 'config.xml');
 }
 
+// get stock www; used if template does not contain www
+paths.www = path.join(require('cordova-app-hello-world').dirname, 
'www');
+
+// get stock hooks; used if template does not contain hooks
+paths.hooks = 
path.join(require('cordova-app-hello-world').dirname, 'hooks');
+
+
 var dirAlreadyExisted = fs.existsSync(dir);
 if (!dirAlreadyExisted) {
 fs.mkdirSync(dir);
 }
 
-
-var tryToLink = !!cfg.lib.www.link;
-function copyOrLink(src, dst, linkable) {
-if (src) {
-if (tryToLink && linkable) {
-fs.symlinkSync(src, dst, 'dir');
-} else {
-shell.mkdir(dst);
-shell.cp('-R', path.join(src, '*'), dst);
-}
-}
-}
-
-    /*
-Copies template files, and directories into a Cordova project 
directory.
-Files, and directories not copied include: www, mergers,platforms,
-plugins, hooks, and config.xml. A template directory, and platform
-directory must be passed.
-
-    templateDir - Template directory
-projectDir - Project directory
- */
-function copyTemplateFiles(templateDir, projectDir) {
-var templateFiles; // Current file
-
-templateFiles = fs.readdirSync(templateDir);
-
-// Remove directories, and files that are automatically copied
-templateFiles = templateFiles.filter(
-function (value) {
-return !(value === 'www' || value === 'mergers' ||
-value === 'config.xml' || value === 'hooks');
-}
-);
-
    -    // Copy each template file
-for (var i = 0; i < templateFiles.length; i++)
-shell.cp('-R', path.resolve(templateDir, 
templateFiles[i]), projectDir);
-}
-
 try {
-copyOrLink(paths.w

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67073107
  
--- Diff: 
cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt
 ---
@@ -0,0 +1 @@
+blah
--- End diff --

Did you mean to include this file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67071311
  
--- Diff: cordova-lib/spec-cordova/create.spec.js ---
@@ -121,6 +122,36 @@ describe('create end-to-end', function() {
 // expect(configXml.name()).toEqual('TestBase');
 }
 
+function checkSubDir() {
+// Check if top level dirs exist.
+var dirs = ['hooks', 'platforms', 'plugins', 'www'];
+dirs.forEach(function(d) {
+expect(path.join(project, d)).toExist();
+});
+expect(path.join(project, 'hooks', 'README.md')).toExist();
+
+//index.js and template folder should not exist (inner files 
should be copied to the project folder)
+expect(path.join(project, 'index.js')).not.toExist();
+expect(path.join(project, 'template')).not.toExist();
--- End diff --

Is this assuming the template folder is named `template`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/456#discussion_r67070160
  
--- Diff: cordova-lib/spec-cordova/create.spec.js ---
@@ -38,15 +37,17 @@ var configNormal = {
   version: 'testCordovaCreate'
 }
   }
-};
-var configSymlink = {
-  lib: {
-www: {
-  url: path.join(__dirname, 'fixtures', 'base'), // "create" 
should copy or link the www child of this dir and not the dir itself.
-  link: true
-}
-  }
-};
+};
+
+var configSubDirPkgJson = {
+lib: {
--- End diff --

nitpick: Look like lib obj here has an extra tab


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[carynbear]

GitHub user carynbear reopened a pull request:

https://github.com/apache/cordova-lib/pull/456

CB-11412 improve template implementation

Removed symlinking.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-lib CB-11412-remove-linking

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #456


commit 5139dee43071c518b9336f69df468824be0c496f
Author: carynbear <caryn.t...@berkeley.edu>
Date:   2016-06-13T21:29:06Z

CB-11412 improve template implementation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[carynbear]

Github user carynbear closed the pull request at:

https://github.com/apache/cordova-lib/pull/456


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

[carynbear]

GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-lib/pull/456

CB-11412 improve template implementation

Removed symlinking.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-lib CB-11412-remove-linking

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #456


commit 5139dee43071c518b9336f69df468824be0c496f
Author: carynbear <caryn.t...@berkeley.edu>
Date:   2016-06-13T21:29:06Z

CB-11412 improve template implementation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11345 Added '/package.json' to path of template...

[carynbear]

GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-lib/pull/446

CB-11345 Added '/package.json' to path of templatePkg



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #446


commit 4501e0b83397479a5eafd33d573acc213a174819
Author: carynbear 
Date:   2016-05-31T22:30:37Z

CB-11345 Added '/package.json' to path of templatePkg

commit f8436b0a210f4cc58e0edb2a4511711f729c3cfe
Author: carynbear 
Date:   2016-05-31T22:31:55Z

Merge branch 'master' of github.com:carynbear/cordova-lib

commit 58234c9ac29f146db47675243b0fa563fbe9fd34
Author: carynbear 
Date:   2016-05-31T22:35:52Z

CB-11345 Added '/package.json' to path of templatePkg




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219137585
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136559
  
I wonder if we should shorten the commit message bullet so that it doesn't 
wrap lines like that? Maybe we can link to 
http://cordova.apache.org/contribute/contribute_guidelines.html instead of 
giving an example (though that page doesn't have anchors for the headings)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136048
  
@nikhilkh please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Moving message in PR template ...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/215

Moving message in PR template to a comment

### Platforms affected
None!

### What does this PR do?
Change the template that I am currently filling out so that the checklist 
message is in a comment

### What testing has been done on this change?
Absolutely none.

### Checklist
Please make sure these boxes are checked before submitting the PR. This 
checklist is intended as a quick reference, for complete details please see our 
[Contributor 
Guidelines](http://cordova.apache.org/contribute/contribute_guidelines.html). 
Thanks!
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database 
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Add automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera 
template-to-comment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #215


commit 2eef09686173cb0ea6f62b29953b702769f88858
Author: Richard Knoll <richard.b.kn...@gmail.com>
Date:   2016-05-13T19:14:03Z

    Moving message in PR template to a comment




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218547172
  
Thanks for the feedback! I made some updates based on feedback. 

As far as running tests - we're automating that process using Jenkins, 
Travis CI as appropriate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218282825
  
great points @tony-- ! +1 to all of 'em


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[tony--]

Github user tony-- commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218277348
  
There are a couple places that contributor workflow is documented:
The wiki has a [contributor workflow 
page](https://wiki.apache.org/cordova/ContributorWorkflow) which also points to 
the [issue workflow page](https://wiki.apache.org/cordova/IssueWorkflow).
The docs have a [Contributor Guidelines 
page](http://cordova.apache.org/contribute/contribute_guidelines.html).

I guess the wiki pages are pretty much obsolete and the docs workflow is 
more current.

It seems like it would make sense to at least point to the docs page from 
the template, something like:
"This checklist is intended as a quick reference, for complete details 
please see our [Contributor 
Guidelines](http://cordova.apache.org/contribute/contribute_guidelines.html)".  
It would make sense to have the template checklist reflect the outline 
structure of the docs page workflow.  I guess this would mean add steps for 
getting code reviewed, running tests and commit message guideline.

If any requirements are added (e.g., PR title guideline) or changed as part 
of this, the docs should be updated to match the template checklist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218265034
  
+1 to the PR title suggestion
The icla is NOT actually required for smaller changes, and we should only 
be enforcing this for large/deep changes.  (large,small,deep are all judgement 
calls I know)
The simple act of sending a pr does technically indicate that they are 
'giving' the code to us, so we only need to protect ourselves for the larger 
changes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218253991
  
Do we need to provide a link for CCLA info just in case? Can we also 
suggest a format for PR titles? Something like:
```
[CB-12345]: Short description
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Add pull request template

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/213

Add pull request template



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera pr-template

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #213


commit 25ddde2c6ca8f7fe1a9687acaed4019bb5b3dbdd
Author: Nikhil Khandelwal <nikhi...@microsoft.com>
Date:   2016-05-10T18:35:48Z

Add pull request template




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Update to starter template

[Raymond Camden]

Big plus one to Jesse's comment. I've felt like the template is too
over complex for quite some time.

On Tue, Feb 16, 2016 at 3:21 PM, Ryan J. Salva <rsa...@microsoft.com> wrote:
> Check out the default template we use in TACO-CLI.
>
> Index.js is a lot simpler and we adopted the new Cordova typeface. If folks 
> like this template, we could issue a PR for it.
>
> rjs
>
>
> Ryan J. Salva  |  Principal PM Manager
> Visual Studio Tools for Apache Cordova
> rsa...@microsoft.com
> 425 706 5270 office
> 206 612 5079 mobile
>
> -Original Message-
> From: Parashuram N [mailto:panar...@microsoft.com]
> Sent: Tuesday, February 16, 2016 12:46 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Update to starter template
>
> I do agree that our starter app needs to change. However, we encountered this 
> when we were looking at documenting, and our object of concern was the way 
> events are bound. My suggestion would be to simply fix the event binding so 
> that the docs are less confusing.
>
> We could then look at re-writing the starter-app itself.
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Tuesday, February 16, 2016 12:28 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> Personally, I think we should rewrite/simplify that template ALOT.
> The app binding stuff is confusing to users, but not potentially any less 
> confusing with PR#15. The use of an object is the issue in my mind.
>
> Also, if this is the starting point for a new developer, they will soon 
> wonder why everything they add to the page is UPPERCASE, part of the css, but 
> potentially confusing.
>
> Ultimately, I think the whole starting point is over-organized with it's 
> multiple folders.  PR#5 is closer to the goal I think, although I would still 
> leave js in an external file, and not directly in index.html and I would 
> leave quotes on html tag attributes.
>
>
>
>
>
> @purplecabbage
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7ca55c7ca45ac24069c54708d337118610%7c72f988bf86f141af91ab2d7cd011db47%7c1=%2bCP4GywoLaqppsEXaqZxo%2br%2baBb0%2b%2babaAImEmW4ZMg%3d
>
> On Tue, Feb 16, 2016 at 11:07 AM, Parashuram N <panar...@microsoft.com>
> wrote:
>
>> Will do.
>>
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Tuesday, February 16, 2016 10:44 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Update to starter template
>>
>> LGTM
>>
>> Could you also add the keyword 'cordova:template' to package.json?
>>
>> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
>> wrote:
>>
>> > :) Sounds good
>> >
>> > Anyone else have any objections to the change ?
>> >
>> > -Original Message-
>> > From: Carlos Santana [mailto:csantan...@gmail.com]
>> > Sent: Monday, February 15, 2016 7:51 PM
>> > To: dev@cordova.apache.org
>> > Subject: Re: [DISCUSS] Update to starter template
>> >
>> > I'm always in favor of having simple answers and guidelines, and we
>> > can take this as a good convention/practice
>> >
>> > "Always bind/attach after deviceready even and you will be in a
>> > happy place"
>> >
>> > But between you and me you know that we can attach before, will
>> > leave that little secret between us :-)
>> >
>> >
>> > On Mon, Feb 15, 2016 at 10:44 PM Parashuram N
>> > <panar...@microsoft.com>
>> > wrote:
>> >
>> > > The reason to say that all events are fired after device ready is
>> > > just to make it simpler. As you say, events by webviews are indeed
>> > > fired before that, but I think it is safe to say that if we attach
>> > > listeners after deviceready, we are guaranteed to have the plugins
>> > > also initialized. This makes for a more consistent story.
>> > >
>> > >
>> > >
>> > > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
>> > >
>> > > >Why do you think that binding is required after "deviceready" ?
>> > > >
>> > > >Attaching before "deviceready" fires is still supported for
>> > > >events like resume, pause, offline, online, etc.. At least that's
>> > > >always being my impression for a long time
>> > > >
>> > > >The only thing I would thin

RE: [DISCUSS] Update to starter template

[Ryan J. Salva]

Check out the default template we use in TACO-CLI.

Index.js is a lot simpler and we adopted the new Cordova typeface. If folks 
like this template, we could issue a PR for it.

rjs


Ryan J. Salva  |  Principal PM Manager
Visual Studio Tools for Apache Cordova
rsa...@microsoft.com
425 706 5270 office
206 612 5079 mobile

-Original Message-
From: Parashuram N [mailto:panar...@microsoft.com] 
Sent: Tuesday, February 16, 2016 12:46 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Update to starter template

I do agree that our starter app needs to change. However, we encountered this 
when we were looking at documenting, and our object of concern was the way 
events are bound. My suggestion would be to simply fix the event binding so 
that the docs are less confusing. 

We could then look at re-writing the starter-app itself. 

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, February 16, 2016 12:28 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template

Personally, I think we should rewrite/simplify that template ALOT.
The app binding stuff is confusing to users, but not potentially any less 
confusing with PR#15. The use of an object is the issue in my mind.

Also, if this is the starting point for a new developer, they will soon wonder 
why everything they add to the page is UPPERCASE, part of the css, but 
potentially confusing.

Ultimately, I think the whole starting point is over-organized with it's 
multiple folders.  PR#5 is closer to the goal I think, although I would still 
leave js in an external file, and not directly in index.html and I would leave 
quotes on html tag attributes.





@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7ca55c7ca45ac24069c54708d337118610%7c72f988bf86f141af91ab2d7cd011db47%7c1=%2bCP4GywoLaqppsEXaqZxo%2br%2baBb0%2b%2babaAImEmW4ZMg%3d

On Tue, Feb 16, 2016 at 11:07 AM, Parashuram N <panar...@microsoft.com>
wrote:

> Will do.
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Tuesday, February 16, 2016 10:44 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> LGTM
>
> Could you also add the keyword 'cordova:template' to package.json?
>
> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
> wrote:
>
> > :) Sounds good
> >
> > Anyone else have any objections to the change ?
> >
> > -Original Message-
> > From: Carlos Santana [mailto:csantan...@gmail.com]
> > Sent: Monday, February 15, 2016 7:51 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Update to starter template
> >
> > I'm always in favor of having simple answers and guidelines, and we 
> > can take this as a good convention/practice
> >
> > "Always bind/attach after deviceready even and you will be in a 
> > happy place"
> >
> > But between you and me you know that we can attach before, will 
> > leave that little secret between us :-)
> >
> >
> > On Mon, Feb 15, 2016 at 10:44 PM Parashuram N 
> > <panar...@microsoft.com>
> > wrote:
> >
> > > The reason to say that all events are fired after device ready is 
> > > just to make it simpler. As you say, events by webviews are indeed 
> > > fired before that, but I think it is safe to say that if we attach 
> > > listeners after deviceready, we are guaranteed to have the plugins 
> > > also initialized. This makes for a more consistent story.
> > >
> > >
> > >
> > > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> > >
> > > >Why do you think that binding is required after "deviceready" ?
> > > >
> > > >Attaching before "deviceready" fires is still supported for 
> > > >events like resume, pause, offline, online, etc.. At least that's 
> > > >always being my impression for a long time
> > > >
> > > >The only thing I would think it could be a potential confusion 
> > > >that would benefit to attached after "deviceready" is that if 
> > > >there is an "online" or "offline" event fire by webview [1], [2] 
> > > >and not plugin those handlers
> > > will
> > > >fire but will not be from the network plugin.
> > > >
> > > >One thing I like thought about the PR is making index.js less 
> > > >verbose and simpler to follow +1
> > > >
> > > >[1]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fd
&g

Re: [DISCUSS] Update to starter template

[Jesse]

Personally, I think we should rewrite/simplify that template ALOT.
The app binding stuff is confusing to users, but not potentially any less
confusing with PR#15. The use of an object is the issue in my mind.

Also, if this is the starting point for a new developer, they will soon
wonder why everything they add to the page is UPPERCASE, part of the css,
but potentially confusing.

Ultimately, I think the whole starting point is over-organized with it's
multiple folders.  PR#5 is closer to the goal I think, although I would
still leave js in an external file, and not directly in index.html and I
would leave quotes on html tag attributes.





@purplecabbage
risingj.com

On Tue, Feb 16, 2016 at 11:07 AM, Parashuram N <panar...@microsoft.com>
wrote:

> Will do.
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Tuesday, February 16, 2016 10:44 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> LGTM
>
> Could you also add the keyword 'cordova:template' to package.json?
>
> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
> wrote:
>
> > :) Sounds good
> >
> > Anyone else have any objections to the change ?
> >
> > -Original Message-
> > From: Carlos Santana [mailto:csantan...@gmail.com]
> > Sent: Monday, February 15, 2016 7:51 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Update to starter template
> >
> > I'm always in favor of having simple answers and guidelines, and we
> > can take this as a good convention/practice
> >
> > "Always bind/attach after deviceready even and you will be in a happy
> > place"
> >
> > But between you and me you know that we can attach before, will leave
> > that little secret between us :-)
> >
> >
> > On Mon, Feb 15, 2016 at 10:44 PM Parashuram N <panar...@microsoft.com>
> > wrote:
> >
> > > The reason to say that all events are fired after device ready is
> > > just to make it simpler. As you say, events by webviews are indeed
> > > fired before that, but I think it is safe to say that if we attach
> > > listeners after deviceready, we are guaranteed to have the plugins
> > > also initialized. This makes for a more consistent story.
> > >
> > >
> > >
> > > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> > >
> > > >Why do you think that binding is required after "deviceready" ?
> > > >
> > > >Attaching before "deviceready" fires is still supported for events
> > > >like resume, pause, offline, online, etc.. At least that's always
> > > >being my impression for a long time
> > > >
> > > >The only thing I would think it could be a potential confusion that
> > > >would benefit to attached after "deviceready" is that if there is
> > > >an "online" or "offline" event fire by webview [1], [2] and not
> > > >plugin those handlers
> > > will
> > > >fire but will not be from the network plugin.
> > > >
> > > >One thing I like thought about the PR is making index.js less
> > > >verbose and simpler to follow +1
> > > >
> > > >[1]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdev
> > > el
> > > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c0
> > > 1%
> > > 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f9
> > > 88
> > > bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmu
> > > lm
> > > bzlAeIogT9H1b4ic%3d
> > > >[2]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdev
> > > el
> > > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01
> > > %7
> > > cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f98
> > > 8b
> > > f86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7Cd
> > > IA
> > > XaRnZbqR4%3d
> > > >
> > > >
> > > >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N
> > > ><panar...@microsoft.com>
> > > >wrote:
> > > >
> > > >> While working on documentation about events for Cordova, we
> > > >> noticed that in our Cordova starter template [1] seems to suggest
> > > >> that we bind events like “offline” and “online” alongside the
> “deviceready”
> > > >

RE: [DISCUSS] Update to starter template

[Parashuram N]

I do agree that our starter app needs to change. However, we encountered this 
when we were looking at documenting, and our object of concern was the way 
events are bound. My suggestion would be to simply fix the event binding so 
that the docs are less confusing. 

We could then look at re-writing the starter-app itself. 

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Tuesday, February 16, 2016 12:28 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template

Personally, I think we should rewrite/simplify that template ALOT.
The app binding stuff is confusing to users, but not potentially any less 
confusing with PR#15. The use of an object is the issue in my mind.

Also, if this is the starting point for a new developer, they will soon wonder 
why everything they add to the page is UPPERCASE, part of the css, but 
potentially confusing.

Ultimately, I think the whole starting point is over-organized with it's 
multiple folders.  PR#5 is closer to the goal I think, although I would still 
leave js in an external file, and not directly in index.html and I would leave 
quotes on html tag attributes.





@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7ca55c7ca45ac24069c54708d337118610%7c72f988bf86f141af91ab2d7cd011db47%7c1=%2bCP4GywoLaqppsEXaqZxo%2br%2baBb0%2b%2babaAImEmW4ZMg%3d

On Tue, Feb 16, 2016 at 11:07 AM, Parashuram N <panar...@microsoft.com>
wrote:

> Will do.
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Tuesday, February 16, 2016 10:44 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> LGTM
>
> Could you also add the keyword 'cordova:template' to package.json?
>
> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
> wrote:
>
> > :) Sounds good
> >
> > Anyone else have any objections to the change ?
> >
> > -Original Message-
> > From: Carlos Santana [mailto:csantan...@gmail.com]
> > Sent: Monday, February 15, 2016 7:51 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Update to starter template
> >
> > I'm always in favor of having simple answers and guidelines, and we 
> > can take this as a good convention/practice
> >
> > "Always bind/attach after deviceready even and you will be in a 
> > happy place"
> >
> > But between you and me you know that we can attach before, will 
> > leave that little secret between us :-)
> >
> >
> > On Mon, Feb 15, 2016 at 10:44 PM Parashuram N 
> > <panar...@microsoft.com>
> > wrote:
> >
> > > The reason to say that all events are fired after device ready is 
> > > just to make it simpler. As you say, events by webviews are indeed 
> > > fired before that, but I think it is safe to say that if we attach 
> > > listeners after deviceready, we are guaranteed to have the plugins 
> > > also initialized. This makes for a more consistent story.
> > >
> > >
> > >
> > > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> > >
> > > >Why do you think that binding is required after "deviceready" ?
> > > >
> > > >Attaching before "deviceready" fires is still supported for 
> > > >events like resume, pause, offline, online, etc.. At least that's 
> > > >always being my impression for a long time
> > > >
> > > >The only thing I would think it could be a potential confusion 
> > > >that would benefit to attached after "deviceready" is that if 
> > > >there is an "online" or "offline" event fire by webview [1], [2] 
> > > >and not plugin those handlers
> > > will
> > > >fire but will not be from the network plugin.
> > > >
> > > >One thing I like thought about the PR is making index.js less 
> > > >verbose and simpler to follow +1
> > > >
> > > >[1]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fd
> > > ev
> > > el
> > > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7
> > > c0
> > > 1%
> > > 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72
> > > f9
> > > 88
> > > bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYn
> > > mu
> > > lm
> > > bzlAeIogT9H1b4ic%3d
> > > >[2]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fd
> > &g

Re: [DISCUSS] Update to starter template

[Tommy Williams]

+1 for the template change

LGTM

This conversation made it sound like this was going to suggest binding 
offline/online etc in deviceready. Glad to see that's not the case in the 
template at least.

I would discourage teaching people that they need to wait for Cordova’s 
deviceready before binding vanilla JavaScript events.

- tommy




> On 17 Feb 2016, at 6:07 AM, Parashuram N <panar...@microsoft.com> wrote:
> 
> Will do.
> 
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Tuesday, February 16, 2016 10:44 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
> 
> LGTM
> 
> Could you also add the keyword 'cordova:template' to package.json?
> 
> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
> wrote:
> 
>> :) Sounds good
>> 
>> Anyone else have any objections to the change ?
>> 
>> -Original Message-
>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> Sent: Monday, February 15, 2016 7:51 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Update to starter template
>> 
>> I'm always in favor of having simple answers and guidelines, and we
>> can take this as a good convention/practice
>> 
>> "Always bind/attach after deviceready even and you will be in a happy
>> place"
>> 
>> But between you and me you know that we can attach before, will leave
>> that little secret between us :-)
>> 
>> 
>> On Mon, Feb 15, 2016 at 10:44 PM Parashuram N <panar...@microsoft.com>
>> wrote:
>> 
>>> The reason to say that all events are fired after device ready is
>>> just to make it simpler. As you say, events by webviews are indeed
>>> fired before that, but I think it is safe to say that if we attach
>>> listeners after deviceready, we are guaranteed to have the plugins
>>> also initialized. This makes for a more consistent story.
>>> 
>>> 
>>> 
>>> On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
>>> 
>>>> Why do you think that binding is required after "deviceready" ?
>>>> 
>>>> Attaching before "deviceready" fires is still supported for events
>>>> like resume, pause, offline, online, etc.. At least that's always
>>>> being my impression for a long time
>>>> 
>>>> The only thing I would think it could be a potential confusion that
>>>> would benefit to attached after "deviceready" is that if there is
>>>> an "online" or "offline" event fire by webview [1], [2] and not
>>>> plugin those handlers
>>> will
>>>> fire but will not be from the network plugin.
>>>> 
>>>> One thing I like thought about the PR is making index.js less
>>>> verbose and simpler to follow +1
>>>> 
>>>> [1]:
>>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdev
>>> el
>>> oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c0
>>> 1%
>>> 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f9
>>> 88
>>> bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmu
>>> lm
>>> bzlAeIogT9H1b4ic%3d
>>>> [2]:
>>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdev
>>> el
>>> oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01
>>> %7
>>> cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f98
>>> 8b
>>> f86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7Cd
>>> IA
>>> XaRnZbqR4%3d
>>>> 
>>>> 
>>>> On Mon, Feb 15, 2016 at 12:36 PM Parashuram N
>>>> <panar...@microsoft.com>
>>>> wrote:
>>>> 
>>>>> While working on documentation about events for Cordova, we
>>>>> noticed that in our Cordova starter template [1] seems to suggest
>>>>> that we bind events like “offline” and “online” alongside the 
>>>>> “deviceready”
>>>>> event. As I understand, the “offline” and “online” events are
>>>>> something that the NetworkInformation plugin provides, and thus
>>>>> should only be bound after cordova-js has been initialized.
>>>>> Here [2] is a change where we only bind “deviceready” first, and
>>>>> then recommend binding all events when the handler for
>

RE: [DISCUSS] Update to starter template

[Parashuram N]

Will do. 

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Tuesday, February 16, 2016 10:44 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template

LGTM

Could you also add the keyword 'cordova:template' to package.json?

On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
wrote:

> :) Sounds good
>
> Anyone else have any objections to the change ?
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Monday, February 15, 2016 7:51 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> I'm always in favor of having simple answers and guidelines, and we 
> can take this as a good convention/practice
>
> "Always bind/attach after deviceready even and you will be in a happy 
> place"
>
> But between you and me you know that we can attach before, will leave 
> that little secret between us :-)
>
>
> On Mon, Feb 15, 2016 at 10:44 PM Parashuram N <panar...@microsoft.com>
> wrote:
>
> > The reason to say that all events are fired after device ready is 
> > just to make it simpler. As you say, events by webviews are indeed 
> > fired before that, but I think it is safe to say that if we attach 
> > listeners after deviceready, we are guaranteed to have the plugins 
> > also initialized. This makes for a more consistent story.
> >
> >
> >
> > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> >
> > >Why do you think that binding is required after "deviceready" ?
> > >
> > >Attaching before "deviceready" fires is still supported for events 
> > >like resume, pause, offline, online, etc.. At least that's always 
> > >being my impression for a long time
> > >
> > >The only thing I would think it could be a potential confusion that 
> > >would benefit to attached after "deviceready" is that if there is 
> > >an "online" or "offline" event fire by webview [1], [2] and not 
> > >plugin those handlers
> > will
> > >fire but will not be from the network plugin.
> > >
> > >One thing I like thought about the PR is making index.js less 
> > >verbose and simpler to follow +1
> > >
> > >[1]:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdev
> > el 
> > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c0
> > 1%
> > 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f9
> > 88 
> > bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmu
> > lm
> > bzlAeIogT9H1b4ic%3d
> > >[2]:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdev
> > el
> > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01
> > %7 
> > cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f98
> > 8b 
> > f86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7Cd
> > IA
> > XaRnZbqR4%3d
> > >
> > >
> > >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N 
> > ><panar...@microsoft.com>
> > >wrote:
> > >
> > >> While working on documentation about events for Cordova, we 
> > >> noticed that in our Cordova starter template [1] seems to suggest 
> > >> that we bind events like “offline” and “online” alongside the 
> > >> “deviceready”
> > >> event. As I understand, the “offline” and “online” events are 
> > >> something that the NetworkInformation plugin provides, and thus 
> > >> should only be bound after cordova-js has been initialized.
> > >> Here [2] is a change where we only bind “deviceready” first, and 
> > >> then recommend binding all events when the handler for 
> > >> “deviceready” is
> > called.
> > >> Do you folks think this is a good change ? Here [3] is the JIRA 
> > >> for
> it.
> > >>
> > >>
> > >> [1] Cordova Started template -
> > >> https://github.com/apache/cordova-app-hello-world/
> > >> [2] Pull request with change to starter template - 
> > >> https://github.com/apache/cordova-app-hello-world/pull/15/files
> > >> [3] JIRA for PR with change to starter template -
> > >>
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ue 
> > s.apache.org%2fjira%2fbrowse%2fCB-10522=01%7c01%7cpanarasi%40mi
> > cr
> > osoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2
> > d7 
> > cd011db47%7c1=66cC5xZm3Rh6xzxjqV48u%2bdrZSJZba1g%2f%2beFnwL7aG
> > k%
> > 3d
> > >>
> > >>
> > >>
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Update to starter template

[Steven Gill]

LGTM

Could you also add the keyword 'cordova:template' to package.json?

On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com>
wrote:

> :) Sounds good
>
> Anyone else have any objections to the change ?
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Monday, February 15, 2016 7:51 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> I'm always in favor of having simple answers and guidelines, and we can
> take this as a good convention/practice
>
> "Always bind/attach after deviceready even and you will be in a happy
> place"
>
> But between you and me you know that we can attach before, will leave that
> little secret between us :-)
>
>
> On Mon, Feb 15, 2016 at 10:44 PM Parashuram N <panar...@microsoft.com>
> wrote:
>
> > The reason to say that all events are fired after device ready is just
> > to make it simpler. As you say, events by webviews are indeed fired
> > before that, but I think it is safe to say that if we attach listeners
> > after deviceready, we are guaranteed to have the plugins also
> > initialized. This makes for a more consistent story.
> >
> >
> >
> > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
> >
> > >Why do you think that binding is required after "deviceready" ?
> > >
> > >Attaching before "deviceready" fires is still supported for events
> > >like resume, pause, offline, online, etc.. At least that's always
> > >being my impression for a long time
> > >
> > >The only thing I would think it could be a potential confusion that
> > >would benefit to attached after "deviceready" is that if there is an
> > >"online" or "offline" event fire by webview [1], [2] and not plugin
> > >those handlers
> > will
> > >fire but will not be from the network plugin.
> > >
> > >One thing I like thought about the PR is making index.js less verbose
> > >and simpler to follow +1
> > >
> > >[1]:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdevel
> > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c01%
> > 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988
> > bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmulm
> > bzlAeIogT9H1b4ic%3d
> > >[2]:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdevel
> > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01%7
> > cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988b
> > f86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7CdIA
> > XaRnZbqR4%3d
> > >
> > >
> > >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N
> > ><panar...@microsoft.com>
> > >wrote:
> > >
> > >> While working on documentation about events for Cordova, we noticed
> > >> that in our Cordova starter template [1] seems to suggest that we
> > >> bind events like “offline” and “online” alongside the “deviceready”
> > >> event. As I understand, the “offline” and “online” events are
> > >> something that the NetworkInformation plugin provides, and thus
> > >> should only be bound after cordova-js has been initialized.
> > >> Here [2] is a change where we only bind “deviceready” first, and
> > >> then recommend binding all events when the handler for
> > >> “deviceready” is
> > called.
> > >> Do you folks think this is a good change ? Here [3] is the JIRA for
> it.
> > >>
> > >>
> > >> [1] Cordova Started template -
> > >> https://github.com/apache/cordova-app-hello-world/
> > >> [2] Pull request with change to starter template -
> > >> https://github.com/apache/cordova-app-hello-world/pull/15/files
> > >> [3] JIRA for PR with change to starter template -
> > >>
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fCB-10522=01%7c01%7cpanarasi%40micr
> > osoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7
> > cd011db47%7c1=66cC5xZm3Rh6xzxjqV48u%2bdrZSJZba1g%2f%2beFnwL7aGk%
> > 3d
> > >>
> > >>
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>

RE: [DISCUSS] Update to starter template

[Parashuram N]

:) Sounds good

Anyone else have any objections to the change ? 

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Monday, February 15, 2016 7:51 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template

I'm always in favor of having simple answers and guidelines, and we can take 
this as a good convention/practice

"Always bind/attach after deviceready even and you will be in a happy place"

But between you and me you know that we can attach before, will leave that 
little secret between us :-)


On Mon, Feb 15, 2016 at 10:44 PM Parashuram N <panar...@microsoft.com>
wrote:

> The reason to say that all events are fired after device ready is just 
> to make it simpler. As you say, events by webviews are indeed fired 
> before that, but I think it is safe to say that if we attach listeners 
> after deviceready, we are guaranteed to have the plugins also 
> initialized. This makes for a more consistent story.
>
>
>
> On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
>
> >Why do you think that binding is required after "deviceready" ?
> >
> >Attaching before "deviceready" fires is still supported for events 
> >like resume, pause, offline, online, etc.. At least that's always 
> >being my impression for a long time
> >
> >The only thing I would think it could be a potential confusion that 
> >would benefit to attached after "deviceready" is that if there is an 
> >"online" or "offline" event fire by webview [1], [2] and not plugin 
> >those handlers
> will
> >fire but will not be from the network plugin.
> >
> >One thing I like thought about the PR is making index.js less verbose 
> >and simpler to follow +1
> >
> >[1]:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdevel
> oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c01%
> 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988
> bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmulm
> bzlAeIogT9H1b4ic%3d
> >[2]:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdevel
> oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01%7
> cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988b
> f86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7CdIA
> XaRnZbqR4%3d
> >
> >
> >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N 
> ><panar...@microsoft.com>
> >wrote:
> >
> >> While working on documentation about events for Cordova, we noticed 
> >> that in our Cordova starter template [1] seems to suggest that we 
> >> bind events like “offline” and “online” alongside the “deviceready” 
> >> event. As I understand, the “offline” and “online” events are 
> >> something that the NetworkInformation plugin provides, and thus 
> >> should only be bound after cordova-js has been initialized.
> >> Here [2] is a change where we only bind “deviceready” first, and 
> >> then recommend binding all events when the handler for 
> >> “deviceready” is
> called.
> >> Do you folks think this is a good change ? Here [3] is the JIRA for it.
> >>
> >>
> >> [1] Cordova Started template -
> >> https://github.com/apache/cordova-app-hello-world/
> >> [2] Pull request with change to starter template - 
> >> https://github.com/apache/cordova-app-hello-world/pull/15/files
> >> [3] JIRA for PR with change to starter template -
> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10522=01%7c01%7cpanarasi%40micr
> osoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7
> cd011db47%7c1=66cC5xZm3Rh6xzxjqV48u%2bdrZSJZba1g%2f%2beFnwL7aGk%
> 3d
> >>
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

Re: [DISCUSS] Update to starter template

[Carlos Santana]

I'm always in favor of having simple answers and guidelines, and we can
take this as a good convention/practice

"Always bind/attach after deviceready even and you will be in a happy place"

But between you and me you know that we can attach before, will leave that
little secret between us :-)


On Mon, Feb 15, 2016 at 10:44 PM Parashuram N <panar...@microsoft.com>
wrote:

> The reason to say that all events are fired after device ready is just to
> make it simpler. As you say, events by webviews are indeed fired before
> that, but I think it is safe to say that if we attach listeners after
> deviceready, we are guaranteed to have the plugins also initialized. This
> makes for a more consistent story.
>
>
>
> On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:
>
> >Why do you think that binding is required after "deviceready" ?
> >
> >Attaching before "deviceready" fires is still supported for events like
> >resume, pause, offline, online, etc.. At least that's always being my
> >impression for a long time
> >
> >The only thing I would think it could be a potential confusion that would
> >benefit to attached after "deviceready" is that if there is an "online" or
> >"offline" event fire by webview [1], [2] and not plugin those handlers
> will
> >fire but will not be from the network plugin.
> >
> >One thing I like thought about the PR is making index.js less verbose and
> >simpler to follow +1
> >
> >[1]:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdeveloper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmulmbzlAeIogT9H1b4ic%3d
> >[2]:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdeveloper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7CdIAXaRnZbqR4%3d
> >
> >
> >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N <panar...@microsoft.com>
> >wrote:
> >
> >> While working on documentation about events for Cordova, we noticed that
> >> in our Cordova starter template [1] seems to suggest that we bind events
> >> like “offline” and “online” alongside the “deviceready” event. As I
> >> understand, the “offline” and “online” events are something that the
> >> NetworkInformation plugin provides, and thus should only be bound after
> >> cordova-js has been initialized.
> >> Here [2] is a change where we only bind “deviceready” first, and then
> >> recommend binding all events when the handler for “deviceready” is
> called.
> >> Do you folks think this is a good change ? Here [3] is the JIRA for it.
> >>
> >>
> >> [1] Cordova Started template -
> >> https://github.com/apache/cordova-app-hello-world/
> >> [2] Pull request with change to starter template -
> >> https://github.com/apache/cordova-app-hello-world/pull/15/files
> >> [3] JIRA for PR with change to starter template -
> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10522=01%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=66cC5xZm3Rh6xzxjqV48u%2bdrZSJZba1g%2f%2beFnwL7aGk%3d
> >>
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

Re: [DISCUSS] Update to starter template

[Parashuram N]

The reason to say that all events are fired after device ready is just to make 
it simpler. As you say, events by webviews are indeed fired before that, but I 
think it is safe to say that if we attach listeners after deviceready, we are 
guaranteed to have the plugins also initialized. This makes for a more 
consistent story. 



On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote:

>Why do you think that binding is required after "deviceready" ?
>
>Attaching before "deviceready" fires is still supported for events like
>resume, pause, offline, online, etc.. At least that's always being my
>impression for a long time
>
>The only thing I would think it could be a potential confusion that would
>benefit to attached after "deviceready" is that if there is an "online" or
>"offline" event fire by webview [1], [2] and not plugin those handlers will
>fire but will not be from the network plugin.
>
>One thing I like thought about the PR is making index.js less verbose and
>simpler to follow +1
>
>[1]: 
>https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdeveloper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline=01%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=8%2b4NzK8zAB%2ffqryeM%2fN9XYnmulmbzlAeIogT9H1b4ic%3d
>[2]: 
>https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdeveloper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline=01%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7CdIAXaRnZbqR4%3d
>
>
>On Mon, Feb 15, 2016 at 12:36 PM Parashuram N <panar...@microsoft.com>
>wrote:
>
>> While working on documentation about events for Cordova, we noticed that
>> in our Cordova starter template [1] seems to suggest that we bind events
>> like “offline” and “online” alongside the “deviceready” event. As I
>> understand, the “offline” and “online” events are something that the
>> NetworkInformation plugin provides, and thus should only be bound after
>> cordova-js has been initialized.
>> Here [2] is a change where we only bind “deviceready” first, and then
>> recommend binding all events when the handler for “deviceready” is called.
>> Do you folks think this is a good change ? Here [3] is the JIRA for it.
>>
>>
>> [1] Cordova Started template -
>> https://github.com/apache/cordova-app-hello-world/
>> [2] Pull request with change to starter template -
>> https://github.com/apache/cordova-app-hello-world/pull/15/files
>> [3] JIRA for PR with change to starter template -
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10522=01%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=66cC5xZm3Rh6xzxjqV48u%2bdrZSJZba1g%2f%2beFnwL7aGk%3d
>>
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Update to starter template

[Carlos Santana]

Why do you think that binding is required after "deviceready" ?

Attaching before "deviceready" fires is still supported for events like
resume, pause, offline, online, etc.. At least that's always being my
impression for a long time

The only thing I would think it could be a potential confusion that would
benefit to attached after "deviceready" is that if there is an "online" or
"offline" event fire by webview [1], [2] and not plugin those handlers will
fire but will not be from the network plugin.

One thing I like thought about the PR is making index.js less verbose and
simpler to follow +1

[1]: https://developer.mozilla.org/en-US/docs/Web/Events/offline
[2]: https://developer.mozilla.org/en-US/docs/Web/Events/online


On Mon, Feb 15, 2016 at 12:36 PM Parashuram N <panar...@microsoft.com>
wrote:

> While working on documentation about events for Cordova, we noticed that
> in our Cordova starter template [1] seems to suggest that we bind events
> like “offline” and “online” alongside the “deviceready” event. As I
> understand, the “offline” and “online” events are something that the
> NetworkInformation plugin provides, and thus should only be bound after
> cordova-js has been initialized.
> Here [2] is a change where we only bind “deviceready” first, and then
> recommend binding all events when the handler for “deviceready” is called.
> Do you folks think this is a good change ? Here [3] is the JIRA for it.
>
>
> [1] Cordova Started template -
> https://github.com/apache/cordova-app-hello-world/
> [2] Pull request with change to starter template -
> https://github.com/apache/cordova-app-hello-world/pull/15/files
> [3] JIRA for PR with change to starter template -
> https://issues.apache.org/jira/browse/CB-10522
>
>
>

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/147


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/147#issuecomment-178816734
  
+1
Windows 8.0 has been deprecated since Apr 13, 2015, let's cleanup so we can 
provide better focus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723
  
Reviewed changes, :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[dubeejw]

GitHub user dubeejw opened a pull request:

https://github.com/apache/cordova-lib/pull/372

CB-10499 - --template should pull the latest template from NPM when

version isn't specified

- Pull the latest template if no version is specified

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #372


commit c181d428c22983b8641e61f62bc2444924ec2c58
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2016-02-01T20:31:26Z

CB-10499 - --template should pull the latest template from NPM when
version isn't specified

- Pull the latest template if no version is specified




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/372


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[csantanapr]

GitHub user csantanapr opened a pull request:

https://github.com/apache/cordova-lib/pull/373

CB-10499 - --template should pull the latest template from NPM when

version isn't specified

- Pull the latest template if no version is specified
- Rename NPM to npm

rename github to git

This close #372

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/csantanapr/cordova-lib pr-372

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #373


commit a65333cfe490288dc5bc0ce992c88d4764872a94
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2016-02-01T20:31:26Z

CB-10499 - --template should pull the latest template from NPM when
version isn't specified

- Pull the latest template if no version is specified
- Rename NPM to npm

rename github to git

This close #372




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738
  
For what version is this for? cordova-windows@5.0.0 ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-windows/pull/147#issuecomment-178059859
  
This will be a breaking change, so yes, probably for cordova-windows@5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/147

CB-10480 Remove Windows 8 template from cordova-windows

[Jira issue](https://issues.apache.org/jira/browse/CB-10480)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10480

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 8fdd8d01b89aac98a583f58a00051c0ce6fadb38
Author: daserge <v-ses...@microsoft.com>
Date:   2016-01-29T16:52:59Z

CB-10480 Remove Windows 8 template from cordova-windows

commit 426ac4abb5abea3347dd722f32a47f9e60bec822
Author: daserge <v-ses...@microsoft.com>
Date:   2016-01-29T18:36:07Z

CB-10480 Remove Windows 8 template from cordova-windows

Updated the tests

commit c1cfa3b5a92d6f64d9257a82a2f51a80ee7ebcb4
Author: daserge <v-ses...@microsoft.com>
Date:   2016-02-01T15:41:33Z

CB-10480 Remove Windows 8 template from cordova-windows

Adds a friendly error message for windows-target-version = 8.0
Updated check_reqs
Updated the docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/432


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9964 - Add --template to create comma...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/339


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9964 Make --copy-from use --template ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/227


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/432#issuecomment-161821043
  
Was this PR stale? Is the change invalid?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

[dubeejw]

GitHub user dubeejw opened a pull request:

https://github.com/apache/cordova-docs/pull/432

CB-9964 - Add --template to online documentation

- Information about --template is now in the CLI documentation

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-docs CB-9964

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit bbb475bcec157e153b55a318811cce4c10211f26
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2015-11-30T21:25:21Z

CB-9964 - Add --template to online documentation

- Information about --template is now in the CLI documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9964 Make --copy-from use --template ...

[dubeejw]

GitHub user dubeejw opened a pull request:

https://github.com/apache/cordova-cli/pull/227

CB-9964 Make --copy-from use --template behavior

- Arguments are now handled for the --template parameter
- --copy-from now uses the same behavior as --template


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-cli master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #227


commit a885c55118b7637cb483da5b6d32ef85d4949a18
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2015-11-05T20:55:14Z

CB-9964 Added --template support to Cordova Create

- Templates can now be added to a project from GitHub, and NPM

commit 2b0c16d35077126397d0d9e9f3814bfb3b499f51
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2015-11-05T21:01:16Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-cli

commit 0f6fa3808297122013085adb56b363031a9e9bf2
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2015-11-16T03:25:37Z

CB-9964 Add --template to help, and remove --copy-from
    
- --template has been add to the help file
- --copy-from has been removed from the help file

commit 5a25f7f3a6a9434664ce9359ce6660b0633c2853
Author: dubeejw <jwdu...@us.ibm.com>
Date:   2015-11-16T03:37:31Z

CB-9964 Deprecate --copy-from

- Deprecated --copy-from in 'create help'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [iOS] Remove non-CLI template

[Andrew Grieve]

I think the difference between the two templates is that the CLI template
adds extra navigator entries to point to ../../www and ../../config.xml.

Might still be worth not keeping two templates though, and just have these
entries be red for non-CLI projects (doesn't break builds).

On Tue, Jun 16, 2015 at 2:18 PM, Shazron shaz...@gmail.com wrote:

 I propose to remove the non-CLI template starting in cordova-ios 4.0.0.

 It was originally used to easily test your own plugins, but now we have the
 alternative using the CLI:

 cordova plugin add --link path/to/your/plugin

[iOS] Remove non-CLI template

[Shazron]

I propose to remove the non-CLI template starting in cordova-ios 4.0.0.

It was originally used to easily test your own plugins, but now we have the
alternative using the CLI:

cordova plugin add --link path/to/your/plugin

[GitHub] cordova-js pull request: CB-9016: Added template-packaged WinJS re...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/111


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request: CB-9016: Added template-packaged WinJS re...

[robpaveza]

GitHub user robpaveza opened a pull request:

https://github.com/apache/cordova-js/pull/111

CB-9016: Added template-packaged WinJS reference for Windows 10 support.

Windows 10 no longer has a Framework Reference for WinJS, instead we 
include it in the project template (since we guarantee that at least WinJS 
Promises and ALM events will be present).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-js CB-9016

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 900772c740c6acd4b9205492caac5f9584928fa4
Author: Rob Paveza rob.pav...@microsoft.com
Date:   2015-05-12T18:34:56Z

Added template-packaged WinJS reference for Windows 10 support.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78153037
  
I put the change behind a flag called `--copywww`. By default `www` is 
linked, and if the flag is passed, then it is copied instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78015632
  
The idea LGTM, but i would prefer not to remove linking of www at all, just 
hide it behind a corresponding option (`--linkwww` for example). There is 
already the same login for plugins and platforms 
[here](https://github.com/MSOpenTech/cordova-mobile-spec/blob/copy-on-create/createmobilespec/createmobilespec.js#L122).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Remove updating www template step

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org