Re: [dba-dev] Need i-team for specification [was [dba-dev] New Filter Dialog]
Hi Karl, just wanted to let you know that I think your effort is great, hope you find a developer who can help you out. I'm totally packed with other stuff, so I cannot be the one, sorry. [1] http://dba.openoffice.org/development/projects.html#new_filter @FS: there is syntax highlighting still on that page, would you remove it, please? Best regards Max - To unsubscribe, e-mail: dev-unsubscr...@dba.openoffice.org For additional commands, e-mail: dev-h...@dba.openoffice.org
Re: [dba-dev] improved SQL view
Hi, Just saw that CWS sqlsyntaxhighlighting is nominated - congratulations, and thanks for doing this implementation! :-) Bettina told me that she will be working on the colors this week. hmmm do we still have light green on white? I know that she lessened the red and green color, but not sure to what excactly and I did not test it. If you do not agree on the colors, please talk to her. If new colors come up in the future, I am happy to integrate them, of course. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, I took the liberty to give the tokens their very own color. great idea, nice working together with smart people ;-) I still think that SQLSTRING needs a change, this is pretty difficult to read now that I see it, +1 Anyway, will talk to Bettina about this. great Best, max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, You should submit an issue for this, just to ensure it doesn't get lost. I suggest the 3.x target. If you don't really feel like coding in Base fyi, issue 96396, target 3.1 assigned to myself ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, It seems it is finished? So did you already pass the CWS to Mechtilde, or are there still fixes needed? yes, rebase is finsished and Mechtilde is doing manual test, while André Schnabel is doing the automatic tests on Win/Linux. Bettina told me that she will be working on the colors this week. Best regards Max PS: mechtilde agreed to postpone the Mac issue to a follow up fix in a next CWS - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, Sounds like a task which we could postpone, IMO, provided the CWS'es QA rep agrees. Which brings me to: Our QA here in Hamburg is busy with a lot of other CWS' which are targeted for 3.1, too. Mechtilde (German QA-Project) will do the QAing and aggreed to postpone the mac issue. Other than that: Did you have a chance to talk about the default colors with Bettina? I still think light green on white is ... eye-hurting :) yes, she told me to have a look rather soon and also align with BASIC IDE as well as report designer colors Thanks for the code review, I fixed it all except the last one, as you pointed out correctly ;-) Rebase is running right now. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, where pretty much finished means [X] I think it's finished, and I just don't dare to say. [ ] There are still some minor open issues, which I'm not sure I should fix in this CWS. [ ] other: I darkly remember having seen the Basic IDE code years ago, do I remember correctly that highlighting is done on a per-line basis, so the problem here is that we always generate one-line SQL statements? Not really, I think. Once you edit a line in the IDE, a broadcast including the current line happens and notifyChange is called, which calculates the new portions and should return a range of changed line, which are then reformatted based on the tokenizer. But I now saw that this does not actually seem to work, but you get a manual notification for every changed line in the editor, this one is then syntax highlighted. In the SQL editor, we just reformat the whole thing. I leave it as it is now, as noone seems to be disturbed. If this should be an issue, we should do some current cursor magic to reformat a smaller range. where pretty much finished means [X] I think it's finished, and I just don't dare to say ;-) So yes, finding a QA person and getting it in for 3.1 would be great. Best regards Max PS: Bettia and I will have a look at the standard colors tomorrow in Bejing - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, [X] I think it's finished, and I just don't dare to say ;-) ouch, now I remember again the last remaining issue. According to [EMAIL PROTECTED], bracket matching does not work on Mac, no idea why. Would you have access to one and could debug there? Otherwise, I get mine in 1 - 3 weeks and could debug it then, but then we might miss feature freeze, which would be really unfortunate. (silent thinking: or maybe get it QA'ed anyway and we fix it afterwards, I guess there is still lots of time after feature freeze) However, you should rebase your CWS to m35, since m34 saw some big changes in dbaccess. I am not sure they would conflict, but we should be sure Yup, will do right after Peking. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, here is a new testable version of the cws sqlsyntaxhighlighting[1]. This was the idea of the new control, so actually this new thing could be used as well in the BASIC IDE and we could throw out a lot of stuff including all the manual EditView/EditEngine code...(if the BASIC IDE does not have a lot of functionality on top of these, which I don't see ,and the maintainer is not too scared to use my code (never change a running IDE...)) - changing the colors is not propagated to currently-open SQL views, you need to close and re-open them fixed in cws - In Tools/Options/Appearance, Strings are listed with color Automatic = White, but in the SQL view, they're light green (which I continue to consider an unfortunate default, given the default background color is white) fixed in cws In general, it's looking better and better. Do you have a list of open issues, or something like that, which shows how far you're from finishing it? based on feedback on [EMAIL PROTECTED], I now added support for SQL comments (--) as well and I consider the whole cws pretty much finished now. One thing I am not sure about is flickering, as always the whole text is syntax highlighted, but up to now, noone complained ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Drew, So - just speaking for myself...thank you for the time and effort you are putting in to it. thanks a lot for your nice words, really appreciated :-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] improved SQL view
Hi, here is a new testable version of the cws sqlsyntaxhighlighting[1]. In addition to the last snapshot, which included the following features: - syntax highlighting in SQL view - bracket matching - font and font size configurable this snapshot now support these as well: - syntax highlighting and bracket matching in Tools-SQL as well (sometimes I really love programming ;-)) - configurable colors in tools-options-appearance - parameters are highlighted as well Best regards Max [1] http://termite.go-oo.org/install_sets/Solaris-Intel-232-sqlsyntaxhighlighting-install_set.zip http://termite.go-oo.org/install_sets/Win-XP2-236-sqlsyntaxhighlighting-install_set.zip http://termite.go-oo.org/install_sets/Ubuntu-225-sqlsyntaxhighlighting-install_set.zip http://termite.go-oo.org/install_sets/MacIntel-580-sqlsyntaxhighlighting-install_set.zip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, two problems here: - optcolor.src:448: Should be SQLIDENTIFIER instead of BASICIDENTIFIER (copy'n'paste error) seems like you missed the latest svn update, found that one last night :-) - optcolor.cxx: aSQLFT should be declared after aSQLBackWN, not before it. Member declaration order controls member initialization order, which in turn controls Z-ordering Thanks a lot, this indeed fixed the issue. I actually thought about sth. like that myself, so I made sure to have this code in the right order: aSQLBackWN(this), SQLFT(this, ResId(FT_SQL_COMMAND, *rResId.GetResMgr())), Why does the declaration order matter, isn't initialization actually be done at this place? Glad everything works fine now, have a great holiday Regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, (uhm, I did it again, I called you with your full name in my last mail ... sorry :-\ ) no worries, it is not that important ;-) *trying to get the value does also not seem to work, I always get the default one, although it is saved upon closing and restarting the application. Can reproduce it :), did not investigate. Though, as Ocke already suggested, you forgot adding a new entry to the configuration schema. See the changes I committed to officecfg. Thanks, after I fixed another thing, it is now working perfectly fine except the group caption is not showing up, but I'm sure I'll find that one as well soon. MultiLineEditSyntaxHighlight, it crashes, to verify, just open and close the SQL view. Cannot reproduce. I suppose you have an incompatibility here, i.e. some file which has not been built though it would need to. Try touching the header file of the class, and rebuilding the module. Thanks for mentioning this possibility again. Although I could swear I did this a million times, it fixed the issue. I used the opportunity to switch to svn directly as well. I'll soon provide a new installation set for people to try out. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] some issues in cws sqlsyntaxhighlighting
Hi Frank, back from vacation and exams, I have some issue in cws sqlsyntaxhighlighting, would be great if you could help out once you find some time: - I tried adding a new group in the appearance dialog and one new entry. * The group appears, but the caption is not shown * the colorbox and window appear just fine, but I get an assertion that ressource 174 and 175 (the one from the colorbox and window) can not be found in the resource file, what am missing? *trying to get the value does also not seem to work, I always get the default one, although it is saved upon closing and restarting the application. I guess you did all that already once for the Base Extension and know the pitfalls ;-) - by simply adding svtools::ColorConfig m_aColorConfig to my new control MultiLineEditSyntaxHighlight, it crashes, to verify, just open and close the SQL view. The crash seems to come from ColorConfig::~ColorConfig() when calling EndListening( *m_pImpl), no idea what's going on there. If I use ColorConfig as a local variable in my highlighting routine, it does not crash, but I guess just creating it once makes more sense. Some help and pointers would be great, everything should be available in the cws. Feel free to submit any changes ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] SQL view improvements
Hi all, here is a first version of an improved SQL view[1], looking forward to many testers and feedback: http://termite.go-oo.org/install_sets/O3-build-3025-sqlsyntaxhighlighting-install_set.zip http://termite.go-oo.org/install_sets/Win-XP2-630-sqlsyntaxhighlighting-install_set.zip Features included: - SQL syntax highlighting [*] - respect settings from Tools-Options-OOo-Font (font size and height) - highlighting matching brackets (so when you type e.g. a ), it will highlight the corresponding (, very helpful when writing long bracket expression) Best regards Max [1] http://wiki.services.openoffice.org/wiki/SQL_Syntax_Highlighting [*] using fixed colors, you cannot change them currently - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] syntax highlighting and other improvements
Hi Frank, * I started syntax highlighting and other small improvements for the SQL view, an inital start can be found here: http://wiki.services.openoffice.org/wiki/SQL_Syntax_Highlighting This is mainly to make others aware of it and it is just an early draft, but I am looking forward to comments, suggestions or anything else. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] syntax highlighting and other improvements
Hi Frank, * I started syntax highlighting and other small improvements for the SQL view, an inital start can be found here: http://wiki.services.openoffice.org/wiki/SQL_Syntax_Highlighting This is mainly to make others aware of it and it is just an early draft, but I am looking forward to comments, suggestions or anything else. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-dev] syntax highlighting (was: [dba-dev] Hi all...)
Hi all, may develop syntax highlighting of SQL commands like it is done in the basic ide. So I'd be happy to work on that project. What's the best way to get I was actually planning to do this myself for 3.1, so if you are equally interested in something else you could do that I'd guess. But please be totally free to stick with this project, you were first and called it :-) Two comments regarding the implementation, although no responsibility is taken for the correctness of this information ;-) : - the wiki page mentiones editview/editengine, but from a first look/comment, textengine/textview (or exteditengine/editview) is enough and faster for our purpose (http://lxr.go-oo.org/source/util/svtools/source/edit/texteng.cxx#2846) (Although all these can be replaced by each other very easily anyway) - it might make sense to not duplicate pretty much everything from the basic ide including Editengine/Editview/Window and so on, but create a MultiLineEdit control + syntax highlighting (multilineedit already exists) as a new control, and use this for the basic IDE as well as SQL syntax highlighting inside Base. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
