Re: [dba-dev] improved SQL view
Hi Max, It seems it is finished? So did you already pass the CWS to Mechtilde, or are there still fixes needed? yes, rebase is finsished and Mechtilde is doing manual test, while André Schnabel is doing the automatic tests on Win/Linux. Just saw that CWS sqlsyntaxhighlighting is nominated - congratulations, and thanks for doing this implementation! Bettina told me that she will be working on the colors this week. hmmm do we still have light green on white? Thanks Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi, Just saw that CWS sqlsyntaxhighlighting is nominated - congratulations, and thanks for doing this implementation! :-) Bettina told me that she will be working on the colors this week. hmmm do we still have light green on white? I know that she lessened the red and green color, but not sure to what excactly and I did not test it. If you do not agree on the colors, please talk to her. If new colors come up in the future, I am happy to integrate them, of course. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, I took the liberty to give the tokens their very own color. great idea, nice working together with smart people ;-) I still think that SQLSTRING needs a change, this is pretty difficult to read now that I see it, +1 Anyway, will talk to Bettina about this. great Best, max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, You should submit an issue for this, just to ensure it doesn't get lost. I suggest the 3.x target. If you don't really feel like coding in Base fyi, issue 96396, target 3.1 assigned to myself ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Max, Rebase is running right now. It seems it is finished? So did you already pass the CWS to Mechtilde, or are there still fixes needed? Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, It seems it is finished? So did you already pass the CWS to Mechtilde, or are there still fixes needed? yes, rebase is finsished and Mechtilde is doing manual test, while André Schnabel is doing the automatic tests on Win/Linux. Bettina told me that she will be working on the colors this week. Best regards Max PS: mechtilde agreed to postpone the Mac issue to a follow up fix in a next CWS - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Max, yes, rebase is finsished and Mechtilde is doing manual test, while André Schnabel is doing the automatic tests on Win/Linux. Bettina told me that she will be working on the colors this week. Okay, fine. PS: mechtilde agreed to postpone the Mac issue to a follow up fix in a next CWS You should submit an issue for this, just to ensure it doesn't get lost. I suggest the 3.x target. If you don't really feel like coding in Base anymore after this CWS is integrated :), then you can put the issue on the pile owned by me, otherwise I'd ask you to assign it to yourself. Thanks Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, Sounds like a task which we could postpone, IMO, provided the CWS'es QA rep agrees. Which brings me to: Our QA here in Hamburg is busy with a lot of other CWS' which are targeted for 3.1, too. Mechtilde (German QA-Project) will do the QAing and aggreed to postpone the mac issue. Other than that: Did you have a chance to talk about the default colors with Bettina? I still think light green on white is ... eye-hurting :) yes, she told me to have a look rather soon and also align with BASIC IDE as well as report designer colors Thanks for the code review, I fixed it all except the last one, as you pointed out correctly ;-) Rebase is running right now. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Max, Which brings me to: Our QA here in Hamburg is busy with a lot of other CWS' which are targeted for 3.1, too. Mechtilde (German QA-Project) will do the QAing and aggreed to postpone the mac issue. Okay, the CWS is in good hands, I'd say. yes, she told me to have a look rather soon and also align with BASIC IDE as well as report designer colors Thanks for the code review, I fixed it all except the last one, as you pointed out correctly ;-) Rebase is running right now. Okay, thanks for those three, too. Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Max, [X] I think it's finished, and I just don't dare to say ;-) ouch, now I remember again the last remaining issue. According to [EMAIL PROTECTED], bracket matching does not work on Mac, no idea why. Would you have access to one and could debug there? Otherwise, I get mine in 1 - 3 weeks and could debug it then, but then we might miss feature freeze, which would be really unfortunate. I don't have time at the moment for debugging this on the Mac, sorry (the more since debugging on the Mac is a cumbersome task. Well, to put it the other way round: I have only minimal experience with the tools on this platform.). Sounds like a task which we could postpone, IMO, provided the CWS'es QA rep agrees. Which brings me to: Our QA here in Hamburg is busy with a lot of other CWS' which are targeted for 3.1, too. But hey, nobody says a CWS'es QA rep needs to be a Sun-paid QA engineer, right? I suggest we ask - here and in [EMAIL PROTECTED] - for a volunteer who has a look at this CWS. What do you think? However, you should rebase your CWS to m35, since m34 saw some big changes in dbaccess. I am not sure they would conflict, but we should be sure Yup, will do right after Peking. Okay. Other than that: Did you have a chance to talk about the default colors with Bettina? I still think light green on white is ... eye-hurting :) I also spent some time reviewing your code changes. The following is a list of items I came across - nothing you're required to change, but I mention them for completeness (otherwise my review time would have been wasted :). - Any reason why m_pSourceViewConfig and m_pColorConfig are allocated dynamically? The instances could have been direct members. - overloading OSqlEdit::Notify is superfluous (in case it's just here because of a compiler warning - a using directive on the class declaration should do). - MultiLineEditSyntaxHighlight should be in an own file - crowding one file with unrelated classes doesn't really contribute to code lucidity. (Well ... that's the only item I would really *like* to see be changed :) - I would have preferred making larger chunks of the highlighter code a parametrization of the MultiLineEditSyntaxHighlight and SyntaxHighlighter classes, instead of hard-coding them. That is, IMO the keyword list, the token types, and everything else which is language specific (Basic or SQL), should have been hidden behind an abstract interface, which then is implemented once in basctl for Basic, and once in dbaccess for SQL. This would have been a much cleaner architecture. However, I see that the old code was in no way prepared for this, and changing this is a too big refactoring for now. Okay, enough for now. Please do the resync when you find the time (if you're really too busy, I can try to do myself, so we have chances of hitting the feature freeze, but I can't promise). Thanks Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, where pretty much finished means [X] I think it's finished, and I just don't dare to say. [ ] There are still some minor open issues, which I'm not sure I should fix in this CWS. [ ] other: I darkly remember having seen the Basic IDE code years ago, do I remember correctly that highlighting is done on a per-line basis, so the problem here is that we always generate one-line SQL statements? Not really, I think. Once you edit a line in the IDE, a broadcast including the current line happens and notifyChange is called, which calculates the new portions and should return a range of changed line, which are then reformatted based on the tokenizer. But I now saw that this does not actually seem to work, but you get a manual notification for every changed line in the editor, this one is then syntax highlighted. In the SQL editor, we just reformat the whole thing. I leave it as it is now, as noone seems to be disturbed. If this should be an issue, we should do some current cursor magic to reformat a smaller range. where pretty much finished means [X] I think it's finished, and I just don't dare to say ;-) So yes, finding a QA person and getting it in for 3.1 would be great. Best regards Max PS: Bettia and I will have a look at the standard colors tomorrow in Bejing - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Maximilian, [X] I think it's finished, and I just don't dare to say ;-) So yes, finding a QA person and getting it in for 3.1 would be great. Okay. However, you should rebase your CWS to m35, since m34 saw some big changes in dbaccess. I am not sure they would conflict, but we should be sure. I took the liberty to merge trunk's changes to solenv/bin/cws.pl, solenv/bin/modules/Cws.pm, and solenv/bin/modules/CwsConfig.pm. This way, you should have a working cws rebase command in the CWS. (At least I hope I remembered the needed files correctly ...) Note that it seems that you already merged in some of the changes, at least in cws.pl. However, it seems you did not use svn merge for this, but just applied a patch file - which will confuse subsequent svn merge operations. So I reverted your change before doing the actual merge, hope you don't mind. PS: Bettia and I will have a look at the standard colors tomorrow in Bejing That's good :) Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, [X] I think it's finished, and I just don't dare to say ;-) ouch, now I remember again the last remaining issue. According to [EMAIL PROTECTED], bracket matching does not work on Mac, no idea why. Would you have access to one and could debug there? Otherwise, I get mine in 1 - 3 weeks and could debug it then, but then we might miss feature freeze, which would be really unfortunate. (silent thinking: or maybe get it QA'ed anyway and we fix it afterwards, I guess there is still lots of time after feature freeze) However, you should rebase your CWS to m35, since m34 saw some big changes in dbaccess. I am not sure they would conflict, but we should be sure Yup, will do right after Peking. Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Peter, I darkly remember having seen the Basic IDE code years ago, do I remember correctly that highlighting is done on a per-line basis, so the problem here is that we always generate one-line SQL statements? In this case, it might be an additional ... motivation to make the Query Designer preserve line ends as entered by the user ... ... which is known as (assigned to requirement) http://qa.openoffice.org/issues/show_bug.cgi?id=78523, am I right? Yes, but not completely. I would also like to see switching from SQL view to graphical view and back preserve the line breaks. Possibly even when you do changes in the graphical view - for instance, when WHERE starts on a new line, then it should continue to do so if you just modified the SELECTed columns. Something like this, though this latter part is non-trivial, admitted. Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Max, here is a new testable version of the cws sqlsyntaxhighlighting[1]. In addition to the last snapshot, which included the following features: - syntax highlighting in SQL view - bracket matching - font and font size configurable this snapshot now support these as well: - syntax highlighting and bracket matching in Tools-SQL as well (sometimes I really love programming ;-)) - configurable colors in tools-options-appearance - parameters are highlighted as well Cool stuff. Great idea to also use the same control in the Tools/SQL-dialog! In general, it's looking better and better. Do you have a list of open issues, or something like that, which shows how far you're from finishing it? Things I noticed while playing with it: - changing the colors is not propagated to currently-open SQL views, you need to close and re-open them - In Tools/Options/Appearance, Strings are listed with color Automatic = White, but in the SQL view, they're light green (which I continue to consider an unfortunate default, given the default background color is white) - (really minor, only worth fixing if it's easy enough) - type SELECT hour(foo, - select the comma - type a closing parenthesis = only the opening parenthesis is bolded That is, when the parenthesis you type replaces a selection, bolding it does not work. Ciao Frank PS: I only played with the installation so far, I did not yet look into the code you wrote. I plan to do so, but this requires a) to find out how, in SVN, to display the changes which happened on a certain CWS branch (excluding changes caused by rebasing the CWS, ideally) and b) time. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Frank Schönheit wrote: Hi Max, this snapshot now support these as well: - syntax highlighting and bracket matching in Tools-SQL as well (sometimes I really love programming ;-)) - configurable colors in tools-options-appearance - parameters are highlighted as well Cool stuff. Great idea to also use the same control in the Tools/SQL-dialog! Hello Max, To be honest I haven't had a lot of time to look at your work in the last little while. I did early on and I am really looking forward to doing so again and to seeing it in the baseline package. The reason for this email is simple - it's easy sometimes to get caught up in what isn't working, or what isn't 'in the package', as evidenced by some of the other discussions going on. It is also all too easy at times to look at the OpenOffice.org project as belonging to one or two particular companies. To keep saying...why don't they push a few more engineers towards this project or that feature and ask - What the @#$% are they thinking? :) This isn't confined to any one modules project either - only to look at the 'Where are all the patches? blog entries of late. This email is not about any of those questions in particular - rather it is simply to be sure that we don't forget to also notice what is going right. This idea of a community built package is never going to happen because of some edict from above - it will happen one contributing developer at a time - it will 'emerge' of it's own power or not in other words. So - just speaking for myself...thank you for the time and effort you are putting in to it. That's it. Sincerely, Drew - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, here is a new testable version of the cws sqlsyntaxhighlighting[1]. This was the idea of the new control, so actually this new thing could be used as well in the BASIC IDE and we could throw out a lot of stuff including all the manual EditView/EditEngine code...(if the BASIC IDE does not have a lot of functionality on top of these, which I don't see ,and the maintainer is not too scared to use my code (never change a running IDE...)) - changing the colors is not propagated to currently-open SQL views, you need to close and re-open them fixed in cws - In Tools/Options/Appearance, Strings are listed with color Automatic = White, but in the SQL view, they're light green (which I continue to consider an unfortunate default, given the default background color is white) fixed in cws In general, it's looking better and better. Do you have a list of open issues, or something like that, which shows how far you're from finishing it? based on feedback on [EMAIL PROTECTED], I now added support for SQL comments (--) as well and I consider the whole cws pretty much finished now. One thing I am not sure about is flickering, as always the whole text is syntax highlighted, but up to now, noone complained ;-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Drew, So - just speaking for myself...thank you for the time and effort you are putting in to it. thanks a lot for your nice words, really appreciated :-) Best regards Max - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Max, ... So - just speaking for myself...thank you for the time and effort you are putting in to it. Which is something I'd like to explicitly sign with my name, too. illegible_scribble/ Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dba-dev] improved SQL view
Hi Frank, Frank Schönheit - Sun Microsystems Germany schrieb: I darkly remember having seen the Basic IDE code years ago, do I remember correctly that highlighting is done on a per-line basis, so the problem here is that we always generate one-line SQL statements? In this case, it might be an additional ... motivation to make the Query Designer preserve line ends as entered by the user ... ... which is known as (assigned to requirement) http://qa.openoffice.org/issues/show_bug.cgi?id=78523, am I right? Regards Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
