[GitHub] cuijian-dexter commented on issue #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
cuijian-dexter commented on issue #8997: Pie chart adds filterValue parameter
URL: 
https://github.com/apache/incubator-echarts/pull/8997#issuecomment-430498829
 
 
   @Ovilia ok,After the final review is completed,I will add again.
   #8759 Has this been updated?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia commented on issue #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
Ovilia commented on issue #8997: Pie chart adds filterValue parameter
URL: 
https://github.com/apache/incubator-echarts/pull/8997#issuecomment-430495198
 
 
   If you add a new configure option, please also update document both in 
[English](https://github.com/ecomfe/echarts-doc/blob/gh-pages/en/option/series/pie.md)
 and 
[Chinese](https://github.com/ecomfe/echarts-doc/blob/gh-pages/cn/option/series/pie.md).
 
   Make a PR for https://github.com/ecomfe/echarts-doc and link it here.
   
   Thanks!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia commented on issue #9171: fix #8009 & #5969, symbol symbolSize and opacity setting for category itemStyle in graph

2018-10-16 Thread GitBox
Ovilia commented on issue #9171: fix #8009 & #5969, symbol symbolSize and 
opacity setting for category itemStyle in graph
URL: 
https://github.com/apache/incubator-echarts/pull/9171#issuecomment-430489030
 
 
   @100pah please verify this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter edited a comment on issue #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
cuijian-dexter edited a comment on issue #8997: Pie chart adds filterValue 
parameter
URL: 
https://github.com/apache/incubator-echarts/pull/8997#issuecomment-430475841
 
 
   @100pah check it again.Thanks
   var option = {
   title: {
   text: '饼图标题',
   left: 16,
   textStyle: {
   fontSize: 14
   }
   },
   tooltip: {
   trigger: 'item',
   axisPointer: {
   },
   extraCssText: 'max-width: 300px; word-break:break-all; 
white-space: normal'
   },
   legend: {
   data: [
   
   ]
   },
   series: [
   {
   type: 'pie',
   
labelDisplayThreshold:0.1,//范围为0-1,默认为0,全部显示。百分比小于0.1的,不显示
   label: {
   normal: {
   show: true
   },
   emphasis: {
   show: true,
   textStyle: {
   fontSize: '14',
   fontWeight: 'bold'
   }
   }
   },
   labelLine: {
   lineStyle: {
   color: '#D9D9D9'
   }
   },
   data: [{
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:49.9
   },
   {
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:50.1
   },
   
   ]
   }
   ]
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on issue #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
cuijian-dexter commented on issue #8997: Pie chart adds filterValue parameter
URL: 
https://github.com/apache/incubator-echarts/pull/8997#issuecomment-430475841
 
 
   @100pah check it again.Thanks
   var option = {
   title: {
   text: '饼图标题',
   left: 16,
   textStyle: {
   fontSize: 14
   }
   },
   tooltip: {
   trigger: 'item',
   axisPointer: {
   },
   extraCssText: 'max-width: 300px; word-break:break-all; 
white-space: normal'
   },
   legend: {
   data: [
   
   ]
   },
   series: [
   {
   type: 'pie',
   
labelDisplayThreshold:0.1,//范围为0-1,默认为0,全部显示。百分比小于0.1的,不显示
   label: {
   normal: {
   show: true
   },
   emphasis: {
   show: true,
   textStyle: {
   fontSize: '14',
   fontWeight: 'bold'
   }
   }
   },
   labelLine: {
   lineStyle: {
   color: '#D9D9D9'
   }
   },
   data: [{
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:49.9
   },
   {
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:100
   },
   {
   name:'1212',
   value:50.1
   },
   
   ]
   }
   ]
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] mzy2240 commented on issue #9212: For Map Application, update the scatter data will erase all the lines data

2018-10-16 Thread GitBox
mzy2240 commented on issue #9212: For Map Application, update the scatter data 
will erase all the lines data
URL: 
https://github.com/apache/incubator-echarts/issues/9212#issuecomment-430474043
 
 
   @Ovilia 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] chapery commented on issue #9146: legend中的icon颜色和对应的气泡图中的颜色不一样

2018-10-16 Thread GitBox
chapery commented on issue #9146: legend中的icon颜色和对应的气泡图中的颜色不一样
URL: 
https://github.com/apache/incubator-echarts/issues/9146#issuecomment-430473610
 
 
   legend中图例的颜色明显比series中的颜色深,可以用取色器看下颜色值


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
cuijian-dexter commented on a change in pull request #8997: Pie chart adds 
filterValue parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225765567
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+var seriesModel = data.hostModel;
+var itemModel = data.getItemModel(idx);
+var valueDim = data.mapDimension('value');
+var sum = data.getSum(valueDim);
 
 Review comment:
   Should I bind `sum` to `this` or `data?`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
cuijian-dexter commented on a change in pull request #8997: Pie chart adds 
filterValue parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225762482
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
 
 Review comment:
   Can the function name be `_getLabelDisplayThreshold` ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9236: 多条折线的图,如何让坐标轴跟随曲线同步显示和隐藏

2018-10-16 Thread GitBox
deqingli commented on issue #9236: 多条折线的图,如何让坐标轴跟随曲线同步显示和隐藏
URL: 
https://github.com/apache/incubator-echarts/issues/9236#issuecomment-430470384
 
 
   您好,麻烦提供更详细的信息,目前的效果图以及 echarts option 的完整配置。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9237: Stacked bars positioned out of the grid when datazoom toolbox feature is used

2018-10-16 Thread GitBox
deqingli commented on issue #9237: Stacked bars positioned out of the grid when 
datazoom toolbox feature is used
URL: 
https://github.com/apache/incubator-echarts/issues/9237#issuecomment-430469993
 
 
   Thank for your feedback.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] zhouzebin closed issue #9230: 如何将折线图的拐点按照不同的角度旋转

2018-10-16 Thread GitBox
zhouzebin closed issue #9230: 如何将折线图的拐点按照不同的角度旋转
URL: https://github.com/apache/incubator-echarts/issues/9230
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] zhouzebin commented on issue #9230: 如何将折线图的拐点按照不同的角度旋转

2018-10-16 Thread GitBox
zhouzebin commented on issue #9230: 如何将折线图的拐点按照不同的角度旋转
URL: 
https://github.com/apache/incubator-echarts/issues/9230#issuecomment-430469660
 
 
   感谢大神,但是不理解,为啥我在官网上找不到你说的这个呢。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9240: add tooltipShow event

2018-10-16 Thread GitBox
deqingli commented on issue #9240: add tooltipShow event
URL: 
https://github.com/apache/incubator-echarts/issues/9240#issuecomment-430469192
 
 
   您好,如果方便的话,建议您提供联动的效果图,以及 echarts 的 option 配置。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] yezhihao17 closed issue #9241: 当数据达到一定数量时,会多出一条连接起点和终点的线

2018-10-16 Thread GitBox
yezhihao17 closed issue #9241: 当数据达到一定数量时,会多出一条连接起点和终点的线
URL: https://github.com/apache/incubator-echarts/issues/9241
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on issue #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
cuijian-dexter commented on issue #9210: fix #9182 Graphlabel.rotate is 
invalid
URL: 
https://github.com/apache/incubator-echarts/pull/9210#issuecomment-430463494
 
 
   @100pah you can check it again.thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
cuijian-dexter commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225760363
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -222,7 +227,7 @@ export default echarts.extendChartView({
 }
 else {
 symbolPath.setStyle({
-textRotation: 0
+textRotation: labelRotate *= Math.PI / 180
 
 Review comment:
   `labelRotate` can't be undefined.The default is 0


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
cuijian-dexter commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225758673
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -200,7 +200,12 @@ export default echarts.extendChartView({
 && seriesModel.get('circular.rotateLabel');
 var cx = data.getLayout('cx');
 var cy = data.getLayout('cy');
+var labelRotate = seriesModel.get('label.rotate') || 0;
 data.eachItemGraphicEl(function (el, idx) {
+var itemRotate = itemModel.get('label.rotate');
 
 Review comment:
   It is useful,Now,I know it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] ahmadalibaloch commented on issue #9232: Use OffScreenCanvas API for big data live charts

2018-10-16 Thread GitBox
ahmadalibaloch commented on issue #9232: Use OffScreenCanvas API for big data 
live charts
URL: 
https://github.com/apache/incubator-echarts/issues/9232#issuecomment-430287014
 
 
   I customized [this large bar 
chart](https://ecomfe.github.io/echarts-examples/public/editor.html?c=bar-large)
 from echarts gallery and made it dynamic so you can have a look, copy and past 
following code into an echart example. While this chart is rendering in real 
time try to scroll the code area scrollbar and you will feel UI thread blocking 
at every interval.
   
   ```
   
   var dataCount = 5e5;
   var data = generateData(dataCount);
   
   var option = {
   title: {
   text: echarts.format.addCommas(dataCount) + ' Data',
   left: 10
   },
   toolbox: {
   feature: {
   dataZoom: {
   yAxisIndex: false
   },
   saveAsImage: {
   pixelRatio: 2
   }
   }
   },
   tooltip: {
   trigger: 'axis',
   axisPointer: {
   type: 'shadow'
   }
   },
   grid: {
   bottom: 90
   },
   dataZoom: [{
   type: 'inside'
   }, {
   type: 'slider'
   }],
   xAxis: {
   data: data.categoryData,
   silent: false,
   splitLine: {
   show: false
   },
   splitArea: {
   show: false
   }
   },
   yAxis: {
   splitArea: {
   show: false
   }
   },
   series: [{
   type: 'bar',
   data: data.valueData,
   // Set `large` for large data amount
   large: true
   }]
   };
   var baseValue = Math.random() * 1000;
   function next1(idx) {
   smallBaseValue = idx % 30 === 0
   ? Math.random() * 700
   : (smallBaseValue + Math.random() * 500 - 250);
   baseValue += Math.random() * 20 - 10;
   return Math.max(
   0,
   Math.round(baseValue + smallBaseValue) + 3000
   );
   }
   setInterval(()=>{
   option.series[0].data.push(next1(1));
   myChart.setOption(option);
   },1000);
   
   function generateData(count) {
   var baseValue = Math.random() * 1000;
   var time = +new Date(2011, 0, 1);
   var smallBaseValue;
   
   function next(idx) {
   smallBaseValue = idx % 30 === 0
   ? Math.random() * 700
   : (smallBaseValue + Math.random() * 500 - 250);
   baseValue += Math.random() * 20 - 10;
   return Math.max(
   0,
   Math.round(baseValue + smallBaseValue) + 3000
   );
   }
   
   var categoryData = [];
   var valueData = [];
   
   for (var i = 0; i < count; i++) {
   categoryData.push(echarts.format.formatTime('-MM-dd\nhh:mm:ss', 
time));
   valueData.push(next(i).toFixed(2));
   time += 1000;
   }
   
   return {
   categoryData: categoryData,
   valueData: valueData
   };
   }
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter removed a comment on issue #9234: echarts只能通过setOption更新数据

2018-10-16 Thread GitBox
cuijian-dexter removed a comment on issue #9234: echarts只能通过setOption更新数据
URL: 
https://github.com/apache/incubator-echarts/issues/9234#issuecomment-430141209
 
 
   @liucrui do you have a example ? 
   `setOption` has parameters `notMerge` . parameter `lazyUpdate` and parameter 
`silent`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on issue #9232: Use OffScreenCanvas API for big data live charts

2018-10-16 Thread GitBox
100pah commented on issue #9232: Use OffScreenCanvas API for big data live 
charts
URL: 
https://github.com/apache/incubator-echarts/issues/9232#issuecomment-430275964
 
 
   If possible, can we have your example/demo for detailed discussion?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] yezhihao17 commented on issue #9241: 当数据达到一定数量时,会多出一条连接起点和终点的线

2018-10-16 Thread GitBox
yezhihao17 commented on issue #9241: 当数据达到一定数量时,会多出一条连接起点和终点的线
URL: 
https://github.com/apache/incubator-echarts/issues/9241#issuecomment-430260796
 
 
   感谢你的回复!
   
上面的配置是完整的options,问题已经找到,造成这样的原因是因为我的data数据的value第一个维度是时间戳,而这个时间戳并不是正常的时间戳,时间戳会在达到一定长度后循环,比如:15:00到18:00,然后又从15:00到18:00这样的一个结果。
 这样就会造成渲染出来的折线图多了一条直线。不知道这个机制是不是框架设计成这样的还是存在的一个问题。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
100pah commented on a change in pull request #8997: Pie chart adds filterValue 
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225533152
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+var seriesModel = data.hostModel;
+var itemModel = data.getItemModel(idx);
+var valueDim = data.mapDimension('value');
+var sum = data.getSum(valueDim);
+var filterValue = seriesModel.get('labelDisplayThreshold');
+var filterIgnore = false;
+if (sum * filterValue.option > itemModel.option.value) {
+filterIgnore = true;
+}
+return filterIgnore;
 
 Review comment:
   Just 
   ```js
   return xxx * yyy > zzz;
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli edited a comment on issue #9241: 当数据达到一定数量时,会多出一条连接起点和终点的线

2018-10-16 Thread GitBox
deqingli edited a comment on issue #9241: 当数据达到一定数量时,会多出一条连接起点和终点的线
URL: 
https://github.com/apache/incubator-echarts/issues/9241#issuecomment-430234281
 
 
   您好,请问这是完整的 echarts option 配置么,有配置  markLine 之类的么。如果方便的话,麻烦提供一下数据,这样我好给你调试。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
100pah commented on a change in pull request #8997: Pie chart adds filterValue 
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225534419
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+var seriesModel = data.hostModel;
+var itemModel = data.getItemModel(idx);
 
 Review comment:
   create an `itemModel` is not necessary here (and should not fetch value from 
itemModel). Just using `data.get(valueDim, idx)` the get the value.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
100pah commented on a change in pull request #8997: Pie chart adds filterValue 
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225531517
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
 
 Review comment:
   (1) Code style: should be `function (data, idx)`, for anonymous function 
declaration.
   (2) Both `get`, `filter`, and `ignore` are verb. that makes the function 
name a bit strange. Should the name has some relationship with 
`labelDisplayThreshold`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
100pah commented on a change in pull request #8997: Pie chart adds filterValue 
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225535214
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+var seriesModel = data.hostModel;
+var itemModel = data.getItemModel(idx);
+var valueDim = data.mapDimension('value');
+var sum = data.getSum(valueDim);
 
 Review comment:
   The `sum` is not necessary to be calculated in each iteration of the loop. 
Only calculate it once outside the loop.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter

2018-10-16 Thread GitBox
100pah commented on a change in pull request #8997: Pie chart adds filterValue 
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225532737
 
 

 ##
 File path: src/chart/pie/PieView.js
 ##
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, 
firstCreate) {
 graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+var seriesModel = data.hostModel;
+var itemModel = data.getItemModel(idx);
+var valueDim = data.mapDimension('value');
+var sum = data.getSum(valueDim);
+var filterValue = seriesModel.get('labelDisplayThreshold');
+var filterIgnore = false;
+if (sum * filterValue.option > itemModel.option.value) {
 
 Review comment:
   does `seriesModel.get('labelDisplayThreshold')` returns an `object`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225525322
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -200,7 +200,12 @@ export default echarts.extendChartView({
 && seriesModel.get('circular.rotateLabel');
 var cx = data.getLayout('cx');
 var cy = data.getLayout('cy');
+var labelRotate = seriesModel.get('label.rotate') || 0;
 data.eachItemGraphicEl(function (el, idx) {
+var itemRotate = itemModel.get('label.rotate');
+if (itemRotate != undefined) {
 
 Review comment:
   By convention, `some != null` is recommended. (not a big deal, just probably 
because that null can not be redefined)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225525322
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -200,7 +200,12 @@ export default echarts.extendChartView({
 && seriesModel.get('circular.rotateLabel');
 var cx = data.getLayout('cx');
 var cy = data.getLayout('cy');
+var labelRotate = seriesModel.get('label.rotate') || 0;
 data.eachItemGraphicEl(function (el, idx) {
+var itemRotate = itemModel.get('label.rotate');
+if (itemRotate != undefined) {
 
 Review comment:
   By convention, `some != null` is recommended. (not a bit deal, just probably 
because that null can not be redefined)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225525322
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -200,7 +200,12 @@ export default echarts.extendChartView({
 && seriesModel.get('circular.rotateLabel');
 var cx = data.getLayout('cx');
 var cy = data.getLayout('cy');
+var labelRotate = seriesModel.get('label.rotate') || 0;
 data.eachItemGraphicEl(function (el, idx) {
+var itemRotate = itemModel.get('label.rotate');
+if (itemRotate != undefined) {
 
 Review comment:
   In most cases, `undefined` and `null` are treat in the same way. So `some != 
null` is recommended.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225524683
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -200,7 +200,12 @@ export default echarts.extendChartView({
 && seriesModel.get('circular.rotateLabel');
 var cx = data.getLayout('cx');
 var cy = data.getLayout('cy');
+var labelRotate = seriesModel.get('label.rotate') || 0;
 data.eachItemGraphicEl(function (el, idx) {
+var itemRotate = itemModel.get('label.rotate');
 
 Review comment:
   `itemModel.get('label.rotate')` already considers the option cascade, that 
is, fetching `label.rotate` from data, and then seriesModel, and then ecModel. 
So `seriesModel.get('label.rotate')` is not necessary.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225526584
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -222,7 +227,7 @@ export default echarts.extendChartView({
 }
 else {
 symbolPath.setStyle({
-textRotation: 0
+textRotation: labelRotate *= Math.PI / 180
 
 Review comment:
   If `labelRotate` is defined outside the loop and not be reset in the 
beginning of each loop, using `*=` is probably incorrect.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] 100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225525322
 
 

 ##
 File path: src/chart/graph/GraphView.js
 ##
 @@ -200,7 +200,12 @@ export default echarts.extendChartView({
 && seriesModel.get('circular.rotateLabel');
 var cx = data.getLayout('cx');
 var cy = data.getLayout('cy');
+var labelRotate = seriesModel.get('label.rotate') || 0;
 data.eachItemGraphicEl(function (el, idx) {
+var itemRotate = itemModel.get('label.rotate');
+if (itemRotate != undefined) {
 
 Review comment:
   In most cases, `undefined` and `null` are treat in the same way. So `some == 
null` is recommended.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli edited a comment on issue #9235: 鼠标移上去的Tips能不能带箭头小三角?

2018-10-16 Thread GitBox
deqingli edited a comment on issue #9235: 鼠标移上去的Tips能不能带箭头小三角?
URL: 
https://github.com/apache/incubator-echarts/issues/9235#issuecomment-430224716
 
 
   您好,麻烦补充下详细的信息,鼠标移动到 tooltip 么?还有麻烦给下 echarts 的 option 配置项,谢谢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9235: 鼠标移上去的Tips能不能带箭头小三角?

2018-10-16 Thread GitBox
deqingli commented on issue #9235: 鼠标移上去的Tips能不能带箭头小三角?
URL: 
https://github.com/apache/incubator-echarts/issues/9235#issuecomment-430224716
 
 
   您好,麻烦补充下详细的信息,鼠标移动到 tooltip 么?,还有麻烦给下 echarts 的 option 配置项,谢谢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9234: echarts只能通过setOption更新数据

2018-10-16 Thread GitBox
deqingli commented on issue #9234: echarts只能通过setOption更新数据
URL: 
https://github.com/apache/incubator-echarts/issues/9234#issuecomment-430220367
 
 
   @liucrui  您好,谢谢您的反馈。现在 setOption() 后,还没办法 merge 每个节点的操作行为,后续我们会考虑支持这块的功能。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] happyeverday commented on issue #5614: 请教:绘制完成后是否有api获取所有节点和节点的坐标

2018-10-16 Thread GitBox
happyeverday commented on issue #5614: 请教:绘制完成后是否有api获取所有节点和节点的坐标
URL: 
https://github.com/apache/incubator-echarts/issues/5614#issuecomment-430216815
 
 
   > 你好,在echarts3.8和4.0版本中,已经没有preservedPoints方法,请问该如何实现该需求呢?
   
   hello,您找到方法解决这个问题了么


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] happyeverday commented on issue #5614: 请教:绘制完成后是否有api获取所有节点和节点的坐标

2018-10-16 Thread GitBox
happyeverday commented on issue #5614: 请教:绘制完成后是否有api获取所有节点和节点的坐标
URL: 
https://github.com/apache/incubator-echarts/issues/5614#issuecomment-430213017
 
 
   你好,在echarts3.8和4.0版本中,已经没有preservedPoints方法,请问该如何实现该需求呢?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9221: Echarts is flushing values when we resume live charts

2018-10-16 Thread GitBox
deqingli commented on issue #9221: Echarts is flushing values when we resume 
live charts
URL: 
https://github.com/apache/incubator-echarts/issues/9221#issuecomment-430211163
 
 
   @ahmadalibaloch  Thank you for your feedback, I will continue to follow up 
on this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli edited a comment on issue #9231: Treemap第二个例子ECharts 配置项查询分布有个展示bug

2018-10-16 Thread GitBox
deqingli edited a comment on issue #9231: Treemap第二个例子ECharts 配置项查询分布有个展示bug
URL: 
https://github.com/apache/incubator-echarts/issues/9231#issuecomment-430202644
 
 
   您好,谢谢您的反馈,这里的 source 不是指父节点,这里的 source 是 convert(source, target, basePath) 
函数里的目标原数据,而 target 是指处理后的数据。 我调试了 convert 数据处理的过程,没有什么问题,产出的数据也是对的。不过,例子中 
xAxis.axisLabel 这一矩形块展示的 label 数据的确有点歧义,容易引起误会,我们会尝试完善下。Anyway,再次感谢您的反馈。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9232: Use OffScreenCanvas API for big data live charts

2018-10-16 Thread GitBox
deqingli commented on issue #9232: Use OffScreenCanvas API for big data live 
charts
URL: 
https://github.com/apache/incubator-echarts/issues/9232#issuecomment-430207901
 
 
   Thank you for your feedback and suggestions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9231: Treemap第二个例子ECharts 配置项查询分布有个展示bug

2018-10-16 Thread GitBox
deqingli commented on issue #9231: Treemap第二个例子ECharts 配置项查询分布有个展示bug
URL: 
https://github.com/apache/incubator-echarts/issues/9231#issuecomment-430202644
 
 
   您好,谢谢您的反馈,这里的 source 不是指父节点,这里的 source 是 convert(source, target, basePath) 
函数里的目标原数据,而 target 是指处理后的数据。 我调试了 convert 数据处理的过程,没有什么问题,产出的数据也是对的。不过,例子中 
xAxis.axisLabel 这一矩形块展示的 label 数据的确有问题,我会继续跟进。Anyway,再次感谢您的反馈。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] cuijian-dexter commented on issue #8921: connectnulls not working properly with step chart

2018-10-16 Thread GitBox
cuijian-dexter commented on issue #8921: connectnulls not working properly with 
step chart
URL: 
https://github.com/apache/incubator-echarts/issues/8921#issuecomment-430182271
 
 
   @vimalraj-ponnusamy  `connectNulls` is effective for all data


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] vimalraj-ponnusamy commented on issue #8921: connectnulls not working properly with step chart

2018-10-16 Thread GitBox
vimalraj-ponnusamy commented on issue #8921: connectnulls not working properly 
with step chart
URL: 
https://github.com/apache/incubator-echarts/issues/8921#issuecomment-430181063
 
 
   Data Sample also   series[i].connectNulls only right ? Its not 
series[i].data[0].connectNulls.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #9150: echarts散点图怎么取消事件冒泡

2018-10-16 Thread GitBox
Ovilia closed issue #9150: echarts散点图怎么取消事件冒泡
URL: https://github.com/apache/incubator-echarts/issues/9150
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #9177: 通过dispatchAction方法触发关系图的缩放无效

2018-10-16 Thread GitBox
Ovilia closed issue #9177: 通过dispatchAction方法触发关系图的缩放无效
URL: https://github.com/apache/incubator-echarts/issues/9177
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #9179: Data View 不显示第一列的 “Date"

2018-10-16 Thread GitBox
Ovilia closed issue #9179: Data View 不显示第一列的 “Date"
URL: https://github.com/apache/incubator-echarts/issues/9179
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #8776: gallery新建图表无法保存,同时也不能上传数据

2018-10-16 Thread GitBox
Ovilia closed issue #8776: gallery新建图表无法保存,同时也不能上传数据
URL: https://github.com/apache/incubator-echarts/issues/8776
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #8754: Gallery创建一个图表后,不能保存,一直提示 无法保存到服务器,已在本地缓存,请尝试刷新页面

2018-10-16 Thread GitBox
Ovilia closed issue #8754: Gallery创建一个图表后,不能保存,一直提示 无法保存到服务器,已在本地缓存,请尝试刷新页面
URL: https://github.com/apache/incubator-echarts/issues/8754
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #9194: axisLine.show doesn't work in the gauge

2018-10-16 Thread GitBox
Ovilia closed issue #9194: axisLine.show doesn't work in the gauge
URL: https://github.com/apache/incubator-echarts/issues/9194
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia closed issue #4047: 雷达图有null值时显示不正常

2018-10-16 Thread GitBox
Ovilia closed issue #4047: 雷达图有null值时显示不正常
URL: https://github.com/apache/incubator-echarts/issues/4047
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia commented on issue #4047: 雷达图有null值时显示不正常

2018-10-16 Thread GitBox
Ovilia commented on issue #4047: 雷达图有null值时显示不正常
URL: 
https://github.com/apache/incubator-echarts/issues/4047#issuecomment-430152840
 
 
   Fixed in #8962


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] hling51325 opened a new pull request #9238: fix: #8952 callback function params.color incorrect

2018-10-16 Thread GitBox
hling51325 opened a new pull request #9238: fix: #8952 callback function 
params.color incorrect
URL: https://github.com/apache/incubator-echarts/pull/9238
 
 
   maybe a idea, check again please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Ovilia commented on issue #9210: fix #9182 Graph label.rotate is invalid

2018-10-16 Thread GitBox
Ovilia commented on issue #9210: fix #9182 Graphlabel.rotate is invalid
URL: 
https://github.com/apache/incubator-echarts/pull/9210#issuecomment-430143891
 
 
   @100pah please review this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] hamidhasnain opened a new issue #9237: Stacked bars positioned out of the grid when datazoom toolbox feature is used

2018-10-16 Thread GitBox
hamidhasnain opened a new issue #9237: Stacked bars positioned out of the grid 
when datazoom toolbox feature is used
URL: https://github.com/apache/incubator-echarts/issues/9237
 
 
   https://jsfiddle.net/xcfv98eq/
   
   Stacked bar graph when used with datazoom toolbox feature goes out of the 
grid. Without datazoom graph behaves as expected.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli edited a comment on issue #9230: 如何将折线图的拐点按照不同的角度旋转

2018-10-16 Thread GitBox
deqingli edited a comment on issue #9230: 如何将折线图的拐点按照不同的角度旋转
URL: 
https://github.com/apache/incubator-echarts/issues/9230#issuecomment-430134932
 
 
   您好,echarts 官网上有个天气的示例 
,跟您说的需求类似,您可以参考下。示例地址为:http://echarts.baidu.com/examples/editor.html?c=wind-barb


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] zhanghongyublog commented on issue #8091: [FR] Allow valueFactor for axis rendering

2018-10-16 Thread GitBox
zhanghongyublog commented on issue #8091: [FR] Allow valueFactor for axis 
rendering
URL: 
https://github.com/apache/incubator-echarts/issues/8091#issuecomment-430135196
 
 
   How do you use i18n? Please @palmiche 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] deqingli commented on issue #9230: 如何将折线图的拐点按照不同的角度旋转

2018-10-16 Thread GitBox
deqingli commented on issue #9230: 如何将折线图的拐点按照不同的角度旋转
URL: 
https://github.com/apache/incubator-echarts/issues/9230#issuecomment-430134932
 
 
   您好,echarts 官网上有个天气的示例 
http://echarts.baidu.com/examples/editor.html?c=wind-barb,跟您说的需求类似,您可以参考下


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] wangchangqi01 opened a new issue #9235: 鼠标移上去的Tips能不能带箭头小三角?

2018-10-16 Thread GitBox
wangchangqi01 opened a new issue #9235: 鼠标移上去的Tips能不能带箭头小三角?
URL: https://github.com/apache/incubator-echarts/issues/9235
 
 
   
   
   
   ### One-line summary [问题简述]
   
   
   
   
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:
   + Browser version [浏览器类型和版本]:
   + OS Version [操作系统类型和版本]:
   
   
   
   
   
   ### Expected behaviour [期望结果]
   
   
   
   
   
   ### ECharts option [ECharts配置项]
   
   
   ```javascript
   option = {
   
   }
   
   ```
   
   
   
   
   ### Other comments [其他信息]
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] liucrui opened a new issue #9234: echarts只能通过setOption更新数据

2018-10-16 Thread GitBox
liucrui opened a new issue #9234: echarts只能通过setOption更新数据
URL: https://github.com/apache/incubator-echarts/issues/9234
 
 
   
   
   
   ### One-line summary [问题简述]
   改变data中的数据后,想刷新图表,只能通过setOption来重绘,我的树形图手动展开的节点,又恢复了初始化展开的节点
   
   
   
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:4.1
   + Browser version [浏览器类型和版本]:Google Chrome
   + OS Version [操作系统类型和版本]:win10专业版
   
   
   
   
   
   ### Expected behaviour [期望结果]
   能不能不通过setOption方法进行图表重绘,只局部刷新data中的数据亦或者有没有其他好的方法
   
   
   
   
   ### ECharts option [ECharts配置项]
   
   
   ```javascript
   option = {
   
   }
   
   ```
   
   
   
   
   ### Other comments [其他信息]
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



[GitHub] Kevin170113664 commented on issue #3209: 折线(面积)图能不能根据横轴不同区间显示不同颜色区域

2018-10-16 Thread GitBox
Kevin170113664 commented on issue #3209: 折线(面积)图能不能根据横轴不同区间显示不同颜色区域
URL: 
https://github.com/apache/incubator-echarts/issues/3209#issuecomment-430113983
 
 
   > > 来一张效果图
   > > 
![default](https://cloud.githubusercontent.com/assets/841551/16405296/153bcf22-3d39-11e6-880b-92bc03a09d79.png)
   > 
   > @pissang 求问一下你的效果图里晚高峰markArea是怎么取到20:00和22:30这两个点的中间点的。
   > 求相应的echarts option
   
   
噢噢我找到了,这个example在这里:http://www.echartsjs.com/examples/editor.html?c=line-sections
   如果能帮到有需要的人,就好了……


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org