[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882033#comment-15882033
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user sbawaska commented on the issue:

https://github.com/apache/geode-examples/pull/3
  
I think our examples should demonstrate how to use a particular feature and 
not try to show how not to use something.
In this case, I think we could show how partitioning works when you use a 
good hashCode implementation; then demonstrate how to use a PartitionResolver 
to ensure some related keys end up in the same bucket.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-examples issue #3: GEODE-2231 A partitioned region example

[sbawaska]

Github user sbawaska commented on the issue:

https://github.com/apache/geode-examples/pull/3
  
I think our examples should demonstrate how to use a particular feature and 
not try to show how not to use something.
In this case, I think we could show how partitioning works when you use a 
good hashCode implementation; then demonstrate how to use a PartitionResolver 
to ensure some related keys end up in the same bucket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (GEODE-2506) Update spring dependencies

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker closed GEODE-2506.


> Update spring dependencies
> --
>
> Key: GEODE-2506
> URL: https://issues.apache.org/jira/browse/GEODE-2506
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> Update Spring dependencies from 4.3.2 to 4.3.6 to pick up latest maintenance 
> and security fixes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2506) Update spring dependencies

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2506.
--
Resolution: Duplicate

> Update spring dependencies
> --
>
> Key: GEODE-2506
> URL: https://issues.apache.org/jira/browse/GEODE-2506
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> Update Spring dependencies from 4.3.2 to 4.3.6 to pick up latest maintenance 
> and security fixes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2506) Update spring dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882028#comment-15882028
 ] 

ASF GitHub Bot commented on GEODE-2506:
---

Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/403


> Update spring dependencies
> --
>
> Key: GEODE-2506
> URL: https://issues.apache.org/jira/browse/GEODE-2506
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Anthony Baker
>
> Update Spring dependencies from 4.3.2 to 4.3.6 to pick up latest maintenance 
> and security fixes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6

[metatype]

Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/403


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56932: GEODE-2520:Add a lucene query test where a bucket is moved while a query is executing

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56932/#review166648
---


Ship it!




Ship It!

- xiaojian zhou


On Feb. 22, 2017, 5:09 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56932/
> ---
> 
> (Updated Feb. 22, 2017, 5:09 p.m.)
> 
> 
> Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The query should continue to work if a bucket has moved mid query execution.
> 
> Added a spy to move a bucket when "getRepo(bucketId)" is called.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
>  9d45526 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
>  90f1b9f 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java
>  931edc5 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  496721a 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexFactorySpy.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56932/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57001/#review166647
---


Ship it!




Ship It!

- xiaojian zhou


On Feb. 24, 2017, 12:36 a.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57001/
> ---
> 
> (Updated Feb. 24, 2017, 12:36 a.m.)
> 
> 
> Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The following cases are being tested in the newly created 
> PaginationOnPersistentRegionDUnitTest.java:
> 
> 1. The only single data store goes offline while paginating -> expected : 
> NoSuchElementException
> 2. One data store goes offline while one still remains online while 
> paginating -> expected : all keys must be retrieved successfully.
> 3. Two data stores exists but we alternatively shut one down and bring the 
> other up in between getting a page -> expected : all keys must be 
> successfully retrieved.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 6d8278e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57001/diff/
> 
> 
> Testing
> ---
> 
> spotlessApply
> geode-lucene:prechecin
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

[Srikanth Manvi]

> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote:
> > +1 I know this change is good and would be safe commit it as is, however we 
> > have been trying to create UnitTests for any class that we touch that 
> > doesn't already have a UnitTest. As a whole, the project relies too much on 
> > end-to-end tests which take forever to run and tend to be more flaky.
> > 
> > So I still recommend trying to write a UnitTest that at a minimum covers 
> > the method you've modified. My definition of UnitTest here is a very fast 
> > test that uses mocking (Mockito) to mock everything this class method 
> > interacts with and the test does not interact with file system or network. 
> > If this method interacts with file system, then there are generally two 
> > choices: test it in an IntegrationTest or refactor the method to allow you 
> > to UnitTest it in isolation from file system. The test class itself has a 
> > JUnit @Category annotation at the top and  the category is either 
> > UnitTest.class or IntegrationTest.class in this case. 
> > 
> > For testing an exception, I recommend using AssertJ:
> > 
> > assertThatThrownBy(() -> 
> > target.callMethodThatThrows()).isInstanceOf(IllegalStateException.class).hasMessageContaining("resourceTypeId").hasMessageContaining("resourceName");
> > 
> > You could instead use .hasMessage("ResourceType is missing for 
> > resourceTypeId xxx, resourceName yyy") but that does tend to make for a 
> > more brittle test.
> 
> Kirk Lund wrote:
> In this case, you could probably just modify 
> StatArchiveWithMissingResourceTypeRegressionTest
> 
> Kirk Lund wrote:
> Also, the travis CI that's hooked up to the github project for geode is 
> executing test but it doesn't run integrationTest or distributedTest. If you 
> run integrationTest, I think you'll see 
> StatArchiveWithMissingResourceTypeRegressionTest fail due to your change. 
> You'll want to update the assertion in this test:
> ```java
>   @Test // fixed GEODE-2013
>   public void throwsIllegalStateExceptionWithMessage() throws Exception {
> assertThatThrownBy(() -> new StatArchiveReader(new File[] 
> {this.archiveFile}, null, true))
> .isExactlyInstanceOf(IllegalStateException.class) // was 
> NullPointerException
> .hasMessage("ResourceType is missing for resourceTypeId 0"); // 
> was null
>   }
> ```

Hi Kirk,

Thank you for the comments and background around Unit/Integration test options.
I ran ./gradlew build, which was successful, hence I submitted a PR and a 
review request. Later on (many hours after I started precheckin) I noticed that 
the test you mentioned in StatArchiveWithMissingResourceTypeRegressionTest did 
fail. I made changes to the test and pushed a new 
commit(https://github.com/apache/geode/pull/406/commits/56c2a7fce00b5a44d50f1cc8374d1da3ab214344#diff-a74ae4844c1a648682d8a0d297976e31R62).
I had a feeling that I was making the test brittle by using 
`.hasMessage("ResourceType is missing for resourceTypeId 0, resourceName 
statistics1")`;
but at the same I felt it was not too brittle as the gfs file was picked up 
from the 
org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.gfs
 which hasnt changed since creation. 

But I agree, your suggestion of using `.hasMessageContaining(...)` , I will 
incorporate that and will push a new commit.

If you dont mind I have few questions, apologies if this is not the right 
place. 

1. I pushed 1 commit and raised a PR and then submitted this review 
request(https://reviews.apache.org/r/56964/). Later on realized that the 
regression test in StatArchiveWithMissingResourceTypeRegressionTest fails 
because of my change. Hence pushed 1 more commit (part of the same PR 
#406[smanvi-pivotal  wants to merge 2 commits into apache:develop from 
smanvi-pivotal:feature/GEODE-2526]) to fix the test and did not create a new 
review request. Should every commit(pushed at different times before the PR is 
closed) in a PR have its own review request ?

2. For non-committers isn`t opening a PR in github equivalent to opening a 
review request in https://reviews.apache.org ? In future should I keep opening 
review requests along with PRs or is reviews.apache.org mainly for committers ?

3. I let my "./gradlew precheckin" execute for about 5 hrs and it was still not 
complete. Is there anything that I can do to speed it up ? How do regular 
contributors/committers push multiple commits/day if each commit needs to be 
preceeded by a succesfull precheckin ?


- Srikanth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56964/#review166590
---


On Feb. 23, 2017, 3:03 a.m., Srikanth Manvi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> 

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881880#comment-15881880
 ] 

ASF subversion and git services commented on GEODE-2439:


Commit 391d79b97c25e5b710a2880dac89312abee636b8 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=391d79b ]

GEODE-2439: Remove C++ fixed width integers from clicache

This closes #27.


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881879#comment-15881879
 ] 

ASF subversion and git services commented on GEODE-2439:


Commit fd204478b6f73e6d4dc814fd3efeba9d804774ae in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=fd20447 ]

GEODE-2439: Remove int type definitions


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881881#comment-15881881
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/27


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881875#comment-15881875
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@dgkimura I think the GitHub UI would work better if the Geode repo was 
actually hosted in GitHub but since this is a mirror it causes some strange 
behaviors with pull requests.



> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@dgkimura I think the GitHub UI would work better if the Geode repo was 
actually hosted in GitHub but since this is a mirror it causes some strange 
behaviors with pull requests.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56991/
---

(Updated Feb. 24, 2017, 3:12 a.m.)


Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

I am putting this up for review for now. It's a big changeset which includes 
the following JIRA tickets: basically it's using replicated region as a 
communication channel to transfer logs from remote servers to the 
jmx-manager/locator that initiates this command, and then gather all the logs 
as a http response to send it back to the gfsh client:

GEODE-2414: Determine a mechanism to stream a zip file from server to locator
GEODE-2415: Write a function to return a zip file for a single server
GEODE-2414: Create exportLogs region for all locators
GEODE-2418: enable gfsh to download file from http connection


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
 11d74c13311923357e82318b32bf0342e156e0c6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 bbf0542b80469e11d21a2ed56f52ef9e647e91ea 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
 b53c53f91ed63a01bfaa1232d9e194481ae45664 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsTest.java
 PRE-CREATION 
  
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpDunit.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56991/diff/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[jira] [Created] (GEODE-2539) Upgrading Jetty causes RestSecurityIntegrationTest to fail

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2539:


 Summary: Upgrading Jetty causes RestSecurityIntegrationTest to fail
 Key: GEODE-2539
 URL: https://issues.apache.org/jira/browse/GEODE-2539
 Project: Geode
  Issue Type: Bug
  Components: rest (admin), security, tests
Reporter: Kirk Lund


Upgrading our jetty dependency in gradle/dependency-versions.properties:

-jetty.version = 9.3.6.v20151106
+jetty.version = 9.4.0.v20161208

Causes these RestSecurityIntegrationTest tests to fail (possibly 
intermittently):

{noformat}
:geode-assembly:integrationTest

org.apache.geode.rest.internal.web.RestSecurityIntegrationTest > headRegion 
FAILED
org.apache.http.NoHttpResponseException: localhost:21423 failed to respond
at 
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:143)
at 
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:57)
at 
org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:261)
at 
org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:165)
at 
org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:167)
at 
org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:272)
at 
org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:124)
at 
org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:271)
at 
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at 
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at 
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
at 
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:71)
at 
org.apache.geode.rest.internal.web.GeodeRestClient.doRequest(GeodeRestClient.java:161)
at 
org.apache.geode.rest.internal.web.GeodeRestClient.doHEAD(GeodeRestClient.java:104)
at 
org.apache.geode.rest.internal.web.RestSecurityIntegrationTest.headRegion(RestSecurityIntegrationTest.java:246)

org.apache.geode.rest.internal.web.RestSecurityIntegrationTest > testServers 
FAILED
org.apache.http.client.ClientProtocolException
at 
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:186)
at 
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:71)
at 
org.apache.geode.rest.internal.web.GeodeRestClient.doRequest(GeodeRestClient.java:161)
at 
org.apache.geode.rest.internal.web.GeodeRestClient.doGet(GeodeRestClient.java:125)
at 
org.apache.geode.rest.internal.web.RestSecurityIntegrationTest.testServers(RestSecurityIntegrationTest.java:165)

Caused by:
org.apache.http.ProtocolException: The server failed to respond with a 
valid HTTP response
at 
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:151)
at 
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:57)
at 
org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:261)
at 
org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:165)
at 
org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:167)
at 
org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:272)
at 
org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:124)
at 
org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:271)
at 
org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at 
org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at 
org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at 
org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
... 4 more

38 tests completed, 2 failed
:geode-assembly:integrationTest FAILED
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2486) Developer can use encrypted ciphers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881786#comment-15881786
 ] 

ASF GitHub Bot commented on GEODE-2486:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/31

GEODE-2486 Developer can use encrypted ciphers. Modified SSL section …

…to remove prior statement of limitations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit a8430291f1e36a74bcd8c24d749a2933fa48f7f7
Author: Dave Barnes 
Date:   2017-02-24T01:56:01Z

GEODE-2486 Developer can use encrypted ciphers. Modified SSL section to 
remove prior statement of limitations.




> Developer can use encrypted ciphers
> ---
>
> Key: GEODE-2486
> URL: https://issues.apache.org/jira/browse/GEODE-2486
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, native client
>Reporter: Jacob S. Barrett
>
> SSLImpl does not correctly initialize the OpenSSL library so ciphers other 
> than the NULL cipher can be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #31: GEODE-2486 Developer can use encrypted cipher...

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/31

GEODE-2486 Developer can use encrypted ciphers. Modified SSL section …

…to remove prior statement of limitations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit a8430291f1e36a74bcd8c24d749a2933fa48f7f7
Author: Dave Barnes 
Date:   2017-02-24T01:56:01Z

GEODE-2486 Developer can use encrypted ciphers. Modified SSL section to 
remove prior statement of limitations.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2461) Remove unnecessary explicit dependencies

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2461:
-
Description: 
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* cdi-api.version
* hadoop.version*
* hbase.version (remove contains check from geode-assembly)
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version
* spymemcached.version? (remove testCompile from geode-core)

These entries are actually for transitive dependencies and should have the 
explicit dependency removed:

* activation.version
* asm.version (done)
* cglib.version (remove testRuntime from test.gradle)
* classmate (remove compile from geode-web-api)
* mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
* scala.version (remove compile from geode-web-api)



  was:
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* cdi-api.version
* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version
* spymemcached.version? (remove testCompile from geode-core)

These entries are actually for transitive dependencies and should have the 
explicit dependency removed:

* activation.version
* asm.version (done)
* cglib.version
* classmate
* mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
* scala.version




> Remove unnecessary explicit dependencies
> 
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version (remove contains check from geode-assembly)
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version (remove testRuntime from test.gradle)
> * classmate (remove compile from geode-web-api)
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version (remove compile from geode-web-api)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2486) Developer can use encrypted ciphers

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2486:
---
Component/s: docs

> Developer can use encrypted ciphers
> ---
>
> Key: GEODE-2486
> URL: https://issues.apache.org/jira/browse/GEODE-2486
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, native client
>Reporter: Jacob S. Barrett
>
> SSLImpl does not correctly initialize the OpenSSL library so ciphers other 
> than the NULL cipher can be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2538) Lucene query with values should not invoke cache loader

[Dan Smith (JIRA)]

Dan Smith created GEODE-2538:


 Summary: Lucene query with values should not invoke cache loader
 Key: GEODE-2538
 URL: https://issues.apache.org/jira/browse/GEODE-2538
 Project: Geode
  Issue Type: Improvement
  Components: lucene
Reporter: Dan Smith


Lucene queries use getAll to fetch pages when returning values.

If an entry is destroyed after the query has found the list of keys, but before 
the query finds the values, the getAll with trigger a cache loader and reload 
the value. This may be unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2538) Lucene query with values should not invoke cache loader

[Dan Smith (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith reassigned GEODE-2538:


Assignee: Dan Smith

> Lucene query with values should not invoke cache loader
> ---
>
> Key: GEODE-2538
> URL: https://issues.apache.org/jira/browse/GEODE-2538
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Dan Smith
>Assignee: Dan Smith
>
> Lucene queries use getAll to fetch pages when returning values.
> If an entry is destroyed after the query has found the list of keys, but 
> before the query finds the values, the getAll with trigger a cache loader and 
> reload the value. This may be unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2461) Remove unnecessary explicit dependencies

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2461:
-
Summary: Remove unnecessary explicit dependencies  (was: Remove unnecessary 
entries from gradle/dependency-versions.properties)

> Remove unnecessary explicit dependencies
> 
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version
> * classmate
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-2461:


Assignee: Kirk Lund

> Remove unnecessary entries from gradle/dependency-versions.properties
> -
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version
> * classmate
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2461:
-
Description: 
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* cdi-api.version
* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version
* spymemcached.version? (remove testCompile from geode-core)

These entries are actually for transitive dependencies and should have the 
explicit dependency removed:

* activation.version
* asm.version (done)
* cglib.version
* classmate
* mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
* scala.version



  was:
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version

These entries are actually for transitive dependencies and should have explicit 
dependency removed:

* activation.version
* asm.version (done)
* scala.version



> Remove unnecessary entries from gradle/dependency-versions.properties
> -
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version
> * classmate
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2537) Docs: redraw image to remove GemFire label

[Karen Smoler Miller (JIRA)]

Karen Smoler Miller created GEODE-2537:
--

 Summary: Docs: redraw image to remove GemFire label
 Key: GEODE-2537
 URL: https://issues.apache.org/jira/browse/GEODE-2537
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Karen Smoler Miller


The image referenced within the How Delta Propagation Works subsection of 
*both* the Geode and the Geode Native manuals has labels that say 'GemFire.' 
There do not appear to be any source files available, so this gif diagram will 
need to be redrawn, and made available to both repos: geode and geode-native.

The gif for the image is 
- geode-native/docs/geode-native-docs/common/images/delta-propagation.gif
- geode/geode-docs/images/DeltaPropagation-1.gif



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2530) Create DunitTests to tests the effect of dataStores going down while paginating

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-2530.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Create DunitTests to tests the effect of dataStores going down while 
> paginating
> ---
>
> Key: GEODE-2530
> URL: https://issues.apache.org/jira/browse/GEODE-2530
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
> Fix For: 1.2.0
>
>
> Analyze the effect of dataStores going offline while the pages are being 
> extracted / Lucene results are being extracted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2461:
-
Description: 
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version

These entries are actually for transitive dependencies and should have explicit 
dependency removed:

* activation.version
* asm.version (done)
* scala.version


  was:
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version

These entries are actually for transitive dependencies and should have explicit 
dependency removed:

* asm.version (done)
* scala.version



> Remove unnecessary entries from gradle/dependency-versions.properties
> -
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * hadoop.version*
> * hbase.version
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> These entries are actually for transitive dependencies and should have 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * scala.version



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2535) DiskId keyId is not correctly updated

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881659#comment-15881659
 ] 

Darrel Schneider commented on GEODE-2535:
-

Another related bug is code in the same basicUpdate method that uses 
"did.getKeyId()" to determine the current state of the region entry (i.e. if 
the value is inVM or onDisk).
I think the code would be much clearer if we quit negating the recoveredKeyId 
on RecoveredEntry and instead just added a boolean flag to it that lets us say 
we have a value or it is still on disk.
The keyId itself on DiskId should not be mutated; it should be final. The only 
place in the code that calls DiskId.isKeyIdNegative simply makes it positive so 
I think if we just leave it positive all the time the code will be easier to 
understand. basicUpdate will need to be changed to no longer use 
"did.getKeyId()" to determine the current state. But this can be done in the 
same way updateRecoveredEntry does it.

> DiskId keyId is not correctly updated
> -
>
> Key: GEODE-2535
> URL: https://issues.apache.org/jira/browse/GEODE-2535
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Darrel Schneider
>
> On a persistent region the DiskId keyId will be set negative if the value is 
> not in memory but can be read from disk.
> The code correctly sets it the first time an entry is recovered from disk but 
> does not correctly update it if a that same entry is recovered more than once 
> from disk. This can happen when a krf for an oplog does not exist. The same 
> entry can have multiple records for the same key.
> They code that does not correctly update DiskId keyId is in these methods:
> org.apache.geode.internal.cache.DiskEntry.Helper.basicUpdate(DiskEntry, 
> LocalRegion, Object, EntryEventImpl): see the section that handles 
> RecoveredEntry
> and 
> org.apache.geode.internal.cache.DiskEntry.Helper.updateRecoveredEntry(PlaceHolderDiskRegion,
>  DiskEntry, RecoveredEntry, RegionEntryContext)
> The only issue with not updating this keyId is that it can cause the "inVM" 
> and "onDisk" statistics to be incorrect.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2536) DiskId code confusing in how it implements needsToBeWritten

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-2536:
---

 Summary: DiskId code confusing in how it implements 
needsToBeWritten
 Key: GEODE-2536
 URL: https://issues.apache.org/jira/browse/GEODE-2536
 Project: Geode
  Issue Type: Improvement
  Components: persistence
Reporter: Darrel Schneider


DiskId has an abstract method "needsToBeWritten." It is set to true by 
"markForWriting" and set to false by "unmarkForWriting." DiskId has two types 
of implementations: one for overflow only regions and one for persistent 
regions.
The needsToBeWritten only makes sense for overflow only. But the persistent 
DiskIds also implement these methods and do so in a way that can be confused 
with "isKeyIdNegative."

Since markForWriting will only be called for overflow only disk ids I recommend 
that the persistent implementation of this method be changed to always throw an 
exception.

unmarkForWriting may be called on any type of disk id but for persistent ones 
should be changed to do nothing.

needsToBeWritten should be changed to always return false for persistent 
DiskIds since they are immediately written to disk (or scheduled to be written 
if async) by whoever gives them a new value. needsToBeWritten is only called by 
the overflowToDisk method and for a persistent+overflow region it should never 
need to write the value to disk; all it needs to do is remove the value from 
memory since it is written to disk.

The current implementation of these methods on persistent DiskIds do it by 
negating the keyId. Unfortunately this is also done to indicate that the value 
was not recovered from disk.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57001/
---

(Updated Feb. 24, 2017, 12:36 a.m.)


Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and 
xiaojian zhou.


Changes
---

Incorporated the review changes


Repository: geode


Description
---

The following cases are being tested in the newly created 
PaginationOnPersistentRegionDUnitTest.java:

1. The only single data store goes offline while paginating -> expected : 
NoSuchElementException
2. One data store goes offline while one still remains online while paginating 
-> expected : all keys must be retrieved successfully.
3. Two data stores exists but we alternatively shut one down and bring the 
other up in between getting a page -> expected : all keys must be successfully 
retrieved.


Diffs (updated)
-

  geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
6d8278e 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/57001/diff/


Testing
---

spotlessApply
geode-lucene:prechecin


Thanks,

nabarun nag

[jira] [Resolved] (GEODE-2497) surprise members are never timed out during startup

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-2497.
-
Resolution: Fixed

> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56999: GEODE-2534 concurrently started locators fail to create a unified system

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56999/#review166616
---


Ship it!




Ship It!

- Hitesh Khamesra


On Feb. 23, 2017, 9:50 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56999/
> ---
> 
> (Updated Feb. 23, 2017, 9:50 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan and Hitesh Khamesra.
> 
> 
> Bugs: GEODE-2534
> https://issues.apache.org/jira/browse/GEODE-2534
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GMS services were being installed in the locator before they were started, 
> causing the locator to not know its own member ID.  This caused the 
> concurrent startup registry to not contain its member ID, allowing 
> FindCoordinatorResponses to be incorrect.
> 
> * locator A starts location service, installs GMS services w/o ID
> * locator B sends FindCoordinatorRequest to A, gets response saying B should 
> be coordinator
> * locator B starts to become coordinator
> * locator A establishes its ID, sends FindCoordinator request to A & B, gets 
> responses saying A should  be coordinator
> * locator A becomes coordinator with view [A]
> * locator B finishes becoming coordinator with view [B]
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/distributed/Locator.java 
> 2c7c251b3be09309819c4c413436cd47c70970be 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  6d7c5a91fdfbf43b7a9e6305a32f556390d05d3c 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/FindCoordinatorResponse.java
>  8d340070bdf6839b73217879427785502710c3bd 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  c05140d29fbdc26a1e218a9c393f3ba5bed81089 
>   geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 
> da0daeb5f85a7c3aeb484ce1db820b9a96dd2f2e 
> 
> Diff: https://reviews.apache.org/r/56999/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2461:
-
Description: 
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version

These entries are actually for transitive dependencies and should have explicit 
dependency removed:

* asm.version (done)
* scala.version


  was:
These unused entries are potential candidates for removal from 
gradle/dependency-versions.properties:

* hadoop.version*
* hbase.version
* hibernate.version
* hibernate-commons-annotations.version
* hsqldb.version
* jline.version
* jsr305.version
* paranamer.version
* quartz.version


> Remove unnecessary entries from gradle/dependency-versions.properties
> -
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * hadoop.version*
> * hbase.version
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> These entries are actually for transitive dependencies and should have 
> explicit dependency removed:
> * asm.version (done)
> * scala.version



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881609#comment-15881609
 ] 

ASF subversion and git services commented on GEODE-2497:


Commit 42f733fc3b2dfda134d5fde7fbde97c124cead9e in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=42f733f ]

GEODE-2497: surprise members are never timed out during startup

fixed NPE caused by previous fix


> surprise members are never timed out during startup
> ---
>
> Key: GEODE-2497
> URL: https://issues.apache.org/jira/browse/GEODE-2497
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> A system was observed to hang during startup when a "surprise member" was 
> added but then never timed out.  The system hung waiting for a response to a 
> startup message sent to the surprise member.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2491) Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881608#comment-15881608
 ] 

ASF subversion and git services commented on GEODE-2491:


Commit 369cab034d667d83bc41c7cd4e93470ab826c386 in geode's branch 
refs/heads/develop from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=369cab0 ]

GEODE-2491 - Don't suppress IOExceptions when writing to the lucene index

Generic IOExceptions should not be suppressed, they may indicate a real
problem, not just bucket movement.


> Reduce logging of handled exceptions in LuceneEventListener and 
> LuceneBucketListeners
> -
>
> Key: GEODE-2491
> URL: https://issues.apache.org/jira/browse/GEODE-2491
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Currently we handle specific exception types but continue to log them as 
> warnings.  Instead we should probably log them at a debug level so they won't 
> show up in regular usage of the product because we do expect these exceptions 
> to be thrown/caught for certain scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881604#comment-15881604
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@echobravopapa Done


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

[dgkimura]

Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@echobravopapa Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2522) Refactor Lucene D Unit tests

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2522.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Refactor Lucene D Unit tests
> 
>
> Key: GEODE-2522
> URL: https://issues.apache.org/jira/browse/GEODE-2522
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> Currently our dunit tests for lucene are organized as a tree heirarchy based 
> on region types.  This makes it difficult to add a tests for a specific type 
> of region type as other test files can possibly extend the file we add the 
> test to.
> Instead we can use parameterized tests and flatten the heirarchy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

[Kirk Lund]

> On Feb. 23, 2017, 11:09 p.m., Kevin Duling wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java,
> >  lines 47-55
> > 
> >
> > Incomplete javadoc.  It should be either filled out or omitted.

There's also another empty @return here that I missed


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56991/#review166599
---


On Feb. 23, 2017, 6:01 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56991/
> ---
> 
> (Updated Feb. 23, 2017, 6:01 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I am putting this up for review for now. It's a big changeset which includes 
> the following JIRA tickets: basically it's using replicated region as a 
> communication channel to transfer logs from remote servers to the 
> jmx-manager/locator that initiates this command, and then gather all the logs 
> as a http response to send it back to the gfsh client:
> 
> GEODE-2414: Determine a mechanism to stream a zip file from server to locator
> GEODE-2415: Write a function to return a zip file for a single server
> GEODE-2414: Create exportLogs region for all locators
> GEODE-2418: enable gfsh to download file from http connection
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 
> a20fba5a1b9fa185283bd7c60c4ade77345ed4ac 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/AbstractCliAroundInterceptor.java
>  de24727819856d180a69ed0021c21aa016e71712 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
>  11d74c13311923357e82318b32bf0342e156e0c6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
>  8525b5862274cbaa98e57455869d404465851291 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandRequest.java
>  b0242c9e8ee656001cf76155f4e727ece07666a2 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
>  bbf0542b80469e11d21a2ed56f52ef9e647e91ea 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  c536e8e99ef32043d9caf267dd563ee2d05b6e50 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
>  b53c53f91ed63a01bfaa1232d9e194481ae45664 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ExportLogsCacheWriter.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ExportLogsRepository.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogExporter.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogFilter.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogLevelExtractor.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/MergeLogs.java
>  8d2ef4599337cb091da6f26c6034b1a71311148d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ZipUtils.java
>  81161d6f3e2539ca3d09765e99b891d1522da302 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/MiscellaneousCommandsController.java
>  ac912c82c873c443dd268f07e8874b5bd18fdd0b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
>  fa052489772e3e03eb865d17dbbcb7e227813c42 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/shell/RestHttpOperationInvoker.java
>  82b2b1fc0d2c8952835b0101c413161d39f361dc 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/shell/SimpleHttpOperationInvoker.java
>  dcda27bef61bad1d7caf1fe1a99063f99d768819 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/CommandRequestTest.java
>  543623766b3422d63a1c3ceca38229144c94076b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnit.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java
>  2fc8e844d319abcf19430cfb9cd09e2a64aab38c 
>   
> 

[jira] [Created] (GEODE-2535) DiskId keyId is not correctly updated

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-2535:
---

 Summary: DiskId keyId is not correctly updated
 Key: GEODE-2535
 URL: https://issues.apache.org/jira/browse/GEODE-2535
 Project: Geode
  Issue Type: Bug
  Components: persistence
Reporter: Darrel Schneider


On a persistent region the DiskId keyId will be set negative if the value is 
not in memory but can be read from disk.
The code correctly sets it the first time an entry is recovered from disk but 
does not correctly update it if a that same entry is recovered more than once 
from disk. This can happen when a krf for an oplog does not exist. The same 
entry can have multiple records for the same key.

They code that does not correctly update DiskId keyId is in these methods:
org.apache.geode.internal.cache.DiskEntry.Helper.basicUpdate(DiskEntry, 
LocalRegion, Object, EntryEventImpl): see the section that handles 
RecoveredEntry
and 
org.apache.geode.internal.cache.DiskEntry.Helper.updateRecoveredEntry(PlaceHolderDiskRegion,
 DiskEntry, RecoveredEntry, RegionEntryContext)

The only issue with not updating this keyId is that it can cause the "inVM" and 
"onDisk" statistics to be incorrect.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57001/#review166609
---


Fix it, then Ship it!





geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
 (line 76)


You only need to flush from one member.



geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
 (line 92)


Maybe use ExpectedException for this.


- Dan Smith


On Feb. 23, 2017, 10:24 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57001/
> ---
> 
> (Updated Feb. 23, 2017, 10:24 p.m.)
> 
> 
> Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The following cases are being tested in the newly created 
> PaginationOnPersistentRegionDUnitTest.java:
> 
> 1. The only single data store goes offline while paginating -> expected : 
> NoSuchElementException
> 2. One data store goes offline while one still remains online while 
> paginating -> expected : all keys must be retrieved successfully.
> 3. Two data stores exists but we alternatively shut one down and bring the 
> other up in between getting a page -> expected : all keys must be 
> successfully retrieved.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 6d8278e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57001/diff/
> 
> 
> Testing
> ---
> 
> spotlessApply
> geode-lucene:prechecin
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

[Kirk Lund]

> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote:
> > +1 I know this change is good and would be safe commit it as is, however we 
> > have been trying to create UnitTests for any class that we touch that 
> > doesn't already have a UnitTest. As a whole, the project relies too much on 
> > end-to-end tests which take forever to run and tend to be more flaky.
> > 
> > So I still recommend trying to write a UnitTest that at a minimum covers 
> > the method you've modified. My definition of UnitTest here is a very fast 
> > test that uses mocking (Mockito) to mock everything this class method 
> > interacts with and the test does not interact with file system or network. 
> > If this method interacts with file system, then there are generally two 
> > choices: test it in an IntegrationTest or refactor the method to allow you 
> > to UnitTest it in isolation from file system. The test class itself has a 
> > JUnit @Category annotation at the top and  the category is either 
> > UnitTest.class or IntegrationTest.class in this case. 
> > 
> > For testing an exception, I recommend using AssertJ:
> > 
> > assertThatThrownBy(() -> 
> > target.callMethodThatThrows()).isInstanceOf(IllegalStateException.class).hasMessageContaining("resourceTypeId").hasMessageContaining("resourceName");
> > 
> > You could instead use .hasMessage("ResourceType is missing for 
> > resourceTypeId xxx, resourceName yyy") but that does tend to make for a 
> > more brittle test.
> 
> Kirk Lund wrote:
> In this case, you could probably just modify 
> StatArchiveWithMissingResourceTypeRegressionTest

Also, the travis CI that's hooked up to the github project for geode is 
executing test but it doesn't run integrationTest or distributedTest. If you 
run integrationTest, I think you'll see 
StatArchiveWithMissingResourceTypeRegressionTest fail due to your change. 
You'll want to update the assertion in this test:
```java
  @Test // fixed GEODE-2013
  public void throwsIllegalStateExceptionWithMessage() throws Exception {
assertThatThrownBy(() -> new StatArchiveReader(new File[] 
{this.archiveFile}, null, true))
.isExactlyInstanceOf(IllegalStateException.class) // was 
NullPointerException
.hasMessage("ResourceType is missing for resourceTypeId 0"); // was null
  }
```


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56964/#review166590
---


On Feb. 23, 2017, 3:03 a.m., Srikanth Manvi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56964/
> ---
> 
> (Updated Feb. 23, 2017, 3:03 a.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Enhanced the log statement to include the ResourceType Name.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
>  9fba511 
> 
> Diff: https://reviews.apache.org/r/56964/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srikanth Manvi
> 
>

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

[Kirk Lund]

> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote:
> > +1 I know this change is good and would be safe commit it as is, however we 
> > have been trying to create UnitTests for any class that we touch that 
> > doesn't already have a UnitTest. As a whole, the project relies too much on 
> > end-to-end tests which take forever to run and tend to be more flaky.
> > 
> > So I still recommend trying to write a UnitTest that at a minimum covers 
> > the method you've modified. My definition of UnitTest here is a very fast 
> > test that uses mocking (Mockito) to mock everything this class method 
> > interacts with and the test does not interact with file system or network. 
> > If this method interacts with file system, then there are generally two 
> > choices: test it in an IntegrationTest or refactor the method to allow you 
> > to UnitTest it in isolation from file system. The test class itself has a 
> > JUnit @Category annotation at the top and  the category is either 
> > UnitTest.class or IntegrationTest.class in this case. 
> > 
> > For testing an exception, I recommend using AssertJ:
> > 
> > assertThatThrownBy(() -> 
> > target.callMethodThatThrows()).isInstanceOf(IllegalStateException.class).hasMessageContaining("resourceTypeId").hasMessageContaining("resourceName");
> > 
> > You could instead use .hasMessage("ResourceType is missing for 
> > resourceTypeId xxx, resourceName yyy") but that does tend to make for a 
> > more brittle test.

In this case, you could probably just modify 
StatArchiveWithMissingResourceTypeRegressionTest


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56964/#review166590
---


On Feb. 23, 2017, 3:03 a.m., Srikanth Manvi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56964/
> ---
> 
> (Updated Feb. 23, 2017, 3:03 a.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Enhanced the log statement to include the ResourceType Name.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
>  9fba511 
> 
> Diff: https://reviews.apache.org/r/56964/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srikanth Manvi
> 
>

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881560#comment-15881560
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@dgkimura yes, you want to handle all that locally... it was just your turn 
to fall for Github's siren song


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881557#comment-15881557
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@pivotal-jbarrett Yes.  Shall I redo?  I had decided to use the github UI 
to resolve conflict and that's how it came out.  I guess that's what I get for 
leaving the terminal?


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

[dgkimura]

Github user dgkimura commented on the issue:

https://github.com/apache/geode-native/pull/27
  
@pivotal-jbarrett Yes.  Shall I redo?  I had decided to use the github UI 
to resolve conflict and that's how it came out.  I guess that's what I get for 
leaving the terminal?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881540#comment-15881540
 ] 

ASF GitHub Bot commented on GEODE-2532:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/30
  
The C++ integration test framework keeps the test files in a directory 
specific to the current test. Can we not do the same thing here and avoid this 
random thing?


> .NET Integration Tests Create Temp Files in the Source Directory
> 
>
> Key: GEODE-2532
> URL: https://issues.apache.org/jira/browse/GEODE-2532
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
> Attachments: ExtraneousTempFiles.jpg
>
>
> The C++/CLI integration tests create temporary .xml files in the src 
> directory as shown in attachment. This pollutes your working area with files 
> that should not be added to the repo. 
> This task is to create these temp files in the runtime test folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881536#comment-15881536
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/27
  
A rebase would have been preferable to a merge.


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/27
  
A rebase would have been preferable to a merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56991/#review166599
---



Kirk did a very comprehensive review.  I only have this to add after that.


geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
 (lines 47 - 55)


Incomplete javadoc.  It should be either filled out or omitted.


- Kevin Duling


On Feb. 23, 2017, 10:01 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56991/
> ---
> 
> (Updated Feb. 23, 2017, 10:01 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I am putting this up for review for now. It's a big changeset which includes 
> the following JIRA tickets: basically it's using replicated region as a 
> communication channel to transfer logs from remote servers to the 
> jmx-manager/locator that initiates this command, and then gather all the logs 
> as a http response to send it back to the gfsh client:
> 
> GEODE-2414: Determine a mechanism to stream a zip file from server to locator
> GEODE-2415: Write a function to return a zip file for a single server
> GEODE-2414: Create exportLogs region for all locators
> GEODE-2418: enable gfsh to download file from http connection
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 
> a20fba5a1b9fa185283bd7c60c4ade77345ed4ac 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/AbstractCliAroundInterceptor.java
>  de24727819856d180a69ed0021c21aa016e71712 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
>  11d74c13311923357e82318b32bf0342e156e0c6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
>  8525b5862274cbaa98e57455869d404465851291 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandRequest.java
>  b0242c9e8ee656001cf76155f4e727ece07666a2 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
>  bbf0542b80469e11d21a2ed56f52ef9e647e91ea 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  c536e8e99ef32043d9caf267dd563ee2d05b6e50 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
>  b53c53f91ed63a01bfaa1232d9e194481ae45664 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ExportLogsCacheWriter.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ExportLogsRepository.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogExporter.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogFilter.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogLevelExtractor.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/MergeLogs.java
>  8d2ef4599337cb091da6f26c6034b1a71311148d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ZipUtils.java
>  81161d6f3e2539ca3d09765e99b891d1522da302 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/MiscellaneousCommandsController.java
>  ac912c82c873c443dd268f07e8874b5bd18fdd0b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
>  fa052489772e3e03eb865d17dbbcb7e227813c42 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/shell/RestHttpOperationInvoker.java
>  82b2b1fc0d2c8952835b0101c413161d39f361dc 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/shell/SimpleHttpOperationInvoker.java
>  dcda27bef61bad1d7caf1fe1a99063f99d768819 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/CommandRequestTest.java
>  543623766b3422d63a1c3ceca38229144c94076b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnit.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java
>  2fc8e844d319abcf19430cfb9cd09e2a64aab38c 
>   
> 

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #482 was SUCCESSFUL (with 1679 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #482 was successful.
---
Scheduled
1681 tests in total.

https://build.spring.io/browse/SGF-NAG-482/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57001/#review166593
---




geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
 (line 43)


Not sure but maybe just name it PaginationDUnitTest.  Then we can have 
tests that don't handle pagination but not necessarily with Persistent regions 
in the same class?
It would just require the @Parameters(values="PARTITION") or whatever.



geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
 (line 134)


maybe pull out the 4 into a variable?  Is this value affecting or affected 
by the number of entries put into the region and/or page size?


- Jason Huynh


On Feb. 23, 2017, 10:24 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57001/
> ---
> 
> (Updated Feb. 23, 2017, 10:24 p.m.)
> 
> 
> Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The following cases are being tested in the newly created 
> PaginationOnPersistentRegionDUnitTest.java:
> 
> 1. The only single data store goes offline while paginating -> expected : 
> NoSuchElementException
> 2. One data store goes offline while one still remains online while 
> paginating -> expected : all keys must be retrieved successfully.
> 3. Two data stores exists but we alternatively shut one down and bring the 
> other up in between getting a page -> expected : all keys must be 
> successfully retrieved.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
> 6d8278e 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57001/diff/
> 
> 
> Testing
> ---
> 
> spotlessApply
> geode-lucene:prechecin
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57001/
---

Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and 
xiaojian zhou.


Repository: geode


Description
---

The following cases are being tested in the newly created 
PaginationOnPersistentRegionDUnitTest.java:

1. The only single data store goes offline while paginating -> expected : 
NoSuchElementException
2. One data store goes offline while one still remains online while paginating 
-> expected : all keys must be retrieved successfully.
3. Two data stores exists but we alternatively shut one down and bring the 
other up in between getting a page -> expected : all keys must be successfully 
retrieved.


Diffs
-

  geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java 
6d8278e 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/57001/diff/


Testing
---

spotlessApply
geode-lucene:prechecin


Thanks,

nabarun nag

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56964/#review166590
---



+1 I know this change is good and would be safe commit it as is, however we 
have been trying to create UnitTests for any class that we touch that doesn't 
already have a UnitTest. As a whole, the project relies too much on end-to-end 
tests which take forever to run and tend to be more flaky.

So I still recommend trying to write a UnitTest that at a minimum covers the 
method you've modified. My definition of UnitTest here is a very fast test that 
uses mocking (Mockito) to mock everything this class method interacts with and 
the test does not interact with file system or network. If this method 
interacts with file system, then there are generally two choices: test it in an 
IntegrationTest or refactor the method to allow you to UnitTest it in isolation 
from file system. The test class itself has a JUnit @Category annotation at the 
top and  the category is either UnitTest.class or IntegrationTest.class in this 
case. 

For testing an exception, I recommend using AssertJ:

assertThatThrownBy(() -> 
target.callMethodThatThrows()).isInstanceOf(IllegalStateException.class).hasMessageContaining("resourceTypeId").hasMessageContaining("resourceName");

You could instead use .hasMessage("ResourceType is missing for resourceTypeId 
xxx, resourceName yyy") but that does tend to make for a more brittle test.

- Kirk Lund


On Feb. 23, 2017, 3:03 a.m., Srikanth Manvi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56964/
> ---
> 
> (Updated Feb. 23, 2017, 3:03 a.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Enhanced the log statement to include the ResourceType Name.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
>  9fba511 
> 
> Diff: https://reviews.apache.org/r/56964/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srikanth Manvi
> 
>

[jira] [Resolved] (GEODE-2508) Generize lib naming

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2508.
-
Resolution: Fixed

> Generize lib naming
> ---
>
> Key: GEODE-2508
> URL: https://issues.apache.org/jira/browse/GEODE-2508
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Ernest Burghardt
>
> Make naming configurable



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-2440.
-
Resolution: Fixed

> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56991/#review166581
---



My main input overall is to create a UnitTest using mocking for every new 
class. It would be ideal to create UnitTests for every existing class we 
modify. The only exception is classes that primarily interact with file system 
or threads -- IntegrationTesting of those is probably sufficient.


geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
 (line 36)


Delete empty @return



geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
 (line 50)


Delete empty @param tags



geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
 (line 54)


Delete empty @return



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 (line 128)


Add final qualifier



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 (line 761)


Delete printStackTrace call. The logger.error will print the stack trace.



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 (line 768)


I realize this is just moved, but I'd go ahead and change to:

lopgger.debug("Exporting logs returning = {}", result);



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 (line 797)


Most of the command functions we inherited do something like this but it 
loses the stack trace. I think we want to consider using the full 
stackTrackAsString -- example:

result = ResultBuilder.createGemFireErrorResult(CliStrings.SHOW_LOG_ERROR + 
CliUtil.stackTraceAsString(e));

Better yet use sendException (I marked a later line where you use 
getResult().sendException() and I think that's the pattern we want to change 
all command functions to use.



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 (line 1037)


What's #SB? I know it used to be this string as well, but maybe we should 
change it?



geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
 (line 97)


This is the best syntax for sending an exception back from a Function. 
Change my earlier recommendations from using CliUtil.stackTraceAsString to 
using sendException instead.



geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
 (line 243)


Replace with logger.error(e);



geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
 (line 282)


Preferred syntax is:

if (Path.class.isInstance(response)) {

(I don't think it matters which syntax we use tho)



geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ExportLogsCacheWriter.java
 (line 31)


As we write new classes (or even edit old classes), we really need to be 
disciplines about creating true unit tests that mock every collaborator. I 
think being test driven is more important than pairing. This changes the design 
of classes and gets us away from having to rely so much on end-to-end tests.



geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ExportLogsRepository.java
 (line 21)


Should this be an Interface instead of a Class? This seems wrong. At a 
minimum, I'd expect it to be abstract, but I would delete "Map exportFiles" 
since this class doesn't use it. The highest subclass that uses this var should 
define it.



geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogExporter.java
 (line 46)


Classes like this don't lend well to mocking for a unit test so it's ok for 
this to be an exception to the overall recommendation of being unit test 
driven. Lowest level test would be an integration test since this interacts 
with files.



geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterTest.java
 (line 100)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881382#comment-15881382
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102831481
  
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public 
LocalRegion {
CacheableVectorPtr routingObj, uint8_t getResult,
ResultCollectorPtr rc, int32_t retryAttempts,
uint32_t timeout = DEFAULT_QUERY_RESPONSE_TIMEOUT);
-  GfErrType getFuncAttributes(const char* func, std::vector** attr);
+  GfErrType getFuncAttributes(const char* func, std::vector** 
attr);
--- End diff --

new goal, be a 0 Star Programmer


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56989: Adding an exception listener for the last lucene exception

[Dan Smith]

> On Feb. 23, 2017, 7:30 p.m., Jason Huynh wrote:
> > Looks good.  Would it be helpful to add which event caused the exception as 
> > well?

That might be a good idea - although it some cases it might not be a single 
event, but the whole batch. If we want that I can add it in a later commit.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56989/#review166556
---


On Feb. 23, 2017, 5:21 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56989/
> ---
> 
> (Updated Feb. 23, 2017, 5:21 p.m.)
> 
> 
> Review request for geode, Jason Huynh and Lynn Hughes-Godfrey.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a way for tests to observe the last seen exception from the
> LuceneAsyncEventListener.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
>  4a6a8358033a9ed0525b8b66f1b899b3b99728f7 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneExceptionObserver.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneEventListenerJUnitTest.java
>  2b7af4a8bd3db8bfe9886250f2aa0f0c48fca7f6 
> 
> Diff: https://reviews.apache.org/r/56989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

[jira] [Resolved] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling resolved GEODE-2457.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

> Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> ---
>
> Key: GEODE-2457
> URL: https://issues.apache.org/jira/browse/GEODE-2457
> Project: Geode
>  Issue Type: Wish
>  Components: general
>Reporter: Kirk Lund
>Assignee: Kevin Duling
> Fix For: 1.2.0
>
>
> Replace use of org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils.
> Delete org.apache.geode.internal.FileUtil.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling reassigned GEODE-2457:
---

Assignee: Kevin Duling  (was: Kirk Lund)

> Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> ---
>
> Key: GEODE-2457
> URL: https://issues.apache.org/jira/browse/GEODE-2457
> Project: Geode
>  Issue Type: Wish
>  Components: general
>Reporter: Kirk Lund
>Assignee: Kevin Duling
> Fix For: 1.2.0
>
>
> Replace use of org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils.
> Delete org.apache.geode.internal.FileUtil.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56999: GEODE-2534 concurrently started locators fail to create a unified system

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56999/
---

Review request for geode, Galen O'Sullivan and Hitesh Khamesra.


Bugs: GEODE-2534
https://issues.apache.org/jira/browse/GEODE-2534


Repository: geode


Description
---

GMS services were being installed in the locator before they were started, 
causing the locator to not know its own member ID.  This caused the concurrent 
startup registry to not contain its member ID, allowing 
FindCoordinatorResponses to be incorrect.

* locator A starts location service, installs GMS services w/o ID
* locator B sends FindCoordinatorRequest to A, gets response saying B should be 
coordinator
* locator B starts to become coordinator
* locator A establishes its ID, sends FindCoordinator request to A & B, gets 
responses saying A should  be coordinator
* locator A becomes coordinator with view [A]
* locator B finishes becoming coordinator with view [B]


Diffs
-

  geode-core/src/main/java/org/apache/geode/distributed/Locator.java 
2c7c251b3be09309819c4c413436cd47c70970be 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 6d7c5a91fdfbf43b7a9e6305a32f556390d05d3c 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/FindCoordinatorResponse.java
 8d340070bdf6839b73217879427785502710c3bd 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
 c05140d29fbdc26a1e218a9c393f3ba5bed81089 
  geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 
da0daeb5f85a7c3aeb484ce1db820b9a96dd2f2e 

Diff: https://reviews.apache.org/r/56999/diff/


Testing
---


Thanks,

Bruce Schuchardt

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881327#comment-15881327
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102826049
  
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const 
char* statName,
  FieldType 
statDescriptorType,
  const char* 
statDescription,
  const char* statUnit,
- int8 statIsStatCounter,
- int8 
statIsStatLargerBetter) {
+ int8_t statIsStatCounter,
--- End diff --

Done!


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102826049
  
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const 
char* statName,
  FieldType 
statDescriptorType,
  const char* 
statDescription,
  const char* statUnit,
- int8 statIsStatCounter,
- int8 
statIsStatLargerBetter) {
+ int8_t statIsStatCounter,
--- End diff --

Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881324#comment-15881324
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102825954
  
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void 
HostStatHelperSolaris::refreshProcess(ProcessStats* processStats) {
 }
 close(fPtr);
   }
-  ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32)thePid);
+  ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32_t)thePid);
--- End diff --

Done!


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102825954
  
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void 
HostStatHelperSolaris::refreshProcess(ProcessStats* processStats) {
 }
 close(fPtr);
   }
-  ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32)thePid);
+  ACE_OS::snprintf(procFileName, 64, "/proc/%u/usage", (uint32_t)thePid);
--- End diff --

Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881322#comment-15881322
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102825863
  
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
 
 class RegionStatType {
  private:
-  static int8 instanceFlag;
+  static int8_t instanceFlag;
--- End diff --

Done!


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881323#comment-15881323
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102825908
  
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory 
{
   Statistics* createStatistics(StatisticsType* type, const char* textId);
 
   Statistics* createStatistics(StatisticsType* type, const char* textId,
-   int64 numericId);
+   int64_t numericId);
 
   Statistics* createOsStatistics(StatisticsType* type, const char* textId,
- int64 numericId);
+ int64_t numericId);
 
   Statistics* createAtomicStatistics(StatisticsType* type);
 
   Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId);
 
   Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId,
- int64 numericId);
+ int64_t numericId);
 
   // StatisticsFactory methods: Statistics Type
   //--
   StatisticsType* createType(const char* name, const char* description,
- StatisticDescriptor** stats, int32 
statsLength);
+ StatisticDescriptor** stats, int32_t 
statsLength);
 
   StatisticsType* findType(const char* name);
 
   // StatisticsFactory methods: Statistics Descriptor
   //-
   StatisticDescriptor* createIntCounter(const char* name,
 const char* description,
-const char* units, int8 
largerBetter);
+const char* units, int8_t 
largerBetter);
--- End diff --

Done!


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102825908
  
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory 
{
   Statistics* createStatistics(StatisticsType* type, const char* textId);
 
   Statistics* createStatistics(StatisticsType* type, const char* textId,
-   int64 numericId);
+   int64_t numericId);
 
   Statistics* createOsStatistics(StatisticsType* type, const char* textId,
- int64 numericId);
+ int64_t numericId);
 
   Statistics* createAtomicStatistics(StatisticsType* type);
 
   Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId);
 
   Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId,
- int64 numericId);
+ int64_t numericId);
 
   // StatisticsFactory methods: Statistics Type
   //--
   StatisticsType* createType(const char* name, const char* description,
- StatisticDescriptor** stats, int32 
statsLength);
+ StatisticDescriptor** stats, int32_t 
statsLength);
 
   StatisticsType* findType(const char* name);
 
   // StatisticsFactory methods: Statistics Descriptor
   //-
   StatisticDescriptor* createIntCounter(const char* name,
 const char* description,
-const char* units, int8 
largerBetter);
+const char* units, int8_t 
largerBetter);
--- End diff --

Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102825863
  
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
 
 class RegionStatType {
  private:
-  static int8 instanceFlag;
+  static int8_t instanceFlag;
--- End diff --

Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881317#comment-15881317
 ] 

ASF GitHub Bot commented on GEODE-2532:
---

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/30
  
@echobravopapa There is an inconsistency in how a few of the tests compute 
the path for the configured xml file. After inspection, there didn't appear to 
be a simple high level way to fix this. My proposed fix is to fix it in the 
isolated file that causes the problem.


> .NET Integration Tests Create Temp Files in the Source Directory
> 
>
> Key: GEODE-2532
> URL: https://issues.apache.org/jira/browse/GEODE-2532
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
> Attachments: ExtraneousTempFiles.jpg
>
>
> The C++/CLI integration tests create temporary .xml files in the src 
> directory as shown in attachment. This pollutes your working area with files 
> that should not be added to the repo. 
> This task is to create these temp files in the runtime test folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

[mmartell]

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/30
  
@echobravopapa There is an inconsistency in how a few of the tests compute 
the path for the configured xml file. After inspection, there didn't appear to 
be a simple high level way to fix this. My proposed fix is to fix it in the 
isolated file that causes the problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56986: GEODE-2497 surprise members are never timed out during startu

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56986/#review166579
---


Ship it!




Ship It!

- Hitesh Khamesra


On Feb. 23, 2017, 4:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56986/
> ---
> 
> (Updated Feb. 23, 2017, 4:17 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan and Hitesh Khamesra.
> 
> 
> Bugs: GEODE-2497
> https://issues.apache.org/jira/browse/GEODE-2497
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> fixing NPE hit by tests using disable-tcp=true.  In this configuration there 
> is no dclistener in the membership manager but there _is_ a listener.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
>  d0a0cbed9c895af26dfba9c5d5ca7fe50b195a30 
> 
> Diff: https://reviews.apache.org/r/56986/diff/
> 
> 
> Testing
> ---
> 
> precheckin, disable-tcp=true testing
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[jira] [Commented] (GEODE-2460) Update dependency versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881304#comment-15881304
 ] 

ASF subversion and git services commented on GEODE-2460:


Commit 384ab6d49cf6182e8a805941f0731046b722cdc3 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=384ab6d ]

GEODE-2460: update dependency versions and notices

* remove non-transitive declaration of org.ow2.asm:asm:5.1
* update to it.unimi.dsi:fastutil:7.1.0
* update to org.apache.httpcomponents:httpclient:4.5.3
* update to io.netty:netty-all:4.1.8.Final
* update to com.tdunning:json:1.8
* update to org.slf4j:slf4j-api:1.7.23
* update to org.springframework.hateoas:spring-hateoas:0.23.0.RELEASE
* update to org.springframework.ldap:spring-ldap-core:2.3.1.RELEASE
* update to org.springframework.security:spring-security-config:4.2.1.RELEASE
* update to org.springframework.security:spring-security-core:4.2.1.RELEASE
* update to org.springframework.security:spring-security-ldap:4.2.1.RELEASE
* update to org.springframework.security:spring-security-web:4.2.1.RELEASE
* update to org.springframework:spring-aspects:4.3.6.RELEASE
* update to org.springframework:spring-beans:4.3.6.RELEASE
* update to org.springframework:spring-context:4.3.6.RELEASE
* update to org.springframework:spring-core:4.3.6.RELEASE
* update to org.springframework:spring-expression:4.3.6.RELEASE
* update to org.springframework:spring-oxm:4.3.6.RELEASE
* update to org.springframework:spring-test:4.3.6.RELEASE
* update to org.springframework:spring-tx:4.3.6.RELEASE
* update to org.springframework:spring-web:4.3.6.RELEASE
* update to org.springframework:spring-webmvc:4.3.6.RELEASE
* update to io.springfox:springfox-swagger2:2.6.1
* update to io.springfox:springfox-swagger-ui:2.6.1


> Update dependency versions
> --
>
> Key: GEODE-2460
> URL: https://issues.apache.org/jira/browse/GEODE-2460
> Project: Geode
>  Issue Type: Wish
>  Components: build, docs
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Here's the first bunch of dependency version updates that passes precheckin 
> without modifying source code:
> Update the following dependency versions defined in
> gradle/dependency-versions.properties.
> Update major versions (test-only):
> * org.apache.bcel:bcel:6.0
> Update minor versions (test and main):
> * commons-beanutils:1.9.3 
> * commons-fileupload:1.3.2 
> * commons-io:2.5 
> * commons-lang:2.6
> * commons-logging:1.2
> * commons-modeler:2.0.1
> * fastutil:7.0.13
> * guava:21.0
> * jansi:1.14
> * javax.mail-api:1.4.7
> * jline:2.14.3
> * jopt-simple:5.0.3
> * log4j-api:2.7
> * log4j-core:2.7
> * log4j-jcl:2.7
> * log4j-jul:2.7
> * log4j-slf4j-impl:2.7
> * netty-all:4.1.7.Final
> * shiro-core:1.3.2
> * slf4j-api:1.7.22
> Update minor versions (test-only):
> * assertj-core:3.6.2
> * cglib:cglib:3.2.4
> * commons-configuration:1.10
> * derby:10.13.1.1
> * google-gson:2.8.0
> * httpclient:4.5.2
> * httpcore:4.4.6
> * hsqldb:2.3.4
> * javassist:3.21.0-GA
> * jedis:2.9.0
> * JUnitParams:1.0.6
> * mockrunner:1.1.2
> * mortbay-jetty-servlet-api:2.5.20110712
> * phantomjsdriver:1.3.0
> * powermock-core:1.6.6
> * powermock-module-junit4:1.6.6
> * powermock-api-mockito:1.6.6
> * selenium-api:3.0.1
> * selenium-remote-driver:3.0.1
> * selenium-support:3.0.1
> * spymemcached:2.12.2
> * system-rules:1.16.1
> * tomcat-catalina:7.0.73 (tomcat7)
> * tomcat-coyote:7.0.73 (tomcat7)
> * tomcat-juli:7.0.73 (tomcat7)
> * tomcat-catalina:8.5.9 (tomcat8)
> * tomcat-coyote:8.5.9 (tomcat8)
> * tomcat-juli:8.5.9 (tomcat8)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881301#comment-15881301
 ] 

ASF GitHub Bot commented on GEODE-2532:
---

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/30
  
The xml files are created in the runtime working directory. For a Debug 
build this is:
BUILD_DIR\clicache\integration-test\Debug, where BUILD_DIR is the cmake 
build directory.

This fix moves those few xml files that were being created in the source 
directory to the working directory to be consistent with the rest of the tests.


> .NET Integration Tests Create Temp Files in the Source Directory
> 
>
> Key: GEODE-2532
> URL: https://issues.apache.org/jira/browse/GEODE-2532
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
> Attachments: ExtraneousTempFiles.jpg
>
>
> The C++/CLI integration tests create temporary .xml files in the src 
> directory as shown in attachment. This pollutes your working area with files 
> that should not be added to the repo. 
> This task is to create these temp files in the runtime test folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

[mmartell]

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/30
  
The xml files are created in the runtime working directory. For a Debug 
build this is:
BUILD_DIR\clicache\integration-test\Debug, where BUILD_DIR is the cmake 
build directory.

This fix moves those few xml files that were being created in the source 
directory to the working directory to be consistent with the rest of the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/30
  
@pivotal-jbarrett good question, @mmartell where do the files go to now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881242#comment-15881242
 ] 

ASF GitHub Bot commented on GEODE-2532:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/30
  
@pivotal-jbarrett good question, @mmartell where do the files go to now?


> .NET Integration Tests Create Temp Files in the Source Directory
> 
>
> Key: GEODE-2532
> URL: https://issues.apache.org/jira/browse/GEODE-2532
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
> Attachments: ExtraneousTempFiles.jpg
>
>
> The C++/CLI integration tests create temporary .xml files in the src 
> directory as shown in attachment. This pollutes your working area with files 
> that should not be added to the repo. 
> This task is to create these temp files in the runtime test folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102813470
  
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
 
 class RegionStatType {
  private:
-  static int8 instanceFlag;
+  static int8_t instanceFlag;
--- End diff --

Turns out all this instanceFlag variables are unused. Please delete them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881224#comment-15881224
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/27#discussion_r102813470
  
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
 
 class RegionStatType {
  private:
-  static int8 instanceFlag;
+  static int8_t instanceFlag;
--- End diff --

Turns out all this instanceFlag variables are unused. Please delete them.


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #29: GEODE-2480: Correct the version of CMake.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/29


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881220#comment-15881220
 ] 

ASF GitHub Bot commented on GEODE-2532:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/30
  
Does this change create the xml files in each of the individual integration 
test's runtime directory of the root of the all the tests?


> .NET Integration Tests Create Temp Files in the Source Directory
> 
>
> Key: GEODE-2532
> URL: https://issues.apache.org/jira/browse/GEODE-2532
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
> Attachments: ExtraneousTempFiles.jpg
>
>
> The C++/CLI integration tests create temporary .xml files in the src 
> directory as shown in attachment. This pollutes your working area with files 
> that should not be added to the repo. 
> This task is to create these temp files in the runtime test folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/30
  
Does this change create the xml files in each of the individual integration 
test's runtime directory of the root of the all the tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881215#comment-15881215
 ] 

ASF GitHub Bot commented on GEODE-2480:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/29


> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is *4.3* or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "*3.4* or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881214#comment-15881214
 ] 

ASF subversion and git services commented on GEODE-2480:


Commit 8e3db6f31948336e85fdfe1b810bb8a00207bb09 in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=8e3db6f ]

GEODE-2480: Correct the version of CMake.

This closes #29.


> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is *4.3* or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "*3.4* or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881209#comment-15881209
 ] 

ASF subversion and git services commented on GEODE-2440:


Commit 71c34a8010ac6cb8f4583d51d6e787cef9792b00 in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=71c34a8 ]

GEODE-2440: Switch hashcode() return type.

- Conver from unit32_t to int32_t to match server.


> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881210#comment-15881210
 ] 

ASF subversion and git services commented on GEODE-2440:


Commit 6cfb76843179f220772786493b3dfdfca53e638e in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=6cfb768 ]

GEODE-2440: Missed conversion of a few internal hashCode types.


> Fix CacheableKey::hashcode to int32_t to match Server.
> --
>
> Key: GEODE-2440
> URL: https://issues.apache.org/jira/browse/GEODE-2440
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #28: Feature/geode 2440

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #481 has FAILED

[John Blum]

Hi Mark-

Thank you for your attention to this matter.

I do not rebase SD Geode on Apache Geode 1.2.0 build snapshots (
1.2.0-SNAPSHOT) until I release SD Geode 1.1.0.RELEASE based on Apache
Geode 1.1.0 (release).

2 things...

1. Because Apache infra deletes (build) snapshots after a release (which I
would say is a questionable practice, actually), the *Spring* team has
created a geode-snapshot (cache)

[1]
in the *Spring* Artifactory (repo) server.

Currently the SD Geode Nightly build is not picking up these "cached" geode
snapshots from [1] because the SD Geode POM is incorrect and pointed at the
wrong *Spring* repo currently

[2]
(i.e. libs-milestone and not libs-snapshot as it should); my mistake.

2. Regardless of #1, I have already based SD Geode on Apache Geode 1.1.0
(release).  I have just not checked in yet as I am currently in the middle
of wrapping up *Lucene Index/Search* support in SD Geode.

I am hoping to have this finished EOD today.

Thanks,
John


[1]
https://repo.spring.io/webapp/#/artifacts/browse/tree/General/geode-snapshot
[2]
https://github.com/spring-projects/spring-data-gemfire/blob/apache-geode/pom.xml#L34-L37


On Thu, Feb 23, 2017 at 12:13 PM, Mark Bretl  wrote:

> John,
>
> It looks like this is failing because it can't find the
> geode-*-1.1.0-SNAPSHOT.jars. As 1.1.0 has been released, we have removed
> these jars. Next version is currently 1.2.0(-SNAPSHOT).
>
> Would you or someone else be able to update this job?
>
> Thanks,
>
> --Mark
>
>
> On Thu, Feb 23, 2017 at 11:51 AM, Spring CI  wrote:
>
>>
>> ---
>> Spring Data GemFire > Nightly-ApacheGeode > #481 failed.
>> ---
>> This was manually triggered by Trevor Marshall.
>> No failed tests found, a possible compilation error.
>>
>> https://build.spring.io/browse/SGF-NAG-481/
>>
>> -
>> Currently Responsible
>> -
>>
>> No one is responsible for fixing this build.
>>
>>
>>
>> --
>> Failing Jobs
>> --
>>   - Default Job (Default Stage): No tests found.
>>
>>
>>
>>
>> --
>> This message is automatically generated by Atlassian Bamboo
>
>
>


-- 
-John
john.blum10101 (skype)

[GitHub] geode-native pull request #28: Feature/geode 2440

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/28#discussion_r102809166
  
--- Diff: 
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -236,8 +236,8 @@ DUNIT_TASK_DEFINITION(CLIENT1, 
CheckPrSingleHopForIntKeysTask_REGION)
 
   try {
 LOGDEBUG("CPPTEST: Putting key %d with hashcode %d", i,
- static_cast(keyPtr->hashcode()));
-dataReg->put(keyPtr, static_cast(keyPtr->hashcode()));
+ keyPtr->hashcode());
--- End diff --

Nothing better than seeing casting removed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #481 has FAILED

[Mark Bretl]

John,

It looks like this is failing because it can't find the
geode-*-1.1.0-SNAPSHOT.jars. As 1.1.0 has been released, we have removed
these jars. Next version is currently 1.2.0(-SNAPSHOT).

Would you or someone else be able to update this job?

Thanks,

--Mark

On Thu, Feb 23, 2017 at 11:51 AM, Spring CI  wrote:

>
> ---
> Spring Data GemFire > Nightly-ApacheGeode > #481 failed.
> ---
> This was manually triggered by Trevor Marshall.
> No failed tests found, a possible compilation error.
>
> https://build.spring.io/browse/SGF-NAG-481/
>
> -
> Currently Responsible
> -
>
> No one is responsible for fixing this build.
>
>
>
> --
> Failing Jobs
> --
>   - Default Job (Default Stage): No tests found.
>
>
>
>
> --
> This message is automatically generated by Atlassian Bamboo

Re: Review Request 56986: GEODE-2497 surprise members are never timed out during startu

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56986/#review166563
---




geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
 (line 980)


Is it worth checking for dcReceiver after this? Do you know what the 
difference is?


- Galen O'Sullivan


On Feb. 23, 2017, 4:17 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56986/
> ---
> 
> (Updated Feb. 23, 2017, 4:17 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan and Hitesh Khamesra.
> 
> 
> Bugs: GEODE-2497
> https://issues.apache.org/jira/browse/GEODE-2497
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> fixing NPE hit by tests using disable-tcp=true.  In this configuration there 
> is no dclistener in the membership manager but there _is_ a listener.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
>  d0a0cbed9c895af26dfba9c5d5ca7fe50b195a30 
> 
> Diff: https://reviews.apache.org/r/56986/diff/
> 
> 
> Testing
> ---
> 
> precheckin, disable-tcp=true testing
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

a new example needs your review

[Karen Miller]

Calling all Geode devs:

I've put together a new, and quite basic example that attempts to
demonstrate
what partitioning does.  Please review and see the PR at
  https://github.com/apache/geode-examples/pull/3

When reviewing this example, please keep in mind that my goal is to
tightly focus on partitioning, so it really doesn't do too much.  Other
(future)
examples will demonstrate other and more complex aspects of using or
developing
with Geode.

Here's the comment I placed in the PR, as you'd want to see this in order to
run the example yourself:

  This example intends to demonstrate what partitioning does (distributes
> entries across buckets, and therefore across servers). It also illustrates
> what goes wrong when a bad hashcode is used, such that all entries end up
> in the same bucket.
> Running the example is explained in the partitioned/README.md file. It
> assumes that the reader has already read and followed the minimal
> directions in the README.md file at the root of the geode-examples repo.

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #481 has FAILED

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #481 failed.
---
This was manually triggered by Trevor Marshall.
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-481/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

[jira] [Commented] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881104#comment-15881104
 ] 

ASF subversion and git services commented on GEODE-2457:


Commit 29246ab7f136e6bd8c91d055980a6ed639ad60e6 in geode's branch 
refs/heads/develop from [~kduling]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=29246ab ]

GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
org.apache.commons.io.FileUtils


> Replace org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils
> ---
>
> Key: GEODE-2457
> URL: https://issues.apache.org/jira/browse/GEODE-2457
> Project: Geode
>  Issue Type: Wish
>  Components: general
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Replace use of org.apache.geode.internal.FileUtil with 
> org.apache.commons.io.FileUtils.
> Delete org.apache.geode.internal.FileUtil.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/
---

(Updated Feb. 23, 2017, 11:41 a.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

GEODE-2457: Replace org.apache.geode.internal.FileUtil with 
org.apache.commons.io.FileUtils


Diffs
-

  
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java
 e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f 
  geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java 
b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java
 a96f8afe75675bb733956cf28bc129e6a7c23b25 
  geode-core/src/main/java/org/apache/geode/internal/FileUtil.java 
2d729303a27179876e2f8a96c0542d796f426e16 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
e53aa5d55437116dc466e551c793af87f24012df 
  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
270c8335a88c48fd3b036b65b50d7fd2b7734a81 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java
 a71394139cd8cc4582122f2d587d0f4434b9ce12 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
 e4e5467383ed0cdfa31efa10864f7eb56362f8d5 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java
 86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee 
  
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java
 20d1c4ff92fbd54956334c923e1bacfea8825aa6 
  geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java 
7bb94ef92c8a641ae87bb6cdbe7b91b379427371 
  
geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java
 f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 
  geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java 
2d6921b9a2087928dffebd2dc050f3967170962b 
  
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 66c4ecfce12c20cd4b1d3e363aa66206d947b8ef 
  
geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java
 f126146d3098f009eda8388273b52758b7d0ee28 
  
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java
 01151931473e882905a4443535f2c2306e34ff63 
  geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java 
942059e110487f3f886ef5749134190768a87eac 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
22f66a3efdb670684c0108ab22dc07c43e0265b1 
  
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 3852dee6613dd67ed85d61365c7ad6ca02306f78 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java 
00bb6fb9064b46ef5622e7e11632a36ec71097dd 
  
geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java 
1d18ed146382e36c894c72ab642e8055fd316df1 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java 
4057069cf4c61bc843e7957b6bcb3be6335a0e5e 
  geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java 
cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java 
10931e194d20369350720736a4435aa5998ca0cc 
  geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java 
a89c0d13ececb47bf7345624d4e7d128e01d6a45 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java
 6955dc829330f8766c172da32795fd8ee6b98f7e 
  
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java
 55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 
  
geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
 9c459a9b737fc80d7a7cd0242927abf2691855b3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java 
138f3acc5abb96831af60a43560334494793d60b 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJUnitTest.java
 2529639f200e3670cb7d108f70e2c0e9a3702401 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java
 478f5e3f8827b78bc5aba5449698ce3fd3768b6c 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 47520bc8177feecf70dc0ede5a17607385b90dd3 
  
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java
 09893be48c4dd0dbd9fadb8a07484e2e84430ee7 
  

[jira] [Updated] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

[Joey McAllister (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joey McAllister updated GEODE-2480:
---
Component/s: (was: docs)

> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is *4.3* or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "*3.4* or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56990: Lowering the log level for errors when cleaning up the index repository

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56990/#review166557
---


Ship it!




Ship It!

- Jason Huynh


On Feb. 23, 2017, 5:22 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56990/
> ---
> 
> (Updated Feb. 23, 2017, 5:22 p.m.)
> 
> 
> Review request for geode and Jason Huynh.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Because we pull the rug out from under the IndexWriter when a member is
> no longer primary, we may get exceptions back while trying to close the
> writer.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  8a68b07ebb9f83ce13da6c7922525fca113ae092 
> 
> Diff: https://reviews.apache.org/r/56990/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>