Re: [discussion] openejb-itests in testsuite
David,
Can you please apply this patch as well.
* It reorders the execution of itests and modules.
* it configures the whole jar plugin to skip adding maven artifacts.
Thanx
prasad
On 11/20/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
https://issues.apache.org/jira/browse/OPENEJB-305 is ready.
The java files from the OPENEJB-302 patch were not applied. Hence the
plans kept failing.
I have the same changes in the above patches too. Please apply them.
I have merged the cmp2 plans with itests-core.
Without the prefetch plan, the other 3 cmp2 plans when merged with
itests-core deploy and starts succeessfully
There is a problem with prefetch plan. After merging it, the jar fails
to start. See log in JIRA. Help needed here please !
Caused by: org.tranql.ql.QueryException: Finder [Finder
method=[findPrefetchAll]; EJB-QL=[
SELECT OBJECT(o) FROM Order AS o WHERE o.id = ?1
]]
at
org.tranql.sql.EJBQLToPhysicalQuery.buildFinder(EJBQLToPhysicalQuery.java:143)
at
org.tranql.sql.EJBQLToPhysicalQuery.buildFinders(EJBQLToPhysicalQuery.java:90)
... 86 more
Caused by: org.tranql.ql.QueryException: Finder does not return the
right abstract schema type.
at
org.tranql.sql.EJBQLToPhysicalQuery.buildFinder(EJBQLToPhysicalQuery.java:137)
... 87 more
Thanx
Prasad
On 11/16/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 14, 2006, at 8:47 AM, Prasad Kashyap wrote:
I began by migrating just the itests-core DDs and then deployed it.
It distributed the artifact but failed to start it.
I hit the following error.
http://rifers.org/paste/show/2308
Can you please decipher this unknown reason error for me ? These DDs
worked fine when I submitted the patch earlier. The only small diff
between the DD then and now is the adjustment for the modified pkg
structure (o.a.openejb)
The patch for the migrated DD is attached here.
Hmm, unfortunately I don't know what the unknown reason is
either.. Is there something in your logs that has more detail?
(hoping that what was posted wasn't the logs :)
-David
Thanx
Prasad
On 11/13/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
Thanks for these comments, David.
https://issues.apache.org/jira/browse/OPENEJB-302#action_12448245
I'll create an ejbcontainer-testsuite now.
Thanx
Prasad
On 11/4/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
David,
Can you please review and apply the patch here -
https://issues.apache.org/jira/browse/OPENEJB-302
Thanx
Prasad
On 11/3/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb.
I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework
integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As
stated above,
there
would be many child modules for the beans under the
itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion
above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests
artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it
is in 3.x.
For now, I shall put all the tests into 1 artifact
module. We
should
look at breaking them and putting them with their
Re: [discussion] openejb-itests in testsuite
On Nov 21, 2006, at 11:08 AM, Prasad Kashyap wrote:
David,
Can you please apply this patch as well.
* It reorders the execution of itests and modules.
* it configures the whole jar plugin to skip adding maven artifacts.
I applied what you described on IRC, let me know if that's not right.
Thanx
prasad
On 11/20/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
https://issues.apache.org/jira/browse/OPENEJB-305 is ready.
The java files from the OPENEJB-302 patch were not applied. Hence the
plans kept failing.
I have the same changes in the above patches too. Please apply them.
I have merged the cmp2 plans with itests-core.
Without the prefetch plan, the other 3 cmp2 plans when merged with
itests-core deploy and starts succeessfully
There is a problem with prefetch plan. After merging it, the jar
fails
to start. See log in JIRA. Help needed here please !
Caused by: org.tranql.ql.QueryException: Finder [Finder
method=[findPrefetchAll]; EJB-QL=[
SELECT OBJECT(o) FROM Order AS o WHERE o.id = ?1
]]
at org.tranql.sql.EJBQLToPhysicalQuery.buildFinder
(EJBQLToPhysicalQuery.java:143)
at org.tranql.sql.EJBQLToPhysicalQuery.buildFinders
(EJBQLToPhysicalQuery.java:90)
... 86 more
Caused by: org.tranql.ql.QueryException: Finder does not return the
right abstract schema type.
at org.tranql.sql.EJBQLToPhysicalQuery.buildFinder
(EJBQLToPhysicalQuery.java:137)
... 87 more
Thanx
Prasad
On 11/16/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 14, 2006, at 8:47 AM, Prasad Kashyap wrote:
I began by migrating just the itests-core DDs and then
deployed it.
It distributed the artifact but failed to start it.
I hit the following error.
http://rifers.org/paste/show/2308
Can you please decipher this unknown reason error for me ?
These DDs
worked fine when I submitted the patch earlier. The only small
diff
between the DD then and now is the adjustment for the modified
pkg
structure (o.a.openejb)
The patch for the migrated DD is attached here.
Hmm, unfortunately I don't know what the unknown reason is
either.. Is there something in your logs that has more detail?
(hoping that what was posted wasn't the logs :)
-David
Thanx
Prasad
On 11/13/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
Thanks for these comments, David.
https://issues.apache.org/jira/browse/
OPENEJB-302#action_12448245
I'll create an ejbcontainer-testsuite now.
Thanx
Prasad
On 11/4/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
David,
Can you please review and apply the patch here -
https://issues.apache.org/jira/browse/OPENEJB-302
Thanx
Prasad
On 11/3/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single
module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from
openejb.
I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework
integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED]
wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As
stated above,
there
would be many child modules for the beans under the
itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our
discussion
above, the
contents of the openejb directory in m2 local repo
are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests
artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it
Re: [discussion] openejb-itests in testsuite
https://issues.apache.org/jira/browse/OPENEJB-305 is ready.
The java files from the OPENEJB-302 patch were not applied. Hence the
plans kept failing.
I have the same changes in the above patches too. Please apply them.
I have merged the cmp2 plans with itests-core.
Without the prefetch plan, the other 3 cmp2 plans when merged with
itests-core deploy and starts succeessfully
There is a problem with prefetch plan. After merging it, the jar fails
to start. See log in JIRA. Help needed here please !
Caused by: org.tranql.ql.QueryException: Finder [Finder
method=[findPrefetchAll]; EJB-QL=[
SELECT OBJECT(o) FROM Order AS o WHERE o.id = ?1
]]
at
org.tranql.sql.EJBQLToPhysicalQuery.buildFinder(EJBQLToPhysicalQuery.java:143)
at
org.tranql.sql.EJBQLToPhysicalQuery.buildFinders(EJBQLToPhysicalQuery.java:90)
... 86 more
Caused by: org.tranql.ql.QueryException: Finder does not return the
right abstract schema type.
at
org.tranql.sql.EJBQLToPhysicalQuery.buildFinder(EJBQLToPhysicalQuery.java:137)
... 87 more
Thanx
Prasad
On 11/16/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 14, 2006, at 8:47 AM, Prasad Kashyap wrote:
I began by migrating just the itests-core DDs and then deployed it.
It distributed the artifact but failed to start it.
I hit the following error.
http://rifers.org/paste/show/2308
Can you please decipher this unknown reason error for me ? These DDs
worked fine when I submitted the patch earlier. The only small diff
between the DD then and now is the adjustment for the modified pkg
structure (o.a.openejb)
The patch for the migrated DD is attached here.
Hmm, unfortunately I don't know what the unknown reason is
either.. Is there something in your logs that has more detail?
(hoping that what was posted wasn't the logs :)
-David
Thanx
Prasad
On 11/13/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
Thanks for these comments, David.
https://issues.apache.org/jira/browse/OPENEJB-302#action_12448245
I'll create an ejbcontainer-testsuite now.
Thanx
Prasad
On 11/4/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
David,
Can you please review and apply the patch here -
https://issues.apache.org/jira/browse/OPENEJB-302
Thanx
Prasad
On 11/3/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb.
I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework
integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As
stated above,
there
would be many child modules for the beans under the
itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion
above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests
artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it
is in 3.x.
For now, I shall put all the tests into 1 artifact
module. We
should
look at breaking them and putting them with their
respective bean
modules later on.
What's the issue with doing that now?
-David
itests-core.patch
Re: [discussion] openejb-itests in testsuite
On Nov 14, 2006, at 8:47 AM, Prasad Kashyap wrote:
I began by migrating just the itests-core DDs and then deployed it.
It distributed the artifact but failed to start it.
I hit the following error.
http://rifers.org/paste/show/2308
Can you please decipher this unknown reason error for me ? These DDs
worked fine when I submitted the patch earlier. The only small diff
between the DD then and now is the adjustment for the modified pkg
structure (o.a.openejb)
The patch for the migrated DD is attached here.
Hmm, unfortunately I don't know what the unknown reason is
either.. Is there something in your logs that has more detail?
(hoping that what was posted wasn't the logs :)
-David
Thanx
Prasad
On 11/13/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
Thanks for these comments, David.
https://issues.apache.org/jira/browse/OPENEJB-302#action_12448245
I'll create an ejbcontainer-testsuite now.
Thanx
Prasad
On 11/4/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
David,
Can you please review and apply the patch here -
https://issues.apache.org/jira/browse/OPENEJB-302
Thanx
Prasad
On 11/3/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb.
I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework
integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As
stated above,
there
would be many child modules for the beans under the
itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion
above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests
artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it
is in 3.x.
For now, I shall put all the tests into 1 artifact
module. We
should
look at breaking them and putting them with their
respective bean
modules later on.
What's the issue with doing that now?
-David
itests-core.patch
Re: [discussion] openejb-itests in testsuite
Thanks for these comments, David.
https://issues.apache.org/jira/browse/OPENEJB-302#action_12448245
I'll create an ejbcontainer-testsuite now.
Thanx
Prasad
On 11/4/06, Prasad Kashyap [EMAIL PROTECTED] wrote:
David,
Can you please review and apply the patch here -
https://issues.apache.org/jira/browse/OPENEJB-302
Thanx
Prasad
On 11/3/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb. I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As stated above,
there
would be many child modules for the beans under the itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it is in 3.x.
For now, I shall put all the tests into 1 artifact module. We
should
look at breaking them and putting them with their respective bean
modules later on.
What's the issue with doing that now?
-David
Re: [discussion] openejb-itests in testsuite
David,
Can you please review and apply the patch here -
https://issues.apache.org/jira/browse/OPENEJB-302
Thanx
Prasad
On 11/3/06, David Blevins [EMAIL PROTECTED] wrote:
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb. I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As stated above,
there
would be many child modules for the beans under the itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it is in 3.x.
For now, I shall put all the tests into 1 artifact module. We
should
look at breaking them and putting them with their respective bean
modules later on.
What's the issue with doing that now?
-David
Re: [discussion] openejb-itests in testsuite
On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are
manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb. I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework integrated
with the G build.
That's fine. We can do that part later.
-David
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As stated above,
there
would be many child modules for the beans under the itests
parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it is in 3.x.
For now, I shall put all the tests into 1 artifact module. We
should
look at breaking them and putting them with their respective bean
modules later on.
What's the issue with doing that now?
-David
Re: [discussion] openejb-itests in testsuite
OK. Sounds good. o.a.openejb it would be.
The reasons I want to leave the tests in one single module are manifold.
1) That is how they are today.
2) To split them, it would have to be someone from openejb. I have no
idea how they are structured.
3) My top priority now is to get the testsuite framework integrated
with the G build.
Cheers
Prasad
On 11/1/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As stated above,
there
would be many child modules for the beans under the itests parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it is in 3.x.
For now, I shall put all the tests into 1 artifact module. We should
look at breaking them and putting them with their respective bean
modules later on.
What's the issue with doing that now?
-David
Re: [discussion] openejb-itests in testsuite
On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be
org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As stated above,
there
would be many child modules for the beans under the itests parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests artifacts one
level down to groupId o.a.openejb.itests ?
Let's keep it in o.a.openejb for now as that's the way it is in 3.x.
For now, I shall put all the tests into 1 artifact module. We should
look at breaking them and putting them with their respective bean
modules later on.
What's the issue with doing that now?
-David
Re: [discussion] openejb-itests in testsuite
On 10/30/06, David Blevins [EMAIL PROTECTED] wrote:
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote:
Thanx. Please see comments inline -
Couple thoughts on the poms:
- the parent would lineage would be org.apache.openejb:itests -
org.apache.openejb:openejb
- the groupId would be org.apache.openejb
The groupId and the parent lineage looks good. As stated above, there
would be many child modules for the beans under the itests parent
module
groupId: o.a.openejb
openejb - itests - itests-security-xxx
openejb - itests - itests-cmp2-xxx
Exactly.
After having built the itest beans as per our discussion above, the
contents of the openejb directory in m2 local repo are -
${settings.localRepository}/org/apache/openejb/
itests-cmp2-cmrmapping
itests-cmp2-petstore
itests-cmp2-prefetch
itests-cmp2-storage
itests-itests-core
itests-security-001
itests-security-002
itests-security-003
openejb
openejb-builder
openejb-corba
openejb-corba-builder
openejb-core
openejb-itests
openejb-pkgen-builder
openejb-sunorb
openejb-yoko
Does this look good ? Or should we move the itests artifacts one
level down to groupId o.a.openejb.itests ?
-David
For now, I shall put all the tests into 1 artifact module. We should
look at breaking them and putting them with their respective bean
modules later on.
Cheers
Prasad.
Re: [discussion] openejb-itests in testsuite
On 10/31/06, Prasad Kashyap [EMAIL PROTECTED] wrote: Does this look good ? Or should we move the itests artifacts one level down to groupId o.a.openejb.itests ? It'd be great to move the itests one level below. Jacek -- Jacek Laskowski http://www.jaceklaskowski.pl
Re: [discussion] openejb-itests in testsuite
Thanx. Please see comments inline - Cheers Prasad On 10/27/06, David Blevins [EMAIL PROTECTED] wrote: Ok, I took look through where you're going and here's a slightly altered proposal. We group the tests with the beans as such: openejb-footests/src/main/# this is where the beans will go openejb-footests/src/test/# this is where the client test code will go Do you propose putting all the beans in one single module and thus one single ejb-jar ? The many plans that we use forces us to have multiple jars and thus separate modules(poms) for each. This is why I had the beans spread across multiple modules. We setup the poms to package and publish the test code with the beans: http://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html +1. I like this idea. It keeps the tests code with the beans. In geronimo/testsuite/ejbcontainer-testsuite, I can just get this test-jar, expand it and run the tests in them. That will avoid spreading the code for a single test between two modules and avoids the bucket module that would contain all test client code for all modules and would needlessly have a dependency on all modules. Couple thoughts on the poms: - the parent would lineage would be org.apache.openejb:itests - org.apache.openejb:openejb - the groupId would be org.apache.openejb The groupId and the parent lineage looks good. As stated above, there would be many child modules for the beans under the itests parent module groupId: o.a.openejb openejb - itests - itests-security-xxx openejb - itests - itests-cmp2-xxx You and put any geronimo-specific plugins, descriptors, or dependencies in pom.xmls (modules) in geronimo svn using any layout you choose. Those modules would just declare dependencies on the openejb test libraries they wish to reuse. That should be fine unless you also plan to redo all the test source code to something other than junit or introduce code dependencies on geronimo-specific bits of test framework. If that's the ultimate goal, then it might just be better to take a copy of the test code. Well, the other tests in geronimo are written in TestNG. Until we move to JDK 1.5, it doesn't make sense to move the openejb itests to TestNG. The annotations all have to change. Moreover, it may not make practical sense to move these 400+ tests from junit to TestNG. So we may stay with this arrangement. But IF ever we do so for any reason, then yes, we should make another copy of the test code. Thoughts? -David Thanx Prasad
Re: [discussion] openejb-itests in testsuite
On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote: Thanx. Please see comments inline - Cheers Prasad On 10/27/06, David Blevins [EMAIL PROTECTED] wrote: Ok, I took look through where you're going and here's a slightly altered proposal. We group the tests with the beans as such: openejb-footests/src/main/# this is where the beans will go openejb-footests/src/test/# this is where the client test code will go Do you propose putting all the beans in one single module and thus one single ejb-jar ? I meant one of the above for each set of beans/tests/descriptors. We setup the poms to package and publish the test code with the beans: http://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html +1. I like this idea. It keeps the tests code with the beans. In geronimo/testsuite/ejbcontainer-testsuite, I can just get this test-jar, expand it and run the tests in them. That will avoid spreading the code for a single test between two modules and avoids the bucket module that would contain all test client code for all modules and would needlessly have a dependency on all modules. Couple thoughts on the poms: - the parent would lineage would be org.apache.openejb:itests - org.apache.openejb:openejb - the groupId would be org.apache.openejb The groupId and the parent lineage looks good. As stated above, there would be many child modules for the beans under the itests parent module groupId: o.a.openejb openejb - itests - itests-security-xxx openejb - itests - itests-cmp2-xxx Exactly. You and put any geronimo-specific plugins, descriptors, or dependencies in pom.xmls (modules) in geronimo svn using any layout you choose. Those modules would just declare dependencies on the openejb test libraries they wish to reuse. That should be fine unless you also plan to redo all the test source code to something other than junit or introduce code dependencies on geronimo-specific bits of test framework. If that's the ultimate goal, then it might just be better to take a copy of the test code. Well, the other tests in geronimo are written in TestNG. Until we move to JDK 1.5, it doesn't make sense to move the openejb itests to TestNG. The annotations all have to change. Moreover, it may not make practical sense to move these 400+ tests from junit to TestNG. So we may stay with this arrangement. But IF ever we do so for any reason, then yes, we should make another copy of the test code. Sounds like a plan. -David
Re: [discussion] openejb-itests in testsuite
On 10/28/06, David Blevins [EMAIL PROTECTED] wrote: Ok, I took look through where you're going and here's a slightly altered proposal. We group the tests with the beans as such: openejb-footests/src/main/# this is where the beans will go openejb-footests/src/test/# this is where the client test code will go We setup the poms to package and publish the test code with the beans: http://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html That will avoid spreading the code for a single test between two modules and avoids the bucket module that would contain all test client code for all modules and would needlessly have a dependency on all modules. That sound very promising. I like it. Couple thoughts on the poms: - the parent would lineage would be org.apache.openejb:itests - org.apache.openejb:openejb - the groupId would be org.apache.openejb Unless I'm mistaken, it implies that itests are a submodule of the top-level module of OpenEJB, doesn't it? If so, I'm fine with it, too. You and put any geronimo-specific plugins, descriptors, or dependencies in pom.xmls (modules) in geronimo svn using any layout you choose. Those modules would just declare dependencies on the openejb test libraries they wish to reuse. Does it mean that Geronimo tests would be dependent on OpenEJB? These should be separate as much as possible. If there's no other way, let's start with it and think about it later. That should be fine unless you also plan to redo all the test source code to something other than junit or introduce code dependencies on geronimo-specific bits of test framework. That's what I didn't catch. What do you mean by that? Jacek -- Jacek Laskowski http://www.jaceklaskowski.pl
Re: [discussion] openejb-itests in testsuite
http://people.apache.org/~prasad/ejb-modules.zip You may remove the parent from the top level pom and adjust the groupId appropriately to build this. Cheers Prasad On 10/25/06, David Blevins [EMAIL PROTECTED] wrote: Great, I'll be looking forward to it. -David On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb-itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
On Oct 27, 2006, at 7:34 AM, Prasad Kashyap wrote: http://people.apache.org/~prasad/ejb-modules.zip You may remove the parent from the top level pom and adjust the groupId appropriately to build this. Looks like you have the beans in there. Where is the test code? -David Cheers Prasad On 10/25/06, David Blevins [EMAIL PROTECTED] wrote: Great, I'll be looking forward to it. -David On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb- itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/ msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
I haven't changed the test code at all. It is essentially the same as it is in the openejb-itests module. Neverthless, here it is. http://people.apache.org/~prasad/test-ejbcontainer.zip I have simply moved it under geronimo/testsuite/ejbcontainer-testsuite/test-ejbcontainer and have ensured that it compiles fine. The reason I didn't bring it up for discussion is because it has to be located under the testsuite directory by convention. The beans can be built anywhere and the ejb-jars made available in the repo. Hence this discussion. Thanx David. Cheers Prasad On 10/27/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 27, 2006, at 7:34 AM, Prasad Kashyap wrote: http://people.apache.org/~prasad/ejb-modules.zip You may remove the parent from the top level pom and adjust the groupId appropriately to build this. Looks like you have the beans in there. Where is the test code? -David Cheers Prasad On 10/25/06, David Blevins [EMAIL PROTECTED] wrote: Great, I'll be looking forward to it. -David On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb- itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/ msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
On Oct 27, 2006, at 10:20 AM, Prasad Kashyap wrote: I haven't changed the test code at all. It is essentially the same as it is in the openejb-itests module. Neverthless, here it is. http://people.apache.org/~prasad/test-ejbcontainer.zip I have simply moved it under geronimo/testsuite/ejbcontainer-testsuite/test-ejbcontainer and have ensured that it compiles fine. The reason I didn't bring it up for discussion is because it has to be located under the testsuite directory by convention. The beans can be built anywhere and the ejb-jars made available in the repo. Hence this discussion. I get Forbidden: You don't have permission to access /~prasad/test- ejbcontainer.zip on this server. -David Thanx David. Cheers Prasad On 10/27/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 27, 2006, at 7:34 AM, Prasad Kashyap wrote: http://people.apache.org/~prasad/ejb-modules.zip You may remove the parent from the top level pom and adjust the groupId appropriately to build this. Looks like you have the beans in there. Where is the test code? -David Cheers Prasad On 10/25/06, David Blevins [EMAIL PROTECTED] wrote: Great, I'll be looking forward to it. -David On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb- itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/ msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
Please try now. Sorry 'bout that. Cheers Prasad On 10/27/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 27, 2006, at 10:20 AM, Prasad Kashyap wrote: I haven't changed the test code at all. It is essentially the same as it is in the openejb-itests module. Neverthless, here it is. http://people.apache.org/~prasad/test-ejbcontainer.zip I have simply moved it under geronimo/testsuite/ejbcontainer-testsuite/test-ejbcontainer and have ensured that it compiles fine. The reason I didn't bring it up for discussion is because it has to be located under the testsuite directory by convention. The beans can be built anywhere and the ejb-jars made available in the repo. Hence this discussion. I get Forbidden: You don't have permission to access /~prasad/test- ejbcontainer.zip on this server. -David Thanx David. Cheers Prasad On 10/27/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 27, 2006, at 7:34 AM, Prasad Kashyap wrote: http://people.apache.org/~prasad/ejb-modules.zip You may remove the parent from the top level pom and adjust the groupId appropriately to build this. Looks like you have the beans in there. Where is the test code? -David Cheers Prasad On 10/25/06, David Blevins [EMAIL PROTECTED] wrote: Great, I'll be looking forward to it. -David On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb- itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/ msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
Great, I'll be looking forward to it. -David On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb-itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
On 10/23/06, Prasad Kashyap [EMAIL PROTECTED] wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb-itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. +1. Geronimo doesn't need to know about EJBs at all unless configured (which again is part of configuration nor building. When an EJB container comes in, it should bring itests, too). I volunteer to help committing necessary changes (and finally get rid of M1). Just let me know what's necessary. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* -1. See above. Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/msg34995.html Can't help much with them. Jacek -- Jacek Laskowski http://www.jaceklaskowski.pl
Re: [discussion] openejb-itests in testsuite
On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb-itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
Thanx David. I shall try to put it in a sandbox if I can, or else send you a a patch. Cheers Prasad On 10/23/06, David Blevins [EMAIL PROTECTED] wrote: On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). I don't know which approach would make sense or if there is some middle ground. You have a copy of this migrated code somewhere I could look at/try out? If we did #2 it'd obviously be a copy as OpenEJB 3 runs those tests about 7 times during an average build and another 5 more times on a build with assemblies. -David The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb-itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/msg34995.html Cheers Prasad
Re: [discussion] openejb-itests in testsuite
Thanx Jacek. I might take you up on that offer :-) Cheers Prasad On 10/23/06, Jacek Laskowski [EMAIL PROTECTED] wrote: On 10/23/06, Prasad Kashyap [EMAIL PROTECTED] wrote: I have migrated the openejb-itests module to m2 with the intention of using it for G's testsuite. The junit test code will have to go under the ejbcontainer-testsuite under the testsuite framework (geronimo/testsuite). The beans and the ejub jars can go just about anywhere. So I'd like to solicit the suggestion of openejb and geronimo folks on where we should place them 1) Leave them where they are under openejb2/modules/openejb-itests. Get help from openejb commiters to get this commited. Unlike in previous G releases, this module would now only build the ejb jars. No tests would actually run here. +1. Geronimo doesn't need to know about EJBs at all unless configured (which again is part of configuration nor building. When an EJB container comes in, it should bring itests, too). I volunteer to help committing necessary changes (and finally get rid of M1). Just let me know what's necessary. 2) Move/copy the ejbs to some place under testsuite and create the jars there. This will keep the ejbs and the tests together. Since the moduleId (configId) in the plans should match the m2 artifactItem id (g:a:v:t), the moduleId in the ejb plans would then become o.a.g.testsuite.* -1. See above. Apart from this decision, other things that need to resolved before we put this code in are http://issues.apache.org/jira/browse/OPENEJB-288 http://www.mail-archive.com/dev@geronimo.apache.org/msg34995.html Can't help much with them. Jacek -- Jacek Laskowski http://www.jaceklaskowski.pl
