[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/313 Hello @vherilier , There is indeed a problem (good catch) as this new field should be persisted to XML/CSV. But my issue here is that it only concerns Transaction Controller and would be in SampleResult. Should we use it everywhere instead of limiting it to Transaction Controller ? At Team, what's your thought ? @vherilier , could you show some report were feature is used so that we can grasp the benefit of it ? Thanks ---
[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/313 Thanks @vherilier for your update, it looks good to me. May I ask one last thing, there is no documentation nor illustration of how this feature can be used. So if we want this feature to be popular there should be some sexy use case showing an example integration with some screenshot. Thanks ---
[GitHub] jmeter issue #315: Fixing bin/jmeter.sh version error, working as expected w...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/315 Thanks for your PR. But this code has recently been updated to work differently: https://github.com/apache/jmeter/blob/trunk/bin/jmeter We'll be happy to integrate an update for Windows script: https://github.com/apache/jmeter/blob/trunk/bin/jmeter.bat Thanks ---
[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/313 Hello @vherilier , Thanks for PR. Could you amend it to: - Add a property that would apply to all TC - add a TristateCheckBox in GUI 'Use comment in SampleResult' I think this will cover all cases: - Send comments for ALL TC - Don't send comments - Send for all except some - Send for none except some And test this value to add it to sampler. Of course JUnit are welcome. I'll be happy to merge it once done. Thank you. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hello @emilianbold , I have merged 310. Can you close this one ? Thank you ---
[GitHub] jmeter issue #312: Documentation for ApdexPerTransactionTest java class
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/312 Hello, Thanks for your PR, still can you answer my questions on PR 311 as there is the same problem here. Thank you ---
[GitHub] jmeter issue #311: Decumentation of CSVRead.java class and Test Cases issue ...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/311 Thank you for your PR, still it seems there are more changes than described. What is the real PR content ? Only javadocs of CSVRead ? Thank you ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Thanks @emilianbold , unfortunately I am still not able to generate diff nor patch file to merge it. ---
[GitHub] jmeter issue #306: Fix to BUG_60156
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/306 Thanks @emilianbold for review. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hi @emilianbold , AS you dropped your repository, I am not able to get the patch file to merge it. Any chance you have it ? Thanks ---
[GitHub] jmeter issue #306: Fix to BUG_60156
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/306 This PR was merged through svn commit http://svn.apache.org/viewvc?rev=1807719&view=rev ---
[GitHub] jmeter issue #306: Fix to BUG_60156
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/306 Hello Unless there is a NO GO , I'll commit this tomorrow. Thanks ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 I will merge this one after 3.3 (note I could do it before provided the feature is disabled by default). I think that new code makes feature better anyway than the current existing one. Ok for you team ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #304: Make smaller scripts shellcheck compatible
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/304 Thanks for your PR. Sorry for time taken to merge it, but as you know we are in summer period and on holidays for some of us. Feel free to test nightly build and give your feedback. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #302: Support sending result to InfluxDB with UDP protocal
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/302 Thank you for your contribution, there are some issues I indicated, either fix them or I'll do when I have time ( not before 2 weeks) . I don't see the code that plugs this sender. Thankw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130241103
--- Diff: src/core/org/apache/jmeter/gui/UndoHistory.java ---
@@ -160,63 +133,46 @@ public void add(JMeterTreeModel treeModel, String
comment) {
// first clone to not convert original tree
tree = (HashTree) tree.getTree(tree.getArray()[0]).clone();
-position++;
-while (history.size() > position) {
-if (log.isDebugEnabled()) {
-log.debug("Removing further record, position: {}, size:
{}", position, history.size());
-}
-history.remove(history.size() - 1);
-}
-
// cloning is required because we need to immute stored data
HashTree copy = UndoCommand.convertAndCloneSubTree(tree);
-history.add(new UndoHistoryItem(copy, comment));
+GuiPackage guiPackage = GuiPackage.getInstance();
+//or maybe a Boolean?
+boolean dirty = guiPackage != null ? guiPackage.isDirty() : false;
--- End diff --
I investigated further code and behaviour, I think issue in incorrect dirty
detection is due to the hypothesis made on GuiPackage#isDirty(), it appears it
is not up to date when added to UndoHistory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hi Emilian, Thanks for feedback. For now with my last tests: - I still have issues with check dirty when I do an intermediate save and undo all changes, dirty is not detected - I have the issue you explained, it is explainable but I am afraid it looks strange to users. Can others confirm the issues I face ? The feature is clearly better than what it was but I would prefer to have it completed before release. I can commit it but should we do that before 3.3 ? Another option is to commit it but keep it disabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #299: Mavenization
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/299 Hello @emilianbold , I think we should wait for 3.3 release , don't you think so ? Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 It seems the creation order is important to reproduce: First create Thread Group 1, add to it a Debug Sampler1 Second create Thread Group 2, add to it a Debug Sampler2 Add User Defined Variables, move it before Thread Group 1 Unfold TG2 and fold TG1 Duplicate User Defined Variables Play with undo, redo it is broken, it seems the element moving is not correctly handled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 I'm using code from: - https://patch-diff.githubusercontent.com/raw/apache/jmeter/pull/300.patch I have just found the problem. I start jmeter using : - t LAST which reloads last opened plan. This option seems to break some fields: - Loaded test plan is detected as dirty immediately Still I confirm that I face the issue with unfolding, let me clarify the scenario: Create a Tree like this: Test Plan |-User Defined Variable |-Thread Group 1 |--Debug Sampler1 |-Thread Group 2 |--Debug Sampler2 Expand Thread Group 1 and Unexpand Thread Group 2. Clone User Defined Variable using menu Edit > Duplicate Undo You end up with both Thread Groups expanded --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Create a Tree like this: Test Plan |-User Defined Variable |-Thread Group 1 |--TC1 |-Thread Group 2 |--TC2 Expand Thread Group 1 and Unexpand Thread Group 2. Clone User Defined Variable Undo You end up with both Thread Groups expanded --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hi @emilianbold , The bug that you previously fixed with TreeState has reappeared. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 HI @emilianbold , It seems to work correctly as of my tests for now, but it requires further tests. Testing it, I have noticed we have an existing bug with dirty check, it seems it doesn't correctly detect CUT and does not propose save. I have fixed it, shall I commit it or wait for your PR to be complete ? Do you consider it mature enough for a commit now ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #301: First stab at a whitelist for the xstream library.
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/301 Hi @FSchumacher , Thanks for the PR. Maybe we could add a interface that plugins could implement to register additional classes: Too coarse and risky ?: `SerializationRegistrator#registerClasses(XStream xstream)` Other option: ` Class[]Â SerializationRegistrator#getTypeHierarchies() String[] SerializationRegistrator#getTypeByRegex() String[] SerializationRegistrator#getTypeByWildcard() ` Still considering what this could break, I am against including it in 3.3 (at least) and also it needs through testing by 3rd parties to have further feedback on what it breaks. It looks to me like a Plugins Geddon that could hurt hardly our software. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #301: First stab at a whitelist for the xstream library.
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/301#discussion_r128925907
--- Diff: src/core/org/apache/jmeter/util/JMeterUtils.java ---
@@ -1261,10 +1265,39 @@ public static final void refreshUI() {
*/
public static void setupXStreamSecurityPolicy(XStream xstream) {
// This will lift the insecure warning
+// disallow any class
xstream.addPermission(NoTypePermission.NONE);
-// We reapply very permissive policy
-// See
https://groups.google.com/forum/#!topic/xstream-user/wiKfdJPL8aY
-// TODO : How much are we concerned by CVE-2013-7285
-xstream.addPermission(AnyTypePermission.ANY);
+// allow some classes that are hopefully secure
+for (TypePermission perm : Arrays.asList(NullPermission.NULL,
+ArrayTypePermission.ARRAYS,
+PrimitiveTypePermission.PRIMITIVES)) {
+xstream.addPermission(perm);
+}
+for (Class allowHierarchy :
Arrays.asList(java.util.Collection.class,
+org.apache.jmeter.testelement.TestElement.class,
+org.apache.jorphan.collections.HashTree.class,
+org.apache.jmeter.samplers.SampleSaveConfiguration.class))
{
+xstream.allowTypeHierarchy(allowHierarchy);
--- End diff --
Shouldn't we also allow subclasses of SampleResult ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Maybe we could change how dirty check works which I think was here because there was no Redo/Undo Management. Am I wrong to think dirty may be simpler to compute now ? - Any change (Element addition/removal) on tree makes dirty = TRUE - Any change in properties of Element makes dirty = TRUE - When Doing/Undo => dirty = (dirty) ? (undohistory == empty ? TRUE : FALSE) : TRUE There is the more complex case of loading a Test plan in version N from a JMeter in version N+X --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 @emilianbold , do you think computing dirty should be part of the undoable edit ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hi Emilian, Thanks for the fix for last bug. I cannot provide the 900K test plan as it's a real life one from a customer. I'll try to create a fake one. Anyway, I think the most annoying issues now would be by descending priorities: - https://bz.apache.org/bugzilla/show_bug.cgi?id=57040 - The non restored marked for search nodes + performance issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hello Emilian, 1) Thanks for fix, see my comment 2) I've noticed another issue. Create a Tree like this: Test Plan |-User Defined Variable |-Thread Group 1 |--TC1 |-Thread Group 2 |--TC2 Expand Thread Group 1 and Unexpand Thread Group 2. Clone User Defined Variable Undo You end up with Thread Group 2 expanded and Thread Group 1 unexpanded. TreeState#restore() seems to be lost in indexes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r128917971
--- Diff: src/core/org/apache/jmeter/gui/action/ActionRouter.java ---
@@ -67,7 +67,10 @@ public void actionPerformed(final ActionEvent e) {
private void performAction(final ActionEvent e) {
String actionCommand = e.getActionCommand();
-GuiPackage.getInstance().beginUndoTransaction();
+//New action will clear undo, no point in having a transaction
+if(!ActionNames.CLOSE.equals(actionCommand)) {
--- End diff --
I think you need to filter also OPEN and OPEN_RECENT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hi @undera, I agree, but for now it is not yet fully fixed although a lot of progress have been made thanks to Emilian. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/300 Hello Emilian, Thanks for this great piece of work ! First test look very promising in regards of performances. I have a first issue to report: 1. Open JMeter 2. Select Menu File > New => An error log appears with the stacktrace (as per line 310 in UndoHistory) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #298: Vary header cache
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/298 Hi Felix, I suggest you commit the PR so that we can update and test code more easily. Thanks Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #298: Vary header cache
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/298
Hi Felix,
Looks good to me.
I'd just change a bit in HTTPJavaImpl#getHeaders(HeaderManager
headerManager) to:
`private Header[] getHeaders(HeaderManager headerManager) {
if (headerManager != null) {
final CollectionProperty headers = headerManager.getHeaders();
if (headers != null) {
List allHeaders = new ArrayList<>(headers.size());
for (final JMeterProperty jMeterProperty : headers) {
allHeaders.add((Header)
jMeterProperty.getObjectValue());
}
return allHeaders.toArray(new Header[allHeaders.size()]);
}
}
return new Header[0];
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #298: Vary header cache
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/298 Great @FSchumacher ! Thanks for your work ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #298: Vary header cache
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/298 Thanks Felix for PR. I reviewed it, it looks good to me. Maybe since we're making API modifications we should start thinking about: - https://bz.apache.org/bugzilla/show_bug.cgi?id=53540 Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #261: Clear querystring args on each call to setPath
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/261 Hello @squarebracket , Sorry for late reply. Thinking about it rapidly, I think your analysis is good if we were writing a new API. But I am afraid some code in JMeter relies on this working this way. I don't have time to investigate more this, as I prefer to spend time on other fields of JMeter. Maybe somebody else in the team can help on this. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #295: Fix to 61071
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/295 Hi Team, What shall we do ? As per Felix note on dev mailing list, it is more an algorithm variation than a bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/296 Hi Team, What shall we do ? As per Felix note on dev mailing list, it is more an algorithm variation than a bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #292: Display the result of the function when generate it
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/292 Hi Mabye a SyntaxtTextArea for result would be better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #292: Display the result of the function when generate it
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/292 Hello, It might be interesting to add some Text area to input some JSR223 Code to fill-in the context. As a fist step, we should document this and possibly add a Hint that pops up to explain that test only works for function not relying on context. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/296 Hello @abalanonline , Thanks for your replies and explanations ! I am not a math expert as you seem to be, so I have few questions you may be able to help on: 1. Thanks to your comment, I see default method is LEGACY, and the one you have created is R_1. Do you have some insights on the different method and their limits / use cases ? 2. Why does the "bug" you report affect all libraries I checked (HdrHistogram, https://github.com/tdunning/t-digest/ and JOrphan ) ? Can't it be due to a different method estimation algorithm ? Note I share your thoughts on using a dedicated library but commons-math may be overkill in terms of performance compared to HdrHistogram or t-digest. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/296
Thanks for your patch.
This test fails for me:
`@Test
public void testPercentagePointBug() throws Exception {
long values[] = new long[] {
10L,9L,5L,6L,1L,3L,8L,2L,7L,4L
};
DescriptiveStatistics statistics = new DescriptiveStatistics();
for (long l : values) {
calc.addValue(l);
statistics.addValue(l);
}
assertEquals(statistics.getPercentile(90),
calc.getPercentPoint(0.9), 0.5);
}`
with:
`java.lang.AssertionError: expected:<9.9> but was:<9.0>`
Does it sounds ok for you ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #291: Add time shifting function
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/291 Hello, Regarding format, for maintainability and documentation, using Java8 Duration is better IMO. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #295: Fix to 61071
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/295 Thanks for completing the PR. Percentile 50 should be equal to median. So I suspect the bug is in getPercentPoint(). I wonder if it's not occasion to switch to https://github.com/HdrHistogram/HdrHistogram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #295: Fix to 61071
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/295 Hello @abalanonline , Thanks for your PR. Would it be possible to provide a current failing test case that shows the issue and confirms that your fix is ok ? Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #294: Add expand/collapse all menu in render XML view
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/294 Hi, I think the greatest UI would contain a Search field where you could enter a text of XPATh and the Tree would expand all nodes matching the search and collapsing others. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #294: Add expand/collapse all menu in render XML view
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/294 Looks useful to me also although I think an XML formatter which allows collapsing of nodes in editor would be much better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #293: Prevent use of the same array in CollectionProperty (clos...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/293 +1 for fixing both methods --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #293: Prevent use of the same array in CollectionProperty (clos...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/293 @FSchumacher , I agree. Let's commit the patch without the new method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #291: Add time shifting function
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/291 Thanks for the changes. Looks good to me for commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #292: Display the result of the function when generate it
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/292 Hi @max3163 , Interesting idea. Does your implementation handle all functions ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #293: Prevent use of the same array in CollectionProperty (clos...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/293 Thanks for analysis and patch. It was a hard one !. @FSchumacher , I don't understand your comment , what exactly do you want to change ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #291: Add time shifting function
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/291 Hello, Looks good to me (see my comments), very good idea ! Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #291: Add time shifting function
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113294213
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.jmeter.functions;
+
+import java.time.Instant;
+import java.time.LocalDateTime;
+import java.time.Year;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeFormatterBuilder;
+import java.time.format.DateTimeParseException;
+import java.time.temporal.ChronoField;
+import java.util.Collection;
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.jmeter.engine.util.CompoundVariable;
+import org.apache.jmeter.samplers.SampleResult;
+import org.apache.jmeter.samplers.Sampler;
+import org.apache.jmeter.threads.JMeterVariables;
+import org.apache.jmeter.util.JMeterUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * timeShifting Function permit to shift a date
+ *
+ * Parameters:
+ * - format date @see
https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html
(optional - defaults to epoch time in millisecond)
+ * - date to shift formated as first param (optional - defaults now)
+ * - amount of (seconds / minutes / hours / days / months ) to add
(optional - default nothing is add )
+ * - variable name ( optional )
+ *
+ * Returns:
+ * - Returns a formated date with the specified number of (seconds /
minutes / hours / days / months ) added.
+ * - value is also saved in the variable for later re-use.
+ *
+ * @since 3.3
+ */
+public class TimeShiftingFunction extends AbstractFunction {
+private static final Logger log =
LoggerFactory.getLogger(TimeShiftingFunction.class);
+
+private static final String KEY = "__timeShifting"; // $NON-NLS-1$
+
+private static final List desc = new LinkedList<>();
+
+static {
+desc.add(JMeterUtils.getResString("time_format_shift"));
//$NON-NLS-1$
+desc.add(JMeterUtils.getResString("date_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("value_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("function_name_paropt"));
//$NON-NLS-1$
+}
+
+// Ensure that these are set, even if no paramters are provided
+private String format = ""; //$NON-NLS-1$
+private String dateToShift = ""; //$NON-NLS-1$
+private String shift = ""; //$NON-NLS-1$
+private String variable = ""; //$NON-NLS-1$
+
+public TimeShiftingFunction() {
+super();
+}
+
+/** {@inheritDoc} */
+@Override
+public String execute(SampleResult previousResult, Sampler
currentSampler) throws InvalidVariableException {
+String dateString;
+LocalDateTime localDateTimeToShift = LocalDateTime.now(
ZoneId.systemDefault() );
+DateTimeFormatter formatter = null;
+if (!StringUtils.isEmpty(format)) {
+try {
+formatter = new
DateTimeFormatterBuilder().appendPattern(format)
+.parseDefaulting(ChronoField.NANO_OF_SECOND, 0)
+.parseDefaulting(ChronoField.MILLI_OF_SECOND, 0)
+.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
+.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
+.parseDefaulting(ChronoField.HOUR_OF_DAY, 0)
+.parseDefaulting(ChronoField.DAY_OF_MONTH, 1)
+.parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
+
[GitHub] jmeter pull request #291: Add time shifting function
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113294131
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.jmeter.functions;
+
+import java.time.Instant;
+import java.time.LocalDateTime;
+import java.time.Year;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeFormatterBuilder;
+import java.time.format.DateTimeParseException;
+import java.time.temporal.ChronoField;
+import java.util.Collection;
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.jmeter.engine.util.CompoundVariable;
+import org.apache.jmeter.samplers.SampleResult;
+import org.apache.jmeter.samplers.Sampler;
+import org.apache.jmeter.threads.JMeterVariables;
+import org.apache.jmeter.util.JMeterUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * timeShifting Function permit to shift a date
+ *
+ * Parameters:
+ * - format date @see
https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html
(optional - defaults to epoch time in millisecond)
+ * - date to shift formated as first param (optional - defaults now)
+ * - amount of (seconds / minutes / hours / days / months ) to add
(optional - default nothing is add )
+ * - variable name ( optional )
+ *
+ * Returns:
+ * - Returns a formated date with the specified number of (seconds /
minutes / hours / days / months ) added.
+ * - value is also saved in the variable for later re-use.
+ *
+ * @since 3.3
+ */
+public class TimeShiftingFunction extends AbstractFunction {
+private static final Logger log =
LoggerFactory.getLogger(TimeShiftingFunction.class);
+
+private static final String KEY = "__timeShifting"; // $NON-NLS-1$
+
+private static final List desc = new LinkedList<>();
+
+static {
+desc.add(JMeterUtils.getResString("time_format_shift"));
//$NON-NLS-1$
+desc.add(JMeterUtils.getResString("date_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("value_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("function_name_paropt"));
//$NON-NLS-1$
+}
+
+// Ensure that these are set, even if no paramters are provided
+private String format = ""; //$NON-NLS-1$
+private String dateToShift = ""; //$NON-NLS-1$
+private String shift = ""; //$NON-NLS-1$
+private String variable = ""; //$NON-NLS-1$
+
+public TimeShiftingFunction() {
+super();
+}
+
+/** {@inheritDoc} */
+@Override
+public String execute(SampleResult previousResult, Sampler
currentSampler) throws InvalidVariableException {
+String dateString;
+LocalDateTime localDateTimeToShift = LocalDateTime.now(
ZoneId.systemDefault() );
+DateTimeFormatter formatter = null;
+if (!StringUtils.isEmpty(format)) {
+try {
+formatter = new
DateTimeFormatterBuilder().appendPattern(format)
+.parseDefaulting(ChronoField.NANO_OF_SECOND, 0)
+.parseDefaulting(ChronoField.MILLI_OF_SECOND, 0)
+.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
+.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
+.parseDefaulting(ChronoField.HOUR_OF_DAY, 0)
+.parseDefaulting(ChronoField.DAY_OF_MONTH, 1)
+.parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
+
[GitHub] jmeter pull request #291: Add time shifting function
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113294069
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.jmeter.functions;
+
+import java.time.Instant;
+import java.time.LocalDateTime;
+import java.time.Year;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeFormatterBuilder;
+import java.time.format.DateTimeParseException;
+import java.time.temporal.ChronoField;
+import java.util.Collection;
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.jmeter.engine.util.CompoundVariable;
+import org.apache.jmeter.samplers.SampleResult;
+import org.apache.jmeter.samplers.Sampler;
+import org.apache.jmeter.threads.JMeterVariables;
+import org.apache.jmeter.util.JMeterUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * timeShifting Function permit to shift a date
+ *
+ * Parameters:
+ * - format date @see
https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html
(optional - defaults to epoch time in millisecond)
+ * - date to shift formated as first param (optional - defaults now)
+ * - amount of (seconds / minutes / hours / days / months ) to add
(optional - default nothing is add )
+ * - variable name ( optional )
+ *
+ * Returns:
+ * - Returns a formated date with the specified number of (seconds /
minutes / hours / days / months ) added.
+ * - value is also saved in the variable for later re-use.
+ *
+ * @since 3.3
+ */
+public class TimeShiftingFunction extends AbstractFunction {
+private static final Logger log =
LoggerFactory.getLogger(TimeShiftingFunction.class);
+
+private static final String KEY = "__timeShifting"; // $NON-NLS-1$
+
+private static final List desc = new LinkedList<>();
+
+static {
+desc.add(JMeterUtils.getResString("time_format_shift"));
//$NON-NLS-1$
+desc.add(JMeterUtils.getResString("date_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("value_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("function_name_paropt"));
//$NON-NLS-1$
+}
+
+// Ensure that these are set, even if no paramters are provided
+private String format = ""; //$NON-NLS-1$
+private String dateToShift = ""; //$NON-NLS-1$
+private String shift = ""; //$NON-NLS-1$
+private String variable = ""; //$NON-NLS-1$
+
+public TimeShiftingFunction() {
+super();
+}
+
+/** {@inheritDoc} */
+@Override
+public String execute(SampleResult previousResult, Sampler
currentSampler) throws InvalidVariableException {
+String dateString;
+LocalDateTime localDateTimeToShift = LocalDateTime.now(
ZoneId.systemDefault() );
+DateTimeFormatter formatter = null;
+if (!StringUtils.isEmpty(format)) {
+try {
+formatter = new
DateTimeFormatterBuilder().appendPattern(format)
+.parseDefaulting(ChronoField.NANO_OF_SECOND, 0)
+.parseDefaulting(ChronoField.MILLI_OF_SECOND, 0)
+.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
+.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
+.parseDefaulting(ChronoField.HOUR_OF_DAY, 0)
+.parseDefaulting(ChronoField.DAY_OF_MONTH, 1)
+.parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
+
[GitHub] jmeter pull request #291: Add time shifting function
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113294026
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.jmeter.functions;
+
+import java.time.Instant;
+import java.time.LocalDateTime;
+import java.time.Year;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeFormatterBuilder;
+import java.time.format.DateTimeParseException;
+import java.time.temporal.ChronoField;
+import java.util.Collection;
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.jmeter.engine.util.CompoundVariable;
+import org.apache.jmeter.samplers.SampleResult;
+import org.apache.jmeter.samplers.Sampler;
+import org.apache.jmeter.threads.JMeterVariables;
+import org.apache.jmeter.util.JMeterUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * timeShifting Function permit to shift a date
+ *
+ * Parameters:
+ * - format date @see
https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html
(optional - defaults to epoch time in millisecond)
+ * - date to shift formated as first param (optional - defaults now)
+ * - amount of (seconds / minutes / hours / days / months ) to add
(optional - default nothing is add )
+ * - variable name ( optional )
+ *
+ * Returns:
+ * - Returns a formated date with the specified number of (seconds /
minutes / hours / days / months ) added.
+ * - value is also saved in the variable for later re-use.
+ *
+ * @since 3.3
+ */
+public class TimeShiftingFunction extends AbstractFunction {
+private static final Logger log =
LoggerFactory.getLogger(TimeShiftingFunction.class);
+
+private static final String KEY = "__timeShifting"; // $NON-NLS-1$
+
+private static final List desc = new LinkedList<>();
+
+static {
+desc.add(JMeterUtils.getResString("time_format_shift"));
//$NON-NLS-1$
+desc.add(JMeterUtils.getResString("date_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("value_to_shift")); //$NON-NLS-1$
+desc.add(JMeterUtils.getResString("function_name_paropt"));
//$NON-NLS-1$
+}
+
+// Ensure that these are set, even if no paramters are provided
+private String format = ""; //$NON-NLS-1$
+private String dateToShift = ""; //$NON-NLS-1$
+private String shift = ""; //$NON-NLS-1$
+private String variable = ""; //$NON-NLS-1$
+
+public TimeShiftingFunction() {
+super();
+}
+
+/** {@inheritDoc} */
+@Override
+public String execute(SampleResult previousResult, Sampler
currentSampler) throws InvalidVariableException {
+String dateString;
+LocalDateTime localDateTimeToShift = LocalDateTime.now(
ZoneId.systemDefault() );
+DateTimeFormatter formatter = null;
+if (!StringUtils.isEmpty(format)) {
+try {
+formatter = new
DateTimeFormatterBuilder().appendPattern(format)
+.parseDefaulting(ChronoField.NANO_OF_SECOND, 0)
+.parseDefaulting(ChronoField.MILLI_OF_SECOND, 0)
+.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
+.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
+.parseDefaulting(ChronoField.HOUR_OF_DAY, 0)
+.parseDefaulting(ChronoField.DAY_OF_MONTH, 1)
+.parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
+
[GitHub] jmeter pull request #291: Add time shifting function
Github user pmouawad commented on a diff in the pull request: https://github.com/apache/jmeter/pull/291#discussion_r113292969 --- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties --- @@ -1169,6 +1170,7 @@ throughput_control_perthread_label=Par utilisateur throughput_control_title=Contr\u00F4leur D\u00E9bit throughput_control_tplabel=D\u00E9bit \: time_format=Chaine de formatage sur le mod\u00E8le SimpleDateFormat (optionnel) +time_format_shift=Chaine de formatage sur le mod\u00E8le DateTimeFormatter (optionnel) ( defaut unix timestamp en milliseconde ) --- End diff -- Chaîne millisecondes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #291: Add time shifting function
Github user pmouawad commented on a diff in the pull request: https://github.com/apache/jmeter/pull/291#discussion_r113292880 --- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties --- @@ -238,6 +238,7 @@ database_sql_query_title=Requ\u00EAte SQL JDBC par d\u00E9faut database_testing_title=Requ\u221A\u2122te JDBC database_url=URL JDBC\: database_url_jdbc_props=URL et driver JDBC de la base de donn\u221A\u00A9es +date_to_shift=Date sur laquel on applique le d\u00E9callage (optionnel) (defaut \: maintenant ) --- End diff -- laquelle, d\u00E9faut --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #288: Bug 60883 - Add ${__escapeXml()} function
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/288 Thanks for contribution. LGTM, I agree with Felix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #283: Allow on JMeter client to use variables and functions for...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/283 Hello Maxime, Thanks for patch. My remarks: - I think we need here JUnit tests to check no regression will occur. This part of the code is complex and critical and needs 100% coverage ideally through JUnit otherwise with a test plan running with Jacoco - I would prefer to delay it after 3.2 release to avoid introducing another delay in release. I'll review code more thoroughly in near future. Regards Philippe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #279: Better j meter proxy doc
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/279 Hello, Looks good to me. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #277: Bug 58506 - JMS Point-to-point sampler should offer an as...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/277 Hello, Thank you for your contribution. My notes: - The class ExtendedQueueRequestor seems to come from existing code as per "This source code implements specifications defined by the Java Community Process." Are you the author of this code or not ? If not what is the license of this code ? - The code lacks javadoc for ExtendedQueueRequestor - TemporaryQueueExecutor is not used anymore, it should be deprecated - The ExtendedQueueRequestor needs to be unit tested. Since we've setup Sonar on repository, we try to increase test coverage either with JUnit code or Test Plan that allows testing results. This code should be unit tested using mocks I think Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #247: Checks for listener output file existence
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/247 Merged with commit: http://svn.apache.org/viewvc?rev=1783297&view=rev This PR can be closed. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #241: Support variable for all JMS messages (bytes, object, ......
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/241 Hello, Would it be possible to bench this with more threads than 2 ? 50 for example ? Would it be possible to wait for 3.2 release before merging this one ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #275: Bug 60664 : Adding log level setting menu under Options m...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/275 Hi Woonsan, Would it be possible to add some screenshot ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #261: Clear querystring args on each call to setPath
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/261 Hello @squarebracket , Thank you for your work. If my understanding of your comment is correct, this would mean that your development has introduced a regression in code. You should usually not touch existing test methods unless test is broken, which does not seem to be the case for testMakingUrl2 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #247: Checks for listener output file existence
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/247 Hi @max3163 , As you're a commiter now, could you apply it ? I tried to but it seems the generated patch files contains other files (JSONManager) , I don't know why but there seem to be unrelated commits. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #264: Bug 60564 - Migrating to SLF4J logger - components/config...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/264 Hi Woonsan, Thanks for the PR. I just modified few lines as per my comment on PR 263 And in CSV DataSet , a call to file.getAbsolutePath() was wrongly replaced by a var that was not updated. Thanks Regards Philippe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #263: Bug 60564 - Migrating LogKit logger to SLF4J logger - onl...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/263 Hi Woonsan, Thanks for the PR. I just modified few lines, I think I did right, but confirmation is better. I added log.isDebugEnabled() when parameters of log message called some methods. Do you agree with this ? Thanks Regards Philippe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #247: Checks for listener output file existence
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/247 Hi Maxime, Is the PR ok now ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #260: Manually synchronized on synchronizedMap as per docs and ...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/260 Hi all, Any thoughts on this ? Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #260: Manually synchronized on synchronizedMap as per docs and ...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/260 Hi, Any thoughts on that ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #261: Clear querystring args on each call to setPath
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/261 More simple: ant test Note you can have a look at existing Tests based on JUnit 4 (annotations). You can usually run them in Eclipse. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #261: Clear querystring args on each call to setPath
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/261 Thank you for your contribution. My understanding is that this bug only happens with classes subclassing HTTPSamplerBase. Would it be possible to produce a Test Unit that highlights the bug and if possible some Test Unit that cover current algorithm ? This is to ensure no regression is introduced by this fix. Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #254: Feature/bz60589-1 PR for review (logkit to slf4j / log4j2...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/254 Forget about my comment on jcl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #254: Feature/bz60589-1 PR for review (logkit to slf4j / log4j2...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/254 I'm not sure commons-logging can be dropped as it's a compile dependency of HttpClient 4.5.3: https://repo1.maven.org/maven2/org/apache/httpcomponents/httpclient/4.5.3/httpclient-4.5.3.pom --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #260: Manually synchronized on synchronizedMap as per docs and ...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/260 Hello, Thanks for contribution. I am not sure we should apply this fix as I am not sure initial bug report was correct. AFAIU, the propMap is never accessed concurrently although I don't know why propMap is wréapped in a synchronized Map. I am afraid that introducing this might hurt performances as it is called for every run of a sample . But others analysis is welcome and particularly if anybody know why propMap was initially synchronized. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #254: Feature/bz60589-1 PR for review (logkit to slf4j / log4j2...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/254 Hello , Thanks for this big piece of work. I made a first review, it looks good to me. There's one thing I don't clearly understand, what's the use of replaceDateFormatInFileName in NewDriver ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #258: BZ60590
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/258 This is explained by: - https://bz.apache.org/bugzilla/show_bug.cgi?id=60650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #258: BZ60590
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/258 Hi, You were right. I have a second possible issue. Here is what the meanAT shows. It does not look ok to me . https://cloud.githubusercontent.com/assets/3127467/22335641/c6c20a2a-e3df-11e6-9540-626affe26f89.png";> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #258: BZ60590
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/258 I tried the patch and I don't see annotations displayed. I tried with: eventTags = TestTag And eventTags = Test tag for release version=1.2.3 [ https://cloud.githubusercontent.com/assets/3127467/22334124/cd99ecce-e3d9-11e6-903a-19f18532a3c3.png";> https://cloud.githubusercontent.com/assets/3127467/22334125/cdba8268-e3d9-11e6-8fe4-be27fd0502ad.png";> ](url) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #258: BZ60590
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/258 Hello, Thanks for PR. I'll look into merging it but what exactly is the 3rd point ? Is it to avoid sending to INflux the Validation results ? Usually it's better to split PR in this case. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #257: Static Analysis Fixes
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/257 Hello, Another question I have. I see you replace StringBuilder by '+' concat. Is there a reason for this ? Reading: - http://www.pellegrino.link/2015/08/22/string-concatenation-with-java-8.html I don't understand that their performance is better. Do you have another reference ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #247: Checks for listener output file existence
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/247 Hello, I reviewed this PR and I have some blocker remarks so I didn't merge it: - I think code in StandardJMeterEngine and DistributedRunner is duplicated - I wouldn't put any dependency on java.awt in those 2 classes. - deleteResultFile should not be static but I don't know how to make it better Regards Philippe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #257: Static Analysis Fixes
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/257 @ham1 , Thanks a lot for your contribution. Looks globally good for me. I have just one remark, I wouldn't "optimize" the org.apache.jmeter.control package classes. This part of JMeter is one of the most complex and less readable. We need by the way to increase our Test coverage on these. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/253 @max3163 , Ok for your proposal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/253 @max3163 , I've fixed the missing httpcore-nio. For the bug, it's because you schedule every 5s, so test ends before and closes the Sender and just guarantees end is sent. We could fix it but I'm not sure it's useful, why would anybody do a 5s load test ? Regarding your note on Annotation, I don't understand why you want me to rollback. As I wrote, I think we should expose tags so that users can put whatever they want. I didn't fully understand what @Wyatts wrote but I think it's worth a discussion with all dev team before going further. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #256: Bug60637 better statistics summary report
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/256
Hello Antonio,
Thanks for PR.
My notes:
- I think you may have problems with your git config for end of line as
your PR modifies more files than needed .
Regarding code, it looks ok to me.
I would just modify in dashboard.js.fmkr method
`
createTable($("#statisticsTable"), ${statisticsSummary!"{}"},
function(index, item){
switch(index){
// Errors pct
case 3:
item = item.toFixed(2) + '%';
break;
// Mean
case 4:
// Percentile 1
case 7:
// Percentile 2
case 8:
// Percentile 3
case 9:
// Throughput
case 10:
// Received Kbytes/s
case 11:
// Sent Kbytes/s
case 12:
item = item.toFixed(2);
break;
}
return item;
}, [[0, 0]], 0, summaryTableHeader);
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/253 Hello I want something similar to that . In next evolution, I think it would be useful to add tags as a parameter of the InfluxdbBackendListenerClient. For example, users could set "Version 3.X.X of application" or "Load Test after pool tuning" Or maybe there's a better way I am not aware of. [ https://cloud.githubusercontent.com/assets/3127467/22178115/d449077a-e02e-11e6-81dc-309fdb32fcbf.png";> ] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/253 Hello @max3163 , I merged this PR with following fixes/changes: - Added more configuration on Async Http Client (Reactor) - Fixed that End annotation not being sent - Fixed the label in annotation containing " - Restored back tags in annotation (is there any reason why you removed them in last PR ?) - Isolated properties for this implementation and Graphite one - Renamed properties. Could you test in your environment and give feedback ? Thank you for your work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #253: Fix issue with annotation and implement remarks from last...
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/253 Hello Maxime, Thanks for being so active on JMeter these days ! I'm really happy about it. I reviewed PR, it looks globally good except for something I don't understand. Why do you use a CountDownLatch set to 1 ? I think it is currently broken anyway as you only init once and countDown, so await will only "wait" the first time. But anyway, in my understanding of AsyncHTTPCLient and our use case here, I think we can send without waiting, that's why I initially proposed to use Async. As we fill in timestamp, for me even if sending occurs in reverse order for whatever reason, it will not be a problem. @Team, am I wrong ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #246: Add Influxdb backend to JMeter
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/246 Hi Mark, Good to know. Are you using Apache HttpAsyncClient or something else ? Do you agree with my proposals ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #246: Add Influxdb backend to JMeter
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/246 Hello, Thanks for contribution. I have few remarks on implementation: - You intentionally don't set timestamp. I am not sure it's a good idea as if any delay occurs sending to InfluxDB, measurement will be wrong, and there is another reason, see next remark - I think HttpAsyncClient (https://hc.apache.org/httpcomponents-asyncclient-dev/quickstart.html) might be a good use case here as we don't care about responses and we don't want to block too much, so we could use it here. But in this case we would need to add timestamp. - I think you should allow some configuration for technical things like timeouts. InfluxdbMetricsSender#setup should have a more flexible parameter like Map to allow passing more parameters Also would it be possible to provide: - A Simple Test plan using the component - If possible some documentation I have already made some changes to PR, I could commit it as is and mark component as Alpha, we could distribute with next release and improve it either before or later. @Team what do you think ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #241: Support variable for all JMS messages (bytes, object, ......
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/241 Hello, Before merging this one , I'd like to be sure it does not introduce performance degradation. Did you have time to make a micro benchmark ? Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #226: Bug 58274 - Removed split methods from JOrphanUtils
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/226 Hello, Thanks for your work but next time please ask on jmeter dev mailing list before working on a PR. We cannot integrate this PR as it is now in conflict and would need too much work to be integrated. Integrating PR that touch a lot of code without JUNIT non regression testing is too risky. Regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #240: Improves JMS component robustness
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/240 Hello, Thanks for PR. I have commited it but with some slight changes. Could you test nightly build and give us feedback ? Also could you attach the JMX plan that you attached to this PR as a zip (which I am not able to read) to the bugzilla 60585 Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #250: Feature/bz60564 (1)
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/250 Thanks for PR. It looks ok. Before we start integrating it, would it be possible to propose a PR for the configuration part ? I think it would be interesting to see how configuration will be done from users point of view in JMeter before going further. Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #245: Allow table sorting
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/245 Hello, I have commited part of the PR and made some changes: - I didn't want to use everywhere HeaderAsPropertyRenderer.install as it removes formatting without introducing sorting - It would have also broken backward compatibility on the class potentially breaking backward compatibility of plugins - So I have replaced it by a HeaderAsPropertyRendererWrapper class - I have added sorting to Aggregate Graph - In ObjectTableModel, I have also replaced the modified method by a new one getObjectListAsList to avoid breaking backward compatibility Thanks for your PR, please test nightly build to see if it works fine for you. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
