[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Unless there are any objections, I'd like to merge this branch back into 
master. There are a few small issues, but none that can't be addressed with 
documentation. I'd love to do this either tonight or tomorrow, so please voice 
any objections as soon as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can 
Mavenize it and get it in to Maven Central so we can use it as a dependency in 
pom.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[chrismattmann]

Github user chrismattmann commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
+1 great work! watch out there are conflicts to resolve before merging 
@mjpost 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985
  
ack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-80945
  
@lewissmc Thank you very much, Sir.
Joshua in Docker - not yet tried so far, I will definitely try it.

I am much interested in your [PR to 
Tika](https://github.com/apache/tika/pull/112/) to integrate this translator 
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-54428
  
@mjpost 
> Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean 
that eclipse compiled files will override the jar? So I can do fast development 
in Eclipse?

Seems like you have hard-time with eclipse maven integration.
last time when I used eclipse there was a eclipse plugin that recognized 
maven projects. That plugin took care of all the complexities under the hood. 
If you have proper setup, you can just go to "JoshuaDecoder" (or whichever 
class you want to run) and "Run main" (no need to package, because that takes 
time)

P.S. I use Intellij Idea opensource edition and the maven integration is a 
breeze.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-38661
  
> I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files 
will override the jar? So I can do fast development in Eclipse?

Yes all you need to execute in your terminal is ```mvn eclipse:eclipse```

> We still have to solve the KenLM problem.

Yes we do :(

> Do we have ideas for how to pull in KenLM and compile it? And BerkeleyLM?

https://bitbucket.org/atlassian/bash-maven-plugin

Honestly thats the most I can find right now without hacking a Maven Github 
download build plugin. I am fed up of XML @mjpost  :0 :) :) :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-37297
  
Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean 
that eclipse compiled files will override the jar? So I can do fast development 
in Eclipse?

We still have to solve the KenLM problem. My tests ran because I linked 
$JOSHUA/ext and $JOSHUA/lib to directories on master. Do we have ideas for how 
to pull in KenLM and compile it? And BerkeleyLM? I think that's the big thing 
remaining.

After that, I'll have to go over the log messages in a bit more detail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-28146
  
@mjpost I am unable to run `test.sh` script, because - 


Caused by: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: no 
ken in java.library.path
at org.apache.joshua.decoder.ff.lm.KenLM.(KenLM.java:52)
... 10 more
Caused by: java.lang.UnsatisfiedLinkError: no ken in java.library.path
at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1867)
at java.lang.Runtime.loadLibrary0(Runtime.java:870)
at java.lang.System.loadLibrary(System.java:1122)
at org.apache.joshua.decoder.ff.lm.KenLM.(KenLM.java:43)
... 10 more
Exception in thread "main" java.lang.RuntimeException: * FATAL: could not 
find a feature 'LanguageModel'


How do I pass this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-25251
  
Found the issue with logger config file. Seems like `-Dlog4j.configuration` 
to override is no longer supported. 
Please review  #18 and merge.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-06844
  
@lewismc @mjpost  Just looked into this. I will debug this issue and come 
back with my findings soon.

+1 for rethinking about log levels.  we can lower some frequent INFO 
messages to DEBUG level.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-04726
  
Yes, I hope I was clear that this is all great work. We just have to figure 
out how to get log4j to read the config file, which it's currently not doing. 
Then, we can make sure the test cases pass, and merge back into master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-04155
  
Make an entry in logging file?
Parameterized logging as implemented by @thammegowda is magnitudes more 
efficient than traditional string + Excepton logging
@thammegowda maybe we need INFO degreded (logging sense) to DEBUG
Thank you @thammegowda for trying to understand the logging. When I was 
doing the build thats something I didn't approach :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-3
  
Just to be clear, not sure it needs to be reverted. We just need to find a 
way to make sure the config file gets read and that logging gets set to INFO by 
default. And logging should all go to STDERR, I think, not STDOUT.

In general, too, having INFO prepended to all informative lines is a bit 
ugly. Is this a useful convention for reasons I can't understand? It's often 
useful to see the decoder working with just these high-level labels, and I 
don't mind debug lines being prepended with DEBUG.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387
  
@thammegowda please revert logging patch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222120221
  
I went into joshua/decoder/chart_parser/ComputeNodeResult; adding and 
removing the following lines makes a huge difference in speed. So it looks like 
logging is neither (a) time-safe nor (b) thread-safe.

Or that something is wrong. I can't get the decoder to output any 
statements using the logging properties. It's sort of a pain to have to rebuild 
a tarball every time you want to test something...

FYI, I won't have any more time to spend on this before Tuesday.

```
if (LOG.isDebugEnabled()) {
  LOG.debug("ComputeNodeResult():");
  LOG.debug("-> RULE {}", rule);
}

[snip]

if (LOG.isDebugEnabled()) {
  LOG.debug("-> item.bestedge: {}", item);
  LOG.debug("-> TAIL NODE {}", item);
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222118458
  
On a hunch, I went through and removed all the calls LOG.*() in Decoder, 
DecoderThread, JoshuaDecoder, Translation, Chart, DotChart, and 
ComputeNodeResult. This fixed the problem; the decoder now runs as fast as 
before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[Matt Post]

yeah this is really strange. I'm talking about the regression tests, not the 
unit tests. these are in src/test/resources. run for example 
test/bn-en/hiero/test.sh. 3 seconds on master, 18 on JOSHUA-252 (you might have 
to remove "-threads 2")

matt (from my phone)

> On May 26, 2016, at 9:15 PM, lewismc  wrote:
> 
> Github user lewismc commented on the pull request:
> 
>https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050
> 
>What kind of 'tests' are we talking about here? The only tests which I 
> know of are invoked by running ```mvn clean test```. These execute very 
> quickly by the looks of it however I assume that they cover little or none of 
> the multithreaded functionality you are referring to. 
>Do you have something we could code, profile and see what is taking so 
> long @mjpost  ? Thanks
> 
>One last thing. No I changed absolutely no code. I did however introduce 
> some classes such as the ArpaFile, etc which were required to get the current 
> tests running. 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050
  
What kind of 'tests' are we talking about here? The only tests which I know 
of are invoked by running ```mvn clean test```. These execute very quickly by 
the looks of it however I assume that they cover little or none of the 
multithreaded functionality you are referring to. 
Do you have something we could code, profile and see what is taking so long 
@mjpost  ? Thanks

One last thing. No I changed absolutely no code. I did however introduce 
some classes such as the ArpaFile, etc which were required to get the current 
tests running. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222032586
  
Okay, I just pushed up the changes after merging in master and making some 
other changes to that the tests will run (with manual calls). The code on 
master runs fine, so it must have been something in the 252 or 262 branches. 
I've done some initial work wrapping LOG.debug() calls in checks for 
LOG.isDebugEnabled(), but that didn't seem to help. All my tests were done with 

log4j.rootLogger=OFF, stdout

I may have some more time to look at this tomorrow.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222027825
  
My guess is that `ConcurrentModificationException` occurs when we try to 
loop (eg: for) on a collection and inside the loop the collection is being 
updated (by adding or removing items).
However, based on the exception, I checked 
https://github.com/apache/incubator-joshua/blob/JOSHUA-252/src/main/java/org/apache/joshua/decoder/chart_parser/DotChart.java#L362
there isnt any such code. I suspect Rule.toString().

That line executes only if DEBUG level is enabled! try disabling DEBUG (by 
setting Log4j level to INFO or higher until we find a fix



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222016587
  
Also, multithreading is broken. I randomly (not always) get the following 
error when decoding with more than 1 thread:

```
Exception in thread "Thread-4" java.lang.RuntimeException: Input 1: FATAL 
UNCAUGHT EXCEPTION: null
at 
org.apache.joshua.decoder.Decoder$DecoderThreadRunner.run(Decoder.java:433)
Caused by: java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at 
org.apache.joshua.decoder.chart_parser.DotChart.addDotItem(DotChart.java:362)
at 
org.apache.joshua.decoder.chart_parser.DotChart.expandDotCell(DotChart.java:223)
at org.apache.joshua.decoder.chart_parser.Chart.expand(Chart.java:585)
at 
org.apache.joshua.decoder.DecoderThread.translate(DecoderThread.java:141)
at 
org.apache.joshua.decoder.Decoder$DecoderThreadRunner.run(Decoder.java:424)
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222013844
  
Okay, cool. It doesn't seem to look for that file automatically, though; if 
I remove the -Dlog4j.configuration, it doesn't find the file you pointed to. So 
I am just having it hard-point to that path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222012667
  
@mjpost as you pointed out, you need to edit log4j settings.

The other way is to edit `src/main/resources/log4j.properties`


If you dont want to rebuild the jar after editing the file, you can create 
an updated log4j.properties and  prefix  its path to the class path (so that it 
gets priority over the one inside jar)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011444
  
Okay, the answer is that our slfj4 is using log4j12 as the backend. I had 
to add

-Dlog4j.configuration=$JOSHUA/logging.properties

to the invocation, and then put

log4j.rootLogger=OFF

(or info, etc).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[KellenSunderland]

Github user KellenSunderland commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011143
  
Does setting it to error instead of info help?
On May 27, 2016 12:04 AM, "Matt Post"  wrote:

> Can someone tell me how to turn off logging in slf4j? I have tried passing
>
> -Dorg.slf4j.Logger.defaultLogLevel=info
>
> but this does not seem to work. Extensive googling around and walking
> through the manual have not turned up anything. I've probably missed
> something.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222008424
  
Can someone tell me how to turn off logging in slf4j? I have tried passing

-Dorg.slf4j.Logger.defaultLogLevel=info

but this does not seem to work. Extensive googling around and walking 
through the manual have not turned up anything. I've probably missed something.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222003148
  
Yep, working through those. Making good progress on the build. Once I can 
verify that the test cases pass under the new build (so I can know I've done 
the merge correctly), I'll push it up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222002633
  
There will be a number of scripts which we need to update with the paths to 
the generated jar files. This is all part of the new build. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222000585
  
Nevermind, found Thamme's [old 
instructions](https://github.com/apache/incubator-joshua/pull/14#issue-155139645).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221969513
  
Okay, cool, I got this merged and compiling. First, THANK YOU for all of 
this amazing work! This feels like a real milestone and it was fun to work 
through the merge.

Before I push, I need to run the tests, though, and am not sure how to 
invoke the decoder. Can you provide some assistance here? I don't know maven 
very well, so if there are any maven commands to type first, that would also 
help to know. Basically, if you can get me to the point where I can type

$ echo test | joshua

and it returns

0 ||| test ||| tm_glue_0=1.000 ||| 0.000

then I can run my regression tests and push up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221928486
  
There have been changes on master (JOSHUA-271 and JOSHUA-272), will try to 
get to this soon, probably not till tomorrow.

Do you want me to be the one to merge master into JOSHUA-252? Then we can 
test and merge back into master. I think this might be our 6.1 release?

For packages:

- Is it possible to have Maven do git checkouts (on specific versions?) 
That's one route
- Otherwise, we should just rely on the user to set them up. The only real 
problem is for BerkeleyLM and KenLM, since those are runtime. I don't have much 
experience in how to do this. But we could have a maven target that does a git 
checkout of a specific version, kind of like a submodule.
- Thrax and GIZA (and fast_align) we can tell the user to set up.

matt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221793740
  
Cool @thammegowda 

#15 merged into JOSHUA-252

Work still to be done
 * plan on how we are going to compile and package GIZA++, KenLM, 
berkeleylm, thrax, etc. Right now the ext directory has been completely removed 
as that code should not live but instead be acquired as part of the build 
system.

@mjpost have you made any changes to master which we need to merge into 
JOSHUA-252 branch?
Thanks



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221778184
  
@lewismc thanks for the reply.

rebased #13 , it is ready for merge!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[chrismattmann]

Github user chrismattmann commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220756830
  
dusted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753345
  
@mjpost Sorry for my previous incomplete comment.
 The problem I see with that line is, now we have new package 
`org.apache.joshua.decoder.ff` instead of old `joshua.decoder.ff`.
Since lewis is currently working on this, I didnt dare to raise a new PR to 
fix a single line :-) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219586976
  
I didn't see your JOSHUA-252 branch. I just created a "maven" branch that 
pulls PRs 4 and 5 into this one. However, I don't see these on github / 
incubator. It seems that Apache is not pushing branches down to github.

Everything seems to compile for me when I type [the commands @thammegowda 
provided](https://github.com/apache/incubator-joshua/pull/13#issuecomment-219570096).
 However, I don't really know how to use Maven, and eclipse is totally broken. 
Can you add a BUILD file that describes how to compile and how to get things 
set up in eclipse?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219337253
  
this is indeed a big change and I think it's better to split into multiple 
small PRs.

Maybe we can have a 'maven' branch in parallel for a short transition time,
resolve the remaining issues on that branch with smaller PRs and merge it 
with master?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219336222
  
ACK
Safe flight Kellen.

On Sun, May 15, 2016 at 7:25 PM, Kellen Sunderland  wrote:

> Hey Lewis. I'm flying today but can take a look at getting the tests to
> compile next week. Thanks for all the work. I'd be game for a google
> hangout to discuss any issues we have.
>
> On Sun, May 15, 2016 at 7:19 PM, Lewis John McGibbney <
> notificati...@github.com> wrote:
>
> > The PR is not finished yet. There are a number of issues as highlighted
> > above which need attention.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



-- 
*Lewis*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321
  
The PR is not finished yet. There are a number of issues as highlighted 
above which need attention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---