[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Actually @chrismattmann it's just a fast-forward at this point — all is 
merged on JOSHUA-252, it's just not showing up on this PR.

https://github.com/apache/incubator-joshua/tree/JOSHUA-252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Unless there are any objections, I'd like to merge this branch back into 
master. There are a few small issues, but none that can't be addressed with 
documentation. I'd love to do this either tonight or tomorrow, so please voice 
any objections as soon as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
https://github.com/joshua-decoder/berkeleylm/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can 
Mavenize it and get it in to Maven Central so we can use it as a dependency in 
pom.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[chrismattmann]

Github user chrismattmann commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
+1 great work! watch out there are conflicts to resolve before merging 
@mjpost 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
So here is what is outstanding:

- We need to either (a) get a new BerkeleyLM in Maven (anyone know how to 
do this?) or (b) pull the codebase into Joshua (is this permissible, including 
the renaming?)
- I think we can safely leave Thrax as an external dependency that the user 
has to install, and provide instructions on the website for how to do so.
- We can do the same for KenLM, and make the BerkeleyLM build and runtime 
tools the default.

That way we don't have to mess with any shell scripts from Maven, which is 
not advised (because of portability concerns).

matt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Another issue: BerkeleyLM is currently pulled from the Maven repository, 
but it is very old 
([1.1.2](http://mvnrepository.com/artifact/edu.berkeley.nlp/berkeleylm/1.1.2), 
but [1.1.6 is 
available](https://github.com/joshua-decoder/berkeleylm/commits/master)). I'm 
pretty sure its author has abandoned it; how can we get it updated? Joshua has 
a few bug fixes on it, even. One option: we could just roll the codebase into 
Joshua (it's Apache 2.0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985
  
ack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-80945
  
@lewissmc Thank you very much, Sir.
Joshua in Docker - not yet tried so far, I will definitely try it.

I am much interested in your [PR to 
Tika](https://github.com/apache/tika/pull/112/) to integrate this translator 
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-80223
  
yes @thammegowda the process is welcome and appreciated Sir. on a side note 
hove you tried th Docker containersTZ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-54428
  
@mjpost 
> Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean 
that eclipse compiled files will override the jar? So I can do fast development 
in Eclipse?

Seems like you have hard-time with eclipse maven integration.
last time when I used eclipse there was a eclipse plugin that recognized 
maven projects. That plugin took care of all the complexities under the hood. 
If you have proper setup, you can just go to "JoshuaDecoder" (or whichever 
class you want to run) and "Run main" (no need to package, because that takes 
time)

P.S. I use Intellij Idea opensource edition and the maven integration is a 
breeze.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-51965
  
Hi @lewismc Thanks so much.

 > For starters, can you please update it.

Oh, I missed the licence header. Got it. I do not yet have write 
permissions to directly fix it, so  guess I have to raise another PR to fix it.

> Can you also please scope the Slf4j over Log4j I implemented over on 
Nutch for an example of how to help @mjpost with the logging issues. 

Sorry, I am not clear what do you mean?

> The Logging effort is absolutely paradise.

Thanks :-) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-38661
  
> I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files 
will override the jar? So I can do fast development in Eclipse?

Yes all you need to execute in your terminal is ```mvn eclipse:eclipse```

> We still have to solve the KenLM problem.

Yes we do :(

> Do we have ideas for how to pull in KenLM and compile it? And BerkeleyLM?

https://bitbucket.org/atlassian/bash-maven-plugin

Honestly thats the most I can find right now without hacking a Maven Github 
download build plugin. I am fed up of XML @mjpost  :0 :) :) :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-37297
  
Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean 
that eclipse compiled files will override the jar? So I can do fast development 
in Eclipse?

We still have to solve the KenLM problem. My tests ran because I linked 
$JOSHUA/ext and $JOSHUA/lib to directories on master. Do we have ideas for how 
to pull in KenLM and compile it? And BerkeleyLM? I think that's the big thing 
remaining.

After that, I'll have to go over the log messages in a bit more detail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-35694
  
Its more than overdue as well for me to say @thammegowda thank you. The 
Logging effort is absolutely paradise. I looked at a lot of code during 
reformat and your logging patches are very welcome. Thank you Sir.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-35386
  
OK @mjpost  thanks 
@thammegowda for starters, more or less every file that you write at 
Apache, and that you wish to build community around should probably have a 
licensse header

https://github.com/apache/incubator-joshua/blob/JOSHUA-252/src/main/resources/log4j.properties
does not. 
For starters, can you please update it.
Can you also please scope the Slf4j over Log4j I implemented over on Nutch 
for an example of how to help @mjpost with the logging issues. 
It is important in this build that we retain the efficiency of everyones 
commits over the build. The build is an enabler not a master.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-29485
  
These are the logs I am getting when the level is OFF, WARN, INFO and DEBUG.

I ran `echo "Subject is not object" | bin/joshua > file.txt`

[off.txt](https://github.com/apache/incubator-joshua/files/287205/off.txt)
[warn.txt](https://github.com/apache/incubator-joshua/files/287204/warn.txt)
[info.txt](https://github.com/apache/incubator-joshua/files/287202/info.txt)

[debug.txt](https://github.com/apache/incubator-joshua/files/287201/debug.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-28146
  
@mjpost I am unable to run `test.sh` script, because - 


Caused by: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: no 
ken in java.library.path
at org.apache.joshua.decoder.ff.lm.KenLM.(KenLM.java:52)
... 10 more
Caused by: java.lang.UnsatisfiedLinkError: no ken in java.library.path
at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1867)
at java.lang.Runtime.loadLibrary0(Runtime.java:870)
at java.lang.System.loadLibrary(System.java:1122)
at org.apache.joshua.decoder.ff.lm.KenLM.(KenLM.java:43)
... 10 more
Exception in thread "main" java.lang.RuntimeException: * FATAL: could not 
find a feature 'LanguageModel'


How do I pass this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-25251
  
Found the issue with logger config file. Seems like `-Dlog4j.configuration` 
to override is no longer supported. 
Please review  #18 and merge.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-06844
  
@lewismc @mjpost  Just looked into this. I will debug this issue and come 
back with my findings soon.

+1 for rethinking about log levels.  we can lower some frequent INFO 
messages to DEBUG level.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-04726
  
Yes, I hope I was clear that this is all great work. We just have to figure 
out how to get log4j to read the config file, which it's currently not doing. 
Then, we can make sure the test cases pass, and merge back into master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-04155
  
Make an entry in logging file?
Parameterized logging as implemented by @thammegowda is magnitudes more 
efficient than traditional string + Excepton logging
@thammegowda maybe we need INFO degreded (logging sense) to DEBUG
Thank you @thammegowda for trying to understand the logging. When I was 
doing the build thats something I didn't approach :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-3
  
Just to be clear, not sure it needs to be reverted. We just need to find a 
way to make sure the config file gets read and that logging gets set to INFO by 
default. And logging should all go to STDERR, I think, not STDOUT.

In general, too, having INFO prepended to all informative lines is a bit 
ugly. Is this a useful convention for reasons I can't understand? It's often 
useful to see the decoder working with just these high-level labels, and I 
don't mind debug lines being prepended with DEBUG.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387
  
@thammegowda please revert logging patch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222143162
  
Okay, can't stop scratching this itch. 

On even further investigation, with some System.err.println()s, I 
discovered that the properties file isn't getting loaded correctly. 
Consequently, isDebugEnabled() is always returning true, but the logging 
statements are not printed anywhere visible. So the work is getting triggered, 
and is just not seen, and that is the problem.

I've pushed up the merge. Can you folks take care of making sure that the 
logger file is running correctly? You can test this by running

cd $JOSHUA/src/test/resources/bn-en/hiero/
time ./test.sh

Depending on your hardware, of course, that should run in just a few 
seconds tops.

Incidentally, there are at least two other problems I am hoping you can 
help address?

-  I see how to build a big tarball and run Maven that way, but that's a 
pain for development, since you have to incur the time of rebuilding the 
tarball. Is there a way to just run against the files in target/classes 
directly? I've tried this, but the problem is that the jar dependencies don't 
seem to get downloaded anywhere. 

-  Your response might be, "actually, you just have to regenerated the 
tarball, that's the proper way to do things." In which case, can you describe 
how to make eclipse do this? Right now, when I'm developing, eclipse is always 
compiling files, so you can just switch over and test right away. It's a small 
but significant paint to have to type "(cd $JOSHUA; mvn compile assembly:single 
install"

-  I really like being able to use the `-v` (verbosity) flag to Joshua, 
which sets the debugging level. This is much simpler than changing a properties 
file and linking to that from the command line. Is it possible to set the log4j 
debug level programmatically based on the value of -v? We could do

   -v 0 = OFF
   -v 1 = INFO
   -v 2 = DEBUG

   Or I would be okay to switch to those values directly (e.g., "-v OFF"). 
But the former seems more Unix-like.

Thanks again for all your work on this!

matt




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222120221
  
I went into joshua/decoder/chart_parser/ComputeNodeResult; adding and 
removing the following lines makes a huge difference in speed. So it looks like 
logging is neither (a) time-safe nor (b) thread-safe.

Or that something is wrong. I can't get the decoder to output any 
statements using the logging properties. It's sort of a pain to have to rebuild 
a tarball every time you want to test something...

FYI, I won't have any more time to spend on this before Tuesday.

```
if (LOG.isDebugEnabled()) {
  LOG.debug("ComputeNodeResult():");
  LOG.debug("-> RULE {}", rule);
}

[snip]

if (LOG.isDebugEnabled()) {
  LOG.debug("-> item.bestedge: {}", item);
  LOG.debug("-> TAIL NODE {}", item);
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222118458
  
On a hunch, I went through and removed all the calls LOG.*() in Decoder, 
DecoderThread, JoshuaDecoder, Translation, Chart, DotChart, and 
ComputeNodeResult. This fixed the problem; the decoder now runs as fast as 
before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[Matt Post]

yeah this is really strange. I'm talking about the regression tests, not the 
unit tests. these are in src/test/resources. run for example 
test/bn-en/hiero/test.sh. 3 seconds on master, 18 on JOSHUA-252 (you might have 
to remove "-threads 2")

matt (from my phone)

> On May 26, 2016, at 9:15 PM, lewismc  wrote:
> 
> Github user lewismc commented on the pull request:
> 
>https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050
> 
>What kind of 'tests' are we talking about here? The only tests which I 
> know of are invoked by running ```mvn clean test```. These execute very 
> quickly by the looks of it however I assume that they cover little or none of 
> the multithreaded functionality you are referring to. 
>Do you have something we could code, profile and see what is taking so 
> long @mjpost  ? Thanks
> 
>One last thing. No I changed absolutely no code. I did however introduce 
> some classes such as the ArpaFile, etc which were required to get the current 
> tests running. 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050
  
What kind of 'tests' are we talking about here? The only tests which I know 
of are invoked by running ```mvn clean test```. These execute very quickly by 
the looks of it however I assume that they cover little or none of the 
multithreaded functionality you are referring to. 
Do you have something we could code, profile and see what is taking so long 
@mjpost  ? Thanks

One last thing. No I changed absolutely no code. I did however introduce 
some classes such as the ArpaFile, etc which were required to get the current 
tests running. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222032586
  
Okay, I just pushed up the changes after merging in master and making some 
other changes to that the tests will run (with manual calls). The code on 
master runs fine, so it must have been something in the 252 or 262 branches. 
I've done some initial work wrapping LOG.debug() calls in checks for 
LOG.isDebugEnabled(), but that didn't seem to help. All my tests were done with 

log4j.rootLogger=OFF, stdout

I may have some more time to look at this tomorrow.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222027825
  
My guess is that `ConcurrentModificationException` occurs when we try to 
loop (eg: for) on a collection and inside the loop the collection is being 
updated (by adding or removing items).
However, based on the exception, I checked 
https://github.com/apache/incubator-joshua/blob/JOSHUA-252/src/main/java/org/apache/joshua/decoder/chart_parser/DotChart.java#L362
there isnt any such code. I suspect Rule.toString().

That line executes only if DEBUG level is enabled! try disabling DEBUG (by 
setting Log4j level to INFO or higher until we find a fix



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222026212
  
Having thought about this, but not looked, my guess is that the arguments 
to logging functions are getting computed even if they're not printed, and 
that's costing lots of time. I'm not sure why that would affect multithreading 
though.

@lewismc and @thammegowda, if you have any thoughts on any other changes 
you made that might have caused this, please let me know.

(I think the lesson is that I should have let JOSHUA-252 get fully merged 
before pulling in the logging code. That would have let us separate these 
issues)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222016587
  
Also, multithreading is broken. I randomly (not always) get the following 
error when decoding with more than 1 thread:

```
Exception in thread "Thread-4" java.lang.RuntimeException: Input 1: FATAL 
UNCAUGHT EXCEPTION: null
at 
org.apache.joshua.decoder.Decoder$DecoderThreadRunner.run(Decoder.java:433)
Caused by: java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at 
org.apache.joshua.decoder.chart_parser.DotChart.addDotItem(DotChart.java:362)
at 
org.apache.joshua.decoder.chart_parser.DotChart.expandDotCell(DotChart.java:223)
at org.apache.joshua.decoder.chart_parser.Chart.expand(Chart.java:585)
at 
org.apache.joshua.decoder.DecoderThread.translate(DecoderThread.java:141)
at 
org.apache.joshua.decoder.Decoder$DecoderThreadRunner.run(Decoder.java:424)
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222016079
  
Okay, I have merged. The handful of test cases I checked passed, but there 
is bad news: the decoder is *significantly* slower, like by an order of 
magnitude. Tests that returned instantly before or took just a second or two 
now take 10–20. This is with log levels turned off. Those of you who have 
worked on this branch, do you have any guesses what the problem might be?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222013844
  
Okay, cool. It doesn't seem to look for that file automatically, though; if 
I remove the -Dlog4j.configuration, it doesn't find the file you pointed to. So 
I am just having it hard-point to that path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222012667
  
@mjpost as you pointed out, you need to edit log4j settings.

The other way is to edit `src/main/resources/log4j.properties`


If you dont want to rebuild the jar after editing the file, you can create 
an updated log4j.properties and  prefix  its path to the class path (so that it 
gets priority over the one inside jar)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011444
  
Okay, the answer is that our slfj4 is using log4j12 as the backend. I had 
to add

-Dlog4j.configuration=$JOSHUA/logging.properties

to the invocation, and then put

log4j.rootLogger=OFF

(or info, etc).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[KellenSunderland]

Github user KellenSunderland commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011143
  
Does setting it to error instead of info help?
On May 27, 2016 12:04 AM, "Matt Post"  wrote:

> Can someone tell me how to turn off logging in slf4j? I have tried passing
>
> -Dorg.slf4j.Logger.defaultLogLevel=info
>
> but this does not seem to work. Extensive googling around and walking
> through the manual have not turned up anything. I've probably missed
> something.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222008424
  
Can someone tell me how to turn off logging in slf4j? I have tried passing

-Dorg.slf4j.Logger.defaultLogLevel=info

but this does not seem to work. Extensive googling around and walking 
through the manual have not turned up anything. I've probably missed something.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222003720
  
Excellent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222003148
  
Yep, working through those. Making good progress on the build. Once I can 
verify that the test cases pass under the new build (so I can know I've done 
the merge correctly), I'll push it up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222002633
  
There will be a number of scripts which we need to update with the paths to 
the generated jar files. This is all part of the new build. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222000585
  
Nevermind, found Thamme's [old 
instructions](https://github.com/apache/incubator-joshua/pull/14#issue-155139645).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221969513
  
Okay, cool, I got this merged and compiling. First, THANK YOU for all of 
this amazing work! This feels like a real milestone and it was fun to work 
through the merge.

Before I push, I need to run the tests, though, and am not sure how to 
invoke the decoder. Can you provide some assistance here? I don't know maven 
very well, so if there are any maven commands to type first, that would also 
help to know. Basically, if you can get me to the point where I can type

$ echo test | joshua

and it returns

0 ||| test ||| tm_glue_0=1.000 ||| 0.000

then I can run my regression tests and push up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221933542
  
Hi @mjpost thanks for response
```
Do you want me to be the one to merge master into JOSHUA-252? Then we can 
test and merge back into master. I think this might be our 6.1 release?
```
Yes please if you could take care of merging your work on master into 
JOSHUA-252 then that would be grand. I am not overly familiar with the work 
done so I don't want to botch it. Thanks Matt.

```
Is it possible to have Maven do git checkouts (on specific versions?) 
That's one route
```
I was thinking the exact same thing and I am actively investigating here. 
```
Otherwise, we should just rely on the user to set them up. The only real 
problem is for BerkeleyLM and KenLM, since those are runtime. I don't have much 
experience in how to do this. But we could have a maven target that does a git 
checkout of a specific version, kind of like a submodule.
```
Hopefully I can provide insight and input into this. Give me a wee bit of 
time and I can get around to answering in due course. 
```
Thrax and GIZA (and fast_align) we can tell the user to set up.
```
Agreed. I sent a PR for Thrax (which is incomplete due to changes in the 
underlying API) which Mavenies the entire build 
https://github.com/joshua-decoder/thrax/pull/12 we could then pull Thrax as a 
dependency within Joshua.
For GIZA we will get the user to set up.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221928486
  
There have been changes on master (JOSHUA-271 and JOSHUA-272), will try to 
get to this soon, probably not till tomorrow.

Do you want me to be the one to merge master into JOSHUA-252? Then we can 
test and merge back into master. I think this might be our 6.1 release?

For packages:

- Is it possible to have Maven do git checkouts (on specific versions?) 
That's one route
- Otherwise, we should just rely on the user to set them up. The only real 
problem is for BerkeleyLM and KenLM, since those are runtime. I don't have much 
experience in how to do this. But we could have a maven target that does a git 
checkout of a specific version, kind of like a submodule.
- Thrax and GIZA (and fast_align) we can tell the user to set up.

matt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221793740
  
Cool @thammegowda 

#15 merged into JOSHUA-252

Work still to be done
 * plan on how we are going to compile and package GIZA++, KenLM, 
berkeleylm, thrax, etc. Right now the ext directory has been completely removed 
as that code should not live but instead be acquired as part of the build 
system.

@mjpost have you made any changes to master which we need to merge into 
JOSHUA-252 branch?
Thanks



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221782894
  
@lewismc Please merge #17 ( it is a duplicate of #15 )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221779115
  
Cool @thammegowda 


#14 is merged.
Work still to be done
#13 merged
work still to be done
 * merge #15 into JOSHUA-252
 * plan on how we are going to compile and package GIZA++, KenLM, 
berkeleylm, thrax, etc. Right now the ext directory has been completely removed 
as that code should not live but instead be acquired as part of the build 
system.

@mjpost have you made any changes to master which we need to merge into 
JOSHUA-252 branch?
Thanks



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221778184
  
@lewismc thanks for the reply.

rebased #13 , it is ready for merge!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221777380
  
#14 is merged.
Work still to be done
 * merge #13 into JOSHUA-252 branch
 * merge #15 into JOSHUA-252
 * plan on how we are going to compile and package GIZA++, KenLM, 
berkeleylm, thrax, etc. Right now the ext directory has been completely removed 
as that code should not live but instead be acquired as part of the build 
system.

@mjpost have you made any changes to master which we need to merge into 
JOSHUA-252 branch?
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221776975
  
hi @thammegowda thanks for reply

 *  #13 should be able to merge with this branch (have conflicts now, but i 
can resolve them)
Please rebase the above against this branch

*  #14 can be merged with this, no conflicts
I will merge this

#15 is targetted to branch named maven . Probably I need to raise a new PR 
targeted to this JOSHUA-252 branch ? 

Yes please do. All branches should be named after the associated Jira 
ticket. That way we have full blown provenance tracking for individual issues. 

Thanks, I'll merge #14 now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221776421
  
great work @lewismc . 

All my activity is branched off from this branch

* #13  should be able to merge with this branch (have conflicts now, but i 
can resolve them)
* #14 can be merged with this, no conflicts
* #15 is targetted to branch named `maven` . Probably I need to raise a new 
PR targeted to this `JOSHUA-252` branch ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221775479
  
@thammegowda @mjpost  OK the Maven build is now 'stable'. 
We need to list which changes have been made to master branch since this 
work began. These then need to be merged into the JOSHUA-252 branch. 
Additionally, the following needs to be addressed
 * merge all work which has been done to master branch into JOSHUA-252 
branch
 * plan on how we are going to compile and package GIZA++, KenLM, 
berkeleylm, thrax, etc. Right now the ext directory has been completely removed 
as that code should not live but instead be acquired as part of the build 
system.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[chrismattmann]

Github user chrismattmann commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220756830
  
dusted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753694
  
I'll have the Javadoc for this PR finished tonight. The build will then be 
'stable'.
At that stage we can rebase @thammegowda 's most recent patch for System 
calls, etc into the JOSHUA-252 branch.
We can then think about how the hell to get all of the other pipeline 
running :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753345
  
@mjpost Sorry for my previous incomplete comment.
 The problem I see with that line is, now we have new package 
`org.apache.joshua.decoder.ff` instead of old `joshua.decoder.ff`.
Since lewis is currently working on this, I didnt dare to raise a new PR to 
fix a single line :-) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753066
  
What's problematic about that? FYI, that line is part of the code that lets 
feature functions be loaded by reflection, e.g., so you can write a new feature 
function and call it directly from the command line without having to add stub 
code to check for and load it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220752546
  
@lewismc I was trying to fix logs, and found this problematic package names 
in strings: 
https://github.com/apache/incubator-joshua/blob/JOSHUA-252/src/main/java/org/apache/joshua/decoder/Decoder.java#L967


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[chrismattmann]

Github user chrismattmann commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220163448
  
great work on this @lewismc so awesome


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219620953
  
You can build it locally by simply using the following scope
```

  edu.berkeley.nlp
  jberkeleyaligner
  X
  system
  /path/to/berkeleyaligner.jar

```
I think you can remove the version element for the time being and try that 
out. We may need to create a Maven build for berkeley aligner and push it to 
Maven Central


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219616619
  
@lewismc I tried to create a training model from maven build. Found that 
`pipeline.pl`  script uses `berkeleyaligner.jar`.  

- `berkeleyaligner.jar` is not in maven repo.  I see [a 
project](https://github.com/mjpost/berkeleyaligner) in @mjpost 's github which 
has ant build  so I couldnt do local maven install to try it out. Should we 
need to port that to maven build or do you know a quick way to install ant jar 
to maven local?

- [The original licence is GPL 
v2](https://code.google.com/archive/p/berkeleyaligner/), I am not sure if it 
has been relicensed to Apache. Can we add this as dependency to create a fat 
jar of all dependencies?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219587186
  
Yep I'll add all of this to the wiki space. In the meantime you can do

mvn eclipse:eclipse

Easy as that

On Monday, May 16, 2016, Matt Post  wrote:

> I didn't see your JOSHUA-252 branch. I just created a "maven" branch that
> pulls PRs 4 and 5 into this one. However, I don't see these on github /
> incubator. It seems that Apache is not pushing branches down to github.
>
> Everything seems to compile for me when I type the commands @thammegowda
> provided
> 
.
> However, I don't really know how to use Maven, and eclipse is totally
> broken. Can you add a BUILD file that describes how to compile and how to
> get things set up in eclipse?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>


-- 
*Lewis*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219586976
  
I didn't see your JOSHUA-252 branch. I just created a "maven" branch that 
pulls PRs 4 and 5 into this one. However, I don't see these on github / 
incubator. It seems that Apache is not pushing branches down to github.

Everything seems to compile for me when I type [the commands @thammegowda 
provided](https://github.com/apache/incubator-joshua/pull/13#issuecomment-219570096).
 However, I don't really know how to use Maven, and eclipse is totally broken. 
Can you add a BUILD file that describes how to compile and how to get things 
set up in eclipse?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219359416
  
The next step here is for me to stabilize the test suite. This will involve 
putting the test resources in to src/test/resources and then removing the top 
level test directory. I'll work on this over the next few days. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219358227
  
Hi Folks, this is now a feature branch and can be found at 
https://github.com/apache/incubator-joshua/tree/JOSHUA-252
I have set up a build for the branch as well to make interpretation and 
understanding a little clearer. The build can be seen at 
https://builds.apache.org/view/H-L/view/Joshua/job/joshua_maven/
I would kindly ask that all code committed to master branch also be 
committed to the JOSHUA-252 branch otherwise the codebases will quickly 
diverge. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219342797
  
+1
 @lewismc  I will then fix logs, system.exits() and other trivial issues in 
code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219341353
  
Wow, nice. We might want to put some of that back in there for completeness 
/ posterity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219341230
  
No way, I actually found the file online

http://www.programcreek.com/java-api-examples/index.php?source_dir=relax-decode-master/third-party/joshua-1.3/src/joshua/decoder/ff/lm/ArpaFile.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219341169
  
ACK @mjpost I knew this. I am tempted to merely skip the ones for which 
classes no longer exist. I'm going to try and stabilize the build tonight. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219340284
  
I don't. However, the "Arpa" denotes the [standard SRILM format for 
language model 
files](http://www.speech.sri.com/projects/srilm/manpages/ngram-format.5.html) 
(read by both BerkeleyLM and KenLM), so the file would have been very similar 
to [this one in 
BerkeleyLM](https://github.com/joshua-decoder/berkeleylm/blob/master/src/edu/berkeley/nlp/lm/io/ArpaLmReader.java).

As a warning, I have not touched many of those unit test files in years, 
and many of them may be way, way out of date.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219339642
  
@mjpost do you know where I can find the class ArpaFile.java ? It is 
referenced within 
[src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java|https://github.com/apache/incubator-joshua/blob/0990ebc07f44073156c1c7923fee7ebaaf7677f5/test/joshua/decoder/ff/lm/ArpaFileTest.java#L107]
 but not available within master source. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219339426
  
I agree as well
It's pretty huge as I said so we need lots of eyes on it.
Current compilation issues as as follows
```
[INFO] 100 errors
[INFO] -
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 9.155 s
[INFO] Finished at: 2016-05-15T20:09:45-07:00
[INFO] Final Memory: 29M/252M
[INFO] 

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile 
(default-testCompile) on project joshua: Compilation failure: Compilation 
failure:
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[21,38]
 error: cannot find symbol
[ERROR] package org.apache.joshua.decoder.ff.tm
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[22,38]
 error: cannot find symbol
[ERROR] package org.apache.joshua.decoder.ff.tm
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[192,22]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/packed/PrintRules.java:[29,42]
 error: package org.apache.joshua.util.quantization does not exist
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/packed/PrintRules.java:[30,42]
 error: package org.apache.joshua.util.quantization does not exist
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/packed/PrintRules.java:[42,10]
 error: cannot find symbol
[ERROR] class PrintRules
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[38,24]
 error: cannot find symbol
[ERROR] class ArityPhrasePenaltyFFTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[46,16]
 error: cannot find symbol
[ERROR] class ArityPhrasePenaltyFFTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[50,4]
 error: cannot find symbol
[ERROR] class ArityPhrasePenaltyFFTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[50,47]
 error: cannot find symbol
[ERROR] class ArityPhrasePenaltyFFTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[58,25]
 error: cannot find symbol
[ERROR] class ArityPhrasePenaltyFFTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/ArityPhrasePenaltyFFTest.java:[60,69]
 error: cannot find symbol
[ERROR] class ArityPhrasePenaltyFFTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[106,4]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[106,28]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[118,4]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[118,28]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[124,9]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[156,4]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[156,28]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[163,4]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[163,28]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[165,4]
 error: cannot find symbol
[ERROR] class ArpaFileTest
[ERROR] 
/usr/local/incubator-joshua/src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java:[165,20]

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[mjpost]

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219339175
  
I second @thammegowda's idea of merging this into a "maven" branch first 
which will also continue to pull the latest from master. This is a big change 
and I'm not going to have time to look at it too closely for a while yet 
(probably later next week).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219337253
  
this is indeed a big change and I think it's better to split into multiple 
small PRs.

Maybe we can have a 'maven' branch in parallel for a short transition time,
resolve the remaining issues on that branch with smaller PRs and merge it 
with master?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219336222
  
ACK
Safe flight Kellen.

On Sun, May 15, 2016 at 7:25 PM, Kellen Sunderland  wrote:

> Hey Lewis. I'm flying today but can take a look at getting the tests to
> compile next week. Thanks for all the work. I'd be game for a google
> hangout to discuss any issues we have.
>
> On Sun, May 15, 2016 at 7:19 PM, Lewis John McGibbney <
> notificati...@github.com> wrote:
>
> > The PR is not finished yet. There are a number of issues as highlighted
> > above which need attention.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



-- 
*Lewis*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[KellenSunderland]

Github user KellenSunderland commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335946
  
Hey Lewis.  I'm flying today but can take a look at getting the tests to
compile next week.  Thanks for all the work.  I'd be game for a google
hangout to discuss any issues we have.

On Sun, May 15, 2016 at 7:19 PM, Lewis John McGibbney <
notificati...@github.com> wrote:

> The PR is not finished yet. There are a number of issues as highlighted
> above which need attention.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321
  
The PR is not finished yet. There are a number of issues as highlighted 
above which need attention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335100
  
My ant build is failing.. 

[ivy:resolve] 
http://ivyroundup.googlecode.com/svn/trunk/repo/modules/org.apache.commons/commons-cli/1.2/packager.xml
[ivy:resolve]   ::
[ivy:resolve]   ::  UNRESOLVED DEPENDENCIES ::
[ivy:resolve]   ::
[ivy:resolve]   :: 
net.sourceforge.ant-doxygen#ant-doxygen;1.6.1: not found
[ivy:resolve]   :: org.apache.commons#commons-cli;1.2: not found
[ivy:resolve]   ::
[ivy:resolve] 
[ivy:resolve] :: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS


 Merging this PR helps me to move forward for resolving other issues.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[thammegowda]

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219334788
  
@lewismc  Please merge this ASAP.
This is a great PR. Maven for the win!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

[lewismc]

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/12

JOSHUA-252 Make it possible to use Maven to build Joshua

Hi Folks,
This PR is a beast. I think a Google Hangout would be best to talk through 
what is going on.
Basically it, 
 * Mavenizes the entire codebase e.g. sets out the 
src/main/java/org/apache/joshua/... structure.
 * goes a long way to implementing the correct structure and notation for 
Unit testing e.g. src/test/java/org/apache/joshua/...
 * moves everything from $JOSHUA_HOM/tst to the correct src/test/java/... 
directories then removes tst
 * moves all test .java files from $JOSHUA_HOME/test to src/test/java/...
 * removes the previous Eclipse project definitions which were committed to 
the repos
 * removes the thrax submodule. We should just pull this in as a dependency 
from now on. I've therefore put up a PR for this over on 
https://github.com/joshua-decoder/thrax/issues/11
...

As I expected there are a bunch of files which include Objects which ni 
longer exist. If you pull this PR in to a branch and execute mvn clean install 
you will see that this is the case with around 6 or 7 test files. We need to 
collectively decide what to do with the missing imports.

Apart from that, work still t be done here is as follows

 * ensure that all testing resources are moved into 
$JOSHUA_HOME/src/test/resources. This folder is not currently created.
 * Remove build.xml
 * plan on how we are going to compile and package GIZA++, KenLM, etc. This 
is something @KellenSunderland @buggtd and I discussed at the ApacheCon meetup 
however there is still work to be done here.

The first thing i think, is to get the test classes compiling. Once we have 
done that we can move on to getting the tests passing and stabilizing the Java 
build code.
After that we can move on to the C++ build challenges.

All in all, a VERY successful week for Joshua. Looking forward to 
stabilizing the Maven build as it will make things so much easier or us all 
moving forward. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-252

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 8cdbc4b8e415fa1f45dd663e2a65bf69d7ef416d
Author: Lewis John McGibbney 
Date:   2016-05-14T03:49:55Z

JOSHUA-252 Make it possible to use Maven to build Joshua

commit 89e227585923e6c277a544579abc5a2b1fa91bef
Author: Lewis John McGibbney 
Date:   2016-05-14T07:53:34Z

JOSHUA-252 Make it possible to use Maven to build Joshua

commit f401535f5b50487c5c6e1f17c954904e32e5d2fb
Author: Lewis John McGibbney 
Date:   2016-05-14T08:44:43Z

JOSHUA-252 Make it possible to use Maven to build Joshua

commit 7f824b4eceefc96813f38cb6bf8c4e5f404f5f44
Author: Lewis John McGibbney 
Date:   2016-05-14T20:53:40Z

JOSHUA-252 Make it possible to use Maven to build Joshua




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---