[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844141#comment-15844141 ] Adrien Grand commented on LUCENE-6959: -- +1 > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch, > LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842885#comment-15842885 ] Michael McCandless commented on LUCENE-6959: bq. I can add that back. Thanks [~martijn.v.groningen]! > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch, > LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842806#comment-15842806 ] Martijn van Groningen commented on LUCENE-6959: --- bq. I can take a crack at putting back some of the child hit checking there, if you all haven't started on that yet? I can add that back. > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch, > LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842606#comment-15842606
]
Michael McCandless commented on LUCENE-6959:
New patch looks great, except for the {{TestBlockJoin}} tests ... I can take a
crack at putting back some of the child hit checking there, if you all haven't
started on that yet?
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch,
> LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840436#comment-15840436
]
Adrien Grand commented on LUCENE-6959:
--
Actually scratch that last comment, that would probably make the feature too
hard to use, I think a wrapper query like you propose is better. Some
questions/comments:
- should it take the childQuery into account for equals/hashcode?
- it looks buggy to me that we do not convert {{parentDocId}} to
{{parentDocId-context.docBase}} in the scorer?
- you use ConstantScoreWeight but then return a Scorer that actually scores,
you should extend Weight directly instead.
{code}
// If parentDocId == 0 then we a parent doc doesn't have child docs
{code}
Let's remove the "we"?
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch,
> LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840277#comment-15840277
]
Adrien Grand commented on LUCENE-6959:
--
I think the new query should take {{childQuery}} into account for
equals/hashcode? This makes me wonder whether we really need to wrap the child
query: we could just provide a query that matches all children for a given
parent and then users could build conjunctions using BooleanQuery to decide
what particular child documents should match?
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch,
> LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839694#comment-15839694 ] Martijn van Groningen commented on LUCENE-6959: --- I was wrong, it can `origChildQuery` can be removed as rewritten queries are used as cache key in query cache. > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839635#comment-15839635
]
Martijn van Groningen commented on LUCENE-6959:
---
bq. Do we really need the {{origChildQuery}} anymore?
In case the query get rewritten and if it happened to get cached?
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839575#comment-15839575
]
Michael McCandless commented on LUCENE-6959:
The new {{ParentChildrenBlockJoinQuery}} looks great! Much easier to use.
Do we really need the {{origChildQuery}} anymore?
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839570#comment-15839570 ] Michael McCandless commented on LUCENE-6959: bq. Mike, would just using a ScoreDoc with TopDocs be sufficient to represent a jira issue with comments in jirasearch? I think that's fine? I agree it would be nice to remove the dependency. I'll have a look at the patch! Thanks for iterating. > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839436#comment-15839436 ] Martijn van Groningen commented on LUCENE-6959: --- I wonder if we should continue using TopGroups in the TestBlockJoin test case? If we stop using it then we can remove the the dependency on the grouping module the join module has. The `TopGroups` has logic for merging other groups, but in case for block join there should be no need for that as the parent and its children are always in the same Lucene index. That makes sense, because in grouping arbitrary document can belong to a group. Mike, would just using a ScoreDoc with TopDocs be sufficient to represent a jira issue with comments in jirasearch? > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839408#comment-15839408 ] Martijn van Groningen commented on LUCENE-6959: --- bq. Can we maybe change the new query to instead hold the parent's docID in the top-level reader's space, and then in the scorer method, check the incoming reader context to see if this is the segment that holds the parent? This would also simplify usage, so users wouldn't have to create their own weights? Then I think you don't need the LeafReader reference. +1 That is much better. > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838956#comment-15838956 ] Adrien Grand commented on LUCENE-6959: -- I think I'm the one responsible for the decimated tests. Agreed it would be nice to restore them using an API that is able to compute top groups. > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838793#comment-15838793
]
Michael McCandless commented on LUCENE-6959:
Thanks [~martijn.v.groningen].
I think it's dangerous that we hold onto a {{LeafReader}} in the new
{{ParentChildrenBlockJoinQuery}}?
Can we maybe change the new query to instead hold the parent's docID in the
top-level reader's space, and then in the {{scorer}} method, check the incoming
reader context to see if this is the segment that holds the parent? This would
also simplify usage, so users wouldn't have to create their own weights? Then
I think you don't need the {{LeafReader}} reference.
Also, the {{TestBlockJoin}} tests got a little over decimated I think :) Can
we restore at least some of the places that were verifying children? Or maybe
we could make a simple sugar API that returns {{TopGroups}} again, and then we
wouldn't need to change the tests (except to switch to this sugar API)?
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838173#comment-15838173 ] Michael McCandless commented on LUCENE-6959: Oooh, thank you [~martijn.v.groningen]! I'll review the patch... > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837606#comment-15837606
]
Michael McCandless commented on LUCENE-6959:
I agree it's messy that one must use a special {{IndexSearcher}} to use this
collector, and that it's overly invasive that it needs access to child scorers,
and we should find a better way.
This collector enables you to get the matching child hits when running a joined
search against child hits up to parent documents. This is very important for
people "joining up" with document blocks, e.g. I use this in
http://jirasearch.mikemccandless.com, where child documents are each jira
comment, and parent documents are the whole jira issue.
I'd like to understand a bit better how exactly we can re-implement this
functionality once we remove the collector. That ES query class seems to be
created for each parent doc that made the top N hits, right? And then you
search with that query, which is very quick since it will hone in on just the
children of that one parent, and build up your child hits that way ... I think
this is indeed a better approach!
It's sort of weird to remove this class without first making the cleaner
implementation available, but since neither Solr nor ES use it, I think it's OK
(and it is experimental). Can we at least open an issue to add the cleaner
option? I can try to tackle it, certainly when I next upgrade jirasearch ;)
Thanks, +1 to remove in 6.x and 7.0.
> Remove ToParentBlockJoinCollector
> -
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Adrien Grand
>Priority: Minor
> Attachments: LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836779#comment-15836779 ] Martijn van Groningen commented on LUCENE-6959: --- +1 To remove this collector in the master and 6x branches. As a follow up issue we can add back to ability to include child docs, but in a different way than is done today. A subsequent search after the main search, that selects child docs for specific parents. For example like is done here: https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/search/fetch/subphase/InnerHitsContext.java#L160 > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432496#comment-15432496 ] Mikhail Khludnev commented on LUCENE-6959: -- Note. SOLR-8643 removed BlockJoinFacetCollector which calls scorer getChildren() > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082571#comment-15082571 ] Mikhail Khludnev commented on LUCENE-6959: -- Here is the recently arrived [BlockJoinFacetCollector|https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/search/join/BlockJoinFacetCollector.java#L66] also calls getChildren(). It seems it works under SolrIndexSearcher, and it's not easy to use a dedicated searcher in Solr. > Remove ToParentBlockJoinCollector > - > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
