[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231432#comment-14231432
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1642862 from [~noble.paul] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1642862 ]
SOLR-6476 refactored bulk schema APIs and other read REST APIs to use standard
RequestHandler mechanism
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
> or
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field":[ {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> {
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229961#comment-14229961
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1642705 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1642705 ]
SOLR-6476 reference to a deleted servlet cleaned up
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
> or
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field":[ {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> {
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229617#comment-14229617
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1642660 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1642660 ]
SOLR-6476 removing othe vestiges of config REST APIs
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
> or
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field":[ {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> {
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229513#comment-14229513
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1642641 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1642641 ]
SOLR-6476 refactored bulk schema APIs and other read REST APIs to use standard
RequestHandler mechanism
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
> or
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field":[ {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> {
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174893#comment-14174893
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1632526 from [~noble.paul] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1632526 ]
SOLR-6476 error message fixed
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
> or
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field":[ {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> {
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174891#comment-14174891
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1632525 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1632525 ]
SOLR-6476 error message fixed
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
> or
> {code}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field":[ {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> {
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171320#comment-14171320
]
Noble Paul commented on SOLR-6476:
--
actually both format is supported
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171305#comment-14171305
]
Yonik Seeley commented on SOLR-6476:
People hate repeated keys in JSON... we should avoid adding more of that if
possible.
Instead of:
{code}
{
"add-field": {...}, // field1
"add-field":{...}// field2
}
{code}
How about:
{code}
{
"add-field": [
{...},// field1
{...} // field2
]
}
{code}
And you can continue to still offer a simple form for a single field:
{code}
{
"add-field": {...}// field1
}
{code}
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169350#comment-14169350
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1631421 from [~noble.paul] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1631421 ]
SOLR-6476 change the error message
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169349#comment-14169349
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1631420 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1631420 ]
SOLR-6476 change the error message
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169321#comment-14169321
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1631400 from [~noble.paul] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1631400 ]
SOLR-6476 refactored to get the Operation class outside
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169317#comment-14169317
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1631397 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1631397 ]
SOLR-6476 refactored to get the Operation class outside
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158446#comment-14158446
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1629301 from [~noble.paul] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1629301 ]
SOLR-6476
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155458#comment-14155458
]
Mark Miller commented on SOLR-6476:
---
+1. If measuring elapsed time, please use nanoTime and not currentTimeMillis.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155455#comment-14155455
]
Ramkumar Aiyengar commented on SOLR-6476:
-
bq. actually System.currentTimeMillis() is fine if used in the same thread .
And if it is used in different threads it can give wrong values.
It's nothing to do with the number of threads. currentTimeMillis uses the wall
time and is not guaranteed to be monotonic. So if the sysadmin or ntp for
example changes time (or horror, if your system time uses local time and you
cross a DST transition), the difference in value between two measurements is
not guaranteed to reflect the actual duration of time. So in this case for
example you might end up violating the timeout altogether. nanoTime essentially
exposes a counter which keeps increasing, so while it has no bearing on the
system time (so a value by itself is meaningless), differences are guaranteed
to be accurate. (Well, as long as the platform supports it, which is almost
everywhere except for some random old versions of Windows).
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154989#comment-14154989
]
Steve Rowe commented on SOLR-6476:
--
Thanks Noble, your last commit fixed the two issues I mentioned. +1 to resolve
once you've backported.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154985#comment-14154985
]
Noble Paul commented on SOLR-6476:
--
bq.Aren't you going to backport this to branch_5x?
yes
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154984#comment-14154984
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1628747 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1628747 ]
SOLR-6476
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: New Feature
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154925#comment-14154925
]
ASF subversion and git services commented on SOLR-6476:
---
Commit 1628734 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1628734 ]
SOLR-6476
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Fix For: Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154760#comment-14154760
]
Noble Paul commented on SOLR-6476:
--
actually System.currentTimeMillis() is fine if used in the same thread . And if
it is used in different threads it can give wrong values. However , for
uniformity I shall change it to System.nanoTime()
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153438#comment-14153438
]
Steve Rowe commented on SOLR-6476:
--
Thanks for the changes, Noble, those look fine - two new issues:
# Didn't [~markrmil...@gmail.com] convert all timing stuff in Solr to use
{{nanoTime()}} instead of {{System.getCurrentTimeMillis()}}? If so, shouldn't
we use {{nanoTime()}} here too? (This applies to [~thelabdude]'s SOLR-6249
work as well.)
# In {{SchemaManager.waitForOtherReplicasToUpdate()}}, called from
{{doOperations()}}, you send {{-1}} in as {{maxWaitSecs}} to
{{ManagedIndexSchema.waitForSchemaZkVersionAgreement()}} when the timeout has
been exceeded, but AFAICT negative values aren't handled appropriately there,
e.g. it gets sent in unexamined to {{ExecutorService.invokeAll()}}:
{code:java}
private List doOperations(List operations){
int timeout = req.getParams().getInt(BaseSolrResource.UPDATE_TIMEOUT_SECS,
-1);
long startTime = System.currentTimeMillis();
[...]
managedIndexSchema.persistManagedSchema(false);
core.setLatestSchema(managedIndexSchema);
waitForOtherReplicasToUpdate(timeout, startTime);
[...]
}
private void waitForOtherReplicasToUpdate(int timeout, long startTime) {
if(timeout > 0 && [...]){
[...]
ManagedIndexSchema.waitForSchemaZkVersionAgreement([...],
getTimeLeftInSecs(timeout, startTime));
}
}
}
private int getTimeLeftInSecs(int timeout, long startTime) {
long timeLeftSecs = timeout - ((System.currentTimeMillis() - startTime)
/1000);
return (int) (timeLeftSecs > 0 ?timeLeftSecs: -1);
}
{code}
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153356#comment-14153356
]
Noble Paul commented on SOLR-6476:
--
SOLR-6249 features applied.
Added javadocs and added complex field types in tests
bq.Order is not important in schema.xml, and in plenty of other contexts. This
order dependence will need to be explicitly documented.
This will have to be documented in the API documentation in reference guide
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152356#comment-14152356
]
Steve Rowe commented on SOLR-6476:
--
{quote}
bq. AFAICT, a bulk Schema API request with a new field using a new field type
in the same request can fail depending on the order of the specified operations
Yes it fails. Works as designed. This is exactly the same behavior you will see
in an RDBMS as well. Order is important
{quote}
Order is not important in {{schema.xml}}, and in plenty of other contexts.
This order dependence will need to be explicitly documented.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152339#comment-14152339
]
Steve Rowe commented on SOLR-6476:
--
{quote}
bq. One of the tests should have a non-trivial fieldtype definition, like at
least one analyzer.
It is not supported yet. Pls correct me if I am wrong. does the current REST
API support it?
{quote}
Yes. See {{TestManagedSchemaFieldTypeResource}}.
{quote}
bq. Most of the add*() javadocs in IndexSchema say that persistence always
happens, but it doesn't if persist=false
It says "* @param persist to persist or not" . Isn't it right?
{quote}
This is what I'm talking about: "Copies this schema, adds the given fields to
the copy, then persists the new schema."
{quote}
bq. {{SchemaManager}} has zero javadocs. More would be good.
It is not a class for others to use . But , it will be added
{quote}
Thanks. Javadocs (or rather comments of any kind) are for maintainers too, not
just users. Here's an example where javadocs/comments would help a maintainer:
{{SchemaManager.Operation.getMetaWithout()}}. What does that thing do? (Hint:
the name of the method doesn't tell you.)
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152117#comment-14152117
]
Noble Paul commented on SOLR-6476:
--
bq.One of the tests should have a non-trivial fieldtype definition, like at
least one analyzer.
It is not supported yet. Pls correct me if I am wrong. does the current REST
API support it?
bq.Most of the add*() javadocs in IndexSchema say that persistence always
happens, but it doesn't if persist=false
It says "* @param persist to persist or not" . Isn't it right?
bq.SchemaManager has zero javadocs. More would be good.
It is not a class for others to use . But , it will be added
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152063#comment-14152063
]
Noble Paul commented on SOLR-6476:
--
bq.AFAICT, a bulk Schema API request with a new field using a new field type in
the same request can fail depending on the order of the specified operations
Yes it fails. Works as designed. This is exactly the same behavior you will see
in an RDBMS as well
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152025#comment-14152025
]
Steve Rowe commented on SOLR-6476:
--
Previously mentioned outstanding issues:
# One of the tests should have a non-trivial fieldtype definition, like at
least one analyzer.
# SchemaManager has lots of non-generic collections - I looked at a couple, and
they could be generified - maybe they all could?
# Most of the {{add\*()}} javadocs in {{IndexSchema}} say that persistence
always happens, but it doesn't if persist=false
New things I noticed today:
# {{SchemaManager}} has zero javadocs. More would be good.
# AFAICT, a bulk Schema API request with a new field using a new field type in
the same request can fail depending on the order of the specified operations,
e.g. this will fail because "newtype" won't exist when {{SchemaManager}} tries
to add "newfield" (caveat: untested):
\\
{code:javascript}
{
"add-field" : { "name":"newfield", "type":"newtype" },
"add-field-type" : { "name":"newtype", "class":"solr.StrField" }
}
{code}
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151974#comment-14151974
]
Steve Rowe commented on SOLR-6476:
--
bq. The only outstanding issue AFAIK is the no:of reties. whether it should be
finite or infinite.
(There are other outstanding issues - I'll list them in another comment after
this one.)
I still think continuous retrying when there are competing updates is the right
thing to do.
How about this: in SOLR-6249, [~thelabdude] added request param
{{updateTimeoutSecs}} to fail Schema API requests unless they succeed within
the given time. We could add checking of this timeout to the update-retry loop
if it's provided, but when it's not, we allow the update-retry loop to continue
ad infinitum.
In any case, the patch on this issue needs to be changed to make bulk Schema
API requests aware of the new {{updateTimeoutSecs}} param and perform the same
all-replicas-in-sync check that the other Schema API methods now have.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151790#comment-14151790
]
Noble Paul commented on SOLR-6476:
--
The only outstanding issue AFAIK is the no:of reties. whether it should be
finite or infinite. I believe all user interacting APIs should be coded to fail
gracefully. If we can resolve that I can commit this
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151137#comment-14151137
]
Noble Paul commented on SOLR-6476:
--
the "files link" is a problem. Instead we should just have a prominent way to
access "schema" which should display what is the current list of fields , types
etc.
we need to eventually de-prioritize the raw file view.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151134#comment-14151134
]
Erick Erickson commented on SOLR-6476:
--
Works for me. The only thing I'll _strongly_ weigh in on here is that the admin
UI _must_ be able to access at least the "describe table" functionality, and
ideally the ability to change the schema definition from the admin UI. Ditto
with accessing the rest of the configuration information. There are just waaay
too many situations "in the field" where actually seeing what the server is
working with (as opposed to what the ops person _thinks_ they've configured) on
a running instance is critical to troubleshooting.
Currently this is all done via the admin UI and the "files" link, although you
can't edit there of course.
Not quite sure how all this applies to, say, solrconfig.xml though. I guess
we'll see as things develop.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151128#comment-14151128
]
Noble Paul commented on SOLR-6476:
--
bq.A while ago, Stefan and I tried to allow schema.xml to be edited from the
admin UI.
I want to move to a system where the users are not aware of schema.xml . It
should be an internal detail. Exactly the same way I deal with my
RDBMS/Cassandra (or whatever) . The way a user thinks of my RDBMS is as follows
* Startup the server first
* use A DDL to create a schema
* During the lifecycle of the system I use more DDL to add/remove fields
* I use a command like "describe table' to know the current schema. (We have a
REST API )
* I don't really care about how the server stores the schema/config or whatever
To achieve tis goal , we must stop thinking about the system in terms of xmls
and we should start thinking about the APIs as the DDL for Solr.
The term 'managed schema' will have no relevance. schema will always be
'managed' and the the adjective 'managed' must go away
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151124#comment-14151124
]
Erick Erickson commented on SOLR-6476:
--
This is complete tangential, but I wanted to get other's thinking about it
A while ago, Stefan and I tried to allow schema.xml to be edited from the admin
UI.
See: https://issues.apache.org/jira/browse/SOLR-5287
Uwe pointed out that writing arbitrary XML to a server is a security problem so
we pulled things out. It's actually in limbo in trunk currently marked as a
blocker.
Is there any way the managed schema functionality could be warped in the Admin
UI to allow editing for the schema file? I'm forever wishing that I could do
that I suppose it would require that the managed schema is used though...
Anyway, feel free to ignore this entirely or open a new JIRA if it sparks some
ideas.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150364#comment-14150364
]
Noble Paul commented on SOLR-6476:
--
[~ysee...@gmail.com]
Let us look at it this way. This command is issued most likely by a user over
http. Normally people expect a command to succeed or fail within a few seconds.
They would be more than glad to be presented with an error message than waiting
forever. HTTP may timeout after some time too
bq.The closest analogy is something like AtomicLong.incrementAndGet()
yes, they are similar . But, that is just doing a CAS inside a CPU which can do
a zillion ops per second. Here we are talking about a distributed operation
where each try can take a a few 100 ms.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150045#comment-14150045
]
Yonik Seeley commented on SOLR-6476:
bq. It keeps retrying when another schema modification request gets in first.
Please fix this - you didn't change anything at all here. There is no way we
should be giving up here just because other modifications are happening.
+1
The closest analogy is something like AtomicLong.incrementAndGet()
Those implementations try forever. It would be exceedingly rare for starvation
for any amount of time... but if we say it can fail then clients need to
implement their own try-until-success loop (which won't succeed any faster!)
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147935#comment-14147935
]
Noble Paul commented on SOLR-6476:
--
bq.It can, but you don't have any distributed tests at all.
I should fix that. May be separately
bq.You removed some sugar methods,
Yeah, the class was getting very hard to read with all the sugar methods and I
prefer them removed
bq.You misunderstand me: SolrTestCaseJ4.json(String)
ok , I got it . I'll fix it
I'll fix the javadocs , in the next patch.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147824#comment-14147824
]
Steve Rowe commented on SOLR-6476:
--
FYI [~noble.paul], I have create a review request on ReviewBoard to compare the
previous patch I reviewed with your latest: https://reviews.apache.org/r/26037/
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147819#comment-14147819
]
Steve Rowe commented on SOLR-6476:
--
{quote}
bq. The bulk schema api should be added to TestCloudManagedSchemaConcurrent
Why can't it be in a new class?
{quote}
It can, but you don't have any distributed tests at all. All existing schema
API modification functionality gets distributed testing via
{{TestCloudManagedSchemaConcurrent}} at this point.
{quote}
bq. {{TestBulkSchemaAPI}} has lots of backslash-double-quotes in JSON strings
That was deliberate. Most JSON writers use double quotes.
{quote}
You misunderstand me: {{SolrTestCaseJ4.json(String)}} converts single-quotes to
double-quotes. Several Solr tests use it to get most-JSON-writer-compatible
output without causing backslash-eye-bleed. I'm suggesting you do the same.
{quote}
bq. In SchemaManager.doOperation(), you limit retries to MAX_TRIES
I can make the variable bigger , but I somehow hate infinite loops
{quote}
It keeps retrying when another schema modification request gets in first.
Please fix this - you didn't change anything at all here. There is no way we
should be giving up here just because other modifications are happening.
{quote}
bq. SchemaManager.ADD_FIELD_TYPE should be "add-field-type"
sure
{quote}
bq. I also want to ask the preference of "add-field" Vs "addField" in the
command names
Thanks - I like "add-field" better, but either would be fine.
{quote}
bq. {{SchemaManager}} has lots of non-generic collections
will fix them
{quote}
I only see one modification here (you added {{}} on the left hand side
but forgot to put in the diamond operator on the right side), still lots of
non-generic collection usages - is there a problem with fixing the others?
{quote}
bq. Most of the add*() javadocs in IndexSchema say that persistence always
happens, but it doesn't if persist=false
We need to remove those methods without persist option
{quote}
You removed some sugar methods, specifically for adding a single dynamic field,
but left other sugar methods intact, e.g. {{addField()}} - why the
inconsistency? I personally think sugar methods are fine - that's why I put
them there - but if you're going to remove them, please be consistent.
And the javadocs are still wrong:
# the persist param isn't listed on {{addFieldTypes()}} and
{{addDynamicFields()}}
# the javadocs for all the methods say the methods will always persist. This
is wrong.
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144724#comment-14144724
]
Noble Paul commented on SOLR-6476:
--
New patch posted with changes incorporated
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144500#comment-14144500
]
Noble Paul commented on SOLR-6476:
--
I also want to ask the preference of "add-field" Vs "addField" in the command
names
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144498#comment-14144498
]
Noble Paul commented on SOLR-6476:
--
bq.The bulk schema api should be added to TestCloudManagedSchemaConcurrent
Why can't it be in a new class?
bq.TestBulkSchemaAPI has lots of backslash-double-quotes in JSON strings
That was deliberate. Most JSON writers use double quotes.
bq.In SchemaManager.doOperation(), you limit retries to MAX_TRIES
I can make the variable bigger , but I somehow hate infinite loops
bq.SchemaManager.ADD_FIELD_TYPE should be "add-field-type"
sure
bq.SchemaManager has lots of non-generic collections
will fix them
bq.IndexSchema.addDynamicFields() is missing the persist param you added to all
the other add*() methods;
will fix
bq.Most of the add*() javadocs in IndexSchema say that persistence always
happens, but it doesn't if persist=false
will fix
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144491#comment-14144491
]
Steve Rowe commented on SOLR-6476:
--
Noble, I looked at your latest patch and I found a few issues:
# The bulk schema api should be added to {{TestCloudManagedSchemaConcurrent}}
# {{TestBulkSchemaAPI}} has lots of backslash-double-quotes in JSON strings -
those are way easier to look at if you convert the backslash-double-quotes to
single-quotes and pass the string to the {{json()}} method.
# One of the tests should have a non-trivial fieldtype definition, like at
least one analyzer.
# In {{SchemaManager.doOperation()}}, you limit retries to {{MAX_TRIES}} when
there is a {{SchemaChangedInZkException}}, but none of the other schema APIs do
that - why not let it continue until success?
# {{SchemaManager.ADD_FIELD_TYPE}} should be "add-field-type" instead of
"add-type". (Solr could introduce a non-field type at some point in the
future; even with "\-field\-" added, it's still not the longest command.)
# {{SchemaManager}} has lots of non-generic collections - I looked at a couple,
and they could be generified - maybe they all could?
# {{IndexSchema.addDynamicFields()}} is missing the {{persist}} param you added
to all the other {{add\*()}} methods; also, it always persists, even when
called from the bulk mode schema api.
# Most of the {{add\*()}} javadocs in {{IndexSchema}} say that persistence
always happens, but it doesn't if persist=false
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-6476) Create a bulk mode for schema API
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140272#comment-14140272
]
Noble Paul commented on SOLR-6476:
--
I plan to commit this soon
> Create a bulk mode for schema API
> -
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
>Reporter: Noble Paul
>Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
