Re: Merge it0105 and it0107 to 2.0.x branch
I don't see the need for either, since the trunk set is a superset of what is on the branch. Kenney Westerhof wrote: On Mon, 12 Jun 2006, Carlos Sanchez wrote: Just tossing in an idea: Perhaps a more sophisticated system where you specify which version of maven is needed for the it test - especially useful for new feature testing that's not available in some versions of m2. So instead of #commenting out you have lines like it [2.0.4) This would imply that the it tests are not on trunk or branch but a new top level project. -- Kenney I think the question here is, should we merge the itxxx folders and then just have the test deactivated in the branch? that would make the differencies between trunk and branch minimal which I see as a good thing (TM) On 6/12/06, Brett Porter <[EMAIL PROTECTED]> wrote: jerome lacoste wrote: Someone might want to create a test case for a branch issue without looking at the trunk. And it's better to keep itest ids synchronized. That would be against our development practices we agreed on a while back (everything goes through trunk). The only scenario would be something that only ever works on the branch, not the trunk, I'd question the value of such a thing. - Brett -- Brett Porter <[EMAIL PROTECTED]> Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- I could give you my word as a Spaniard. No good. I've known too many Spaniards. -- The Princess Bride - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter <[EMAIL PROTECTED]> Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
On Mon, 12 Jun 2006, Carlos Sanchez wrote: Just tossing in an idea: Perhaps a more sophisticated system where you specify which version of maven is needed for the it test - especially useful for new feature testing that's not available in some versions of m2. So instead of #commenting out you have lines like it [2.0.4) This would imply that the it tests are not on trunk or branch but a new top level project. -- Kenney > I think the question here is, should we merge the itxxx folders and > then just have the test deactivated in the branch? that would make the > differencies between trunk and branch minimal which I see as a good > thing (TM) > > On 6/12/06, Brett Porter <[EMAIL PROTECTED]> wrote: > > jerome lacoste wrote: > > > Someone might want to create a test case for a branch issue without > > > looking at the trunk. And it's better to keep itest ids synchronized. > > > > That would be against our development practices we agreed on a while > > back (everything goes through trunk). > > > > The only scenario would be something that only ever works on the branch, > > not the trunk, I'd question the value of such a thing. > > > > - Brett > > > > -- > > Brett Porter <[EMAIL PROTECTED]> > > Apache Maven - http://maven.apache.org/ > > Better Builds with Maven - http://library.mergere.com/ > > > > - > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > I could give you my word as a Spaniard. > No good. I've known too many Spaniards. > -- The Princess Bride > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
I think the question here is, should we merge the itxxx folders and then just have the test deactivated in the branch? that would make the differencies between trunk and branch minimal which I see as a good thing (TM) On 6/12/06, Brett Porter <[EMAIL PROTECTED]> wrote: jerome lacoste wrote: > Someone might want to create a test case for a branch issue without > looking at the trunk. And it's better to keep itest ids synchronized. That would be against our development practices we agreed on a while back (everything goes through trunk). The only scenario would be something that only ever works on the branch, not the trunk, I'd question the value of such a thing. - Brett -- Brett Porter <[EMAIL PROTECTED]> Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- I could give you my word as a Spaniard. No good. I've known too many Spaniards. -- The Princess Bride - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
jerome lacoste wrote: Someone might want to create a test case for a branch issue without looking at the trunk. And it's better to keep itest ids synchronized. That would be against our development practices we agreed on a while back (everything goes through trunk). The only scenario would be something that only ever works on the branch, not the trunk, I'd question the value of such a thing. - Brett -- Brett Porter <[EMAIL PROTECTED]> Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
On 6/9/06, Kenney Westerhof <[EMAIL PROTECTED]> wrote: On Fri, 9 Jun 2006, Carlos Sanchez wrote: Carlos, > Kenney, could you check it0105 and it0107 and merge its revisions them > to the 2.0.x branch, or does it not apply? it0107 is related to MNG-2293 which is only applied to trunk, so that one doesn't make any sense to commit to the 2.0.x branch. it0105.. that's a long time ago. Looking at the issue (MRESOURCES-18), it's intended for 2.2 (although it's fixed in trunk so it'll be in 2.1 too). BTW, is there some policy to add them to the README.txt and integrationtests.txt files anyway, to make sure the 'ids' are allocated? Something like: it0107: trunk only Someone might want to create a test case for a branch issue without looking at the trunk. And it's better to keep itest ids synchronized. Jerome - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
On Fri, 9 Jun 2006, Carlos Sanchez wrote: [snip] > > it0105.. that's a long time ago. Looking at the issue (MRESOURCES-18), > > it's intended for 2.2 (although it's fixed in trunk so it'll be in 2.1 > > too). > > > > I haven't found the cause for this bug yet, but the problem does not > > occur in 2.0.x, so this one shouldn't be applied to the 2.0.x trunk > > either. Although a case can be made that this regression test should be in > > 2.0.x. > > this issue is closed but I don't see any changes in the resources > plugin inside Subversion Commits tab? yeah, i'm wondering about that too. I guess the svn root for the resources plugin is below the components so JIRA doesn't 'see' the commit in the maven-core-it directory. > If it applies only to the plugin it'd be better to move the test to > the plugin. Anyway as it's not components related should be in the > branch too I'm not sure where the bug comes from. Might be some interpolation issue in maven-core or maven-project, or just in the resources plugin (i filed it there because it was the obvious place until the real cause could be determined..) I found that bug while I was using a bootstrapped build from a few weeks old. When I updated and rebootstrapped the bug was gone. So there are no code changes. I wasn't sure where to put this or how to handle this at the time, but I thought it best to at least mention it and add a regression test so it wouldn't be forgotten about. -- Kenney - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
On 6/9/06, Kenney Westerhof <[EMAIL PROTECTED]> wrote: On Fri, 9 Jun 2006, Carlos Sanchez wrote: Carlos, > Kenney, could you check it0105 and it0107 and merge its revisions them > to the 2.0.x branch, or does it not apply? it0107 is related to MNG-2293 which is only applied to trunk, so that one doesn't make any sense to commit to the 2.0.x branch. ok it0105.. that's a long time ago. Looking at the issue (MRESOURCES-18), it's intended for 2.2 (although it's fixed in trunk so it'll be in 2.1 too). I haven't found the cause for this bug yet, but the problem does not occur in 2.0.x, so this one shouldn't be applied to the 2.0.x trunk either. Although a case can be made that this regression test should be in 2.0.x. this issue is closed but I don't see any changes in the resources plugin inside Subversion Commits tab? If it applies only to the plugin it'd be better to move the test to the plugin. Anyway as it's not components related should be in the branch too Knowing this, what do you want me to do? Add the it0105 to 2.0.x? -- Kenney > > Thanks > > -- > I could give you my word as a Spaniard. > No good. I've known too many Spaniards. > -- The Princess Bride > -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- I could give you my word as a Spaniard. No good. I've known too many Spaniards. -- The Princess Bride - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Merge it0105 and it0107 to 2.0.x branch
On Fri, 9 Jun 2006, Carlos Sanchez wrote: Carlos, > Kenney, could you check it0105 and it0107 and merge its revisions them > to the 2.0.x branch, or does it not apply? it0107 is related to MNG-2293 which is only applied to trunk, so that one doesn't make any sense to commit to the 2.0.x branch. it0105.. that's a long time ago. Looking at the issue (MRESOURCES-18), it's intended for 2.2 (although it's fixed in trunk so it'll be in 2.1 too). I haven't found the cause for this bug yet, but the problem does not occur in 2.0.x, so this one shouldn't be applied to the 2.0.x trunk either. Although a case can be made that this regression test should be in 2.0.x. Knowing this, what do you want me to do? Add the it0105 to 2.0.x? -- Kenney > > Thanks > > -- > I could give you my word as a Spaniard. > No good. I've known too many Spaniards. > -- The Princess Bride > -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Merge it0105 and it0107 to 2.0.x branch
Kenney, could you check it0105 and it0107 and merge its revisions them to the 2.0.x branch, or does it not apply? Thanks -- I could give you my word as a Spaniard. No good. I've known too many Spaniards. -- The Princess Bride - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
