Review Request 24734: Fixed a few issues in configure.ac.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/
---

Review request for mesos, Timothy St. Clair and Vinod Kone.


Repository: mesos-git


Description
---

Merged the fix in https://reviews.apache.org/r/24714/

Fixed a few other issues.

Also, did a few consistency/style fix.


Diffs
-

  3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 
  configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c 

Diff: https://reviews.apache.org/r/24734/diff/


Testing
---

On my mac:

CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure 
--prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled 
--with-leveldb=/opt/twitter --with-glog=/opt/twitter 
--with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 
--disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter 
--with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser


Thanks,

Jie Yu

Re: Review Request 24733: Minor fixes for prefix installation of libev and http-parser.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24733/#review50705
---

Ship it!


Ship It!

- Jie Yu


On Aug. 15, 2014, 5:36 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24733/
> ---
> 
> (Updated Aug. 15, 2014, 5:36 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 
> 
> Diff: https://reviews.apache.org/r/24733/diff/
> 
> 
> Testing
> ---
> 
> configured with prefix installation of libev and http parser.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Build failed in Jenkins: Mesos-Ubuntu-distcheck #275

[Apache Jenkins Server]

See 

Changes:

[vinodkone] Fixed style issues in slave/flags.hpp.

--
[...truncated 2646 lines...]
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ mesos ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ mesos ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/classes
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ mesos ---
[INFO] Compiling 16 source files to 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
mesos ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/src/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
mesos ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ mesos ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mesos ---
[INFO] Building jar: 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/mesos-0.20.0.jar
[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ mesos 
---
[INFO] 
[INFO] --- maven-javadoc-plugin:2.8.1:jar (build-and-attach-javadocs) @ mesos 
---
[INFO] 
Loading source files for package org.apache.mesos...
Loading source files for package org.apache.mesos.state...
Loading source files for package org.apache.mesos.containerizer...
Constructing Javadoc information...
Standard Doclet version 1.6.0_20
Building tree for all the packages and classes...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Executor.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//ExecutorDriver.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.Entry.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.OperationFailedException.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.Position.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.Reader.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.Writer.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Log.WriterFailedException.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//MesosExecutorDriver.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//MesosSchedulerDriver.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//Scheduler.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//SchedulerDriver.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//AbstractState.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//InMemoryState.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//LevelDBState.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//State.html...
Generating 
/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck

Review Request 24733: Minor fixes for prefix installation of libev and http-parser.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24733/
---

Review request for mesos, Jie Yu and Timothy St. Clair.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 

Diff: https://reviews.apache.org/r/24733/diff/


Testing
---

configured with prefix installation of libev and http parser.


Thanks,

Vinod Kone

Re: Review Request 24731: Allow external isolator flag to be backward compatible

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
---

(Updated Aug. 15, 2014, 5:01 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1580
https://issues.apache.org/jira/browse/MESOS-1580


Repository: mesos-git


Description (updated)
---

Allow external isolator flag to be backward compatible


Diffs
-

  src/slave/containerizer/containerizer.cpp 
0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
---

make


Thanks,

Timothy Chen

Review Request 24732: Fix build error in docker.cpp for clang

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24732/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

Fix build error in docker.cpp for clang


Diffs
-

  src/slave/containerizer/docker.cpp d5292b609a9348e36d1327c9719f347bba84efb2 

Diff: https://reviews.apache.org/r/24732/diff/


Testing
---

make check, built on OSX and Ubuntu


Thanks,

Timothy Chen

Re: Review Request 24731: Allow external isolator flag to be backward compatible

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/#review50700
---

Ship it!



src/slave/containerizer/containerizer.cpp


ExternalContainerizer::create(flags, local)


- Benjamin Hindman


On Aug. 15, 2014, 4:04 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24731/
> ---
> 
> (Updated Aug. 15, 2014, 4:04 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1580
> https://issues.apache.org/jira/browse/MESOS-1580
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Allow external isolator flag to be backward compatible
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 0a262ee04f35f8236826c5ada8e7698838af4db5 
> 
> Diff: https://reviews.apache.org/r/24731/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24731: Allow external isolator flag to be backward compatible

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
---

(Updated Aug. 15, 2014, 4:04 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1580
https://issues.apache.org/jira/browse/MESOS-1580


Repository: mesos-git


Description
---

Allow external isolator flag to be backward compatible


Diffs
-

  src/slave/containerizer/containerizer.cpp 
0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
---

make


Thanks,

Timothy Chen

Review Request 24731: Allow external isolator flag to be backward compatible

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

Allow external isolator flag to be backward compatible


Diffs
-

  src/slave/containerizer/containerizer.cpp 
0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
---

make


Thanks,

Timothy Chen

Review Request 24730: Allow override to run in command executor

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24730/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Allow override to run in command executor


Diffs
-

  src/launcher/executor.cpp 1aa2c99a5e5b19982e99f03d6fbb3bc3d34cea64 
  src/tests/docker_containerizer_tests.cpp 
e0fd62f83387635f503817ced7a592cc3ae6e775 

Diff: https://reviews.apache.org/r/24730/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

[Nikita Vetoshkin]

> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote:
> > I don't think that si_uid can give something interesting because it can be 
> > either 0 or UID of receiving process. How about logging si_pid too?
> 
> Ben Mahler wrote:
> si_uid represents the user id of the _sending_ process, not the receiving 
> process. Am I missing something?
> 
> We could log the pid as well, hopefully that helps us identify long-lived 
> proceses, like init or monit.

>represents the user id of the sending process, not the receiving process.

I think otherwise you won't receive the signal, sender will get EPERM upon 
calling kill(2).

>that helps us identify long-lived proceses, like init or monit.

Yes, that's exactly my point.


- Nikita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50607
---


On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24700/
> ---
> 
> (Updated Aug. 14, 2014, 3:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1567
> https://issues.apache.org/jira/browse/MESOS-1567
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Log the user id when receiving a SIGTERM. This will make debugging more easy.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea 
> 
> Diff: https://reviews.apache.org/r/24700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>

Jenkins build is back to normal : mesos-reviewbot #1346

[Apache Jenkins Server]

See 

Re: Review Request 24667: Added a user doc for framework rate limiting.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50697
---


Bad patch!

Reviews applied: [24667]

Failed command: git apply --index 24667.patch

Error:
 error: docs/framework-rate-limiting.md: already exists in index

- Mesos ReviewBot


On Aug. 14, 2014, 10:16 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> ---
> 
> (Updated Aug. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
> https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> ---
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24719: Added document for network monitoring.

[Chi Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24719/#review50686
---

Ship it!


all minor stuff.


docs/network-monitoring.md


[czhang@tw-172-25-24-214 linux]$ git describe 
6a662719c9868b3d6c7d26b3a085f0cd3cc15e64
v3.15-rc1-55-g6a66271
[czhang@tw-172-25-24-214 linux]$ git describe 
0d5edc68739f1c1e0519acbea1d3f0c1882a15d7
v3.15-rc1-56-g0d5edc6
[czhang@tw-172-25-24-214 linux]$ git describe 
e374c618b1465f0292047a9f4c244bd71ab5f1f0
v3.15-rc1-512-ge374c61
[czhang@tw-172-25-24-214 linux]$ git describe 
7a9bc9b81a5bc6e44ebc80ef781332e4385083f2  <-- can probably skip.
v3.5-rc4-1092-g7a9bc9b
[czhang@tw-172-25-24-214 linux]$ git describe 
25f929fbff0d1bcebf2e92656d33025cd330cbf8
v3.14-rc2-257-g25f929f

for the other 4, maybe rephrase to be more explict on 'a minimum 3.6 kernel 
+ those patches _backported_'?



docs/network-monitoring.md


for this whole dependency section, maybe just say something like 'network 
monitoring depends on libnl3 (url) >= 3.2.25. iproute2 (url) >= 2.6.39 is 
advised for debugging support ('ip netns' subcommands).



docs/network-monitoring.md


iproute2 v2.6.39-8 starts to support netns



docs/network-monitoring.md


s/world/network/



docs/network-monitoring.md


s/executor/executors/



docs/network-monitoring.md


add a shell-style comment at the end of the line to explain the effect? 
'this reduces ephemeral ports available to host to only 57345-61000'?


- Chi Zhang


On Aug. 15, 2014, 12:13 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24719/
> ---
> 
> (Updated Aug. 15, 2014, 12:13 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24719/diff/
> 
> 
> Testing
> ---
> 
> checked the markdown syntax
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 20983: Update system check (http-parser)

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20983/#review50690
---



3rdparty/libprocess/configure.ac


what about LDFLAGS?



3rdparty/libprocess/configure.ac


We also need to AC_CHECK_LIB for the lib here.


- Vinod Kone


On May 5, 2014, 7:13 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20983/
> ---
> 
> (Updated May 5, 2014, 7:13 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1175
> https://issues.apache.org/jira/browse/MESOS-1175
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Updates libprocess configure check for http-parser to build against system 
> dependencies outlined in MESOS-1071
> + fixes libprocess local 'make check' which was broken
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 980146b 
>   3rdparty/libprocess/Makefile.am 8990f38 
>   3rdparty/libprocess/configure.ac 0c7cc6d 
> 
> Diff: https://reviews.apache.org/r/20983/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 23414: Unbundling of libev

[Vinod Kone]

> On Aug. 15, 2014, 1:18 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, lines 80-86
> > 
> >
> > I think you also forgot to plumb this through the configure.ac at the 
> > root of the repo, like you did for other deps?

nm..this is libprocess only dep.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review50684
---


On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23414/
> ---
> 
> (Updated July 11, 2014, 4:16 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against the system installed version of libev.  
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/Makefile.am 87cf1ae 
>   3rdparty/libprocess/configure.ac 27c6ede 
> 
> Diff: https://reviews.apache.org/r/23414/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50687
---

Ship it!



src/launcher/fetcher.cpp


s/the the/the/



src/launcher/fetcher.cpp


s/it's/its/


- Ian Downes


On Aug. 14, 2014, 5:26 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> ---
> 
> (Updated Aug. 14, 2014, 5:26 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 
> 1f458970081639db50d07c4ca67765a8b0903978 
>   src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d0676c55e3bb30bcc8e32b27c091080ec58b0c81 
> 
> Diff: https://reviews.apache.org/r/24722/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 23414: Unbundling of libev

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review50684
---



3rdparty/libprocess/configure.ac


I think you also forgot to plumb this through the configure.ac at the root 
of the repo, like you did for other deps?


- Vinod Kone


On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23414/
> ---
> 
> (Updated July 11, 2014, 4:16 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against the system installed version of libev.  
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/Makefile.am 87cf1ae 
>   3rdparty/libprocess/configure.ac 27c6ede 
> 
> Diff: https://reviews.apache.org/r/23414/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24687: Added support for disabling glog initialization.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24687/#review50678
---

Ship it!



include/mesos/executor.hpp


Would a better example here and below be GLOG_v (even though it's not a 
mesos flag)? I think by default we don't print anything, right?



src/exec/exec.cpp


Curious why you didn't use executor->error() here akin to what's done 
inside sched.cpp?



src/logging/flags.hpp


Does 'initialize_logging' read more naturally?

Maybe we should have a NOTE in this flag description that this is only used 
for the library entry points (executor / scheduler drivers), for other 
components (master / slave) it is ignored completely.


- Ben Mahler


On Aug. 14, 2014, 1:19 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24687/
> ---
> 
> (Updated Aug. 14, 2014, 1:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1629
> https://issues.apache.org/jira/browse/MESOS-1629
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> C++ frameworks can now explicitly disable glog initialization if they choose 
> to do so.
> 
> By default now the executor driver also enables glog initialization. It 
> didn't use to before, but I think that's a bug.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp ed2330f1677b9aa56ef43bae5dec0b3acfca0e1c 
>   include/mesos/scheduler.hpp 802727270ae8afb2d772bdb0170a2378dd611ee4 
>   src/exec/exec.cpp 15d41eb303c81a1ae958adc76a105c11d7ef72ef 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java 
> 910548c0b5137294f67b8a21b8c77fc2d8dbd5e3 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> afdbbbc0e6deddcf620517b7ecc4ab7947ae91b6 
>   src/logging/flags.hpp d30a7069c07af5b98a7f26e4158e839cbf424506 
>   src/sched/sched.cpp cbc52916c551b324aab7c5ddb51b2f7679cae88b 
>   src/scheduler/scheduler.cpp 498d6aa421c96768d4be0ccff38d148e992949fc 
> 
> Diff: https://reviews.apache.org/r/24687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> # ./src/long-lived-framework 127.0.0.1:5050
> I0814 01:13:32.889717 56878 sched.cpp:139] Version: 0.20.0
> I0814 01:13:32.896556 56975 sched.cpp:235] New master detected at 
> master@127.0.0.1:5050
> I0814 01:13:32.896836 56975 sched.cpp:243] No credentials provided. 
> Attempting to register without authentication
> 
> # MESOS_LOGGING_INITIALIZE=0 ./src/long-lived-framework 127.0.0.1:5050
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> I0814 01:14:18.517209 60286 sched.cpp:139] Version: 0.20.0
> I0814 01:14:18.524113 60322 sched.cpp:235] New master detected at 
> master@127.0.0.1:5050
> I0814 01:14:18.524395 60322 sched.cpp:243] No credentials provided. 
> Attempting to register without authentication
> 
> 
> # MESOS_LOGGING_INITIALIZE=1 ./src/long-lived-framework 127.0.0.1:5050
> I0814 01:14:25.621443 60969 sched.cpp:139] Version: 0.20.0
> I0814 01:14:25.628525 60986 sched.cpp:235] New master detected at 
> master@127.0.0.1:5050
> I0814 01:14:25.628746 60986 sched.cpp:243] No credentials provided. 
> Attempting to register without authentication
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 24714: fix prefix glog on mac

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/
---

(Updated Aug. 15, 2014, 1:07 a.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

fix prefix glog on mac


Repository: mesos-git


Description
---

Fixes on glog check to support mac.


Diffs
-

  3rdparty/libprocess/configure.ac f552e60 
  configure.ac 30a7e26 

Diff: https://reviews.apache.org/r/24714/diff/


Testing
---

./configure --with-glog=/opt/local && make check  


Thanks,

Timothy St. Clair

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50681
---



src/launcher/fetcher.cpp


Nit: We've been using SIGKILL instead of 9 in the code base.


- Timothy Chen


On Aug. 15, 2014, 12:26 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> ---
> 
> (Updated Aug. 15, 2014, 12:26 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 
> 1f458970081639db50d07c4ca67765a8b0903978 
>   src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d0676c55e3bb30bcc8e32b27c091080ec58b0c81 
> 
> Diff: https://reviews.apache.org/r/24722/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50673
---

Ship it!



src/launcher/fetcher.cpp


Some process might be forking, so we might miss some processes here, right? 
Adding a TODO?



src/launcher/fetcher.cpp


s/stdin/STDIN_FILENO/?


- Jie Yu


On Aug. 15, 2014, 12:26 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> ---
> 
> (Updated Aug. 15, 2014, 12:26 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 
> 1f458970081639db50d07c4ca67765a8b0903978 
>   src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d0676c55e3bb30bcc8e32b27c091080ec58b0c81 
> 
> Diff: https://reviews.apache.org/r/24722/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/
---

(Updated Aug. 15, 2014, 12:26 a.m.)


Review request for mesos, Ian Downes and Jie Yu.


Repository: mesos-git


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 
1f458970081639db50d07c4ca67765a8b0903978 
  src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 
  src/slave/containerizer/mesos/containerizer.cpp 
d0676c55e3bb30bcc8e32b27c091080ec58b0c81 

Diff: https://reviews.apache.org/r/24722/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/
---

Review request for mesos, Ian Downes and Jie Yu.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 
1f458970081639db50d07c4ca67765a8b0903978 
  src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 

Diff: https://reviews.apache.org/r/24722/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24719: Added document for network monitoring.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24719/#review50668
---

Ship it!



docs/network-monitoring.md


s/Our/The current/ ?

can you expand on "will not notice any difference"? you mean no difference 
w.r.t getting a private bridge, NAT or anything like that right?



docs/network-monitoring.md


s/Prerequisite/Prerequisites/



docs/network-monitoring.md


s/our code/Mesos/



docs/network-monitoring.md


Can you update the "getting started doc" too w.r.t these pre-reqs for 
network monitoring?



docs/network-monitoring.md


is there an authoritative doc that we can link to for more info on "network 
namespaces"?



docs/network-monitoring.md


s/port/ports/ ?



docs/network-monitoring.md


s/previously/ pre 0.20.0/

or maybe

s/previously/without network monitoring/

s/non of the/none of the/

s/host process is/host processes are/



docs/network-monitoring.md


s/squeeze/squeeze and reboot/



docs/network-monitoring.md


Also, note that they need to add "network/portmapping" to --isolation flag.

s/resource/resource (via '--resources' flag)/

s/wanna/want to/ :)



docs/network-monitoring.md


s/this is/these are/



docs/network-monitoring.md


give a random executor_id, executor_name and source instead of 
"aurora/thermos" :)


- Vinod Kone


On Aug. 15, 2014, 12:13 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24719/
> ---
> 
> (Updated Aug. 15, 2014, 12:13 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24719/diff/
> 
> 
> Testing
> ---
> 
> checked the markdown syntax
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24719: Added document for network monitoring.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24719/
---

(Updated Aug. 15, 2014, 12:13 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.


Changes
---

+chi and cong


Repository: mesos-git


Description
---

See summary


Diffs
-

  docs/network-monitoring.md PRE-CREATION 

Diff: https://reviews.apache.org/r/24719/diff/


Testing
---

checked the markdown syntax


Thanks,

Jie Yu

Re: Python bindings are changing!

[Thomas Rampelberg]

> More specifically, say all masters/slaves/executors/schedulers are using
> 0.19.1. What should we upgrade first? For example
> 1) If we upgrade the slaves first (libmesos.so will be updated), what
> happens if the new slave launches an old executor? (here, you actually have
> two cases: a) the executor bundles libmesos.so; b) the execute does not
> bundle libmesos.so)

The python egg statically links libmesos.so. If the new slave launches
an executor running the old egg, your slave will be running 0.20 and
the executor will be on 0.19.

> 2) Same question for framework, which one should we upgrade first (scheduler
> or master)?

There's nothing different here wrt. python.

Build failed in Jenkins: mesos-reviewbot #1345

[Apache Jenkins Server]

See 

Changes:

[benjamin.hindman] Redirect Docker logs.

[yan] Added a user doc for framework rate limiting.

--
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
Started by an SCM change
Started by an SCM change
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace 

 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/mesos.git
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/mesos.git
 > git --version
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/mesos.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit}
Checking out Revision 0083b1285a4fe3755c96de6abf76a35b429a85e3 (origin/master)
 > git config core.sparsecheckout
 > git checkout -f 0083b1285a4fe3755c96de6abf76a35b429a85e3
 > git rev-list b70a863d2214231e306ce6e2932557439a5ecba6
 > git tag -a -f -m Jenkins Build #1345 jenkins-mesos-reviewbot-1345
[mesos-reviewbot] $ /bin/bash -xe /tmp/hudson4008794208724925731.sh
+ export JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64
+ JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64
+ export 
PATH=/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ 
PATH=/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ export M2_HOME=/home/jenkins/tools/maven/latest
+ M2_HOME=/home/jenkins/tools/maven/latest
+ export 
PATH=/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ 
PATH=/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ date
Thu Aug 14 23:47:34 UTC 2014
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile.am NOTICE README.md 
bin bootstrap configure.ac docs ec2 frameworks include m4 mesos.pc.in mpi src 
support
+ git clean -fdx
Removing 3rdparty/leveldb/
+ git reset --hard HEAD
HEAD is now at 0083b12 Added a user doc for framework rate limiting.
+ ./support/mesos-style.py
Checking 503 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/slave/flags.hpp:294:  Lines should be <= 80 characters long  
[whitespace/line_length] [2]
Total errors found: 1
Build step 'Execute shell' marked build as failure

Re: Python bindings are changing!

[Thomas Rampelberg]

There is one important step to do during the upgrade:

- Upgrade your python framework and executor. You'll be able to either
import using the new configuration or the old. Replace the existing
imports with this:

try:
from mesos.native import MesosExecutorDriver, MesosSchedulerDriver
from mesos.interface import Executor, Scheduler
from mesos.interface import mesos_pb2
except ImportError:
from mesos import Executor, MesosExecutorDriver,
MesosSchedulerDriver, Scheduler
import mesos_pb2

Then, you'll be able to follow the normal upgrade instructions.
Following the ones from the 0.18.x -> 0.19.x instructions:

- Install the new master binaries and restart the masters.
- Install the new slave binaries and restart the slaves.
- Upgrade the schedulers by installing the latest python egg.
- Restart the schedulers.
- Upgrade the executors by installing the latest python egg.

On Wed, Aug 13, 2014 at 10:19 AM, Jie Yu  wrote:
> Thomas,
>
> We are about to cut the 0.20.0 release. I am updating the docs/upgrades.md.
> Regarding the python binding change, can you let us know the exact deploy
> procedure if someone is using the old python binding?
>
> More specifically, say all masters/slaves/executors/schedulers are using
> 0.19.1. What should we upgrade first? For example
> 1) If we upgrade the slaves first (libmesos.so will be updated), what
> happens if the new slave launches an old executor? (here, you actually have
> two cases: a) the executor bundles libmesos.so; b) the execute does not
> bundle libmesos.so)
> 2) Same question for framework, which one should we upgrade first (scheduler
> or master)?
>
> Also, would you please test all these scenarios so that we can provide
> correct guidance to the community. Thanks a lot!
>
> - Jie
>
>
> On Sun, Aug 3, 2014 at 11:18 PM, Benjamin Mahler 
> wrote:
>>>
>>> It might work to use
>>> 0.19 with a 0.20 mesos (or visa versa), but there be dragons =)
>>
>>
>> Is there a deprecation cycle? How should folks be upgrading Python
>> schedulers
>> and executors to 0.20.0 if they are not statically bundling libmesos?
>> Is there an upgrade order required?
>>
>> We will need to document this carefully in the upgrade procedures for
>> 0.20.0.
>>
>> Thanks for cleaning this up Thomas! Appreciate it.
>>
>> On Sat, Aug 2, 2014 at 12:12 PM, Thomas Rampelberg 
>> wrote:
>>>
>>> You'll want to match the python bindings to your mesos version as the
>>> functionality is coming from libmesos itself. It might work to use
>>> 0.19 with a 0.20 mesos (or visa versa), but there be dragons =)
>>>
>>>
>>> On Fri, Aug 1, 2014 at 1:30 PM, Jie Yu  wrote:
>>> > Thomas,
>>> >
>>> > Thank you for the heads-up. One question: what if mesos and python
>>> > binding
>>> > have different versions? For example, is it ok to use a 0.19.0 python
>>> > binding and having a 0.20.0 mesos? Same question for the reverse.
>>> >
>>> > - Jie
>>> >
>>> >
>>> > On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg 
>>> > wrote:
>>> >
>>> >> - What problem are we trying to solve?
>>> >>
>>> >> Currently, the python bindings group protobufs, stub implementations
>>> >> and compiled code into a single python package that cannot be
>>> >> distributed easily. This forces python projects using mesos to copy
>>> >> protobufs around and forces a onerous dependency on anyone who would
>>> >> like to do a pure python binding.
>>> >>
>>> >> - How was this problem solved?
>>> >>
>>> >> The current python package has been split into two separate packages:
>>> >>
>>> >> - mesos.interface (stub implementations and protobufs)
>>> >> - mesos.native (old _mesos module)
>>> >>
>>> >> These are python meta-packages and can be installed as separate
>>> >> pieces. The `mesos.interface` package will be hosted on pypi and can
>>> >> be installed via. easy_install and pip.
>>> >>
>>> >> See https://issues.apache.org/jira/browse/MESOS-857 and
>>> >> https://reviews.apache.org/r/23224/.
>>> >>
>>> >> - Why should I care?
>>> >>
>>> >> These changes are not backwards compatible. With 0.20.0 you will need
>>> >> to change how you use the python bindings. Here's a quick overview:
>>> >>
>>> >> mesos.Scheduler -> mesos.interface.Scheduler
>>> >> mesos.mesos_pb2 -> mesos.interface.mesos_pb2
>>> >> mesos.MesosSchedulerDriver -> mesos.native.MesosSchedulerDriver
>>> >>
>>> >> For more details, you can take a look at the examples in
>>> >> `src/examples/python".
>>> >>
>>
>>
>

Re: Review Request 23414: Unbundling of libev

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review50664
---



3rdparty/libprocess/configure.ac


Just testing the unbundling stuff locally, and came across an issue with 
libev.

I think you missed updating the CPPFLAGS when using prefix installed libev.

Also, shouldn't we be doing a AC_CHECK_LIB for libev?


- Vinod Kone


On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23414/
> ---
> 
> (Updated July 11, 2014, 4:16 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1172
> https://issues.apache.org/jira/browse/MESOS-1172
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against the system installed version of libev.  
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/Makefile.am 87cf1ae 
>   3rdparty/libprocess/configure.ac 27c6ede 
> 
> Diff: https://reviews.apache.org/r/23414/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24719: Added document for network monitoring.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24719/
---

(Updated Aug. 14, 2014, 10:59 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Changes
---

Updated.


Repository: mesos-git


Description
---

See summary


Diffs (updated)
-

  docs/network-monitoring.md PRE-CREATION 

Diff: https://reviews.apache.org/r/24719/diff/


Testing
---

checked the markdown syntax


Thanks,

Jie Yu

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #273

[Apache Jenkins Server]

See 

Review Request 24719: Added document for network monitoring.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24719/
---

Review request for mesos, Ian Downes and Vinod Kone.


Repository: mesos-git


Description
---

See summary


Diffs
-

  docs/network-monitoring.md PRE-CREATION 

Diff: https://reviews.apache.org/r/24719/diff/


Testing
---

checked the markdown syntax


Thanks,

Jie Yu

Re: Review Request 24667: Added a user doc for framework rate limiting.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50659
---

Ship it!



docs/framework-rate-limiting.md


s/implicitly/implicit/



docs/framework-rate-limiting.md


s/temporarily/temporary/


- Vinod Kone


On Aug. 14, 2014, 10:16 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> ---
> 
> (Updated Aug. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
> https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> ---
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24667: Added a user doc for framework rate limiting.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/
---

(Updated Aug. 14, 2014, 3:16 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-1683
https://issues.apache.org/jira/browse/MESOS-1683


Repository: mesos-git


Description
---

See summary.


Diffs (updated)
-

  docs/framework-rate-limiting.md PRE-CREATION 

Diff: https://reviews.apache.org/r/24667/diff/


Testing
---

Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9


Thanks,

Jiang Yan Xu

Re: Review Request 24667: Added a user doc for framework rate limiting.

[Jiang Yan Xu]

> On Aug. 13, 2014, 4:44 p.m., Vinod Kone wrote:
> > docs/framework-rate-limiting.md, line 61
> > 
> >
> > what do you mean by "nature of the frameworks"? do you mean "messages 
> > generated by the frameworks"?

Removed these sentences.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50526
---


On Aug. 14, 2014, 3:16 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> ---
> 
> (Updated Aug. 14, 2014, 3:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
> https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> ---
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50642
---

Ship it!


pls test this on linux too if you haven't already, before committing.

- Vinod Kone


On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 14, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Timothy St. Clair]

> On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote:
> > configure.ac, line 281
> > 
> >
> > so "src" worked on linux but not on osx? how's that possible?
> 
> Timothy St. Clair wrote:
> It shouldn't have worked.  
> It likely flew under the radar due to system installation.

https://reviews.apache.org/r/23453/diff/#


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
---


On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 14, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Timothy St. Clair]

> On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote:
> > configure.ac, line 281
> > 
> >
> > so "src" worked on linux but not on osx? how's that possible?

It shouldn't have worked.  
It likely flew under the radar due to system installation.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
---


On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 14, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
---



configure.ac


so "src" worked on linux but not on osx? how's that possible?


- Vinod Kone


On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> ---
> 
> (Updated Aug. 14, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes on glog check to support mac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac f552e60 
>   configure.ac 30a7e26 
> 
> Diff: https://reviews.apache.org/r/24714/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-glog=/opt/local && make check  
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Build failed in Jenkins: mesos-reviewbot #1344

[Apache Jenkins Server]

See 

Changes:

[tstclair] MESOS-1693: enable build against non-x86 arch

[yujie.jay] Fixed a few compiler warnings in stout.

--
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace 

 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/mesos.git
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/mesos.git
 > git --version
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/mesos.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit}
Checking out Revision b70a863d2214231e306ce6e2932557439a5ecba6 (origin/master)
 > git config core.sparsecheckout
 > git checkout -f b70a863d2214231e306ce6e2932557439a5ecba6
 > git rev-list 9397ba46fda304ae62d73b7943f1652c63715c01
 > git tag -a -f -m Jenkins Build #1344 jenkins-mesos-reviewbot-1344
[mesos-reviewbot] $ /bin/bash -xe /tmp/hudson4606048356608947252.sh
+ export JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64
+ JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64
+ export 
PATH=/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ 
PATH=/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ export M2_HOME=/home/jenkins/tools/maven/latest
+ M2_HOME=/home/jenkins/tools/maven/latest
+ export 
PATH=/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ 
PATH=/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ date
Thu Aug 14 21:06:14 UTC 2014
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile.am NOTICE README.md 
bin bootstrap configure.ac docs ec2 frameworks include m4 mesos.pc.in mpi src 
support
+ git clean -fdx
Removing 3rdparty/leveldb/
+ git reset --hard HEAD
HEAD is now at b70a863 Fixed a few compiler warnings in stout.
+ ./support/mesos-style.py
Checking 503 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/slave/flags.hpp:294:  Lines should be <= 80 characters long  
[whitespace/line_length] [2]
Total errors found: 1
Build step 'Execute shell' marked build as failure

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

[Ben Mahler]

> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote:
> > I don't think that si_uid can give something interesting because it can be 
> > either 0 or UID of receiving process. How about logging si_pid too?

si_uid represents the user id of the _sending_ process, not the receiving 
process. Am I missing something?

We could log the pid as well, hopefully that helps us identify long-lived 
proceses, like init or monit.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50607
---


On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24700/
> ---
> 
> (Updated Aug. 14, 2014, 3:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1567
> https://issues.apache.org/jira/browse/MESOS-1567
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Log the user id when receiving a SIGTERM. This will make debugging more easy.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea 
> 
> Diff: https://reviews.apache.org/r/24700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>

Re: Review Request 24714: fix prefiex glog on mac

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/
---

(Updated Aug. 14, 2014, 9:01 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos-git


Description
---

Fixes on glog check to support mac.


Diffs
-

  3rdparty/libprocess/configure.ac f552e60 
  configure.ac 30a7e26 

Diff: https://reviews.apache.org/r/24714/diff/


Testing
---

./configure --with-glog=/opt/local && make check  


Thanks,

Timothy St. Clair

Re: Review Request 24709: Redirect Docker logs.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24709/#review50622
---

Ship it!


Ship It!

- Jie Yu


On Aug. 14, 2014, 7:48 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24709/
> ---
> 
> (Updated Aug. 14, 2014, 7:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c18023c0143d8ea25886495667752eec8b8eff39 
>   src/tests/docker_containerizer_tests.cpp 
> 30990639c6fa89c49c6b8d5e082fd9b091e08e41 
>   src/tests/environment.cpp a6cc772f060ac7214941dd581ea826d8d086b5b1 
>   src/tests/mesos.cpp 5bd8ba0bb56c9be9d0a3c49c27b6ebc03cfbdf7a 
> 
> Diff: https://reviews.apache.org/r/24709/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24709: Redirect Docker logs.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24709/#review50620
---

Ship it!


Ship It!


src/tests/mesos.cpp


Good catch!


- Timothy Chen


On Aug. 14, 2014, 7:48 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24709/
> ---
> 
> (Updated Aug. 14, 2014, 7:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c18023c0143d8ea25886495667752eec8b8eff39 
>   src/tests/docker_containerizer_tests.cpp 
> 30990639c6fa89c49c6b8d5e082fd9b091e08e41 
>   src/tests/environment.cpp a6cc772f060ac7214941dd581ea826d8d086b5b1 
>   src/tests/mesos.cpp 5bd8ba0bb56c9be9d0a3c49c27b6ebc03cfbdf7a 
> 
> Diff: https://reviews.apache.org/r/24709/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Review Request 24709: Redirect Docker logs.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24709/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  src/slave/containerizer/docker.cpp c18023c0143d8ea25886495667752eec8b8eff39 
  src/tests/docker_containerizer_tests.cpp 
30990639c6fa89c49c6b8d5e082fd9b091e08e41 
  src/tests/environment.cpp a6cc772f060ac7214941dd581ea826d8d086b5b1 
  src/tests/mesos.cpp 5bd8ba0bb56c9be9d0a3c49c27b6ebc03cfbdf7a 

Diff: https://reviews.apache.org/r/24709/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2317

[Apache Jenkins Server]

See 

Re: Build failed in Jenkins: mesos-reviewbot #1343

[Vinod Kone]

On Thu, Aug 14, 2014 at 11:16 AM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> Checking 503 files using filter
> --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
> src/slave/flags.hpp:294:  Lines should be <= 80 characters long
>  [whitespace/line_length] [2]
>


@tnachen: this looks like you. mind fixing it? also, please use the git
hook in (support/hook/pre-commit) if you aren't already.

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

> On Aug. 14, 2014, 4:44 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/include/process/internal.hpp, line 18
> > 
> >
> > Do all the other arch have "nop" instruction?

That I'm aware of, yes.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50590
---


On Aug. 14, 2014, 6:38 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 14, 2014, 6:38 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp c2bee98 
>   configure.ac 321f09d 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

(Updated Aug. 14, 2014, 6:38 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
---

remove the nop s


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs (updated)
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 321f09d 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Build failed in Jenkins: Mesos-Ubuntu-distcheck #272

[Apache Jenkins Server]

See 

Changes:

[tstclair] MESOS-1169: unbundle distribute

[benjamin.hindman] Added explicit DockerInfo within ContainerInfo.

[benjamin.hindman] Used new CommandInfo with Docker::run.

--
[...truncated 4525 lines...]
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/include/mesos/containerizer'
 && rm -f containerizer.pb.h )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/include/mesos'
 && rm -f mesos.hpp mesos.pb.h )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/sbin'
 && rm -f mesos-daemon.sh mesos-start-cluster.sh mesos-start-masters.sh 
mesos-start-slaves.sh mesos-stop-cluster.sh mesos-stop-masters.sh 
mesos-stop-slaves.sh )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/include/mesos/scheduler'
 && rm -f scheduler.pb.h )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/include/mesos'
 && rm -f executor.hpp scheduler.hpp resources.hpp values.hpp mesos.proto )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/libexec/mesos'
 && rm -f mesos-fetcher mesos-executor mesos-containerizer mesos-health-check 
mesos-usage )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/sbin'
 && rm -f mesos-master mesos-slave )
 ( cd 
'/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_inst/include/mesos/scheduler'
 && rm -f scheduler.hpp scheduler.proto )
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src'
Making uninstall in ec2
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/ec2'
make[2]: Nothing to be done for `uninstall'.
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/ec2'
make[1]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
make[1]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
make[1]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
make[1]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
Making install in .
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
make[3]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
make[3]: Nothing to be done for `install-exec-am'.
make[3]: Nothing to be done for `install-data-am'.
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build'
Making install in 3rdparty
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty'
make  install-recursive
make[3]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty'
Making install in libprocess
make[4]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess'
Making install in 3rdparty
make[5]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
make  install-recursive
make[6]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
Making install in stout
make[7]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout'
Making install in .
make[8]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout'
make[9]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout'
make[9]: Nothing to be done for `install-exec-am'.
make[9]: Nothing to be done for `install-data-am'.
make[9]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout'
make[8]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout'
Making install in include
make[8]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/

Re: Review Request 24264: Installed python libraries during make install.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50616
---


Let me know if you want any help on the updated configure checks.


3rdparty/Makefile.am


should wrap with new build mechanics for checking system



configure.ac


We have a .m4 that can check python mods


- Timothy St. Clair


On Aug. 11, 2014, 6:09 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> ---
> 
> (Updated Aug. 11, 2014, 6:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
> 
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 
>   3rdparty/pip-1.5.6.tar.gz PRE-CREATION 
>   3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 
>   3rdparty/wheel-0.24.0.tar.gz PRE-CREATION 
>   configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b 
>   mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 
>   src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 
>   src/examples/python/test-containerizer.in 
> f71828db98a90f455c88d90cb4e3320b7e8c9e9e 
>   src/examples/python/test-executor.in 
> b22e7a7dc0c26f805eb63c7139066ce7dc830636 
>   src/examples/python/test-framework.in 
> 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb 
> 
> Diff: https://reviews.apache.org/r/24264/diff/
> 
> 
> Testing
> ---
> 
> `make distcheck -j6`
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50614
---

Ship it!



3rdparty/libprocess/include/process/internal.hpp


I would sugguest remove the "nop" here (this is a spin lock anyway and nop 
is not available on all other archs).

#if defined(__i386__) || defined(__x86_64__)
  asm volatile ("pause")
#endif



3rdparty/libprocess/src/process.cpp


Ditto.


- Jie Yu


On Aug. 14, 2014, 6:16 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 14, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp c2bee98 
>   configure.ac 321f09d 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Build failed in Jenkins: mesos-reviewbot #1343

[Apache Jenkins Server]

See 

Changes:

[benjamin.hindman] Added explicit DockerInfo within ContainerInfo.

[benjamin.hindman] Used new CommandInfo with Docker::run.

[tstclair] Fix for configure --disable-python

--
Started by an SCM change
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
[URLTrigger] A change within the response URL invocation (log)
Started by an SCM change
Started by an SCM change
Started by an SCM change
Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace 

 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/mesos.git
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/mesos.git
 > git --version
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/mesos.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit}
Checking out Revision 9397ba46fda304ae62d73b7943f1652c63715c01 (origin/master)
 > git config core.sparsecheckout
 > git checkout -f 9397ba46fda304ae62d73b7943f1652c63715c01
 > git rev-list f105ed77212069af2fc67474416f304b8b830a82
 > git tag -a -f -m Jenkins Build #1343 jenkins-mesos-reviewbot-1343
[mesos-reviewbot] $ /bin/bash -xe /tmp/hudson8848112518712733372.sh
+ export JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64
+ JAVA_HOME=/home/jenkins/tools/java/jdk1.6.0_20-64
+ export 
PATH=/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ 
PATH=/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ export M2_HOME=/home/jenkins/tools/maven/latest
+ M2_HOME=/home/jenkins/tools/maven/latest
+ export 
PATH=/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ 
PATH=/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/jdk1.6.0_20-64/bin:/home/jenkins/tools/java/latest1.6/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
+ date
Thu Aug 14 18:16:03 UTC 2014
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am 
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap 
config.guess config.log config.lt config.status config.sub configure 
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh 
m4 mesos-0.20.0 mesos-0.20.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/leveldb/
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/gmock_sources.cc
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
Removing 3rdparty/libprocess/3rdparty/stout/config.log
Removing 3rdparty/libprocess/3rdparty/stout/config.status
Removing 3rdparty/libprocess/3rdparty/stout/configure
Removing 3rdparty/libprocess/3rdparty/stout/include/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/include/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/missing
Removing 3rdparty/libprocess/Makefile
Removing 3rdparty/libprocess/Makefile.in
Removing 3rdparty/libprocess/aclocal.m4
Removing 3rdparty/libprocess/ar-lib
Removing 3rdparty/libprocess/autom4te.cache/
Removing 3rdparty/libprocess/config.guess
Removing 3rdparty/libprocess/config.log
Removing 3rdparty/libprocess/config.lt
Removing 3rdparty/libprocess/config.status
Removing 3rdparty/libprocess/config.sub
Removing 3rdparty/libprocess/configure
Removing 3rdparty/libprocess/depcomp
Removing 3rdparty/libprocess/include/Makefile
Removing 3rdparty/libprocess/include/Makefile.in
Removing 3rdparty/libprocess/libtool
Removing 3rdparty/libprocess/ltmain.sh
Removing 3rdparty/libprocess/m4/libtool.m4
Removing 3rdparty/libprocess/m4/ltoptions.m4
Removing 3rdparty/libprocess/m4/ltsugar.m4
Removing 3rdparty/libprocess/m4/ltversion.m4
Removing 3rdparty/libprocess/m4/lt~obsolete.m4
Removing 3rdparty/libprocess/missing
Removing Makefile
Removing Makefile.in
Removing aclocal.m4
Removing ar-lib
Removing autom4te.cache/
Removing bin/gdb-mesos-local.sh
Removing bin/

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
---

(Updated Aug. 14, 2014, 6:16 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
---

update per review.


Bugs: MESOS-1693
https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
---

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs (updated)
-

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 321f09d 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
---

make check


Thanks,

Timothy St. Clair

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

[Nikita Vetoshkin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50607
---


I don't think that si_uid can give something interesting because it can be 
either 0 or UID of receiving process. How about logging si_pid too?

- Nikita Vetoshkin


On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24700/
> ---
> 
> (Updated Aug. 14, 2014, 3:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1567
> https://issues.apache.org/jira/browse/MESOS-1567
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Log the user id when receiving a SIGTERM. This will make debugging more easy.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea 
> 
> Diff: https://reviews.apache.org/r/24700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

[Tim St Clair]

it was from '--disable-python', should be fixed. 

../configure --disable-java --disable-python --disable-webui

Cheers,
Tim

- Original Message -
> From: "Tim St Clair" 
> To: dev@mesos.apache.org
> Sent: Thursday, August 14, 2014 12:04:25 PM
> Subject: Re: Build failed in Jenkins: 
> Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui
> #2316
> 
> looking.
> 
> - Original Message -
> > From: "Vinod Kone" 
> > To: "dev" 
> > Cc: "Timothy St. Clair" 
> > Sent: Thursday, August 14, 2014 11:50:27 AM
> > Subject: Re: Build failed in Jenkins:
> > Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui
> > #2316
> > 
> > On Thu, Aug 14, 2014 at 9:40 AM, Apache Jenkins Server <
> > jenk...@builds.apache.org> wrote:
> > 
> > > configure: error: conditional "WITH_BUNDLED_DISTRIBUTE" was never
> > > defined.
> > > Usually this means the macro was only invoked conditionally.
> > >
> > 
> > @tim: can you take a look?
> > 
> 
> --
> Cheers,
> Timothy St. Clair
> Red Hat Inc.
> 

-- 
Cheers,
Timothy St. Clair
Red Hat Inc.

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

[Alexandra Sava]

> On Aug. 14, 2014, 5:26 p.m., Ben Mahler wrote:
> > Did you test this manually?

Yes I did. I ran the master and sent it SIGTERM with kill. It worked perfectly 
fine, I don't know why ReviewBot doesn't like it.


> On Aug. 14, 2014, 5:26 p.m., Ben Mahler wrote:
> > src/logging/logging.cpp, line 75
> > 
> >
> > Since we're in a signal handler, we have to avoid using system calls 
> > that are not async signal safe:
> > 
> > http://man7.org/linux/man-pages/man7/signal.7.html
> > 
> > os::user uses sysconf and getpwuid_r, so I think the best we can do 
> > here is just print the si_uid.

ok.


- Alexandra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50600
---


On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24700/
> ---
> 
> (Updated Aug. 14, 2014, 3:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1567
> https://issues.apache.org/jira/browse/MESOS-1567
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Log the user id when receiving a SIGTERM. This will make debugging more easy.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea 
> 
> Diff: https://reviews.apache.org/r/24700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50600
---


Did you test this manually?


src/logging/logging.cpp


Since we're in a signal handler, we have to avoid using system calls that 
are not async signal safe:

http://man7.org/linux/man-pages/man7/signal.7.html

os::user uses sysconf and getpwuid_r, so I think the best we can do here is 
just print the si_uid.


- Ben Mahler


On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24700/
> ---
> 
> (Updated Aug. 14, 2014, 3:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1567
> https://issues.apache.org/jira/browse/MESOS-1567
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Log the user id when receiving a SIGTERM. This will make debugging more easy.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea 
> 
> Diff: https://reviews.apache.org/r/24700/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>

Build failed in Jenkins: mesos-reviewbot #1342

[Apache Jenkins Server]

See 

--
[...truncated 4514 lines...]
 /usr/bin/install -c -m 644  
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/execenv.hpp
 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/exists.hpp
 ../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp
 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp
 ../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp
 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp
 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp
 
../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp
 
'/tmp/am-dc-23700//x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_inst/include/stout/os'
make[9]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout/include'
make[8]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout/include'
make[7]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout'
make[7]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
make[8]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
make[8]: Nothing to be done for `install-exec-am'.
make[8]: Nothing to be done for `install-data-am'.
make[8]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
make[7]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
make[6]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty'
Making install in .
make[5]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess'
make[6]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess'
make[6]: Nothing to be done for `install-exec-am'.
make[6]: Nothing to be done for `install-data-am'.
make[6]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess'
make[5]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess'
Making install in include
make[5]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/include'
make[6]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_build/3rdparty/libprocess/include'
make[6]: Nothing to be done for `install-exec-am'.
test -z 
"/x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_inst/include"
 || /bin/mkdir -p 
"/tmp/am-dc-23700//x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_inst/include"
/bin/mkdir -p 
'/tmp/am-dc-23700//x1/jenkins/jenkins-slave/workspace/mesos-reviewbot/mesos-0.20.0/_inst/include/process'
 /usr/bin/install -c -m 644  
../../../../3rdparty/libprocess/include/process/async.hpp 
../../../../3rdparty/libprocess/include/process/check.hpp 
../../../../3rdparty/libprocess/include/process/clock.hpp 
../../../../3rdparty/libprocess/include/process/collect.hpp 
../../../../3rdparty/libprocess/include/process/defer.hpp 
../../../../3rdparty/libprocess/include/process/deferred.hpp 
../../../../3rdparty/libprocess/include/process/delay.hpp 
../../../../3rdparty/libprocess/include/process/dispatch.hpp 
../../../../3rdparty/libprocess/include/process/event.hpp 
../../../../3rdparty/libprocess/include/process/executor.hpp 
../../../../3rdparty/libprocess/include/process/filter.hpp 
../../../../3rdparty/libprocess/include/process/future.hpp 
../../../../3rdparty/libprocess/include/process/gc.hpp 
../../../..

Re: Review Request 24673: Used new CommandInfo with Docker::run.

[Benjamin Hindman]

> On Aug. 13, 2014, 10:22 p.m., Timothy Chen wrote:
> > Ship It!
> 
> Timothy Chen wrote:
> Ben you will need to update this rb with the new commandInfo argv -> 
> arguments renamed.

Yup, done, thanks.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50520
---


On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> ---
> 
> (Updated Aug. 13, 2014, 9:53 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
> 
> Diff: https://reviews.apache.org/r/24673/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: RB 2.0.5

[Benjamin Mahler]

Thanks Jake!


On Wed, Aug 13, 2014 at 9:07 PM, Vinod Kone  wrote:

> Thanks to Jake Farrell, we now have an upgraded RB server (1.6.x to 2.0.x)!
>
> Apart from the UI flourishes, the thing I'm excited about is that this
> should fix our long standing problem of review updates obliterating
> "depends on" field!
>
> Thanks again Jake for the quick turn around. Really appreciate it.
>

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

[Tim St Clair]

looking.

- Original Message -
> From: "Vinod Kone" 
> To: "dev" 
> Cc: "Timothy St. Clair" 
> Sent: Thursday, August 14, 2014 11:50:27 AM
> Subject: Re: Build failed in Jenkins: 
> Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui
> #2316
> 
> On Thu, Aug 14, 2014 at 9:40 AM, Apache Jenkins Server <
> jenk...@builds.apache.org> wrote:
> 
> > configure: error: conditional "WITH_BUNDLED_DISTRIBUTE" was never defined.
> > Usually this means the macro was only invoked conditionally.
> >
> 
> @tim: can you take a look?
> 

-- 
Cheers,
Timothy St. Clair
Red Hat Inc.

Re: Review Request 24673: Used new CommandInfo with Docker::run.

[Benjamin Hindman]

> On Aug. 13, 2014, 10:20 p.m., Jie Yu wrote:
> > src/docker/docker.cpp, line 266
> > 
> >
> > I would probably rename it to argv as subprocess's signature uses argv.

Great idea! Thanks Jie!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50519
---


On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> ---
> 
> (Updated Aug. 13, 2014, 9:53 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
> 
> Diff: https://reviews.apache.org/r/24673/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

[Vinod Kone]

On Thu, Aug 14, 2014 at 9:40 AM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> configure: error: conditional "WITH_BUNDLED_DISTRIBUTE" was never defined.
> Usually this means the macro was only invoked conditionally.
>

@tim: can you take a look?

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50590
---



3rdparty/libprocess/include/process/internal.hpp


for #ifdef blocks, that's how we align:

{
  while (!...) {
#if defined(...) || defined(...)
asm volatile ...
#else
...
#endif
  }
}



3rdparty/libprocess/include/process/internal.hpp


Do all the other arch have "nop" instruction?



3rdparty/libprocess/src/process.cpp


Ditto.


- Jie Yu


On Aug. 13, 2014, 7:30 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 13, 2014, 7:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

[Apache Jenkins Server]

See 


Changes:

[tstclair] MESOS-1169: unbundle distribute

--
[...truncated 289 lines...]
3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled
3rdparty/Makefile.am:145: warning: source file 
'$(STOUT)/tests/strings_tests.cpp' is in a subdirectory,
3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled
3rdparty/Makefile.am:145: warning: source file 
'$(STOUT)/tests/subcommand_tests.cpp' is in a subdirectory,
3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled
3rdparty/Makefile.am:145: warning: source file 
'$(STOUT)/tests/thread_tests.cpp' is in a subdirectory,
3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled
3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/uuid_tests.cpp' 
is in a subdirectory,
3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled
3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/proc_tests.cpp' 
is in a subdirectory,
3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled
3rdparty/Makefile.am:179: warning: source file 
'$(STOUT)/tests/os/setns_tests.cpp' is in a subdirectory,
3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled
3rdparty/Makefile.am: installing './depcomp'
Makefile.am:32: warning: source file 'src/http.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/latch.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/metrics/metrics.cpp' is in a 
subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/process.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/reap.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/subprocess.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:32: warning: source file 'src/timeseries.cpp' is in a subdirectory,
Makefile.am:32: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/decoder_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/encoder_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/http_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/io_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/main.cpp' is in a subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/mutex_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/metrics_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/owned_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/process_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/queue_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/reap_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/sequence_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/shared_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/statistics_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/subprocess_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/system_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/timeseries_tests.cpp' is in a 
subdirectory,
Makefile.am:90: but option 'subdir-objects' is disabled
Makefile.am:90: warning: source file 'src/tests/time_tests.cpp' is in a 
subdirec

Review Request 24700: Log the user id when receiving a SIGTERM.

[Alexandra Sava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-1567
https://issues.apache.org/jira/browse/MESOS-1567


Repository: mesos-git


Description
---

Log the user id when receiving a SIGTERM. This will make debugging more easy.


Diffs
-

  src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea 

Diff: https://reviews.apache.org/r/24700/diff/


Testing
---


Thanks,

Alexandra Sava

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/
---

(Updated Aug. 14, 2014, 2:45 p.m.)


Review request for mesos, Adam B, Jie Yu, and Vinod Kone.


Changes
---

rebase for clean apply


Bugs: MESOS-1169
https://issues.apache.org/jira/browse/MESOS-1169


Repository: mesos-git


Description
---

Enabling unbundling for distribute python utils.


Diffs (updated)
-

  3rdparty/Makefile.am 70b45fe 
  configure.ac e2d8371 
  mpi/mpiexec-mesos.in 9aa0702 
  src/examples/python/test-containerizer.in 3238ccc 
  src/examples/python/test-executor.in 072fd7d 
  src/examples/python/test-framework.in ee90e55 

Diff: https://reviews.apache.org/r/24555/diff/


Testing
---

./configure && make check 
./configure --disable-bundled  && make check

For prefixed installs require updated PYTHON_PATH.


Thanks,

Timothy St. Clair

Re: Review Request 24628: MESOS-1171: unbundle gmock

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/
---

(Updated Aug. 14, 2014, 1:48 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

rebase patch for clean apply. 


Bugs: MESOS-1171
https://issues.apache.org/jira/browse/MESOS-1171


Repository: mesos-git


Description
---

Enable support to build against unbundled versions of gmock.  


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am ea46d6a 
  3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/libprocess/configure.ac d6695ce 
  configure.ac 5653775 

Diff: https://reviews.apache.org/r/24628/diff/


Testing
---

configure && make check
configure --disable-bundled && make check
configure --with-gmock=/opt/gmock && make check


Thanks,

Timothy St. Clair

Re: Review Request 24687: Added support for disabling glog initialization.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24687/#review50578
---


Patch looks great!

Reviews applied: [24687]

All tests passed.

- Mesos ReviewBot


On Aug. 14, 2014, 1:19 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24687/
> ---
> 
> (Updated Aug. 14, 2014, 1:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1629
> https://issues.apache.org/jira/browse/MESOS-1629
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> C++ frameworks can now explicitly disable glog initialization if they choose 
> to do so.
> 
> By default now the executor driver also enables glog initialization. It 
> didn't use to before, but I think that's a bug.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp ed2330f1677b9aa56ef43bae5dec0b3acfca0e1c 
>   include/mesos/scheduler.hpp 802727270ae8afb2d772bdb0170a2378dd611ee4 
>   src/exec/exec.cpp 15d41eb303c81a1ae958adc76a105c11d7ef72ef 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java 
> 910548c0b5137294f67b8a21b8c77fc2d8dbd5e3 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> afdbbbc0e6deddcf620517b7ecc4ab7947ae91b6 
>   src/logging/flags.hpp d30a7069c07af5b98a7f26e4158e839cbf424506 
>   src/sched/sched.cpp cbc52916c551b324aab7c5ddb51b2f7679cae88b 
>   src/scheduler/scheduler.cpp 498d6aa421c96768d4be0ccff38d148e992949fc 
> 
> Diff: https://reviews.apache.org/r/24687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> # ./src/long-lived-framework 127.0.0.1:5050
> I0814 01:13:32.889717 56878 sched.cpp:139] Version: 0.20.0
> I0814 01:13:32.896556 56975 sched.cpp:235] New master detected at 
> master@127.0.0.1:5050
> I0814 01:13:32.896836 56975 sched.cpp:243] No credentials provided. 
> Attempting to register without authentication
> 
> # MESOS_LOGGING_INITIALIZE=0 ./src/long-lived-framework 127.0.0.1:5050
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> I0814 01:14:18.517209 60286 sched.cpp:139] Version: 0.20.0
> I0814 01:14:18.524113 60322 sched.cpp:235] New master detected at 
> master@127.0.0.1:5050
> I0814 01:14:18.524395 60322 sched.cpp:243] No credentials provided. 
> Attempting to register without authentication
> 
> 
> # MESOS_LOGGING_INITIALIZE=1 ./src/long-lived-framework 127.0.0.1:5050
> I0814 01:14:25.621443 60969 sched.cpp:139] Version: 0.20.0
> I0814 01:14:25.628525 60986 sched.cpp:235] New master detected at 
> master@127.0.0.1:5050
> I0814 01:14:25.628746 60986 sched.cpp:243] No credentials provided. 
> Attempting to register without authentication
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 24677: Add Docker::pull

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24677/#review50568
---


Bad patch!

Reviews applied: [24677]

Failed command: git apply --index 24677.patch

Error:
 error: patch failed: src/docker/docker.hpp:82
error: src/docker/docker.hpp: patch does not apply
error: patch failed: src/docker/docker.cpp:209
error: src/docker/docker.cpp: patch does not apply

- Mesos ReviewBot


On Aug. 13, 2014, 11:32 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24677/
> ---
> 
> (Updated Aug. 13, 2014, 11:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added Docker pull(). BenH already has a patch and I'm taking his and adding 
> inspect call into pull.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 98b2d60 
>   src/docker/docker.cpp 1cba381 
> 
> Diff: https://reviews.apache.org/r/24677/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2314

[Apache Jenkins Server]

See