The mesos.interface python egg
Hey guys, Has someone been changing things relating to the new *mesos.interface* python egg on pypi? I don't seem to be able to install it anymore.. which is strange as it's listed as available on the pypi site. Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 Cheers, Tom.
Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/ --- (Updated Sept. 4, 2014, 9:28 a.m.) Review request for mesos. Changes --- No changes - just trigger build Bugs: MESOS-1625 https://issues.apache.org/jira/browse/MESOS-1625 Repository: mesos-git Description --- As mentioned in MESOS-1625 current HTTP Chunked Encoding implementation can break clients (e.g. Tornado). As I see no need in Chunked-Encoding because we know content size beforehand - I propose to use Content-Length. Diffs (updated) - 3rdparty/libprocess/src/encoder.hpp 9c5aa81 Diff: https://reviews.apache.org/r/24984/diff/ Testing --- `make check` and manual testing with golang language native binding Thanks, Nikita Vetoshkin
Review Request 25334: Fixed python egg proto imports.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- Review request for mesos, Benjamin Hindman, Tom Arnfeld, Thomas Rampelberg, and Vinod Kone. Bugs: MESOS-1750 https://issues.apache.org/jira/browse/MESOS-1750 Repository: mesos-git Description --- Fixes defective import introduced by the flat folder hierachy of the mesos.interface Python egg generation. Diffs - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff
Re: The mesos.interface python egg
Has someone been changing things relating to the new *mesos.interface* python egg on pypi? I don't seem to be able to install it anymore.. which is strange as it's listed as available on the pypi site. Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 I am getting the same results, the log-file shows: /usr/local/bin/pip run on Thu Sep 4 13:51:38 2014 Downloading/unpacking mesos.interface Getting page https://pypi.python.org/simple/mesos.interface/ URLs to search for versions for mesos.interface: * https://pypi.python.org/simple/mesos.interface/ Analyzing links from page https://pypi.python.org/simple/mesos.interface/ Skipping link https://pypi.python.org/packages/2.7/m/mesos.interface/mesos.interface-0.20.0-py2.7.egg#md5=21382705ad44629dc8e00cb3a7ba0407 (from https://pypi.python.org/simple/mesos.interface/); unknown archive format: .egg Could not find any downloads that satisfy the requirement mesos.interface No distributions at all found for mesos.interface However, manually downloading that egg via the pypi website https://pypi.python.org/pypi/mesos.interface/0.20.0 works fine. As mentioned on IRC, people seemed to expect a source distribution instead of an egg - is that the problem for pip as well?
Re: The mesos.interface python egg
I'm not sure what happened, but I got it fixed up this morning. On Thu, Sep 4, 2014 at 4:55 AM, Till Toenshoff toensh...@me.com wrote: Has someone been changing things relating to the new *mesos.interface* python egg on pypi? I don't seem to be able to install it anymore.. which is strange as it's listed as available on the pypi site. Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 I am getting the same results, the log-file shows: /usr/local/bin/pip run on Thu Sep 4 13:51:38 2014 Downloading/unpacking mesos.interface Getting page https://pypi.python.org/simple/mesos.interface/ URLs to search for versions for mesos.interface: * https://pypi.python.org/simple/mesos.interface/ Analyzing links from page https://pypi.python.org/simple/mesos.interface/ Skipping link https://pypi.python.org/packages/2.7/m/mesos.interface/mesos.interface-0.20.0-py2.7.egg#md5=21382705ad44629dc8e00cb3a7ba0407 (from https://pypi.python.org/simple/mesos.interface/); unknown archive format: .egg Could not find any downloads that satisfy the requirement mesos.interface No distributions at all found for mesos.interface However, manually downloading that egg via the pypi website https://pypi.python.org/pypi/mesos.interface/0.20.0 works fine. As mentioned on IRC, people seemed to expect a source distribution instead of an egg - is that the problem for pip as well?
Review Request 25344: Improved the error message when destroying a container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 src/slave/containerizer/mesos/containerizer.cpp 5116b14b312b6d605245486f33b74d2547287876 Diff: https://reviews.apache.org/r/25344/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 25334: Fixed python egg proto imports.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52316 --- Ship it! :thumbsup: Is there any reason we're not running `test-containerizer` as part of the normal unit tests? I'd hate for something like this to happen accidentally again. - Thomas Rampelberg On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- (Updated Sept. 4, 2014, 11:46 a.m.) Review request for mesos, Benjamin Hindman, Tom Arnfeld, Thomas Rampelberg, and Vinod Kone. Bugs: MESOS-1750 https://issues.apache.org/jira/browse/MESOS-1750 Repository: mesos-git Description --- Fixes defective import introduced by the flat folder hierachy of the mesos.interface Python egg generation. Diffs - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff
Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52317 --- 3rdparty/libprocess/src/encoder.hpp https://reviews.apache.org/r/24984/#comment91081 i'm not even sure how this was working given that Transfer-Encoding is an HTTP/1.1 feature. - Dominic Hamon On Sept. 4, 2014, 2:28 a.m., Nikita Vetoshkin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/ --- (Updated Sept. 4, 2014, 2:28 a.m.) Review request for mesos. Bugs: MESOS-1625 https://issues.apache.org/jira/browse/MESOS-1625 Repository: mesos-git Description --- As mentioned in MESOS-1625 current HTTP Chunked Encoding implementation can break clients (e.g. Tornado). As I see no need in Chunked-Encoding because we know content size beforehand - I propose to use Content-Length. Diffs - 3rdparty/libprocess/src/encoder.hpp 9c5aa81 Diff: https://reviews.apache.org/r/24984/diff/ Testing --- `make check` and manual testing with golang language native binding Thanks, Nikita Vetoshkin
Re: Review Request 25334: Fixed python egg proto imports.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52331 --- src/Makefile.am https://reviews.apache.org/r/25334/#comment91099 Can you add a comment on why you are doing a 'sed' here? - Vinod Kone On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- (Updated Sept. 4, 2014, 11:46 a.m.) Review request for mesos, Benjamin Hindman, Tom Arnfeld, Thomas Rampelberg, and Vinod Kone. Bugs: MESOS-1750 https://issues.apache.org/jira/browse/MESOS-1750 Repository: mesos-git Description --- Fixes defective import introduced by the flat folder hierachy of the mesos.interface Python egg generation. Diffs - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff
Re: Review Request 25205: Fix command executor path check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/#review52333 --- Bad patch! Reviews applied: [25205] Failed command: git apply --index 25205.patch Error: error: patch failed: src/slave/slave.hpp:522 error: src/slave/slave.hpp: patch does not apply - Mesos ReviewBot On Sept. 3, 2014, 8:30 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/ --- (Updated Sept. 3, 2014, 8:30 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. Repository: mesos-git Description --- Fix command executor path check. Currently we expand the symlinks when we assign the command executor path when we write the ExecutorInfo's command value, but we don't do the same when we perform a string match later to check if the Executor is a commandExecutor. This patches fixes so it does both on both place. Diffs - src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25205/diff/ Testing --- make check Thanks, Timothy Chen
Jenkins build is back to normal : mesos-reviewbot #1466
See https://builds.apache.org/job/mesos-reviewbot/1466/
Re: Review Request 25270: Enable bridge networking and port mapping for Docker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52347 --- src/docker/docker.cpp https://reviews.apache.org/r/25270/#comment91110 Don't you want --host= and --bridge=br(x), in the case where folks configure bridges for vlans? - Timothy St. Clair On Sept. 2, 2014, 8:47 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 2, 2014, 8:47 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Enable bridge networking and port mapping for Docker Diffs - include/mesos/mesos.proto dea51f9 src/docker/docker.cpp af51ac9 src/slave/slave.cpp 5c76dd1 src/tests/docker_containerizer_tests.cpp 8654f9c Diff: https://reviews.apache.org/r/25270/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25270: Enable bridge networking and port mapping for Docker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 8:24 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. Repository: mesos-git Description --- Enable bridge networking and port mapping for Docker Diffs - include/mesos/mesos.proto dea51f9 src/docker/docker.cpp af51ac9 src/slave/slave.cpp 5c76dd1 src/tests/docker_containerizer_tests.cpp 8654f9c Diff: https://reviews.apache.org/r/25270/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25250: Mark running tasks killed during framework shutdown.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review52351 --- Patch looks great! Reviews applied: [25250] All tests passed. - Mesos ReviewBot On Sept. 3, 2014, 9:56 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 3, 2014, 9:56 p.m.) Review request for mesos, Benjamin Hindman and Till Toenshoff. Bugs: MESOS-1736 https://issues.apache.org/jira/browse/MESOS-1736 Repository: mesos-git Description --- When a framework is shut down e.g. by calling driver.stop() from the scheduler, running tasks are marked KILLED before migrating them to completed. WIP: bad patch, not reviewable. Diffs - src/master/master.cpp 2508b38e86b8399886bffcbaca8ec11c731363d8 src/tests/master_tests.cpp eaa1675aa3c598ee9b59334852eafcce65687f18 Diff: https://reviews.apache.org/r/25250/diff/ Testing --- make check Thanks, Alexander Rukletsov
Review Request 25355: Minor update to include package config file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS-1764 https://issues.apache.org/jira/browse/MESOS-1764 Repository: mesos-git Description --- Minor update to include package config file Diffs - Makefile.am e4ffa35 Diff: https://reviews.apache.org/r/25355/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 22066: Added timeout to rescind unused offers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Sept. 4, 2014, 5:09 p.m.) Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy Chen. Changes --- More updates to reflect Ben's suggestions. Bugs: mesos-186 https://issues.apache.org/jira/browse/mesos-186 Repository: mesos-git Description --- A timer is associated with each newly created offer. The offer is rescinded on timeout. The timer is disarmed on a launchTask or decline. This is continuation of Tim's patch: https://reviews.apache.org/r/22796/. Revision two represents the latest patch from Tim. I have tried to address the comments/concerns from that request into the third revision. Diffs (updated) - src/master/flags.hpp 5e9ecb5 src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/tests/master_tests.cpp eaa1675 Diff: https://reviews.apache.org/r/22066/diff/ Testing --- Added one more test after Tim's patch to test offer is not rescinded once it has been declined. make check Thanks, Kapil Arya
Re: Review Request 25355: Minor update to include package config file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/#review52358 --- Makefile.am https://reviews.apache.org/r/25355/#comment91125 i'm likely missing context. what is this for? - Vinod Kone On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/ --- (Updated Sept. 4, 2014, 9 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS-1764 https://issues.apache.org/jira/browse/MESOS-1764 Repository: mesos-git Description --- Minor update to include package config file Diffs - Makefile.am e4ffa35 Diff: https://reviews.apache.org/r/25355/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 25270: Enable bridge networking and port mapping for Docker
On Sept. 4, 2014, 8:23 p.m., Timothy St. Clair wrote: src/docker/docker.cpp, line 324 https://reviews.apache.org/r/25270/diff/1/?file=674166#file674166line324 Don't you want --host= and --bridge=br(x), in the case where folks configure bridges for vlans? Hi Tim, the custom bridge configuration is an option for the docker daemon, and not part of the per docker run configuration. So users want to configure bridges will set it on the docker daemon and docker cli will automatically pick it up. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52347 --- On Sept. 4, 2014, 8:34 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 8:34 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. Bugs: MESOS-1621 https://issues.apache.org/jira/browse/MESOS-1621 Repository: mesos-git Description --- Enable bridge networking and port mapping for Docker Diffs - include/mesos/mesos.proto dea51f9 src/docker/docker.cpp af51ac9 src/slave/slave.cpp 5c76dd1 src/tests/docker_containerizer_tests.cpp 8654f9c Diff: https://reviews.apache.org/r/25270/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25270: Enable bridge network in Mesos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 10:04 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. Summary (updated) - Enable bridge network in Mesos Bugs: MESOS-1621 https://issues.apache.org/jira/browse/MESOS-1621 Repository: mesos-git Description (updated) --- Review: https://reviews.apache.org/r/25270 Diffs (updated) - include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e src/slave/slave.cpp bd31831022c97e68b0293d66e1eb5f28ac508525 src/tests/docker_containerizer_tests.cpp 8654f9c787bd207f6a7b821651e0c083bea9dc8a Diff: https://reviews.apache.org/r/25270/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 10:49 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Fixing cosmetics. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 include/mesos/resources.hpp 0e37170 src/Makefile.am 5526189 src/common/resources.cpp 29fc765 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 src/tests/isolator_tests.cpp c38f876 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 11:01 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Updating testing. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 include/mesos/resources.hpp 0e37170 src/Makefile.am 5526189 src/common/resources.cpp 29fc765 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 src/tests/isolator_tests.cpp c38f876 Diff: https://reviews.apache.org/r/25105/diff/ Testing (updated) --- This now implements isolation at the read / write level, using both iops or kbps. Tests for both are also included. Thanks, Patrick Reilly
Re: Review Request 25344: Improved the error message when destroying a container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:12 p.m.) Review request for mesos and Ben Mahler. Changes --- BenM's sugguestion. Repository: mesos-git Description --- See summary. Diffs (updated) - src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 src/slave/containerizer/mesos/containerizer.cpp 5116b14b312b6d605245486f33b74d2547287876 Diff: https://reviews.apache.org/r/25344/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 25344: Improved the error message when destroying a container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/#review52378 --- Ship it! Thanks! src/linux/cgroups.cpp https://reviews.apache.org/r/25344/#comment91150 Maybe we shouldn't ignore the transition of the future here, instead we can map: ready - ready failed - failed discarded - failed(Timed out in ...); I think timedout is two words :) src/linux/cgroups.cpp https://reviews.apache.org/r/25344/#comment91151 Could you use an Owned to avoid the need for deleting the promise explicitly? - Ben Mahler On Sept. 4, 2014, 11:12 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:12 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 src/slave/containerizer/mesos/containerizer.cpp 5116b14b312b6d605245486f33b74d2547287876 Diff: https://reviews.apache.org/r/25344/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 25344: Improved the error message when destroying a container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:42 p.m.) Review request for mesos and Ben Mahler. Changes --- BenM's suggestion again. Repository: mesos-git Description --- See summary. Diffs (updated) - src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/slave/containerizer/isolators/cgroups/perf_event.cpp 6f65b722c5b22a71a7c334c2b63db1584cb9fe29 src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 src/slave/containerizer/mesos/containerizer.cpp 5116b14b312b6d605245486f33b74d2547287876 Diff: https://reviews.apache.org/r/25344/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 25344: Improved the error message when destroying a container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:47 p.m.) Review request for mesos and Ben Mahler. Changes --- Review comments. Repository: mesos-git Description --- See summary. Diffs (updated) - src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/slave/containerizer/isolators/cgroups/perf_event.cpp 6f65b722c5b22a71a7c334c2b63db1584cb9fe29 src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 src/slave/containerizer/mesos/containerizer.cpp 5116b14b312b6d605245486f33b74d2547287876 Diff: https://reviews.apache.org/r/25344/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 25344: Improved the error message when destroying a container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/#review52380 --- Ship it! src/linux/cgroups.cpp https://reviews.apache.org/r/25344/#comment91154 const Owned ? src/linux/cgroups.cpp https://reviews.apache.org/r/25344/#comment91155 s/Nothing()/future.get()/ ? src/linux/cgroups.cpp https://reviews.apache.org/r/25344/#comment91157 s/in/after/ ? src/linux/cgroups.cpp https://reviews.apache.org/r/25344/#comment91158 s/_future/future_/ akin to prime notation - Ben Mahler On Sept. 4, 2014, 11:47 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:47 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/slave/containerizer/isolators/cgroups/perf_event.cpp 6f65b722c5b22a71a7c334c2b63db1584cb9fe29 src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 src/slave/containerizer/mesos/containerizer.cpp 5116b14b312b6d605245486f33b74d2547287876 Diff: https://reviews.apache.org/r/25344/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52372 --- src/linux/cgroups.cpp https://reviews.apache.org/r/25105/#comment91144 Single line comments. src/linux/cgroups.cpp https://reviews.apache.org/r/25105/#comment91145 two spaces between methods. And all other places. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment91146 previous line src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment91152 Format log. LOG(INFO) . ..; src/tests/isolator_tests.cpp https://reviews.apache.org/r/25105/#comment91159 I'm not familiar with boost concept checks, but are you using it in your tests? src/tests/isolator_tests.cpp https://reviews.apache.org/r/25105/#comment91153 pad with 4 spaces. src/tests/isolator_tests.cpp https://reviews.apache.org/r/25105/#comment91156 previous line src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91137 Use single line comments, and this already exceeds 70 char. src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91142 two spaces in between methods. src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91141 formatting? src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91140 two spaces between methods. src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91139 two spaces between methods. src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91138 formatting. src/common/resources.cpp https://reviews.apache.org/r/25105/#comment91143 two spaces in between methods. - Timothy Chen On Sept. 4, 2014, 11:01 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 11:01 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 include/mesos/resources.hpp 0e37170 src/Makefile.am 5526189 src/common/resources.cpp 29fc765 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 src/tests/isolator_tests.cpp c38f876 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- This now implements isolation at the read / write level, using both iops or kbps. Tests for both are also included. Thanks, Patrick Reilly
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2380
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2380/changes Changes: [yujie.jay] Improved the error message when destroying a container. -- [...truncated 260 lines...] 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/strings_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/subcommand_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/thread_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/uuid_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/proc_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/os/setns_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am: installing './depcomp' Makefile.am:32: warning: source file 'src/http.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/latch.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/metrics/metrics.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/process.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/reap.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/subprocess.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/timeseries.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/decoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/encoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/http_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/io_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/main.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/mutex_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/metrics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/owned_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/process_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/queue_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/reap_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/sequence_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/shared_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/statistics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/subprocess_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/system_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/timeseries_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/time_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled
Review Request 25369: Add Dockerfile for building Mesos from source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25369/ --- Review request for mesos and Timothy Chen. Repository: mesos Description --- Add Dockerfile for building Mesos from source Diffs - Dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/25369/diff/ Testing --- Create snapshot builds with: docker build -t mesos/mesos:git-`git rev-parse --short HEAD` . Run master/slave with: docker run mesos/mesos:git-`git rev-parse --short HEAD` mesos-master [options] docker run mesos/mesos:git-`git rev-parse --short HEAD` mesos-slave [options] Some Docker layer gymanstics are performed during the final layer to remove build dependencies and reduce image size from ~5GB to 2GB. Thanks, Gabriel Monroy
Jenkins build is back to normal : Mesos-Ubuntu-distcheck #317
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/317/changes
Re: Review Request 25355: Minor update to include package config file
On Sept. 4, 2014, 9:19 p.m., Vinod Kone wrote: Makefile.am, lines 27-28 https://reviews.apache.org/r/25355/diff/1/?file=679007#file679007line27 i'm likely missing context. what is this for? A while back we added a package config file, or .pc file. This mod installs it in the default location. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/#review52358 --- On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/ --- (Updated Sept. 4, 2014, 9 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS-1764 https://issues.apache.org/jira/browse/MESOS-1764 Repository: mesos-git Description --- Minor update to include package config file Diffs - Makefile.am e4ffa35 Diff: https://reviews.apache.org/r/25355/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2380
Alright, I'm going to remove the H11 slave from the label expression to cut the noise. Filed a ticket for getting libcurl installed: https://issues.apache.org/jira/browse/INFRA-8308 On Thu, Sep 4, 2014 at 4:59 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2380/changes Changes: [yujie.jay] Improved the error message when destroying a container. -- [...truncated 260 lines...] 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/strings_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/subcommand_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/thread_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/uuid_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/proc_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/os/setns_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am: installing './depcomp' Makefile.am:32: warning: source file 'src/http.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/latch.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/metrics/metrics.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/process.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/reap.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/subprocess.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/timeseries.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/decoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/encoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/http_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/io_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/main.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/mutex_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/metrics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/owned_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/process_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/queue_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/reap_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/sequence_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/shared_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/statistics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/subprocess_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/system_tests.cpp' is in a subdirectory,
Re: Review Request 25355: Minor update to include package config file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/#review52398 --- Ship it! Ship It! - Vinod Kone On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/ --- (Updated Sept. 4, 2014, 9 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS-1764 https://issues.apache.org/jira/browse/MESOS-1764 Repository: mesos-git Description --- Minor update to include package config file Diffs - Makefile.am e4ffa35 Diff: https://reviews.apache.org/r/25355/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52400 --- Patch looks great! Reviews applied: [24984] All tests passed. - Mesos ReviewBot On Sept. 4, 2014, 9:28 a.m., Nikita Vetoshkin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/ --- (Updated Sept. 4, 2014, 9:28 a.m.) Review request for mesos. Bugs: MESOS-1625 https://issues.apache.org/jira/browse/MESOS-1625 Repository: mesos-git Description --- As mentioned in MESOS-1625 current HTTP Chunked Encoding implementation can break clients (e.g. Tornado). As I see no need in Chunked-Encoding because we know content size beforehand - I propose to use Content-Length. Diffs - 3rdparty/libprocess/src/encoder.hpp 9c5aa81 Diff: https://reviews.apache.org/r/24984/diff/ Testing --- `make check` and manual testing with golang language native binding Thanks, Nikita Vetoshkin
Review Request 25373: Added a test for sending pending tasks during re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715 https://issues.apache.org/jira/browse/MESOS-1715 Repository: mesos-git Description --- This uses a MockGarbageCollector and a detector to force the slave to re-register with a pending task. Diffs - src/tests/fault_tolerance_tests.cpp b0e74b94db8a68cd676569d42b2ccd120f12b9d3 Diff: https://reviews.apache.org/r/25373/diff/ Testing --- make check Thanks, Ben Mahler
Review Request 25371: Send pending tasks during re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25371/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715 https://issues.apache.org/jira/browse/MESOS-1715 Repository: mesos-git Description --- Not sending the pending tasks leads to the master considering them lost when it reconciles its state! Diffs - src/common/protobuf_utils.hpp 809e4b2b702934c460c7e02439349f6148c470e8 src/common/protobuf_utils.cpp 1714ef75309624bca17baeefa9839dfe78d589bd src/slave/slave.hpp 062e961a0ff2cfa88057a0d01114375cb86ffd24 src/slave/slave.cpp bd31831022c97e68b0293d66e1eb5f28ac508525 src/tests/common/http_tests.cpp 5fa51bf1c100805ebd997c20ce020d4ca11664be src/tests/slave_recovery_tests.cpp 357edfc134e825036aeea58ca0b66bb48f3d08e9 Diff: https://reviews.apache.org/r/25371/diff/ Testing --- Test added in the review chain. Thanks, Ben Mahler
Review Request 25372: Made the GarbageCollector injectable into the Slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715 https://issues.apache.org/jira/browse/MESOS-1715 Repository: mesos-git Description --- Need to inject the GarbageCollector for testing MESOS-1715. I also cleaned up the testing cluster code. Diffs - src/local/local.cpp 9db4dd18c1aefca24cfa66d762994ac59ed2ed3d src/slave/gc.hpp 8f9398b1d8bf4b2615e632accade4cfa79d7b62d src/slave/main.cpp 319316f8f95cddbfa4b5d0656f4377e3b8d6ade1 src/slave/slave.hpp 062e961a0ff2cfa88057a0d01114375cb86ffd24 src/slave/slave.cpp bd31831022c97e68b0293d66e1eb5f28ac508525 src/tests/cluster.hpp d857fc604f5b47cf9805b37c13051093f486ba31 src/tests/fault_tolerance_tests.cpp b0e74b94db8a68cd676569d42b2ccd120f12b9d3 src/tests/master_authorization_tests.cpp b9aa7bf4f53e414d84f8cf4e020a645db8e5d855 src/tests/mesos.hpp b31c347299707cba242619c3dc6915f295bee9cb src/tests/mesos.cpp 0f759a70b457561bc878fa62b819142a064d5ea4 src/tests/reconciliation_tests.cpp 8c66659982ceff37572a89628221c40be1c59406 Diff: https://reviews.apache.org/r/25372/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 25334: Fixed python egg proto imports.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52413 --- Patch looks great! Reviews applied: [25334] All tests passed. - Mesos ReviewBot On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- (Updated Sept. 4, 2014, 11:46 a.m.) Review request for mesos, Benjamin Hindman, Tom Arnfeld, Thomas Rampelberg, and Vinod Kone. Bugs: MESOS-1750 https://issues.apache.org/jira/browse/MESOS-1750 Repository: mesos-git Description --- Fixes defective import introduced by the flat folder hierachy of the mesos.interface Python egg generation. Diffs - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff
