Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80659
---

Ship it!


LGTM, assuming we reach a consensus on the style issues. (Also assuming you 
didn't lie about changing any logic/functionality. ;)

- Adam B


On April 14, 2015, 5:44 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 5:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Michael Park]

> On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
> > src/authentication/cram_md5/authenticatee.cpp, lines 46-47
> > 
> >
> > Let's move to newline to avoid jaggeddness. Btw, what does clang-format 
> > suggest?
> 
> Kapil Arya wrote:
> According to our style guide, this is okay but we keep seeing issues 
> being raised about this. Should we just update the style guide instead?
> 
> Alexander Rukletsov wrote:
> I would like to have just one way of doing this. I think the one with 
> newline scales better.
> 
> Till Toenshoff wrote:
> This was exactly clang-format's suggestion. Raised 
> https://issues.apache.org/jira/browse/MESOS-2618

Sorry about that, `clang-format` gets this "wrong" currently. It's documented 
under [Known 
Limitations](https://github.com/apache/mesos/blob/master/docs/clang-format.md#known-limitations).


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---


On April 15, 2015, 12:44 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 15, 2015, 12:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Till Toenshoff]

> On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
> >

Thanks a bunch for your review Alex, much appreciated.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---


On April 15, 2015, 12:44 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 15, 2015, 12:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Till Toenshoff]

> On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
> > src/authentication/cram_md5/authenticatee.cpp, lines 46-47
> > 
> >
> > Let's move to newline to avoid jaggeddness. Btw, what does clang-format 
> > suggest?
> 
> Kapil Arya wrote:
> According to our style guide, this is okay but we keep seeing issues 
> being raised about this. Should we just update the style guide instead?
> 
> Alexander Rukletsov wrote:
> I would like to have just one way of doing this. I think the one with 
> newline scales better.

This was exactly clang-format's suggestion. Raised 
https://issues.apache.org/jira/browse/MESOS-2618


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---


On April 15, 2015, 12:44 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 15, 2015, 12:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
---

(Updated April 15, 2015, 12:44 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
'mcypark'.


Changes
---

Addressed most of Alex's comments.


Bugs: MESOS-2584
https://issues.apache.org/jira/browse/MESOS-2584


Repository: mesos-incubating


Description
---

Removing the process from the header is much cleaner and also fixes the linked 
clang 3.4.2 JIRA. Apart from that moving, no code is changed.


Diffs (updated)
-

  src/Makefile.am d15a373 
  src/authentication/cram_md5/authenticatee.hpp 55fac68 
  src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/32850/diff/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Till Toenshoff]

> On April 14, 2015, 7:22 p.m., Kapil Arya wrote:
> > src/authentication/cram_md5/authenticatee.cpp, lines 46-47
> > 
> >
> > According to our style guide, this is okay but we keep seeing issues 
> > being raised about this. Should we just update the style guide instead?

The styleguide is IMHO unclear on this case as it proposes similar examples but 
only being "ok". Definitely a case for an update suggestion.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80082
---


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Joerg Schad]

> On April 14, 2015, 6:17 p.m., Joerg Schad wrote:
> > src/authentication/cram_md5/authenticatee.cpp, line 33
> > 
> >
> > Actually according to Google's styleguide this should be the first 
> > include, shouldn't it?
> > 
> > http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
> > 
> > I know we don't do that at other places but actually it would prevent a 
> > number of Alexs comments (and be consistent with the styleguide)...
> 
> Alexander Rukletsov wrote:
> I think we don't follow google styleguide whe including headers (update 
> the styleguide?), we have our own grouping: by project, by directory, 
> alphabetically.

Already on Agenda for next Review/C++ meeting.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80072
---


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Alexander Rukletsov]

> On April 14, 2015, 6:17 p.m., Joerg Schad wrote:
> > src/authentication/cram_md5/authenticatee.cpp, line 33
> > 
> >
> > Actually according to Google's styleguide this should be the first 
> > include, shouldn't it?
> > 
> > http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
> > 
> > I know we don't do that at other places but actually it would prevent a 
> > number of Alexs comments (and be consistent with the styleguide)...

I think we don't follow google styleguide whe including headers (update the 
styleguide?), we have our own grouping: by project, by directory, 
alphabetically.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80072
---


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Alexander Rukletsov]

> On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
> > src/authentication/cram_md5/authenticatee.cpp, lines 46-47
> > 
> >
> > Let's move to newline to avoid jaggeddness. Btw, what does clang-format 
> > suggest?
> 
> Kapil Arya wrote:
> According to our style guide, this is okay but we keep seeing issues 
> being raised about this. Should we just update the style guide instead?

I would like to have just one way of doing this. I think the one with newline 
scales better.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Kapil Arya]

> On April 14, 2015, 10:16 a.m., Alexander Rukletsov wrote:
> > src/authentication/cram_md5/authenticatee.cpp, lines 46-47
> > 
> >
> > Let's move to newline to avoid jaggeddness. Btw, what does clang-format 
> > suggest?

According to our style guide, this is okay but we keep seeing issues being 
raised about this. Should we just update the style guide instead?


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---


On April 14, 2015, 10:20 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 10:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80082
---



src/authentication/cram_md5/authenticatee.cpp


According to our style guide, this is okay but we keep seeing issues being 
raised about this. Should we just update the style guide instead?


- Kapil Arya


On April 14, 2015, 10:20 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 10:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80072
---



src/authentication/cram_md5/authenticatee.cpp


Actually according to Google's styleguide this should be the first include, 
shouldn't it?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes

I know we don't do that at other places but actually it would prevent a 
number of Alexs comments (and be consistent with the styleguide)...


- Joerg Schad


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
---

(Updated April 14, 2015, 2:20 p.m.)


Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
'mcypark'.


Changes
---

Addressed Kapil's comment.


Bugs: MESOS-2584
https://issues.apache.org/jira/browse/MESOS-2584


Repository: mesos-incubating


Description
---

Removing the process from the header is much cleaner and also fixes the linked 
clang 3.4.2 JIRA. Apart from that moving, no code is changed.


Diffs (updated)
-

  src/Makefile.am d15a373 
  src/authentication/cram_md5/authenticatee.hpp 55fac68 
  src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/32850/diff/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---



src/authentication/cram_md5/authenticatee.hpp


`#include `?



src/authentication/cram_md5/authenticatee.hpp


`#include `?



src/authentication/cram_md5/authenticatee.cpp


Should stay in the header.



src/authentication/cram_md5/authenticatee.cpp


Let's move to newline to avoid jaggeddness. Btw, what does clang-format 
suggest?



src/authentication/cram_md5/authenticatee.cpp


`#include "logging/logging.hpp"`?



src/authentication/cram_md5/authenticatee.cpp


`#include ?


- Alexander Rukletsov


On April 10, 2015, 2:58 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 10, 2015, 2:58 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am fa609da 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80018
---

Ship it!


LGTM assuming the changes only involve code move only :-).


src/authentication/cram_md5/authenticatee.hpp


I think this `#include` can be moved to the cpp file as well.


- Kapil Arya


On April 9, 2015, 10:58 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 9, 2015, 10:58 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am fa609da 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review78876
---


Patch looks great!

Reviews applied: [32850]

All tests passed.

- Mesos ReviewBot


On April 4, 2015, 3:22 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> ---
> 
> (Updated April 4, 2015, 3:22 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-2584
> https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Removing the process from the header is much cleaner and also fixes the 
> linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> NOTE: This patch is mostly a proof of concept for validation and further 
> research. There are more tests breaking as described in the JIRA and those 
> might need some care as well, depending on our clang 3.4 support strategy.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9c01f5d 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>