[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme Resource Enums for better readability
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842958#action_12842958 ] Rishi Solanki commented on OFBIZ-3519: -- +1 for Scott's suggestion, as the new ID's are giving more verbose meaning (IMO). Later we can remove the old one as dependencies resolve. Slightly modified Visual Theme Resource Enums for better readability Key: OFBIZ-3519 URL: https://issues.apache.org/jira/browse/OFBIZ-3519 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Reporter: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: enum.patch Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified. The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size. The suffix in the enum contains following changes. 1. STYLESHEET is replaced with CSS 2. JAVASCRIPT is replaced with JS 3. LOC is completely removed from TMPLT, since it is anyway specify a template location. With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability. For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3527) Color of links in retrieved list for Tomahawk theme
[ https://issues.apache.org/jira/browse/OFBIZ-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842968#action_12842968 ] Jacques Le Roux commented on OFBIZ-3527: Ho, my cats (we have 5 females and 1 male all castrated, of course we live in the countryside) sometimes catch a bird when it's early and cold, I hate that. But what can we do? Cats love birds, only not our way. Color of links in retrieved list for Tomahawk theme --- Key: OFBIZ-3527 URL: https://issues.apache.org/jira/browse/OFBIZ-3527 Project: OFBiz Issue Type: Sub-task Components: themes Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3527_LookupLayoutFix.patch, OFBIZ-3527_LookupLayoutFix_2.patch, screenshot-1.jpg -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme Resource Enums for better readability
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842970#action_12842970 ] Jacques Le Roux commented on OFBIZ-3519: Yes, I agree with Rishi, Scott's proposition is the better... if someone is happy to implement it. Don't forget comments above removing. Thanks Slightly modified Visual Theme Resource Enums for better readability Key: OFBIZ-3519 URL: https://issues.apache.org/jira/browse/OFBIZ-3519 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Reporter: Vikas Mayur Priority: Minor Fix For: SVN trunk Attachments: enum.patch Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified. The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size. The suffix in the enum contains following changes. 1. STYLESHEET is replaced with CSS 2. JAVASCRIPT is replaced with JS 3. LOC is completely removed from TMPLT, since it is anyway specify a template location. With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability. For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Postal Adress and Party table
hello, When i try to delete a general adress location from the web screen that do this: http://n4.nabble.com/file/n1585681/capture.jpg After doing that i have take the message error in the console.log : The mistake is that http://n4.nabble.com/file/n1585681/console.log console.log Thanks for help Fabrice -- View this message in context: http://n4.nabble.com/Postal-Adress-and-Party-table-tp1584481p1585681.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Postal Adress and Party table
Le 09/03/2010 09:54, fabrice a écrit : http://n4.nabble.com/file/n1585681/console.log console.log Hi Fabrice, from the screenshot, it seems you are using the oya application, which is based on Neogia, based itself on OFBiz 4.0. Your better ask your questions on oya mailing lists, or maybe on neogia ones. Cheers, -- Erwan de FERRIERES www.nereide.biz
Catalog product managed by meter (also price) VS stock by each and serializable
Hello, I have the following need. So I'd like to know if it's possible in the current implementation. FYI I'm using the trunk version. I have a product catalog that must be ordered by meter and the given price is by meter. But once an order has been done, the resulting products (after production) are present in stock in a serializable way. Each product has a distinct number and has a standard length of 2,5 meters. So even if a customer asks for a quantity (in meters) that is not a multiple of 2,5, we will deliver only products of 2,5 meters. The remains is not billed to the customer of course. Example : a customer asks for 11 meters of this product @ 5 $/meter - the resulting order must be only 10 meters - total = 50$. The delivery will consist of 4 stock items - serializable because we need to have a follow-up for each product and information can differ between final products. Hope it's clear. Can someone give me an idea on how it can be done ? Thanks a lot and regards, el.ansari -- View this message in context: http://n4.nabble.com/Catalog-product-managed-by-meter-also-price-VS-stock-by-each-and-serializable-tp1585723p1585723.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Hi Raj, I can't see any reasons to not create a Jira and a patch Thanks Jacques From: Raj Saini rajsa...@gmail.com Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. Starting with JDK 1.6, java.util.ServiceLoader class is provided to replace the javax.imageio.spi.ServiceRegistry class and this class does not depend on sun.misc.Service class. This is minor two line code change and if community agree I can provide the patch. Thanks, Raj
Re: Catalog product managed by meter (also price) VS stock by each and serializable
Please use rather user ML for such questions, see why here : http://cwiki.apache.org/confluence/display/OFBADMIN/Mailing+Lists#MailingLists-DesignanddevelopmentList:dev@ofbiz.apache.org Thanks Jacques From: el.ansari el.abdesa...@gmail.com Hello, I have the following need. So I'd like to know if it's possible in the current implementation. FYI I'm using the trunk version. I have a product catalog that must be ordered by meter and the given price is by meter. But once an order has been done, the resulting products (after production) are present in stock in a serializable way. Each product has a distinct number and has a standard length of 2,5 meters. So even if a customer asks for a quantity (in meters) that is not a multiple of 2,5, we will deliver only products of 2,5 meters. The remains is not billed to the customer of course. Example : a customer asks for 11 meters of this product @ 5 $/meter - the resulting order must be only 10 meters - total = 50$. The delivery will consist of 4 stock items - serializable because we need to have a follow-up for each product and information can differ between final products. Hope it's clear. Can someone give me an idea on how it can be done ? Thanks a lot and regards, el.ansari -- View this message in context: http://n4.nabble.com/Catalog-product-managed-by-meter-also-price-VS-stock-by-each-and-serializable-tp1585723p1585723.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Postal Adress and Party table
hello, I use ofbiz 1_6 version for agroalimentaire agri-business. perhaps is it based on oya I'dont know. Could you explain me how to post it to the oya mailing list, here i have just found the ofbiz forum whith the dev, intallation, etc. but not a mailing list. Thanks fabrice -- View this message in context: http://n4.nabble.com/Postal-Adress-and-Party-table-tp1584481p1585742.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: ofbiz.org domain and all the infra around it
As soon as I get into the server, I will post all of this stuff up there for sure. Thanks Jacques. Cheers, Ruppert On Mar 9, 2010, at 7:25 AM, Jacques Le Roux wrote: Hi Tim, I saw that we have now a ofbiz-bigfiles.apache.org domain at https://issues.apache.org/jira/browse/INFRA-2516 Have you planned to migrate our big file there, what should be done? Do you need some help? BTW, I have asked for more memory at https://issues.apache.org/jira/browse/INFRA-2483 Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Tim, I may help a bit this week-end Jacques From: Tim Ruppert tim.rupp...@hotwaxmedia.com Just another heads up in this thread - we're now at the 18th - and I'm not sure that bigfiles, etc have all been setup over there. Just don't want anyone to get the gotcha. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Jan 4, 2010, at 9:11 AM, Tim Ruppert wrote: Just wanted to let everyone know that we reupped for another month since it appears that everything hasn't been migrated off of the server by the end of last week. We have signed the decommission notice for this server to end before the end of this month. Looking forward to not losing any data and getting people rallied around getting everything over to the ASF. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 22, 2009, at 9:41 PM, Tim Ruppert wrote: Alright, just wanted to raise this up again to anyone working with the infra team at the ASF - I'm still not sure that we have a working duplicate of what Contegix and HotWax have been hosting for years. Here's the checklist if anyone's interested: 1. docs.ofbiz.org - migrated, but still dependent at some level of the old backup at olddocs.ofbiz.org 2. demo.ofbiz.org - not migrated 3. demo40.ofbiz.org - not migrated 4. demo904.ofbiz.org - not migrated 5. api.ofbiz.org - migrated? 6. build.ofbiz.org (I think this is close) 7. log.ofbiz.org - not migrated until 2, 3, and 4 are migrated 8. olddocs.ofbiz.org - not migrated 9. bigfiles.ofbiz.org - not migrated 10. anything else? We're now over the XMas holiday here and there are only 9 days left on this server. Please speak up on which portions are going to be a huge problem or please step up and help to migrate this stuff off because I don't want OFBiz to turn into a pumpkin because we didn't have people acting - we've been talking about it for six weeks now Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 15, 2009, at 2:34 PM, Tim Ruppert wrote: The other thing to remember is that I don't think that the demo.ofbiz.org, demo40.ofbiz.org, and demo904.ofbiz.org - but I think the rest of those are good to go. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 15, 2009, at 12:38 PM, David E Jones wrote: On Dec 15, 2009, at 1:34 PM, Jacques Le Roux wrote: From: David E Jones d...@me.com What are the remaining resources? From memory: - build.ofbiz.org - api.ofbiz.org - bigfiles.ofbiz.org - olddocs.ofbiz.org What were bigfiles.ofbiz.org? These are movie files and other big files linked to from docs.ofbiz.org, now cwiki.ofbiz.org (like the Framework Introduction videos). You're right that there hasn't been much about these... does anyone care? About olddocs... IMO it's a bad idea to move it over just because some old links inside the wiki itself can be served by it. Over time that content will get more and more stale, and more an more confusing. Let's just update the links as we notice them or as they bother us. Yes, but for old tinylinks it's not always obvious to know what they represent. There are some of them in OFBiz trunk as well (not much 50+). And it's not very good for newcomers. If we could change them in one shoot it would be great but we have to know where they point to. Also I must admit I have no time to put in this at the moment Well, hopefully we've learned our lesson... -David On Dec 15, 2009, at 9:26 AM, Tim Ruppert wrote: Looking for thoughts from the community since we're less than two weeks away from removing this server. Also, what about moving the olddocs.ofbiz.org to ASF infra somewhere so that all of the links don't have to be updated? Something to think on Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 10, 2009, at 9:56 AM, Tim Ruppert wrote: David you own this officially at this point - but I'd like to know what we should do with this at the end of the month? The reason is that there are a ton of subdomains, that even if we move over to all being under ofbiz.apache.org or some other hosted
[jira] Updated: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven
[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Sharma updated OFBIZ-3533: --- Attachment: OFBIZ-3533.patch Here is the updated patch. Added a logic so that if promo folder is not exists then it gets created automatically. Regards, Amit Sharma Associate Image functionality with ProductPromo using content driven Key: OFBIZ-3533 URL: https://issues.apache.org/jira/browse/OFBIZ-3533 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Amit Sharma Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch Associate Image functionality with ProductPromo using content driven. Following work will be covered: - # Add new entity ProductPromoContent entity having composite primary key: ## productPromoId ## contentId ## productPromoContentTypeId ## fromDate # CRUD services for ProductPromoContent Entity. # Create wrapper ProductPromoContentWrapper # Add content tab at catalog - promo # List and edit form for associating images to specific productPromoId. # Implement service addImageForProductPromo. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r920359 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: form/MacroFormRenderer.java screen/MacroScreenViewHandler.java screen/ScreenFopViewHandler.java
Le 08/03/2010 18:50, Jacopo Cappellato a écrit : before Kind regards Hi Jacopo, just tried, and your suggestion is not working. Cheers, -- Erwan de FERRIERES www.nereide.biz
Re: svn commit: r920359 - in /ofbiz/trunk/framework/widget/src/org/ofbiz/widget: form/MacroFormRenderer.java screen/MacroScreenViewHandler.java screen/ScreenFopViewHandler.java
Ok, I will look into it because I would like to improve the code committed in r920359 Kind regards, Jacopo On Mar 9, 2010, at 12:08 PM, Erwan de FERRIERES wrote: Le 08/03/2010 18:50, Jacopo Cappellato a écrit : before Kind regards Hi Jacopo, just tried, and your suggestion is not working. Cheers, -- Erwan de FERRIERES www.nereide.biz
Re: Postal Adress and Party table
There is no ofbiz 1_6 version for agroalimentaire agri-business You use the Entente Oya software. C-Libre is behind Entente Oya, it's a commercial product (not open source) based on Neogia which is based on OFBiz. http://www.entente-oya.com/cms/showcontenttree;jsessionid=EDB15FC04766C2E0B01C611B8466C835.jvm1?contentId=11696nodeTrailCsv=MG10173,11696 Not sure which number is the good one http://www.prolibre.net/article.php3?id_article=103 http://www.industrie.com/it/actualites/c-libre-lance-un-erp-open-source-pour-l-agroalimentaire.6972 I sent you a link for the OFBiz user ML, please don't use this ML for this kind of questions Jacques From: fabrice merlin.ava...@yahoo.fr hello, I use ofbiz 1_6 version for agroalimentaire agri-business. perhaps is it based on oya I'dont know. Could you explain me how to post it to the oya mailing list, here i have just found the ofbiz forum whith the dev, intallation, etc. but not a mailing list. Thanks fabrice -- View this message in context: http://n4.nabble.com/Postal-Adress-and-Party-table-tp1584481p1585742.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: svn commit: r920770 - in /ofbiz/trunk/framework/widget: dtd/widget-form.xsd src/org/ofbiz/widget/form/MacroFormRenderer.java src/org/ofbiz/widget/form/ModelFormField.java templates/htmlFormMacroLi
Hi Erwan,
please remember to add the description and alternate arguments to all the
other *FormMacroLibrary.ftl templates.
Kind regards,
Jacopo
On Mar 9, 2010, at 11:18 AM, er...@apache.org wrote:
Author: erwan
Date: Tue Mar 9 10:18:54 2010
New Revision: 920770
URL: http://svn.apache.org/viewvc?rev=920770view=rev
Log:
Adding description and alternate text on a field type=image
Modified:
ofbiz/trunk/framework/widget/dtd/widget-form.xsd
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
Modified: ofbiz/trunk/framework/widget/dtd/widget-form.xsd
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-form.xsd?rev=920770r1=920769r2=920770view=diff
==
--- ofbiz/trunk/framework/widget/dtd/widget-form.xsd (original)
+++ ofbiz/trunk/framework/widget/dtd/widget-form.xsd Tue Mar 9 10:18:54 2010
@@ -875,6 +875,8 @@ under the License.
xs:attribute type=xs:positiveInteger name=height/
xs:attribute type=xs:string name=value/
xs:attribute type=xs:string name=default-value/
+xs:attribute type=xs:string name=description/
+xs:attribute type=xs:string name=alternate/
/xs:attributeGroup
xs:element name=lookup substitutionGroup=AllFields
xs:complexType
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java?rev=920770r1=920769r2=920770view=diff
==
---
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
(original)
+++
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
Tue Mar 9 10:18:54 2010
@@ -2396,6 +2396,12 @@ public class MacroFormRenderer implement
String value = modelFormField.getEntry(context,
imageField.getValue(context));
String width = ;
String height = ;
+String description = imageField.getDescription();
+String alternate = imageField.getAlternate();
+
+if(UtilValidate.isEmpty(description)){
+description = imageField.getModelFormField().getTitle(context);
+}
if (UtilValidate.isNotEmpty(value)) {
StringBuilder buffer = new StringBuilder();
ContentUrlTag.appendContentPrefix(request, buffer);
@@ -2420,6 +2426,10 @@ public class MacroFormRenderer implement
sr.append(@renderImageField );
sr.append( value=\);
sr.append(value);
+sr.append(\ description=\);
+sr.append(description);
+sr.append(\ alternate=\);
+sr.append(alternate);
sr.append(\ border=\);
sr.append(border);
sr.append(\ width=\);
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java?rev=920770r1=920769r2=920770view=diff
==
---
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
(original)
+++
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
Tue Mar 9 10:18:54 2010
@@ -3620,6 +3620,8 @@ public class ModelFormField {
protected FlexibleStringExpander defaultValue;
protected FlexibleStringExpander value;
protected SubHyperlink subHyperlink;
+protected String description;
+protected String alternate;
protected ImageField() {
super();
@@ -3636,6 +3638,8 @@ public class ModelFormField {
public ImageField(Element element, ModelFormField modelFormField) {
super(element, modelFormField);
this.setValue(element.getAttribute(value));
+this.setDescription(element.getAttribute(description));
+this.setAlternate(element.getAttribute(alternate));
String borderStr = element.getAttribute(border);
try {
@@ -3726,6 +3730,22 @@ public class ModelFormField {
this.value = FlexibleStringExpander.getInstance(string);
}
+public String getDescription() {
+return this.description;
+}
+
+public void setDescription(String string) {
+this.description = string;
+}
+
+public String getAlternate() {
+return this.alternate;
+}
+
+public void setAlternate(String string) {
+this.alternate = string;
+}
+
}
public static class ContainerField
Re: product store shipment meth
Hi Adam, Go to catalog stores select a store say 9000 Go to Shipping we can remove the product store shipping association which will not expires but delete the record. Go to Shipping Estimates will give you opportunity to change the estimates. I think these business process will be able to handle all the scenarios you are talking about. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Mar 9, 2010 at 5:25 AM, Adam Heath doo...@brainfood.com wrote: How can I do date-like filtering on ProductStoreShipmentMeth? I see no fromDate/thruDate fields in ProductStoreShipmentMeth, ShipmentCostEstimate, CarrierShipmentMethod, nor ShipmentMethodType. How can I handle the cost estimates changing in the future, how can I cycle out old values, while still maintaining any existing database references?
Re: svn commit: r920770 - in /ofbiz/trunk/framework/widget: dtd/widget-form.xsd src/org/ofbiz/widget/form/MacroFormRenderer.java src/org/ofbiz/widget/form/ModelFormField.java templates/htmlFormMacroLi
Also please html encode the strings within the MacroFormRenderer.
Thanks
Scott
HotWax Media
http://www.hotwaxmedia.com
On 9/03/2010, at 4:25 AM, Jacopo Cappellato wrote:
Hi Erwan,
please remember to add the description and alternate arguments to all
the other *FormMacroLibrary.ftl templates.
Kind regards,
Jacopo
On Mar 9, 2010, at 11:18 AM, er...@apache.org wrote:
Author: erwan
Date: Tue Mar 9 10:18:54 2010
New Revision: 920770
URL: http://svn.apache.org/viewvc?rev=920770view=rev
Log:
Adding description and alternate text on a field type=image
Modified:
ofbiz/trunk/framework/widget/dtd/widget-form.xsd
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
Modified: ofbiz/trunk/framework/widget/dtd/widget-form.xsd
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-form.xsd?rev=920770r1=920769r2=920770view=diff
==
--- ofbiz/trunk/framework/widget/dtd/widget-form.xsd (original)
+++ ofbiz/trunk/framework/widget/dtd/widget-form.xsd Tue Mar 9 10:18:54 2010
@@ -875,6 +875,8 @@ under the License.
xs:attribute type=xs:positiveInteger name=height/
xs:attribute type=xs:string name=value/
xs:attribute type=xs:string name=default-value/
+xs:attribute type=xs:string name=description/
+xs:attribute type=xs:string name=alternate/
/xs:attributeGroup
xs:element name=lookup substitutionGroup=AllFields
xs:complexType
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java?rev=920770r1=920769r2=920770view=diff
==
---
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
(original)
+++
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java
Tue Mar 9 10:18:54 2010
@@ -2396,6 +2396,12 @@ public class MacroFormRenderer implement
String value = modelFormField.getEntry(context,
imageField.getValue(context));
String width = ;
String height = ;
+String description = imageField.getDescription();
+String alternate = imageField.getAlternate();
+
+if(UtilValidate.isEmpty(description)){
+description = imageField.getModelFormField().getTitle(context);
+}
if (UtilValidate.isNotEmpty(value)) {
StringBuilder buffer = new StringBuilder();
ContentUrlTag.appendContentPrefix(request, buffer);
@@ -2420,6 +2426,10 @@ public class MacroFormRenderer implement
sr.append(@renderImageField );
sr.append( value=\);
sr.append(value);
+sr.append(\ description=\);
+sr.append(description);
+sr.append(\ alternate=\);
+sr.append(alternate);
sr.append(\ border=\);
sr.append(border);
sr.append(\ width=\);
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java?rev=920770r1=920769r2=920770view=diff
==
---
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
(original)
+++
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java
Tue Mar 9 10:18:54 2010
@@ -3620,6 +3620,8 @@ public class ModelFormField {
protected FlexibleStringExpander defaultValue;
protected FlexibleStringExpander value;
protected SubHyperlink subHyperlink;
+protected String description;
+protected String alternate;
protected ImageField() {
super();
@@ -3636,6 +3638,8 @@ public class ModelFormField {
public ImageField(Element element, ModelFormField modelFormField) {
super(element, modelFormField);
this.setValue(element.getAttribute(value));
+this.setDescription(element.getAttribute(description));
+this.setAlternate(element.getAttribute(alternate));
String borderStr = element.getAttribute(border);
try {
@@ -3726,6 +3730,22 @@ public class ModelFormField {
this.value = FlexibleStringExpander.getInstance(string);
}
+public String getDescription() {
+return this.description;
+}
+
+public void setDescription(String string) {
+this.description = string;
+}
+
+public String getAlternate() {
+return this.alternate;
+}
+
+
[jira] Assigned: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven
[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-3533: -- Assignee: Ashish Vijaywargiya Associate Image functionality with ProductPromo using content driven Key: OFBIZ-3533 URL: https://issues.apache.org/jira/browse/OFBIZ-3533 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Amit Sharma Assignee: Ashish Vijaywargiya Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch Associate Image functionality with ProductPromo using content driven. Following work will be covered: - # Add new entity ProductPromoContent entity having composite primary key: ## productPromoId ## contentId ## productPromoContentTypeId ## fromDate # CRUD services for ProductPromoContent Entity. # Create wrapper ProductPromoContentWrapper # Add content tab at catalog - promo # List and edit form for associating images to specific productPromoId. # Implement service addImageForProductPromo. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Associate image with promotion
I am thinking to commit the code today. Please comment if you have any concern on the implemented work. Thanks! -- Ashish On Mon, Mar 8, 2010 at 10:26 AM, Amit Sharma amit.sha...@hotwaxmedia.com wrote: Hello All, We are planning new functionality in OOTB. Purpose : Associate Image with ProductPromo using content driven. Here is the jira issue link https://issues.apache.org/jira/browse/OFBIZ-3533 Following work will be covered: 1. Add new entity ProductPromoContent entity having composite primary key: 1. productPromoId 2. contentId 3. productPromoContentTypeId 4. fromDate 2. CRUD services for ProductPromoContent Entity. 3. Create wrapper ProductPromoContentWrapper 4. Add content tab at catalog - promo 5. List and edit form for associating images to specific productPromoId. 6. Implement service addImageForProductPromo. Your valuable thoughts and suggestion will be appreciable. Thanks Regards, --Amit Sharma
Re: ofbiz.org domain and all the infra around it
Hi Tim, I saw that we have now a ofbiz-bigfiles.apache.org domain at https://issues.apache.org/jira/browse/INFRA-2516 Have you planned to migrate our big file there, what should be done? Do you need some help? BTW, I have asked for more memory at https://issues.apache.org/jira/browse/INFRA-2483 Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Tim, I may help a bit this week-end Jacques From: Tim Ruppert tim.rupp...@hotwaxmedia.com Just another heads up in this thread - we're now at the 18th - and I'm not sure that bigfiles, etc have all been setup over there. Just don't want anyone to get the gotcha. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Jan 4, 2010, at 9:11 AM, Tim Ruppert wrote: Just wanted to let everyone know that we reupped for another month since it appears that everything hasn't been migrated off of the server by the end of last week. We have signed the decommission notice for this server to end before the end of this month. Looking forward to not losing any data and getting people rallied around getting everything over to the ASF. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 22, 2009, at 9:41 PM, Tim Ruppert wrote: Alright, just wanted to raise this up again to anyone working with the infra team at the ASF - I'm still not sure that we have a working duplicate of what Contegix and HotWax have been hosting for years. Here's the checklist if anyone's interested: 1. docs.ofbiz.org - migrated, but still dependent at some level of the old backup at olddocs.ofbiz.org 2. demo.ofbiz.org - not migrated 3. demo40.ofbiz.org - not migrated 4. demo904.ofbiz.org - not migrated 5. api.ofbiz.org - migrated? 6. build.ofbiz.org (I think this is close) 7. log.ofbiz.org - not migrated until 2, 3, and 4 are migrated 8. olddocs.ofbiz.org - not migrated 9. bigfiles.ofbiz.org - not migrated 10. anything else? We're now over the XMas holiday here and there are only 9 days left on this server. Please speak up on which portions are going to be a huge problem or please step up and help to migrate this stuff off because I don't want OFBiz to turn into a pumpkin because we didn't have people acting - we've been talking about it for six weeks now Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 15, 2009, at 2:34 PM, Tim Ruppert wrote: The other thing to remember is that I don't think that the demo.ofbiz.org, demo40.ofbiz.org, and demo904.ofbiz.org - but I think the rest of those are good to go. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 15, 2009, at 12:38 PM, David E Jones wrote: On Dec 15, 2009, at 1:34 PM, Jacques Le Roux wrote: From: David E Jones d...@me.com What are the remaining resources? From memory: - build.ofbiz.org - api.ofbiz.org - bigfiles.ofbiz.org - olddocs.ofbiz.org What were bigfiles.ofbiz.org? These are movie files and other big files linked to from docs.ofbiz.org, now cwiki.ofbiz.org (like the Framework Introduction videos). You're right that there hasn't been much about these... does anyone care? About olddocs... IMO it's a bad idea to move it over just because some old links inside the wiki itself can be served by it. Over time that content will get more and more stale, and more an more confusing. Let's just update the links as we notice them or as they bother us. Yes, but for old tinylinks it's not always obvious to know what they represent. There are some of them in OFBiz trunk as well (not much 50+). And it's not very good for newcomers. If we could change them in one shoot it would be great but we have to know where they point to. Also I must admit I have no time to put in this at the moment Well, hopefully we've learned our lesson... -David On Dec 15, 2009, at 9:26 AM, Tim Ruppert wrote: Looking for thoughts from the community since we're less than two weeks away from removing this server. Also, what about moving the olddocs.ofbiz.org to ASF infra somewhere so that all of the links don't have to be updated? Something to think on Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Dec 10, 2009, at 9:56 AM, Tim Ruppert wrote: David you own this officially at this point - but I'd like to know what we should do with this at the end of the month? The reason is that there are a ton of subdomains, that even if we move over to all being under ofbiz.apache.org or some other hosted infra at apache, we will need to support the rewrites, etc going forward. I'd love to have everyone weigh in to see what we want to do. Thoughts? Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Thanks Jacques. Will create a JIRA issue and attach the patch. Raj Jacques Le Roux wrote: Hi Raj, I can't see any reasons to not create a Jira and a patch Thanks Jacques From: Raj Saini rajsa...@gmail.com Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. Starting with JDK 1.6, java.util.ServiceLoader class is provided to replace the javax.imageio.spi.ServiceRegistry class and this class does not depend on sun.misc.Service class. This is minor two line code change and if community agree I can provide the patch. Thanks, Raj
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Starting with JDK 1.6, java.util.ServiceLoader class is provided to replace the javax.imageio.spi.ServiceRegistry class and this class does not depend on sun.misc.Service class. This is minor two line code change and if community agree I can provide the patch. The api isn't exactly compatible, but yes.
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Adam Heath wrote: Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Starting with JDK 1.6, java.util.ServiceLoader class is provided to replace the javax.imageio.spi.ServiceRegistry class and this class does not depend on sun.misc.Service class. This is minor two line code change and if community agree I can provide the patch. The api isn't exactly compatible, but yes. Btw, I'm happy to just do this, but I'm a bit busy for the next few days. There's no immediate hurry for this either.
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Adam Heath wrote: Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Try debugging the code in Eclipse and you wont be able to attach source code the source code internal classes is not part of the JDK. I had hard time resolving a class loading issues as I could not look into look into the source code in Eclipse debugger. Starting with JDK 1.6, java.util.ServiceLoader class is provided to replace the javax.imageio.spi.ServiceRegistry class and this class does not depend on sun.misc.Service class. This is minor two line code change and if community agree I can provide the patch. The api isn't exactly compatible, but yes. You are right they are not exactly compatible. I had to add one more line of code to replace the ServiceRegistry with ServiceLoader. Thanks, Raj
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Raj Saini wrote: Adam Heath wrote: Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Try debugging the code in Eclipse and you wont be able to attach source code the source code internal classes is not part of the JDK. I had hard time resolving a class loading issues as I could not look into look into the source code in Eclipse debugger. Huh? ServiceRegistry is not an internal class, it's a public class. There's nothing keeping ServiceLoader from being an *exact* copy of ServiceRegistry, with any and all same-class internal uses, including using some internal jvm-specific class. So, to change this class just because eclipse can't debug it because it's trying to read the source of some internal jvm class is the wrong reason.
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Thanks Adam. Look forward to it. Raj Adam Heath wrote: Adam Heath wrote: Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Starting with JDK 1.6, java.util.ServiceLoader class is provided to replace the javax.imageio.spi.ServiceRegistry class and this class does not depend on sun.misc.Service class. This is minor two line code change and if community agree I can provide the patch. The api isn't exactly compatible, but yes. Btw, I'm happy to just do this, but I'm a bit busy for the next few days. There's no immediate hurry for this either.
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
You can find a better description of the problem here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5014358 Thanks, Raj Adam Heath wrote: Raj Saini wrote: Adam Heath wrote: Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Try debugging the code in Eclipse and you wont be able to attach source code the source code internal classes is not part of the JDK. I had hard time resolving a class loading issues as I could not look into look into the source code in Eclipse debugger. Huh? ServiceRegistry is not an internal class, it's a public class. There's nothing keeping ServiceLoader from being an *exact* copy of ServiceRegistry, with any and all same-class internal uses, including using some internal jvm-specific class. So, to change this class just because eclipse can't debug it because it's trying to read the source of some internal jvm class is the wrong reason.
Re: product store shipment meth
Rishi Solanki wrote: Hi Adam, Go to catalog stores select a store say 9000 Go to Shipping we can remove the product store shipping association which will not expires but delete the record. Go to Shipping Estimates will give you opportunity to change the estimates. I think these business process will be able to handle all the scenarios you are talking about. Well, I'd like to see what the values were in the past, for historical reasons. This could be done like any other date-filter based entity. I do see that ProductStoreShipmentMeth(and it's ShipmentCostEstimate) is only used to provide a list of available shipment types, and once the order is created, it is never used again. OrderItemShipGroup just references CarrierShipmentMethod. I don't like deleting ProductStoreShipmentMeth.
Re: Replace javax.imageio.spi.ServiceRegistry with java.util.ServiceLoader
Raj Saini wrote: You can find a better description of the problem here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5014358 So? What does that have to do with my observation, that any class provided by the jvm may end up using internal classes, and that eclipse shouldn't bitch about it. Thanks, Raj Adam Heath wrote: Raj Saini wrote: Adam Heath wrote: Raj Saini wrote: Hi, org.ofbiz.base.util.UtilObject#getObjectFromFactory class uses *javax.imageio.spi.ServiceRegistry *class to load DelegatorFactory implementation. ServiceRegistry class internally uses sun.misc.Service class which is internal to sun and may not be part of other JDKs. So? ServiceRegistry is a public class, who cares how it works internally. Try debugging the code in Eclipse and you wont be able to attach source code the source code internal classes is not part of the JDK. I had hard time resolving a class loading issues as I could not look into look into the source code in Eclipse debugger. Huh? ServiceRegistry is not an internal class, it's a public class. There's nothing keeping ServiceLoader from being an *exact* copy of ServiceRegistry, with any and all same-class internal uses, including using some internal jvm-specific class. So, to change this class just because eclipse can't debug it because it's trying to read the source of some internal jvm class is the wrong reason.
[jira] Commented: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven
[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12843199#action_12843199 ] Scott Gray commented on OFBIZ-3533: --- Few comments: - The entity packages should probably be org.ofbiz.product.promo instead of org.ofbiz.product.product - I'm not sure about re-using the ProductContentType entity for representing productPromoContentTypeIds, does anyone have an opinion on this? - What is the reason for calling updateContent within the ProductPromoContent CrUD services? Maybe the answer is obvious but I'm not fresh enough on the content stuff to know. Thanks Scott Associate Image functionality with ProductPromo using content driven Key: OFBIZ-3533 URL: https://issues.apache.org/jira/browse/OFBIZ-3533 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Amit Sharma Assignee: Ashish Vijaywargiya Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch Associate Image functionality with ProductPromo using content driven. Following work will be covered: - # Add new entity ProductPromoContent entity having composite primary key: ## productPromoId ## contentId ## productPromoContentTypeId ## fromDate # CRUD services for ProductPromoContent Entity. # Create wrapper ProductPromoContentWrapper # Add content tab at catalog - promo # List and edit form for associating images to specific productPromoId. # Implement service addImageForProductPromo. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Associate image with promotion
Hi Ashish, I've added a few comments and questions to the jira issue. One of them asks for the opinion of the community at large so if anyone is reading in and would like to comment on it please do so! Thanks Scott HotWax Media http://www.hotwaxmedia.com On 9/03/2010, at 8:42 AM, Ashish Vijaywargiya wrote: I am thinking to commit the code today. Please comment if you have any concern on the implemented work. Thanks! -- Ashish On Mon, Mar 8, 2010 at 10:26 AM, Amit Sharma amit.sha...@hotwaxmedia.com wrote: Hello All, We are planning new functionality in OOTB. Purpose : Associate Image with ProductPromo using content driven. Here is the jira issue link https://issues.apache.org/jira/browse/OFBIZ-3533 Following work will be covered: 1. Add new entity ProductPromoContent entity having composite primary key: 1. productPromoId 2. contentId 3. productPromoContentTypeId 4. fromDate 2. CRUD services for ProductPromoContent Entity. 3. Create wrapper ProductPromoContentWrapper 4. Add content tab at catalog - promo 5. List and edit form for associating images to specific productPromoId. 6. Implement service addImageForProductPromo. Your valuable thoughts and suggestion will be appreciable. Thanks Regards, --Amit Sharma smime.p7s Description: S/MIME cryptographic signature
Re: Postal Adress and Party table
From: fabrice merlin.ava...@yahoo.fr Hello, I don't find the link you speak about : OFBiz user ML. Right, I thought I had sent it to you, here it is http://cwiki.apache.org/confluence/display/OFBADMIN/Mailing+Lists Jacques thanks for the link i'm looking for. --- En date de : Mar 9.3.10, Jacques Le Roux [via OFBiz] ml-node+1585802-1144093634-182...@n4.nabble.com a écrit : De: Jacques Le Roux [via OFBiz] ml-node+1585802-1144093634-182...@n4.nabble.com Objet: Re: Postal Adress and Party table À: fabrice merlin.ava...@yahoo.fr Date: Mardi 9 mars 2010, 12h08 There is no ofbiz 1_6 version for agroalimentaire agri-business You use the Entente Oya software. C-Libre is behind Entente Oya, it's a commercial product (not open source) based on Neogia which is based on OFBiz. http://www.entente-oya.com/cms/showcontenttree;jsessionid=EDB15FC04766C2E0B01C611B8466C835.jvm1?contentId=11696nodeTrailCsv=MG10173,11696 Not sure which number is the good one http://www.prolibre.net/article.php3?id_article=103 http://www.industrie.com/it/actualites/c-libre-lance-un-erp-open-source-pour-l-agroalimentaire.6972 I sent you a link for the OFBiz user ML, please don't use this ML for this kind of questions Jacques From: fabrice [hidden email] hello, I use ofbiz 1_6 version for agroalimentaire agri-business. perhaps is it based on oya I'dont know. Could you explain me how to post it to the oya mailing list, here i have just found the ofbiz forum whith the dev, intallation, etc. but not a mailing list. Thanks fabrice -- View this message in context: http://n4.nabble.com/Postal-Adress-and-Party-table-tp1584481p1585742.html Sent from the OFBiz - Dev mailing list archive at Nabble.com. View message @ http://n4.nabble.com/Postal-Adress-and-Party-table-tp1584481p1585802.html To unsubscribe from Re: Postal Adress and Party table, click here. -- View this message in context: http://n4.nabble.com/Postal-Adress-and-Party-table-tp1584481p1585944.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: svn commit: r921099 - in /ofbiz/trunk/framework/widget/templates: csvFormMacroLibrary.ftl foFormMacroLibrary.ftl xmlFormMacroLibrary.ftl
er...@apache.org wrote: Author: erwan Date: Tue Mar 9 20:22:35 2010 New Revision: 921099 URL: http://svn.apache.org/viewvc?rev=921099view=rev Log: Adding missing tags in r920770 as spotted on the dev mailing list in the *FormMacroLibrary.ftl files Modified: ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl ofbiz/trunk/framework/widget/templates/foFormMacroLibrary.ftl ofbiz/trunk/framework/widget/templates/xmlFormMacroLibrary.ftl Modified: ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl?rev=921099r1=921098r2=921099view=diff == --- ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl (original) +++ ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl Tue Mar 9 20:22:35 2010 @@ -107,7 +107,7 @@ under the License. #macro renderNextPrev paginateStyle paginateFirstStyle viewIndex highIndex listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl firstUrl paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl previousUrl paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl ajaxSelectSizeUrl selectSizeUrl commonDisplaying paginateNextStyle ajaxNextUrl nextUrl paginateNextLabel paginateLastStyle ajaxLastUrl lastUrl paginateLastLabel paginateViewSizeLabel/#macro #macro renderFileField className alert name value size maxlength autocomplete@renderField value //#macro #macro renderPasswordField className alert name value size maxlength id autocomplete/#macro -#macro renderImageFiel value border width height event action/#macro +#macro renderImageFiel value description alternate border width height event action/#macro #macro renderBanner style leftStyle rightStyle leftText text rightText/#macro #macro renderFieldGroupOpen style id title collapsed collapsibleAreaId collapsible expandToolTip collapseToolTip/#macro #macro renderFieldGroupClose style id title/#macro renderImageFiel?
Re: svn commit: r921099 - in /ofbiz/trunk/framework/widget/templates: csvFormMacroLibrary.ftl foFormMacroLibrary.ftl xmlFormMacroLibrary.ftl
#macro renderFileField className alert name value size maxlength autocomplete@renderField value //#macro #macro renderPasswordField className alert name value size maxlength id autocomplete/#macro -#macro renderImageFiel value border width height event action/#macro +#macro renderImageFiel value description alternate border width height event action/#macro #macro renderBanner style leftStyle rightStyle leftText text rightText/#macro #macro renderFieldGroupOpen style id title collapsed collapsibleAreaId collapsible expandToolTip collapseToolTip/#macro #macro renderFieldGroupClose style id title/#macro renderImageFiel? yeah it was like that... I corrected it at rev. 921109 (one commit, one thing rule !) Cheers, -- Erwan de FERRIERES www.nereide.biz
Re: svn commit: r921087 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
On 9/03/2010, at 12:53 PM, doo...@apache.org wrote:
Author: doogie
Date: Tue Mar 9 19:53:25 2010
New Revision: 921087
URL: http://svn.apache.org/viewvc?rev=921087view=rev
Log:
Add helper method for determining whether a ship group contains only
digital goods.
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?rev=921087r1=921086r2=921087view=diff
==
---
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
(original)
+++
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Tue Mar 9 19:53:25 2010
@@ -818,6 +818,28 @@ public class ShoppingCart implements Ser
return true;
}
+/**
+ * Check to see if the ship group contains only Digital Goods, ie no
Finished Goods and no Finished/Digital Goods, et cetera.
+ * This is determined by making sure no Product has a type where
ProductType.isPhysical!=N.
+ */
+public boolean containOnlyDigitalGoods(int shipGroupIdx) {
+CartShipInfo shipInfo = getShipInfo(shipGroupIdx);
+for (ShoppingCartItem cartItem: shipInfo.getShipItems()) {
+GenericValue product = cartItem.getProduct();
+try {
+GenericValue productType =
product.getRelatedOneCache(ProductType);
+if (productType == null ||
!N.equals(productType.getString(isPhysical))) {
+return false;
+}
+} catch (GenericEntityException e) {
+Debug.logError(e, Error looking up ProductType: +
e.toString(), module);
+// consider this not a digital good if we don't have proof
+return false;
+}
+}
+return true;
+}
+
It looks like we've ended up with some duplicated functionality around this at
some point, shippingApplies() and containOnlyDigitalGoods() do essentially the
same thing and we should probably deprecate one of them. I'd prefer to keep
the former because digital good doesn't do a good job of describing the purpose
of the method e.g. shipping doesn't apply to a service item or non-product item
yet they aren't digital goods.
Regards
Scott
smime.p7s
Description: S/MIME cryptographic signature
Re: svn commit: r921087 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Scott Gray wrote:
On 9/03/2010, at 12:53 PM, doo...@apache.org wrote:
Author: doogie
Date: Tue Mar 9 19:53:25 2010
New Revision: 921087
URL: http://svn.apache.org/viewvc?rev=921087view=rev
Log:
Add helper method for determining whether a ship group contains only
digital goods.
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?rev=921087r1=921086r2=921087view=diff
==
---
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
(original)
+++
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Tue Mar 9 19:53:25 2010
@@ -818,6 +818,28 @@ public class ShoppingCart implements Ser
return true;
}
+/**
+ * Check to see if the ship group contains only Digital Goods, ie no
Finished Goods and no Finished/Digital Goods, et cetera.
+ * This is determined by making sure no Product has a type where
ProductType.isPhysical!=N.
+ */
+public boolean containOnlyDigitalGoods(int shipGroupIdx) {
+CartShipInfo shipInfo = getShipInfo(shipGroupIdx);
+for (ShoppingCartItem cartItem: shipInfo.getShipItems()) {
+GenericValue product = cartItem.getProduct();
+try {
+GenericValue productType =
product.getRelatedOneCache(ProductType);
+if (productType == null ||
!N.equals(productType.getString(isPhysical))) {
+return false;
+}
+} catch (GenericEntityException e) {
+Debug.logError(e, Error looking up ProductType: +
e.toString(), module);
+// consider this not a digital good if we don't have proof
+return false;
+}
+}
+return true;
+}
+
It looks like we've ended up with some duplicated functionality around this
at some point, shippingApplies() and containOnlyDigitalGoods() do essentially
the same thing and we should probably deprecate one of them. I'd prefer to
keep the former because digital good doesn't do a good job of describing the
purpose of the method e.g. shipping doesn't apply to a service item or
non-product item yet they aren't digital goods.
I don't care which, and will happily use another method instead of
this new one I just added.
I use this method to skip PostalAddress queries/creation if a
shipgroup only contains digital goods(our frontend puts all digital
goods into a single shipgroup).
Regards
Scott
ProductStoreEmailSetting code duplication
I was noticing several cases where code was fetching a ProductStoreEmailSetting, then doing various setup work, before calling sendEmailFromScreen. None of the setup blocks are the same, the set of features they support are not unified. I'd like to move all these separate calls into a single shared worker method. Then, the second phase, would add a feature that would call a service to send the email, instead of always forcing it to be a screen. Anyone else agree with this?
Re: product store shipment meth
There are several entities which have from and thru date attributes but they can be enable the record again in future. But once the shipment estimates is increase or company stop to use any shipment method due to any reason then record for them is none of use for the company. It is just my opinion because I'm not able to see the use of which shipment method company uses in past wanna to look at. I'm for the existing handling if it will change then also I do not have any problem, but I believe the OFBiz Data Model is design in such manner that all generic requirements can be handle using it. If we are changing it then it is our specific wish or requirement. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Mar 9, 2010 at 10:26 PM, Adam Heath doo...@brainfood.com wrote: Rishi Solanki wrote: Hi Adam, Go to catalog stores select a store say 9000 Go to Shipping we can remove the product store shipping association which will not expires but delete the record. Go to Shipping Estimates will give you opportunity to change the estimates. I think these business process will be able to handle all the scenarios you are talking about. Well, I'd like to see what the values were in the past, for historical reasons. This could be done like any other date-filter based entity. I do see that ProductStoreShipmentMeth(and it's ShipmentCostEstimate) is only used to provide a list of available shipment types, and once the order is created, it is never used again. OrderItemShipGroup just references CarrierShipmentMethod. I don't like deleting ProductStoreShipmentMeth.
Re: ProductStoreEmailSetting code duplication
+1. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Mar 10, 2010 at 5:31 AM, Adam Heath doo...@brainfood.com wrote: I was noticing several cases where code was fetching a ProductStoreEmailSetting, then doing various setup work, before calling sendEmailFromScreen. None of the setup blocks are the same, the set of features they support are not unified. I'd like to move all these separate calls into a single shared worker method. Then, the second phase, would add a feature that would call a service to send the email, instead of always forcing it to be a screen. Anyone else agree with this?
Re: ProductStoreEmailSetting code duplication
+1 -- Thanks Regards Awdesh Singh Parihar Hotwax Media http://www.hotwaxmedia.com awdesh.pari...@hotwaxmedia.com - direct: +91 - 989.335.1789
UtilCache is buggy when maxMemSize is set
Ok, this is a cute bug. Under the hood, UtilCache makes use of java.util.LinkedHashMap when maxMemSize is set. It configures LinkedHashMap to act like a LRU map; every access reorders the internal linked list. Access here is defined as a call to get(key). The problem is that to handle element expiration, UtilCache must call get(key) on LinkedHashMap. This causes the key to be accessed, which pushes it to the front of the linked list, and breaks the LRU contract. The way to fix this is to switch UtilCache away from a polling mechanism for expiration. Instead, a DelayQueue can be used, where every single CacheLine is registered into a single, static DelayQueue, and a thread is started that is always polling from that. When an item is returned from the poll, it removes it from it's containing cache. This is the only way I see to get UtilCache make to being a proper LRU system.
[jira] Created: (OFBIZ-3546) FreeMarkerViewHandler should load templates via the FreeMarkerWorker
FreeMarkerViewHandler should load templates via the FreeMarkerWorker Key: OFBIZ-3546 URL: https://issues.apache.org/jira/browse/OFBIZ-3546 Project: OFBiz Issue Type: Bug Components: framework Reporter: Bruno Busco This bug has been introduced in r920115. A temporary fix is in r920589: Fix a problem reported by Hans Bakker, FreeMarker templates loaded using the Configuration object don't have access to the component:// notation reader and this causes them to fail because all templates now attempt to retrieve the html form macro library using that notation. This is a quick fix but we should really fix the FreeMarkerViewHandler to load templates via the FreeMarkerWorker. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
