[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982517#action_12982517 ] Sascha Rodekamp commented on OFBIZ-4092: Oh yes that's really amazing, i like the new Flat Gray. Many Thanks *Ryan* and *Adrian* for your effort!!! Cheers Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4120: --- Description: By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available was:By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4122) Duplicate view map entry in controller.
Duplicate view map entry in controller. --- Key: OFBIZ-4122 URL: https://issues.apache.org/jira/browse/OFBIZ-4122 Project: OFBiz Issue Type: Bug Components: commonext/setup Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: Release Branch 10.04, SVN trunk Duplicate view map entry in the controller . view-map name=EditProductStore type=screen page=component://commonext/widget/ofbizsetup/SetupScreens.xml#EditProductStore/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4122) Duplicate view map entry in controller.
[ https://issues.apache.org/jira/browse/OFBIZ-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4122: -- Attachment: OFBIZ_4122.patch Here is the Patch for the same. -- Ankit Jain Duplicate view map entry in controller. --- Key: OFBIZ-4122 URL: https://issues.apache.org/jira/browse/OFBIZ-4122 Project: OFBiz Issue Type: Bug Components: commonext/setup Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ_4122.patch Duplicate view map entry in the controller . view-map name=EditProductStore type=screen page=component://commonext/widget/ofbizsetup/SetupScreens.xml#EditProductStore/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
New Flat Grey theme issues
Hi, Some minor issues I found while playing with it Sometimes, from catalog main page at least, when you get out after choising another theme you get a broken catalog main page (missing footer but actually more than that). It does not reproduce locally :/ Locally the new Flat Grey theme comment reads Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional but on the demo trunk it's still the old one Flat Grey - Old OFBiz Standard Floating Layout, not sure why since it has been automatically svn updated and run-installed (I suspected it could be a language issue but turnedf from French to English and got the same) Jacques
Re: New Flat Grey theme issues
Forget it, it was a cache issue for the second, and I can't reproduce the 1st now Jacques Jacques Le Roux wrote: Hi, Some minor issues I found while playing with it Sometimes, from catalog main page at least, when you get out after choising another theme you get a broken catalog main page (missing footer but actually more than that). It does not reproduce locally :/ Locally the new Flat Grey theme comment reads Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional but on the demo trunk it's still the old one Flat Grey - Old OFBiz Standard Floating Layout, not sure why since it has been automatically svn updated and run-installed (I suspected it could be a language issue but turnedf from French to English and got the same) Jacques
[jira] Commented: (OFBIZ-2131) Anonymous checkout Submit purchase button does not work in IE7
[ https://issues.apache.org/jira/browse/OFBIZ-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982579#action_12982579 ] Sascha Rodekamp commented on OFBIZ-2131: Task can be closed. anonymous quick checkout works in IE7 without problems Cheers Sascha Anonymous checkout Submit purchase button does not work in IE7 -- Key: OFBIZ-2131 URL: https://issues.apache.org/jira/browse/OFBIZ-2131 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Environment: XP, IE7. Reporter: chris The bug is still alive. See OFBIZ-1374. I'm tried all suggestions and bug still alive. I commented out following code and submit worked: dojo.addOnLoad(init); This line is in quickAnonPaymentInformation.ftl and quickAnonOptionSettings.ftl. So problem seems to be with dojo and IE7. The function processOrder() in quickAnonCheckoutReview.ftl never fires. The other functions that are registered with dojo.addOnLoad() do fire. Of course, with dojo.addOnLoad commented out, the payment choices are not rendered. In my research I found this bug report http://dojotoolkit.org/forum/dojo-core-dojo-0-9/dojo-core-support/dojo-addonload-bug-ie7;. Any suggestions for a temporary workaround I can use? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2131) Anonymous checkout Submit purchase button does not work in IE7
[ https://issues.apache.org/jira/browse/OFBIZ-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2131. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Sascha! Anonymous checkout Submit purchase button does not work in IE7 -- Key: OFBIZ-2131 URL: https://issues.apache.org/jira/browse/OFBIZ-2131 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Environment: XP, IE7. Reporter: chris Assignee: Jacques Le Roux Fix For: SVN trunk The bug is still alive. See OFBIZ-1374. I'm tried all suggestions and bug still alive. I commented out following code and submit worked: dojo.addOnLoad(init); This line is in quickAnonPaymentInformation.ftl and quickAnonOptionSettings.ftl. So problem seems to be with dojo and IE7. The function processOrder() in quickAnonCheckoutReview.ftl never fires. The other functions that are registered with dojo.addOnLoad() do fire. Of course, with dojo.addOnLoad commented out, the payment choices are not rendered. In my research I found this bug report http://dojotoolkit.org/forum/dojo-core-dojo-0-9/dojo-core-support/dojo-addonload-bug-ie7;. Any suggestions for a temporary workaround I can use? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid
Hans Jacopo, I agree with Hans - many things are wrong with that application. I am working on a project that will make much use of HR - so I can work on some of the problems. I expect to start working on it mid February or early March. -Adrian Sorry Jacopo, many things either wrong or missing on this application... redirecting to showing the tabs is only possible when the 'create' service returns the key of the entity (3 fields) and not only the perfReviewId. Regards, Hans On Sun, 2011-01-16 at 17:19 +0100, Jacopo Cappellato wrote: Ah yes, I can recreate the same after taking an update: it is caused by your today changes (rev. 1059556), I guess you will be able to fix it on your own. Jacopo On Jan 16, 2011, at 5:16 PM, Jacopo Cappellato wrote: On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote: After adding a review one still has to go back to he find option, find the review again and then finally items can add be added. This is not what I can see in my local box, please have a second look. Jacopo -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
[jira] Created: (OFBIZ-4123) Collapsing servlet
Collapsing servlet -- Key: OFBIZ-4123 URL: https://issues.apache.org/jira/browse/OFBIZ-4123 Project: OFBiz Issue Type: Sub-task Affects Versions: Release Branch 09.04, Release Branch 10.04, SVN trunk Reporter: Jacques Le Roux Priority: Minor Example: Search Products panel in Catalog/Main. This was working in R4.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: New Flat Grey theme issues
I see a different problem with the trunk demo: https://demo-trunk.ofbiz.apache.org/example/control/ExampleLayoutDemo It appears the Java code was not compiled - because that's the error I got before I committed rev 1059425. -Adrian --- On Mon, 1/17/11, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, Some minor issues I found while playing with it Sometimes, from catalog main page at least, when you get out after choising another theme you get a broken catalog main page (missing footer but actually more than that). It does not reproduce locally :/ Locally the new Flat Grey theme comment reads Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional but on the demo trunk it's still the old one Flat Grey - Old OFBiz Standard Floating Layout, not sure why since it has been automatically svn updated and run-installed (I suspected it could be a language issue but turnedf from French to English and got the same) Jacques
[jira] Created: (OFBIZ-4124) Catalogs/Categories tree in Main Catalog screen
Catalogs/Categories tree in Main Catalog screen --- Key: OFBIZ-4124 URL: https://issues.apache.org/jira/browse/OFBIZ-4124 Project: OFBiz Issue Type: Sub-task Affects Versions: SVN trunk Reporter: Jacques Le Roux Only trunk has this problem since http://svn.apache.org/viewvc?rev=1055790view=rev. I recommend to switch to the old way when javascript is not usable -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4125) Quick jump option in Catalog Main
Quick jump option in Catalog Main - Key: OFBIZ-4125 URL: https://issues.apache.org/jira/browse/OFBIZ-4125 Project: OFBiz Issue Type: Sub-task Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, SVN trunk Reporter: Jacques Le Roux It's the dropdown entitled - Product Jump -. Seems it has never(?) worked w/out js. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982622#action_12982622 ] Jacques Le Roux commented on OFBIZ-4120: So far, the current cases are only the ones found on the Catalog Main page, I'm sure there are more... Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4126) Online Help
Online Help --- Key: OFBIZ-4126 URL: https://issues.apache.org/jira/browse/OFBIZ-4126 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Fix For: Release Branch 10.04, SVN trunk -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: JavaScriptEnabled
Hi Adrian, If you are interested I'm filling https://issues.apache.org/jira/browse/OFBIZ-4120 One thing came into my mind: for security reasons we have heavily introduced use of javascript (see https://issues.apache.org/jira/browse/OFBIZ-2330 and maybe even https://issues.apache.org/jira/browse/OFBIZ-1525) all those cases are not barely usable w/out js but unusable... So I wonder now if OFBIZ-4120 has even any sense. We rely on js and OFBIZ-2330 is really showing it! Jacques From: Adrian Crum adrian.c...@yahoo.com --- On Sun, 1/16/11, Jacques Le Roux jacques.le.r...@les7arts.com wrote: BTW, what I'd suggest at this stage is to warn the user that it will miss a lot of things if javascript is disabled (even if OFBiz should be still barely usable - not checked, no guarantee...) So, OFBiz was barely usable before the JavaScript enhancements were added? ;-) -Adrian
Re: JavaScriptEnabled
I'm speaking about http://svn.apache.org/viewvc?rev=1055790view=rev You may have a look at https://issues.apache.org/jira/browse/OFBIZ-4120 and especially https://issues.apache.org/jira/browse/OFBIZ-4124 if you are really interested Jacques BJ Freeman wrote: If i remember correctly we were going to have a tree widget. so I don't see this correct. more it is what people perceive what happen to making ofbiz stand out with its own UI. = BJ Freeman Strategic Power Office with Supplier Automation http://www.businessesnetwork.com/automation/viewforum.php?f=52 Specialtymarket.com http://www.specialtymarket.com/ Systems Integrator-- Glad to Assist Chat Y! messenger: bjfr33man Jacques Le Roux sent the following on 1/16/2011 3:10 PM: Also, with last Hans's change on Catalog main page, if you disable javascript you don't have access to Catalogs/Categories tree. It's typically a case were we could degrade gracefully (just have to use the old way), but anyway who's care :/
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982626#action_12982626 ] Jacques Le Roux commented on OFBIZ-4120: Mmm, now that I think more about it I think we have a bigger problem here: for security reasons we have heavily introduced use of javascript (see https://issues.apache.org/jira/browse/OFBIZ-2330 and maybe even https://issues.apache.org/jira/browse/OFBIZ-1525) all those cases are not barely usable w/out js but unusable... So I wonder now if OFBIZ-4120 has even any sense. We rely on js and OFBIZ-2330 is really showing it! Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid
Hi Adrian, I am trying to use it for my own company but see chances for my customers too as long as it is working reasonably? looking forward to work together Regards Hans On Mon, 2011-01-17 at 04:05 -0800, Adrian Crum wrote: Hans Jacopo, I agree with Hans - many things are wrong with that application. I am working on a project that will make much use of HR - so I can work on some of the problems. I expect to start working on it mid February or early March. -Adrian Sorry Jacopo, many things either wrong or missing on this application... redirecting to showing the tabs is only possible when the 'create' service returns the key of the entity (3 fields) and not only the perfReviewId. Regards, Hans On Sun, 2011-01-16 at 17:19 +0100, Jacopo Cappellato wrote: Ah yes, I can recreate the same after taking an update: it is caused by your today changes (rev. 1059556), I guess you will be able to fix it on your own. Jacopo On Jan 16, 2011, at 5:16 PM, Jacopo Cappellato wrote: On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote: After adding a review one still has to go back to he find option, find the review again and then finally items can add be added. This is not what I can see in my local box, please have a second look. Jacopo -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
Re: New Flat Grey theme issues
Thanks Adrian, I just completly updated by hand, could you check please? Jacques From: Adrian Crum adrian.c...@yahoo.com I see a different problem with the trunk demo: https://demo-trunk.ofbiz.apache.org/example/control/ExampleLayoutDemo It appears the Java code was not compiled - because that's the error I got before I committed rev 1059425. -Adrian --- On Mon, 1/17/11, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, Some minor issues I found while playing with it Sometimes, from catalog main page at least, when you get out after choising another theme you get a broken catalog main page (missing footer but actually more than that). It does not reproduce locally :/ Locally the new Flat Grey theme comment reads Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional but on the demo trunk it's still the old one Flat Grey - Old OFBiz Standard Floating Layout, not sure why since it has been automatically svn updated and run-installed (I suspected it could be a language issue but turnedf from French to English and got the same) Jacques
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982627#action_12982627 ] Hans Bakker commented on OFBIZ-4120: what is the reason for supporting browser without javascript? I really do not see why you want to do that? Any modern browser supports it? Regards, Hans Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982628#action_12982628 ] Jacques Le Roux commented on OFBIZ-4120: I agree, I think we will finally end with your answer. It was an attempt to seriously answer to Adrian: http://markmail.org/message/qv2fay566mfr4zjq My conclusion is that w/out javascript currently OFBiz backend is screwed. So we should forget to try to make OFBiz running without it, it's too much work. I f you are interested you can (re?)-read the above thread Thanks Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982630#action_12982630 ] Jacques Le Roux commented on OFBIZ-4120: My initial idea was to let know users that javascript is required! Adrian was against, but I think there are simply no other reasonnable solutons... And I tried to demonstrate it, I think it's *done* Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1694) Content: NPE on Upload Image page for DataResource of mimetype application/pdf
[ https://issues.apache.org/jira/browse/OFBIZ-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982634#action_12982634 ] Sascha Rodekamp commented on OFBIZ-1694: Bug is *closed*, images can be upload successfully. The NPE seems so be fixed. Cheers Sascha Content: NPE on Upload Image page for DataResource of mimetype application/pdf -- Key: OFBIZ-1694 URL: https://issues.apache.org/jira/browse/OFBIZ-1694 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Release Branch 4.0 Environment: java 1.6, Fedora Core 8, OFBIZ Release Branch 4.0 Reporter: Bradley Plies Priority: Trivial Attachments: screenshot-1.jpg Running a demo instance of OFBIZ and peeking around the content application. While inspecting the DataResource DR1114 (Disclosure Agreement) and clicking on the Image link for Upload Image For: Disclosure Agreement [DR1114] got an NPE. Unable to duplicate with most other DataResource instances, seems to be mainly centered around mime type of application/pdf Trunk is probably affected too because no changes have been made to org.ofbiz.content.data.DataResourceWorker since the branch. source of DataResourceWorker..streamDataResource has a comment: // TODO: remove this method in favor of getDataResourceStream Probably a trivial fix runtime exception report -- Error in request handler: Exception: java.lang.NullPointerException Message: null stack trace --- java.lang.NullPointerException org.ofbiz.content.data.DataResourceWorker.streamDataResource(DataResourceWorker.java:1079) org.ofbiz.content.data.DataResourceWorker.getContentAsByteWrapper(DataResourceWorker.java:1128) org.ofbiz.content.view.SimpleContentViewHandler.render(SimpleContentViewHandler.java:100) org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:643) org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:427) org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:189) javax.servlet.http.HttpServlet.service(HttpServlet.java:595) javax.servlet.http.HttpServlet.service(HttpServlet.java:688) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) java.lang.Thread.run(Thread.java:619) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: New Flat Grey theme issues
That fixed it. Thanks Jacques! -Adrian --- On Mon, 1/17/11, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Thanks Adrian, I just completly updated by hand, could you check please? Jacques From: Adrian Crum adrian.c...@yahoo.com I see a different problem with the trunk demo: https://demo-trunk.ofbiz.apache.org/example/control/ExampleLayoutDemo It appears the Java code was not compiled - because that's the error I got before I committed rev 1059425. -Adrian --- On Mon, 1/17/11, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, Some minor issues I found while playing with it Sometimes, from catalog main page at least, when you get out after choising another theme you get a broken catalog main page (missing footer but actually more than that). It does not reproduce locally :/ Locally the new Flat Grey theme comment reads Flat Grey - Floating Layout, Sight-Impaired Accessible, Bidirectional but on the demo trunk it's still the old one Flat Grey - Old OFBiz Standard Floating Layout, not sure why since it has been automatically svn updated and run-installed (I suspected it could be a language issue but turnedf from French to English and got the same) Jacques
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982639#action_12982639 ] Adrian Crum commented on OFBIZ-4120: Hans, Some users prefer to leave JavaScript turned off for security and privacy reasons. Some organizations may require it to be turned off. Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982642#action_12982642 ] Adrian Crum commented on OFBIZ-4120: Jacques, It's great that you've consolidated the JavaScript issues under one task, but I don't think we need to make a special effort to accommodate users who have it turned off. From my perspective, as long as OFBiz detects if it is enabled and provides an indicator in the rendering context, then we've done our job. Like everything else in the project, those users who encounter problems using OFBiz with JavaScript turned off can provide patches to fix them. Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982644#action_12982644 ] Jacques Le Roux commented on OFBIZ-4120: Adrian, quoting you {quote} From my perspective, as long as OFBiz detects if it is enabled and provides an indicator in the rendering context, then we've done our job. {quote} Actually that's what I suggestged in the above thread, quoting myself {quote} This is user's problem not OFBiz's, we can't take care of all subtilities. But we should explain this to users. We could add an obivous (colored?) label in the header (javascript enabled). Then they should be aware and it's their responsabilites. {quote} I will go for that with the jQuery cookie solution and... voilà... Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;) Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1694) Content: NPE on Upload Image page for DataResource of mimetype application/pdf
[ https://issues.apache.org/jira/browse/OFBIZ-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982646#action_12982646 ] Jacques Le Roux commented on OFBIZ-1694: Sascha, this was only in release 4.0 I guess... Did you really try this version ;) ? Content: NPE on Upload Image page for DataResource of mimetype application/pdf -- Key: OFBIZ-1694 URL: https://issues.apache.org/jira/browse/OFBIZ-1694 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Release Branch 4.0 Environment: java 1.6, Fedora Core 8, OFBIZ Release Branch 4.0 Reporter: Bradley Plies Priority: Trivial Attachments: screenshot-1.jpg Running a demo instance of OFBIZ and peeking around the content application. While inspecting the DataResource DR1114 (Disclosure Agreement) and clicking on the Image link for Upload Image For: Disclosure Agreement [DR1114] got an NPE. Unable to duplicate with most other DataResource instances, seems to be mainly centered around mime type of application/pdf Trunk is probably affected too because no changes have been made to org.ofbiz.content.data.DataResourceWorker since the branch. source of DataResourceWorker..streamDataResource has a comment: // TODO: remove this method in favor of getDataResourceStream Probably a trivial fix runtime exception report -- Error in request handler: Exception: java.lang.NullPointerException Message: null stack trace --- java.lang.NullPointerException org.ofbiz.content.data.DataResourceWorker.streamDataResource(DataResourceWorker.java:1079) org.ofbiz.content.data.DataResourceWorker.getContentAsByteWrapper(DataResourceWorker.java:1128) org.ofbiz.content.view.SimpleContentViewHandler.render(SimpleContentViewHandler.java:100) org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:643) org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:427) org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:189) javax.servlet.http.HttpServlet.service(HttpServlet.java:595) javax.servlet.http.HttpServlet.service(HttpServlet.java:688) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) java.lang.Thread.run(Thread.java:619) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1694) Content: NPE on Upload Image page for DataResource of mimetype application/pdf
[ https://issues.apache.org/jira/browse/OFBIZ-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982648#action_12982648 ] Sascha Rodekamp commented on OFBIZ-1694: Ups nope ;) I tested on trunk ;) Content: NPE on Upload Image page for DataResource of mimetype application/pdf -- Key: OFBIZ-1694 URL: https://issues.apache.org/jira/browse/OFBIZ-1694 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Release Branch 4.0 Environment: java 1.6, Fedora Core 8, OFBIZ Release Branch 4.0 Reporter: Bradley Plies Priority: Trivial Attachments: screenshot-1.jpg Running a demo instance of OFBIZ and peeking around the content application. While inspecting the DataResource DR1114 (Disclosure Agreement) and clicking on the Image link for Upload Image For: Disclosure Agreement [DR1114] got an NPE. Unable to duplicate with most other DataResource instances, seems to be mainly centered around mime type of application/pdf Trunk is probably affected too because no changes have been made to org.ofbiz.content.data.DataResourceWorker since the branch. source of DataResourceWorker..streamDataResource has a comment: // TODO: remove this method in favor of getDataResourceStream Probably a trivial fix runtime exception report -- Error in request handler: Exception: java.lang.NullPointerException Message: null stack trace --- java.lang.NullPointerException org.ofbiz.content.data.DataResourceWorker.streamDataResource(DataResourceWorker.java:1079) org.ofbiz.content.data.DataResourceWorker.getContentAsByteWrapper(DataResourceWorker.java:1128) org.ofbiz.content.view.SimpleContentViewHandler.render(SimpleContentViewHandler.java:100) org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:643) org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:427) org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:189) javax.servlet.http.HttpServlet.service(HttpServlet.java:595) javax.servlet.http.HttpServlet.service(HttpServlet.java:688) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) java.lang.Thread.run(Thread.java:619) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)
Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
[jira] Updated: (OFBIZ-3877) New Web Service Style
[ https://issues.apache.org/jira/browse/OFBIZ-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joonas Keturi updated OFBIZ-3877: - Attachment: webservice.tar.bz2 patch with fixes related to wsdl-generation, and conflicts resolved with last trunk version. New Web Service Style - Key: OFBIZ-3877 URL: https://issues.apache.org/jira/browse/OFBIZ-3877 Project: OFBiz Issue Type: New Feature Components: framework Environment: Windows, Ubuntu Linux Reporter: Chatree Srichart Assignee: Hans Bakker Attachments: webservice.tar.bz2, webservice.zip This is a new stub for new web service style that use a normal style (not hash map [key/value]). [[ Installation ]] - Extract webservice.zip file (attached file) to hot-deploy directory of OFBiz framework - run ant task for apply patch in webservice directory with: ant reapply-ofbiz-patches [[ Features ]] 1.) New classes There is new important class org.ofbiz.webapp.webservice.event.WebServiceEventHandler which corresponds to earlier org.ofbiz.webapp.event.SOAPEventHandler but tries to support document style web services using SOAP with XML-format, or REST with XML and JSON-formats. This handler class uses other class: org.ofbiz.service.webservice.WebServiceModel which wraps inside class org.ofbiz.service.ModelService and contains support for WSDL-generation, WADL-generation and conversion between Java Maps and XML-object models. WSDL=Web Service Definition Language for SOAP-interface http://www.w3.org/TR/wsdl WADL=Web Application Description Language for REST-interface http://www.w3.org/Submission/wadl/ There is another new important class org.ofbiz.service.webservice.engine.WebServiceClientEngine which corresponds to earlier org.ofbiz.service.engine.SOAPClientEngine but tries to support document style web services using SOAP with XML-format. Web services can be called using their WSDL-document or messages can be specified in services.xml without using WSDL-document. engine-attribute in services description is set to webservice. Location of WSDL-document is given in attribute wsdlLocation or it can be left out if messages are described with attribute- definitions. Name of service in WSDL is given in attribute webServiceName and name of operation to be invoked in attribute invoke. One service-definition is needed for one web service-operation pair. Example of web service definitions are in file: framework/common/servicedef/services_test.xml This engine class uses other class: org.ofbiz.service.webservice.WebServiceClientModel which extends org.ofbiz.service.webservice.WebServiceModel and contains support for filling attribute definitions in org.ofbiz.service.ModelService from WSDL-document. 2.) Service definitions Web service interface can be used only if service definition file services.xml is completed with additional definitions. Schema of this file is extended. attribute-elements can have nested attribute elements which describe structure of Java maps and lists. If attribute has type Map, it should have nested attributes which describe contents of this map. If attribute has type List, it should have nested attributes which describe element contents of this list. If List has simple elements, there must be only one nested attribute, which describes element. If List has element which is map or other list, there must be one nested attribute stating that the element is Map or List, and then this attribute should have nested attributes describing structure of Map or structure of list element. There are also two new modes for attributes ERROR which means that attribute is responded as error message OUTERROR which means that attribute is responded as error or as success message These modes are needed for web services to describe which parameters will go to detail-elements of SOAP Fault response or REST error messages. Also in WSDL- and WADL-files will be generated XML-schema for general response messages. File framework\webapp\servicedef\services_test.xml can be used as example of attribute definitions. This file is used in unit tests of web service interface. 3.) Web service requests In REST-services HTTP GET-method is used in services whose name start with words find or get. These services should have input parameters in one level, so that they can be given as query parameters in URL. HTTP DELETE-method is used with services whose name start with word remove. Other services are used with HTTP POST-method and PUT-method. Service must look itself for method name POST or PUT, if it is required to operate differently in insert or update cases. List of links to all WSDL-documents can be requested with URL: /webtools/control/WebService?wsdl Specific WSDL-document is requested with URL:
[jira] Closed: (OFBIZ-1694) Content: NPE on Upload Image page for DataResource of mimetype application/pdf
[ https://issues.apache.org/jira/browse/OFBIZ-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1694. -- Resolution: Won't Fix Closing: It's too old an nobody seems to have been sufficiently interested to provide a patch. If someone has a patch please feel free to reopen... Content: NPE on Upload Image page for DataResource of mimetype application/pdf -- Key: OFBIZ-1694 URL: https://issues.apache.org/jira/browse/OFBIZ-1694 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Release Branch 4.0 Environment: java 1.6, Fedora Core 8, OFBIZ Release Branch 4.0 Reporter: Bradley Plies Priority: Trivial Attachments: screenshot-1.jpg Running a demo instance of OFBIZ and peeking around the content application. While inspecting the DataResource DR1114 (Disclosure Agreement) and clicking on the Image link for Upload Image For: Disclosure Agreement [DR1114] got an NPE. Unable to duplicate with most other DataResource instances, seems to be mainly centered around mime type of application/pdf Trunk is probably affected too because no changes have been made to org.ofbiz.content.data.DataResourceWorker since the branch. source of DataResourceWorker..streamDataResource has a comment: // TODO: remove this method in favor of getDataResourceStream Probably a trivial fix runtime exception report -- Error in request handler: Exception: java.lang.NullPointerException Message: null stack trace --- java.lang.NullPointerException org.ofbiz.content.data.DataResourceWorker.streamDataResource(DataResourceWorker.java:1079) org.ofbiz.content.data.DataResourceWorker.getContentAsByteWrapper(DataResourceWorker.java:1128) org.ofbiz.content.view.SimpleContentViewHandler.render(SimpleContentViewHandler.java:100) org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:643) org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:427) org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:189) javax.servlet.http.HttpServlet.service(HttpServlet.java:595) javax.servlet.http.HttpServlet.service(HttpServlet.java:688) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248) org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) java.lang.Thread.run(Thread.java:619) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982705#action_12982705 ] Jacques Le Roux commented on OFBIZ-4121: I think it's possible using http://download.oracle.com/javase/6/docs/technotes/guides/scripting/programmer_guide/index.html#evalfile? We need to load jQuery and the cookie plugin before. So we would need to have the last jquery version concatened with the last version of the cookie plugin (we have them at hand) and after an expression like jQuery.cookie(javascripEnabled, just testing, { path: '/' } concatened. It should work, we have then to test if the cookie has just been created. Seems doable, to be revisited... Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982742#action_12982742 ] Adrian Crum commented on OFBIZ-4121: Jacques, How would this method be any different than the one we use now? You're still running a script that works only when JavaScript is enabled. Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)
That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer. Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote: Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982762#action_12982762 ] Ryan Foster commented on OFBIZ-4092: The _MACOSX folder is a hidden system folder for Apple. Not necessary. Feel free to blow that away. My original intent was actually to create a generic login screen style, similar to the way the BizznessTime theme, but that task got lost in the shuffle. I'll see if I can get you a new patch that addresses that within the next couple of days. All in all, I think everything looks great. I look forward to community feedback. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982763#action_12982763 ] Jacques Le Roux commented on OFBIZ-4121: Now it's arbitrary, it's set on an URL when login but does not determine really if javascript is enabled (usable actually) or not. The code is (LoginWorker.login[450...]) {code} // check on JavaScriptEnabled String javaScriptEnabled = N; if (Y.equals(request.getParameter(JavaScriptEnabled))) { javaScriptEnabled = Y; } {code} With the change above, we will now if we can really use javascript or not (test: can we create a cookie using javacscript and check it's there locally still using javascript). BTW there is maybe an easier way than creating a local cookie, just a quick test with an exception? Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982764#action_12982764 ] Jacques Le Roux commented on OFBIZ-4121: We will then be able to inform the user about it by a way or another Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)
Ryan Foster wrote: That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer. That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk... Jacques Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote: Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982776#action_12982776 ] Adrian Crum commented on OFBIZ-4121: The script in the login screen is what I was referring to. If JavaScript is turned off, the JavaScriptEnabled field will not be set to Y. It's an easy way to determine if JavaScript is enabled. If a user has JavaScript enabled, then JavaScriptEnabled=Y will be added to the login request URL. That is why you need to include it in any URL that bypasses the login screen. Setting a cookie and then testing its existence is another way to do the same thing, but It's not any easier. Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982778#action_12982778 ] Bruno Busco commented on OFBIZ-4092: This new Flat grey theme looks really good! Thank you guys. Update The Flat Grey Visual Theme - Key: OFBIZ-4092 URL: https://issues.apache.org/jira/browse/OFBIZ-4092 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png Update the Flat Grey visual theme. Design objectives: 1. Floating, flexible layout - screen can be resized. 2. Sight impaired accessible - users can change font size in their browser. 3. Supports RTL layout. 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4121. -- Resolution: Not A Problem Ho, I think I know why now (though I was not able to reproduce). I was logging using this URL https://localhost:28443/catalog/control/login?USERNAME=adminPASSWORD=ofbiz, so I guess maybe I was bypassing the login screen hence the JavaScriptEnabled initialisation... Forget it :) Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4120: --- Description: By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier for users than wih javascript. (was: By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript. The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available) Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier for users than wih javascript. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Updated Flat Grey Visual Theme
Jacques, If you're asking why JavaScript isn't used to create user preference drop-down menus, then the answer is in the Design Objectives listed in the Jira issue. -Adrian On 1/17/2011 10:07 AM, Jacques Le Roux wrote: Ryan Foster wrote: That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer. That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk... Jacques Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote: Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982784#action_12982784 ] Jacques Le Roux commented on OFBIZ-4120: I guess I was a bit wrong in my assumptions, since I missed the script at the end of login.ftl files (do we really need more than one?). But it's still true that collapsing screenlets were working without js in R4.0 so was (and is still in Order Manager and eCommerce, lack of consistency) the categories tree in R10.04 and we should switch on JavaScriptEnabled using the old way rather than nothing. For the Help we should at least have something, but I for all the FTL using javascript for security reasons (no parameters in URL to avoid XSS) I guess we have no solutions, so yes all I did is maybe a waste of time :( Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier for users than wih javascript. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982786#action_12982786 ] Jacques Le Roux commented on OFBIZ-4120: Since a lot of actions are not availablke without js enabled, should we not warn the user about it? If we are OK on this I will close all the tasks here since we can't avoid the FTL issues (OFBIZ-2330). Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier for users than wih javascript. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982787#action_12982787 ] Adrian Crum commented on OFBIZ-4121: I agree that it would be helpful to let the user know they will have a better experience if JavaScript is enabled. That information and other helpful tips could be in a Help page that is accessed via the Help link on the Login page. Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982804#action_12982804 ] Jacques Le Roux commented on OFBIZ-4121: So we need to create a specific Help link on the login screen (because the Online Help needs javascript) . Can we simply put a small sentence there? and maybe in the header or footer (if javascript is disabled else nothing) Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Updated Flat Grey Visual Theme
No no, only why those information are in the footer when they are in the header for all other themes (also see my comment about time zone missing) Jacques Adrian Crum wrote: Jacques, If you're asking why JavaScript isn't used to create user preference drop-down menus, then the answer is in the Design Objectives listed in the Jira issue. -Adrian On 1/17/2011 10:07 AM, Jacques Le Roux wrote: Ryan Foster wrote: That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer. That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk... Jacques Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote: Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982818#action_12982818 ] Adrian Crum commented on OFBIZ-4121: Actually, that Help link needs its own Jira issue. You can't view the Help page without being already logged in. Plus, it would preferable if JavaScript wasn't required to get basic help when logging in. Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully
[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982832#action_12982832 ] BJ Freeman commented on OFBIZ-4120: --- guess I am the lonely decenter I had to turn on my browser java script to see what I was missing. looks like I will have to do more manual appliation of commits from now on. why do I keep the JS off a lot of sites are showing up that use js to override pop ups and install applications that are usually viruses or trojans. Umbrella task for features which use javascript to degrade gracefully -- Key: OFBIZ-4120 URL: https://issues.apache.org/jira/browse/OFBIZ-4120 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier for users than wih javascript. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)
I guess it really just comes down to the approach. The objective of the task was to update the Flat Grey theme. So, I approached the design as a realign rather than a redesign. I did not look at any other themes as examples, I simply focused on how Flat Grey looked and functioned and then tried to make the smallest amount of CSS and markup changes possible in order to achieve the objective and stay with the scope of the task. I understand your bias, because I have it as well, as probably every other active OFBiz developer does. But for the average user, the vast majority are going to select one language, one time zone, and one theme and then never touch this section again. Also, for a developer deploying OFBiz across a large organization, they may even decide to set these preferences globally across the entire organization and not allow the user to have these selections. In that case, it becomes much easier for them because they can simply disable the footer in the theme and it does not affect anything else at all. Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 11:07 AM, Jacques Le Roux wrote: Ryan Foster wrote: That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer. That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk... Jacques Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote: Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)
Yes that makes sense. And anyway if they prefer another theme they have now the choice. It's ok with me Jacques Ryan Foster wrote: I guess it really just comes down to the approach. The objective of the task was to update the Flat Grey theme. So, I approached the design as a realign rather than a redesign. I did not look at any other themes as examples, I simply focused on how Flat Grey looked and functioned and then tried to make the smallest amount of CSS and markup changes possible in order to achieve the objective and stay with the scope of the task. I understand your bias, because I have it as well, as probably every other active OFBiz developer does. But for the average user, the vast majority are going to select one language, one time zone, and one theme and then never touch this section again. Also, for a developer deploying OFBiz across a large organization, they may even decide to set these preferences globally across the entire organization and not allow the user to have these selections. In that case, it becomes much easier for them because they can simply disable the footer in the theme and it does not affect anything else at all. Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 11:07 AM, Jacques Le Roux wrote: Ryan Foster wrote: That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer. That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk... Jacques Ryan L. Foster 801.671.0769 cont...@ryanlfoster.com ryanlfoster.com On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote: Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content. -Adrian --- On Mon, 1/17/11, Jacques Le Roux (JIRA) j...@apache.org wrote: Also I asked {quote} BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me {quote} Any answers? ;)
[jira] Commented: (OFBIZ-4121) Determine if javascript is available using jQuery cookie plugin
[ https://issues.apache.org/jira/browse/OFBIZ-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983037#action_12983037 ] Jacques Le Roux commented on OFBIZ-4121: Adrian, It's not really about better experience. We should warn them that w/out js they will not be able to achieve some of their goals. There are 444 calls of a href=javascript: in FTL files. Not all are mandatory (for instance you don't need a lookup to fill a field, same for calendar). But I doubt that in certain cases you can seriously do it without lookups for instance. For security reasons there are 248 actions which needs javascript: in FTL files (ie javascript is mandatory for those actions to work). Just look for a href=javascript:document. in *.ftl... There are 1353 occurences of the word javascript at all in FTL files, 343 in XML files but there I think it's rarely mandatory. So I really think it's now wishful thinking to hope using OFBIz w/out js enabled... Determine if javascript is available using jQuery cookie plugin --- Key: OFBIZ-4121 URL: https://issues.apache.org/jira/browse/OFBIZ-4121 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascript or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4125) Quick jump option in Catalog Main
[ https://issues.apache.org/jira/browse/OFBIZ-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4125. -- Resolution: Won't Fix I really think it's now wishful thinking to hope using OFBIz w/out js enabled. This is the reason why I decided to forget about all this and to close this subtask Quick jump option in Catalog Main - Key: OFBIZ-4125 URL: https://issues.apache.org/jira/browse/OFBIZ-4125 Project: OFBiz Issue Type: Sub-task Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, SVN trunk Reporter: Jacques Le Roux It's the dropdown entitled - Product Jump -. Seems it has never(?) worked w/out js. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4126) Online Help
[ https://issues.apache.org/jira/browse/OFBIZ-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4126. -- Resolution: Won't Fix Fix Version/s: (was: Release Branch 10.04) (was: SVN trunk) I really think it's now wishful thinking to hope using OFBIz w/out js enabled. This is the reason why I decided to forget about all this and to close this subtask Online Help --- Key: OFBIZ-4126 URL: https://issues.apache.org/jira/browse/OFBIZ-4126 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4123) Collapsing servlet
[ https://issues.apache.org/jira/browse/OFBIZ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4123. -- Resolution: Won't Fix Assignee: Jacques Le Roux I really think it's now wishful thinking to hope using OFBIz w/out js enabled. This is the reason why I decided to forget about all this and to close this subtask Collapsing servlet -- Key: OFBIZ-4123 URL: https://issues.apache.org/jira/browse/OFBIZ-4123 Project: OFBiz Issue Type: Sub-task Affects Versions: Release Branch 09.04, Release Branch 10.04, SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Example: Search Products panel in Catalog/Main. This was working in R4.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4124) Catalogs/Categories tree in Main Catalog screen
[ https://issues.apache.org/jira/browse/OFBIZ-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4124. -- Resolution: Won't Fix I really think it's now wishful thinking to hope using OFBIz w/out js enabled. This is the reason why I decided to forget about all this and to close this subtask Catalogs/Categories tree in Main Catalog screen --- Key: OFBIZ-4124 URL: https://issues.apache.org/jira/browse/OFBIZ-4124 Project: OFBiz Issue Type: Sub-task Affects Versions: SVN trunk Reporter: Jacques Le Roux Only trunk has this problem since http://svn.apache.org/viewvc?rev=1055790view=rev. I recommend to switch to the old way when javascript is not usable -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1319) Split javascript files to have more generic ones includ-able in all screens, and the more specific ones included more locally
[ https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983046#action_12983046 ] Jacques Le Roux commented on OFBIZ-1319: Adrian, I guess you already read my comments about that in the related tasks I just closed. But for those interesed and record fo the future here is a summary: There are 444 calls of a href=javascript: in FTL files. Not all are mandatory (for instance you don't need a lookup to fill a field, same for calendar). But I doubt that in certain cases you can seriously do it without lookups for instance. For security reasons there are 248 actions which needs javascript: in FTL files (ie javascript is mandatory for those actions to work). Just look for a href=javascript:document. in *.ftl... There are 1353 occurences of the word javascript at all in FTL files, 343 in XML files but I think it's rarely mandatory there. So I really think it's now wishful thinking to hope using OFBIz w/out js enabled, 248 impossible and needed actions can't be forgotten. See OFBIZ-2330 to know more... Split javascript files to have more generic ones includ-able in all screens, and the more specific ones included more locally - Key: OFBIZ-1319 URL: https://issues.apache.org/jira/browse/OFBIZ-1319 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk From a David's E. Jones comment on ML : Weshould split up javascript files to have the more generic ones includ-able in all screens, and the more specific ones (like the toggle* and selectAll* methods in there) into a file that can be included more locally. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4122) Duplicate view map entry in controller.
[ https://issues.apache.org/jira/browse/OFBIZ-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4122. -- Resolution: Fixed Fix Version/s: (was: Release Branch 10.04) Assignee: Jacques Le Roux Thanks Ankit, Your patch is in trunk at r1060220, I did not backport as it's not breaking anything Duplicate view map entry in controller. --- Key: OFBIZ-4122 URL: https://issues.apache.org/jira/browse/OFBIZ-4122 Project: OFBiz Issue Type: Bug Components: commonext/setup Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ_4122.patch Duplicate view map entry in the controller . view-map name=EditProductStore type=screen page=component://commonext/widget/ofbizsetup/SetupScreens.xml#EditProductStore/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4119. -- Resolution: Invalid Assignee: Jacques Le Roux Hi Ankit, Actually there is a reason to this hidden field, please read http://markmail.org/message/cxofqfvhfrianu6e Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4119: Ha sorry Ankit, I was abused by the title and forgot the id case. I will commit this part soon... Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.