[GitHub] [phoenix-thirdparty] stoty commented on a diff in pull request #6: PHOENIX-6771 Allow only "squash and merge" from GitHub UI
stoty commented on code in PR #6: URL: https://github.com/apache/phoenix-thirdparty/pull/6#discussion_r946644709 ## .asf.yaml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This file controls the integration of the Phoenix-thirdpary repo with ASF Review Comment: Thank you, done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty commented on a diff in pull request #6: PHOENIX-6771 Allow only "squash and merge" from GitHub UI
stoty commented on code in PR #6: URL: https://github.com/apache/phoenix-thirdparty/pull/6#discussion_r946644709 ## .asf.yaml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This file controls the integration of the Phoenix-thirdpary repo with ASF Review Comment: Thank you, I've rewritten to that in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] richardantal commented on a diff in pull request #6: PHOENIX-6771 Allow only "squash and merge" from GitHub UI
richardantal commented on code in PR #6: URL: https://github.com/apache/phoenix-thirdparty/pull/6#discussion_r946622496 ## .asf.yaml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This file controls the integration of the Phoenix-thirdpary repo with ASF Review Comment: Phoenix-thirdpary could be without dash like on the others, but it is fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
gjacoby126 commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r946078799
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
-&& CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+&& PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
@Aarchy - in general we've been trying to replace uses of KeyValue in
Phoenix and its related projects with Cell and its related public interfaces
like CellUtil where possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 merged pull request #113: OMID-228 Upgrade snakeyaml
gjacoby126 merged PR #113: URL: https://github.com/apache/phoenix-omid/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 merged pull request #112: OMID-227 Upgrade jcommander
gjacoby126 merged PR #112: URL: https://github.com/apache/phoenix-omid/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r945523712
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
-&& CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+&& PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
Yes.
If you need to copy some code from the IA.Private classes, please add a
comment to the copied code that explains why it was copied, and where is the
original code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] Aarchy commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
Aarchy commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r945500706
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
-&& CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+&& PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
I agree that InterfaceAudience.Private methods should be avoided.
Nonetheless, I used it here because the class already has a KeyValue field
which is also InterfaceAudience.Private.
An alternative solution could be to use Cell instead of KeyValue, and maybe
CellUtil.matchingRows(Cell, Cell) instead of this call. How do you think? How
should line 73 be changed in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
stoty commented on code in PR #111: URL: https://github.com/apache/phoenix-omid/pull/111#discussion_r945433122 ## pom.xml: ## @@ -168,7 +168,7 @@ 0.6.1 1.6.2 4.13.1 -1.10.19 +2.28.2 Review Comment: nit: AFAIK the mockito libraries have a single common version, we could keep using mockito.version as the property name, even if we only pull mockito-core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #108: OMID-224 Switch default logging backend to log4j2
stoty closed pull request #108: OMID-224 Switch default logging backend to log4j2 URL: https://github.com/apache/phoenix-omid/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #108: OMID-224 Switch default logging backend to log4j2
stoty commented on PR #108: URL: https://github.com/apache/phoenix-omid/pull/108#issuecomment-1214627742 Yes, @apurtell , the only log4j dependencies are the test/runtime log4j2 dependencies for tests and benchmarks, examples, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] apurtell opened a new pull request, #113: OMID-228 Upgrade snakeyaml
apurtell opened a new pull request, #113: URL: https://github.com/apache/phoenix-omid/pull/113 Some snakeyaml versions are no the Snyk naught list. See https://security.snyk.io/package/maven/org.yaml:snakeyaml Upgrade it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] apurtell opened a new pull request, #112: OMID-227 Upgrade jcommander
apurtell opened a new pull request, #112: URL: https://github.com/apache/phoenix-omid/pull/112 Some jcommander versions are on the Snyk naughty list. https://security.snyk.io/package/maven/com.beust:jcommander Upgrade it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] apurtell commented on pull request #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
apurtell commented on PR #111: URL: https://github.com/apache/phoenix-omid/pull/111#issuecomment-1213418408 All unit tests passed for me locally before I pushed this up. Phoenix itself is using mockito-core 1.x and should align with HBase, which is using 2.28.2 on branch-2.4 and branch-2.5, but this is out of scope of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] apurtell opened a new pull request, #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
apurtell opened a new pull request, #111: URL: https://github.com/apache/phoenix-omid/pull/111 At some point OMID will upgrade to latest Hadoop 2.10 and HBase 2.4 releases and will then experience IncompatibleClassChangeErrors in unit tests due to a conflict between mockito-all used here and mockito-core used by Hadoop, HBase, and Phoenix. Prepare for this by migrating from mockito-all to mockito-core now. Update matchers in some unit tests for minor differences in mocking and matching behavior after the migration. Clean up test dependency declarations in POMs while at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] apurtell closed pull request #110: OMID-225 Migrate from log4j1 to reload4j
apurtell closed pull request #110: OMID-225 Migrate from log4j1 to reload4j URL: https://github.com/apache/phoenix-omid/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] apurtell opened a new pull request, #110: OMID-225 Migrate from log4j1 to reload4j
apurtell opened a new pull request, #110: URL: https://github.com/apache/phoenix-omid/pull/110 Log4J1 is abandoned and has a number of significant CVEs filed for it. [Reload4J](https://reload4j.qos.ch) is a drop in binary compatible replacement for Log4J1 with all known security issues remediated. Move up `hbase.version` to 2.4.13 and `hadoop.version` to 2.10.2 because those downstream versions have also migrated from log4j1 to reload4j. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940369614
##
common/src/main/java/org/apache/omid/YAMLUtils.java:
##
@@ -64,7 +64,6 @@ public Map loadSettings(String resourcePath, String
defaultResourcePath) throws
return defaultSetting;
}
-@SuppressWarnings("unchecked")
Review Comment:
If removing it doesn't cause a warning, the we should, if it does, we should
keep it.
I haven't checked if it's really needed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
stoty commented on code in PR #109: URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940365337 ## pom.xml: ## @@ -158,7 +158,7 @@ 2.0.0 3.0 6.10 -1.7.36 +1.7.30 Review Comment: Agree, we want the latest version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940355736
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
-&& CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+&& PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
Don't use PrivateCellUtil anywhere, it's InterfaceAudience.Private.
Use the methods in the Public CellUtil.
##
hbase-commit-table/src/main/java/org/apache/omid/committable/hbase/HBaseCommitTable.java:
##
@@ -144,7 +145,10 @@ public boolean atomicAddCommittedTransaction(long
startTimestamp, long commitTim
Put put = new Put(transactionRow, startTimestamp);
byte[] value = encodeCommitTimestamp(startTimestamp,
commitTimestamp);
put.addColumn(commitTableFamily, COMMIT_TABLE_QUALIFIER,
value);
-return table.checkAndPut(transactionRow, commitTableFamily,
INVALID_TX_QUALIFIER, null, put);
+CheckAndMutate checkAndPut =
CheckAndMutate.newBuilder(transactionRow)
+.ifEquals(commitTableFamily, INVALID_TX_QUALIFIER,
null)
Review Comment:
While this is correct, using the new ifNotExist() method would more
descriptive.
The same applies to the other ifEquals(null) calls.
##
hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestCompactorScanner.java:
##
@@ -67,7 +67,7 @@ public void
testShouldRetainNonTransactionallyDeletedCellMethod(int optionIdx, b
RegionCoprocessorEnvironment rce =
mock(RegionCoprocessorEnvironment.class);
HRegion hRegion = mock(HRegion.class);
-HRegionInfo hRegionInfo = mock(HRegionInfo.class);
+RegionInfo hRegionInfo = mock(RegionInfo.class);
Review Comment:
Renaming the variable to match the type would make it easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] richardantal commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
richardantal commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r937688092
##
common/src/main/java/org/apache/omid/YAMLUtils.java:
##
@@ -64,7 +64,6 @@ public Map loadSettings(String resourcePath, String
defaultResourcePath) throws
return defaultSetting;
}
-@SuppressWarnings("unchecked")
Review Comment:
Why don't we remove the @SuppressWarnings("unchecked") from line number 56?
Maybe @stoty knows it better.
##
pom.xml:
##
@@ -158,7 +158,7 @@
2.0.0
3.0
6.10
-1.7.36
+1.7.30
Review Comment:
I guess it is an unintentional change during rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.
stoty commented on PR #109: URL: https://github.com/apache/phoenix-omid/pull/109#issuecomment-1208221678 Thre are still some deprecation warnings: ``` [WARNING] /home/stoty/workspaces/apache-phoenix/omid/statemachine/src/main/java/org/apache/statemachine/StateMachine.java:[246,24] finalize() in java.lang.Object has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/statemachine/src/main/java/org/apache/statemachine/StateMachine.java:[247,18] finalize() in java.lang.Object has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java:[311,67] getTypeByte() in org.apache.hadoop.hbase.Cell has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java:[340,33] getSequenceId() in org.apache.hadoop.hbase.Cell has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java:[340,62] getSequenceId() in org.apache.hadoop.hbase.Cell has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-common/src/main/java/org/apache/omid/committable/hbase/RegionSplitter.java:[170,63] newInstance() in java.lang.Class has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/tso-server/src/main/java/org/apache/omid/tso/LeaseManager.java:[25,32] org.apache.curator.utils.EnsurePath in org.apache.curator.utils has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/tso-server/src/main/java/org/apache/omid/tso/LeaseManager.java:[281,9] org.apache.curator.utils.EnsurePath in org.apache.curator.utils has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/tso-server/src/main/java/org/apache/omid/tso/LeaseManager.java:[281,35] newNamespaceAwareEnsurePath(java.lang.String) in org.apache.curator.framework.CuratorFramework has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/tso-server/src/test/java/org/apache/omid/TestUtils.java:[90,24] closeQuietly(java.net.Socket) in org.apache.commons.io.IOUtils has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/tso-server/src/test/java/org/apache/omid/TestUtils.java:[107,24] closeQuietly(java.net.Socket) in org.apache.commons.io.IOUtils has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-client/src/main/java/org/apache/omid/transaction/TTable.java:[295,54] getTypeByte() in org.apache.hadoop.hbase.Cell has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-client/src/main/java/org/apache/omid/transaction/TTable.java:[370,43] ensureKeyValue(org.apache.hadoop.hbase.Cell) in org.apache.hadoop.hbase.KeyValueUtil has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-client/src/main/java/org/apache/omid/transaction/TTable.java:[419,43] ensureKeyValue(org.apache.hadoop.hbase.Cell) in org.apache.hadoop.hbase.KeyValueUtil has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java:[491,55] COMPARATOR in org.apache.hadoop.hbase.KeyValue has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-client/src/test/java/org/apache/omid/transaction/TestTransactionCleanup.java:[111,76] getTypeByte() in org.apache.hadoop.hbase.Cell has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-client/src/test/java/org/apache/omid/transaction/TestTxMgrFailover.java:[153,44] getTypeByte() in org.apache.hadoop.hbase.Cell has been deprecated [WARNING] /home/stoty/workspaces/apache-phoenix/omid/hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/regionserver/CompactorScanner.java:[168,61] COMPARATOR in org.apache.hadoop.hbase.KeyValue has been deprecated ``` While some of those are not HBase related, this would be a great opportunity to clean all of them up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #108: OMID-224 Switch default logging backend to log4j2
stoty commented on code in PR #108: URL: https://github.com/apache/phoenix-omid/pull/108#discussion_r939812812 ## hbase-commit-table/pom.xml: ## @@ -112,13 +117,32 @@ curator-test test + + + + + +org.apache.logging.log4j +log4j-api +test + + +org.apache.logging.log4j +log4j-core +test + -org.apache.zookeeper -zookeeper Review Comment: It was never needed in that module. TBH dependencies are stil a mess in Omid. We SHOULD depend on ZK in _timestamp-storage_ , and _tso-server_ but the dependency was never defined there. We also define a ZK version properrty in the top pom that we don't use now, and have never used properly. At some point, we should clean up the dependencies and add maven-dependency-plugin check. Now we're effectively using whatever ZK version the HBase version we're building with is pulling in, which should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #108: OMID-224 Switch default logging backend to log4j2
gjacoby126 commented on code in PR #108: URL: https://github.com/apache/phoenix-omid/pull/108#discussion_r939545022 ## hbase-commit-table/pom.xml: ## @@ -112,13 +117,32 @@ curator-test test + + + + + +org.apache.logging.log4j +log4j-api +test + + +org.apache.logging.log4j +log4j-core +test + -org.apache.zookeeper -zookeeper Review Comment: Is the zookeeper reference not needed anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty opened a new pull request, #108: OMID-224 Switch default logging backend to log4j2
stoty opened a new pull request, #108: URL: https://github.com/apache/phoenix-omid/pull/108 Replace logging config based on HBase Change logging configuration for tso-server to match the HBase setup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] dependabot[bot] opened a new pull request, #115: Bump libthrift from 0.9.3-1 to 0.14.0
dependabot[bot] opened a new pull request, #115:
URL: https://github.com/apache/phoenix-tephra/pull/115
Bumps [libthrift](https://github.com/apache/thrift) from 0.9.3-1 to 0.14.0.
Release notes
Sourced from https://github.com/apache/thrift/releases;>libthrift's
releases.
Version 0.14.0
For release 0.14.0 head over to the official release download source:
http://thrift.apache.org/download;>http://thrift.apache.org/download
The assets below are added by Github based on the release tag and they
may therefore not match the checkums.
Version 0.13.0
For release 0.13.0 head over to the official release download source:
http://thrift.apache.org/download;>http://thrift.apache.org/download
The assets below are added by Github based on the release tag and they
may therefore not match the checkums.
Version 0.12.0
Apache Thrift Release 0.12.0
Version 0.9.3.1
This release is a backport of the security fix for https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-1320;>CVE-2018-1320
as documented in https://issues.apache.org/jira/browse/THRIFT-4506;>THRIFT-4506. The
only code change is in Java, and a 0.9.3-1 package was released to https://search.maven.org/search?q=g:org.apache.thrift%20AND%20a:libthriftcore=gav;>Maven
Central.
This is marked in GitHub as a pre-release so that it does not become the
latest release.
Changelog
Sourced from https://github.com/apache/thrift/blob/master/CHANGES.md;>libthrift's
changelog.
0.14.0
Deprecated Languages
https://issues.apache.org/jira/browse/THRIFT-5229;>THRIFT-5229 -
Deprecate ActionScript 3 support
Removed Languages
https://issues.apache.org/jira/browse/THRIFT-4980;>THRIFT-4980 -
Remove deprecated C# and netcore bindings from the code base
https://issues.apache.org/jira/browse/THRIFT-4981;>THRIFT-4981 -
Remove deprecated netcore bindings from the code base
https://issues.apache.org/jira/browse/THRIFT-4982;>THRIFT-4982 -
Remove deprecated C# bindings from the code base
Breaking Changes
https://issues.apache.org/jira/browse/THRIFT-4981;>THRIFT-4981 -
Remove deprecated netcore bindings from the code base
https://issues.apache.org/jira/browse/THRIFT-4982;>THRIFT-4982 -
Remove deprecated csharp bindings from the code base
https://issues.apache.org/jira/browse/THRIFT-4990;>THRIFT-4990 -
Upgrade to .NET Core 3.1 (LTS)
https://issues.apache.org/jira/browse/THRIFT-5006;>THRIFT-5006 -
Implement DEFAULT_MAX_LENGTH at TFramedTransport
https://issues.apache.org/jira/browse/THRIFT-5069;>THRIFT-5069 - In
Go library TDeserializer.Transport is now typed *TMemoryBuffer instead of
TTransport
https://issues.apache.org/jira/browse/THRIFT-5072;>THRIFT-5072 -
Haskell generator fails to distinguish between multiple enum types with
conflicting enum identifiers
https://issues.apache.org/jira/browse/THRIFT-5116;>THRIFT-5116 -
Upgrade NodeJS to 10.x
https://issues.apache.org/jira/browse/THRIFT-5138;>THRIFT-5138 -
Swift generator does not escape keywords properly
https://issues.apache.org/jira/browse/THRIFT-5164;>THRIFT-5164 - In
Go library TProcessor interface now includes ProcessorMap and AddToProcessorMap
functions.
https://issues.apache.org/jira/browse/THRIFT-5186;>THRIFT-5186 - cpp:
use all getaddrinfo() results when retrying failed bind() in
T{Nonblocking,}ServerSocket
https://issues.apache.org/jira/browse/THRIFT-5233;>THRIFT-5233 - go:
Now all Read*, Write* and Skip functions in TProtocol accept context arg
https://issues.apache.org/jira/browse/THRIFT-5152;>THRIFT-5152 - go:
TSocket and TSSLSocket now have separated connect timeout and socket
timeout
c++: dropped support for Windows XP
https://issues.apache.org/jira/browse/THRIFT-5326;>THRIFT-5326 - go:
TException interface now has a new function: TExceptionType
https://issues.apache.org/jira/browse/THRIFT-4914;>THRIFT-4914 - go:
TClient.Call now returns ResponseMeta in addition to error
Known Open Issues (Blocker or Critical)
https://issues.apache.org/jira/browse/THRIFT-3877;>THRIFT-3877 - C++:
library don't work with HTTP (csharp server, cpp client; need cross test
enhancement)
https://issues.apache.org/jira/browse/THRIFT-5098;>THRIFT-5098 -
Deprecated: The high level Network interface is no longer supported.
Please use Network.Socket. and other Haskell issues
https://issues.apache.org/jira/browse/THRIFT-5245;>THRIFT-5245 - NPE
when the value of map's key is null
https://issues.apache.org/jira/browse/THRIFT-4687;>THRIFT-4687 - Add
thrift 0.12.0 to pypi and/or enable more maintainers
Build Process
https://issues.apache.org/jira/browse/THRIFT-4976;>THRIFT-4976 -
Docker build: Test failure for StalenessCheckTest on MacOS
https://issues.apache.org/jira/browse/THRIFT-5087;>THRIFT-5087 -
test/test.py fails with AssertionError: Python 3.3 or later is required
for proper operation.
[GitHub] [phoenix-omid] dependabot[bot] opened a new pull request, #107: Bump hadoop-yarn-server-common from 2.10.0 to 2.10.2
dependabot[bot] opened a new pull request, #107: URL: https://github.com/apache/phoenix-omid/pull/107 Bumps hadoop-yarn-server-common from 2.10.0 to 2.10.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/phoenix-omid/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] dependabot[bot] opened a new pull request, #106: Bump hadoop-common from 2.10.0 to 3.2.3
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/phoenix-omid/pull/106 Bumps hadoop-common from 2.10.0 to 3.2.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/phoenix-omid/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty closed pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4 URL: https://github.com/apache/phoenix-omid/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1157352943 Fixed both versions, @gjacoby126. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898788305 ## pom.xml: ## @@ -190,8 +175,8 @@ 1.10 1.3 -2.13.0 -3.4.9 +4.3.0 Review Comment: Right again, fixing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898788288
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
Review Comment:
You're right, fixing it.
##
pom.xml:
##
@@ -190,8 +175,8 @@
1.10
1.3
-2.13.0
-3.4.9
+4.3.0
Review Comment:
Right again, fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898299565 ## pom.xml: ## @@ -190,8 +175,8 @@ 1.10 1.3 -2.13.0 -3.4.9 +4.3.0 Review Comment: I believe in PHOENIX-6723 we set Curator in the main Phoenix to 4.2. Should we be consistent here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898298858
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
Review Comment:
@stoty should this be 2.4.10 given the recent investigation that showed a
Phoenix incompatibility in 2.4.11 and 2.4.12? (Of course, it should be 2.4.13
or 2.5 once they're released)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1154680247 I had to pause working on 5.2 stuff due to @dayjob deadlines, but now I can resume work on it. (Bar the usual summer PTOs) Can you please re-review @gjacoby126 ? We can change/drop the enforcer rules in any way you see fit, it's not an essential part of the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] dependabot[bot] opened a new pull request, #114: Bump gson from 2.2.4 to 2.8.9
dependabot[bot] opened a new pull request, #114: URL: https://github.com/apache/phoenix-tephra/pull/114 Bumps [gson](https://github.com/google/gson) from 2.2.4 to 2.8.9. Release notes Sourced from https://github.com/google/gson/releases;>gson's releases. Gson 2.8.9 Make OSGi bundle's dependency on sun.misc optional (https://github-redirect.dependabot.com/google/gson/issues/1993;>#1993). Deprecate Gson.excluder() exposing internal Excluder class (https://github-redirect.dependabot.com/google/gson/issues/1986;>#1986). Prevent Java deserialization of internal classes (https://github-redirect.dependabot.com/google/gson/issues/1991;>#1991). Improve number strategy implementation (https://github-redirect.dependabot.com/google/gson/issues/1987;>#1987). Fix LongSerializationPolicy null handling being inconsistent with Gson (https://github-redirect.dependabot.com/google/gson/issues/1990;>#1990). Support arbitrary Number implementation for Object and Number deserialization (https://github-redirect.dependabot.com/google/gson/issues/1290;>#1290). Bump proguard-maven-plugin from 2.4.0 to 2.5.1 (https://github-redirect.dependabot.com/google/gson/issues/1980;>#1980). Don't exclude static local classes (https://github-redirect.dependabot.com/google/gson/issues/1969;>#1969). Fix RuntimeTypeAdapterFactory depending on internal Streams class (https://github-redirect.dependabot.com/google/gson/issues/1959;>#1959). Improve Maven build (https://github-redirect.dependabot.com/google/gson/issues/1964;>#1964). Make dependency on java.sql optional (https://github-redirect.dependabot.com/google/gson/issues/1707;>#1707). Gson 2.8.8 Fixed issue with recursive types (https://github-redirect.dependabot.com/google/gson/issues/1390;>#1390). Better behaviour with Java 9+ and Unsafe if there is a security manager (https://github-redirect.dependabot.com/google/gson/issues/1712;>#1712). EnumTypeAdapter now works better when ProGuard has obfuscated enum fields (https://github-redirect.dependabot.com/google/gson/issues/1495;>#1495). Changelog Sourced from https://github.com/google/gson/blob/master/CHANGELOG.md;>gson's changelog. Version 2.8.9 Make OSGi bundle's dependency on sun.misc optional (https://github-redirect.dependabot.com/google/gson/issues/1993;>#1993). Deprecate Gson.excluder() exposing internal Excluder class (https://github-redirect.dependabot.com/google/gson/issues/1986;>#1986). Prevent Java deserialization of internal classes (https://github-redirect.dependabot.com/google/gson/issues/1991;>#1991). Improve number strategy implementation (https://github-redirect.dependabot.com/google/gson/issues/1987;>#1987). Fix LongSerializationPolicy null handling being inconsistent with Gson (https://github-redirect.dependabot.com/google/gson/issues/1990;>#1990). Support arbitrary Number implementation for Object and Number deserialization (https://github-redirect.dependabot.com/google/gson/issues/1290;>#1290). Bump proguard-maven-plugin from 2.4.0 to 2.5.1 (https://github-redirect.dependabot.com/google/gson/issues/1980;>#1980). Don't exclude static local classes (https://github-redirect.dependabot.com/google/gson/issues/1969;>#1969). Fix RuntimeTypeAdapterFactory depending on internal Streams class (https://github-redirect.dependabot.com/google/gson/issues/1959;>#1959). Improve Maven build (https://github-redirect.dependabot.com/google/gson/issues/1964;>#1964). Make dependency on java.sql optional (https://github-redirect.dependabot.com/google/gson/issues/1707;>#1707). Version 2.8.8 Fixed issue with recursive types (https://github-redirect.dependabot.com/google/gson/issues/1390;>#1390). Better behaviour with Java 9+ and Unsafe if there is a security manager (https://github-redirect.dependabot.com/google/gson/issues/1712;>#1712). EnumTypeAdapter now works better when ProGuard has obfuscated enum fields (https://github-redirect.dependabot.com/google/gson/issues/1495;>#1495). Version 2.8.7 Fixed ISO8601UtilsTest failing on systems with UTC+X. Improved javadoc for JsonStreamParser. Updated proguard.cfg (https://github-redirect.dependabot.com/google/gson/issues/1693;>#1693). Fixed IllegalStateException in JsonTreeWriter (https://github-redirect.dependabot.com/google/gson/issues/1592;>#1592). Added JsonArray.isEmpty() (https://github-redirect.dependabot.com/google/gson/issues/1640;>#1640). Added new test cases (https://github-redirect.dependabot.com/google/gson/issues/1638;>#1638). Fixed OSGi metadata generation to work on JavaSE 9 (https://github-redirect.dependabot.com/google/gson/issues/1603;>#1603). Version 2.8.6 2019-10-04 https://github.com/google/gson/compare/gson-parent-2.8.5...gson-parent-2.8.6;>GitHub Diff Added static methods JsonParser.parseString and JsonParser.parseReader and deprecated instance method
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445938
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-${shims2.artifactId}
-hbase-2
-1.8
-${hadoop2.version}
-${hbase2.version}
-
${hbase2.artifactId.suffix}
-2.11.0
-
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce
+
+ enforce
+
+
+
+
Review Comment:
We can add the same AlwaysFail for hbase-2 too, or just remove both
profiles, I'm fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445600
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445204
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
This will mess the classpath up, as the slf4j backend pulls in relad4j, and
we still pull log4j12.
I won't clean that up, as I plan to switch to log4j2 before 1.1 is released
anayway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
OK, I will update.
(edited to remove false statement about using log4j2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
OK, I will update.
(Note that omid uses log4j2 already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875443116
##
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
IOException {
"Should be equal");
// Modify dup shadow cell to have a greater MVCC and check that is
replaced
-HBaseShims.setKeyValueSequenceId((KeyValue) dupCell1WithAnotherValue,
1);
+((KeyValue)dupCell1WithAnotherValue).setSequenceId(1);
Review Comment:
As that would be an effective code change, I think that we should track that
in a separate ticket, if you think that we should have that for 1.1. (it's only
used in tests)
I originally tried to refactor all the deprecated HBase 1.x APIs as part of
this change, but I postponed that to OMID-223 , as it's a lot of work and there
are some hairy cases, and I want to get Omid released 1.1 ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875439934
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-${shims2.artifactId}
-hbase-2
-1.8
-${hadoop2.version}
-${hbase2.version}
-
${hbase2.artifactId.suffix}
-2.11.0
-
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce
+
+ enforce
+
+
+
+
Review Comment:
I've meant this as a courtesy to let people who try to update to 1.1 without
checking the release notes know early that it won't work.
If I removed this, the old build command for HBase 1.x would sill work, even
though HBase 1.x is no longer supported.
It is not essential, as we've also changed the artifact names, so they would
figure out when the expected artifacts are not present at the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875438343
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
Review Comment:
We've never used hadoop2.version in the old build, it was just copy-paste
remainder.
As Omid doesn't create shaded artifacts with Hbase bits, the Haodop we build
with has no impact on the end product, only on what we run the tests with.
I'm tracking this in OMID-163, but as this would require that we rebuild
HBase for Hadoop3 for testing the same way that we do for Phoenix, I have
decided against doing this.
If you feel that this is important, I can work on OMID-163, but it's out of
scope for this JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875233006
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
Let's go all the way up to slf4j.version 1.7.36, the latest, which
transparently uses reload4j where necessary if any slf4j dependency tries to
pull in log4j 1.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875216816
##
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
IOException {
"Should be equal");
// Modify dup shadow cell to have a greater MVCC and check that is
replaced
-HBaseShims.setKeyValueSequenceId((KeyValue) dupCell1WithAnotherValue,
1);
+((KeyValue)dupCell1WithAnotherValue).setSequenceId(1);
Review Comment:
Should we be using ExtendedCell rather than KeyValue? (Technically they're
both IA.Private, but it at least doesn't couple us to KeyValue's on-heap
array-backed implementation)
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
Review Comment:
We only support Hadoop 3 in Phoenix but only 2.10 in Omid? Seems like an odd
inconsistency, esp since the old hadoop2.version here is actually 3.0.0
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
Let's go all the way up to slf4j.version 1.7.36, the latest, which
transparently uses reload4j where necessary if anything slf4j dependency tries
to pull in log4j 1.x.
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-${shims2.artifactId}
-hbase-2
-1.8
-${hadoop2.version}
-${hbase2.version}
-
${hbase2.artifactId.suffix}
-2.11.0
-
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce
+
+ enforce
+
+
+
+
Review Comment:
Even if this is just a draft, why AlwaysFail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1129271715 The failure with hbase-1 profile is intentional, as it is no longer supported. I'm going to update the test job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1129262892 Build fails with an enforcer rule to always fail? `[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce) @ omid --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.AlwaysFail failed with message: Always fails!` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #103: Bump junit from 4.13 to 4.13.1
stoty closed pull request #103: Bump junit from 4.13 to 4.13.1 URL: https://github.com/apache/phoenix-omid/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] dependabot[bot] commented on pull request #103: Bump junit from 4.13 to 4.13.1
dependabot[bot] commented on PR #103: URL: https://github.com/apache/phoenix-omid/pull/103#issuecomment-1108790486 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #103: Bump junit from 4.13 to 4.13.1
stoty commented on PR #103: URL: https://github.com/apache/phoenix-omid/pull/103#issuecomment-1108790443 Merged from a cloned commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #104: OMID-221 Bump junit from 4.13 to 4.13.1
stoty closed pull request #104: OMID-221 Bump junit from 4.13 to 4.13.1 URL: https://github.com/apache/phoenix-omid/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty opened a new pull request, #104: OMID-221 Bump junit from 4.13 to 4.13.1
stoty opened a new pull request, #104: URL: https://github.com/apache/phoenix-omid/pull/104 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.13...r4.13.1) --- updated-dependencies: - dependency-name: junit:junit dependency-type: direct:production ... Signed-off-by: dependabot[bot] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] dependabot[bot] opened a new pull request, #103: Bump junit from 4.13 to 4.13.1
dependabot[bot] opened a new pull request, #103: URL: https://github.com/apache/phoenix-omid/pull/103 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases. JUnit 4.13.1 Please refer to the https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md;>release notes for details. Changelog Sourced from https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md;>junit's changelog. Summary of changes in version 4.13.1 Rules Security fix: TemporaryFolder now limits access to temporary folders on Java 1.7 or later A local information disclosure vulnerability in TemporaryFolder has been fixed. See the published https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp;>security advisory for details. Test Runners [Pull request https://github-redirect.dependabot.com/junit-team/junit4/issues/1669;>#1669:](https://github-redirect.dependabot.com/junit-team/junit/pull/1669;>junit-team/junit#1669) Make FrameworkField constructor public Prior to this change, custom runners could make FrameworkMethod instances, but not FrameworkField instances. This small change allows for both now, because FrameworkField's constructor has been promoted from package-private to public. Commits https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66;>1b683f4 [maven-release-plugin] prepare release r4.13.1 https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2;>ce6ce3a Draft 4.13.1 release notes https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24;>c29dd82 Change version to 4.13.1-SNAPSHOT https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567;>1d17486 Add a link to assertThrows in exception testing https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9;>543905d Use separate line for annotation in Javadoc https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944;>510e906 Add sub headlines to class Javadoc https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae;>610155b Merge pull request from GHSA-269g-pwp5-87pp https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec;>b6cfd1e Explicitly wrap float parameter for consistency (https://github-redirect.dependabot.com/junit-team/junit4/issues/1671;>#1671) https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646;>a5d205c Fix GitHub link in FAQ (https://github-redirect.dependabot.com/junit-team/junit4/issues/1672;>#1672) https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8;>3a5c6b4 Deprecated since jdk9 replacing constructor instance of Double and Float (https://github-redirect.dependabot.com/junit-team/junit4/issues/1660;>#1660) Additional commits viewable in https://github.com/junit-team/junit4/compare/r4.13...r4.13.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it
[GitHub] [phoenix-omid] stoty closed pull request #102: OMID-220 Update netty to 4.1.76.Final
stoty closed pull request #102: OMID-220 Update netty to 4.1.76.Final URL: https://github.com/apache/phoenix-omid/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #101: OMID-219 Update to phoenix-thirdparty 2.0
stoty closed pull request #101: OMID-219 Update to phoenix-thirdparty 2.0 URL: https://github.com/apache/phoenix-omid/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] dependabot[bot] commented on pull request #113: Bump hadoop-common from 2.2.0 to 3.2.3
dependabot[bot] commented on PR #113: URL: https://github.com/apache/phoenix-tephra/pull/113#issuecomment-1097821338 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] stoty closed pull request #113: Bump hadoop-common from 2.2.0 to 3.2.3
stoty closed pull request #113: Bump hadoop-common from 2.2.0 to 3.2.3 URL: https://github.com/apache/phoenix-tephra/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] stoty commented on pull request #113: Bump hadoop-common from 2.2.0 to 3.2.3
stoty commented on PR #113: URL: https://github.com/apache/phoenix-tephra/pull/113#issuecomment-1097821271 No way, Jose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] dependabot[bot] opened a new pull request, #113: Bump hadoop-common from 2.2.0 to 3.2.3
dependabot[bot] opened a new pull request, #113: URL: https://github.com/apache/phoenix-tephra/pull/113 Bumps hadoop-common from 2.2.0 to 3.2.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/phoenix-tephra/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty closed pull request #5: PHOENIX-6648 Change next release version of phoenix-thirdparty to 2.0.0
stoty closed pull request #5: URL: https://github.com/apache/phoenix-thirdparty/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty closed pull request #4: PHOENIX-6641 Bump Guava to 31.0.1 in phoenix-thirdparty
stoty closed pull request #4: URL: https://github.com/apache/phoenix-thirdparty/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty commented on a change in pull request #4: PHOENIX-6641 Bump Guava to 31.0.1 in phoenix-thirdparty
stoty commented on a change in pull request #4: URL: https://github.com/apache/phoenix-thirdparty/pull/4#discussion_r802387168 ## File path: pom.xml ## @@ -68,7 +68,7 @@ org.apache.phoenix.thirdparty -29.0-android +31.0.1-android Review comment: Exactly. There is no special provision in thridparty for Java 7, apart from using guava-android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty commented on a change in pull request #4: PHOENIX-6641 Bump Guava to 31.0.1 in phoenix-thirdparty
stoty commented on a change in pull request #4: URL: https://github.com/apache/phoenix-thirdparty/pull/4#discussion_r802387168 ## File path: pom.xml ## @@ -68,7 +68,7 @@ org.apache.phoenix.thirdparty -29.0-android +31.0.1-android Review comment: Exactly. There is no special provision in thridparty in Java 7, apart from using guava-android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] ankitsinghal commented on a change in pull request #4: PHOENIX-6641 Bump Guava to 31.0.1 in phoenix-thirdparty
ankitsinghal commented on a change in pull request #4: URL: https://github.com/apache/phoenix-thirdparty/pull/4#discussion_r802330352 ## File path: pom.xml ## @@ -68,7 +68,7 @@ org.apache.phoenix.thirdparty -29.0-android +31.0.1-android Review comment: Do we still want to stick to android not 31.0.1-jre because of java 7 compatibility? Not sure if we add any compat module in our third-party library for jdk7 separately though this is entirely unrelated to this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] ankitsinghal commented on a change in pull request #4: PHOENIX-6641 Bump Guava to 31.0.1 in phoenix-thirdparty
ankitsinghal commented on a change in pull request #4: URL: https://github.com/apache/phoenix-thirdparty/pull/4#discussion_r802330352 ## File path: pom.xml ## @@ -68,7 +68,7 @@ org.apache.phoenix.thirdparty -29.0-android +31.0.1-android Review comment: Do we still want to stick to android not 31.0.1-jre because of java 7 compatibility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #100: OMID-218 Update OWASP plugin to latest
stoty closed pull request #100: URL: https://github.com/apache/phoenix-omid/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty closed pull request #3: PHOENIX-6575 Replace patched commons-cli with original one when a rel…
stoty closed pull request #3: URL: https://github.com/apache/phoenix-thirdparty/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] virajjasani commented on pull request #3: PHOENIX-6575 Replace patched commons-cli with original one when a rel…
virajjasani commented on pull request #3: URL: https://github.com/apache/phoenix-thirdparty/pull/3#issuecomment-964986582 +1, makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-thirdparty] stoty opened a new pull request #3: PHOENIX-6575 Replace patched commons-cli with original one when a rel…
stoty opened a new pull request #3: URL: https://github.com/apache/phoenix-thirdparty/pull/3 …ease with CLI-254 is available -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #99: OMID-216 Remove log4j.properties from maven artifact
stoty closed pull request #99: URL: https://github.com/apache/phoenix-omid/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #66: OMID-161 Switch default timestampType to WORLD_TIME
stoty closed pull request #66: URL: https://github.com/apache/phoenix-omid/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #74: OMID-167 fix flaky TestTSOChannelHandlerNetty
stoty commented on pull request #74: URL: https://github.com/apache/phoenix-omid/pull/74#issuecomment-934336836 This has been fixed by OMID-198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #74: OMID-167 fix flaky TestTSOChannelHandlerNetty
stoty closed pull request #74: URL: https://github.com/apache/phoenix-omid/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #84: OMID-188 Fix "inconsistent module metadata found" when using hbase-2
stoty closed pull request #84: URL: https://github.com/apache/phoenix-omid/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #90: OMID-199 Omid client cannot use pre-authenticated UserGroupInformatio…
stoty closed pull request #90: URL: https://github.com/apache/phoenix-omid/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #93: OMID-207 Upgrade to snakeyaml 1.26
stoty closed pull request #93: URL: https://github.com/apache/phoenix-omid/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #98: OMID-214 Upgrade commons-io to 2.11.0
stoty closed pull request #98: URL: https://github.com/apache/phoenix-omid/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #97: OMID-211 Don't leak testing dependencies in hbase shims.
stoty closed pull request #97: URL: https://github.com/apache/phoenix-omid/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] petersomogyi commented on pull request #98: OMID-214 Upgrade commons-io to 2.11.0
petersomogyi commented on pull request #98: URL: https://github.com/apache/phoenix-omid/pull/98#issuecomment-932228136 Commons IO does not support Java 7 anymore from 2.7 so this PR would break the compatibility. I'll check how this could be reworked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] greyfairer commented on pull request #97: OMID-211 Don't leak testing dependencies in hbase shims.
greyfairer commented on pull request #97: URL: https://github.com/apache/phoenix-omid/pull/97#issuecomment-878215912 > Can you please open an OMID JIRA for the change, and update this PR to refer to that ? Done: OMID-211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #97: Don't leak testing dependencies in hbase shims.
stoty commented on pull request #97: URL: https://github.com/apache/phoenix-omid/pull/97#issuecomment-875279313 Can you please open an OMID JIRA for the change, and update this PR to refer to that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] greyfairer opened a new pull request #97: Don't leak testing dependencies in hbase shims.
greyfairer opened a new pull request #97: URL: https://github.com/apache/phoenix-omid/pull/97 HBase-testing-util was scoped as compile dependency, so all users depending on one of the shims will have it on it's classpath, unless they exclude it. We found this when using Phoenix 5.1 in Cloudera CDP 7.1 in a web application using JAX-RS 2. The hbase-testing-util dependencies drags in dependencies on 10-year old JAX-RS 1 api's. ``` [INFO] | | +- org.apache.phoenix:phoenix-core:jar:5.1.0.7.1.6.0-297:compile [INFO] | | | +- org.apache.phoenix.thirdparty:phoenix-shaded-guava:jar:1.0.0.7.1.6.0-297:compile [INFO] | | | +- org.apache.phoenix:phoenix-hbase-compat-2.4.0:jar:5.1.0.7.1.6.0-297:compile [INFO] | | | +- org.apache.hadoop:hadoop-yarn-api:jar:3.1.1.7.1.6.0-297:compile [INFO] | | | +- org.apache.hadoop:hadoop-hdfs-client:jar:3.1.1.7.1.6.0-297:compile [INFO] | | | +- org.apache.omid:omid-hbase-client-hbase2.x:jar:1.0.2.7.1.6.0-297:compile [INFO] | | | +- org.apache.omid:omid-hbase-coprocessor-hbase2.x:jar:1.0.2.7.1.6.0-297:compile [INFO] | | | +- org.apache.omid:omid-hbase-shims-hbase2.x:jar:1.0.2.7.1.6.0-297:compile [INFO] | | | | +- org.apache.hbase:hbase-endpoint:jar:2.2.3.7.1.6.0-297:compile [INFO] | | | | \- org.apache.hbase:hbase-testing-util:jar:2.2.3.7.1.6.0-297:compile [INFO] | | | | +- org.apache.hbase:hbase-server:test-jar:tests:2.2.3.7.1.6.0-297:compile [INFO] | | | | | +- org.apache.hbase:hbase-http:jar:2.2.3.7.1.6.0-297:compile [INFO] | | | | | +- org.glassfish.web:javax.servlet.jsp:jar:2.3.2:compile [INFO] | | | | | | \- org.glassfish:javax.el:jar:3.0.1-b11:compile [INFO] | | | | | +- javax.servlet.jsp:javax.servlet.jsp-api:jar:2.3.1:compile [INFO] | | | | +- org.apache.hadoop:hadoop-hdfs:test-jar:tests:3.1.1.7.1.6.0-297:compile [INFO] | | | | \- org.apache.hadoop:hadoop-minicluster:jar:3.1.1.7.1.6.0-297:compile [INFO] | | | |+- org.apache.hadoop:hadoop-common:test-jar:tests:3.1.1.7.1.6.0-297:compile [INFO] | | | || +- javax.servlet.jsp:jsp-api:jar:2.1:runtime [INFO] | | | || +- com.sun.jersey:jersey-core:jar:1.19:compile [INFO] | | | || | \- javax.ws.rs:jsr311-api:jar:1.1.1:compile ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #96: OMID-210 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
stoty closed pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] martin-g commented on pull request #96: OMID-210 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
martin-g commented on pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96#issuecomment-849355924 All done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #96: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
stoty commented on pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96#issuecomment-849304469 Sorry, wanted to close the Phoenix one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #96: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
stoty closed pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty edited a comment on pull request #96: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
stoty edited a comment on pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96#issuecomment-849301746 OMID has its own JIRA project. Please clone the Phoenix ticket to OMID, and update the commit message and patch description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #96: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
stoty commented on pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96#issuecomment-849301746 OMID has its own JIRA project. Please clone the Phoenix ticket to OMID, and update the patch description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] martin-g opened a new pull request #96: PHOENIX-6475 Use org.openlabtesting.protobuf:protoc:2.5.0 on Linux ARM64
martin-g opened a new pull request #96: URL: https://github.com/apache/phoenix-omid/pull/96 Similar to https://github.com/apache/phoenix/pull/1238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] stoty closed pull request #95: OMID-209 Migrate to commons-lang3
stoty closed pull request #95: URL: https://github.com/apache/phoenix-omid/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] jojochuang opened a new pull request #95: OMID-209 Migrate to commons-lang3
jojochuang opened a new pull request #95: URL: https://github.com/apache/phoenix-omid/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] richardantal merged pull request #94: OMID-208 Pass additional options to omid.sh
richardantal merged pull request #94: URL: https://github.com/apache/phoenix-omid/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] richardantal opened a new pull request #94: OMID-208 Pass additional options to omid.sh
richardantal opened a new pull request #94: URL: https://github.com/apache/phoenix-omid/pull/94 Change-Id: I3922f89d8723350b2c3b6e8ae36615e7ba6c2fe5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] wolf31o2 closed pull request #15: TEPHRA-186 Prefix shell variables and functions
wolf31o2 closed pull request #15: URL: https://github.com/apache/phoenix-tephra/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] wolf31o2 closed pull request #16: TEPHRA-187 Support --foreground argument for foreground operation
wolf31o2 closed pull request #16: URL: https://github.com/apache/phoenix-tephra/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] richardantal opened a new pull request #93: OMID-207 Upgrade to snakeyaml 1.26 due to CVE-2017-18640
richardantal opened a new pull request #93: URL: https://github.com/apache/phoenix-omid/pull/93 Change-Id: I59cef742ac05eb596ce42fea06d24b07f7dcaec3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] stoty closed pull request #112: TEPHRA-317 Add support for HBase 2.4
stoty closed pull request #112: URL: https://github.com/apache/phoenix-tephra/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] stoty commented on pull request #112: TEPHRA-317 Add support for HBase 2.4
stoty commented on pull request #112: URL: https://github.com/apache/phoenix-tephra/pull/112#issuecomment-822241294 Thanks. Let's wait for the CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-tephra] richardantal commented on pull request #112: TEPHRA-317 Add support for HBase 2.4
richardantal commented on pull request #112: URL: https://github.com/apache/phoenix-tephra/pull/112#issuecomment-822236477 > 1. There seems to be a pom error that causes the test to fail. > 2. Did you have to make changes in the code for 2.4 compared to 2.3 ? If not, then it'd be better to turn the 2.3 module into 2.3-base, and use that as a base for the actual 2.3 and 2.4 modules to avoid code duplication. (see the 2.0-base module for an example) 1. Thanks, tephra-examples/tephra-examples-post-1.3/hbase-2.4/pom.xml was missing, locally it was fine but I forgot to add it to git. 2. I made 2 small code changes. One of them was in TransactionAwareHTable, there is a mutateRow function. It was void but now it returns Result type. The second change is in the TransactionProcessorTest, the ChunkCreator function has an additional indexChunkSizePercent parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
