Royale_Release_Step_010 - Build # 9 - Still Failing!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 9 - Still Failing:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/9/
 to view the results.

Build failed in Jenkins: royale-asjs #1094

[apacheroyaleci]

See 


Changes:


--
[...truncated 1.35 MB...]
[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] 94131 bytes written to 

 in 2.893 seconds
[mxmlc] 4.2250701 seconds
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx2g

test:
[mkdir] Created dir: 

[royaleunit] Validating task attributes ...
[royaleunit] Generating default values ...
[royaleunit] Using the following settings for the test run:
[royaleunit]ROYALE_HOME: 
[
[royaleunit]haltonfailure: [true]
[royaleunit]headless: [false]
[royaleunit]display: [99]
[royaleunit]localTrusted: [true]
[royaleunit]player: [flash]
[royaleunit]port: [1024]
[royaleunit]swf: 
[
[royaleunit]timeout: [9ms]
[royaleunit]toDir: 
[
[royaleunit] Setting up server process ...
[royaleunit] Starting server ...
[royaleunit] Entry 
[
 already available in local trust file at 
[C:\Users\ApacheRoyaleCI\AppData\Roaming\Macromedia\Flash 
Player\#Security\FlashPlayerTrust\royaleUnit.cfg].
[royaleunit] Executing 'rundll32' with arguments:
[royaleunit] 'url.dll,FileProtocolHandler'
[royaleunit] 
'
[royaleunit] 
[royaleunit] The ' characters around the executable and arguments are
[royaleunit] not part of the command.
[royaleunit] 
[royaleunit] Opening server socket on port [1024].
[royaleunit] Waiting for client connection ...
[royaleunit] Client connected.
[royaleunit] Setting inbound buffer size to [262144] bytes.
[royaleunit] Receiving data ...
[royaleunit] Sending acknowledgement to player to start sending test data ...
[royaleunit] 
[royaleunit] 
[royaleunit] Stopping server ...
[royaleunit] End of test data reached, sending acknowledgement to player ...
[royaleunit] Closing client connection ...
[royaleunit] Closing server on port [1024] ...
[royaleunit] Analyzing reports ...
[royaleunit] 
[royaleunit] Suite: flexUnitTests.DataGridColumnTest
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[royaleunit] Results :
[royaleunit] 
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[junitreport] Processing 

 to C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null1896069859
[junitreport] Loading stylesheet 
jar:file:/C:/apache/apache-ant-1.9.9/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1000ms
[junitreport] Deleting: 
C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null1896069859

main:
 [echo] swc-date is 04/18/20 04:41 +

test-js:
 [echo] swc-date is 04/18/20 04:42 +
   [delete] Deleting: 


check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Cross-compiling tests
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] playerglobal.version: 11.7
Trying to override old definition of task compc
Trying to override old definition of task mxmlc
[mxmlc] MXMLJSC
[mxmlc] -compiler.targets=JSRoyale
[mxmlc] -js-output=target
[mxmlc] +playerglobal.version=11.7
[mxmlc] +env.PLAYERGLOBAL_HOME=C:\adobe\flash
[mxmlc] 
+royalelib=
[mxmlc] --
[mxmlc] 

Build failed in Jenkins: royale-asjs #1093

[apacheroyaleci]

See 


Changes:


--
[...truncated 1.34 MB...]
[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] 94132 bytes written to 

 in 2.936 seconds
[mxmlc] 3.8847059 seconds
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx2g

test:
[mkdir] Created dir: 

[royaleunit] Validating task attributes ...
[royaleunit] Generating default values ...
[royaleunit] Using the following settings for the test run:
[royaleunit]ROYALE_HOME: 
[
[royaleunit]haltonfailure: [true]
[royaleunit]headless: [false]
[royaleunit]display: [99]
[royaleunit]localTrusted: [true]
[royaleunit]player: [flash]
[royaleunit]port: [1024]
[royaleunit]swf: 
[
[royaleunit]timeout: [9ms]
[royaleunit]toDir: 
[
[royaleunit] Setting up server process ...
[royaleunit] Starting server ...
[royaleunit] Opening server socket on port [1024].
[royaleunit] Waiting for client connection ...
[royaleunit] Entry 
[
 already available in local trust file at 
[C:\Users\ApacheRoyaleCI\AppData\Roaming\Macromedia\Flash 
Player\#Security\FlashPlayerTrust\royaleUnit.cfg].
[royaleunit] Executing 'rundll32' with arguments:
[royaleunit] 'url.dll,FileProtocolHandler'
[royaleunit] 
'
[royaleunit] 
[royaleunit] The ' characters around the executable and arguments are
[royaleunit] not part of the command.
[royaleunit] 
[royaleunit] Client connected.
[royaleunit] Setting inbound buffer size to [262144] bytes.
[royaleunit] Receiving data ...
[royaleunit] Sending acknowledgement to player to start sending test data ...
[royaleunit] 
[royaleunit] 
[royaleunit] Stopping server ...
[royaleunit] End of test data reached, sending acknowledgement to player ...
[royaleunit] Closing client connection ...
[royaleunit] Closing server on port [1024] ...
[royaleunit] Analyzing reports ...
[royaleunit] 
[royaleunit] Suite: flexUnitTests.DataGridColumnTest
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[royaleunit] Results :
[royaleunit] 
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[junitreport] Processing 

 to C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null616769560
[junitreport] Loading stylesheet 
jar:file:/C:/apache/apache-ant-1.9.9/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 975ms
[junitreport] Deleting: C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null616769560

main:
 [echo] swc-date is 04/18/20 03:16 +

test-js:
 [echo] swc-date is 04/18/20 03:17 +
   [delete] Deleting: 


check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Cross-compiling tests
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] playerglobal.version: 11.7
Trying to override old definition of task compc
Trying to override old definition of task mxmlc
[mxmlc] MXMLJSC
[mxmlc] -compiler.targets=JSRoyale
[mxmlc] -js-output=target
[mxmlc] +playerglobal.version=11.7
[mxmlc] +env.PLAYERGLOBAL_HOME=C:\adobe\flash
[mxmlc] 
+royalelib=
[mxmlc] --
[mxmlc] 

Build failed in Jenkins: royale-asjs #1092

[apacheroyaleci]

See 


Changes:

[carlosrovira] markdown-example: load from a royale docs md page from github


--
[...truncated 1.35 MB...]
[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] 94133 bytes written to 

 in 3.340 seconds
[mxmlc] 4.4287205 seconds
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx2g

test:
[mkdir] Created dir: 

[royaleunit] Validating task attributes ...
[royaleunit] Generating default values ...
[royaleunit] Using the following settings for the test run:
[royaleunit]ROYALE_HOME: 
[
[royaleunit]haltonfailure: [true]
[royaleunit]headless: [false]
[royaleunit]display: [99]
[royaleunit]localTrusted: [true]
[royaleunit]player: [flash]
[royaleunit]port: [1024]
[royaleunit]swf: 
[
[royaleunit]timeout: [9ms]
[royaleunit]toDir: 
[
[royaleunit] Setting up server process ...
[royaleunit] Starting server ...
[royaleunit] Entry 
[
 already available in local trust file at 
[C:\Users\ApacheRoyaleCI\AppData\Roaming\Macromedia\Flash 
Player\#Security\FlashPlayerTrust\royaleUnit.cfg].
[royaleunit] Executing 'rundll32' with arguments:
[royaleunit] 'url.dll,FileProtocolHandler'
[royaleunit] 
'
[royaleunit] 
[royaleunit] The ' characters around the executable and arguments are
[royaleunit] not part of the command.
[royaleunit] 
[royaleunit] Opening server socket on port [1024].
[royaleunit] Waiting for client connection ...
[royaleunit] Client connected.
[royaleunit] Setting inbound buffer size to [262144] bytes.
[royaleunit] Receiving data ...
[royaleunit] Sending acknowledgement to player to start sending test data ...
[royaleunit] 
[royaleunit] 
[royaleunit] Stopping server ...
[royaleunit] End of test data reached, sending acknowledgement to player ...
[royaleunit] Closing client connection ...
[royaleunit] Closing server on port [1024] ...
[royaleunit] Analyzing reports ...
[royaleunit] 
[royaleunit] Suite: flexUnitTests.DataGridColumnTest
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[royaleunit] Results :
[royaleunit] 
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[junitreport] Processing 

 to C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null296665912
[junitreport] Loading stylesheet 
jar:file:/C:/apache/apache-ant-1.9.9/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 972ms
[junitreport] Deleting: C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null296665912

main:
 [echo] swc-date is 04/18/20 00:19 +

test-js:
 [echo] swc-date is 04/18/20 00:20 +
   [delete] Deleting: 


check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Cross-compiling tests
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] playerglobal.version: 11.7
Trying to override old definition of task compc
Trying to override old definition of task mxmlc
[mxmlc] MXMLJSC
[mxmlc] -compiler.targets=JSRoyale
[mxmlc] -js-output=target
[mxmlc] +playerglobal.version=11.7
[mxmlc] +env.PLAYERGLOBAL_HOME=C:\adobe\flash
[mxmlc] 
+royalelib=
[mxmlc] --
[mxmlc] 

Re: 0.9.7 release notes updates - quick check

[Greg Dove]

Ok, thanks for clarifying Alex. I will do that later today.


On Sat, Apr 18, 2020 at 11:03 AM Alex Harui 
wrote:

> IMO, there is no perfect solution.  There will be times where the release
> branch is so broken that it will be tossed and re-cut from develop.  But
> this time around we are trying to keep the release branches around, so make
> changes to the release branch and make sure the RM knows so they RM knows
> to merge changes back in case we get to the toss-and-re-cut point.
>
> Thanks,
> -Alex
>
> On 4/17/20, 3:20 PM, "Greg Dove"  wrote:
>
> I am not sure whether the current work on 0.9.7 release is a dry run
> or a
> full effort (I have not been reading all details recently, sorry). I
> assume
> it is a full release effort.
>
> For 0.9.6 release we had a collective rush to add things to RELEASE
> NOTES
> before release.
>
> I have a few things I want to add to RELEASE NOTES. But I would also
> like
> to make sure I apply our collective learning from last time.
>
> The issue last time (iirc) was that we pushed updates into develop
> branch
> which I think then were being cherry picked into release branch. This I
> believe contributed to some merge conflicts at some point.
> Can I get a definitive answer for where I should add updates to RELEASE
> NOTES at this point if it is not too late? I think it is probably
> supposed
> to be directly into release branch which then gets merged later back
> into
> develop, but I'd like a confirmation of that if it is correct (and not
> too
> late), please.
>
>
>

Build failed in Jenkins: royale-asjs #1091

[apacheroyaleci]

See 


Changes:

[carlosrovira] a new example showing markdown with highlight code, this could 
be the

[greg.dove] minor: Consistency with flash for amf deserialization: the local

[greg.dove] Added initial tests for mx Collections. ArrayCollection iteration 
tests,


--
[...truncated 1.34 MB...]
[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] 94127 bytes written to 

 in 2.859 seconds
[mxmlc] 3.9906222 seconds
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx2g

test:
[mkdir] Created dir: 

[royaleunit] Validating task attributes ...
[royaleunit] Generating default values ...
[royaleunit] Using the following settings for the test run:
[royaleunit]ROYALE_HOME: 
[
[royaleunit]haltonfailure: [true]
[royaleunit]headless: [false]
[royaleunit]display: [99]
[royaleunit]localTrusted: [true]
[royaleunit]player: [flash]
[royaleunit]port: [1024]
[royaleunit]swf: 
[
[royaleunit]timeout: [9ms]
[royaleunit]toDir: 
[
[royaleunit] Setting up server process ...
[royaleunit] Entry 
[
 already available in local trust file at 
[C:\Users\ApacheRoyaleCI\AppData\Roaming\Macromedia\Flash 
Player\#Security\FlashPlayerTrust\royaleUnit.cfg].
[royaleunit] Executing 'rundll32' with arguments:
[royaleunit] 'url.dll,FileProtocolHandler'
[royaleunit] 
'
[royaleunit] 
[royaleunit] The ' characters around the executable and arguments are
[royaleunit] not part of the command.
[royaleunit] 
[royaleunit] Starting server ...
[royaleunit] Opening server socket on port [1024].
[royaleunit] Waiting for client connection ...
[royaleunit] Client connected.
[royaleunit] Setting inbound buffer size to [262144] bytes.
[royaleunit] Receiving data ...
[royaleunit] Sending acknowledgement to player to start sending test data ...
[royaleunit] 
[royaleunit] 
[royaleunit] Stopping server ...
[royaleunit] End of test data reached, sending acknowledgement to player ...
[royaleunit] Closing client connection ...
[royaleunit] Closing server on port [1024] ...
[royaleunit] Analyzing reports ...
[royaleunit] 
[royaleunit] Suite: flexUnitTests.DataGridColumnTest
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[royaleunit] Results :
[royaleunit] 
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[junitreport] Processing 

 to C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null2014360146
[junitreport] Loading stylesheet 
jar:file:/C:/apache/apache-ant-1.9.9/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 969ms
[junitreport] Deleting: 
C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null2014360146

main:
 [echo] swc-date is 04/17/20 23:14 +

test-js:
 [echo] swc-date is 04/17/20 23:15 +
   [delete] Deleting: 


check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Cross-compiling tests
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] playerglobal.version: 11.7
Trying to override old definition of task compc
Trying to override old definition of task mxmlc
[mxmlc] MXMLJSC
[mxmlc] -compiler.targets=JSRoyale
[mxmlc] -js-output=target
[mxmlc] +playerglobal.version=11.7
[mxmlc] +env.PLAYERGLOBAL_HOME=C:\adobe\flash
  

Re: [royale-compiler] branch develop updated: fix build

[Alex Harui]

Please do not add an Apache header to the README or NOTICE (or the LICENSE).  
I'm pretty sure it is just a convention to not add the header.  Headers are not 
a legal thing, they are just helpful signposts.  A missing header does not 
change the copyright of the content.  I would also argue that there isn't 
anything worth copyrighting in these files.

I thought Apache didn't like markdown files for README/RELEASE_NOTES.  They 
look great on Github, but can be less readable in plain text.  Maybe that's 
changed though.

I would prefer that there aren't lots of README/RELEASE_NOTES in the tree, so 
not sure we should recursively exclude all .md files.

My.2 cents,
-Alex

On 4/17/20, 11:13 AM, "Christofer Dutz"  wrote:

Hi all.

So what is the difference between code and documentation? 
I would say none. 
So if I would be asked, I'd probably add the headers to all md, adoc, 
whatsoever files.

Chris

Am 17.04.20, 19:02 schrieb "Carlos Rovira" :

totally

El vie., 17 abr. 2020 a las 18:58, Yishay Weiss 
()
escribió:

> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> **/*.md
>
> ?
>
> From: aha...@apache.org
> Sent: Friday, April 17, 2020 7:14 PM
> To: comm...@royale.apache.org
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C00d54869fbb64bc5383908d7e2fb1061%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227440263647213sdata=FU01dhyhRS3Tows8tzsh6tRpewOT5EBKHsppBdmiy5s%3Dreserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>  new c61b3d0  fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui 
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
>  pom.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
>  LICENSE*
>  NOTICE*
>  README*
> -RELEASE_NOTES*
> +**/RELEASE_NOTES*
>  
>  
>  fb.properties
>
>

-- 
Carlos Rovira

https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosroviradata=02%7C01%7Caharui%40adobe.com%7C00d54869fbb64bc5383908d7e2fb1061%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227440263647213sdata=IUBNebxRAN8NJke78spKrg%2FzGFCohJaOKTpdhlvfYbE%3Dreserved=0

Re: Problems to create AS3 externs when JS library returns some kind of object

[Carlos Rovira]

Hi Josh,

that's right I could be doing something wrong. What I really don't
understand is how setOptions can apply to a concrete marked object.
that's what I could not make it work, and I was supposing that was due to
the fact that is just a function, not a class, since to make a class I
can't have a method "marked" (that get 3 params and returns a string)
because "marked" is will be the reserved word for the constructor.

Although if you say me you got this working I'll try again as I have some
time.

Thanks Josh



El vie., 17 abr. 2020 a las 23:53, Josh Tynjala ()
escribió:

> To be clear, I have successfully used the approach that I suggested with
> other libraries.
>
> Have you tried calling marked["setOptions"]() instead? I think that you
> should rule out the possibility that you were using the API incorrectly.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Fri, Apr 17, 2020 at 2:40 PM Carlos Rovira 
> wrote:
>
> > Hi Josh,
> >
> > I already tried that approach (without the highlighter to avoid
> > complexity), and was not working.
> > I think what's happening is "marked" is not a class is just a function
> that
> > gets a string and returns a string, so a instance is created and
> destroyed
> > each time, but we are not able to store in a var or use "setOptions" to
> > affect that instance and then pass a string and get the new string.
> >
> > As I said I think we have a problem here or a limitation. Or at least is
> > what it seems to me.
> >
> > I was able to use other library (markdown-it) and for now I was able in
> > that one to apply configurations, still trying, but seems that one is
> > modeled in a "royale compatible way", but I think Royale should be able
> to
> > use any js lib out there to be really a js solution.
> >
> > Thanks for the suggestion and for taking a look :)
> >
> > Carlos
> >
> >
> >
> >
> >
> >
> >
> > El vie., 17 abr. 2020 a las 19:24, Josh Tynjala (<
> > joshtynj...@bowlerhat.dev>)
> > escribió:
> >
> > > You may be able to do something like this instead:
> > >
> > > import marked.setOptions;
> > > import marked.Renderer;
> > >
> > > setOptions({
> > >   renderer: new Renderer(),
> > >   highlight: function(code, language) {
> > > const hljs = require('highlight.js');
> > > const validLanguage = hljs.getLanguage(language) ? language :
> > > 'plaintext';
> > > return hljs.highlight(validLanguage, code).value;
> > >   },
> > >   pedantic: false,
> > >   gfm: true,
> > >   breaks: false,
> > >   sanitize: false,
> > >   smartLists: true,
> > >   smartypants: false,
> > >   xhtml: false
> > > });
> > >
> > > console.log(marked(markdownString));
> > >
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Fri, Apr 17, 2020 at 9:54 AM Carlos Rovira  >
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > I think we have some kind of limitation. trying multiple ways with
> the
> > > > "marked" js library and I couldn't objects in the marked library (
> > > > 'setOptions' and the 'Renderer').
> > > >
> > > > I was able just to declare as a function:
> > > >
> > > > package
> > > > {
> > > > /**
> > > > * @externs
> > > > */
> > > > COMPILE::JS
> > > > public function marked(s:String):String {
> > > > return null;
> > > > };
> > > > }
> > > >
> > > > but creating package "marked" and creating "setOptions" and
> "Renderer"
> > as
> > > > functions in that package was not working for me
> > > >
> > > > following library spec I'll need to create an object like this:
> > > >
> > > > options = {
> > > > renderer: new marked.Renderer(),
> > > > pedantic: false,
> > > > gfm: true,
> > > > breaks: false,
> > > > sanitize: false,
> > > > smartLists: true,
> > > > smartypants: false,
> > > > xhtml: false
> > > > };
> > > >
> > > > Then pass to marked (extending the function:
> > > >
> > > > package
> > > > {
> > > > /**
> > > > * @externs
> > > > */
> > > > COMPILE::JS
> > > > public function marked(s:String, options:Object = null,
> > > callback:Function =
> > > > null):String {
> > > > return null;
> > > > };
> > > > }
> > > >
> > > > the callBack function is working, but the options object makes the
> > output
> > > > "undefined"
> > > >
> > > > I think the main problem is if the library has a method that receive
> > > params
> > > > and return values, that collision with AS3 constructor.
> > > >
> > > > We need to be able to create AS3 stub that allow us to do the
> following
> > > JS:
> > > >
> > > > // Create reference instance
> > > > const marked = require('marked');
> > > >
> > > > // Set options
> > > > // `highlight` example uses `highlight.js`
> > > > marked.setOptions({
> > > >   renderer: new marked.Renderer(),
> > > >   highlight: function(code, language) {
> > > > const hljs = require('highlight.js');
> > > > const validLanguage = hljs.getLanguage(language) ? language :
> > > > 'plaintext';
> > > > return hljs.highlight(validLanguage, code).value;
> > > >   },
> > > >   pedantic: 

Re: 0.9.7 release notes updates - quick check

[Alex Harui]

IMO, there is no perfect solution.  There will be times where the release 
branch is so broken that it will be tossed and re-cut from develop.  But this 
time around we are trying to keep the release branches around, so make changes 
to the release branch and make sure the RM knows so they RM knows to merge 
changes back in case we get to the toss-and-re-cut point.

Thanks,
-Alex

On 4/17/20, 3:20 PM, "Greg Dove"  wrote:

I am not sure whether the current work on 0.9.7 release is a dry run or a
full effort (I have not been reading all details recently, sorry). I assume
it is a full release effort.

For 0.9.6 release we had a collective rush to add things to RELEASE NOTES
before release.

I have a few things I want to add to RELEASE NOTES. But I would also like
to make sure I apply our collective learning from last time.

The issue last time (iirc) was that we pushed updates into develop branch
which I think then were being cherry picked into release branch. This I
believe contributed to some merge conflicts at some point.
Can I get a definitive answer for where I should add updates to RELEASE
NOTES at this point if it is not too late? I think it is probably supposed
to be directly into release branch which then gets merged later back into
develop, but I'd like a confirmation of that if it is correct (and not too
late), please.

Re: Routing (was Re: Spectrum Components)

[Greg Dove]

Thanks Josh, good to know. I think I got close to expressing that with 'the
initial path needs to be handled by the server no matter what it is. It may
not do anything different other than to serve the same content regardless
of the path'

But your example with .htaccess is a much more helpful representation of
that - I will keep that in my local references :)



On Sat, Apr 18, 2020 at 10:21 AM Josh Tynjala 
wrote:

> Yes, your understanding is correct. The HTML History API is not limited to
> the hash, and it can update other parts of the URL without reloading the
> whole page. However, if you are not using a hash, then your server may need
> some extra configuration to understand which URLs should be mapped to your
> application's main HTML file.
>
> For example, I have an application at
> https://feathersui.com/samples/haxe-openfl/components-explorer
>
> If you click the Asset Loader list item, it navigates to a new view, and
> the URL changes to
> https://feathersui.com/samples/haxe-openfl/components-explorer/asset-loader
> instead. This is the same instance of the application that was initially
> loaded. It only changes the URL.
>
> If you navigate directly to
> https://feathersui.com/samples/haxe-openfl/components-explorer/asset-loader
> in a new window, it loads the correct view too. This required configuring
> my Apache server with a .htaccess file. Other servers will have a different
> way to configure this behavior.
>
> Here's my .htaccess file:
>
> RewriteBase /samples/haxe-openfl/components-explorer/
> RewriteCond %{HTTPS} off
> RewriteRule ^/?(.*)
> https://%{SERVER_NAME}/samples/haxe-openfl/components-explorer/$1
> [R,L]
> RewriteCond %{REQUEST_FILENAME} !-f
> RewriteCond %{REQUEST_FILENAME} !-d
> RewriteRule . /samples/haxe-openfl/components-explorer/ [L]
>
> It basically says that anything at components-explorer or deeper is part of
> the same application, so even if the browser requests something like
> /samples/haxe-openfl/components-explorer/asset-loader, always serve
> /samples/haxe-openfl/components-explorer (unless a file with the exact
> requested name actually exists, which allows loading images or
> stylesheets). When the page loads, the JS checks the URL to determine which
> view should be initially loaded.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Fri, Apr 17, 2020 at 2:53 PM Greg Dove  wrote:
>
> >  'AIUI, hash has to be used as the delimiter if you plan to change the
> > route information within the application, otherwise the application will
> > reload.'
> >
> > I am pretty sure that is no longer the case.  HTML5 support for history
> > changes it not like the old days and there is good native browser support
> > for this I think. I have certainly worked on React apps with Router
> support
> > that change the full path without reloading the page. I think the main
> > thing is that if the path parts represent the current state of the app,
> > then the initial path needs to be handled by the server no matter what it
> > is. It may not do anything different other than to serve the same content
> > regardless of the path. The JS app can possibly retrieve its serialized
> > previous state from the localStorage based on the intiial path elements
> or
> > make remote separate api requests that are perhaps dependent on the
> startup
> > path elements, and it is not uncommon to continue to update the browser
> > history with full path representations of subsequent api requests that
> > don't rely on hashes.
> > I might be wrong about that because it has been a while since I worked on
> > something that was doing this, but I do recall thinking 'this is so much
> > better than it used to be'.
> >
> >
> > On Sat, Apr 18, 2020 at 3:54 AM Alex Harui 
> > wrote:
> >
> > > Ideally, supporting the route information in parameters vs hash would
> be
> > > done in a PAYG way.
> > >
> > > AIUI, hash has to be used as the delimiter if you plan to change the
> > route
> > > information within the application, otherwise the application will
> > reload.
> > > IOW, if the user is going to navigate in the appiication and the route
> > > information is going to change as they navigate, hash should be used.
> > If,
> > > on the other hand, there are a bunch of links on a website to click and
> > you
> > > end up on a "page", then URL parameters is probably ok.
> > >
> > > I don't understand the concern about the dev branch version.  The
> release
> > > branch for 0.9.7 has been cut.  Any changes that go in develop are
> going
> > in
> > > the next release.  That's how the git branching model works.  You can
> > make
> > > any change you want in the dev branch right now.  It just won't be in
> the
> > > 0.9.7 release unless the RM decides to cherry-pick it, which they
> should
> > > not unless it is really important.  What am I missing?
> > >
> > > -Alex
> > >
> > > On 4/17/20, 3:09 AM, "Harbs"  wrote:
> > >
> > > Whatever you think is fine by me.
> > >
> > > I 

Re: Routing (was Re: Spectrum Components)

[Josh Tynjala]

Yes, your understanding is correct. The HTML History API is not limited to
the hash, and it can update other parts of the URL without reloading the
whole page. However, if you are not using a hash, then your server may need
some extra configuration to understand which URLs should be mapped to your
application's main HTML file.

For example, I have an application at
https://feathersui.com/samples/haxe-openfl/components-explorer

If you click the Asset Loader list item, it navigates to a new view, and
the URL changes to
https://feathersui.com/samples/haxe-openfl/components-explorer/asset-loader
instead. This is the same instance of the application that was initially
loaded. It only changes the URL.

If you navigate directly to
https://feathersui.com/samples/haxe-openfl/components-explorer/asset-loader
in a new window, it loads the correct view too. This required configuring
my Apache server with a .htaccess file. Other servers will have a different
way to configure this behavior.

Here's my .htaccess file:

RewriteBase /samples/haxe-openfl/components-explorer/
RewriteCond %{HTTPS} off
RewriteRule ^/?(.*)
https://%{SERVER_NAME}/samples/haxe-openfl/components-explorer/$1
[R,L]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /samples/haxe-openfl/components-explorer/ [L]

It basically says that anything at components-explorer or deeper is part of
the same application, so even if the browser requests something like
/samples/haxe-openfl/components-explorer/asset-loader, always serve
/samples/haxe-openfl/components-explorer (unless a file with the exact
requested name actually exists, which allows loading images or
stylesheets). When the page loads, the JS checks the URL to determine which
view should be initially loaded.

--
Josh Tynjala
Bowler Hat LLC 


On Fri, Apr 17, 2020 at 2:53 PM Greg Dove  wrote:

>  'AIUI, hash has to be used as the delimiter if you plan to change the
> route information within the application, otherwise the application will
> reload.'
>
> I am pretty sure that is no longer the case.  HTML5 support for history
> changes it not like the old days and there is good native browser support
> for this I think. I have certainly worked on React apps with Router support
> that change the full path without reloading the page. I think the main
> thing is that if the path parts represent the current state of the app,
> then the initial path needs to be handled by the server no matter what it
> is. It may not do anything different other than to serve the same content
> regardless of the path. The JS app can possibly retrieve its serialized
> previous state from the localStorage based on the intiial path elements or
> make remote separate api requests that are perhaps dependent on the startup
> path elements, and it is not uncommon to continue to update the browser
> history with full path representations of subsequent api requests that
> don't rely on hashes.
> I might be wrong about that because it has been a while since I worked on
> something that was doing this, but I do recall thinking 'this is so much
> better than it used to be'.
>
>
> On Sat, Apr 18, 2020 at 3:54 AM Alex Harui 
> wrote:
>
> > Ideally, supporting the route information in parameters vs hash would be
> > done in a PAYG way.
> >
> > AIUI, hash has to be used as the delimiter if you plan to change the
> route
> > information within the application, otherwise the application will
> reload.
> > IOW, if the user is going to navigate in the appiication and the route
> > information is going to change as they navigate, hash should be used.
> If,
> > on the other hand, there are a bunch of links on a website to click and
> you
> > end up on a "page", then URL parameters is probably ok.
> >
> > I don't understand the concern about the dev branch version.  The release
> > branch for 0.9.7 has been cut.  Any changes that go in develop are going
> in
> > the next release.  That's how the git branching model works.  You can
> make
> > any change you want in the dev branch right now.  It just won't be in the
> > 0.9.7 release unless the RM decides to cherry-pick it, which they should
> > not unless it is really important.  What am I missing?
> >
> > -Alex
> >
> > On 4/17/20, 3:09 AM, "Harbs"  wrote:
> >
> > Whatever you think is fine by me.
> >
> > I don’t remember why I have "if(location.hash)”. It’s possible you
> can
> > get rid of that conditional.
> >
> > It could be you can get rid of that and handle hashRecieved in a
> bead.
> > If the hashReceived event has no hash you can then check the URL.You do
> > need to make sure that you always get a stateChange event and don’t
> > dispatch it twice.
> >
> > Feel free to play around with the code… ;-)
> >
> > Harbs
> >
> > > On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki <
> > piotrzarzyck...@gmail.com> wrote:
> > >
> > > I think it would be better to have it here in Router.
> > >
> > > pt., 17 

0.9.7 release notes updates - quick check

[Greg Dove]

I am not sure whether the current work on 0.9.7 release is a dry run or a
full effort (I have not been reading all details recently, sorry). I assume
it is a full release effort.

For 0.9.6 release we had a collective rush to add things to RELEASE NOTES
before release.

I have a few things I want to add to RELEASE NOTES. But I would also like
to make sure I apply our collective learning from last time.

The issue last time (iirc) was that we pushed updates into develop branch
which I think then were being cherry picked into release branch. This I
believe contributed to some merge conflicts at some point.
Can I get a definitive answer for where I should add updates to RELEASE
NOTES at this point if it is not too late? I think it is probably supposed
to be directly into release branch which then gets merged later back into
develop, but I'd like a confirmation of that if it is correct (and not too
late), please.

Re: Routing (was Re: Spectrum Components)

[Greg Dove]

 'AIUI, hash has to be used as the delimiter if you plan to change the
route information within the application, otherwise the application will
reload.'

I am pretty sure that is no longer the case.  HTML5 support for history
changes it not like the old days and there is good native browser support
for this I think. I have certainly worked on React apps with Router support
that change the full path without reloading the page. I think the main
thing is that if the path parts represent the current state of the app,
then the initial path needs to be handled by the server no matter what it
is. It may not do anything different other than to serve the same content
regardless of the path. The JS app can possibly retrieve its serialized
previous state from the localStorage based on the intiial path elements or
make remote separate api requests that are perhaps dependent on the startup
path elements, and it is not uncommon to continue to update the browser
history with full path representations of subsequent api requests that
don't rely on hashes.
I might be wrong about that because it has been a while since I worked on
something that was doing this, but I do recall thinking 'this is so much
better than it used to be'.


On Sat, Apr 18, 2020 at 3:54 AM Alex Harui  wrote:

> Ideally, supporting the route information in parameters vs hash would be
> done in a PAYG way.
>
> AIUI, hash has to be used as the delimiter if you plan to change the route
> information within the application, otherwise the application will reload.
> IOW, if the user is going to navigate in the appiication and the route
> information is going to change as they navigate, hash should be used.  If,
> on the other hand, there are a bunch of links on a website to click and you
> end up on a "page", then URL parameters is probably ok.
>
> I don't understand the concern about the dev branch version.  The release
> branch for 0.9.7 has been cut.  Any changes that go in develop are going in
> the next release.  That's how the git branching model works.  You can make
> any change you want in the dev branch right now.  It just won't be in the
> 0.9.7 release unless the RM decides to cherry-pick it, which they should
> not unless it is really important.  What am I missing?
>
> -Alex
>
> On 4/17/20, 3:09 AM, "Harbs"  wrote:
>
> Whatever you think is fine by me.
>
> I don’t remember why I have "if(location.hash)”. It’s possible you can
> get rid of that conditional.
>
> It could be you can get rid of that and handle hashRecieved in a bead.
> If the hashReceived event has no hash you can then check the URL.You do
> need to make sure that you always get a stateChange event and don’t
> dispatch it twice.
>
> Feel free to play around with the code… ;-)
>
> Harbs
>
> > On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com> wrote:
> >
> > I think it would be better to have it here in Router.
> >
> > pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> >
> >> Alternatively, you can subclass Router to support setting the
> parameters
> >> in the onInit method.
> >>
> >> Not sure which of these is best.
> >>
> >>> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> >>>
> >>> Actually, it’s not going to work because the
> >> router.routeState.parameters will not be set.
> >>>
> >>> You will likely need to add code to set the
> router.routeState.parameters
> >> using the part of the location after the question mark.
> >>>
> >>> The easiest way to do that would be to either:
> >>> 1. Modify RouteToParameters.stateChanged to first check that there
> is a
> >> parameters value and then set it if not.
> >>> 2. Subclass RouteToParameters and override stateChanged to make
> that
> >> check first.
> >>>
>  On Apr 17, 2020, at 10:29 AM, Harbs   >> harbs.li...@gmail.com>> wrote:
> 
>  I’m pretty sure it’ll work without the hash as well.
> 
>  Give it a try.
> 
> > On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> >> piotrzarzyck...@gmail.com >
> wrote:
> >
> > Hi Harbs,
> >
> > Thanks for pointing me out, but this is still that Routing
> expects me
> >> to
> > use in url hashes - The question is - What if I can't use
> hashes, but
> >> url
> > looks like I have presented in previous email ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 17 kwi 2020 o 09:20 Harbs  >> harbs.li...@gmail.com>> napisał(a):
> >
> >> This app uses both path based and query based routing:
> >>
> >>
> 

Re: Problems to create AS3 externs when JS library returns some kind of object

[Josh Tynjala]

To be clear, I have successfully used the approach that I suggested with
other libraries.

Have you tried calling marked["setOptions"]() instead? I think that you
should rule out the possibility that you were using the API incorrectly.

--
Josh Tynjala
Bowler Hat LLC 


On Fri, Apr 17, 2020 at 2:40 PM Carlos Rovira 
wrote:

> Hi Josh,
>
> I already tried that approach (without the highlighter to avoid
> complexity), and was not working.
> I think what's happening is "marked" is not a class is just a function that
> gets a string and returns a string, so a instance is created and destroyed
> each time, but we are not able to store in a var or use "setOptions" to
> affect that instance and then pass a string and get the new string.
>
> As I said I think we have a problem here or a limitation. Or at least is
> what it seems to me.
>
> I was able to use other library (markdown-it) and for now I was able in
> that one to apply configurations, still trying, but seems that one is
> modeled in a "royale compatible way", but I think Royale should be able to
> use any js lib out there to be really a js solution.
>
> Thanks for the suggestion and for taking a look :)
>
> Carlos
>
>
>
>
>
>
>
> El vie., 17 abr. 2020 a las 19:24, Josh Tynjala (<
> joshtynj...@bowlerhat.dev>)
> escribió:
>
> > You may be able to do something like this instead:
> >
> > import marked.setOptions;
> > import marked.Renderer;
> >
> > setOptions({
> >   renderer: new Renderer(),
> >   highlight: function(code, language) {
> > const hljs = require('highlight.js');
> > const validLanguage = hljs.getLanguage(language) ? language :
> > 'plaintext';
> > return hljs.highlight(validLanguage, code).value;
> >   },
> >   pedantic: false,
> >   gfm: true,
> >   breaks: false,
> >   sanitize: false,
> >   smartLists: true,
> >   smartypants: false,
> >   xhtml: false
> > });
> >
> > console.log(marked(markdownString));
> >
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 
> >
> >
> > On Fri, Apr 17, 2020 at 9:54 AM Carlos Rovira 
> > wrote:
> >
> > > Hi,
> > >
> > > I think we have some kind of limitation. trying multiple ways with the
> > > "marked" js library and I couldn't objects in the marked library (
> > > 'setOptions' and the 'Renderer').
> > >
> > > I was able just to declare as a function:
> > >
> > > package
> > > {
> > > /**
> > > * @externs
> > > */
> > > COMPILE::JS
> > > public function marked(s:String):String {
> > > return null;
> > > };
> > > }
> > >
> > > but creating package "marked" and creating "setOptions" and "Renderer"
> as
> > > functions in that package was not working for me
> > >
> > > following library spec I'll need to create an object like this:
> > >
> > > options = {
> > > renderer: new marked.Renderer(),
> > > pedantic: false,
> > > gfm: true,
> > > breaks: false,
> > > sanitize: false,
> > > smartLists: true,
> > > smartypants: false,
> > > xhtml: false
> > > };
> > >
> > > Then pass to marked (extending the function:
> > >
> > > package
> > > {
> > > /**
> > > * @externs
> > > */
> > > COMPILE::JS
> > > public function marked(s:String, options:Object = null,
> > callback:Function =
> > > null):String {
> > > return null;
> > > };
> > > }
> > >
> > > the callBack function is working, but the options object makes the
> output
> > > "undefined"
> > >
> > > I think the main problem is if the library has a method that receive
> > params
> > > and return values, that collision with AS3 constructor.
> > >
> > > We need to be able to create AS3 stub that allow us to do the following
> > JS:
> > >
> > > // Create reference instance
> > > const marked = require('marked');
> > >
> > > // Set options
> > > // `highlight` example uses `highlight.js`
> > > marked.setOptions({
> > >   renderer: new marked.Renderer(),
> > >   highlight: function(code, language) {
> > > const hljs = require('highlight.js');
> > > const validLanguage = hljs.getLanguage(language) ? language :
> > > 'plaintext';
> > > return hljs.highlight(validLanguage, code).value;
> > >   },
> > >   pedantic: false,
> > >   gfm: true,
> > >   breaks: false,
> > >   sanitize: false,
> > >   smartLists: true,
> > >   smartypants: false,
> > >   xhtml: false
> > > });
> > >
> > > // Compile
> > > console.log(marked(markdownString));
> > >
> > >
> > > I was thinking in use it in the basic way, but soon I'll need to use
> the
> > > highlight since our web uses code that needs to be highlighted.
> > >
> > > Anyway, just exposing the issue here. I'm going to try other markdown
> lib
> > > (although seems this is the most used) that has other API surface more
> > > compatible with Royale until someone can take a look and see how we can
> > > make this work on Royale.
> > >
> > > Thanks
> > >
> > >
> > >
> > > El mié., 15 abr. 2020 a las 20:54, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > Yes, it sounds like you have understood me correctly.
> > > >
> > > > --
> > > > Josh 

Re: Problems to create AS3 externs when JS library returns some kind of object

[Carlos Rovira]

Hi Josh,

I already tried that approach (without the highlighter to avoid
complexity), and was not working.
I think what's happening is "marked" is not a class is just a function that
gets a string and returns a string, so a instance is created and destroyed
each time, but we are not able to store in a var or use "setOptions" to
affect that instance and then pass a string and get the new string.

As I said I think we have a problem here or a limitation. Or at least is
what it seems to me.

I was able to use other library (markdown-it) and for now I was able in
that one to apply configurations, still trying, but seems that one is
modeled in a "royale compatible way", but I think Royale should be able to
use any js lib out there to be really a js solution.

Thanks for the suggestion and for taking a look :)

Carlos







El vie., 17 abr. 2020 a las 19:24, Josh Tynjala ()
escribió:

> You may be able to do something like this instead:
>
> import marked.setOptions;
> import marked.Renderer;
>
> setOptions({
>   renderer: new Renderer(),
>   highlight: function(code, language) {
> const hljs = require('highlight.js');
> const validLanguage = hljs.getLanguage(language) ? language :
> 'plaintext';
> return hljs.highlight(validLanguage, code).value;
>   },
>   pedantic: false,
>   gfm: true,
>   breaks: false,
>   sanitize: false,
>   smartLists: true,
>   smartypants: false,
>   xhtml: false
> });
>
> console.log(marked(markdownString));
>
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Fri, Apr 17, 2020 at 9:54 AM Carlos Rovira 
> wrote:
>
> > Hi,
> >
> > I think we have some kind of limitation. trying multiple ways with the
> > "marked" js library and I couldn't objects in the marked library (
> > 'setOptions' and the 'Renderer').
> >
> > I was able just to declare as a function:
> >
> > package
> > {
> > /**
> > * @externs
> > */
> > COMPILE::JS
> > public function marked(s:String):String {
> > return null;
> > };
> > }
> >
> > but creating package "marked" and creating "setOptions" and "Renderer" as
> > functions in that package was not working for me
> >
> > following library spec I'll need to create an object like this:
> >
> > options = {
> > renderer: new marked.Renderer(),
> > pedantic: false,
> > gfm: true,
> > breaks: false,
> > sanitize: false,
> > smartLists: true,
> > smartypants: false,
> > xhtml: false
> > };
> >
> > Then pass to marked (extending the function:
> >
> > package
> > {
> > /**
> > * @externs
> > */
> > COMPILE::JS
> > public function marked(s:String, options:Object = null,
> callback:Function =
> > null):String {
> > return null;
> > };
> > }
> >
> > the callBack function is working, but the options object makes the output
> > "undefined"
> >
> > I think the main problem is if the library has a method that receive
> params
> > and return values, that collision with AS3 constructor.
> >
> > We need to be able to create AS3 stub that allow us to do the following
> JS:
> >
> > // Create reference instance
> > const marked = require('marked');
> >
> > // Set options
> > // `highlight` example uses `highlight.js`
> > marked.setOptions({
> >   renderer: new marked.Renderer(),
> >   highlight: function(code, language) {
> > const hljs = require('highlight.js');
> > const validLanguage = hljs.getLanguage(language) ? language :
> > 'plaintext';
> > return hljs.highlight(validLanguage, code).value;
> >   },
> >   pedantic: false,
> >   gfm: true,
> >   breaks: false,
> >   sanitize: false,
> >   smartLists: true,
> >   smartypants: false,
> >   xhtml: false
> > });
> >
> > // Compile
> > console.log(marked(markdownString));
> >
> >
> > I was thinking in use it in the basic way, but soon I'll need to use the
> > highlight since our web uses code that needs to be highlighted.
> >
> > Anyway, just exposing the issue here. I'm going to try other markdown lib
> > (although seems this is the most used) that has other API surface more
> > compatible with Royale until someone can take a look and see how we can
> > make this work on Royale.
> >
> > Thanks
> >
> >
> >
> > El mié., 15 abr. 2020 a las 20:54, Josh Tynjala (<
> > joshtynj...@bowlerhat.dev>)
> > escribió:
> >
> > > Yes, it sounds like you have understood me correctly.
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Wed, Apr 15, 2020 at 11:00 AM Carlos Rovira <
> carlosrov...@apache.org>
> > > wrote:
> > >
> > > > Hi Josh,
> > > >
> > > > so if I understand correctly your words, for cases where the function
> > is
> > > > called the same as the typedef and we have params and return values
> we
> > > need
> > > > to create a function as I did and then add the rest of functions in
> > > > separate files in the packaged named the same as the typedef?
> > > >
> > > > Regarding "marked" example, I got the initial example working, but
> I'm
> > > > trying to configure options that require create internal types in
> > marked,
> > > > and I'm not got 

Royale_Release_Step_010 - Build # 8 - Still Failing!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 8 - Still Failing:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/8/
 to view the results.

Re: [royale-compiler] branch develop updated: fix build

[Christofer Dutz]

Hi all.

So what is the difference between code and documentation? 
I would say none. 
So if I would be asked, I'd probably add the headers to all md, adoc, 
whatsoever files.

Chris

Am 17.04.20, 19:02 schrieb "Carlos Rovira" :

totally

El vie., 17 abr. 2020 a las 18:58, Yishay Weiss ()
escribió:

> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> **/*.md
>
> ?
>
> From: aha...@apache.org
> Sent: Friday, April 17, 2020 7:14 PM
> To: comm...@royale.apache.org
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>  new c61b3d0  fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui 
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
>  pom.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
>  LICENSE*
>  NOTICE*
>  README*
> -RELEASE_NOTES*
> +**/RELEASE_NOTES*
>  
>  
>  fb.properties
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Build failed in Jenkins: royale-asjs #1090

[apacheroyaleci]

See 


Changes:

[aharui] jgit

[aharui] oops, wrong place

[aharui] [maven-release-plugin] prepare branch @{releaseLabel}

[aharui] [maven-release-plugin] prepare for next development iteration

[aharui] Revert "[maven-release-plugin] prepare for next development iteration"

[aharui] Revert "[maven-release-plugin] prepare branch @{releaseLabel}"

[aharui] [maven-release-plugin] prepare branch @{releaseLabel}

[aharui] [maven-release-plugin] prepare for next development iteration

[piotrzarzycki21] Router: Make onInit protected to give more opportunity to 
extend it

[carlosrovira] scrollToIndex: forgot to remove the class here

[carlosrovira] jewel: add IScrollToIndex interface left from a recent commit


--
[...truncated 1.35 MB...]
[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] 94132 bytes written to 

 in 2.170 seconds
[mxmlc] 3.1161684 seconds
[mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx2g

test:
[mkdir] Created dir: 

[royaleunit] Validating task attributes ...
[royaleunit] Generating default values ...
[royaleunit] Using the following settings for the test run:
[royaleunit]ROYALE_HOME: 
[
[royaleunit]haltonfailure: [true]
[royaleunit]headless: [false]
[royaleunit]display: [99]
[royaleunit]localTrusted: [true]
[royaleunit]player: [flash]
[royaleunit]port: [1024]
[royaleunit]swf: 
[
[royaleunit]timeout: [9ms]
[royaleunit]toDir: 
[
[royaleunit] Setting up server process ...
[royaleunit] Starting server ...
[royaleunit] Opening server socket on port [1024].
[royaleunit] Waiting for client connection ...
[royaleunit] Entry 
[
 already available in local trust file at 
[C:\Users\ApacheRoyaleCI\AppData\Roaming\Macromedia\Flash 
Player\#Security\FlashPlayerTrust\royaleUnit.cfg].
[royaleunit] Executing 'rundll32' with arguments:
[royaleunit] 'url.dll,FileProtocolHandler'
[royaleunit] 
'
[royaleunit] 
[royaleunit] The ' characters around the executable and arguments are
[royaleunit] not part of the command.
[royaleunit] 
[royaleunit] Client connected.
[royaleunit] Setting inbound buffer size to [262144] bytes.
[royaleunit] Receiving data ...
[royaleunit] Sending acknowledgement to player to start sending test data ...
[royaleunit] 
[royaleunit] 
[royaleunit] Stopping server ...
[royaleunit] End of test data reached, sending acknowledgement to player ...
[royaleunit] Closing client connection ...
[royaleunit] Closing server on port [1024] ...
[royaleunit] Analyzing reports ...
[royaleunit] 
[royaleunit] Suite: flexUnitTests.DataGridColumnTest
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[royaleunit] Results :
[royaleunit] 
[royaleunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.123 sec
[royaleunit] 
[junitreport] Processing 

 to C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null1847233806
[junitreport] Loading stylesheet 
jar:file:/C:/apache/apache-ant-1.9.9/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 452ms
[junitreport] Deleting: 
C:\Users\ApacheRoyaleCI\AppData\Local\Temp\null1847233806

main:
 [echo] swc-date is 04/17/20 17:53 +

test-js:
 [echo] swc-date is 04/17/20 17:54 +
   [delete] Deleting: 


check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Cross-compiling tests
 [echo] ROYALE_HOME: 

Jenkins build is back to normal : royale-asjs_jsonly #1289

[apacheroyaleci]

See 

Re: Problems to create AS3 externs when JS library returns some kind of object

[Josh Tynjala]

You may be able to do something like this instead:

import marked.setOptions;
import marked.Renderer;

setOptions({
  renderer: new Renderer(),
  highlight: function(code, language) {
const hljs = require('highlight.js');
const validLanguage = hljs.getLanguage(language) ? language :
'plaintext';
return hljs.highlight(validLanguage, code).value;
  },
  pedantic: false,
  gfm: true,
  breaks: false,
  sanitize: false,
  smartLists: true,
  smartypants: false,
  xhtml: false
});

console.log(marked(markdownString));


--
Josh Tynjala
Bowler Hat LLC 


On Fri, Apr 17, 2020 at 9:54 AM Carlos Rovira 
wrote:

> Hi,
>
> I think we have some kind of limitation. trying multiple ways with the
> "marked" js library and I couldn't objects in the marked library (
> 'setOptions' and the 'Renderer').
>
> I was able just to declare as a function:
>
> package
> {
> /**
> * @externs
> */
> COMPILE::JS
> public function marked(s:String):String {
> return null;
> };
> }
>
> but creating package "marked" and creating "setOptions" and "Renderer" as
> functions in that package was not working for me
>
> following library spec I'll need to create an object like this:
>
> options = {
> renderer: new marked.Renderer(),
> pedantic: false,
> gfm: true,
> breaks: false,
> sanitize: false,
> smartLists: true,
> smartypants: false,
> xhtml: false
> };
>
> Then pass to marked (extending the function:
>
> package
> {
> /**
> * @externs
> */
> COMPILE::JS
> public function marked(s:String, options:Object = null, callback:Function =
> null):String {
> return null;
> };
> }
>
> the callBack function is working, but the options object makes the output
> "undefined"
>
> I think the main problem is if the library has a method that receive params
> and return values, that collision with AS3 constructor.
>
> We need to be able to create AS3 stub that allow us to do the following JS:
>
> // Create reference instance
> const marked = require('marked');
>
> // Set options
> // `highlight` example uses `highlight.js`
> marked.setOptions({
>   renderer: new marked.Renderer(),
>   highlight: function(code, language) {
> const hljs = require('highlight.js');
> const validLanguage = hljs.getLanguage(language) ? language :
> 'plaintext';
> return hljs.highlight(validLanguage, code).value;
>   },
>   pedantic: false,
>   gfm: true,
>   breaks: false,
>   sanitize: false,
>   smartLists: true,
>   smartypants: false,
>   xhtml: false
> });
>
> // Compile
> console.log(marked(markdownString));
>
>
> I was thinking in use it in the basic way, but soon I'll need to use the
> highlight since our web uses code that needs to be highlighted.
>
> Anyway, just exposing the issue here. I'm going to try other markdown lib
> (although seems this is the most used) that has other API surface more
> compatible with Royale until someone can take a look and see how we can
> make this work on Royale.
>
> Thanks
>
>
>
> El mié., 15 abr. 2020 a las 20:54, Josh Tynjala (<
> joshtynj...@bowlerhat.dev>)
> escribió:
>
> > Yes, it sounds like you have understood me correctly.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 
> >
> >
> > On Wed, Apr 15, 2020 at 11:00 AM Carlos Rovira 
> > wrote:
> >
> > > Hi Josh,
> > >
> > > so if I understand correctly your words, for cases where the function
> is
> > > called the same as the typedef and we have params and return values we
> > need
> > > to create a function as I did and then add the rest of functions in
> > > separate files in the packaged named the same as the typedef?
> > >
> > > Regarding "marked" example, I got the initial example working, but I'm
> > > trying to configure options that require create internal types in
> marked,
> > > and I'm not got it already.
> > >
> > > thanks
> > >
> > >
> > >
> > > El mié., 15 abr. 2020 a las 18:00, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > It's not ideal, but one way that I've found to define a typedef
> > function
> > > > that exposes "static" functions similar to a class is to put those
> > > "static"
> > > > functions into a package with the same name as the root function.
> > > >
> > > > package
> > > > {
> > > > /**
> > > > * @externs
> > > > */
> > > > COMPILE::JS
> > > > public function marked(s:String):String {
> > > > return null;
> > > > };
> > > > }
> > > >
> > > > package marked
> > > > {
> > > > /**
> > > > * @externs
> > > > * configure marked with options
> > > > */
> > > > COMPILE::JS
> > > > public function setOptions(o:Object):void {};
> > > > }
> > > >
> > > > Another option is to use dynamic access, but that won't be checked by
> > the
> > > > compiler.
> > > >
> > > > marked["setOptions"]()
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC 
> > > >
> > > >
> > > > On Wed, Apr 15, 2020 at 7:39 AM Carlos Rovira <
> carlosrov...@apache.org
> > >
> > > > wrote:
> > > >
> > > > > Hi Yishay,
> > > > >
> > > > > this finally worked 

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Yishay Weiss]

Oops, looks like I need to rebuild Core.  Ignore this.


From: Yishay Weiss 
Sent: Friday, April 17, 2020 8:05:06 PM
To: dev@royale.apache.org 
Subject: RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove 
isolated function

I’m getting

 [java] 
C:\dev\flexjs\royale-asjs\frameworks\projects\Jewel\src\main\royale\org\apache\royale\jewel\List.as(277):
 col: 20 Error: Access of possibly undefine
d property IScrollToIndexView.

When building Jewel.

I searched IScrollToIndexView and it doesn’t exist.

From: Carlos Rovira
Sent: Friday, April 17, 2020 7:53 PM
To: Apache Royale Development
Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove 
isolated function

Hi Yishay,

reverting the maven release plugin and rebuilding Jewel worked for me. I
don't see any problem for now

El vie., 17 abr. 2020 a las 17:43, Carlos Rovira ()
escribió:

> Hi Yishay,
>
> the problem is I can't build due to develop in 0.9.8-SNAPSHOT
> I'll try locally to reset my repo to a commit where the versions are not
> bumped
>
> El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ()
> escribió:
>
>> Is Jewel building for you? Even after that change it fails for me.
>>
>> 
>> From: Carlos Rovira 
>> Sent: Friday, April 17, 2020 3:34:21 PM
>> To: Apache Royale Development 
>> Cc: comm...@royale.apache.org 
>> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
>> remove isolated function
>>
>> Thanks
>> just commited :)
>>
>> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss (> >)
>> escribió:
>>
>> > Build is failing. Looks like you forgot to remove scrollToIndex from
>> > JewelClasses
>> >
>> > 
>> > From: carlosrov...@apache.org 
>> > Sent: Friday, April 17, 2020 3:56:44 AM
>> > To: comm...@royale.apache.org 
>> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
>> remove
>> > isolated function
>> >
>> > This is an automated email from the ASF dual-hosted git repository.
>> >
>> > carlosrovira pushed a commit to branch develop
>> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> >
>> >
>> > The following commit(s) were added to refs/heads/develop by this push:
>> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
>> > 8f66e33 is described below
>> >
>> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
>> > Author: Carlos Rovira 
>> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
>> >
>> > jewel-scrollToIndex: remove isolated function
>> > ---
>> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
>> > --
>> >  1 file changed, 97 deletions(-)
>> >
>> > diff --git
>> >
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> >
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> > deleted file mode 100644
>> > index fd4f278..000
>> > ---
>> >
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> > +++ /dev/null
>> > @@ -1,97 +0,0 @@
>> >
>> >
>> -
>> > -//
>> > -//  Licensed to the Apache Software Foundation (ASF) under one or more
>> > -//  contributor license agreements.  See the NOTICE file distributed
>> with
>> > -//  this work for additional information regarding copyright ownership.
>> > -//  The ASF licenses this file to You under the Apache License, Version
>> > 2.0
>> > -//  (the "License"); you may not use this file except in compliance
>> with
>> > -//  the License.  You may obtain a copy of the License at
>> > -//
>> > -//  http://www.apache.org/licenses/LICENSE-2.0
>> > -//
>> > -//  Unless required by applicable law or agreed to in writing, software
>> > -//  distributed under the License is distributed on an "AS IS" BASIS,
>> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> > implied.
>> > -//  See the License for the specific language governing permissions and
>> > -//  limitations under the License.
>> > -//
>> >
>> >
>> -
>> > -package org.apache.royale.jewel.beads.controls.list
>> > -{
>> > -   import org.apache.royale.core.IItemRenderer;
>> > -   import org.apache.royale.core.IItemRendererOwnerView;
>> > -   import org.apache.royale.core.IStrand;
>> > -   import org.apache.royale.html.beads.IListView;
>> > -   import org.apache.royale.jewel.List;
>> > -   import
>> org.apache.royale.jewel.beads.models.ListPresentationModel;
>> > -
>> > -   /**
>> > - *  Ensures that the data provider item at the given index is
>> visible.
>> > - *
>> > - *  If the item is visible, the verticalScrollPosition
>> > - *  property is left 

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Yishay Weiss]

Glad you fixed it. Wasn’t in Core after all…

From: Carlos Rovira
Sent: Friday, April 17, 2020 8:11 PM
To: Apache Royale Development
Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove 
isolated function

Hi Yishay,

just committed, sorry, I was not repairing on that file since is a new one
and I had several others new

sorry for the confusion

now all should work ok

Thanks

El vie., 17 abr. 2020 a las 19:05, Yishay Weiss ()
escribió:

> I’m getting
>
>  [java]
> C:\dev\flexjs\royale-asjs\frameworks\projects\Jewel\src\main\royale\org\apache\royale\jewel\List.as(277):
> col: 20 Error: Access of possibly undefine
> d property IScrollToIndexView.
>
> When building Jewel.
>
> I searched IScrollToIndexView and it doesn’t exist.
>
> From: Carlos Rovira
> Sent: Friday, April 17, 2020 7:53 PM
> To: Apache Royale Development
> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> remove isolated function
>
> Hi Yishay,
>
> reverting the maven release plugin and rebuilding Jewel worked for me. I
> don't see any problem for now
>
> El vie., 17 abr. 2020 a las 17:43, Carlos Rovira ( >)
> escribió:
>
> > Hi Yishay,
> >
> > the problem is I can't build due to develop in 0.9.8-SNAPSHOT
> > I'll try locally to reset my repo to a commit where the versions are not
> > bumped
> >
> > El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ( >)
> > escribió:
> >
> >> Is Jewel building for you? Even after that change it fails for me.
> >>
> >> 
> >> From: Carlos Rovira 
> >> Sent: Friday, April 17, 2020 3:34:21 PM
> >> To: Apache Royale Development 
> >> Cc: comm...@royale.apache.org 
> >> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> >> remove isolated function
> >>
> >> Thanks
> >> just commited :)
> >>
> >> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss (<
> yishayj...@hotmail.com
> >> >)
> >> escribió:
> >>
> >> > Build is failing. Looks like you forgot to remove scrollToIndex from
> >> > JewelClasses
> >> >
> >> > 
> >> > From: carlosrov...@apache.org 
> >> > Sent: Friday, April 17, 2020 3:56:44 AM
> >> > To: comm...@royale.apache.org 
> >> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> >> remove
> >> > isolated function
> >> >
> >> > This is an automated email from the ASF dual-hosted git repository.
> >> >
> >> > carlosrovira pushed a commit to branch develop
> >> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >> >
> >> >
> >> > The following commit(s) were added to refs/heads/develop by this push:
> >> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
> >> > 8f66e33 is described below
> >> >
> >> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
> >> > Author: Carlos Rovira 
> >> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
> >> >
> >> > jewel-scrollToIndex: remove isolated function
> >> > ---
> >> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
> >> > --
> >> >  1 file changed, 97 deletions(-)
> >> >
> >> > diff --git
> >> >
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >> >
> >>
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >> > deleted file mode 100644
> >> > index fd4f278..000
> >> > ---
> >> >
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >> > +++ /dev/null
> >> > @@ -1,97 +0,0 @@
> >> >
> >> >
> >>
> -
> >> > -//
> >> > -//  Licensed to the Apache Software Foundation (ASF) under one or
> more
> >> > -//  contributor license agreements.  See the NOTICE file distributed
> >> with
> >> > -//  this work for additional information regarding copyright
> ownership.
> >> > -//  The ASF licenses this file to You under the Apache License,
> Version
> >> > 2.0
> >> > -//  (the "License"); you may not use this file except in compliance
> >> with
> >> > -//  the License.  You may obtain a copy of the License at
> >> > -//
> >> > -//  http://www.apache.org/licenses/LICENSE-2.0
> >> > -//
> >> > -//  Unless required by applicable law or agreed to in writing,
> software
> >> > -//  distributed under the License is distributed on an "AS IS" BASIS,
> >> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >> > implied.
> >> > -//  See the License for the specific language governing permissions
> and
> >> > -//  limitations under the License.
> >> > -//
> >> >
> >> >
> >>
> -
> >> > -package org.apache.royale.jewel.beads.controls.list
> >> > -{
> >> > -   import 

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Carlos Rovira]

Hi Yishay,

just committed, sorry, I was not repairing on that file since is a new one
and I had several others new

sorry for the confusion

now all should work ok

Thanks

El vie., 17 abr. 2020 a las 19:05, Yishay Weiss ()
escribió:

> I’m getting
>
>  [java]
> C:\dev\flexjs\royale-asjs\frameworks\projects\Jewel\src\main\royale\org\apache\royale\jewel\List.as(277):
> col: 20 Error: Access of possibly undefine
> d property IScrollToIndexView.
>
> When building Jewel.
>
> I searched IScrollToIndexView and it doesn’t exist.
>
> From: Carlos Rovira
> Sent: Friday, April 17, 2020 7:53 PM
> To: Apache Royale Development
> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> remove isolated function
>
> Hi Yishay,
>
> reverting the maven release plugin and rebuilding Jewel worked for me. I
> don't see any problem for now
>
> El vie., 17 abr. 2020 a las 17:43, Carlos Rovira ( >)
> escribió:
>
> > Hi Yishay,
> >
> > the problem is I can't build due to develop in 0.9.8-SNAPSHOT
> > I'll try locally to reset my repo to a commit where the versions are not
> > bumped
> >
> > El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ( >)
> > escribió:
> >
> >> Is Jewel building for you? Even after that change it fails for me.
> >>
> >> 
> >> From: Carlos Rovira 
> >> Sent: Friday, April 17, 2020 3:34:21 PM
> >> To: Apache Royale Development 
> >> Cc: comm...@royale.apache.org 
> >> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> >> remove isolated function
> >>
> >> Thanks
> >> just commited :)
> >>
> >> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss (<
> yishayj...@hotmail.com
> >> >)
> >> escribió:
> >>
> >> > Build is failing. Looks like you forgot to remove scrollToIndex from
> >> > JewelClasses
> >> >
> >> > 
> >> > From: carlosrov...@apache.org 
> >> > Sent: Friday, April 17, 2020 3:56:44 AM
> >> > To: comm...@royale.apache.org 
> >> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> >> remove
> >> > isolated function
> >> >
> >> > This is an automated email from the ASF dual-hosted git repository.
> >> >
> >> > carlosrovira pushed a commit to branch develop
> >> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >> >
> >> >
> >> > The following commit(s) were added to refs/heads/develop by this push:
> >> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
> >> > 8f66e33 is described below
> >> >
> >> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
> >> > Author: Carlos Rovira 
> >> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
> >> >
> >> > jewel-scrollToIndex: remove isolated function
> >> > ---
> >> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
> >> > --
> >> >  1 file changed, 97 deletions(-)
> >> >
> >> > diff --git
> >> >
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >> >
> >>
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >> > deleted file mode 100644
> >> > index fd4f278..000
> >> > ---
> >> >
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >> > +++ /dev/null
> >> > @@ -1,97 +0,0 @@
> >> >
> >> >
> >>
> -
> >> > -//
> >> > -//  Licensed to the Apache Software Foundation (ASF) under one or
> more
> >> > -//  contributor license agreements.  See the NOTICE file distributed
> >> with
> >> > -//  this work for additional information regarding copyright
> ownership.
> >> > -//  The ASF licenses this file to You under the Apache License,
> Version
> >> > 2.0
> >> > -//  (the "License"); you may not use this file except in compliance
> >> with
> >> > -//  the License.  You may obtain a copy of the License at
> >> > -//
> >> > -//  http://www.apache.org/licenses/LICENSE-2.0
> >> > -//
> >> > -//  Unless required by applicable law or agreed to in writing,
> software
> >> > -//  distributed under the License is distributed on an "AS IS" BASIS,
> >> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >> > implied.
> >> > -//  See the License for the specific language governing permissions
> and
> >> > -//  limitations under the License.
> >> > -//
> >> >
> >> >
> >>
> -
> >> > -package org.apache.royale.jewel.beads.controls.list
> >> > -{
> >> > -   import org.apache.royale.core.IItemRenderer;
> >> > -   import org.apache.royale.core.IItemRendererOwnerView;
> >> > -   import org.apache.royale.core.IStrand;
> >> > -   import org.apache.royale.html.beads.IListView;
> >> > -   import org.apache.royale.jewel.List;
> >> > -   import
> >> 

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Yishay Weiss]

I’m getting

 [java] 
C:\dev\flexjs\royale-asjs\frameworks\projects\Jewel\src\main\royale\org\apache\royale\jewel\List.as(277):
 col: 20 Error: Access of possibly undefine
d property IScrollToIndexView.

When building Jewel.

I searched IScrollToIndexView and it doesn’t exist.

From: Carlos Rovira
Sent: Friday, April 17, 2020 7:53 PM
To: Apache Royale Development
Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove 
isolated function

Hi Yishay,

reverting the maven release plugin and rebuilding Jewel worked for me. I
don't see any problem for now

El vie., 17 abr. 2020 a las 17:43, Carlos Rovira ()
escribió:

> Hi Yishay,
>
> the problem is I can't build due to develop in 0.9.8-SNAPSHOT
> I'll try locally to reset my repo to a commit where the versions are not
> bumped
>
> El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ()
> escribió:
>
>> Is Jewel building for you? Even after that change it fails for me.
>>
>> 
>> From: Carlos Rovira 
>> Sent: Friday, April 17, 2020 3:34:21 PM
>> To: Apache Royale Development 
>> Cc: comm...@royale.apache.org 
>> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
>> remove isolated function
>>
>> Thanks
>> just commited :)
>>
>> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss (> >)
>> escribió:
>>
>> > Build is failing. Looks like you forgot to remove scrollToIndex from
>> > JewelClasses
>> >
>> > 
>> > From: carlosrov...@apache.org 
>> > Sent: Friday, April 17, 2020 3:56:44 AM
>> > To: comm...@royale.apache.org 
>> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
>> remove
>> > isolated function
>> >
>> > This is an automated email from the ASF dual-hosted git repository.
>> >
>> > carlosrovira pushed a commit to branch develop
>> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> >
>> >
>> > The following commit(s) were added to refs/heads/develop by this push:
>> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
>> > 8f66e33 is described below
>> >
>> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
>> > Author: Carlos Rovira 
>> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
>> >
>> > jewel-scrollToIndex: remove isolated function
>> > ---
>> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
>> > --
>> >  1 file changed, 97 deletions(-)
>> >
>> > diff --git
>> >
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> >
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> > deleted file mode 100644
>> > index fd4f278..000
>> > ---
>> >
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> > +++ /dev/null
>> > @@ -1,97 +0,0 @@
>> >
>> >
>> -
>> > -//
>> > -//  Licensed to the Apache Software Foundation (ASF) under one or more
>> > -//  contributor license agreements.  See the NOTICE file distributed
>> with
>> > -//  this work for additional information regarding copyright ownership.
>> > -//  The ASF licenses this file to You under the Apache License, Version
>> > 2.0
>> > -//  (the "License"); you may not use this file except in compliance
>> with
>> > -//  the License.  You may obtain a copy of the License at
>> > -//
>> > -//  http://www.apache.org/licenses/LICENSE-2.0
>> > -//
>> > -//  Unless required by applicable law or agreed to in writing, software
>> > -//  distributed under the License is distributed on an "AS IS" BASIS,
>> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> > implied.
>> > -//  See the License for the specific language governing permissions and
>> > -//  limitations under the License.
>> > -//
>> >
>> >
>> -
>> > -package org.apache.royale.jewel.beads.controls.list
>> > -{
>> > -   import org.apache.royale.core.IItemRenderer;
>> > -   import org.apache.royale.core.IItemRendererOwnerView;
>> > -   import org.apache.royale.core.IStrand;
>> > -   import org.apache.royale.html.beads.IListView;
>> > -   import org.apache.royale.jewel.List;
>> > -   import
>> org.apache.royale.jewel.beads.models.ListPresentationModel;
>> > -
>> > -   /**
>> > - *  Ensures that the data provider item at the given index is
>> visible.
>> > - *
>> > - *  If the item is visible, the verticalScrollPosition
>> > - *  property is left unchanged even if the item is not the first
>> > visible
>> > - *  item. If the item is not currently visible, the
>> > - *  verticalScrollPosition
>> > - *  property is changed make the item the first visible item,
>> unless
>> > there
>> > - *  aren't enough rows 

Re: [royale-compiler] branch develop updated: fix build

[Carlos Rovira]

totally

El vie., 17 abr. 2020 a las 18:58, Yishay Weiss ()
escribió:

> Thanks. Doesn’t it make more sense to recursively exclude *.md files,
> something like
>
> **/*.md
>
> ?
>
> From: aha...@apache.org
> Sent: Friday, April 17, 2020 7:14 PM
> To: comm...@royale.apache.org
> Subject: [royale-compiler] branch develop updated: fix build
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>  new c61b3d0  fix build
> c61b3d0 is described below
>
> commit c61b3d0aa2159a902392307ebcbb53312eb93dce
> Author: Alex Harui 
> AuthorDate: Fri Apr 17 09:14:31 2020 -0700
>
> fix build
> ---
>  pom.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index a9cd598..53af767 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -144,7 +144,7 @@
>  LICENSE*
>  NOTICE*
>  README*
> -RELEASE_NOTES*
> +**/RELEASE_NOTES*
>  
>  
>  fb.properties
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Re: about current framework release (was Re: Routing (was Re: Spectrum Components))

[Carlos Rovira]

Hi Alex,

I'm just exposing that in the other repos there was various tries and
reverts. I was expecting the same here. If you are getting enough progress
to get the release in few hours, that's great. But maybe exposing you got
all working to finish the release and send an email to the list will be
just fine as a courtesy for the rest of the team (not just me).

The fact is that I fixed some things in Jewel scrollToIndex last night and
then you got to step 9, but seems there was a build problem catched by
Yishay with an import left in Jewel. So that will make the release fail for
sure.

A part from that, not me, but others could need to add things...or I could
be wrong. I must say I don't need to add anything myself. So from my
perspective you can go and finish as you prefer. Just thinking on others,
not me :)







El vie., 17 abr. 2020 a las 18:46, Alex Harui ()
escribió:

> Hi Carlos,
>
> First you are complaining that I was not making enough progress on the
> release.  Then there have clearly been Release_Step emails this week and
> you are now claiming I did not give you enough warning?
>
> -Alex
>
> On 4/17/20, 9:38 AM, "Carlos Rovira"  wrote:
>
> Hi Alex,
>
> a part from the issue with version bumped, I thought that you were
> testing
> and changing, and this could be just a test as done in compiler.
> If this is the real release, great. But in that case, I think you
> should
> cherry pick my latest commit removing a class (scrollToIndex) since
> right
> now Jewel is broken. I think others could need to add something to
> enter
> the release as we did other times, if so maybe just asking to people if
> want for a last call to add something would be good.
>
> Thanks
>
> El vie., 17 abr. 2020 a las 17:54, Alex Harui
> ()
> escribió:
>
> > Ideally, supporting the route information in parameters vs hash
> would be
> > done in a PAYG way.
> >
> > AIUI, hash has to be used as the delimiter if you plan to change the
> route
> > information within the application, otherwise the application will
> reload.
> > IOW, if the user is going to navigate in the appiication and the
> route
> > information is going to change as they navigate, hash should be
> used.  If,
> > on the other hand, there are a bunch of links on a website to click
> and you
> > end up on a "page", then URL parameters is probably ok.
> >
> > I don't understand the concern about the dev branch version.  The
> release
> > branch for 0.9.7 has been cut.  Any changes that go in develop are
> going in
> > the next release.  That's how the git branching model works.  You
> can make
> > any change you want in the dev branch right now.  It just won't be
> in the
> > 0.9.7 release unless the RM decides to cherry-pick it, which they
> should
> > not unless it is really important.  What am I missing?
> >
> > -Alex
> >
> > On 4/17/20, 3:09 AM, "Harbs"  wrote:
> >
> > Whatever you think is fine by me.
> >
> > I don’t remember why I have "if(location.hash)”. It’s possible
> you can
> > get rid of that conditional.
> >
> > It could be you can get rid of that and handle hashRecieved in a
> bead.
> > If the hashReceived event has no hash you can then check the URL.You
> do
> > need to make sure that you always get a stateChange event and don’t
> > dispatch it twice.
> >
> > Feel free to play around with the code… ;-)
> >
> > Harbs
> >
> > > On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki <
> > piotrzarzyck...@gmail.com> wrote:
> > >
> > > I think it would be better to have it here in Router.
> > >
> > > pt., 17 kwi 2020 o 09:37 Harbs 
> napisał(a):
> > >
> > >> Alternatively, you can subclass Router to support setting the
> > parameters
> > >> in the onInit method.
> > >>
> > >> Not sure which of these is best.
> > >>
> > >>> On Apr 17, 2020, at 10:35 AM, Harbs 
> wrote:
> > >>>
> > >>> Actually, it’s not going to work because the
> > >> router.routeState.parameters will not be set.
> > >>>
> > >>> You will likely need to add code to set the
> > router.routeState.parameters
> > >> using the part of the location after the question mark.
> > >>>
> > >>> The easiest way to do that would be to either:
> > >>> 1. Modify RouteToParameters.stateChanged to first check that
> there
> > is a
> > >> parameters value and then set it if not.
> > >>> 2. Subclass RouteToParameters and override stateChanged to
> make
> > that
> > >> check first.
> > >>>
> >  On Apr 17, 2020, at 10:29 AM, Harbs  >  > >> harbs.li...@gmail.com>> wrote:
> > 
> >  I’m pretty sure it’ll work without the hash as well.
> > 

RE: [royale-compiler] branch develop updated: fix build

[Yishay Weiss]

Thanks. Doesn’t it make more sense to recursively exclude *.md files, something 
like

**/*.md

?

From: aha...@apache.org
Sent: Friday, April 17, 2020 7:14 PM
To: comm...@royale.apache.org
Subject: [royale-compiler] branch develop updated: fix build

This is an automated email from the ASF dual-hosted git repository.

aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


The following commit(s) were added to refs/heads/develop by this push:
 new c61b3d0  fix build
c61b3d0 is described below

commit c61b3d0aa2159a902392307ebcbb53312eb93dce
Author: Alex Harui 
AuthorDate: Fri Apr 17 09:14:31 2020 -0700

fix build
---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index a9cd598..53af767 100644
--- a/pom.xml
+++ b/pom.xml
@@ -144,7 +144,7 @@
 LICENSE*
 NOTICE*
 README*
-RELEASE_NOTES*
+**/RELEASE_NOTES*
 
 
 fb.properties

Re: Problems to create AS3 externs when JS library returns some kind of object

[Carlos Rovira]

Hi,

I think we have some kind of limitation. trying multiple ways with the
"marked" js library and I couldn't objects in the marked library (
'setOptions' and the 'Renderer').

I was able just to declare as a function:

package
{
/**
* @externs
*/
COMPILE::JS
public function marked(s:String):String {
return null;
};
}

but creating package "marked" and creating "setOptions" and "Renderer" as
functions in that package was not working for me

following library spec I'll need to create an object like this:

options = {
renderer: new marked.Renderer(),
pedantic: false,
gfm: true,
breaks: false,
sanitize: false,
smartLists: true,
smartypants: false,
xhtml: false
};

Then pass to marked (extending the function:

package
{
/**
* @externs
*/
COMPILE::JS
public function marked(s:String, options:Object = null, callback:Function =
null):String {
return null;
};
}

the callBack function is working, but the options object makes the output
"undefined"

I think the main problem is if the library has a method that receive params
and return values, that collision with AS3 constructor.

We need to be able to create AS3 stub that allow us to do the following JS:

// Create reference instance
const marked = require('marked');

// Set options
// `highlight` example uses `highlight.js`
marked.setOptions({
  renderer: new marked.Renderer(),
  highlight: function(code, language) {
const hljs = require('highlight.js');
const validLanguage = hljs.getLanguage(language) ? language : 'plaintext';
return hljs.highlight(validLanguage, code).value;
  },
  pedantic: false,
  gfm: true,
  breaks: false,
  sanitize: false,
  smartLists: true,
  smartypants: false,
  xhtml: false
});

// Compile
console.log(marked(markdownString));


I was thinking in use it in the basic way, but soon I'll need to use the
highlight since our web uses code that needs to be highlighted.

Anyway, just exposing the issue here. I'm going to try other markdown lib
(although seems this is the most used) that has other API surface more
compatible with Royale until someone can take a look and see how we can
make this work on Royale.

Thanks



El mié., 15 abr. 2020 a las 20:54, Josh Tynjala ()
escribió:

> Yes, it sounds like you have understood me correctly.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Wed, Apr 15, 2020 at 11:00 AM Carlos Rovira 
> wrote:
>
> > Hi Josh,
> >
> > so if I understand correctly your words, for cases where the function is
> > called the same as the typedef and we have params and return values we
> need
> > to create a function as I did and then add the rest of functions in
> > separate files in the packaged named the same as the typedef?
> >
> > Regarding "marked" example, I got the initial example working, but I'm
> > trying to configure options that require create internal types in marked,
> > and I'm not got it already.
> >
> > thanks
> >
> >
> >
> > El mié., 15 abr. 2020 a las 18:00, Josh Tynjala (<
> > joshtynj...@bowlerhat.dev>)
> > escribió:
> >
> > > It's not ideal, but one way that I've found to define a typedef
> function
> > > that exposes "static" functions similar to a class is to put those
> > "static"
> > > functions into a package with the same name as the root function.
> > >
> > > package
> > > {
> > > /**
> > > * @externs
> > > */
> > > COMPILE::JS
> > > public function marked(s:String):String {
> > > return null;
> > > };
> > > }
> > >
> > > package marked
> > > {
> > > /**
> > > * @externs
> > > * configure marked with options
> > > */
> > > COMPILE::JS
> > > public function setOptions(o:Object):void {};
> > > }
> > >
> > > Another option is to use dynamic access, but that won't be checked by
> the
> > > compiler.
> > >
> > > marked["setOptions"]()
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Wed, Apr 15, 2020 at 7:39 AM Carlos Rovira  >
> > > wrote:
> > >
> > > > Hi Yishay,
> > > >
> > > > this finally worked (declaring as a function):
> > > >
> > > > package
> > > > {
> > > > /**
> > > > * @externs
> > > > */
> > > > COMPILE::JS
> > > > public function marked(s:String):String {
> > > > return null;
> > > > };
> > > > }
> > > >
> > > > I see two problems with this approach
> > > >
> > > >1.  inject_html is not valid, So I need other wrapper class to add
> > the
> > > >inject_html and use marked within, to make usable as a piece of
> code
> > > > (don't
> > > >like let the user to add the .js script to the html template
> > > >2. Since is a function I can add other API functions like
> > setOptions.
> > > > ie:
> > > >
> > > > /**
> > > > * configure marked with options
> > > > */
> > > > COMPILE::JS
> > > > public function setOptions(o:Object):void {};
> > > >
> > > > Would like to be know how to declare this as a class to add other
> > > function
> > > > APIs available in the js library
> > > >
> > > >
> > > > El mié., 15 abr. 2020 a las 11:14, Yishay Weiss (<
> > yishayj...@hotmail.com
> > > >)
> > > > 

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Carlos Rovira]

Hi Yishay,

reverting the maven release plugin and rebuilding Jewel worked for me. I
don't see any problem for now

El vie., 17 abr. 2020 a las 17:43, Carlos Rovira ()
escribió:

> Hi Yishay,
>
> the problem is I can't build due to develop in 0.9.8-SNAPSHOT
> I'll try locally to reset my repo to a commit where the versions are not
> bumped
>
> El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ()
> escribió:
>
>> Is Jewel building for you? Even after that change it fails for me.
>>
>> 
>> From: Carlos Rovira 
>> Sent: Friday, April 17, 2020 3:34:21 PM
>> To: Apache Royale Development 
>> Cc: comm...@royale.apache.org 
>> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
>> remove isolated function
>>
>> Thanks
>> just commited :)
>>
>> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss (> >)
>> escribió:
>>
>> > Build is failing. Looks like you forgot to remove scrollToIndex from
>> > JewelClasses
>> >
>> > 
>> > From: carlosrov...@apache.org 
>> > Sent: Friday, April 17, 2020 3:56:44 AM
>> > To: comm...@royale.apache.org 
>> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
>> remove
>> > isolated function
>> >
>> > This is an automated email from the ASF dual-hosted git repository.
>> >
>> > carlosrovira pushed a commit to branch develop
>> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> >
>> >
>> > The following commit(s) were added to refs/heads/develop by this push:
>> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
>> > 8f66e33 is described below
>> >
>> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
>> > Author: Carlos Rovira 
>> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
>> >
>> > jewel-scrollToIndex: remove isolated function
>> > ---
>> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
>> > --
>> >  1 file changed, 97 deletions(-)
>> >
>> > diff --git
>> >
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> >
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> > deleted file mode 100644
>> > index fd4f278..000
>> > ---
>> >
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
>> > +++ /dev/null
>> > @@ -1,97 +0,0 @@
>> >
>> >
>> -
>> > -//
>> > -//  Licensed to the Apache Software Foundation (ASF) under one or more
>> > -//  contributor license agreements.  See the NOTICE file distributed
>> with
>> > -//  this work for additional information regarding copyright ownership.
>> > -//  The ASF licenses this file to You under the Apache License, Version
>> > 2.0
>> > -//  (the "License"); you may not use this file except in compliance
>> with
>> > -//  the License.  You may obtain a copy of the License at
>> > -//
>> > -//  http://www.apache.org/licenses/LICENSE-2.0
>> > -//
>> > -//  Unless required by applicable law or agreed to in writing, software
>> > -//  distributed under the License is distributed on an "AS IS" BASIS,
>> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> > implied.
>> > -//  See the License for the specific language governing permissions and
>> > -//  limitations under the License.
>> > -//
>> >
>> >
>> -
>> > -package org.apache.royale.jewel.beads.controls.list
>> > -{
>> > -   import org.apache.royale.core.IItemRenderer;
>> > -   import org.apache.royale.core.IItemRendererOwnerView;
>> > -   import org.apache.royale.core.IStrand;
>> > -   import org.apache.royale.html.beads.IListView;
>> > -   import org.apache.royale.jewel.List;
>> > -   import
>> org.apache.royale.jewel.beads.models.ListPresentationModel;
>> > -
>> > -   /**
>> > - *  Ensures that the data provider item at the given index is
>> visible.
>> > - *
>> > - *  If the item is visible, the verticalScrollPosition
>> > - *  property is left unchanged even if the item is not the first
>> > visible
>> > - *  item. If the item is not currently visible, the
>> > - *  verticalScrollPosition
>> > - *  property is changed make the item the first visible item,
>> unless
>> > there
>> > - *  aren't enough rows to do so because the
>> > - *  verticalScrollPosition value is limited by the
>> > - *  maxVerticalScrollPosition property.
>> > - *
>> > - *  @param index The index of the item in the data provider.
>> > - *
>> > - *  @return true if
>> verticalScrollPosition
>> > changed.
>> > - *
>> > - *  @langversion 3.0
>> > - *  @playerversion Flash 9
>> > - *  @playerversion AIR 1.1
>> > - *  @productversion Royale 0.9.7
>> > - */
>> > -public function scrollToIndex(list:IStrand, 

Royale_Release_Step_010 - Build # 7 - Still Failing!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 7 - Still Failing:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/7/
 to view the results.

Re: about current framework release (was Re: Routing (was Re: Spectrum Components))

[Alex Harui]

Hi Carlos,

First you are complaining that I was not making enough progress on the release. 
 Then there have clearly been Release_Step emails this week and you are now 
claiming I did not give you enough warning?

-Alex

On 4/17/20, 9:38 AM, "Carlos Rovira"  wrote:

Hi Alex,

a part from the issue with version bumped, I thought that you were testing
and changing, and this could be just a test as done in compiler.
If this is the real release, great. But in that case, I think you should
cherry pick my latest commit removing a class (scrollToIndex) since right
now Jewel is broken. I think others could need to add something to enter
the release as we did other times, if so maybe just asking to people if
want for a last call to add something would be good.

Thanks

El vie., 17 abr. 2020 a las 17:54, Alex Harui ()
escribió:

> Ideally, supporting the route information in parameters vs hash would be
> done in a PAYG way.
>
> AIUI, hash has to be used as the delimiter if you plan to change the route
> information within the application, otherwise the application will reload.
> IOW, if the user is going to navigate in the appiication and the route
> information is going to change as they navigate, hash should be used.  If,
> on the other hand, there are a bunch of links on a website to click and 
you
> end up on a "page", then URL parameters is probably ok.
>
> I don't understand the concern about the dev branch version.  The release
> branch for 0.9.7 has been cut.  Any changes that go in develop are going 
in
> the next release.  That's how the git branching model works.  You can make
> any change you want in the dev branch right now.  It just won't be in the
> 0.9.7 release unless the RM decides to cherry-pick it, which they should
> not unless it is really important.  What am I missing?
>
> -Alex
>
> On 4/17/20, 3:09 AM, "Harbs"  wrote:
>
> Whatever you think is fine by me.
>
> I don’t remember why I have "if(location.hash)”. It’s possible you can
> get rid of that conditional.
>
> It could be you can get rid of that and handle hashRecieved in a bead.
> If the hashReceived event has no hash you can then check the URL.You do
> need to make sure that you always get a stateChange event and don’t
> dispatch it twice.
>
> Feel free to play around with the code… ;-)
>
> Harbs
>
> > On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com> wrote:
> >
> > I think it would be better to have it here in Router.
> >
> > pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> >
> >> Alternatively, you can subclass Router to support setting the
> parameters
> >> in the onInit method.
> >>
> >> Not sure which of these is best.
> >>
> >>> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> >>>
> >>> Actually, it’s not going to work because the
> >> router.routeState.parameters will not be set.
> >>>
> >>> You will likely need to add code to set the
> router.routeState.parameters
> >> using the part of the location after the question mark.
> >>>
> >>> The easiest way to do that would be to either:
> >>> 1. Modify RouteToParameters.stateChanged to first check that there
> is a
> >> parameters value and then set it if not.
> >>> 2. Subclass RouteToParameters and override stateChanged to make
> that
> >> check first.
> >>>
>  On Apr 17, 2020, at 10:29 AM, Harbs   >> harbs.li...@gmail.com>> wrote:
> 
>  I’m pretty sure it’ll work without the hash as well.
> 
>  Give it a try.
> 
> > On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> >> piotrzarzyck...@gmail.com >
> wrote:
> >
> > Hi Harbs,
> >
> > Thanks for pointing me out, but this is still that Routing
> expects me
> >> to
> > use in url hashes - The question is - What if I can't use
> hashes, but
> >> url
> > looks like I have presented in previous email ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 17 kwi 2020 o 09:20 Harbs  >> harbs.li...@gmail.com>> napisał(a):
> >
> >> This app uses both path based and query based routing:
> >>
> >>
> 

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Alex Harui]

Everything built for me with 0.9.8-SNAPSHOT in Maven up until the error in 
Jewel.  What error are you getting?

On 4/17/20, 8:44 AM, "Carlos Rovira"  wrote:

Hi Yishay,

the problem is I can't build due to develop in 0.9.8-SNAPSHOT
I'll try locally to reset my repo to a commit where the versions are not
bumped

El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ()
escribió:

> Is Jewel building for you? Even after that change it fails for me.
>
> 
> From: Carlos Rovira 
> Sent: Friday, April 17, 2020 3:34:21 PM
> To: Apache Royale Development 
> Cc: comm...@royale.apache.org 
> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> remove isolated function
>
> Thanks
> just commited :)
>
> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss ()
> escribió:
>
> > Build is failing. Looks like you forgot to remove scrollToIndex from
> > JewelClasses
> >
> > 
> > From: carlosrov...@apache.org 
> > Sent: Friday, April 17, 2020 3:56:44 AM
> > To: comm...@royale.apache.org 
> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> remove
> > isolated function
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > carlosrovira pushed a commit to branch develop
> > in repository 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.gitdata=02%7C01%7Caharui%40adobe.com%7C6ae85bec1e8d46765a0b08d7e2e62f1a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227350593801407sdata=3CNYVSG4izly2Cd79jfmAuNa4%2BYoosTO5Wj7m9VdLVg%3Dreserved=0
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
> > 8f66e33 is described below
> >
> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
> > Author: Carlos Rovira 
> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
> >
> > jewel-scrollToIndex: remove isolated function
> > ---
> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
> > --
> >  1 file changed, 97 deletions(-)
> >
> > diff --git
> >
> 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >
> 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> > deleted file mode 100644
> > index fd4f278..000
> > ---
> >
> 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> > +++ /dev/null
> > @@ -1,97 +0,0 @@
> >
> >
> 
-
> > -//
> > -//  Licensed to the Apache Software Foundation (ASF) under one or more
> > -//  contributor license agreements.  See the NOTICE file distributed
> with
> > -//  this work for additional information regarding copyright ownership.
> > -//  The ASF licenses this file to You under the Apache License, Version
> > 2.0
> > -//  (the "License"); you may not use this file except in compliance 
with
> > -//  the License.  You may obtain a copy of the License at
> > -//
> > -//  
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Flicenses%2FLICENSE-2.0data=02%7C01%7Caharui%40adobe.com%7C6ae85bec1e8d46765a0b08d7e2e62f1a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227350593801407sdata=DJd5XohspnzFix0P4RaAKeiMeu%2BF%2FlR3yPj1R3%2Fi71Y%3Dreserved=0
> > -//
> > -//  Unless required by applicable law or agreed to in writing, software
> > -//  distributed under the License is distributed on an "AS IS" BASIS,
> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > -//  See the License for the specific language governing permissions and
> > -//  limitations under the License.
> > -//
> >
> >
> 
-
> > -package org.apache.royale.jewel.beads.controls.list
> > -{
> > -   import org.apache.royale.core.IItemRenderer;
> > -   import org.apache.royale.core.IItemRendererOwnerView;
> > -   import org.apache.royale.core.IStrand;
> > -   import org.apache.royale.html.beads.IListView;
> > -   import org.apache.royale.jewel.List;
> > -   import
> org.apache.royale.jewel.beads.models.ListPresentationModel;
> > -
> > -   /**
> > - *  Ensures that the data provider item at the given index is
> visible.
> > - *
> > - *  If the item is visible, the verticalScrollPosition
> > - *  

Royale_Release_Step_010 - Build # 6 - Still Failing!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 6 - Still Failing:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/6/
 to view the results.

about current framework release (was Re: Routing (was Re: Spectrum Components))

[Carlos Rovira]

Hi Alex,

a part from the issue with version bumped, I thought that you were testing
and changing, and this could be just a test as done in compiler.
If this is the real release, great. But in that case, I think you should
cherry pick my latest commit removing a class (scrollToIndex) since right
now Jewel is broken. I think others could need to add something to enter
the release as we did other times, if so maybe just asking to people if
want for a last call to add something would be good.

Thanks

El vie., 17 abr. 2020 a las 17:54, Alex Harui ()
escribió:

> Ideally, supporting the route information in parameters vs hash would be
> done in a PAYG way.
>
> AIUI, hash has to be used as the delimiter if you plan to change the route
> information within the application, otherwise the application will reload.
> IOW, if the user is going to navigate in the appiication and the route
> information is going to change as they navigate, hash should be used.  If,
> on the other hand, there are a bunch of links on a website to click and you
> end up on a "page", then URL parameters is probably ok.
>
> I don't understand the concern about the dev branch version.  The release
> branch for 0.9.7 has been cut.  Any changes that go in develop are going in
> the next release.  That's how the git branching model works.  You can make
> any change you want in the dev branch right now.  It just won't be in the
> 0.9.7 release unless the RM decides to cherry-pick it, which they should
> not unless it is really important.  What am I missing?
>
> -Alex
>
> On 4/17/20, 3:09 AM, "Harbs"  wrote:
>
> Whatever you think is fine by me.
>
> I don’t remember why I have "if(location.hash)”. It’s possible you can
> get rid of that conditional.
>
> It could be you can get rid of that and handle hashRecieved in a bead.
> If the hashReceived event has no hash you can then check the URL.You do
> need to make sure that you always get a stateChange event and don’t
> dispatch it twice.
>
> Feel free to play around with the code… ;-)
>
> Harbs
>
> > On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com> wrote:
> >
> > I think it would be better to have it here in Router.
> >
> > pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> >
> >> Alternatively, you can subclass Router to support setting the
> parameters
> >> in the onInit method.
> >>
> >> Not sure which of these is best.
> >>
> >>> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> >>>
> >>> Actually, it’s not going to work because the
> >> router.routeState.parameters will not be set.
> >>>
> >>> You will likely need to add code to set the
> router.routeState.parameters
> >> using the part of the location after the question mark.
> >>>
> >>> The easiest way to do that would be to either:
> >>> 1. Modify RouteToParameters.stateChanged to first check that there
> is a
> >> parameters value and then set it if not.
> >>> 2. Subclass RouteToParameters and override stateChanged to make
> that
> >> check first.
> >>>
>  On Apr 17, 2020, at 10:29 AM, Harbs   >> harbs.li...@gmail.com>> wrote:
> 
>  I’m pretty sure it’ll work without the hash as well.
> 
>  Give it a try.
> 
> > On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> >> piotrzarzyck...@gmail.com >
> wrote:
> >
> > Hi Harbs,
> >
> > Thanks for pointing me out, but this is still that Routing
> expects me
> >> to
> > use in url hashes - The question is - What if I can't use
> hashes, but
> >> url
> > looks like I have presented in previous email ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 17 kwi 2020 o 09:20 Harbs  >> harbs.li...@gmail.com>> napisał(a):
> >
> >> This app uses both path based and query based routing:
> >>
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C3f371b8193974ec8a47d08d7e2b77733%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227149925562717sdata=kGEULHJDYvZ1XHxq1GRF0FNx5%2BBwoXjDTZHw%2BppF6ks%3Dreserved=0
> <
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C3f371b8193974ec8a47d08d7e2b77733%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227149925562717sdata=kGEULHJDYvZ1XHxq1GRF0FNx5%2BBwoXjDTZHw%2BppF6ks%3Dreserved=0>
> <
> >>
> 

Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

[Alex Harui]

Only at the top level.  The maven build should have failed.  I just pushed the 
fix for it.

On 4/17/20, 2:57 AM, "Yishay Weiss"  wrote:

I don’t see any license headers to other md files. Aren’t they filtered out 
of the RAT check?

From: Carlos Rovira
Sent: Friday, April 17, 2020 12:34 PM
To: Apache Royale Development
Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

Hi Yishay,

not sure but probably the empty file added will cause RAT problems with
maven
maybe you should see if that happens and at least add a license header

About content, since is taken from the git history I think is ok

thanks



El vie., 17 abr. 2020 a las 10:14, Yishay Weiss ()
escribió:

> Ok Carlos, thanks. I created RELEASE_NOTES.md under compiler-build-tools.
> I think the main contributors since 1.1 [1] are Alex and Chris so it would
> be great if they could add their comments there.
>
>
>
> [1] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fkmw0kdata=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248566154sdata=WxQXt15d89UFzn6s%2Fx1szRvzEvrX%2FPadPyHWZqNvZfM%3Dreserved=0
>
>
>
> *From:* Carlos Rovira 
> *Sent:* Wednesday, April 15, 2020 11:29:04 AM
> *To:* Apache Royale Development 
> *Subject:* Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was 
part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point 
me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development >
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftakari%2Fmaven-wrapperdata=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248566154sdata=2KdG3HXYRtkAP0vvvJgRtbVsUjk%2BXrp%2FQpCr7TUYEP0%3Dreserved=0
> > >
> > > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > If you're on Windows, and you happened to install Maven using the
> > > > Chocolatey package manager, you may need to tweak the
> > > ApproveBuildTools.xml
> > > > file to get it to work.
> > > >
> > > > Find this line:
> > > >
> > > > 
> > > >
> > > > And change it to this:
> > > >
> > > > 
> > > >
> > > > I think that most people will be fine, but I just wanted to mention
> it.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC 

> > > >
> > > >
> > > > On Mon, Apr 13, 2020 at 1:33 PM  wrote:
> > > >
> > > > > This is the discussion thread.
> > > > >
> > > > > Thanks,
> > > > > Yishay Weiss
> > > >
> > >
> > >
> > > --
> > > Carlos Rovira
> > > 
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosroviradata=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147sdata=PbZNxbS1Rs09AdjnVxu4%2Fxph2tHTEtLZMD9k7iDPwvs%3Dreserved=0
> > >
> >
> >
>
> 

Royale_Release_Step_010 - Build # 5 - Still Failing!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 5 - Still Failing:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/5/
 to view the results.

Royale_Release_Step_010 - Build # 4 - Still Failing!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 4 - Still Failing:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/4/
 to view the results.

Re: Routing (was Re: Spectrum Components)

[Alex Harui]

Ideally, supporting the route information in parameters vs hash would be done 
in a PAYG way.

AIUI, hash has to be used as the delimiter if you plan to change the route 
information within the application, otherwise the application will reload.  
IOW, if the user is going to navigate in the appiication and the route 
information is going to change as they navigate, hash should be used.  If, on 
the other hand, there are a bunch of links on a website to click and you end up 
on a "page", then URL parameters is probably ok.

I don't understand the concern about the dev branch version.  The release 
branch for 0.9.7 has been cut.  Any changes that go in develop are going in the 
next release.  That's how the git branching model works.  You can make any 
change you want in the dev branch right now.  It just won't be in the 0.9.7 
release unless the RM decides to cherry-pick it, which they should not unless 
it is really important.  What am I missing?

-Alex

On 4/17/20, 3:09 AM, "Harbs"  wrote:

Whatever you think is fine by me.

I don’t remember why I have "if(location.hash)”. It’s possible you can get 
rid of that conditional.

It could be you can get rid of that and handle hashRecieved in a bead. If 
the hashReceived event has no hash you can then check the URL.You do need to 
make sure that you always get a stateChange event and don’t dispatch it twice.

Feel free to play around with the code… ;-)

Harbs

> On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki  
wrote:
> 
> I think it would be better to have it here in Router.
> 
> pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> 
>> Alternatively, you can subclass Router to support setting the parameters
>> in the onInit method.
>> 
>> Not sure which of these is best.
>> 
>>> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
>>> 
>>> Actually, it’s not going to work because the
>> router.routeState.parameters will not be set.
>>> 
>>> You will likely need to add code to set the router.routeState.parameters
>> using the part of the location after the question mark.
>>> 
>>> The easiest way to do that would be to either:
>>> 1. Modify RouteToParameters.stateChanged to first check that there is a
>> parameters value and then set it if not.
>>> 2. Subclass RouteToParameters and override stateChanged to make that
>> check first.
>>> 
 On Apr 17, 2020, at 10:29 AM, Harbs > harbs.li...@gmail.com>> wrote:
 
 I’m pretty sure it’ll work without the hash as well.
 
 Give it a try.
 
> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
>> piotrzarzyck...@gmail.com > wrote:
> 
> Hi Harbs,
> 
> Thanks for pointing me out, but this is still that Routing expects me
>> to
> use in url hashes - The question is - What if I can't use hashes, but
>> url
> looks like I have presented in previous email ?
> 
> Thanks,
> Piotr
> 
> pt., 17 kwi 2020 o 09:20 Harbs > harbs.li...@gmail.com>> napisał(a):
> 
>> This app uses both path based and query based routing:
>> 
>> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C3f371b8193974ec8a47d08d7e2b77733%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227149925562717sdata=kGEULHJDYvZ1XHxq1GRF0FNx5%2BBwoXjDTZHw%2BppF6ks%3Dreserved=0
 <
>> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C3f371b8193974ec8a47d08d7e2b77733%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227149925562717sdata=kGEULHJDYvZ1XHxq1GRF0FNx5%2BBwoXjDTZHw%2BppF6ks%3Dreserved=0>
 <
>> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C3f371b8193974ec8a47d08d7e2b77733%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227149925562717sdata=kGEULHJDYvZ1XHxq1GRF0FNx5%2BBwoXjDTZHw%2BppF6ks%3Dreserved=0
 <
>> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C3f371b8193974ec8a47d08d7e2b77733%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227149925562717sdata=kGEULHJDYvZ1XHxq1GRF0FNx5%2BBwoXjDTZHw%2BppF6ks%3Dreserved=0>>
>> 
>> You can see how it’s done here:
>> 
>> 

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Carlos Rovira]

Hi Yishay,

the problem is I can't build due to develop in 0.9.8-SNAPSHOT
I'll try locally to reset my repo to a commit where the versions are not
bumped

El vie., 17 abr. 2020 a las 14:44, Yishay Weiss ()
escribió:

> Is Jewel building for you? Even after that change it fails for me.
>
> 
> From: Carlos Rovira 
> Sent: Friday, April 17, 2020 3:34:21 PM
> To: Apache Royale Development 
> Cc: comm...@royale.apache.org 
> Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> remove isolated function
>
> Thanks
> just commited :)
>
> El vie., 17 abr. 2020 a las 13:30, Yishay Weiss ()
> escribió:
>
> > Build is failing. Looks like you forgot to remove scrollToIndex from
> > JewelClasses
> >
> > 
> > From: carlosrov...@apache.org 
> > Sent: Friday, April 17, 2020 3:56:44 AM
> > To: comm...@royale.apache.org 
> > Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex:
> remove
> > isolated function
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > carlosrovira pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> >  new 8f66e33  jewel-scrollToIndex: remove isolated function
> > 8f66e33 is described below
> >
> > commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
> > Author: Carlos Rovira 
> > AuthorDate: Fri Apr 17 02:56:40 2020 +0200
> >
> > jewel-scrollToIndex: remove isolated function
> > ---
> >  .../jewel/beads/controls/list/scrollToIndex.as | 97
> > --
> >  1 file changed, 97 deletions(-)
> >
> > diff --git
> >
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> >
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> > deleted file mode 100644
> > index fd4f278..000
> > ---
> >
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> > +++ /dev/null
> > @@ -1,97 +0,0 @@
> >
> >
> -
> > -//
> > -//  Licensed to the Apache Software Foundation (ASF) under one or more
> > -//  contributor license agreements.  See the NOTICE file distributed
> with
> > -//  this work for additional information regarding copyright ownership.
> > -//  The ASF licenses this file to You under the Apache License, Version
> > 2.0
> > -//  (the "License"); you may not use this file except in compliance with
> > -//  the License.  You may obtain a copy of the License at
> > -//
> > -//  http://www.apache.org/licenses/LICENSE-2.0
> > -//
> > -//  Unless required by applicable law or agreed to in writing, software
> > -//  distributed under the License is distributed on an "AS IS" BASIS,
> > -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > -//  See the License for the specific language governing permissions and
> > -//  limitations under the License.
> > -//
> >
> >
> -
> > -package org.apache.royale.jewel.beads.controls.list
> > -{
> > -   import org.apache.royale.core.IItemRenderer;
> > -   import org.apache.royale.core.IItemRendererOwnerView;
> > -   import org.apache.royale.core.IStrand;
> > -   import org.apache.royale.html.beads.IListView;
> > -   import org.apache.royale.jewel.List;
> > -   import
> org.apache.royale.jewel.beads.models.ListPresentationModel;
> > -
> > -   /**
> > - *  Ensures that the data provider item at the given index is
> visible.
> > - *
> > - *  If the item is visible, the verticalScrollPosition
> > - *  property is left unchanged even if the item is not the first
> > visible
> > - *  item. If the item is not currently visible, the
> > - *  verticalScrollPosition
> > - *  property is changed make the item the first visible item, unless
> > there
> > - *  aren't enough rows to do so because the
> > - *  verticalScrollPosition value is limited by the
> > - *  maxVerticalScrollPosition property.
> > - *
> > - *  @param index The index of the item in the data provider.
> > - *
> > - *  @return true if verticalScrollPosition
> > changed.
> > - *
> > - *  @langversion 3.0
> > - *  @playerversion Flash 9
> > - *  @playerversion AIR 1.1
> > - *  @productversion Royale 0.9.7
> > - */
> > -public function scrollToIndex(list:IStrand, index:int):Boolean
> > -{
> > -var _list:List = list as List;
> > -
> > -COMPILE::SWF
> > -{
> > -// to implement
> > -
> > -return false;
> > -}
> > -
> > -   COMPILE::JS
> > -   {
> > -var scrollArea:HTMLElement = _list.element;
> > -  

Build failed in Jenkins: royale-asjs_jsonly #1288

[apacheroyaleci]

See 


Changes:

[carlosrovira] scrollToIndex: forgot to remove the class here


--
[...truncated 1.57 MB...]
compile-js:
 [echo] swc-date is 04/17/20 13:00 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 13:00 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling SparkRoyaleJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.define+=GOOG::DEBUG,goog.DEBUG
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 13:00 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 
:
 col: 30 Warning: Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Warning: Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/projects/SparkRoyaleJS/target/SparkRoyaleJS.swc>
 in 26.264 seconds
 [java] COMPCJSCRoyale
 [java] 
:
 col: 30 Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/libs>

main:

copy-swc:

check-for-tests:

test:

main:

Crux:
 [echo] swc-date is 04/17/20 13:01 +

clean:
 [echo] swc-date is 04/17/20 13:01 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 04/17/20 13:01 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 13:01 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling CruxJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Yishay Weiss]

Is Jewel building for you? Even after that change it fails for me.


From: Carlos Rovira 
Sent: Friday, April 17, 2020 3:34:21 PM
To: Apache Royale Development 
Cc: comm...@royale.apache.org 
Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove 
isolated function

Thanks
just commited :)

El vie., 17 abr. 2020 a las 13:30, Yishay Weiss ()
escribió:

> Build is failing. Looks like you forgot to remove scrollToIndex from
> JewelClasses
>
> 
> From: carlosrov...@apache.org 
> Sent: Friday, April 17, 2020 3:56:44 AM
> To: comm...@royale.apache.org 
> Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove
> isolated function
>
> This is an automated email from the ASF dual-hosted git repository.
>
> carlosrovira pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>  new 8f66e33  jewel-scrollToIndex: remove isolated function
> 8f66e33 is described below
>
> commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
> Author: Carlos Rovira 
> AuthorDate: Fri Apr 17 02:56:40 2020 +0200
>
> jewel-scrollToIndex: remove isolated function
> ---
>  .../jewel/beads/controls/list/scrollToIndex.as | 97
> --
>  1 file changed, 97 deletions(-)
>
> diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> deleted file mode 100644
> index fd4f278..000
> ---
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> +++ /dev/null
> @@ -1,97 +0,0 @@
>
> -
> -//
> -//  Licensed to the Apache Software Foundation (ASF) under one or more
> -//  contributor license agreements.  See the NOTICE file distributed with
> -//  this work for additional information regarding copyright ownership.
> -//  The ASF licenses this file to You under the Apache License, Version
> 2.0
> -//  (the "License"); you may not use this file except in compliance with
> -//  the License.  You may obtain a copy of the License at
> -//
> -//  http://www.apache.org/licenses/LICENSE-2.0
> -//
> -//  Unless required by applicable law or agreed to in writing, software
> -//  distributed under the License is distributed on an "AS IS" BASIS,
> -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> -//  See the License for the specific language governing permissions and
> -//  limitations under the License.
> -//
>
> -
> -package org.apache.royale.jewel.beads.controls.list
> -{
> -   import org.apache.royale.core.IItemRenderer;
> -   import org.apache.royale.core.IItemRendererOwnerView;
> -   import org.apache.royale.core.IStrand;
> -   import org.apache.royale.html.beads.IListView;
> -   import org.apache.royale.jewel.List;
> -   import org.apache.royale.jewel.beads.models.ListPresentationModel;
> -
> -   /**
> - *  Ensures that the data provider item at the given index is visible.
> - *
> - *  If the item is visible, the verticalScrollPosition
> - *  property is left unchanged even if the item is not the first
> visible
> - *  item. If the item is not currently visible, the
> - *  verticalScrollPosition
> - *  property is changed make the item the first visible item, unless
> there
> - *  aren't enough rows to do so because the
> - *  verticalScrollPosition value is limited by the
> - *  maxVerticalScrollPosition property.
> - *
> - *  @param index The index of the item in the data provider.
> - *
> - *  @return true if verticalScrollPosition
> changed.
> - *
> - *  @langversion 3.0
> - *  @playerversion Flash 9
> - *  @playerversion AIR 1.1
> - *  @productversion Royale 0.9.7
> - */
> -public function scrollToIndex(list:IStrand, index:int):Boolean
> -{
> -var _list:List = list as List;
> -
> -COMPILE::SWF
> -{
> -// to implement
> -
> -return false;
> -}
> -
> -   COMPILE::JS
> -   {
> -var scrollArea:HTMLElement = _list.element;
> -var oldScroll:Number = scrollArea.scrollTop;
> -
> -var totalHeight:Number = 0;
> -
> -if(_list.variableRowHeight)
> -{
> -var listView:IListView = list.getBeadByType(IListView) as
> IListView;
> -var dataGroup:IItemRendererOwnerView = listView.dataGroup;
> -
> -//each item render can have its own height
> -var n:int = _list.dataProvider.length;
> -var irHeights:Array = [];
> -  

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Carlos Rovira]

Thanks
just commited :)

El vie., 17 abr. 2020 a las 13:30, Yishay Weiss ()
escribió:

> Build is failing. Looks like you forgot to remove scrollToIndex from
> JewelClasses
>
> 
> From: carlosrov...@apache.org 
> Sent: Friday, April 17, 2020 3:56:44 AM
> To: comm...@royale.apache.org 
> Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove
> isolated function
>
> This is an automated email from the ASF dual-hosted git repository.
>
> carlosrovira pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>  new 8f66e33  jewel-scrollToIndex: remove isolated function
> 8f66e33 is described below
>
> commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
> Author: Carlos Rovira 
> AuthorDate: Fri Apr 17 02:56:40 2020 +0200
>
> jewel-scrollToIndex: remove isolated function
> ---
>  .../jewel/beads/controls/list/scrollToIndex.as | 97
> --
>  1 file changed, 97 deletions(-)
>
> diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> deleted file mode 100644
> index fd4f278..000
> ---
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
> +++ /dev/null
> @@ -1,97 +0,0 @@
>
> -
> -//
> -//  Licensed to the Apache Software Foundation (ASF) under one or more
> -//  contributor license agreements.  See the NOTICE file distributed with
> -//  this work for additional information regarding copyright ownership.
> -//  The ASF licenses this file to You under the Apache License, Version
> 2.0
> -//  (the "License"); you may not use this file except in compliance with
> -//  the License.  You may obtain a copy of the License at
> -//
> -//  http://www.apache.org/licenses/LICENSE-2.0
> -//
> -//  Unless required by applicable law or agreed to in writing, software
> -//  distributed under the License is distributed on an "AS IS" BASIS,
> -//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> -//  See the License for the specific language governing permissions and
> -//  limitations under the License.
> -//
>
> -
> -package org.apache.royale.jewel.beads.controls.list
> -{
> -   import org.apache.royale.core.IItemRenderer;
> -   import org.apache.royale.core.IItemRendererOwnerView;
> -   import org.apache.royale.core.IStrand;
> -   import org.apache.royale.html.beads.IListView;
> -   import org.apache.royale.jewel.List;
> -   import org.apache.royale.jewel.beads.models.ListPresentationModel;
> -
> -   /**
> - *  Ensures that the data provider item at the given index is visible.
> - *
> - *  If the item is visible, the verticalScrollPosition
> - *  property is left unchanged even if the item is not the first
> visible
> - *  item. If the item is not currently visible, the
> - *  verticalScrollPosition
> - *  property is changed make the item the first visible item, unless
> there
> - *  aren't enough rows to do so because the
> - *  verticalScrollPosition value is limited by the
> - *  maxVerticalScrollPosition property.
> - *
> - *  @param index The index of the item in the data provider.
> - *
> - *  @return true if verticalScrollPosition
> changed.
> - *
> - *  @langversion 3.0
> - *  @playerversion Flash 9
> - *  @playerversion AIR 1.1
> - *  @productversion Royale 0.9.7
> - */
> -public function scrollToIndex(list:IStrand, index:int):Boolean
> -{
> -var _list:List = list as List;
> -
> -COMPILE::SWF
> -{
> -// to implement
> -
> -return false;
> -}
> -
> -   COMPILE::JS
> -   {
> -var scrollArea:HTMLElement = _list.element;
> -var oldScroll:Number = scrollArea.scrollTop;
> -
> -var totalHeight:Number = 0;
> -
> -if(_list.variableRowHeight)
> -{
> -var listView:IListView = list.getBeadByType(IListView) as
> IListView;
> -var dataGroup:IItemRendererOwnerView = listView.dataGroup;
> -
> -//each item render can have its own height
> -var n:int = _list.dataProvider.length;
> -var irHeights:Array = [];
> -for (var i:int = 0; i <= index; i++)
> -{
> -var ir:IItemRenderer =
> dataGroup.getItemRendererForIndex(i) as IItemRenderer;
> -totalHeight += ir.element.clientHeight;
> -irHeights.push(totalHeight + ir.element.clientHeight -
> scrollArea.clientHeight);
> -

Build failed in Jenkins: royale-asjs_jsonly #1287

[apacheroyaleci]

See 


Changes:


--
[...truncated 1.58 MB...]
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.define+=GOOG::DEBUG,goog.DEBUG
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 12:34 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 
:
 col: 30 Warning: Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Warning: Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/projects/SparkRoyaleJS/target/SparkRoyaleJS.swc>
 in 29.166 seconds
 [java] COMPCJSCRoyale
 [java] 
:
 col: 30 Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/libs>

main:

copy-swc:

check-for-tests:

test:

main:

Crux:
 [echo] swc-date is 04/17/20 12:35 +

clean:
 [echo] swc-date is 04/17/20 12:35 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 04/17/20 12:35 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 12:35 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling CruxJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 12:35 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

[Yishay Weiss]

Build is failing. Looks like you forgot to remove scrollToIndex from 
JewelClasses


From: carlosrov...@apache.org 
Sent: Friday, April 17, 2020 3:56:44 AM
To: comm...@royale.apache.org 
Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove 
isolated function

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
 new 8f66e33  jewel-scrollToIndex: remove isolated function
8f66e33 is described below

commit 8f66e334aebb23c6bf802232de6f925a9e4a2a13
Author: Carlos Rovira 
AuthorDate: Fri Apr 17 02:56:40 2020 +0200

jewel-scrollToIndex: remove isolated function
---
 .../jewel/beads/controls/list/scrollToIndex.as | 97 --
 1 file changed, 97 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
deleted file mode 100644
index fd4f278..000
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/list/scrollToIndex.as
+++ /dev/null
@@ -1,97 +0,0 @@
-
-//
-//  Licensed to the Apache Software Foundation (ASF) under one or more
-//  contributor license agreements.  See the NOTICE file distributed with
-//  this work for additional information regarding copyright ownership.
-//  The ASF licenses this file to You under the Apache License, Version 2.0
-//  (the "License"); you may not use this file except in compliance with
-//  the License.  You may obtain a copy of the License at
-//
-//  http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-//
-
-package org.apache.royale.jewel.beads.controls.list
-{
-   import org.apache.royale.core.IItemRenderer;
-   import org.apache.royale.core.IItemRendererOwnerView;
-   import org.apache.royale.core.IStrand;
-   import org.apache.royale.html.beads.IListView;
-   import org.apache.royale.jewel.List;
-   import org.apache.royale.jewel.beads.models.ListPresentationModel;
-
-   /**
- *  Ensures that the data provider item at the given index is visible.
- *
- *  If the item is visible, the verticalScrollPosition
- *  property is left unchanged even if the item is not the first visible
- *  item. If the item is not currently visible, the
- *  verticalScrollPosition
- *  property is changed make the item the first visible item, unless there
- *  aren't enough rows to do so because the
- *  verticalScrollPosition value is limited by the
- *  maxVerticalScrollPosition property.
- *
- *  @param index The index of the item in the data provider.
- *
- *  @return true if verticalScrollPosition 
changed.
- *
- *  @langversion 3.0
- *  @playerversion Flash 9
- *  @playerversion AIR 1.1
- *  @productversion Royale 0.9.7
- */
-public function scrollToIndex(list:IStrand, index:int):Boolean
-{
-var _list:List = list as List;
-
-COMPILE::SWF
-{
-// to implement
-
-return false;
-}
-
-   COMPILE::JS
-   {
-var scrollArea:HTMLElement = _list.element;
-var oldScroll:Number = scrollArea.scrollTop;
-
-var totalHeight:Number = 0;
-
-if(_list.variableRowHeight)
-{
-var listView:IListView = list.getBeadByType(IListView) as 
IListView;
-var dataGroup:IItemRendererOwnerView = listView.dataGroup;
-
-//each item render can have its own height
-var n:int = _list.dataProvider.length;
-var irHeights:Array = [];
-for (var i:int = 0; i <= index; i++)
-{
-var ir:IItemRenderer = dataGroup.getItemRendererForIndex(i) as 
IItemRenderer;
-totalHeight += ir.element.clientHeight;
-irHeights.push(totalHeight + ir.element.clientHeight - 
scrollArea.clientHeight);
-}
-
-scrollArea.scrollTop = Math.min(irHeights[index], totalHeight);
-
-} else
-{
-var rowHeight:Number;
-// all items renderers with same height
-rowHeight = isNaN(_list.rowHeight) ? 
ListPresentationModel.DEFAULT_ROW_HEIGHT : _list.rowHeight;
- 

Re: Routing (was Re: Spectrum Components)

[Harbs]

Whatever you think is fine by me.

I don’t remember why I have "if(location.hash)”. It’s possible you can get rid 
of that conditional.

It could be you can get rid of that and handle hashRecieved in a bead. If the 
hashReceived event has no hash you can then check the URL.You do need to make 
sure that you always get a stateChange event and don’t dispatch it twice.

Feel free to play around with the code… ;-)

Harbs

> On Apr 17, 2020, at 11:37 AM, Piotr Zarzycki  
> wrote:
> 
> I think it would be better to have it here in Router.
> 
> pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> 
>> Alternatively, you can subclass Router to support setting the parameters
>> in the onInit method.
>> 
>> Not sure which of these is best.
>> 
>>> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
>>> 
>>> Actually, it’s not going to work because the
>> router.routeState.parameters will not be set.
>>> 
>>> You will likely need to add code to set the router.routeState.parameters
>> using the part of the location after the question mark.
>>> 
>>> The easiest way to do that would be to either:
>>> 1. Modify RouteToParameters.stateChanged to first check that there is a
>> parameters value and then set it if not.
>>> 2. Subclass RouteToParameters and override stateChanged to make that
>> check first.
>>> 
 On Apr 17, 2020, at 10:29 AM, Harbs > harbs.li...@gmail.com>> wrote:
 
 I’m pretty sure it’ll work without the hash as well.
 
 Give it a try.
 
> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
>> piotrzarzyck...@gmail.com > wrote:
> 
> Hi Harbs,
> 
> Thanks for pointing me out, but this is still that Routing expects me
>> to
> use in url hashes - The question is - What if I can't use hashes, but
>> url
> looks like I have presented in previous email ?
> 
> Thanks,
> Piotr
> 
> pt., 17 kwi 2020 o 09:20 Harbs > harbs.li...@gmail.com>> napisał(a):
> 
>> This app uses both path based and query based routing:
>> 
>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark> <
>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>>
>> 
>> You can see how it’s done here:
>> 
>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>> <
>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>>> 
>> <
>> 
>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>> <
>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>>> 
>>> 
>> 
>>> On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
>> piotrzarzyck...@gmail.com >
>> wrote:
>>> 
>>> I'm still looking into the code and it looks like Routing
>> implemented now
>>> is not doing what I would expected. Everything is based on "hash"
>> property
>>> in "location". Instead I need something which is in "search" of
>> location. I
>>> will wait for your thoughts before I do try to handle stuff on my
>> end.
>>> 
>>> pt., 17 kwi 2020 o 08:30 Piotr Zarzycki > >
>>> napisał(a):
>>> 
 Hi Guys,
 
 I really thought that I will be able to use Router [1] based on
 documentation and maybe eventually some look to the code [2] - to
>> figure
 out how things should be implemented. However it looks like non of
>> the
 existing stuff helps me to use in in real world application at all.
>> I
>> would
 like to throw a simple question.
 
 I would like to "answer" in my application to following url, catch
>> params
 and do some actions:
 
 
>> https://mydomain.com/somefolder/index.html?target=somevalue= <
>> https://mydomain.com/somefolder/index.html?target=somevalue=>
 <
>> 
>> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
>> <
>> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
>>> 
>>> 
 somevalue
 
 How should I do that using Routing in Royale ? :)
 
 [1] https://apache.github.io/royale-docs/features/routing <
>> https://apache.github.io/royale-docs/features/routing>
 [2]
 
>> 
>> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
>> <
>> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
>>> 
 
 Thanks,
 Piotr
 
 śr., 22 sty 2020 o 13:08 Carlos Rovira 

Build failed in Jenkins: royale-asjs_jsonly #1286

[apacheroyaleci]

See 


Changes:

[piotrzarzycki21] Router: Make onInit protected to give more opportunity to 
extend it


--
[...truncated 1.58 MB...]
 [echo] Cross-compiling SparkRoyaleJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.define+=GOOG::DEBUG,goog.DEBUG
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 10:01 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 
:
 col: 30 Warning: Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Warning: Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/projects/SparkRoyaleJS/target/SparkRoyaleJS.swc>
 in 9.887 seconds
 [java] COMPCJSCRoyale
 [java] 
:
 col: 30 Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/libs>

main:

copy-swc:

check-for-tests:

test:

main:

Crux:
 [echo] swc-date is 04/17/20 10:01 +

clean:
 [echo] swc-date is 04/17/20 10:01 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 04/17/20 10:01 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 10:01 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling CruxJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 10:01 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 

RE: [DISCUSS] Discuss Release Apache Royale 1.2.0

[Yishay Weiss]

I don’t see any license headers to other md files. Aren’t they filtered out of 
the RAT check?

From: Carlos Rovira
Sent: Friday, April 17, 2020 12:34 PM
To: Apache Royale Development
Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

Hi Yishay,

not sure but probably the empty file added will cause RAT problems with
maven
maybe you should see if that happens and at least add a license header

About content, since is taken from the git history I think is ok

thanks



El vie., 17 abr. 2020 a las 10:14, Yishay Weiss ()
escribió:

> Ok Carlos, thanks. I created RELEASE_NOTES.md under compiler-build-tools.
> I think the main contributors since 1.1 [1] are Alex and Chris so it would
> be great if they could add their comments there.
>
>
>
> [1] https://paste.apache.org/kmw0k
>
>
>
> *From:* Carlos Rovira 
> *Sent:* Wednesday, April 15, 2020 11:29:04 AM
> *To:* Apache Royale Development 
> *Subject:* Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development >
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1] https://github.com/takari/maven-wrapper
> > >
> > > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > If you're on Windows, and you happened to install Maven using the
> > > > Chocolatey package manager, you may need to tweak the
> > > ApproveBuildTools.xml
> > > > file to get it to work.
> > > >
> > > > Find this line:
> > > >
> > > > 
> > > >
> > > > And change it to this:
> > > >
> > > > 
> > > >
> > > > I think that most people will be fine, but I just wanted to mention
> it.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC 
> > > >
> > > >
> > > > On Mon, Apr 13, 2020 at 1:33 PM  wrote:
> > > >
> > > > > This is the discussion thread.
> > > > >
> > > > > Thanks,
> > > > > Yishay Weiss
> > > >
> > >
> > >
> > > --
> > > Carlos Rovira
> > > http://about.me/carlosrovira
> > >
> >
> >
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
> *From: *Carlos Rovira 
> *Sent: *Wednesday, April 15, 2020 11:29 AM
> *To: *Apache Royale Development 
> *Subject: *Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development >
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1] https://github.com/takari/maven-wrapper
> > >
> > > El mar., 14 abr. 2020 a las 18:05, 

Re: Routing (was Re: Spectrum Components)

[Carlos Rovira]

Hi,

that's the problem I was talking in the other thread. While a release
process goes, we are stuck, for that reason I was proposing to do release
from a branch, that is something totally legit and will make the rest of
contributors free to continue work. As gitflow indicates, when release is
completed, is merged against develop to upgrade all versions to the right
state.

Maybe not for this, but next release should consider this, since our
release use to last some days. Other projects that release more fast could
do in the actual way since people will not notice.


El vie., 17 abr. 2020 a las 11:43, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:

>  I would update it with params once develop will be
> stable. Right now branch is switched to 0.9.8, so Alex probably is doing
> some work.
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

Thanks for input Carlos - I think I will have some scenario in future where
Router may help me. I would update it with params once develop will be
stable. Right now branch is switched to 0.9.8, so Alex probably is doing
some work.

pt., 17 kwi 2020 o 11:37 Carlos Rovira  napisał(a):

> Hi Piotr,
>
> I'm not saying is not right what you're doing. Just pointing that maybe for
> your use case adding all the Router sttuff is not worthit if you don't plan
> to make a real router use far beyond adding those params. But I think if
> there's some scenario not covered with passing params, we need to cover it.
>
>
>
> El vie., 17 abr. 2020 a las 11:22, Piotr Zarzycki (<
> piotrzarzyck...@gmail.com>) escribió:
>
> > Hi Carlos,
> >
> > At some point you are right, but it was just really weird to me that
> Router
> > has in state parameters property and it's empty. To me it looks like
> bug. I
> > would be willing to set it properly in Router as Harbs suggested, but if
> > you think it shouldn't be there - What would be the purpose of parameters
> > property ?
> >
> > pt., 17 kwi 2020 o 11:09 Carlos Rovira 
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > based on the url you provide, URLParameterBead seems the best option
> > right?
> > > Or at least for the info you provided I don't see a SPA for now, just a
> > > need to load some params to set a state.
> > > If you need a full SPA, then is worth to add Routing and part of that
> > could
> > > be receive params.
> > >
> > > HTH
> > >
> > > Carlos
> > >
> > >
> > > El vie., 17 abr. 2020 a las 10:38, Piotr Zarzycki (<
> > > piotrzarzyck...@gmail.com>) escribió:
> > >
> > > > I think it would be better to have it here in Router.
> > > >
> > > > pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> > > >
> > > > > Alternatively, you can subclass Router to support setting the
> > > parameters
> > > > > in the onInit method.
> > > > >
> > > > > Not sure which of these is best.
> > > > >
> > > > > > On Apr 17, 2020, at 10:35 AM, Harbs 
> wrote:
> > > > > >
> > > > > > Actually, it’s not going to work because the
> > > > > router.routeState.parameters will not be set.
> > > > > >
> > > > > > You will likely need to add code to set the
> > > > router.routeState.parameters
> > > > > using the part of the location after the question mark.
> > > > > >
> > > > > > The easiest way to do that would be to either:
> > > > > > 1. Modify RouteToParameters.stateChanged to first check that
> there
> > > is a
> > > > > parameters value and then set it if not.
> > > > > > 2. Subclass RouteToParameters and override stateChanged to make
> > that
> > > > > check first.
> > > > > >
> > > > > >> On Apr 17, 2020, at 10:29 AM, Harbs  >  > > > > harbs.li...@gmail.com>> wrote:
> > > > > >>
> > > > > >> I’m pretty sure it’ll work without the hash as well.
> > > > > >>
> > > > > >> Give it a try.
> > > > > >>
> > > > > >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> > > > > piotrzarzyck...@gmail.com >
> wrote:
> > > > > >>>
> > > > > >>> Hi Harbs,
> > > > > >>>
> > > > > >>> Thanks for pointing me out, but this is still that Routing
> > expects
> > > me
> > > > > to
> > > > > >>> use in url hashes - The question is - What if I can't use
> hashes,
> > > but
> > > > > url
> > > > > >>> looks like I have presented in previous email ?
> > > > > >>>
> > > > > >>> Thanks,
> > > > > >>> Piotr
> > > > > >>>
> > > > > >>> pt., 17 kwi 2020 o 09:20 Harbs  > > > > harbs.li...@gmail.com>> napisał(a):
> > > > > >>>
> > > > >  This app uses both path based and query based routing:
> > > > > 
> > > > > 
> > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> > > <
> > > > > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>
> <
> > > > > 
> > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> > > <
> > > > > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> >>
> > > > > 
> > > > >  You can see how it’s done here:
> > > > > 
> > > > >
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > > >
> > > > >  <
> > > > > 
> > > > >
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > > >
> > > > > >
> > > > > 
> > > > > > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> > > > > piotrzarzyck...@gmail.com >
> > > > >  wrote:
> > > > > >
> > > > > > I'm still looking into the code and it looks like Routing
> > > > > implemented now
> > > > > > is not doing what I would expected. Everything is based on
> > 

Re: Routing (was Re: Spectrum Components)

[Carlos Rovira]

Hi Piotr,

I'm not saying is not right what you're doing. Just pointing that maybe for
your use case adding all the Router sttuff is not worthit if you don't plan
to make a real router use far beyond adding those params. But I think if
there's some scenario not covered with passing params, we need to cover it.



El vie., 17 abr. 2020 a las 11:22, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:

> Hi Carlos,
>
> At some point you are right, but it was just really weird to me that Router
> has in state parameters property and it's empty. To me it looks like bug. I
> would be willing to set it properly in Router as Harbs suggested, but if
> you think it shouldn't be there - What would be the purpose of parameters
> property ?
>
> pt., 17 kwi 2020 o 11:09 Carlos Rovira 
> napisał(a):
>
> > Hi Piotr,
> >
> > based on the url you provide, URLParameterBead seems the best option
> right?
> > Or at least for the info you provided I don't see a SPA for now, just a
> > need to load some params to set a state.
> > If you need a full SPA, then is worth to add Routing and part of that
> could
> > be receive params.
> >
> > HTH
> >
> > Carlos
> >
> >
> > El vie., 17 abr. 2020 a las 10:38, Piotr Zarzycki (<
> > piotrzarzyck...@gmail.com>) escribió:
> >
> > > I think it would be better to have it here in Router.
> > >
> > > pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> > >
> > > > Alternatively, you can subclass Router to support setting the
> > parameters
> > > > in the onInit method.
> > > >
> > > > Not sure which of these is best.
> > > >
> > > > > On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> > > > >
> > > > > Actually, it’s not going to work because the
> > > > router.routeState.parameters will not be set.
> > > > >
> > > > > You will likely need to add code to set the
> > > router.routeState.parameters
> > > > using the part of the location after the question mark.
> > > > >
> > > > > The easiest way to do that would be to either:
> > > > > 1. Modify RouteToParameters.stateChanged to first check that there
> > is a
> > > > parameters value and then set it if not.
> > > > > 2. Subclass RouteToParameters and override stateChanged to make
> that
> > > > check first.
> > > > >
> > > > >> On Apr 17, 2020, at 10:29 AM, Harbs   > > > harbs.li...@gmail.com>> wrote:
> > > > >>
> > > > >> I’m pretty sure it’ll work without the hash as well.
> > > > >>
> > > > >> Give it a try.
> > > > >>
> > > > >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> > > > piotrzarzyck...@gmail.com > wrote:
> > > > >>>
> > > > >>> Hi Harbs,
> > > > >>>
> > > > >>> Thanks for pointing me out, but this is still that Routing
> expects
> > me
> > > > to
> > > > >>> use in url hashes - The question is - What if I can't use hashes,
> > but
> > > > url
> > > > >>> looks like I have presented in previous email ?
> > > > >>>
> > > > >>> Thanks,
> > > > >>> Piotr
> > > > >>>
> > > > >>> pt., 17 kwi 2020 o 09:20 Harbs  > > > harbs.li...@gmail.com>> napisał(a):
> > > > >>>
> > > >  This app uses both path based and query based routing:
> > > > 
> > > > 
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> > <
> > > > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark> <
> > > > 
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> > <
> > > > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>>
> > > > 
> > > >  You can see how it’s done here:
> > > > 
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > <
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > >
> > > >  <
> > > > 
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > <
> > > >
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > > >
> > > > >
> > > > 
> > > > > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> > > > piotrzarzyck...@gmail.com >
> > > >  wrote:
> > > > >
> > > > > I'm still looking into the code and it looks like Routing
> > > > implemented now
> > > > > is not doing what I would expected. Everything is based on
> "hash"
> > > >  property
> > > > > in "location". Instead I need something which is in "search" of
> > > >  location. I
> > > > > will wait for your thoughts before I do try to handle stuff on
> my
> > > > end.
> > > > >
> > > > > pt., 17 kwi 2020 o 08:30 Piotr Zarzycki <
> > piotrzarzyck...@gmail.com
> > > > >
> > > > > napisał(a):
> > > > >
> > > > >> Hi Guys,
> > > > >>
> > > > >> I really thought that I will be able to use Router [1] based
> on
> > > > >> documentation and maybe eventually some look 

Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

[Carlos Rovira]

Hi Yishay,

not sure but probably the empty file added will cause RAT problems with
maven
maybe you should see if that happens and at least add a license header

About content, since is taken from the git history I think is ok

thanks



El vie., 17 abr. 2020 a las 10:14, Yishay Weiss ()
escribió:

> Ok Carlos, thanks. I created RELEASE_NOTES.md under compiler-build-tools.
> I think the main contributors since 1.1 [1] are Alex and Chris so it would
> be great if they could add their comments there.
>
>
>
> [1] https://paste.apache.org/kmw0k
>
>
>
> *From:* Carlos Rovira 
> *Sent:* Wednesday, April 15, 2020 11:29:04 AM
> *To:* Apache Royale Development 
> *Subject:* Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development >
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1] https://github.com/takari/maven-wrapper
> > >
> > > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > If you're on Windows, and you happened to install Maven using the
> > > > Chocolatey package manager, you may need to tweak the
> > > ApproveBuildTools.xml
> > > > file to get it to work.
> > > >
> > > > Find this line:
> > > >
> > > > 
> > > >
> > > > And change it to this:
> > > >
> > > > 
> > > >
> > > > I think that most people will be fine, but I just wanted to mention
> it.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC 
> > > >
> > > >
> > > > On Mon, Apr 13, 2020 at 1:33 PM  wrote:
> > > >
> > > > > This is the discussion thread.
> > > > >
> > > > > Thanks,
> > > > > Yishay Weiss
> > > >
> > >
> > >
> > > --
> > > Carlos Rovira
> > > http://about.me/carlosrovira
> > >
> >
> >
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
> *From: *Carlos Rovira 
> *Sent: *Wednesday, April 15, 2020 11:29 AM
> *To: *Apache Royale Development 
> *Subject: *Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development >
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1] https://github.com/takari/maven-wrapper
> > >
> > > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > If you're on Windows, and you happened to install Maven using the
> > > > Chocolatey package manager, you may need to tweak the
> > > ApproveBuildTools.xml
> > > > file to get it to work.
> > > >
> > > > Find this line:
> > > 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

Hi Carlos,

At some point you are right, but it was just really weird to me that Router
has in state parameters property and it's empty. To me it looks like bug. I
would be willing to set it properly in Router as Harbs suggested, but if
you think it shouldn't be there - What would be the purpose of parameters
property ?

pt., 17 kwi 2020 o 11:09 Carlos Rovira  napisał(a):

> Hi Piotr,
>
> based on the url you provide, URLParameterBead seems the best option right?
> Or at least for the info you provided I don't see a SPA for now, just a
> need to load some params to set a state.
> If you need a full SPA, then is worth to add Routing and part of that could
> be receive params.
>
> HTH
>
> Carlos
>
>
> El vie., 17 abr. 2020 a las 10:38, Piotr Zarzycki (<
> piotrzarzyck...@gmail.com>) escribió:
>
> > I think it would be better to have it here in Router.
> >
> > pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
> >
> > > Alternatively, you can subclass Router to support setting the
> parameters
> > > in the onInit method.
> > >
> > > Not sure which of these is best.
> > >
> > > > On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> > > >
> > > > Actually, it’s not going to work because the
> > > router.routeState.parameters will not be set.
> > > >
> > > > You will likely need to add code to set the
> > router.routeState.parameters
> > > using the part of the location after the question mark.
> > > >
> > > > The easiest way to do that would be to either:
> > > > 1. Modify RouteToParameters.stateChanged to first check that there
> is a
> > > parameters value and then set it if not.
> > > > 2. Subclass RouteToParameters and override stateChanged to make that
> > > check first.
> > > >
> > > >> On Apr 17, 2020, at 10:29 AM, Harbs  > > harbs.li...@gmail.com>> wrote:
> > > >>
> > > >> I’m pretty sure it’ll work without the hash as well.
> > > >>
> > > >> Give it a try.
> > > >>
> > > >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> > > piotrzarzyck...@gmail.com > wrote:
> > > >>>
> > > >>> Hi Harbs,
> > > >>>
> > > >>> Thanks for pointing me out, but this is still that Routing expects
> me
> > > to
> > > >>> use in url hashes - The question is - What if I can't use hashes,
> but
> > > url
> > > >>> looks like I have presented in previous email ?
> > > >>>
> > > >>> Thanks,
> > > >>> Piotr
> > > >>>
> > > >>> pt., 17 kwi 2020 o 09:20 Harbs  > > harbs.li...@gmail.com>> napisał(a):
> > > >>>
> > >  This app uses both path based and query based routing:
> > > 
> > >  https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> <
> > > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark> <
> > >  https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark
> <
> > > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>>
> > > 
> > >  You can see how it’s done here:
> > > 
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > <
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > >
> > >  <
> > > 
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > <
> > >
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > > >
> > > >
> > > 
> > > > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> > > piotrzarzyck...@gmail.com >
> > >  wrote:
> > > >
> > > > I'm still looking into the code and it looks like Routing
> > > implemented now
> > > > is not doing what I would expected. Everything is based on "hash"
> > >  property
> > > > in "location". Instead I need something which is in "search" of
> > >  location. I
> > > > will wait for your thoughts before I do try to handle stuff on my
> > > end.
> > > >
> > > > pt., 17 kwi 2020 o 08:30 Piotr Zarzycki <
> piotrzarzyck...@gmail.com
> > > >
> > > > napisał(a):
> > > >
> > > >> Hi Guys,
> > > >>
> > > >> I really thought that I will be able to use Router [1] based on
> > > >> documentation and maybe eventually some look to the code [2] -
> to
> > > figure
> > > >> out how things should be implemented. However it looks like non
> of
> > > the
> > > >> existing stuff helps me to use in in real world application at
> > all.
> > > I
> > >  would
> > > >> like to throw a simple question.
> > > >>
> > > >> I would like to "answer" in my application to following url,
> catch
> > >  params
> > > >> and do some actions:
> > > >>
> > > >>
> > > https://mydomain.com/somefolder/index.html?target=somevalue= <
> > > https://mydomain.com/somefolder/index.html?target=somevalue=>
> > > >> <
> > > 
> > >
> >
> 

Re: Routing (was Re: Spectrum Components)

[Carlos Rovira]

Hi Piotr,

based on the url you provide, URLParameterBead seems the best option right?
Or at least for the info you provided I don't see a SPA for now, just a
need to load some params to set a state.
If you need a full SPA, then is worth to add Routing and part of that could
be receive params.

HTH

Carlos


El vie., 17 abr. 2020 a las 10:38, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:

> I think it would be better to have it here in Router.
>
> pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):
>
> > Alternatively, you can subclass Router to support setting the parameters
> > in the onInit method.
> >
> > Not sure which of these is best.
> >
> > > On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> > >
> > > Actually, it’s not going to work because the
> > router.routeState.parameters will not be set.
> > >
> > > You will likely need to add code to set the
> router.routeState.parameters
> > using the part of the location after the question mark.
> > >
> > > The easiest way to do that would be to either:
> > > 1. Modify RouteToParameters.stateChanged to first check that there is a
> > parameters value and then set it if not.
> > > 2. Subclass RouteToParameters and override stateChanged to make that
> > check first.
> > >
> > >> On Apr 17, 2020, at 10:29 AM, Harbs  > harbs.li...@gmail.com>> wrote:
> > >>
> > >> I’m pretty sure it’ll work without the hash as well.
> > >>
> > >> Give it a try.
> > >>
> > >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> > piotrzarzyck...@gmail.com > wrote:
> > >>>
> > >>> Hi Harbs,
> > >>>
> > >>> Thanks for pointing me out, but this is still that Routing expects me
> > to
> > >>> use in url hashes - The question is - What if I can't use hashes, but
> > url
> > >>> looks like I have presented in previous email ?
> > >>>
> > >>> Thanks,
> > >>> Piotr
> > >>>
> > >>> pt., 17 kwi 2020 o 09:20 Harbs  > harbs.li...@gmail.com>> napisał(a):
> > >>>
> >  This app uses both path based and query based routing:
> > 
> >  https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark> <
> >  https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> > https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>>
> > 
> >  You can see how it’s done here:
> > 
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > <
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > >
> >  <
> > 
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > <
> >
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> > >
> > >
> > 
> > > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> > piotrzarzyck...@gmail.com >
> >  wrote:
> > >
> > > I'm still looking into the code and it looks like Routing
> > implemented now
> > > is not doing what I would expected. Everything is based on "hash"
> >  property
> > > in "location". Instead I need something which is in "search" of
> >  location. I
> > > will wait for your thoughts before I do try to handle stuff on my
> > end.
> > >
> > > pt., 17 kwi 2020 o 08:30 Piotr Zarzycki  > >
> > > napisał(a):
> > >
> > >> Hi Guys,
> > >>
> > >> I really thought that I will be able to use Router [1] based on
> > >> documentation and maybe eventually some look to the code [2] - to
> > figure
> > >> out how things should be implemented. However it looks like non of
> > the
> > >> existing stuff helps me to use in in real world application at
> all.
> > I
> >  would
> > >> like to throw a simple question.
> > >>
> > >> I would like to "answer" in my application to following url, catch
> >  params
> > >> and do some actions:
> > >>
> > >>
> > https://mydomain.com/somefolder/index.html?target=somevalue= <
> > https://mydomain.com/somefolder/index.html?target=somevalue=>
> > >> <
> > 
> >
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> > <
> >
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> > >
> > >
> > >> somevalue
> > >>
> > >> How should I do that using Routing in Royale ? :)
> > >>
> > >> [1] https://apache.github.io/royale-docs/features/routing <
> > https://apache.github.io/royale-docs/features/routing>
> > >> [2]
> > >>
> > 
> >
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> > <
> >
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> > >
> > 

Build failed in Jenkins: royale-asjs_jsonly #1285

[apacheroyaleci]

See 


Changes:


--
[...truncated 1.58 MB...]
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.define+=GOOG::DEBUG,goog.DEBUG
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 08:51 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 429630 bytes written to 

 in 10.388 seconds
 [java] COMPCJSCRoyale
 [java] 
:
 col: 30 Warning: Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Warning: Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 30 Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/libs>

main:

copy-swc:

check-for-tests:

test:

main:

Crux:
 [echo] swc-date is 04/17/20 08:52 +

clean:
 [echo] swc-date is 04/17/20 08:52 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 04/17/20 08:52 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 08:52 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling CruxJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 08:52 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

I think it would be better to have it here in Router.

pt., 17 kwi 2020 o 09:37 Harbs  napisał(a):

> Alternatively, you can subclass Router to support setting the parameters
> in the onInit method.
>
> Not sure which of these is best.
>
> > On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> >
> > Actually, it’s not going to work because the
> router.routeState.parameters will not be set.
> >
> > You will likely need to add code to set the router.routeState.parameters
> using the part of the location after the question mark.
> >
> > The easiest way to do that would be to either:
> > 1. Modify RouteToParameters.stateChanged to first check that there is a
> parameters value and then set it if not.
> > 2. Subclass RouteToParameters and override stateChanged to make that
> check first.
> >
> >> On Apr 17, 2020, at 10:29 AM, Harbs  harbs.li...@gmail.com>> wrote:
> >>
> >> I’m pretty sure it’ll work without the hash as well.
> >>
> >> Give it a try.
> >>
> >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com > wrote:
> >>>
> >>> Hi Harbs,
> >>>
> >>> Thanks for pointing me out, but this is still that Routing expects me
> to
> >>> use in url hashes - The question is - What if I can't use hashes, but
> url
> >>> looks like I have presented in previous email ?
> >>>
> >>> Thanks,
> >>> Piotr
> >>>
> >>> pt., 17 kwi 2020 o 09:20 Harbs  harbs.li...@gmail.com>> napisał(a):
> >>>
>  This app uses both path based and query based routing:
> 
>  https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark> <
>  https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>>
> 
>  You can see how it’s done here:
> 
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> <
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> >
>  <
> 
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> <
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> >
> >
> 
> > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com >
>  wrote:
> >
> > I'm still looking into the code and it looks like Routing
> implemented now
> > is not doing what I would expected. Everything is based on "hash"
>  property
> > in "location". Instead I need something which is in "search" of
>  location. I
> > will wait for your thoughts before I do try to handle stuff on my
> end.
> >
> > pt., 17 kwi 2020 o 08:30 Piotr Zarzycki  >
> > napisał(a):
> >
> >> Hi Guys,
> >>
> >> I really thought that I will be able to use Router [1] based on
> >> documentation and maybe eventually some look to the code [2] - to
> figure
> >> out how things should be implemented. However it looks like non of
> the
> >> existing stuff helps me to use in in real world application at all.
> I
>  would
> >> like to throw a simple question.
> >>
> >> I would like to "answer" in my application to following url, catch
>  params
> >> and do some actions:
> >>
> >>
> https://mydomain.com/somefolder/index.html?target=somevalue= <
> https://mydomain.com/somefolder/index.html?target=somevalue=>
> >> <
> 
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> <
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> >
> >
> >> somevalue
> >>
> >> How should I do that using Routing in Royale ? :)
> >>
> >> [1] https://apache.github.io/royale-docs/features/routing <
> https://apache.github.io/royale-docs/features/routing>
> >> [2]
> >>
> 
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> <
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> >
> >>
> >> Thanks,
> >> Piotr
> >>
> >> śr., 22 sty 2020 o 13:08 Carlos Rovira 
> >> napisał(a):
> >>
> >>> Hi Harbs,
> >>>
> >>> thanks for taking a look, I'll try to apply your suggestions and
> see
>  if I
> >>> can make it work.
> >>>
> >>> If you plan to work in that new Routing implementation, I'll wait
> for
>  it
> >>> to
> >>> write about it in blog and social media, since better to point
> people
>  to
> >>> the more elaborated one. I as well recommend you to make it end in
> its
>  own
> >>> "Routing.swc" since I think it deserves it.
> >>>
> >>> As Alex dream on 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

I would like to make in  RouteToParameters methods which handle events
protected - Any objections to that ?

pt., 17 kwi 2020 o 10:14 Piotr Zarzycki 
napisał(a):

> Alex,
>
> I wanted to try out new stuff. I know about URLParameterBead, but I may
> use also some other features available in Routing itself.
>
> pt., 17 kwi 2020 o 10:02 Alex Harui  napisał(a):
>
>> Could Piotr use URLParameterBead?
>>
>> On 4/17/20, 12:37 AM, "Harbs"  wrote:
>>
>> Alternatively, you can subclass Router to support setting the
>> parameters in the onInit method.
>>
>> Not sure which of these is best.
>>
>> > On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
>> >
>> > Actually, it’s not going to work because the
>> router.routeState.parameters will not be set.
>> >
>> > You will likely need to add code to set the
>> router.routeState.parameters using the part of the location after the
>> question mark.
>> >
>> > The easiest way to do that would be to either:
>> > 1. Modify RouteToParameters.stateChanged to first check that there
>> is a parameters value and then set it if not.
>> > 2. Subclass RouteToParameters and override stateChanged to make
>> that check first.
>> >
>> >> On Apr 17, 2020, at 10:29 AM, Harbs > > wrote:
>> >>
>> >> I’m pretty sure it’ll work without the hash as well.
>> >>
>> >> Give it a try.
>> >>
>> >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
>> piotrzarzyck...@gmail.com > wrote:
>> >>>
>> >>> Hi Harbs,
>> >>>
>> >>> Thanks for pointing me out, but this is still that Routing
>> expects me to
>> >>> use in url hashes - The question is - What if I can't use hashes,
>> but url
>> >>> looks like I have presented in previous email ?
>> >>>
>> >>> Thanks,
>> >>> Piotr
>> >>>
>> >>> pt., 17 kwi 2020 o 09:20 Harbs > harbs.li...@gmail.com>> napisał(a):
>> >>>
>>  This app uses both path based and query based routing:
>> 
>> 
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
>> <
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0>
>> <
>> 
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
>> <
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
>> >>
>> 
>>  You can see how it’s done here:
>> 
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
>> <
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
>> >
>>  <
>> 
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
>> <
>> 

Royale_Release_Step_010 - Build # 3 - Failure!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 3 - Failure:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/3/
 to view the results.

Build failed in Jenkins: royale-asjs_jsonly #1284

[apacheroyaleci]

See 


Changes:

[aharui] Revert "[maven-release-plugin] prepare for next development iteration"

[aharui] Revert "[maven-release-plugin] prepare branch @{releaseLabel}"

[aharui] [maven-release-plugin] prepare branch @{releaseLabel}

[aharui] [maven-release-plugin] prepare for next development iteration


--
[...truncated 1.58 MB...]
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.define+=GOOG::DEBUG,goog.DEBUG
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 08:15 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 
:
 col: 30 Warning: Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Warning: Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/projects/SparkRoyaleJS/target/SparkRoyaleJS.swc>
 in 19.127 seconds
 [java] COMPCJSCRoyale
 [java] 
:
 col: 30 Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/libs>

main:

copy-swc:

check-for-tests:

test:

main:

Crux:
 [echo] swc-date is 04/17/20 08:15 +

clean:
 [echo] swc-date is 04/17/20 08:15 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 04/17/20 08:15 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 08:15 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling CruxJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 08:15 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

Alex,

I wanted to try out new stuff. I know about URLParameterBead, but I may use
also some other features available in Routing itself.

pt., 17 kwi 2020 o 10:02 Alex Harui  napisał(a):

> Could Piotr use URLParameterBead?
>
> On 4/17/20, 12:37 AM, "Harbs"  wrote:
>
> Alternatively, you can subclass Router to support setting the
> parameters in the onInit method.
>
> Not sure which of these is best.
>
> > On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> >
> > Actually, it’s not going to work because the
> router.routeState.parameters will not be set.
> >
> > You will likely need to add code to set the
> router.routeState.parameters using the part of the location after the
> question mark.
> >
> > The easiest way to do that would be to either:
> > 1. Modify RouteToParameters.stateChanged to first check that there
> is a parameters value and then set it if not.
> > 2. Subclass RouteToParameters and override stateChanged to make that
> check first.
> >
> >> On Apr 17, 2020, at 10:29 AM, Harbs  harbs.li...@gmail.com>> wrote:
> >>
> >> I’m pretty sure it’ll work without the hash as well.
> >>
> >> Give it a try.
> >>
> >>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com > wrote:
> >>>
> >>> Hi Harbs,
> >>>
> >>> Thanks for pointing me out, but this is still that Routing expects
> me to
> >>> use in url hashes - The question is - What if I can't use hashes,
> but url
> >>> looks like I have presented in previous email ?
> >>>
> >>> Thanks,
> >>> Piotr
> >>>
> >>> pt., 17 kwi 2020 o 09:20 Harbs  harbs.li...@gmail.com>> napisał(a):
> >>>
>  This app uses both path based and query based routing:
> 
> 
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
> <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0>
> <
> 
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
> <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
> >>
> 
>  You can see how it’s done here:
> 
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
> <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
> >
>  <
> 
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
> <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
> >
> >
> 
> > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com >
>  wrote:
> >
> > I'm still looking into 

RE: [DISCUSS] Discuss Release Apache Royale 1.2.0

[Yishay Weiss]

Ok Carlos, thanks. I created RELEASE_NOTES.md under compiler-build-tools. I 
think the main contributors since 1.1 [1] are Alex and Chris so it would be 
great if they could add their comments there.

[1] https://paste.apache.org/kmw0k


From: Carlos Rovira 
Sent: Wednesday, April 15, 2020 11:29:04 AM
To: Apache Royale Development 
Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

Hi Yishay,

build tools and jburg was never released on its own before. Always was part
of the global royale release. This is the first time we do this.

Thanks

El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
escribió:

> I’ve just noticed the subject should be changed to
>
> [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> bug in CI step 6.
>
> Anyway, the vote has passed. I haven’t seen previous announcements on
> compiler build tools. Has this been done in the past? Can anyone point me
> to an example?
>
> Thanks.
>
> From: Greg Dove
> Sent: Tuesday, April 14, 2020 9:27 PM
> To: Apache Royale Development
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
> fyi I can't get to this until my current EOD, about 12 hours from now. I
> will remind myself what I need to do and check it then and vote, if the
> voting is still open (I understand it may not be, as I think the threshold
> was already passed).
>
>
>
> On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> wrote:
>
> > Remember that we have Maven Wrapper [1] in our repo so if you don't have
> > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> that
> > will install maven for you :)
> >
> > [1] https://github.com/takari/maven-wrapper
> >
> > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > joshtynj...@bowlerhat.dev>)
> > escribió:
> >
> > > If you're on Windows, and you happened to install Maven using the
> > > Chocolatey package manager, you may need to tweak the
> > ApproveBuildTools.xml
> > > file to get it to work.
> > >
> > > Find this line:
> > >
> > > 
> > >
> > > And change it to this:
> > >
> > > 
> > >
> > > I think that most people will be fine, but I just wanted to mention it.
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Mon, Apr 13, 2020 at 1:33 PM  wrote:
> > >
> > > > This is the discussion thread.
> > > >
> > > > Thanks,
> > > > Yishay Weiss
> > >
> >
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
>
>

--
Carlos Rovira
http://about.me/carlosrovira
From: Carlos Rovira
Sent: Wednesday, April 15, 2020 11:29 AM
To: Apache Royale Development
Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

Hi Yishay,

build tools and jburg was never released on its own before. Always was part
of the global royale release. This is the first time we do this.

Thanks

El mié., 15 abr. 2020 a las 10:21, Yishay Weiss ()
escribió:

> I’ve just noticed the subject should be changed to
>
> [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> bug in CI step 6.
>
> Anyway, the vote has passed. I haven’t seen previous announcements on
> compiler build tools. Has this been done in the past? Can anyone point me
> to an example?
>
> Thanks.
>
> From: Greg Dove
> Sent: Tuesday, April 14, 2020 9:27 PM
> To: Apache Royale Development
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
> fyi I can't get to this until my current EOD, about 12 hours from now. I
> will remind myself what I need to do and check it then and vote, if the
> voting is still open (I understand it may not be, as I think the threshold
> was already passed).
>
>
>
> On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira 
> wrote:
>
> > Remember that we have Maven Wrapper [1] in our repo so if you don't have
> > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> that
> > will install maven for you :)
> >
> > [1] https://github.com/takari/maven-wrapper
> >
> > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > joshtynj...@bowlerhat.dev>)
> > escribió:
> >
> > > If you're on Windows, and you happened to install Maven using the
> > > Chocolatey package manager, you may need to tweak the
> > ApproveBuildTools.xml
> > > file to get it to work.
> > >
> > > Find this line:
> > >
> > > 
> > >
> > > And change it to this:
> > >
> > > 
> > >
> > > I think that most people will be fine, but I just wanted to mention it.
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Mon, Apr 13, 2020 at 1:33 PM  wrote:
> > >
> > > > This is the discussion thread.
> > > >
> > > > Thanks,
> > > > Yishay Weiss
> > >
> >
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
>
>

--
Carlos Rovira
http://about.me/carlosrovira

Re: Routing (was Re: Spectrum Components)

[Alex Harui]

Could Piotr use URLParameterBead?

On 4/17/20, 12:37 AM, "Harbs"  wrote:

Alternatively, you can subclass Router to support setting the parameters in 
the onInit method.

Not sure which of these is best.

> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> 
> Actually, it’s not going to work because the router.routeState.parameters 
will not be set.
> 
> You will likely need to add code to set the router.routeState.parameters 
using the part of the location after the question mark.
> 
> The easiest way to do that would be to either:
> 1. Modify RouteToParameters.stateChanged to first check that there is a 
parameters value and then set it if not.
> 2. Subclass RouteToParameters and override stateChanged to make that 
check first.
> 
>> On Apr 17, 2020, at 10:29 AM, Harbs mailto:harbs.li...@gmail.com>> wrote:
>> 
>> I’m pretty sure it’ll work without the hash as well.
>> 
>> Give it a try.
>> 
>>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki mailto:piotrzarzyck...@gmail.com>> wrote:
>>> 
>>> Hi Harbs,
>>> 
>>> Thanks for pointing me out, but this is still that Routing expects me to
>>> use in url hashes - The question is - What if I can't use hashes, but 
url
>>> looks like I have presented in previous email ?
>>> 
>>> Thanks,
>>> Piotr
>>> 
>>> pt., 17 kwi 2020 o 09:20 Harbs mailto:harbs.li...@gmail.com>> napisał(a):
>>> 
 This app uses both path based and query based routing:
 
 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
 

 <
 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Funhurdle.github.io%2Fspectrum-royale%2F%23!asset%3Fcolorstop%3Ddarkdata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=J0%2B2oe8aWAsHB2eCgOHVeixDBX%2FIqifp60yX6W3ZCmk%3Dreserved=0
 
>
 
 You can see how it’s done here:
 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
 

 <
 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funhurdle%2Fspectrum-royale%2Fblob%2Fmaster%2FSpectrumBrowser%2Fsrc%2Fview%2FBrowserRouter.mxmldata=02%7C01%7Caharui%40adobe.com%7C5e655077c66b4a94f55f08d7e2a224a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227058344292469sdata=O%2FoVVZWDijp7CejxncZo7vH0DPeQsw7dudhb19cUzo4%3Dreserved=0
 

> 
 
> On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki 
mailto:piotrzarzyck...@gmail.com>>
 wrote:
> 
> I'm still looking into the code and it looks like Routing implemented 
now
> is not doing what I would expected. Everything is based on "hash"
 property
> in "location". Instead I need something which is in "search" of
 location. I
> will wait for your thoughts before I do try to handle stuff on my end.
> 
> pt., 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

Thanks for pointing it out. Do you suggest me to change framework code or
your suggestion is something which I should rather do on my application ?

pt., 17 kwi 2020 o 09:35 Harbs  napisał(a):

> Actually, it’s not going to work because the router.routeState.parameters
> will not be set.
>
> You will likely need to add code to set the router.routeState.parameters
> using the part of the location after the question mark.
>
> The easiest way to do that would be to either:
> 1. Modify RouteToParameters.stateChanged to first check that there is a
> parameters value and then set it if not.
> 2. Subclass RouteToParameters and override stateChanged to make that check
> first.
>
> > On Apr 17, 2020, at 10:29 AM, Harbs  wrote:
> >
> > I’m pretty sure it’ll work without the hash as well.
> >
> > Give it a try.
> >
> >> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki  > wrote:
> >>
> >> Hi Harbs,
> >>
> >> Thanks for pointing me out, but this is still that Routing expects me to
> >> use in url hashes - The question is - What if I can't use hashes, but
> url
> >> looks like I have presented in previous email ?
> >>
> >> Thanks,
> >> Piotr
> >>
> >> pt., 17 kwi 2020 o 09:20 Harbs  harbs.li...@gmail.com>> napisał(a):
> >>
> >>> This app uses both path based and query based routing:
> >>>
> >>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark> <
> >>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>>
> >>>
> >>> You can see how it’s done here:
> >>>
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> <
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> >
> >>> <
> >>>
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> <
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> >
> 
> >>>
>  On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com >
> >>> wrote:
> 
>  I'm still looking into the code and it looks like Routing implemented
> now
>  is not doing what I would expected. Everything is based on "hash"
> >>> property
>  in "location". Instead I need something which is in "search" of
> >>> location. I
>  will wait for your thoughts before I do try to handle stuff on my end.
> 
>  pt., 17 kwi 2020 o 08:30 Piotr Zarzycki  >
>  napisał(a):
> 
> > Hi Guys,
> >
> > I really thought that I will be able to use Router [1] based on
> > documentation and maybe eventually some look to the code [2] - to
> figure
> > out how things should be implemented. However it looks like non of
> the
> > existing stuff helps me to use in in real world application at all. I
> >>> would
> > like to throw a simple question.
> >
> > I would like to "answer" in my application to following url, catch
> >>> params
> > and do some actions:
> >
> > https://mydomain.com/somefolder/index.html?target=somevalue=
> 
> > <
> >>>
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> <
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> >
> 
> > somevalue
> >
> > How should I do that using Routing in Royale ? :)
> >
> > [1] https://apache.github.io/royale-docs/features/routing
> > [2]
> >
> >>>
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> >
> > Thanks,
> > Piotr
> >
> > śr., 22 sty 2020 o 13:08 Carlos Rovira 
> > napisał(a):
> >
> >> Hi Harbs,
> >>
> >> thanks for taking a look, I'll try to apply your suggestions and see
> >>> if I
> >> can make it work.
> >>
> >> If you plan to work in that new Routing implementation, I'll wait
> for
> >>> it
> >> to
> >> write about it in blog and social media, since better to point
> people
> >>> to
> >> the more elaborated one. I as well recommend you to make it end in
> its
> >>> own
> >> "Routing.swc" since I think it deserves it.
> >>
> >> As Alex dream on possibilities, I want as well to dream and I think
> >> nowadays, a part from pure client navigation, we have server
> >>> navigation,
> >> and as other royale features people will soon try to do it. In the
> >>> case of
> >> Routing, people will want to have URLs for concrete items retrieved
> >>> from
> >> database and we should support it (was what we discussed before
> that in
> >> that case, we'll be able to not have # in the 

Re: Routing (was Re: Spectrum Components)

[Harbs]

Alternatively, you can subclass Router to support setting the parameters in the 
onInit method.

Not sure which of these is best.

> On Apr 17, 2020, at 10:35 AM, Harbs  wrote:
> 
> Actually, it’s not going to work because the router.routeState.parameters 
> will not be set.
> 
> You will likely need to add code to set the router.routeState.parameters 
> using the part of the location after the question mark.
> 
> The easiest way to do that would be to either:
> 1. Modify RouteToParameters.stateChanged to first check that there is a 
> parameters value and then set it if not.
> 2. Subclass RouteToParameters and override stateChanged to make that check 
> first.
> 
>> On Apr 17, 2020, at 10:29 AM, Harbs > > wrote:
>> 
>> I’m pretty sure it’ll work without the hash as well.
>> 
>> Give it a try.
>> 
>>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki >> > wrote:
>>> 
>>> Hi Harbs,
>>> 
>>> Thanks for pointing me out, but this is still that Routing expects me to
>>> use in url hashes - The question is - What if I can't use hashes, but url
>>> looks like I have presented in previous email ?
>>> 
>>> Thanks,
>>> Piotr
>>> 
>>> pt., 17 kwi 2020 o 09:20 Harbs >> > napisał(a):
>>> 
 This app uses both path based and query based routing:
 
 https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 
  <
 https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 
 >
 
 You can see how it’s done here:
 https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
  
 
 <
 https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
  
 
> 
 
> On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki  >
 wrote:
> 
> I'm still looking into the code and it looks like Routing implemented now
> is not doing what I would expected. Everything is based on "hash"
 property
> in "location". Instead I need something which is in "search" of
 location. I
> will wait for your thoughts before I do try to handle stuff on my end.
> 
> pt., 17 kwi 2020 o 08:30 Piotr Zarzycki  >
> napisał(a):
> 
>> Hi Guys,
>> 
>> I really thought that I will be able to use Router [1] based on
>> documentation and maybe eventually some look to the code [2] - to figure
>> out how things should be implemented. However it looks like non of the
>> existing stuff helps me to use in in real world application at all. I
 would
>> like to throw a simple question.
>> 
>> I would like to "answer" in my application to following url, catch
 params
>> and do some actions:
>> 
>> https://mydomain.com/somefolder/index.html?target=somevalue= 
>> 
>> <
 https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
  
 
> 
>> somevalue
>> 
>> How should I do that using Routing in Royale ? :)
>> 
>> [1] https://apache.github.io/royale-docs/features/routing 
>> 
>> [2]
>> 
 https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
  
 
>> 
>> Thanks,
>> Piotr
>> 
>> śr., 22 sty 2020 o 13:08 Carlos Rovira 
>> napisał(a):
>> 
>>> Hi Harbs,
>>> 
>>> thanks for taking a look, I'll try to apply your suggestions and see
 if I
>>> can make it work.
>>> 
>>> If you plan to work in that new Routing implementation, I'll wait for
 it
>>> to
>>> write about it in blog and social media, since better to point people
 to
>>> the more elaborated one. I as well recommend you to make it end in its
 own
>>> "Routing.swc" since I think it deserves it.
>>> 
>>> As Alex dream on possibilities, I want as well to dream and I think
>>> nowadays, a part from pure client navigation, we have server
 navigation,
>>> and as other royale features people will soon try to do it. In the
 case of
>>> Routing, people will want to have URLs for concrete items retrieved

Re: Routing (was Re: Spectrum Components)

[Harbs]

Actually, it’s not going to work because the router.routeState.parameters will 
not be set.

You will likely need to add code to set the router.routeState.parameters using 
the part of the location after the question mark.

The easiest way to do that would be to either:
1. Modify RouteToParameters.stateChanged to first check that there is a 
parameters value and then set it if not.
2. Subclass RouteToParameters and override stateChanged to make that check 
first.

> On Apr 17, 2020, at 10:29 AM, Harbs  wrote:
> 
> I’m pretty sure it’ll work without the hash as well.
> 
> Give it a try.
> 
>> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki > > wrote:
>> 
>> Hi Harbs,
>> 
>> Thanks for pointing me out, but this is still that Routing expects me to
>> use in url hashes - The question is - What if I can't use hashes, but url
>> looks like I have presented in previous email ?
>> 
>> Thanks,
>> Piotr
>> 
>> pt., 17 kwi 2020 o 09:20 Harbs > > napisał(a):
>> 
>>> This app uses both path based and query based routing:
>>> 
>>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 
>>>  <
>>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 
>>> >
>>> 
>>> You can see how it’s done here:
>>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>>>  
>>> 
>>> <
>>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>>>  
>>> 
 
>>> 
 On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki >>> >
>>> wrote:
 
 I'm still looking into the code and it looks like Routing implemented now
 is not doing what I would expected. Everything is based on "hash"
>>> property
 in "location". Instead I need something which is in "search" of
>>> location. I
 will wait for your thoughts before I do try to handle stuff on my end.
 
 pt., 17 kwi 2020 o 08:30 Piotr Zarzycki >>> >
 napisał(a):
 
> Hi Guys,
> 
> I really thought that I will be able to use Router [1] based on
> documentation and maybe eventually some look to the code [2] - to figure
> out how things should be implemented. However it looks like non of the
> existing stuff helps me to use in in real world application at all. I
>>> would
> like to throw a simple question.
> 
> I would like to "answer" in my application to following url, catch
>>> params
> and do some actions:
> 
> https://mydomain.com/somefolder/index.html?target=somevalue= 
> 
> <
>>> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
>>>  
>>> 
 
> somevalue
> 
> How should I do that using Routing in Royale ? :)
> 
> [1] https://apache.github.io/royale-docs/features/routing
> [2]
> 
>>> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> 
> Thanks,
> Piotr
> 
> śr., 22 sty 2020 o 13:08 Carlos Rovira 
> napisał(a):
> 
>> Hi Harbs,
>> 
>> thanks for taking a look, I'll try to apply your suggestions and see
>>> if I
>> can make it work.
>> 
>> If you plan to work in that new Routing implementation, I'll wait for
>>> it
>> to
>> write about it in blog and social media, since better to point people
>>> to
>> the more elaborated one. I as well recommend you to make it end in its
>>> own
>> "Routing.swc" since I think it deserves it.
>> 
>> As Alex dream on possibilities, I want as well to dream and I think
>> nowadays, a part from pure client navigation, we have server
>>> navigation,
>> and as other royale features people will soon try to do it. In the
>>> case of
>> Routing, people will want to have URLs for concrete items retrieved
>>> from
>> database and we should support it (was what we discussed before that in
>> that case, we'll be able to not have # in the url but just a friendly
>> permalink). Hope we can support that, since we'll be great to create,
>>> lets
>> say, a blog app, and as user browse posts and navigate to see a full
>> posst,
>> he gets as well a friendly URL with no anchors that can be indexable by
>> google and retrieved (i.e, the same as Wordpress)
>> 
>> Thanks
>> 
>> 
>> 
>> 
>> 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

My url already have a proper look. I wanted to have it like that
https://mydomain.com/somefolder/index.html?target=somevalue=

somevalue

pt., 17 kwi 2020 o 09:15 Alex Harui  napisał(a):

> What do you want your URLs to look like?  Remember that hash is used to
> keep the browser from reloading the app.
>
> On 4/17/20, 12:13 AM, "Piotr Zarzycki"  wrote:
>
> I'm still looking into the code and it looks like Routing implemented
> now
> is not doing what I would expected. Everything is based on "hash"
> property
> in "location". Instead I need something which is in "search" of
> location. I
> will wait for your thoughts before I do try to handle stuff on my end.
>
> pt., 17 kwi 2020 o 08:30 Piotr Zarzycki 
> napisał(a):
>
> > Hi Guys,
> >
> > I really thought that I will be able to use Router [1] based on
> > documentation and maybe eventually some look to the code [2] - to
> figure
> > out how things should be implemented. However it looks like non of
> the
> > existing stuff helps me to use in in real world application at all.
> I would
> > like to throw a simple question.
> >
> > I would like to "answer" in my application to following url, catch
> params
> > and do some actions:
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmydomain.com%2Fsomefolder%2Findex.html%3Ftarget%3Dsomevalue%26account%3Ddata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=Dv%2FfoygkOuy8EWX3yajDig8oYM9d7ZgqUOGohQd37og%3Dreserved=0
> > <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flocaldev.prominic.net%2Fprominic%2Fbin%2Fjs-debug%2Findex.html%3Ftarget%3DUpdateCreditCard%26account%3DA55XXXdata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=OW%2BlL31bVS%2FUSwL3GJrUAN7ppdjLjYPueWlLqFXQxwA%3Dreserved=0
> >
> > somevalue
> >
> > How should I do that using Routing in Royale ? :)
> >
> > [1]
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapache.github.io%2Froyale-docs%2Ffeatures%2Froutingdata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=%2Bq64VNDap48GgbtQtGnIKFQhasrk%2FXb5%2B0bqiTXs328%3Dreserved=0
> > [2]
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Ftree%2Fdevelop%2Fframeworks%2Fprojects%2FBasic%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Froutingdata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=dbfGXbu79kwYBWPwd4i0meomYPr616KOKMT6ok%2FVwX8%3Dreserved=0
> >
> > Thanks,
> > Piotr
> >
> > śr., 22 sty 2020 o 13:08 Carlos Rovira 
> > napisał(a):
> >
> >> Hi Harbs,
> >>
> >> thanks for taking a look, I'll try to apply your suggestions and
> see if I
> >> can make it work.
> >>
> >> If you plan to work in that new Routing implementation, I'll wait
> for it
> >> to
> >> write about it in blog and social media, since better to point
> people to
> >> the more elaborated one. I as well recommend you to make it end in
> its own
> >> "Routing.swc" since I think it deserves it.
> >>
> >> As Alex dream on possibilities, I want as well to dream and I think
> >> nowadays, a part from pure client navigation, we have server
> navigation,
> >> and as other royale features people will soon try to do it. In the
> case of
> >> Routing, people will want to have URLs for concrete items retrieved
> from
> >> database and we should support it (was what we discussed before
> that in
> >> that case, we'll be able to not have # in the url but just a
> friendly
> >> permalink). Hope we can support that, since we'll be great to
> create, lets
> >> say, a blog app, and as user browse posts and navigate to see a full
> >> posst,
> >> he gets as well a friendly URL with no anchors that can be
> indexable by
> >> google and retrieved (i.e, the same as Wordpress)
> >>
> >> Thanks
> >>
> >>
> >>
> >>
> >>
> >> El mar., 21 ene. 2020 a las 23:57, Alex Harui
> ( >> >)
> >> escribió:
> >>
> >> > If we're dreaming of the future possible implementations, one
> vision is
> >> > that the route paths are computed from the currentStates of
> Containers.
> >> > That might have the least setup required, it would almost be
> automatic.
> >> >
> >> > IOW, Containers have both a label and currentState property. A
> routing
> >> > implementation could scan the DOM for contaners and build the
> path from
> >> > label/currentState 

Re: Routing (was Re: Spectrum Components)

[Harbs]

I’m pretty sure it’ll work without the hash as well.

Give it a try.

> On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki  
> wrote:
> 
> Hi Harbs,
> 
> Thanks for pointing me out, but this is still that Routing expects me to
> use in url hashes - The question is - What if I can't use hashes, but url
> looks like I have presented in previous email ?
> 
> Thanks,
> Piotr
> 
> pt., 17 kwi 2020 o 09:20 Harbs  > napisał(a):
> 
>> This app uses both path based and query based routing:
>> 
>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 
>>  <
>> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 
>> >
>> 
>> You can see how it’s done here:
>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>>  
>> 
>> <
>> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
>>  
>> 
>>> 
>> 
>>> On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki 
>> wrote:
>>> 
>>> I'm still looking into the code and it looks like Routing implemented now
>>> is not doing what I would expected. Everything is based on "hash"
>> property
>>> in "location". Instead I need something which is in "search" of
>> location. I
>>> will wait for your thoughts before I do try to handle stuff on my end.
>>> 
>>> pt., 17 kwi 2020 o 08:30 Piotr Zarzycki 
>>> napisał(a):
>>> 
 Hi Guys,
 
 I really thought that I will be able to use Router [1] based on
 documentation and maybe eventually some look to the code [2] - to figure
 out how things should be implemented. However it looks like non of the
 existing stuff helps me to use in in real world application at all. I
>> would
 like to throw a simple question.
 
 I would like to "answer" in my application to following url, catch
>> params
 and do some actions:
 
 https://mydomain.com/somefolder/index.html?target=somevalue=
 <
>> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
>>> 
 somevalue
 
 How should I do that using Routing in Royale ? :)
 
 [1] https://apache.github.io/royale-docs/features/routing
 [2]
 
>> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
 
 Thanks,
 Piotr
 
 śr., 22 sty 2020 o 13:08 Carlos Rovira 
 napisał(a):
 
> Hi Harbs,
> 
> thanks for taking a look, I'll try to apply your suggestions and see
>> if I
> can make it work.
> 
> If you plan to work in that new Routing implementation, I'll wait for
>> it
> to
> write about it in blog and social media, since better to point people
>> to
> the more elaborated one. I as well recommend you to make it end in its
>> own
> "Routing.swc" since I think it deserves it.
> 
> As Alex dream on possibilities, I want as well to dream and I think
> nowadays, a part from pure client navigation, we have server
>> navigation,
> and as other royale features people will soon try to do it. In the
>> case of
> Routing, people will want to have URLs for concrete items retrieved
>> from
> database and we should support it (was what we discussed before that in
> that case, we'll be able to not have # in the url but just a friendly
> permalink). Hope we can support that, since we'll be great to create,
>> lets
> say, a blog app, and as user browse posts and navigate to see a full
> posst,
> he gets as well a friendly URL with no anchors that can be indexable by
> google and retrieved (i.e, the same as Wordpress)
> 
> Thanks
> 
> 
> 
> 
> 
> El mar., 21 ene. 2020 a las 23:57, Alex Harui
>> (> )
> escribió:
> 
>> If we're dreaming of the future possible implementations, one vision
>> is
>> that the route paths are computed from the currentStates of
>> Containers.
>> That might have the least setup required, it would almost be
>> automatic.
>> 
>> IOW, Containers have both a label and currentState property. A routing
>> implementation could scan the DOM for contaners and build the path
>> from
>> label/currentState pairs.
>> 
>> Of course, I could be wrong...
>> 
>> -Alex
>> 
>> 
>> On 1/21/20, 1:33 PM, "Harbs"  wrote:
>> 
>>   I’ve also been thinking about the router in general, and I came up
>> with an idea on how to do it with beads.
>> 
>>   It’ll probably take me a few days until I implement the changes…
>> 
>>   In addition to , I think we can also 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

Hi Harbs,

Thanks for pointing me out, but this is still that Routing expects me to
use in url hashes - The question is - What if I can't use hashes, but url
looks like I have presented in previous email ?

Thanks,
Piotr

pt., 17 kwi 2020 o 09:20 Harbs  napisał(a):

> This app uses both path based and query based routing:
>
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark <
> https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark>
>
> You can see how it’s done here:
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> <
> https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
> >
>
> > On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki 
> wrote:
> >
> > I'm still looking into the code and it looks like Routing implemented now
> > is not doing what I would expected. Everything is based on "hash"
> property
> > in "location". Instead I need something which is in "search" of
> location. I
> > will wait for your thoughts before I do try to handle stuff on my end.
> >
> > pt., 17 kwi 2020 o 08:30 Piotr Zarzycki 
> > napisał(a):
> >
> >> Hi Guys,
> >>
> >> I really thought that I will be able to use Router [1] based on
> >> documentation and maybe eventually some look to the code [2] - to figure
> >> out how things should be implemented. However it looks like non of the
> >> existing stuff helps me to use in in real world application at all. I
> would
> >> like to throw a simple question.
> >>
> >> I would like to "answer" in my application to following url, catch
> params
> >> and do some actions:
> >>
> >> https://mydomain.com/somefolder/index.html?target=somevalue=
> >> <
> https://localdev.prominic.net/prominic/bin/js-debug/index.html?target=UpdateCreditCard=A55XXX
> >
> >> somevalue
> >>
> >> How should I do that using Routing in Royale ? :)
> >>
> >> [1] https://apache.github.io/royale-docs/features/routing
> >> [2]
> >>
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
> >>
> >> Thanks,
> >> Piotr
> >>
> >> śr., 22 sty 2020 o 13:08 Carlos Rovira 
> >> napisał(a):
> >>
> >>> Hi Harbs,
> >>>
> >>> thanks for taking a look, I'll try to apply your suggestions and see
> if I
> >>> can make it work.
> >>>
> >>> If you plan to work in that new Routing implementation, I'll wait for
> it
> >>> to
> >>> write about it in blog and social media, since better to point people
> to
> >>> the more elaborated one. I as well recommend you to make it end in its
> own
> >>> "Routing.swc" since I think it deserves it.
> >>>
> >>> As Alex dream on possibilities, I want as well to dream and I think
> >>> nowadays, a part from pure client navigation, we have server
> navigation,
> >>> and as other royale features people will soon try to do it. In the
> case of
> >>> Routing, people will want to have URLs for concrete items retrieved
> from
> >>> database and we should support it (was what we discussed before that in
> >>> that case, we'll be able to not have # in the url but just a friendly
> >>> permalink). Hope we can support that, since we'll be great to create,
> lets
> >>> say, a blog app, and as user browse posts and navigate to see a full
> >>> posst,
> >>> he gets as well a friendly URL with no anchors that can be indexable by
> >>> google and retrieved (i.e, the same as Wordpress)
> >>>
> >>> Thanks
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> El mar., 21 ene. 2020 a las 23:57, Alex Harui
> (  )
> >>> escribió:
> >>>
>  If we're dreaming of the future possible implementations, one vision
> is
>  that the route paths are computed from the currentStates of
> Containers.
>  That might have the least setup required, it would almost be
> automatic.
> 
>  IOW, Containers have both a label and currentState property. A routing
>  implementation could scan the DOM for contaners and build the path
> from
>  label/currentState pairs.
> 
>  Of course, I could be wrong...
> 
>  -Alex
> 
> 
>  On 1/21/20, 1:33 PM, "Harbs"  wrote:
> 
> I’ve also been thinking about the router in general, and I came up
>  with an idea on how to do it with beads.
> 
> It’ll probably take me a few days until I implement the changes…
> 
> In addition to , I think we can also offer
>   which would allow different routers to be attached to
>  different places in the application and each level of the hierarchy
> can
>  take care of its own state.
> 
> Harbs
> 
> > On Jan 21, 2020, at 11:29 PM, Harbs 
> >>> wrote:
> >
> > FWIW, I’d like to write a version of a router which allows for
> >>> more
>  declarative syntax for routing to components.
> >
> > Something like this:
> > 
> > 
> > 
> >  >>> state=“layouts_panel”
>  title=“Layouts”/>
> >   title=“Grids”/>
> >  >>> state=“button_panel”
>  

Re: Routing (was Re: Spectrum Components)

[Harbs]

This app uses both path based and query based routing:

https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark 


You can see how it’s done here: 
https://github.com/unhurdle/spectrum-royale/blob/master/SpectrumBrowser/src/view/BrowserRouter.mxml
 


> On Apr 17, 2020, at 10:13 AM, Piotr Zarzycki  
> wrote:
> 
> I'm still looking into the code and it looks like Routing implemented now
> is not doing what I would expected. Everything is based on "hash" property
> in "location". Instead I need something which is in "search" of location. I
> will wait for your thoughts before I do try to handle stuff on my end.
> 
> pt., 17 kwi 2020 o 08:30 Piotr Zarzycki 
> napisał(a):
> 
>> Hi Guys,
>> 
>> I really thought that I will be able to use Router [1] based on
>> documentation and maybe eventually some look to the code [2] - to figure
>> out how things should be implemented. However it looks like non of the
>> existing stuff helps me to use in in real world application at all. I would
>> like to throw a simple question.
>> 
>> I would like to "answer" in my application to following url, catch params
>> and do some actions:
>> 
>> https://mydomain.com/somefolder/index.html?target=somevalue=
>> 
>> somevalue
>> 
>> How should I do that using Routing in Royale ? :)
>> 
>> [1] https://apache.github.io/royale-docs/features/routing
>> [2]
>> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
>> 
>> Thanks,
>> Piotr
>> 
>> śr., 22 sty 2020 o 13:08 Carlos Rovira 
>> napisał(a):
>> 
>>> Hi Harbs,
>>> 
>>> thanks for taking a look, I'll try to apply your suggestions and see if I
>>> can make it work.
>>> 
>>> If you plan to work in that new Routing implementation, I'll wait for it
>>> to
>>> write about it in blog and social media, since better to point people to
>>> the more elaborated one. I as well recommend you to make it end in its own
>>> "Routing.swc" since I think it deserves it.
>>> 
>>> As Alex dream on possibilities, I want as well to dream and I think
>>> nowadays, a part from pure client navigation, we have server navigation,
>>> and as other royale features people will soon try to do it. In the case of
>>> Routing, people will want to have URLs for concrete items retrieved from
>>> database and we should support it (was what we discussed before that in
>>> that case, we'll be able to not have # in the url but just a friendly
>>> permalink). Hope we can support that, since we'll be great to create, lets
>>> say, a blog app, and as user browse posts and navigate to see a full
>>> posst,
>>> he gets as well a friendly URL with no anchors that can be indexable by
>>> google and retrieved (i.e, the same as Wordpress)
>>> 
>>> Thanks
>>> 
>>> 
>>> 
>>> 
>>> 
>>> El mar., 21 ene. 2020 a las 23:57, Alex Harui (>>> )
>>> escribió:
>>> 
 If we're dreaming of the future possible implementations, one vision is
 that the route paths are computed from the currentStates of Containers.
 That might have the least setup required, it would almost be automatic.
 
 IOW, Containers have both a label and currentState property. A routing
 implementation could scan the DOM for contaners and build the path from
 label/currentState pairs.
 
 Of course, I could be wrong...
 
 -Alex
 
 
 On 1/21/20, 1:33 PM, "Harbs"  wrote:
 
I’ve also been thinking about the router in general, and I came up
 with an idea on how to do it with beads.
 
It’ll probably take me a few days until I implement the changes…
 
In addition to , I think we can also offer
  which would allow different routers to be attached to
 different places in the application and each level of the hierarchy can
 take care of its own state.
 
Harbs
 
> On Jan 21, 2020, at 11:29 PM, Harbs 
>>> wrote:
> 
> FWIW, I’d like to write a version of a router which allows for
>>> more
 declarative syntax for routing to components.
> 
> Something like this:
> 
> 
> 
> >> state=“layouts_panel”
 title=“Layouts”/>
> >>> title=“Grids”/>
> >> state=“button_panel”
 title=“Button Bar”/>
> etc...
> 
> 
> 
> 
>> On Jan 21, 2020, at 11:20 PM, Harbs >> >>> harbs.li...@gmail.com>> wrote:
>> 
>> To see what I mean about href links, check out this page and
>>> click
 on a link:
>> http://spectrum-royale/SpectrumBrowser/bin/js-debug/#!link <
 http://spectrum-royale/SpectrumBrowser/bin/js-debug/#!link>
>> 
>> Then use the side panel to navigate to the same pages.
>> 
>>> On Jan 21, 2020, at 11:18 PM, Harbs >>> 

Re: Routing (was Re: Spectrum Components)

[Alex Harui]

What do you want your URLs to look like?  Remember that hash is used to keep 
the browser from reloading the app.

On 4/17/20, 12:13 AM, "Piotr Zarzycki"  wrote:

I'm still looking into the code and it looks like Routing implemented now
is not doing what I would expected. Everything is based on "hash" property
in "location". Instead I need something which is in "search" of location. I
will wait for your thoughts before I do try to handle stuff on my end.

pt., 17 kwi 2020 o 08:30 Piotr Zarzycki 
napisał(a):

> Hi Guys,
>
> I really thought that I will be able to use Router [1] based on
> documentation and maybe eventually some look to the code [2] - to figure
> out how things should be implemented. However it looks like non of the
> existing stuff helps me to use in in real world application at all. I 
would
> like to throw a simple question.
>
> I would like to "answer" in my application to following url, catch params
> and do some actions:
>
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmydomain.com%2Fsomefolder%2Findex.html%3Ftarget%3Dsomevalue%26account%3Ddata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=Dv%2FfoygkOuy8EWX3yajDig8oYM9d7ZgqUOGohQd37og%3Dreserved=0
> 

> somevalue
>
> How should I do that using Routing in Royale ? :)
>
> [1] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapache.github.io%2Froyale-docs%2Ffeatures%2Froutingdata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=%2Bq64VNDap48GgbtQtGnIKFQhasrk%2FXb5%2B0bqiTXs328%3Dreserved=0
> [2]
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Ftree%2Fdevelop%2Fframeworks%2Fprojects%2FBasic%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Froutingdata=02%7C01%7Caharui%40adobe.com%7C9c2cf4e0d00b4580633708d7e29ed603%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227044141794314sdata=dbfGXbu79kwYBWPwd4i0meomYPr616KOKMT6ok%2FVwX8%3Dreserved=0
>
> Thanks,
> Piotr
>
> śr., 22 sty 2020 o 13:08 Carlos Rovira 
> napisał(a):
>
>> Hi Harbs,
>>
>> thanks for taking a look, I'll try to apply your suggestions and see if I
>> can make it work.
>>
>> If you plan to work in that new Routing implementation, I'll wait for it
>> to
>> write about it in blog and social media, since better to point people to
>> the more elaborated one. I as well recommend you to make it end in its 
own
>> "Routing.swc" since I think it deserves it.
>>
>> As Alex dream on possibilities, I want as well to dream and I think
>> nowadays, a part from pure client navigation, we have server navigation,
>> and as other royale features people will soon try to do it. In the case 
of
>> Routing, people will want to have URLs for concrete items retrieved from
>> database and we should support it (was what we discussed before that in
>> that case, we'll be able to not have # in the url but just a friendly
>> permalink). Hope we can support that, since we'll be great to create, 
lets
>> say, a blog app, and as user browse posts and navigate to see a full
>> posst,
>> he gets as well a friendly URL with no anchors that can be indexable by
>> google and retrieved (i.e, the same as Wordpress)
>>
>> Thanks
>>
>>
>>
>>
>>
>> El mar., 21 ene. 2020 a las 23:57, Alex Harui (> >)
>> escribió:
>>
>> > If we're dreaming of the future possible implementations, one vision is
>> > that the route paths are computed from the currentStates of Containers.
>> > That might have the least setup required, it would almost be automatic.
>> >
>> > IOW, Containers have both a label and currentState property. A routing
>> > implementation could scan the DOM for contaners and build the path from
>> > label/currentState pairs.
>> >
>> > Of course, I could be wrong...
>> >
>> > -Alex
>> >
>> >
>> > On 1/21/20, 1:33 PM, "Harbs"  wrote:
>> >
>> > I’ve also been thinking about the router in general, and I came up
>> > with an idea on how to do it with beads.
>> >
>> > It’ll probably take me a few days until I implement the changes…
>> >
>> > In addition to , I think we can also offer
>> >  which would allow different routers to be 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

I'm still looking into the code and it looks like Routing implemented now
is not doing what I would expected. Everything is based on "hash" property
in "location". Instead I need something which is in "search" of location. I
will wait for your thoughts before I do try to handle stuff on my end.

pt., 17 kwi 2020 o 08:30 Piotr Zarzycki 
napisał(a):

> Hi Guys,
>
> I really thought that I will be able to use Router [1] based on
> documentation and maybe eventually some look to the code [2] - to figure
> out how things should be implemented. However it looks like non of the
> existing stuff helps me to use in in real world application at all. I would
> like to throw a simple question.
>
> I would like to "answer" in my application to following url, catch params
> and do some actions:
>
> https://mydomain.com/somefolder/index.html?target=somevalue=
> 
> somevalue
>
> How should I do that using Routing in Royale ? :)
>
> [1] https://apache.github.io/royale-docs/features/routing
> [2]
> https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing
>
> Thanks,
> Piotr
>
> śr., 22 sty 2020 o 13:08 Carlos Rovira 
> napisał(a):
>
>> Hi Harbs,
>>
>> thanks for taking a look, I'll try to apply your suggestions and see if I
>> can make it work.
>>
>> If you plan to work in that new Routing implementation, I'll wait for it
>> to
>> write about it in blog and social media, since better to point people to
>> the more elaborated one. I as well recommend you to make it end in its own
>> "Routing.swc" since I think it deserves it.
>>
>> As Alex dream on possibilities, I want as well to dream and I think
>> nowadays, a part from pure client navigation, we have server navigation,
>> and as other royale features people will soon try to do it. In the case of
>> Routing, people will want to have URLs for concrete items retrieved from
>> database and we should support it (was what we discussed before that in
>> that case, we'll be able to not have # in the url but just a friendly
>> permalink). Hope we can support that, since we'll be great to create, lets
>> say, a blog app, and as user browse posts and navigate to see a full
>> posst,
>> he gets as well a friendly URL with no anchors that can be indexable by
>> google and retrieved (i.e, the same as Wordpress)
>>
>> Thanks
>>
>>
>>
>>
>>
>> El mar., 21 ene. 2020 a las 23:57, Alex Harui (> >)
>> escribió:
>>
>> > If we're dreaming of the future possible implementations, one vision is
>> > that the route paths are computed from the currentStates of Containers.
>> > That might have the least setup required, it would almost be automatic.
>> >
>> > IOW, Containers have both a label and currentState property. A routing
>> > implementation could scan the DOM for contaners and build the path from
>> > label/currentState pairs.
>> >
>> > Of course, I could be wrong...
>> >
>> > -Alex
>> >
>> >
>> > On 1/21/20, 1:33 PM, "Harbs"  wrote:
>> >
>> > I’ve also been thinking about the router in general, and I came up
>> > with an idea on how to do it with beads.
>> >
>> > It’ll probably take me a few days until I implement the changes…
>> >
>> > In addition to , I think we can also offer
>> >  which would allow different routers to be attached to
>> > different places in the application and each level of the hierarchy can
>> > take care of its own state.
>> >
>> > Harbs
>> >
>> > > On Jan 21, 2020, at 11:29 PM, Harbs 
>> wrote:
>> > >
>> > > FWIW, I’d like to write a version of a router which allows for
>> more
>> > declarative syntax for routing to components.
>> > >
>> > > Something like this:
>> > > 
>> > > 
>> > > 
>> > > > state=“layouts_panel”
>> > title=“Layouts”/>
>> > > > > title=“Grids”/>
>> > > > state=“button_panel”
>> > title=“Button Bar”/>
>> > > etc...
>> > > 
>> > > 
>> > > 
>> > >
>> > >> On Jan 21, 2020, at 11:20 PM, Harbs > > > harbs.li...@gmail.com>> wrote:
>> > >>
>> > >> To see what I mean about href links, check out this page and
>> click
>> > on a link:
>> > >> http://spectrum-royale/SpectrumBrowser/bin/js-debug/#!link <
>> > http://spectrum-royale/SpectrumBrowser/bin/js-debug/#!link>
>> > >>
>> > >> Then use the side panel to navigate to the same pages.
>> > >>
>> > >>> On Jan 21, 2020, at 11:18 PM, Harbs > > > wrote:
>> > >>>
>> > >>> The problem is the href in the  element in the nav. The hash
>> is
>> > being changed to “#" after the router redirects.
>> > >>>
>> > >>> You need to handle routing in one of two ways (and not both).
>> > >>> 1. Use setState()
>> > >>> 2. Use href links
>> > >>>
>> > >>> To do #1, you need to remove the href from the  elements (or
>> > use something else such as a div or li).
>> > >>>
>> > >>> If you use 

Release Step 009 Succeeded

[apacheroyaleci]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_009 and run the following commands:
git push

You will need your Apache/Github username and 2FA token.

Release Step 008 Succeeded

[apacheroyaleci]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_008 and run the following commands:
git push
git checkout release/0.9.7
git push -u origin release/0.9.7

You will need your Apache/Github username and 2FA token.

Build failed in Jenkins: royale-asjs_jsonly #1283

[apacheroyaleci]

See 


Changes:

[aharui] [maven-release-plugin] prepare branch @{releaseLabel}

[aharui] [maven-release-plugin] prepare for next development iteration


--
[...truncated 1.58 MB...]
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.define+=GOOG::DEBUG,goog.DEBUG
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 06:58 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 429630 bytes written to 

 in 10.530 seconds
 [java] COMPCJSCRoyale
 [java] 
:
 col: 30 Warning: Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Warning: Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 30 Data binding will not be able to detect assignments to 'x'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/FormItemSkin.mxml(169)>:
 col: 83 Data binding will not be able to detect assignments to 'y'.
 [java] 
 [java] http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/ws/frameworks/js/libs>

main:

copy-swc:

check-for-tests:

test:

main:

Crux:
 [echo] swc-date is 04/17/20 06:59 +

clean:
 [echo] swc-date is 04/17/20 06:59 +

check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:

compile-js:
 [echo] swc-date is 04/17/20 06:59 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 04/17/20 06:59 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling CruxJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=04/17/20 06:59 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.7
 [java] 

Re: Routing (was Re: Spectrum Components)

[Piotr Zarzycki]

Hi Guys,

I really thought that I will be able to use Router [1] based on
documentation and maybe eventually some look to the code [2] - to figure
out how things should be implemented. However it looks like non of the
existing stuff helps me to use in in real world application at all. I would
like to throw a simple question.

I would like to "answer" in my application to following url, catch params
and do some actions:

https://mydomain.com/somefolder/index.html?target=somevalue=

somevalue

How should I do that using Routing in Royale ? :)

[1] https://apache.github.io/royale-docs/features/routing
[2]
https://github.com/apache/royale-asjs/tree/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing

Thanks,
Piotr

śr., 22 sty 2020 o 13:08 Carlos Rovira  napisał(a):

> Hi Harbs,
>
> thanks for taking a look, I'll try to apply your suggestions and see if I
> can make it work.
>
> If you plan to work in that new Routing implementation, I'll wait for it to
> write about it in blog and social media, since better to point people to
> the more elaborated one. I as well recommend you to make it end in its own
> "Routing.swc" since I think it deserves it.
>
> As Alex dream on possibilities, I want as well to dream and I think
> nowadays, a part from pure client navigation, we have server navigation,
> and as other royale features people will soon try to do it. In the case of
> Routing, people will want to have URLs for concrete items retrieved from
> database and we should support it (was what we discussed before that in
> that case, we'll be able to not have # in the url but just a friendly
> permalink). Hope we can support that, since we'll be great to create, lets
> say, a blog app, and as user browse posts and navigate to see a full posst,
> he gets as well a friendly URL with no anchors that can be indexable by
> google and retrieved (i.e, the same as Wordpress)
>
> Thanks
>
>
>
>
>
> El mar., 21 ene. 2020 a las 23:57, Alex Harui ()
> escribió:
>
> > If we're dreaming of the future possible implementations, one vision is
> > that the route paths are computed from the currentStates of Containers.
> > That might have the least setup required, it would almost be automatic.
> >
> > IOW, Containers have both a label and currentState property. A routing
> > implementation could scan the DOM for contaners and build the path from
> > label/currentState pairs.
> >
> > Of course, I could be wrong...
> >
> > -Alex
> >
> >
> > On 1/21/20, 1:33 PM, "Harbs"  wrote:
> >
> > I’ve also been thinking about the router in general, and I came up
> > with an idea on how to do it with beads.
> >
> > It’ll probably take me a few days until I implement the changes…
> >
> > In addition to , I think we can also offer
> >  which would allow different routers to be attached to
> > different places in the application and each level of the hierarchy can
> > take care of its own state.
> >
> > Harbs
> >
> > > On Jan 21, 2020, at 11:29 PM, Harbs  wrote:
> > >
> > > FWIW, I’d like to write a version of a router which allows for more
> > declarative syntax for routing to components.
> > >
> > > Something like this:
> > > 
> > > 
> > > 
> > >  > title=“Layouts”/>
> > >  > title=“Grids”/>
> > >  state=“button_panel”
> > title=“Button Bar”/>
> > > etc...
> > > 
> > > 
> > > 
> > >
> > >> On Jan 21, 2020, at 11:20 PM, Harbs   > harbs.li...@gmail.com>> wrote:
> > >>
> > >> To see what I mean about href links, check out this page and click
> > on a link:
> > >> http://spectrum-royale/SpectrumBrowser/bin/js-debug/#!link <
> > http://spectrum-royale/SpectrumBrowser/bin/js-debug/#!link>
> > >>
> > >> Then use the side panel to navigate to the same pages.
> > >>
> > >>> On Jan 21, 2020, at 11:18 PM, Harbs  > > wrote:
> > >>>
> > >>> The problem is the href in the  element in the nav. The hash
> is
> > being changed to “#" after the router redirects.
> > >>>
> > >>> You need to handle routing in one of two ways (and not both).
> > >>> 1. Use setState()
> > >>> 2. Use href links
> > >>>
> > >>> To do #1, you need to remove the href from the  elements (or
> > use something else such as a div or li).
> > >>>
> > >>> If you use href links, the logic of actually switching the views
> > should be handled by the router, so for example in Card, the href should
> > be  #card_panel or #!card_panel.
> > >>>
> > >>> Then setNavSelection will work.
> > >>>
> > >>> The downside of the second method is that I’m not sure how to set
> > the title. Maybe that should be a separate method that can be called.
> > >>>
> >  On Jan 21, 2020, at 8:48 PM, Carlos Rovira <
> > carlosrov...@apache.org > wrote:
> > 
> > 

Royale_Release_Step_010 - Build # 1 - Failure!

[apacheroyaleci]

Royale_Release_Step_010 - Build # 1 - Failure:

Check console output at 
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/1/
 to view the results.

Release Step 009 Succeeded

[apacheroyaleci]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_009 and run the following commands:
git push

You will need your Apache/Github username and 2FA token.