svn commit: r396220 - in /struts/action/trunk: el/pom.xml extras/pom.xml faces/pom.xml scripting/pom.xml taglib/pom.xml
Author: wsmoak Date: Sat Apr 22 23:03:49 2006 New Revision: 396220 URL: http://svn.apache.org/viewcvs?rev=396220view=rev Log: Added distributionManagement/site element to be used with 'mvn site:deploy'. Removed experimental designation from poms. Modified: struts/action/trunk/el/pom.xml struts/action/trunk/extras/pom.xml struts/action/trunk/faces/pom.xml struts/action/trunk/scripting/pom.xml struts/action/trunk/taglib/pom.xml Modified: struts/action/trunk/el/pom.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/el/pom.xml?rev=396220r1=396219r2=396220view=diff == --- struts/action/trunk/el/pom.xml (original) +++ struts/action/trunk/el/pom.xml Sat Apr 22 23:03:49 2006 @@ -19,18 +19,6 @@ */ -- -!-- - Experimental Maven 2 Build for Apache Struts - - -To build and install this module into your local repo: - - $ mvn install - -For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan - --- - project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; @@ -46,6 +34,13 @@ packagingjar/packaging nameStruts Action - EL/name urlhttp://struts.apache.org/url + + distributionManagement + site + idapache-site/id + urlscp://people.apache.org/www/struts.apache.org/struts-action/struts-el/url + /site + /distributionManagement build Modified: struts/action/trunk/extras/pom.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/extras/pom.xml?rev=396220r1=396219r2=396220view=diff == --- struts/action/trunk/extras/pom.xml (original) +++ struts/action/trunk/extras/pom.xml Sat Apr 22 23:03:49 2006 @@ -19,18 +19,6 @@ */ -- -!-- - Experimental Maven 2 Build for Apache Struts - - -To build and install this module into your local repo: - - $ mvn install - -For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan - --- - project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; @@ -46,6 +34,13 @@ packagingjar/packaging nameStruts Action - Extras/name urlhttp://struts.apache.org/url + + distributionManagement + site + idapache-site/id + urlscp://people.apache.org/www/struts.apache.org/struts-action/struts-extras/url + /site + /distributionManagement build Modified: struts/action/trunk/faces/pom.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/faces/pom.xml?rev=396220r1=396219r2=396220view=diff == --- struts/action/trunk/faces/pom.xml (original) +++ struts/action/trunk/faces/pom.xml Sat Apr 22 23:03:49 2006 @@ -19,18 +19,6 @@ */ -- -!-- - Experimental Maven 2 Build for Apache Struts - - -To build and install this module into your local repo: - - $ mvn install - -For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan - --- - project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; @@ -48,6 +36,13 @@ packagingjar/packaging nameStruts Action - Faces/name urlhttp://struts.apache.org/url + + distributionManagement + site + idapache-site/id + urlscp://people.apache.org/www/struts.apache.org/struts-action/struts-faces/url + /site + /distributionManagement build Modified: struts/action/trunk/scripting/pom.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/scripting/pom.xml?rev=396220r1=396219r2=396220view=diff == --- struts/action/trunk/scripting/pom.xml (original) +++ struts/action/trunk/scripting/pom.xml Sat Apr 22 23:03:49 2006 @@ -19,18 +19,6 @@ */ -- -!-- - Experimental Maven 2 Build for Apache Struts - - -To build and install this module into your local repo: - - $ mvn install - -For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan - --- - project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; @@ -47,6 +35,13 @@ nameStruts
svn commit: r396221 - /struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java
Author: mrdon Date: Sat Apr 22 23:22:37 2006 New Revision: 396221 URL: http://svn.apache.org/viewcvs?rev=396221view=rev Log: Fixing compile error caused by recent renaming of the package Modified: struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java Modified: struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java URL: http://svn.apache.org/viewcvs/struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java?rev=396221r1=396220r2=396221view=diff == --- struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java (original) +++ struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java Sat Apr 22 23:22:37 2006 @@ -22,7 +22,7 @@ import org.apache.commons.logging.LogFactory; import org.apache.struts.action.ActionServlet; import org.apache.struts.action.PlugIn; -import org.apache.struts.apps.mailreader.Constants; +import org.apache.struts.apps.scriptingmailreader.Constants; import org.apache.struts.apps.mailreader.dao.impl.memory.MemoryUserDatabase; import org.apache.struts.config.ModuleConfig; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396222 - in /incubator/webwork2/action/src: main/java/org/apache/struts/action2/components/Text.java test/java/org/apache/struts/action2/views/jsp/TextTagTest.java
Author: tmjee
Date: Sat Apr 22 23:45:05 2006
New Revision: 396222
URL: http://svn.apache.org/viewcvs?rev=396222view=rev
Log:
ww-1268
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/Text.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/TextTagTest.java
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/Text.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/Text.java?rev=396222r1=396221r2=396222view=diff
==
---
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/Text.java
(original)
+++
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/Text.java
Sat Apr 22 23:45:05 2006
@@ -89,8 +89,14 @@
* pre
* !-- START SNIPPET: i18nExample --
*
+ * lt;-- Third Example --gt;
* lt;a:text name=some.key /gt;
*
+ * lt;-- Fourth Example --gt;
+ * lt;a:text name=some.invalid.key gt;
+ *The Default Message That Will Be Displayed
+ * lt;/a:textgt;
+ *
* !-- END SNIPPET: i18nExample --
* /pre
*
@@ -116,6 +122,14 @@
*/
public void setName(String name) {
this.name = name;
+}
+
+
+public boolean usesBody() {
+ // overriding this to true such that EVAL_BODY_BUFFERED is return and
+ // bodyContent will be valid hence, text between start end tag will
+ // be honoured as default message (WW-1268)
+ return true;
}
public boolean end(Writer writer, String body) {
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/TextTagTest.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/TextTagTest.java?rev=396222r1=396221r2=396222view=diff
==
---
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/TextTagTest.java
(original)
+++
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/TextTagTest.java
Sat Apr 22 23:45:05 2006
@@ -22,11 +22,18 @@
import org.apache.struts.action2.components.Text;
import org.apache.struts.action2.views.jsp.ui.TestAction1;
import org.apache.struts.action2.views.jsp.ui.StrutsBodyContent;
+
+import com.mockobjects.servlet.MockBodyContent;
+import com.mockobjects.servlet.MockJspWriter;
import com.opensymphony.xwork.Action;
import com.opensymphony.xwork.ActionContext;
import com.opensymphony.xwork.util.OgnlValueStack;
import javax.servlet.jsp.JspException;
+import javax.servlet.jsp.tagext.BodyTag;
+import javax.servlet.jsp.tagext.Tag;
+import javax.servlet.jsp.tagext.TagSupport;
+
import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.Date;
@@ -49,6 +56,22 @@
action.setFoo(fooValue);
return action;
+}
+
+public void testDefaultMessageOk() throws Exception {
+ // NOTE:
+ // simulate the condition
+ // saf:text name=some.invalid.keyMy Default Message/saf:text
+
+ StrutsMockBodyContent mockBodyContent = new StrutsMockBodyContent(new
MockJspWriter());
+ mockBodyContent.setString(Sample Of Default Message);
+ tag.setBodyContent(mockBodyContent);
+ tag.setName(some.invalid.key.so.we.should.get.the.default.message);
+ int startStatus = tag.doStartTag();
+ tag.doEndTag();
+
+ assertEquals(startStatus, BodyTag.EVAL_BODY_BUFFERED);
+ assertEquals(Sample Of Default Message, writer.toString());
}
public void testExpressionsEvaluated() throws Exception {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396233 - /struts/action/trunk/el/src/site/site.xml
Author: wsmoak Date: Sun Apr 23 00:01:49 2006 New Revision: 396233 URL: http://svn.apache.org/viewcvs?rev=396233view=rev Log: Corrected tagreference links, added a link to the Javadoc. Modified: struts/action/trunk/el/src/site/site.xml Modified: struts/action/trunk/el/src/site/site.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/el/src/site/site.xml?rev=396233r1=396232r2=396233view=diff == --- struts/action/trunk/el/src/site/site.xml (original) +++ struts/action/trunk/el/src/site/site.xml Sun Apr 23 00:01:49 2006 @@ -22,10 +22,11 @@ item name=FAQ href=struts-el.html/ /menu menu name=Reference -item name=Bean EL href=tagreference-struts-bean-el.html/ -item name=HTML EL href=tagreference-struts-html-el.html/ -item name=Logic EL href=tagreference-struts-logic-el.html/ -item name=Tiles EL href=tagreference-struts-tiles-el.html/ +item name=Bean EL href=tagreference.html#struts-bean-el.tld/ +item name=HTML EL href=tagreference.html#struts-html-el.tld/ +item name=Logic EL href=tagreference.html#struts-logic-el.tld/ +item name=Tiles EL href=tagreference.html#struts-tiles-el.tld/ +item name=Javadoc href=apidocs/index.html/ /menu menu name=Quick Links item - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396239 - in /incubator/webwork2/action/src: main/java/org/apache/struts/action2/components/URL.java test/java/org/apache/struts/action2/views/jsp/URLTagTest.java
Author: tmjee
Date: Sun Apr 23 00:19:46 2006
New Revision: 396239
URL: http://svn.apache.org/viewcvs?rev=396239view=rev
Log:
ww-1266
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/URL.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/URLTagTest.java
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/URL.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/URL.java?rev=396239r1=396238r2=396239view=diff
==
---
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/URL.java
(original)
+++
incubator/webwork2/action/src/main/java/org/apache/struts/action2/components/URL.java
Sun Apr 23 00:19:46 2006
@@ -148,7 +148,8 @@
// no explicit url set so attach params from current url, do
// this at start so body params can override any of these they wish.
try {
-String includeParams = null;
+ // ww-1266
+String includeParams = GET;
if (this.includeParams != null) {
includeParams = findString(this.includeParams);
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/URLTagTest.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/URLTagTest.java?rev=396239r1=396238r2=396239view=diff
==
---
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/URLTagTest.java
(original)
+++
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/URLTagTest.java
Sun Apr 23 00:19:46 2006
@@ -17,8 +17,17 @@
*/
package org.apache.struts.action2.views.jsp;
+import java.util.HashMap;
+import java.util.Map;
+
import javax.servlet.jsp.JspWriter;
+import org.apache.struts.action2.components.URL;
+import org.springframework.mock.web.MockHttpServletRequest;
+import org.springframework.mock.web.MockHttpServletResponse;
+
+import com.opensymphony.xwork.util.OgnlValueStack;
+
/**
* Unit test for [EMAIL PROTECTED] URLTag}.
*
@@ -27,6 +36,31 @@
private URLTag tag;
+public void testIncludeParamsDefaultToGET() throws Exception {
+ request.setQueryString(one=oneValtwo=twoValthree=threeVal);
+
+ // request parameter map should not have any effect, as includeParams
+ // default to GET, which get its param from request.getQueryString()
+ Map tmp = new HashMap();
+ tmp.put(one, aaa);
+ tmp.put(two, bbb);
+ tmp.put(three, ccc);
+ request.setParameterMap(tmp);
+
+ tag.setValue(TestAction.acton);
+
+ tag.doStartTag();
+
+ URL url = (URL) tag.getComponent();
+ Map parameters = url.getParameters();
+
+ tag.doEndTag();
+
+ assertEquals(parameters.get(one), oneVal);
+ assertEquals(parameters.get(two), twoVal);
+ assertEquals(parameters.get(three), threeVal);
+}
+
public void testActionURL() throws Exception {
tag.setValue(TestAction.action);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396245 - /incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/util/UrlHelperTest.java
Author: tmjee
Date: Sun Apr 23 02:43:49 2006
New Revision: 396245
URL: http://svn.apache.org/viewcvs?rev=396245view=rev
Log:
fixed failing test case
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/util/UrlHelperTest.java
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/util/UrlHelperTest.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/util/UrlHelperTest.java?rev=396245r1=396244r2=396245view=diff
==
---
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/util/UrlHelperTest.java
(original)
+++
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/util/UrlHelperTest.java
Sun Apr 23 02:43:49 2006
@@ -282,16 +282,30 @@
}
public void testTranslateAndEncode() throws Exception {
- String result = UrlHelper.translateAndEncode(\u65b0\u805e);
- String expectedResult = %E6%96%B0%E8%81%9E;
+ Object defaultI18nEncoding =
Configuration.get(StrutsConstants.STRUTS_I18N_ENCODING);
+ try {
+ Configuration.set(StrutsConstants.STRUTS_I18N_ENCODING,
UTF-8);
+ String result = UrlHelper.translateAndEncode(\u65b0\u805e);
+ String expectedResult = %E6%96%B0%E8%81%9E;
- assertEquals(result, expectedResult);
+ assertEquals(result, expectedResult);
+ }
+ finally {
+ Configuration.set(StrutsConstants.STRUTS_I18N_ENCODING,
defaultI18nEncoding);
+ }
}
public void testTranslateAndDecode() throws Exception {
- String result = UrlHelper.translateAndDecode(%E6%96%B0%E8%81%9E);
- String expectedResult = \u65b0\u805e;
+ Object defaultI18nEncoding =
Configuration.get(StrutsConstants.STRUTS_I18N_ENCODING);
+ try {
+ Configuration.set(StrutsConstants.STRUTS_I18N_ENCODING,
UTF-8);
+ String result =
UrlHelper.translateAndDecode(%E6%96%B0%E8%81%9E);
+ String expectedResult = \u65b0\u805e;
- assertEquals(result, expectedResult);
+ assertEquals(result, expectedResult);
+ }
+ finally {
+ Configuration.set(StrutsConstants.STRUTS_I18N_ENCODING,
defaultI18nEncoding);
+ }
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r396221 - /struts/action/trunk/apps/scripting-mailreader/src/main/java/org/apache/struts/apps/scriptingmailreader/plugin/MemoryDatabasePlugIn.java
Sorry, forgot about that one. I made the change locally and then got distracted on something else. Thanks. -- James Mitchell On Apr 23, 2006, at 2:22 AM, [EMAIL PROTECTED] wrote: Author: mrdon Date: Sat Apr 22 23:22:37 2006 New Revision: 396221 URL: http://svn.apache.org/viewcvs?rev=396221view=rev Log: Fixing compile error caused by recent renaming of the package Modified: struts/action/trunk/apps/scripting-mailreader/src/main/java/org/ apache/struts/apps/scriptingmailreader/plugin/ MemoryDatabasePlugIn.java Modified: struts/action/trunk/apps/scripting-mailreader/src/main/ java/org/apache/struts/apps/scriptingmailreader/plugin/ MemoryDatabasePlugIn.java URL: http://svn.apache.org/viewcvs/struts/action/trunk/apps/ scripting-mailreader/src/main/java/org/apache/struts/apps/ scriptingmailreader/plugin/MemoryDatabasePlugIn.java? rev=396221r1=396220r2=396221view=diff == --- struts/action/trunk/apps/scripting-mailreader/src/main/java/org/ apache/struts/apps/scriptingmailreader/plugin/ MemoryDatabasePlugIn.java (original) +++ struts/action/trunk/apps/scripting-mailreader/src/main/java/org/ apache/struts/apps/scriptingmailreader/plugin/ MemoryDatabasePlugIn.java Sat Apr 22 23:22:37 2006 @@ -22,7 +22,7 @@ import org.apache.commons.logging.LogFactory; import org.apache.struts.action.ActionServlet; import org.apache.struts.action.PlugIn; -import org.apache.struts.apps.mailreader.Constants; +import org.apache.struts.apps.scriptingmailreader.Constants; import org.apache.struts.apps.mailreader.dao.impl.memory.MemoryUserDatabase; import org.apache.struts.config.ModuleConfig; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (STR-2837) Fix the site build
[ http://issues.apache.org/struts/browse/STR-2837?page=comments#action_37171 ] Don Brown commented on STR-2837: test comment Fix the site build -- Key: STR-2837 URL: http://issues.apache.org/struts/browse/STR-2837 Project: Struts Action 1 Type: Bug Components: Infrastructure Versions: 1.3.2 Reporter: Don Brown We need to fix the website/docs build so that we can update the website easily. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (WW-1266) URL tag - includeParams default is none, but docs states get is the default
[ http://issues.apache.org/struts/browse/WW-1266?page=comments#action_37172 ] tm_jee commented on WW-1266: fixed. Nils kindly review when you find the time. :-) changes are at :- Sending action/src/main/java/org/apache/struts/action2/components/URL.java Sending action/src/test/java/org/apache/struts/action2/views/jsp/URLTagTest.java URL tag - includeParams default is none, but docs states get is the default --- Key: WW-1266 URL: http://issues.apache.org/struts/browse/WW-1266 Project: Struts Action 2 Type: Bug Components: Views Versions: WW 2.2.2 Environment: tested on Apache Tomcat 5.5.15, JDK 6 (build 76) Reporter: Claudio Miranda Assignee: tm_jee Priority: Minor Fix For: 2.0 Attachments: ww-222-url-bug.tar.gz At http://wiki.opensymphony.com/display/WW/url, is stated includeParams attribute is get by default, indeed it was on 2.2.1. On 2.2.2 the ww url tag stop to work properly, tracking down the issue I found out includeParams attribute needed to be get or all to work See attached the test case. 1) unzip it and copy the directory ww-222-url-bug to $CATALINA_HOME/webapps, restart tomcat 2) open the browser and points to http://localhost:8080/ww-222-url-bug/encodingTestNew.action 3) submit anything 4) click at the link Correct some fields 5) the previous form is not filled The scope interceptor is used. To make it work Edit encoding_test_2.ftl and add the attribute includeParams=get, make the test again. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (WW-1266) URL tag - includeParams default is none, but docs states get is the default
[ http://issues.apache.org/struts/browse/WW-1266?page=all ] tm_jee resolved WW-1266: Resolution: Fixed URL tag - includeParams default is none, but docs states get is the default --- Key: WW-1266 URL: http://issues.apache.org/struts/browse/WW-1266 Project: Struts Action 2 Type: Bug Components: Views Versions: WW 2.2.2 Environment: tested on Apache Tomcat 5.5.15, JDK 6 (build 76) Reporter: Claudio Miranda Assignee: tm_jee Priority: Minor Fix For: 2.0 Attachments: ww-222-url-bug.tar.gz At http://wiki.opensymphony.com/display/WW/url, is stated includeParams attribute is get by default, indeed it was on 2.2.1. On 2.2.2 the ww url tag stop to work properly, tracking down the issue I found out includeParams attribute needed to be get or all to work See attached the test case. 1) unzip it and copy the directory ww-222-url-bug to $CATALINA_HOME/webapps, restart tomcat 2) open the browser and points to http://localhost:8080/ww-222-url-bug/encodingTestNew.action 3) submit anything 4) click at the link Correct some fields 5) the previous form is not filled The scope interceptor is used. To make it work Edit encoding_test_2.ftl and add the attribute includeParams=get, make the test again. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (STR-2837) Fix the site build
test complete -- James Mitchell On Apr 23, 2006, at 3:02 AM, Don Brown (JIRA) wrote: [ http://issues.apache.org/struts/browse/STR-2837? page=comments#action_37171 ] Don Brown commented on STR-2837: test comment Fix the site build -- Key: STR-2837 URL: http://issues.apache.org/struts/browse/STR-2837 Project: Struts Action 1 Type: Bug Components: Infrastructure Versions: 1.3.2 Reporter: Don Brown We need to fix the website/docs build so that we can update the website easily. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Update of RoughSpots by TimFennell
Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by TimFennell: http://wiki.apache.org/struts/RoughSpots The comment on the change is: Added some my issues, and commented on existing ones. -- * [crazybob] I'll buy that. We do need to move the constants out and encourage users to use static import (Effective Java Item 17). * [plightbo] Related to this, I would encourage us to try to find a solution (using Bob's mix-in suggestion below, or possibly just taking advantage of the value stack) that would make ActionSupport much simpler. This would encourage using POJOs more. * [mrdon] Regardless whether we remove Action or not, I like the idea of moving the result constants out. + * [tfenne] I think removing Action would be a bad idea. If you're going to try and get away from requiring XML configuration or listing out all your Actions somewhere, you'll probably want to have someway of discovering your Actions. An interface is the easiest option - an annotation would do too, but would feel a little stranger I think. 1. Only put classes in root package that most users need to know about. For example, most don't need to know about `Default*` or `ObjectFactory`. * [plightbo] +1 on this - sounds like Bob has a good handle on what it takes to make a nice API. I'll defer to him on this. @@ -213, +214 @@ 1. Get rid of the use of static constant variables that are used in the key in the stack and accessed all over the place like XWorkNullHandler.CREATE_NULL_OBJECTS etc. I've started to do that with the OgnlContextState class, but it's not complete and I'm not sure if that's the best way to do it. + == Tim's Issues == + I'm new around here, so be nice ;) I probably have a lot less WW experience than most, so I apologize in advance if I'm flat out wrong about some of the things here. + + 1. How does WW help the user with state management? As far as I can tell, if I want to keep a 'user' object around I have to interact with the map returned by ActionContext.getSession(). Actions should in general have a type-safe and transparent way to do this, e.g. by subclassing ActionContext and providing getUser()/setUser() which store the user in session. This allows for re-working of the storage strategy (e.g. write a cookie and lookup the user each time) without affecting actions. + 1. In tandem with the previous point, since Actions are already stateful, it'd be nice to have the ActionContext injected into the Action. One benefit is when a newbie developer needs it, the linkage is obvious (they don't have to a priori know about the ActionContext, they're being handed in it on a platter). If the developer can subclass ActionContext, it would also encourage them to implement a base action which accepts the context inject and leveraging the fact that JDK 1.5 allows co-variant returns, also write a getContext() method that returns the down-casted type; they wouldn't have to do ((MyActionContext) ActionContext.getContext()).getUser() for example, just getContext().getUser(). + 1. HTML analog tags should stick to HTML attributes. I dont' mean they shouldn't have more functionality, but the attributes should be identical where possible, and they shouldn't do things like render a label and an input. Keeping them more like regular HTML tags makes them easier to ramp up on, and more non-developer friendly + 1. Actions should return concrete objects, not symbolic results. Symbolic results might have been optimal when you had one event/method per action and the outcomes were always whole-page views, but they get in the way now. When you want to return anything that requires more than the symbol, you have to do some less than intuitive things to make the Action and the Result cooperate. I'd prefer to see a concrete Result get returned from Action methods, which would allows developers to do more powerful things more easily. There are a bunch of ways to make it backward compatible too. You could return 'new SymbolicResult(success)' and have the SymbolicResult do the lookup stuff (You could even redefine the String constants to be SymbolicResults). You could alternatively use a static class to do Results.find(SUCCESS). Or you could even allow method to continue to return String or Result, and if String wrap it in a SymbolicResult. + + == Nice to haves == 1. Inheritance is not a good way to reuse code between actions. One work around is to use the strategy pattern to swap in different implementations of interfaces like `ValidationAware`. It would be nice if the framework had built-in support for mixins using cglib or Dynaop. For example, instead of extending a class that implements `ValidationAware`, SAF could extend an action class at
svn commit: r396273 - in /incubator/webwork2/action/src: main/resources/template/ajax/ main/resources/template/simple/ main/resources/template/xhtml/ test/resources/org/apache/struts/action2/views/jsp
Author: tmjee
Date: Sun Apr 23 07:06:16 2006
New Revision: 396273
URL: http://svn.apache.org/viewcvs?rev=396273view=rev
Log:
ww-1184
Modified:
incubator/webwork2/action/src/main/resources/template/ajax/form-close.ftl
incubator/webwork2/action/src/main/resources/template/simple/form-close.ftl
incubator/webwork2/action/src/main/resources/template/simple/form.ftl
incubator/webwork2/action/src/main/resources/template/xhtml/form-validate.ftl
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/tooltip-1.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/tooltip-2.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/tooltip-3.txt
Modified:
incubator/webwork2/action/src/main/resources/template/ajax/form-close.ftl
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/resources/template/ajax/form-close.ftl?rev=396273r1=396272r2=396273view=diff
==
--- incubator/webwork2/action/src/main/resources/template/ajax/form-close.ftl
(original)
+++ incubator/webwork2/action/src/main/resources/template/ajax/form-close.ftl
Sun Apr 23 07:06:16 2006
@@ -1,11 +1,13 @@
-script
+#if (parameters.customOnsubmitEnabled?default(false))
+script
#--
Enable auto-select of optiontransferselect tag's entries upon containing
form's
submission.
--
-var containingForm = document.getElementById(${parameters.id});
+dojo.require(dojo.event.connect);
#if (parameters.optiontransferselectIds?if_exists?size 0)
+ var containingForm = document.getElementById(${parameters.id});
#assign selectObjIds = parameters.optiontransferselectIds.keySet() /
#list selectObjIds as selectObjectId
dojo.event.connect(containingForm, onsubmit,
@@ -21,6 +23,7 @@
/#list
/#if
#if (parameters.optiontransferselectDoubleIds?if_exists?size 0)
+ var containingForm = document.getElementById(${parameters.id});
#assign selectDoubleObjIds =
parameters.optiontransferselectDoubleIds.keySet() /
#list selectDoubleObjIds as selectObjId
dojo.event.connect(containingForm, onsubmit,
@@ -42,6 +45,7 @@
submission
--
#if (parameters.updownselectIds?if_exists?size 0)
+var containingForm = document.getElementById(${parameters.id});
#assign tmpIds = parameters.updownselectIds.keySet() /
#list tmpIds as tmpId
dojo.event.connect(containingForm, onsubmit,
@@ -56,8 +60,9 @@
});
/#list
/#if
-
/script
+/#if
+
/table
/form
Modified:
incubator/webwork2/action/src/main/resources/template/simple/form-close.ftl
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/resources/template/simple/form-close.ftl?rev=396273r1=396272r2=396273view=diff
==
--- incubator/webwork2/action/src/main/resources/template/simple/form-close.ftl
(original)
+++ incubator/webwork2/action/src/main/resources/template/simple/form-close.ftl
Sun Apr 23 07:06:16 2006
@@ -1,57 +1,68 @@
/form
-
+#if (parameters.customOnsubmitEnabled?if_exists)
script
- function customOnsubmit() {
- #--
- Code that will auto-select optiontransferselect elements upon
containing form submission
- --#t/
- #if (parameters.optiontransferselectIds?if_exists?size 0)#t/
- // Code that will auto-select optiontransferselect elements
upon containing form submission
- #assign selectTagIds =
parameters.optiontransferselectIds.keySet()/#t/
- #list selectTagIds as tmpId#t/
- // auto-select optiontrasferselect (left side) with id
${tmpId}
- var selectObj = document.getElementById(${tmpId});
- selectAllOptions(selectObj);
- selectUnselectMatchingOptions(selectObj, null,
unselect, false, key);
- #if
parameters.optiontransferselectIds.get(tmpId)?exists#t/
-
[jira] Commented: (WW-1184) form-close.ftl outputs an empty script tag.
[ http://issues.apache.org/struts/browse/WW-1184?page=comments#action_37173 ] tm_jee commented on WW-1184: fixed. Kindly review. since saf now by default (even in simple or xhtml theme) uses dojo. onsubmit is changed to be hooked using dojo.event.connect, so this problem should not exists. If not custom onsubmit hook is needed, no script.../script tag will appear. form-close.ftl outputs an empty script tag. --- Key: WW-1184 URL: http://issues.apache.org/struts/browse/WW-1184 Project: Struts Action 2 Type: Improvement Components: Views Versions: WW 2.2.1 Reporter: Mutsutoshi Yoshimoto Assignee: tm_jee Priority: Minor Fix For: 2.0 Attachments: form-close.ftl.diff My target device does not support javascript. A target device ignored a script tag, but the case without need made a patch not to output it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (WW-1184) form-close.ftl outputs an empty script tag.
[ http://issues.apache.org/struts/browse/WW-1184?page=comments#action_37174 ] tm_jee commented on WW-1184: changes are at :- Sendingaction/src/main/resources/template/ajax/form-close.ftl Sendingaction/src/main/resources/template/simple/form-close.ftl Sendingaction/src/main/resources/template/simple/form.ftl Sendingaction/src/main/resources/template/xhtml/form-validate.ftl Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/tooltip-1.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/tooltip-2.txt Sending action/src/test/resources/org/apache/struts/action2/views/jsp/ui/tooltip-3.txt form-close.ftl outputs an empty script tag. --- Key: WW-1184 URL: http://issues.apache.org/struts/browse/WW-1184 Project: Struts Action 2 Type: Improvement Components: Views Versions: WW 2.2.1 Reporter: Mutsutoshi Yoshimoto Assignee: tm_jee Priority: Minor Fix For: 2.0 Attachments: form-close.ftl.diff My target device does not support javascript. A target device ignored a script tag, but the case without need made a patch not to output it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (WW-1184) form-close.ftl outputs an empty script tag.
[ http://issues.apache.org/struts/browse/WW-1184?page=all ] tm_jee resolved WW-1184: Resolution: Fixed form-close.ftl outputs an empty script tag. --- Key: WW-1184 URL: http://issues.apache.org/struts/browse/WW-1184 Project: Struts Action 2 Type: Improvement Components: Views Versions: WW 2.2.1 Reporter: Mutsutoshi Yoshimoto Assignee: tm_jee Priority: Minor Fix For: 2.0 Attachments: form-close.ftl.diff My target device does not support javascript. A target device ignored a script tag, but the case without need made a patch not to output it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/22/06, Martin Cooper [EMAIL PROTECTED] wrote: I have these same concerns. That is why my preference would be for Tiles to stay here until Jakarta Web Components (nee Jakarta Silk) gets off the ground, and then move there, where it can share a general purpose web-focussed community and mindshare. That sounds fine, though I wonder if adding Tiles to Jakarta Web Components might help that project get off the ground, the way our moving BeanUtils and friends to Commons gave that effort a boost. Every mall needs an anchor. :) -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Update of RoughSpots by MichaelJouravlev
Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by MichaelJouravlev: http://wiki.apache.org/struts/RoughSpots -- Some things that could be addresssed before Action 2.0.0. (If we don't address them, we'll be stuck supporting them throughout all eternity or until Struts 3.0.0, whichever comes first. ;)) - We have a small number of existing WebWork users compared to the number of Struts users we'll (hopefully) eventually have. This is a new framework (if only in name) and a major release. This is our one chance to break compatibility. We must get it right now, because we will *not* be able to fix most of these problems later (the cost of breaking existing Struts users will almost always outweigh the value of the fix). + We have a small number of existing !WebWork users compared to the number of Struts users we'll (hopefully) eventually have. This is a new framework (if only in name) and a major release. This is our one chance to break compatibility. We must get it right now, because we will *not* be able to fix most of these problems later (the cost of breaking existing Struts users will almost always outweigh the value of the fix). We do not need to expose Struts users to XWork; they do not care. At the very least we should build a thin abstraction layer to isolate users from XWork. XWork should be an implementation detail not part of the SAF API. We can make most of the following changes in SAF's abstraction layer and avoid breaking existing XWork users. @@ -220, +220 @@ 1. How does WW help the user with state management? As far as I can tell, if I want to keep a 'user' object around I have to interact with the map returned by ActionContext.getSession(). Actions should in general have a type-safe and transparent way to do this, e.g. by subclassing ActionContext and providing getUser()/setUser() which store the user in session. This allows for re-working of the storage strategy (e.g. write a cookie and lookup the user each time) without affecting actions. 1. In tandem with the previous point, since Actions are already stateful, it'd be nice to have the ActionContext injected into the Action. One benefit is when a newbie developer needs it, the linkage is obvious (they don't have to a priori know about the ActionContext, they're being handed in it on a platter). If the developer can subclass ActionContext, it would also encourage them to implement a base action which accepts the context inject and leveraging the fact that JDK 1.5 allows co-variant returns, also write a getContext() method that returns the down-casted type; they wouldn't have to do ((MyActionContext) ActionContext.getContext()).getUser() for example, just getContext().getUser(). 1. HTML analog tags should stick to HTML attributes. I dont' mean they shouldn't have more functionality, but the attributes should be identical where possible, and they shouldn't do things like render a label and an input. Keeping them more like regular HTML tags makes them easier to ramp up on, and more non-developer friendly + * [MJ] I see the following options when it comes to tags. (1) Use plain HTML + implicit scoped variables like actionName, actionAddress, etc. to create dynamic values; this looks pretty compact with JSP 2.0. (2) Use 1:1 relation between WW tags and HTML tags. (3) Use 1:M relation between WW tags and HTML tags, like to create data entry form or a table. (4) Use non-HTML-looking tags + more abstract attributes + media attribute, thus creating something like JSF renderer for different media. Choosing between (1) and (2) I prefer the first one. 1. Actions should return concrete objects, not symbolic results. Symbolic results might have been optimal when you had one event/method per action and the outcomes were always whole-page views, but they get in the way now. When you want to return anything that requires more than the symbol, you have to do some less than intuitive things to make the Action and the Result cooperate. I'd prefer to see a concrete Result get returned from Action methods, which would allows developers to do more powerful things more easily. There are a bunch of ways to make it backward compatible too. You could return 'new SymbolicResult(success)' and have the SymbolicResult do the lookup stuff (You could even redefine the String constants to be SymbolicResults). You could alternatively use a static class to do Results.find(SUCCESS). Or you could even allow method to continue to return String or Result, and if String wrap it in a SymbolicResult. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
Agreed. Would it be possible to do this by JavaOne? Moving Tiles isn't a huge deal, but it would make the new directions of Struts easier to explain to users. Don Ted Husted wrote: On 4/22/06, Martin Cooper [EMAIL PROTECTED] wrote: I have these same concerns. That is why my preference would be for Tiles to stay here until Jakarta Web Components (nee Jakarta Silk) gets off the ground, and then move there, where it can share a general purpose web-focussed community and mindshare. That sounds fine, though I wonder if adding Tiles to Jakarta Web Components might help that project get off the ground, the way our moving BeanUtils and friends to Commons gave that effort a boost. Every mall needs an anchor. :) -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Update of RoughSpots by FrankZammetti
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Struts Wiki for change
notification.
The following page has been changed by FrankZammetti:
http://wiki.apache.org/struts/RoughSpots
--
* [plightbo] By running our interceptors and other objects through the
same factories and lifecycle managers that the action classes go through, this
should be a non issue.
* [mrdon] This I'd like to see. I've found myself using these objects so
often in wierd little places, I'd be loath to remove them unless we could prove
100% that their information can be retrieved elsewhere.
* [jcarreira] +1 to Patrick's point... we may need to introduce some more
advanced *Aware interfaces, though, to give people access to the guts if they
really want it.
+ * [frankz] !ActionContext being !ThreadLocal was one of the first cool
things I noticed about WW. I'd hate to see that change. The only thing I can
think of that would make me agree to change that is that I think we may find
developers using it in inappropriate ways, i.e., an Action calls a business
delegate and the delegate uses !ActionContext. My bet is most people would
agree it should be a best practice to not do that. Still, it's cool that you
can!
1. Is `ValidationAware` a good name? Perhaps `Errors` or `ErrorList` would
be a better name.
@@ -117, +118 @@
* [crazybob] Triggering an event should still be a POST (though the
framework should make it easy). From the HTTP spec.: GET and HEAD methods
SHOULD NOT have the significance of taking an action other than retrieval.
* [jcarreira] I think it's great that you want to take the HTTP spec at
its word... most users don't care though.
* [crazybob] I'm not arguing semantics. There are real security
implications to using GET when you should use POST, not to mention products
like Google Web Accelerator will reak havok on your site. As framework
developers, we should make using POST as easy as GET for users. To not help
users do the right thing in this situation would be irresponsible, and not in
the letter of the law sense.
+ * [frankz] Perhaps a new attribute on the action mapping?
type=view or type=update? This would really make the mapping of a specific
various type, not the underlying Action, which might be better because the type
is abstracted from the actual implementation and the Action class itself can
house both types of functions (i.e., something like a !DispatchAction), but the
framework can know to treat them differently as appropriate. I'm not one of
those no XML config! folks, I actually still prefer it to annotations, but
having an analogous annotation would be a good idea too.
1. On the OGNL value stack `#request` refers to request attributes and
`#parameters` refers to the parameters. We could rename these `#request` for
request parameters and `#requestAttributes` for request attributes.
@@ -155, +157 @@
1. The ajax support is pitiful. Have a look at how stripes does it. Ajax
for validation is trivial and not that impressive, but people are going to want
to do real ajax work, and webwork does absolutely nothing to help in that
regard. I'd like to for example be able to easily invoke actions and get at
some kind of result to display, and have webwork provide at least some of the
wiring
* [jcarreira] Well, that's a relatively simple usecase, and I think it IS
supported... at least we use it at work?
+ * [frankz] I would ask what real AJAX work means, because that would
really determine what path makes sense.
1. The default theme for the ui tags should be simple. The current stuff is
too dumb to get right on the first go, which gives an awful impression. It's
NOT intuitive to write: {{{
table
@@ -165, +168 @@
1. File upload should support progress notification. Have a look at
webwork-multipart on java.net, it's based on the pell parser but has a progress
API.
* [jcarreira] We've implemented this at work with WebWork fileupload +
DWR + a class that looks at the file as it's uploading to see how big it is on
disk
+ * [frankz] Just an opinion, but this seems to me too specific a use case
for a framework to encapsulate. I think having an example showing how to do
it, perhaps what jcarreira has done at work, would be great, but I for one
wouldn't like the framework offering this out of the box... I think it is
possible for a framework to be able to do TOO much!
1. Better error checking for UI tags. The freemarker error message, while
great for freemarker users, look like gibberish. People should not be forced to
learn freemarker. So in such cases, the tags themselves should check the
parameters and report back sane messages, even if that check is duplicated in
the templates
@@ -173, +177 @@
1. Get rid of the validation framework. it's
Welcome Tim Fennell from Stripes! (was Update of RoughSpots by TimFennell)
For those who may not recognize Tim, he is the author of the rising Stripes [1] framework that aims to simplify action-based web development building entirely on Java 5. As the Struts Action 2 discussion moves towards Java 5, we've asked him to join the discussion and bring his lessons learned from Stripes to help guide our design. To be clear, Stripes is not merging with Struts, but rather our two projects will hopefully begin to better collaborate and share ideas. As of the recently released 1.3, Stripes is now licensed under the Apache license, which should help facilitate information and code sharing. I'd also like to extend the offer of collaboration to any other web framework out there. I believe Struts and WebWork have taken an unprecedented move by merging, and hope this spirit of cooperation will continue to spread. Welcome Tim! Don [1] http://stripes.mc4j.org/confluence/display/stripes/Home Apache Wiki wrote: Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by TimFennell: http://wiki.apache.org/struts/RoughSpots The comment on the change is: Added some my issues, and commented on existing ones. -- * [crazybob] I'll buy that. We do need to move the constants out and encourage users to use static import (Effective Java Item 17). * [plightbo] Related to this, I would encourage us to try to find a solution (using Bob's mix-in suggestion below, or possibly just taking advantage of the value stack) that would make ActionSupport much simpler. This would encourage using POJOs more. * [mrdon] Regardless whether we remove Action or not, I like the idea of moving the result constants out. + * [tfenne] I think removing Action would be a bad idea. If you're going to try and get away from requiring XML configuration or listing out all your Actions somewhere, you'll probably want to have someway of discovering your Actions. An interface is the easiest option - an annotation would do too, but would feel a little stranger I think. 1. Only put classes in root package that most users need to know about. For example, most don't need to know about `Default*` or `ObjectFactory`. * [plightbo] +1 on this - sounds like Bob has a good handle on what it takes to make a nice API. I'll defer to him on this. @@ -213, +214 @@ 1. Get rid of the use of static constant variables that are used in the key in the stack and accessed all over the place like XWorkNullHandler.CREATE_NULL_OBJECTS etc. I've started to do that with the OgnlContextState class, but it's not complete and I'm not sure if that's the best way to do it. + == Tim's Issues == + I'm new around here, so be nice ;) I probably have a lot less WW experience than most, so I apologize in advance if I'm flat out wrong about some of the things here. + + 1. How does WW help the user with state management? As far as I can tell, if I want to keep a 'user' object around I have to interact with the map returned by ActionContext.getSession(). Actions should in general have a type-safe and transparent way to do this, e.g. by subclassing ActionContext and providing getUser()/setUser() which store the user in session. This allows for re-working of the storage strategy (e.g. write a cookie and lookup the user each time) without affecting actions. + 1. In tandem with the previous point, since Actions are already stateful, it'd be nice to have the ActionContext injected into the Action. One benefit is when a newbie developer needs it, the linkage is obvious (they don't have to a priori know about the ActionContext, they're being handed in it on a platter). If the developer can subclass ActionContext, it would also encourage them to implement a base action which accepts the context inject and leveraging the fact that JDK 1.5 allows co-variant returns, also write a getContext() method that returns the down-casted type; they wouldn't have to do ((MyActionContext) ActionContext.getContext()).getUser() for example, just getContext().getUser(). + 1. HTML analog tags should stick to HTML attributes. I dont' mean they shouldn't have more functionality, but the attributes should be identical where possible, and they shouldn't do things like render a label and an input. Keeping them more like regular HTML tags makes them easier to ramp up on, and more non-developer friendly + 1. Actions should return concrete objects, not symbolic results. Symbolic results might have been optimal when you had one event/method per action and the outcomes were always whole-page views, but they get in the way now. When you want to return anything that requires more than the symbol, you have to do some less than intuitive things to make the Action and the Result cooperate. I'd prefer to see a concrete Result get returned
Re: Standalone Tiles as TLP
On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Agreed. Would it be possible to do this by JavaOne? Moving Tiles isn't a huge deal, but it would make the new directions of Struts easier to explain to users. What happens to Struts Tiles, then? I'm not sure I understand why we're holding Struts Tiles out of the Struts Action distribution. Won't there always be a struts-tiles.jar of some kind, whether it's the current one with all the code, or a much lighter version that works with Standalone Tiles? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
I would think it would be Tiles' responsibility to support deployment with Struts. In that view, Tiles would be its own project, yet part of it would depend on struts-action.jar to provide the Struts hooks. In the same way, they would provide Struts Action 2 hooks, if necessary. Don Wendy Smoak wrote: On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Agreed. Would it be possible to do this by JavaOne? Moving Tiles isn't a huge deal, but it would make the new directions of Struts easier to explain to users. What happens to Struts Tiles, then? I'm not sure I understand why we're holding Struts Tiles out of the Struts Action distribution. Won't there always be a struts-tiles.jar of some kind, whether it's the current one with all the code, or a much lighter version that works with Standalone Tiles? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Struts BOF Wednesday, May 19 at 6:00 PM at JavaOne
I'm noticing JavaOne schedules filling up, so while we don't have the location nailed down, I want to reserve this timeslot for everyone: Wednesday, May 19 at 6:00 PM. This will be after our Struts Action 2 presentation at 2:45 PM, so we should have plenty to talk about :) Thanks for the location ideas, and please keep them coming. Don Gary VanMatre wrote: From: Don Brown [EMAIL PROTECTED] To help bring this flurry of ideas and directions to a head, I think we should have an unofficial Struts BOF at JavaOne next month. I envision a setting conducive to discussion, design, and planning (good beer is a definite plus :)) with the goal of exploring a roadmap for where we see Struts going in the next year. My first thought was trying to secure a side conference room at Moscone, but I don't have a clue on how to get one. We could also just meet in a hotel lobby or a quiet bar/restaurant somewhere near by. Any ideas? I don't have any suggestions on the logistics, but my employer, Wyant Data Systems (www.wyantdata.com), has offered an initial $200 for beer. Now the 'good' part is dependent on which type of brew you choose ;-) Don Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Agreed. Would it be possible to do this by JavaOne? Moving Tiles isn't a huge deal, but it would make the new directions of Struts easier to explain to users. Hmm, JavaOne is only 3 weeks away... There are two things that would need to happen: 1) Get Standalone Tiles really standalone, so that there are no dependencies on other Struts code. Maybe that's happened already - I've kinda lost track. 2) Get Jakarta Web Components bootstrapped. Actually, I think moving Tiles there might be just the kickstart that will get that subproject off the ground, because it would sidestep all the Commons navel-gazing that has effectively blocked its creation so far. I know Hen is on this list. Hen, any thoughts here before I propose this on [EMAIL PROTECTED] -- Martin Cooper Don Ted Husted wrote: On 4/22/06, Martin Cooper [EMAIL PROTECTED] wrote: I have these same concerns. That is why my preference would be for Tiles to stay here until Jakarta Web Components (nee Jakarta Silk) gets off the ground, and then move there, where it can share a general purpose web-focussed community and mindshare. That sounds fine, though I wonder if adding Tiles to Jakarta Web Components might help that project get off the ground, the way our moving BeanUtils and friends to Commons gave that effort a boost. Every mall needs an anchor. :) -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: I would think it would be Tiles' responsibility to support deployment with Struts. In that view, Tiles would be its own project, yet part of it would depend on struts-action.jar to provide the Struts hooks. In the same way, they would provide Struts Action 2 hooks, if necessary. This is a tough one - for me, at least. Should an independent Tiles have glue code for Struts, or should it be Struts' responsibility to provide the glue? If we look at Velocity, the glue is over there, but we've also talked about it coming here. If we look at Validator, the glue is here. If we look at Chain, the servlet and portlet glue is over there. My preference, at least at this time, would be for the Struts / Tiles glue to stay here. That will help Standalone Tiles stand on its own feet, and especially help with the notion that it's now independent of Struts. Any perception - real or otherwise - that Tiles is tied to Struts will be detrimental to Tiles as an independent library. -- Martin Cooper Don Wendy Smoak wrote: On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Agreed. Would it be possible to do this by JavaOne? Moving Tiles isn't a huge deal, but it would make the new directions of Struts easier to explain to users. What happens to Struts Tiles, then? I'm not sure I understand why we're holding Struts Tiles out of the Struts Action distribution. Won't there always be a struts-tiles.jar of some kind, whether it's the current one with all the code, or a much lighter version that works with Standalone Tiles? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Struts BOF Wednesday, May 17 at 6:00 PM at JavaOne (corrected
Sorry, that date should be May 17, not 19. Don Don Brown wrote: I'm noticing JavaOne schedules filling up, so while we don't have the location nailed down, I want to reserve this timeslot for everyone: Wednesday, May 19 at 6:00 PM. This will be after our Struts Action 2 presentation at 2:45 PM, so we should have plenty to talk about :) Thanks for the location ideas, and please keep them coming. Don Gary VanMatre wrote: From: Don Brown [EMAIL PROTECTED] To help bring this flurry of ideas and directions to a head, I think we should have an unofficial Struts BOF at JavaOne next month. I envision a setting conducive to discussion, design, and planning (good beer is a definite plus :)) with the goal of exploring a roadmap for where we see Struts going in the next year. My first thought was trying to secure a side conference room at Moscone, but I don't have a clue on how to get one. We could also just meet in a hotel lobby or a quiet bar/restaurant somewhere near by. Any ideas? I don't have any suggestions on the logistics, but my employer, Wyant Data Systems (www.wyantdata.com), has offered an initial $200 for beer. Now the 'good' part is dependent on which type of brew you choose ;-) Don Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts BOF Wednesday, May 17 at 6:00 PM at JavaOne (corrected
You've mentioned hosting a session at Java One, but have you announced the session to the list yet? On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Sorry, that date should be May 17, not 19. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Agitator Licenses for Struts Committers
Agitar Software (http://www.agitar.com/) has donated several licenses for its Agitator product to Apache Struts for our committers to use on open source projects. The Agitator includes experts that help it work better with frameworks like Struts Action. Right now, the Agitator Struts Expert supports Action 1.2. Experts for other releases of Apache Struts frameworks are expected. I'm working with Agitar to make the Expert API available to us, so that we can create and maintain our own experts. A whitepaper that describes using the Agitator to test the MailReader is available here: * http://www.StrutsUniversity.org/Agitator And I'll be giving the whitepaper as a webinar on Wednesday. * http://www.planetstruts.org/roller/page/news?entry=what_to_do_if_your Apache Struts committers can find the list of product keys in the ASF repository. * https://svn.apache.org/repos/private/committers/pmc/struts/agitator-keys.txt Access to this file is resticted to Struts committers. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts BOF Wednesday, May 19 at 6:00 PM at JavaOne
Just so you know, my company (and many others) are hosting a Geronimo party at that same time. http://www.virtuas.com/geronimo/geronimolive If you'd like, I could get all the Struts Committers invites, and you could have the meeting there. ;-) Matt On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: I'm noticing JavaOne schedules filling up, so while we don't have the location nailed down, I want to reserve this timeslot for everyone: Wednesday, May 19 at 6:00 PM. This will be after our Struts Action 2 presentation at 2:45 PM, so we should have plenty to talk about :) Thanks for the location ideas, and please keep them coming. Don Gary VanMatre wrote: From: Don Brown [EMAIL PROTECTED] To help bring this flurry of ideas and directions to a head, I think we should have an unofficial Struts BOF at JavaOne next month. I envision a setting conducive to discussion, design, and planning (good beer is a definite plus :)) with the goal of exploring a roadmap for where we see Struts going in the next year. My first thought was trying to secure a side conference room at Moscone, but I don't have a clue on how to get one. We could also just meet in a hotel lobby or a quiet bar/restaurant somewhere near by. Any ideas? I don't have any suggestions on the logistics, but my employer, Wyant Data Systems (www.wyantdata.com), has offered an initial $200 for beer. Now the 'good' part is dependent on which type of brew you choose ;-) Don Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts BOF Wednesday, May 19 at 6:00 PM at JavaOne
Thanks for the invite :) A social occasion would be fun, but I want to ensure time for a technical discussion. Would it be possible for the W hotel to give up a little side conference room for an hour or so, say 7:30 - 8:30 or so? Also, could it be open to anyone rather than just committers? A number of non-committers have expressed interest in getting involved in the design meeting. Don On 4/23/06, Matt Raible [EMAIL PROTECTED] wrote: Just so you know, my company (and many others) are hosting a Geronimo party at that same time. http://www.virtuas.com/geronimo/geronimolive If you'd like, I could get all the Struts Committers invites, and you could have the meeting there. ;-) Matt On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: I'm noticing JavaOne schedules filling up, so while we don't have the location nailed down, I want to reserve this timeslot for everyone: Wednesday, May 19 at 6:00 PM. This will be after our Struts Action 2 presentation at 2:45 PM, so we should have plenty to talk about :) Thanks for the location ideas, and please keep them coming. Don Gary VanMatre wrote: From: Don Brown [EMAIL PROTECTED] To help bring this flurry of ideas and directions to a head, I think we should have an unofficial Struts BOF at JavaOne next month. I envision a setting conducive to discussion, design, and planning (good beer is a definite plus :)) with the goal of exploring a roadmap for where we see Struts going in the next year. My first thought was trying to secure a side conference room at Moscone, but I don't have a clue on how to get one. We could also just meet in a hotel lobby or a quiet bar/restaurant somewhere near by. Any ideas? I don't have any suggestions on the logistics, but my employer, Wyant Data Systems (www.wyantdata.com), has offered an initial $200 for beer. Now the 'good' part is dependent on which type of brew you choose ;-) Don Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts BOF Wednesday, May 17 at 6:00 PM at JavaOne (corrected
Not directly yet, but that's a good idea. I'll do that when we nail down this BOF so I can announce both at the same time. Don Ted Husted wrote: You've mentioned hosting a session at Java One, but have you announced the session to the list yet? On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Sorry, that date should be May 17, not 19. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts BOF Wednesday, May 19 at 6:00 PM at JavaOne
I'll see what I can do and get back to you tomorrow. Matt On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Thanks for the invite :) A social occasion would be fun, but I want to ensure time for a technical discussion. Would it be possible for the W hotel to give up a little side conference room for an hour or so, say 7:30 - 8:30 or so? Also, could it be open to anyone rather than just committers? A number of non-committers have expressed interest in getting involved in the design meeting. Don On 4/23/06, Matt Raible [EMAIL PROTECTED] wrote: Just so you know, my company (and many others) are hosting a Geronimo party at that same time. http://www.virtuas.com/geronimo/geronimolive If you'd like, I could get all the Struts Committers invites, and you could have the meeting there. ;-) Matt On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: I'm noticing JavaOne schedules filling up, so while we don't have the location nailed down, I want to reserve this timeslot for everyone: Wednesday, May 19 at 6:00 PM. This will be after our Struts Action 2 presentation at 2:45 PM, so we should have plenty to talk about :) Thanks for the location ideas, and please keep them coming. Don Gary VanMatre wrote: From: Don Brown [EMAIL PROTECTED] To help bring this flurry of ideas and directions to a head, I think we should have an unofficial Struts BOF at JavaOne next month. I envision a setting conducive to discussion, design, and planning (good beer is a definite plus :)) with the goal of exploring a roadmap for where we see Struts going in the next year. My first thought was trying to secure a side conference room at Moscone, but I don't have a clue on how to get one. We could also just meet in a hotel lobby or a quiet bar/restaurant somewhere near by. Any ideas? I don't have any suggestions on the logistics, but my employer, Wyant Data Systems (www.wyantdata.com), has offered an initial $200 for beer. Now the 'good' part is dependent on which type of brew you choose ;-) Don Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Martin Cooper [EMAIL PROTECTED] wrote: On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: I would think it would be Tiles' responsibility to support deployment with Struts. In that view, Tiles would be its own project, yet part of it would depend on struts-action.jar to provide the Struts hooks. In the same way, they would provide Struts Action 2 hooks, if necessary. This is a tough one - for me, at least. Should an independent Tiles have glue code for Struts, or should it be Struts' responsibility to provide the glue? If we look at Velocity, the glue is over there, but we've also talked about it coming here. If we look at Validator, the glue is here. If we look at Chain, the servlet and portlet glue is over there. I've always thought it would be as Martin describes for Validator -- standalone Tiles would really be standalone, and each framework that wanted to utilize it would provide it's own glue to some particular version(s) of Standalone Tiles. That is what Shale already does with the standalone Tiles stuff -- for example, Shale integrates tiles into the standard JSF navigation mechanism. That's not something that it seems reasonable to impose on a standalone project. My preference, at least at this time, would be for the Struts / Tiles glue to stay here. That will help Standalone Tiles stand on its own feet, and especially help with the notion that it's now independent of Struts. Any perception - real or otherwise - that Tiles is tied to Struts will be detrimental to Tiles as an independent library. +1 -- Martin Cooper Craig
svn commit: r396335 - in /struts/action/trunk/apps: pom.xml src/ src/site/ src/site/site.xml xdocs/
Author: wsmoak
Date: Sun Apr 23 16:00:09 2006
New Revision: 396335
URL: http://svn.apache.org/viewcvs?rev=396335view=rev
Log:
Maven 2 reorganization.
Added:
struts/action/trunk/apps/src/
struts/action/trunk/apps/src/site/
struts/action/trunk/apps/src/site/site.xml (contents, props changed)
- copied, changed from r396315,
struts/action/trunk/apps/xdocs/navigation.xml
Removed:
struts/action/trunk/apps/xdocs/
Modified:
struts/action/trunk/apps/pom.xml
Modified: struts/action/trunk/apps/pom.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/apps/pom.xml?rev=396335r1=396334r2=396335view=diff
==
--- struts/action/trunk/apps/pom.xml (original)
+++ struts/action/trunk/apps/pom.xml Sun Apr 23 16:00:09 2006
@@ -19,18 +19,6 @@
*/
--
-!--
- Experimental Maven 2 Build for Apache Struts
-
-
-To build and install this module into your local repo:
-
- $ mvn install
-
-For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan
-
---
-
project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
Copied: struts/action/trunk/apps/src/site/site.xml (from r396315,
struts/action/trunk/apps/xdocs/navigation.xml)
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/apps/src/site/site.xml?p2=struts/action/trunk/apps/src/site/site.xmlp1=struts/action/trunk/apps/xdocs/navigation.xmlr1=396315r2=396335rev=396335view=diff
==
--- struts/action/trunk/apps/xdocs/navigation.xml (original)
+++ struts/action/trunk/apps/src/site/site.xml Sun Apr 23 16:00:09 2006
@@ -1,11 +1,44 @@
?xml version=1.0 encoding=ISO-8859-1?
-project name=Struts Applications
-titleApache Struts - Struts Applications/title
+project name=Apache Struts
+bannerLeft
+nameApache Software Foundation/name
+srchttp://www.apache.org/images/asf-logo.gif/src
+hrefhttp://www.apache.org/href
+/bannerLeft
+bannerRight
+nameApache Struts/name
+srchttp://struts.apache.org/images/struts.gif/src
+hrefhttp://struts.apache.org/href
+/bannerRight
body
+links
+item name=Apache href=http://www.apache.org; /
+item name=Action href=http://struts.apache.org/struts-action;
/
+item name=Shale href=http://struts.apache.org/struts-shale; /
+item name=Tiles href=http://struts.apache.org/struts-tiles; /
+/links
+
menu name=Quick Links
item
name=Apache Struts Home
+href=http://struts.apache.org//
+item
+name=Struts Action
href=../index.html/
/menu
+
+menu name=Apps
+item
+name=Cookbook
+href=struts-cookbook//
+item
+name=Mailreader
+href=struts-mailreader//
+/menu
+
+${modules}
+
+${reports}
+
/body
/project
Propchange: struts/action/trunk/apps/src/site/site.xml
--
svn:eol-style = native
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Struts [2006/04/23]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 5739|Opn|Enh|2002-01-08|Struts fails silently in too many places | | 5937|New|Enh|2002-01-21|[taglib] html:form trims all extensions | | 6847|New|Enh|2002-03-04|Multiple file upload not possible due to MultiPart| | 7902|Opn|Enh|2002-04-10|The exception handling declaration in the DTD does| | 8240|Ver|Min|2002-04-18|Data-Source configuration in examples is outdated | | 9088|Opn|Enh|2002-05-15|FormTag.getActionMappingURL() assumes 1 servlet ma| | 9616|New|Enh|2002-06-05|Some more Struts docs | | 9748|New|Enh|2002-06-10|[taglib] attribute labelKeyProperty for Options ta| |10550|New|Enh|2002-07-08|Delegate path-management to ActionForwards| |10552|New|Enh|2002-07-08|create helper objects in struts-config| |10867|Opn|Enh|2002-07-16|[taglib] Add indexedProperty attribute in html tag| |11154|Opn|Enh|2002-07-25|[taglib] html:link tag extension for multiple para| |11733|Opn|Enh|2002-08-15|Make error keys more specific | |12170|Opn|Enh|2002-08-29|Added functionality when extending another definit| |12301|Opn|Enh|2002-09-04|[taglib] nested:messages Tag does not work as expe| |12600|New|Enh|2002-09-12|[taglib] html:form tag always prepends context pat| |13125|Opn|Enh|2002-09-30|[taglib] Lack of character-set while using html:| |13521|New|Enh|2002-10-11|CombinedDispatchAction| |13544|Opn|Enh|2002-10-11|[exception] support contextRelative paths | |14183|New|Enh|2002-11-01|[taglib] html:img does not support forward attribu| |15188|New|Enh|2002-12-09|roles attribute of tags and definitions only allow| |15422|Opn|Enh|2002-12-17|[taglib] Form Tag exportFormName attribute | |15816|Opn|Enh|2003-01-06|[taglib] html:form focus in pages with several for| |15849|Opn|Enh|2003-01-07|Incorrect documentation for Developing Your Own M| |16074|New|Enh|2003-01-14|[taglib] html:form uses 'action' not 'input' to se| |16107|Opn|Enh|2003-01-15|Configure if you want to call ActionForm.reset() i| |16207|Opn|Enh|2003-01-17|[tiles] Add ability to import tile attributes into| |16401|New|Enh|2003-01-24|ActionValidatorUtil | |16543|Opn|Enh|2003-01-29|IncludeAction should return an ActionForward. | |16603|Opn|Enh|2003-01-30|controller forwardPattern should support differe| |16708|New|Enh|2003-02-03|I18N on ActionForwards| |16764|Opn|Enh|2003-02-04|No inheritance of html:html xhtml=true in includ| |16792|Ass|Enh|2003-02-05|Migrate to commons-resources for message resources| |16814|New|Enh|2003-02-05|Add a generalized utililty class to expose informa| |16946|Opn|Enh|2003-02-10|SwitchAction not setting context properly for tile| |16971|New|Enh|2003-02-11|[taglib] multiple attribute on select tag should| |17368|Opn|Enh|2003-02-25|[taglib] html:select multiple does not populate | |17449|New|Enh|2003-02-26|[taglib] Allow relative URL in action attribute of| |17473|New|Enh|2003-02-27|[taglib] Problem to include a jsp into an iterate | |17530|New|Enh|2003-02-28|RequestUtils.computeURL should use the session ass| |17559|New|Enh|2003-03-01|[tiles] key attribute for tiles (put item) | |17600|New|Enh|2003-03-03|[taglib] key property for html:optionsCollection t| |17698|Opn|Enh|2003-03-05|The value(key) form name pattern doesn't work with| |18015|Opn|Enh|2003-03-14|[taglib] New html:label custom tag to write form| |18017|Opn|Enh|2003-03-14|[tiles] extends fails in JSP-based Definitions| |18022|New|Enh|2003-03-14|HttpSessionBindingListener.valueUnbound() called o| |18032|Opn|Enh|2003-03-16|[taglib] html:img tag appending session doesn't | |18194|Opn|Enh|2003-03-20|[resources] Enhance MessageResources to enable sev| |18237|Opn|Enh|2003-03-21|[tiles] excessive memory usage| |18293|New|Enh|2003-03-24|Loading language files does not use Resource Bundl| |18788|New|Enh|2003-04-07|Multiple input hook for multipage forms in process|
Re: Bug report for Struts [2006/04/23]
Heh, guess we'll need to turn that off :) Don [EMAIL PROTECTED] wrote: +---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 5739|Opn|Enh|2002-01-08|Struts fails silently in too many places | | 5937|New|Enh|2002-01-21|[taglib] html:form trims all extensions | | 6847|New|Enh|2002-03-04|Multiple file upload not possible due to MultiPart| | 7902|Opn|Enh|2002-04-10|The exception handling declaration in the DTD does| | 8240|Ver|Min|2002-04-18|Data-Source configuration in examples is outdated | | 9088|Opn|Enh|2002-05-15|FormTag.getActionMappingURL() assumes 1 servlet ma| | 9616|New|Enh|2002-06-05|Some more Struts docs | | 9748|New|Enh|2002-06-10|[taglib] attribute labelKeyProperty for Options ta| |10550|New|Enh|2002-07-08|Delegate path-management to ActionForwards| |10552|New|Enh|2002-07-08|create helper objects in struts-config| |10867|Opn|Enh|2002-07-16|[taglib] Add indexedProperty attribute in html tag| |11154|Opn|Enh|2002-07-25|[taglib] html:link tag extension for multiple para| |11733|Opn|Enh|2002-08-15|Make error keys more specific | |12170|Opn|Enh|2002-08-29|Added functionality when extending another definit| |12301|Opn|Enh|2002-09-04|[taglib] nested:messages Tag does not work as expe| |12600|New|Enh|2002-09-12|[taglib] html:form tag always prepends context pat| |13125|Opn|Enh|2002-09-30|[taglib] Lack of character-set while using html:| |13521|New|Enh|2002-10-11|CombinedDispatchAction| |13544|Opn|Enh|2002-10-11|[exception] support contextRelative paths | |14183|New|Enh|2002-11-01|[taglib] html:img does not support forward attribu| |15188|New|Enh|2002-12-09|roles attribute of tags and definitions only allow| |15422|Opn|Enh|2002-12-17|[taglib] Form Tag exportFormName attribute | |15816|Opn|Enh|2003-01-06|[taglib] html:form focus in pages with several for| |15849|Opn|Enh|2003-01-07|Incorrect documentation for Developing Your Own M| |16074|New|Enh|2003-01-14|[taglib] html:form uses 'action' not 'input' to se| |16107|Opn|Enh|2003-01-15|Configure if you want to call ActionForm.reset() i| |16207|Opn|Enh|2003-01-17|[tiles] Add ability to import tile attributes into| |16401|New|Enh|2003-01-24|ActionValidatorUtil | |16543|Opn|Enh|2003-01-29|IncludeAction should return an ActionForward. | |16603|Opn|Enh|2003-01-30|controller forwardPattern should support differe| |16708|New|Enh|2003-02-03|I18N on ActionForwards| |16764|Opn|Enh|2003-02-04|No inheritance of html:html xhtml=true in includ| |16792|Ass|Enh|2003-02-05|Migrate to commons-resources for message resources| |16814|New|Enh|2003-02-05|Add a generalized utililty class to expose informa| |16946|Opn|Enh|2003-02-10|SwitchAction not setting context properly for tile| |16971|New|Enh|2003-02-11|[taglib] multiple attribute on select tag should| |17368|Opn|Enh|2003-02-25|[taglib] html:select multiple does not populate | |17449|New|Enh|2003-02-26|[taglib] Allow relative URL in action attribute of| |17473|New|Enh|2003-02-27|[taglib] Problem to include a jsp into an iterate | |17530|New|Enh|2003-02-28|RequestUtils.computeURL should use the session ass| |17559|New|Enh|2003-03-01|[tiles] key attribute for tiles (put item) | |17600|New|Enh|2003-03-03|[taglib] key property for html:optionsCollection t| |17698|Opn|Enh|2003-03-05|The value(key) form name pattern doesn't work with| |18015|Opn|Enh|2003-03-14|[taglib] New html:label custom tag to write form| |18017|Opn|Enh|2003-03-14|[tiles] extends fails in JSP-based Definitions| |18022|New|Enh|2003-03-14|HttpSessionBindingListener.valueUnbound() called o| |18032|Opn|Enh|2003-03-16|[taglib] html:img tag appending session doesn't | |18194|Opn|Enh|2003-03-20|[resources] Enhance MessageResources to enable sev| |18237|Opn|Enh|2003-03-21|[tiles] excessive memory usage| |18293|New|Enh|2003-03-24|Loading language files does not use Resource Bundl|
Re: Bug report for Struts [2006/04/23]
On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: Heh, guess we'll need to turn that off :) I should already know this, but does JIRA have an automatic email report that we can turn on? -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396336 - in /struts/action/trunk/assembly: pom.xml src/main/assembly/dist.xml
Author: wsmoak
Date: Sun Apr 23 16:20:09 2006
New Revision: 396336
URL: http://svn.apache.org/viewcvs?rev=396336view=rev
Log:
First pass at an assembly that includes the source code and website docs.
Added:
struts/action/trunk/assembly/src/main/assembly/dist.xml (with props)
Modified:
struts/action/trunk/assembly/pom.xml
Modified: struts/action/trunk/assembly/pom.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/assembly/pom.xml?rev=396336r1=396335r2=396336view=diff
==
--- struts/action/trunk/assembly/pom.xml (original)
+++ struts/action/trunk/assembly/pom.xml Sun Apr 23 16:20:09 2006
@@ -19,18 +19,6 @@
*/
--
-!--
- Experimental Maven 2 Build for Apache Struts
-
-
-To create the assembly:
-
- $ mvn assembly:assembly
-
-For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan
-
---
-
project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
modelVersion4.0.0/modelVersion
@@ -63,7 +51,7 @@
groupIdorg.codehaus.mojo/groupId
artifactIddependency-maven-plugin/artifactId
executions
- execution
+ !--execution
idcopy-javadoc/id
phasepackage/phase
goals
@@ -116,7 +104,7 @@
/artifactItems
outputDirectory${project.build.directory}/javadoc/outputDirectory
/configuration
- /execution
+ /execution--
execution
idcopy-war/id
phasepackage/phase
@@ -183,7 +171,7 @@
outputDirectory${project.build.directory}/webapps/outputDirectory
/configuration
/execution
- execution
+ !--execution
idcopy-sources/id
phasepackage/phase
goals
@@ -236,7 +224,7 @@
/artifactItems
outputDirectory${project.build.directory}/sources/outputDirectory
/configuration
- /execution
+ /execution--
/executions
/plugin
/plugins
@@ -251,7 +239,8 @@
version2.0.1/version
configuration
descriptors
-descriptorsrc/main/assembly/all.xml/descriptor
+descriptorsrc/main/assembly/dist.xml/descriptor
+!-- descriptorsrc/main/assembly/all.xml/descriptor --
!-- descriptorsrc/main/assembly/dep.xml/descriptor --
!-- descriptorsrc/main/assembly/src.xml/descriptor --
/descriptors
Added: struts/action/trunk/assembly/src/main/assembly/dist.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/assembly/src/main/assembly/dist.xml?rev=396336view=auto
==
--- struts/action/trunk/assembly/src/main/assembly/dist.xml (added)
+++ struts/action/trunk/assembly/src/main/assembly/dist.xml Sun Apr 23 16:20:09
2006
@@ -0,0 +1,87 @@
+assembly
+ idall/id
+ formats
+formatzip/format
+ /formats
+ dependencySets
+dependencySet
+ outputDirectorylib/outputDirectory
+ scoperuntime/scope
+/dependencySet
+ /dependencySets
+ fileSets
+fileSet
+ directorysrc/main/resources/directory
+ outputDirectory/outputDirectory
+ includes
+includeREADME*/include
+includeLICENSE*/include
+includeNOTICE*/include
+ /includes
+/fileSet
+fileSet
+ directorytarget/webapps/directory
+ outputDirectorywebapps/outputDirectory
+ includes
+include*.war/include
+ /includes
+/fileSet
+
+!-- Include the source code in the assembly --
+fileSet
+ directory..//directory
+ outputDirectorysrc//outputDirectory
+ includes
+includepom.xml/include
+ /includes
+/fileSet
+fileSet
+ directory../core/directory
+ outputDirectorysrc/core/outputDirectory
+ includes
+includepom.xml/include
+includesrc//include
+ /includes
+ /fileSet
+ fileSet
+ directory../el/directory
+ outputDirectorysrc/el/outputDirectory
+ includes
+includepom.xml/include
+includesrc//include
+ /includes
+ /fileSet
+ fileSet
+ directory../taglib/directory
+ outputDirectorysrc/taglib/outputDirectory
+ includes
+includepom.xml/include
+includesrc//include
+ /includes
+ /fileSet
+
+
+ !-- Include the website docs in the assembly --
+ fileSet
+ directory../target/site/directory
+ outputDirectorydocs//outputDirectory
+ /fileSet
+ fileSet
+ directory../apps/target/site/directory
+ outputDirectorydocs/struts-apps/outputDirectory
+ /fileSet
+ fileSet
+ directory../core/target/site/directory
+
[Struts Wiki] Update of StrutsMaintenanceMaven by WendySmoak
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Struts Wiki for change
notification.
The following page has been changed by WendySmoak:
http://wiki.apache.org/struts/StrutsMaintenanceMaven
The comment on the change is:
Update assembly instructions
--
}}}
=== Binary and Source Assembly ===
- To build the -all assembly, first enable the 'pre-assembly' profile, which
will cause the javadoc and source artifacts to be produced:
+ To build the -all assembly, enable the 'pre-assembly' profile (which produces
the javadoc and source artifacts), and execute both 'install' and 'site':
{{{
~/svn/struts/current/action
-$ mvn -P pre-assembly
+$ mvn install site -P pre-assembly
}}}
And then create the assembly:
{{{
@@ -56, +56 @@
=== Source Assembly ===
- * The -sources jars are included in struts-action-x.x.x-all.[zip|tar.gz].
+ * The source code is included in struts-action-x.x.x-all.zip.
- * Wait for v2.1 of maven-assembly-plugin, then switch to the
action/assembly/src/main/assembly/src.xml and dep.xml descriptors for separate
-bin and -src assemblies.
+ * Wait for v2.1 of maven-assembly-plugin, then consider switching to the
action/assembly/src/main/assembly/src.xml and dep.xml descriptors for separate
-bin and -src assemblies.
* See StrutsMaven2Plan for some additional thoughts on assemblies.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Update of StrutsMavenRelease by WendySmoak
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Struts Wiki for change
notification.
The following page has been changed by WendySmoak:
http://wiki.apache.org/struts/StrutsMavenRelease
The comment on the change is:
The site must be built before the assembly.
--
1. Ensure that your settings.xml contains a server for
apache-maven-test-builds (see the Suggested Settings section on
StrutsMaintenanceMaven)
1. Clear out your local Maven repo
1. Build all jar and war artifacts, including -sources and -javadoc, and
deploy them to maven-snapshot-repository.
+ 1. Build and deploy the website
1. Create the assembly and upload it to cvs.apache.org/dist
1. Make sure that everything under
maven-snapshot-repository/org/apache/struts is group writeable
1. Create and upload signatures for all .jar and .pom files in
maven-snapshot-repository, and the .zip, and .tar.gz files.
@@ -16, +17 @@
rm -rf $M2_REPO/org/apache/struts/action
mvn deploy -P pre-assembly
{about 20 minutes later...}
+ mvn site site:deploy
+ {may have to deploy the site for each module individually}
cd assembly
mvn assembly:assembly
scp target/assembly/out/*
people.apache.org:/www/cvs.apache.org/dist/struts/action/v.1.3.2
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396345 - in /incubator/webwork2: ./ action/ action/src/main/java/org/apache/struts/action2/ action/src/test/java/org/apache/struts/action2/dispatcher/ action/src/test/java/org/apache/stru
Author: plightbo
Date: Sun Apr 23 16:48:36 2006
New Revision: 396345
URL: http://svn.apache.org/viewcvs?rev=396345view=rev
Log:
more tests now extend StrutsTestCase like they should; StrutsTestCase resets
more stuff like it should; refactored maven build to reduce version number
repetition
Modified:
incubator/webwork2/action/pom.xml
incubator/webwork2/action/src/main/java/org/apache/struts/action2/StrutsTestCase.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/DispatcherUtilsTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/HttpHeaderResultTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/interceptor/TokenInterceptorTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/portlet/context/PreparatorServletTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/portlet/util/StrutsUtilTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/spring/StrutsSpringObjectFactoryTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ElseTagTest.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/xslt/XSLTResultTest.java
incubator/webwork2/pom.xml
incubator/webwork2/thirdparty/jasperreports/pom.xml
incubator/webwork2/thirdparty/jfreechart/pom.xml
incubator/webwork2/thirdparty/pell-file-upload/pom.xml
incubator/webwork2/thirdparty/pom.xml
incubator/webwork2/uber/pom.xml
incubator/webwork2/webapps/blank/pom.xml
incubator/webwork2/webapps/pom.xml
incubator/webwork2/webapps/portlet/pom.xml
incubator/webwork2/webapps/shopping-cart/pom.xml
incubator/webwork2/webapps/showcase/pom.xml
incubator/webwork2/webapps/starter/pom.xml
Modified: incubator/webwork2/action/pom.xml
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/pom.xml?rev=396345r1=396344r2=396345view=diff
==
--- incubator/webwork2/action/pom.xml (original)
+++ incubator/webwork2/action/pom.xml Sun Apr 23 16:48:36 2006
@@ -8,7 +8,6 @@
version2.0-SNAPSHOT/version
/parent
groupIdorg.apache.struts.action2/groupId
-version2.0-SNAPSHOT/version
artifactIdaction/artifactId
packagingjar/packaging
nameStruts Action Framework 2.0/name
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/StrutsTestCase.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/java/org/apache/struts/action2/StrutsTestCase.java?rev=396345r1=396344r2=396345view=diff
==
---
incubator/webwork2/action/src/main/java/org/apache/struts/action2/StrutsTestCase.java
(original)
+++
incubator/webwork2/action/src/main/java/org/apache/struts/action2/StrutsTestCase.java
Sun Apr 23 16:48:36 2006
@@ -18,7 +18,9 @@
package org.apache.struts.action2;
import org.apache.struts.action2.config.Configuration;
+import org.apache.struts.action2.dispatcher.DispatcherUtils;
import com.opensymphony.xwork.XWorkTestCase;
+import com.opensymphony.xwork.util.LocalizedTextUtil;
/**
* Base test case for unit testing WebWork.
@@ -27,7 +29,9 @@
protected void setUp() throws Exception {
super.setUp();
+DispatcherUtils.setInstance(null);
Configuration.reset();
+LocalizedTextUtil.clearDefaultResourceBundles();
}
protected void tearDown() throws Exception {
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/DispatcherUtilsTest.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/DispatcherUtilsTest.java?rev=396345r1=396344r2=396345view=diff
==
---
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/DispatcherUtilsTest.java
(original)
+++
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/DispatcherUtilsTest.java
Sun Apr 23 16:48:36 2006
@@ -20,6 +20,7 @@
import java.util.Locale;
import org.springframework.mock.web.MockServletContext;
+import org.apache.struts.action2.StrutsTestCase;
import com.opensymphony.xwork.util.LocalizedTextUtil;
@@ -29,7 +30,7 @@
* Test case for DispatcherUtils.
*
*/
-public class DispatcherUtilsTest extends TestCase {
+public class DispatcherUtilsTest extends StrutsTestCase {
public void testDefaultResurceBundlePropertyLoaded() throws Exception {
Locale.setDefault(Locale.US); // force to US locale as we also have
_de and _da properties
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/HttpHeaderResultTest.java
URL:
svn commit: r396354 - in /incubator/webwork2: action/pom.xml pom.xml
Author: plightbo Date: Sun Apr 23 17:21:44 2006 New Revision: 396354 URL: http://svn.apache.org/viewcvs?rev=396354view=rev Log: more pom refactoring Modified: incubator/webwork2/action/pom.xml incubator/webwork2/pom.xml Modified: incubator/webwork2/action/pom.xml URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/pom.xml?rev=396354r1=396353r2=396354view=diff == --- incubator/webwork2/action/pom.xml (original) +++ incubator/webwork2/action/pom.xml Sun Apr 23 17:21:44 2006 @@ -25,39 +25,33 @@ dependency groupIdopensymphony/groupId artifactIdxwork/artifactId -version1.2-SNAPSHOT/version /dependency dependency groupIdfreemarker/groupId artifactIdfreemarker/artifactId -version2.3.4/version /dependency dependency groupIdjavax.servlet/groupId artifactIdservlet-api/artifactId -version2.4/version scopeprovided/scope /dependency dependency groupIdjavax.servlet/groupId artifactIdjsp-api/artifactId -version2.0/version scopeprovided/scope /dependency dependency groupIdcommons-logging/groupId artifactIdcommons-logging/artifactId -version1.0.4/version /dependency dependency groupIdcommons-lang/groupId artifactIdcommons-lang/artifactId -version2.0/version optionaltrue/optional /dependency @@ -65,7 +59,6 @@ dependency groupIduk.ltd.getahead/groupId artifactIddwr/artifactId -version1.1-beta-3/version optionaltrue/optional /dependency @@ -73,14 +66,12 @@ dependency groupIdvelocity/groupId artifactIdvelocity/artifactId -version1.4/version optionaltrue/optional /dependency dependency groupIdvelocity-tools/groupId artifactIdvelocity-tools/artifactId -version1.1/version optionaltrue/optional /dependency @@ -88,14 +79,12 @@ dependency groupIdcommons-fileupload/groupId artifactIdcommons-fileupload/artifactId -version1.1/version optionaltrue/optional /dependency dependency groupIdservlets.com/groupId artifactIdcos/artifactId -version05Nov2002/version optionaltrue/optional /dependency @@ -103,7 +92,6 @@ groupIdopensymphony/groupId artifactIdpell-multipart/artifactId !-- webwork's ivy dependency reports mentions v1.19 ? -- -version2.1.5/version optionaltrue/optional /dependency @@ -112,7 +100,6 @@ !-- group should be com.opensymphony -- groupIdopensymphony/groupId artifactIdsitemesh/artifactId -version2.2.1/version optionaltrue/optional /dependency @@ -120,14 +107,12 @@ dependency groupIdjetty/groupId artifactIdorg.mortbay.jetty/artifactId -version5.1.4/version optionaltrue/optional /dependency dependency groupIdeclipse/groupId artifactIdjdtcore/artifactId -version3.1.0/version optionaltrue/optional /dependency @@ -135,7 +120,6 @@ dependency groupIdjasperreports/groupId artifactIdjasperreports/artifactId -version1.1.0/version optionaltrue/optional /dependency @@ -143,7 +127,6 @@ dependency groupIdjfree/groupId artifactIdjfreechart/artifactId -version1.0.0/version optionaltrue/optional exclusions exclusion @@ -157,13 +140,11 @@ dependency groupIdorg.apache.struts.tiles/groupId artifactIdtiles-core/artifactId -version0.2-SNAPSHOT/version optionaltrue/optional /dependency dependency groupIdcommons-digester/groupId artifactIdcommons-digester/artifactId -version1.7/version optionaltrue/optional /dependency @@ -171,14 +152,12 @@ dependency groupIdportlet-api/groupId artifactIdportlet-api/artifactId -version1.0/version optionaltrue/optional /dependency dependency groupIdorg.apache.pluto/groupId artifactIdpluto/artifactId -version1.0.1-rc4/version optionaltrue/optional /dependency @@ -186,7
[Struts Wiki] Update of RoughSpots by CraigMcClanahan
Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by CraigMcClanahan: http://wiki.apache.org/struts/RoughSpots -- * [plightbo] Related to this, I would encourage us to try to find a solution (using Bob's mix-in suggestion below, or possibly just taking advantage of the value stack) that would make ActionSupport much simpler. This would encourage using POJOs more. * [mrdon] Regardless whether we remove Action or not, I like the idea of moving the result constants out. * [tfenne] I think removing Action would be a bad idea. If you're going to try and get away from requiring XML configuration or listing out all your Actions somewhere, you'll probably want to have someway of discovering your Actions. An interface is the easiest option - an annotation would do too, but would feel a little stranger I think. + * [craigmcc] You can actually have this one both ways, as we do in Shale -- define an Action interface for + the JDK 1.4 users, and provide an optional JavaSE 5 layer that lets you define the appropriate callbacks + with annotations instead. For a detailed example, take a look at how Shale's Tiger Extensions package + lets you get the functionality of a ViewController interface without having to say implements + ViewController in your action class. 1. Only put classes in root package that most users need to know about. For example, most don't need to know about `Default*` or `ObjectFactory`. * [plightbo] +1 on this - sounds like Bob has a good handle on what it takes to make a nice API. I'll defer to him on this. * [mrdon] +1 + * [craigmcc] In Shale, I adopted the convention of package org.apache.shale.foo for public APIs, and + org.apache.shale.foo.impl for things like default implemetnation classes. However, there is an additional + subtlety here to take into account -- there is a difference between APIs that application developers should + depend on versus those extending the framework should be allowed to extend. The latter category of folks + can be presumed to be smaller, as well as more willing to deal with occastional API breakages. 1. Only make classes/members public if we're willing to guarantee future compatibility. Everything else should be package-private or excluded from the Javadocs. @@ -35, +45 @@ * [mrdon] This I don't agree with. From a framework developer, I understand the logic, but from a user, it is arrogant. I think we should allow people to extend Struts in ways we haven't imagined, and restricting access like this says, We know more than you and will force you to do it our way. * [crazybob] I don't think we should make everything final or anything, but I do think we should differentiate between the published API and the implementation through package organization, excluding stuff from the Javadocs, etc. Users can know that we won't change the published API out from under them, but that if they depend on implementation classes, we may break them (reluctantly). It's the polite thing to do, and it frees us up to refactor and improve our implementation. * [jcarreira] +1 published public vs. private APIs are a good thing, and a contract with the user of what can change. + * [craigmcc] See comments on the previous bullet related to APIs that application developers use versus those + who are extending the framework might use. 1. Remove `destroy()` and `init()` from `Interceptor`. They don't make much sense until the interceptor lifecycle is specified (see next item). I've never needed them, yet it's a pain to implement empty methods every time I implement an interceptor. Users can use the constructor/finalizer or we can create additional lifecycle interfaces. @@ -68, +80 @@ * [mrdon] This I'd like to see. I've found myself using these objects so often in wierd little places, I'd be loath to remove them unless we could prove 100% that their information can be retrieved elsewhere. * [jcarreira] +1 to Patrick's point... we may need to introduce some more advanced *Aware interfaces, though, to give people access to the guts if they really want it. * [frankz] !ActionContext being !ThreadLocal was one of the first cool things I noticed about WW. I'd hate to see that change. The only thing I can think of that would make me agree to change that is that I think we may find developers using it in inappropriate ways, i.e., an Action calls a business delegate and the delegate uses !ActionContext. My bet is most people would agree it should be a best practice to not do that. Still, it's cool that you can! + * [craigmcc] JSF likes the thread local approach to a per-request context object (FacesContext in this
[action2] Confluence migration next step: Migrate content
Patrick and I have implemented the first steps of the migration plan: - The OpenSymphony WebWork wiki is read-only, save for the project developers for rare changes - I installed a Confluence instance on my personal server: http://confluence.twdata.org - Patrick exported the data and loaded it into the new instance Therefore, we now are at the stage where we need to rename the documentation. The end goal is that we migrate the content to an ASF Confluence instance, but until one is available, please work on the twdata one so we can at least continue moving forward. Any user account should be able to edit pages, but if you need admin access, let me know. Again, the server is at http://confluence.twdata.org and everyone please join in the effort to migrate its content. Feel free to add new information as well, as this data will be loaded into the ASF instance. Don http://confluence.twdata.org -- one more time :) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396361 - /struts/action/trunk/assembly/src/main/assembly/dist.xml
Author: wsmoak Date: Sun Apr 23 17:51:36 2006 New Revision: 396361 URL: http://svn.apache.org/viewcvs?rev=396361view=rev Log: Add more website docs to the assembly. Modified: struts/action/trunk/assembly/src/main/assembly/dist.xml Modified: struts/action/trunk/assembly/src/main/assembly/dist.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/assembly/src/main/assembly/dist.xml?rev=396361r1=396360r2=396361view=diff == --- struts/action/trunk/assembly/src/main/assembly/dist.xml (original) +++ struts/action/trunk/assembly/src/main/assembly/dist.xml Sun Apr 23 17:51:36 2006 @@ -71,12 +71,52 @@ outputDirectorydocs/struts-apps/outputDirectory /fileSet fileSet + directory../apps/blank/target/site/directory + outputDirectorydocs/struts-apps/struts-blank/outputDirectory + /fileSet + fileSet + directory../apps/cookbook/target/site/directory + outputDirectorydocs/struts-apps/struts-cookbook/outputDirectory + /fileSet + fileSet + directory../apps/examples/target/site/directory + outputDirectorydocs/struts-apps/struts-examples/outputDirectory + /fileSet + fileSet + directory../apps/faces-example1/target/site/directory + outputDirectorydocs/struts-apps/struts-faces-example1/outputDirectory + /fileSet + fileSet + directory../apps/mailreader/target/site/directory + outputDirectorydocs/struts-apps/struts-mailreader/outputDirectory + /fileSet + fileSet + directory../apps/scripting-mailreader/target/site/directory + outputDirectorydocs/struts-apps/struts-scripting-mailreader/outputDirectory + /fileSet + fileSet + directory../apps/strutsel-exercise-taglib/target/site/directory + outputDirectorydocs/struts-apps/strutsel-exercise-taglib/outputDirectory + /fileSet + fileSet directory../core/target/site/directory outputDirectorydocs/struts-core/outputDirectory /fileSet fileSet directory../el/target/site/directory outputDirectorydocs/struts-el/outputDirectory + /fileSet + fileSet + directory../extras/target/site/directory + outputDirectorydocs/struts-extras/outputDirectory + /fileSet + fileSet + directory../faces/target/site/directory + outputDirectorydocs/struts-faces/outputDirectory + /fileSet + fileSet + directory../scripting/target/site/directory + outputDirectorydocs/struts-scripting/outputDirectory /fileSet fileSet directory../taglib/target/site/directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396369 - /struts/action/trunk/assembly/src/main/assembly/dist.xml
Author: wsmoak Date: Sun Apr 23 18:25:00 2006 New Revision: 396369 URL: http://svn.apache.org/viewcvs?rev=396369view=rev Log: Added more source code to the assembly. Modified: struts/action/trunk/assembly/src/main/assembly/dist.xml Modified: struts/action/trunk/assembly/src/main/assembly/dist.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/assembly/src/main/assembly/dist.xml?rev=396369r1=396368r2=396369view=diff == --- struts/action/trunk/assembly/src/main/assembly/dist.xml (original) +++ struts/action/trunk/assembly/src/main/assembly/dist.xml Sun Apr 23 18:25:00 2006 @@ -28,6 +28,7 @@ /fileSet !-- Include the source code in the assembly -- +!-- TODO: Replace with modules when maven-assembly-plugin is released -- fileSet directory..//directory outputDirectorysrc//outputDirectory @@ -36,6 +37,90 @@ /includes /fileSet fileSet + directory../apps/directory + outputDirectorysrc/apps/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/blank/directory + outputDirectorysrc/apps/blank/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/cookbook/directory + outputDirectorysrc/apps/cookbook/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/examples/directory + outputDirectorysrc/apps/examples/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/faces-example1/directory + outputDirectorysrc/apps/faces-example1/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/faces-example2/directory + outputDirectorysrc/apps/faces-example2/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/mailreader/directory + outputDirectorysrc/apps/mailreader/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/scripting-mailreader/directory + outputDirectorysrc/apps/scripting-mailreader/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../apps/strutsel-exercise-taglib/directory + outputDirectorysrc/apps/strutsel-exercise-taglib/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../assembly/directory + outputDirectorysrc/assembly/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes +/fileSet +fileSet + directory../build/directory + outputDirectorysrc/build/outputDirectory +/fileSet +fileSet directory../core/directory outputDirectorysrc/core/outputDirectory includes @@ -46,6 +131,54 @@ fileSet directory../el/directory outputDirectorysrc/el/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes + /fileSet + fileSet + directory../extras/directory + outputDirectorysrc/extras/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes + /fileSet + fileSet + directory../faces/directory + outputDirectorysrc/faces/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes + /fileSet + fileSet + directory../integration/directory + outputDirectorysrc/integration/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes + /fileSet + fileSet + directory../integration/taglib-it/directory + outputDirectorysrc/integration/taglib-it/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes + /fileSet + fileSet + directory../mailreader-dao/directory + outputDirectorysrc/mailreader-dao/outputDirectory + includes +includepom.xml/include +includesrc//include + /includes + /fileSet + fileSet + directory../scripting/directory + outputDirectorysrc/scripting/outputDirectory includes includepom.xml/include includesrc//include - To unsubscribe, e-mail: [EMAIL
svn commit: r396389 - in /struts: action/trunk/apps/src/site/site.xml action/trunk/src/site/site.xml action/trunk/src/site/xdoc/javadoc.xml site/src/site/site.xml site/src/site/xdoc/javadoc.xml
Author: wsmoak
Date: Sun Apr 23 19:52:54 2006
New Revision: 396389
URL: http://svn.apache.org/viewcvs?rev=396389view=rev
Log:
Reworked the website menus and Javadoc links.
Added:
struts/action/trunk/src/site/xdoc/javadoc.xml (with props)
Modified:
struts/action/trunk/apps/src/site/site.xml
struts/action/trunk/src/site/site.xml (contents, props changed)
struts/site/src/site/site.xml
struts/site/src/site/xdoc/javadoc.xml
Modified: struts/action/trunk/apps/src/site/site.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/apps/src/site/site.xml?rev=396389r1=396388r2=396389view=diff
==
--- struts/action/trunk/apps/src/site/site.xml (original)
+++ struts/action/trunk/apps/src/site/site.xml Sun Apr 23 19:52:54 2006
@@ -28,12 +28,28 @@
/menu
menu name=Apps
-item
-name=Cookbook
-href=struts-cookbook//
-item
-name=Mailreader
-href=struts-mailreader//
+
+item name=Struts Blank
+href=struts-blank/index.html /
+
+item name=Struts Cookbook
+href=struts-cookbook/index.html /
+
+item name=Struts Examples
+href=struts-examples/index.html /
+
+item name=Struts Faces 1
+href=struts-faces-example1/index.html /
+
+item name=Struts Faces 2
+href=struts-faces-example2/index.html /
+
+item name=Struts Mailreader
+href=struts-mailreader/index.html /
+
+item name=Struts EL Exercise Taglib
+href=strutsel-exercise-taglib/index.html /
+
/menu
${modules}
Modified: struts/action/trunk/src/site/site.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/src/site/site.xml?rev=396389r1=396388r2=396389view=diff
==
--- struts/action/trunk/src/site/site.xml (original)
+++ struts/action/trunk/src/site/site.xml Sun Apr 23 19:52:54 2006
@@ -49,8 +49,8 @@
href=faqs/index.html
/
item
-name=JavaDocs
-href=apidocs/index.html
+name=Javadoc
+href=javadoc.html
/
item
name=Release Notes
@@ -64,6 +64,33 @@
name=Apache Struts Home
href=http://struts.apache.org/
/menu
+
+menu name=Components
+
+item name=Struts Action Core
+href=struts-core/index.html /
+
+item name=Struts Apps
+href=struts-apps/index.html /
+
+item name=Struts EL
+href=struts-el/index.html /
+
+item name=Struts Extras
+href=struts-extras/index.html /
+
+item name=Struts Faces
+href=struts-faces/index.html /
+
+item name=Struts Scripting
+href=struts-scripting/index.html /
+
+item name=Struts Taglib
+href=struts-taglib/index.html /
+
+/menu
+
+${modules}
${reports}
/body
/project
Propchange: struts/action/trunk/src/site/site.xml
--
svn:eol-style = native
Added: struts/action/trunk/src/site/xdoc/javadoc.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/src/site/xdoc/javadoc.xml?rev=396389view=auto
==
--- struts/action/trunk/src/site/xdoc/javadoc.xml (added)
+++ struts/action/trunk/src/site/xdoc/javadoc.xml Sun Apr 23 19:52:54 2006
@@ -0,0 +1,53 @@
+?xml version=1.0?
+!--
+Copyright 2006 The Apache Software Foundation
+Licensed under the Apache License, Version 2.0 (the License);
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an AS IS BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+--
+!--
+// 78
+--
+document
+
+ properties
+ titleStruts Action - Javadoc/title
+ /properties
+
+ body
+
+ section name=Struts Action Javadoc
+
+ ul
+li
+ a href=struts-core/apidocs/index.html target=_blank
+
svn commit: r396390 - /struts/action/trunk/assembly/src/main/assembly/dist.xml
Author: wsmoak Date: Sun Apr 23 19:53:43 2006 New Revision: 396390 URL: http://svn.apache.org/viewcvs?rev=396390view=rev Log: Include the action/src directory in the assembly. Modified: struts/action/trunk/assembly/src/main/assembly/dist.xml Modified: struts/action/trunk/assembly/src/main/assembly/dist.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/assembly/src/main/assembly/dist.xml?rev=396390r1=396389r2=396390view=diff == --- struts/action/trunk/assembly/src/main/assembly/dist.xml (original) +++ struts/action/trunk/assembly/src/main/assembly/dist.xml Sun Apr 23 19:53:43 2006 @@ -34,6 +34,7 @@ outputDirectorysrc//outputDirectory includes includepom.xml/include +includesrc//include /includes /fileSet fileSet - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396394 - in /struts/site: maven.xml pom.xml project.properties project.xml
Author: wsmoak Date: Sun Apr 23 20:02:47 2006 New Revision: 396394 URL: http://svn.apache.org/viewcvs?rev=396394view=rev Log: Add a distributionManagement section to the pom, and remove Maven 1 build files. Removed: struts/site/maven.xml struts/site/project.properties struts/site/project.xml Modified: struts/site/pom.xml Modified: struts/site/pom.xml URL: http://svn.apache.org/viewcvs/struts/site/pom.xml?rev=396394r1=396393r2=396394view=diff == --- struts/site/pom.xml (original) +++ struts/site/pom.xml Sun Apr 23 20:02:47 2006 @@ -49,4 +49,11 @@ urlhttp://svn.apache.org/repos/asf/struts/site/trunk/url /scm + distributionManagement +site + idapache-site/id + urlscp://people.apache.org/www/struts.apache.org/url +/site + /distributionManagement + /project - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396398 - in /incubator/webwork2/action/src/main/resources: org/apache/struts/action2/static/optiontransferselect.js org/apache/struts/action2/static/optiontransferselect/ template/simple/
Author: mrdon
Date: Sun Apr 23 20:31:47 2006
New Revision: 396398
URL: http://svn.apache.org/viewcvs?rev=396398view=rev
Log:
Removed the Kruse script for option transfer select, replaced with clean
impl
Added:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/static/optiontransferselect.js
Removed:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/static/optiontransferselect/
Modified:
incubator/webwork2/action/src/main/resources/template/simple/optiontransferselect.ftl
Added:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/static/optiontransferselect.js
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/resources/org/apache/struts/action2/static/optiontransferselect.js?rev=396398view=auto
==
---
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/static/optiontransferselect.js
(added)
+++
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/static/optiontransferselect.js
Sun Apr 23 20:31:47 2006
@@ -0,0 +1,112 @@
+function moveSelectedOptions(objSourceElement, objTargetElement, toSort,
notMove1, notMove2) {
+var test1 = compile(notMove1);
+var test2 = compile(notMove2);
+moveOptions(objSourceElement, objTargetElement, toSort,
+function(opt) {
+return (opt.selected !test1(opt.value) !test2(opt.value));
+}
+);
+}
+
+function moveAllOptions(objSourceElement, objTargetElement, toSort, notMove1,
notMove2) {
+var test1 = compile(notMove1);
+var test2 = compile(notMove2);
+moveOptions(objSourceElement, objTargetElement, toSort,
+function(opt) {
+return (!test1(opt.value) !test2(opt.value));
+}
+);
+}
+
+function compile(ptn) {
+if (ptn != undefined) {
+if (ptn == '' || !window.RegExp) {
+return function(val) { return val == ptn; }
+} else {
+var reg = new RegExp(ptn);
+return function (val) { return reg.test(val); }
+}
+}
+return function(val) { return false; }
+}
+
+
+function moveOptions(objSourceElement, objTargetElement, toSort, chooseFunc) {
+var aryTempSourceOptions = new Array();
+var aryTempTargetOptions = new Array();
+var x = 0;
+
+//looping through source element to find selected options
+for (var i = 0; i objSourceElement.length; i++) {
+if (chooseFunc(objSourceElement.options[i])) {
+//need to move this option to target element
+var intTargetLen = objTargetElement.length++;
+objTargetElement.options[intTargetLen].text =
objSourceElement.options[i].text;
+objTargetElement.options[intTargetLen].value =
objSourceElement.options[i].value;
+}
+else {
+//storing options that stay to recreate select element
+var objTempValues = new Object();
+objTempValues.text = objSourceElement.options[i].text;
+objTempValues.value = objSourceElement.options[i].value;
+aryTempSourceOptions[x] = objTempValues;
+x++;
+}
+}
+
+//sorting and refilling target list
+for (var i = 0; i objTargetElement.length; i++) {
+var objTempValues = new Object();
+objTempValues.text = objTargetElement.options[i].text;
+objTempValues.value = objTargetElement.options[i].value;
+aryTempTargetOptions[i] = objTempValues;
+}
+
+if (toSort) {
+aryTempTargetOptions.sort(sortByText);
+}
+
+for (var i = 0; i objTargetElement.length; i++) {
+objTargetElement.options[i].text = aryTempTargetOptions[i].text;
+objTargetElement.options[i].value = aryTempTargetOptions[i].value;
+objTargetElement.options[i].selected = false;
+}
+
+//resetting length of source
+objSourceElement.length = aryTempSourceOptions.length;
+//looping through temp array to recreate source select element
+for (var i = 0; i aryTempSourceOptions.length; i++) {
+objSourceElement.options[i].text = aryTempSourceOptions[i].text;
+objSourceElement.options[i].value = aryTempSourceOptions[i].value;
+objSourceElement.options[i].selected = false;
+}
+}
+
+function sortByText(a, b) {
+if (a.text b.text) {return -1}
+if (a.text b.text) {return 1}
+return 0;
+}
+
+function selectAllOptionsExceptSome(objTargetElement, type, ptn) {
+var test = compile(ptn);
+for (var i = 0; i objTargetElement.length; i++) {
+var opt = objTargetElement.options[i];
+if ((type == 'key' !test(opt.value)) ||
+ (type == 'text' !test(opt.text))) {
+opt.selected = true;
+} else {
+opt.selected = false;
+}
+}
+return false;
+}
+
+function selectAllOptions(objTargetElement) {
+for (var i = 0; i
svn commit: r396407 - /struts/site/src/site/resources/.htaccess
Author: wsmoak Date: Sun Apr 23 20:55:51 2006 New Revision: 396407 URL: http://svn.apache.org/viewcvs?rev=396407view=rev Log: Add the current .htaccess file for struts.apache.org Added: struts/site/src/site/resources/.htaccess (with props) Added: struts/site/src/site/resources/.htaccess URL: http://svn.apache.org/viewcvs/struts/site/src/site/resources/.htaccess?rev=396407view=auto == --- struts/site/src/site/resources/.htaccess (added) +++ struts/site/src/site/resources/.htaccess Sun Apr 23 20:55:51 2006 @@ -0,0 +1,12 @@ +Redirect permanent /userGuide http://struts.apache.org/struts-action/userGuide +Redirect permanent /faqs http://struts.apache.org/struts-action/faqs +Redirect permanent /struts-corehttp://struts.apache.org/struts-action +Redirect permanent /shale http://struts.apache.org/struts-shale +Redirect permanent /flow http://struts.apache.org/struts-flow +Redirect permanent /faces http://struts.apache.org/struts-faces +Redirect permanent /bsfhttp://struts.apache.org/struts-scripting +Redirect permanent /struts-bsf http://struts.apache.org/struts-scripting +Redirect permanent /struts-plugins http://struts.apache.org/struts-extras +Redirect permanent /learning.html http://struts.apache.org/struts-action/learning.html +Redirect permanent /using.html http://struts.apache.org/struts-action/userGuide/index.html + Propchange: struts/site/src/site/resources/.htaccess -- svn:eol-style = native - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396410 - /struts/action/trunk/apps/pom.xml
Author: mrdon Date: Sun Apr 23 20:57:12 2006 New Revision: 396410 URL: http://svn.apache.org/viewcvs?rev=396410view=rev Log: Adding the distribution management section to the pom Modified: struts/action/trunk/apps/pom.xml Modified: struts/action/trunk/apps/pom.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/apps/pom.xml?rev=396410r1=396409r2=396410view=diff == --- struts/action/trunk/apps/pom.xml (original) +++ struts/action/trunk/apps/pom.xml Sun Apr 23 20:57:12 2006 @@ -34,6 +34,14 @@ packagingpom/packaging nameStruts Action - Apps/name + distributionManagement + site + idapache-site/id + urlscp://people.apache.org/www/struts.apache.org/struts-action/struts-apps/url + /site + /distributionManagement + + modules modulecookbook/module modulefaces-example1/module - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396412 - in /incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven: modelDriven.jsp modelDrivenResult.jsp
Author: mrdon Date: Sun Apr 23 21:07:53 2006 New Revision: 396412 URL: http://svn.apache.org/viewcvs?rev=396412view=rev Log: Fixed dojo errors on showcase cause not using head tag that imports dojo Modified: incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDriven.jsp incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDrivenResult.jsp Modified: incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDriven.jsp URL: http://svn.apache.org/viewcvs/incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDriven.jsp?rev=396412r1=396411r2=396412view=diff == --- incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDriven.jsp (original) +++ incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDriven.jsp Sun Apr 23 21:07:53 2006 @@ -3,6 +3,7 @@ html head titleShowcase - Model Driven Example/title +saf:head/ /head body Modified: incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDrivenResult.jsp URL: http://svn.apache.org/viewcvs/incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDrivenResult.jsp?rev=396412r1=396411r2=396412view=diff == --- incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDrivenResult.jsp (original) +++ incubator/webwork2/webapps/showcase/src/main/webapp/modelDriven/modelDrivenResult.jsp Sun Apr 23 21:07:53 2006 @@ -3,6 +3,7 @@ html head titleShowcase - Model Driven Example/title +saf:head/ /head body @@ -20,4 +21,4 @@ name=description /br/ /body -/html \ No newline at end of file +/html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396415 - /struts/site/src/site/resources/.htaccess
Author: mrdon Date: Sun Apr 23 21:15:33 2006 New Revision: 396415 URL: http://svn.apache.org/viewcvs?rev=396415view=rev Log: Added more redirects Modified: struts/site/src/site/resources/.htaccess Modified: struts/site/src/site/resources/.htaccess URL: http://svn.apache.org/viewcvs/struts/site/src/site/resources/.htaccess?rev=396415r1=396414r2=396415view=diff == --- struts/site/src/site/resources/.htaccess (original) +++ struts/site/src/site/resources/.htaccess Sun Apr 23 21:15:33 2006 @@ -1,12 +1,16 @@ -Redirect permanent /userGuide http://struts.apache.org/struts-action/userGuide -Redirect permanent /faqs http://struts.apache.org/struts-action/faqs -Redirect permanent /struts-corehttp://struts.apache.org/struts-action -Redirect permanent /shale http://struts.apache.org/struts-shale -Redirect permanent /flow http://struts.apache.org/struts-flow -Redirect permanent /faces http://struts.apache.org/struts-faces -Redirect permanent /bsfhttp://struts.apache.org/struts-scripting -Redirect permanent /struts-bsf http://struts.apache.org/struts-scripting -Redirect permanent /struts-plugins http://struts.apache.org/struts-extras -Redirect permanent /learning.html http://struts.apache.org/struts-action/learning.html -Redirect permanent /using.html http://struts.apache.org/struts-action/userGuide/index.html +Redirect permanent /userGuide http://struts.apache.org/struts-action/userGuide +Redirect permanent /faqs http://struts.apache.org/struts-action/faqs +Redirect permanent /struts-core http://struts.apache.org/struts-action +Redirect permanent /faces http://struts.apache.org/struts-action/struts-faces +Redirect permanent /struts-faces http://struts.apache.org/struts-action/struts-faces +Redirect permanent /bsf http://struts.apache.org/struts-action/struts-scripting +Redirect permanent /struts-bsf http://struts.apache.org/struts-action/struts-scripting +Redirect permanent /struts-scripting http://struts.apache.org/struts-action/struts-scripting +Redirect permanent /struts-plugins http://struts.apache.org/struts-action/struts-extras +Redirect permanent /struts-extras http://struts.apache.org/struts-action/struts-extras +Redirect permanent /struts-taglib http://struts.apache.org/struts-action/struts-taglib +Redirect permanent /struts-el http://struts.apache.org/struts-action/struts-el +Redirect permanent /learning.html http://struts.apache.org/struts-action/learning.html +Redirect permanent /using.html http://struts.apache.org/struts-action/userGuide/index.html +Redirect permanent /shale http://struts.apache.org/struts-shale - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396420 - in /struts/action/trunk/taglib/src/site/xdoc: dev_bean.xml dev_html.xml dev_logic.xml dev_nested.xml
Author: wsmoak Date: Sun Apr 23 21:36:19 2006 New Revision: 396420 URL: http://svn.apache.org/viewcvs?rev=396420view=rev Log: Fixed broken links to the tag reference page. Modified: struts/action/trunk/taglib/src/site/xdoc/dev_bean.xml struts/action/trunk/taglib/src/site/xdoc/dev_html.xml struts/action/trunk/taglib/src/site/xdoc/dev_logic.xml struts/action/trunk/taglib/src/site/xdoc/dev_nested.xml Modified: struts/action/trunk/taglib/src/site/xdoc/dev_bean.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/taglib/src/site/xdoc/dev_bean.xml?rev=396420r1=396419r2=396420view=diff == --- struts/action/trunk/taglib/src/site/xdoc/dev_bean.xml (original) +++ struts/action/trunk/taglib/src/site/xdoc/dev_bean.xml Sun Apr 23 21:36:19 2006 @@ -77,7 +77,7 @@ Taglibdoc/a /li li -a href=tagreference-struts-bean.htmlBean Tag +a href=tagreference.html#struts-bean.tldBean Tag Reference/a /li /ul Modified: struts/action/trunk/taglib/src/site/xdoc/dev_html.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/taglib/src/site/xdoc/dev_html.xml?rev=396420r1=396419r2=396420view=diff == --- struts/action/trunk/taglib/src/site/xdoc/dev_html.xml (original) +++ struts/action/trunk/taglib/src/site/xdoc/dev_html.xml Sun Apr 23 21:36:19 2006 @@ -55,7 +55,7 @@ Taglibdoc/a /li li -a href=tagreference-struts-html.htmlHTML Tag +a href=tagreference.html#struts-html.tldHTML Tag Reference/a /li /ul Modified: struts/action/trunk/taglib/src/site/xdoc/dev_logic.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/taglib/src/site/xdoc/dev_logic.xml?rev=396420r1=396419r2=396420view=diff == --- struts/action/trunk/taglib/src/site/xdoc/dev_logic.xml (original) +++ struts/action/trunk/taglib/src/site/xdoc/dev_logic.xml Sun Apr 23 21:36:19 2006 @@ -59,7 +59,7 @@ Taglibdoc/a /li li -a href=tagreference-struts-logic.htmlLogic Tag +a href=tagreference.html#struts-logic.tldLogic Tag Reference/a /li /ul Modified: struts/action/trunk/taglib/src/site/xdoc/dev_nested.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/taglib/src/site/xdoc/dev_nested.xml?rev=396420r1=396419r2=396420view=diff == --- struts/action/trunk/taglib/src/site/xdoc/dev_nested.xml (original) +++ struts/action/trunk/taglib/src/site/xdoc/dev_nested.xml Sun Apr 23 21:36:19 2006 @@ -49,7 +49,7 @@ Taglibdoc/a /li li -a href=tagreference-struts-nested.htmlNested Tag +a href=tagreference.html#struts-nested.tldNested Tag Reference/a /li /ul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
I'm in the same camp on this one. I think we (SAF1) should be providing a plugin that provides Tiles integration. -- James Mitchell On Apr 23, 2006, at 6:35 PM, Craig McClanahan wrote: On 4/23/06, Martin Cooper [EMAIL PROTECTED] wrote: On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: I would think it would be Tiles' responsibility to support deployment with Struts. In that view, Tiles would be its own project, yet part of it would depend on struts-action.jar to provide the Struts hooks. In the same way, they would provide Struts Action 2 hooks, if necessary. This is a tough one - for me, at least. Should an independent Tiles have glue code for Struts, or should it be Struts' responsibility to provide the glue? If we look at Velocity, the glue is over there, but we've also talked about it coming here. If we look at Validator, the glue is here. If we look at Chain, the servlet and portlet glue is over there. I've always thought it would be as Martin describes for Validator -- standalone Tiles would really be standalone, and each framework that wanted to utilize it would provide it's own glue to some particular version (s) of Standalone Tiles. That is what Shale already does with the standalone Tiles stuff -- for example, Shale integrates tiles into the standard JSF navigation mechanism. That's not something that it seems reasonable to impose on a standalone project. My preference, at least at this time, would be for the Struts / Tiles glue to stay here. That will help Standalone Tiles stand on its own feet, and especially help with the notion that it's now independent of Struts. Any perception - real or otherwise - that Tiles is tied to Struts will be detrimental to Tiles as an independent library. +1 -- Martin Cooper Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, James Mitchell [EMAIL PROTECTED] wrote: I'm in the same camp on this one. I think we (SAF1) should be providing a plugin that provides Tiles integration. In that case, should Struts Tiles be put back under Struts Action? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396423 - /struts/site/src/site/resources/.htaccess
Author: wsmoak Date: Sun Apr 23 21:55:29 2006 New Revision: 396423 URL: http://svn.apache.org/viewcvs?rev=396423view=rev Log: Added more redirects. Modified: struts/site/src/site/resources/.htaccess Modified: struts/site/src/site/resources/.htaccess URL: http://svn.apache.org/viewcvs/struts/site/src/site/resources/.htaccess?rev=396423r1=396422r2=396423view=diff == --- struts/site/src/site/resources/.htaccess (original) +++ struts/site/src/site/resources/.htaccess Sun Apr 23 21:55:29 2006 @@ -13,4 +13,7 @@ Redirect permanent /learning.html http://struts.apache.org/struts-action/learning.html Redirect permanent /using.html http://struts.apache.org/struts-action/userGuide/index.html Redirect permanent /shale http://struts.apache.org/struts-shale +Redirect permanent /flow http://struts.apache.org/struts-sandbox/struts-flow +Redirect permanent /struts-flow http://struts.apache.org/struts-sandbox/struts-flow +Redirect permanent /struts-apps http://struts.apache.org/struts-action/struts-apps - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
I'm fine with this solution, as long as my original concern of a circular dependency is resolved. Don Wendy Smoak wrote: On 4/23/06, James Mitchell [EMAIL PROTECTED] wrote: I'm in the same camp on this one. I think we (SAF1) should be providing a plugin that provides Tiles integration. In that case, should Struts Tiles be put back under Struts Action? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396426 - in /incubator/webwork2: ./ action/ action/src/main/java/org/apache/struts/action2/quickstart/ webapps/showcase/
Author: plightbo
Date: Sun Apr 23 22:01:09 2006
New Revision: 396426
URL: http://svn.apache.org/viewcvs?rev=396426view=rev
Log:
quick start runs from idea once again
Modified:
incubator/webwork2/action/pom.xml
incubator/webwork2/action/src/main/java/org/apache/struts/action2/quickstart/Configuration.java
incubator/webwork2/action/src/main/java/org/apache/struts/action2/quickstart/MultiWebApplicationContext.java
incubator/webwork2/pom.xml
incubator/webwork2/webapps/showcase/quickstart.xml
Modified: incubator/webwork2/action/pom.xml
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/pom.xml?rev=396426r1=396425r2=396426view=diff
==
--- incubator/webwork2/action/pom.xml (original)
+++ incubator/webwork2/action/pom.xml Sun Apr 23 22:01:09 2006
@@ -116,6 +116,76 @@
optionaltrue/optional
/dependency
+dependency
+groupIdant/groupId
+artifactIdant/artifactId
+version1.6.5/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdtomcat/groupId
+artifactIdjasper-compiler/artifactId
+version5.5.12/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdtomcat/groupId
+artifactIdjasper-runtime/artifactId
+version5.5.12/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdtomcat/groupId
+artifactIdjasper-compiler-jdt/artifactId
+version5.5.12/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdcommons-el/groupId
+artifactIdcommons-el/artifactId
+version1.0/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdcommons-io/groupId
+artifactIdcommons-io/artifactId
+version1.0/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdcommons-lang/groupId
+artifactIdcommons-lang/artifactId
+version2.1/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdjspapi/groupId
+artifactIdjsp-api/artifactId
+version2.0/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdcommons-collections/groupId
+artifactIdcommons-collections/artifactId
+version2.1.1/version
+optionaltrue/optional
+/dependency
+
+dependency
+groupIdxstream/groupId
+artifactIdxstream/artifactId
+version1.1.2/version
+optionaltrue/optional
+/dependency
+
!-- Jasper --
dependency
groupIdjasperreports/groupId
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/quickstart/Configuration.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/java/org/apache/struts/action2/quickstart/Configuration.java?rev=396426r1=396425r2=396426view=diff
==
---
incubator/webwork2/action/src/main/java/org/apache/struts/action2/quickstart/Configuration.java
(original)
+++
incubator/webwork2/action/src/main/java/org/apache/struts/action2/quickstart/Configuration.java
Sun Apr 23 22:01:09 2006
@@ -35,9 +35,9 @@
* Configuration for the QuickStart program.
*/
public class Configuration implements Serializable {
-
+
private static final long serialVersionUID = 9159115401614443449L;
-
+
String ideaConfig;
String extendsConfig;
String resolver;
@@ -132,32 +132,36 @@
public void resolveDirs(String wd) {
if (ideaConfig != null) {
-String full = resolveDir(this.ideaConfig, wd);
-
-try {
-DocumentBuilder db =
DocumentBuilderFactory.newInstance().newDocumentBuilder();
-Document doc = db.parse(full);
-NodeList components = doc.getElementsByTagName(root);
-List jars = new ArrayList();
-for (int i = 0; i components.getLength(); i++) {
-Element e = (Element) components.item(i);
-String value = e.getAttribute(url);
-if (value != null value.startsWith(jar://)
value.endsWith(.jar!/)) {
-value = value.substring(6, value.length() - 2);
-if (value.startsWith($MODULE_DIR$)) {
-value = value.substring(13);
+String[] parts = ideaConfig.split(,);
+for (int i = 0; i parts.length; i++) {
+String full = resolveDir(parts[i], wd);
+
+try {
+
Re: Standalone Tiles as TLP
Doesn't that conflict with the idea of making Tiles a stand-alone TLP? Frank Don Brown wrote: I'm fine with this solution, as long as my original concern of a circular dependency is resolved. Don Wendy Smoak wrote: On 4/23/06, James Mitchell [EMAIL PROTECTED] wrote: I'm in the same camp on this one. I think we (SAF1) should be providing a plugin that provides Tiles integration. In that case, should Struts Tiles be put back under Struts Action? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com AIM: fzammetti Yahoo: fzammetti MSN: [EMAIL PROTECTED] Java Web Parts - http://javawebparts.sourceforge.net Supplying the wheel, so you don't have to reinvent it! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Frank W. Zammetti [EMAIL PROTECTED] wrote: Doesn't that conflict with the idea of making Tiles a stand-alone TLP? No. This is Struts Tiles, not Standalone Tiles. Standalone Tiles is in the sandbox, and will have a life of its own. Struts Tiles is what most of us are using. Eventually (and I'm not too clear on this part) it will become a plugin or wrapper or something to let Struts Action work with Standalone Tiles. But it sounds to me like there will always be a 'struts-tiles.jar', so we might as well keep it as part of Struts Action. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
The end goal is a standalone Tiles in the Jakarta Web Commons project (to be created), then Struts Action 1 would have a struts-tiles artifact which makes it possible for Struts users to use this standalone Tiles. Think of it how Struts Scripting works or Struts validator. In the meantime, we'd put the Struts Tiles project, which isn't standalone, back into Action until we can replace the core of it with a new dependency on the new Standalone Tiles. Did I get that right? :) Don Frank W. Zammetti wrote: Doesn't that conflict with the idea of making Tiles a stand-alone TLP? Frank Don Brown wrote: I'm fine with this solution, as long as my original concern of a circular dependency is resolved. Don Wendy Smoak wrote: On 4/23/06, James Mitchell [EMAIL PROTECTED] wrote: I'm in the same camp on this one. I think we (SAF1) should be providing a plugin that provides Tiles integration. In that case, should Struts Tiles be put back under Struts Action? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396428 - in /struts/site/src: cgi/ cgi/download.cgi site/resources/download.cgi
Author: mrdon Date: Sun Apr 23 22:11:46 2006 New Revision: 396428 URL: http://svn.apache.org/viewcvs?rev=396428view=rev Log: Moved the download.cgi script out of Maven's way so it won't keep getting overwritten and made not executable Added: struts/site/src/cgi/ struts/site/src/cgi/download.cgi - copied unchanged from r396426, struts/site/src/site/resources/download.cgi Removed: struts/site/src/site/resources/download.cgi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Martin Cooper [EMAIL PROTECTED] wrote: 1) Get Standalone Tiles really standalone, so that there are no dependencies on other Struts code. Maybe that's happened already - I've kinda lost track. This seems to be done -- sandbox/tiles/pom.xml has no struts dependencies listed. Speaking of build files, there are three sets. Who is using them, and is there any interest in standardizing on one? (Maven 2, of course!) -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Don Brown [EMAIL PROTECTED] wrote: The end goal is a standalone Tiles in the Jakarta Web Commons project (to be created), then Struts Action 1 would have a struts-tiles artifact which makes it possible for Struts users to use this standalone Tiles. Think of it how Struts Scripting works or Struts validator. In the meantime, we'd put the Struts Tiles project, which isn't standalone, back into Action until we can replace the core of it with a new dependency on the new Standalone Tiles. Did I get that right? :) Yep. Except I think the target name is 'Jakarta Web Components'. -- Martin Cooper Don Frank W. Zammetti wrote: Doesn't that conflict with the idea of making Tiles a stand-alone TLP? Frank Don Brown wrote: I'm fine with this solution, as long as my original concern of a circular dependency is resolved. Don Wendy Smoak wrote: On 4/23/06, James Mitchell [EMAIL PROTECTED] wrote: I'm in the same camp on this one. I think we (SAF1) should be providing a plugin that provides Tiles integration. In that case, should Struts Tiles be put back under Struts Action? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
Ah, gotcha... I guess I wasn't clear that there was two different entities called Tiles. Thanks for clearing it up (both you and Don, I saw your post too). Frank Wendy Smoak wrote: On 4/23/06, Frank W. Zammetti [EMAIL PROTECTED] wrote: Doesn't that conflict with the idea of making Tiles a stand-alone TLP? No. This is Struts Tiles, not Standalone Tiles. Standalone Tiles is in the sandbox, and will have a life of its own. Struts Tiles is what most of us are using. Eventually (and I'm not too clear on this part) it will become a plugin or wrapper or something to let Struts Action work with Standalone Tiles. But it sounds to me like there will always be a 'struts-tiles.jar', so we might as well keep it as part of Struts Action. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com AIM: fzammetti Yahoo: fzammetti MSN: [EMAIL PROTECTED] Java Web Parts - http://javawebparts.sourceforge.net Supplying the wheel, so you don't have to reinvent it! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Standalone Tiles as TLP
On 4/23/06, Wendy Smoak [EMAIL PROTECTED] wrote: On 4/23/06, Martin Cooper [EMAIL PROTECTED] wrote: 1) Get Standalone Tiles really standalone, so that there are no dependencies on other Struts code. Maybe that's happened already - I've kinda lost track. This seems to be done -- sandbox/tiles/pom.xml has no struts dependencies listed. Speaking of build files, there are three sets. Who is using them, and is there any interest in standardizing on one? (Maven 2, of course!) +1 for Maven 2. :-) -- Martin Cooper -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396431 - in /struts: action/tags/STRUTS_TILES_1_3_0/ tiles/tags/STRUTS_TILES_1_3_0/
Author: wsmoak Date: Sun Apr 23 22:25:33 2006 New Revision: 396431 URL: http://svn.apache.org/viewcvs?rev=396431view=rev Log: Moved the Struts Tiles 1.3.0 tag to struts/action/tags. Added: struts/action/tags/STRUTS_TILES_1_3_0/ - copied from r396430, struts/tiles/tags/STRUTS_TILES_1_3_0/ Removed: struts/tiles/tags/STRUTS_TILES_1_3_0/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396432 - in /struts: action/trunk/tiles/ tiles/trunk/
Author: wsmoak Date: Sun Apr 23 22:28:07 2006 New Revision: 396432 URL: http://svn.apache.org/viewcvs?rev=396432view=rev Log: Moved Struts Tiles into Struts Action Added: struts/action/trunk/tiles/ - copied from r396431, struts/tiles/trunk/ Removed: struts/tiles/trunk/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396433 - /struts/site/src/site/site.xml
Author: mrdon Date: Sun Apr 23 22:28:38 2006 New Revision: 396433 URL: http://svn.apache.org/viewcvs?rev=396433view=rev Log: Removing the Tiles link as a subproject Modified: struts/site/src/site/site.xml Modified: struts/site/src/site/site.xml URL: http://svn.apache.org/viewcvs/struts/site/src/site/site.xml?rev=396433r1=396432r2=396433view=diff == --- struts/site/src/site/site.xml (original) +++ struts/site/src/site/site.xml Sun Apr 23 22:28:38 2006 @@ -77,12 +77,6 @@ item name=Shale Framework href=http://struts.apache.org/struts-shale/index.html/ /menu -menu name=Extensions -item name=Tiles href=http://struts.apache.org/struts-tiles/index.html/ -item name=Other Extensions - href=http://wiki.apache.org/struts/StrutsExtensions/ -/menu - menu name=Subprojects item name=Sandbox href=http://struts.apache.org/struts-sandbox/index.html/ /menu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396434 - /struts/site/src/site/resources/.htaccess
Author: mrdon Date: Sun Apr 23 22:29:19 2006 New Revision: 396434 URL: http://svn.apache.org/viewcvs?rev=396434view=rev Log: Adding tiles to the redirects Modified: struts/site/src/site/resources/.htaccess Modified: struts/site/src/site/resources/.htaccess URL: http://svn.apache.org/viewcvs/struts/site/src/site/resources/.htaccess?rev=396434r1=396433r2=396434view=diff == --- struts/site/src/site/resources/.htaccess (original) +++ struts/site/src/site/resources/.htaccess Sun Apr 23 22:29:19 2006 @@ -10,6 +10,7 @@ Redirect permanent /struts-extras http://struts.apache.org/struts-action/struts-extras Redirect permanent /struts-taglib http://struts.apache.org/struts-action/struts-taglib Redirect permanent /struts-el http://struts.apache.org/struts-action/struts-el +Redirect permanent /struts-tiles http://struts.apache.org/struts-action/struts-tiles Redirect permanent /learning.html http://struts.apache.org/struts-action/learning.html Redirect permanent /using.html http://struts.apache.org/struts-action/userGuide/index.html Redirect permanent /shale http://struts.apache.org/struts-shale - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396435 - /struts/tiles/
Author: wsmoak Date: Sun Apr 23 22:30:20 2006 New Revision: 396435 URL: http://svn.apache.org/viewcvs?rev=396435view=rev Log: Removed top-level Struts Tiles directory, trunk was moved to struts/action/trunk/tiles in r396432. Removed: struts/tiles/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396437 - /struts/current/
Author: wsmoak Date: Sun Apr 23 22:33:08 2006 New Revision: 396437 URL: http://svn.apache.org/viewcvs?rev=396437view=rev Log: Removed svn:externals definition for Struts Tiles, which was moved to struts/action/trunk Modified: struts/current/ (props changed) Propchange: struts/current/ -- --- svn:externals (original) +++ svn:externals Sun Apr 23 22:33:08 2006 @@ -2,5 +2,4 @@ sandbox https://svn.apache.org/repos/asf/struts/sandbox/trunk shale https://svn.apache.org/repos/asf/struts/shale/trunk site https://svn.apache.org/repos/asf/struts/site -tiles https://svn.apache.org/repos/asf/struts/tiles/trunk pom https://svn.apache.org/repos/asf/struts/pom - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396441 - /struts/action/trunk/tiles/pom.xml
Author: wsmoak
Date: Sun Apr 23 22:43:55 2006
New Revision: 396441
URL: http://svn.apache.org/viewcvs?rev=396441view=rev
Log:
Updated pom after moving Struts Tiles back into Struts Action.
Modified:
struts/action/trunk/tiles/pom.xml
Modified: struts/action/trunk/tiles/pom.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/tiles/pom.xml?rev=396441r1=396440r2=396441view=diff
==
--- struts/action/trunk/tiles/pom.xml (original)
+++ struts/action/trunk/tiles/pom.xml Sun Apr 23 22:43:55 2006
@@ -19,28 +19,21 @@
*/
--
-!--
- Experimental Maven 2 Build for Apache Struts
-
-
-To build and install this module into your local repo:
-
- $ mvn install
-
-For more information, see: http://wiki.apache.org/struts/StrutsMaven2Plan
-
---
project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
modelVersion4.0.0/modelVersion
- groupIdorg.apache.struts.tiles/groupId
+
+ parent
+ groupIdorg.apache.struts.action/groupId
+ artifactIdstruts-action-parent/artifactId
+ version1.3.2-SNAPSHOT/version
+/parent
+
artifactIdstruts-tiles/artifactId
packagingjar/packaging
- version1.3.1-SNAPSHOT/version
nameStruts Tiles/name
- urlhttp://struts.apache.org/url
distributionManagement
snapshotRepository
@@ -104,13 +97,12 @@
dependency
groupIdorg.apache.struts.action/groupId
- artifactIdstruts-action/artifactId
- version1.3.2-SNAPSHOT/version
+ artifactIdstruts-core/artifactId
+ version${version}/version
/dependency
/dependencies
- !--
reporting
plugins
plugin
@@ -122,6 +114,5 @@
/plugin
/plugins
/reporting
- --
/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396442 - in /struts/action/trunk/tiles: src/site/ src/site/resources/ src/site/xdoc/ src/site/xdoc/navigation.xml xdocs/
Author: mrdon Date: Sun Apr 23 22:47:13 2006 New Revision: 396442 URL: http://svn.apache.org/viewcvs?rev=396442view=rev Log: Initial move of xdocs to maven 2 Added: struts/action/trunk/tiles/src/site/ struts/action/trunk/tiles/src/site/resources/ struts/action/trunk/tiles/src/site/xdoc/ - copied from r396440, struts/action/trunk/tiles/xdocs/ Removed: struts/action/trunk/tiles/src/site/xdoc/navigation.xml struts/action/trunk/tiles/xdocs/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396443 - /struts/action/trunk/el/pom.xml
Author: wsmoak
Date: Sun Apr 23 22:55:20 2006
New Revision: 396443
URL: http://svn.apache.org/viewcvs?rev=396443view=rev
Log:
Struts Tiles is now part of Struts Action.
Modified:
struts/action/trunk/el/pom.xml
Modified: struts/action/trunk/el/pom.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/el/pom.xml?rev=396443r1=396442r2=396443view=diff
==
--- struts/action/trunk/el/pom.xml (original)
+++ struts/action/trunk/el/pom.xml Sun Apr 23 22:55:20 2006
@@ -111,9 +111,9 @@
/dependency
dependency
- groupIdorg.apache.struts.tiles/groupId
+ groupIdorg.apache.struts.action/groupId
artifactIdstruts-tiles/artifactId
- version1.3.0/version
+ version${pom.version}/version
optionaltrue/optional
/dependency
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r396444 - in /struts/action/trunk/tiles: pom.xml src/site/fml/ src/site/fml/faq.fml src/site/resources/images/ src/site/xdoc/faq.fml src/site/xdoc/images/
Author: mrdon
Date: Sun Apr 23 22:57:59 2006
New Revision: 396444
URL: http://svn.apache.org/viewcvs?rev=396444view=rev
Log:
Fixing some POM stuff, finishing site restructuring
Added:
struts/action/trunk/tiles/src/site/fml/
struts/action/trunk/tiles/src/site/fml/faq.fml
- copied unchanged from r396442,
struts/action/trunk/tiles/src/site/xdoc/faq.fml
struts/action/trunk/tiles/src/site/resources/images/
- copied from r396442, struts/action/trunk/tiles/src/site/xdoc/images/
Removed:
struts/action/trunk/tiles/src/site/xdoc/faq.fml
struts/action/trunk/tiles/src/site/xdoc/images/
Modified:
struts/action/trunk/tiles/pom.xml
Modified: struts/action/trunk/tiles/pom.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/tiles/pom.xml?rev=396444r1=396443r2=396444view=diff
==
--- struts/action/trunk/tiles/pom.xml (original)
+++ struts/action/trunk/tiles/pom.xml Sun Apr 23 22:57:59 2006
@@ -36,11 +36,10 @@
nameStruts Tiles/name
distributionManagement
- snapshotRepository
- idapache-snapshot/id
- nameApache Snapshot Repository/name
-
urlscp://people.apache.org/www/cvs.apache.org/maven-snapshot-repository/url
- /snapshotRepository
+ site
+ idapache-site/id
+
urlscp://people.apache.org/www/struts.apache.org/struts-action/struts-tiles/url
+ /site
/distributionManagement
build
@@ -60,7 +59,7 @@
targetPathMETA-INF/tlds/targetPath
/resource
resource
-directorybuild/directory
+directory../build/directory
includes
includeLICENSE.txt/include
includeNOTICE.txt/include
@@ -98,7 +97,7 @@
dependency
groupIdorg.apache.struts.action/groupId
artifactIdstruts-core/artifactId
- version${version}/version
+ version${pom.version}/version
/dependency
/dependencies
@@ -114,5 +113,35 @@
/plugin
/plugins
/reporting
+
+ profiles
+ profile
+idpre-assembly/id
+build
+plugins
+ plugin
+groupIdorg.apache.maven.plugins/groupId
+artifactIdmaven-javadoc-plugin/artifactId
+executions
+ execution
+idattach-javadoc/id
+goalsgoaljar/goal/goals
+ /execution
+/executions
+ /plugin
+ plugin
+groupIdorg.apache.maven.plugins/groupId
+artifactIdmaven-source-plugin/artifactId
+executions
+ execution
+idattach-source/id
+goalsgoaljar/goal/goals
+ /execution
+/executions
+ /plugin
+ /plugins
+ /build
+ /profile
+/profiles
/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
