[jira] [Commented] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324891#comment-16324891 ] Alexander Volanis commented on THRIFT-4259: --- I am going to attempt converting the Java library project to build using Gradle. I notice that the android library in lib/java/android is already using Gradle and that makes it a possible option in my opinion. After reading through the Ant build.xml which uses Maven under the covers to perform many of the tasks I have a pretty good understanding of the build process and how it should behave. If all goes well I can have something to review in a relatively short time. Gradle offers an option to be downloaded just in time using the Gradle Wrapper and that would help normalize the build environment for all supported platforms including Windows to a common base version of Gradle instead of relying on package managers to pull whatever backported version they happen to have in the distribution repositories. I can certainly use a lowest common denominator approach since Gradle scripting is backwards compatible through several major releases but the recommended way to make this work is to always use the Gradle Wrapper. > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0, 0.11.0 > Environment: Fedora 25, Linux, any project docker image (all use ant > 1.9.x) >Reporter: Jacek Furmankiewicz >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(De
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324709#comment-16324709 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thanks - as I remember - I already merged (not re-based) some changes from master to pull request branch (in one or few previous commits) - not sure that this will correctly work with squash. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thanks - as I remember - I already merged (not re-based) some changes from master to pull request branch (in one or few previous commits) - not sure that this will correctly work with squash. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324696#comment-16324696 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I'll squash it then. For future reference there are instructions on squashing here: https://thrift.apache.org/docs/HowToContribute > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I'll squash it then. For future reference there are instructions on squashing here: https://thrift.apache.org/docs/HowToContribute ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324601#comment-16324601 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hard to say - this can cause some time to make a single commit in manual way - if you know how I can make it fast and in simple way - then I can try to do it. Or we can simply re-run CI tests and make cherry-pick. Previously, it took half of day to understand where are problems during merge and what should be fixed - don't want to spend another day on resolving issues of merge in manual way (we can get some stupid errors and then spend some time to fix them). > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hard to say - this can cause some time to make a single commit in manual way - if you know how I can make it fast and in simple way - then I can try to do it. Or we can simply re-run CI tests and make cherry-pick. Previously, it took half of day to understand where are problems during merge and what should be fixed - don't want to spend another day on resolving issues of merge in manual way (we can get some stupid errors and then spend some time to fix them). ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324557#comment-16324557 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Would it be possible for you to squash this to a single commit, or does the commit history contain rebases? > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Would it be possible for you to squash this to a single commit, or does the commit history contain rebases? ---
[GitHub] thrift pull request #1466: THRIFT-4454 Large writes/reads may cause range ch...
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1466 THRIFT-4454 Large writes/reads may cause range check errors in debug ⦠â¦mode Client: Delphi Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4454 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1466.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1466 commit b27498128b28bfab2b7951254798d4832d775e06 Author: Jens Geyer Date: 2018-01-12T20:20:59Z THRIFT-4454 Large writes/reads may cause range check errors in debug mode Client: Delphi Patch: Jens Geyer ---
[jira] [Commented] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode
[
https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324554#comment-16324554
]
ASF GitHub Bot commented on THRIFT-4454:
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1466
THRIFT-4454 Large writes/reads may cause range check errors in debug …
…mode
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4454
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1466
commit b27498128b28bfab2b7951254798d4832d775e06
Author: Jens Geyer
Date: 2018-01-12T20:20:59Z
THRIFT-4454 Large writes/reads may cause range check errors in debug mode
Client: Delphi
Patch: Jens Geyer
> Large writes/reads may cause range check errors in debug mode
> -
>
> Key: THRIFT-4454
> URL: https://issues.apache.org/jira/browse/THRIFT-4454
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Affects Versions: 0.11.0
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.12.0
>
>
> The pipes code contains a few casts using the {{PByteArray}} pointer type.
> The underlying array {{TByteArray}} is defined as {code}
> type TByteArray = array [0..32767] of Byte;
> {code}
> With range checks enabled, any access to indices > 32767, even correct ones,
> result in an range check exception. It may be worth noting that the code is
> otherwise entirely correct (i.e. no buffer overruns). It is really only the
> type cast that introduces the failing constraint.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324550#comment-16324550 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I saw a dart signing key issue about 30 minutes ago, so yes it could be that. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I saw a dart signing key issue about 30 minutes ago, so yes it could be that. ---
[jira] [Updated] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode
[
https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4454:
---
Summary: Large writes/reads may cause range check errors in debug mode
(was: Large writes may cause range check errors in debug mode)
> Large writes/reads may cause range check errors in debug mode
> -
>
> Key: THRIFT-4454
> URL: https://issues.apache.org/jira/browse/THRIFT-4454
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Affects Versions: 0.11.0
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.12.0
>
>
> The pipes code contains a few casts using the {{PByteArray}} pointer type.
> The underlying array {{TByteArray}} is defined as {code}
> type TByteArray = array [0..32767] of Byte;
> {code}
> With range checks enabled, any access to indices > 32767, even correct ones,
> result in an range check exception. It may be worth noting that the code is
> otherwise entirely correct (i.e. no buffer overruns). It is really only the
> type cast that introduces the failing constraint.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (THRIFT-4454) Large writes may cause range check errors in debug mode
Jens Geyer created THRIFT-4454:
--
Summary: Large writes may cause range check errors in debug mode
Key: THRIFT-4454
URL: https://issues.apache.org/jira/browse/THRIFT-4454
Project: Thrift
Issue Type: Bug
Components: Delphi - Library
Affects Versions: 0.11.0
Reporter: Jens Geyer
Assignee: Jens Geyer
Fix For: 0.12.0
The pipes code contains a few casts using the {{PByteArray}} pointer type. The
underlying array {{TByteArray}} is defined as {code}
type TByteArray = array [0..32767] of Byte;
{code}
With range checks enabled, any access to indices > 32767, even correct ones,
result in an range check exception. It may be worth noting that the code is
otherwise entirely correct (i.e. no buffer overruns). It is really only the
type cast that introduces the failing constraint.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324523#comment-16324523 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 @dkochmanski Need the following things to happen: 1. resolve the merge conflict 2. install sbcl in the ubuntu-xenial and ubuntu-artful Dockerfiles 3. update LANGUAGES.md 4. update build/docker/README.md with the versions that are in the distributions. Xenial uses SBCL 1.3.1 and Artful has 1.3.14 5. we need to see a clean build so I would recommend rebasing on the current master before you push Once lisp is part of the docker images then "make check" and "make cross" will exercise it with every build. Thanks, Jim > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Fix For: 0.12.0 > > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 @dkochmanski Need the following things to happen: 1. resolve the merge conflict 2. install sbcl in the ubuntu-xenial and ubuntu-artful Dockerfiles 3. update LANGUAGES.md 4. update build/docker/README.md with the versions that are in the distributions. Xenial uses SBCL 1.3.1 and Artful has 1.3.14 5. we need to see a clean build so I would recommend rebasing on the current master before you push Once lisp is part of the docker images then "make check" and "make cross" will exercise it with every build. Thanks, Jim ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324502#comment-16324502 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Cross langs tests passed fully - some of other builds seems just a curl problems (maybe because of impossibility to download dart signing keys). So everything is good now :) > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Cross langs tests passed fully - some of other builds seems just a curl problems (maybe because of impossibility to download dart signing keys). So everything is good now :) ---
[jira] [Resolved] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4452. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > Fix For: 0.12.0 > > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324491#comment-16324491 ] ASF GitHub Bot commented on THRIFT-4452: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1464 > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > Fix For: 0.12.0 > > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1464 ---
[jira] [Created] (THRIFT-4453) Go generator flag to turn off Context parameter
Renan DelValle created THRIFT-4453: -- Summary: Go generator flag to turn off Context parameter Key: THRIFT-4453 URL: https://issues.apache.org/jira/browse/THRIFT-4453 Project: Thrift Issue Type: Improvement Affects Versions: 0.11.0 Reporter: Renan DelValle Priority: Minor It would be worthwhile to be able to pass a argument to the code generator for Go that allows to disable the addition of the Context parameter to each function signature that was included with the 0.11.0 release. This is to avoid backwards incompatible code generation in cases where developers don't require context. This flag could be as simple as `-disable-context` -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324417#comment-16324417 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes - it can be (if such self-signed certs are not trusted and if it not possible to build and validate the chain - but we cannot change that, because this will cause security problems at productions) I'm waiting for the results of cross tests - if they will be successful - then we can say that everything is good. Locally, I cannot reproduce any problem with set of few languages (cpp, c, csharp, rust, netcore, ...) for cross tests. And you can approve current pull request :) Will be a good gift for people which want to reuse .Net Core Thrift and migrate their infrastructures to the latest stable stack for .Net > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes - it can be (if such self-signed certs are not trusted and if it not possible to build and validate the chain - but we cannot change that, because this will cause security problems at productions) I'm waiting for the results of cross tests - if they will be successful - then we can say that everything is good. Locally, I cannot reproduce any problem with set of few languages (cpp, c, csharp, rust, netcore, ...) for cross tests. And you can approve current pull request :) Will be a good gift for people which want to reuse .Net Core Thrift and migrate their infrastructures to the latest stable stack for .Net ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324407#comment-16324407 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 All our tests use self-signed certificates... so validating the chain may result in a certificate error? > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 All our tests use self-signed certificates... so validating the chain may result in a certificate error? ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324256#comment-16324256 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 The biggest fun - that csharp code for server tests are the same as it was regarding the Tls (it was simple Tls1 and it is Tls1). I will try to remove ((sender, certificate, chain, errors) => true, ) locally and test - if it will work then commit to check at build machines. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 The biggest fun - that csharp code for server tests are the same as it was regarding the Tls (it was simple Tls1 and it is Tls1). I will try to remove ((sender, certificate, chain, errors) => true, ) locally and test - if it will work then commit to check at build machines. ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hm - for csharp for tests I enabled validation of any certificate to be successful ``` csharp ((sender, certificate, chain, errors) => true, ) ``` in server tests code Do you think I should revert it to check ? ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324244#comment-16324244 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hm - for csharp for tests I enabled validation of any certificate to be successful ``` csharp ((sender, certificate, chain, errors) => true, ) ``` in server tests code Do you think I should revert it to check ? > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324235#comment-16324235 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 The log is there: ``` === *** Following 1 failures were unexpected ***: If it is introduced by you, please fix it before submitting the code. === server-client: protocol: transport: result: csharp-tls binarybuffered-ip-ssl failure(3) === ``` There is a security feature test in test/features called tls and it verifies that the server accepts a TLS connection. It verifies that a TLSv1.0, TLSv1.1, or TLSv1.2 client can connect successfully. If this is failing then something changed in the code that restricted the TLS to one level. We currently use SSLv23 handshake and disable the use of SSLv2 and SSLv3, so that the client can connect at TLSv1.0 or higher. There's a story in the backlog to move all languages by default up to TLSv1.2 to improve security. https://issues.apache.org/jira/browse/THRIFT-3165 Implementing that across the board would be verified by modifying tls.sh in test/features so that TLSv1.0 and TLSv1.1 was NOT expected to allow a connection by default. What I have found is that if you specify a handshake at TLSv10, then ONLY TLSv1.0 is allowed to connect. It doesn't allow TLSv1.1 or TLSv1.2 to connect. If you specify a SSLv23 handshake, but disable SSLv2 and SSLv3 negotiation, then any client can connect and they can only negotiate at TLSv1.0 or later, which is the current behavior we have. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 The log is there: ``` === *** Following 1 failures were unexpected ***: If it is introduced by you, please fix it before submitting the code. === server-client: protocol: transport: result: csharp-tls binarybuffered-ip-ssl failure(3) === ``` There is a security feature test in test/features called tls and it verifies that the server accepts a TLS connection. It verifies that a TLSv1.0, TLSv1.1, or TLSv1.2 client can connect successfully. If this is failing then something changed in the code that restricted the TLS to one level. We currently use SSLv23 handshake and disable the use of SSLv2 and SSLv3, so that the client can connect at TLSv1.0 or higher. There's a story in the backlog to move all languages by default up to TLSv1.2 to improve security. https://issues.apache.org/jira/browse/THRIFT-3165 Implementing that across the board would be verified by modifying tls.sh in test/features so that TLSv1.0 and TLSv1.1 was NOT expected to allow a connection by default. What I have found is that if you specify a handshake at TLSv10, then ONLY TLSv1.0 is allowed to connect. It doesn't allow TLSv1.1 or TLSv1.2 to connect. If you specify a SSLv23 handshake, but disable SSLv2 and SSLv3 negotiation, then any client can connect and they can only negotiate at TLSv1.0 or later, which is the current behavior we have. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324224#comment-16324224 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Something at https://travis-ci.org/apache/thrift/jobs/328143179 - but locally I cannot reproduce this problem - also no logs at Travis CI. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Something at https://travis-ci.org/apache/thrift/jobs/328143179 - but locally I cannot reproduce this problem - also no logs at Travis CI. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324154#comment-16324154 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Currently the Ubuntu Xenial image which runs our cross tests in CI is installing dotnet-sdk-2.0.3, as is our Ubuntu Artful image. The latest is dotnet-sdk-2.1.4. Normally we like to have an older language level in the mix somewhere; so if your changes work properly on 2.0.3 that's great; we should update the artful Dockerfile to 2.1.4 in that case, so we have a "make check" environment on the latest SDK. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Currently the Ubuntu Xenial image which runs our cross tests in CI is installing dotnet-sdk-2.0.3, as is our Ubuntu Artful image. The latest is dotnet-sdk-2.1.4. Normally we like to have an older language level in the mix somewhere; so if your changes work properly on 2.0.3 that's great; we should update the artful Dockerfile to 2.1.4 in that case, so we have a "make check" environment on the latest SDK. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324147#comment-16324147 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 Let me know what the commands are to add lisp to an Ubuntu Xenial system. We need to update the Dockerfile to include Common Lisp so that it actually runs in the build system. This has to happen before we commit. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Fix For: 0.12.0 > > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 Let me know what the commands are to add lisp to an Ubuntu Xenial system. We need to update the Dockerfile to include Common Lisp so that it actually runs in the build system. This has to happen before we commit. ---
[jira] [Commented] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324145#comment-16324145
]
ASF GitHub Bot commented on THRIFT-4352:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1465
THRIFT-4352: update artful to use haxe 3.4.4 which fixes a core in haxe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4352
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1465.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1465
commit 0f236a25628b84348515c77f71b79d9accfd9719
Author: James E. King III
Date: 2018-01-12T15:43:25Z
THRIFT-4352: update artful to use haxe 3.4.4 which fixes a core in haxe
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
>
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful with haxe 3.4.2 (stock)
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1465: THRIFT-4352: update artful to use haxe 3.4.4 whic...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1465 THRIFT-4352: update artful to use haxe 3.4.4 which fixes a core in haxe You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4352 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1465.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1465 commit 0f236a25628b84348515c77f71b79d9accfd9719 Author: James E. King III Date: 2018-01-12T15:43:25Z THRIFT-4352: update artful to use haxe 3.4.4 which fixes a core in haxe ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324123#comment-16324123 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 It's already enabled - I removed disabled for netcore from tests.json > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 It's already enabled - I removed disabled for netcore from tests.json ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324107#comment-16324107 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 To get netcore cross test running as a server you need to change "server-disabled" to "server" in test/tests.json, by the way... > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 To get netcore cross test running as a server you need to change "server-disabled" to "server" in test/tests.json, by the way... ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324085#comment-16324085 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 See: https://github.com/apache/thrift/blob/master/build/docker/README.md Also, I am testing Ubuntu Artful with dotnet-sdk-2.1.4 which pulls in netcore-2.0.5 (we're on 2.0.2). We may be able to pull this dotnet sdk into the xenial image just as easily, especially if it fixes netcore server cross tests. I'd like to continue to run the cross test suite on the LTS release. Fortunately there's another coming out in a few months. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 See: https://github.com/apache/thrift/blob/master/build/docker/README.md Also, I am testing Ubuntu Artful with dotnet-sdk-2.1.4 which pulls in netcore-2.0.5 (we're on 2.0.2). We may be able to pull this dotnet sdk into the xenial image just as easily, especially if it fixes netcore server cross tests. I'd like to continue to run the cross test suite on the LTS release. Fortunately there's another coming out in a few months. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324047#comment-16324047 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - pls check what version of mono is used for building csharp - it seems it very old (because it doesn't contain Tls11 and Tls12 in enumeration - error `System.Security.Authentication.SslProtocols' does not contain a definition for `Tls11') > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - pls check what version of mono is used for building csharp - it seems it very old (because it doesn't contain Tls11 and Tls12 in enumeration - error `System.Security.Authentication.SslProtocols' does not contain a definition for `Tls11') ---
[jira] [Resolved] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes
[
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4390.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> Rust binary protocol and buffered transport cannot handle writes above 4096
> bytes
> -
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
>Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
>Reporter: James E. King, III
>Assignee: Allen George
>Priority: Critical
> Fix For: 0.12.0
>
>
> While working on improving test coverage and fixing busted cross tests I
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16,
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126,
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing
> with the interop against c_glib recently. It is the root cause of some (if
> not all of) the rs-csharp test failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes
[
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323930#comment-16323930
]
ASF GitHub Bot commented on THRIFT-4390:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1458
> Rust binary protocol and buffered transport cannot handle writes above 4096
> bytes
> -
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
>Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
>Reporter: James E. King, III
>Assignee: Allen George
>Priority: Critical
> Fix For: 0.12.0
>
>
> While working on improving test coverage and fixing busted cross tests I
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16,
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126,
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing
> with the interop against c_glib recently. It is the root cause of some (if
> not all of) the rs-csharp test failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1458: THRIFT-4390: Fix bug where binary/buffered messag...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1458 ---
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323920#comment-16323920 ] ASF GitHub Bot commented on THRIFT-4452: Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161216512 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ +echo "deb https://deb.nodesource.com/node_8.x artful main" | sudo tee /etc/apt/sources.list.d/nodesource.list +# D +RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E && \ +wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O /etc/apt/sources.list.d/d-apt.list && \ +wget -qO - https://dlang.org/d-keyring.gpg | apt-key add - + +# Dart +RUN curl https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - && \ +curl https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list > \ +/etc/apt/sources.list.d/dart_stable.list --- End diff -- `apt-get install nodejs` run at line 137 > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161216512 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ +echo "deb https://deb.nodesource.com/node_8.x artful main" | sudo tee /etc/apt/sources.list.d/nodesource.list +# D +RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E && \ +wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O /etc/apt/sources.list.d/d-apt.list && \ +wget -qO - https://dlang.org/d-keyring.gpg | apt-key add - + +# Dart +RUN curl https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - && \ +curl https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list > \ +/etc/apt/sources.list.d/dart_stable.list --- End diff -- `apt-get install nodejs` run at line 137 ---
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323915#comment-16323915 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1464 I wish Dockerfile had a INCLUDE directive where common stuff could be factored out! > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1464: THRIFT-4452: optimize Dockerfile
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1464 I wish Dockerfile had a INCLUDE directive where common stuff could be factored out! ---
[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes
[
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323913#comment-16323913
]
ASF GitHub Bot commented on THRIFT-4390:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1458
@jeking3 Looks like everything passed, so this patch is good to go. TY!
> Rust binary protocol and buffered transport cannot handle writes above 4096
> bytes
> -
>
> Key: THRIFT-4390
> URL: https://issues.apache.org/jira/browse/THRIFT-4390
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
>Affects Versions: 0.10.0
> Environment: docker image ubuntu-artful
>Reporter: James E. King, III
>Assignee: Allen George
>Priority: Critical
>
> While working on improving test coverage and fixing busted cross tests I
> reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16,
> ..., 131072 and after 4096 the rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126,
> 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError
> { kind: Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}
> @gadLinux this may be the root cause of some of the issues you were seeing
> with the interop against c_glib recently. It is the root cause of some (if
> not all of) the rs-csharp test failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 Looks like everything passed, so this patch is good to go. TY! ---
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323911#comment-16323911 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215273 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list --- End diff -- Indent this so it makes more sense (it looks like a separate command) > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323912#comment-16323912 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215374 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ --- End diff -- where is the node.js setup run? > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215374 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ --- End diff -- where is the node.js setup run? ---
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215273 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list --- End diff -- Indent this so it makes more sense (it looks like a separate command) ---
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323909#comment-16323909 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215006 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ +echo "deb https://deb.nodesource.com/node_8.x artful main" | sudo tee /etc/apt/sources.list.d/nodesource.list +# D +RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E && \ +wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O /etc/apt/sources.list.d/d-apt.list && \ +wget -qO - https://dlang.org/d-keyring.gpg | apt-key add - + +# Dart +RUN curl https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - && \ +curl https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list > \ +/etc/apt/sources.list.d/dart_stable.list --- End diff -- You need to run apt-get update here after adding these repositories. > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215006 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ +echo "deb https://deb.nodesource.com/node_8.x artful main" | sudo tee /etc/apt/sources.list.d/nodesource.list +# D +RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E && \ +wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O /etc/apt/sources.list.d/d-apt.list && \ +wget -qO - https://dlang.org/d-keyring.gpg | apt-key add - + +# Dart +RUN curl https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - && \ +curl https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list > \ +/etc/apt/sources.list.d/dart_stable.list --- End diff -- You need to run apt-get update here after adding these repositories. ---
[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4352:
---
Component/s: (was: Build Process)
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
>
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful with haxe 3.4.2 (stock)
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4352:
---
Component/s: Build Process
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
>
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful with haxe 3.4.2 (stock)
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4352:
---
Environment: docker ubuntu-artful with haxe 3.4.2 (stock) (was: docker
ubuntu-artful)
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
>
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful with haxe 3.4.2 (stock)
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323905#comment-16323905
]
James E. King, III commented on THRIFT-4352:
Good news - the latest Haxe 3.4.4 seems to work and not crash like 3.4.2, so I
will update the artful Dockerfile for this.
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
>
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4352:
---
Summary: Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe
3.4.2 (was: Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe
3.4)
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2
>
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4
[
https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4352:
--
Assignee: James E. King, III
> Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4
> --
>
> Key: THRIFT-4352
> URL: https://issues.apache.org/jira/browse/THRIFT-4352
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-artful
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm working on the artful image, and haxe fails make check, so I have
> disabled haxe in artful builds:
> {noformat}
> TestServerHandler.hx:51: testVoid()
> TestClient.hx:926: 1.262 ms per testVoid() call
> TestClient.hx:100: ===
> TestClient.hx:101: Tests executed122
> TestClient.hx:102: Tests succeeded 122 (100%)
> TestClient.hx:103: Tests failed 0 (0%)
> TestClient.hx:109: ===
> TestClient.hx:135: total test time: 1.396 seconds
> TSocket.hx:167: Eof Eof
> sleep 10
> timeout 20 php -S 127.0.0.1:9090 router.php &
> sleep 1
> PHP 7.1.8-1ubuntu1 Development Server started at Sun Oct 1 23:24:37 2017
> Listening on http://127.0.0.1:9090
> Document root is /thrift/src/test/haxe
> Press Ctrl-C to quit.
> bin/Main-debug client --transport http
> TestClient.hx:216: - http client : http://localhost:9090
> TestClient.hx:237: - binary protocol
> TestClient.hx:252: - 1 iterations
> TestClient.hx:437: testException("Xception")
> TestClient.hx:85: FAIL: testException("Xception") - OutsideBounds
> TestClient.hx:453: testException("TException")
> TestClient.hx:85: FAIL: testException("TException") - OutsideBounds
> TestClient.hx:473: testException("bla")
> TestClient.hx:85: FAIL: testException("bla") - OutsideBounds
> TestClient.hx:485: testVoid()
> Makefile:693: recipe for target 'check_php_web' failed
> make: *** [check_php_web] Segmentation fault (core dumped)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323895#comment-16323895 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161212364 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ --- End diff -- sudo is unnecessary and causes a failure in a docker container (see build) > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161212364 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ --- End diff -- sudo is unnecessary and causes a failure in a docker container (see build) ---
[GitHub] thrift pull request #1340: THRIFT-4295: reworked docker images to resolve bu...
Github user stigsb commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1340#discussion_r161191042
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -242,8 +242,10 @@ public function open()
throw new TException($error);
}
-$socket = socket_import_stream($this->handle_);
-socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
+if (function_exists('socket_import_stream') &&
function_exists('socket_set_option')) {
--- End diff --
My analysis was incorrect, it wasn't your patch causing our issue @jeking3
sorry for jumping the gun.
---
[jira] [Commented] (THRIFT-4295) Refresh the Docker image file suite for Ubuntu, Debian, and CentOS
[
https://issues.apache.org/jira/browse/THRIFT-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323818#comment-16323818
]
ASF GitHub Bot commented on THRIFT-4295:
Github user stigsb commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1340#discussion_r161191042
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -242,8 +242,10 @@ public function open()
throw new TException($error);
}
-$socket = socket_import_stream($this->handle_);
-socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
+if (function_exists('socket_import_stream') &&
function_exists('socket_set_option')) {
--- End diff --
My analysis was incorrect, it wasn't your patch causing our issue @jeking3
sorry for jumping the gun.
> Refresh the Docker image file suite for Ubuntu, Debian, and CentOS
> --
>
> Key: THRIFT-4295
> URL: https://issues.apache.org/jira/browse/THRIFT-4295
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
>Affects Versions: 0.11.0
> Environment: docker, travis
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Critical
> Labels: centos, debian, docker, travis-ci, ubuntu
> Fix For: 0.11.0
>
>
> The docker build images are in need of some much needed updating to avoid CI
> build issues.
> centos is getting updates for cmake, gcc, go, and others as well as working
> around the epel issue with nodejs and http_parser
> debian is being updated from jessie (8) to stretch (9.1)
> ubuntu is being updated from 14.04 to 16.04
> The previous images will still be available:
> centos6 will remain untouched, however the last remaining build job
> validating python 2.6 is going to be removed
> debian8 will be there for jessie, however we will not build packages from it
> any more
> ubuntu1404 will be there for trusty, however we will not build using it any
> more
> So far here's what's on the ubuntu 16.04 xenial docker image:
> {noformat}
> C++ (C++11 default) gcc-5.4.0, clang-3.8
> C# mono 5.2.0.215
> c_glib 2.0
> d 2.075.1
> dart1.24.2
> erlang 18.3
> go 1.6.2
> haskell 7.10.3
> haxe3.2.1
> java1.8.0_131
> lua 5.3
> nodejs 8.4.0
> perl5.22.1
> php 7.0.22
> python 2.7.12, 3.5.2
> ruby2.3.1p112
> rust1.15.1
> Intentionally leaving this out, for now (it wasn't in the trusty docker image
> either):
> dotnet 2.0.0
> Not in any images:
> cocoa
> smalltalk
> swift
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
