[freenet-dev] CPUID patch from FMS

2008-06-04 Thread Florent Daignière 
* Florent Daigni?re  [2008-05-18 06:09:15]:

> * Matthew Toseland  [2008-05-17 14:44:27]:
> 
> > On Saturday 17 May 2008 13:58, Florent Daigni?re wrote:
> > > * Florent Daigni?re  [2008-05-17 
> > > 14:03:10]:
> > > 
> > > > * Matthew Toseland  [2008-05-17 12:29:09]:
> > > > 
> > > > > As nextgens is worried about anonymous contributions, I thought he 
> > > > > might 
> > want 
> > > > > to review this before I apply it.
> > > > > 
> > > > 
> > > > There is a related bug in the bug tracker... It's not the only bits that
> > > > need updating :/
> > > > 
> > > > See #74
> > > 
> > > http://download.intel.com/design/processor/applnots/24161832.pdf
> > > 
> > http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf
> > > 
> > > Here are the CPUID codes if you want to update them.
> > > 
> > So should we or shouldn't we apply yongjhen's patch?
> 
> I think that applying that patch instead of updating the whole set of codes
> is not the way to go...
> 
> If we were really after performances we would recompile the native
> libraries with the new libgmp... which has performances boost on that
> kind of (recent) processors.

Any progress ?
Did you fill a ticket in for that issue ?
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:

Re: [freenet-dev] CPUID patch from FMS

2008-06-04 Thread Florent Daignière 
* Florent Daignière [EMAIL PROTECTED] [2008-05-18 06:09:15]:

 * Matthew Toseland [EMAIL PROTECTED] [2008-05-17 14:44:27]:
 
  On Saturday 17 May 2008 13:58, Florent Daignière wrote:
   * Florent Daignière [EMAIL PROTECTED] [2008-05-17 14:03:10]:
   
* Matthew Toseland [EMAIL PROTECTED] [2008-05-17 12:29:09]:

 As nextgens is worried about anonymous contributions, I thought he 
 might 
  want 
 to review this before I apply it.
 

There is a related bug in the bug tracker... It's not the only bits that
need updating :/

See #74
   
   http://download.intel.com/design/processor/applnots/24161832.pdf
   
  http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf
   
   Here are the CPUID codes if you want to update them.
   
  So should we or shouldn't we apply yongjhen's patch?
 
 I think that applying that patch instead of updating the whole set of codes
 is not the way to go...
 
 If we were really after performances we would recompile the native
 libraries with the new libgmp... which has performances boost on that
 kind of (recent) processors.

Any progress ?
Did you fill a ticket in for that issue ?


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

[freenet-dev] CPUID patch from FMS

2008-05-20 Thread Florent Daignière 
* Ian Clarke  [2008-05-17 10:35:59]:

> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
>  wrote:
> > As nextgens is worried about anonymous contributions, I thought he might 
> > want
> > to review this before I apply it.
> 
> You know, I wish you guys would at least try using that Smartbear
> software, this is *exactly* what it is designed for and makes
> code-review much easier.
> 

Okay, I've set it up on emu and I'm about to configure the svn-hooks; I
will publish its address when I'm done.

Here is what the doc says about them:

###
Subversion Server Triggers
Subversion server-side hooks can enforce certain workflow rules across all 
Subversion clients:
- Review-before-commit
- Create review automatically upon commit
- Upload changelists upon commit so reviews can be created by revision 
number
###

IMHO we don't want the first option... I'm not sure about the others...
The third one would be useful if we really use the tool and the second
one would actually force us to use it.

Which of the hooks shall I set up ? :)
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:

Re: [freenet-dev] CPUID patch from FMS

2008-05-20 Thread Florent Daignière 
* Ian Clarke [EMAIL PROTECTED] [2008-05-17 10:35:59]:

 On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
  As nextgens is worried about anonymous contributions, I thought he might 
  want
  to review this before I apply it.
 
 You know, I wish you guys would at least try using that Smartbear
 software, this is *exactly* what it is designed for and makes
 code-review much easier.
 

Okay, I've set it up on emu and I'm about to configure the svn-hooks; I
will publish its address when I'm done.

Here is what the doc says about them:

###
Subversion Server Triggers
Subversion server-side hooks can enforce certain workflow rules across all 
Subversion clients:
- Review-before-commit
- Create review automatically upon commit
- Upload changelists upon commit so reviews can be created by revision 
number
###

IMHO we don't want the first option... I'm not sure about the others...
The third one would be useful if we really use the tool and the second
one would actually force us to use it.

Which of the hooks shall I set up ? :)


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

[freenet-dev] CPUID patch from FMS

2008-05-18 Thread Daniel Cheng 
On Sun, May 18, 2008 at 9:00 PM, Ian Clarke  wrote:
> On Sun, May 18, 2008 at 5:34 AM, Daniel Cheng  
> wrote:
>> On Sat, May 17, 2008 at 11:35 PM, Ian Clarke  wrote:
>>> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
>>>  wrote:
 As nextgens is worried about anonymous contributions, I thought he might 
 want
 to review this before I apply it.
>>>
>>> You know, I wish you guys would at least try using that Smartbear
>>> software, this is *exactly* what it is designed for and makes
>>> code-review much easier.
>>
>> Atlassian Crucible is designed for code reviewing too. Their software
>> are well integrated with subversion. They offer their whole stack of
>> softwares to any open source project for free on request.
>
> Do you have personal experience of working with Crucible?  I don't
> have personal experience of working with Smartbear, but people I trust
> do and highly recommend it (and they were at least as dismissive as
> Toad and Nextgens are being to begin with).

(According to what I have seen) Crucible is not as good as Smartbear,
but it can be integrated with other Atlassian products (see
http://www.atlassian.com/software/development.jsp), which I love to
use.

OTOH, if we want some participation from the anonymous freenet
communities, keeping the existing review-on-maillist workflow and
build a maillist-to-fms/freemail gateway is probably a better choice.

Daniel

[freenet-dev] CPUID patch from FMS

2008-05-18 Thread Daniel Cheng 
On Sat, May 17, 2008 at 11:35 PM, Ian Clarke  wrote:
> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
>  wrote:
>> As nextgens is worried about anonymous contributions, I thought he might want
>> to review this before I apply it.
>
> You know, I wish you guys would at least try using that Smartbear
> software, this is *exactly* what it is designed for and makes
> code-review much easier.

Atlassian Crucible is designed for code reviewing too. Their software
are well integrated with subversion. They offer their whole stack of
softwares to any open source project for free on request.


> Ian.

[freenet-dev] CPUID patch from FMS

2008-05-18 Thread Ian Clarke 
On Sun, May 18, 2008 at 5:34 AM, Daniel Cheng  
wrote:
> On Sat, May 17, 2008 at 11:35 PM, Ian Clarke  wrote:
>> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
>>  wrote:
>>> As nextgens is worried about anonymous contributions, I thought he might 
>>> want
>>> to review this before I apply it.
>>
>> You know, I wish you guys would at least try using that Smartbear
>> software, this is *exactly* what it is designed for and makes
>> code-review much easier.
>
> Atlassian Crucible is designed for code reviewing too. Their software
> are well integrated with subversion. They offer their whole stack of
> softwares to any open source project for free on request.

Do you have personal experience of working with Crucible?  I don't
have personal experience of working with Smartbear, but people I trust
do and highly recommend it (and they were at least as dismissive as
Toad and Nextgens are being to begin with).

Not that this is a significant factor, but I'm friends with the
founder of Smartbear, so if we need anything from them, we're likely
to get it.

Ian.

-- 
Email: ian at uprizer.com
Cell: +1 512 422 3588
Skype: sanity

[freenet-dev] CPUID patch from FMS

2008-05-18 Thread Florent Daignière 
* Matthew Toseland  [2008-05-17 14:44:27]:

> On Saturday 17 May 2008 13:58, Florent Daigni?re wrote:
> > * Florent Daigni?re  [2008-05-17 14:03:10]:
> > 
> > > * Matthew Toseland  [2008-05-17 12:29:09]:
> > > 
> > > > As nextgens is worried about anonymous contributions, I thought he 
> > > > might 
> want 
> > > > to review this before I apply it.
> > > > 
> > > 
> > > There is a related bug in the bug tracker... It's not the only bits that
> > > need updating :/
> > > 
> > > See #74
> > 
> > http://download.intel.com/design/processor/applnots/24161832.pdf
> > 
> http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf
> > 
> > Here are the CPUID codes if you want to update them.
> > 
> So should we or shouldn't we apply yongjhen's patch?

I think that applying that patch instead of updating the whole set of codes
is not the way to go...

If we were really after performances we would recompile the native
libraries with the new libgmp... which has performances boost on that
kind of (recent) processors.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:

[freenet-dev] CPUID patch from FMS

2008-05-18 Thread Florent Daignière 
* Ian Clarke  [2008-05-17 20:43:17]:

> On Sat, May 17, 2008 at 12:53 PM, Matthew Toseland
>  wrote:
> > On Saturday 17 May 2008 16:35, Ian Clarke wrote:
> >> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
> >>  wrote:
> >> > As nextgens is worried about anonymous contributions, I thought he might
> > want
> >> > to review this before I apply it.
> >>
> >> You know, I wish you guys would at least try using that Smartbear
> >> software, this is *exactly* what it is designed for and makes
> >> code-review much easier.
> >
> > I personally review all commits.
> 
> Who reviews your commits?  Perhaps if it were easier, someone would.
> 

Its a matter of time and will more than a tool-related problem afaic :/
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:

Re: [freenet-dev] CPUID patch from FMS

2008-05-18 Thread Daniel Cheng 
On Sat, May 17, 2008 at 11:35 PM, Ian Clarke [EMAIL PROTECTED] wrote:
 On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
 As nextgens is worried about anonymous contributions, I thought he might want
 to review this before I apply it.

 You know, I wish you guys would at least try using that Smartbear
 software, this is *exactly* what it is designed for and makes
 code-review much easier.

Atlassian Crucible is designed for code reviewing too. Their software
are well integrated with subversion. They offer their whole stack of
softwares to any open source project for free on request.


 Ian.
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-18 Thread Ian Clarke 
On Sun, May 18, 2008 at 5:34 AM, Daniel Cheng [EMAIL PROTECTED] wrote:
 On Sat, May 17, 2008 at 11:35 PM, Ian Clarke [EMAIL PROTECTED] wrote:
 On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
 As nextgens is worried about anonymous contributions, I thought he might 
 want
 to review this before I apply it.

 You know, I wish you guys would at least try using that Smartbear
 software, this is *exactly* what it is designed for and makes
 code-review much easier.

 Atlassian Crucible is designed for code reviewing too. Their software
 are well integrated with subversion. They offer their whole stack of
 softwares to any open source project for free on request.

Do you have personal experience of working with Crucible?  I don't
have personal experience of working with Smartbear, but people I trust
do and highly recommend it (and they were at least as dismissive as
Toad and Nextgens are being to begin with).

Not that this is a significant factor, but I'm friends with the
founder of Smartbear, so if we need anything from them, we're likely
to get it.

Ian.

-- 
Email: [EMAIL PROTECTED]
Cell: +1 512 422 3588
Skype: sanity
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-18 Thread Daniel Cheng 
On Sun, May 18, 2008 at 9:00 PM, Ian Clarke [EMAIL PROTECTED] wrote:
 On Sun, May 18, 2008 at 5:34 AM, Daniel Cheng [EMAIL PROTECTED] wrote:
 On Sat, May 17, 2008 at 11:35 PM, Ian Clarke [EMAIL PROTECTED] wrote:
 On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
 As nextgens is worried about anonymous contributions, I thought he might 
 want
 to review this before I apply it.

 You know, I wish you guys would at least try using that Smartbear
 software, this is *exactly* what it is designed for and makes
 code-review much easier.

 Atlassian Crucible is designed for code reviewing too. Their software
 are well integrated with subversion. They offer their whole stack of
 softwares to any open source project for free on request.

 Do you have personal experience of working with Crucible?  I don't
 have personal experience of working with Smartbear, but people I trust
 do and highly recommend it (and they were at least as dismissive as
 Toad and Nextgens are being to begin with).

(According to what I have seen) Crucible is not as good as Smartbear,
but it can be integrated with other Atlassian products (see
http://www.atlassian.com/software/development.jsp), which I love to
use.

OTOH, if we want some participation from the anonymous freenet
communities, keeping the existing review-on-maillist workflow and
build a maillist-to-fms/freemail gateway is probably a better choice.

Daniel
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Ian Clarke 
On Sat, May 17, 2008 at 12:53 PM, Matthew Toseland
 wrote:
> On Saturday 17 May 2008 16:35, Ian Clarke wrote:
>> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
>>  wrote:
>> > As nextgens is worried about anonymous contributions, I thought he might
> want
>> > to review this before I apply it.
>>
>> You know, I wish you guys would at least try using that Smartbear
>> software, this is *exactly* what it is designed for and makes
>> code-review much easier.
>
> I personally review all commits.

Who reviews your commits?  Perhaps if it were easier, someone would.

Ian.

-- 
Email: ian at uprizer.com
Cell: +1 512 422 3588
Skype: sanity

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Matthew Toseland 
On Saturday 17 May 2008 16:35, Ian Clarke wrote:
> On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
>  wrote:
> > As nextgens is worried about anonymous contributions, I thought he might 
want
> > to review this before I apply it.
> 
> You know, I wish you guys would at least try using that Smartbear
> software, this is *exactly* what it is designed for and makes
> code-review much easier.

I personally review all commits. Nextgens used to but doesn't have time any 
more... if a specific commit worries me I will forward it to him.
> 
> Ian.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Florent Daignière 
* Florent Daigni?re  [2008-05-17 14:03:10]:

> * Matthew Toseland  [2008-05-17 12:29:09]:
> 
> > As nextgens is worried about anonymous contributions, I thought he might 
> > want 
> > to review this before I apply it.
> > 
> 
> There is a related bug in the bug tracker... It's not the only bits that
> need updating :/
> 
> See #74

http://download.intel.com/design/processor/applnots/24161832.pdf
http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf

Here are the CPUID codes if you want to update them.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Matthew Toseland 
On Saturday 17 May 2008 13:58, Florent Daigni?re wrote:
> * Florent Daigni?re  [2008-05-17 14:03:10]:
> 
> > * Matthew Toseland  [2008-05-17 12:29:09]:
> > 
> > > As nextgens is worried about anonymous contributions, I thought he might 
want 
> > > to review this before I apply it.
> > > 
> > 
> > There is a related bug in the bug tracker... It's not the only bits that
> > need updating :/
> > 
> > See #74
> 
> http://download.intel.com/design/processor/applnots/24161832.pdf
> 
http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf
> 
> Here are the CPUID codes if you want to update them.
> 
So should we or shouldn't we apply yongjhen's patch?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Florent Daignière 
* Matthew Toseland  [2008-05-17 12:29:09]:

> As nextgens is worried about anonymous contributions, I thought he might want 
> to review this before I apply it.
> 

There is a related bug in the bug tracker... It's not the only bits that
need updating :/

See #74

> CPUID patch
> From:
> yongjhen at okYcFnYIaKTYWj1K7EfA7LONeLu7Bwazdd4djTIe4eU
>   Date:
> Friday 16 May 2008 03:43:30
>   Groups:
> freenet
>   Followup-To:
> freenet
> Message was signed with unknown key 0xB3FFA5B9.
> The validity of the signature cannot be verified.
>   Hi all,
> 
> This patch makes Freenet recognize Intel Pentium M, Core, and Core 2 as
> Pentium 4 compatible, and load corresponding native BigInteger library.
> Tested on my laptop with Core CPU.
> 
> 
> --- freenet/src/freenet/support/CPUInformation/CPUID.java.orig
> 2008-04-23 15:24:19.0 +0800
> +++ freenet/src/freenet/support/CPUInformation/CPUID.java
> 2008-05-16 10:35:55.0 +0800
> @@ -280,7 +280,10 @@
> }
> public boolean IsPentium4Compatible()
> {
> -   return getCPUFamily() >= 15;
> +   int family = getCPUFamily();
> +   int model = getCPUModel();
> +   return (family >= 15 ||
> +   (family == 6 && (model == 9 || model
> >=13)));
> }
> public String getCPUModelString() throws
> UnknownCPUException {
> if(getCPUFamily() == 4){
> 
> 
> Cheers!
> 
> --
> FMS:  yongjhen at okYcFnYIaKTYWj1K7EfA7LONeLu7Bwazdd4djTIe4eU
> Freemail: yongjhen at alqualonde.freemail
> PGP fingerprint: 88B6 7F21 38E1 01E6 CF3E B1AD 31CC C1F2 B3FF A5B9
> 
> 
>   End of signed message



> ___
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Matthew Toseland 
As nextgens is worried about anonymous contributions, I thought he might want 
to review this before I apply it.

CPUID patch
From:
yongjhen at okYcFnYIaKTYWj1K7EfA7LONeLu7Bwazdd4djTIe4eU
  Date:
Friday 16 May 2008 03:43:30
  Groups:
freenet
  Followup-To:
freenet
Message was signed with unknown key 0xB3FFA5B9.
The validity of the signature cannot be verified.
  Hi all,

This patch makes Freenet recognize Intel Pentium M, Core, and Core 2 as
Pentium 4 compatible, and load corresponding native BigInteger library.
Tested on my laptop with Core CPU.


--- freenet/src/freenet/support/CPUInformation/CPUID.java.orig
2008-04-23 15:24:19.0 +0800
+++ freenet/src/freenet/support/CPUInformation/CPUID.java
2008-05-16 10:35:55.0 +0800
@@ -280,7 +280,10 @@
}
public boolean IsPentium4Compatible()
{
-   return getCPUFamily() >= 15;
+   int family = getCPUFamily();
+   int model = getCPUModel();
+   return (family >= 15 ||
+   (family == 6 && (model == 9 || model
>=13)));
}
public String getCPUModelString() throws
UnknownCPUException {
if(getCPUFamily() == 4){


Cheers!

--
FMS:  yongjhen at okYcFnYIaKTYWj1K7EfA7LONeLu7Bwazdd4djTIe4eU
Freemail: yongjhen at alqualonde.freemail
PGP fingerprint: 88B6 7F21 38E1 01E6 CF3E B1AD 31CC C1F2 B3FF A5B9


  End of signed message
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:

[freenet-dev] CPUID patch from FMS

2008-05-17 Thread Matthew Toseland 
As nextgens is worried about anonymous contributions, I thought he might want 
to review this before I apply it.

CPUID patch
From:
[EMAIL PROTECTED]
  Date:
Friday 16 May 2008 03:43:30
  Groups:
freenet
  Followup-To:
freenet
Message was signed with unknown key 0xB3FFA5B9.
The validity of the signature cannot be verified.
  Hi all,

This patch makes Freenet recognize Intel Pentium M, Core, and Core 2 as
Pentium 4 compatible, and load corresponding native BigInteger library.
Tested on my laptop with Core CPU.

patch
--- freenet/src/freenet/support/CPUInformation/CPUID.java.orig
2008-04-23 15:24:19.0 +0800
+++ freenet/src/freenet/support/CPUInformation/CPUID.java
2008-05-16 10:35:55.0 +0800
@@ -280,7 +280,10 @@
}
public boolean IsPentium4Compatible()
{
-   return getCPUFamily() = 15;
+   int family = getCPUFamily();
+   int model = getCPUModel();
+   return (family = 15 ||
+   (family == 6  (model == 9 || model
=13)));
}
public String getCPUModelString() throws
UnknownCPUException {
if(getCPUFamily() == 4){
/patch

Cheers!

--
FMS:  [EMAIL PROTECTED]
Freemail: [EMAIL PROTECTED]
PGP fingerprint: 88B6 7F21 38E1 01E6 CF3E B1AD 31CC C1F2 B3FF A5B9


  End of signed message


pgpjmUNPjWZx1.pgp
Description: PGP signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Florent Daignière 
* Matthew Toseland [EMAIL PROTECTED] [2008-05-17 12:29:09]:

 As nextgens is worried about anonymous contributions, I thought he might want 
 to review this before I apply it.
 

There is a related bug in the bug tracker... It's not the only bits that
need updating :/

See #74

 CPUID patch
 From:
 [EMAIL PROTECTED]
   Date:
 Friday 16 May 2008 03:43:30
   Groups:
 freenet
   Followup-To:
 freenet
 Message was signed with unknown key 0xB3FFA5B9.
 The validity of the signature cannot be verified.
   Hi all,
 
 This patch makes Freenet recognize Intel Pentium M, Core, and Core 2 as
 Pentium 4 compatible, and load corresponding native BigInteger library.
 Tested on my laptop with Core CPU.
 
 patch
 --- freenet/src/freenet/support/CPUInformation/CPUID.java.orig
 2008-04-23 15:24:19.0 +0800
 +++ freenet/src/freenet/support/CPUInformation/CPUID.java
 2008-05-16 10:35:55.0 +0800
 @@ -280,7 +280,10 @@
 }
 public boolean IsPentium4Compatible()
 {
 -   return getCPUFamily() = 15;
 +   int family = getCPUFamily();
 +   int model = getCPUModel();
 +   return (family = 15 ||
 +   (family == 6  (model == 9 || model
 =13)));
 }
 public String getCPUModelString() throws
 UnknownCPUException {
 if(getCPUFamily() == 4){
 /patch
 
 Cheers!
 
 --
 FMS:  [EMAIL PROTECTED]
 Freemail: [EMAIL PROTECTED]
 PGP fingerprint: 88B6 7F21 38E1 01E6 CF3E B1AD 31CC C1F2 B3FF A5B9
 
 
   End of signed message



 ___
 Devl mailing list
 Devl@freenetproject.org
 http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Florent Daignière 
* Florent Daignière [EMAIL PROTECTED] [2008-05-17 14:03:10]:

 * Matthew Toseland [EMAIL PROTECTED] [2008-05-17 12:29:09]:
 
  As nextgens is worried about anonymous contributions, I thought he might 
  want 
  to review this before I apply it.
  
 
 There is a related bug in the bug tracker... It's not the only bits that
 need updating :/
 
 See #74

http://download.intel.com/design/processor/applnots/24161832.pdf
http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf

Here are the CPUID codes if you want to update them.


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Matthew Toseland 
On Saturday 17 May 2008 13:58, Florent Daignière wrote:
 * Florent Daignière [EMAIL PROTECTED] [2008-05-17 14:03:10]:
 
  * Matthew Toseland [EMAIL PROTECTED] [2008-05-17 12:29:09]:
  
   As nextgens is worried about anonymous contributions, I thought he might 
want 
   to review this before I apply it.
   
  
  There is a related bug in the bug tracker... It's not the only bits that
  need updating :/
  
  See #74
 
 http://download.intel.com/design/processor/applnots/24161832.pdf
 
http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf
 
 Here are the CPUID codes if you want to update them.
 
So should we or shouldn't we apply yongjhen's patch?


pgpyCVWloqQTs.pgp
Description: PGP signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Ian Clarke 
On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
[EMAIL PROTECTED] wrote:
 As nextgens is worried about anonymous contributions, I thought he might want
 to review this before I apply it.

You know, I wish you guys would at least try using that Smartbear
software, this is *exactly* what it is designed for and makes
code-review much easier.

Ian.

-- 
Email: [EMAIL PROTECTED]
Cell: +1 512 422 3588
Skype: sanity
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Matthew Toseland 
On Saturday 17 May 2008 16:35, Ian Clarke wrote:
 On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
  As nextgens is worried about anonymous contributions, I thought he might 
want
  to review this before I apply it.
 
 You know, I wish you guys would at least try using that Smartbear
 software, this is *exactly* what it is designed for and makes
 code-review much easier.

I personally review all commits. Nextgens used to but doesn't have time any 
more... if a specific commit worries me I will forward it to him.
 
 Ian.


pgpBrXprC7cqe.pgp
Description: PGP signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Ian Clarke 
On Sat, May 17, 2008 at 12:53 PM, Matthew Toseland
[EMAIL PROTECTED] wrote:
 On Saturday 17 May 2008 16:35, Ian Clarke wrote:
 On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
  As nextgens is worried about anonymous contributions, I thought he might
 want
  to review this before I apply it.

 You know, I wish you guys would at least try using that Smartbear
 software, this is *exactly* what it is designed for and makes
 code-review much easier.

 I personally review all commits.

Who reviews your commits?  Perhaps if it were easier, someone would.

Ian.

-- 
Email: [EMAIL PROTECTED]
Cell: +1 512 422 3588
Skype: sanity
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Florent Daignière 
* Ian Clarke [EMAIL PROTECTED] [2008-05-17 20:43:17]:

 On Sat, May 17, 2008 at 12:53 PM, Matthew Toseland
 [EMAIL PROTECTED] wrote:
  On Saturday 17 May 2008 16:35, Ian Clarke wrote:
  On Sat, May 17, 2008 at 6:29 AM, Matthew Toseland
  [EMAIL PROTECTED] wrote:
   As nextgens is worried about anonymous contributions, I thought he might
  want
   to review this before I apply it.
 
  You know, I wish you guys would at least try using that Smartbear
  software, this is *exactly* what it is designed for and makes
  code-review much easier.
 
  I personally review all commits.
 
 Who reviews your commits?  Perhaps if it were easier, someone would.
 

Its a matter of time and will more than a tool-related problem afaic :/


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] CPUID patch from FMS

2008-05-17 Thread Florent Daignière 
* Matthew Toseland [EMAIL PROTECTED] [2008-05-17 14:44:27]:

 On Saturday 17 May 2008 13:58, Florent Daignière wrote:
  * Florent Daignière [EMAIL PROTECTED] [2008-05-17 14:03:10]:
  
   * Matthew Toseland [EMAIL PROTECTED] [2008-05-17 12:29:09]:
   
As nextgens is worried about anonymous contributions, I thought he 
might 
 want 
to review this before I apply it.

   
   There is a related bug in the bug tracker... It's not the only bits that
   need updating :/
   
   See #74
  
  http://download.intel.com/design/processor/applnots/24161832.pdf
  
 http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/25481.pdf
  
  Here are the CPUID codes if you want to update them.
  
 So should we or shouldn't we apply yongjhen's patch?

I think that applying that patch instead of updating the whole set of codes
is not the way to go...

If we were really after performances we would recompile the native
libraries with the new libgmp... which has performances boost on that
kind of (recent) processors.


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl