Re: r128 software features patch
Philipp Klaus Krause wrote: Since vertex program support was the main point of the patch, and the discussion has shown reasons not to add any vertex program support to the r128 I think that my patch should be ignored. I might create another one once Mesa implements vertex shaders. Well the discussion only inovlved two people :-). It's quite possible others might think it's worthwile, I'm certainly no authority on that. OTOH, I think EXT_multi_draw_arrays and ARB_vertex_buffer_object are quite reasonable to add. Roland --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Since vertex program support was the main point of the patch, and the discussion has shown reasons not to add any vertex program support to the r128 I think that my patch should be ignored. I might create another one once Mesa implements vertex shaders. Philipp --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Roland Scheidegger schrieb: > > btw it looks you can't announce ARB_vertex_program on r128. The > extension says not only based on OpenGL 1.3, but it requires OpenGL 1.3. I think that leaves two options 1) Don't add any vertex program stuff to the r128 driver. In that case the patch I posted should be ignored. Vertex program support should be removed from the mga and tdfx drivers, since they only support OpenGL 1.2. 2) Make GL_ARB_vertex_program support a configuration option that defaults to off. The same should be done with the mga and tdfx drivers. Philipp --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Philipp Klaus Krause wrote: In that sense, I'd consider NV_vertex_program as bloat just as well. Applications really always can deal with not available non-standard extensions very well. About GL_NV_vertex_program: 1) It was the first nice vertex program interface and is used in many old tutorials on vertex shading. 2) Currently Mesa layers GL_ARB_vertex_program on top of GL_NV_vertex_program. A driver that already advertizes GL_ARB_vertex_program can support GL_NV_vertex_program for free. Sure, but I hate unneeded driver complexity, even if it's just a single line, so it's not completely free :-). 3) It is a widespread extension, not a Nvidia-specific one: It is implemented by the i915 driver, the mga driver, the tdfx driver, the r300 driver, the non-free 3Dlabs drivers and of course all the Nvidia drivers. It's not completely limited to nvidia hardware, but it's still a non-standard extension. If you look at commercial drivers (www.delphi3d.net), support is indeed pretty much limited to nvidia hardware, the only other company to support it is 3dlabs - no ATI, no intel, no matrox, nothing. That is quite nvidia-specific if you ask me. 4) I added an option to deactivate it. Makes the driver even more complex :-). btw it looks you can't announce ARB_vertex_program on r128. The extension says not only based on OpenGL 1.3, but it requires OpenGL 1.3. Not sure why exactly, there doesn't seem to be anything in the new features of OpenGL 1.3 which seems to be related to vertices (safe maybe multitexturing, or maybe matrix transpose, I didn't study the extension to see if you could do it with 1.2 + multitexture). NV_vertex_program requires only 1.2.1 though. Roland --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
> In that sense, I'd consider NV_vertex_program as bloat just as well. > Applications really always can deal with not available non-standard > extensions very well. About GL_NV_vertex_program: 1) It was the first nice vertex program interface and is used in many old tutorials on vertex shading. 2) Currently Mesa layers GL_ARB_vertex_program on top of GL_NV_vertex_program. A driver that already advertizes GL_ARB_vertex_program can support GL_NV_vertex_program for free. 3) It is a widespread extension, not a Nvidia-specific one: It is implemented by the i915 driver, the mga driver, the tdfx driver, the r300 driver, the non-free 3Dlabs drivers and of course all the Nvidia drivers. 4) I added an option to deactivate it. Philipp --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Philipp Klaus Krause wrote: Stephane Marchesin schrieb: What is the point of advertising GL_MESA_pack_invert if it's not implemented ? Stephane According to extensions specification this extension's main purpose seems to be making application developers life a little bit easier, just like GL_MESA_window_pos/GL_ARB_window_pos does, not exposing hardware features. So I thought it might be useful to advertize this one. The i915 driver does the same. The intel driver actually uses it however - if you set that PACK_INVERT parameter the driver will do optimized pixel reads (i.e. direct blits). I don't see much point in advertizing vendor-speficic extensions if the hardware doesn't support it natively (that's not to say the r128 wouldn't support GL_MESA_pack_invert in hardware, but you'd need to implement optimized pixel readback functions to take advantage of it). In that sense, I'd consider NV_vertex_program as bloat just as well. Applications really always can deal with not available non-standard extensions very well. There's some point for adding the ARB (and EXT) extensions, though actually ARB_vertex_program doesn't come for free. Vertex programs are slow currently, so if an app would use a fixed-function fallback it would likely be faster. Though of course not everything possible with ARB_vertex_program can be done with fixed function... (and in theory vertex programs could be just as fast as fixed function when done in software, it's just currently not the case with mesa). Roland --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 2188] radeon dri driver: q-coord texgen causes an unnecessary fallback
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=2188 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-10-08 09:52 --- this should be fixed with https://bugs.freedesktop.org/show_bug.cgi?id=4499 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 2241] implement GL_ARB_texture_cube_map in radeon driver
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=2241 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #3164 is|0 |1 obsolete|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 2241] implement GL_ARB_texture_cube_map in radeon driver
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=2241 --- Additional Comments From [EMAIL PROTECTED] 2005-10-08 09:46 --- Created an attachment (id=3515) --> (https://bugs.freedesktop.org/attachment.cgi?id=3515&action=view) mesa_radeon_cubemap_3tmu_20051008.diff.txt here is another update, I changed the emit code in radeon_swtcl.d a bit to emit the q-coord always if more than 2 texture-coords are available. Since Roland added texgen for q-coord, cubemap demo also works with hw-tcl. Unfortunately ut2003_demo looks better with tcl_mode=0, especially the reflections on water. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Philipp Klaus Krause wrote: Stephane Marchesin schrieb: What is the point of advertising GL_MESA_pack_invert if it's not implemented ? Stephane According to extensions specification this extension's main purpose seems to be making application developers life a little bit easier, just like GL_MESA_window_pos/GL_ARB_window_pos does, not exposing hardware features. So I thought it might be useful to advertize this one. The i915 driver does the same. No, the intel driver implements it. Stephane --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Stephane Marchesin schrieb: > > What is the point of advertising GL_MESA_pack_invert if it's not > implemented ? > > Stephane > According to extensions specification this extension's main purpose seems to be making application developers life a little bit easier, just like GL_MESA_window_pos/GL_ARB_window_pos does, not exposing hardware features. So I thought it might be useful to advertize this one. The i915 driver does the same. Philipp --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: r128 software features patch
Philipp Klaus Krause wrote: I hvae removed GL_EXT_cull_vertex from my patch, since Brian wants to remove it from Mesa, too. Since the r128 doesn't have hardware tcl all interesting features of Mesa's software tcl should be exposed. This patch adds support for GL_ARB_vertex_buffer_object, GL_ARB_vertex_program, GL_EXT_multi_draw_arrays, GL_MESA_pack_invert, What is the point of advertising GL_MESA_pack_invert if it's not implemented ? Stephane --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 4622] gamma_state.c:1593: warning: array subscript out of range
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=4622 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-10-08 08:04 --- This was fixed in Mesa CVS a while back. The fix will be in Mesa 6.4 and the next X.org release. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
The r128 software features path
Sorry, I forgot to include tha patch.
? depend
? r128_software.patch
Index: r128_context.c
===
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/r128/r128_context.c,v
retrieving revision 1.19
diff -u -r1.19 r128_context.c
--- r128_context.c 28 Jul 2005 00:29:52 - 1.19
+++ r128_context.c 8 Oct 2005 12:08:47 -
@@ -68,7 +68,11 @@
#define need_GL_ARB_multisample
#define need_GL_ARB_texture_compression
+#define need_GL_ARB_vertex_buffer_object
+#define need_GL_ARB_vertex_program
#define need_GL_EXT_blend_minmax
+#define need_GL_EXT_multi_draw_arrays
+#define need_GL_NV_vertex_program
#include "extension_helper.h"
const struct dri_extension card_extensions[] =
@@ -78,14 +82,25 @@
{ "GL_ARB_texture_compression",GL_ARB_texture_compression_functions },
{ "GL_ARB_texture_env_add",NULL },
{ "GL_ARB_texture_mirrored_repeat",NULL },
+{ "GL_ARB_vertex_buffer_object", GL_ARB_vertex_buffer_object_functions },
+{ "GL_ARB_vertex_program", GL_ARB_vertex_program_functions },
{ "GL_EXT_blend_subtract", GL_EXT_blend_minmax_functions },
+{ "GL_EXT_multi_draw_arrays", GL_EXT_multi_draw_arrays_functions },
{ "GL_EXT_texture_edge_clamp", NULL },
+{ "GL_MESA_pack_invert", NULL },
{ "GL_MESA_ycbcr_texture", NULL },
{ "GL_NV_blend_square",NULL },
{ "GL_SGIS_generate_mipmap", NULL },
{ NULL,NULL }
};
+const struct dri_extension NV_vp_extensions[] = {
+{ "GL_NV_vertex_program", GL_NV_vertex_program_functions },
+{ "GL_NV_vertex_program1_1", NULL },
+{ NULL,NULL }
+};
+
+
static const struct dri_debug_control debug_control[] =
{
{ "ioctl", DEBUG_VERBOSE_IOCTL },
@@ -248,6 +263,8 @@
driInitExtensions( ctx, card_extensions, GL_TRUE );
if (sPriv->drmMinor >= 4)
_mesa_enable_extension( ctx, "GL_MESA_ycbcr_texture" );
+ if(driQueryOptionb(&rmesa->optionCache, "nv_vertex_program"))
+ driInitExtensions( ctx, NV_vp_extensions, GL_FALSE );
r128InitTriFuncs( ctx );
r128DDInitStateFuncs( ctx );
Index: r128_dd.c
===
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/r128/r128_dd.c,v
retrieving revision 1.5
diff -u -r1.5 r128_dd.c
--- r128_dd.c 4 May 2005 20:11:38 - 1.5
+++ r128_dd.c 8 Oct 2005 12:08:47 -
@@ -44,7 +44,7 @@
#include "utils.h"
-#define DRIVER_DATE "20041026"
+#define DRIVER_DATE "20051008"
/* Return the width and height of the current color buffer.
Index: r128_screen.c
===
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/r128/r128_screen.c,v
retrieving revision 1.24
diff -u -r1.24 r128_screen.c
--- r128_screen.c 4 Sep 2005 22:13:43 - 1.24
+++ r128_screen.c 8 Oct 2005 12:08:48 -
@@ -68,11 +68,14 @@
DRI_CONF_PERFORMANCE_BOXES(false)
#endif
DRI_CONF_SECTION_END
+DRI_CONF_SECTION_SOFTWARE
+DRI_CONF_NV_VERTEX_PROGRAM(true)
+DRI_CONF_SECTION_END
DRI_CONF_END;
#if ENABLE_PERF_BOXES
-static const GLuint __driNConfigOptions = 4;
+static const GLuint __driNConfigOptions = 5;
#else
-static const GLuint __driNConfigOptions = 3;
+static const GLuint __driNConfigOptions = 4;
#endif
extern const struct dri_extension card_extensions[];
r128 software features patch
I hvae removed GL_EXT_cull_vertex from my patch, since Brian wants to remove it from Mesa, too. Since the r128 doesn't have hardware tcl all interesting features of Mesa's software tcl should be exposed. This patch adds support for GL_ARB_vertex_buffer_object, GL_ARB_vertex_program, GL_EXT_multi_draw_arrays, GL_MESA_pack_invert, GL_NV_vertex_program, GL_NV_vertex_program1_1. For the last two a configuration option has been added. I have tested using the programs in Mesa/progs/tests. They seem to behave just like on i915, that means everything works expect vptest1 and vptest2, where assertions fail. Philipp --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
