Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

this method of setting transparency breaks on focus changes because of the
unset comp focus-in color class. I dicked around with it a bit to see if I
could get it to work a bit better, but no dice. going to need to figure out
a better way of clipping this I guess

On Fri, Feb 22, 2013 at 9:49 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> set initial window opacity to max
>
> Author:   discomfitor
> Date: 2013-02-22 01:49:51 -0800 (Fri, 22 Feb 2013)
> New Revision: 84305
> Trac: http://trac.enlightenment.org/e/changeset/84305
>
> Modified:
>   trunk/e/src/bin/e_border.c
>
> Modified: trunk/e/src/bin/e_border.c
> ===
> --- trunk/e/src/bin/e_border.c  2013-02-22 09:46:20 UTC (rev 84304)
> +++ trunk/e/src/bin/e_border.c  2013-02-22 09:49:51 UTC (rev 84305)
> @@ -539,6 +539,7 @@
> bd->client.netwm.action.fullscreen = 0;
> bd->client.netwm.action.change_desktop = 0;
> bd->client.netwm.action.close = 0;
> +   bd->client.netwm.opacity = 255;
> bd->client.netwm.type = ECORE_X_WINDOW_TYPE_UNKNOWN;
>
> {
>
>
>
> --
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_feb
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[The Rasterman]

On Thu, 27 Dec 2012 08:38:17 +0100 Vincent Torri  said:

> if e trunk is for e18 and if e18 will use elm, why is elm optional ?

right now elm is optional because nothing in e17 even uses it yet... when it
does - it will change. nothing is going to use it.. until elm's theme is
adapted to look like e17... so it's a while yet until that happens. no need to
hurry that up.

> On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
>  wrote:
> > Log:
> > if using elm, include globally for e
> >
> >
> > Author:   discomfitor
> > Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
> > New Revision: 81732
> > Trac: http://trac.enlightenment.org/e/changeset/81732
> >
> > Modified:
> >   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
> >
> > Modified: trunk/e/src/bin/e_includes.h
> > ===
> > --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev 81731)
> > +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev 81732)
> > @@ -147,3 +147,6 @@
> >  #include "e_import_config_dialog.h"
> >  #include "e_grab_dialog.h"
> >  #include "e_widget_filepreview.h"
> > +#ifdef HAVE_ELEMENTARY
> > +# include 
> > +#endif
> >
> > Modified: trunk/e/src/bin/e_win.c
> > ===
> > --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
> > +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
> > @@ -15,8 +15,6 @@
> >  #ifdef HAVE_ELEMENTARY
> >  /* intercept elm_win operations so we talk directly to e_border */
> >
> > -#include 
> > -
> >  typedef struct _Elm_Win_Trap_Ctx
> >  {
> > E_Border *border;
> >
> >
> > --
> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > MVPs and experts. ON SALE this month only -- learn more at:
> > http://p.sf.net/sfu/learnmore_122712
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> 
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[The Rasterman]

On Thu, 27 Dec 2012 08:55:30 + Michael Blumenkrantz
 said:

currently i am not sure this is warranted. any "current start" of e17 in svn
should be totally buildable and workable any any stage... so any moving of
stuff around or work at least for the next few weeks/months is going to be
"branched inline" (ie runtime or compile-time optional new feature until "it
works")... so any release should be doable with ease... :)

> imo it would be nice (and is necessary) to be able to make quick releases
> with fixes for critical bugs, such as crashes. to do this, we can use the
> branch. all other development can just be done in trunk
> 
> On Thu, Dec 27, 2012 at 8:49 AM, Vincent Torri wrote:
> 
> > On Thu, Dec 27, 2012 at 9:38 AM, Daniel Juyung Seo 
> > wrote:
> > > As far as I know e trunk is not for e18, e17 will do a rolling release
> > > according to what we talked on the mailing list a couple of days ago.
> > > e17.0 branch is just for the bug fix release.
> >
> > strange. A program is not a library. I can understand that branch and
> > trunk are necessary for a library, as it can be used by programs, but
> > i am wondering what will be the interest of doing e17 development in
> > trunk as it can be done in the e17 branch(es). Adding fonctionalities
> > for a program have not the same impact than for a library.
> >
> > Vincent
> >
> > >
> > > Daniel Juyung Seo (SeoZ)
> > >
> > > On Thu, Dec 27, 2012 at 4:38 PM, Vincent Torri  > >wrote:
> > >
> > >> if e trunk is for e18 and if e18 will use elm, why is elm optional ?
> > >>
> > >> On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
> > >>  wrote:
> > >> > Log:
> > >> > if using elm, include globally for e
> > >> >
> > >> >
> > >> > Author:   discomfitor
> > >> > Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
> > >> > New Revision: 81732
> > >> > Trac: http://trac.enlightenment.org/e/changeset/81732
> > >> >
> > >> > Modified:
> > >> >   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
> > >> >
> > >> > Modified: trunk/e/src/bin/e_includes.h
> > >> > ===
> > >> > --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev
> > >> 81731)
> > >> > +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev
> > >> 81732)
> > >> > @@ -147,3 +147,6 @@
> > >> >  #include "e_import_config_dialog.h"
> > >> >  #include "e_grab_dialog.h"
> > >> >  #include "e_widget_filepreview.h"
> > >> > +#ifdef HAVE_ELEMENTARY
> > >> > +# include 
> > >> > +#endif
> > >> >
> > >> > Modified: trunk/e/src/bin/e_win.c
> > >> > ===
> > >> > --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
> > >> > +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
> > >> > @@ -15,8 +15,6 @@
> > >> >  #ifdef HAVE_ELEMENTARY
> > >> >  /* intercept elm_win operations so we talk directly to e_border */
> > >> >
> > >> > -#include 
> > >> > -
> > >> >  typedef struct _Elm_Win_Trap_Ctx
> > >> >  {
> > >> > E_Border *border;
> > >> >
> > >> >
> > >> >
> > >>
> > --
> > >> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > >> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills
> > current
> > >> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > >> > MVPs and experts. ON SALE this month only -- learn more at:
> > >> > http://p.sf.net/sfu/learnmore_122712
> > >> > ___
> > >> > enlightenment-svn mailing list
> > >> > enlightenment-...@lists.sourceforge.net
> > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> > >>
> > >>
> > >>
> > --
> > >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > >> MVPs and experts. ON SALE this month only -- learn more at:
> > >> http://p.sf.net/sfu/learnmore_122712
> > >> ___
> > >> enlightenment-devel mailing list
> > >> enlightenment-devel@lists.sourceforge.net
> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >>
> > >
> > --
> > > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > > MVPs and experts. ON SALE this month only -- learn more at:
> > > http://p.sf.net/sfu/learnmore_122712
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourcef

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

imo it would be nice (and is necessary) to be able to make quick releases
with fixes for critical bugs, such as crashes. to do this, we can use the
branch. all other development can just be done in trunk

On Thu, Dec 27, 2012 at 8:49 AM, Vincent Torri wrote:

> On Thu, Dec 27, 2012 at 9:38 AM, Daniel Juyung Seo 
> wrote:
> > As far as I know e trunk is not for e18, e17 will do a rolling release
> > according to what we talked on the mailing list a couple of days ago.
> > e17.0 branch is just for the bug fix release.
>
> strange. A program is not a library. I can understand that branch and
> trunk are necessary for a library, as it can be used by programs, but
> i am wondering what will be the interest of doing e17 development in
> trunk as it can be done in the e17 branch(es). Adding fonctionalities
> for a program have not the same impact than for a library.
>
> Vincent
>
> >
> > Daniel Juyung Seo (SeoZ)
> >
> > On Thu, Dec 27, 2012 at 4:38 PM, Vincent Torri  >wrote:
> >
> >> if e trunk is for e18 and if e18 will use elm, why is elm optional ?
> >>
> >> On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
> >>  wrote:
> >> > Log:
> >> > if using elm, include globally for e
> >> >
> >> >
> >> > Author:   discomfitor
> >> > Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
> >> > New Revision: 81732
> >> > Trac: http://trac.enlightenment.org/e/changeset/81732
> >> >
> >> > Modified:
> >> >   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
> >> >
> >> > Modified: trunk/e/src/bin/e_includes.h
> >> > ===
> >> > --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev
> >> 81731)
> >> > +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev
> >> 81732)
> >> > @@ -147,3 +147,6 @@
> >> >  #include "e_import_config_dialog.h"
> >> >  #include "e_grab_dialog.h"
> >> >  #include "e_widget_filepreview.h"
> >> > +#ifdef HAVE_ELEMENTARY
> >> > +# include 
> >> > +#endif
> >> >
> >> > Modified: trunk/e/src/bin/e_win.c
> >> > ===
> >> > --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
> >> > +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
> >> > @@ -15,8 +15,6 @@
> >> >  #ifdef HAVE_ELEMENTARY
> >> >  /* intercept elm_win operations so we talk directly to e_border */
> >> >
> >> > -#include 
> >> > -
> >> >  typedef struct _Elm_Win_Trap_Ctx
> >> >  {
> >> > E_Border *border;
> >> >
> >> >
> >> >
> >>
> --
> >> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> >> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills
> current
> >> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> >> > MVPs and experts. ON SALE this month only -- learn more at:
> >> > http://p.sf.net/sfu/learnmore_122712
> >> > ___
> >> > enlightenment-svn mailing list
> >> > enlightenment-...@lists.sourceforge.net
> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >>
> >>
> >>
> --
> >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> >> MVPs and experts. ON SALE this month only -- learn more at:
> >> http://p.sf.net/sfu/learnmore_122712
> >> ___
> >> enlightenment-devel mailing list
> >> enlightenment-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >>
> >
> --
> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > MVPs and experts. ON SALE this month only -- learn more at:
> > http://p.sf.net/sfu/learnmore_122712
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

On Thu, Dec 27, 2012 at 9:38 AM, Daniel Juyung Seo  wrote:
> As far as I know e trunk is not for e18, e17 will do a rolling release
> according to what we talked on the mailing list a couple of days ago.
> e17.0 branch is just for the bug fix release.

strange. A program is not a library. I can understand that branch and
trunk are necessary for a library, as it can be used by programs, but
i am wondering what will be the interest of doing e17 development in
trunk as it can be done in the e17 branch(es). Adding fonctionalities
for a program have not the same impact than for a library.

Vincent

>
> Daniel Juyung Seo (SeoZ)
>
> On Thu, Dec 27, 2012 at 4:38 PM, Vincent Torri wrote:
>
>> if e trunk is for e18 and if e18 will use elm, why is elm optional ?
>>
>> On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
>>  wrote:
>> > Log:
>> > if using elm, include globally for e
>> >
>> >
>> > Author:   discomfitor
>> > Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
>> > New Revision: 81732
>> > Trac: http://trac.enlightenment.org/e/changeset/81732
>> >
>> > Modified:
>> >   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
>> >
>> > Modified: trunk/e/src/bin/e_includes.h
>> > ===
>> > --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev
>> 81731)
>> > +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev
>> 81732)
>> > @@ -147,3 +147,6 @@
>> >  #include "e_import_config_dialog.h"
>> >  #include "e_grab_dialog.h"
>> >  #include "e_widget_filepreview.h"
>> > +#ifdef HAVE_ELEMENTARY
>> > +# include 
>> > +#endif
>> >
>> > Modified: trunk/e/src/bin/e_win.c
>> > ===
>> > --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
>> > +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
>> > @@ -15,8 +15,6 @@
>> >  #ifdef HAVE_ELEMENTARY
>> >  /* intercept elm_win operations so we talk directly to e_border */
>> >
>> > -#include 
>> > -
>> >  typedef struct _Elm_Win_Trap_Ctx
>> >  {
>> > E_Border *border;
>> >
>> >
>> >
>> --
>> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
>> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
>> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
>> > MVPs and experts. ON SALE this month only -- learn more at:
>> > http://p.sf.net/sfu/learnmore_122712
>> > ___
>> > enlightenment-svn mailing list
>> > enlightenment-...@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>>
>>
>> --
>> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
>> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
>> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
>> MVPs and experts. ON SALE this month only -- learn more at:
>> http://p.sf.net/sfu/learnmore_122712
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Daniel Juyung Seo]

As far as I know e trunk is not for e18, e17 will do a rolling release
according to what we talked on the mailing list a couple of days ago.
e17.0 branch is just for the bug fix release.

Daniel Juyung Seo (SeoZ)

On Thu, Dec 27, 2012 at 4:38 PM, Vincent Torri wrote:

> if e trunk is for e18 and if e18 will use elm, why is elm optional ?
>
> On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
>  wrote:
> > Log:
> > if using elm, include globally for e
> >
> >
> > Author:   discomfitor
> > Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
> > New Revision: 81732
> > Trac: http://trac.enlightenment.org/e/changeset/81732
> >
> > Modified:
> >   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
> >
> > Modified: trunk/e/src/bin/e_includes.h
> > ===
> > --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev
> 81731)
> > +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev
> 81732)
> > @@ -147,3 +147,6 @@
> >  #include "e_import_config_dialog.h"
> >  #include "e_grab_dialog.h"
> >  #include "e_widget_filepreview.h"
> > +#ifdef HAVE_ELEMENTARY
> > +# include 
> > +#endif
> >
> > Modified: trunk/e/src/bin/e_win.c
> > ===
> > --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
> > +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
> > @@ -15,8 +15,6 @@
> >  #ifdef HAVE_ELEMENTARY
> >  /* intercept elm_win operations so we talk directly to e_border */
> >
> > -#include 
> > -
> >  typedef struct _Elm_Win_Trap_Ctx
> >  {
> > E_Border *border;
> >
> >
> >
> --
> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > MVPs and experts. ON SALE this month only -- learn more at:
> > http://p.sf.net/sfu/learnmore_122712
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

I have no idea.

On Thu, Dec 27, 2012 at 7:38 AM, Vincent Torri wrote:

> if e trunk is for e18 and if e18 will use elm, why is elm optional ?
>
> On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
>  wrote:
> > Log:
> > if using elm, include globally for e
> >
> >
> > Author:   discomfitor
> > Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
> > New Revision: 81732
> > Trac: http://trac.enlightenment.org/e/changeset/81732
> >
> > Modified:
> >   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
> >
> > Modified: trunk/e/src/bin/e_includes.h
> > ===
> > --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev
> 81731)
> > +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev
> 81732)
> > @@ -147,3 +147,6 @@
> >  #include "e_import_config_dialog.h"
> >  #include "e_grab_dialog.h"
> >  #include "e_widget_filepreview.h"
> > +#ifdef HAVE_ELEMENTARY
> > +# include 
> > +#endif
> >
> > Modified: trunk/e/src/bin/e_win.c
> > ===
> > --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
> > +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
> > @@ -15,8 +15,6 @@
> >  #ifdef HAVE_ELEMENTARY
> >  /* intercept elm_win operations so we talk directly to e_border */
> >
> > -#include 
> > -
> >  typedef struct _Elm_Win_Trap_Ctx
> >  {
> > E_Border *border;
> >
> >
> >
> --
> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > MVPs and experts. ON SALE this month only -- learn more at:
> > http://p.sf.net/sfu/learnmore_122712
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

if e trunk is for e18 and if e18 will use elm, why is elm optional ?

On Thu, Dec 27, 2012 at 8:27 AM, Enlightenment SVN
 wrote:
> Log:
> if using elm, include globally for e
>
>
> Author:   discomfitor
> Date: 2012-12-26 23:27:12 -0800 (Wed, 26 Dec 2012)
> New Revision: 81732
> Trac: http://trac.enlightenment.org/e/changeset/81732
>
> Modified:
>   trunk/e/src/bin/e_includes.h trunk/e/src/bin/e_win.c
>
> Modified: trunk/e/src/bin/e_includes.h
> ===
> --- trunk/e/src/bin/e_includes.h2012-12-27 06:46:29 UTC (rev 81731)
> +++ trunk/e/src/bin/e_includes.h2012-12-27 07:27:12 UTC (rev 81732)
> @@ -147,3 +147,6 @@
>  #include "e_import_config_dialog.h"
>  #include "e_grab_dialog.h"
>  #include "e_widget_filepreview.h"
> +#ifdef HAVE_ELEMENTARY
> +# include 
> +#endif
>
> Modified: trunk/e/src/bin/e_win.c
> ===
> --- trunk/e/src/bin/e_win.c 2012-12-27 06:46:29 UTC (rev 81731)
> +++ trunk/e/src/bin/e_win.c 2012-12-27 07:27:12 UTC (rev 81732)
> @@ -15,8 +15,6 @@
>  #ifdef HAVE_ELEMENTARY
>  /* intercept elm_win operations so we talk directly to e_border */
>
> -#include 
> -
>  typedef struct _Elm_Win_Trap_Ctx
>  {
> E_Border *border;
>
>
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122712
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Tue, Dec 18, 2012 at 12:10 PM, Gustavo Sverzut Barbieri <
barbi...@profusion.mobi> wrote:

> On Tue, Dec 18, 2012 at 10:01 AM, Enlightenment SVN <
> no-re...@enlightenment.org> wrote:
>
> > Log:
> > apparently efreet_menu_get() uses timers and such for some reason, sigh.
> > back to threadless we go for this
> >
> >
> ha ha (nelson style). Told you shit could happen with that ;-)
>

hilarious, but completely unrelated to anything you said; just annoying
getting all the error spam


>
> efreet should support a threaded version itself, with an async
> event/callback when its ready.. but that would be 1.8 and thus next E
> release.
>

definitely, though at this point it seems to only be this one function that
doesn't work with threads :/


>
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
> --
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Gustavo Sverzut Barbieri]

On Tue, Dec 18, 2012 at 10:01 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> apparently efreet_menu_get() uses timers and such for some reason, sigh.
> back to threadless we go for this
>
>
ha ha (nelson style). Told you shit could happen with that ;-)

efreet should support a threaded version itself, with an async
event/callback when its ready.. but that would be 1.8 and thus next E
release.



-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

forwarding to list for common interest...

On Tue, Nov 13, 2012 at 7:46 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> by popular (overwhelming) demand,
> -i-really-know-what-i-am-doing-and-accept-full-responsibility-for-it now
> prevents enlightenment_start from ptracing, which allows gdb attaching once
> more
>
>
> Author:   discomfitor
> Date: 2012-11-12 23:46:02 -0800 (Mon, 12 Nov 2012)
> New Revision: 79202
> Trac: http://trac.enlightenment.org/e/changeset/79202
>
> Modified:
>   trunk/e/src/bin/e_start_main.c
>
> Modified: trunk/e/src/bin/e_start_main.c
> ===
> --- trunk/e/src/bin/e_start_main.c  2012-11-13 06:52:52 UTC (rev 79201)
> +++ trunk/e/src/bin/e_start_main.c  2012-11-13 07:46:02 UTC (rev 79202)
> @@ -417,8 +417,9 @@
>  else if (child == 0)
>{
>  #ifdef HAVE_SYS_PTRACE_H
> - /* in the child */
> - ptrace(PT_TRACE_ME, 0, NULL, NULL);
> + if (!really_know)
> +   /* in the child */
> +   ptrace(PT_TRACE_ME, 0, NULL, NULL);
>  #endif
>   execv(args[0], args);
>   return 0; /* We failed, 0 mean normal exit from E with no
> restart or crash so let exit */
> @@ -431,11 +432,12 @@
>   int status;
>   Eina_Bool done = EINA_FALSE;
>  #ifdef HAVE_SYS_PTRACE_H
> - ptrace(PT_ATTACH, child, NULL, NULL);
> + if (!really_know)
> +   ptrace(PT_ATTACH, child, NULL, NULL);
>  #endif
>   result = waitpid(child, &status, 0);
>  #ifdef HAVE_SYS_PTRACE_H
> - if (!stop_ptrace)
> + if ((!really_know) && (!stop_ptrace))
> {
>if (WIFSTOPPED(status))
>  ptrace(PT_CONTINUE, child, NULL, NULL);
> @@ -459,7 +461,8 @@
>  int back;
>
>  #ifdef HAVE_SYS_PTRACE_H
> -r = ptrace(PTRACE_GETSIGINFO, child, NULL,
> &sig);
> +   if (!really_know)
> + r = ptrace(PTRACE_GETSIGINFO, child, NULL,
> &sig);
>  #endif
>  back = r == 0 &&
>sig.si_signo != SIGTRAP ? sig.si_signo : 0;
> @@ -485,13 +488,15 @@
>   sig.si_signo != SIGABRT))
>{
>  #ifdef HAVE_SYS_PTRACE_H
> - ptrace(PT_CONTINUE, child, NULL, back);
> + if (!really_know)
> +   ptrace(PT_CONTINUE, child, NULL, back);
>  #endif
>   continue ;
>}
>  #ifdef HAVE_SYS_PTRACE_H
> -/* E17 should be in pause, we can detach */
> -ptrace(PT_DETACH, child, NULL, back);
> +if (!really_know)
> +  /* E17 should be in pause, we can detach */
> +  ptrace(PT_DETACH, child, NULL, back);
>  #endif
>  /* And call gdb if available */
>  if (home)
> @@ -554,7 +559,8 @@
>   kill(child, SIGSTOP);
>   usleep(20);
>  #ifdef HAVE_SYS_PTRACE_H
> - ptrace(PT_DETACH, child, NULL, NULL);
> + if (!really_know)
> +   ptrace(PT_DETACH, child, NULL, NULL);
>  #endif
>}
>   }
>
>
>
> --
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

yep, was a typo on my part

On Mon, Nov 12, 2012 at 1:12 PM, Gustavo Sverzut Barbieri <
barbi...@profusion.mobi> wrote:

> I mean, if you have the "=" in the define, it will be placed everywhere
> that the symbol is used, so if you have
>
> if (x == XCB_ATOM_NONE)
>
> if will expand like: if (x == = 0)
>
>
> On Mon, Nov 12, 2012 at 11:10 AM, Christopher Michael <
> cp.mich...@samsung.com> wrote:
>
> > On 12/11/12 13:04, Gustavo Sverzut Barbieri wrote:
> >
> >> = 0? are you sure?
> >>
> >>
> >> On Mon, Nov 12, 2012 at 11:02 AM, Enlightenment SVN <
> >> no-re...@enlightenment.org> wrote:
> >>
> >>  Log:
> >>> define XCB_ATOM_NONE if not defined because opensuse sucks
> >>>ticket #1722
> >>>this commit brought to you by the recipient of the 2012 E-Devel
> >>> "Hater"
> >>> award
> >>>
> >>>
> >>> Author:   discomfitor
> >>> Date: 2012-11-12 05:02:12 -0800 (Mon, 12 Nov 2012)
> >>> New Revision: 79157
> >>> Trac: http://trac.enlightenment.org/**e/changeset/79157<
> http://trac.enlightenment.org/e/changeset/79157>
> >>>
> >>> Modified:
> >>>trunk/e/src/bin/e_alert_main.c
> >>>
> >>> Modified: trunk/e/src/bin/e_alert_main.c
> >>> ==**==**===
> >>> --- trunk/e/src/bin/e_alert_main.c  2012-11-12 12:56:21 UTC (rev
> >>> 79156)
> >>> +++ trunk/e/src/bin/e_alert_main.c  2012-11-12 13:02:12 UTC (rev
> >>> 79157)
> >>> @@ -19,6 +19,10 @@
> >>>   #define WINDOW_WIDTH 320
> >>>   #define WINDOW_HEIGHT 240
> >>>
> >>> +#ifndef XCB_ATOM_NONE
> >>> +# define XCB_ATOM_NONE = 0
> >>> +#endif
> >>> +
> >>>   /* local function prototypes */
> >>>   static int _e_alert_connect(void);
> >>>   static void _e_alert_create(void);
> >>>
> >>>
> >>>
> >>>
> > /usr/include/xcb/xproto.h: 1007
> >
> > typedef enum xcb_atom_enum_t {
> > XCB_ATOM_NONE = 0,
> > XCB_ATOM_ANY = 0,
> > XCB_ATOM_PRIMARY,
> > XCB_ATOM_SECONDARY,
> > XCB_ATOM_ARC,
> > XCB_ATOM_ATOM,
> >
> > So ... no I am not really sure. Perhaps it should be something else ??
> >
> > dh
> >
> >
> >
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
> --
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Chris Michael]

Ohhh lol  sorry about that, fat finger copy-paste L

 

I thought you were questioning if Zero is the proper value.

 

Dh

 

 

From: Gustavo Sverzut Barbieri [mailto:barbi...@profusion.mobi] 
Sent: 12 November 2012 01:13 PM
To: Christopher Michael
Cc: Enlightenment developer list
Subject: Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

 

I mean, if you have the "=" in the define, it will be placed everywhere that 
the symbol is used, so if you have

 

if (x == XCB_ATOM_NONE)

 

if will expand like: if (x == = 0)

 

On Mon, Nov 12, 2012 at 11:10 AM, Christopher Michael  
wrote:

On 12/11/12 13:04, Gustavo Sverzut Barbieri wrote:

= 0? are you sure?


On Mon, Nov 12, 2012 at 11:02 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

Log:
define XCB_ATOM_NONE if not defined because opensuse sucks
   ticket #1722
   this commit brought to you by the recipient of the 2012 E-Devel "Hater"
award


Author:   discomfitor
Date: 2012-11-12 05:02:12 -0800 (Mon, 12 Nov 2012)
New Revision: 79157
Trac: http://trac.enlightenment.org/e/changeset/79157

Modified:
   trunk/e/src/bin/e_alert_main.c

Modified: trunk/e/src/bin/e_alert_main.c
===
--- trunk/e/src/bin/e_alert_main.c  2012-11-12 12:56:21 UTC (rev 79156)
+++ trunk/e/src/bin/e_alert_main.c  2012-11-12 13:02:12 UTC (rev 79157)
@@ -19,6 +19,10 @@
  #define WINDOW_WIDTH 320
  #define WINDOW_HEIGHT 240

+#ifndef XCB_ATOM_NONE
+# define XCB_ATOM_NONE = 0
+#endif
+
  /* local function prototypes */
  static int _e_alert_connect(void);
  static void _e_alert_create(void);




 

/usr/include/xcb/xproto.h: 1007

typedef enum xcb_atom_enum_t {
XCB_ATOM_NONE = 0,
XCB_ATOM_ANY = 0,
XCB_ATOM_PRIMARY,
XCB_ATOM_SECONDARY,
XCB_ATOM_ARC,
XCB_ATOM_ATOM,

So ... no I am not really sure. Perhaps it should be something else ??

dh







 

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Gustavo Sverzut Barbieri]

I mean, if you have the "=" in the define, it will be placed everywhere
that the symbol is used, so if you have

if (x == XCB_ATOM_NONE)

if will expand like: if (x == = 0)


On Mon, Nov 12, 2012 at 11:10 AM, Christopher Michael <
cp.mich...@samsung.com> wrote:

> On 12/11/12 13:04, Gustavo Sverzut Barbieri wrote:
>
>> = 0? are you sure?
>>
>>
>> On Mon, Nov 12, 2012 at 11:02 AM, Enlightenment SVN <
>> no-re...@enlightenment.org> wrote:
>>
>>  Log:
>>> define XCB_ATOM_NONE if not defined because opensuse sucks
>>>ticket #1722
>>>this commit brought to you by the recipient of the 2012 E-Devel
>>> "Hater"
>>> award
>>>
>>>
>>> Author:   discomfitor
>>> Date: 2012-11-12 05:02:12 -0800 (Mon, 12 Nov 2012)
>>> New Revision: 79157
>>> Trac: 
>>> http://trac.enlightenment.org/**e/changeset/79157
>>>
>>> Modified:
>>>trunk/e/src/bin/e_alert_main.c
>>>
>>> Modified: trunk/e/src/bin/e_alert_main.c
>>> ==**==**===
>>> --- trunk/e/src/bin/e_alert_main.c  2012-11-12 12:56:21 UTC (rev
>>> 79156)
>>> +++ trunk/e/src/bin/e_alert_main.c  2012-11-12 13:02:12 UTC (rev
>>> 79157)
>>> @@ -19,6 +19,10 @@
>>>   #define WINDOW_WIDTH 320
>>>   #define WINDOW_HEIGHT 240
>>>
>>> +#ifndef XCB_ATOM_NONE
>>> +# define XCB_ATOM_NONE = 0
>>> +#endif
>>> +
>>>   /* local function prototypes */
>>>   static int _e_alert_connect(void);
>>>   static void _e_alert_create(void);
>>>
>>>
>>>
>>>
> /usr/include/xcb/xproto.h: 1007
>
> typedef enum xcb_atom_enum_t {
> XCB_ATOM_NONE = 0,
> XCB_ATOM_ANY = 0,
> XCB_ATOM_PRIMARY,
> XCB_ATOM_SECONDARY,
> XCB_ATOM_ARC,
> XCB_ATOM_ATOM,
>
> So ... no I am not really sure. Perhaps it should be something else ??
>
> dh
>
>
>


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Christopher Michael]

On 12/11/12 13:04, Gustavo Sverzut Barbieri wrote:
> = 0? are you sure?
>
>
> On Mon, Nov 12, 2012 at 11:02 AM, Enlightenment SVN <
> no-re...@enlightenment.org> wrote:
>
>> Log:
>> define XCB_ATOM_NONE if not defined because opensuse sucks
>>ticket #1722
>>this commit brought to you by the recipient of the 2012 E-Devel "Hater"
>> award
>>
>>
>> Author:   discomfitor
>> Date: 2012-11-12 05:02:12 -0800 (Mon, 12 Nov 2012)
>> New Revision: 79157
>> Trac: http://trac.enlightenment.org/e/changeset/79157
>>
>> Modified:
>>trunk/e/src/bin/e_alert_main.c
>>
>> Modified: trunk/e/src/bin/e_alert_main.c
>> ===
>> --- trunk/e/src/bin/e_alert_main.c  2012-11-12 12:56:21 UTC (rev 79156)
>> +++ trunk/e/src/bin/e_alert_main.c  2012-11-12 13:02:12 UTC (rev 79157)
>> @@ -19,6 +19,10 @@
>>   #define WINDOW_WIDTH 320
>>   #define WINDOW_HEIGHT 240
>>
>> +#ifndef XCB_ATOM_NONE
>> +# define XCB_ATOM_NONE = 0
>> +#endif
>> +
>>   /* local function prototypes */
>>   static int _e_alert_connect(void);
>>   static void _e_alert_create(void);
>>
>>
>>

/usr/include/xcb/xproto.h: 1007

typedef enum xcb_atom_enum_t {
 XCB_ATOM_NONE = 0,
 XCB_ATOM_ANY = 0,
 XCB_ATOM_PRIMARY,
 XCB_ATOM_SECONDARY,
 XCB_ATOM_ARC,
 XCB_ATOM_ATOM,

So ... no I am not really sure. Perhaps it should be something else ??

dh



--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Gustavo Sverzut Barbieri]

= 0? are you sure?


On Mon, Nov 12, 2012 at 11:02 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> define XCB_ATOM_NONE if not defined because opensuse sucks
>   ticket #1722
>   this commit brought to you by the recipient of the 2012 E-Devel "Hater"
> award
>
>
> Author:   discomfitor
> Date: 2012-11-12 05:02:12 -0800 (Mon, 12 Nov 2012)
> New Revision: 79157
> Trac: http://trac.enlightenment.org/e/changeset/79157
>
> Modified:
>   trunk/e/src/bin/e_alert_main.c
>
> Modified: trunk/e/src/bin/e_alert_main.c
> ===
> --- trunk/e/src/bin/e_alert_main.c  2012-11-12 12:56:21 UTC (rev 79156)
> +++ trunk/e/src/bin/e_alert_main.c  2012-11-12 13:02:12 UTC (rev 79157)
> @@ -19,6 +19,10 @@
>  #define WINDOW_WIDTH 320
>  #define WINDOW_HEIGHT 240
>
> +#ifndef XCB_ATOM_NONE
> +# define XCB_ATOM_NONE = 0
> +#endif
> +
>  /* local function prototypes */
>  static int _e_alert_connect(void);
>  static void _e_alert_create(void);
>
>
>
> --
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>



-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Cedric BAIL]

Cedric Bail
On Nov 2, 2012 6:59 PM, "David Seikel"  wrote:
>
> On Fri,  2 Nov 2012 02:50:04 -0700 "Enlightenment SVN"
>  wrote:
>
> > Log:
> > unbork e_start; 500 bonus b0rker points to cedric for b0rking the
> > unb0rkable
>
> Let me be the first to congratulate Cedric on that outstanding effort.

Oh, yes! This one deserve it! I am impressed by myself sometime!

> --
> A big old stinking pile of genius that no one wants
> coz there are too many silver coated monkeys in the world.
>
>
--
> LogMeIn Central: Instant, anywhere, Remote PC access and management.
> Stay in control, update software, and manage PCs from one command center
> Diagnose problems and improve visibility into emerging IT issues
> Automate, monitor and manage. Do more in less time with Central
> http://p.sf.net/sfu/logmein12331_d2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

I lied, it's not ticket #1691.

On Fri, Nov 2, 2012 at 11:56 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> finally fix annoying submenu offset bug
>   ticket #1691
>
>
> Author:   discomfitor
> Date: 2012-11-02 04:56:32 -0700 (Fri, 02 Nov 2012)
> New Revision: 78854
> Trac: http://trac.enlightenment.org/e/changeset/78854
>
> Modified:
>   trunk/e/src/bin/e_menu.c
>
> Modified: trunk/e/src/bin/e_menu.c
> ===
> --- trunk/e/src/bin/e_menu.c2012-11-02 11:35:24 UTC (rev 78853)
> +++ trunk/e/src/bin/e_menu.c2012-11-02 11:56:32 UTC (rev 78854)
> @@ -763,7 +763,17 @@
> _e_menu_lock = EINA_TRUE;
> if ((mi->submenu) || (mi->submenu_pre_cb.func))
>   {
> -if (mi->submenu_object) evas_object_del(mi->submenu_object);
> +if (mi->submenu_object)
> +  {
> + if (!e_util_strcmp(evas_object_type_get(mi->submenu_object),
> "edje"))
> +   {
> +  /* already have a correct submenu object, don't re-set
> it */
> +  _e_menu_lock = EINA_FALSE;
> +  if (sub) e_object_unref(E_OBJECT(sub));
> +  return;
> +   }
> + evas_object_del(mi->submenu_object);
> +  }
>  o = edje_object_add(mi->menu->evas);
>  if (sub && (mi->submenu != sub)) e_object_ref(E_OBJECT(sub));
>  mi->submenu = sub;
> @@ -776,6 +786,16 @@
>  edje_object_size_min_calc(mi->submenu_object, &ww, &hh);
>  mi->submenu_w = ww;
>  mi->submenu_h = hh;
> +edje_object_part_swallow(mi->bg_object, "e.swallow.content",
> + mi->container_object);
> +edje_object_size_min_calc(mi->bg_object, &ww, &hh);
> +e_box_pack_options_set(mi->bg_object,
> +   1, 1, /* fill */
> +   1, 0, /* expand */
> +   0.5, 0.5, /* align */
> +   ww, hh, /* min */
> +   -1, -1 /* max */
> +   );
>   }
> else
>   {
>
>
>
> --
> LogMeIn Central: Instant, anywhere, Remote PC access and management.
> Stay in control, update software, and manage PCs from one command center
> Diagnose problems and improve visibility into emerging IT issues
> Automate, monitor and manage. Do more in less time with Central
> http://p.sf.net/sfu/logmein12331_d2d
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[David Seikel]

On Fri,  2 Nov 2012 02:50:04 -0700 "Enlightenment SVN"
 wrote:

> Log:
> unbork e_start; 500 bonus b0rker points to cedric for b0rking the
> unb0rkable 

Let me be the first to congratulate Cedric on that outstanding effort.

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Daniel Juyung Seo]

So this usage is not proper?

Daniel Juyung Seo (SeoZ)

On Sun, Oct 21, 2012 at 4:36 PM, Michael Blumenkrantz
 wrote:
> On Sun, 21 Oct 2012 16:35:15 +0900
> Daniel Juyung Seo  wrote:
>
>> But e_icon_object_set() is deprecated.
>>
>> Daniel Juyung Seo (SeoZ)
>>
>> On Sun, Oct 21, 2012 at 4:27 PM, Michael Blumenkrantz
>>  wrote:
>> > On Sun, 21 Oct 2012 16:04:39 +0900
>> > Daniel Juyung Seo  wrote:
>> >
>> >> Dear discomfitor,
>> >> I found another use case for e_icon_object_set.
>> >>
>> >>it->o_proxy = e_icon_add(ng->evas);
>> >>o = evas_object_image_add(ng->evas);
>> >>evas_object_image_source_set(o, it->base.obj);
>> >>evas_object_resize(o, 128, 128);
>> >>evas_object_image_fill_set(o, 0,0,128,128);
>> >>e_icon_object_set(it->o_proxy, o);
>> >>
>> >> They are from the line 687 of E-MODULES-EXTRA/engage/src/ng_gadcon.c.
>> >> How can I implement this without using e_icon_object_set?
>> >>
>> >> Daniel Juyung Seo (SeoZ)
>> >>
>> >> On Fri, Jul 20, 2012 at 4:52 PM, Enlightenment SVN
>> >>  wrote:
>> >> > Log:
>> >> > finally kill off the last of the e_icon_object_set uses;
>> >> >   this function was being abused in 100% of cases to do something other
>> >> > than the intended use of just setting an evas image into an e_icon. I've
>> >> > added e_icon_edje_object_set which is the edje version and will,
>> >> > hopefully, make things more clear and avoid confusion in the future
>> >> > e_widget_image now calls the proper e_icon functions and is far less
>> >> > likely to trigger a magic failure
>> >> >
>> >> >
>> >> > Author:   discomfitor
>> >> > Date: 2012-07-20 00:52:53 -0700 (Fri, 20 Jul 2012)
>> >> > New Revision: 74213
>> >> > Trac: http://trac.enlightenment.org/e/changeset/74213
>> >> >
>> >> > Modified:
>> >> >   trunk/e/src/bin/e_icon.c trunk/e/src/bin/e_icon.h
>> >> > trunk/e/src/bin/e_widget_image.c trunk/e/src/bin/e_widget_image.h
>> >
>> > that is a correct usage of e_icon
>
> and engage is an unsupported module

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Sun, 21 Oct 2012 16:35:15 +0900
Daniel Juyung Seo  wrote:

> But e_icon_object_set() is deprecated.
> 
> Daniel Juyung Seo (SeoZ)
> 
> On Sun, Oct 21, 2012 at 4:27 PM, Michael Blumenkrantz
>  wrote:
> > On Sun, 21 Oct 2012 16:04:39 +0900
> > Daniel Juyung Seo  wrote:
> >
> >> Dear discomfitor,
> >> I found another use case for e_icon_object_set.
> >>
> >>it->o_proxy = e_icon_add(ng->evas);
> >>o = evas_object_image_add(ng->evas);
> >>evas_object_image_source_set(o, it->base.obj);
> >>evas_object_resize(o, 128, 128);
> >>evas_object_image_fill_set(o, 0,0,128,128);
> >>e_icon_object_set(it->o_proxy, o);
> >>
> >> They are from the line 687 of E-MODULES-EXTRA/engage/src/ng_gadcon.c.
> >> How can I implement this without using e_icon_object_set?
> >>
> >> Daniel Juyung Seo (SeoZ)
> >>
> >> On Fri, Jul 20, 2012 at 4:52 PM, Enlightenment SVN
> >>  wrote:
> >> > Log:
> >> > finally kill off the last of the e_icon_object_set uses;
> >> >   this function was being abused in 100% of cases to do something other
> >> > than the intended use of just setting an evas image into an e_icon. I've
> >> > added e_icon_edje_object_set which is the edje version and will,
> >> > hopefully, make things more clear and avoid confusion in the future
> >> > e_widget_image now calls the proper e_icon functions and is far less
> >> > likely to trigger a magic failure
> >> >
> >> >
> >> > Author:   discomfitor
> >> > Date: 2012-07-20 00:52:53 -0700 (Fri, 20 Jul 2012)
> >> > New Revision: 74213
> >> > Trac: http://trac.enlightenment.org/e/changeset/74213
> >> >
> >> > Modified:
> >> >   trunk/e/src/bin/e_icon.c trunk/e/src/bin/e_icon.h
> >> > trunk/e/src/bin/e_widget_image.c trunk/e/src/bin/e_widget_image.h
> >
> > that is a correct usage of e_icon

and engage is an unsupported module

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Daniel Juyung Seo]

But e_icon_object_set() is deprecated.

Daniel Juyung Seo (SeoZ)

On Sun, Oct 21, 2012 at 4:27 PM, Michael Blumenkrantz
 wrote:
> On Sun, 21 Oct 2012 16:04:39 +0900
> Daniel Juyung Seo  wrote:
>
>> Dear discomfitor,
>> I found another use case for e_icon_object_set.
>>
>>it->o_proxy = e_icon_add(ng->evas);
>>o = evas_object_image_add(ng->evas);
>>evas_object_image_source_set(o, it->base.obj);
>>evas_object_resize(o, 128, 128);
>>evas_object_image_fill_set(o, 0,0,128,128);
>>e_icon_object_set(it->o_proxy, o);
>>
>> They are from the line 687 of E-MODULES-EXTRA/engage/src/ng_gadcon.c.
>> How can I implement this without using e_icon_object_set?
>>
>> Daniel Juyung Seo (SeoZ)
>>
>> On Fri, Jul 20, 2012 at 4:52 PM, Enlightenment SVN
>>  wrote:
>> > Log:
>> > finally kill off the last of the e_icon_object_set uses;
>> >   this function was being abused in 100% of cases to do something other
>> > than the intended use of just setting an evas image into an e_icon. I've
>> > added e_icon_edje_object_set which is the edje version and will, hopefully,
>> > make things more clear and avoid confusion in the future e_widget_image now
>> > calls the proper e_icon functions and is far less likely to trigger a magic
>> > failure
>> >
>> >
>> > Author:   discomfitor
>> > Date: 2012-07-20 00:52:53 -0700 (Fri, 20 Jul 2012)
>> > New Revision: 74213
>> > Trac: http://trac.enlightenment.org/e/changeset/74213
>> >
>> > Modified:
>> >   trunk/e/src/bin/e_icon.c trunk/e/src/bin/e_icon.h
>> > trunk/e/src/bin/e_widget_image.c trunk/e/src/bin/e_widget_image.h
>
> that is a correct usage of e_icon

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Sun, 21 Oct 2012 16:04:39 +0900
Daniel Juyung Seo  wrote:

> Dear discomfitor,
> I found another use case for e_icon_object_set.
> 
>it->o_proxy = e_icon_add(ng->evas);
>o = evas_object_image_add(ng->evas);
>evas_object_image_source_set(o, it->base.obj);
>evas_object_resize(o, 128, 128);
>evas_object_image_fill_set(o, 0,0,128,128);
>e_icon_object_set(it->o_proxy, o);
> 
> They are from the line 687 of E-MODULES-EXTRA/engage/src/ng_gadcon.c.
> How can I implement this without using e_icon_object_set?
> 
> Daniel Juyung Seo (SeoZ)
> 
> On Fri, Jul 20, 2012 at 4:52 PM, Enlightenment SVN
>  wrote:
> > Log:
> > finally kill off the last of the e_icon_object_set uses;
> >   this function was being abused in 100% of cases to do something other
> > than the intended use of just setting an evas image into an e_icon. I've
> > added e_icon_edje_object_set which is the edje version and will, hopefully,
> > make things more clear and avoid confusion in the future e_widget_image now
> > calls the proper e_icon functions and is far less likely to trigger a magic
> > failure
> >
> >
> > Author:   discomfitor
> > Date: 2012-07-20 00:52:53 -0700 (Fri, 20 Jul 2012)
> > New Revision: 74213
> > Trac: http://trac.enlightenment.org/e/changeset/74213
> >
> > Modified:
> >   trunk/e/src/bin/e_icon.c trunk/e/src/bin/e_icon.h
> > trunk/e/src/bin/e_widget_image.c trunk/e/src/bin/e_widget_image.h

that is a correct usage of e_icon

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Daniel Juyung Seo]

Dear discomfitor,
I found another use case for e_icon_object_set.

   it->o_proxy = e_icon_add(ng->evas);
   o = evas_object_image_add(ng->evas);
   evas_object_image_source_set(o, it->base.obj);
   evas_object_resize(o, 128, 128);
   evas_object_image_fill_set(o, 0,0,128,128);
   e_icon_object_set(it->o_proxy, o);

They are from the line 687 of E-MODULES-EXTRA/engage/src/ng_gadcon.c.
How can I implement this without using e_icon_object_set?

Daniel Juyung Seo (SeoZ)

On Fri, Jul 20, 2012 at 4:52 PM, Enlightenment SVN
 wrote:
> Log:
> finally kill off the last of the e_icon_object_set uses;
>   this function was being abused in 100% of cases to do something other than 
> the intended use of just setting an evas image into an e_icon. I've added 
> e_icon_edje_object_set which is the edje version and will, hopefully, make 
> things more clear and avoid confusion in the future
>   e_widget_image now calls the proper e_icon functions and is far less likely 
> to trigger a magic failure
>
>
> Author:   discomfitor
> Date: 2012-07-20 00:52:53 -0700 (Fri, 20 Jul 2012)
> New Revision: 74213
> Trac: http://trac.enlightenment.org/e/changeset/74213
>
> Modified:
>   trunk/e/src/bin/e_icon.c trunk/e/src/bin/e_icon.h 
> trunk/e/src/bin/e_widget_image.c trunk/e/src/bin/e_widget_image.h
>
> Modified: trunk/e/src/bin/e_icon.c
> ===
> --- trunk/e/src/bin/e_icon.c2012-07-20 07:38:40 UTC (rev 74212)
> +++ trunk/e/src/bin/e_icon.c2012-07-20 07:52:53 UTC (rev 74213)
> @@ -342,6 +342,35 @@
> return EINA_TRUE;
>  }
>
> +EAPI void
> +e_icon_edje_object_set(Evas_Object *obj, Evas_Object *edje)
> +{
> +   E_Smart_Data *sd;
> +
> +   if (evas_object_smart_smart_get(obj) != _e_smart) SMARTERR();
> +   if (!(sd = evas_object_smart_data_get(obj))) return;
> +
> +   /* smart code here */
> +   if (sd->obj) evas_object_del(sd->obj);
> +   sd->loading = 0;
> +   if (sd->fdo)
> + {
> +eina_stringshare_del(sd->fdo);
> +sd->fdo = NULL;
> + }
> +
> +   if (sd->timer) ecore_timer_del(sd->timer);
> +   sd->timer = NULL;
> +   sd->frame = 0;
> +   sd->frame_count = 0;
> +   sd->edje = EINA_TRUE;
> +   sd->obj = edje;
> +
> +   if (evas_object_visible_get(obj)) evas_object_show(sd->obj);
> +   evas_object_smart_member_add(sd->obj, obj);
> +   _e_icon_smart_reconfigure(sd);
> +}
> +
>  EAPI Eina_Bool
>  e_icon_file_edje_set(Evas_Object *obj, const char *file, const char *part)
>  {
> @@ -435,8 +464,8 @@
> if (evas_object_smart_smart_get(obj) != _e_smart) SMARTERR();
> if (!(sd = evas_object_smart_data_get(obj))) return;
> str = evas_object_type_get(o);
> -   if ((!str) || (strcmp(str, "edje") && strcmp(str, "image")))
> - printf(EINA_COLOR_RED"**\ntrying to set an image object 
> of type '%s'! this is not what you 
> want!\n**\n"EINA_COLOR_RESET, str);
> +   if ((!str) || strcmp(str, "image"))
> + CRI(EINA_COLOR_RED"**\ntrying to set an image object of 
> type '%s'! this is not what you want!\n**\n"EINA_COLOR_RESET, 
> str);
>
> if (sd->timer) ecore_timer_del(sd->timer);
> sd->timer = NULL;
>
> Modified: trunk/e/src/bin/e_icon.h
> ===
> --- trunk/e/src/bin/e_icon.h2012-07-20 07:38:40 UTC (rev 74212)
> +++ trunk/e/src/bin/e_icon.h2012-07-20 07:52:53 UTC (rev 74213)
> @@ -11,7 +11,8 @@
>  EAPI Eina_Boole_icon_file_key_set (Evas_Object *obj, const char 
> *file, const char *key);
>  EAPI Eina_Boole_icon_file_edje_set(Evas_Object *obj, const char 
> *file, const char *part);
>  EAPI Eina_Boole_icon_fdo_icon_set (Evas_Object *obj, const char 
> *icon);
> -EAPI void e_icon_object_set   (Evas_Object *obj, Evas_Object *o);
> +EAPI void e_icon_edje_object_set(Evas_Object *obj, Evas_Object 
> *edje);
> +EAPI void e_icon_object_set   (Evas_Object *obj, Evas_Object *o) 
> EINA_DEPRECATED;
>  EAPI const char  *e_icon_file_get (const Evas_Object *obj);
>  EAPI void e_icon_smooth_scale_set (Evas_Object *obj, Eina_Bool 
> smooth);
>  EAPI Eina_Boole_icon_smooth_scale_get (const Evas_Object *obj);
>
> Modified: trunk/e/src/bin/e_widget_image.c
> ===
> --- trunk/e/src/bin/e_widget_image.c2012-07-20 07:38:40 UTC (rev 74212)
> +++ trunk/e/src/bin/e_widget_image.c2012-07-20 07:52:53 UTC (rev 74213)
> @@ -26,7 +26,7 @@
> evas_object_show(object);
> o = e_icon_add(evas);
> e_icon_fill_inside_set(o, 1);
> -   e_icon_object_set(o, object);
> +   e_icon_edje_object_set(o, object);
> wd->img = o;
> e_widget_data_set(obj, wd);
> e_widget_can_focus_set(obj, 0);
> @@ -54,9 +54,13 @@
>
> o = e_icon_add(evas);
> e_icon_fill_inside_set(o, 1);
> -   o2 = evas_object_image_add(evas);
> -   evas_object_image_file_set(o2, file, 

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On 18/10/12 17:11, Lucas De Marchi wrote:
> it would be even nicer to convert to bool, though, starting to use it 
> internally

We don't use bool in e. Maybe we should, maybe we shouldn't, but until
we decide, we should stick to what's already there, or suggest to change
it in a different thread.

--
Tom.

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Christopher Michael]

On 18/10/2012 03:37 PM, Michael Blumenkrantz wrote:
> On Thu, 18 Oct 2012 12:23:00 -0300
> Lucas De Marchi  wrote:
>
>> On Thu, Oct 18, 2012 at 12:16 PM, Michael Blumenkrantz
>>  wrote:
>>> On Thu, 18 Oct 2012 12:11:58 -0300
>>> Lucas De Marchi  wrote:
>>>
 On Thu, Oct 18, 2012 at 4:42 AM, Christopher Michael
  wrote:
> On 18/10/12 08:28, Enlightenment SVN wrote:
>> Log:
>> uchar -> Eina_Bool
>>
>>
>> Author:   discomfitor
>> Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
>> New Revision: 78150
>> Trac: http://trac.enlightenment.org/e/changeset/78150
>>
>> Modified:
>> trunk/e/src/bin/e_menu.h
>
> Would actually be nice to do this across the E src directory as there
> are a ton of places this occurs. It would (if nothing else) provide some
> consistency.

 it would be even nicer to convert to bool, though, starting to use it
 internally


 Lucas De Marchi

>>>
>>> NO WAY MAN SOME PLATFORMS DON'T SUPPORT BOOL WTF ARE YOU THINKING OMGOMGOMG
>>
>> /me trying to decide if you are serious here.
>>
>>
>> Lucas De Marchi
>
> http://i.imgur.com/yRVPd.png

Wow, that looks very much like my first computer

dh



--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Thu, 18 Oct 2012 12:23:00 -0300
Lucas De Marchi  wrote:

> On Thu, Oct 18, 2012 at 12:16 PM, Michael Blumenkrantz
>  wrote:
> > On Thu, 18 Oct 2012 12:11:58 -0300
> > Lucas De Marchi  wrote:
> >
> >> On Thu, Oct 18, 2012 at 4:42 AM, Christopher Michael
> >>  wrote:
> >> > On 18/10/12 08:28, Enlightenment SVN wrote:
> >> >> Log:
> >> >> uchar -> Eina_Bool
> >> >>
> >> >>
> >> >> Author:   discomfitor
> >> >> Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
> >> >> New Revision: 78150
> >> >> Trac: http://trac.enlightenment.org/e/changeset/78150
> >> >>
> >> >> Modified:
> >> >>trunk/e/src/bin/e_menu.h
> >> >
> >> > Would actually be nice to do this across the E src directory as there
> >> > are a ton of places this occurs. It would (if nothing else) provide some
> >> > consistency.
> >>
> >> it would be even nicer to convert to bool, though, starting to use it
> >> internally
> >>
> >>
> >> Lucas De Marchi
> >>
> >
> > NO WAY MAN SOME PLATFORMS DON'T SUPPORT BOOL WTF ARE YOU THINKING OMGOMGOMG
> 
> /me trying to decide if you are serious here.
> 
> 
> Lucas De Marchi

http://i.imgur.com/yRVPd.png

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Lucas De Marchi]

On Thu, Oct 18, 2012 at 12:16 PM, Michael Blumenkrantz
 wrote:
> On Thu, 18 Oct 2012 12:11:58 -0300
> Lucas De Marchi  wrote:
>
>> On Thu, Oct 18, 2012 at 4:42 AM, Christopher Michael
>>  wrote:
>> > On 18/10/12 08:28, Enlightenment SVN wrote:
>> >> Log:
>> >> uchar -> Eina_Bool
>> >>
>> >>
>> >> Author:   discomfitor
>> >> Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
>> >> New Revision: 78150
>> >> Trac: http://trac.enlightenment.org/e/changeset/78150
>> >>
>> >> Modified:
>> >>trunk/e/src/bin/e_menu.h
>> >
>> > Would actually be nice to do this across the E src directory as there
>> > are a ton of places this occurs. It would (if nothing else) provide some
>> > consistency.
>>
>> it would be even nicer to convert to bool, though, starting to use it
>> internally
>>
>>
>> Lucas De Marchi
>>
>
> NO WAY MAN SOME PLATFORMS DON'T SUPPORT BOOL WTF ARE YOU THINKING OMGOMGOMG

/me trying to decide if you are serious here.


Lucas De Marchi

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Thu, 18 Oct 2012 12:11:58 -0300
Lucas De Marchi  wrote:

> On Thu, Oct 18, 2012 at 4:42 AM, Christopher Michael
>  wrote:
> > On 18/10/12 08:28, Enlightenment SVN wrote:
> >> Log:
> >> uchar -> Eina_Bool
> >>
> >>
> >> Author:   discomfitor
> >> Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
> >> New Revision: 78150
> >> Trac: http://trac.enlightenment.org/e/changeset/78150
> >>
> >> Modified:
> >>trunk/e/src/bin/e_menu.h
> >
> > Would actually be nice to do this across the E src directory as there
> > are a ton of places this occurs. It would (if nothing else) provide some
> > consistency.
> 
> it would be even nicer to convert to bool, though, starting to use it
> internally
> 
> 
> Lucas De Marchi
> 

NO WAY MAN SOME PLATFORMS DON'T SUPPORT BOOL WTF ARE YOU THINKING OMGOMGOMG

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Lucas De Marchi]

On Thu, Oct 18, 2012 at 4:42 AM, Christopher Michael
 wrote:
> On 18/10/12 08:28, Enlightenment SVN wrote:
>> Log:
>> uchar -> Eina_Bool
>>
>>
>> Author:   discomfitor
>> Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
>> New Revision: 78150
>> Trac: http://trac.enlightenment.org/e/changeset/78150
>>
>> Modified:
>>trunk/e/src/bin/e_menu.h
>
> Would actually be nice to do this across the E src directory as there
> are a ton of places this occurs. It would (if nothing else) provide some
> consistency.

it would be even nicer to convert to bool, though, starting to use it internally


Lucas De Marchi

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

I do it as I go

On Thu, Oct 18, 2012 at 8:42 AM, Christopher Michael  wrote:

> On 18/10/12 08:28, Enlightenment SVN wrote:
> > Log:
> > uchar -> Eina_Bool
> >
> >
> > Author:   discomfitor
> > Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
> > New Revision: 78150
> > Trac: http://trac.enlightenment.org/e/changeset/78150
> >
> > Modified:
> >trunk/e/src/bin/e_menu.h
>
> Would actually be nice to do this across the E src directory as there
> are a ton of places this occurs. It would (if nothing else) provide some
> consistency.
>
> dh
>
>
>
> --
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_sfd2d_oct
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Christopher Michael]

On 18/10/12 08:28, Enlightenment SVN wrote:
> Log:
> uchar -> Eina_Bool
>
>
> Author:   discomfitor
> Date: 2012-10-18 00:28:12 -0700 (Thu, 18 Oct 2012)
> New Revision: 78150
> Trac: http://trac.enlightenment.org/e/changeset/78150
>
> Modified:
>trunk/e/src/bin/e_menu.h

Would actually be nice to do this across the E src directory as there 
are a ton of places this occurs. It would (if nothing else) provide some 
consistency.

dh


--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

whoops

On Thu, Oct 4, 2012 at 12:45 PM, Sebastian Dransfeld 
wrote:

> On 10/04/2012 10:43 AM, Enlightenment SVN wrote:
> > Log:
> > show desktop filename in icon selection dialog
> >ticket #1237
>
> You are joking? Static text as argument for %s?
>
> S.
>
> >
> >
> > Author:   discomfitor
> > Date: 2012-10-04 01:43:50 -0700 (Thu, 04 Oct 2012)
> > New Revision: 77411
> > Trac: http://trac.enlightenment.org/e/changeset/77411
> >
> > Modified:
> >trunk/e/src/bin/e_eap_editor.c
> >
> > Modified: trunk/e/src/bin/e_eap_editor.c
> > ===
> > --- trunk/e/src/bin/e_eap_editor.c2012-10-04 08:31:35 UTC (rev 77410)
> > +++ trunk/e/src/bin/e_eap_editor.c2012-10-04 08:43:50 UTC (rev 77411)
> > @@ -808,6 +808,7 @@
> >  E_Desktop_Edit *editor;
> >  char *path = NULL;
> >  const char *icon_path = NULL;
> > +   char buf[PATH_MAX + 32];
> >
> >  editor = data2;
> >  cfdata = data1;
> > @@ -818,7 +819,8 @@
> >  if (!dia) return;
> >  e_object_del_attach_func_set(E_OBJECT(dia),
> >
> _e_desktop_edit_cb_icon_select_destroy);
> > -   e_dialog_title_set(dia, _("Select an Icon"));
> > +   snprintf(buf, sizeof(buf), "%s '%s'", "Select an Icon for",
> ecore_file_file_get(cfdata->orig_path));
> > +   e_dialog_title_set(dia, buf);
> >  dia->data = cfdata;
> >
> >  /* absolute path to icon */
> >
> >
> >
> --
> > Don't let slow site performance ruin your business. Deploy New Relic APM
> > Deploy New Relic app performance management and know exactly
> > what is happening inside your Ruby, Python, PHP, Java, and .NET app
> > Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> > http://p.sf.net/sfu/newrelic-dev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
>
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Leif Middelschulte]

Am Donnerstag, 4. Oktober 2012 um 13:45 schrieb Sebastian Dransfeld:
> On 10/04/2012 10:43 AM, Enlightenment SVN wrote:
> > Log:
> > show desktop filename in icon selection dialog
> > ticket #1237
> > 
> 
> 
> You are joking? Static text as argument for %s?
More probably forgot the _() around for gettext :) 
> 
> S.
> 
> > 
> > 
> > Author: discomfitor
> > Date: 2012-10-04 01:43:50 -0700 (Thu, 04 Oct 2012)
> > New Revision: 77411
> > Trac: http://trac.enlightenment.org/e/changeset/77411
> > 
> > Modified:
> > trunk/e/src/bin/e_eap_editor.c
> > 
> > Modified: trunk/e/src/bin/e_eap_editor.c
> > ===
> > --- trunk/e/src/bin/e_eap_editor.c 2012-10-04 08:31:35 UTC (rev 77410)
> > +++ trunk/e/src/bin/e_eap_editor.c 2012-10-04 08:43:50 UTC (rev 77411)
> > @@ -808,6 +808,7 @@
> > E_Desktop_Edit *editor;
> > char *path = NULL;
> > const char *icon_path = NULL;
> > + char buf[PATH_MAX + 32];
> > 
> > editor = data2;
> > cfdata = data1;
> > @@ -818,7 +819,8 @@
> > if (!dia) return;
> > e_object_del_attach_func_set(E_OBJECT(dia),
> > _e_desktop_edit_cb_icon_select_destroy);
> > - e_dialog_title_set(dia, _("Select an Icon"));
> > + snprintf(buf, sizeof(buf), "%s '%s'", "Select an Icon for", 
> > ecore_file_file_get(cfdata->orig_path));
> > + e_dialog_title_set(dia, buf);
> > dia->data = cfdata;
> > 
> > /* absolute path to icon */
> > 
> > 
> > --
> > Don't let slow site performance ruin your business. Deploy New Relic APM
> > Deploy New Relic app performance management and know exactly
> > what is happening inside your Ruby, Python, PHP, Java, and .NET app
> > Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> > http://p.sf.net/sfu/newrelic-dev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net 
> > (mailto:enlightenment-...@lists.sourceforge.net)
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> > 
> 
> 
> 
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net 
> (mailto:enlightenment-devel@lists.sourceforge.net)
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> 


--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Sebastian Dransfeld]

On 10/04/2012 10:43 AM, Enlightenment SVN wrote:
> Log:
> show desktop filename in icon selection dialog
>ticket #1237

You are joking? Static text as argument for %s?

S.

>
>
> Author:   discomfitor
> Date: 2012-10-04 01:43:50 -0700 (Thu, 04 Oct 2012)
> New Revision: 77411
> Trac: http://trac.enlightenment.org/e/changeset/77411
>
> Modified:
>trunk/e/src/bin/e_eap_editor.c
>
> Modified: trunk/e/src/bin/e_eap_editor.c
> ===
> --- trunk/e/src/bin/e_eap_editor.c2012-10-04 08:31:35 UTC (rev 77410)
> +++ trunk/e/src/bin/e_eap_editor.c2012-10-04 08:43:50 UTC (rev 77411)
> @@ -808,6 +808,7 @@
>  E_Desktop_Edit *editor;
>  char *path = NULL;
>  const char *icon_path = NULL;
> +   char buf[PATH_MAX + 32];
>
>  editor = data2;
>  cfdata = data1;
> @@ -818,7 +819,8 @@
>  if (!dia) return;
>  e_object_del_attach_func_set(E_OBJECT(dia),
>   _e_desktop_edit_cb_icon_select_destroy);
> -   e_dialog_title_set(dia, _("Select an Icon"));
> +   snprintf(buf, sizeof(buf), "%s '%s'", "Select an Icon for", 
> ecore_file_file_get(cfdata->orig_path));
> +   e_dialog_title_set(dia, buf);
>  dia->data = cfdata;
>
>  /* absolute path to icon */
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>


--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Tue, 18 Sep 2012 20:03:13 +0200
Sebastian Dransfeld  wrote:

> As ecore is implemented now it should be true, but in theory it can be false
> for large drop objects which needs time to transfer (if I remember
> correctly). If we don't plan to implement this feature maybe it should be
> cleaned up?
> 
> Den 18. sep. 2012 kl. 15:20 skrev "Enlightenment SVN"
> :
> 
> > Log:
> > ignore the completed flag on dnd-finished events since this (SHOULD be)
> > always true; fixes bug where windows could be stuck in a never-ending drag
> > and no longer respond to user input
> > 
> > 
> > Author:   discomfitor
> > Date: 2012-09-18 06:20:11 -0700 (Tue, 18 Sep 2012)
> > New Revision: 76818
> > Trac: http://trac.enlightenment.org/e/changeset/76818
> > 
> > Modified:
> >  trunk/e/src/bin/e_dnd.c 
> > 

the issue is that we don't provide the events for conversion or whatever. the
FINISHED event is the last possible event that we can receive, so failing to
end the dnd operation here is always a mistake. I do agree that in the future
this should likely be fixed, but for e17 release there's no possibility of this
being the case :/

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Sebastian Dransfeld]

As ecore is implemented now it should be true, but in theory it can be false 
for large drop objects which needs time to transfer (if I remember correctly). 
If we don't plan to implement this feature maybe it should be cleaned up?

Den 18. sep. 2012 kl. 15:20 skrev "Enlightenment SVN" 
:

> Log:
> ignore the completed flag on dnd-finished events since this (SHOULD be) 
> always true; fixes bug where windows could be stuck in a never-ending drag 
> and no longer respond to user input
> 
> 
> Author:   discomfitor
> Date: 2012-09-18 06:20:11 -0700 (Tue, 18 Sep 2012)
> New Revision: 76818
> Trac: http://trac.enlightenment.org/e/changeset/76818
> 
> Modified:
>  trunk/e/src/bin/e_dnd.c 
> 
> Modified: trunk/e/src/bin/e_dnd.c
> ===
> --- trunk/e/src/bin/e_dnd.c2012-09-18 13:05:20 UTC (rev 76817)
> +++ trunk/e/src/bin/e_dnd.c2012-09-18 13:20:11 UTC (rev 76818)
> @@ -1377,14 +1377,20 @@
> }
> 
> static Eina_Bool
> -_e_dnd_cb_event_dnd_finished(void *data __UNUSED__, int type __UNUSED__, 
> void *event)
> +_e_dnd_cb_event_dnd_finished(void *data __UNUSED__, int type __UNUSED__, 
> void *event __UNUSED__)
> {
> +/*
> + * this is broken since the completed flag doesn't tell us anything with 
> current
> + * ecore-x and results in never-ending dnd operation which breaks the window
> + * 18 September 2012
> + * BORKER CERTIFICATION: BRONZE
> + * -discomfitor
>Ecore_X_Event_Xdnd_Finished *ev;
> 
>ev = event;
> 
>if (!ev->completed) return ECORE_CALLBACK_PASS_ON;
> -
> +*/
>if (_drag_current)
>  {
> E_Drag *tmp;
> 
> 
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Thu, 6 Sep 2012 02:04:31 +0900
Daniel Juyung Seo  wrote:

> arggg E17 still shows popup whenever it restarts.
> http://imagebin.org/227291
> It's too late today, I will figure it out why tomorrow.
> 
> Daniel Juyung Seo (SeoZ)

run in xephyr with gdb attached. working fine here

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Daniel Juyung Seo]

arggg E17 still shows popup whenever it restarts.
http://imagebin.org/227291
It's too late today, I will figure it out why tomorrow.

Daniel Juyung Seo (SeoZ)

On Thu, Sep 6, 2012 at 1:47 AM, Enlightenment SVN
 wrote:
> Log:
> revert gadcon event thingy, this causes a stupid gadman bug crash which takes 
> more than 5 mins to fix
>
>
> Author:   discomfitor
> Date: 2012-09-05 09:47:16 -0700 (Wed, 05 Sep 2012)
> New Revision: 76203
> Trac: http://trac.enlightenment.org/e/changeset/76203
>
> Modified:
>   trunk/e/src/bin/e_gadcon.c trunk/e/src/bin/e_gadcon.h
>
> Modified: trunk/e/src/bin/e_gadcon.c
> ===
> --- trunk/e/src/bin/e_gadcon.c  2012-09-05 16:06:35 UTC (rev 76202)
> +++ trunk/e/src/bin/e_gadcon.c  2012-09-05 16:47:16 UTC (rev 76203)
> @@ -83,7 +83,6 @@
>  static void _e_gadcon_provider_populate_unrequest(const 
> E_Gadcon_Client_Class *cc);
>  static Eina_Bool_e_gadcon_provider_populate_idler(void 
> *data);
>  static Eina_Bool_e_gadcon_custom_populate_idler(void *data);
> -static void _e_gadcon_event_end(void *data, void *ev);
>
>  static int  _e_gadcon_location_change(E_Gadcon_Client 
> *gcc, E_Gadcon_Location *src, E_Gadcon_Location *dst);
>
> @@ -182,9 +181,6 @@
>
>  //
>
> -EAPI int E_EVENT_GADCON_POPULATE = -1;
> -EAPI int E_EVENT_GADCON_UNPOPULATE = -1;
> -
>  static Eina_Hash *providers = NULL;
>  static Eina_List *providers_list = NULL;
>  static Eina_List *gadcons = NULL;
> @@ -224,8 +220,6 @@
>  EINTERN int
>  e_gadcon_init(void)
>  {
> -   E_EVENT_GADCON_POPULATE = ecore_event_type_new();
> -   E_EVENT_GADCON_UNPOPULATE = ecore_event_type_new();
> _module_init_end_handler = 
> ecore_event_handler_add(E_EVENT_MODULE_INIT_END, _module_init_end_cb, NULL);
> return 1;
>  }
> @@ -526,7 +520,6 @@
> Eina_List *l;
> E_Config_Gadcon_Client *cf_gcc;
> Eina_Bool ret = EINA_TRUE;
> -   E_Event_Gadcon_Populate *ev;
>
> E_OBJECT_CHECK(gc);
> E_OBJECT_TYPE_CHECK(gc, E_GADCON_TYPE);
> @@ -554,10 +547,6 @@
>e_gadcon_client_queue(gc, cf_gcc);
>   }
> e_gadcon_layout_thaw(gc->o_container);
> -   ev = E_NEW(E_Event_Gadcon_Populate, 1);
> -   ev->gadcon = gc;
> -   e_object_ref(E_OBJECT(gc));
> -   ecore_event_add(E_EVENT_GADCON_POPULATE, ev, _e_gadcon_event_end, NULL);
> return EINA_TRUE;
>  }
>
> @@ -565,7 +554,6 @@
>  e_gadcon_unpopulate(E_Gadcon *gc)
>  {
> E_Gadcon_Client *gcc;
> -   E_Event_Gadcon_Populate *ev;
>
> E_OBJECT_CHECK(gc);
> E_OBJECT_TYPE_CHECK(gc, E_GADCON_TYPE);
> @@ -578,10 +566,6 @@
> if (gc->awaiting_classes)
>   eina_hash_free(gc->awaiting_classes);
> gc->awaiting_classes = NULL;
> -   ev = E_NEW(E_Event_Gadcon_Populate, 1);
> -   ev->gadcon = gc;
> -   e_object_ref(E_OBJECT(gc));
> -   ecore_event_add(E_EVENT_GADCON_UNPOPULATE, ev, _e_gadcon_event_end, NULL);
>  }
>
>  EAPI void
> @@ -5276,14 +5260,6 @@
>   }
>  }
>
> -static void
> -_e_gadcon_event_end(void *data __UNUSED__, void *event)
> -{
> -   E_Event_Gadcon_Populate *ev = event;
> -   e_object_unref(E_OBJECT(ev->gadcon));
> -   free(ev);
> -}
> -
>  static Eina_Bool
>  _e_gadcon_custom_populate_idler(void *data __UNUSED__)
>  {
>
> Modified: trunk/e/src/bin/e_gadcon.h
> ===
> --- trunk/e/src/bin/e_gadcon.h  2012-09-05 16:06:35 UTC (rev 76202)
> +++ trunk/e/src/bin/e_gadcon.h  2012-09-05 16:47:16 UTC (rev 76203)
> @@ -1,8 +1,5 @@
>  #ifdef E_TYPEDEFS
>
> -EAPI extern int E_EVENT_GADCON_POPULATE;
> -EAPI extern int E_EVENT_GADCON_UNPOPULATE;
> -
>  #define E_GADCON_CLIENT(x) ((E_Gadcon_Client *)(x))
>
>  /* different layout policies - only 1 supported for now */
> @@ -49,9 +46,6 @@
>  typedef struct _E_Gadcon_Client_Class E_Gadcon_Client_Class;
>  typedef struct _E_Gadcon_Location E_Gadcon_Location;
>
> -typedef struct _E_Event_Gadcon E_Event_Gadcon_Populate;
> -typedef struct _E_Event_Gadcon E_Event_Gadcon_Unpopulate;
> -
>  #else
>  #ifndef E_GADCON_H
>  #define E_GADCON_H
> @@ -132,11 +126,6 @@
> unsigned char  dummy : 1;
>  };
>
> -struct _E_Event_Gadcon
> -{
> -   E_Gadcon *gadcon;
> -};
> -
>  #define GADCON_CLIENT_CLASS_VERSION 3
>  /* Version 3 add the *client_class param to icon(),label(),id_new(), 
> id_del() */
>  /*   and the *orient param to orient() */
>
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.s

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

nope

On Tue, Aug 7, 2012 at 11:24 PM, Sebastian Dransfeld 
wrote:

> Should both calls to e_bindings_mapping_change_enable() be with argument
> FALSE?
>
> S.
>
> On 08/06/2012 12:21 PM, Enlightenment SVN wrote:
> > Log:
> > add an amazing hack which, when a vmware player window is opened,
> disables keyboard remapping until the window is closed. this is stupid, but
> seems to be the only way to keep it from breaking keymaps on some setups
> >ticket #1057
> >
> >
> > Author:   discomfitor
> > Date: 2012-08-06 03:21:41 -0700 (Mon, 06 Aug 2012)
> > New Revision: 74919
> > Trac: http://trac.enlightenment.org/e/changeset/74919
> >
> > Modified:
> >trunk/e/src/bin/e_bindings.c trunk/e/src/bin/e_bindings.h
> trunk/e/src/bin/e_border.c
> >
> > Modified: trunk/e/src/bin/e_bindings.c
> > ===
> > --- trunk/e/src/bin/e_bindings.c  2012-08-06 09:48:34 UTC (rev 74918)
> > +++ trunk/e/src/bin/e_bindings.c  2012-08-06 10:21:41 UTC (rev 74919)
> > @@ -24,6 +24,7 @@
> >   static Eina_List *signal_bindings = NULL;
> >   static Eina_List *wheel_bindings = NULL;
> >   static Eina_List *acpi_bindings = NULL;
> > +static int _e_bindings_mapping_change_enabled = 1;
> >
> >   typedef struct _E_Binding_Edge_Data E_Binding_Edge_Data;
> >
> > @@ -1077,12 +1078,23 @@
> >  return act;
> >   }
> >
> > +EAPI void
> > +e_bindings_mapping_change_enable(Eina_Bool enable)
> > +{
> > +   if (enable)
> > + _e_bindings_mapping_change_enabled++;
> > +   else
> > + _e_bindings_mapping_change_enabled--;
> > +   if (_e_bindings_mapping_change_enabled < 0)
> > + _e_bindings_mapping_change_enabled = 0;
> > +}
> > +
> >   /* local subsystem functions */
> >   static Eina_Bool
> >   _e_bindings_mapping_change_event_cb(void *data __UNUSED__, int type
> __UNUSED__, void *event __UNUSED__)
> >   {
> > Ecore_X_Event_Mapping_Change *ev = event;
> > -  fprintf(stderr, "MAPPING CHANGE: type: %d || keycode: %d || num:
> %d\n", ev->type, ev->keycode, ev->num);
> > +  if (!_e_bindings_mapping_change_enabled) return ECORE_CALLBACK_RENEW;
> > e_managers_keys_ungrab();
> > e_border_button_bindings_ungrab_all();
> > e_border_button_bindings_grab_all();
> >
> > Modified: trunk/e/src/bin/e_bindings.h
> > ===
> > --- trunk/e/src/bin/e_bindings.h  2012-08-06 09:48:34 UTC (rev 74918)
> > +++ trunk/e/src/bin/e_bindings.h  2012-08-06 10:21:41 UTC (rev 74919)
> > @@ -149,6 +149,7 @@
> >   EAPI void e_bindings_acpi_del(E_Binding_Context ctxt, int type, int
> status, const char *action, const char *params);
> >   EAPI E_Action *e_bindings_acpi_find(E_Binding_Context ctxt, E_Object
> *obj, E_Event_Acpi *ev, E_Binding_Acpi **bind_ret);
> >   EAPI E_Action *e_bindings_acpi_event_handle(E_Binding_Context ctxt,
> E_Object *obj, E_Event_Acpi *ev);
> > +EAPI void e_bindings_mapping_change_enable(Eina_Bool enable);
> >
> >   #endif
> >   #endif
> >
> > Modified: trunk/e/src/bin/e_border.c
> > ===
> > --- trunk/e/src/bin/e_border.c2012-08-06 09:48:34 UTC (rev 74918)
> > +++ trunk/e/src/bin/e_border.c2012-08-06 10:21:41 UTC (rev 74919)
> > @@ -4574,7 +4574,11 @@
> >  if (bd->client.icccm.name)
> >eina_stringshare_del(bd->client.icccm.name);
> >  if (bd->client.icccm.class)
> > - eina_stringshare_del(bd->client.icccm.class);
> > + {
> > +if (!strcmp(bd->client.icccm.class, "Vmplayer"))
> > +  e_bindings_mapping_change_enable(EINA_FALSE);
> > +eina_stringshare_del(bd->client.icccm.class);
> > + }
> >  if (bd->client.icccm.title)
> >eina_stringshare_del(bd->client.icccm.title);
> >  if (bd->client.icccm.icon_name)
> > @@ -6650,11 +6654,13 @@
> >   const char *pname, *pclass;
> >   char *nname, *nclass;
> >
> > - ecore_x_icccm_name_class_get(bd->client.win, &nname, &nclass);
> > +ecore_x_icccm_name_class_get(bd->client.win, &nname, &nclass);
> >   pname = bd->client.icccm.name;
> >   pclass = bd->client.icccm.class;
> >   bd->client.icccm.name = eina_stringshare_add(nname);
> >   bd->client.icccm.class = eina_stringshare_add(nclass);
> > +if (bd->client.icccm.class && (!strcmp(bd->client.icccm.class,
> "Vmplayer")))
> > +  e_bindings_mapping_change_enable(EINA_FALSE);
> >   if (nname) free(nname);
> >   if (nclass) free(nclass);
> >
> >
> >
> >
> --
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond. Discussions
> > will include endpoint security, mobile security and the latest in malware
> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Sebastian Dransfeld]

Should both calls to e_bindings_mapping_change_enable() be with argument 
FALSE?

S.

On 08/06/2012 12:21 PM, Enlightenment SVN wrote:
> Log:
> add an amazing hack which, when a vmware player window is opened, disables 
> keyboard remapping until the window is closed. this is stupid, but seems to 
> be the only way to keep it from breaking keymaps on some setups
>ticket #1057
>
>
> Author:   discomfitor
> Date: 2012-08-06 03:21:41 -0700 (Mon, 06 Aug 2012)
> New Revision: 74919
> Trac: http://trac.enlightenment.org/e/changeset/74919
>
> Modified:
>trunk/e/src/bin/e_bindings.c trunk/e/src/bin/e_bindings.h 
> trunk/e/src/bin/e_border.c
>
> Modified: trunk/e/src/bin/e_bindings.c
> ===
> --- trunk/e/src/bin/e_bindings.c  2012-08-06 09:48:34 UTC (rev 74918)
> +++ trunk/e/src/bin/e_bindings.c  2012-08-06 10:21:41 UTC (rev 74919)
> @@ -24,6 +24,7 @@
>   static Eina_List *signal_bindings = NULL;
>   static Eina_List *wheel_bindings = NULL;
>   static Eina_List *acpi_bindings = NULL;
> +static int _e_bindings_mapping_change_enabled = 1;
>
>   typedef struct _E_Binding_Edge_Data E_Binding_Edge_Data;
>
> @@ -1077,12 +1078,23 @@
>  return act;
>   }
>
> +EAPI void
> +e_bindings_mapping_change_enable(Eina_Bool enable)
> +{
> +   if (enable)
> + _e_bindings_mapping_change_enabled++;
> +   else
> + _e_bindings_mapping_change_enabled--;
> +   if (_e_bindings_mapping_change_enabled < 0)
> + _e_bindings_mapping_change_enabled = 0;
> +}
> +
>   /* local subsystem functions */
>   static Eina_Bool
>   _e_bindings_mapping_change_event_cb(void *data __UNUSED__, int type 
> __UNUSED__, void *event __UNUSED__)
>   {
> Ecore_X_Event_Mapping_Change *ev = event;
> -  fprintf(stderr, "MAPPING CHANGE: type: %d || keycode: %d || num: %d\n", 
> ev->type, ev->keycode, ev->num);
> +  if (!_e_bindings_mapping_change_enabled) return ECORE_CALLBACK_RENEW;
> e_managers_keys_ungrab();
> e_border_button_bindings_ungrab_all();
> e_border_button_bindings_grab_all();
>
> Modified: trunk/e/src/bin/e_bindings.h
> ===
> --- trunk/e/src/bin/e_bindings.h  2012-08-06 09:48:34 UTC (rev 74918)
> +++ trunk/e/src/bin/e_bindings.h  2012-08-06 10:21:41 UTC (rev 74919)
> @@ -149,6 +149,7 @@
>   EAPI void e_bindings_acpi_del(E_Binding_Context ctxt, int type, int status, 
> const char *action, const char *params);
>   EAPI E_Action *e_bindings_acpi_find(E_Binding_Context ctxt, E_Object *obj, 
> E_Event_Acpi *ev, E_Binding_Acpi **bind_ret);
>   EAPI E_Action *e_bindings_acpi_event_handle(E_Binding_Context ctxt, 
> E_Object *obj, E_Event_Acpi *ev);
> +EAPI void e_bindings_mapping_change_enable(Eina_Bool enable);
>
>   #endif
>   #endif
>
> Modified: trunk/e/src/bin/e_border.c
> ===
> --- trunk/e/src/bin/e_border.c2012-08-06 09:48:34 UTC (rev 74918)
> +++ trunk/e/src/bin/e_border.c2012-08-06 10:21:41 UTC (rev 74919)
> @@ -4574,7 +4574,11 @@
>  if (bd->client.icccm.name)
>eina_stringshare_del(bd->client.icccm.name);
>  if (bd->client.icccm.class)
> - eina_stringshare_del(bd->client.icccm.class);
> + {
> +if (!strcmp(bd->client.icccm.class, "Vmplayer"))
> +  e_bindings_mapping_change_enable(EINA_FALSE);
> +eina_stringshare_del(bd->client.icccm.class);
> + }
>  if (bd->client.icccm.title)
>eina_stringshare_del(bd->client.icccm.title);
>  if (bd->client.icccm.icon_name)
> @@ -6650,11 +6654,13 @@
>   const char *pname, *pclass;
>   char *nname, *nclass;
>
> - ecore_x_icccm_name_class_get(bd->client.win, &nname, &nclass);
> +ecore_x_icccm_name_class_get(bd->client.win, &nname, &nclass);
>   pname = bd->client.icccm.name;
>   pclass = bd->client.icccm.class;
>   bd->client.icccm.name = eina_stringshare_add(nname);
>   bd->client.icccm.class = eina_stringshare_add(nclass);
> +if (bd->client.icccm.class && (!strcmp(bd->client.icccm.class, 
> "Vmplayer")))
> +  e_bindings_mapping_change_enable(EINA_FALSE);
>   if (nname) free(nname);
>   if (nclass) free(nclass);
>
>
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>


--
Live S

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[David Seikel]

On Fri, 20 Jul 2012 10:45:58 +0100 Michael Blumenkrantz
 wrote:

> it was far simpler to add this than to figure out maug and then add
> yet more hash keys/lookups
> 
> On Fri, Jul 20, 2012 at 10:34 AM, Carsten Haitzler
> wrote:
> 
> > On Fri, 20 Jul 2012 18:12:40 +1000 David Seikel 
> > said:
> >
> > > On Thu, 19 Jul 2012 02:05:34 -0700 "Enlightenment SVN"
> > >  wrote:
> > >
> > > > Log:
> > > > add mechanism for injecting entries into border menus
> > >
> > > Didn't we have that years ago?  Did it bit rot or something?
> >
> > this looks like re-inventing the maug (menu augmentation) system
> > already there
> > - the border client menu just never had any maug points added. :)

My point is that it exists already, and has done so since at least 2005.
E17 had the ability for modules to add things to window border menus,
window border maximise menu, and window border stacking menus, waaay
back in 2005.  I know this coz I just looked up my ancient emu module
source code, which actually used those menu hooks at the time.

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

it was far simpler to add this than to figure out maug and then add yet
more hash keys/lookups

On Fri, Jul 20, 2012 at 10:34 AM, Carsten Haitzler wrote:

> On Fri, 20 Jul 2012 18:12:40 +1000 David Seikel  said:
>
> > On Thu, 19 Jul 2012 02:05:34 -0700 "Enlightenment SVN"
> >  wrote:
> >
> > > Log:
> > > add mechanism for injecting entries into border menus
> >
> > Didn't we have that years ago?  Did it bit rot or something?
>
> this looks like re-inventing the maug (menu augmentation) system already
> there
> - the border client menu just never had any maug points added. :)
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
>
>
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[David Seikel]

On Fri, 20 Jul 2012 18:34:07 +0900 Carsten Haitzler (The Rasterman)
 wrote:

> On Fri, 20 Jul 2012 18:12:40 +1000 David Seikel 
> said:
> 
> > On Thu, 19 Jul 2012 02:05:34 -0700 "Enlightenment SVN"
> >  wrote:
> > 
> > > Log:
> > > add mechanism for injecting entries into border menus
> > 
> > Didn't we have that years ago?  Did it bit rot or something?
> 
> this looks like re-inventing the maug (menu augmentation) system
> already there
> - the border client menu just never had any maug points added. :)

Thought I was using it long ago in the emu module.  lol

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[The Rasterman]

On Fri, 20 Jul 2012 18:12:40 +1000 David Seikel  said:

> On Thu, 19 Jul 2012 02:05:34 -0700 "Enlightenment SVN"
>  wrote:
> 
> > Log:
> > add mechanism for injecting entries into border menus
> 
> Didn't we have that years ago?  Did it bit rot or something?

this looks like re-inventing the maug (menu augmentation) system already there
- the border client menu just never had any maug points added. :)

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[David Seikel]

On Thu, 19 Jul 2012 02:05:34 -0700 "Enlightenment SVN"
 wrote:

> Log:
> add mechanism for injecting entries into border menus

Didn't we have that years ago?  Did it bit rot or something?

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On 19/07/12 16:41, Michael Blumenkrantz wrote:
> as the quote implies, efm now does wildcard matching in its typebuf just
> like a shell

The commit message made sense, this email does not.

--
Tom.


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

as the quote implies, efm now does wildcard matching in its typebuf just
like a shell

On Thu, Jul 19, 2012 at 2:40 PM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:

> Log:
> "when I was a boy, all the file managers did glob matching with their
> typebufs, and they could do it uphill both ways in the snow! barefoot!"
>   -rasterman (18 July 2012)
>
>
> Author:   discomfitor
> Date: 2012-07-19 06:40:11 -0700 (Thu, 19 Jul 2012)
> New Revision: 74190
> Trac: http://trac.enlightenment.org/e/changeset/74190
>
> Modified:
>   trunk/e/src/bin/e_fm.c
>
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[P Purkayastha]

On Tuesday, March 13, 2012 9:27:08 AM UTC+8, P Purkayastha wrote:
>
> On Tuesday, March 13, 2012 4:08:23 AM UTC+8, David Seikel wrote:
> >
> > On Mon, 12 Mar 2012 10:47:27 -0700 "Enlightenment SVN"
> >  wrote:
> >
> > > Log:
> > > revert all window menu changes since august of last year
> > >   
> > >   I tried to like the new layout, but it required way too much
> > > navigation for most commonly used functions if people really liked
> > > the other layout, perhaps it can be merged as a config option. 
> >
> > N!!
> >
> > Now it sucks again.  Most commonly used functions for you is not most
> > commonly used functions for others.
> >
> > Some functions are in there twice.
> >
> +1
>
> The earlier layout was really bad with some options 3 levels deep. This 
> layout since last August was much better.
>
 
Just to clarify. I use sticky, maximize vertically/horizontally, and move 
to desktop, and all those options were one level down in the menu. Not so 
for the older menu. Once in a blue moon, I need to use the "always on top" 
and even this option is one level down.
--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[David Seikel]

On Mon, 12 Mar 2012 21:35:48 +0100 Leif Middelschulte
 wrote:

> 2012/3/12 Michael Blumenkrantz :
> > On Tue, 13 Mar 2012 06:08:23 +1000
> > David Seikel  wrote:
> >
> >> On Mon, 12 Mar 2012 10:47:27 -0700 "Enlightenment SVN"
> >>  wrote:
> >>
> >> > Log:
> >> > revert all window menu changes since august of last year
> >> >
> >> >   I tried to like the new layout, but it required way too much
> >> > navigation for most commonly used functions if people really
> >> > liked the other layout, perhaps it can be merged as a config
> >> > option.
> >>
> >> N!!
> +1
> >>
> >> Now it sucks again.  Most commonly used functions for you is not
> >> most commonly used functions for others.
> >>
> >> Some functions are in there twice.
> >>
> >
> > I never use this menu. These changes were made as a result of
> > feedback (constant nagging) from users. As yet, you are literally
> > the only person I have heard who liked the other layout.

Now there's two of us, plus whoever changed it before.

How about moving iconify and the maximize menu to the top level?  Or
copy if you insist on having duplicates.

Hmm, just noticed we now have two sticky's AND a pin to desktop.  Same
thing?

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[P Purkayastha]

On Tuesday, March 13, 2012 4:08:23 AM UTC+8, David Seikel wrote:
>
> On Mon, 12 Mar 2012 10:47:27 -0700 "Enlightenment SVN"
>  wrote:
>
> > Log:
> > revert all window menu changes since august of last year
> >   
> >   I tried to like the new layout, but it required way too much
> > navigation for most commonly used functions if people really liked
> > the other layout, perhaps it can be merged as a config option. 
>
> N!!
>
> Now it sucks again.  Most commonly used functions for you is not most
> commonly used functions for others.
>
> Some functions are in there twice.
>
+1

The earlier layout was really bad with some options 3 levels deep. This 
layout since last August was much better.
--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Leif Middelschulte]

2012/3/12 Michael Blumenkrantz :
> On Tue, 13 Mar 2012 06:08:23 +1000
> David Seikel  wrote:
>
>> On Mon, 12 Mar 2012 10:47:27 -0700 "Enlightenment SVN"
>>  wrote:
>>
>> > Log:
>> > revert all window menu changes since august of last year
>> >
>> >   I tried to like the new layout, but it required way too much
>> > navigation for most commonly used functions if people really liked
>> > the other layout, perhaps it can be merged as a config option.
>>
>> N!!
+1
>>
>> Now it sucks again.  Most commonly used functions for you is not most
>> commonly used functions for others.
>>
>> Some functions are in there twice.
>>
>
> I never use this menu. These changes were made as a result of feedback 
> (constant
> nagging) from users. As yet, you are literally the only person I have heard 
> who
> liked the other layout.
>
> --
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



-- 
Leif

--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Tue, 13 Mar 2012 06:08:23 +1000
David Seikel  wrote:

> On Mon, 12 Mar 2012 10:47:27 -0700 "Enlightenment SVN"
>  wrote:
> 
> > Log:
> > revert all window menu changes since august of last year
> >   
> >   I tried to like the new layout, but it required way too much
> > navigation for most commonly used functions if people really liked
> > the other layout, perhaps it can be merged as a config option. 
> 
> N!!
> 
> Now it sucks again.  Most commonly used functions for you is not most
> commonly used functions for others.
> 
> Some functions are in there twice.
> 

I never use this menu. These changes were made as a result of feedback (constant
nagging) from users. As yet, you are literally the only person I have heard who
liked the other layout.

--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[David Seikel]

On Mon, 12 Mar 2012 10:47:27 -0700 "Enlightenment SVN"
 wrote:

> Log:
> revert all window menu changes since august of last year
>   
>   I tried to like the new layout, but it required way too much
> navigation for most commonly used functions if people really liked
> the other layout, perhaps it can be merged as a config option. 

N!!

Now it sucks again.  Most commonly used functions for you is not most
commonly used functions for others.

Some functions are in there twice.

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Sat, 24 Dec 2011 12:06:07 +0100
Cedric BAIL  wrote:

> On Sat, Dec 24, 2011 at 8:44 AM, Enlightenment SVN
>  wrote:
> > Log:
> > maybe prevent a leak but probably not
> >
> >
> > Author:       discomfitor
> > Date:         2011-12-23 23:44:07 -0800 (Fri, 23 Dec 2011)
> > New Revision: 66492
> > Trac:         http://trac.enlightenment.org/e/changeset/66492
> >
> > Modified:
> >  trunk/e/src/bin/e_backlight.c
> >
> > Modified: trunk/e/src/bin/e_backlight.c
> > ===
> > --- trunk/e/src/bin/e_backlight.c       2011-12-24 07:29:21 UTC (rev 66491)
> > +++ trunk/e/src/bin/e_backlight.c       2011-12-24 07:44:07 UTC (rev 66492)
> > @@ -254,7 +254,10 @@
> >         if (!devs) return;
> >      }
> >    EINA_LIST_FREE(devs, f)
> > -     bl_sysval = f;
> > +     {
> > +        eina_stringshare_replace(&bl_sysval, NULL);
> > +        bl_sysval = f;
> > +     }
> 
> This one is very strange. I don't see the rest of the code, but the
> normal use would have been eina_stringshare_replace(&bl_sysval, f).
> Your use can lead to the premature death of f.
> 
> >  }
> >
> >  static void
> >
> >
> > --
> > Write once. Port to many.
> > Get the SDK and tools to simplify cross-platform app development. Create
> > new or port existing apps to sell to consumers worldwide. Explore the
> > Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> > http://p.sf.net/sfu/intel-appdev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> 
> 
> 
you'll just have to trust me when I say that it's fine

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Cedric BAIL]

On Sat, Dec 24, 2011 at 8:44 AM, Enlightenment SVN
 wrote:
> Log:
> maybe prevent a leak but probably not
>
>
> Author:       discomfitor
> Date:         2011-12-23 23:44:07 -0800 (Fri, 23 Dec 2011)
> New Revision: 66492
> Trac:         http://trac.enlightenment.org/e/changeset/66492
>
> Modified:
>  trunk/e/src/bin/e_backlight.c
>
> Modified: trunk/e/src/bin/e_backlight.c
> ===
> --- trunk/e/src/bin/e_backlight.c       2011-12-24 07:29:21 UTC (rev 66491)
> +++ trunk/e/src/bin/e_backlight.c       2011-12-24 07:44:07 UTC (rev 66492)
> @@ -254,7 +254,10 @@
>         if (!devs) return;
>      }
>    EINA_LIST_FREE(devs, f)
> -     bl_sysval = f;
> +     {
> +        eina_stringshare_replace(&bl_sysval, NULL);
> +        bl_sysval = f;
> +     }

This one is very strange. I don't see the rest of the code, but the
normal use would have been eina_stringshare_replace(&bl_sysval, f).
Your use can lead to the premature death of f.

>  }
>
>  static void
>
>
> --
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>



-- 
Cedric BAIL

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Michael Blumenkrantz]

On Sat, 24 Dec 2011 09:21:17 +0100
Vincent Torri  wrote:

> > --- trunk/e/src/bin/e_backlight_main.c  2011-12-24 07:44:07 UTC (rev 66492)
> > +++ trunk/e/src/bin/e_backlight_main.c  2011-12-24 07:44:18 UTC (rev 66493)
> > @@ -104,6 +104,9 @@
> >              return _bl_write_file(buf, curlevel);
> >           }
> >         eina_stringshare_del(f);
> > +        /* Currently this will set brightness levels on ALL detected
> > devices
> > +           If this is not desired, add a break here
> > +         */
> 
> you should add a big FIXME in the comment
> 
> Vincent
> 
> >      }
> >
> >    return -1;
> >
> >
perhaps, but there's a fixme in the other part of the backlight code. anyone
who knows backlight internals enough to tinker with them will look in both
places.

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

> --- trunk/e/src/bin/e_backlight_main.c  2011-12-24 07:44:07 UTC (rev 66492)
> +++ trunk/e/src/bin/e_backlight_main.c  2011-12-24 07:44:18 UTC (rev 66493)
> @@ -104,6 +104,9 @@
>              return _bl_write_file(buf, curlevel);
>           }
>         eina_stringshare_del(f);
> +        /* Currently this will set brightness levels on ALL detected devices
> +           If this is not desired, add a break here
> +         */

you should add a big FIXME in the comment

Vincent

>      }
>
>    return -1;
>
>
> --
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Boris Faure]

On Tue, Nov 8, 2011 at 00:53, Enlightenment SVN
 wrote:
> Log:
> I don't spend hours and hours and hours and days of my free time hacking on 
> ecrustify for people to not use it.
[…]
> -#define Ecore_X_Randr_None   0
> +#define Ecore_X_Randr_None  0
>  #define Ecore_X_Randr_Unset -1

ecrustify doesn't seem to pad correctly when defined value start with '-'.

-- 
Boris Faure

--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Lucas De Marchi]

On Mon, Nov 7, 2011 at 9:54 PM, Christopher Michael
 wrote:
> On 11/07/11 18:53, Enlightenment SVN wrote:
>> Log:
>> I don't spend hours and hours and hours and days of my free time hacking on 
>> ecrustify for people to not use it.
>>
>>
>> Author:       discomfitor
>> Date:         2011-11-07 15:53:01 -0800 (Mon, 07 Nov 2011)
>> New Revision: 64917
>> Trac:         http://trac.enlightenment.org/e/changeset/64917
>>
>> Modified:
>>    trunk/e/src/bin/e_randr.c
>>
>> Modified: trunk/e/src/bin/e_randr.c
>> ===
>
> Then the only solution is to stop wasting your hours & hours :P

come on, the coding style is already not the prettiest things in the
world. But sticking to it will at least being consistent throught out
EFL.

And discomfitor is doing a great work with ecrustify.


Lucas De Marchi

--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Christopher Michael]

On 11/07/11 18:53, Enlightenment SVN wrote:
> Log:
> I don't spend hours and hours and hours and days of my free time hacking on 
> ecrustify for people to not use it.
>
>
> Author:   discomfitor
> Date: 2011-11-07 15:53:01 -0800 (Mon, 07 Nov 2011)
> New Revision: 64917
> Trac: http://trac.enlightenment.org/e/changeset/64917
>
> Modified:
>trunk/e/src/bin/e_randr.c
>
> Modified: trunk/e/src/bin/e_randr.c
> ===

Then the only solution is to stop wasting your hours & hours :P

dh

--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

eina suffix or whatever eina function to detect suffi ?

Vincent

On Thu, 11 Aug 2011, Enlightenment SVN wrote:

> Log:
> fix segv
>
>
> Author:   discomfitor
> Date: 2011-08-11 14:39:10 -0700 (Thu, 11 Aug 2011)
> New Revision: 62362
> Trac: http://trac.enlightenment.org/e/changeset/62362
>
> Modified:
>  trunk/e/src/bin/e_bg.c
>
> Modified: trunk/e/src/bin/e_bg.c
> ===
> --- trunk/e/src/bin/e_bg.c2011-08-11 21:35:17 UTC (rev 62361)
> +++ trunk/e/src/bin/e_bg.c2011-08-11 21:39:10 UTC (rev 62362)
> @@ -296,7 +296,7 @@
>   evas_object_clip_set(o, zone->bg_clip_object);
>   evas_object_show(o);
>  }
> -   ext = strrchr(bgfile, '.');
> +   if (bgfile) ext = strrchr(bgfile, '.');
>if ((ext) && (!strcasecmp(ext, ".edj")))
>  {
> o = edje_object_add(zone->container->bg_evas);
>
>
> --
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it.
> http://p.sf.net/sfu/wandisco-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. 
http://p.sf.net/sfu/wandisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Mike Blumenkrantz]

On Sun, 16 Jan 2011 03:51:18 +0100 (CET)
Vincent Torri  wrote:

> 
> 
> On Sat, 15 Jan 2011, Enlightenment SVN wrote:
> 
> > Log:
> > avoid possible strlen(NULL)
> >
> >
> > Author:   discomfitor
> > Date: 2011-01-15 17:11:46 -0800 (Sat, 15 Jan 2011)
> > New Revision: 56144
> > Trac: http://trac.enlightenment.org/e/changeset/56144
> >
> > Modified:
> >  trunk/e/src/bin/e_menu.c
> >
> > Modified: trunk/e/src/bin/e_menu.c
> > ===
> > --- trunk/e/src/bin/e_menu.c2011-01-15 20:25:44 UTC (rev 56143)
> > +++ trunk/e/src/bin/e_menu.c2011-01-16 01:11:46 UTC (rev 56144)
> > @@ -619,10 +619,13 @@
> >if (mi->icon_key) eina_stringshare_del(mi->icon_key);
> >mi->icon = NULL;
> >mi->icon_key = NULL;
> > -   if (icon) mi->icon = eina_stringshare_add(icon);
> > -   len = strlen(icon);
> > -   if ((len > 4) && (!strcasecmp(icon + len - 4, ".edj")))
> > -  mi->icon_key = eina_stringshare_add("icon");
> > +   if (icon)
> > + {
> > +mi->icon = eina_stringshare_add(icon);
> > +len = strlen(icon);
> > +if ((len > 4) && (!strcasecmp(icon + len - 4, ".edj")))
> > +  mi->icon_key = eina_stringshare_add("icon");
> 
> use eina_str_has_suffix() function
> 
> > + }
> >mi->changed = 1;
> >mi->menu->changed = 1;
> > }
> >
> >
ah I was just fixing a null segv, not modifying any existing code

-- 
Mike Blumenkrantz
Zentific: NULL pointer dereferences now 50% off!

--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

On Sat, 15 Jan 2011, Enlightenment SVN wrote:

> Log:
> avoid possible strlen(NULL)
>
>
> Author:   discomfitor
> Date: 2011-01-15 17:11:46 -0800 (Sat, 15 Jan 2011)
> New Revision: 56144
> Trac: http://trac.enlightenment.org/e/changeset/56144
>
> Modified:
>  trunk/e/src/bin/e_menu.c
>
> Modified: trunk/e/src/bin/e_menu.c
> ===
> --- trunk/e/src/bin/e_menu.c  2011-01-15 20:25:44 UTC (rev 56143)
> +++ trunk/e/src/bin/e_menu.c  2011-01-16 01:11:46 UTC (rev 56144)
> @@ -619,10 +619,13 @@
>if (mi->icon_key) eina_stringshare_del(mi->icon_key);
>mi->icon = NULL;
>mi->icon_key = NULL;
> -   if (icon) mi->icon = eina_stringshare_add(icon);
> -   len = strlen(icon);
> -   if ((len > 4) && (!strcasecmp(icon + len - 4, ".edj")))
> -  mi->icon_key = eina_stringshare_add("icon");
> +   if (icon)
> + {
> +mi->icon = eina_stringshare_add(icon);
> +len = strlen(icon);
> +if ((len > 4) && (!strcasecmp(icon + len - 4, ".edj")))
> +  mi->icon_key = eina_stringshare_add("icon");

use eina_str_has_suffix() function

> + }
>mi->changed = 1;
>mi->menu->changed = 1;
> }
>
>
> --
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them. Understand
> malware threats, the impact they can have on your business, and how you
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin/e_fm

[Mike Blumenkrantz]

On Wed, 12 Jan 2011 11:55:23 +1000
David Seikel  wrote:

> On Tue, 11 Jan 2011 17:44:08 -0800 "Enlightenment SVN"
>  wrote:
> 
> > Log:
> > okay, so to check for udisks I've done the following:
> >   1) set a signal handler to watch for udisks starting
> >   2) check for udisks already running
> >   3) send dbus method call to udisks regardless of run state
> >   4) free error which is 100% guaranteed to occur
> >   5) either pick up udisks from signal handler or from random dbus
> > call 6) finally start efm
> >   7) drink heavily.
> 
> You forgot -
> 
> 8) 
> 9) Profit!!!
No.  I most definitely did not.

-- 
Mike Blumenkrantz
Zentific: NULL pointer dereferences now 50% off!

--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin/e_fm

[David Seikel]

On Tue, 11 Jan 2011 17:44:08 -0800 "Enlightenment SVN"
 wrote:

> Log:
> okay, so to check for udisks I've done the following:
>   1) set a signal handler to watch for udisks starting
>   2) check for udisks already running
>   3) send dbus method call to udisks regardless of run state
>   4) free error which is 100% guaranteed to occur
>   5) either pick up udisks from signal handler or from random dbus
> call 6) finally start efm
>   7) drink heavily.

You forgot -

8) 
9) Profit!!!


signature.asc
Description: PGP signature
--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Mike Blumenkrantz]

On Thu, 23 Dec 2010 18:41:24 +0100
"Kim Woelders"  wrote:

> On Thu, 23 Dec 2010 17:47:06 +0100, Enlightenment SVN  
>  wrote:
> 
> > Log:
> > fix sizeof use, thanks to kim woelders
> >
> > Author:   discomfitor
> > Date: 2010-12-23 08:47:05 -0800 (Thu, 23 Dec 2010)
> > New Revision: 55739
> > Trac: http://trac.enlightenment.org/e/changeset/55739
> >
> > Modified:
> >   trunk/e/src/bin/e_hints.c
> >
> > Modified: trunk/e/src/bin/e_hints.c
> > ===
> > --- trunk/e/src/bin/e_hints.c   2010-12-23 12:47:23 UTC (rev 55738)
> > +++ trunk/e/src/bin/e_hints.c   2010-12-23 16:47:05 UTC (rev 55739)
> > @@ -1435,7 +1435,8 @@
> >  int num, i;
> > memset(state, 0, sizeof(state));
> > -num = ecore_x_window_prop_card32_get(bd->client.win,  
> > E_ATOM_WINDOW_STATE, state, sizeof(state));
> > +num = ecore_x_window_prop_card32_get(bd->client.win,  
> > E_ATOM_WINDOW_STATE,
> > +  state, sizeof(state) / sizeof(state[0]); /* ugly, but avoids  
> > possible future overflow if more states are added */
> >  if (!num) return;
> > for (i = 0; (i < num) && (i < sizeof(state)); i++)
> >
> Sorry about going on here, but if the (i < sizeof(state)) condition makes  
> clang happy it's just silly.
> This check ensures that i < 4 but clang should be clever enough to see  
> that accessing state[1] is bad.
> 
> /Kim
Well yes, that's the point.  clang sees that it could potentially overflow the
buffer there and thus generates a warning.  it's super pedantic, but that's the
idea.

-- 
Mike Blumenkrantz
Zentific: We run the three-legged race individually.

--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Kim Woelders]

On Thu, 23 Dec 2010 17:47:06 +0100, Enlightenment SVN  
 wrote:

> Log:
> fix sizeof use, thanks to kim woelders
>
> Author:   discomfitor
> Date: 2010-12-23 08:47:05 -0800 (Thu, 23 Dec 2010)
> New Revision: 55739
> Trac: http://trac.enlightenment.org/e/changeset/55739
>
> Modified:
>   trunk/e/src/bin/e_hints.c
>
> Modified: trunk/e/src/bin/e_hints.c
> ===
> --- trunk/e/src/bin/e_hints.c 2010-12-23 12:47:23 UTC (rev 55738)
> +++ trunk/e/src/bin/e_hints.c 2010-12-23 16:47:05 UTC (rev 55739)
> @@ -1435,7 +1435,8 @@
>  int num, i;
> memset(state, 0, sizeof(state));
> -num = ecore_x_window_prop_card32_get(bd->client.win,  
> E_ATOM_WINDOW_STATE, state, sizeof(state));
> +num = ecore_x_window_prop_card32_get(bd->client.win,  
> E_ATOM_WINDOW_STATE,
> +  state, sizeof(state) / sizeof(state[0]); /* ugly, but avoids  
> possible future overflow if more states are added */
>  if (!num) return;
> for (i = 0; (i < num) && (i < sizeof(state)); i++)
>
Sorry about going on here, but if the (i < sizeof(state)) condition makes  
clang happy it's just silly.
This check ensures that i < 4 but clang should be clever enough to see  
that accessing state[1] is bad.

/Kim

--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Mike Blumenkrantz]

On Thu, 23 Dec 2010 17:31:24 +0100
"Kim Woelders"  wrote:

> On Thu, 23 Dec 2010 17:15:13 +0100, Mike Blumenkrantz   
> wrote:
> 
> > On Thu, 23 Dec 2010 16:50:19 +0100
> > "Kim Woelders"  wrote:
> >
> >> On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN
> >>  wrote:
> >>
> >> > Log:
> >> > make this more portable in case the number of states changes in the
> >> > future, also outdent and make function params more explicit
> >> >
> >> > Author:   discomfitor
> >> > Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
> >> > New Revision: 55727
> >> > Trac: http://trac.enlightenment.org/e/changeset/55727
> >> >
> >> > Modified:
> >> >   trunk/e/src/bin/e_hints.c
> >> >
> >> > Modified: trunk/e/src/bin/e_hints.c
> >> > ===
> >> > --- trunk/e/src/bin/e_hints.c2010-12-23 00:28:49 UTC (rev 55726)
> >> > +++ trunk/e/src/bin/e_hints.c2010-12-23 00:36:53 UTC (rev 55727)
> >> > @@ -1432,18 +1432,16 @@
> >> >  {
> >> > /* Remember to update the count if we add more states! */
> >> >  Ecore_X_Atom state[1];
> >> > -int num;
> >> > +int num, i;
> >> > memset(state, 0, sizeof(state));
> >> > -num = ecore_x_window_prop_card32_get(bd->client.win,
> >> > E_ATOM_WINDOW_STATE, state, 1);
> >> > -if (num)
> >> > +num = ecore_x_window_prop_card32_get(bd->client.win,
> >> > E_ATOM_WINDOW_STATE, state, sizeof(state));
> >> ^^^
> >>
> >> > +if (!num) return;
> >> > +
> >> > +for (i = 0; (i < num) && (i < sizeof(state)); i++)
> >> ^^^
> >>
> >> >{
> >> > - int i;
> >> > - for (i = 0; i < num; i++)
> >> > -   {
> >> > -  if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
> >> > -bd->client.e.state.centered = 1;
> >> > -   }
> >> > + if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
> >> > +   bd->client.e.state.centered = 1;
> >> >}
> >> >  }
> >> >
> >> Just happened to notice...
> >> The use of sizeof(state) is wrong in the marked lines - should probably  
> >> be
> >> some #define or (sizeof(state)/sizeof(state[0])) or similar.
> > hmm since it's just passing the size of the array (1) isn't it fine?
> 
> sizeof(state) = 4.
touche.
> 
> >> The use in the second line is futhermore superfluous as
> >> ecore_x_window_prop_card32_get should never return num > the len  
> >> parameter
> >> (fourth argument).
> > yes, it seems obvious, but it caused a warning in clang so I stuck this  
> > in to
> > prevent future runs from picking it up.
> 
> IMO adding code for that reason is wrong. Isn't there some way to shut  
> clang up when it generates bogus warnings?
sadly no.
> 
> /Kim
> 
> --
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment, and, 
> should the need arise, upgrade to a full multi-node Oracle RAC database 
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
Mike Blumenkrantz
Zentific: We run the three-legged race individually.

--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Kim Woelders]

On Thu, 23 Dec 2010 17:15:13 +0100, Mike Blumenkrantz   
wrote:

> On Thu, 23 Dec 2010 16:50:19 +0100
> "Kim Woelders"  wrote:
>
>> On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN
>>  wrote:
>>
>> > Log:
>> > make this more portable in case the number of states changes in the
>> > future, also outdent and make function params more explicit
>> >
>> > Author:   discomfitor
>> > Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
>> > New Revision: 55727
>> > Trac: http://trac.enlightenment.org/e/changeset/55727
>> >
>> > Modified:
>> >   trunk/e/src/bin/e_hints.c
>> >
>> > Modified: trunk/e/src/bin/e_hints.c
>> > ===
>> > --- trunk/e/src/bin/e_hints.c  2010-12-23 00:28:49 UTC (rev 55726)
>> > +++ trunk/e/src/bin/e_hints.c  2010-12-23 00:36:53 UTC (rev 55727)
>> > @@ -1432,18 +1432,16 @@
>> >  {
>> > /* Remember to update the count if we add more states! */
>> >  Ecore_X_Atom state[1];
>> > -int num;
>> > +int num, i;
>> > memset(state, 0, sizeof(state));
>> > -num = ecore_x_window_prop_card32_get(bd->client.win,
>> > E_ATOM_WINDOW_STATE, state, 1);
>> > -if (num)
>> > +num = ecore_x_window_prop_card32_get(bd->client.win,
>> > E_ATOM_WINDOW_STATE, state, sizeof(state));
>> ^^^
>>
>> > +if (!num) return;
>> > +
>> > +for (i = 0; (i < num) && (i < sizeof(state)); i++)
>> ^^^
>>
>> >{
>> > - int i;
>> > - for (i = 0; i < num; i++)
>> > -   {
>> > -  if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
>> > -bd->client.e.state.centered = 1;
>> > -   }
>> > + if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
>> > +   bd->client.e.state.centered = 1;
>> >}
>> >  }
>> >
>> Just happened to notice...
>> The use of sizeof(state) is wrong in the marked lines - should probably  
>> be
>> some #define or (sizeof(state)/sizeof(state[0])) or similar.
> hmm since it's just passing the size of the array (1) isn't it fine?

sizeof(state) = 4.

>> The use in the second line is futhermore superfluous as
>> ecore_x_window_prop_card32_get should never return num > the len  
>> parameter
>> (fourth argument).
> yes, it seems obvious, but it caused a warning in clang so I stuck this  
> in to
> prevent future runs from picking it up.

IMO adding code for that reason is wrong. Isn't there some way to shut  
clang up when it generates bogus warnings?

/Kim

--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Mike Blumenkrantz]

On Thu, 23 Dec 2010 16:50:19 +0100
"Kim Woelders"  wrote:

> On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN  
>  wrote:
> 
> > Log:
> > make this more portable in case the number of states changes in the  
> > future, also outdent and make function params more explicit
> >
> > Author:   discomfitor
> > Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
> > New Revision: 55727
> > Trac: http://trac.enlightenment.org/e/changeset/55727
> >
> > Modified:
> >   trunk/e/src/bin/e_hints.c
> >
> > Modified: trunk/e/src/bin/e_hints.c
> > ===
> > --- trunk/e/src/bin/e_hints.c   2010-12-23 00:28:49 UTC (rev 55726)
> > +++ trunk/e/src/bin/e_hints.c   2010-12-23 00:36:53 UTC (rev 55727)
> > @@ -1432,18 +1432,16 @@
> >  {
> > /* Remember to update the count if we add more states! */
> >  Ecore_X_Atom state[1];
> > -int num;
> > +int num, i;
> > memset(state, 0, sizeof(state));
> > -num = ecore_x_window_prop_card32_get(bd->client.win,  
> > E_ATOM_WINDOW_STATE, state, 1);
> > -if (num)
> > +num = ecore_x_window_prop_card32_get(bd->client.win,  
> > E_ATOM_WINDOW_STATE, state, sizeof(state));
> ^^^
> 
> > +if (!num) return;
> > +
> > +for (i = 0; (i < num) && (i < sizeof(state)); i++)
> ^^^
> 
> >{
> > - int i;
> > - for (i = 0; i < num; i++)
> > -   {
> > -  if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
> > -bd->client.e.state.centered = 1;
> > -   }
> > + if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
> > +   bd->client.e.state.centered = 1;
> >}
> >  }
> >
> Just happened to notice...
> The use of sizeof(state) is wrong in the marked lines - should probably be  
> some #define or (sizeof(state)/sizeof(state[0])) or similar.
hmm since it's just passing the size of the array (1) isn't it fine?
> The use in the second line is futhermore superfluous as  
> ecore_x_window_prop_card32_get should never return num > the len parameter  
> (fourth argument).
yes, it seems obvious, but it caused a warning in clang so I stuck this in to
prevent future runs from picking it up.
> 
> /Kim
> 
> 
> 
> --
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment, and, 
> should the need arise, upgrade to a full multi-node Oracle RAC database 
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
Mike Blumenkrantz
Zentific: We run the three-legged race individually.

--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Kim Woelders]

On Thu, 23 Dec 2010 01:36:53 +0100, Enlightenment SVN  
 wrote:

> Log:
> make this more portable in case the number of states changes in the  
> future, also outdent and make function params more explicit
>
> Author:   discomfitor
> Date: 2010-12-22 16:36:53 -0800 (Wed, 22 Dec 2010)
> New Revision: 55727
> Trac: http://trac.enlightenment.org/e/changeset/55727
>
> Modified:
>   trunk/e/src/bin/e_hints.c
>
> Modified: trunk/e/src/bin/e_hints.c
> ===
> --- trunk/e/src/bin/e_hints.c 2010-12-23 00:28:49 UTC (rev 55726)
> +++ trunk/e/src/bin/e_hints.c 2010-12-23 00:36:53 UTC (rev 55727)
> @@ -1432,18 +1432,16 @@
>  {
> /* Remember to update the count if we add more states! */
>  Ecore_X_Atom state[1];
> -int num;
> +int num, i;
> memset(state, 0, sizeof(state));
> -num = ecore_x_window_prop_card32_get(bd->client.win,  
> E_ATOM_WINDOW_STATE, state, 1);
> -if (num)
> +num = ecore_x_window_prop_card32_get(bd->client.win,  
> E_ATOM_WINDOW_STATE, state, sizeof(state));
^^^

> +if (!num) return;
> +
> +for (i = 0; (i < num) && (i < sizeof(state)); i++)
^^^

>{
> - int i;
> - for (i = 0; i < num; i++)
> -   {
> -  if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
> -bd->client.e.state.centered = 1;
> -   }
> + if (state[i] == E_ATOM_WINDOW_STATE_CENTERED)
> +   bd->client.e.state.centered = 1;
>}
>  }
>
Just happened to notice...
The use of sizeof(state) is wrong in the marked lines - should probably be  
some #define or (sizeof(state)/sizeof(state[0])) or similar.
The use in the second line is futhermore superfluous as  
ecore_x_window_prop_card32_get should never return num > the len parameter  
(fourth argument).

/Kim



--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On Tue, 2010-10-05 at 21:56 +0800, Tom Haste wrote:
> I figured Id throw my $0.2 AUD into this...
> 
> Being a noob to the programming game, Just the ecore_init() seems fine
> by me as long as ecore_init() documentation also states that
> eina_init() happens with it. Seeing eina_init() and ecore_init() tells
> my noobie brain that one must happen before the other otherwise stuff
> might not work right.

I already commented on that, docs aren't everything.
Let's assume for a moment ecore does not want to use Eina anymore (but
keeps API the same), eina_init() is dropped from ecore_init() (because
it's not used) and the docs are updated to state that eina_init() is no
longer automatically issued.

In this scenario, an application with an explicit eina_init() will
continue to work just as well, while an application without the explicit
eina_init() will not. Both were written before the change in ecore, and
both read in the docs that eina_init() *is* automatically issued.

Do you get my point now?

--
Tom.


--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Haste]

I figured Id throw my $0.2 AUD into this...

Being a noob to the programming game, Just the ecore_init() seems fine
by me as long as ecore_init() documentation also states that
eina_init() happens with it. Seeing eina_init() and ecore_init() tells
my noobie brain that one must happen before the other otherwise stuff
might not work right.

I guess you could consider that the 'grandma' test.


On 5 October 2010 20:46, Tom Hacohen  wrote:
> On Tue, 2010-10-05 at 09:41 -0300, Iván Briano (Sachiel) wrote:
>> Still not good. There's a difference of relying on some component 
>> initializing
>> a library because it uses internally, and initializing it because it's
>> also giving
>> you back stuff from it. In the first case, yes, relying on that and not being
>> explicit can cause you problems in the future, but for the second, even if
>> Ecore can be built without Evas, ecore_evas_init() is pretty much guaranteed
>> to init Evas as well, unless something is very wrong somewhere. So being
>> explicit or not depends on you knowing what you are doing, which doesn't
>> necessarily imply that you know the internals of what you are using.
>
> ecore_init() says nothing about eina in any way or form. It's not like
> ecore_evas_init() which explicitly says "evas is there and will be
> used".
>
> As I said, this case is different because ecore will probably always use
> eina, but still, you can't say ecore_init() implies eina_init() will
> also be run.
>
> But yes I agree that libs that fall under this category:
> "Still not good. There's a difference of relying on some component
> initializing a library because it uses internally, and initializing it
> because it's also giving you back stuff from it."
>
> Are special cases (which ecore may be one of those, I'm not sure, I
> don't remember ecore's API by heart).
>
> --
> Tom.
>
>
>
>
> --
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On Tue, 2010-10-05 at 09:41 -0300, Iván Briano (Sachiel) wrote:
> Still not good. There's a difference of relying on some component initializing
> a library because it uses internally, and initializing it because it's
> also giving
> you back stuff from it. In the first case, yes, relying on that and not being
> explicit can cause you problems in the future, but for the second, even if
> Ecore can be built without Evas, ecore_evas_init() is pretty much guaranteed
> to init Evas as well, unless something is very wrong somewhere. So being
> explicit or not depends on you knowing what you are doing, which doesn't
> necessarily imply that you know the internals of what you are using.

ecore_init() says nothing about eina in any way or form. It's not like
ecore_evas_init() which explicitly says "evas is there and will be
used".

As I said, this case is different because ecore will probably always use
eina, but still, you can't say ecore_init() implies eina_init() will
also be run.

But yes I agree that libs that fall under this category:
"Still not good. There's a difference of relying on some component
initializing a library because it uses internally, and initializing it
because it's also giving you back stuff from it."

Are special cases (which ecore may be one of those, I'm not sure, I
don't remember ecore's API by heart).

--
Tom.




--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Sachiel]

On Tue, Oct 5, 2010 at 9:13 AM, Tom Hacohen
 wrote:
> On Tue, 2010-10-05 at 09:05 -0300, Iván Briano (Sachiel) wrote:
>> I think it's a very bad example, considering glib is an outside dependency.
>> On the other hand, given the amount of functions in the EFL that return an
>> Eina type, having your app break because you were not explicily initializing 
>> it,
>> in the case of it being dropped, is probably the least of your worries.
>>
>> Yes, I agree that sometimes it's better to be explicit, but generalizing 
>> every
>> case is not always a good idea.
>
> Like I said a couple of emails back: I'm not sure about this specific
> case, because eina is VERY depended on through all of efl. I was just
> saying (like as you just said) that sometimes (most of the times) it's
> better to be explicit.
>
> And yes, I agree glib+ecore wasn't a good example, that's why I changed
> it to ewebkit+glib :P
>

Still not good. There's a difference of relying on some component initializing
a library because it uses internally, and initializing it because it's
also giving
you back stuff from it. In the first case, yes, relying on that and not being
explicit can cause you problems in the future, but for the second, even if
Ecore can be built without Evas, ecore_evas_init() is pretty much guaranteed
to init Evas as well, unless something is very wrong somewhere. So being
explicit or not depends on you knowing what you are doing, which doesn't
necessarily imply that you know the internals of what you are using.

> --
> Tom.
>
>
>

--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On Tue, 2010-10-05 at 09:05 -0300, Iván Briano (Sachiel) wrote:
> I think it's a very bad example, considering glib is an outside dependency.
> On the other hand, given the amount of functions in the EFL that return an
> Eina type, having your app break because you were not explicily initializing 
> it,
> in the case of it being dropped, is probably the least of your worries.
> 
> Yes, I agree that sometimes it's better to be explicit, but generalizing every
> case is not always a good idea.

Like I said a couple of emails back: I'm not sure about this specific
case, because eina is VERY depended on through all of efl. I was just
saying (like as you just said) that sometimes (most of the times) it's
better to be explicit.

And yes, I agree glib+ecore wasn't a good example, that's why I changed
it to ewebkit+glib :P

--
Tom.




--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Sachiel]

On Tue, Oct 5, 2010 at 9:01 AM, Tom Hacohen
 wrote:
> On Tue, 2010-10-05 at 08:58 -0300, Iván Briano (Sachiel) wrote:
>> glib?
>
> I was just making a point, that we may have depended on glib in the past
> (no idea really, but for example ewebkit still in some cases depends on
> it) in ecore and all the applications that assumed ecore_init inits glib
> broke.
>

I think it's a very bad example, considering glib is an outside dependency.
On the other hand, given the amount of functions in the EFL that return an
Eina type, having your app break because you were not explicily initializing it,
in the case of it being dropped, is probably the least of your worries.

Yes, I agree that sometimes it's better to be explicit, but generalizing every
case is not always a good idea.

> --
> Tom.
>
>

--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On Tue, 2010-10-05 at 08:58 -0300, Iván Briano (Sachiel) wrote:
> glib?

I was just making a point, that we may have depended on glib in the past
(no idea really, but for example ewebkit still in some cases depends on
it) in ecore and all the applications that assumed ecore_init inits glib
broke.

--
Tom.



--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Sachiel]

On Tue, Oct 5, 2010 at 6:34 AM, Tom Hacohen
 wrote:
> On Tue, 2010-10-05 at 11:29 +0200, Vincent Torri wrote:
>> because it's useless ? That kind of stuff must be documented. If not, the
>> doc must be fixed. Hence, internal or not, a user knows what the
>> initialisation does.
>
> Useless: yes, costly: no, future-proof: more than without.
> What do you need to doc? everything you init? And let's say you do doc
> that you init eina, so the user of ecore_init sees that and doesn't init
> eina himself, all is good, until ecore_init stops initing eina and that
> application will break.
>
> Eina is an extreme example because it's unlikely to be dropped, but what
> about glib? glib was probably used before eina, and then one day it got
> dropped. It's the same idea, in different flavor.
>

glib?

> As I said, it doesn't really matter this time (because ffs it's eina),
> but I think explicitly stating what you need (in the code) is nicer and
> more obvious.
>
> --
> Tom.
>
>
> --
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On Tue, 2010-10-05 at 11:29 +0200, Vincent Torri wrote:
> because it's useless ? That kind of stuff must be documented. If not, the 
> doc must be fixed. Hence, internal or not, a user knows what the 
> initialisation does.

Useless: yes, costly: no, future-proof: more than without.
What do you need to doc? everything you init? And let's say you do doc
that you init eina, so the user of ecore_init sees that and doesn't init
eina himself, all is good, until ecore_init stops initing eina and that
application will break.

Eina is an extreme example because it's unlikely to be dropped, but what
about glib? glib was probably used before eina, and then one day it got
dropped. It's the same idea, in different flavor.

As I said, it doesn't really matter this time (because ffs it's eina),
but I think explicitly stating what you need (in the code) is nicer and
more obvious.

--
Tom.


--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

On Tue, 5 Oct 2010, Tom Hacohen wrote:

> On Tue, 2010-10-05 at 09:58 +0200, Vincent Torri wrote:
>> ecore_init calls eina_init, so it's useless
>
> As you said, it doesn't really matter, but I honestly find explicitly
> init-ing a good idea. You should never depend on internal design, even
> if you are the one who writes both parts.
>
> As I said, in this case it doesn't really matter, but, why not include
> it?

because it's useless ? That kind of stuff must be documented. If not, the 
doc must be fixed. Hence, internal or not, a user knows what the 
initialisation does.

Vincent

--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Tom Hacohen]

On Tue, 2010-10-05 at 09:58 +0200, Vincent Torri wrote:
> ecore_init calls eina_init, so it's useless

As you said, it doesn't really matter, but I honestly find explicitly
init-ing a good idea. You should never depend on internal design, even
if you are the one who writes both parts.

As I said, in this case it doesn't really matter, but, why not include
it?

--
Tom.




--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor trunk/e/src/bin

[Vincent Torri]

On Mon, 4 Oct 2010, Enlightenment SVN wrote:

> Log:
>  reorder inits
> Author:   discomfitor
> Date: 2010-10-04 23:33:12 -0700 (Mon, 04 Oct 2010)
> New Revision: 53048
>
> Modified:
>  trunk/e/src/bin/e_fm_main.c
>
> Modified: trunk/e/src/bin/e_fm_main.c
> ===
> --- trunk/e/src/bin/e_fm_main.c   2010-10-05 06:33:09 UTC (rev 53047)
> +++ trunk/e/src/bin/e_fm_main.c   2010-10-05 06:33:12 UTC (rev 53048)
> @@ -143,8 +143,8 @@
> }
>  }
>
> +   eina_init();
>ecore_init();

ecore_init calls eina_init, so it's useless

Vincent

> -   eina_init();
>ecore_app_args_set(argc, (const char **)argv);
>
>e_dbus_init();
>
>
> --
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel