Re: [E-devel] patch for the pager module, about window urgent state support
On Fri, 23 Mar 2007 16:24:55 +0100 Laurent Ghigonis <[EMAIL PROTECTED]> babbled: doesn't look too bad - in cvs :) > > Here is a little patch for the pager module, > > that basically able the user to show the pager popup on window urgent > > state change. > > I did some changes on my patch, the new one is attached. > > > Details of the patch : > > new from last patch : > * if the urgent window gets focused, close the > popup > * new from last patch : show popup if the urgent window is on the > current desk too, but is not focused > > old patch things : > * fix: show the urgent state of a window even if the urgent state was > set before the pager start > * show the urgent state of windows in the pager popup > * the pager pops its popup on window urgent state change (configurable) > * a desktop can be selected in the pager popup, but all other actions > actions are still forbidden inside the popup > > > It adds 3 options in the pager configuration panel : > 1. "show popup on urgent window" > 2. "urgent popup sticks on the screen" > 3. "urgent popup timer" > > > laurent 'kiwi_' -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
> Here is a little patch for the pager module,
> that basically able the user to show the pager popup on window urgent
> state change.
I did some changes on my patch, the new one is attached.
Details of the patch :
new from last patch :
* if the urgent window gets focused, close the
popup
* new from last patch : show popup if the urgent window is on the
current desk too, but is not focused
old patch things :
* fix: show the urgent state of a window even if the urgent state was
set before the pager start
* show the urgent state of windows in the pager popup
* the pager pops its popup on window urgent state change (configurable)
* a desktop can be selected in the pager popup, but all other actions
actions are still forbidden inside the popup
It adds 3 options in the pager configuration panel :
1. "show popup on urgent window"
2. "urgent popup sticks on the screen"
3. "urgent popup timer"
laurent 'kiwi_'? pager_e_mod_main.patch
? patch_e_mod_pager_urgentstate
Index: e_mod_config.c
===
RCS file: /cvs/e/e17/apps/e/src/modules/pager/e_mod_config.c,v
retrieving revision 1.27
diff -u -r1.27 e_mod_config.c
--- e_mod_config.c 3 Feb 2007 02:02:49 - 1.27
+++ e_mod_config.c 23 Mar 2007 11:41:25 -
@@ -12,6 +12,9 @@
{
int show_popup;
double popup_speed;
+ int show_popup_urgent;
+ int popup_urgent_stick;
+ double popup_urgent_speed;
int drag_resist;
unsigned char btn_drag;
unsigned char btn_noplace;
@@ -25,6 +28,8 @@
} grab;
struct {
+ Evas_Object *o_urgent_stick;
+ Evas_Object *o_urgent_speed;
Evas_Object *o_btn1;
Evas_Object *o_btn2;
} gui;
@@ -42,6 +47,7 @@
static void _grab_wnd_hide(E_Config_Dialog_Data *cfdata);
static int _grab_mouse_down_cb(void *data, int type, void *event);
static int _grab_key_down_cb(void *data, int type, void *event);
+static void _check_urgent_stick_cb_change(void *data, Evas_Object *obj);
void
_config_pager_module(Config_Item *ci)
@@ -73,6 +79,9 @@
/* FIXME: configure zone config item */
cfdata->show_popup = pager_config->popup;
cfdata->popup_speed = pager_config->popup_speed;
+ cfdata->show_popup_urgent = pager_config->popup_urgent;
+ cfdata->popup_urgent_stick = pager_config->popup_urgent_stick;
+ cfdata->popup_urgent_speed = pager_config->popup_urgent_speed;
cfdata->drag_resist = pager_config->drag_resist;
cfdata->btn_drag = pager_config->btn_drag;
cfdata->btn_noplace = pager_config->btn_noplace;
@@ -105,7 +114,7 @@
o = e_widget_list_add(evas, 0, 0);
of = e_widget_framelist_add(evas, _("General Settings"), 0);
- ob = e_widget_check_add(evas, _("Show Popup"), &(cfdata->show_popup));
+ ob = e_widget_check_add(evas, _("Show Popup on desktop change"), &(cfdata->show_popup));
e_widget_framelist_object_append(of, ob);
e_widget_list_object_append(o, of, 1, 1, 0.5);
@@ -124,7 +133,7 @@
static Evas_Object *
_advanced_create_widgets(E_Config_Dialog *cfd, Evas *evas, E_Config_Dialog_Data *cfdata)
{
- Evas_Object *o, *of, *ob;
+ Evas_Object *o, *of, *of2, *ob;
o = e_widget_list_add(evas, 0, 0);
of = e_widget_framelist_add(evas, _("Resistance to Dragging Windows:"), 0);
@@ -133,13 +142,29 @@
e_widget_list_object_append(o, of, 1, 1, 0.5);
of = e_widget_framelist_add(evas, _("Popup Settings"), 0);
- ob = e_widget_check_add(evas, _("Show Popup"), &(cfdata->show_popup));
+ ob = e_widget_check_add(evas, _("Show Popup on desktop change"), &(cfdata->show_popup));
e_widget_framelist_object_append(of, ob);
ob = e_widget_label_add(evas, _("Popup Speed"));
e_widget_framelist_object_append(of, ob);
ob = e_widget_slider_add(evas, 1, 0, _("%1.1f seconds"), 0.1, 10.0, 0.1, 0, &(cfdata->popup_speed), NULL, 200);
e_widget_framelist_object_append(of, ob);
- e_widget_list_object_append(o, of, 1, 1, 0.5);
+
+ of2 = e_widget_framelist_add(evas, _("Urgent window"), 0);
+ ob = e_widget_check_add(evas, _("Show Popup on urgent window"), &(cfdata->show_popup_urgent));
+ e_widget_framelist_object_append(of2, ob);
+ ob = e_widget_check_add(evas, _("Popup on urgent window sticks on the screen"), &(cfdata->popup_urgent_stick));
+ cfdata->gui.o_urgent_stick = ob;
+ e_widget_on_change_hook_set(ob, _check_urgent_stick_cb_change, cfdata);
+ e_widget_framelist_object_append(of2, ob);
+ ob = e_widget_label_add(evas, _("Popup Speed"));
+ e_widget_framelist_object_append(of2, ob);
+ ob = e_widget_slider_add(evas, 1, 0, _("%1.1f seconds"), 0.1, 10.0, 0.1, 0, &(cfdata->popup_urgent_speed), NULL, 200);
+ cfdata->gui.o_urgent_speed = ob;
+ _check_urgent_stick_cb_change(cfdata, cfdata->gui.o_urgent_stick);
+ e_widget_framelist_object_append(of2, ob);
+
+ e_widget_framelist_object_append(of, of2);
+ e_widget_list_object_append(o, of, 1, 1, 0.5);
of = e_widget_frametable_add(evas, _("Buttons Settings"), 0);
ob = e_widget_label_add(evas
Re: [E-devel] patch for the pager module, about window urgent state support
On 03/17/2007 04:48, Laurent Ghigonis wrote: > I'm not sure to understand you're answer. > > Did you test the patch ? The way you describe the things are how > they _should_ happend. Closing the popup after the first desktop change. > If it's not the case for you, please tell me what you're pager setting > are, so maybe i can reproduce that. Yes... my mistake. You are correct. It does not disappear immediately. But it does disappear before the full timeout specified, which is what I was suggesting. When I initially tested, I was using a shorter timeout, and it simply appeared as if it was continuing to wait until that timeout expired. But if I set it to 10 full seconds... its obvious that it does close after the desktop switch. :) Thanks, Ravenlock > > The thing is, sometimes its _not_ a good thing to close the popup after > a desktop change : you could miss a popup urgent event, if you change > of desktop at the time the event happend. Need to think about that, > maybe a timer that must be respected ... > > > laurent > > >> This is very handy. Though one thought. It might be nice to have a >> configurable setting that when selected... the pager popup would >> close after the first desktop change. >> >> For example: >>1) you get an urgent window >>2) pager pops up >>3) you select the desktop of the urgent window >>4) the popup closes. >> >> :) >> >> Just a thought. > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Regards, Eric - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
I'm not sure to understand you're answer. Did you test the patch ? The way you describe the things are how they _should_ happend. Closing the popup after the first desktop change. If it's not the case for you, please tell me what you're pager setting are, so maybe i can reproduce that. The thing is, sometimes its _not_ a good thing to close the popup after a desktop change : you could miss a popup urgent event, if you change of desktop at the time the event happend. Need to think about that, maybe a timer that must be respected ... laurent > This is very handy. Though one thought. It might be nice to have a > configurable setting that when selected... the pager popup would > close after the first desktop change. > > For example: >1) you get an urgent window >2) pager pops up >3) you select the desktop of the urgent window >4) the popup closes. > > :) > > Just a thought. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
I'm not sure to understand you're answer. Did you test the patch ? The way you describe the things are how they _should_ happend. Closing the popup after the first desktop change. If it's not the case for you, please tell me what you're pager setting are, so maybe i can reproduce that. The thing is, sometimes its _not_ a good thing to close the popup after a desktop change : you could miss a popup urgent event, if you change of desktop at the time the event happend. Need to think about that, maybe a timer that must be respected ... laurent > This is very handy. Though one thought. It might be nice to have a > configurable setting that when selected... the pager popup would > close after the first desktop change. > > For example: >1) you get an urgent window >2) pager pops up >3) you select the desktop of the urgent window >4) the popup closes. > > :) > > Just a thought. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
On 03/16/2007 18:53, Laurent Ghigonis wrote: >> oh... another idea (hope you don't mind the unsolicited ideas)... > > i love them =) > >> Might be nice to have the pager itself get raised to above all in >> response to an urgent client. (configurable) >> >> This might be nice because, at least for me, the pager is in a less >> obtrusive location than the popup would be. The popup can obscure >> things when visible. the pager (in my case) is a bit more out of the >> way, but would be very noticeable. :) > > Raise the pager, you mean raise temporary the shelf where the pager > is ? It would be a new shelf mecanism to code, maybe a good thing, > maybe not verry usefull outside this case ... dunno. oh yes. I tend to have only one shelf, and only the pager in it. I spoke before I thought. That would probably be overly complex and would affect more than just the pager. Maybe not such a good idea after all. :/ > > I agree, it would be less obstrusive. Sometimes you want that. > But the idea is to warn the user, so we want to be sure he sees the > event. > > Make that configurable would be nice, maybe later, when we will have > the author's module opinion :) > > > laurent > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Regards, Ravenlock - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
> oh... another idea (hope you don't mind the unsolicited ideas)... i love them =) > Might be nice to have the pager itself get raised to above all in > response to an urgent client. (configurable) > > This might be nice because, at least for me, the pager is in a less > obtrusive location than the popup would be. The popup can obscure > things when visible. the pager (in my case) is a bit more out of the > way, but would be very noticeable. :) Raise the pager, you mean raise temporary the shelf where the pager is ? It would be a new shelf mecanism to code, maybe a good thing, maybe not verry usefull outside this case ... dunno. I agree, it would be less obstrusive. Sometimes you want that. But the idea is to warn the user, so we want to be sure he sees the event. Make that configurable would be nice, maybe later, when we will have the author's module opinion :) laurent - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
On 03/16/2007 08:48, Laurent Ghigonis wrote: > Hi all > > Here is a little patch for the pager module, > that basically able the user to show the pager popup on window urgent > state change. > oh... another idea (hope you don't mind the unsolicited ideas)... Might be nice to have the pager itself get raised to above all in response to an urgent client. (configurable) This might be nice because, at least for me, the pager is in a less obtrusive location than the popup would be. The popup can obscure things when visible. the pager (in my case) is a bit more out of the way, but would be very noticeable. :) > More details : > * fix: show the urgent state of a window even if the urgent state was > set before the pager start > * show the urgent state of windows in the pager popup > * the pager pops its popup on window urgent state change (configurable) > * a desktop can be selected in the pager popup, but all other actions > actions are still forbidden inside the popup > > It adds 3 more options in the pager configuration panel : > 1. "show popup on urgent window" > 2. "urgent popup sticks on the screen" > 3. "urgent popup timer" > > > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Regards, Ravenlock - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for the pager module, about window urgent state support
On 03/16/2007 08:48, Laurent Ghigonis wrote: > Hi all > > Here is a little patch for the pager module, > that basically able the user to show the pager popup on window urgent > state change. This is very handy. Though one thought. It might be nice to have a configurable setting that when selected... the pager popup would close after the first desktop change. For example: 1) you get an urgent window 2) pager pops up 3) you select the desktop of the urgent window 4) the popup closes. :) Just a thought. > > More details : > * fix: show the urgent state of a window even if the urgent state was > set before the pager start > * show the urgent state of windows in the pager popup > * the pager pops its popup on window urgent state change (configurable) > * a desktop can be selected in the pager popup, but all other actions > actions are still forbidden inside the popup > > It adds 3 more options in the pager configuration panel : > 1. "show popup on urgent window" > 2. "urgent popup sticks on the screen" > 3. "urgent popup timer" > > > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Regards, Eric - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
