Re: [VOTE] Release Wink 1.1 (incubating)
Looks ok to me, +1 ...ant On Tue, May 11, 2010 at 5:06 PM, Mike Rheinheimer r...@apache.org wrote: I should have mentioned this, Wink 1.1 release already has two IPMC binding votes from: Davanum Srinivas Kevan Miller Wink 1.1. release needs only one more IPMC binding vote to pass. Thanks. mike On Tue, May 11, 2010 at 10:43 AM, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
Thanks Sebb, Just to be clear, is this a minus 1 vote from you? If so, I'll roll it all back and restart the process. mike On Tue, May 11, 2010 at 11:36 AM, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) AL headers are missing from: wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. Also, the SNAPSHOT downloads should not be listed on the public download page. Only approved releases should be made generally available. It would be useful to include details of how to use sigs and hashes to check downloads. The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
On 11/05/2010, Mike Rheinheimer r...@ohmyhead.com wrote: Thanks Sebb, Just to be clear, is this a minus 1 vote from you? If so, I'll roll it all back and restart the process. The missing AL headers would have been -1 from me, but as they cannot currently be fixed that can be left for a later release (if indeed possible at all). Might be useful to document these restrictions in the POM license plugin excludes section in trunk so it will be noted in future releases. Other issues I raised have either been fixed (thanks!) or are not blockers IMO. mike On Tue, May 11, 2010 at 11:36 AM, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) AL headers are missing from: wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. Also, the SNAPSHOT downloads should not be listed on the public download page. Only approved releases should be made generally available. It would be useful to include details of how to use sigs and hashes to check downloads. The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
I should have mentioned this, Wink 1.1 release already has two IPMC binding votes from: Davanum Srinivas Kevan Miller Wink 1.1. release needs only one more IPMC binding vote to pass. Thanks. mike On Tue, May 11, 2010 at 10:43 AM, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike
Re: [VOTE] Release Wink 1.1 (incubating)
On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) AL headers are missing from: wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. Also, the SNAPSHOT downloads should not be listed on the public download page. Only approved releases should be made generally available. It would be useful to include details of how to use sigs and hashes to check downloads. The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
Just tried building the source archive using mvn install. This reports a lot of warnings from the license:check goal. Seems unnecessary to include a license check in every build; it should probably be run as part of the site generation - if it is run automatically at all. Also, I got a test error: Failed tests: testCustomResolverCacheOn(org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest) junit.framework.AssertionFailedError: expected: 20 38 at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest.testCustomResolverCacheOn(JAXBCustomContextResolverCacheTest.java:197) On 11/05/2010, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) AL headers are missing from: wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. Also, the SNAPSHOT downloads should not be listed on the public download page. Only approved releases should be made generally available. It would be useful to include details of how to use sigs and hashes to check downloads. The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
Thanks Sebb for your review, I'll try to address each of your concerns: 1) AL headers are missing from... These files list implementation classes like other standard META-INF/services/* files. We may be able to accommodate and re-write code that reads these files in the next release but I don't believe these should be release blockers. 2) The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. I've added a link for the KEYS file. Site will be updated as soon as I have proper permissions on people.apache.org. 3) Also, the SNAPSHOT downloads should not be listed... Also fixed. Site will be updated as soon as I have proper permissions on people.apache.org. 4) It would be useful to include details of how to use sigs and hashes to check downloads. Added a link from the downloads page to the Apache instructions. Site will be updated as soon as I have proper permissions on people.apache.org. 5) This reports a lot of warnings from the license:check goal... My personal preference is that this goal remains. It has served us well. :) 6) Also, I got a test error:... This test has been running consistently in Hudson since its creation, and has been successful for individual developers as well. I'll be glad to open a Jira and review the problem, but I don't think this is a release blocker. Thanks again, mike On Tue, May 11, 2010 at 2:08 PM, sebb seb...@gmail.com wrote: Just tried building the source archive using mvn install. This reports a lot of warnings from the license:check goal. Seems unnecessary to include a license check in every build; it should probably be run as part of the site generation - if it is run automatically at all. Also, I got a test error: Failed tests: testCustomResolverCacheOn(org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest) junit.framework.AssertionFailedError: expected: 20 38 at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest.testCustomResolverCacheOn(JAXBCustomContextResolverCacheTest.java:197) On 11/05/2010, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) AL headers are missing from: wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. Also, the SNAPSHOT downloads should not be listed on the public download page. Only approved releases should be made generally available. It would be useful to include details of how to use sigs and hashes to check downloads. The vote will be open here for at least 72 hours (ending Friday, May 14, 10:45am US CST). Please indicate your vote: [ ] +1 to release Wink 1.1 incubating [ ] +0 [ ] -1 NOT to release Wink 1.1 incubating (and why) Thanks! mike - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: Thanks Sebb for your review, I'll try to address each of your concerns: 1) AL headers are missing from... These files list implementation classes like other standard META-INF/services/* files. We may be able to accommodate and re-write code that reads these files in the next release but I don't believe these should be release blockers. I assumed these were standard services files which do allow comments. See for example: http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Provider%20Configuration%20File which describes the service file format. 2) The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. I've added a link for the KEYS file. Site will be updated as soon as I have proper permissions on people.apache.org. Thanks, seen it via people proxy. The link is to an SVN tag, which works, however is not usual. There's a copy of KEYS in http://www.apache.org/dist/incubator/wink/ which is a more usual location for links to refer to, and is closer to the hashes/sigs. BTW, the amended download page has two copies of the Instructions and SVN URLs under the 1.0 release table. Also, just noticed that the 0.1 release location is still using www.apache.org. Archived releases should be referenced from archive.apache.org, e.g.: http://archive.apache.org/dist/incubator/wink/0.1-incubating/ Once the 1.0 release has been available for a week or so, any previous releases should be deleted from www.apache.org/dist. They will remain on archive.a.o forever. 3) Also, the SNAPSHOT downloads should not be listed... Also fixed. Site will be updated as soon as I have proper permissions on people.apache.org. 4) It would be useful to include details of how to use sigs and hashes to check downloads. Added a link from the downloads page to the Apache instructions. Site will be updated as soon as I have proper permissions on people.apache.org. 5) This reports a lot of warnings from the license:check goal... My personal preference is that this goal remains. It has served us well. :) But does it need to be run for every install? Surely you only need it for the -PCIBuild installs. 6) Also, I got a test error:... This test has been running consistently in Hudson since its creation, and has been successful for individual developers as well. I'll be glad to open a Jira and review the problem, but I don't think this is a release blocker. Thanks again, mike On Tue, May 11, 2010 at 2:08 PM, sebb seb...@gmail.com wrote: Just tried building the source archive using mvn install. This reports a lot of warnings from the license:check goal. Seems unnecessary to include a license check in every build; it should probably be run as part of the site generation - if it is run automatically at all. Also, I got a test error: Failed tests: testCustomResolverCacheOn(org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest) junit.framework.AssertionFailedError: expected: 20 38 at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest.testCustomResolverCacheOn(JAXBCustomContextResolverCacheTest.java:197) On 11/05/2010, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at: https://repository.apache.org/content/repositories/orgapachewink-007/ The distributions are in: https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/ This release is tagged at: https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating (revision 941046) AL headers are missing from: wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. Also, the SNAPSHOT downloads should not be listed on the public download page. Only approved releases should be made generally available. It would be useful to include details of how to use sigs and hashes to check downloads. The vote will be open here for at least 72 hours (ending Friday,
Re: [VOTE] Release Wink 1.1 (incubating)
Sebb, Sorry, I was incomplete in my explanation. Regarding the services files, the JAX-RS API jar is reading the first line in these files. I just confirmed it again in my build; if I add a # comment as the first line in wink-common/src/main/ resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate, the JAX-RS API reads that first line, and we see errors everywhere. Of course, we have no ability to quickly fix the JAX-RS API code. Your thoughts? Also, I went back and fixed the site again per your suggestions. I've not done the 1.1 parts yet since we don't yet have a release, of course. I don't have a strong objection to changing the Apache license goal to only run during -PCIBuild. Not sure why this is an issue exactly though. Is it just to keep the output cleaner for developers? Does it pollute Hudson build output? I just don't know. Thanks again. mike On Tue, May 11, 2010 at 4:31 PM, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: Thanks Sebb for your review, I'll try to address each of your concerns: 1) AL headers are missing from... These files list implementation classes like other standard META-INF/services/* files. We may be able to accommodate and re-write code that reads these files in the next release but I don't believe these should be release blockers. I assumed these were standard services files which do allow comments. See for example: http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Provider%20Configuration%20File which describes the service file format. 2) The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. I've added a link for the KEYS file. Site will be updated as soon as I have proper permissions on people.apache.org. Thanks, seen it via people proxy. The link is to an SVN tag, which works, however is not usual. There's a copy of KEYS in http://www.apache.org/dist/incubator/wink/ which is a more usual location for links to refer to, and is closer to the hashes/sigs. BTW, the amended download page has two copies of the Instructions and SVN URLs under the 1.0 release table. Also, just noticed that the 0.1 release location is still using www.apache.org. Archived releases should be referenced from archive.apache.org, e.g.: http://archive.apache.org/dist/incubator/wink/0.1-incubating/ Once the 1.0 release has been available for a week or so, any previous releases should be deleted from www.apache.org/dist. They will remain on archive.a.o forever. 3) Also, the SNAPSHOT downloads should not be listed... Also fixed. Site will be updated as soon as I have proper permissions on people.apache.org. 4) It would be useful to include details of how to use sigs and hashes to check downloads. Added a link from the downloads page to the Apache instructions. Site will be updated as soon as I have proper permissions on people.apache.org. 5) This reports a lot of warnings from the license:check goal... My personal preference is that this goal remains. It has served us well. :) But does it need to be run for every install? Surely you only need it for the -PCIBuild installs. 6) Also, I got a test error:... This test has been running consistently in Hudson since its creation, and has been successful for individual developers as well. I'll be glad to open a Jira and review the problem, but I don't think this is a release blocker. Thanks again, mike On Tue, May 11, 2010 at 2:08 PM, sebb seb...@gmail.com wrote: Just tried building the source archive using mvn install. This reports a lot of warnings from the license:check goal. Seems unnecessary to include a license check in every build; it should probably be run as part of the site generation - if it is run automatically at all. Also, I got a test error: Failed tests: testCustomResolverCacheOn(org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest) junit.framework.AssertionFailedError: expected: 20 38 at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest.testCustomResolverCacheOn(JAXBCustomContextResolverCacheTest.java:197) On 11/05/2010, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: IPMCers, Wink 1.1 release voting has completed successfully on the wink-dev list. I'm now calling the IPMC vote to release Wink 1.1 (incubating) per the process indicated here: http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote The Maven staging area is at:
Re: [VOTE] Release Wink 1.1 (incubating)
On May 11, 2010, at 3:05 PM, Mike Rheinheimer wrote: Sorry, I was incomplete in my explanation. Regarding the services files, the JAX-RS API jar is reading the first line in these files. I just confirmed it again in my build; if I add a # comment as the first line in wink-common/src/main/ resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate, the JAX-RS API reads that first line, and we see errors everywhere. Of course, we have no ability to quickly fix the JAX-RS API code. Your thoughts? This is probably a bug in JAX-RS and not something that should block the release, though hopefully sun/oracle/whoever will fix it one day. If it was Wink code causing the problem, that should be fixed ASAP, but IMO should not block a release. I think that Apache Geronimo has a few such files that can not contain any comments/headers... they are all files like this IIRC. --jason - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Wink 1.1 (incubating)
On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: Sebb, Sorry, I was incomplete in my explanation. Regarding the services files, the JAX-RS API jar is reading the first line in these files. I just confirmed it again in my build; if I add a # comment as the first line in wink-common/src/main/ resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate, the JAX-RS API reads that first line, and we see errors everywhere. Of course, we have no ability to quickly fix the JAX-RS API code. Your thoughts? OK, if the JAX-RS code cannot deal with comments, and it's not possible to fix it, then it will have to be left as is for now. Also, I went back and fixed the site again per your suggestions. I've not done the 1.1 parts yet since we don't yet have a release, of course. That looks much better now, thanks! I don't have a strong objection to changing the Apache license goal to only run during -PCIBuild. Not sure why this is an issue exactly though. Is it just to keep the output cleaner for developers? Does it pollute Hudson build output? I just don't know. It takes longer to run many Maven goals, and the output is very cluttered because of all the unknown file types. I get a whole screenful of messages such as: [WARNING] Unknown file extension: D:\ReleaseCheck\apache-wink-1.1-incubating-src-zip\apache-wink-1.1-incubating-src\wink -common\src\main\resources\META-INF\core\wink-providers These files should probably be excluded from the checks anyway, but it still wastes build time. Also, the plugin does not seem to check for AL headers in pom.xml files (I removed the headers from two of them to check). It does check *.java files, but the fact that it misses pom.xml files is a bit concerning - what else is it not checking? A brief test suggests that it is not checking the following file types either, not that the Wink project uses these particular file types at present: .c, .sh, .cmd, .bat, .xsl Thanks again. mike On Tue, May 11, 2010 at 4:31 PM, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: Thanks Sebb for your review, I'll try to address each of your concerns: 1) AL headers are missing from... These files list implementation classes like other standard META-INF/services/* files. We may be able to accommodate and re-write code that reads these files in the next release but I don't believe these should be release blockers. I assumed these were standard services files which do allow comments. See for example: http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Provider%20Configuration%20File which describes the service file format. 2) The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. I've added a link for the KEYS file. Site will be updated as soon as I have proper permissions on people.apache.org. Thanks, seen it via people proxy. The link is to an SVN tag, which works, however is not usual. There's a copy of KEYS in http://www.apache.org/dist/incubator/wink/ which is a more usual location for links to refer to, and is closer to the hashes/sigs. BTW, the amended download page has two copies of the Instructions and SVN URLs under the 1.0 release table. Also, just noticed that the 0.1 release location is still using www.apache.org. Archived releases should be referenced from archive.apache.org, e.g.: http://archive.apache.org/dist/incubator/wink/0.1-incubating/ Once the 1.0 release has been available for a week or so, any previous releases should be deleted from www.apache.org/dist. They will remain on archive.a.o forever. 3) Also, the SNAPSHOT downloads should not be listed... Also fixed. Site will be updated as soon as I have proper permissions on people.apache.org. 4) It would be useful to include details of how to use sigs and hashes to check downloads. Added a link from the downloads page to the Apache instructions. Site will be updated as soon as I have proper permissions on people.apache.org. 5) This reports a lot of warnings from the license:check goal... My personal preference is that this goal remains. It has served us well. :) But does it need to be run for every install? Surely you only need it for the -PCIBuild installs. 6) Also, I got a test error:... This test has been running consistently in Hudson since its creation, and has been successful for individual developers as well. I'll be glad to open a Jira and review the problem, but I don't think this is a release blocker. Thanks again, mike On Tue, May 11, 2010 at 2:08 PM, sebb seb...@gmail.com wrote: Just tried
Re: [VOTE] Release Wink 1.1 (incubating)
On 12/05/2010, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: Sebb, Sorry, I was incomplete in my explanation. Regarding the services files, the JAX-RS API jar is reading the first line in these files. I just confirmed it again in my build; if I add a # comment as the first line in wink-common/src/main/ resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate, the JAX-RS API reads that first line, and we see errors everywhere. Of course, we have no ability to quickly fix the JAX-RS API code. Your thoughts? OK, if the JAX-RS code cannot deal with comments, and it's not possible to fix it, then it will have to be left as is for now. Also, I went back and fixed the site again per your suggestions. I've not done the 1.1 parts yet since we don't yet have a release, of course. That looks much better now, thanks! I don't have a strong objection to changing the Apache license goal to only run during -PCIBuild. Not sure why this is an issue exactly though. Is it just to keep the output cleaner for developers? Does it pollute Hudson build output? I just don't know. It takes longer to run many Maven goals, and the output is very cluttered because of all the unknown file types. I get a whole screenful of messages such as: [WARNING] Unknown file extension: D:\ReleaseCheck\apache-wink-1.1-incubating-src-zip\apache-wink-1.1-incubating-src\wink -common\src\main\resources\META-INF\core\wink-providers These files should probably be excluded from the checks anyway, but it still wastes build time. Also, the plugin does not seem to check for AL headers in pom.xml files (I removed the headers from two of them to check). It does check *.java files, but the fact that it misses pom.xml files is a bit concerning - what else is it not checking? A brief test suggests that it is not checking the following file types either, not that the Wink project uses these particular file types at present: .c, .sh, .cmd, .bat, .xsl Just discovered that this was because my test files were not under src/ Also discovered that the plugin defaultExcludes list contains **/pom.xml, which is why the missing pom.xml headers were not found. Not sure it is possible to override some of the defaultExcludes, so you may have to disable the defaultExcludes and exclude them one by one. Thanks again. mike On Tue, May 11, 2010 at 4:31 PM, sebb seb...@gmail.com wrote: On 11/05/2010, Mike Rheinheimer r...@apache.org wrote: Thanks Sebb for your review, I'll try to address each of your concerns: 1) AL headers are missing from... These files list implementation classes like other standard META-INF/services/* files. We may be able to accommodate and re-write code that reads these files in the next release but I don't believe these should be release blockers. I assumed these were standard services files which do allow comments. See for example: http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Provider%20Configuration%20File which describes the service file format. 2) The Wink download page does not have a link to the KEYS file; this should be fixed before any release please. I've added a link for the KEYS file. Site will be updated as soon as I have proper permissions on people.apache.org. Thanks, seen it via people proxy. The link is to an SVN tag, which works, however is not usual. There's a copy of KEYS in http://www.apache.org/dist/incubator/wink/ which is a more usual location for links to refer to, and is closer to the hashes/sigs. BTW, the amended download page has two copies of the Instructions and SVN URLs under the 1.0 release table. Also, just noticed that the 0.1 release location is still using www.apache.org. Archived releases should be referenced from archive.apache.org, e.g.: http://archive.apache.org/dist/incubator/wink/0.1-incubating/ Once the 1.0 release has been available for a week or so, any previous releases should be deleted from www.apache.org/dist. They will remain on archive.a.o forever. 3) Also, the SNAPSHOT downloads should not be listed... Also fixed. Site will be updated as soon as I have proper permissions on people.apache.org. 4) It would be useful to include details of how to use sigs and hashes to check downloads. Added a link from the downloads page to the Apache instructions. Site will be updated as soon as I have proper permissions on people.apache.org. 5) This reports a lot of warnings from the license:check goal...
