Build failure of network:osmocom:latest/ulfius in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Testing/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 434s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5 of 'MHD_start_daemon' from incompatible pointer type [-Werror=incompatible-pointer-types] [ 434s] 839 | mhd_flags, u_instance->port, NULL, NULL, _webservice_dispatcher, (void *)u_instance, [ 434s] | ^ [ 434s] || [ 434s] |int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)} [ 434s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46, [ 434s] from /usr/src/packages/BUILD/include/u_private.h:29, [ 434s] from /usr/src/packages/BUILD/src/ulfius.c:29: [ 434s] /usr/include/microhttpd.h:2425:1: note: expected 'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} [ 434s] 2425 | MHD_start_daemon (unsigned int flags, [ 434s] | ^~~~ [ 435s] cc1: all warnings being treated as errors [ 435s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144: CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1 [ 435s] make[3]: *** Waiting for unfinished jobs [ 435s] make[3]: Leaving directory '/usr/src/packages/BUILD/build' [ 435s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all] Error 2 [ 435s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 435s] make[1]: *** [Makefile:166: all] Error 2 [ 435s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 435s] dh_auto_build: error: cd build && make -j8 "INSTALL=install --strip-program=true" returned exit code 2 [ 435s] make: *** [debian/rules:9: build] Error 25 [ 435s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 435s] ### VM INTERACTION START ### [ 438s] [ 407.011536] sysrq: Power Off [ 438s] [ 407.046450] reboot: Power down [ 438s] ### VM INTERACTION END ### [ 439s] [ 439s] lamb24 failed "build ulfius_2.5.2-4.1.dsc" at Fri Aug 7 03:44:33 UTC 2020. [ 439s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 95s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5 of 'MHD_start_daemon' from incompatible pointer type [-Werror=incompatible-pointer-types] [ 95s] 839 | mhd_flags, u_instance->port, NULL, NULL, _webservice_dispatcher, (void *)u_instance, [ 95s] | ^ [ 95s] || [ 95s] |int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)} [ 95s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46, [ 95s] from /usr/src/packages/BUILD/include/u_private.h:29, [ 95s] from /usr/src/packages/BUILD/src/ulfius.c:29: [ 95s] /usr/include/microhttpd.h:2428:45: note: expected 'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} [ 95s] 2428 | MHD_AccessHandlerCallback dh, void *dh_cls, [ 95s] | ~~^~ [ 95s] cc1: all warnings being treated as errors [ 95s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144: CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1 [ 95s] make[3]: *** Waiting for unfinished jobs [ 95s] make[3]: Leaving directory '/usr/src/packages/BUILD/build' [ 95s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all] Error 2 [ 95s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 95s] make[1]: *** [Makefile:166: all] Error 2 [ 95s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 95s] dh_auto_build: error: cd build && make -j6 "INSTALL=install --strip-program=true" returned exit code 2 [ 95s] make: *** [debian/rules:9: build] Error 25 [ 95s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 95s] ### VM INTERACTION START ### [ 99s] [ 87.880203] sysrq: Power Off [ 99s] [ 87.885723] reboot: Power down [ 99s] ### VM INTERACTION END ### [ 99s] [ 99s] sheep85 failed "build ulfius_2.5.2-4.1.dsc" at Fri Aug 7 03:26:11 UTC 2020. [ 99s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 179s] [COMPILING apps/dfu/main.c] [ 179s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 179s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 179s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 179s] Memory region Used Size Region Size %age Used [ 179s] rom: 16464 B16 KB100.49% [ 179s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 179s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 179s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 179s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 179s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 179s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 179s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 80 bytes [ 179s] collect2: error: ld returned 1 exit status [ 179s] % [ 179s] make[2]: *** [Makefile:234: flash] Error 1 [ 179s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 179s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 179s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 179s] dh_auto_build: error: make -j1 returned exit code 2 [ 179s] make: *** [debian/rules:16: build] Error 25 [ 179s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 179s] ### VM INTERACTION START ### [ 182s] [ 158.176430] sysrq: Power Off [ 182s] [ 158.181117] reboot: Power down [ 183s] ### VM INTERACTION END ### [ 183s] [ 183s] old-atreju4 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 03:17:33 UTC 2020. [ 183s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/ulfius in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Testing/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 85s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5 of 'MHD_start_daemon' from incompatible pointer type [-Werror=incompatible-pointer-types] [ 85s] 839 | mhd_flags, u_instance->port, NULL, NULL, _webservice_dispatcher, (void *)u_instance, [ 85s] | ^ [ 85s] || [ 85s] |int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)} [ 85s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46, [ 85s] from /usr/src/packages/BUILD/include/u_private.h:29, [ 85s] from /usr/src/packages/BUILD/src/ulfius.c:29: [ 85s] /usr/include/microhttpd.h:2425:1: note: expected 'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} [ 85s] 2425 | MHD_start_daemon (unsigned int flags, [ 85s] | ^~~~ [ 85s] cc1: all warnings being treated as errors [ 85s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144: CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1 [ 85s] make[3]: *** Waiting for unfinished jobs [ 85s] make[3]: Leaving directory '/usr/src/packages/BUILD/build' [ 85s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all] Error 2 [ 85s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 85s] make[1]: *** [Makefile:166: all] Error 2 [ 85s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 85s] dh_auto_build: error: cd build && make -j16 "INSTALL=install --strip-program=true" returned exit code 2 [ 85s] make: *** [debian/rules:9: build] Error 25 [ 85s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 85s] ### VM INTERACTION START ### [ 88s] [ 80.392103] sysrq: Power Off [ 88s] [ 80.401621] reboot: Power down [ 88s] ### VM INTERACTION END ### [ 88s] [ 88s] sheep81 failed "build ulfius_2.5.2-4.1.dsc" at Fri Aug 7 03:17:39 UTC 2020. [ 88s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 82s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5 of 'MHD_start_daemon' from incompatible pointer type [-Werror=incompatible-pointer-types] [ 82s] 839 | mhd_flags, u_instance->port, NULL, NULL, _webservice_dispatcher, (void *)u_instance, [ 82s] | ^ [ 82s] || [ 82s] |int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)} [ 82s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46, [ 82s] from /usr/src/packages/BUILD/include/u_private.h:29, [ 82s] from /usr/src/packages/BUILD/src/ulfius.c:29: [ 82s] /usr/include/microhttpd.h:2428:45: note: expected 'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char *, const char *, const char *, const char *, long unsigned int *, void **)'} [ 82s] 2428 | MHD_AccessHandlerCallback dh, void *dh_cls, [ 82s] | ~~^~ [ 82s] cc1: all warnings being treated as errors [ 82s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144: CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1 [ 82s] make[3]: *** Waiting for unfinished jobs [ 82s] make[3]: Leaving directory '/usr/src/packages/BUILD/build' [ 82s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all] Error 2 [ 82s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 82s] make[1]: *** [Makefile:166: all] Error 2 [ 82s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 82s] dh_auto_build: error: cd build && make -j16 "INSTALL=install --strip-program=true" returned exit code 2 [ 82s] make: *** [debian/rules:9: build] Error 25 [ 82s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 82s] ### VM INTERACTION START ### [ 85s] [ 78.157286] sysrq: Power Off [ 85s] [ 78.165903] reboot: Power down [ 85s] ### VM INTERACTION END ### [ 85s] [ 85s] goat15 failed "build ulfius_2.5.2-4.1.dsc" at Fri Aug 7 03:03:40 UTC 2020. [ 85s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 484s] [COMPILING libboard/common/source/uart_console.c] [ 485s] [COMPILING libboard/common/source/led.c] [ 485s] [COMPILING libboard/common/source/boardver_adc.c] [ 485s] [COMPILING libboard/common/source/manifest.c] [ 485s] [COMPILING libboard/simtrace/source/board_simtrace.c] [ 486s] [COMPILING apps/dfu/main.c] [ 486s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 486s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 487s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 487s] Memory region Used Size Region Size %age Used [ 487s] rom: 16460 B16 KB100.46% [ 487s] ram: 11664 B48 KB 23.73/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/simtrace-dfu-flash.elf section `.text' will not fit in region `rom' [ 487s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 76 bytes [ 487s] collect2: error: ld returned 1 exit status [ 487s] % [ 487s] make[2]: *** [Makefile:234: flash] Error 1 [ 487s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 487s] make[1]: *** [Makefile:10: fw-simtrace-dfu] Error 2 [ 487s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 487s] dh_auto_build: error: make -j1 returned exit code 2 [ 487s] make: *** [debian/rules:16: build] Error 25 [ 487s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 487s] ### VM INTERACTION START ### [ 490s] [ 453.870614] sysrq: Power Off [ 491s] [ 453.926281] reboot: Power down [ 491s] ### VM INTERACTION END ### [ 491s] [ 491s] lamb03 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 02:42:19 UTC 2020. [ 491s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_19.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 270s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 270s] [COMPILING libboard/qmod/source/card_pres.c] [ 270s] [COMPILING libboard/qmod/source/wwan_led.c] [ 270s] [COMPILING libboard/qmod/source/i2c.c] [ 271s] [COMPILING libboard/qmod/source/board_qmod.c] [ 271s] [COMPILING apps/dfu/main.c] [ 271s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 271s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 271s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 272s] Memory region Used Size Region Size %age Used [ 272s] rom: 16504 B16 KB100.73% [ 272s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 272s] /usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 120 bytes [ 272s] collect2: error: ld returned 1 exit status [ 272s] % [ 272s] make[2]: *** [Makefile:234: flash] Error 1 [ 272s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 272s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 272s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 272s] dh_auto_build: make -j1 returned exit code 2 [ 272s] make: *** [debian/rules:16: build] Error 2 [ 272s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 272s] ### VM INTERACTION START ### [ 275s] [ 265.015057] sysrq: Power Off [ 275s] [ 265.022763] reboot: Power down [ 275s] ### VM INTERACTION END ### [ 275s] [ 275s] lamb05 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 02:08:20 UTC 2020. [ 275s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 440s] [COMPILING libboard/qmod/source/i2c.c] [ 440s] [COMPILING libboard/qmod/source/board_qmod.c] [ 440s] [COMPILING apps/dfu/main.c] [ 440s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 441s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 441s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 441s] Memory region Used Size Region Size %age Used [ 441s] rom: 16576 B16 KB101.17% [ 441s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 441s] /usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 192 bytes [ 441s] collect2: error: ld returned 1 exit status [ 441s] % [ 441s] Makefile:234: recipe for target 'flash' failed [ 441s] make[2]: *** [flash] Error 1 [ 441s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 441s] Makefile:13: recipe for target 'fw-qmod-dfu' failed [ 441s] make[1]: *** [fw-qmod-dfu] Error 2 [ 441s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 441s] dh_auto_build: make -j1 returned exit code 2 [ 441s] debian/rules:16: recipe for target 'build' failed [ 441s] make: *** [build] Error 2 [ 441s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 441s] ### VM INTERACTION START ### [ 444s] [ 416.014662] sysrq: Power Off [ 444s] [ 416.045427] reboot: Power down [ 444s] ### VM INTERACTION END ### [ 444s] [ 444s] lamb23 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 02:01:58 UTC 2020. [ 444s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 530s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 530s] [COMPILING libboard/qmod/source/card_pres.c] [ 530s] [COMPILING libboard/qmod/source/wwan_led.c] [ 530s] [COMPILING libboard/qmod/source/i2c.c] [ 530s] [COMPILING libboard/qmod/source/board_qmod.c] [ 531s] [COMPILING apps/dfu/main.c] [ 531s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 531s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 532s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 532s] Memory region Used Size Region Size %age Used [ 532s] rom: 16504 B16 KB100.73% [ 532s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 532s] /usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 120 bytes [ 532s] collect2: error: ld returned 1 exit status [ 532s] % [ 532s] make[2]: *** [Makefile:234: flash] Error 1 [ 532s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 532s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 532s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 532s] dh_auto_build: make -j1 returned exit code 2 [ 532s] make: *** [debian/rules:16: build] Error 2 [ 532s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 532s] ### VM INTERACTION START ### [ 535s] [ 503.823199] sysrq: Power Off [ 535s] [ 503.853958] reboot: Power down [ 535s] ### VM INTERACTION END ### [ 535s] [ 535s] lamb26 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:56:48 UTC 2020. [ 535s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 351s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 351s] [COMPILING libboard/qmod/source/card_pres.c] [ 351s] [COMPILING libboard/qmod/source/wwan_led.c] [ 351s] [COMPILING libboard/qmod/source/i2c.c] [ 351s] [COMPILING libboard/qmod/source/board_qmod.c] [ 352s] [COMPILING apps/dfu/main.c] [ 352s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 352s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 352s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 353s] Memory region Used Size Region Size %age Used [ 353s] rom: 16504 B16 KB100.73% [ 353s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 353s] /usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 120 bytes [ 353s] collect2: error: ld returned 1 exit status [ 353s] % [ 353s] make[2]: *** [Makefile:234: flash] Error 1 [ 353s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 353s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 353s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 353s] dh_auto_build: make -j1 returned exit code 2 [ 353s] make: *** [debian/rules:16: build] Error 2 [ 353s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 353s] ### VM INTERACTION START ### [ 356s] [ 342.099399] sysrq: Power Off [ 356s] [ 342.115658] reboot: Power down [ 356s] ### VM INTERACTION END ### [ 356s] [ 356s] lamb15 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:56:14 UTC 2020. [ 356s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 258s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 259s] [COMPILING libboard/qmod/source/card_pres.c] [ 259s] [COMPILING libboard/qmod/source/wwan_led.c] [ 259s] [COMPILING libboard/qmod/source/i2c.c] [ 259s] [COMPILING libboard/qmod/source/board_qmod.c] [ 259s] [COMPILING apps/dfu/main.c] [ 260s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 260s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 260s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 260s] Memory region Used Size Region Size %age Used [ 260s] rom: 16576 B16 KB101.17% [ 260s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 260s] /usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 192 bytes [ 260s] collect2: error: ld returned 1 exit status [ 260s] % [ 260s] make[2]: *** [Makefile:234: flash] Error 1 [ 260s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 260s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 260s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 260s] dh_auto_build: make -j1 returned exit code 2 [ 260s] make: *** [debian/rules:16: build] Error 2 [ 260s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 260s] ### VM INTERACTION START ### [ 263s] [ 253.588539] sysrq: Power Off [ 264s] [ 253.637625] reboot: Power down [ 264s] ### VM INTERACTION END ### [ 264s] [ 264s] lamb24 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:51:46 UTC 2020. [ 264s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_19.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_19.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_19.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 108s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 108s] [COMPILING libboard/qmod/source/card_pres.c] [ 108s] [COMPILING libboard/qmod/source/wwan_led.c] [ 108s] [COMPILING libboard/qmod/source/i2c.c] [ 108s] [COMPILING libboard/qmod/source/board_qmod.c] [ 108s] [COMPILING apps/dfu/main.c] [ 108s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 108s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 108s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 109s] Memory region Used Size Region Size %age Used [ 109s] rom: 16504 B16 KB100.73% [ 109s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 109s] /usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 120 bytes [ 109s] collect2: error: ld returned 1 exit status [ 109s] % [ 109s] make[2]: *** [Makefile:234: flash] Error 1 [ 109s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 109s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 109s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 109s] dh_auto_build: make -j1 returned exit code 2 [ 109s] make: *** [debian/rules:16: build] Error 255 [ 109s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 109s] ### VM INTERACTION START ### [ 112s] [ 105.485098] sysrq: Power Off [ 112s] [ 105.487798] reboot: Power down [ 112s] ### VM INTERACTION END ### [ 112s] [ 112s] sheep85 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:51:53 UTC 2020. [ 112s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Unstable/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 118s] [COMPILING apps/dfu/main.c] [ 119s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 119s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 119s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 119s] Memory region Used Size Region Size %age Used [ 119s] rom: 16464 B16 KB100.49% [ 119s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 119s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 119s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 119s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 119s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 119s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 119s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 80 bytes [ 119s] collect2: error: ld returned 1 exit status [ 119s] % [ 119s] make[2]: *** [Makefile:234: flash] Error 1 [ 119s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 119s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 119s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 119s] dh_auto_build: error: make -j1 returned exit code 2 [ 119s] make: *** [debian/rules:16: build] Error 25 [ 119s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 119s] ### VM INTERACTION START ### [ 122s] [ 114.184878] sysrq: Power Off [ 122s] [ 114.194398] reboot: Power down [ 122s] ### VM INTERACTION END ### [ 122s] [ 122s] sheep81 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:51:33 UTC 2020. [ 122s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 452s] [COMPILING libboard/qmod/source/i2c.c] [ 453s] [COMPILING libboard/qmod/source/board_qmod.c] [ 453s] [COMPILING apps/dfu/main.c] [ 453s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 454s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 454s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 454s] Memory region Used Size Region Size %age Used [ 454s] rom: 16576 B16 KB101.17% [ 454s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 454s] /usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 192 bytes [ 454s] collect2: error: ld returned 1 exit status [ 454s] % [ 454s] Makefile:234: recipe for target 'flash' failed [ 454s] make[2]: *** [flash] Error 1 [ 454s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 454s] Makefile:13: recipe for target 'fw-qmod-dfu' failed [ 454s] make[1]: *** [fw-qmod-dfu] Error 2 [ 454s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 454s] dh_auto_build: make -j1 returned exit code 2 [ 454s] debian/rules:16: recipe for target 'build' failed [ 454s] make: *** [build] Error 2 [ 454s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 454s] ### VM INTERACTION START ### [ 458s] [ 435.137589] sysrq: Power Off [ 458s] [ 435.181571] reboot: Power down [ 458s] ### VM INTERACTION END ### [ 458s] [ 458s] lamb61 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:51:08 UTC 2020. [ 458s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 87s] [COMPILING apps/dfu/main.c] [ 87s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 87s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 87s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 87s] Memory region Used Size Region Size %age Used [ 87s] rom: 16464 B16 KB100.49% [ 87s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 87s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 87s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 87s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 87s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 87s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 87s] /usr/lib/gcc/arm-none-eabi/8.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 80 bytes [ 87s] collect2: error: ld returned 1 exit status [ 87s] % [ 87s] make[2]: *** [Makefile:234: flash] Error 1 [ 87s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 87s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 87s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 87s] dh_auto_build: error: make -j1 returned exit code 2 [ 87s] make: *** [debian/rules:16: build] Error 25 [ 87s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 87s] ### VM INTERACTION START ### [ 90s] [ 84.61] sysrq: Power Off [ 90s] [ 84.626208] reboot: Power down [ 90s] ### VM INTERACTION END ### [ 90s] [ 90s] goat13 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:50:55 UTC 2020. [ 90s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 132s] [COMPILING libboard/qmod/source/i2c.c] [ 132s] [COMPILING libboard/qmod/source/board_qmod.c] [ 132s] [COMPILING apps/dfu/main.c] [ 132s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 132s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 133s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 133s] Memory region Used Size Region Size %age Used [ 133s] rom: 16584 B16 KB101.22% [ 133s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/5.4.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 133s] /usr/lib/gcc/arm-none-eabi/5.4.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 200 bytes [ 133s] collect2: error: ld returned 1 exit status [ 133s] % [ 133s] Makefile:234: recipe for target 'flash' failed [ 133s] make[2]: *** [flash] Error 1 [ 133s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 133s] Makefile:13: recipe for target 'fw-qmod-dfu' failed [ 133s] make[1]: *** [fw-qmod-dfu] Error 2 [ 133s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 133s] dh_auto_build: make -j1 returned exit code 2 [ 133s] debian/rules:16: recipe for target 'build' failed [ 133s] make: *** [build] Error 2 [ 133s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 133s] ### VM INTERACTION START ### [ 136s] [ 124.253220] sysrq: Power Off [ 136s] [ 124.256319] reboot: Power down [ 136s] ### VM INTERACTION END ### [ 136s] [ 136s] build79 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:49:29 UTC 2020. [ 136s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.10/i586 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 433s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 433s] [COMPILING libboard/qmod/source/card_pres.c] [ 433s] [COMPILING libboard/qmod/source/wwan_led.c] [ 434s] [COMPILING libboard/qmod/source/i2c.c] [ 434s] [COMPILING libboard/qmod/source/board_qmod.c] [ 434s] [COMPILING apps/dfu/main.c] [ 434s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 435s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 435s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 435s] Memory region Used Size Region Size %age Used [ 435s] rom: 16576 B16 KB101.17% [ 435s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 435s] /usr/lib/gcc/arm-none-eabi/6.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 192 bytes [ 435s] collect2: error: ld returned 1 exit status [ 435s] % [ 435s] make[2]: *** [Makefile:234: flash] Error 1 [ 435s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 435s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 435s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 435s] dh_auto_build: make -j1 returned exit code 2 [ 435s] make: *** [debian/rules:16: build] Error 2 [ 435s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 435s] ### VM INTERACTION START ### [ 438s] [ 419.256470] sysrq: Power Off [ 438s] [ 419.278207] reboot: Power down [ 439s] ### VM INTERACTION END ### [ 439s] [ 439s] lamb21 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:47:06 UTC 2020. [ 439s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 271s] [COMPILING libboard/qmod/source/i2c.c] [ 271s] [COMPILING libboard/qmod/source/board_qmod.c] [ 272s] [COMPILING apps/dfu/main.c] [ 272s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 272s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 273s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 273s] Memory region Used Size Region Size %age Used [ 273s] rom: 16584 B16 KB101.22% [ 273s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/5.4.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 273s] /usr/lib/gcc/arm-none-eabi/5.4.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 200 bytes [ 273s] collect2: error: ld returned 1 exit status [ 273s] % [ 273s] Makefile:234: recipe for target 'flash' failed [ 273s] make[2]: *** [flash] Error 1 [ 273s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 273s] Makefile:13: recipe for target 'fw-qmod-dfu' failed [ 273s] make[1]: *** [fw-qmod-dfu] Error 2 [ 273s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 273s] dh_auto_build: make -j1 returned exit code 2 [ 273s] debian/rules:16: recipe for target 'build' failed [ 273s] make: *** [build] Error 2 [ 273s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 273s] ### VM INTERACTION START ### [ 277s] [ 253.580854] sysrq: Power Off [ 277s] [ 253.584836] reboot: Power down [ 277s] ### VM INTERACTION END ### [ 277s] [ 277s] obs-arm-3 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:41:08 UTC 2020. [ 277s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 83s] [COMPILING libboard/qmod/source/i2c.c] [ 83s] [COMPILING libboard/qmod/source/board_qmod.c] [ 84s] [COMPILING apps/dfu/main.c] [ 84s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 84s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 84s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 84s] Memory region Used Size Region Size %age Used [ 84s] rom: 16584 B16 KB101.22% [ 84s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/5.4.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 84s] /usr/lib/gcc/arm-none-eabi/5.4.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 200 bytes [ 84s] collect2: error: ld returned 1 exit status [ 84s] % [ 84s] Makefile:234: recipe for target 'flash' failed [ 84s] make[2]: *** [flash] Error 1 [ 84s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 84s] Makefile:13: recipe for target 'fw-qmod-dfu' failed [ 84s] make[1]: *** [fw-qmod-dfu] Error 2 [ 84s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 84s] dh_auto_build: make -j1 returned exit code 2 [ 84s] debian/rules:16: recipe for target 'build' failed [ 84s] make: *** [build] Error 2 [ 84s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 84s] ### VM INTERACTION START ### [ 87s] [ 81.691415] sysrq: Power Off [ 87s] [ 81.696735] reboot: Power down [ 87s] ### VM INTERACTION END ### [ 87s] [ 87s] sheep87 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:38:58 UTC 2020. [ 87s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in Debian_10/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 177s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 177s] [COMPILING libboard/qmod/source/card_pres.c] [ 177s] [COMPILING libboard/qmod/source/wwan_led.c] [ 177s] [COMPILING libboard/qmod/source/i2c.c] [ 177s] [COMPILING libboard/qmod/source/board_qmod.c] [ 178s] [COMPILING apps/dfu/main.c] [ 178s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 178s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 178s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 179s] Memory region Used Size Region Size %age Used [ 179s] rom: 16504 B16 KB100.73% [ 179s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 179s] /usr/lib/gcc/arm-none-eabi/7.3.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 120 bytes [ 179s] collect2: error: ld returned 1 exit status [ 179s] % [ 179s] make[2]: *** [Makefile:234: flash] Error 1 [ 179s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 179s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 179s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 179s] dh_auto_build: make -j1 returned exit code 2 [ 179s] make: *** [debian/rules:16: build] Error 2 [ 179s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 179s] ### VM INTERACTION START ### [ 182s] [ 169.981246] sysrq: Power Off [ 182s] [ 169.982805] reboot: Power down [ 182s] ### VM INTERACTION END ### [ 182s] [ 182s] obs-arm-9 failed "build simtrace2_0.7.0.61.1afb7.dsc" at Fri Aug 7 01:39:10 UTC 2020. [ 182s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmocom-bb[master]: firmware/makefile: Add GIT_SHORTHASH
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19542 ) Change subject: firmware/makefile: Add GIT_SHORTHASH .. firmware/makefile: Add GIT_SHORTHASH GIT_SHORTHASH is used by the recently introduced snake game. Change-Id: I837e3dcc5c44e64ca7f6c243c08981ed01f35dd1 --- M src/target/firmware/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/target/firmware/Makefile.inc b/src/target/firmware/Makefile.inc index a91cf4f..2be240d 100644 --- a/src/target/firmware/Makefile.inc +++ b/src/target/firmware/Makefile.inc @@ -39,6 +39,7 @@ GIT VERSION GIT_COMMIT:=$(shell git describe --always) +GIT_SHORTHASH:=$(shell git rev-parse --short HEAD) GIT_MODIFIED:=$(shell (git status | grep "modified:\|added:\|deleted:" -q) && echo "-modified") GIT_REVISION:=$(GIT_COMMIT)$(GIT_MODIFIED) @@ -46,6 +47,9 @@ ASFLAGS += -DGIT_REVISION=\"$(GIT_REVISION)\" CFLAGS += -DGIT_REVISION=\"$(GIT_REVISION)\" +ASFLAGS += -DGIT_SHORTHASH=\"$(GIT_SHORTHASH)\" +CFLAGS += -DGIT_SHORTHASH=\"$(GIT_SHORTHASH)\" + GLOBAL DATA ALL_OBJS= -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I837e3dcc5c44e64ca7f6c243c08981ed01f35dd1 Gerrit-Change-Number: 19542 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmocom-bb[master]: firmware/makefile: Add GIT_SHORTHASH
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19542 ) Change subject: firmware/makefile: Add GIT_SHORTHASH .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I837e3dcc5c44e64ca7f6c243c08981ed01f35dd1 Gerrit-Change-Number: 19542 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 21:13:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: configure.ac: fix: do not define HAVE_NEON unconditionally
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19545 ) Change subject: configure.ac: fix: do not define HAVE_NEON unconditionally .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I761a7afaeda9d232ac26edff47949e911f8f1f0c Gerrit-Change-Number: 19545 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 21:12:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: configure.ac: print ARM NEON instructions support status
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19546 ) Change subject: configure.ac: print ARM NEON instructions support status .. configure.ac: print ARM NEON instructions support status Change-Id: I0e8910d6cf337a95d6b4295f5c425d2d4cfa2b41 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index d249be9..fbdcb57 100644 --- a/configure.ac +++ b/configure.ac @@ -384,6 +384,8 @@ [Enable ARM NEON instructions support [default=no]] )], [neon=$enableval], [neon="no"]) +AC_MSG_CHECKING([whether to enable ARM NEON instructions support]) +AC_MSG_RESULT([$neon]) AM_CONDITIONAL(HAVE_NEON, [test "x$neon" != "xno"]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e8910d6cf337a95d6b4295f5c425d2d4cfa2b41 Gerrit-Change-Number: 19546 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: configure.ac: print ARM NEON instructions support status
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19546 ) Change subject: configure.ac: print ARM NEON instructions support status .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e8910d6cf337a95d6b4295f5c425d2d4cfa2b41 Gerrit-Change-Number: 19546 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 21:12:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: configure.ac: fix: do not define HAVE_NEON unconditionally
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19545 ) Change subject: configure.ac: fix: do not define HAVE_NEON unconditionally .. configure.ac: fix: do not define HAVE_NEON unconditionally Change-Id: I761a7afaeda9d232ac26edff47949e911f8f1f0c --- M configure.ac 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index cc8d3a7..d249be9 100644 --- a/configure.ac +++ b/configure.ac @@ -384,8 +384,6 @@ [Enable ARM NEON instructions support [default=no]] )], [neon=$enableval], [neon="no"]) -AC_DEFINE(HAVE_NEON,, -[Support ARM NEON instructions]) AM_CONDITIONAL(HAVE_NEON, [test "x$neon" != "xno"]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I761a7afaeda9d232ac26edff47949e911f8f1f0c Gerrit-Change-Number: 19545 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19543 ) Change subject: src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST .. src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST Change-Id: I641c25f8aec249df43c781debfc967f07e221b9d --- M src/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index be09784..c2847ec 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -54,7 +54,7 @@ endif BUILT_SOURCES = crc8gen.c crc16gen.c crc32gen.c crc64gen.c -EXTRA_DIST = conv_acc_sse_impl.h crcXXgen.c.tpl +EXTRA_DIST = conv_acc_sse_impl.h conv_acc_neon_impl.h crcXXgen.c.tpl libosmocore_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641c25f8aec249df43c781debfc967f07e221b9d Gerrit-Change-Number: 19543 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: configure.ac: clarify description of --enable-neon
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19544 ) Change subject: configure.ac: clarify description of --enable-neon .. configure.ac: clarify description of --enable-neon Change-Id: Id261dcf396f19a385203ae5f339cc5570efa4aab --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 2397b2f..cc8d3a7 100644 --- a/configure.ac +++ b/configure.ac @@ -381,7 +381,7 @@ AC_ARG_ENABLE(neon, [AS_HELP_STRING( [--enable-neon], - [Enable NEON support] + [Enable ARM NEON instructions support [default=no]] )], [neon=$enableval], [neon="no"]) AC_DEFINE(HAVE_NEON,, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id261dcf396f19a385203ae5f339cc5570efa4aab Gerrit-Change-Number: 19544 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: configure.ac: clarify description of --enable-neon
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19544 ) Change subject: configure.ac: clarify description of --enable-neon .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id261dcf396f19a385203ae5f339cc5570efa4aab Gerrit-Change-Number: 19544 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 21:11:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19543 ) Change subject: src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641c25f8aec249df43c781debfc967f07e221b9d Gerrit-Change-Number: 19543 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 21:11:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: configure.ac: fix: do not define HAVE_NEON unconditionally
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19545 ) Change subject: configure.ac: fix: do not define HAVE_NEON unconditionally .. configure.ac: fix: do not define HAVE_NEON unconditionally Change-Id: I761a7afaeda9d232ac26edff47949e911f8f1f0c --- M configure.ac 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/19545/1 diff --git a/configure.ac b/configure.ac index cc8d3a7..d249be9 100644 --- a/configure.ac +++ b/configure.ac @@ -384,8 +384,6 @@ [Enable ARM NEON instructions support [default=no]] )], [neon=$enableval], [neon="no"]) -AC_DEFINE(HAVE_NEON,, -[Support ARM NEON instructions]) AM_CONDITIONAL(HAVE_NEON, [test "x$neon" != "xno"]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I761a7afaeda9d232ac26edff47949e911f8f1f0c Gerrit-Change-Number: 19545 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmocore[master]: src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19543 ) Change subject: src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST .. src/Makefile.am: add conv_acc_neon_impl.h to EXTRA_DIST Change-Id: I641c25f8aec249df43c781debfc967f07e221b9d --- M src/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/43/19543/1 diff --git a/src/Makefile.am b/src/Makefile.am index be09784..c2847ec 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -54,7 +54,7 @@ endif BUILT_SOURCES = crc8gen.c crc16gen.c crc32gen.c crc64gen.c -EXTRA_DIST = conv_acc_sse_impl.h crcXXgen.c.tpl +EXTRA_DIST = conv_acc_sse_impl.h conv_acc_neon_impl.h crcXXgen.c.tpl libosmocore_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I641c25f8aec249df43c781debfc967f07e221b9d Gerrit-Change-Number: 19543 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmocore[master]: configure.ac: clarify description of --enable-neon
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19544 ) Change subject: configure.ac: clarify description of --enable-neon .. configure.ac: clarify description of --enable-neon Change-Id: Id261dcf396f19a385203ae5f339cc5570efa4aab --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/19544/1 diff --git a/configure.ac b/configure.ac index 2397b2f..cc8d3a7 100644 --- a/configure.ac +++ b/configure.ac @@ -381,7 +381,7 @@ AC_ARG_ENABLE(neon, [AS_HELP_STRING( [--enable-neon], - [Enable NEON support] + [Enable ARM NEON instructions support [default=no]] )], [neon=$enableval], [neon="no"]) AC_DEFINE(HAVE_NEON,, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id261dcf396f19a385203ae5f339cc5570efa4aab Gerrit-Change-Number: 19544 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmocore[master]: configure.ac: print ARM NEON instructions support status
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19546 ) Change subject: configure.ac: print ARM NEON instructions support status .. configure.ac: print ARM NEON instructions support status Change-Id: I0e8910d6cf337a95d6b4295f5c425d2d4cfa2b41 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/19546/1 diff --git a/configure.ac b/configure.ac index d249be9..fbdcb57 100644 --- a/configure.ac +++ b/configure.ac @@ -384,6 +384,8 @@ [Enable ARM NEON instructions support [default=no]] )], [neon=$enableval], [neon="no"]) +AC_MSG_CHECKING([whether to enable ARM NEON instructions support]) +AC_MSG_RESULT([$neon]) AM_CONDITIONAL(HAVE_NEON, [test "x$neon" != "xno"]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e8910d6cf337a95d6b4295f5c425d2d4cfa2b41 Gerrit-Change-Number: 19546 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmocom-bb[master]: firmware/makefile: Add GIT_SHORTHASH
roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19542 ) Change subject: firmware/makefile: Add GIT_SHORTHASH .. firmware/makefile: Add GIT_SHORTHASH GIT_SHORTHASH is used by the recently introduced snake game. Change-Id: I837e3dcc5c44e64ca7f6c243c08981ed01f35dd1 --- M src/target/firmware/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/42/19542/1 diff --git a/src/target/firmware/Makefile.inc b/src/target/firmware/Makefile.inc index a91cf4f..2be240d 100644 --- a/src/target/firmware/Makefile.inc +++ b/src/target/firmware/Makefile.inc @@ -39,6 +39,7 @@ GIT VERSION GIT_COMMIT:=$(shell git describe --always) +GIT_SHORTHASH:=$(shell git rev-parse --short HEAD) GIT_MODIFIED:=$(shell (git status | grep "modified:\|added:\|deleted:" -q) && echo "-modified") GIT_REVISION:=$(GIT_COMMIT)$(GIT_MODIFIED) @@ -46,6 +47,9 @@ ASFLAGS += -DGIT_REVISION=\"$(GIT_REVISION)\" CFLAGS += -DGIT_REVISION=\"$(GIT_REVISION)\" +ASFLAGS += -DGIT_SHORTHASH=\"$(GIT_SHORTHASH)\" +CFLAGS += -DGIT_SHORTHASH=\"$(GIT_SHORTHASH)\" + GLOBAL DATA ALL_OBJS= -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I837e3dcc5c44e64ca7f6c243c08981ed01f35dd1 Gerrit-Change-Number: 19542 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange
Change in libosmocore[master]: gsm_412 Cell Broadcast
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/11410 ) Change subject: gsm_412 Cell Broadcast .. Patch Set 9: Code-Review-1 (5 comments) CR-1 due to LE specific field order. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h File include/osmocom/gsm/protocol/gsm_04_12.h: https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@48 PS9, Line 48: ?? What should be here? https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@56 PS9, Line 56: gsm412_warning_type This is only valid for little endian, please run 'libosmocore/contrib/struct_endianess.py'. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@84 PS9, Line 84: gsm412_9_serial_nr Same here. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@91 PS9, Line 91: gsm412_9_page_param And here. https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@114 PS9, Line 114: struct gsm412_ A missing structure or TODO? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/11410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1a17c2ae8bf62150327956c10cb5bb896939e3fd Gerrit-Change-Number: 11410 Gerrit-PatchSet: 9 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 17:55:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: encoding: assert() presence of Downlink TBF
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19310 ) Change subject: encoding: assert() presence of Downlink TBF .. Patch Set 1: (1 comment) Sorry for late reply, somehow I missed these comments. Given that this is not supposed to happen, logging is not really important in this case. I really like the idea of sending crash indications over GSMTAP though. https://gerrit.osmocom.org/c/osmo-pcu/+/19310/1/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/19310/1/src/encoding.cpp@497 PS1, Line 497: OSMO_ASSERT(as_dl_tbf(tbf) != NULL); > UNRELATED: maybe we should make sure that osmo_panic_default() sends a GSMTAP > packet, if gsmtap logg […] Indeed, this is an interesting idea. Especially if this "crash indication" would additionally contain the backtrace. We should definitely create a ticket. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04 Gerrit-Change-Number: 19310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 17:33:33 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-pcu[master]: encoding: assert() presence of Downlink TBF
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19310 ) Change subject: encoding: assert() presence of Downlink TBF .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04 Gerrit-Change-Number: 19310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 16:49:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: encoding: assert() presence of Downlink TBF
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19310 ) Change subject: encoding: assert() presence of Downlink TBF .. encoding: assert() presence of Downlink TBF This is not something that should normally happen. If it happens, then it's definitely a bug, and we should not tolerate it. Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/encoding.cpp b/src/encoding.cpp index 2564575..9dfd7c9 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -494,10 +494,7 @@ /* 3GPP TS 44.018 §10.5.2.16 IA Rest Octets */ dest->cur_bit = wp; if (downlink) { - if (!as_dl_tbf(tbf)) { - LOGP(DRLCMACDL, LOGL_ERROR, "Cannot encode DL IMMEDIATE ASSIGNMENT without TBF\n"); - return -EINVAL; - } + OSMO_ASSERT(as_dl_tbf(tbf) != NULL); rc = write_ia_rest_downlink(as_dl_tbf(tbf), dest, polling, gsm48_ta_is_valid(ta), fn, alpha, gamma, ta_idx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04 Gerrit-Change-Number: 19310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: stp/STP_Test.cfg: Add M3UA and IPA tests
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19113 ) Change subject: stp/STP_Test.cfg: Add M3UA and IPA tests .. stp/STP_Test.cfg: Add M3UA and IPA tests Change-Id: Ib8a874d842854cd919edbc1929352fcc3fc1ad97 --- M stp/STP_Tests.cfg 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/stp/STP_Tests.cfg b/stp/STP_Tests.cfg index 3ba2d13..945ef8f 100644 --- a/stp/STP_Tests.cfg +++ b/stp/STP_Tests.cfg @@ -15,4 +15,6 @@ [MAIN_CONTROLLER] [EXECUTE] +STP_Tests_M3UA.control +STP_Tests_IPA.control STP_Tests.control -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8a874d842854cd919edbc1929352fcc3fc1ad97 Gerrit-Change-Number: 19113 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in libosmocore[master]: libomsocoding: NEON viterbi acceleration
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19372 ) Change subject: libomsocoding: NEON viterbi acceleration .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I58ff2cb4ce3514f43390ff0a2121f81e6a4983b5 Gerrit-Change-Number: 19372 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 16:47:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: libomsocoding: NEON viterbi acceleration
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19372 ) Change subject: libomsocoding: NEON viterbi acceleration .. libomsocoding: NEON viterbi acceleration configure flag required to enable this: --enable-neon Although autodetection according to __ARM_NEON would work because this is only defined if the fpu is neon neon-fp16 neon-vfpv3 neon-vfpv4 neon-fp-armv8 crypto-neon-fp-armv8 doing that would lead to a unknown performance impact, so it needs to be enabled manually. Speedup is about ~1.3-1.5 on a unspecified single core Cortex A9. This requires handling a special case for RACH with len 14 which is far too short for neon and would actually incur a performance penalty of 25%. Related: OS#4585 Change-Id: I58ff2cb4ce3514f43390ff0a2121f81e6a4983b5 --- M configure.ac M src/Makefile.am M src/conv_acc.c A src/conv_acc_neon.c A src/conv_acc_neon_impl.h 5 files changed, 508 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index f69c78d..2397b2f 100644 --- a/configure.ac +++ b/configure.ac @@ -378,6 +378,17 @@ AM_CONDITIONAL(HAVE_SSE4_1, false) fi +AC_ARG_ENABLE(neon, + [AS_HELP_STRING( + [--enable-neon], + [Enable NEON support] + )], + [neon=$enableval], [neon="no"]) +AC_DEFINE(HAVE_NEON,, +[Support ARM NEON instructions]) +AM_CONDITIONAL(HAVE_NEON, [test "x$neon" != "xno"]) + + OSMO_AC_CODE_COVERAGE dnl Check if the compiler supports specified GCC's built-in function diff --git a/src/Makefile.am b/src/Makefile.am index 16119d9..be09784 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -48,6 +48,11 @@ endif endif +if HAVE_NEON +libosmocore_la_SOURCES += conv_acc_neon.c +# conv_acc_neon.lo : AM_CFLAGS += -mfpu=neon no, could as well be vfp with neon +endif + BUILT_SOURCES = crc8gen.c crc16gen.c crc32gen.c crc64gen.c EXTRA_DIST = conv_acc_sse_impl.h crcXXgen.c.tpl diff --git a/src/conv_acc.c b/src/conv_acc.c index c16e436..0f6f7ca 100644 --- a/src/conv_acc.c +++ b/src/conv_acc.c @@ -85,6 +85,11 @@ void osmo_conv_sse_avx_vdec_free(int16_t *ptr); #endif +#ifdef HAVE_NEON +int16_t *osmo_conv_neon_vdec_malloc(size_t n); +void osmo_conv_neon_vdec_free(int16_t *ptr); +#endif + /* Forward Metric Units */ void osmo_conv_gen_metrics_k5_n2(const int8_t *seq, const int16_t *out, int16_t *sums, int16_t *paths, int norm); @@ -129,6 +134,21 @@ int16_t *sums, int16_t *paths, int norm); #endif +#if defined(HAVE_NEON) +void osmo_conv_neon_metrics_k5_n2(const int8_t *seq, const int16_t *out, + int16_t *sums, int16_t *paths, int norm); +void osmo_conv_neon_metrics_k5_n3(const int8_t *seq, const int16_t *out, + int16_t *sums, int16_t *paths, int norm); +void osmo_conv_neon_metrics_k5_n4(const int8_t *seq, const int16_t *out, + int16_t *sums, int16_t *paths, int norm); +void osmo_conv_neon_metrics_k7_n2(const int8_t *seq, const int16_t *out, + int16_t *sums, int16_t *paths, int norm); +void osmo_conv_neon_metrics_k7_n3(const int8_t *seq, const int16_t *out, + int16_t *sums, int16_t *paths, int norm); +void osmo_conv_neon_metrics_k7_n4(const int8_t *seq, const int16_t *out, + int16_t *sums, int16_t *paths, int norm); +#endif + /* Trellis State * state - Internal lshift register value * prev - Register values of previous 0 and 1 states @@ -528,6 +548,12 @@ if (dec->k == 5) { switch (dec->n) { case 2: +/* rach len 14 is too short for neon */ +#ifdef HAVE_NEON + if (code->len < 100) + dec->metric_func = osmo_conv_gen_metrics_k5_n2; + else +#endif dec->metric_func = osmo_conv_metrics_k5_n2; break; case 3: @@ -681,6 +707,8 @@ } else { INIT_POINTERS(gen); } +#elif defined(HAVE_NEON) + INIT_POINTERS(neon); #else INIT_POINTERS(gen); #endif diff --git a/src/conv_acc_neon.c b/src/conv_acc_neon.c new file mode 100644 index 000..7244946 --- /dev/null +++ b/src/conv_acc_neon.c @@ -0,0 +1,110 @@ +/*! \file conv_acc_neon.c + * Accelerated Viterbi decoder implementation + * for architectures with only NEON available. */ +/* + * (C) 2020 by sysmocom - s.f.m.c. GmbH + * Author: Eric Wild + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A
Change in osmocom-bb[master]: Implemented rand() and automove for snake.
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19487 ) Change subject: Implemented rand() and automove for snake. .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I94bf887160a4a58423b93fcfd47c92e09404507c Gerrit-Change-Number: 19487 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: Initial commit for the game Snake.
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19484 ) Change subject: Initial commit for the game Snake. .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6a409074285fda90f966b1727c9c0f068dd050d3 Gerrit-Change-Number: 19484 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: abandon
Change in osmocom-bb[master]: If the snake eats itself the score will be decremented.
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19488 ) Change subject: If the snake eats itself the score will be decremented. .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I91eaf50c11321ada9ffdc2f692847a13ff3d3e6a Gerrit-Change-Number: 19488 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: Adjusted coding style.
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19489 ) Change subject: Adjusted coding style. .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9b5250579290b6eb1e33d446e9fc7d2c082c4002 Gerrit-Change-Number: 19489 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: abandon
Change in osmocom-bb[master]: Wrote my not yet feature complete implementation of Snake.
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19486 ) Change subject: Wrote my not yet feature complete implementation of Snake. .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib146f749b60e5851ba0723546697e09a6a05ae85 Gerrit-Change-Number: 19486 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: firmware/fb: Implemtented fb_set_p(uint16_t x, uint16_t y)
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19485 ) Change subject: firmware/fb: Implemtented fb_set_p(uint16_t x,uint16_t y) .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I21e8da1cbf4654b786626b94b197438facef902a Gerrit-Change-Number: 19485 Gerrit-PatchSet: 2 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmo-bts[master]: pcu_sock: separate trx / ts filling from pcu_tx_info_ind()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19511 ) Change subject: pcu_sock: separate trx / ts filling from pcu_tx_info_ind() .. pcu_sock: separate trx / ts filling from pcu_tx_info_ind() This would allow to avoid further nasting in 'for' loops. Change-Id: Idb102c77751ccf77fd246f538e62fd7acf6ee88b --- M src/common/pcu_sock.c 1 file changed, 35 insertions(+), 26 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index ca8dd15..392900a 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -112,6 +112,39 @@ } } +static void info_ind_fill_trx(struct gsm_pcu_if_info_trx *trx_info, + const struct gsm_bts_trx *trx) +{ + unsigned int tn; + + trx_info->pdch_mask = 0; + trx_info->arfcn = trx->arfcn; + trx_info->hlayer1 = trx_get_hlayer1(trx); + + if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || + trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) { + LOGPTRX(trx, DPCU, LOGL_INFO, "unavailable for PCU (op=%s adm=%s)\n", + abis_nm_opstate_name(trx->mo.nm_state.operational), + abis_nm_admin_name(trx->mo.nm_state.administrative)); + return; + } + + for (tn = 0; tn < 8; tn++) { + const struct gsm_bts_trx_ts *ts = >ts[tn]; + + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (!ts_should_be_pdch(ts)) + continue; + + trx_info->pdch_mask |= (1 << tn); + trx_info->tsc[tn] = gsm_ts_tsc(ts); + + LOGP(DPCU, LOGL_INFO, "(trx=%u,ts=%u) PDCH available (tsc=%u arfcn=%u)\n", + trx->nr, ts->nr, trx_info->tsc[tn], trx->arfcn); + } +} + int pcu_tx_info_ind(void) { struct gsm_network *net = _gsmnet; @@ -122,8 +155,7 @@ struct gprs_rlc_cfg *rlcc; struct gsm_bts_gprs_nsvc *nsvc; struct gsm_bts_trx *trx; - struct gsm_bts_trx_ts *ts; - int i, j; + int i; LOGP(DPCU, LOGL_INFO, "Sending info\n"); @@ -223,30 +255,7 @@ continue; } - info_ind->trx[trx->nr].pdch_mask = 0; - info_ind->trx[trx->nr].arfcn = trx->arfcn; - info_ind->trx[trx->nr].hlayer1 = trx_get_hlayer1(trx); - if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || - trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) { - LOGPTRX(trx, DPCU, LOGL_INFO, "unavailable for PCU (op=%s adm=%s)\n", - abis_nm_opstate_name(trx->mo.nm_state.operational), - abis_nm_admin_name(trx->mo.nm_state.administrative)); - continue; - } - for (j = 0; j < 8; j++) { - ts = >ts[j]; - if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED - && ts_should_be_pdch(ts)) { - info_ind->trx[trx->nr].pdch_mask |= (1 << j); - info_ind->trx[trx->nr].tsc[j] = gsm_ts_tsc(ts); - - LOGP(DPCU, LOGL_INFO, "trx=%d ts=%d: " - "available (tsc=%d arfcn=%d)\n", - trx->nr, ts->nr, - info_ind->trx[trx->nr].tsc[j], - info_ind->trx[trx->nr].arfcn); - } - } + info_ind_fill_trx(_ind->trx[trx->nr], trx); } return pcu_sock_send(net, msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb102c77751ccf77fd246f538e62fd7acf6ee88b Gerrit-Change-Number: 19511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: pcu_sock: use LOGPTRX() in info_ind_fill_trx()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19512 ) Change subject: pcu_sock: use LOGPTRX() in info_ind_fill_trx() .. pcu_sock: use LOGPTRX() in info_ind_fill_trx() Change-Id: I91410b32199780e41e0111b480e7611cdae7e022 --- M src/common/pcu_sock.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 392900a..53822a2 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -140,8 +140,8 @@ trx_info->pdch_mask |= (1 << tn); trx_info->tsc[tn] = gsm_ts_tsc(ts); - LOGP(DPCU, LOGL_INFO, "(trx=%u,ts=%u) PDCH available (tsc=%u arfcn=%u)\n", - trx->nr, ts->nr, trx_info->tsc[tn], trx->arfcn); + LOGPTRX(trx, DPCU, LOGL_INFO, "PDCH on ts=%u is available " + "(tsc=%u arfcn=%u)\n", ts->nr, trx_info->tsc[tn], trx->arfcn); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I91410b32199780e41e0111b480e7611cdae7e022 Gerrit-Change-Number: 19512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: pcu_sock: separate trx / ts filling from pcu_tx_info_ind()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19511 ) Change subject: pcu_sock: separate trx / ts filling from pcu_tx_info_ind() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb102c77751ccf77fd246f538e62fd7acf6ee88b Gerrit-Change-Number: 19511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:44:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: pcu_sock: warn about maximum transceiver number constraints
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19510 ) Change subject: pcu_sock: warn about maximum transceiver number constraints .. pcu_sock: warn about maximum transceiver number constraints Change-Id: I600860b12758a73e1bba6d9d508cf67c3d88cf34 --- M src/common/pcu_sock.c 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 0125793..ca8dd15 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -215,13 +215,17 @@ info_ind->remote_ip[i] = nsvc->remote_ip; } - for (i = 0; i < 8; i++) { - trx = gsm_bts_trx_num(bts, i); - if (!trx) - break; - info_ind->trx[i].pdch_mask = 0; - info_ind->trx[i].arfcn = trx->arfcn; - info_ind->trx[i].hlayer1 = trx_get_hlayer1(trx); + llist_for_each_entry(trx, >trx_list, list) { + if (trx->nr >= ARRAY_SIZE(info_ind->trx)) { + LOGPTRX(trx, DPCU, LOGL_NOTICE, "PCU interface (version %u) " + "cannot handle more than %zu transceivers => skipped\n", + PCU_IF_VERSION, ARRAY_SIZE(info_ind->trx)); + continue; + } + + info_ind->trx[trx->nr].pdch_mask = 0; + info_ind->trx[trx->nr].arfcn = trx->arfcn; + info_ind->trx[trx->nr].hlayer1 = trx_get_hlayer1(trx); if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) { LOGPTRX(trx, DPCU, LOGL_INFO, "unavailable for PCU (op=%s adm=%s)\n", @@ -233,14 +237,14 @@ ts = >ts[j]; if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED && ts_should_be_pdch(ts)) { - info_ind->trx[i].pdch_mask |= (1 << j); - info_ind->trx[i].tsc[j] = gsm_ts_tsc(ts); + info_ind->trx[trx->nr].pdch_mask |= (1 << j); + info_ind->trx[trx->nr].tsc[j] = gsm_ts_tsc(ts); LOGP(DPCU, LOGL_INFO, "trx=%d ts=%d: " "available (tsc=%d arfcn=%d)\n", trx->nr, ts->nr, - info_ind->trx[i].tsc[j], - info_ind->trx[i].arfcn); + info_ind->trx[trx->nr].tsc[j], + info_ind->trx[trx->nr].arfcn); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I600860b12758a73e1bba6d9d508cf67c3d88cf34 Gerrit-Change-Number: 19510 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: pcu_sock: use a 'switch' statement in ts_should_be_pdch()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19509 ) Change subject: pcu_sock: use a 'switch' statement in ts_should_be_pdch() .. pcu_sock: use a 'switch' statement in ts_should_be_pdch() Change-Id: I628c2c5198c52fb82309dfe4a31a59aeebc00f09 --- M src/common/pcu_sock.c 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 8966b31..0125793 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -86,9 +86,10 @@ static bool ts_should_be_pdch(const struct gsm_bts_trx_ts *ts) { - if (ts->pchan == GSM_PCHAN_PDCH) + switch (ts->pchan) { + case GSM_PCHAN_PDCH: return true; - if (ts->pchan == GSM_PCHAN_TCH_F_PDCH) { + case GSM_PCHAN_TCH_F_PDCH: /* When we're busy deactivating the PDCH, we first set * DEACT_PENDING, tell the PCU about it and wait for a * response. So DEACT_PENDING means "no PDCH" to the PCU. @@ -99,16 +100,16 @@ return !(ts->flags & TS_F_PDCH_DEACT_PENDING); else return (ts->flags & TS_F_PDCH_ACT_PENDING); - } - if (ts->pchan == GSM_PCHAN_TCH_F_TCH_H_PDCH) { + case GSM_PCHAN_TCH_F_TCH_H_PDCH: /* * When we're busy de-/activating the PDCH, we first set * ts->dyn.pchan_want, tell the PCU about it and wait for a * response. So only care about dyn.pchan_want here. */ return ts->dyn.pchan_want == GSM_PCHAN_PDCH; + default: + return false; } - return false; } int pcu_tx_info_ind(void) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I628c2c5198c52fb82309dfe4a31a59aeebc00f09 Gerrit-Change-Number: 19509 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: pcu_sock: use LOGPTRX() in info_ind_fill_trx()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19512 ) Change subject: pcu_sock: use LOGPTRX() in info_ind_fill_trx() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I91410b32199780e41e0111b480e7611cdae7e022 Gerrit-Change-Number: 19512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:44:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: pcu_sock: warn about maximum transceiver number constraints
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19510 ) Change subject: pcu_sock: warn about maximum transceiver number constraints .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I600860b12758a73e1bba6d9d508cf67c3d88cf34 Gerrit-Change-Number: 19510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:44:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: verify hopping parameters in the INFO.ind message
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19518 ) Change subject: BTS_Tests: verify hopping parameters in the INFO.ind message .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9bb164fd2c7c48b91e0d7bd1abaf3cfec155342c Gerrit-Change-Number: 19518 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 16:43:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: compose the MA bitmask in f_resolve_fh_params()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19517 ) Change subject: BTS_Tests: compose the MA bitmask in f_resolve_fh_params() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic0a07d9deb60712347a42d9aa7813c684eaccd01 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 16:43:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/scheduler: implement baseband frequency hopping
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19030 ) Change subject: osmo-bts-trx/scheduler: implement baseband frequency hopping .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68f4ae09fd0789ad0d8f1c1e17e17dfc4de8e462 Gerrit-Change-Number: 19030 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 16:43:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 ) Change subject: bsc CBSP: log expected response in f_cbsp_write .. Abandoned loggign was only required during R, not now anymore -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617 Gerrit-Change-Number: 19433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: abandon
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG The sysmobts uses the same OML attributes as IP.access. Because the IP.access attribute only supports IPv4 as NSVC configuration, add an own attribute. Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 --- M include/osmocom/gsm/protocol/gsm_12_21.h M src/gsm/abis_nm.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 86d12ea..06755c9 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -511,6 +511,7 @@ /* osmocom (osmo-bts) specific attributes, used in combination * with the "org.osmocom" manufacturer identification */ + NM_ATT_OSMO_NS_LINK_CFG = 0xfd, /* osmocom version supports IPv4 & IPv6 in difference to IPACC */ NM_ATT_OSMO_REDUCEPOWER = 0xfe, /* TLV_TYPE_TV */ }; #define NM_ATT_BS11_FILE_DATA NM_ATT_EVENT_TYPE diff --git a/src/gsm/abis_nm.c b/src/gsm/abis_nm.c index 3fb8f0f..13837d2 100644 --- a/src/gsm/abis_nm.c +++ b/src/gsm/abis_nm.c @@ -589,6 +589,7 @@ /*! org.osmocom GSM A-bis OML TLV parser definition */ const struct tlv_definition abis_nm_osmo_att_tlvdef = { .def = { + [NM_ATT_OSMO_NS_LINK_CFG] = { TLV_TYPE_TL16V }, [NM_ATT_OSMO_REDUCEPOWER] = { TLV_TYPE_TV }, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged
Change in libosmocore[master]: osmo_sock_init2: improve support for AF_UNSPEC
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19140 ) Change subject: osmo_sock_init2: improve support for AF_UNSPEC .. osmo_sock_init2: improve support for AF_UNSPEC osmo_sock_init2 abstract two calls of getaddrinfo into one. While there aren't problems with AF_INET or AF_INET6. When using AF_UNSPEC there are corner cases when this fails. E.g. calling local_host with "" and remote_host with an IPv6 only address results in setting up a local socket with AF_INET while trying to connect from there towards AF_INET6 will most likely fail. To prevent such cases with AF_UNSPEC, search prio calling any syscalls if local and remote site supports AF_INET or AF_INET6. In case both supported, prefer AF_INET6 Change-Id: I397c633931fd00d4f083955a3c49a40fb002d766 --- M src/socket.c M tests/socket/socket_test.c M tests/socket/socket_test.err M tests/socket/socket_test.ok 4 files changed, 105 insertions(+), 14 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/socket.c b/src/socket.c index 7fa9ab3..9c60821 100644 --- a/src/socket.c +++ b/src/socket.c @@ -260,22 +260,85 @@ const char *local_host, uint16_t local_port, const char *remote_host, uint16_t remote_port, unsigned int flags) { - struct addrinfo *result, *rp; + struct addrinfo *local = NULL, *remote = NULL, *rp; int sfd = -1, rc, on = 1; + bool local_ipv4 = false, local_ipv6 = false; + bool remote_ipv4 = false, remote_ipv6 = false; + if ((flags & (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT)) == 0) { LOGP(DLGLOBAL, LOGL_ERROR, "invalid: you have to specify either " "BIND or CONNECT flags\n"); return -EINVAL; } + /* figure out local address infos */ + if (flags & OSMO_SOCK_F_BIND) { + local = addrinfo_helper(family, type, proto, local_host, local_port, true); + if (!local) + return -EINVAL; + } + + /* figure out remote address infos */ + if (flags & OSMO_SOCK_F_CONNECT) { + remote = addrinfo_helper(family, type, proto, remote_host, remote_port, false); + if (!remote) { + if (local) + freeaddrinfo(local); + + return -EINVAL; + } + } + + /* It must do a full run to ensure AF_UNSPEC does not fail. +* In case first local valid entry is IPv4 and only remote valid entry +* is IPv6 or vice versa */ + if (family == AF_UNSPEC) { + for (rp = local; rp != NULL; rp = rp->ai_next) { + switch (rp->ai_family) { + case AF_INET: + local_ipv4 = true; + break; + case AF_INET6: + local_ipv6 = true; + break; + } + } + + for (rp = remote; rp != NULL; rp = rp->ai_next) { + switch (rp->ai_family) { + case AF_INET: + remote_ipv4 = true; + break; + case AF_INET6: + remote_ipv6 = true; + break; + } + } + + /* priotize ipv6 as per RFC */ + if (local_ipv6 && remote_ipv6) + family = AF_INET6; + else if (local_ipv4 && remote_ipv4) + family = AF_INET; + else { + if (local) + freeaddrinfo(local); + if (remote) + freeaddrinfo(remote); + LOGP(DLGLOBAL, LOGL_ERROR, "Unable to find a common protocol (IPv4 or IPv6) for local host: %s and remote host: %s.\n", +local_host, remote_host); + return -ENODEV; + } + } + /* figure out local side of socket */ if (flags & OSMO_SOCK_F_BIND) { - result = addrinfo_helper(family, type, proto, local_host, local_port, true); - if (!result) - return -EINVAL; + for (rp = local; rp != NULL; rp = rp->ai_next) { + /* When called with AF_UNSPEC, family will set to IPv4 or IPv6 */ + if (rp->ai_family != family) + continue; - for (rp = result; rp != NULL; rp =
Change in libosmocore[master]: osmo_sock_init2: improve support for AF_UNSPEC
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19140 ) Change subject: osmo_sock_init2: improve support for AF_UNSPEC .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I397c633931fd00d4f083955a3c49a40fb002d766 Gerrit-Change-Number: 19140 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 06 Aug 2020 16:40:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 ) Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG .. Patch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/6/src/gsm/abis_nm.c@515 PS6, Line 515: NM_ATT_OSMO_NS_LINK_CFG > Shouldn't this be a part of abis_nm_osmo_att_tlvdef? At least > NM_ATT_OSMO_REDUCEPOWER is defined the […] see my comment https://gerrit.osmocom.org/c/libosmocore/+/19146#message-613e3f74ae329e8cf29b825cd7cac017631dd3f3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 16:41:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc CBSP: quick-fix f_cbsp_init_client()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19435 ) Change subject: bsc CBSP: quick-fix f_cbsp_init_client() .. Patch Set 1: > So instead of this patch, we should fix osmo-bsc to send a RESTART when a > client connects, right? yes, this is my understanding of the specification. But please don't take my word for it and check if you also read TS 48.049 that way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib93530691344c6dc4c0a8318bee2edf87e309a42 Gerrit-Change-Number: 19435 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 16:40:18 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gsm_412 Cell Broadcast
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/11410 ) Change subject: gsm_412 Cell Broadcast .. Patch Set 9: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/11410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1a17c2ae8bf62150327956c10cb5bb896939e3fd Gerrit-Change-Number: 11410 Gerrit-PatchSet: 9 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:39:33 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the...
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19482 ) Change subject: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed .. firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed I am not sure how other developers do this. There are probably better ways to make testing faster but I kind of like it this way. I just call the twl3025_power_off_now function when the power key is pressed. Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 --- M src/target/firmware/abb/twl3025.c M src/target/firmware/include/abb/twl3025.h 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/target/firmware/abb/twl3025.c b/src/target/firmware/abb/twl3025.c index ad2b01f..5b792d6 100644 --- a/src/target/firmware/abb/twl3025.c +++ b/src/target/firmware/abb/twl3025.c @@ -229,6 +229,15 @@ twl3025_reg_write(VRPCDEV, 0x01); } +void twl3025_power_off_now(void) +{ + /* The phone will restart if the power butten has not been released. +* This can be useful for development. */ + unsigned long flags; + local_firq_save(flags); + twl3025_reg_write(VRPCDEV, 0x01); +} + void twl3025_clk13m(int enable) { if (enable) { diff --git a/src/target/firmware/include/abb/twl3025.h b/src/target/firmware/include/abb/twl3025.h index 727bde0..8bc2fb9 100755 --- a/src/target/firmware/include/abb/twl3025.h +++ b/src/target/firmware/include/abb/twl3025.h @@ -147,6 +147,7 @@ int twl3025_get_pwon(void); void twl3025_power_off(void); +void twl3025_power_off_now(void); void twl3025_clk13m(int enable); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 Gerrit-Change-Number: 19482 Gerrit-PatchSet: 2 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: merged
Change in osmocom-bb[master]: firmware/fb: Implemtented fb_bw8_line and fb_set_p(uint16_t x, uint16_...
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19483 ) Change subject: firmware/fb: Implemtented fb_bw8_line and fb_set_p(uint16_t x,uint16_t y) .. firmware/fb: Implemtented fb_bw8_line and fb_set_p(uint16_t x,uint16_t y) Change-Id: Id8856ace2a31ba4ebcd04746e0c96c23a679cc40 --- M src/target/firmware/fb/fb_bw8.c M src/target/firmware/fb/fb_st7558.c M src/target/firmware/include/fb/fb_bw8.h M src/target/firmware/include/fb/framebuffer.h 4 files changed, 60 insertions(+), 19 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/target/firmware/fb/fb_bw8.c b/src/target/firmware/fb/fb_bw8.c index ffb59d8..0fc12ee 100644 --- a/src/target/firmware/fb/fb_bw8.c +++ b/src/target/firmware/fb/fb_bw8.c @@ -22,6 +22,7 @@ * */ +#include #include #include @@ -51,7 +52,7 @@ uint16_t x2,uint16_t y2 /* right lower corner (inclusive) */ ){ fb_sanitize_box(,,,); - + x2++; /* see definition of fb_bw8->damage_x2/y2 */ y2++; @@ -86,17 +87,6 @@ #endif } -static void fb_bw8_line(uint16_t x1,uint16_t y1,uint16_t x2,uint16_t y2){ - fb_sanitize_box(,,,); - /* FIXME : this is currently unimplemented! */ -} - -void fb_bw8_lineto(uint16_t x,uint16_t y){ - fb_bw8_line(framebuffer->cursor_x,framebuffer->cursor_y,x,y); - framebuffer->cursor_x = x; - framebuffer->cursor_y = y; -} - /* depending on color set (add to or_mask) or clear (remove from and_mask) bit number bitnum */ static void set_pixel(uint8_t *and_mask, @@ -166,13 +156,56 @@ framebuffer->cursor_y = y; } +/* Just set the given pixel to the current front ground color. + * This function does not update the damage rectangle! */ +void fb_bw8_set_pixel(uint16_t x,uint16_t y){ + uint8_t *p = fb_bw8->mem + (y/8)*framebuffer->width + x; + uint8_t and_mask = 0xff, or_mask = 0x00; + set_fg_pixel(_mask, _mask, y % 8); + *p = (*p & and_mask)|or_mask; + /* printf("fb_bw8_set_pixel: set: (%u|%u)\n", x, y); */ +} + +/* Copy Paste from + * http://de.wikipedia.org/wiki/Bresenham-Algorithmus#Kompakte_Variante */ +static void fb_bw8_line(int16_t x1,int16_t y1,int16_t x2,int16_t y2){ + fb_limit_fb_range(, ); + fb_limit_fb_range(, ); + fb_bw8_update_damage(x1,y1,x2,y2); + /* printf("fb_bw8_line from (%u|%u) -> (%u|%u)\n", x1, y1, x2, y2); */ + int16_t dx = abs(x2-x1), dy = -abs(y2-y1); + int16_t sx = x1 dy) { err += dy; x1 += sx; } /* e_xy+e_x > 0 */ + if (e2 < dx) { err += dx; y1 += sy; } /* e_xy+e_y < 0 */ + } +} + +/* Set the given pixel to the current front ground color and update the damage + * rectangle. */ +void fb_bw8_set_p(uint16_t x,uint16_t y){ + fb_bw8_update_damage(x,y,x+1,y+1); + fb_bw8_set_pixel(x,y); +} + +void fb_bw8_lineto(uint16_t x,uint16_t y){ + fb_bw8_line(framebuffer->cursor_x,framebuffer->cursor_y,x,y); + framebuffer->cursor_x = x; + framebuffer->cursor_y = y; +} + + /* this is the most ridiculous function ever, because it has to fiddle with two braindead bitmaps at once, both being organized differently */ /* draw text at current position, with current font and colours up to a width of maxwidth pixels, return pixelwidth consumed */ - int fb_bw8_putstr(char *str,int maxwidth){ const struct fb_font *font = fb_fonts[framebuffer->font]; @@ -187,7 +220,7 @@ int bitmap_offs,bitmap_bit; // offset inside bitmap, bit number of pixel int fb8_offs; // offset to current pixel in framebuffer uint8_t and_mask,or_mask; // to draw on framebuffer - uint8_t *p; // pointer into framebuffer memorya + uint8_t *p; // pointer into framebuffer memory int total_w;// total width /* center, if maxwidth < 0 */ @@ -251,7 +284,7 @@ bitmap_y = fchr->bbox_h - (char_y - fchr->bbox_y) - 1; - fb8_offs = framebuffer->cursor_x + + fb8_offs = framebuffer->cursor_x + char_x + (y/8)*framebuffer->width; and_mask = 0xff; diff --git a/src/target/firmware/fb/fb_st7558.c b/src/target/firmware/fb/fb_st7558.c index fdcd38f..f09b12b 100644 --- a/src/target/firmware/fb/fb_st7558.c +++ b/src/target/firmware/fb/fb_st7558.c @@ -118,6 +118,7 @@ .clear = fb_bw8_clear, .boxto = fb_bw8_boxto, .lineto = fb_bw8_lineto, + .set_p = fb_bw8_set_p, .putstr = fb_bw8_putstr, .flush = fb_st7558_flush, .width = ST7558_WIDTH, diff --git a/src/target/firmware/include/fb/fb_bw8.h b/src/target/firmware/include/fb/fb_bw8.h index d84f91a..db0b31a 100644 ---
Change in osmocom-bb[master]: firmware/fb: Implemtented fb_bw8_line and fb_set_p(uint16_t x, uint16_...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19483 ) Change subject: firmware/fb: Implemtented fb_bw8_line and fb_set_p(uint16_t x,uint16_t y) .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8856ace2a31ba4ebcd04746e0c96c23a679cc40 Gerrit-Change-Number: 19483 Gerrit-PatchSet: 3 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:38:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware/app: Initial commit for the game Snake
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19490 ) Change subject: firmware/app: Initial commit for the game Snake .. firmware/app: Initial commit for the game Snake Change-Id: I3c3f012552f2a7474ade911fc071c89e55e19352 --- A src/target/firmware/apps/snake_game/main.c 1 file changed, 521 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/firmware/apps/snake_game/main.c b/src/target/firmware/apps/snake_game/main.c new file mode 100644 index 000..44dda9a --- /dev/null +++ b/src/target/firmware/apps/snake_game/main.c @@ -0,0 +1,521 @@ +/* The game Snake as Free Software for Calypso Phone */ + +/* (C) 2013 by Marcel `sdrfnord` McKinnon + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * + */ + +#include +#include + +#include +#define DEBUG 1 +#define KNRM "\x1B[0m" +#define UNDERLINE "\x1B[4m" + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +unsigned long next = 1; +/* This is not a good random number generator ... */ +int rand(void) +{ + next = next * 110351 + 12; + return (unsigned int)(next & 0x7fff); +} + +void srand(unsigned int seed) +{ + next = seed; +} + +#define BLANK 0 +#define HEAD 1 +#define TAIL 2 +#define HEAD_FOOD 3 +#define FOOD 9 +#define SBODY 20 +/* The numbers above 20 are the distance to the head. + * 21 is direly behind the head. + */ +#define STDLEN 3 +#define HEIGHT 7 +#define WIDTH 16 + +/* Time in ms to wait to the next auto move of the snake. */ +#define WAIT_TIME_AUTOMOVE 300 + +struct position { + int x; + int y; +} pos; + +uint8_t field[WIDTH][HEIGHT]; +int16_t score = 0, lenght = 0; +enum errors { ALLRIGHT, SNAKE_COL } err; + +void printField(); +void setItem(int, int, int); +void movepos(char); +void increaseBodyAge(); +void setFood() +{ + int x, y, c; + for (c = 0; c < 10; c++) { + x = rand() % (WIDTH - 1); + y = rand() % (HEIGHT - 1); +#if DEBUG > 0 + printf("Next %u\n", next); + printf("Rand (%d|%d)\n", x, y); +#endif + if (field[x][y] == BLANK) { + field[x][y] = FOOD; + return; + } + } + for (x = 0; x < WIDTH; x++) { + for (y = 0; y < HEIGHT; y++) { + if (field[x][y] == BLANK) { + field[x][y] = FOOD; +#if DEBUG > 0 + printf("Set without rand (%d|%d) %d\n", x, y, + c); +#endif + return; + } + } + } +} + +static void print_snake_str(char *text, int16_t x, int16_t y) +{ + x = 6 * x; + y = 8 * (y + 1) - 3; +#if DEBUG > 1 + printf("Put string %s to (%d|%d)\n", text, x, y); +#endif + fb_gotoxy(x, y); + fb_putstr(text, framebuffer->width); +} + +char Move; +void movepos(char move) +{ + Move = move; + setItem(pos.x, pos.y, SBODY); + switch (move) { + case 'h': pos.x--; break; + case 'j': pos.y++; break; + case 'k': pos.y--; break; + case 'l': pos.x++; break; + } + switch (move) { + case 'j': + case 'k': + if (pos.y == -1) + pos.y = HEIGHT - 1; + else if (pos.y == HEIGHT) + pos.y = 0; + increaseBodyAge(); + break; + case 'l': + case 'h': + if (pos.x == -1) + pos.x = WIDTH - 1; + else if (pos.x == WIDTH) + pos.x = 0; + increaseBodyAge(); + break; + } + setItem(pos.x, pos.y, HEAD); + printField(); +} + +void movepos_timer_cb(void *p) +{ + struct osmo_timer_list *tmr = (struct osmo_timer_list *)p; +#if DEBUG > 0 + printf("Auto move %c\n", Move); +#endif + movepos(Move); + + osmo_timer_schedule(tmr,
Change in osmocom-bb[master]: firmware/app: Initial commit for the game Snake
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19490 ) Change subject: firmware/app: Initial commit for the game Snake .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c3f012552f2a7474ade911fc071c89e55e19352 Gerrit-Change-Number: 19490 Gerrit-PatchSet: 3 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:38:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19482 ) Change subject: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 Gerrit-Change-Number: 19482 Gerrit-PatchSet: 2 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 16:37:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: firmware: fix builds with gcc stack smashing protection enabled
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/19527 ) Change subject: firmware: fix builds with gcc stack smashing protection enabled .. firmware: fix builds with gcc stack smashing protection enabled On Ubuntu 20.04 when builiding dpkg packages, even when cross-compiling firmware, gcc stack smashing protection is enabled. Let's provide what is minimally required in order to sucessfully complete builds on such platforms. Change-Id: Ic2f68f16b0730e7b5db17c30effc29a2909d1997 Closes: OS#4687 --- M firmware/Makefile A firmware/libcommon/source/stack_check.c 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/firmware/Makefile b/firmware/Makefile index bdca6e5..7be5c30 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -100,7 +100,7 @@ C_LIBUSB_RT = dfu.c dfu_runtime.c C_LIBUSB_DFU = dfu.c dfu_desc.c dfu_driver.c C_LIBCOMMON = string.c stdio.c fputs.c usb_buf.c ringbuffer.c pseudo_talloc.c host_communication.c \ - main_common.c + main_common.c stack_check.c C_BOARD = $(notdir $(wildcard libboard/common/source/*.c)) C_BOARD += $(notdir $(wildcard libboard/$(BOARD)/source/*.c)) diff --git a/firmware/libcommon/source/stack_check.c b/firmware/libcommon/source/stack_check.c new file mode 100644 index 000..3130dd8 --- /dev/null +++ b/firmware/libcommon/source/stack_check.c @@ -0,0 +1,14 @@ +#include +#include + +/* This is what's minimally required to fix builds on Ubuntu 20.04, + * where stack smashing protection is enabled by default when using dpkg + * - even when cross-compiling: https://osmocom.org/issues/4687 + */ + +uintptr_t __stack_chk_guard = 0xdeadbeef; + +void __stack_chk_fail(void) +{ + osmo_panic("Stack smashing detected!\r\n"); +} -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/19527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic2f68f16b0730e7b5db17c30effc29a2909d1997 Gerrit-Change-Number: 19527 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: ttcn3/suites/bts: also enable both BTS_Tests_{SMSCB, LAPDm}
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19531 ) Change subject: ttcn3/suites/bts: also enable both BTS_Tests_{SMSCB,LAPDm} .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8eb28584e90ad012cbf7f3175ee3a8e775c8d523 Gerrit-Change-Number: 19531 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:35:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx: fix resource leak in bts_model_trx_deact_rf()
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19537 ) Change subject: osmo-bts-trx: fix resource leak in bts_model_trx_deact_rf() .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id20d12f76b1aac5c81a79eb293e537ed41a1c28a Gerrit-Change-Number: 19537 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmo-bts[master]: osmo-bts-trx: fix resource leak in bts_model_trx_deact_rf()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19537 ) Change subject: osmo-bts-trx: fix resource leak in bts_model_trx_deact_rf() .. Patch Set 1: > Patch Set 1: Code-Review-1 > > as written in the respective redmine issue, I think this is the wrong > approach. The problem is that the schedule is disabled/reset, when all we > actually want is disable mostly transmit. ACK. I'll abandon this change. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id20d12f76b1aac5c81a79eb293e537ed41a1c28a Gerrit-Change-Number: 19537 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 16:09:12 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libusrp[master]: Bump version: 3.4.4.8-e2c8 → 3.4.5
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/19541 ) Change subject: Bump version: 3.4.4.8-e2c8 → 3.4.5 .. Bump version: 3.4.4.8-e2c8 → 3.4.5 Change-Id: Iaf3545265d8ec28f9b760b55e6170808c35f6ccb --- M debian/changelog 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index a62e533..4dff165 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,21 @@ +libusrp (3.4.5) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * jenkins.sh: Workaround race conditon in make + * m4/ax_boost_base.m4: Update to newest version from autoconf-archive + * m4/ax_boost_base.m4: Fix debian multiarch_libsubdir path for arch armv7l + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * Makefile.common: LTVERSIONFLAGS: remove -release + * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in + + [ Harald Welte ] + * debian/control: Add python as BuildRequires, as edit-gpif uses it + + -- Harald Welte Sat, 13 Jun 2020 14:04:03 +0200 + libusrp (3.4.4) unstable; urgency=medium * debian/rules: Don't delete .tarball-version -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Iaf3545265d8ec28f9b760b55e6170808c35f6ccb Gerrit-Change-Number: 19541 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: osmo-bts-trx: fix resource leak in bts_model_trx_deact_rf()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19537 ) Change subject: osmo-bts-trx: fix resource leak in bts_model_trx_deact_rf() .. Patch Set 1: Code-Review-1 as written in the respective redmine issue, I think this is the wrong approach. The problem is that the schedule is disabled/reset, when all we actually want is disable mostly transmit. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id20d12f76b1aac5c81a79eb293e537ed41a1c28a Gerrit-Change-Number: 19537 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 15:54:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: rsl: constify the 'lchan' argument of rsl_tx_conn_fail()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19536 ) Change subject: rsl: constify the 'lchan' argument of rsl_tx_conn_fail() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icec43d7c1f3b99292fa87462ad65b2c19fdd3b5f Gerrit-Change-Number: 19536 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: radio_link_timeout(): bad_frame is a boolean
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19535 ) Change subject: l1sap: radio_link_timeout(): bad_frame is a boolean .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id173f69705948aafe861ec36450b147deda95246 Gerrit-Change-Number: 19535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: radio_link_timeout(): use LOGPLCHAN() macro
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19534 ) Change subject: l1sap: radio_link_timeout(): use LOGPLCHAN() macro .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4 Gerrit-Change-Number: 19534 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: radio_link_timeout(): clarify logging messages
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19533 ) Change subject: l1sap: radio_link_timeout(): clarify logging messages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iafb190454c65cebe3de3c212fa8b10a86ec7eb67 Gerrit-Change-Number: 19533 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19528 ) Change subject: lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4f1f39bf90b0a7c9ea448dab255daf99cd36bb4a Gerrit-Change-Number: 19528 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 15:52:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19528 ) Change subject: lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type .. lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type When the BTS is is not an ipaccess BTS, the BTS can only be an E1 bts. In that case E1 endpoints must be used and there will be no RTP stream setup towards the BTS. Change-Id: I4f1f39bf90b0a7c9ea448dab255daf99cd36bb4a Related: OS#2547 --- M include/osmocom/bsc/bsc_subscr_conn_fsm.h M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/lchan_rtp_fsm.c 3 files changed, 32 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h b/include/osmocom/bsc/bsc_subscr_conn_fsm.h index 1a827d9..7893735 100644 --- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h +++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h @@ -65,7 +65,7 @@ int gscon_sigtran_send(struct gsm_subscriber_connection *conn, struct msgb *msg); struct osmo_mgcpc_ep *gscon_ensure_mgw_endpoint(struct gsm_subscriber_connection *conn, - uint16_t msc_assigned_cic); + uint16_t msc_assigned_cic, struct gsm_lchan *for_lchan); bool gscon_connect_mgw_to_msc(struct gsm_subscriber_connection *conn, struct gsm_lchan *for_lchan, const char *addr, uint16_t port, diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 9b1fb3f..0faf3b2 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -471,8 +471,10 @@ * SCCPlite, pass in msc_assigned_cic the CIC received upon BSSMAP Assignment Command or BSSMAP Handover * Request form the MSC (which is only stored in conn->user_plane after success). Ignored for AoIP. */ struct osmo_mgcpc_ep *gscon_ensure_mgw_endpoint(struct gsm_subscriber_connection *conn, - uint16_t msc_assigned_cic) + uint16_t msc_assigned_cic, struct gsm_lchan *for_lchan) { + const char *epname; + if (conn->user_plane.mgw_endpoint) return conn->user_plane.mgw_endpoint; @@ -489,13 +491,19 @@ msc_assigned_cic, osmo_mgcpc_ep_name(conn->user_plane.mgw_endpoint)); } else if (gscon_is_aoip(conn)) { - /* use dynamic RTPBRIDGE endpoint allocation in MGW */ + + if (is_ipaccess_bts(for_lchan->ts->trx->bts)) + /* use dynamic RTPBRIDGE endpoint allocation in MGW */ + epname = mgcp_client_rtpbridge_wildcard(conn->network->mgw.client); + else + epname = mgcp_client_e1_epname(conn, conn->network->mgw.client, 1, for_lchan->ts->e1_link.e1_ts, 16, for_lchan->ts->e1_link.e1_ts_ss*2); + conn->user_plane.mgw_endpoint = osmo_mgcpc_ep_alloc(conn->fi, GSCON_EV_FORGET_MGW_ENDPOINT, conn->network->mgw.client, conn->network->mgw.tdefs, conn->fi->id, - "%s", mgcp_client_rtpbridge_wildcard(conn->network->mgw.client)); + "%s", epname); } else { LOGPFSML(conn->fi, LOGL_ERROR, "Conn is neither SCCPlite nor AoIP!?\n"); return NULL; @@ -570,7 +578,7 @@ } else verb = MGCP_VERB_CRCX; - gscon_ensure_mgw_endpoint(conn, for_lchan->activate.info.msc_assigned_cic); + gscon_ensure_mgw_endpoint(conn, for_lchan->activate.info.msc_assigned_cic, for_lchan); if (!conn->user_plane.mgw_endpoint) { LOGPFSML(conn->fi, LOGL_ERROR, "Unable to allocate endpoint info\n"); diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 24a7147..1fe5452 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -141,6 +141,12 @@ struct osmo_mgcpc_ep_ci *use_mgwep_ci = lchan_use_mgw_endpoint_ci_bts(lchan); struct mgcp_conn_peer crcx_info = {}; + if (!is_ipaccess_bts(lchan->ts->trx->bts)) { + LOG_LCHAN_RTP(lchan, LOGL_DEBUG, "Audio link to-BTS via E1, skipping IPACC\n"); + lchan_rtp_fsm_state_chg(LCHAN_RTP_ST_WAIT_LCHAN_READY); + return; + } + if (use_mgwep_ci) { LOG_LCHAN_RTP(lchan, LOGL_DEBUG, "MGW endpoint already available: %s\n", osmo_mgcpc_ep_ci_name(use_mgwep_ci)); @@ -148,7 +154,7 @@ return; } - mgwep = gscon_ensure_mgw_endpoint(lchan->conn,
Change in osmo-bsc[master]: lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type
laforge has uploaded a new patch set (#3) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19528 ) Change subject: lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type .. lchan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type When the BTS is is not an ipaccess BTS, the BTS can only be an E1 bts. In that case E1 endpoints must be used and there will be no RTP stream setup towards the BTS. Change-Id: I4f1f39bf90b0a7c9ea448dab255daf99cd36bb4a Related: OS#2547 --- M include/osmocom/bsc/bsc_subscr_conn_fsm.h M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/lchan_rtp_fsm.c 3 files changed, 32 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/19528/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4f1f39bf90b0a7c9ea448dab255daf99cd36bb4a Gerrit-Change-Number: 19528 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in libusrp[master]: Bump version: 3.4.4.8-e2c8 → 3.4.5
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/19541 ) Change subject: Bump version: 3.4.4.8-e2c8 → 3.4.5 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Iaf3545265d8ec28f9b760b55e6170808c35f6ccb Gerrit-Change-Number: 19541 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Aug 2020 15:51:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libusrp[master]: Bump version: 3.4.4.8-e2c8 → 3.4.5
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libusrp/+/19541 ) Change subject: Bump version: 3.4.4.8-e2c8 → 3.4.5 .. Bump version: 3.4.4.8-e2c8 → 3.4.5 Change-Id: Iaf3545265d8ec28f9b760b55e6170808c35f6ccb --- M debian/changelog 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/41/19541/1 diff --git a/debian/changelog b/debian/changelog index a62e533..4dff165 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,21 @@ +libusrp (3.4.5) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * jenkins.sh: Workaround race conditon in make + * m4/ax_boost_base.m4: Update to newest version from autoconf-archive + * m4/ax_boost_base.m4: Fix debian multiarch_libsubdir path for arch armv7l + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * Makefile.common: LTVERSIONFLAGS: remove -release + * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in + + [ Harald Welte ] + * debian/control: Add python as BuildRequires, as edit-gpif uses it + + -- Harald Welte Sat, 13 Jun 2020 14:04:03 +0200 + libusrp (3.4.4) unstable; urgency=medium * debian/rules: Don't delete .tarball-version -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Iaf3545265d8ec28f9b760b55e6170808c35f6ccb Gerrit-Change-Number: 19541 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-bsc[master]: lctan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19528 ) Change subject: lctan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type .. Patch Set 2: (1 comment) (ensure all messages are sent) https://gerrit.osmocom.org/c/osmo-bsc/+/19528/1/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/19528/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@495 PS1, Line 495: conn->lchan > I see some code paths where conn->lchan can be NULL. […] Yes, thats true, it also crashes in TTCN3. I have fixed that now. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4f1f39bf90b0a7c9ea448dab255daf99cd36bb4a Gerrit-Change-Number: 19528 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 14:04:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-bsc[master]: lctan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19528 ) Change subject: lctan_rtp_fsm: use E1 endpoints if the BTS is not ipaccess type .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4f1f39bf90b0a7c9ea448dab255daf99cd36bb4a Gerrit-Change-Number: 19528 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 14:02:39 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-abis[master]: trau_sync: Check return value of osmo_fsm_register()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19539 ) Change subject: trau_sync: Check return value of osmo_fsm_register() .. trau_sync: Check return value of osmo_fsm_register() Change-Id: Ieaf524423033864a8b79ea1b04b62568d10ffbd3 Closes: CID#211593 --- M src/trau/trau_sync.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/trau/trau_sync.c b/src/trau/trau_sync.c index dfd7ce4..730cf0c 100644 --- a/src/trau/trau_sync.c +++ b/src/trau/trau_sync.c @@ -524,5 +524,5 @@ for (i = 0; i < ARRAY_SIZE(sync_patterns); i++) sync_pattern_register(_patterns[i]); - osmo_fsm_register(_sync_fsm); + OSMO_ASSERT(osmo_fsm_register(_sync_fsm) == 0); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieaf524423033864a8b79ea1b04b62568d10ffbd3 Gerrit-Change-Number: 19539 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmo-abis[master]: trau_frame: Add missing break statement in osmo_trau_frame_encode()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19540 ) Change subject: trau_frame: Add missing break statement in osmo_trau_frame_encode() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I986781218a844e043b6206124696452b3afec7fd Gerrit-Change-Number: 19540 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 10:05:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: trau_frame: Fix computation of odd parity while encoding HR frames
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19538 ) Change subject: trau_frame: Fix computation of odd parity while encoding HR frames .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5 Gerrit-Change-Number: 19538 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 10:05:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: trau_frame: Add missing break statement in osmo_trau_frame_encode()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19540 ) Change subject: trau_frame: Add missing break statement in osmo_trau_frame_encode() .. trau_frame: Add missing break statement in osmo_trau_frame_encode() Change-Id: I986781218a844e043b6206124696452b3afec7fd Closes: CID#211592 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 1159bb1..9c9baa7 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1249,6 +1249,7 @@ /* timing alignment may happen: increased space requirement */ if (n_bits < 2 * 20 * 8 - 1) return -ENOSPC; + break; case OSMO_TRAU8_DATA: case OSMO_TRAU8_OAM: if (n_bits < 1 * 20 * 8) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I986781218a844e043b6206124696452b3afec7fd Gerrit-Change-Number: 19540 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmo-abis[master]: trau_frame: Fix computation of odd parity while encoding HR frames
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19538 ) Change subject: trau_frame: Fix computation of odd parity while encoding HR frames .. trau_frame: Fix computation of odd parity while encoding HR frames division modulo 1 is always 0, and hence we always returned '1' as parity bit. Instead, we need to check if the LSB is set in order to know if the number of bits is odd or even. Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5 Closes: CID#211594 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 0a8faf9..1159bb1 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -817,7 +817,7 @@ sum++; } - if (sum % 1) + if (sum & 1) return 0; else return 1; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5 Gerrit-Change-Number: 19538 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmo-abis[master]: trau_sync: Check return value of osmo_fsm_register()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19539 ) Change subject: trau_sync: Check return value of osmo_fsm_register() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieaf524423033864a8b79ea1b04b62568d10ffbd3 Gerrit-Change-Number: 19539 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 10:05:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: e1_input: Support I.460 timeslot type
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/18933 to look at the new patch set (#4). Change subject: e1_input: Support I.460 timeslot type .. e1_input: Support I.460 timeslot type Unlike the legacy TRAU mode, this only adds I460 mux/demux, without any TRAU frame synchronization. The user must still be adding the actual sub-channels using osmo_i460_subchan_add() depending on his requirements. Change-Id: I44da6dfec77ef475adb35001a0e4fa11d549aa02 --- M include/osmocom/abis/e1_input.h M src/e1_input.c M src/input/dahdi.c M src/input/e1d.c M src/input/misdn.c 5 files changed, 41 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/33/18933/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I44da6dfec77ef475adb35001a0e4fa11d549aa02 Gerrit-Change-Number: 18933 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmo-abis[master]: trau_frame: Fix computation of odd parity while encoding HR frames
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19538 ) Change subject: trau_frame: Fix computation of odd parity while encoding HR frames .. trau_frame: Fix computation of odd parity while encoding HR frames division modulo 1 is always 0, and hence we always returned '1' as parity bit. Instead, we need to check if the LSB is set in order to know if the number of bits is odd or even. Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5 Closes: CID#211594 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/38/19538/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 0a8faf9..1159bb1 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -817,7 +817,7 @@ sum++; } - if (sum % 1) + if (sum & 1) return 0; else return 1; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5 Gerrit-Change-Number: 19538 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in libosmo-abis[master]: trau_sync: Check return value of osmo_fsm_register()
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19539 ) Change subject: trau_sync: Check return value of osmo_fsm_register() .. trau_sync: Check return value of osmo_fsm_register() Change-Id: Ieaf524423033864a8b79ea1b04b62568d10ffbd3 Closes: CID#211593 --- M src/trau/trau_sync.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/39/19539/1 diff --git a/src/trau/trau_sync.c b/src/trau/trau_sync.c index dfd7ce4..730cf0c 100644 --- a/src/trau/trau_sync.c +++ b/src/trau/trau_sync.c @@ -524,5 +524,5 @@ for (i = 0; i < ARRAY_SIZE(sync_patterns); i++) sync_pattern_register(_patterns[i]); - osmo_fsm_register(_sync_fsm); + OSMO_ASSERT(osmo_fsm_register(_sync_fsm) == 0); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieaf524423033864a8b79ea1b04b62568d10ffbd3 Gerrit-Change-Number: 19539 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in libosmo-abis[master]: trau_frame: Add missing break statement in osmo_trau_frame_encode()
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19540 ) Change subject: trau_frame: Add missing break statement in osmo_trau_frame_encode() .. trau_frame: Add missing break statement in osmo_trau_frame_encode() Change-Id: I986781218a844e043b6206124696452b3afec7fd Closes: CID#211592 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/40/19540/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 1159bb1..9c9baa7 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1249,6 +1249,7 @@ /* timing alignment may happen: increased space requirement */ if (n_bits < 2 * 20 * 8 - 1) return -ENOSPC; + break; case OSMO_TRAU8_DATA: case OSMO_TRAU8_OAM: if (n_bits < 1 * 20 * 8) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I986781218a844e043b6206124696452b3afec7fd Gerrit-Change-Number: 19540 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange