[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

[Leif Åstrand]

Leif Åstrand has posted comments on this change.

Change subject: Use JSON.parse() instead of eval() to deserialize rpc  
callback payload

..


Patch Set 11:

The existing test suite seems to have quite good coverage, but it does not  
help when it only tests the default protocol version, i.e. 7. All the  
problems I mentioned were discovered by changing the default protocol  
version to 8 and running the RPCSuite.


Vaadin has fixes for those problems in  
https://github.com/vaadin/gwt/commit/9c8f102265c032efc575ed3c070334bf57645aa3  
and  
https://github.com/vaadin/gwt/commit/d3914682163347a9eacee8d3b23e55e62b2a97ea.  
John A is currently on vacation and I won't have time to submit a new  
version here either because I'm leaving today.


--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 11
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos 
Gerrit-Reviewer: Artur Signell 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Colin Alworth 
Gerrit-Reviewer: John Ahlroos 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Leif Åstrand 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

[Manuel Carrasco Moñino]

Hello Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3211

to look at the new patch set (#5).

Change subject: FileUpload: extending FocusWidget instead of Widget so as  
it exposes many features which already are in the file-input element:  
click(), focus(), mouseevents, keyevents, etc.

..

FileUpload: extending FocusWidget instead of Widget so as it exposes
many features which already are in the file-input element: click(),
focus(), mouseevents, keyevents, etc.

Now it is possible open the file browser calling fileupload.click().
This allows customize widgets to upload files.
It works in almost supported browsers: IE6+, Chrome, Safari, FF (from 4.0)
and Opera (from 12).

Documented css rules noticing that browsers impose many constrains to
input file styling.

Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Bugs: issue 2262, issue 4078, issue 1998
---
M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
M user/src/com/google/gwt/user/client/ui/FileUpload.java
M user/test/com/google/gwt/user/client/ui/FileUploadTest.java
3 files changed, 81 insertions(+), 31 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3211
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Patrick Tucker 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

[Manuel Carrasco Moñino]

Hello Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3211

to look at the new patch set (#4).

Change subject: FileUpload: extending FocusWidget instead of Widget so as  
it exposes many features which already are in the file-input element:  
click(), focus(), mouseevents, keyevents, etc.

..

FileUpload: extending FocusWidget instead of Widget so as it exposes
many features which already are in the file-input element: click(),
focus(), mouseevents, keyevents, etc.

Now it is possible open the file browser calling fileupload.click().
This allows customize widgets to upload files.
It works in almost supported browsers: IE6+, Chrome, Safari, FF (from 4.0)
and Opera (from 12).

Documented css rules noticing that browsers impose many constrains to
input file styling.

Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Bugs: issue 2262, issue 4078, issue 1998
---
M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
M user/src/com/google/gwt/user/client/ui/FileUpload.java
M user/test/com/google/gwt/user/client/ui/ButtonTest.java
M user/test/com/google/gwt/user/client/ui/FileUploadTest.java
4 files changed, 77 insertions(+), 27 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3211
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Patrick Tucker 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

[Manuel Carrasco Moñino]

Hello Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3211

to look at the new patch set (#3).

Change subject: FileUpload: extending FocusWidget instead of Widget so as  
it exposes many features which already are in the file-input element:  
click(), focus(), mouseevents, keyevents, etc.

..

FileUpload: extending FocusWidget instead of Widget so as it exposes
many features which already are in the file-input element: click(),
focus(), mouseevents, keyevents, etc.

Now it is possible open the file browser calling fileupload.click().
This allows customize widgets to upload files.
It works in almost supported browsers: IE6+, Chrome, Safari, FF (from 4.0)
and Opera (from 12).

Documented css rules noticing that browsers impose many constrains to
input file styling.

Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Bugs: issue 2262, issue 4078, issue 1998
---
M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
M user/src/com/google/gwt/user/client/ui/FileUpload.java
M user/test/com/google/gwt/user/client/ui/ButtonTest.java
M user/test/com/google/gwt/user/client/ui/FileUploadTest.java
4 files changed, 78 insertions(+), 28 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3211
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Patrick Tucker 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Work to do for bug 3042

[Manuel Carrasco Moñino]

In my opinion, having the tool-bar in gwt makes perfectly sense,
RichTextArea is almost unusable without a bar in any project. It's
plenty of gwt projects which have copied and pasted the code from the
showcase.

I think that you should face this issue in some steps:
1.- Listen to GWT contributors for the convenience of moving
RichTextToolbar from samples to gwt. So maintain live this thread
until you get enough feedback.
2.- Send a first patch just moving the code from show-case to gwt
(showcase should use the new code)
3.- When the patch were accepted, continue adding other features like
adding/removing widgets from the toolbar, or a panel grouping
RichTextArea + RichTextToolbar, etc. because each thing needs a
different review/discussion.

- Manolo

On Tue, Jun 11, 2013 at 7:25 PM, Adolfo Panizo Touzon
 wrote:
> Oh! Sorry I saw you were the owner and I thought you had plenty of
> responsability.
>
> Thanks, but everything is fine, the installation process is quite
> simple/clear, so, all is up  and running. :D.
>
> Keep an eye into the Issue 1127 because maybe you are interested in giving
> instructions related to both issues.
>
> Thanks,
>
> Adolfo.
>
>
> On Tue, Jun 11, 2013 at 10:28 AM, Daniel Kurka  wrote:
>>
>> Hi Adolfo,
>>
>> this is not my issue and I am not solely responsible for it.
>>
>> We should see wait and see if anybody opposes to adding this to GWT,
>> before you actually start working on it, so that your time will not be
>> wasted.
>> On the other hand you can already setup your IDE and tools to be able to
>> start. James pointed out the resources. If there is anything wrong / unclear
>> in those resources please let us know. Or you could even send a patch for
>> the homepage to be updated.
>>
>> - Daniel
>>
>>
>> On Mon, Jun 10, 2013 at 8:07 PM, Adolfo Panizo Touzon
>>  wrote:
>>>
>>> Thanks James!
>>>
>>> But I have done those steps yet (indeed I read in that link I should ask
>>> here first :D) . When I said the necessary work I meant the steps for
>>> develop the RichTextArea according to the GWT steering committee (for this
>>> issue I think Daniel is responsible) so I need to wait for his opinion.
>>>
>>> Thanks anyway for your quick response.
>>>
>>> Adolfo.
>>>
>>>
>>> On Mon, Jun 10, 2013 at 1:02 PM, James Horsley 
>>> wrote:

 Adolfo,

 To get the source checked out and compiling follow:
 http://www.gwtproject.org/makinggwtbetter.html#workingoncode

 To submit the patch use:
 http://www.gwtproject.org/makinggwtbetter.html#submittingpatches

 I recently had to move an old svn patch into gerrit and the following
 gave a very simple way to apply it
 http://stackoverflow.com/questions/659467/how-to-apply-svn-diff-to-git just
 remember to clean up any leftover .orij and .rej files.

 Cheers,
 James


 On 10 June 2013 10:01, Adolfo Panizo  wrote:
>
> Hi,
>
> as I wrote in the issue, I am able to do the necessary work for solving
> it.  So, can you guide me about the steps that I need to follow in order 
> to
> create a patch properly?
>
> Would you like to reuse some code of the old patch?
>
> I am going to contact the creator of it because maybe he continues
> interested on fixing the issue and rebase the patch with the last code.
>
> Of course if there are other issues related to RichTextArea I can solve
> as well.
>
> Thanks in advance,
>
> Adolfo.
>
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google
> Groups "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>


 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors
 ---
 You received this message because you are subscribed to the Google
 Groups "GWT Contributors" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


>>>
>>>
>>>
>>>
>>> --
>>> El precio es lo que pagas. El valor es lo que recibes.
>>> Warren Buffet
>>>
>>> --
>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>> ---
>>> You received this message because you are subscribed to the Google Groups
>>> "GWT Contributors" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>>
>>
>>
>>
>>
>> --
>> Google Germany GmbH
>> Dienerstr. 12
>> 80331 München
>>
>> Registerge

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Adds Timer#isRunning().
..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/client/Timer.java
Line 151:
I think javadoc looks good right now:

 "Returns {@code true} if the timer is running. Timer is running if and  
only if it is scheduled	but it is not expired or cancelled."


Actually it is more clear than java.swing.Timer's description which has the  
same behavior =) :


 "Returns true if the Timer is running."

If you have something specific in your mind then we can change it. However,  
we should be careful when adding more data on the javadoc as developers  
start thinking about if there is a special behavior and if they should be  
doing something specific to handle that. In this case, they should not have  
any concerns.



--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

[Goktug Gokdogan]

Goktug Gokdogan has submitted this change and it was merged.

Change subject: Set display to none for table columns that should not be  
visible.

..


Set display to none for table columns that should not be visible.

Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Review-Link: https://gwt-review.googlesource.com/#/c/3390/
---
M user/src/com/google/gwt/user/cellview/client/CellTable.java
M user/test/com/google/gwt/user/cellview/client/CellTableTest.java
2 files changed, 14 insertions(+), 5 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Goktug Gokdogan: Looks good to me, approved



diff --git a/user/src/com/google/gwt/user/cellview/client/CellTable.java  
b/user/src/com/google/gwt/user/cellview/client/CellTable.java

index 12b3db2..a3a1d57 100644
--- a/user/src/com/google/gwt/user/cellview/client/CellTable.java
+++ b/user/src/com/google/gwt/user/cellview/client/CellTable.java
@@ -18,6 +18,7 @@
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.dom.client.BrowserEvents;
 import com.google.gwt.dom.client.Document;
+import com.google.gwt.dom.client.Style.Display;
 import com.google.gwt.dom.client.Style.TableLayout;
 import com.google.gwt.dom.client.Style.Unit;
 import com.google.gwt.dom.client.TableCellElement;
@@ -889,14 +890,21 @@
 super.refreshColumnWidths();

 /*
- * Set the width to zero for all col elements that appear after the  
last
- * column. Clearing the width would cause it to take up the remaining  
width

- * in a fixed layout table.
+ * Set the width to zero and the display to none for all col elements  
that
+ * appear after the last column. Clearing the width would cause it to  
take

+ * up the remaining width in a fixed layout table.
+ *
+ * Clear the display for all columns that appear in the table.
  */
 if (colGroupEnabled) {
   int colCount = colgroup.getChildCount();
-  for (int i = getRealColumnCount(); i < colCount; i++) {
+  int lastColumn = getRealColumnCount();
+  for (int i = 0; i < lastColumn; i++) {
+ensureTableColElement(i).getStyle().clearDisplay();
+  }
+  for (int i = lastColumn; i < colCount; i++) {
 doSetColumnWidth(i, "0px");
+ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
   }
 }
   }
diff --git  
a/user/test/com/google/gwt/user/cellview/client/CellTableTest.java  
b/user/test/com/google/gwt/user/cellview/client/CellTableTest.java

index c54266f..965e59a 100644
--- a/user/test/com/google/gwt/user/cellview/client/CellTableTest.java
+++ b/user/test/com/google/gwt/user/cellview/client/CellTableTest.java
@@ -283,7 +283,7 @@
   }

   /**
-   * Test that removing a column sets its width to zero.
+   * Test that removing a column sets its width to zero and the display to  
none.

*/
   public void testRemoveColumnWithWidth() {
 CellTable table = createAbstractHasData(new TextCell());
@@ -297,6 +297,7 @@
 table.removeColumn(column1);
 table.getPresenter().flush();
 assertEquals("0px", col1.getStyle().getWidth());
+assertEquals("none", col1.getStyle().getDisplay().toLowerCase());
   }

   @Override

--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright 
Gerrit-Reviewer: Aliseya Wright 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Set display to none for table columns that should not be  
visible.

..


Patch Set 3: Code-Review+2

Ok, I (or him) might have misinterpreted what is going on.

If toggling columns works in practice, let's go ahead and see if it breaks  
anybody.


(You can click submit now if you are ready to merge.)

--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright 
Gerrit-Reviewer: Aliseya Wright 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has submitted this change and it was merged.

Change subject: Adding a DOM clear method to RootPanel
..


Adding a DOM clear method to RootPanel

By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements located under this RootPanel.

fixes Issue 516

Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Review-Link: https://gwt-review.googlesource.com/#/c/2512/
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 88 insertions(+), 0 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Brian Slesinsky: Looks good to me, approved



diff --git a/user/src/com/google/gwt/user/client/ui/RootPanel.java  
b/user/src/com/google/gwt/user/client/ui/RootPanel.java

index 8d22da0..c4929c6 100644
--- a/user/src/com/google/gwt/user/client/ui/RootPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/RootPanel.java
@@ -300,4 +300,27 @@
 super(elem. cast());
 onAttach();
   }
+
+  /**
+   * Clears the rootPanel. If clearDom is true, then also remove any DOM
+   * elements that are not widgets.
+   *
+   * By default {@link #clear()} will only remove children that are GWT  
widgets.
+   * This method also provides the option to remove all children including  
the
+   * non-widget DOM elements that are directly added (e.g. elements added  
via

+   * {@code getElement().appendChild(...)}.
+   *
+   * @param clearDom if {@code true} this method will also remove any DOM
+   *  elements that are not widgets.
+   */
+  public void clear(boolean clearDom) {
+clear();
+
+if (clearDom) {
+  com.google.gwt.user.client.Element containerElement = getElement();
+  while (containerElement.hasChildNodes()) {
+containerElement.removeChild(containerElement.getFirstChild());
+  }
+}
+  }
 }
diff --git a/user/test/com/google/gwt/user/client/ui/RootPanelTest.java  
b/user/test/com/google/gwt/user/client/ui/RootPanelTest.java

index 6584fef..d455bd1 100644
--- a/user/test/com/google/gwt/user/client/ui/RootPanelTest.java
+++ b/user/test/com/google/gwt/user/client/ui/RootPanelTest.java
@@ -19,6 +19,7 @@
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.junit.client.GWTTestCase;
+import com.google.gwt.user.client.DOM;

 /**
  * Tests {@link RootPanel}.
@@ -28,6 +29,56 @@
   @Override
   public String getModuleName() {
 return "com.google.gwt.user.User";
+  }
+
+  public void testClearRootPanelAndDOM() {
+
+RootPanel rootPanel = createDOM("testClearRootPanelAndDOM");
+
+rootPanel.add(new Button("a"));
+rootPanel.add(new Button("b"));
+
+com.google.gwt.user.client.Element newDiv = DOM.createDiv();
+newDiv.setInnerText("c");
+rootPanel.getElement().appendChild(newDiv);
+
+assertEquals(3, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
+  }
+
+  public void testClearRootPanel() {
+
+RootPanel rootPanel = createDOM("testClearRootPanel");
+
+rootPanel.add(new Button("a"));
+rootPanel.add(new Button("b"));
+
+com.google.gwt.user.client.Element newDiv = DOM.createDiv();
+newDiv.setInnerText("c");
+rootPanel.getElement().appendChild(newDiv);
+
+assertEquals(3, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(false);
+assertEquals(1, rootPanel.getElement().getChildCount());
+
+// clean up
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
+  }
+
+  public void testClearRootPanelContainingTextNodes() {
+
+RootPanel rootPanel = createDOM("testClearRootPanelAndDOM");
+
+rootPanel.getElement().setInnerHTML("Some mixed content");
+
+assertEquals(3, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
   }

   public void testDetachNowWithErrorOnDetach() {
@@ -131,4 +182,18 @@
 RootPanel.getBodyElement().appendChild(elem);
 return elem;
   }
+
+  private RootPanel createDOM(String id) {
+// create our own part in the document
+com.google.gwt.user.client.Element div = DOM.createDiv();
+div.setId(id);
+Document.get().getBody().appendChild(div);
+
+// get it via RootPanel
+RootPanel rootPanel = RootPanel.get(id);
+
+// no elements in the DOM prior to test
+assertEquals(0, rootPanel.getElement().getChildCount());
+return rootPanel;
+  }
 }

--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Revi

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Set display to none for table columns that should not be  
visible.

..


Patch Set 1:

(1 comment)


File user/src/com/google/gwt/user/cellview/client/CellTable.java
Line 905:
ensureTableColElement(i).getStyle().setDisplay(Display.NONE);
Actually I'm referring to what he originally said but I'm talking about  
some other potential problems.


In the original email (you might have not seen it) Alan said,

"...it makes changes CSS attribute "display" to "none", and the column  
element loses its "table-column" properties, and its "width" attributes do  
not propagate to the  and  elements (because this element is not a  
table-column and does not describe a column of cells)..."


so I thought that with your change we will have a problem with columns  
transitioning from hidden to visible. If the column was hidden and made  
just visible again the "setWidth" calls from super.refreshColumnWidths()  
will not be propagated to the cells because "display" property is not  
a "table-column".



--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright 
Gerrit-Reviewer: Aliseya Wright 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 6: Code-Review+2

This is a pretty minor change, breakage is unlikely, and I don't think it  
matters too much, so I'm going to stop bikeshedding. Daniel, I'm okay with  
whatever you decide.


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 6:

It is better to just call it "clear" so that people will need to read the  
javadoc instead of making assumptions what clearDom means (widgets inc. or  
not?) =)


Note that, the whole purpose of this patch is just for stuff like loading  
indicator then that it is better and safer to be done with:


 Document.get().getElementById("loading").removeFromParent();

--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Set display to none for table columns that should not be  
visible.

..


Patch Set 3:

Aliseya, you very likely responded to my comments but I can't see them. In  
order to publish them, you need to press "review" and publish in the  
specific patch set that you responded.


--
To view, visit https://gwt-review.googlesource.com/3390
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5eabeda8a3ef2f7b851d540c3776026984654c3
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Aliseya Wright 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Use JSON.parse() instead of eval() to deserialize rpc  
callback payload

..


Patch Set 11:

Sounds like we need more tests. Serialization code generally does benefit  
from a thorough test suite.


--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 11
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos 
Gerrit-Reviewer: Artur Signell 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Colin Alworth 
Gerrit-Reviewer: John Ahlroos 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Leif Åstrand 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 6:

Admittedly it's a judgment call. I'm somewhat biased in favor of shorter  
names and somewhat against giving two methods the same name. I don't think  
there's a sensible interpretation of clearing the DOM that doesn't include  
the widgets too, so it seems like we don't need to include that in the name.


(By the way, if we did have to do something tricky like avoid clearing the  
history frame then that would actually be an argument in favor of having  
this method.)


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.

[John A. Tamplin]

John A. Tamplin has posted comments on this change.

Change subject: Ensure clinits get called for JSO instance methods.
..


Patch Set 2: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3361
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Colin Alworth 
Gerrit-Reviewer: Colin Alworth 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Daniel Kurka has submitted this change and it was merged.

Change subject: adding compare for several number types
..


adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 85 insertions(+), 51 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Goktug Gokdogan: Looks good to me, approved



diff --git a/user/super/com/google/gwt/emul/java/lang/Byte.java  
b/user/super/com/google/gwt/emul/java/lang/Byte.java

index 664589e..ec3e4d9 100644
--- a/user/super/com/google/gwt/emul/java/lang/Byte.java
+++ b/user/super/com/google/gwt/emul/java/lang/Byte.java
@@ -33,6 +33,10 @@
 private static Byte[] boxedValues = new Byte[256];
   }

+  public static int compare(byte x, byte y) {
+return x - y;
+  }
+
   public static Byte decode(String s) throws NumberFormatException {
 return Byte.valueOf((byte) __decodeAndValidateInt(s, MIN_VALUE,  
MAX_VALUE));

   }
@@ -93,13 +97,7 @@
   }

   public int compareTo(Byte b) {
-if (value < b.value) {
-  return -1;
-} else if (value > b.value) {
-  return 1;
-} else {
-  return 0;
-}
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Double.java  
b/user/super/com/google/gwt/emul/java/lang/Double.java

index e32f9d2..74bdcd9 100644
--- a/user/super/com/google/gwt/emul/java/lang/Double.java
+++ b/user/super/com/google/gwt/emul/java/lang/Double.java
@@ -86,22 +86,24 @@
   };

   public static int compare(double x, double y) {
+if (x < y) {
+  return -1;
+}
+if (x > y) {
+  return 1;
+}
+if (x == y) {
+  return 0;
+}
+
 if (isNaN(x)) {
   if (isNaN(y)) {
 return 0;
   } else {
 return 1;
   }
-} else if (isNaN(y)) {
-  return -1;
-}
-
-if (x < y) {
-  return -1;
-} else if (x > y) {
-  return 1;
 } else {
-  return 0;
+  return -1;
 }
   }

diff --git a/user/super/com/google/gwt/emul/java/lang/Float.java  
b/user/super/com/google/gwt/emul/java/lang/Float.java

index fe4bc2b..84e2ef1 100644
--- a/user/super/com/google/gwt/emul/java/lang/Float.java
+++ b/user/super/com/google/gwt/emul/java/lang/Float.java
@@ -34,13 +34,7 @@
   private static final long POWER_32_INT = 4294967296L;

   public static int compare(float x, float y) {
-if (x < y) {
-  return -1;
-} else if (x > y) {
-  return 1;
-} else {
-  return 0;
-}
+return Double.compare(x, y);
   }

   public static int floatToIntBits(float value) {
@@ -187,13 +181,7 @@
   }

   public int compareTo(Float b) {
-if (value < b.value) {
-  return -1;
-} else if (value > b.value) {
-  return 1;
-} else {
-  return 0;
-}
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Integer.java  
b/user/super/com/google/gwt/emul/java/lang/Integer.java

index 04e2b00..a0c2f6f 100644
--- a/user/super/com/google/gwt/emul/java/lang/Integer.java
+++ b/user/super/com/google/gwt/emul/java/lang/Integer.java
@@ -57,6 +57,10 @@
 return x & 0x003f;
   }

+  public static int compare(int x, int y) {
+return signum(x - y);
+  }
+
   public static Integer decode(String s) throws NumberFormatException {
 return Integer.valueOf((int) __decodeAndValidateInt(s, MIN_VALUE,  
MAX_VALUE));

   }
@@ -287,13 +291,7 @@
   }

   public int compareTo(Integer b) {
-if (value < b.value) {
-  return -1;
-} else if (value > b.value) {
-  return 1;
-} else {
-  return 0;
-}
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Long.java  
b/user/super/com/google/gwt/emul/java/lang/Long.java

index c0b08d7..eaee9ec 100644
--- a/user/super/com/google/gwt/emul/java/lang/Long.java
+++ b/user/super/com/google/gwt/emul/java/lang/Long.java
@@ -58,6 +58,10 @@
 return Integer.bitCount(high) + Integer.bitCount(low);
   }

+  public static int compare(long x, long y) {
+return signum(x - y);
+  }
+
   public static Long decode(String s) 

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: adding compare for several number types
..


Patch Set 14: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 14
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#14).

Change subject: adding compare for several number types
..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 85 insertions(+), 51 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 14
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#13).

Change subject: adding compare for several number types
..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 86 insertions(+), 52 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 13
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[Brian Slesinsky]

I agree; this seems like a workaround for one application that picked the
wrong datatype. Maybe we should warn about BigDecimal being slow somewhere?
If someone wants to do some performance tests of GWT-RPC serialization,
publishing the results would be useful to the community.

My recommendation in this case would be create a new class named "Id" or
Key" that simply contains the BigDecimal, then modify the code to use it,
then change the implementation to store the data in a string field instead.
In the end you'll have more readable code.

- Brian


On Thu, Jun 13, 2013 at 12:03 PM, David  wrote:

> John,
>
> Well, if I don't have support for this patch then I better stop working on
> it. I can understand that this is not seen as a priority for GWT. Worst
> case I just replace the BigInteger/BigDecimal class in the project itself,
> that is basically what I did right now.
>
> Oracle sequences can be configured as a range between -10ˆ-26 and 10ˆ27.
> The Oracle JDBC drivers return
> a BigInteger if you force it to the extremes.
>
> Changing the application is not feasible, that will be too much work, we
> are talking about many thousands of dependencies in a huge codebase where
> BigIntegers and BigDecimals are used - while handling this optimisation on
> the RPC level can be done in just a few lines of code.
>
> In many cases we send large lists of objects that contain BigInteger,
> BigDecimals but only a few will actually be interacted with. So in that
> case we only need to convert the Strings to BigInteger (or BigDecimal) when
> really needed.
>
> David
>
> On Thu, Jun 13, 2013 at 7:52 PM, John A. Tamplin  wrote:
>
>> On Thu, Jun 13, 2013 at 3:14 AM, David  wrote:
>>
>>> The lazy parsing would only happen during deserialisation in the client.
>>> I think it is safe to assume that a BigInteger created through toString on
>>> the server will not result in a parse exception in the client code - or are
>>> there known incompatibilities ?
>>>
>>> I don't want that the regular constructor of BigInteger( String ) or
>>> BigInteger( String, int) would behave differently than before. Not even in
>>> the client when those BigInts are created in the client. That's why I was
>>> asking about the possibility to have different serialisers on client and
>>> server side.
>>>
>>> As the why, well currently the custom field serializer converts the
>>> BigInteger to a String, the client side needs to parse the string and
>>> convert it to an int array, which involves multiple substring,
>>> Integer.parseInt and multiply and add operations. Somehow IE8 has a problem
>>> with this. IE9 and other browsers are more efficient, but still that is a
>>> lot of CPU operations that can be avoided in my use case.
>>>
>>> In my particular use case they used BigInteger to represent a key in the
>>> database (oracle uses sequence numbers that are bigger than what can be
>>> represented with long). That might have not been the best idea, but those
>>> decisions have been made a long time ago, when I was not around. On the
>>> server side there is a usage of equals and compareTo happening, which would
>>> be hard to implement without a BigInteger, so there is logic in the choice.
>>> They obviously don't want to have an extra layer of objects to avoid the
>>> BigInteger in the GWT client since a lot of code is independent of client
>>> or server, this would hinder code sharing between the tiers.
>>>
>>> On the client side these id's are only send forth and back between
>>> client and server, no operation is ever performed, so making the custom
>>> field serialiser and the BigInteger cooperate gives a big performance
>>> improvement. They only operation needed on the client-side is equals,
>>> which can also be optimized to do a String comparison when bother have not
>>> been parsed after RPC.
>>>
>> 
>> I'm beginning to think such a change does not belong in GWT.  In your
>> example, wouldn't you be better served by only sending strings to the
>> client rather than BigDecimals, if they client never does anything with
>> them but send them back?  I think it is going to be pretty rare in normal
>> situations that you instantiate a BigDecimal but never actually use it in
>> the client, so it seems the special-case hack for your use-case should be
>> performed in your code instead.
>>
>> Too often people want to send things to the client that really don't
>> belong there, and that includes particular representations of it.  I know
>> DTOs are extra work over just shipping your regular objects over the wire
>> and GWT RPC makes that easy, but in many cases it is the wrong thing to do.
>>  Think about if you were building a proto for the communication -- would
>> you send the data in the current form?  If not, you shouldn't be sending it
>> that way via RPC just because it is easy to do so.
>>
>> BTW, I thought Oracle sequence numbers did fit in long (aren't they
>> int64?) -- at least all the JDBC code I see for manipulating them stores
>

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: adding compare for several number types
..


Patch Set 12:

(1 comment)

The comparison functions are usually used in non linear algorithm like  
sorting so average # of checks done for each comparison can significantly  
impact performance.



File user/super/com/google/gwt/emul/java/lang/Double.java
Line 95:
x == y is also more common than NaN so it is better to check it earlier:

{
  if (x < y) {
return -1;
  }
  if (x > y) {
return 1;
  }
  if (x == y) {
return 0;
  }

  // At this point, at least one of them is NaN

  if (isNaN(x)) {
if (isNaN(y)) {
  return 0;
}
return 1;
  } else {
return -1;
  }
}


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 12
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 6:

With that rationale we should name it clearWidgetsAndDom?

--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 6:

(1 comment)

I still don't think it's necessary but I'm okay with a helper method if  
it's very simple to use.



File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 316:   public void clear(boolean clearDom) {
How about calling this clearDom() and removing the boolean? If they don't  
want to clear the dom then they can call clear().


Rationale: clear(true) is less readable and memorable because you have to  
look up the method definition to see what "true" means. Hardly anyone would  
call this with any value other than a constant "true".



--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[John A. Tamplin]

On Thu, Jun 13, 2013 at 3:03 PM, David  wrote:

> Well, if I don't have support for this patch then I better stop working on
> it. I can understand that this is not seen as a priority for GWT. Worst
> case I just replace the BigInteger/BigDecimal class in the project itself,
> that is basically what I did right now.
>

I'm just one person and I'm not even on the steering committee, so you
shouldn't take my opinion as gospel.  To summarize, I don't think there is
any value in having lazy initialization of BigInteger in GWT since it
doesn't strike me as an important use-case that you would instantiate a lot
of them but never use them, but it might be worth looking at performance on
IE8 to see if it can be improved (which might fix your problem in a more
generally useful way).


> Changing the application is not feasible, that will be too much work, we
> are talking about many thousands of dependencies in a huge codebase where
> BigIntegers and BigDecimals are used - while handling this optimisation on
> the RPC level can be done in just a few lines of code.
>

You can also maintain a local fork of GWT if you think that is easier.


> In many cases we send large lists of objects that contain BigInteger,
> BigDecimals but only a few will actually be interacted with. So in that
> case we only need to convert the Strings to BigInteger (or BigDecimal) when
> really needed.
>

Well, if you are sending lots of stuff to the client that isn't actually
used on the client, that seems an obvious avenue for optimization.  Again,
just because you can easily ship it to the client doesn't mean you should.

-- 
John A. Tamplin

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Add support for 'ImageResource' to @url substitution in  
css. Only 'DataResource' used to be supported.

..


Patch Set 2: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3290
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ae9fe0ace59eb682a77a761fe252bf46cafa9f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Emmanuel Pellereau 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Emmanuel Pellereau 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....

[Goktug Gokdogan]

Goktug Gokdogan has submitted this change and it was merged.

Change subject: Add support for 'ImageResource' to @url substitution in  
css. Only 'DataResource' used to be supported.

..


Add support for 'ImageResource' to @url substitution in css.
Only 'DataResource' used to be supported.

Change-Id: Ie6ae9fe0ace59eb682a77a761fe252bf46cafa9f
Review-Link: https://gwt-review.googlesource.com/#/c/3290/
---
M user/src/com/google/gwt/resources/css/SubstitutionReplacer.java
M user/test/com/google/gwt/resources/client/CSSResourceTest.java
M user/test/com/google/gwt/resources/client/test.css
3 files changed, 30 insertions(+), 4 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Goktug Gokdogan: Looks good to me, approved



diff --git  
a/user/src/com/google/gwt/resources/css/SubstitutionReplacer.java  
b/user/src/com/google/gwt/resources/css/SubstitutionReplacer.java

index 885a2b4..0fe893f 100644
--- a/user/src/com/google/gwt/resources/css/SubstitutionReplacer.java
+++ b/user/src/com/google/gwt/resources/css/SubstitutionReplacer.java
@@ -17,8 +17,10 @@

 import com.google.gwt.core.ext.TreeLogger;
 import com.google.gwt.core.ext.typeinfo.JClassType;
+import com.google.gwt.core.ext.typeinfo.JType;
 import com.google.gwt.core.ext.typeinfo.NotFoundException;
 import com.google.gwt.resources.client.DataResource;
+import com.google.gwt.resources.client.ImageResource;
 import com.google.gwt.resources.css.ast.Context;
 import com.google.gwt.resources.css.ast.CssCompilerException;
 import com.google.gwt.resources.css.ast.CssDef;
@@ -44,6 +46,7 @@
 public class SubstitutionReplacer extends CssVisitor {
   private final ResourceContext context;
   private final JClassType dataResourceType;
+  private final JClassType imageResourceType;
   private final TreeLogger logger;
   private final Map substitutions;

@@ -52,6 +55,8 @@
 this.context = context;
 this.dataResourceType =  
context.getGeneratorContext().getTypeOracle().findType(

 DataResource.class.getCanonicalName());
+this.imageResourceType =  
context.getGeneratorContext().getTypeOracle().findType(

+ImageResource.class.getCanonicalName());
 this.logger = logger;
 this.substitutions = substitutions;
   }
@@ -95,21 +100,34 @@
 assert def.getValues().get(0).isDotPathValue() != null;
 DotPathValue functionName =  
def.getValues().get(0).isDotPathValue();


+JType methodType = null;
 try {
-   
ResourceGeneratorUtil.getMethodByPath(context.getClientBundleType(),

-  functionName.getParts(), dataResourceType);
+  methodType =  
ResourceGeneratorUtil.getMethodByPath(context.getClientBundleType(),

+  functionName.getParts(), null).getReturnType();
 } catch (NotFoundException e) {
   logger.log(TreeLogger.ERROR, e.getMessage());
   throw new CssCompilerException("Cannot find data method");
 }

-String instance = "((" + DataResource.class.getName() + ")("
+if (!methodType.equals(dataResourceType) &&
+!methodType.equals(imageResourceType)) {
+  String message = "Invalid method type for url substitution: " +  
methodType + ". " +

+  "Only DataResource and ImageResource are supported.";
+  logger.log(TreeLogger.ERROR, message);
+  throw new CssCompilerException(message);
+}
+
+String instance = "((" + methodType.getQualifiedSourceName() + ")("
 + context.getImplementationSimpleSourceName() + ".this."
 + functionName.getExpression() + "))";

 StringBuilder expression = new StringBuilder();
 expression.append("\"url('\" + ");
-expression.append(instance).append(".getUrl()");
+if (methodType.equals(dataResourceType)) {
+  expression.append(instance).append(".getUrl()");
+} else if (methodType.equals(imageResourceType)) {
+  expression.append(instance).append(".getURL()");
+}
 expression.append(" + \"')\"");
 result.add(new ExpressionValue(expression.toString()));
   } else {
diff --git a/user/test/com/google/gwt/resources/client/CSSResourceTest.java  
b/user/test/com/google/gwt/resources/client/CSSResourceTest.java

index ab91748..be907ae 100644
--- a/user/test/com/google/gwt/resources/client/CSSResourceTest.java
+++ b/user/test/com/google/gwt/resources/client/CSSResourceTest.java
@@ -313,6 +313,10 @@
 + Resources.INSTANCE.dataMethod().getUrl() + "')"));
 assertTrue(text.contains("backgroundNested:url('"
 + Resources.INSTANCE.nested().dataMethod().getUrl() + "')"));
+assertTrue(text.contains("backgroundImage:url('"
++ Resources.INSTANCE.spriteMethod().getURL() + "')"));
+assertTrue(text.contains("backgroundImageNested:url('"
++ Resources.INSTANCE.nested().spriteMethod().getURL() + "')"));

 // Check @eval expansion
 assertTrue(text.co

[gwt-contrib] Corp Textarea annoucement (google-web-toolkit-contributors@googlegroups.com)

[Daniel Kurka (Google Drive)]

I've shared an item with you:

Corp Textarea annoucement
https://docs.google.com/document/d/1uSFPO8tKsVvbs9RVOz9Mbyg-Llf_VABI-eoiWBfV_vs/edit?usp=sharing

It's not an attachment -- it's stored online. To open this item, just click  
the link above.


Hey Goktug,

please let me know if this is a good message to send out.

- Daniel

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[Jens]

> I'm beginning to think such a change does not belong in GWT.  In your 
> example, wouldn't you be better served by only sending strings to the 
> client rather than BigDecimals, if they client never does anything with 
> them but send them back? 
>

Thats exactly what I thought too. If its just a database key then transform 
it on server side to something that does not cost you performance on client 
side. We also use GWT-RPC and all our database ids are converted to base64 
strings before they go to the client. Works pretty well.


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[David]

John,

Well, if I don't have support for this patch then I better stop working on
it. I can understand that this is not seen as a priority for GWT. Worst
case I just replace the BigInteger/BigDecimal class in the project itself,
that is basically what I did right now.

Oracle sequences can be configured as a range between -10ˆ-26 and 10ˆ27.
The Oracle JDBC drivers return
a BigInteger if you force it to the extremes.

Changing the application is not feasible, that will be too much work, we
are talking about many thousands of dependencies in a huge codebase where
BigIntegers and BigDecimals are used - while handling this optimisation on
the RPC level can be done in just a few lines of code.

In many cases we send large lists of objects that contain BigInteger,
BigDecimals but only a few will actually be interacted with. So in that
case we only need to convert the Strings to BigInteger (or BigDecimal) when
really needed.

David

On Thu, Jun 13, 2013 at 7:52 PM, John A. Tamplin  wrote:

> On Thu, Jun 13, 2013 at 3:14 AM, David  wrote:
>
>> The lazy parsing would only happen during deserialisation in the client.
>> I think it is safe to assume that a BigInteger created through toString on
>> the server will not result in a parse exception in the client code - or are
>> there known incompatibilities ?
>>
>> I don't want that the regular constructor of BigInteger( String ) or
>> BigInteger( String, int) would behave differently than before. Not even in
>> the client when those BigInts are created in the client. That's why I was
>> asking about the possibility to have different serialisers on client and
>> server side.
>>
>> As the why, well currently the custom field serializer converts the
>> BigInteger to a String, the client side needs to parse the string and
>> convert it to an int array, which involves multiple substring,
>> Integer.parseInt and multiply and add operations. Somehow IE8 has a problem
>> with this. IE9 and other browsers are more efficient, but still that is a
>> lot of CPU operations that can be avoided in my use case.
>>
>> In my particular use case they used BigInteger to represent a key in the
>> database (oracle uses sequence numbers that are bigger than what can be
>> represented with long). That might have not been the best idea, but those
>> decisions have been made a long time ago, when I was not around. On the
>> server side there is a usage of equals and compareTo happening, which would
>> be hard to implement without a BigInteger, so there is logic in the choice.
>> They obviously don't want to have an extra layer of objects to avoid the
>> BigInteger in the GWT client since a lot of code is independent of client
>> or server, this would hinder code sharing between the tiers.
>>
>> On the client side these id's are only send forth and back between client
>> and server, no operation is ever performed, so making the custom field
>> serialiser and the BigInteger cooperate gives a big performance
>> improvement. They only operation needed on the client-side is equals,
>> which can also be optimized to do a String comparison when bother have not
>> been parsed after RPC.
>>
> 
> I'm beginning to think such a change does not belong in GWT.  In your
> example, wouldn't you be better served by only sending strings to the
> client rather than BigDecimals, if they client never does anything with
> them but send them back?  I think it is going to be pretty rare in normal
> situations that you instantiate a BigDecimal but never actually use it in
> the client, so it seems the special-case hack for your use-case should be
> performed in your code instead.
>
> Too often people want to send things to the client that really don't
> belong there, and that includes particular representations of it.  I know
> DTOs are extra work over just shipping your regular objects over the wire
> and GWT RPC makes that easy, but in many cases it is the wrong thing to do.
>  Think about if you were building a proto for the communication -- would
> you send the data in the current form?  If not, you shouldn't be sending it
> that way via RPC just because it is easy to do so.
>
> BTW, I thought Oracle sequence numbers did fit in long (aren't they
> int64?) -- at least all the JDBC code I see for manipulating them stores
> them in a Java long.
>
> --
> John A. Tamplin
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email

[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.

[Colin Alworth]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3361

to look at the new patch set (#2).

Change subject: Ensure clinits get called for JSO instance methods.
..

Ensure clinits get called for JSO instance methods.

In following Java semantics, any static initialization code in a class
(collectively a clinit) should be run before any part of that class is  
used. To

achieve this, GWT ensures that this clinit was invoked before any (actually)
static method, and as part of any constructor. This way, instance methods  
are

sure to have already run the clinit, so it doesn't need to be run again.

However, JSO constructors don't exist, so instance methods are not  
guaranteed to
have had the clinit already run. This is the bug that this patch is trying  
to

fix.

Two locations are changed, both with the effect of ensuring that a clinit is
emitted for JSOs. First, the MethodInliner must not skip adding a call to  
the
clinit when the jso body is inlined and the method invocation (and ref to  
the

class) is dropped, and second, GenerateJavaScriptAST must likewise write out
explicit clinits for any static method or jso instance method.

The jso methods for the unit tests include methods that seem slightly  
convoluted
to avoid being inlined - once inlined, the clinit would re-appear (as it  
shoud,
since the static field is being accessed directly). Each situation being  
tested
requires its own type, since the test app would require being restarted to  
empty
out each static field. Note that prior to this fix, only the "instance  
method"
case failed and returned null - the other situations are added just to  
ensure

that everything else is behaving as expected going forward.

Bug: issue 3192
Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
---
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
M dev/core/src/com/google/gwt/dev/jjs/impl/MethodInliner.java
M user/test/com/google/gwt/dev/jjs/test/JsoTest.java
3 files changed, 70 insertions(+), 4 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3361
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If09885382bcf2d6c149cd8e48bfdd3ae527d67cb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Colin Alworth 
Gerrit-Reviewer: Colin Alworth 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[John A. Tamplin]

On Thu, Jun 13, 2013 at 3:14 AM, David  wrote:

> The lazy parsing would only happen during deserialisation in the client. I
> think it is safe to assume that a BigInteger created through toString on
> the server will not result in a parse exception in the client code - or are
> there known incompatibilities ?
>
> I don't want that the regular constructor of BigInteger( String ) or
> BigInteger( String, int) would behave differently than before. Not even in
> the client when those BigInts are created in the client. That's why I was
> asking about the possibility to have different serialisers on client and
> server side.
>
> As the why, well currently the custom field serializer converts the
> BigInteger to a String, the client side needs to parse the string and
> convert it to an int array, which involves multiple substring,
> Integer.parseInt and multiply and add operations. Somehow IE8 has a problem
> with this. IE9 and other browsers are more efficient, but still that is a
> lot of CPU operations that can be avoided in my use case.
>
> In my particular use case they used BigInteger to represent a key in the
> database (oracle uses sequence numbers that are bigger than what can be
> represented with long). That might have not been the best idea, but those
> decisions have been made a long time ago, when I was not around. On the
> server side there is a usage of equals and compareTo happening, which would
> be hard to implement without a BigInteger, so there is logic in the choice.
> They obviously don't want to have an extra layer of objects to avoid the
> BigInteger in the GWT client since a lot of code is independent of client
> or server, this would hinder code sharing between the tiers.
>
> On the client side these id's are only send forth and back between client
> and server, no operation is ever performed, so making the custom field
> serialiser and the BigInteger cooperate gives a big performance
> improvement. They only operation needed on the client-side is equals, which
> can also be optimized to do a String comparison when bother have not been
> parsed after RPC.
>

I'm beginning to think such a change does not belong in GWT.  In your
example, wouldn't you be better served by only sending strings to the
client rather than BigDecimals, if they client never does anything with
them but send them back?  I think it is going to be pretty rare in normal
situations that you instantiate a BigDecimal but never actually use it in
the client, so it seems the special-case hack for your use-case should be
performed in your code instead.

Too often people want to send things to the client that really don't belong
there, and that includes particular representations of it.  I know DTOs are
extra work over just shipping your regular objects over the wire and GWT
RPC makes that easy, but in many cases it is the wrong thing to do.  Think
about if you were building a proto for the communication -- would you send
the data in the current form?  If not, you shouldn't be sending it that way
via RPC just because it is easy to do so.

BTW, I thought Oracle sequence numbers did fit in long (aren't they int64?)
-- at least all the JDBC code I see for manipulating them stores them in a
Java long.

-- 
John A. Tamplin

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[John A. Tamplin]

On Thu, Jun 13, 2013 at 3:18 AM, David  wrote:

> Forgot to mention this code-snippet I found in the BigInteger class:
>
>   /**
>* The magnitude of this big integer. This array is in little endian
> order and
>* each "digit" is a 32-bit unsigned integer. For example: {@code 13} is
>* represented as [ 13 ] {@code -13} is represented as [ 13 ] {@code2^32 +
>* 13} is represented as [ 13, 1 ] {@code 2^64 + 13} is represented as
> [ 13,
>* 0, 1 ] {@code 2^31} is represented as [ Integer.MIN_VALUE ] The
> magnitude
>* array may be longer than strictly necessary, which results in
> additional
>* trailing zeros.
>*
>* TODO(jat): consider changing to 24-bit integers for better
> performance
>* in browsers.
>*/
>   transient int digits[];
> Always nice to have TODO's in code that are not done :-) Who is "jat" ?
>

So where else should TODO's go?  Clearly this is something that was
intended for future exploration - would you prefer there be nothing there
at all?

-- 
John A. Tamplin

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[John A. Tamplin]

John A. Tamplin has posted comments on this change.

Change subject: adding compare for several number types
..


Patch Set 12: Code-Review+2

The intent wasn't to make it more readable, but to give a slight  
performance optimization on the assumption that most comparisons don't  
involve NaNs.


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 12
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

[Matthew Dempsky]

Matthew Dempsky has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 9:

Gerrit is a bit different than Google practices internally, because  
internally only the CL author can actually submit their changes.  So  
there's no issue of someone else submitting a CL before you're ready.


I agree we need some better conventions on how things should work, I just  
don't know what those should be.  Perhaps better discussed on gwt-contrib  
directly, since it's awkward replying on Gerrit threads. :)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Andrey Korzhevskiy 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects

[Matthew Dempsky]

Matthew Dempsky has posted comments on this change.

Change subject: Failing tests for java.util.Objects
..


Patch Set 1:

(1 comment)

Thanks for submitting and getting the build green (or blue) again! :)


File user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
Line 86
Ahh, okay.


--
To view, visit https://gwt-review.googlesource.com/3400
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2512

to look at the new patch set (#6).

Change subject: Adding a DOM clear method to RootPanel
..

Adding a DOM clear method to RootPanel

By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements located under this RootPanel.

fixes Issue 516

Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Review-Link: https://gwt-review.googlesource.com/#/c/2512/
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 88 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 5:

I would like to see this get landed or abandoned. I think having it would  
have a small value, but if Brian feels strongly I could also drop it.


At the very least we should update javadoc and all removeChildren to  
dom.Element


@Hilbrand

A clear(true) will remove the history frame. But it is only used for IE6  
anyway and we are phasing that out.


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 4:

(1 comment)


File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 311:* {@code getElement().appendChild(...)}.
Done


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2512

to look at the new patch set (#5).

Change subject: Adding a DOM clear method to RootPanel
..

Adding a DOM clear method to RootPanel

By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements located under this RootPanel.

fixes Issue 516

Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Review-Link: https://gwt-review.googlesource.com/#/c/2512/
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 91 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4:

(1 comment)


File user/src/com/google/gwt/user/HTMLTable.gwt.xml
Line 15: 

Done


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#5).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Fix support for Document.{get,set}ScrollLeft() in RTL for sa...

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for  
safari and ie9.

..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
Line 226: if (!"BODY".equals(elem.getTagName()) && isRTL(elem)) {
I've just merged Ib24bee7fa494c0345a7bc97e1b5df1095a05d024 so you can now  
use hasTagName(BodyElement.TAG)



--
To view, visit https://gwt-review.googlesource.com/3420
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce64ab4bbbae02ee7519ed8d24241cdfbc28617
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Emmanuel Pellereau 
Gerrit-Reviewer: Emmanuel Pellereau 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.

[Thomas Broyer]

Thomas Broyer has submitted this change and it was merged.

Change subject: Make Element.hasTagName(...) case-insensitive.
..


Make Element.hasTagName(...) case-insensitive.

Helpful because the various Element TAG constants are in lower-case, but
Element.getTagName() returns upper-case.

Fixes issue 7756.

Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Leeroy Jenkins: Verified
  Thomas Broyer: Looks good to me, approved



diff --git a/user/src/com/google/gwt/dom/client/Element.java  
b/user/src/com/google/gwt/dom/client/Element.java

index f8768e4..c801f5d 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -514,7 +514,7 @@
*/
   public final boolean hasTagName(String tagName) {
 assert tagName != null : "tagName must not be null";
-return tagName.equals(getTagName());
+return tagName.equalsIgnoreCase(getTagName());
   }

   /**
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java  
b/user/test/com/google/gwt/dom/client/ElementTest.java

index 907f736..911d788 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -356,6 +356,18 @@
 assertFalse(div.hasAttribute(null));
   }

+  public void testHasTagName() {
+DivElement div = Document.get().createDivElement();
+
+// hasTagName is case-insensitive
+assertTrue(div.hasTagName("div"));
+assertTrue(div.hasTagName("DIV"));
+assertTrue(div.hasTagName(DivElement.TAG));
+assertTrue(div.hasTagName(div.getTagName()));
+
+assertFalse(div.hasTagName("dove"));
+  }
+
   /**
* Tests HeadingElement.as() (it has slightly more complex assertion  
logic

* than most).

--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Roy Paterson 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Make Element.hasTagName(...) case-insensitive.
..


Patch Set 7:

Hoorays!

--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Roy Paterson 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Fix support for Document.{get,set}ScrollLeft() in RTL for sa...

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for  
safari and ie9.

..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
Line 226: if (!"BODY".equals(elem.getTagName()) && isRTL(elem)) {
Ib24bee7fa494c0345a7bc97e1b5df1095a05d024 is only waiting for Verified+1  
(for some reason, Jenkins doesn't verifies it). You can rebase your change  
on top of it (or I14aa6163e52adb2f71cd1ca3557ff3514571a6a2 for  
BodyElement.is(elem))



--
To view, visit https://gwt-review.googlesource.com/3420
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce64ab4bbbae02ee7519ed8d24241cdfbc28617
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Emmanuel Pellereau 
Gerrit-Reviewer: Emmanuel Pellereau 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Make Element.hasTagName(...) case-insensitive.
..


Patch Set 7: Code-Review+2

@Matthew: any idea why Jenkins doesn't pick it up?

--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Roy Paterson 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

[Leif Åstrand]

Leif Åstrand has posted comments on this change.

Change subject: Use JSON.parse() instead of eval() to deserialize rpc  
callback payload

..


Patch Set 11: Code-Review-1

This patch does not work as it stands for a couple of reasons:

Special numbers (e.g. NaN) values are sent as strings, but they are in the  
string table which means that the receiver just gets an index to the table  
without knowing whether that is the actual value or just a string table  
index.


The sent value is not valid JSON in a couple of situations. This does at  
least include escaping unicode values using \x (JSON only supports \u) and  
sending long values as base64 strings enclosed using ' (JSON only  
supports ")


A readVersion method has been added to the super sourced version of  
ClientSerializationStreamReader but it is missing from the original version.


--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 11
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos 
Gerrit-Reviewer: Artur Signell 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Colin Alworth 
Gerrit-Reviewer: John Ahlroos 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Leif Åstrand 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add drawImage(VideoElement, …) overloads

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add drawImage(VideoElement, …) overloads
..


Patch Set 1: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3421
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31012c21053d0e8219b731ff547ecb9c7364854a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4:

So IE10 leaks as well without the workaround.

Sending out a repro to MS, but I think we have to deal with that. I would  
like to implement this without any major changes in other parts of the SDK,  
but we might want to open a bug just to be sure that we are not leaking  
memory on other occasions as well.


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add drawImage(VideoElement, …) overloads

[Thomas Broyer]

Thomas Broyer has uploaded a new change for review.

  https://gwt-review.googlesource.com/3421


Change subject: Add drawImage(VideoElement, …) overloads
..

Add drawImage(VideoElement, …) overloads

Bug: issue 8192
Change-Id: I31012c21053d0e8219b731ff547ecb9c7364854a
---
M user/src/com/google/gwt/canvas/dom/client/Context2d.java
1 file changed, 44 insertions(+), 0 deletions(-)



diff --git a/user/src/com/google/gwt/canvas/dom/client/Context2d.java  
b/user/src/com/google/gwt/canvas/dom/client/Context2d.java

index 0be7e00..d7128db 100644
--- a/user/src/com/google/gwt/canvas/dom/client/Context2d.java
+++ b/user/src/com/google/gwt/canvas/dom/client/Context2d.java
@@ -19,6 +19,7 @@
 import com.google.gwt.core.client.JavaScriptObject;
 import com.google.gwt.dom.client.CanvasElement;
 import com.google.gwt.dom.client.ImageElement;
+import com.google.gwt.dom.client.VideoElement;

 /**
  * Rendering interface used to draw on a {@link CanvasElement}.
@@ -504,6 +505,49 @@
   }-*/;

   /**
+   * Draws a video's current frame.
+   *
+   * @param image a {@link VideoElement} object
+   * @param dx the x coordinate of the upper-left corner of the  
destination rectangle
+   * @param dy the y coordinate of the upper-left corner of the  
destination rectangle

+   */
+  public final native void drawImage(VideoElement image, double dx, double  
dy) /*-{

+this.drawImage(image, dx, dy);
+  }-*/;
+
+  /**
+   * Draws a scaled video's current frame.
+   *
+   * @param image a {@link VideoElement} object
+   * @param dx the x coordinate of the upper-left corner of the  
destination rectangle
+   * @param dy the y coordinate of the upper-left corner of the  
destination rectangle

+   * @param dw the width of the destination rectangle
+   * @param dh the height of the destination rectangle
+   */
+  public final native void drawImage(VideoElement image, double dx, double  
dy, double dw,

+  double dh) /*-{
+this.drawImage(image, dx, dy, dw, dh);
+  }-*/;
+
+  /**
+   * Draws a scaled subset of a video's current frame.
+   *
+   * @param image a {@link VideoElement} object
+   * @param sx the x coordinate of the upper-left corner of the source  
rectangle
+   * @param sy the y coordinate of the upper-left corner of the source  
rectangle

+   * @param sw the width of the source rectangle
+   * @param sh the width of the source rectangle
+   * @param dx the x coordinate of the upper-left corner of the  
destination rectangle
+   * @param dy the y coordinate of the upper-left corner of the  
destination rectangle

+   * @param dw the width of the destination rectangle
+   * @param dh the height of the destination rectangle
+   */
+  public final native void drawImage(VideoElement image, double sx, double  
sy, double sw, double sh,

+  double dx, double dy, double dw, double dh) /*-{
+this.drawImage(image, sx, sy, sw, sh, dx, dy, dw, dh);
+  }-*/;
+
+  /**
* Fills the current path.
*/
   public final native void fill() /*-{

--
To view, visit https://gwt-review.googlesource.com/3421
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31012c21053d0e8219b731ff547ecb9c7364854a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4:

I am about to test behavior on IE10 and see if it leaks as well. If it does  
not we can simply leave it as is and mark this as an IE quirk.


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4: Code-Review+1

(1 comment)


File user/src/com/google/gwt/user/HTMLTable.gwt.xml
Line 15: 

Should probably read HTMLTable only, or "FlexTable and Grid"


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#4).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 3: Code-Review+1

According to the MDN, using 'children' in all browsers would work. The  
problem is that IE6-8 include comment nodes too, so we cannot actually move  
it to com.google.gwt.dom (even with deferred-binding only for the  
ie6/ie8/ie9 permutations) :-(


https://developer.mozilla.org/en-US/docs/Web/API/Element.children

--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#3).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 2:

(2 comments)


File user/src/com/google/gwt/user/HTMLTable.gwt.xml
Line 2: 

Done


Line 23:   
Done


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Failing tests for java.util.Objects
..


Patch Set 1:

Now let's see if it indeed fixes the build ;-)

--
To view, visit https://gwt-review.googlesource.com/3400
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects

[Thomas Broyer]

Thomas Broyer has submitted this change and it was merged.

Change subject: Failing tests for java.util.Objects
..


Failing tests for java.util.Objects

Fixes issue 8193

Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
---
M user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
2 files changed, 7 insertions(+), 9 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Thomas Broyer: Looks good to me, approved



diff --git a/user/super/com/google/gwt/emul/java/util/Objects.java  
b/user/super/com/google/gwt/emul/java/util/Objects.java

index ca0f5e1..ec5e9a4 100644
--- a/user/super/com/google/gwt/emul/java/util/Objects.java
+++ b/user/super/com/google/gwt/emul/java/util/Objects.java
@@ -29,7 +29,13 @@
   }

   public static boolean deepEquals(Object a, Object b) {
-if (equals(a, b)) {
+if (a == b) {
+  return true;
+}
+if (a == null || b == null) {
+  return false;
+}
+if (a.equals(b)) {
   return true;
 }

diff --git a/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java  
b/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java

index 96cd788..f6416e2 100644
--- a/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
+++ b/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
@@ -82,14 +82,6 @@

 Object obj = new Object();
 assertTrue(Objects.equals(obj, obj));
-
-assertFalse(Objects.equals(new Object() {
-  @Override
-  public boolean equals(Object other) {
-fail("Shouldn't call equals if second argument is null");
-return false;
-  }
-}, null));
   }

   public void testHashCode() {

--
To view, visit https://gwt-review.googlesource.com/3400
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 9:

@Andrey: thanks; but no need to create a new issue here, it's the  
continuity of the original issue (and fixing failing tests / failing builds  
shouldn't need an issue filed generally speaking)


@Matthew & Goktug: OK. We should write it somewhere I think.

Actually, I think we should write out how we want to run code reviews: does  
+2 really means "ready to merge"? who should merge? the person giving the  
+2 or the submitted –if he can, of course–? For instance, Daniel gave a +2  
and merged one of Goktug's change before he could test the implications  
Ia3e4870e85ea5825bfbd1ccef6c635a4b331601c, so it was later reverted  
Id162c4e9b553a5981f09d26a3d1112dbf085825e; stating somewhere that Goktug  
should have given his review a -1 or -2 until he tested the implications of  
the change would have prevented it. Do you have such a doc already inside  
Google that could be used as a first draft?


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Andrey Korzhevskiy 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Failing tests for java.util.Objects
..


Patch Set 1: Code-Review+2

(1 comment)


File user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
Line 86
This is not how Objects.equals is implemented in OpenJDK, contrary to what  
the javadoc says, so the test fails in dev mode.



--
To view, visit https://gwt-review.googlesource.com/3400
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Fix support for Document.{get,set}ScrollLeft() in RTL for sa...

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for  
safari and ie9.

..


Patch Set 2: Code-Review+1

(1 comment)


File user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
Line 226: if (!"BODY".equals(elem.getTagName()) && isRTL(elem)) {
Use

 !elem.hasTagName(BodyElement.TAG)

We should soon have BodyElement.is(elem) to make it even more readable:  
I14aa6163e52adb2f71cd1ca3557ff3514571a6a2



--
To view, visit https://gwt-review.googlesource.com/3420
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce64ab4bbbae02ee7519ed8d24241cdfbc28617
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Emmanuel Pellereau 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

[Thomas Broyer]

Hello Goktug Gokdogan,

I'd like you to reexamine a rebased change.  Please visit

https://gwt-review.googlesource.com/2976

to look at the new rebased patch set (#4).

Change subject: Add static is(...) to complement as as(...).
..

Add static is(...) to complement as as(...).

Adds static is(Element elem) method to complement static
as(Element elem) in each Element sub-class.

Fixes issue 5723.

Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2
---
M user/src/com/google/gwt/dom/client/AnchorElement.java
M user/src/com/google/gwt/dom/client/AreaElement.java
M user/src/com/google/gwt/dom/client/BRElement.java
M user/src/com/google/gwt/dom/client/BaseElement.java
M user/src/com/google/gwt/dom/client/BodyElement.java
M user/src/com/google/gwt/dom/client/ButtonElement.java
M user/src/com/google/gwt/dom/client/DListElement.java
M user/src/com/google/gwt/dom/client/DivElement.java
M user/src/com/google/gwt/dom/client/FieldSetElement.java
M user/src/com/google/gwt/dom/client/FormElement.java
M user/src/com/google/gwt/dom/client/FrameElement.java
M user/src/com/google/gwt/dom/client/FrameSetElement.java
M user/src/com/google/gwt/dom/client/HRElement.java
M user/src/com/google/gwt/dom/client/HeadElement.java
M user/src/com/google/gwt/dom/client/HeadingElement.java
M user/src/com/google/gwt/dom/client/IFrameElement.java
M user/src/com/google/gwt/dom/client/ImageElement.java
M user/src/com/google/gwt/dom/client/InputElement.java
M user/src/com/google/gwt/dom/client/LIElement.java
M user/src/com/google/gwt/dom/client/LabelElement.java
M user/src/com/google/gwt/dom/client/LegendElement.java
M user/src/com/google/gwt/dom/client/LinkElement.java
M user/src/com/google/gwt/dom/client/MapElement.java
M user/src/com/google/gwt/dom/client/MetaElement.java
M user/src/com/google/gwt/dom/client/ModElement.java
M user/src/com/google/gwt/dom/client/OListElement.java
M user/src/com/google/gwt/dom/client/ObjectElement.java
M user/src/com/google/gwt/dom/client/OptGroupElement.java
M user/src/com/google/gwt/dom/client/OptionElement.java
M user/src/com/google/gwt/dom/client/ParagraphElement.java
M user/src/com/google/gwt/dom/client/ParamElement.java
M user/src/com/google/gwt/dom/client/PreElement.java
M user/src/com/google/gwt/dom/client/QuoteElement.java
M user/src/com/google/gwt/dom/client/ScriptElement.java
M user/src/com/google/gwt/dom/client/SelectElement.java
M user/src/com/google/gwt/dom/client/SourceElement.java
M user/src/com/google/gwt/dom/client/SpanElement.java
M user/src/com/google/gwt/dom/client/StyleElement.java
M user/src/com/google/gwt/dom/client/TableCaptionElement.java
M user/src/com/google/gwt/dom/client/TableCellElement.java
M user/src/com/google/gwt/dom/client/TableColElement.java
M user/src/com/google/gwt/dom/client/TableElement.java
M user/src/com/google/gwt/dom/client/TableRowElement.java
M user/src/com/google/gwt/dom/client/TableSectionElement.java
M user/src/com/google/gwt/dom/client/TextAreaElement.java
M user/src/com/google/gwt/dom/client/TitleElement.java
M user/src/com/google/gwt/dom/client/UListElement.java
M user/test/com/google/gwt/dom/client/ElementTest.java
48 files changed, 1,721 insertions(+), 59 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2976
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I14aa6163e52adb2f71cd1ca3557ff3514571a6a2
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Roy Paterson 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

[Daniel Kurka]

Hello Leeroy Jenkins, Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3340

to look at the new patch set (#3).

Change subject: Add show relative to Element in PopupPanel
..

Add show relative to Element in PopupPanel

fixes issue 6006

Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/user/client/ui/PopupPanel.java
2 files changed, 20 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3340
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add show relative to Element in PopupPanel
..


Patch Set 2:

(2 comments)


File tools/api-checker/config/gwt25_26userApi.conf
Line 176: #adding method to PopupPanel to show relative to an Element
Done


Line 177:  
com.google.gwt.user.client.ui.PopupPanel::showRelativeTo(Lcom/google/gwt/dom/client/Element;)  
OVERLOADED_METHOD_CALL

Done


--
To view, visit https://gwt-review.googlesource.com/3340
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types
..


Patch Set 12:

Updated Patch to deal with normal numbers first, but I don't think this  
ends up being more readable. But I am fine either way.


Float.compare also uses Double.compare to avoid redundancy.

--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 12
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#12).

Change subject: adding compare for several number types
..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 84 insertions(+), 50 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 12
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[Thomas Broyer]

On Thursday, June 13, 2013 9:18:23 AM UTC+2, stuckagain wrote:
>
> Forgot to mention this code-snippet I found in the BigInteger class:
>  
>   /**
>* The magnitude of this big integer. This array is in little endian 
> order and
>* each "digit" is a 32-bit unsigned integer. For example: 
> {...@code13} is
>* represented as [ 13 ] {...@code  -13} is represented as 
> [ 13 ] {...@code  2^32 +
>* 13} is represented as [ 13, 1 ] {...@code  2^64 + 13} 
> is represented as [ 13,
>* 0, 1 ] {...@code  2^31} is represented as [ 
> Integer.MIN_VALUE ] The magnitude
>* array may be longer than strictly necessary, which results in 
> additional
>* trailing zeros.
>* 
>* TODO(jat): consider changing to 24-bit integers for better 
> performance
>* in browsers.
>*/
>   transient int digits[];
> Always nice to have TODO's in code that are not done :-) Who is "jat" ?
>

jat == John A. Tamplin

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Timer#isRunning().
..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/client/Timer.java
Line 151:
lets add a note in the javadoc of is running making this clear.


--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[David]

Forgot to mention this code-snippet I found in the BigInteger class:

  /**
   * The magnitude of this big integer. This array is in little endian
order and
   * each "digit" is a 32-bit unsigned integer. For example: {@code 13} is
   * represented as [ 13 ] {@code -13} is represented as [ 13 ] {@code 2^32
+
   * 13} is represented as [ 13, 1 ] {@code 2^64 + 13} is represented as [
13,
   * 0, 1 ] {@code 2^31} is represented as [ Integer.MIN_VALUE ] The
magnitude
   * array may be longer than strictly necessary, which results in
additional
   * trailing zeros.
   *
   * TODO(jat): consider changing to 24-bit integers for better
performance
   * in browsers.
   */
  transient int digits[];
Always nice to have TODO's in code that are not done :-) Who is "jat" ?


David

On Thu, Jun 13, 2013 at 9:14 AM, David  wrote:

> Hi,
>
> The lazy parsing would only happen during deserialisation in the client. I
> think it is safe to assume that a BigInteger created through toString on
> the server will not result in a parse exception in the client code - or are
> there known incompatibilities ?
>
> I don't want that the regular constructor of BigInteger( String ) or
> BigInteger( String, int) would behave differently than before. Not even in
> the client when those BigInts are created in the client. That's why I was
> asking about the possibility to have different serialisers on client and
> server side.
>
> As the why, well currently the custom field serializer converts the
> BigInteger to a String, the client side needs to parse the string and
> convert it to an int array, which involves multiple substring,
> Integer.parseInt and multiply and add operations. Somehow IE8 has a problem
> with this. IE9 and other browsers are more efficient, but still that is a
> lot of CPU operations that can be avoided in my use case.
>
> In my particular use case they used BigInteger to represent a key in the
> database (oracle uses sequence numbers that are bigger than what can be
> represented with long). That might have not been the best idea, but those
> decisions have been made a long time ago, when I was not around. On the
> server side there is a usage of equals and compareTo happening, which would
> be hard to implement without a BigInteger, so there is logic in the choice.
> They obviously don't want to have an extra layer of objects to avoid the
> BigInteger in the GWT client since a lot of code is independent of client
> or server, this would hinder code sharing between the tiers.
>
> On the client side these id's are only send forth and back between client
> and server, no operation is ever performed, so making the custom field
> serialiser and the BigInteger cooperate gives a big performance
> improvement. They only operation needed on the client-side is equals, which
> can also be optimized to do a String comparison when bother have not been
> parsed after RPC.
>
> David
>
> On Thu, Jun 13, 2013 at 2:30 AM, John A. Tamplin  wrote:
>
>> Have we evaluated why it is so slow on ie8?  It might be easier to fix
>> that.  The one thing it does is heavy use of StringBuffers so that could be
>> where the issue is.
>> On Jun 12, 2013 8:09 PM, "Brian Slesinsky"  wrote:
>>
>>> Lazy parsing can be a performance win, but it also complicates the API
>>> in the case of a parse error. Have you thought about how to report errors
>>> when they happen later?
>>>
>>> It might less confusing to solve this using a separate LazyBigDecimal
>>> class. People can declare fields of this type in their data transfer
>>> objects when they're concerned about performance.
>>>
>>>
>>> On Tue, Jun 11, 2013 at 1:56 AM, stuckagain wrote:
>>>
 Hi,

 I am working on a fix for this issue:
 https://code.google.com/p/google-web-toolkit/issues/detail?id=8083

 I am avoiding converting from string to the internal format of
 BigInteger because it has a big performance impact on IE8 when sending it
 over RPC. It performs much better in IE9 and other browsers, but still I
 want to optimize this since this is having a major impact in an application
 I am working on (And I saw some other people in the banking industry having
 similar issues with BigDecimal).

 In many cases this data is never modified in the client, so I am
 delaying the actual parsing of the String to the internal format of
 BigInteger.

 Is it feasible to have custom field serializers depending on running in
 the client or server ?

 The question I am asking is because I don't want to break the
 BigInteger(String) constructor that will throw exceptions when you feed it
 a non parseable string. so my solution would be to use a static method or
 custom constructor for BigInteger when deserializing on the client. But
 this method is not available in the real java.math.BigInteger class.

 So is it possible to have different client and server
 serializers/deserializer code for RPC ?

 David

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

[David]

Hi,

The lazy parsing would only happen during deserialisation in the client. I
think it is safe to assume that a BigInteger created through toString on
the server will not result in a parse exception in the client code - or are
there known incompatibilities ?

I don't want that the regular constructor of BigInteger( String ) or
BigInteger( String, int) would behave differently than before. Not even in
the client when those BigInts are created in the client. That's why I was
asking about the possibility to have different serialisers on client and
server side.

As the why, well currently the custom field serializer converts the
BigInteger to a String, the client side needs to parse the string and
convert it to an int array, which involves multiple substring,
Integer.parseInt and multiply and add operations. Somehow IE8 has a problem
with this. IE9 and other browsers are more efficient, but still that is a
lot of CPU operations that can be avoided in my use case.

In my particular use case they used BigInteger to represent a key in the
database (oracle uses sequence numbers that are bigger than what can be
represented with long). That might have not been the best idea, but those
decisions have been made a long time ago, when I was not around. On the
server side there is a usage of equals and compareTo happening, which would
be hard to implement without a BigInteger, so there is logic in the choice.
They obviously don't want to have an extra layer of objects to avoid the
BigInteger in the GWT client since a lot of code is independent of client
or server, this would hinder code sharing between the tiers.

On the client side these id's are only send forth and back between client
and server, no operation is ever performed, so making the custom field
serialiser and the BigInteger cooperate gives a big performance
improvement. They only operation needed on the client-side is equals, which
can also be optimized to do a String comparison when bother have not been
parsed after RPC.

David

On Thu, Jun 13, 2013 at 2:30 AM, John A. Tamplin  wrote:

> Have we evaluated why it is so slow on ie8?  It might be easier to fix
> that.  The one thing it does is heavy use of StringBuffers so that could be
> where the issue is.
> On Jun 12, 2013 8:09 PM, "Brian Slesinsky"  wrote:
>
>> Lazy parsing can be a performance win, but it also complicates the API in
>> the case of a parse error. Have you thought about how to report errors when
>> they happen later?
>>
>> It might less confusing to solve this using a separate LazyBigDecimal
>> class. People can declare fields of this type in their data transfer
>> objects when they're concerned about performance.
>>
>>
>> On Tue, Jun 11, 2013 at 1:56 AM, stuckagain wrote:
>>
>>> Hi,
>>>
>>> I am working on a fix for this issue:
>>> https://code.google.com/p/google-web-toolkit/issues/detail?id=8083
>>>
>>> I am avoiding converting from string to the internal format of
>>> BigInteger because it has a big performance impact on IE8 when sending it
>>> over RPC. It performs much better in IE9 and other browsers, but still I
>>> want to optimize this since this is having a major impact in an application
>>> I am working on (And I saw some other people in the banking industry having
>>> similar issues with BigDecimal).
>>>
>>> In many cases this data is never modified in the client, so I am
>>> delaying the actual parsing of the String to the internal format of
>>> BigInteger.
>>>
>>> Is it feasible to have custom field serializers depending on running in
>>> the client or server ?
>>>
>>> The question I am asking is because I don't want to break the
>>> BigInteger(String) constructor that will throw exceptions when you feed it
>>> a non parseable string. so my solution would be to use a static method or
>>> custom constructor for BigInteger when deserializing on the client. But
>>> this method is not available in the real java.math.BigInteger class.
>>>
>>> So is it possible to have different client and server
>>> serializers/deserializer code for RPC ?
>>>
>>> David
>>>
>>> --
>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "GWT Contributors" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com
>>> .
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>>
>>>
>>
>>  --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "GWT Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received t