Re: [PHP-DEV] Type hinting/casting request for vote
On 09.07.2009, at 02:28, troels knak-nielsen wrote: On Thu, Jul 9, 2009 at 2:15 AM, Markmark...@gmail.com wrote: I personally would be highly in favor of adding type hinting/casting BUT with the benifit that php actually becomes faster if you do things like that. Afterall you can use way more effective c code if you know what you expect right? As for the version to include type I sure hope that all the people in favour of this change aren't basing their opinion on some delusion that it would improve performance in any way. well .. this will have an effect on performance. for one the additional checks will probably add a small overhead for all users. the reduction in user land type check code should of course improve performance. that being said, none of the above will have a significant relevant affect on performance in real world applications (which usually spend most of their time talking to data stores and not type checking). regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Wed, Jul 08, 2009 at 08:31:49PM +0200, Jordi Boggiano wrote: Since the votes seem to switch to 6.0 instead of 5.3, would it be feasible to throw an E_DEPRECATED in 5.3.1 if one declares a function/class called int/bool/object/whatever ? +1 We *must* think about the transition. Just throwing the idea in the wild since I am not able to assess if that's doable, but it might be a good idea to add it as soon as possible if it is, especially if we want to skip a 5.4 -- Alain Williams Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT Lecturer. +44 (0) 787 668 0256 http://www.phcomp.co.uk/ Parliament Hill Computers Ltd. Registration Information: http://www.phcomp.co.uk/contact.php Past chairman of UKUUG: http://www.ukuug.org/ #include std_disclaimer.h -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
-1 for 5.3 0 for 5.x (if there ever will be one) +1 for 6.0 On 7.7.2009 2:52 Uhr, Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- Liip AG // Feldstrasse 133 // CH-8004 Zurich Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 www.liip.ch // blog.liip.ch // GnuPG 0x5CE1DECB -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
2009/7/8 Ilia Alshanetsky i...@prohost.org:
All of the identified issues can be resolved and none of them represent a
major challenge to address. However, if there is no consensus to put this in
OK, but you had not said you would resolve them. I would appreciate
some detail on what you will do to address them.
the near future (which at this point is 5.3), I have hard time justifying
spending further time on this. The original patch that was posted, that did
break BC was far simpler and featureless, the changes since (which took a
fair amount of work) were specifically made to address some of the main
concerns that were on the list. I feel what is on the table right now is
pretty close to what a final product could be, to have a vote on it. If
Personally, I had gotten the impression that this was the final
product, and that we could take it or leave it.
decision is made to proceed within a practical release schedule, then
suffice to say that I'd be more then happy to put further time to address
the minor issues indicated.
I recommend:
- stop the vote
- address the issues (possibly deferring them until after voting, or whatever)
- write an RFC
- wait for Lukas to finish what he's doing
- new vote, more options (5.3.x/5.4/6.0, Lukas'/yours, make it clear
what we're voting for)
Thanks,
Paul
On 7-Jul-09, at 7:07 PM, Paul Biggar wrote:
2009/7/7 Johannes Schlüter johan...@php.net:
On Mon, 2009-07-06 at 20:52 -0400, Ilia Alshanetsky wrote:
Last week or so there was a fairly detailed discussion on the
internals list regarding type hinting based on my original patch.
Having an old 5.3 extension with a typehint expecting an array
arg_info.array_type_hint will be set to 1.
The newly compiled engine with this patch will then do
+ /* existing type already matches the hint or forced type
*/
+ if (Z_TYPE_P(arg) == cur_arg_info-array_type_hint ||
Z_TYPE_P(arg) == (cur_arg_info-array_type_hint ^ (17))) {
as it's main type check, but Z_TYPE_P(arg) will be IS_ARRAY (5) which
doesn't match the 1 provided by the old extension, other checks in there
will fail too, so the valid param will be rejected whereas an integer
(IS_LONG 1) will be accepted where the extension expects an array.
I raised this in my review, to which Ilia replied It should be fine
(http://news.php.net/php.internals/44707). I would not have thought it
would be fine.
I had been thinking that Ilia would have to hack it to make 1 mean
array in this case, which would be ugly, but workable. Based on the
arguments in this thread, I believe it shouldn't go into 5.3 at all.
Are we allowed break the ABI for 5.4 (I would think so, but amn't
sure).
Overall, I'm very disappointed with the way this has been conducted.
When reviews were posted they are not replied to (Stas posted
http://news.php.net/php.internals/44710, I posted
http://news.php.net/php.internals/44706, and I dont see any replies
except a cursory response to mine). Furthermore:
- the RFC process has been wilfully ignored (despite multiple requests)
- a vote was asked for when Lukas was still trying to discuss his
proposal
- the vote was take it or leave it
- there has been a general attitude of throwing the toys out of the
pram
I am mostly for the patch, and I 100% support the idea. However, I
feel I have to vote against it, and urge others to do the same, until
the entire mess is rectified.
Ilia, I respect the work you have put into this, but I would ask you
to withdraw the patch and the vote until these things have been sorted
out.
-1
Thanks,
Paul
--
Paul Biggar
paul.big...@gmail.com
--
Paul Biggar
paul.big...@gmail.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, 7 Jul 2009, Graham Kelly wrote: However, this is ONLY because I do not feel PHP 5.3 is the place to put this. However, I do have to agree with Ilia here that PHP 6 is too far away and it would be nice to have this feature long before then. I would however, be very for adding something similar to this patch in a PHP 5.4 release. I don't see why a PHP 5.4 release can't be done relativly quickly (Like 6-12 months) by just making it more of a minor internal update but something that could have large impacts on user code (syntax changes for type hints). With this logic, we got a PHP 5.3 as well, and with the same logic there will be a PHP 5.4, 5.5, 5.6 and we never get to 6. Instead of putting stuff in PHP 5.4 (which at the moment is *not* planned), why not focus all effort on 6 to make sure it comes out faster? And although this feature is useful, it's not something that I would *really-need-right-now*. regards, Derick -- http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org twitter: @derickr -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 08.07.2009, at 10:25, Paul Biggar wrote: - wait for Lukas to finish what he's doing - new vote, more options (5.3.x/5.4/6.0, Lukas'/yours, make it clear what we're voting for) Do not wait for me. I have decided it doesn't make sense for me to write this RFC. There was essentially nobody that even agreed with the basic principle and I do not think I have what it takes to convince people otherwise. I would very much appreciate it if someone who has just been lurking for now, to pick up my RFC and improve it so that people do understand what I was trying to say. regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, 7 Jul 2009, Derick Rethans wrote: On Mon, 6 Jul 2009, Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 Obviously, that was not for putting it in PHP 5.3, but in HEAD only. regards, Derick -- http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org twitter: @derickr -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Derick Rethans wrote: On Tue, 7 Jul 2009, Graham Kelly wrote: However, this is ONLY because I do not feel PHP 5.3 is the place to put this. However, I do have to agree with Ilia here that PHP 6 is too far away and it would be nice to have this feature long before then. I would however, be very for adding something similar to this patch in a PHP 5.4 release. I don't see why a PHP 5.4 release can't be done relativly quickly (Like 6-12 months) by just making it more of a minor internal update but something that could have large impacts on user code (syntax changes for type hints). With this logic, we got a PHP 5.3 as well, and with the same logic there will be a PHP 5.4, 5.5, 5.6 and we never get to 6. Instead of putting stuff in PHP 5.4 (which at the moment is *not* planned), why not focus all effort on 6 to make sure it comes out faster? And although this feature is useful, it's not something that I would *really-need-right-now*. Yes please to PHP6! Although I suspect there is still a debate on retaining PHP5.x as being 'ascii native' and PHP6 being 'unicode native' so new features end up having to be 'back ported'? -- Lester Caine - G8HFL - Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk// Firebird - http://www.firebirdsql.org/index.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
At 21:38 07/07/2009, Rasmus Lerdorf wrote: -1 on 5.3. The window for adding new major features to 5.3 is obviously long gone. Not sure why you are even suggesting it. +0 on parts of it for the next major release. You still haven't convinced me that strict type checking won't cause more problems than it will solve, but I do see the benefits. Agreed 100%: -1 on 5.3. Such a major change simply does not belong in 5.3 as a last-minute addition. +0 for revisiting for the next major release. Will change to +1 if we focus on conversion only - with slightly stricter semantics than the ones for internal functions, but with very much the same theme - as per my email. Zeev -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Derick Rethans wrote: On Tue, 7 Jul 2009, Graham Kelly wrote: However, this is ONLY because I do not feel PHP 5.3 is the place to put this. However, I do have to agree with Ilia here that PHP 6 is too far away and it would be nice to have this feature long before then. I would however, be very for adding something similar to this patch in a PHP 5.4 release. I don't see why a PHP 5.4 release can't be done relativly quickly (Like 6-12 months) by just making it more of a minor internal update but something that could have large impacts on user code (syntax changes for type hints). With this logic, we got a PHP 5.3 as well, and with the same logic there will be a PHP 5.4, 5.5, 5.6 and we never get to 6. Instead of putting stuff in PHP 5.4 (which at the moment is *not* planned), why not focus all effort on 6 to make sure it comes out faster? And although this feature is useful, it's not something that I would *really-need-right-now*. regards, Derick Agree 100% +1 for parameter type enforcement in PHP 6 Steven -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky wrote: On 7-Jul-09, at 8:43 PM, Rasmus Lerdorf wrote: That doesn't really change the timing, especially since you said you have been using it for 2 years. Why pick the week after the 5.3 release to propose it for 5.3? It makes very little sense to me, and I think consensus is building that we aren't going to add this to 5.3. I wish I had time to post the patch sooner, but timing was such that it was not an option. Plus people have tried to post the same functionality before there was patch from Hannes back in 2006, a full RFC by Fellipe in 2008 (with patch) and now my attempt in 2009. After some discussions at the developer meeting in Chicago and seeing that there was a substantial interest in the feature I've cleaned up the code and posted the patch. I think half the people who voted +1 didn't realize you were seriously thinking of pushing it into 5.3 Well, its only Tuesday there is plenty of time for people to change their mind (like some already have). Agreeably its a major decisions and I think everyone would agree it should not hinge on 1-2 votes either way, there has to be a substantial let it in consensus for it to go in. Like I said earlier on IRC, I'm +1 for this in 5.4 if that ever happens. Otherwise it's gotta be PHP 6. Or just spork. :) --Jani -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Jani Taskinen wrote: Ilia Alshanetsky wrote: On 7-Jul-09, at 8:43 PM, Rasmus Lerdorf wrote: That doesn't really change the timing, especially since you said you have been using it for 2 years. Why pick the week after the 5.3 release to propose it for 5.3? It makes very little sense to me, and I think consensus is building that we aren't going to add this to 5.3. I wish I had time to post the patch sooner, but timing was such that it was not an option. Plus people have tried to post the same functionality before there was patch from Hannes back in 2006, a full RFC by Fellipe in 2008 (with patch) and now my attempt in 2009. After some discussions at the developer meeting in Chicago and seeing that there was a substantial interest in the feature I've cleaned up the code and posted the patch. I think half the people who voted +1 didn't realize you were seriously thinking of pushing it into 5.3 Well, its only Tuesday there is plenty of time for people to change their mind (like some already have). Agreeably its a major decisions and I think everyone would agree it should not hinge on 1-2 votes either way, there has to be a substantial let it in consensus for it to go in. Like I said earlier on IRC, I'm +1 for this in 5.4 if that ever happens. Otherwise it's gotta be PHP 6. Or just spork. :) --Jani One more thing: It seems there is no reason not to simply commit it to HEAD. That's the development branch, if the thing isn't good, it can be removed / modified / etc. This voting is really whether it should be merged or not.. --Jani -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
1) The patch introduce several new reserved words (resource, numeric, scalar, object). This may break existing applications which use these names as function or class names. 2) The patch should define something like ZEND_ARG_TYPE_INFO() 3) do we really need IS_CLASS constant? 4) arg_info-array_type_hint should be probably changed into arg_info-type_hint. May be it's better to use bitset mask for it. Then we won't need IS_SCALAR and IS_NUMERIC as well and arg_info-allow_null field. Otherwise the patch looks good, but note that for now it only slowdowns execution a bit because of addition checks. I hope, it'll be possible to use these hints in the future to generate more optimal code. +1 for php6 after improvements Thanks. Dmitry. Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
2) The patch should define something like ZEND_ARG_TYPE_INFO()
Yeah, that can be used or existing macros can be retained using type
parameter, which can even made BC compliant by using new sets of
constants that match the IS_ARRAY or not hint semantics.
3) do we really need IS_CLASS constant?
Only because there is a class hint (currently supported) function foo
(StdClass $foo) {} and there was a request to support a generic object
hint. So one became IS_CLASS and one is IS_OBJECT.
4) arg_info-array_type_hint should be probably changed into
arg_info-type_hint. May be it's better to use bitset mask for it.
Then we won't need IS_SCALAR and IS_NUMERIC as well and arg_info-
allow_null field.
Originally that is how I had it, but to avoid BC break I've renamed
the property back to type_hint.
Otherwise the patch looks good, but note that for now it only
slowdowns execution a bit because of addition checks. I hope, it'll
be possible to use these hints in the future to generate more
optimal code.
+1 for php6 after improvements
Thanks. Dmitry.
Ilia Alshanetsky wrote:
Last week or so there was a fairly detailed discussion on the
internals list regarding type hinting based on my original patch.
Since then the patch has been revised to address the major concerns
that were identified (breakage of binary compatibility) as well
extended with additional functionality (object hint, type casting,
reflection support, etc...).
The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt
The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2
I would like to ask all developers to voice their opinions of
whether it makes sense to add this to 5.3 or to throw it away
(either one is fine btw). To keep the process simple flamewar
free, please restrict yourself to +/- (1/0), next week monday I'll
run a tally of the votes and based on the result we can determine
how to proceed further.
Ilia
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Hi. On 08.07.2009 12:11 Uhr, Steven Van Poeck wrote: Derick Rethans wrote: With this logic, we got a PHP 5.3 as well, and with the same logic there will be a PHP 5.4, 5.5, 5.6 and we never get to 6. Instead of putting stuff in PHP 5.4 (which at the moment is *not* planned), why not focus all effort on 6 to make sure it comes out faster? And although this feature is useful, it's not something that I would *really-need-right-now*. regards, Derick Agree 100% +1 for parameter type enforcement in PHP 6 +1 to that. Regards, Karsten -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] OT Godwin's law, was Re: [PHP-DEV] Type hinting/casting request for vote
Aside: I'd like to propose an internals-specific mutation of Godwin's law, which might state: As a PHP internals discussion thread grows longer, the probability of a comparison involving Perl 6 approaches 1. JG On 07/07/09 6:14 PM, Wez Furlong wrote: -1 for 5.x +1 for 6.0 Otherwise the Perl 6 guys will starting making their own jokes about being released before PHP 6. --Wez. On Mon, Jul 6, 2009 at 8:52 PM, Ilia Alshanetskyi...@prohost.org wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. -- blog: http://www.openkomodo.com/blogs/jeffg web:http://www.ActiveState.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Mon, July 6, 2009 7:52 pm, Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 (subject to release master veto) And I doubt that my vote counts anyway... This seems simple enough to grok, and seems to make the type-hinter crowd happy, except for the name hint -- Some people ask for gifts here. I just want you to buy an Indie CD for yourself: http://cdbaby.com/search/from/lynch -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Hi!
Only because there is a class hint (currently supported) function foo
(StdClass $foo) {} and there was a request to support a generic object
hint. So one became IS_CLASS and one is IS_OBJECT.
I'd say IS_OBJECT can fit both - we could treat empty class name as any
object.
--
Stanislav Malyshev, Zend Software Architect
s...@zend.com http://www.zend.com/
(408)253-8829 MSN: s...@zend.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Hi! One more thing: It seems there is no reason not to simply commit it to HEAD. That's the development branch, if the thing isn't good, it can be Erm, I was under impression that development branch is for developing new functionalities which were agreed on, not for committing any code that anybody wanted to without any consensus or agreement on what should happen with it. So yes, there's a reason not to simply commit this or any other major language-level functionality without prior discussion. The fact that you can remove it doesn't mean you should commit first and discuss later. -- Stanislav Malyshev, Zend Software Architect s...@zend.com http://www.zend.com/ (408)253-8829 MSN: s...@zend.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Wed, Jul 8, 2009 at 8:01 PM, Stanislav Malyshevs...@zend.com wrote: Hi! One more thing: It seems there is no reason not to simply commit it to HEAD. That's the development branch, if the thing isn't good, it can be Erm, I was under impression that development branch is for developing new functionalities which were agreed on, not for committing any code that anybody wanted to without any consensus or agreement on what should happen with it. So yes, there's a reason not to simply commit this or any other major language-level functionality without prior discussion. The fact that you can remove it doesn't mean you should commit first and discuss later. As I agree with that statement, we have to accept that we have a consensus about this addition. For what I can read the implementation is almost complete, there are issues but they can be fixed afterward as well as all the other side effects we are going to have, no? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Since the votes seem to switch to 6.0 instead of 5.3, would it be feasible to throw an E_DEPRECATED in 5.3.1 if one declares a function/class called int/bool/object/whatever ? Just throwing the idea in the wild since I am not able to assess if that's doable, but it might be a good idea to add it as soon as possible if it is, especially if we want to skip a 5.4 Cheers, Jordi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 7 Jul 2009, at 02:52, Ilia Alshanetsky wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. -1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, Jul 7, 2009 at 3:52 AM, Ilia Alshanetsky i...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php +1
Re: [PHP-DEV] Type hinting/casting request for vote
On Wed, Jul 8, 2009 at 10:13 PM, George Antoniadisgeo...@noodles.gr wrote: On Tue, Jul 7, 2009 at 3:52 AM, Ilia Alshanetsky i...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php +1 Hi List, I've been watching this thread silently and reply now just to let you all know how i, as a php developer (as in writing php scripts), would like to see this feature to get in php. I personally would be highly in favor of adding type hinting/casting BUT with the benifit that php actually becomes faster if you do things like that. Afterall you can use way more effective c code if you know what you expect right? As for the version to include type hinting/casting. I would say as soon as possible but i also see a big issue comming up if it's added in, lets say, 5.3.1 or 5.3.2... it makes no sence that a major php version that got released just over a week ago (5.3) doesn't have a big feature like this and a minor version would include it.. That's somewhat odd. I would say: make a php version between 5.3 and 6.0 that introduces syntax changes and make that version (in terms of syntax) backwards (5.3) and forward (6.0) compatible. If a 'swap' version is going to be introduced then do it this year! don't wait to long with it because it will take at least one more year before it's on the majority of web servers. A sad side effect is that php 5.3 won't have a long life since (for the sake of version numbers) php 5.4 could be here this year! The way it currently stands is that this feature (just by looking at the vast +1's) is going to be in php 6.0 but who knows when that's going to be released! I bet it's not this year and i doubt it will be anywhere in 2010 so that delays the adaption of this feature by that time + the time it takes hosts to get php 6.0 (which is between 1 and 2 years) ending up in a total of 3 - 4 years if not included now or in a 'swap' version. Just my opinion. Thanx, Mark. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Thu, Jul 9, 2009 at 2:15 AM, Markmark...@gmail.com wrote: I personally would be highly in favor of adding type hinting/casting BUT with the benifit that php actually becomes faster if you do things like that. Afterall you can use way more effective c code if you know what you expect right? As for the version to include type I sure hope that all the people in favour of this change aren't basing their opinion on some delusion that it would improve performance in any way. -- troels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Monday, July 6, 2009, Ilia Alshanetsky i...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). +1 Regards, Matthew The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky schrieb: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. I have tested the patch (ran the supplied test suite, reviewed the test suite) and ran into no issues. +1 -- Sebastian BergmannCo-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Mon, 6 Jul 2009, Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 Derick -- http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org twitter: @derickr -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, Jul 7, 2009 at 02:52, Ilia Alshanetskyi...@prohost.org wrote: The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 +1 -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 Patrick Allaert --- http://code.google.com/p/peclapm/ - Alternative PHP Monitor -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 -- Slan, David -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 06/07/09 20:52, Ilia Alshanetsky wrote: The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
2009/7/7 Ilia Alshanetsky i...@prohost.org: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php +1 -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731 Standing on the shoulders of some very clever giants! I need a car : http://snipurl.com/l4pih ZOPA : http://uk.zopa.com/member/RQuadling -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 from me On Tue, Jul 7, 2009 at 1:52 AM, Ilia Alshanetsky i...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky wrote: [..] I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). +1 [..] - Mark -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
2009/7/7 Ilia Alshanetsky i...@prohost.org: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). +1 -- regrads, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
-1 for 5.x +1 for 6.0 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. I'm struggling here but must emit -1 because PHP does not add features within point (5.3.x) releases, especially those affecting syntax like this. But if this philosophy changes, then also add traits. :) Regards, Philip -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). I don't want to start a long discussion, but IMO this and other major language changes doen't belong in a point release of 5.3.x (whether it's 5.3.2 or 5.3.192). so: -1 in 5.3 -1 throw away +1 in HEAD (or 5.4; sorry for opening $canOfWorms) S -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 On Jul 6, 2009, at 7:52 PM, Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Sebastian Bergmann schrieb: +1 Just to be clear, my vote was for putting this into (PHP_5_3) + 1, not into PHP 5.3.1. -- Sebastian BergmannCo-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
that vote is for anything coming after 5.3.x (be 5.4 or 6.x), did not see the 5.3 only requirement (which makes no sense). I'm generally -1 on any major change for 5.3.x. On Tue, Jul 7, 2009 at 11:42 AM, Pierre Joyepierre@gmail.com wrote: +1 -- Pierre http://blog.thepimp.net | http://www.libgd.org -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1. -a -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Andrei Zmievski wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1. Sorry, I should have read better. My +1 was for the feature in general, not for 5.3. I think we should concentrate most of the new feature development on 6.0, now that 5.3 is out to avoid having yet another feature-filled 5.x release. So, once again, completely against this going into 5.3. -Andrei -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 07/07/09 10:17 AM, Andrei Zmievski wrote: Andrei Zmievski wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1. Sorry, I should have read better. My +1 was for the feature in general, not for 5.3. I think we should concentrate most of the new feature development on 6.0, now that 5.3 is out to avoid having yet another feature-filled 5.x release. So, once again, completely against this going into 5.3. +1 for what Andrei said ( to further muddy the waters ). Ilia, why 5.3 or die? This feature should be in HEAD IMO. Aside: I'm personally really excited at the possibilities of improving completion in Komodo for code that uses this feature. Jeff -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Hi,
I am -1 on the inclusion of cast support. IMHO this part isnt thought
out and was just thrown in to silence those who feel that there is a
use case for non strict type hinting. But in that case I might as well
leave the type cast in the API calling code. The number of characters
saved are next to nothing, the performance impact is probably also
fairly irrelevant and with this syntax I get slapped and then I can
choose if I want to cast manually or do something else. But just
hiding things by just blindly casting seems counter productive (which
is why I proposed to add reasonable checks before doing the cast in my
RFC that would make things more compatible with data coming out of a
database, config file or other trusted data source). I just do not see
what is gained at all from:
A) foo((int)$bar);
function bar(int $bar) {}
vs.
B) foo($bar);
function bar((int) $bar) {}
What am I really saying with B)?
I don't care what you give me, I am going to use it as an int anyways?
IMHO no need to introduce a special syntax for this.
Of course I am also quite opposed to sticking this into 5.3.
Finally I would like to ask to rename this entire feature (including
what we currently already have) to type checking or something other
than hint in the documentation.
regards,
Lukas Kahwe Smith
m...@pooteeweet.org
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, Jul 7, 2009 at 6:41 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote:
B) foo($bar);
function bar((int) $bar) {}
What am I really saying with B)?
I don't care what you give me, I am going to use it as an int anyways?
Exactly. Very simple. I would phrase it as I'll accept anything and
cast it to an int.
Of course I am also quite opposed to sticking this into 5.3.
On which grounds? If you don't like the feature, please cast a -1
vote. If its because of the BC problems, I believe you and Johannes
have veto power on what goes into 5.3.x? If so, do you intend to use
it?
Finally I would like to ask to rename this entire feature (including what we
currently already have) to type checking or something other than hint in
the documentation.
Seconded.
Thanks,
Paul
--
Paul Biggar
paul.big...@gmail.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 07.07.2009, at 20:04, Paul Biggar wrote: Of course I am also quite opposed to sticking this into 5.3. On which grounds? If you don't like the feature, please cast a -1 That adding language syntax sugar anything but a major or minor release is a bad idea. And this even if Ilia does manage to solve the BC issues. If there are BC issues, we shouldnt even have to talk about 5.3 for one second. vote. If its because of the BC problems, I believe you and Johannes have veto power on what goes into 5.3.x? If so, do you intend to use it? I dont think we have a veto power, nor would I want to use it if we did have one. One job is to keep things focused and appeal to the general sanity if we feel that things are going off track. I would want to appeal to the general sanity on this one though :) regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. -1 on 5.3. The window for adding new major features to 5.3 is obviously long gone. Not sure why you are even suggesting it. +0 on parts of it for the next major release. You still haven't convinced me that strict type checking won't cause more problems than it will solve, but I do see the benefits. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 7-Jul-09, at 1:35 PM, Jeff Griffiths wrote: On 07/07/09 10:17 AM, Andrei Zmievski wrote: Andrei Zmievski wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1. Sorry, I should have read better. My +1 was for the feature in general, not for 5.3. I think we should concentrate most of the new feature development on 6.0, now that 5.3 is out to avoid having yet another feature-filled 5.x release. So, once again, completely against this going into 5.3. +1 for what Andrei said ( to further muddy the waters ). Ilia, why 5.3 or die? This feature should be in HEAD IMO. PHP 6 is too far off in a practical sense (sorry Andrei) from the time where I can see myself using it in production or other people benefiting from this function. The (simpler) variant of provided patch is what is currently being used on production, if it can go into 5.3, which I see myself using soon, then there is a tangible benefit from making this a public feature (reduce the amount of custom patching) and spending the time to refine it for public consumption and making it PHP 6 ready. If it can only be added in PHP6, then the amount of interest I personally have towards further evolution of this feature is very minimal. So for me personally, the practically of the feature's deployment is critical. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Paul Biggar wrote:
On Tue, Jul 7, 2009 at 6:41 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote:
B) foo($bar);
function bar((int) $bar) {}
What am I really saying with B)?
I don't care what you give me, I am going to use it as an int anyways?
Exactly. Very simple. I would phrase it as I'll accept anything and
cast it to an int.
Of course I am also quite opposed to sticking this into 5.3.
On which grounds? If you don't like the feature, please cast a -1
vote. If its because of the BC problems, I believe you and Johannes
have veto power on what goes into 5.3.x? If so, do you intend to use
it?
On the grounds that 5.3.x is now in maintenance mode, no new features.
This is not a new way of conducting business in PHP, FYI.
Greg
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Ilia Alshanetsky wrote: PHP 6 is too far off in a practical sense (sorry Andrei) from the time where I can see myself using it in production or other people benefiting from this function. The (simpler) variant of provided patch is what is currently being used on production, if it can go into 5.3, which I see myself using soon, then there is a tangible benefit from making this a public feature (reduce the amount of custom patching) and spending the time to refine it for public consumption and making it PHP 6 ready. If it can only be added in PHP6, then the amount of interest I personally have towards further evolution of this feature is very minimal. So for me personally, the practically of the feature's deployment is critical. Ilia, I understand what you're saying, but with this kind of attitude PHP 6 might never arrive if we all keep putting only the things that are practical for our (personal) usage into 5.3, 5.4, etc. The best way to shorten the time horizon of 6 is to treat it as the primary target of the development effort. -Andrei -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Jul 7, 2009, at 1:17 PM, Andrei Zmievski wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1. Sorry, I should have read better. My +1 was for the feature in general, not for 5.3. I think we should concentrate most of the new feature development on 6.0, now that 5.3 is out to avoid having yet another feature-filled 5.x release. So, once again, completely against this going into 5.3. Same here. +1 for HEAD, -1 for 5.3. -- Gwynne -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 for HEAD and 5.3 On Tue, Jul 7, 2009 at 1:55 PM, Gwynne Raskindgwy...@darkrainfall.org wrote: On Jul 7, 2009, at 1:17 PM, Andrei Zmievski wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1. Sorry, I should have read better. My +1 was for the feature in general, not for 5.3. I think we should concentrate most of the new feature development on 6.0, now that 5.3 is out to avoid having yet another feature-filled 5.x release. So, once again, completely against this going into 5.3. Same here. +1 for HEAD, -1 for 5.3. -- Gwynne -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Mon, 2009-07-06 at 20:52 -0400, Ilia Alshanetsky wrote:
Last week or so there was a fairly detailed discussion on the
internals list regarding type hinting based on my original patch.
Since then the patch has been revised to address the major concerns
that were identified (breakage of binary compatibility) as well
extended with additional functionality (object hint, type casting,
reflection support, etc...).
The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt
The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2
If I read the patch correctly it still breaks binary compatibility:
-#define ZEND_ARG_OBJ_INFO(pass_by_ref, name, classname, allow_null) { #name,
sizeof(#name)-1, #classname, sizeof(#classname)-1, 0, allow_null, pass_by_ref,
0, 0 },
-#define ZEND_ARG_ARRAY_INFO(pass_by_ref, name, allow_null) { #name,
sizeof(#name)-1, NULL, 0, 1, allow_null, pass_by_ref, 0, 0 },
+#define ZEND_ARG_OBJ_INFO(pass_by_ref, name, classname, allow_null) { #name,
sizeof(#name)-1, #classname, sizeof(#classname)-1, IS_CLASS, allow_null,
pass_by_ref, 0, 0 },
+#define ZEND_ARG_ARRAY_INFO(pass_by_ref, name, allow_null) { #name,
sizeof(#name)-1, NULL, 0, IS_ARRAY, allow_null, pass_by_ref, 0, 0 },
Having an old 5.3 extension with a typehint expecting an array
arg_info.array_type_hint will be set to 1.
The newly compiled engine with this patch will then do
+ /* existing type already matches the hint or forced type */
+ if (Z_TYPE_P(arg) == cur_arg_info-array_type_hint ||
Z_TYPE_P(arg) == (cur_arg_info-array_type_hint ^ (17))) {
as it's main type check, but Z_TYPE_P(arg) will be IS_ARRAY (5) which
doesn't match the 1 provided by the old extension, other checks in there
will fail too, so the valid param will be rejected whereas an integer
(IS_LONG 1) will be accepted where the extension expects an array.
The only clean why I see for doing this is by breaking the binary
compatibility, then one could also rename array_type_hint and change
it's type from zend_bool to a better suited type.
Independently from this compatibility issue I'd vote -1 for 5.3.
Yes 5.3 took lng and we should, in my opinion, try to be faster with
the next feature release instead of changing syntax and adding other
big features in _bugfix_ releases.
I know it is bad to wait long till new features become available (btw.
that's one of the reasons why 5.3 took so long - let's add this feature
else we have to wait so long till we get the next major version) but
adding features and changing syntax is a pain for users and at least one
of the reasons why distributors won't update the PHP versions they are
offering (What's the current PHP version in RedHat, again? - Yes, I know
people should built PHP themselves but still...)
A thing I wish for sometime is a change to our release model but never
sat really down to do the research and write a good proposal. The basic
concept would be to have a pre announced release date (maybe +/- a few
days) and therefore a last integration date a few weeks/months
beforehand. Ideally the release and integration date for the next
version would be set before the integration date for the current tree is
reached. After the integration day only be bug fixes should be allowed,
no new features at all. By such a model people can plan and if a feature
doesn't make it into a release it's not rejected for an unforeseeable
future. Similar models, in different flavors, are used by at least
PostgreSQL, Ubuntu, OpenSolaris and quite a few more ... but well,
that's off-topic for this thread and I wanted to do some more research
with other projects before proposing such a thing
johannes
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
2009/7/7 Johannes Schlüter johan...@php.net:
On Mon, 2009-07-06 at 20:52 -0400, Ilia Alshanetsky wrote:
Last week or so there was a fairly detailed discussion on the
internals list regarding type hinting based on my original patch.
Having an old 5.3 extension with a typehint expecting an array
arg_info.array_type_hint will be set to 1.
The newly compiled engine with this patch will then do
+ /* existing type already matches the hint or forced type */
+ if (Z_TYPE_P(arg) == cur_arg_info-array_type_hint ||
Z_TYPE_P(arg) == (cur_arg_info-array_type_hint ^ (17))) {
as it's main type check, but Z_TYPE_P(arg) will be IS_ARRAY (5) which
doesn't match the 1 provided by the old extension, other checks in there
will fail too, so the valid param will be rejected whereas an integer
(IS_LONG 1) will be accepted where the extension expects an array.
I raised this in my review, to which Ilia replied It should be fine
(http://news.php.net/php.internals/44707). I would not have thought it
would be fine.
I had been thinking that Ilia would have to hack it to make 1 mean
array in this case, which would be ugly, but workable. Based on the
arguments in this thread, I believe it shouldn't go into 5.3 at all.
Are we allowed break the ABI for 5.4 (I would think so, but amn't
sure).
Overall, I'm very disappointed with the way this has been conducted.
When reviews were posted they are not replied to (Stas posted
http://news.php.net/php.internals/44710, I posted
http://news.php.net/php.internals/44706, and I dont see any replies
except a cursory response to mine). Furthermore:
- the RFC process has been wilfully ignored (despite multiple requests)
- a vote was asked for when Lukas was still trying to discuss his proposal
- the vote was take it or leave it
- there has been a general attitude of throwing the toys out of the pram
I am mostly for the patch, and I 100% support the idea. However, I
feel I have to vote against it, and urge others to do the same, until
the entire mess is rectified.
Ilia, I respect the work you have put into this, but I would ask you
to withdraw the patch and the vote until these things have been sorted
out.
-1
Thanks,
Paul
--
Paul Biggar
paul.big...@gmail.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Paul Biggar wrote: - the RFC process has been wilfully ignored (despite multiple requests) For me it is pretty hard to take a major feature for 5.3 RFC seriously when it comes a week after we finally get 5.3 out the door. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
All of the identified issues can be resolved and none of them
represent a major challenge to address. However, if there is no
consensus to put this in the near future (which at this point is 5.3),
I have hard time justifying spending further time on this. The
original patch that was posted, that did break BC was far simpler and
featureless, the changes since (which took a fair amount of work) were
specifically made to address some of the main concerns that were on
the list. I feel what is on the table right now is pretty close to
what a final product could be, to have a vote on it. If decision is
made to proceed within a practical release schedule, then suffice to
say that I'd be more then happy to put further time to address the
minor issues indicated.
On 7-Jul-09, at 7:07 PM, Paul Biggar wrote:
2009/7/7 Johannes Schlüter johan...@php.net:
On Mon, 2009-07-06 at 20:52 -0400, Ilia Alshanetsky wrote:
Last week or so there was a fairly detailed discussion on the
internals list regarding type hinting based on my original patch.
Having an old 5.3 extension with a typehint expecting an array
arg_info.array_type_hint will be set to 1.
The newly compiled engine with this patch will then do
+ /* existing type already matches the hint or forced
type */
+ if (Z_TYPE_P(arg) == cur_arg_info-array_type_hint
|| Z_TYPE_P(arg) == (cur_arg_info-array_type_hint ^ (17))) {
as it's main type check, but Z_TYPE_P(arg) will be IS_ARRAY (5) which
doesn't match the 1 provided by the old extension, other checks in
there
will fail too, so the valid param will be rejected whereas an integer
(IS_LONG 1) will be accepted where the extension expects an array.
I raised this in my review, to which Ilia replied It should be fine
(http://news.php.net/php.internals/44707). I would not have thought it
would be fine.
I had been thinking that Ilia would have to hack it to make 1 mean
array in this case, which would be ugly, but workable. Based on the
arguments in this thread, I believe it shouldn't go into 5.3 at all.
Are we allowed break the ABI for 5.4 (I would think so, but amn't
sure).
Overall, I'm very disappointed with the way this has been conducted.
When reviews were posted they are not replied to (Stas posted
http://news.php.net/php.internals/44710, I posted
http://news.php.net/php.internals/44706, and I dont see any replies
except a cursory response to mine). Furthermore:
- the RFC process has been wilfully ignored (despite multiple
requests)
- a vote was asked for when Lukas was still trying to discuss his
proposal
- the vote was take it or leave it
- there has been a general attitude of throwing the toys out of
the pram
I am mostly for the patch, and I 100% support the idea. However, I
feel I have to vote against it, and urge others to do the same, until
the entire mess is rectified.
Ilia, I respect the work you have put into this, but I would ask you
to withdraw the patch and the vote until these things have been sorted
out.
-1
Thanks,
Paul
--
Paul Biggar
paul.big...@gmail.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Rasmus, Well, 5.3 has been in feature lock for quite some time, its not like its been a week or two since we went from features in phase to stabilization phase. On 7-Jul-09, at 7:14 PM, Rasmus Lerdorf wrote: Paul Biggar wrote: - the RFC process has been wilfully ignored (despite multiple requests) For me it is pretty hard to take a major feature for 5.3 RFC seriously when it comes a week after we finally get 5.3 out the door. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
Andrei, PHP represents a major change on every aspect of the language, I think you gotta appreciate it that even if it were to be released today there would be sometime before it can certified as production ready in terms of stability and performance. I'd go on a limb and say that PHP6 is probably 3-4 years away from being production material and that's assuming it gets released in the next 8-12 months. During that time people still need to develop applications, which are getting increasingly complex and any helpful tool/feature would be an asset. On 7-Jul-09, at 4:52 PM, Andrei Zmievski wrote: Ilia Alshanetsky wrote: PHP 6 is too far off in a practical sense (sorry Andrei) from the time where I can see myself using it in production or other people benefiting from this function. The (simpler) variant of provided patch is what is currently being used on production, if it can go into 5.3, which I see myself using soon, then there is a tangible benefit from making this a public feature (reduce the amount of custom patching) and spending the time to refine it for public consumption and making it PHP 6 ready. If it can only be added in PHP6, then the amount of interest I personally have towards further evolution of this feature is very minimal. So for me personally, the practically of the feature's deployment is critical. Ilia, I understand what you're saying, but with this kind of attitude PHP 6 might never arrive if we all keep putting only the things that are practical for our (personal) usage into 5.3, 5.4, etc. The best way to shorten the time horizon of 6 is to treat it as the primary target of the development effort. -Andrei -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/07/2009 02:52 AM, Ilia Alshanetsky wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 (5.4/6.0 and object) - -- Tobias Schlitt tob...@schlitt.info GPG Key: 0xC462BC14 a passion for php http://schlitt.info/opensource Member of the eZ Components project http://components.ez.no -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpT6CEACgkQ5bO3TcRivBSHDACgu9ymI+3eDhyZozd+cn9f+cBi GIcAoLRK13NOZaSlQuKyMxl9Zu8TW16r =CCc0 -END PGP SIGNATURE- -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
-1 However, this is ONLY because I do not feel PHP 5.3 is the place to put this. However, I do have to agree with Ilia here that PHP 6 is too far away and it would be nice to have this feature long before then. I would however, be very for adding something similar to this patch in a PHP 5.4 release. I don't see why a PHP 5.4 release can't be done relativly quickly (Like 6-12 months) by just making it more of a minor internal update but something that could have large impacts on user code (syntax changes for type hints). I'd like to see a feature like this out as soon as possible so that people can start adopting it. - Graham Kelly On Tue, Jul 7, 2009 at 5:21 PM, Ilia Alshanetsky i...@prohost.org wrote: Andrei, PHP represents a major change on every aspect of the language, I think you gotta appreciate it that even if it were to be released today there would be sometime before it can certified as production ready in terms of stability and performance. I'd go on a limb and say that PHP6 is probably 3-4 years away from being production material and that's assuming it gets released in the next 8-12 months. During that time people still need to develop applications, which are getting increasingly complex and any helpful tool/feature would be an asset. On 7-Jul-09, at 4:52 PM, Andrei Zmievski wrote: Ilia Alshanetsky wrote: PHP 6 is too far off in a practical sense (sorry Andrei) from the time where I can see myself using it in production or other people benefiting from this function. The (simpler) variant of provided patch is what is currently being used on production, if it can go into 5.3, which I see myself using soon, then there is a tangible benefit from making this a public feature (reduce the amount of custom patching) and spending the time to refine it for public consumption and making it PHP 6 ready. If it can only be added in PHP6, then the amount of interest I personally have towards further evolution of this feature is very minimal. So for me personally, the practically of the feature's deployment is critical. Ilia, I understand what you're saying, but with this kind of attitude PHP 6 might never arrive if we all keep putting only the things that are practical for our (personal) usage into 5.3, 5.4, etc. The best way to shorten the time horizon of 6 is to treat it as the primary target of the development effort. -Andrei -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
That doesn't really change the timing, especially since you said you have been using it for 2 years. Why pick the week after the 5.3 release to propose it for 5.3? It makes very little sense to me, and I think consensus is building that we aren't going to add this to 5.3. I think half the people who voted +1 didn't realize you were seriously thinking of pushing it into 5.3 -Rasmus Ilia Alshanetsky wrote: Rasmus, Well, 5.3 has been in feature lock for quite some time, its not like its been a week or two since we went from features in phase to stabilization phase. On 7-Jul-09, at 7:14 PM, Rasmus Lerdorf wrote: Paul Biggar wrote: - the RFC process has been wilfully ignored (despite multiple requests) For me it is pretty hard to take a major feature for 5.3 RFC seriously when it comes a week after we finally get 5.3 out the door. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
-1 for 5.x +1 for 6.0 Otherwise the Perl 6 guys will starting making their own jokes about being released before PHP 6. --Wez. On Mon, Jul 6, 2009 at 8:52 PM, Ilia Alshanetskyi...@prohost.org wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, Jul 7, 2009 at 08:52, Ilia Alshanetskyi...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php +1 -- Regards, Wang Yi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On 7-Jul-09, at 8:43 PM, Rasmus Lerdorf wrote: That doesn't really change the timing, especially since you said you have been using it for 2 years. Why pick the week after the 5.3 release to propose it for 5.3? It makes very little sense to me, and I think consensus is building that we aren't going to add this to 5.3. I wish I had time to post the patch sooner, but timing was such that it was not an option. Plus people have tried to post the same functionality before there was patch from Hannes back in 2006, a full RFC by Fellipe in 2008 (with patch) and now my attempt in 2009. After some discussions at the developer meeting in Chicago and seeing that there was a substantial interest in the feature I've cleaned up the code and posted the patch. I think half the people who voted +1 didn't realize you were seriously thinking of pushing it into 5.3 Well, its only Tuesday there is plenty of time for people to change their mind (like some already have). Agreeably its a major decisions and I think everyone would agree it should not hinge on 1-2 votes either way, there has to be a substantial let it in consensus for it to go in. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Type hinting/casting request for vote
Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
2009/7/6 Ilia Alshanetsky i...@prohost.org: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Mon, Jul 6, 2009 at 8:52 PM, Ilia Alshanetskyi...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
+1 On Mon, Jul 6, 2009 at 10:42 PM, Eddie Drapkinoorza...@gmail.com wrote: On Mon, Jul 6, 2009 at 8:52 PM, Ilia Alshanetskyi...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- Guilherme Blanco - Web Developer CBC - Certified Bindows Consultant Cell Phone: +55 (16) 9215-8480 MSN: guilhermebla...@hotmail.com URL: http://blog.bisna.com São Paulo - SP/Brazil -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, Jul 7, 2009 at 8:52 AM, Ilia Alshanetskyi...@prohost.org wrote: I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Type hinting/casting request for vote
On Tue, Jul 7, 2009 at 4:52 AM, Ilia Alshanetskyi...@prohost.org wrote: Last week or so there was a fairly detailed discussion on the internals list regarding type hinting based on my original patch. Since then the patch has been revised to address the major concerns that were identified (breakage of binary compatibility) as well extended with additional functionality (object hint, type casting, reflection support, etc...). The final patch is available here: http://ilia.ws/patch/type_hint_53_v2.txt The test suit is available here: http://ia.gd/patch/type_hint_tests.tar.bz2 I would like to ask all developers to voice their opinions of whether it makes sense to add this to 5.3 or to throw it away (either one is fine btw). To keep the process simple flamewar free, please restrict yourself to +/- (1/0), next week monday I'll run a tally of the votes and based on the result we can determine how to proceed further. +1 -- Alexey Zakhlestin http://www.milkfarmsoft.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
