[GitHub] [hbase] ZhaoBQ commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
ZhaoBQ commented on a change in pull request #528: HBASE-22890 Verify the files
when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r323574125
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
##
@@ -267,6 +318,98 @@ void refreshFileConnection(int accessFileNum, IOException
ioe) throws IOExceptio
}
}
+ @Override
+ public byte[] readPersistenceChecksum(String persistencePath) {
Review comment:
It has been modified. Thanks for giving advice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22993) HBCK report UI showed -1 if hbck chore not running
[
https://issues.apache.org/jira/browse/HBASE-22993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928258#comment-16928258
]
Hudson commented on HBASE-22993:
Results for branch master
[build #1429 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1429/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1429//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1429//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1429//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBCK report UI showed -1 if hbck chore not running
> --
>
> Key: HBASE-22993
> URL: https://issues.apache.org/jira/browse/HBASE-22993
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> the HBCK Report is a bit strange as I haven't run any checks
> yet, it says 'Checking started at -1 and generated report at -1. Execute
> hbck_chore_run in hbase shell to generate a new sub-report.'. I think the
> -1 is a bit confusing to users.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#issuecomment-530676871 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 55s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 31s | branch-1 passed | | :green_heart: | compile | 0m 49s | branch-1 passed | | :green_heart: | checkstyle | 2m 4s | branch-1 passed | | :broken_heart: | shadedjars | 0m 14s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 45s | branch-1 passed | | :blue_heart: | spotbugs | 2m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 46s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 2m 19s | the patch passed | | :green_heart: | compile | 0m 54s | the patch passed | | :green_heart: | javac | 0m 54s | the patch passed | | :broken_heart: | checkstyle | 1m 52s | hbase-server: The patch generated 2 new + 46 unchanged - 6 fixed = 48 total (was 52) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 13s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 38s | the patch passed | | :broken_heart: | findbugs | 2m 53s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | :green_heart: | unit | 124m 59s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 159m 52s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(int[]) ignores result of java.io.ObjectInputStream.read(byte[]) At BucketCache.java: At BucketCache.java:[line 1073] | | | org.apache.hadoop.hbase.io.hfile.bucket.FileIOEngine.readPersistenceChecksum(String) ignores result of java.io.ObjectInputStream.read(byte[]) At FileIOEngine.java: At FileIOEngine.java:[line 328] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/528 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 75327fbb7d3e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-528/out/precommit/personality/provided.sh | | git revision | branch-1 / 3f84591 | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/artifact/out/patch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/testReport/ | | Max. process+thread count | 4733 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/32/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu
[jira] [Updated] (HBASE-22980) HRegionPartioner getPartition() method incorrectly partitions the regions of the table.
[
https://issues.apache.org/jira/browse/HBASE-22980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shardul Singh updated HBASE-22980:
--
Description:
*Problem:*
Partitioner class HRegionPartitioner in a HBase MapReduce job has a method
getPartition(). In getPartition(), there is a scenario where we have check for
less number of reducers than region. This scenario seems incorrect because for
a rowKey present in last region(let us say nth region) , getPartition() should
return value (n-1). But it is not returning n-1 for the last region as it is
falling in the case where number of reducers < number of regions and returning
some random value.
So if a client uses this class as a partitioner class in HBase MapReduce jobs,
this method incorrectly partitions the regions because rowKeys present in the
last regions does not fall to the last region.
[https://github.com/apache/hbase/blob/fbd5b5e32753104f88600b0f4c803ab5659bce64/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java#L92]
Consider the following scenario:
if there are 5 regions for the table, partitions = 5 and number of reducers is
also 5.
So in this case above check for reducers < regions should not return true.
But for the last region when i=4(last region, 5th region) , getPartition should
return 4 but it returns 2 because it falls in the case of when we have less
reduces than region and returns true for the above condition even though we
have reducers = regions. So the condition is incorrect.
*Solution:*
Instead of
{code} if (i >= numPartitions-1) {code}
It should be
{code} if (i >= numPartitions){ {code}
was:
Partitioner class HRegionPartitioner in a HBase MapReduce job has a method
getPartition(). In getPartition(), there is a scenario where we have check for
less number of reducers than region. This scenario seems incorrect because for
a rowKey present in last region(let us say nth region) , getPartition() should
return value (n-1). But it is not returning n-1 for the last region as it is
falling in the case where number of reducers < number of regions and returning
some random value.
So if a client uses this class as a partitioner class in HBase MapReduce jobs,
this method incorrectly partitions the regions because rowKeys present in the
last regions does not fall to the last region.
[https://github.com/apache/hbase/blob/fbd5b5e32753104f88600b0f4c803ab5659bce64/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java#L92]
Consider the following scenario:
if there are 5 regions for the table, partitions = 5 and number of reducers is
also 5.
So in this case above check for reducers < regions should not return true.
But for the last region when i=4(last region, 5th region) , getPartition should
return 4 but it returns 2 because it falls in the case of when we have less
reduces than region and returns true for the above condition even though we
have reducers = regions. So the condition is incorrect.
Solution:
Instead of
{code} if (i >= numPartitions-1) {code}
It should be
{code} if (i >= numPartitions){ {code}
> HRegionPartioner getPartition() method incorrectly partitions the regions of
> the table.
> ---
>
> Key: HBASE-22980
> URL: https://issues.apache.org/jira/browse/HBASE-22980
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
>Reporter: Shardul Singh
>Assignee: Shardul Singh
>Priority: Major
>
> *Problem:*
> Partitioner class HRegionPartitioner in a HBase MapReduce job has a method
> getPartition(). In getPartition(), there is a scenario where we have check
> for less number of reducers than region. This scenario seems incorrect
> because for a rowKey present in last region(let us say nth region) ,
> getPartition() should return value (n-1). But it is not returning n-1 for the
> last region as it is falling in the case where number of reducers < number of
> regions and returning some random value.
> So if a client uses this class as a partitioner class in HBase MapReduce
> jobs, this method incorrectly partitions the regions because rowKeys present
> in the last regions does not fall to the last region.
> [https://github.com/apache/hbase/blob/fbd5b5e32753104f88600b0f4c803ab5659bce64/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java#L92]
> Consider the following scenario:
> if there are 5 regions for the table, partitions = 5 and number of reducers
> is also 5.
> So in this case above check for reducers < regions should not return true.
> But for the last region when i=4(last region, 5th region) , getPartition
> should return 4 but it returns 2 because it falls in the case of when we have
> less reduce
[GitHub] [hbase] anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff
anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due
to DBE reference to an reused ByteBuff
URL: https://github.com/apache/hbase/pull/603#discussion_r323557944
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##
@@ -781,6 +783,11 @@ public Cell getLastCell() {
return lastCell;
}
+ @VisibleForTesting
Review comment:
So many method exposes for the test-ability. Are we really testing the FT
way? That a prevCell been passed and we pollute that cell's backing BB/byte[]
after a shipped call? That would be the best and in that I dont think we need
to expose these many method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff
anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due
to DBE reference to an reused ByteBuff
URL: https://github.com/apache/hbase/pull/603#discussion_r323557456
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
##
@@ -840,6 +841,16 @@ public boolean isSharedMem() {
/** Meta data that holds information about the hfileblock**/
private HFileContext fileContext;
+void beforeShipped() {
Review comment:
Why not making it ShipperListener. That would be best
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff
anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due
to DBE reference to an reused ByteBuff
URL: https://github.com/apache/hbase/pull/603#discussion_r323557327
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodingState.java
##
@@ -31,4 +32,15 @@
* The previous Cell the encoder encoded.
*/
protected Cell prevCell = null;
+
+ @VisibleForTesting
+ public Cell getLastCell() {
+return prevCell;
+ }
+
+ public void beforeShipped() {
+if (this.prevCell != null) {
+ this.prevCell = KeyValueUtil.copyToNewKeyValue(this.prevCell);
Review comment:
Seems we need both key and value from the prevCell in FastDiffDeltaEncoder
and all. Just add a comment saying so. Normally we copy the key part alone in
beforeShipped
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff
anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due
to DBE reference to an reused ByteBuff
URL: https://github.com/apache/hbase/pull/603#discussion_r323557399
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodingState.java
##
@@ -31,4 +32,15 @@
* The previous Cell the encoder encoded.
*/
protected Cell prevCell = null;
+
+ @VisibleForTesting
+ public Cell getLastCell() {
+return prevCell;
+ }
+
+ public void beforeShipped() {
Review comment:
Why not making it ShipperListener. That would be best
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ramkrish86 commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
ramkrish86 commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r323554877
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
##
@@ -267,6 +318,98 @@ void refreshFileConnection(int accessFileNum, IOException
ioe) throws IOExceptio
}
}
+ @Override
+ public byte[] readPersistenceChecksum(String persistencePath) {
Review comment:
this can be called readPersistentCheckSum(). But do we need this API.
Instead can we just do this internally under verifyCheckSum() or
verifyFileIntegrity()?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23006) RSGroupBasedLoadBalancer should also try to place replicas for the same region to different region servers
[ https://issues.apache.org/jira/browse/HBASE-23006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928194#comment-16928194 ] ramkrishna.s.vasudevan commented on HBASE-23006: In many of the cases the LB was not considering the replicas. good to see this getting solved. > RSGroupBasedLoadBalancer should also try to place replicas for the same > region to different region servers > -- > > Key: HBASE-23006 > URL: https://issues.apache.org/jira/browse/HBASE-23006 > Project: HBase > Issue Type: Bug > Components: Region Assignment, rsgroup >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-23006-UT.patch > > > Found this when implementing HBASE-22971. TestSCPWithReplicas fails when > RSGroupBasedLoadBalancer is enabled. > And this can be reproduced by a UT on master branch too. I think the problem > is that in RSGroupBasedLoadBalancer.retainAssignment we do not consider > region replicas. > We should fix this. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928187#comment-16928187
]
Hudson commented on HBASE-23000:
Results for branch branch-1.3
[build #966 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
> Fix For: 1.3.6
>
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-18150) hbase.version file is created under both hbase.rootdir and hbase.wal.dir
[
https://issues.apache.org/jira/browse/HBASE-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928188#comment-16928188
]
Hudson commented on HBASE-18150:
Results for branch branch-1.3
[build #966 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/966//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> hbase.version file is created under both hbase.rootdir and hbase.wal.dir
>
>
> Key: HBASE-18150
> URL: https://issues.apache.org/jira/browse/HBASE-18150
> Project: HBase
> Issue Type: Bug
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Critical
> Fix For: 1.4.0
>
> Attachments: HBASE-18150.branch-1.000.patch
>
>
> Branch-1 has HBASE-17437. When hbase.wal.dir is specified, hbase.version file
> is created under both hbase.rootdir and hbase.wal.dir. The master branch does
> not has the same issue
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Use separate classe to deal with streaming read and pread
Apache9 commented on a change in pull request #581: HBASE-22888 Use separate
classe to deal with streaming read and pread
URL: https://github.com/apache/hbase/pull/581#discussion_r323545030
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
##
@@ -614,7 +629,11 @@ public static Reader createReader(FileSystem fs, Path
path, CacheConfig cacheCon
static Reader createReaderFromStream(Path path, FSDataInputStream fsdis,
long size,
CacheConfig cacheConf, Configuration conf) throws IOException {
FSDataInputStreamWrapper wrapper = new FSDataInputStreamWrapper(fsdis);
-return openReader(path, wrapper, size, cacheConf, null, true, conf);
+Reader preadReader = openReader(path, wrapper, size, cacheConf, null,
true, true, conf);
Review comment:
This is a bit strange, that we create two readers, but only returns one of
them, without closing the other one...I know there is no problem, as the
resources are in the FSDataInputStream passed in, but still a bit strange
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Use separate classe to deal with streaming read and pread
Apache9 commented on a change in pull request #581: HBASE-22888 Use separate
classe to deal with streaming read and pread
URL: https://github.com/apache/hbase/pull/581#discussion_r323545281
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
##
@@ -164,13 +158,14 @@ public boolean isEmpty() {
@Override
public BlockWithScanInfo loadDataBlockWithScanInfo(Cell key, HFileBlock
currentBlock,
boolean cacheBlocks, boolean pread, boolean isCompaction,
-DataBlockEncoding expectedDataBlockEncoding) throws IOException {
+DataBlockEncoding expectedDataBlockEncoding,
+CachingBlockReader cachingBlockReader) throws IOException {
// this would not be needed
return null;
}
@Override
-public Cell midkey() throws IOException {
+public Cell midkey(CachingBlockReader cachingBlockReader) throws
IOException {
Review comment:
Ditto.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Use separate classe to deal with streaming read and pread
Apache9 commented on a change in pull request #581: HBASE-22888 Use separate
classe to deal with streaming read and pread
URL: https://github.com/apache/hbase/pull/581#discussion_r323545204
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
##
@@ -164,13 +158,14 @@ public boolean isEmpty() {
@Override
public BlockWithScanInfo loadDataBlockWithScanInfo(Cell key, HFileBlock
currentBlock,
boolean cacheBlocks, boolean pread, boolean isCompaction,
-DataBlockEncoding expectedDataBlockEncoding) throws IOException {
+DataBlockEncoding expectedDataBlockEncoding,
+CachingBlockReader cachingBlockReader) throws IOException {
Review comment:
What is the new parameter CachingBlockReader used for?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #581: HBASE-22888 Use separate classe to deal with streaming read and pread
Apache9 commented on a change in pull request #581: HBASE-22888 Use separate
classe to deal with streaming read and pread
URL: https://github.com/apache/hbase/pull/581#discussion_r323545829
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
##
@@ -270,7 +270,10 @@ public StoreFileReader open(FileSystem fs, CacheConfig
cacheConf, boolean canUse
status = fs.getFileStatus(initialPath);
}
long length = status.getLen();
-hdfsBlocksDistribution = computeHDFSBlocksDistribution(fs);
+if (shared) {
Review comment:
I know why we need to test this but it is a bit strange...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani edited a comment on issue #611: HBASE-22903 : Table to RegionStatesCount metrics
virajjasani edited a comment on issue #611: HBASE-22903 : Table to RegionStatesCount metrics URL: https://github.com/apache/hbase/pull/611#issuecomment-530653156 Please review @Reidd @Apache9 @openinx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22993) HBCK report UI showed -1 if hbck chore not running
[ https://issues.apache.org/jira/browse/HBASE-22993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22993. Fix Version/s: 2.2.2 2.1.7 2.3.0 3.0.0 Resolution: Fixed Pushed to branch-2.1+. Thanks [~stack] for reviewing. > HBCK report UI showed -1 if hbck chore not running > -- > > Key: HBASE-22993 > URL: https://issues.apache.org/jira/browse/HBASE-22993 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > the HBCK Report is a bit strange as I haven't run any checks > yet, it says 'Checking started at -1 and generated report at -1. Execute > hbck_chore_run in hbase shell to generate a new sub-report.'. I think the > -1 is a bit confusing to users. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics
virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics URL: https://github.com/apache/hbase/pull/611#issuecomment-530653156 Please review @Reidd @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-23005) Table UI showed exception message when table is disabled
[ https://issues.apache.org/jira/browse/HBASE-23005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-23005: -- Assignee: Guanghao Zhang > Table UI showed exception message when table is disabled > > > Key: HBASE-23005 > URL: https://issues.apache.org/jira/browse/HBASE-23005 > Project: HBase > Issue Type: Bug >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Minor > Attachments: 2019-09-11 09-49-29屏幕截图.png > > > Compaction > java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)org.apache.hadoop.hbase.generated.master.table_jsp._jspService(table_jsp.java:299)org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)javax.servlet.http.HttpServlet.service(HttpServlet.java:790)org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:840)org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1391)org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)org.eclipse.jetty.server.Server.handle(Server.java:539)org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)java.lang.Thread.run(Thread.java:748) > Unknown -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23013) Please add my public key to committer keys
[ https://issues.apache.org/jira/browse/HBASE-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928174#comment-16928174 ] Sakthi commented on HBASE-23013: Thanks Duo. > Please add my public key to committer keys > -- > > Key: HBASE-23013 > URL: https://issues.apache.org/jira/browse/HBASE-23013 > Project: HBase > Issue Type: Sub-task > Components: community >Reporter: Sakthi >Assignee: Duo Zhang >Priority: Major > Attachments: sakthi.asc > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HBASE-23013) Please add my public key to committer keys
[ https://issues.apache.org/jira/browse/HBASE-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23013: - Assignee: Duo Zhang (was: Sakthi) > Please add my public key to committer keys > -- > > Key: HBASE-23013 > URL: https://issues.apache.org/jira/browse/HBASE-23013 > Project: HBase > Issue Type: Sub-task > Components: community >Reporter: Sakthi >Assignee: Duo Zhang >Priority: Major > Attachments: sakthi.asc > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-23013) Please add my public key to committer keys
[ https://issues.apache.org/jira/browse/HBASE-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23013. --- Resolution: Fixed Done. > Please add my public key to committer keys > -- > > Key: HBASE-23013 > URL: https://issues.apache.org/jira/browse/HBASE-23013 > Project: HBase > Issue Type: Sub-task > Components: community >Reporter: Sakthi >Assignee: Duo Zhang >Priority: Major > Attachments: sakthi.asc > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22975) Add read and write QPS metrics at server level and table level
[ https://issues.apache.org/jira/browse/HBASE-22975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zbq.dean updated HBASE-22975: - Affects Version/s: master 2.2.0 > Add read and write QPS metrics at server level and table level > -- > > Key: HBASE-22975 > URL: https://issues.apache.org/jira/browse/HBASE-22975 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 2.2.0, 1.4.10, master >Reporter: zbq.dean >Priority: Major > > Use HBase‘s existing class DropwizardMeter to collect read and write QPS. The > collected location is the same as metrics readRequestsCount and > writeRequestsCount. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] ZhaoBQ closed pull request #586: HBASE-22975 Add read and write QPS metrics at server level and table level
ZhaoBQ closed pull request #586: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22890) Verify the files when RegionServer is starting and BucketCache is in file mode
[ https://issues.apache.org/jira/browse/HBASE-22890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928162#comment-16928162 ] zbq.dean edited comment on HBASE-22890 at 9/12/19 3:27 AM: --- [~reidchan] [~anoop.hbase], I have created a new issue for master and branch-2. [Forward-port|https://issues.apache.org/jira/browse/HBASE-23017] was (Author: deanz): [~reidchan] [~anoop.hbase], I have created a new issue for master and branch-2. > Verify the files when RegionServer is starting and BucketCache is in file mode > -- > > Key: HBASE-22890 > URL: https://issues.apache.org/jira/browse/HBASE-22890 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 1.4.6, 1.4.10, 1.3.5 >Reporter: zbq.dean >Priority: Major > Attachments: HBASE-22890.branch-1.0001.patch > > > We use FileIOEngine in BucketCache and have configured > . If the RegionServer is stopped, and the > cache data file or the backingMap persistence file is deleted or changed > before the RegionServer is restarted. When restart RegionServer, the > backingMap and cache data are Inconsistent, and get or scan command will get > IOException like follows: > bucket.BucketCache: Failed reading block > 18951416e2ca4e8bbc11523f4f5ea576_1125745279 from bucket cache > java.io.IOException: Invalid HFile block magic: > \x00\x00\x00\x00\x00\x00\x00\x00 > at org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154) > at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167) > at org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:347) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:247) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:226) > at > org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:514) > .. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22890) Verify the files when RegionServer is starting and BucketCache is in file mode
[ https://issues.apache.org/jira/browse/HBASE-22890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928162#comment-16928162 ] zbq.dean commented on HBASE-22890: -- [~reidchan] [~anoop.hbase], I have created a new issue for master and branch-2. > Verify the files when RegionServer is starting and BucketCache is in file mode > -- > > Key: HBASE-22890 > URL: https://issues.apache.org/jira/browse/HBASE-22890 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 1.4.6, 1.4.10, 1.3.5 >Reporter: zbq.dean >Priority: Major > Attachments: HBASE-22890.branch-1.0001.patch > > > We use FileIOEngine in BucketCache and have configured > . If the RegionServer is stopped, and the > cache data file or the backingMap persistence file is deleted or changed > before the RegionServer is restarted. When restart RegionServer, the > backingMap and cache data are Inconsistent, and get or scan command will get > IOException like follows: > bucket.BucketCache: Failed reading block > 18951416e2ca4e8bbc11523f4f5ea576_1125745279 from bucket cache > java.io.IOException: Invalid HFile block magic: > \x00\x00\x00\x00\x00\x00\x00\x00 > at org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154) > at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167) > at org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:347) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:247) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:226) > at > org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:514) > .. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-23017) [Forward-port] Verify the file integrity in persistent IOEngine
[ https://issues.apache.org/jira/browse/HBASE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zbq.dean updated HBASE-23017: - Summary: [Forward-port] Verify the file integrity in persistent IOEngine (was: Verify the file integrity in persistent IOEngine) > [Forward-port] Verify the file integrity in persistent IOEngine > --- > > Key: HBASE-23017 > URL: https://issues.apache.org/jira/browse/HBASE-23017 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 2.2.0, master >Reporter: zbq.dean >Priority: Major > > Verify the persistent cache file integrity before retrieve from persistence > file. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-23017) Verify the file integrity in persistent IOEngine
zbq.dean created HBASE-23017: Summary: Verify the file integrity in persistent IOEngine Key: HBASE-23017 URL: https://issues.apache.org/jira/browse/HBASE-23017 Project: HBase Issue Type: Bug Components: BucketCache Affects Versions: 2.2.0, master Reporter: zbq.dean Verify the persistent cache file integrity before retrieve from persistence file. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928139#comment-16928139 ] Vladimir Rodionov commented on HBASE-22749: --- Uploaded patch for 2.2 branch. Master version will follow shortly. > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBASE-22749-branch-2.2-v3.patch, HBase-MOB-2.0-v1.pdf, > HBase-MOB-2.0-v2.1.pdf, HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-22749: -- Attachment: HBASE-22749-branch-2.2-v3.patch > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBASE-22749-branch-2.2-v3.patch, HBase-MOB-2.0-v1.pdf, > HBase-MOB-2.0-v2.1.pdf, HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] shahrs87 commented on issue #580: [HBASE-22874] Canary should not be IA.Public
shahrs87 commented on issue #580: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/580#issuecomment-530631488 @jatsakthi Would like to see this commit in 1.3 release also. Apologies if I am requesting to review too many PR's. I will really appreciate if you can review this PR. Thank you ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shahrs87 commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
shahrs87 commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530628696 Thank you @jatsakthi for the review and commit ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928116#comment-16928116 ] stack commented on HBASE-23003: --- .0001 seems to work. There is an issue with what is pushed up to repository.apache.org but that is not this stuff IIRC. This patch is what was in hbase for creating a release but generalized. Porting to one other repo and it might be general enough for yetus? > [HBCK2/hbase-operator-tools] Release-making scripts > --- > > Key: HBASE-23003 > URL: https://issues.apache.org/jira/browse/HBASE-23003 > Project: HBase > Issue Type: Task >Reporter: stack >Priority: Major > Attachments: > 0001-HBASE-23003-HBCK2-hbase-operator-tools-Release-makin.patch > > > Make some scripts for creating hbase-operator-tools releases so its easy to > do and not subject to vagaries of environment or RM's attention-to-detail (or > not). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-23003: -- Attachment: 0001-HBASE-23003-HBCK2-hbase-operator-tools-Release-makin.patch > [HBCK2/hbase-operator-tools] Release-making scripts > --- > > Key: HBASE-23003 > URL: https://issues.apache.org/jira/browse/HBASE-23003 > Project: HBase > Issue Type: Task >Reporter: stack >Priority: Major > Attachments: > 0001-HBASE-23003-HBCK2-hbase-operator-tools-Release-makin.patch > > > Make some scripts for creating hbase-operator-tools releases so its easy to > do and not subject to vagaries of environment or RM's attention-to-detail (or > not). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] infraio merged pull request #610: HBASE-22993 HBCK report UI showed -1 if hbck chore not running
infraio merged pull request #610: HBASE-22993 HBCK report UI showed -1 if hbck chore not running URL: https://github.com/apache/hbase/pull/610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-18150) hbase.version file is created under both hbase.rootdir and hbase.wal.dir
[ https://issues.apache.org/jira/browse/HBASE-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928111#comment-16928111 ] Hudson commented on HBASE-18150: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #639 (See [https://builds.apache.org/job/HBase-1.3-IT/639/]) [HBASE-23000] Backport HBASE-18150 to branch-1.3 to fix consistently (sakthi: rev 009882b31c38d0d3c696f3e6b0defc6c0fc31144) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java > hbase.version file is created under both hbase.rootdir and hbase.wal.dir > > > Key: HBASE-18150 > URL: https://issues.apache.org/jira/browse/HBASE-18150 > Project: HBase > Issue Type: Bug >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Critical > Fix For: 1.4.0 > > Attachments: HBASE-18150.branch-1.000.patch > > > Branch-1 has HBASE-17437. When hbase.wal.dir is specified, hbase.version file > is created under both hbase.rootdir and hbase.wal.dir. The master branch does > not has the same issue -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928110#comment-16928110
]
Hudson commented on HBASE-23000:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #639 (See
[https://builds.apache.org/job/HBase-1.3-IT/639/])
[HBASE-23000] Backport HBASE-18150 to branch-1.3 to fix consistently (sakthi:
rev 009882b31c38d0d3c696f3e6b0defc6c0fc31144)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
> Fix For: 1.3.6
>
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics
Apache-HBase commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics URL: https://github.com/apache/hbase/pull/611#issuecomment-530619368 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 2m 13s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 41s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 7m 7s | master passed | | :green_heart: | compile | 3m 12s | master passed | | :green_heart: | checkstyle | 2m 56s | master passed | | :green_heart: | shadedjars | 5m 57s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 50s | master passed | | :blue_heart: | spotbugs | 5m 33s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 10m 4s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 6m 28s | the patch passed | | :green_heart: | compile | 3m 14s | the patch passed | | :green_heart: | cc | 3m 14s | the patch passed | | :green_heart: | javac | 3m 15s | the patch passed | | :broken_heart: | checkstyle | 0m 41s | hbase-client: The patch generated 9 new + 180 unchanged - 0 fixed = 189 total (was 180) | | :broken_heart: | rubocop | 0m 11s | The patch generated 3 new + 270 unchanged - 1 fixed = 273 total (was 271) | | :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 6m 5s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 22m 10s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 2m 59s | the patch passed | | :green_heart: | javadoc | 1m 49s | the patch passed | | :green_heart: | findbugs | 10m 31s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 53s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 2m 11s | hbase-client in the patch passed. | | :broken_heart: | unit | 290m 46s | hbase-server in the patch failed. | | :green_heart: | unit | 11m 25s | hbase-shell in the patch passed. | | :green_heart: | asflicense | 1m 58s | The patch does not generate ASF License warnings. | | | | 406m 47s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestAsyncRegionAdminApi2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/611 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop | | uname | Linux d62b8f9b8295 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-611/out/precommit/personality/provided.sh | | git revision | master / a58149827b | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/diff-checkstyle-hbase-client.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/diff-patch-rubocop.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/testReport/ | | Max. process+thread count | 4712 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . | | Console output | https://builds.apache.org/job/H
[jira] [Commented] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928106#comment-16928106
]
Sakthi commented on HBASE-23000:
Merged the PR. Thanks [~shahrs87] for the contribution.
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
> Fix For: 1.3.6
>
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Resolved] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi resolved HBASE-23000.
Fix Version/s: 1.3.6
Resolution: Fixed
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
> Fix For: 1.3.6
>
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] jatsakthi merged pull request #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
jatsakthi merged pull request #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530616965 The tests passed continuously around ~15 times. I think we are good here. Let me merge this in. Thanks @shahrs87 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23013) Please add my public key to committer keys
[
https://issues.apache.org/jira/browse/HBASE-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928103#comment-16928103
]
Sakthi commented on HBASE-23013:
{code:java}
$ svn co https://dist.apache.org/repos/dist/release/hbase/ svn-hbase
...
$ // After modifying KEYS
...
$ svn status
M KEYS
$ svn update
Updating '.':
At revision 35774.
$ svn status
M KEYS
$ svn commit --username sakthi --password --message "Add sak...@apache.org
to KEYS file"
SendingKEYS
Transmitting file data .svn: E195023: Commit failed (details follow):
svn: E195023: Changing file '/path/to/dev/svn-hbase/KEYS' is forbidden by the
server
svn: E175013: Access to '/repos/dist/!svn/txr/35774-u6q/release/hbase/KEYS'
forbidden {code}
[~Apache9] Am I doing something wrong? Or only the PMC has push access, maybe?
Could you please guide me.
> Please add my public key to committer keys
> --
>
> Key: HBASE-23013
> URL: https://issues.apache.org/jira/browse/HBASE-23013
> Project: HBase
> Issue Type: Sub-task
> Components: community
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
> Attachments: sakthi.asc
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928102#comment-16928102
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #106 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/106/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/106//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/106//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/106//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/106//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22956) [HBCK2/hbase-operator-tools] Make first release, 1.0.0
[ https://issues.apache.org/jira/browse/HBASE-22956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928094#comment-16928094 ] stack commented on HBASE-22956: --- Task is running through git log and comparing to JIRA making sure they are aligned so when we generate CHANGES and RELEASENOTES, they are correct (Fixes need to have version set to hbase-operator-tools-1.0.0 in JIRA). Also need to go other way, comparing JIRA to git log (smile). > [HBCK2/hbase-operator-tools] Make first release, 1.0.0 > -- > > Key: HBASE-22956 > URL: https://issues.apache.org/jira/browse/HBASE-22956 > Project: HBase > Issue Type: Bug > Components: hbck2 >Reporter: stack >Priority: Major > Fix For: hbase-operator-tools-1.0.0 > > > Make our first release of hbck2/hbase-operator-tools. > First release should have the coverage hbck1 had at least. When the parent > for this issue is done, we'll be at hbck1+. Let us release then (week or > two?). > A release will help operators who have been struggling having to build hbck2 > against different hbase versions. The release should be a "fat > jar"/completely contained with all dependency satisfied so operator can just > fire up hbck2 w/o having to build against an hbase or provide some magic mix > of jars to satisfy hbck2 tool needs. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928092#comment-16928092
]
Sakthi edited comment on HBASE-23000 at 9/11/19 11:32 PM:
--
Unfortunately all 4 tests (TestLogRollAbort, TestBlockReorder,
TestHRegionServerBulkLoad, TestMasterFileSystemWithWALDir) that this patch
intends to fix, were skipped in the UT runs of the QA.
Running [TestLogRollAbort, TestBlockReorder, TestHRegionServerBulkLoad,
TestMasterFileSystemWithWALDir] -
[https://builds.apache.org/view/H-L/view/HBase/job/HBase-adhoc-run-tests/30/console]
was (Author: jatsakthi):
Running [TestLogRollAbort, TestBlockReorder, TestHRegionServerBulkLoad,
TestMasterFileSystemWithWALDir] -
[https://builds.apache.org/view/H-L/view/HBase/job/HBase-adhoc-run-tests/30/console]
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928092#comment-16928092
]
Sakthi commented on HBASE-23000:
Running [TestLogRollAbort, TestBlockReorder, TestHRegionServerBulkLoad,
TestMasterFileSystemWithWALDir] -
[https://builds.apache.org/view/H-L/view/HBase/job/HBase-adhoc-run-tests/30/console]
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530604548 Running [TestLogRollAbort, TestBlockReorder, TestHRegionServerBulkLoad, TestMasterFileSystemWithWALDir] - https://builds.apache.org/view/H-L/view/HBase/job/HBase-adhoc-run-tests/30/console This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530602601 Let me run this patch in our adhoc testing framework to crosscheck This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary
Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612#issuecomment-530601006 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | :broken_heart: | dupname | 0m 0s | The patch has 1 duplicated filenames that differ only in case. | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/612 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 16a43de13997 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-612/out/precommit/personality/provided.sh | | git revision | branch-1 / 3f84591 | | dupname | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/2/artifact/out/dupnames.txt | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/2/console | | versions | git=1.9.1 maven=3.0.5 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928086#comment-16928086
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #105 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/105/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/105//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/105//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/105//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/105//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-23000:
---
Parent: HBASE-23012
Issue Type: Sub-task (was: Bug)
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-23000:
---
Labels: backport (was: )
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
> Labels: backport
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-23000) Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-23000:
---
Summary: Backport HBASE-18150 to branch-1.3 to fix consistently failing
tests (was: Fix all consistently failing tests in branch-1.3)
> Backport HBASE-18150 to branch-1.3 to fix consistently failing tests
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
jatsakthi commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530598109 Thanks for the patch @shahrs87 let me give it a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23013) Please add my public key to committer keys
[ https://issues.apache.org/jira/browse/HBASE-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928078#comment-16928078 ] Sakthi commented on HBASE-23013: Thanks for the suggestion [~Apache9]. Let me give it a try. > Please add my public key to committer keys > -- > > Key: HBASE-23013 > URL: https://issues.apache.org/jira/browse/HBASE-23013 > Project: HBase > Issue Type: Sub-task > Components: community >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Attachments: sakthi.asc > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HBASE-23013) Please add my public key to committer keys
[ https://issues.apache.org/jira/browse/HBASE-23013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi reassigned HBASE-23013: -- Assignee: Sakthi > Please add my public key to committer keys > -- > > Key: HBASE-23013 > URL: https://issues.apache.org/jira/browse/HBASE-23013 > Project: HBase > Issue Type: Sub-task > Components: community >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Attachments: sakthi.asc > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23014) Should not show split parent regions in hbck report UI
[
https://issues.apache.org/jira/browse/HBASE-23014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928077#comment-16928077
]
Hudson commented on HBASE-23014:
Results for branch branch-2
[build #2252 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2252/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2252//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2252//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2252//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not show split parent regions in hbck report UI
> --
>
> Key: HBASE-23014
> URL: https://issues.apache.org/jira/browse/HBASE-23014
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: 2019-09-11 09-11-47屏幕截图.png
>
>
> Now the split parent region is showed in Inconsistent Regions and Region
> Holes. Attached a screen for this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] shahrs87 commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
shahrs87 commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530597486 @jatsakthi could you please review this PR ? Thank you ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22988) Backport HBASE-11062 "hbtop" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928068#comment-16928068 ] Andrew Purtell commented on HBASE-22988: Not sure your addendum changes are included here. I used your github branch as source. bq. Do we need to convert the patch to for java7? If so, I can do it. It would make adoption easier. Right now we must conditionally include the module only if building with java 8 and there are issues with precommit for this configuration. If it were all Java 7 code then we can include the module unconditionally. The issues with the unit tests would also be resolved. Let’s do this if you have the time and interest. I will be back from vacation in two weeks. Happy to review or help out when back if needed. > Backport HBASE-11062 "hbtop" to branch-1 > > > Key: HBASE-22988 > URL: https://issues.apache.org/jira/browse/HBASE-22988 > Project: HBase > Issue Type: Sub-task > Components: backport, hbtop >Reporter: Toshihiro Suzuki >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22988-branch-1.patch > > > Backport parent issue to branch-1. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23014) Should not show split parent regions in hbck report UI
[
https://issues.apache.org/jira/browse/HBASE-23014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928051#comment-16928051
]
Hudson commented on HBASE-23014:
Results for branch master
[build #1428 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1428/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1428//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1428//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1428//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not show split parent regions in hbck report UI
> --
>
> Key: HBASE-23014
> URL: https://issues.apache.org/jira/browse/HBASE-23014
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: 2019-09-11 09-11-47屏幕截图.png
>
>
> Now the split parent region is showed in Inconsistent Regions and Region
> Holes. Attached a screen for this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23014) Should not show split parent regions in hbck report UI
[
https://issues.apache.org/jira/browse/HBASE-23014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928048#comment-16928048
]
Hudson commented on HBASE-23014:
Results for branch branch-2.2
[build #598 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/598/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/598//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/598//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/598//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not show split parent regions in hbck report UI
> --
>
> Key: HBASE-23014
> URL: https://issues.apache.org/jira/browse/HBASE-23014
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: 2019-09-11 09-11-47屏幕截图.png
>
>
> Now the split parent region is showed in Inconsistent Regions and Region
> Holes. Attached a screen for this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary
Apache-HBase commented on issue #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612#issuecomment-530586253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 18s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 0s | branch-1 passed | | :green_heart: | compile | 0m 41s | branch-1 passed | | :green_heart: | checkstyle | 1m 43s | branch-1 passed | | :broken_heart: | shadedjars | 0m 12s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 39s | branch-1 passed | | :blue_heart: | spotbugs | 2m 38s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 36s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 2m 2s | the patch passed | | :green_heart: | compile | 0m 44s | the patch passed | | :green_heart: | javac | 0m 44s | the patch passed | | :broken_heart: | checkstyle | 1m 47s | hbase-server: The patch generated 45 new + 64 unchanged - 5 fixed = 109 total (was 69) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 13s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 7s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 31s | the patch passed | | :green_heart: | findbugs | 2m 19s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 137m 8s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 168m 51s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/612 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 20da2abc28d0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-612/out/precommit/personality/provided.sh | | git revision | branch-1 / 3f84591 | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/artifact/out/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/testReport/ | | Max. process+thread count | 5122 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-612/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload
busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#discussion_r323461971 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java ## @@ -0,0 +1,304 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import static org.apache.hadoop.hbase.HConstants.REPLICATION_CLUSTER_ID; +import static org.apache.hadoop.hbase.HConstants.REPLICATION_CONF_DIR; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import java.io.File; +import java.io.FileOutputStream; +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FSDataOutputStream; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.CellBuilder; +import org.apache.hadoop.hbase.CellBuilderFactory; +import org.apache.hadoop.hbase.CellBuilderType; +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.HBaseTestingUtility; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.KeyValue; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.client.ConnectionFactory; +import org.apache.hadoop.hbase.client.Get; +import org.apache.hadoop.hbase.client.Result; +import org.apache.hadoop.hbase.client.Table; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.client.TableDescriptorBuilder; +import org.apache.hadoop.hbase.coprocessor.ObserverContext; +import org.apache.hadoop.hbase.coprocessor.RegionCoprocessor; +import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment; +import org.apache.hadoop.hbase.coprocessor.RegionObserver; +import org.apache.hadoop.hbase.io.hfile.HFile; +import org.apache.hadoop.hbase.io.hfile.HFileContext; +import org.apache.hadoop.hbase.replication.ReplicationPeerConfig; +import org.apache.hadoop.hbase.replication.TestReplicationBase; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.apache.hadoop.hbase.testclassification.ReplicationTests; +import org.apache.hadoop.hbase.tool.BulkLoadHFilesTool; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.Pair; +import org.apache.hadoop.hdfs.MiniDFSCluster; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.rules.TemporaryFolder; +import org.junit.rules.TestName; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Integration test for bulk load replication. Defines two clusters, with two way replication. + * Performs a bulk load on cluster defined by UTIL1 first, asserts the Cell on the bulk loaded file + * gets into the related table in UTIL1, then also validates the same got replicated to cluster + * UTIL2. Then, bulk loads another file into UTIL2, and checks if related values are present on + * UTIL2, and also gets replicated to UTIL1. Review comment: This description isn't accurate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #566: HBASE-22380 break circle replication when doing bulkload
busbey commented on a change in pull request #566: HBASE-22380 break circle
replication when doing bulkload
URL: https://github.com/apache/hbase/pull/566#discussion_r323462663
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##
@@ -579,9 +579,9 @@ public static BulkLoadHFileRequest
buildBulkLoadHFileRequest(
* @return a bulk load request
*/
public static BulkLoadHFileRequest buildBulkLoadHFileRequest(
- final List> familyPaths,
- final byte[] regionName, boolean assignSeqNum,
- final Token userToken, final String bulkToken, boolean copyFiles) {
+ final List> familyPaths, final byte[] regionName,
boolean assignSeqNum,
+final Token userToken, final String bulkToken, boolean copyFiles,
+ List clusterIds) {
Review comment:
I agree keeping UUIDs until serialization would be nicer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #494: HBASE-22380 break circle replication when doing bulkload
busbey commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-530566488 > On the reported findbugs issue: We do need to iterate over the keySet, as we do need the clusterId further to forward it to HFileReplicator call. What do you mean by annotate it @busbey ? Commenting on that line? You can annotate the implementation so that findbugs doesn't report an error. I think the lowest level you can do it for is the method. In this case though, I believe the complaint from findbugs is that we should be using `entrySet` instead of both `keySet` and then `getValue` with the key. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11
busbey commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530556788 We still need the ignore class when using Mockito 2.28.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23009) TestSnapshotScannerHDFSAclController is broken on branch-2
[
https://issues.apache.org/jira/browse/HBASE-23009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927965#comment-16927965
]
Hudson commented on HBASE-23009:
Results for branch branch-2
[build #2251 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2251/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2251//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2251//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2251//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestSnapshotScannerHDFSAclController is broken on branch-2
> --
>
> Key: HBASE-23009
> URL: https://issues.apache.org/jira/browse/HBASE-23009
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Affects Versions: 2.3.0
>Reporter: Peter Somogyi
>Assignee: Yi Mei
>Priority: Major
> Fix For: 2.3.0
>
>
> TestSnapshotScannerHDFSAclController.testCleanArchiveTableDir always fails on
> branch-2.
> {noformat}
> java.lang.AssertionError at
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testCleanArchiveTableDir(TestSnapshotScannerHDFSAclController.java:745)
> {noformat}
> Test run:
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/4148/testReport/junit/org.apache.hadoop.hbase.security.access/TestSnapshotScannerHDFSAclController/testCleanArchiveTableDir/]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927960#comment-16927960
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #104 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/104/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/104//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/104//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/104//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/104//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11
Apache-HBase commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-530532953 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 49s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 7m 4s | master passed | | :green_heart: | compile | 3m 51s | master passed | | :green_heart: | shadedjars | 5m 41s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 3m 26s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 6m 12s | the patch passed | | :green_heart: | compile | 4m 0s | the patch passed | | :green_heart: | javac | 4m 0s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | :broken_heart: | shadedjars | 6m 2s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 20m 11s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 3m 31s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 181m 59s | root in the patch failed. | | :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 251m 4s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDroppedTables | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/593 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux b67760cb5248 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh | | git revision | master / b20d9b9d0e | | Default Java | 1.8.0_181 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/artifact/out/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/testReport/ | | Max. process+thread count | 4713 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23014) Should not show split parent regions in hbck report UI
[
https://issues.apache.org/jira/browse/HBASE-23014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927939#comment-16927939
]
Hudson commented on HBASE-23014:
Results for branch branch-2.1
[build #1589 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1589/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1589//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1589//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1589//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1589//console].
> Should not show split parent regions in hbck report UI
> --
>
> Key: HBASE-23014
> URL: https://issues.apache.org/jira/browse/HBASE-23014
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: 2019-09-11 09-11-47屏幕截图.png
>
>
> Now the split parent region is showed in Inconsistent Regions and Region
> Holes. Attached a screen for this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23000) Fix all consistently failing tests in branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927935#comment-16927935
]
HBase QA commented on HBASE-23000:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
48s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
37s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} branch-1.3 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
12s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} branch-1.3 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
32s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
28s{color} | {color:green} branch-1.3 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
12s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 6s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.1 2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 46s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 7s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/608 |
| JIRA Issue | HBASE-23000 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f6f7512ed469 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-608/out/precommit/personality/provid
[GitHub] [hbase] Apache-HBase commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3
Apache-HBase commented on issue #608: [HBASE-23000] Backport HBASE-18150 to branch-1.3 URL: https://github.com/apache/hbase/pull/608#issuecomment-530526838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 48s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.3 Compile Tests _ | | :green_heart: | mvninstall | 7m 37s | branch-1.3 passed | | :green_heart: | compile | 0m 40s | branch-1.3 passed | | :green_heart: | checkstyle | 1m 36s | branch-1.3 passed | | :broken_heart: | shadedjars | 0m 12s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 42s | branch-1.3 passed | | :blue_heart: | spotbugs | 2m 32s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 28s | branch-1.3 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 1m 45s | the patch passed | | :green_heart: | compile | 0m 41s | the patch passed | | :green_heart: | javac | 0m 41s | the patch passed | | :green_heart: | checkstyle | 1m 39s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 12s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 10m 6s | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | :green_heart: | javadoc | 0m 35s | the patch passed | | :green_heart: | findbugs | 2m 32s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 101m 46s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 135m 7s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.cleaner.TestSnapshotFromMaster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/608 | | JIRA Issue | HBASE-23000 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f6f7512ed469 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-608/out/precommit/personality/provided.sh | | git revision | branch-1.3 / 64c0ac5 | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/branch-shadedjars.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/testReport/ | | Max. process+thread count | 4004 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #595: HBASE-22971 Deprecated RSGroupAdminEndpoint and make RSGroup feature …
Apache-HBase commented on issue #595: HBASE-22971 Deprecated RSGroupAdminEndpoint and make RSGroup feature … URL: https://github.com/apache/hbase/pull/595#issuecomment-530521592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 8 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | :green_heart: | mvninstall | 6m 53s | HBASE-22514 passed | | :green_heart: | compile | 1m 4s | HBASE-22514 passed | | :green_heart: | checkstyle | 1m 35s | HBASE-22514 passed | | :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 43s | HBASE-22514 passed | | :blue_heart: | spotbugs | 5m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 7s | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 24s | the patch passed | | :green_heart: | compile | 0m 58s | the patch passed | | :green_heart: | javac | 0m 58s | the patch passed | | :green_heart: | checkstyle | 1m 31s | hbase-server: The patch generated 0 new + 174 unchanged - 2 fixed = 174 total (was 176) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 12s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 35s | the patch passed | | :green_heart: | findbugs | 5m 44s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 165m 35s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 230m 32s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | hadoop.hbase.regionserver.TestRegionOpen | | | hadoop.hbase.master.TestMetaFixer | | | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | hadoop.hbase.util.TestHBaseFsckReplication | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/595 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 33abced74453 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-595/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / ce72633e88 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/4/testReport/ | | Max. process+thread count | 4590 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] caroliney14 opened a new pull request #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary
caroliney14 opened a new pull request #612: HBASE-22804 Provide an API to get list of successful regions and total expected regions in Canary URL: https://github.com/apache/hbase/pull/612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position
[
https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927847#comment-16927847
]
HBase QA commented on HBASE-22969:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} prototool {color} | {color:blue} 0m
0s{color} | {color:blue} prototool was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
53s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
8s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
56s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 56s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
42s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{co
[jira] [Comment Edited] (HBASE-23015) branch-1 hbase-server, testing util, and shaded testing util need jackson
[
https://issues.apache.org/jira/browse/HBASE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927842#comment-16927842
]
Sean Busbey edited comment on HBASE-23015 at 9/11/19 5:30 PM:
--
bq. Just to confirm, each module(except hbase-rest) would have to use Gson
directly as hbase-thirdparty isn't available to branch-1.
no, we should use the hbase-thirdparty version of GSON. we should be able to
use it just fine. [we should be able to reference the 2.2.1 release of
hbase-shaded-miscellaneous|https://search.maven.org/artifact/org.apache.hbase.thirdparty/hbase-shaded-miscellaneous/2.2.1/jar]
i.e.
{code}
org.apache.hbase.thirdparty
hbase-shaded-miscellaneous
2.2.1
{code}
and then use the classes in the {{org.apache.hbase.thirdparty.com.google.gson}}
package.
was (Author: busbey):
bq. Just to confirm, each module(except hbase-rest) would have to use Gson
directly as hbase-thirdparty isn't available to branch-1.
no, we should use the hbase-thirdparty version of GSON. we should be able to
use it just fine. [we should be able to reference the 2.2.1 release of
hbase-shaded-miscellaneous|org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:2.2.1]
i.e.
{code}
org.apache.hbase.thirdparty
hbase-shaded-miscellaneous
2.2.1
{code}
and then use the classes in the {{org.apache.hbase.thirdparty.com.google.gson}}
package.
> branch-1 hbase-server, testing util, and shaded testing util need jackson
> --
>
> Key: HBASE-23015
> URL: https://issues.apache.org/jira/browse/HBASE-23015
> Project: HBase
> Issue Type: Bug
> Components: Client, shading
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Viraj Jasani
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-23015.branch-1.000.patch
>
>
> HBASE-22728 moved out jackson transitive dependencies. mostly good, but
> moving jackson2 to provided in hbase-server broke few things
> testing-util needs a transitive jackson 2 in order to start the minicluster,
> currently fails with CNFE for {{com.fasterxml.jackson.databind.ObjectMapper}}
> when trying to initialize the master.
> shaded-testing-util needs a relocated jackson 2 for the same reason
> it's not used for any of the mapreduce stuff in hbase-server, so
> {{hbase-shaded-server}} for that purpose should be fine. But it is used by
> {{WALPrettyPrinter}} and some folks might expect that to work from that
> artifact since it is present.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927841#comment-16927841 ] Rushabh S Shah edited comment on HBASE-22874 at 9/11/19 5:30 PM: - [~busbey] [~Apache9][~gjacoby] could you guys please help reviewing the PR. I would like to include this change in 1.3.6 release. Thank you ! Here is the link to PR: https://github.com/apache/hbase/pull/580 was (Author: shahrs87): [~busbey] [~Apache9][~gjacoby] could you guys please help reviewing the PR. I would like to include this change in 1.3.6 release. Thank you ! > Define a public interface for Canary and move existing implementation to > LimitedPrivate > --- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Assignee: Rushabh S Shah >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 2.1.7, 2.2.2, 1.4.12 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927841#comment-16927841 ] Rushabh S Shah commented on HBASE-22874: [~busbey] [~Apache9][~gjacoby] could you guys please help reviewing the PR. I would like to include this change in 1.3.6 release. Thank you ! > Define a public interface for Canary and move existing implementation to > LimitedPrivate > --- > > Key: HBASE-22874 > URL: https://issues.apache.org/jira/browse/HBASE-22874 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Duo Zhang >Assignee: Rushabh S Shah >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 2.1.7, 2.2.2, 1.4.12 > > > It can be marked as IA.LimitedPrivate(TOOLS). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23015) branch-1 hbase-server, testing util, and shaded testing util need jackson
[
https://issues.apache.org/jira/browse/HBASE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927842#comment-16927842
]
Sean Busbey commented on HBASE-23015:
-
bq. Just to confirm, each module(except hbase-rest) would have to use Gson
directly as hbase-thirdparty isn't available to branch-1.
no, we should use the hbase-thirdparty version of GSON. we should be able to
use it just fine. [we should be able to reference the 2.2.1 release of
hbase-shaded-miscellaneous|org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:2.2.1]
i.e.
{code}
org.apache.hbase.thirdparty
hbase-shaded-miscellaneous
2.2.1
{code}
and then use the classes in the {{org.apache.hbase.thirdparty.com.google.gson}}
package.
> branch-1 hbase-server, testing util, and shaded testing util need jackson
> --
>
> Key: HBASE-23015
> URL: https://issues.apache.org/jira/browse/HBASE-23015
> Project: HBase
> Issue Type: Bug
> Components: Client, shading
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Viraj Jasani
>Priority: Blocker
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-23015.branch-1.000.patch
>
>
> HBASE-22728 moved out jackson transitive dependencies. mostly good, but
> moving jackson2 to provided in hbase-server broke few things
> testing-util needs a transitive jackson 2 in order to start the minicluster,
> currently fails with CNFE for {{com.fasterxml.jackson.databind.ObjectMapper}}
> when trying to initialize the master.
> shaded-testing-util needs a relocated jackson 2 for the same reason
> it's not used for any of the mapreduce stuff in hbase-server, so
> {{hbase-shaded-server}} for that purpose should be fine. But it is used by
> {{WALPrettyPrinter}} and some folks might expect that to work from that
> artifact since it is present.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics
virajjasani commented on issue #611: HBASE-22903 : Table to RegionStatesCount metrics URL: https://github.com/apache/hbase/pull/611#issuecomment-530481449 Please review @saintstack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani opened a new pull request #611: HBASE-22903 : Table to RegionStatesCount metrics
virajjasani opened a new pull request #611: HBASE-22903 : Table to RegionStatesCount metrics URL: https://github.com/apache/hbase/pull/611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323339774 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt ## @@ -0,0 +1,26 @@ +Apache HBase - Kafka Model Review comment: no ".txt" in the name, just NOTICE This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323339985 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt ## @@ -0,0 +1,26 @@ +Apache HBase - Kafka Model +Copyright 2019 The Apache Software Foundation + Review comment: The tool that generates the final NOTICE file should get the project name and the copyright notice on its own. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323339591 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/LICENSE.txt ## @@ -0,0 +1,272 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323340269 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt ## @@ -0,0 +1,26 @@ +Apache HBase - Kafka Model +Copyright 2019 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + + +Apache HBase - Kafka Model contained works + +This product contains additional works that are distributed under licenses +other than Apache Software License Version 2. See LICENSE for full details + + +This product includes the SLF4J API Module Review comment: are these things that end up in the jar file for hbase-kafka-model? it doesn't seem like we should. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323339177 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/LICENSE.txt ## @@ -0,0 +1,272 @@ + Review comment: this file should be name LICENSE (no ".txt") This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323339056 ## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/LICENSE.txt ## @@ -0,0 +1,272 @@ + + Apache License Review comment: a LICENSE in append-resources shouldn't need the ALv2 text, because the tool that generates the file should start with that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323363181 ## File path: spark/hbase-spark-it/src/main/appended-resources/META-INF/LICENSE.txt ## @@ -0,0 +1,4498 @@ +Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323361814 ## File path: kafka/hbase-kafka-proxy/src/main/appended-resources/META-INF/LICENSE.txt ## @@ -0,0 +1,3610 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation agains
[GitHub] [hbase-connectors] busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0.
busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323362288 ## File path: kafka/hbase-kafka-proxy/src/main/appended-resources/META-INF/LICENSE.txt ## @@ -0,0 +1,3610 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation agains
[jira] [Resolved] (HBASE-23014) Should not show split parent regions in hbck report UI
[ https://issues.apache.org/jira/browse/HBASE-23014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-23014. --- Fix Version/s: 2.2.2 2.1.7 2.3.0 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.1. Did merge because looks like this work happened because I didn't do it right first time through. Thanks [~zghaobac] > Should not show split parent regions in hbck report UI > -- > > Key: HBASE-23014 > URL: https://issues.apache.org/jira/browse/HBASE-23014 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: 2019-09-11 09-11-47屏幕截图.png > > > Now the split parent region is showed in Inconsistent Regions and Region > Holes. Attached a screen for this. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] saintstack commented on issue #609: HBASE-23014 Should not show split parent regions in hbck report UI
saintstack commented on issue #609: HBASE-23014 Should not show split parent regions in hbck report UI URL: https://github.com/apache/hbase/pull/609#issuecomment-530476757 Pushed to branch-2.1+ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack merged pull request #609: HBASE-23014 Should not show split parent regions in hbck report UI
saintstack merged pull request #609: HBASE-23014 Should not show split parent regions in hbck report UI URL: https://github.com/apache/hbase/pull/609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23012) Release 1.3.6
[ https://issues.apache.org/jira/browse/HBASE-23012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927811#comment-16927811 ] Rushabh S Shah commented on HBASE-23012: We have few consistent tests failing in branch-1.3 and I would like to get that fix in the release. https://issues.apache.org/jira/browse/HBASE-23000 I have PR ready for review. Thanks ! > Release 1.3.6 > - > > Key: HBASE-23012 > URL: https://issues.apache.org/jira/browse/HBASE-23012 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 1.3.6 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-23000) Fix all consistently failing tests in branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-23000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rushabh S Shah updated HBASE-23000:
---
Priority: Blocker (was: Major)
> Fix all consistently failing tests in branch-1.3
>
>
> Key: HBASE-23000
> URL: https://issues.apache.org/jira/browse/HBASE-23000
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 1.3.6
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Blocker
>
> Flaky test report:
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-1.3/Flaky_20Test_20Report/dashboard.html#job_2
> In last 30 builds this test failed all 30 times.
> Here is the stack trace:
> {noformat}
> Stacktrace
> java.io.IOException: Shutting down
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> Caused by: java.lang.RuntimeException: Master not initialized after 20ms
> seconds
> at
> org.apache.hadoop.hbase.fs.TestBlockReorder.testBlockLocation(TestBlockReorder.java:428)
> {noformat}
> Link to latest jenkins build:
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-1.3/9351/testReport/org.apache.hadoop.hbase.fs/TestBlockReorder/testBlockLocation/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23006) RSGroupBasedLoadBalancer should also try to place replicas for the same region to different region servers
[
https://issues.apache.org/jira/browse/HBASE-23006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927745#comment-16927745
]
Hudson commented on HBASE-23006:
Results for branch branch-2
[build #2250 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2250/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2250//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2250//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2250//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RSGroupBasedLoadBalancer should also try to place replicas for the same
> region to different region servers
> --
>
> Key: HBASE-23006
> URL: https://issues.apache.org/jira/browse/HBASE-23006
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-23006-UT.patch
>
>
> Found this when implementing HBASE-22971. TestSCPWithReplicas fails when
> RSGroupBasedLoadBalancer is enabled.
> And this can be reproduced by a UT on master branch too. I think the problem
> is that in RSGroupBasedLoadBalancer.retainAssignment we do not consider
> region replicas.
> We should fix this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23006) RSGroupBasedLoadBalancer should also try to place replicas for the same region to different region servers
[
https://issues.apache.org/jira/browse/HBASE-23006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927743#comment-16927743
]
Hudson commented on HBASE-23006:
Results for branch branch-2.2
[build #597 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/597/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/597//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/597//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/597//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RSGroupBasedLoadBalancer should also try to place replicas for the same
> region to different region servers
> --
>
> Key: HBASE-23006
> URL: https://issues.apache.org/jira/browse/HBASE-23006
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-23006-UT.patch
>
>
> Found this when implementing HBASE-22971. TestSCPWithReplicas fails when
> RSGroupBasedLoadBalancer is enabled.
> And this can be reproduced by a UT on master branch too. I think the problem
> is that in RSGroupBasedLoadBalancer.retainAssignment we do not consider
> region replicas.
> We should fix this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position
[
https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udai Bhan Kashyap updated HBASE-22969:
--
Attachment: HBASE-22969.0008.patch
Status: Patch Available (was: Open)
> A new binary component comparator(BinaryComponentComparator) to perform
> comparison of arbitrary length and position
> ---
>
> Key: HBASE-22969
> URL: https://issues.apache.org/jira/browse/HBASE-22969
> Project: HBase
> Issue Type: Improvement
> Components: Filters
>Reporter: Udai Bhan Kashyap
>Assignee: Udai Bhan Kashyap
>Priority: Minor
> Attachments: HBASE-22969.0003.patch, HBASE-22969.0004.patch,
> HBASE-22969.0005.patch, HBASE-22969.0006.patch, HBASE-22969.0007.patch,
> HBASE-22969.0008.patch, HBASE-22969.HBASE-22969.0001.patch,
> HBASE-22969.master.0001.patch
>
>
> Lets say you have composite key: a+b+c+d. And for simplicity assume that
> a,b,c, and d all are 4 byte integers.
> Now, if you want to execute a query which is semantically same to following
> sql:
> {{"SELECT * from table where a=1 and b > 10 and b < 20 and c > 90 and c < 100
> and d=1"}}
> The only choice you have is to do client side filtering. That could be lots
> of unwanted data going through various software components and network.
> Solution:
> We can create a "component" comparator which takes the value of the
> "component" and its relative position in the key to pass the 'Filter'
> subsystem of the server:
> {code}
> FilterList filterList = new FilterList(FilterList.Operator.MUST_PASS_ALL);
> int bOffset = 4;
> byte[] b10 = Bytes.toBytes(10);
> Filter b10Filter = new RowFilter(CompareFilter.CompareOp.GREATER,
> new BinaryComponentComparator(b10,bOffset));
> filterList.addFilter(b10Filter);
> byte[] b20 = Bytes.toBytes(20);
> Filter b20Filter = new RowFilter(CompareFilter.CompareOp.LESS,
> new BinaryComponentComparator(b20,bOffset));
> filterList.addFilter(b20Filter);
> int cOffset = 8;
> byte[] c90 = Bytes.toBytes(90);
> Filter c90Filter = new RowFilter(CompareFilter.CompareOp.GREATER,
> new BinaryComponentComparator(c90,cOffset));
> filterList.addFilter(c90Filter);
> byte[] c100 = Bytes.toBytes(100);
> Filter c100Filter = new RowFilter(CompareFilter.CompareOp.LESS,
> new BinaryComponentComparator(c100,cOffset));
> filterList.addFilter(c100Filter);
> in dOffset = 12;
> byte[] d1 = Bytes.toBytes(1);
> Filter dFilter = new RowFilter(CompareFilter.CompareOp.EQUAL,
> new BinaryComponentComparator(d1,dOffset));
> filterList.addFilter(dFilter);
> //build start and end key for scan
> int aOffset = 0;
> byte[] startKey = new byte[16]; //key size with four ints
> Bytes.putInt(startKey,aOffset,1); //a=1
> Bytes.putInt(startKey,bOffset,11); //b=11, takes care of b > 10
> Bytes.putInt(startKey,cOffset,91); //c=91,
> Bytes.putInt(startKey,dOffset,1); //d=1,
> byte[] endKey = new byte[16];
> Bytes.putInt(endKey,aOffset,1); //a=1
> Bytes.putInt(endKey,bOffset,20); //b=20, takes care of b < 20
> Bytes.putInt(endKey,cOffset,100); //c=100,
> Bytes.putInt(endKey,dOffset,1); //d=1,
> //setup scan
> Scan scan = new Scan(startKey,endKey);
> scan.setFilter(filterList);
> //The scanner below now should give only desired rows.
> //No client side filtering is required.
> ResultScanner scanner = table.getScanner(scan);
> {code}
> The comparator can be used with any filter which makes use of
> ByteArrayComparable. Most notably it can be used with ValueFilter to filter
> out KV based on partial comparison of 'values' :
> {code}
> byte[] partialValue = Bytes.toBytes("partial_value");
> int partialValueOffset =
> Filter partialValueFilter = new
> ValueFilter(CompareFilter.CompareOp.GREATER,
> new BinaryComponentComparator(partialValue,partialValueOffset));
> {code}
> Which in turn can be combined with RowFilter to create a poweful predicate:
> {code}
> RowFilter rowFilter = new RowFilter(GREATER, new
> BinaryComponentComparator(Bytes.toBytes("a"),1);
> FilterLiost fl = new FilterList
> (MUST_PASS_ALL,rowFilter,partialValueFilter);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
