[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741263#comment-17741263
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1257190622
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
Renamed `overrideUmask` into `umask` to avoid confusion.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
> {code:xml}
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741056#comment-17741056 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255894077 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: > I'm not sure "override" means the same thing in both cases. If I'm following this, in the other cases the override replaces the existing GIDs, UIDs, etc. set on the files being added to the assembly. In this case it's not doing that. Rather it's changing the behavior of the plugin. I meant the following Assembly plugin configuration options: * `overrideUid` * `overrideUserName` * `overrideGid` * `overrideGroupName` are similar to this pull request, because instead of setting these values in Assembly plugin configuration, they had to be a part of respective sections of assembly descriptor - just like `fileMode` and `directoryMode` are part of `fileSet` section of assembly descriptor. Unfortunately, that change was more complex and required changes in API of Plexus Archiver (which I was working on). It seems that maintainers of Assembly plugin decided to chose simpler (but less generic / agile) path, which is the same as this pull request suggests. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741052#comment-17741052 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255878013 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Maven Assembly Plugin 3.6.0 is not compatible with older version of Plexus Archiver (that was the first thing I tried to workaround this bug), so there is no way to "revert to old version" of Plexus Archiver when using Maven Assembly Plugin 3.6.0. Instead my team has to stay on 3.5.0 version of Maven Assembly Plugin (which cases some "false" warnings when used with Maven 3.9.x). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741051#comment-17741051 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255878013 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Maven Assembly Plugin 3.6.0 is not compatible with older version of Plexus Archiver (that was the first thing I tried to workaround this bug), so there is no way to "revert to old version" of Plexus Archiver when using Maven Assembly Plugin 3.6.0. Instead my team has to stay on 3.5.9 version of Maven Assembly Plugin (which cases some false warnings when used with Maven 3.9.x). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741050#comment-17741050 ] ASF GitHub Bot commented on MASSEMBLY-791: -- elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255874221 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: I'm not sure "override" means the same thing in both cases. If I'm following this, in the other cases the override replaces the existing GIDs, UIDs, etc. set on the files being added to the assembly. In this case it's not doing that. Rather it's changing the behavior of the plugin. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741048#comment-17741048 ] ASF GitHub Bot commented on MASSEMBLY-791: -- elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255871319 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: I do not agree with new public API as a quick workaround. If the bug was introduced by a new version of plexus archiver, then revert to the old version as a workaround until plexus archiver is fixed. New public API needs to be justified on its own merits. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741047#comment-17741047
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255868214
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
Review Comment:
Thanks. Fixed.
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
Fixed
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741040#comment-17741040
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
It overrides umask at Assembly plugin level (i.e. for all files/directories)
which otherwise is implementation specific (can be set by Plexus Archiver under
some conditions or can be undefined), but is still plugin configuration scoped.
Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please. `override` word means here overriding of what Plexus
Archiver does under the hood and not overriding per file/directory attribute. I
understand that `set` is more natural... do you find `umask` a better name than
`overrideUmask`?
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741038#comment-17741038
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
It overrides umask at Assembly plugin level (i.e. for all files/directories)
which otherwise is implementation specific (can be set by Plexus Archiver under
some conditions or can be undefined), but is still plugin configuration scoped.
Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please. `override` word means here overriding of what Plexus
Archiver does under the hood and not overriding per file/directory attribute.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741033#comment-17741033
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
It overrides umask at Assembly plugin level (i.e. for all files/directories)
which otherwise is implementation specific (can be set by Plexus Archiver under
some conditions or can be undefined), but is still plugin configuration scoped.
Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please. `Override` means here overriding of what Plexus Archiver
does under the hood and not per file/directory (but per Assembly plugin
configuration).
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741031#comment-17741031
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
It overrides umask at Assembly plugin level (i.e. for all files/directories)
which otherwise is implementation specific (can be set by Plexus Archiver under
some conditions or can be undefined), but is still plugin configuration scoped.
Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741030#comment-17741030
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
It overrides umask which otherwise is implementation specific (can be set by
Plexus Archiver under some conditions or can be undefined). Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741028#comment-17741028
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255815210
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
Review Comment:
Yes, it is. It is implementation-specific, because it depends on Plexus
Archiver internals. Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741026#comment-17741026 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255783058 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Maven users use Assembly plugin and not Plexus Archiver, so for the users of Maven it is a bug of Assembly plugin introduced in 3.6.0 version (by migration to the new version of Plexus Archiver). We can provide a quick workaround. Changing Plexus Archiver is too complex. It can require Plexus Archiver API change and change of Assembly plugin. Unfortunately, I won’t be able to help with this kind of changes (I am even not the author of this pull request). Assembly plugin already has `override*` configuration options, which are close to `overrideUmask` configuration option (which are the same sort workaround). IMHO, it’s a trade-off which Maven maintainers decide if they agree or not. I tried my best to provide all details for making informed decision :) > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741016#comment-17741016 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255783058 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Maven users use Assembly plugin and not Plexus Archiver, so for the users of Maven it is a bug of Assembly plugin introduced in 3.6.0 version. We can provide a quick workaround. Changing Plexus Archiver is too complex. It can require Plexus Archiver API change and change of Assembly plugin. Unfortunately, I won’t be able to help with this kind of changes (I am even not the author of this pull request). Assembly plugin already has override* configuration options, which are close to overrideUmask option (which are the same sort workaround). IMHO, it’s a trade-off which Maven maintainers decide if they agree or not. I tried my best to provide all details for that :) > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740982#comment-17740982 ] ASF GitHub Bot commented on MASSEMBLY-791: -- elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255690761 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Additional public API is too heavyweight a solution for a bug that can be fixed at the source. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740981#comment-17740981
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
elharo commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255699674
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
Review Comment:
Is it really implementation specific? Not just that there simply isn't a
mask? How many implementations are there?
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
Review Comment:
an invalid value
such as a negative value
the behavior
That is, it depends on the underlying
of assembly --> the assembly
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+@Parameter
+private Integer overrideUmask;
Review Comment:
Does this actually override a umask or does it set a umask? In the other
cases above — GID, username — these are set on the files and may vary from one
file to the next. umask, however, is not a per-file property. It's applied to
the permissions of the file (which is a per-file property)
##
src/it/projects/bugs/massembly-791/pom.xml:
##
@@ -0,0 +1,64 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+org.apache.maven.plugin.assembly.test
+it-project-parent
+1
+
+
+ org.apache.maven.its
+ massembly-791
+ pom
+ 1.0
+
+
+
2023-06-07T10:18:31Z
Review Comment:
Additional public API is too heavyweight a solution to work is too
heavyweight a solution for a bug that can be fixed at the source.
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
the assembly
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740975#comment-17740975 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255677697 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: 1. It definitely should be fixed in Plexus Archiver (but it is much more complex task). 1. We still can implement `overrideUmask` in Maven Assembly Plugin, because: * It can be used as a quick workaround for the Plexus Archiver bug. * IMHO, we still may need `overrideUmask` configuration option in Maven Assembly Plugin for flexibility, i.e. it's not just quick & dirty workaround. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740971#comment-17740971 ] ASF GitHub Bot commented on MASSEMBLY-791: -- elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255658107 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: I'm losing the plot here, but it sounds like maybe this is something that should be fixed in plexus-archvier instead? If a fix there could avoid adding extra complexity and API here that would be preferable. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740799#comment-17740799 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. `fileMode`/`directoryMode` are defined for `fileSet` (as far as I understand, both `fileMode` and `directoryMode` options of `fileSet` have default values - `0644` and `0755` respectively - so it means that this condition is always true). 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - users of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is sometimes implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. `fileMode`/`directoryMode` are defined for `fileSet` (as far as I understand, both `fileMode` and `directoryMode` options of `fileSet` have default values - `0644` and `0755` respectively - so it means that this condition is always true). 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - users of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is sometimes (see above) implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way).
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740797#comment-17740797 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. `fileMode`/`directoryMode` are defined for `fileSet` (as far as I understand, both `fileMode` and `directoryMode` options of `fileSet` have default values - `0644` and `0755` respectively - so it means that this condition is always true). 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - user of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is (sometimes) implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740796#comment-17740796 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. `fileMode`/`directoryMode` are defined for `fileSet` (as far as I understand, both `fileMode` and `directoryMode` options of `fileSet` have default value, so it means that this condition is always true). 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - user of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is (sometimes) implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740795#comment-17740795 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. `fileMode`/`directoryMode` are defined for `fileSet` (as far as I understand, both `fileMode` and `directoryMode` options of `fileSet` have default value, so it means that this condition is always met). 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - user of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is (sometimes) implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740792#comment-17740792 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. User explicitly specifies `fileMode`/`directoryMode` in assembly descriptor. 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - user of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is (sometimes) implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740791#comment-17740791 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when both conditions are met: 1. User explicitly specifies `fileMode`/`directoryMode` in assembly descriptor. 1. Assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team has) - user of Maven Assembly Plugin can specify `0` as `overrideUmask` configuration option to explicitly override umask which is (sometimes) implicitly used by Plexus Archiver. 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740786#comment-17740786 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. It means that `0` as value of `overrideUmask` configuration option changes behavior of Maven Assembly Plugin only when `project.build.outputTimestamp` maven property is specified. It's sad (complicated for the users of Maven Assembly Plugin) behavior, but it's an issue of Plexus Archiver, which should not apply its default umask to file/directory permissions for the case when user explicitly specifies `fileMode`/`directoryMode` in assembly descriptor and when the assembly format (like `tar`, `zip` and `jar`) supports configuration of file/directory permissions independent of OS. This is the reason `overrideUmask` configuration option of Maven Assembly Plugin is introduced: 1. It helps to workaround bug in Plexus Archiver (the case my team needs). 1. It provides additional flexibility for the users of Maven Assembly Plugin (but they need to realize that not every assembly format - like `dir` - supports setting same permissions as defined in assembly descriptor or source file/directory has in an OS independent way). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740781#comment-17740781 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967 ## src/it/projects/bugs/massembly-791/pom.xml: ## @@ -0,0 +1,64 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.apache.maven.plugin.assembly.test +it-project-parent +1 + + + org.apache.maven.its + massembly-791 + pom + 1.0 + + + 2023-06-07T10:18:31Z Review Comment: Current implementation of Plexus Archiver (used by Maven Assembly Plugin) - `org.codehaus.plexus.archiver.AbstractArchiver` class - applies its default umask (which is `022`) only when `configureReproducibleBuild` method is called. Current version of Maven Assembly Plugin invokes that method only when `project.build.outputTimestamp` maven property is specified. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740780#comment-17740780 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#issuecomment-1624231912 Hi @elharo, Regarding that [comment](https://github.com/apache/maven-assembly-plugin/pull/148#pullrequestreview-1514449650): 1. Integration test for the new configuration option was added. 1. The case when invalid value is specified for `overrideUmask` plugin configuration option is described in Javadoc for `org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo#overrideUmask` field. This Javadoc is used for generation of plugin documentation - plugin.xml - so I find it sufficient. Thank you for your help with review of this pull request. > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740202#comment-17740202
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253097140
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
Fixed
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740200#comment-17740200
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
elharo commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253083133
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
Yes, change the case per Javadoc conventions as published by Oracle. Always
follow the documented rules. Do not copy what some random developer did 15
years ago. "The description begins with a lowercase letter if it is a phrase
(contains no verb), or an uppercase letter if it is a sentence. End the phrase
with a period only if another phrase or sentence follows it."
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740197#comment-17740197
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
Sorry, do you mean changing of case (**m**ask)? It looks like documentation
for all over methods with `@return` Javadoc starts from upper case after
`@return` statement. Is it OK to not follow existing formatting in this case?
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740196#comment-17740196
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
Sorry, do you mean changing of case (**m**ask)? I see all over methods with
`@return` Javadoc start from upper case after `@return` statement. Is it OK to
not follow existing formatting in this case?
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740195#comment-17740195
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
Sorry, do you mean changing of case? I see all over methods with `@return`
Javadoc start from upper case after `@return` statement. Is it OK to not follow
existing formatting in this case?
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740194#comment-17740194
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253072332
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of umask.
Review Comment:
Changed to
```java
/**
* Mask which is applied to permissions of files/directories before they are
put into assembly.
* If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
*/
```
When this option is not configured (`null`), then the umask remains Plexus
Archiver implementation detail (which I know is `022`, but I cannot put it into
documentation of `overrideUmask` configuration option of Maven Assembly Plugin).
IMHO, we can not put `022` as default value of `overrideUmask` configuration
option of Maven Assembly Plugin, because it breaks backward compatibility (in
case someone uses another version of Plexus Archiver - the one which has
different default value of umask option - with Maven Assembly Plugin and
migrates to the new version of Maven Assembly Plugin with this pull request
integrated).
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740193#comment-17740193
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
elharo commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253066482
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Mask which is applied to permissions of files/directories
before they are put into assembly.
Review Comment:
nit: Mask --> mask
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740189#comment-17740189
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253063508
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
+ */
+Integer getOverrideUmask();
Review Comment:
Added default method implementation.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740188#comment-17740188
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253062676
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
Review Comment:
Changed to
```java
/**
* Mask which is applied to permissions of files/directories before they are
put into assembly.
* If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
*/
```
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730932#comment-17730932
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
elharo commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1224195808
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of umask.
Review Comment:
Now that I see the description, does it even matter that this overrides
another value? It would be simpler to just say this sets the umask directly,
and also specify the default value used if one is not specified here. The rest
is implementation detail.
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
Review Comment:
Consistency with existing incomplete code is not a virtue.
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
+ */
+Integer getOverrideUmask();
Review Comment:
You never know who your dependents are. It's easy to add a return null here,
and then you don't break anyone.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730703#comment-17730703 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223487911 ## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends AbstractMojo implements Assem @Parameter private String overrideGroupName; +/** + * Override of umask. Review Comment: I followed description of `overrideGroupName` option here. What about: ```suggestion * Overrides mask which is applied to permissions of files/directories before they are put into assembly. If null then umask option of Plexus Archiver is not configured and default mask defined by Plexus Archiver (022) is used. ``` ? > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730702#comment-17730702 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223487911 ## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends AbstractMojo implements Assem @Parameter private String overrideGroupName; +/** + * Override of umask. Review Comment: I followed description of `overrideGroupName` option here. What about: ```suggestion * Overrides mask which is applied to permissions of files/directories before they are put into assembly. If null then umask option of Plexus Archiver is not configured and default umask defined by Plexus Archiver (022) is used. ``` ? > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730698#comment-17730698 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#issuecomment-1583266597 FYI, this pull request doesn't fixes original issue reported in [MASSEMBLY-791](https://issues.apache.org/jira/browse/MASSEMBLY-791), but fixes (with additional configuration added by the user of plugin (!)) a new issue introduced in 3.6.0 version and leading to the same (unexpected/invalid) behavior as described in [MASSEMBLY-791](https://issues.apache.org/jira/browse/MASSEMBLY-791). > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730697#comment-17730697
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223491868
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
+ */
+Integer getOverrideUmask();
Review Comment:
Sorry, but I failed to understand why we need to support backward
compatibility for this interface. What about
`org.apache.maven.plugins.assembly.AssemblerConfigurationSource#getOverrideGroupName`
method (which I followed in this pull request)?
I was under impression that we need to provide backward compatibility for
plugin configuration from the point of view of POM only - this is the reason
`null` value is supported (and means that respective configuration options is
not defined).
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730696#comment-17730696
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223491868
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
+ */
+Integer getOverrideUmask();
Review Comment:
Sorry, but I failed to understand why we need to support backward
compatibility for this interface. What about
`org.apache.maven.plugins.assembly.AssemblerConfigurationSource#getOverrideGroupName`
method (which I followed in this pull request)?
I was under impression that we need to provide backward compatibility for
plugin configuration from POM point of view only - this is the reason `null`
value is supported (and means that respective configuration options is not
defined).
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730695#comment-17730695
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223491868
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
+ */
+Integer getOverrideUmask();
Review Comment:
Sorry, but I failed to understand why do we need to support backward
compatibility for this interface. What about
`org.apache.maven.plugins.assembly.AssemblerConfigurationSource#getOverrideGroupName`
method (which I followed in this pull request)?
I was under impression that we need to provide backward compatibility for
plugin configuration from POM point of view only - this is the reason `null`
value is supported (and means that respective configuration options is not
defined).
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730694#comment-17730694 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223487911 ## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends AbstractMojo implements Assem @Parameter private String overrideGroupName; +/** + * Override of umask. Review Comment: I followed description of `overrideGroupName` option here. What about: ```suggestion * Overrides mask which is applied to permissions of files/directories before they are put into assembly. ``` ? > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730693#comment-17730693 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223487911 ## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends AbstractMojo implements Assem @Parameter private String overrideGroupName; +/** + * Override of umask. Review Comment: I followed description of `overrideGroupName` option here. What about: ```suggestion * Override of umask applied to permissions of files/directories before they are put into assembly. ``` ? > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730691#comment-17730691
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1223485178
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
Review Comment:
I failed to find the place were `overrideGroupName` option (which I followed
for `overrideUmask`) is described. Could you please point the right one?
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730506#comment-17730506
]
ASF GitHub Bot commented on MASSEMBLY-791:
--
elharo commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1222887655
##
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##
@@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+/**
+ * Override of umask.
Review Comment:
If this shows up in user docs, better description is needed. If it doesn't
no description is needed.
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
+ */
+Integer getOverrideUmask();
Review Comment:
Adding a method to an interface is an incompatible change in public API that
can break existing code. In Java 8 this should have a default implementation to
avoid that.
##
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+/**
+ * @return Override umask.
Review Comment:
What is an override umask? The api doc should explain
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730370#comment-17730370 ] ASF GitHub Bot commented on MASSEMBLY-791: -- gnodet opened a new pull request, #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148 …requested ones. JIRA issue: https://issues.apache.org/jira/browse/MASSEMBLY-791 > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726719#comment-17726719
]
Marat Abrarov commented on MASSEMBLY-791:
-
Hi [~elharo],
With 3.6.0 version of Maven Assembly Plugin {{fileMode}} and {{directoryMode}}
options look to be ignored or transformed (umask applied?). This is the reason
my team delays migration from 3.5.0 to 3.6.0 - we need to generate archives
with specific permissions, like 0777 for specific directory entry in the
generated TAR, but we get 0755 with 3.6.0.
> fileMode not set in dependencySet creating format tar.gz
>
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
>Affects Versions: 2.6
> Environment: Linux and Windows
>Reporter: Rick Poleshuck
>Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
>
>
>
> com.company:dependency-artifact
>
> true
>
>
> *.py
>
>
>
> 0750
> 0750
>
>
>
[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996821#comment-16996821 ] Elliotte Rusty Harold commented on MASSEMBLY-791: - and in 3.6? > fileMode not set in dependencySet creating format tar.gz > > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions >Affects Versions: 2.6 > Environment: Linux and Windows >Reporter: Rick Poleshuck >Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > > > > com.company:dependency-artifact > > true > > > *.py > > > > 0750 > 0750 > > >
