Re: Moving Baloo and Baloo-widgets into KDE SC

[Ivan Čukić]

On Tuesday, 24. December 2013. 22.03.28 Àlex Fiestas wrote:
> As I see it, the nepomuk maintainer says it works better than Nepomuk for
> all cases covered by SC. I don't see any reason not to move forward then.

The truthfulness of Vishesh's claim does not enter into it. If we believe it 
(and I do), it works better *only* for the things that are ported to it. What 
of applications that are not ([1] as an example of a 3rd party app)?

hypothetical: Were we able to make khtml render nothing while preserving api 
and abi because we decided that webkit was better?

Cheerio,
Ivan

[1] http://kde-apps.org/content/show.php?content=145505



-- 
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun

Re: Moving Baloo and Baloo-widgets into KDE SC

[Thomas Lübking]

On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote:

On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote:


I would like baloo to be available in 4.x, with no API 
stability guarantees, ...


As I see it, the nepomuk maintainer says it works better than 
Nepomuk for all 
cases covered by SC. I don't see any reason not to move forward then.


Since actual ABI is not affected (in terms of "things start to crash"), you 
/can/ do whatever you want, but it still has consequences.

The point is, that you virtually cannot make a release that breaks half the 
former nepomuk clients.
You'd get thousands of bug reports about "feature x in application y broken/not 
available" all over the place.

So either nepomuk and baloo can run (and sync) side by side or there eventually 
needs to be some sort of API wrapper and a very LOUD heads-up! to distros to 
relink everything that's not been ported, so to have baloo *completely* replace 
nepomuk - or baloo can still be added to allow devs migrate to it, but in 
general we stick with nepomuk until P-W/2.

This is not about the quality or sheer sanity advance of Baloo, but the bare 
necessities (yes ;-) of release management.

Albert will unleash Shir Khan if we f*** the (for workspace: "minor") release - 
or just revert breaking commits =)

Cheers,
Thomas

(To leave no question: the sooner virtuoso leaves my desktop system, the better)

Re: Moving Baloo and Baloo-widgets into KDE SC

[Àlex Fiestas]

On Tuesday 24 December 2013 19:57:17 Thomas Lübking wrote:
> On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote:
> > On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote:
> >> How does Baloo cooperate with Nepomuk? Note that we have ABI
> >> guarantees, so if the metadata is not shared between running instances
> >> of two services, but applications would have to be ported to the new
> >> ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5.
> > 
> > I'm confused on how not sharing metadata = ABI break? Could you please
> > elaborate?
> 
> If baloo can neither coexist with and talk to nepomuk, nor is 100% ABI
> compatible on clientlib (wrapper?) side, it cannot just replace nepomuk.

Workspace doesn't keep any kind of compatibility so we can do what we please 
there.

In kdelibs, Nepomuk will continue working as it does right now, so 
applications that support it will continue doing so.

Re: Moving Baloo and Baloo-widgets into KDE SC

[Àlex Fiestas]

On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote:
> > As I understand it there are no plans to remove the nepomuk-core or
> > nepomuk-widget libraries. If you switch to Baloo, anything compiled
> > against
> > nepomuk will still run but will act as if nepomuk is disabled. This is
> > something clients previously had to cope with anyway.
> 
> Meaning that everything* that uses nepomuk now (fortunately, not much) will
> stop working properly.
> 
> Either that, or we will have to keep both systems running in-parallel.
> 
> * except the parts Vishesh ports over :)
> 
> I would like baloo to be available in 4.x, with no API stability guarantees,
> so that it can mature for 5.x series. I am not sure about pushing it as a
> nepomuk replacement just jet.
As I see it, the nepomuk maintainer says it works better than Nepomuk for all 
cases covered by SC. I don't see any reason not to move forward then.

> Vishesh, how possible would it be to have dolphin (and others) with support
> for both nepomuk and baloo?
I don't know details but ofc it is possible, but I doubt we have the manpower 
to do it (it will take longer and it will require more maintainership).

Re: Moving Baloo and Baloo-widgets into KDE SC

[Ivan Čukić]

> As I understand it there are no plans to remove the nepomuk-core or
> nepomuk-widget libraries. If you switch to Baloo, anything compiled against
> nepomuk will still run but will act as if nepomuk is disabled. This is
> something clients previously had to cope with anyway.

Meaning that everything* that uses nepomuk now (fortunately, not much) will 
stop working properly.

Either that, or we will have to keep both systems running in-parallel.

* except the parts Vishesh ports over :)

I would like baloo to be available in 4.x, with no API stability guarantees, 
so that it can mature for 5.x series. I am not sure about pushing it as a 
nepomuk replacement just jet.

Vishesh, how possible would it be to have dolphin (and others) with support 
for both nepomuk and baloo?

Cheers,
Ivan


-- 
Make your code readable. Pretend the next person who looks
at your code is a psychopath and they know where you live.
  -- Philip Wadler

Re: Moving Baloo and Baloo-widgets into KDE SC

[David Edmundson]

On 24 Dec 2013 18:57, "Thomas Lübking"  wrote:
>
> On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote:
>>
>> On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote:
>>>
>>> How does Baloo cooperate with Nepomuk? Note that we have ABI
>>> guarantees, so if the metadata is not shared between running instances
>>> of two services, but applications would have to be ported to the new
>>> ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5.
>>>
>>
>> I'm confused on how not sharing metadata = ABI break? Could you please
elaborate?
>
>
> If baloo can neither coexist with and talk to nepomuk, nor is 100% ABI
compatible on clientlib (wrapper?) side, it cannot just replace nepomuk.

As I understand it there are no plans to remove the nepomuk-core or
nepomuk-widget libraries. If you switch to Baloo, anything compiled against
nepomuk will still run but will act as if nepomuk is disabled. This is
something clients previously had to cope with anyway.

David

> Cheers,
> Thomas

Re: Moving Baloo and Baloo-widgets into KDE SC

[Thomas Lübking]

On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote:

On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote:

How does Baloo cooperate with Nepomuk? Note that we have ABI
guarantees, so if the metadata is not shared between running instances
of two services, but applications would have to be ported to the new
ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5.



I'm confused on how not sharing metadata = ABI break? Could you please 
elaborate?


If baloo can neither coexist with and talk to nepomuk, nor is 100% ABI 
compatible on clientlib (wrapper?) side, it cannot just replace nepomuk.

Cheers,
Thomas

Re: Moving Baloo and Baloo-widgets into KDE SC

[Vishesh Handa]

On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote:
> How does Baloo cooperate with Nepomuk? Note that we have ABI
> guarantees, so if the metadata is not shared between running instances
> of two services, but applications would have to be ported to the new
> ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5.
> 

I'm confused on how not sharing metadata = ABI break? Could you please 
elaborate?

-- 
Vishesh Handa

KF5 Update Meeting Minutes 2013-w52

[Kevin Ottens]

Hello everyone,

This is the minutes of the Week 52 KF5 meeting. As usual it has been held on 
#kde-devel at 4pm Paris time.

Were present: alexmerry, apol and myself.

Announcement:
 * I lined up that one to see who would show up, merry christmas!

 * alexmerry has been working on getting jenkins green;
 * he also helps agateau with the readme files and such;

 * agateau created the jobs on Jenkins
 * he also refreshed KF5 diagrams (see http://agateau.com/tmp/kf5)
 * and started to write README.md files for frameworks
 * last but not least he tried to resume discussion on cmake build types 
https://git.reviewboard.kde.org/r/113805/

 * apol has been mostly pushing plasma-framework forward;

 * ervin has been mostly away but trying to get things in order for tp1.

If you got questions, feel free to ask.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114436/
---

(Updated Dec. 24, 2013, 3:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs, David Faure and Frank Reininghaus.


Repository: kdelibs


Description
---

The attached patch changes the WindowModality of all the message/information 
boxes displayed by KIO::JobUiDelegate to Qt::WindowModal instead of 
Qt::ApplicationModal. This prevents a message box in one window from blocking 
all other windows.


Diffs
-

  kio/kio/jobuidelegate.cpp 8534863 

Diff: https://git.reviewboard.kde.org/r/114436/diff/


Testing
---


Thanks,

Dawit Alemayehu

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114436/#review46137
---


This review has been submitted with commit 
7ca1acc9f491bc73585268e66260c0f2d6785020 by Dawit Alemayehu to branch KDE/4.12.

- Commit Hook


On Dec. 13, 2013, 1:53 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114436/
> ---
> 
> (Updated Dec. 13, 2013, 1:53 p.m.)
> 
> 
> Review request for kdelibs, David Faure and Frank Reininghaus.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The attached patch changes the WindowModality of all the message/information 
> boxes displayed by KIO::JobUiDelegate to Qt::WindowModal instead of 
> Qt::ApplicationModal. This prevents a message box in one window from blocking 
> all other windows.
> 
> 
> Diffs
> -
> 
>   kio/kio/jobuidelegate.cpp 8534863 
> 
> Diff: https://git.reviewboard.kde.org/r/114436/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 114479: Select the newly created bookmark folder as the current item

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/#review46135
---


This review has been submitted with commit 
2d83344174fe956dd6df0be6c96e068e5186371c by Dawit Alemayehu to branch KDE/4.12.

- Commit Hook


On Dec. 24, 2013, 2:26 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114479/
> ---
> 
> (Updated Dec. 24, 2013, 2:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 152158
> http://bugs.kde.org/show_bug.cgi?id=152158
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> When a user creates a new bookmark folder in the Add Bookmark dialog, make it 
> the current selected item.
> 
> 
> Diffs
> -
> 
>   kio/bookmarks/kbookmarkdialog.h a746c22 
>   kio/bookmarks/kbookmarkdialog.cc 713ceff 
> 
> Diff: https://git.reviewboard.kde.org/r/114479/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Add new folder w/o patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
> Add new folder w/ patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 114479: Select the newly created bookmark folder as the current item

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/
---

(Updated Dec. 24, 2013, 2:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Bugs: 152158
http://bugs.kde.org/show_bug.cgi?id=152158


Repository: kdelibs


Description
---

When a user creates a new bookmark folder in the Add Bookmark dialog, make it 
the current selected item.


Diffs
-

  kio/bookmarks/kbookmarkdialog.h a746c22 
  kio/bookmarks/kbookmarkdialog.cc 713ceff 

Diff: https://git.reviewboard.kde.org/r/114479/diff/


Testing
---


File Attachments


Add new folder w/o patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png


Thanks,

Dawit Alemayehu

Re: Review Request 114479: Select the newly created bookmark folder as the current item

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/#review46134
---

Ship it!


Ship It!

- David Faure


On Dec. 24, 2013, 2:26 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114479/
> ---
> 
> (Updated Dec. 24, 2013, 2:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 152158
> http://bugs.kde.org/show_bug.cgi?id=152158
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> When a user creates a new bookmark folder in the Add Bookmark dialog, make it 
> the current selected item.
> 
> 
> Diffs
> -
> 
>   kio/bookmarks/kbookmarkdialog.h a746c22 
>   kio/bookmarks/kbookmarkdialog.cc 713ceff 
> 
> Diff: https://git.reviewboard.kde.org/r/114479/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Add new folder w/o patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
> Add new folder w/ patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 114479: Select the newly created bookmark folder as the current item

[Dawit Alemayehu]

> On Dec. 24, 2013, 8:14 a.m., David Faure wrote:
> > kio/bookmarks/kbookmarkdialog.cc, line 350
> > 
> >
> > this method could now call the other one with an empty selectGroup, to 
> > remove the code duplication, right?

Indeed. Fixed.


- Dawit


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/#review46109
---


On Dec. 24, 2013, 6:04 a.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114479/
> ---
> 
> (Updated Dec. 24, 2013, 6:04 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 152158
> http://bugs.kde.org/show_bug.cgi?id=152158
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> When a user creates a new bookmark folder in the Add Bookmark dialog, make it 
> the current selected item.
> 
> 
> Diffs
> -
> 
>   kio/bookmarks/kbookmarkdialog.h a746c22 
>   kio/bookmarks/kbookmarkdialog.cc 713ceff 
> 
> Diff: https://git.reviewboard.kde.org/r/114479/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Add new folder w/o patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
> Add new folder w/ patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 114479: Select the newly created bookmark folder as the current item

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/
---

(Updated Dec. 24, 2013, 2:26 p.m.)


Review request for kdelibs and David Faure.


Changes
---

Updated patch based on feedback.


Bugs: 152158
http://bugs.kde.org/show_bug.cgi?id=152158


Repository: kdelibs


Description
---

When a user creates a new bookmark folder in the Add Bookmark dialog, make it 
the current selected item.


Diffs (updated)
-

  kio/bookmarks/kbookmarkdialog.h a746c22 
  kio/bookmarks/kbookmarkdialog.cc 713ceff 

Diff: https://git.reviewboard.kde.org/r/114479/diff/


Testing
---


File Attachments


Add new folder w/o patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
Add new folder w/ patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png


Thanks,

Dawit Alemayehu

Re: Review Request 114623: kjs: Implement es6 Math.fround

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114623/#review46132
---

Ship it!


what a silly function, but looks okay to me.

- Martin Tobias Holmedahl Sandsmark


On Dec. 22, 2013, 7:34 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114623/
> ---
> 
> (Updated Dec. 22, 2013, 7:34 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> kjs: Implement es6 Math.fround
> 
> 
> Diffs
> -
> 
>   kjs/math_object.h 3d193dd 
>   kjs/math_object.cpp 89835e5 
> 
> Diff: https://git.reviewboard.kde.org/r/114623/diff/
> 
> 
> Testing
> ---
> 
> Basic Mozilla tests:
> 
> Math.fround(0) // 0
> Math.fround(1) // 1
> Math.fround(1.337) // 1.337123977661
> Math.fround(1.5)   // 1.5
> Math.fround(NaN)   // NaN
> Math.fround(Infinity)   // Inf
> Math.fround(-Infinity)   // -Inf
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Review Request 114455: kjs: Implement ES6 Math.imul

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114455/#review46131
---

Ship it!


Ship It!

- Martin Tobias Holmedahl Sandsmark


On Dec. 22, 2013, 7:34 p.m., Bernd Buschinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114455/
> ---
> 
> (Updated Dec. 22, 2013, 7:34 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> kjs: Implement ES6 Math.imul
> 
> I admit I am totally lost here, I need help, the specs just confuse me. The 
> code doesn't look like it does anything useful.
> 
> step 1 to 4 is just getting the values.
> a and b must be a uint32_t.
> 
> 5. Let product be (a * b) modulo 2^32.
> 6. If product ? 2^31, return product - 2^32, otherwise return product.
> 
> (Taken from ES6 draft 08.11.2013)
> 
> This is the part I don't understand at all.
> I am not even sure about the product datatype.
> 
> Also NOTE: the JSC and firefox implementation look totally different and both 
> return different values in highvalue cases, so I rather not trust them.
> 
> 
> Diffs
> -
> 
>   kjs/math_object.h 3d193dd 
>   kjs/math_object.cpp 89835e5 
> 
> Diff: https://git.reviewboard.kde.org/r/114455/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

Re: Moving Baloo and Baloo-widgets into KDE SC

[Christoph Feck]

On Tuesday 24 December 2013 11:28:11 Vishesh Handa wrote:
> Hey guys
> 
> I would like to move Baloo and Baloo-widgets into KDE SC soon. It
> would be nice if someone could review the code. Both the projects
> are in kdereview.
> 
> Baloo is a metadata and search framework which is a successor to
> the Nepomuk project. It primarily provides -
> 
> * An API for searching
> * A way of storing relations between entities
> * File indexing
> * Email and Contact Indexing
> * timeline kioslave
> 
> Baloo-widgets is a direct fork of nepomuk-widgets (history
> preserved). It offers the same widgets and API as nepomuk-widgets.

How does Baloo cooperate with Nepomuk? Note that we have ABI 
guarantees, so if the metadata is not shared between running instances 
of two services, but applications would have to be ported to the new 
ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5.

Christoph Feck (kdepepo)
KDE Quality Team

Moving Baloo and Baloo-widgets into KDE SC

[Vishesh Handa]

Hey guys

I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be 
nice if someone could review the code. Both the projects are in kdereview.

Baloo is a metadata and search framework which is a successor to the Nepomuk 
project. It primarily provides -

* An API for searching
* A way of storing relations between entities
* File indexing
* Email and Contact Indexing
* timeline kioslave

Baloo-widgets is a direct fork of nepomuk-widgets (history preserved). It 
offers the same widgets and API as nepomuk-widgets.

-- 
Vishesh Handa

Re: Review Request 114479: Select the newly created bookmark folder as the current item

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114479/#review46109
---


Much better, but... :)


kio/bookmarks/kbookmarkdialog.h


@since isn't relevant for private methods, which are by definition private.



kio/bookmarks/kbookmarkdialog.cc


this method could now call the other one with an empty selectGroup, to 
remove the code duplication, right?


- David Faure


On Dec. 24, 2013, 6:04 a.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114479/
> ---
> 
> (Updated Dec. 24, 2013, 6:04 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 152158
> http://bugs.kde.org/show_bug.cgi?id=152158
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> When a user creates a new bookmark folder in the Add Bookmark dialog, make it 
> the current selected item.
> 
> 
> Diffs
> -
> 
>   kio/bookmarks/kbookmarkdialog.h a746c22 
>   kio/bookmarks/kbookmarkdialog.cc 713ceff 
> 
> Diff: https://git.reviewboard.kde.org/r/114479/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Add new folder w/o patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png
> Add new folder w/ patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>