Re: Review Request 113052: Remove find_package calls from root kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 3:54 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- As suggested by a kdelibs_cleanups task, move all find_package usages to its own module. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/src/CMakeLists.txt d392cbe experimental/CMakeLists.txt 30a2ff8 experimental/kdeclarative/CMakeLists.txt a4c8982 interfaces/CMakeLists.txt 8a3a2fc kded/CMakeLists.txt d373cdb kdesu/CMakeLists.txt a004c82 kdewidgets/CMakeLists.txt d8b8542 kfile/CMakeLists.txt b62973d khtml/CMakeLists.txt 4ce8fce kinit/CMakeLists.txt 4ae92f3 kio/CMakeLists.txt 18a9962 kioslave/CMakeLists.txt 3b957ae kioslave/http/CMakeLists.txt 97a5a4b kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a kioslave/http/tests/CMakeLists.txt 590e2be kjsembed/CMakeLists.txt 15450b5 knewstuff/CMakeLists.txt 3fccbc6 knotify/CMakeLists.txt 8c3bf50 kpty/CMakeLists.txt 9a79827 kross/CMakeLists.txt 014f5c9 kross/modules/CMakeLists.txt d22a11c staging/CMakeLists.txt 0f608c7 staging/frameworkintegration/CMakeLists.txt 58776b0 staging/frameworkintegration/autotests/CMakeLists.txt c203019 staging/kbookmarks/autotests/CMakeLists.txt b1e031b staging/kde4attic/CMakeLists.txt 44cbc17 staging/kde4attic/src/CMakeLists.txt c7c4373 staging/kde4support/CMakeLists.txt 3f13677 staging/kde4support/src/CMakeLists.txt bab81e6 staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION staging/kio/CMakeLists.txt f9afb6d staging/kio/src/widgets/CMakeLists.txt 35eae7e staging/kjobwidgets/CMakeLists.txt c1e769e staging/kjobwidgets/src/CMakeLists.txt 46d1a6e staging/kwallet/CMakeLists.txt 02c3d7b tier1/itemviews/CMakeLists.txt e13ea0e tier1/kconfig/CMakeLists.txt d6fe4f7 tier1/kidletime/CMakeLists.txt ed801f4 tier1/kidletime/src/CMakeLists.txt b005120 tier1/kjs/CMakeLists.txt 2385027 tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 tier1/kwindowsystem/CMakeLists.txt dde412d tier1/kwindowsystem/src/CMakeLists.txt ea0f313 tier2/kauth/CMakeLists.txt 6fe7f68 tier2/kcrash/CMakeLists.txt 8879784 tier2/ki18n/CMakeLists.txt be337de tier2/knotifications/CMakeLists.txt 5e1b4cc tier2/knotifications/src/CMakeLists.txt 7c52664 tier3/kconfigwidgets/CMakeLists.txt a212a11 tier3/kprintutils/CMakeLists.txt dd8c403 tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112942: Move KDNSSD to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 2, 2013, 4:05 p.m.) Review request for KDE Frameworks. Changes --- removed include of MacroBoolTo01. Repository: kdelibs Description --- Moves KDNSSD to tier2, fixes some missing dependencies. Diffs (updated) - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/ConfigureChecks.cmake dnssd/KDNSSDConfig.cmake.in dnssd/Mainpage.dox dnssd/PACKAGERS dnssd/config-dnssd.h.cmake dnssd/src/CMakeLists.txt dnssd/src/avahi-domainbrowser.cpp dnssd/src/avahi-domainbrowser_p.h dnssd/src/avahi-publicservice.cpp dnssd/src/avahi-publicservice_p.h dnssd/src/avahi-remoteservice.cpp dnssd/src/avahi-remoteservice_p.h dnssd/src/avahi-servicebrowser.cpp dnssd/src/avahi-servicebrowser_p.h dnssd/src/avahi-servicetypebrowser.cpp dnssd/src/avahi-servicetypebrowser_p.h dnssd/src/avahi_entrygroup_interface.h dnssd/src/avahi_entrygroup_interface.cpp dnssd/src/avahi_server_interface.h dnssd/src/avahi_server_interface.cpp dnssd/src/avahi_serviceresolver_interface.h dnssd/src/avahi_serviceresolver_interface.cpp dnssd/src/domainbrowser.h dnssd/src/domainmodel.h dnssd/src/domainmodel.cpp dnssd/src/dummy-domainbrowser.cpp dnssd/src/dummy-publicservice.cpp dnssd/src/dummy-remoteservice.cpp dnssd/src/dummy-servicebrowser.cpp dnssd/src/dummy-servicetypebrowser.cpp dnssd/src/kcm_kdnssd.kcfg dnssd/src/mdnsd-domainbrowser.cpp dnssd/src/mdnsd-domainbrowser_p.h dnssd/src/mdnsd-publicservice.cpp dnssd/src/mdnsd-remoteservice.cpp dnssd/src/mdnsd-responder.h dnssd/src/mdnsd-responder.cpp dnssd/src/mdnsd-sdevent.h dnssd/src/mdnsd-servicebrowser.cpp dnssd/src/mdnsd-servicebrowser_p.h dnssd/src/mdnsd-servicetypebrowser.cpp dnssd/src/mdnsd-servicetypebrowser_p.h dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml dnssd/src/publicservice.h dnssd/src/remoteservice.h dnssd/src/servicebase.h dnssd/src/servicebase.cpp dnssd/src/servicebase_p.h dnssd/src/servicebrowser.h dnssd/src/servicemodel.h dnssd/src/servicemodel.cpp dnssd/src/servicetypebrowser.h dnssd/src/settings.kcfgc tier2/CMakeLists.txt 73175b3 Diff: http://git.reviewboard.kde.org/r/112942/diff/ Testing --- Builds, no tests Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113052: Remove find_package calls from root kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 5:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- As suggested by a kdelibs_cleanups task, move all find_package usages to its own module. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/src/CMakeLists.txt d392cbe experimental/CMakeLists.txt 30a2ff8 experimental/kdeclarative/CMakeLists.txt a4c8982 interfaces/CMakeLists.txt 8a3a2fc kded/CMakeLists.txt d373cdb kdesu/CMakeLists.txt a004c82 kdewidgets/CMakeLists.txt d8b8542 kfile/CMakeLists.txt b62973d khtml/CMakeLists.txt 4ce8fce kinit/CMakeLists.txt 4ae92f3 kio/CMakeLists.txt 18a9962 kioslave/CMakeLists.txt 3b957ae kioslave/http/CMakeLists.txt 97a5a4b kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a kioslave/http/tests/CMakeLists.txt 590e2be kjsembed/CMakeLists.txt 15450b5 knewstuff/CMakeLists.txt 3fccbc6 knotify/CMakeLists.txt 8c3bf50 kpty/CMakeLists.txt 9a79827 kross/CMakeLists.txt 014f5c9 kross/modules/CMakeLists.txt d22a11c staging/CMakeLists.txt 0f608c7 staging/frameworkintegration/CMakeLists.txt 58776b0 staging/frameworkintegration/autotests/CMakeLists.txt c203019 staging/kbookmarks/autotests/CMakeLists.txt b1e031b staging/kde4attic/CMakeLists.txt 44cbc17 staging/kde4attic/src/CMakeLists.txt c7c4373 staging/kde4support/CMakeLists.txt 3f13677 staging/kde4support/src/CMakeLists.txt bab81e6 staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION staging/kio/CMakeLists.txt f9afb6d staging/kio/src/widgets/CMakeLists.txt 35eae7e staging/kjobwidgets/CMakeLists.txt c1e769e staging/kjobwidgets/src/CMakeLists.txt 46d1a6e staging/kwallet/CMakeLists.txt 02c3d7b tier1/itemviews/CMakeLists.txt e13ea0e tier1/kconfig/CMakeLists.txt d6fe4f7 tier1/kidletime/CMakeLists.txt ed801f4 tier1/kidletime/src/CMakeLists.txt b005120 tier1/kjs/CMakeLists.txt 2385027 tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 tier1/kwindowsystem/CMakeLists.txt dde412d tier1/kwindowsystem/src/CMakeLists.txt ea0f313 tier2/kauth/CMakeLists.txt 6fe7f68 tier2/kcrash/CMakeLists.txt 8879784 tier2/ki18n/CMakeLists.txt be337de tier2/knotifications/CMakeLists.txt 5e1b4cc tier2/knotifications/src/CMakeLists.txt 7c52664 tier3/kconfigwidgets/CMakeLists.txt a212a11 tier3/kprintutils/CMakeLists.txt dd8c403 tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112901: Remove weird cmake indirections
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
---
(Updated Oct. 2, 2013, 5:17 p.m.)
Status
--
This change has been marked as submitted.
Review request for Build System and KDE Frameworks.
Repository: kdelibs
Description
---
There were some un-reviewed cmake files where libraries would be defined with a
${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that
didn't follow through.
I propose to remove all the uses for the moment, it's not ever being set anyway.
Diffs
-
interfaces/kimproxy/library/CMakeLists.txt 36e55ef
interfaces/kmediaplayer/CMakeLists.txt 3d1797d
kdesu/CMakeLists.txt e526643
kdewebkit/CMakeLists.txt cdc5835
kfile/CMakeLists.txt e05137d
khtml/CMakeLists.txt 4e1bb80
kio/CMakeLists.txt 25dc6d9
kio/misc/kntlm/CMakeLists.txt fe70a8d
kjsembed/kjsembed/CMakeLists.txt 8ed55c1
knewstuff/src/CMakeLists.txt c313981
knotify/config/CMakeLists.txt 69e1c11
kparts/CMakeLists.txt 6ab9391
kpty/CMakeLists.txt 9a79827
kross/core/CMakeLists.txt 52cd3d4
kross/qts/CMakeLists.txt 1a30bd1
kross/ui/CMakeLists.txt 9e7806d
kutils/CMakeLists.txt 0cb281d
staging/kemoticons/src/core/CMakeLists.txt f7fb463
staging/ktextwidgets/src/CMakeLists.txt 4787c10
Diff: http://git.reviewboard.kde.org/r/112901/diff/
Testing
---
Everything still builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113039: Remove unused includes from KDESu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/#review41141 --- Ship it! Woa amazing :) +1 - Aleix Pol Gonzalez On Oct. 1, 2013, 9:12 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/ --- (Updated Oct. 1, 2013, 9:12 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- There are a whole lot of unused includes in KDESu, this removes them all. Diffs - staging/kdesu/src/client.h 6f425a0 staging/kdesu/src/client.cpp 8a3230a staging/kdesu/src/kcookie.cpp 22a119b staging/kdesu/src/process.cpp 9b27ad6 staging/kdesu/src/ssh.cpp d4f76fe staging/kdesu/src/stub.cpp a9af802 staging/kdesu/src/su.h 8681f2c staging/kdesu/src/su.cpp 8cd5b25 Diff: http://git.reviewboard.kde.org/r/113039/diff/ Testing --- Builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112828: Add a new functions to add unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review41179 --- Ship it! Looks good to me - Aleix Pol Gonzalez On Oct. 2, 2013, 5:14 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/ --- (Updated Oct. 2, 2013, 5:14 p.m.) Review request for Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add a new functions to add unit tests Every framework in KF5 has a macro similar to these, this reduces the unnecessary duplication inside all of the frameworks Diffs - modules/ECMAddTests.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112828/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112772: Create an ecm_mark_as_autotest macro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- (Updated Oct. 3, 2013, 1:53 p.m.) Status -- This change has been discarded. Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Creates a function that will define a unit test with the project name (like it's being done in KF5) and calls ecm_mark_as_test. This should help simplify the tests creation that at the moment is quite verbose. Diffs - modules/ECMMarkAsTest.cmake f1e53e4 Diff: http://git.reviewboard.kde.org/r/112772/diff/ Testing --- Ported some tests in KF5, it worked. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112928: Template files for frameworks
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review41181 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 27, 2013, 3:05 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 27, 2013, 3:05 p.m.) Review request for KDE Frameworks, Kevin Ottens, Alexander Neundorf, and Stephen Kelly. Repository: kdelibs Description --- This patch adds a template/ dir which contains example CMakeLists.txt and FooBarConfig.cmake.in files, based on what exists in current frameworks. Diffs - template/CMakeLists.txt PRE-CREATION template/FooBarConfig.cmake.in PRE-CREATION template/autotests/CMakeLists.txt PRE-CREATION template/setup.sh PRE-CREATION template/src/CMakeLists.txt PRE-CREATION template/src/myclass.h PRE-CREATION template/src/myclass.cpp PRE-CREATION template/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112928/diff/ Testing --- Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112942: Move KDNSSD to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 3, 2013, 4:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDNSSD to tier2, fixes some missing dependencies. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/ConfigureChecks.cmake dnssd/KDNSSDConfig.cmake.in dnssd/Mainpage.dox dnssd/PACKAGERS dnssd/config-dnssd.h.cmake dnssd/src/CMakeLists.txt dnssd/src/avahi-domainbrowser.cpp dnssd/src/avahi-domainbrowser_p.h dnssd/src/avahi-publicservice.cpp dnssd/src/avahi-publicservice_p.h dnssd/src/avahi-remoteservice.cpp dnssd/src/avahi-remoteservice_p.h dnssd/src/avahi-servicebrowser.cpp dnssd/src/avahi-servicebrowser_p.h dnssd/src/avahi-servicetypebrowser.cpp dnssd/src/avahi-servicetypebrowser_p.h dnssd/src/avahi_entrygroup_interface.h dnssd/src/avahi_entrygroup_interface.cpp dnssd/src/avahi_server_interface.h dnssd/src/avahi_server_interface.cpp dnssd/src/avahi_serviceresolver_interface.h dnssd/src/avahi_serviceresolver_interface.cpp dnssd/src/domainbrowser.h dnssd/src/domainmodel.h dnssd/src/domainmodel.cpp dnssd/src/dummy-domainbrowser.cpp dnssd/src/dummy-publicservice.cpp dnssd/src/dummy-remoteservice.cpp dnssd/src/dummy-servicebrowser.cpp dnssd/src/dummy-servicetypebrowser.cpp dnssd/src/kcm_kdnssd.kcfg dnssd/src/mdnsd-domainbrowser.cpp dnssd/src/mdnsd-domainbrowser_p.h dnssd/src/mdnsd-publicservice.cpp dnssd/src/mdnsd-remoteservice.cpp dnssd/src/mdnsd-responder.h dnssd/src/mdnsd-responder.cpp dnssd/src/mdnsd-sdevent.h dnssd/src/mdnsd-servicebrowser.cpp dnssd/src/mdnsd-servicebrowser_p.h dnssd/src/mdnsd-servicetypebrowser.cpp dnssd/src/mdnsd-servicetypebrowser_p.h dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml dnssd/src/publicservice.h dnssd/src/remoteservice.h dnssd/src/servicebase.h dnssd/src/servicebase.cpp dnssd/src/servicebase_p.h dnssd/src/servicebrowser.h dnssd/src/servicemodel.h dnssd/src/servicemodel.cpp dnssd/src/servicetypebrowser.h dnssd/src/settings.kcfgc tier2/CMakeLists.txt 73175b3 Diff: http://git.reviewboard.kde.org/r/112942/diff/ Testing --- Builds, no tests Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113086: KDeclarative cleanup
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- Review request for KDE Frameworks and Plasma. Repository: kdelibs Description --- Reorganizes the file structure as the KF5 module suggest. Adopts newer syntaxes for defining dependencies. Diffs - CMakeLists.txt 3204c11 experimental/CMakeLists.txt e73a8c4 experimental/COPYING 5185fd3 experimental/COPYING.LIB 2d2d780 experimental/CTestConfig.cmake c383ee1 experimental/KDELibsExperimentalNightly.cmake fd53e0c experimental/kdeclarative/CMakeLists.txt 72ea7a2 experimental/kdeclarative/bindings/backportglobal.h fca8ade experimental/kdeclarative/bindings/i18n.cpp 75a67aa experimental/kdeclarative/bindings/i18n_p.h experimental/kdeclarative/bindings/icon.cpp dbdc8fe experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 experimental/kdeclarative/bindings/url.cpp 3031a6f experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 experimental/kdeclarative/configpropertymap.h c9ef3ae experimental/kdeclarative/configpropertymap.cpp 373a655 experimental/kdeclarative/kdeclarative.h experimental/kdeclarative/kdeclarative.cpp 63ae180 experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 experimental/kdeclarative/private/kdeclarative_p.h experimental/kdeclarative/private/kiconprovider.cpp 8506b8b experimental/kdeclarative/private/kiconprovider_p.h experimental/kdeclarative/private/rootcontext.cpp experimental/kdeclarative/private/rootcontext_p.h experimental/kdeclarative/qmlobject.h experimental/kdeclarative/qmlobject.cpp ee81b41 experimental/kdeclarative/qmlobject_p.h experimental/kdeclarative/test/test.cpp 3986b77 experimental/kdeclarative/test/test.qml 060c265 experimental/kdeclarative/test/testobject_p.h staging/CMakeLists.txt 5c5c80c staging/kdeclarative/CMakeLists.txt PRE-CREATION staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION staging/kdeclarative/src/CMakeLists.txt PRE-CREATION staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113086/diff/ Testing --- Builds. There's a test that tests things that are not part either of this module or its dependencies: import Qt 4.7 import org.kde.plasma.core 0.1 as PlasmaCore import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113087: Start preparing KHTML for moving
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113087/#review41192
---
khtml/KHTMLConfig.cmake.in
http://git.reviewboard.kde.org/r/113087/#comment30222
It's missing tons of dependencies, you want to add them later?
khtml/src/CMakeLists.txt
http://git.reviewboard.kde.org/r/113087/#comment30221
We usually put the find_package in the root CMakeLists.txt
(khtml/CMakeLists.txt)
- Aleix Pol Gonzalez
On Oct. 3, 2013, 10:15 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113087/
---
(Updated Oct. 3, 2013, 10:15 p.m.)
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Split into /src and /tests
(file moves not shown as it makes the diff even more impossible to read. Diff
made with --diff-filter=AM)
Remove references to ${CMAKE_SOURCE_DIR}/khtml/ which won't work when
moved
KComboBox - QComboBox
If building standalone load kcookieserver dbus interface from system path
---
Still has quite a few other changes left to do, but this will be easier in
small chunks (diff is already hard to read)
Diffs
-
CMakeLists.txt 3204c11
khtml/CMakeLists.txt 91b55a3
khtml/KHTMLConfig.cmake.in PRE-CREATION
khtml/src/CMakeLists.txt PRE-CREATION
khtml/tests/CMakeLists.txt 0a404d5
khtml/tests/testkhtml.qrc 4cfe54b
khtml/tests/testkhtmlnew.h e7b7205
khtml/tests/testkhtmlnew.cpp 525c9fd
staging/CMakeLists.txt 5c5c80c
Diff: http://git.reviewboard.kde.org/r/113087/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113088: Prepare kpty for moving
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41193 --- kpty/CMakeLists.txt http://git.reviewboard.kde.org/r/113088/#comment30225 Rename to the camel-cased version. kpty/src/CMakeLists.txt http://git.reviewboard.kde.org/r/113088/#comment30223 shouldn't it be KPty? The classes are called KPty at least. kpty/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/113088/#comment30224 You can remove this - Aleix Pol Gonzalez On Oct. 3, 2013, 10:56 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 3, 2013, 10:56 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Prepare kpty for moving Diffs - kpty/CMakeLists.txt ecc296c120a6a7938a703773a63af2534b445897 kpty/ConfigureChecks.cmake kpty/KPTYConfig.cmake.in PRE-CREATION kpty/config-pty.h.cmake kpty/kgrantpty.c kpty/kpty.h kpty/kpty.cpp kpty/kpty_p.h kpty/kptydevice.h kpty/kptydevice.cpp kpty/kptyprocess.h kpty/kptyprocess.cpp kpty/src/CMakeLists.txt PRE-CREATION kpty/tests/CMakeLists.txt 1f39830df5e7eacf3b64ea456c1892c62e53fde5 Diff: http://git.reviewboard.kde.org/r/113088/diff/ Testing --- Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113094: Last CMake changes for KDESu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/#review41201 --- Ship it! staging/kdesu/src/CMakeLists.txt http://git.reviewboard.kde.org/r/113094/#comment30230 I think now it's kpty. Does it build? - Aleix Pol Gonzalez On Oct. 4, 2013, 9:58 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/ --- (Updated Oct. 4, 2013, 9:58 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Some last modifications needed for moving Diffs - staging/kdesu/src/CMakeLists.txt 60f43a6 staging/kdesu/KDESuConfig.cmake.in 44caead staging/kdesu/CMakeLists.txt 93e5eba Diff: http://git.reviewboard.kde.org/r/113094/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113086: KDeclarative cleanup
On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: experimental/kdeclarative/bindings/backportglobal.h, line 24 http://git.reviewboard.kde.org/r/113086/diff/1/?file=193824#file193824line24 backportglobal should be not needed anymore since we don't have qscriptengine anymore (needs to be tested tough) Note that QtScript is still a dependency of the module. On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: experimental/kdeclarative/bindings/i18n.cpp, line 31 http://git.reviewboard.kde.org/r/113086/diff/1/?file=193825#file193825line31 this file (probably the bindings folder too) could go as well I don't think I have the authority to remove anything. Also note that we're supposed to be backwards compatible, at least to some extent... - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41220 --- On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- (Updated Oct. 3, 2013, 8:02 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdelibs Description --- Reorganizes the file structure as the KF5 module suggest. Adopts newer syntaxes for defining dependencies. Diffs - CMakeLists.txt 3204c11 experimental/CMakeLists.txt e73a8c4 experimental/COPYING 5185fd3 experimental/COPYING.LIB 2d2d780 experimental/CTestConfig.cmake c383ee1 experimental/KDELibsExperimentalNightly.cmake fd53e0c experimental/kdeclarative/CMakeLists.txt 72ea7a2 experimental/kdeclarative/bindings/backportglobal.h fca8ade experimental/kdeclarative/bindings/i18n.cpp 75a67aa experimental/kdeclarative/bindings/i18n_p.h experimental/kdeclarative/bindings/icon.cpp dbdc8fe experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 experimental/kdeclarative/bindings/url.cpp 3031a6f experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 experimental/kdeclarative/configpropertymap.h c9ef3ae experimental/kdeclarative/configpropertymap.cpp 373a655 experimental/kdeclarative/kdeclarative.h experimental/kdeclarative/kdeclarative.cpp 63ae180 experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 experimental/kdeclarative/private/kdeclarative_p.h experimental/kdeclarative/private/kiconprovider.cpp 8506b8b experimental/kdeclarative/private/kiconprovider_p.h experimental/kdeclarative/private/rootcontext.cpp experimental/kdeclarative/private/rootcontext_p.h experimental/kdeclarative/qmlobject.h experimental/kdeclarative/qmlobject.cpp ee81b41 experimental/kdeclarative/qmlobject_p.h experimental/kdeclarative/test/test.cpp 3986b77 experimental/kdeclarative/test/test.qml 060c265 experimental/kdeclarative/test/testobject_p.h staging/CMakeLists.txt 5c5c80c staging/kdeclarative/CMakeLists.txt PRE-CREATION staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION staging/kdeclarative/src/CMakeLists.txt PRE-CREATION staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113086/diff/ Testing --- Builds. There's a test that tests things that are not part either of this module or its dependencies: import Qt 4.7 import org.kde.plasma.core 0.1 as PlasmaCore import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113086: KDeclarative cleanup
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: Looking good, lots of incremental improvements, too. I suppose we need to adjust the linker targets in plasma-framework and kde-workspace, too? If you don't have a patch for that as well, let me know, and I'll change it shortly after you've committed this one. Sebastian Kügler wrote: Ow, the test you mention can just be disabled. It probably needs rewriting, at least, it has to move into plasma-framework. Still, we want to have the module unit-tested. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41215 --- On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- (Updated Oct. 3, 2013, 8:02 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdelibs Description --- Reorganizes the file structure as the KF5 module suggest. Adopts newer syntaxes for defining dependencies. Diffs - CMakeLists.txt 3204c11 experimental/CMakeLists.txt e73a8c4 experimental/COPYING 5185fd3 experimental/COPYING.LIB 2d2d780 experimental/CTestConfig.cmake c383ee1 experimental/KDELibsExperimentalNightly.cmake fd53e0c experimental/kdeclarative/CMakeLists.txt 72ea7a2 experimental/kdeclarative/bindings/backportglobal.h fca8ade experimental/kdeclarative/bindings/i18n.cpp 75a67aa experimental/kdeclarative/bindings/i18n_p.h experimental/kdeclarative/bindings/icon.cpp dbdc8fe experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 experimental/kdeclarative/bindings/url.cpp 3031a6f experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 experimental/kdeclarative/configpropertymap.h c9ef3ae experimental/kdeclarative/configpropertymap.cpp 373a655 experimental/kdeclarative/kdeclarative.h experimental/kdeclarative/kdeclarative.cpp 63ae180 experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 experimental/kdeclarative/private/kdeclarative_p.h experimental/kdeclarative/private/kiconprovider.cpp 8506b8b experimental/kdeclarative/private/kiconprovider_p.h experimental/kdeclarative/private/rootcontext.cpp experimental/kdeclarative/private/rootcontext_p.h experimental/kdeclarative/qmlobject.h experimental/kdeclarative/qmlobject.cpp ee81b41 experimental/kdeclarative/qmlobject_p.h experimental/kdeclarative/test/test.cpp 3986b77 experimental/kdeclarative/test/test.qml 060c265 experimental/kdeclarative/test/testobject_p.h staging/CMakeLists.txt 5c5c80c staging/kdeclarative/CMakeLists.txt PRE-CREATION staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION staging/kdeclarative/src/CMakeLists.txt PRE-CREATION staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113086/diff/ Testing --- Builds. There's a test that tests things that are not part either of this module or its dependencies: import Qt 4.7 import org.kde.plasma.core 0.1 as PlasmaCore import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113097: KInit splitting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113097/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Adapts KInit to be moved to its tier, there's still work to do. The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE macro. Also I reorganized the source code in different directories, so it's easier to figure out. Diffs - CMakeLists.txt 3204c11 KDE5PORTING.html 88700b0 cmake/modules/kde4init_dummy.cpp.in cmake/modules/kde4init_win32lib_dummy.cpp.in 0aa704b kded/CMakeLists.txt 5a09a3a kinit/CMakeLists.txt 2e26d91 kinit/ConfigureChecks.cmake kinit/Info.plist.template kinit/Mainpage.dox kinit/README kinit/README.autostart kinit/README.wrapper kinit/autostart.h kinit/autostart.cpp kinit/config-kdeinit.h.cmake kinit/kinit.cpp kinit/kinit_win.cpp kinit/kioslave.cpp kinit/klauncher.h kinit/klauncher.cpp kinit/klauncher_adaptor.h kinit/klauncher_adaptor.cpp kinit/klauncher_cmds.h kinit/klauncher_cmds.cpp kinit/klauncher_main.cpp kinit/kwrapper.cpp d43ffc7 kinit/kwrapper_win.cpp kinit/proctitle.h kinit/proctitle.cpp kinit/shell.cpp ccb42ed kinit/start_kdeinit.c kinit/start_kdeinit_wrapper.c kinit/wrapper.cpp kioslave/http/CMakeLists.txt 5dfcbce staging/CMakeLists.txt 5c5c80c staging/kinit/CMakeLists.txt PRE-CREATION staging/kinit/KInitMacros.cmake PRE-CREATION staging/kinit/src/CMakeLists.txt PRE-CREATION staging/kinit/src/kdeinit/CMakeLists.txt PRE-CREATION staging/kinit/src/kioslave/CMakeLists.txt PRE-CREATION staging/kinit/src/klauncher/CMakeLists.txt PRE-CREATION staging/kinit/src/kshell/CMakeLists.txt PRE-CREATION staging/kinit/src/kwrapper/CMakeLists.txt PRE-CREATION staging/kinit/src/start_kdeinit/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/src/CMakeLists.txt 00c92de Diff: http://git.reviewboard.kde.org/r/113097/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113086: KDeclarative cleanup
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- (Updated Oct. 4, 2013, 4:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdelibs Description --- Reorganizes the file structure as the KF5 module suggest. Adopts newer syntaxes for defining dependencies. Diffs - CMakeLists.txt 3204c11 experimental/CMakeLists.txt e73a8c4 experimental/COPYING 5185fd3 experimental/COPYING.LIB 2d2d780 experimental/CTestConfig.cmake c383ee1 experimental/KDELibsExperimentalNightly.cmake fd53e0c experimental/kdeclarative/CMakeLists.txt 72ea7a2 experimental/kdeclarative/bindings/backportglobal.h fca8ade experimental/kdeclarative/bindings/i18n.cpp 75a67aa experimental/kdeclarative/bindings/i18n_p.h experimental/kdeclarative/bindings/icon.cpp dbdc8fe experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 experimental/kdeclarative/bindings/url.cpp 3031a6f experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 experimental/kdeclarative/configpropertymap.h c9ef3ae experimental/kdeclarative/configpropertymap.cpp 373a655 experimental/kdeclarative/kdeclarative.h experimental/kdeclarative/kdeclarative.cpp 63ae180 experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 experimental/kdeclarative/private/kdeclarative_p.h experimental/kdeclarative/private/kiconprovider.cpp 8506b8b experimental/kdeclarative/private/kiconprovider_p.h experimental/kdeclarative/private/rootcontext.cpp experimental/kdeclarative/private/rootcontext_p.h experimental/kdeclarative/qmlobject.h experimental/kdeclarative/qmlobject.cpp ee81b41 experimental/kdeclarative/qmlobject_p.h experimental/kdeclarative/test/test.cpp 3986b77 experimental/kdeclarative/test/test.qml 060c265 experimental/kdeclarative/test/testobject_p.h staging/CMakeLists.txt 5c5c80c staging/kdeclarative/CMakeLists.txt PRE-CREATION staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION staging/kdeclarative/src/CMakeLists.txt PRE-CREATION staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113086/diff/ Testing --- Builds. There's a test that tests things that are not part either of this module or its dependencies: import Qt 4.7 import org.kde.plasma.core 0.1 as PlasmaCore import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 4, 2013, 5:26 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Changes --- Add documentation in KDE5Porting.html Repository: kdelibs Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs (updated) - KDE5PORTING.html 88700b0 staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 51519a3 staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113008: Clean up KWallet before moving to its own tier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/ --- (Updated Oct. 4, 2013, 5:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs Description --- Makes a bit of sense of the cmake, adds a TODO. Diffs - staging/kwallet/src/CMakeLists.txt 0aaa39e staging/kwallet/src/kwallet_mac.cpp d5d522b Diff: http://git.reviewboard.kde.org/r/113008/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113105: Move KWallet to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs Description --- Does the move, adds the missing dependencies Diffs - staging/CMakeLists.txt afa9c87 tier2/CMakeLists.txt 3d3d2cf tier2/kwallet/CMakeLists.txt e8be3ef tier2/kwallet/KWalletConfig.cmake.in 4dec013 Diff: http://git.reviewboard.kde.org/r/113105/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113110: Move KNotifyConfig to staging
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113110/#review41260 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 4, 2013, 8:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113110/ --- (Updated Oct. 4, 2013, 8:34 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move KNotifyConfig to staging Diffs - knotify/CMakeLists.txt 842bf10 knotify/config/CMakeLists.txt 1d7c3fd knotify/config/knotify-config.h.cmake knotify/config/knotifyconfigactionswidget.h knotify/config/knotifyconfigactionswidget.cpp knotify/config/knotifyconfigactionswidgetbase.ui knotify/config/knotifyconfigelement.h knotify/config/knotifyconfigelement.cpp knotify/config/knotifyconfigwidget.h knotify/config/knotifyconfigwidget.cpp fb4f111 knotify/config/knotifyeventlist.h knotify/config/knotifyeventlist.cpp knotify/tests/CMakeLists.txt 9aae033 knotify/tests/knotifytest.notifyrc knotify/tests/knotifytestui.rc knotify/tests/knotifytestview.ui knotify/tests/knotifytestwindow.h knotify/tests/knotifytestwindow.cpp knotify/tests/main.cpp staging/CMakeLists.txt afa9c87 staging/knotifyconfig/CMakeLists.txt PRE-CREATION staging/knotifyconfig/KNotifyConfigConfig.cmake.in PRE-CREATION staging/knotifyconfig/src/CMakeLists.txt PRE-CREATION staging/knotifyconfig/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113110/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113112: Notify about palette changes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41262 --- Uh, just realized ingenuous doesn't mean what I thought, I guess it's too late in the night, at least my brain noticed a few minutes later. :D Anyway, it was meant as a compliment, now I shut up. :) Have a good weekend guys! - Aleix Pol Gonzalez On Oct. 5, 2013, 12:14 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/ --- (Updated Oct. 5, 2013, 12:14 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler. Repository: kdelibs Description --- Make sure the application can react to changes in the application's defaults regarding palette, when using the kde platform plugin. Diffs - staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 Diff: http://git.reviewboard.kde.org/r/113112/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113105: Move KWallet to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/ --- (Updated Oct. 7, 2013, 10:46 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs Description --- Does the move, adds the missing dependencies Diffs - staging/CMakeLists.txt afa9c87 tier2/CMakeLists.txt 3d3d2cf tier2/kwallet/CMakeLists.txt e8be3ef tier2/kwallet/KWalletConfig.cmake.in 4dec013 Diff: http://git.reviewboard.kde.org/r/113105/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113097: KInit splitting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113097/ --- (Updated Oct. 7, 2013, 11:37 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adapts KInit to be moved to its tier, there's still work to do. The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE macro. Also I reorganized the source code in different directories, so it's easier to figure out. Diffs - CMakeLists.txt 3204c11 KDE5PORTING.html 88700b0 cmake/modules/kde4init_dummy.cpp.in cmake/modules/kde4init_win32lib_dummy.cpp.in 0aa704b kded/CMakeLists.txt 5a09a3a kinit/CMakeLists.txt 2e26d91 kinit/ConfigureChecks.cmake kinit/Info.plist.template kinit/Mainpage.dox kinit/README kinit/README.autostart kinit/README.wrapper kinit/autostart.h kinit/autostart.cpp kinit/config-kdeinit.h.cmake kinit/kinit.cpp kinit/kinit_win.cpp kinit/kioslave.cpp kinit/klauncher.h kinit/klauncher.cpp kinit/klauncher_adaptor.h kinit/klauncher_adaptor.cpp kinit/klauncher_cmds.h kinit/klauncher_cmds.cpp kinit/klauncher_main.cpp kinit/kwrapper.cpp d43ffc7 kinit/kwrapper_win.cpp kinit/proctitle.h kinit/proctitle.cpp kinit/shell.cpp ccb42ed kinit/start_kdeinit.c kinit/start_kdeinit_wrapper.c kinit/wrapper.cpp kioslave/http/CMakeLists.txt 5dfcbce staging/CMakeLists.txt 5c5c80c staging/kinit/CMakeLists.txt PRE-CREATION staging/kinit/KInitMacros.cmake PRE-CREATION staging/kinit/src/CMakeLists.txt PRE-CREATION staging/kinit/src/kdeinit/CMakeLists.txt PRE-CREATION staging/kinit/src/kioslave/CMakeLists.txt PRE-CREATION staging/kinit/src/klauncher/CMakeLists.txt PRE-CREATION staging/kinit/src/kshell/CMakeLists.txt PRE-CREATION staging/kinit/src/kwrapper/CMakeLists.txt PRE-CREATION staging/kinit/src/start_kdeinit/CMakeLists.txt PRE-CREATION tier1/kwindowsystem/src/CMakeLists.txt 00c92de Diff: http://git.reviewboard.kde.org/r/113097/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113142: Move KPty to tier 3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/#review41337 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 7, 2013, 11:04 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/ --- (Updated Oct. 7, 2013, 11:04 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move KPty to tier 3 Diffs - CMakeLists.txt 6a6b5f5 kpty/CMakeLists.txt kpty/KPtyConfig.cmake.in kpty/Mainpage.dox kpty/src/CMakeLists.txt kpty/src/ConfigureChecks.cmake kpty/src/config-pty.h.cmake kpty/src/kgrantpty.c kpty/src/kpty.h kpty/src/kpty.cpp kpty/src/kpty_p.h kpty/src/kptydevice.h kpty/src/kptydevice.cpp kpty/src/kptyprocess.h kpty/src/kptyprocess.cpp kpty/tests/CMakeLists.txt kpty/tests/kptyprocesstest.h kpty/tests/kptyprocesstest.cpp tier3/CMakeLists.txt 53fe81b Diff: http://git.reviewboard.kde.org/r/113142/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113148: Move and clean KBuildsycoca to KService
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41351 --- kded/kbuildsycoca.cpp http://git.reviewboard.kde.org/r/113148/#comment30273 Maybe it could be removed? kded/kbuildsycoca.cpp http://git.reviewboard.kde.org/r/113148/#comment30274 What happens with this? - Aleix Pol Gonzalez On Oct. 7, 2013, 2:43 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 7, 2013, 2:43 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Moved KBuildsyscoca to KService. I have done the moving and the cleaning in different commits, just unified them for reviewboard. Diffs - kded/CMakeLists.txt 4f9133f kded/applications.menu kded/kbuildmimetypefactory.h kded/kbuildmimetypefactory.cpp 2e81ce7 kded/kbuildservicefactory.h kded/kbuildservicefactory.cpp 971f327 kded/kbuildservicegroupfactory.h kded/kbuildservicegroupfactory.cpp 5485b1c kded/kbuildservicetypefactory.h kded/kbuildservicetypefactory.cpp f473cd6 kded/kbuildsycoca.h kded/kbuildsycoca.cpp 8ea2d2e kded/kbuildsycocainterface.h kded/kctimefactory.h kded/kctimefactory.cpp kded/kmimeassociations.h kded/kmimeassociations.cpp kded/ksycocaresourcelist.h kded/tests/CMakeLists.txt ca392d2 kded/tests/kmimeassociationstest.cpp kded/vfolder_menu.h kded/vfolder_menu.cpp staging/kservice/CMakeLists.txt b244731 staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION staging/kservice/tests/CMakeLists.txt 23d4854 Diff: http://git.reviewboard.kde.org/r/113148/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- (Updated Oct. 7, 2013, 3:24 p.m.) Review request for Build System, KDE Frameworks and Sebastian Kügler. Changes --- I forgot to add the Config.cmake files Repository: kdelibs Description --- There are some KF5 frameworks that are used through cmake macros instead of by linking to its libraries. These frameworks install a Macros.cmake file that adds the tools needed to use them. It's not really possible to include those Macros files from other projects at the moment. This patch adds a Config file so these include files can be found using find_package (which is the standard way of finding a framework anyway) Diffs (updated) - staging/kinit/CMakeLists.txt 10c226c staging/kinit/KInitConfig.cmake PRE-CREATION tier2/kdoctools/CMakeLists.txt a74ef92 tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- (Updated Oct. 7, 2013, 3:29 p.m.) Review request for Build System, KDE Frameworks and Sebastian Kügler. Changes --- Properly find the Macros.cmake files Repository: kdelibs Description --- There are some KF5 frameworks that are used through cmake macros instead of by linking to its libraries. These frameworks install a Macros.cmake file that adds the tools needed to use them. It's not really possible to include those Macros files from other projects at the moment. This patch adds a Config file so these include files can be found using find_package (which is the standard way of finding a framework anyway) Diffs (updated) - staging/kinit/CMakeLists.txt 10c226c staging/kinit/KInitConfig.cmake PRE-CREATION tier2/kdoctools/CMakeLists.txt a74ef92 tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- (Updated Oct. 7, 2013, 3:41 p.m.) Status -- This change has been marked as submitted. Review request for Build System, KDE Frameworks and Sebastian Kügler. Repository: kdelibs Description --- There are some KF5 frameworks that are used through cmake macros instead of by linking to its libraries. These frameworks install a Macros.cmake file that adds the tools needed to use them. It's not really possible to include those Macros files from other projects at the moment. This patch adds a Config file so these include files can be found using find_package (which is the standard way of finding a framework anyway) Diffs - staging/kinit/CMakeLists.txt 10c226c staging/kinit/KInitConfig.cmake PRE-CREATION tier2/kdoctools/CMakeLists.txt a74ef92 tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113149/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113155: Port all kde4_add_unit_test uses
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 0a404d5 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113112: Notify about palette changes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/ --- (Updated Oct. 7, 2013, 5:12 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler. Repository: kdelibs Description --- Make sure the application can react to changes in the application's defaults regarding palette, when using the kde platform plugin. Diffs - staging/frameworkintegration/autotests/kdeplatformtheme_unittest.cpp 417e9e1 staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 Diff: http://git.reviewboard.kde.org/r/113112/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113160: Move KDeclarative to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDeclarative to tier3 Also trim down the test so that it uses the module but it doesn't use something from upstream (such as plasma components) Diffs - tier3/CMakeLists.txt 11be8e4 staging/kdeclarative/tests/testobject_p.h staging/kdeclarative/tests/test.qml 060c265 staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 staging/kdeclarative/tests/CMakeLists.txt ad4a7db staging/kdeclarative/src/qmlobject_p.h staging/kdeclarative/src/qmlobject.cpp staging/kdeclarative/src/qmlobject.h staging/kdeclarative/src/private/rootcontext_p.h staging/kdeclarative/src/private/rootcontext.cpp staging/kdeclarative/src/private/kiconprovider_p.h staging/kdeclarative/src/private/kiconprovider.cpp staging/kdeclarative/src/private/kdeclarative_p.h staging/kdeclarative/src/kdeclarative.cpp staging/kdeclarative/src/kdeclarative.h staging/kdeclarative/src/configpropertymap.cpp staging/kdeclarative/src/configpropertymap.h staging/kdeclarative/src/bindings/url.cpp staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp staging/kdeclarative/src/bindings/icon.cpp staging/kdeclarative/src/bindings/i18n_p.h staging/kdeclarative/src/bindings/i18n.cpp staging/kdeclarative/src/bindings/backportglobal.h staging/kdeclarative/src/CMakeLists.txt staging/kdeclarative/KDeclarativeConfig.cmake.in staging/kdeclarative/CMakeLists.txt eefa756 staging/CMakeLists.txt 4f64e8a tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION tier3/kdeclarative/tests/test.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113160/diff/ Testing --- the test starts and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Documents KInit dependencies, updates to the newer executable names and adds a comment regarding things to be looked into. Diffs - staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 staging/kinit/src/kdeinit/kinit.cpp c4a0908 staging/kinit/src/klauncher/CMakeLists.txt 1b173be staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 staging/kinit/src/wrapper.cpp c9d40cc Diff: http://git.reviewboard.kde.org/r/113170/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113173/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Modifies how features are checked. This file has some pre-processor macros that are used to checking for OS features. These are defined with 1 if acceptable and undefined if the feature is not present. These macros are being checked with #if, so the pre-processor will complain whenever it's asked about one of the variables that haven't been defined. This patch adds a defined() first, before checking the value, so the pre-processor doesn't need to consider the variable value, if it's not present. This change makes it possible to read the compilation logs from modules that use KJS. Diffs - tier1/kjs/src/wtf/Platform.h 843cfd2 Diff: http://git.reviewboard.kde.org/r/113173/diff/ Testing --- Builds, KJS tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113174: Cleanup KJsEmbed
/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 4f64e8a staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e Diff: http://git.reviewboard.kde.org/r/113174/diff/ Testing --- Builds, the test case seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113179: Make the runners compile again
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time. This patch tries to port plasma-framework to that new API. Diffs - src/plasma/CMakeLists.txt 411256a src/plasma/private/runnerjobs.cpp d11f7e9 src/plasma/private/runnerjobs_p.h 7fd7076 src/plasma/private/storage.cpp 35b222e src/plasma/runnermanager.cpp 135279e src/plasma/scripting/runnerscript.cpp d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113179: Make the runners compile again
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote:
There's also runner-related code in
src/declarativeimports/{core,runnermodel}, these should be reenabled as
well. Possibly, they also need changes to make built. I had disabled this
after a discussion with Aaron (who has refactored these classes) and
Vishesh, who plans to work on them. I'm not sure what's the most useful, I
can imagine this leading to a lot of conflicts when merging this
refactoring, while the benefits of this patch are then just going away.
Aaron can weigh in here to say what's easiest moving forward. Mirko is the
best person to review the ThreadWeaver API changes you implement. Could you
add him to the reviewers for this request?
thanks...
Well, the only reason I did this was because kickoff in kde-workspace requires
runners as well. If those are not good anymore, maybe it's wiser to disable
them there as well?
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/#review41412
---
On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/
---
(Updated Oct. 8, 2013, 5:14 p.m.)
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
---
Recently there's been some big changes in the ThreadWeaver API. So big that
they break the source compatibility we were supposed to maintain, big time.
This patch tries to port plasma-framework to that new API.
Diffs
-
src/plasma/CMakeLists.txt 411256a
src/plasma/private/runnerjobs.cpp d11f7e9
src/plasma/private/runnerjobs_p.h 7fd7076
src/plasma/private/storage.cpp 35b222e
src/plasma/runnermanager.cpp 135279e
src/plasma/scripting/runnerscript.cpp d5142a2
Diff: http://git.reviewboard.kde.org/r/113179/diff/
Testing
---
Everything builds, including kde-workspace.
Couldn't test it, there's no tests for it or even an application to test it
:/.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/#review41459 --- Ship it! Makes sense, as long as there's a replacement. :) Maybe you should put a note on KDE5Porting.hml - Aleix Pol Gonzalez On Oct. 7, 2013, 5:01 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/ --- (Updated Oct. 7, 2013, 5:01 p.m.) Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description --- They will no longer exist in KF5, and everyone should be using the Nepomuk widgets instead. Diffs - kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadatawidget.h 50ddce9 Diff: http://git.reviewboard.kde.org/r/113153/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 9, 2013, 6:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Repository: kdelibs Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs - KDE5PORTING.html 88700b0 staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 51519a3 staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113160: Move KDeclarative to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/ --- (Updated Oct. 9, 2013, 6:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDeclarative to tier3 Also trim down the test so that it uses the module but it doesn't use something from upstream (such as plasma components) Diffs - tier3/CMakeLists.txt 11be8e4 staging/kdeclarative/tests/testobject_p.h staging/kdeclarative/tests/test.qml 060c265 staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 staging/kdeclarative/tests/CMakeLists.txt ad4a7db staging/kdeclarative/src/qmlobject_p.h staging/kdeclarative/src/qmlobject.cpp staging/kdeclarative/src/qmlobject.h staging/kdeclarative/src/private/rootcontext_p.h staging/kdeclarative/src/private/rootcontext.cpp staging/kdeclarative/src/private/kiconprovider_p.h staging/kdeclarative/src/private/kiconprovider.cpp staging/kdeclarative/src/private/kdeclarative_p.h staging/kdeclarative/src/kdeclarative.cpp staging/kdeclarative/src/kdeclarative.h staging/kdeclarative/src/configpropertymap.cpp staging/kdeclarative/src/configpropertymap.h staging/kdeclarative/src/bindings/url.cpp staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp staging/kdeclarative/src/bindings/icon.cpp staging/kdeclarative/src/bindings/i18n_p.h staging/kdeclarative/src/bindings/i18n.cpp staging/kdeclarative/src/bindings/backportglobal.h staging/kdeclarative/src/CMakeLists.txt staging/kdeclarative/KDeclarativeConfig.cmake.in staging/kdeclarative/CMakeLists.txt eefa756 staging/CMakeLists.txt 4f64e8a tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION tier3/kdeclarative/tests/test.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113160/diff/ Testing --- the test starts and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113174: Cleanup KJsEmbed
kjsembed/examples/kjsconsole/jsconsole.ui kjsembed/examples/kjsconsole/kjs_object_model.h kjsembed/examples/kjsconsole/kjs_object_model.cpp kjsembed/examples/kjsconsole/main.cpp kjsembed/examples/kjsconsole/numberedtextview.h kjsembed/examples/kjsconsole/numberedtextview.cpp f144502 kjsembed/examples/scribble/scribble.js kjsembed/examples/tests/args.js kjsembed/examples/tests/brush.js kjsembed/examples/tests/builtins.js kjsembed/examples/tests/class.js kjsembed/examples/tests/colortest.js kjsembed/examples/tests/conio.js kjsembed/examples/tests/domtest.js kjsembed/examples/tests/events.js kjsembed/examples/tests/fileio.js kjsembed/examples/tests/fonttest.js kjsembed/examples/tests/frame.js kjsembed/examples/tests/gc.js kjsembed/examples/tests/include.js kjsembed/examples/tests/inner.js kjsembed/examples/tests/jsslot.js kjsembed/examples/tests/layout.js kjsembed/examples/tests/library.js kjsembed/examples/tests/listproperties.js kjsembed/examples/tests/matt.js kjsembed/examples/tests/paintertest.js kjsembed/examples/tests/paintevent.js kjsembed/examples/tests/pixmap.js kjsembed/examples/tests/recttest.js kjsembed/examples/tests/settings.js kjsembed/examples/tests/signslots.js kjsembed/examples/tests/statictest.js kjsembed/examples/tests/stylesheet.js kjsembed/examples/tests/svgtest.js kjsembed/examples/tests/system.js kjsembed/examples/tests/test.svg kjsembed/examples/tests/test.ui kjsembed/examples/tests/typecheck.js kjsembed/examples/tests/uitest.js kjsembed/examples/tests/uitest2.js kjsembed/examples/tests/url.js kjsembed/examples/tests/widgettest.js kjsembed/kjscmd/CMakeLists.txt eeb5667 kjsembed/kjscmd/console.js kjsembed/kjscmd/kjscmd.cpp kjsembed/kjscmd/kjscmd.qrc kjsembed/kjsembed/CMakeLists.txt 8089c4b Diff: http://git.reviewboard.kde.org/r/113174/diff/ Testing --- Builds, the test case seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113174: Cleanup KJsEmbed
On Oct. 9, 2013, 4:19 p.m., David Edmundson wrote: kjsembed/kjscmd/kjscmd.cpp, line 78 http://git.reviewboard.kde.org/r/113174/diff/1/?file=200020#file200020line78 this seems to break whitespace for no reason? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/#review41435 --- On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adopt directory organization, naming scheme, cmake structures, documents dependencies. Diffs - kjsembed/kjsembed/fileio.cpp kjsembed/kjsembed/font.h kjsembed/kjsembed/font.cpp kjsembed/kjsembed/image.h kjsembed/kjsembed/image.cpp kjsembed/kjsembed/iosupport.h kjsembed/kjsembed/iosupport.cpp kjsembed/kjsembed/jseventmapper.h kjsembed/kjsembed/jseventmapper.cpp kjsembed/kjsembed/jseventutils.h kjsembed/kjsembed/jseventutils.cpp kjsembed/kjsembed/kjseglobal.h kjsembed/kjsembed/kjseglobal.cpp kjsembed/kjsembed/kjsembed.h 74dfab8 kjsembed/kjsembed/kjsembed.cpp kjsembed/kjsembed/object_binding.h kjsembed/kjsembed/object_binding.cpp kjsembed/kjsembed/pen.h kjsembed/kjsembed/pen.cpp kjsembed/kjsembed/pixmap.h kjsembed/kjsembed/pixmap.cpp kjsembed/kjsembed/point.h kjsembed/kjsembed/point.cpp kjsembed/kjsembed/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 55cc3d3 staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e tier1/kjs/src/wtf/Platform.h 843cfd2 kjsembed/kjsembed/fileio.h kjsembed/kjsembed/filedialog_binding.cpp kjsembed/kjsembed/filedialog_binding.h kjsembed/kjsembed/eventproxy.cpp kjsembed/kjsembed/eventproxy.h kjsembed/kjsembed/dom.cpp kjsembed/kjsembed/dom.h kjsembed/kjsembed/brush.cpp kjsembed/kjsembed/builtins.h kjsembed/kjsembed/builtins.cpp kjsembed/kjsembed/color.h kjsembed/kjsembed/color.cpp kjsembed/kjsembed/brush.h kjsembed/kjsembed/binding_support.cpp kjsembed/kjsembed/binding_support.h kjsembed/kjsembed/application.h kjsembed/kjsembed/application.cpp kjsembed/kjsembed/QBrush_bind.cpp kjsembed/kjsembed/QBrush_bind.h CMakeLists.txt 368584e kjsembed/AUTHORS kjsembed/CMakeLists.txt 6cb6727 kjsembed/Mainpage.dox kjsembed/examples/calc/calc.js kjsembed/examples/calc/calc.ui kjsembed/examples/console/console.js kjsembed/examples/console/console.ui kjsembed/examples/docviewer/docviewer.js kjsembed/examples/docviewer/docviewer.ui kjsembed/examples/fancy/fancy.js kjsembed/examples/grammar/grammar.js kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b kjsembed/examples/kjsconsole/console.h kjsembed/examples/kjsconsole/console.cpp f65f39b kjsembed
Re: Review Request 113174: Cleanup KJsEmbed
On Oct. 9, 2013, 5:22 p.m., Kevin Ottens wrote: kjsembed/examples/kjsconsole/console.cpp, line 35 http://git.reviewboard.kde.org/r/113174/diff/1/?file=199962#file199962line35 Hm actually surprising, where does this include come from? KJS, JSVariableObject.h is where GlobalObject is declared. On Oct. 9, 2013, 5:22 p.m., Kevin Ottens wrote: staging/kjsembed/CMakeLists.txt, line 26 http://git.reviewboard.kde.org/r/113174/diff/1/?file=200102#file200102line26 Hm... if this if really needed? UiTools being declared as a REQUIRED component in the find_package above. Well, I just wanted to make sure Qt5::UiTools was not required, but it probably doesn't make sense since the rest of the modules that depend on KJsEmbed shouldn't be compiled then too. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/#review41456 --- On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adopt directory organization, naming scheme, cmake structures, documents dependencies. Diffs - kjsembed/kjsembed/fileio.cpp kjsembed/kjsembed/font.h kjsembed/kjsembed/font.cpp kjsembed/kjsembed/image.h kjsembed/kjsembed/image.cpp kjsembed/kjsembed/iosupport.h kjsembed/kjsembed/iosupport.cpp kjsembed/kjsembed/jseventmapper.h kjsembed/kjsembed/jseventmapper.cpp kjsembed/kjsembed/jseventutils.h kjsembed/kjsembed/jseventutils.cpp kjsembed/kjsembed/kjseglobal.h kjsembed/kjsembed/kjseglobal.cpp kjsembed/kjsembed/kjsembed.h 74dfab8 kjsembed/kjsembed/kjsembed.cpp kjsembed/kjsembed/object_binding.h kjsembed/kjsembed/object_binding.cpp kjsembed/kjsembed/pen.h kjsembed/kjsembed/pen.cpp kjsembed/kjsembed/pixmap.h kjsembed/kjsembed/pixmap.cpp kjsembed/kjsembed/point.h kjsembed/kjsembed/point.cpp kjsembed/kjsembed/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 55cc3d3 staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e tier1/kjs/src/wtf/Platform.h 843cfd2 kjsembed/kjsembed/fileio.h kjsembed/kjsembed/filedialog_binding.cpp kjsembed/kjsembed/filedialog_binding.h kjsembed/kjsembed/eventproxy.cpp kjsembed/kjsembed/eventproxy.h kjsembed/kjsembed/dom.cpp kjsembed/kjsembed/dom.h kjsembed/kjsembed/brush.cpp kjsembed/kjsembed/builtins.h kjsembed/kjsembed/builtins.cpp kjsembed/kjsembed/color.h kjsembed/kjsembed/color.cpp kjsembed/kjsembed/brush.h kjsembed/kjsembed/binding_support.cpp kjsembed/kjsembed/binding_support.h kjsembed/kjsembed/application.h kjsembed/kjsembed/application.cpp kjsembed/kjsembed/QBrush_bind.cpp kjsembed/kjsembed/QBrush_bind.h CMakeLists.txt 368584e kjsembed/AUTHORS
Re: Review Request 113155: Port all kde4_add_unit_test uses
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 10, 2013, 6:08 p.m.) Review request for KDE Frameworks. Changes --- Ping! Rebase to frameworks branch. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs (updated) - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 59a0a56 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113179: Make the runners compile again
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 10, 2013, 6:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time. This patch tries to port plasma-framework to that new API. Diffs - src/plasma/CMakeLists.txt 411256a src/plasma/private/runnerjobs.cpp d11f7e9 src/plasma/private/runnerjobs_p.h 7fd7076 src/plasma/private/storage.cpp 35b222e src/plasma/runnermanager.cpp 135279e src/plasma/scripting/runnerscript.cpp d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113199: KHTML: KComponentData - KAboutData
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/#review41558 --- Ship it! Looks quite straightforward to me, happy to see another kde4support dependency less :). - Aleix Pol Gonzalez On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113199/ --- (Updated Oct. 11, 2013, 12:16 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KComponentData - KAboutData This drops the KDE4Support dependency in KHTML. Diffs - khtml/src/java/kjavaappletviewer.h 3c3fd77 khtml/src/java/kjavaappletviewer.cpp cf6acf1 khtml/src/java/CMakeLists.txt 02efcd8 khtml/src/CMakeLists.txt dd36945 khtml/src/khtml_global.h 0d16716 khtml/src/khtml_global.cpp 4d7c6ca khtml/src/khtml_part.cpp 6e7f87e khtml/src/khtmlimage.h 9623a2a khtml/src/khtmlimage.cpp a074051 Diff: http://git.reviewboard.kde.org/r/113199/diff/ Testing --- Compiles. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- (Updated Oct. 11, 2013, 2 p.m.) Review request for KDE Frameworks. Changes --- Small love addition to the patch Repository: kdelibs Description --- Documents KInit dependencies, updates to the newer executable names and adds a comment regarding things to be looked into. Diffs (updated) - staging/kinit/src/wrapper.cpp c9d40cc staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 staging/kinit/src/klauncher/CMakeLists.txt 1b173be staging/kinit/src/kdeinit/kinit.cpp c4a0908 staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 staging/kinit/src/CMakeLists.txt 9fc6736 Diff: http://git.reviewboard.kde.org/r/113170/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113174: Cleanup KJsEmbed
On Oct. 11, 2013, 2:03 p.m., Àlex Fiestas wrote: tier1/kjs/src/wtf/Platform.h, lines 36-40 http://git.reviewboard.kde.org/r/113174/diff/2/?file=200451#file200451line36 This has been already pushed, no? Yes, it's in already, it wasn't part of that patch. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/#review41564 --- On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adopt directory organization, naming scheme, cmake structures, documents dependencies. Diffs - kjsembed/kjsembed/fileio.cpp kjsembed/kjsembed/font.h kjsembed/kjsembed/font.cpp kjsembed/kjsembed/image.h kjsembed/kjsembed/image.cpp kjsembed/kjsembed/iosupport.h kjsembed/kjsembed/iosupport.cpp kjsembed/kjsembed/jseventmapper.h kjsembed/kjsembed/jseventmapper.cpp kjsembed/kjsembed/jseventutils.h kjsembed/kjsembed/jseventutils.cpp kjsembed/kjsembed/kjseglobal.h kjsembed/kjsembed/kjseglobal.cpp kjsembed/kjsembed/kjsembed.h 74dfab8 kjsembed/kjsembed/kjsembed.cpp kjsembed/kjsembed/object_binding.h kjsembed/kjsembed/object_binding.cpp kjsembed/kjsembed/pen.h kjsembed/kjsembed/pen.cpp kjsembed/kjsembed/pixmap.h kjsembed/kjsembed/pixmap.cpp kjsembed/kjsembed/point.h kjsembed/kjsembed/point.cpp kjsembed/kjsembed/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 55cc3d3 staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e tier1/kjs/src/wtf/Platform.h 843cfd2 kjsembed/kjsembed/fileio.h kjsembed/kjsembed/filedialog_binding.cpp kjsembed/kjsembed/filedialog_binding.h kjsembed/kjsembed/eventproxy.cpp kjsembed/kjsembed/eventproxy.h kjsembed/kjsembed/dom.cpp kjsembed/kjsembed/dom.h kjsembed/kjsembed/brush.cpp kjsembed/kjsembed/builtins.h kjsembed/kjsembed/builtins.cpp kjsembed/kjsembed/color.h kjsembed/kjsembed/color.cpp kjsembed/kjsembed/brush.h kjsembed/kjsembed/binding_support.cpp kjsembed/kjsembed/binding_support.h kjsembed/kjsembed/application.h kjsembed/kjsembed/application.cpp kjsembed/kjsembed/QBrush_bind.cpp kjsembed/kjsembed/QBrush_bind.h CMakeLists.txt 368584e kjsembed/AUTHORS kjsembed/CMakeLists.txt 6cb6727 kjsembed/Mainpage.dox kjsembed/examples/calc/calc.js kjsembed/examples/calc/calc.ui kjsembed/examples/console/console.js kjsembed/examples/console/console.ui kjsembed/examples/docviewer/docviewer.js kjsembed/examples/docviewer/docviewer.ui kjsembed/examples/fancy/fancy.js kjsembed/examples/grammar/grammar.js kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b kjsembed/examples/kjsconsole/console.h kjsembed/examples
Re: Review Request 113170: Document KInit dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- (Updated Oct. 11, 2013, 3:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Documents KInit dependencies, updates to the newer executable names and adds a comment regarding things to be looked into. Diffs - staging/kinit/src/wrapper.cpp c9d40cc staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 staging/kinit/src/klauncher/CMakeLists.txt 1b173be staging/kinit/src/kdeinit/kinit.cpp c4a0908 staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 staging/kinit/src/CMakeLists.txt 9fc6736 Diff: http://git.reviewboard.kde.org/r/113170/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113206: Make KIconLoader a bit less fragile
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113206/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that would delete the d-pointer. This patch makes it so instead of deleting it, it will clear the values and initialize them again instead. Diffs - tier3/kiconthemes/src/kiconloader.cpp bf3899a Diff: http://git.reviewboard.kde.org/r/113206/diff/ Testing --- Makes ktoolbartest pass (and valgrind-proof) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113206: Make KIconLoader a bit less fragile
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113206/ --- (Updated Oct. 11, 2013, 6:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that would delete the d-pointer. This patch makes it so instead of deleting it, it will clear the values and initialize them again instead. Diffs - tier3/kiconthemes/src/kiconloader.cpp bf3899a Diff: http://git.reviewboard.kde.org/r/113206/diff/ Testing --- Makes ktoolbartest pass (and valgrind-proof) Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113237: Move KInit to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113237/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KInit to tier3 Diffs - CMakeLists.txt 17c3090 staging/CMakeLists.txt a3bfaab staging/kinit/CMakeLists.txt staging/kinit/ConfigureChecks.cmake staging/kinit/Info.plist.template staging/kinit/KInitConfig.cmake staging/kinit/KInitMacros.cmake 67d24dd staging/kinit/Mainpage.dox staging/kinit/README staging/kinit/README.autostart staging/kinit/README.wrapper staging/kinit/kde5init_dummy.cpp.in staging/kinit/kde5init_win32lib_dummy.cpp.in staging/kinit/src/CMakeLists.txt 12d1590 staging/kinit/src/config-kdeinit.h.cmake staging/kinit/src/kdeinit/CMakeLists.txt staging/kinit/src/kdeinit/kinit.cpp staging/kinit/src/kdeinit/kinit_win.cpp staging/kinit/src/kdeinit/proctitle.h staging/kinit/src/kdeinit/proctitle.cpp staging/kinit/src/kioslave/CMakeLists.txt staging/kinit/src/kioslave/kioslave.cpp staging/kinit/src/klauncher/CMakeLists.txt staging/kinit/src/klauncher/autostart.h staging/kinit/src/klauncher/autostart.cpp staging/kinit/src/klauncher/klauncher.h staging/kinit/src/klauncher/klauncher.cpp staging/kinit/src/klauncher/klauncher_adaptor.h staging/kinit/src/klauncher/klauncher_adaptor.cpp staging/kinit/src/klauncher/klauncher_main.cpp staging/kinit/src/klauncher_cmds.h staging/kinit/src/klauncher_cmds.cpp staging/kinit/src/kshell/CMakeLists.txt staging/kinit/src/kshell/shell.cpp staging/kinit/src/kwrapper/CMakeLists.txt staging/kinit/src/kwrapper/kwrapper.cpp staging/kinit/src/kwrapper/kwrapper_win.cpp staging/kinit/src/start_kdeinit/CMakeLists.txt staging/kinit/src/start_kdeinit/start_kdeinit.c staging/kinit/src/start_kdeinit/start_kdeinit_wrapper.c staging/kinit/src/wrapper.cpp tier3/CMakeLists.txt 4f5c1c8 Diff: http://git.reviewboard.kde.org/r/113237/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113237: Move KInit to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113237/ --- (Updated Oct. 14, 2013, 4:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KInit to tier3 Diffs - CMakeLists.txt 17c3090 staging/CMakeLists.txt a3bfaab staging/kinit/CMakeLists.txt staging/kinit/ConfigureChecks.cmake staging/kinit/Info.plist.template staging/kinit/KInitConfig.cmake staging/kinit/KInitMacros.cmake 67d24dd staging/kinit/Mainpage.dox staging/kinit/README staging/kinit/README.autostart staging/kinit/README.wrapper staging/kinit/kde5init_dummy.cpp.in staging/kinit/kde5init_win32lib_dummy.cpp.in staging/kinit/src/CMakeLists.txt 12d1590 staging/kinit/src/config-kdeinit.h.cmake staging/kinit/src/kdeinit/CMakeLists.txt staging/kinit/src/kdeinit/kinit.cpp staging/kinit/src/kdeinit/kinit_win.cpp staging/kinit/src/kdeinit/proctitle.h staging/kinit/src/kdeinit/proctitle.cpp staging/kinit/src/kioslave/CMakeLists.txt staging/kinit/src/kioslave/kioslave.cpp staging/kinit/src/klauncher/CMakeLists.txt staging/kinit/src/klauncher/autostart.h staging/kinit/src/klauncher/autostart.cpp staging/kinit/src/klauncher/klauncher.h staging/kinit/src/klauncher/klauncher.cpp staging/kinit/src/klauncher/klauncher_adaptor.h staging/kinit/src/klauncher/klauncher_adaptor.cpp staging/kinit/src/klauncher/klauncher_main.cpp staging/kinit/src/klauncher_cmds.h staging/kinit/src/klauncher_cmds.cpp staging/kinit/src/kshell/CMakeLists.txt staging/kinit/src/kshell/shell.cpp staging/kinit/src/kwrapper/CMakeLists.txt staging/kinit/src/kwrapper/kwrapper.cpp staging/kinit/src/kwrapper/kwrapper_win.cpp staging/kinit/src/start_kdeinit/CMakeLists.txt staging/kinit/src/start_kdeinit/start_kdeinit.c staging/kinit/src/start_kdeinit/start_kdeinit_wrapper.c staging/kinit/src/wrapper.cpp tier3/CMakeLists.txt 4f5c1c8 Diff: http://git.reviewboard.kde.org/r/113237/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113240: Move KJsEmbed to tier3
/filedialog_binding.h staging/kjsembed/src/kjsembed/filedialog_binding.cpp staging/kjsembed/src/kjsembed/fileio.h staging/kjsembed/src/kjsembed/fileio.cpp staging/kjsembed/src/kjsembed/font.h staging/kjsembed/src/kjsembed/font.cpp staging/kjsembed/src/kjsembed/image.h staging/kjsembed/src/kjsembed/image.cpp staging/kjsembed/src/kjsembed/iosupport.h staging/kjsembed/src/kjsembed/iosupport.cpp staging/kjsembed/src/kjsembed/jseventmapper.h staging/kjsembed/src/kjsembed/jseventmapper.cpp staging/kjsembed/src/kjsembed/jseventutils.h staging/kjsembed/src/kjsembed/jseventutils.cpp staging/kjsembed/src/kjsembed/kjseglobal.h staging/kjsembed/src/kjsembed/kjseglobal.cpp staging/kjsembed/src/kjsembed/kjsembed.h staging/kjsembed/src/kjsembed/kjsembed.cpp staging/kjsembed/src/kjsembed/object_binding.h staging/kjsembed/src/kjsembed/object_binding.cpp staging/kjsembed/src/kjsembed/pen.h staging/kjsembed/src/kjsembed/pen.cpp staging/kjsembed/src/kjsembed/pixmap.h staging/kjsembed/src/kjsembed/pixmap.cpp staging/kjsembed/src/kjsembed/point.h staging/kjsembed/src/kjsembed/point.cpp staging/kjsembed/src/kjsembed/pointer.h staging/kjsembed/src/kjsembed/qaction_binding.h staging/kjsembed/src/kjsembed/qaction_binding.cpp staging/kjsembed/src/kjsembed/qformbuilder_binding.h staging/kjsembed/src/kjsembed/qformbuilder_binding.cpp staging/kjsembed/src/kjsembed/qlayout_binding.h staging/kjsembed/src/kjsembed/qlayout_binding.cpp staging/kjsembed/src/kjsembed/qobject_binding.h staging/kjsembed/src/kjsembed/qobject_binding.cpp staging/kjsembed/src/kjsembed/qpainter_binding.h staging/kjsembed/src/kjsembed/qpainter_binding.cpp staging/kjsembed/src/kjsembed/quiloader_binding.h staging/kjsembed/src/kjsembed/quiloader_binding.cpp staging/kjsembed/src/kjsembed/qwidget_binding.h staging/kjsembed/src/kjsembed/qwidget_binding.cpp staging/kjsembed/src/kjsembed/rect.h staging/kjsembed/src/kjsembed/rect.cpp staging/kjsembed/src/kjsembed/settings.h staging/kjsembed/src/kjsembed/settings.cpp staging/kjsembed/src/kjsembed/size.h staging/kjsembed/src/kjsembed/size.cpp staging/kjsembed/src/kjsembed/slotproxy.h staging/kjsembed/src/kjsembed/slotproxy.cpp staging/kjsembed/src/kjsembed/static_binding.h staging/kjsembed/src/kjsembed/static_binding.cpp staging/kjsembed/src/kjsembed/svg_binding.h staging/kjsembed/src/kjsembed/svg_binding.cpp staging/kjsembed/src/kjsembed/test/QByteArray_bind.h staging/kjsembed/src/kjsembed/test/QByteArray_bind.cpp staging/kjsembed/src/kjsembed/url.h staging/kjsembed/src/kjsembed/url.cpp staging/kjsembed/src/kjsembed/util.h staging/kjsembed/src/kjsembed/value_binding.h staging/kjsembed/src/kjsembed/value_binding.cpp staging/kjsembed/src/kjsembed/variant_binding.h staging/kjsembed/src/kjsembed/variant_binding.cpp tier3/CMakeLists.txt 4f5c1c8 Diff: http://git.reviewboard.kde.org/r/113240/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113243: KMessageBox: Re-enable squeezed text for extreme situations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113243/#review41746 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 14, 2013, 4:20 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113243/ --- (Updated Oct. 14, 2013, 4:20 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KMessageBox: Re-enable squeezed text for extreme situations Also adds a test for it to kmessageboxtest.cpp Diffs - KDE5PORTING.html 9ed2294 tier1/kwidgetsaddons/src/kmessagebox.cpp e56f666 tier1/kwidgetsaddons/tests/kmessageboxtest.cpp 18c50b7 Diff: http://git.reviewboard.kde.org/r/113243/diff/ Testing --- Builds, message box shows for the new test in kmessageboxtest.cpp. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113248: Cleanup KNotifyConfig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113247: Port KCompletion away from KStandardAction
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/#review41750 --- Ship it! Good catch David! - Aleix Pol Gonzalez On Oct. 14, 2013, 5:04 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247/ --- (Updated Oct. 14, 2013, 5:04 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix depends in KCompletion KCompletion cannot use KStandardAction which is from kconfigwidgets in tier3 Diffs - tier2/kcompletion/CMakeLists.txt 8c34bd6 tier2/kcompletion/KCompletionConfig.cmake.in 46647d1 tier2/kcompletion/src/CMakeLists.txt d2b7602 tier2/kcompletion/src/klineedit.cpp 2f70935 Diff: http://git.reviewboard.kde.org/r/113247/diff/ Testing --- Compiled in source Tried compiling standalone (it builds, but has a linker fail on something unrelated) Ran klineedittest and checked combobox was the same. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Changes --- forgot the diff Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs (updated) - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
On Oct. 15, 2013, 1:44 p.m., Kevin Ottens wrote: staging/knotifyconfig/CMakeLists.txt, line 17 http://git.reviewboard.kde.org/r/113248/diff/1/?file=201274#file201274line17 Shouldn't this type of conditional removed now that we use alias targets? Or you plan to change that in another commit? No, that should stay as long as it can be compiled from a higher module. Otherwise all modules would be writing their own summary. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41776 --- On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/#review41821 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 16, 2013, 7:45 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/ --- (Updated Oct. 16, 2013, 7:45 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds part about KDebug Diffs - KDE5PORTING.html acb408c Diff: http://git.reviewboard.kde.org/r/113181/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/#review41850 --- Ship it! tier1/kidletime/CMakeLists.txt http://git.reviewboard.kde.org/r/113276/#comment30542 really needed? Good work! :) - Aleix Pol Gonzalez On Oct. 16, 2013, 4:44 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/ --- (Updated Oct. 16, 2013, 4:44 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- Calls to functions provided by includes must come after includes themselves. This request also includes a separate commit for template/CMakeLists.txt, which moves all calls to find_package() after ecm is setup and provide a hint as to where find_package() calls should be. This should hopefully help prevent future errors. Diffs - template/CMakeLists.txt 96a5363 tier1/kidletime/CMakeLists.txt 21e9f37 tier1/kjs/CMakeLists.txt 9c2acaa tier1/kwindowsystem/CMakeLists.txt e4f984b Diff: http://git.reviewboard.kde.org/r/113276/diff/ Testing --- Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113300: Improve porting to Qt/KF5 scripts
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300/ --- Review request for KDE Frameworks. Repository: plasma-framework Description --- Improve the porting scripts in plasma-framework (maybe they should be in kdesdk?). - Add a script to remove the Qt module part of an include (QtGui/QLabel becomes QLabel). - Add more cases when porting cmake files, adding the Qt libraries as well. Diffs - tools/port-cmake.sh 832cdd2 tools/port-includes.sh PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113300/diff/ Testing --- Been trying to port an application, to see how it worked. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113248: Cleanup KNotifyConfig
On Oct. 15, 2013, 1:51 p.m., Aurélien Gâteau wrote: Standalone build fails here with this message: -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at CMakeLists.txt:19 (find_package): Found package configuration file: /home/aurelien/opt/kf5/lib/x86_64-linux-gnu/cmake/KIO/KIOConfig.cmake but it set KIO_FOUND to FALSE so package KIO is considered to be NOT FOUND. Reason given by package: The following imported targets are referenced, but are missing: KF5::KBookmarks KF5::XmlGui KF5::Solid Is it really a problem in KNotifyConfig? I'd say it is in KIO... - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41778 --- On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly. Diffs - staging/knotifyconfig/CMakeLists.txt 65867ba staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 Diff: http://git.reviewboard.kde.org/r/113248/diff/ Testing --- builds, teh test seems to work still. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113328: Fix standalone build of kdoctools
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review41951 --- tier2/kdoctools/CMakeLists.txt http://git.reviewboard.kde.org/r/113328/#comment30603 The KF5 find_package should be outside of the if - Aleix Pol Gonzalez On Oct. 18, 2013, 12:14 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 18, 2013, 12:14 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs - tier2/kdoctools/src/CMakeLists.txt 8b726a8 tier2/kdoctools/CMakeLists.txt 53fd0e9 superbuild/CMakeLists.txt 5cdec94 Diff: http://git.reviewboard.kde.org/r/113328/diff/ Testing --- Builds within kdelibs and using superbuild. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113300: Improve porting to Qt/KF5 scripts
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300/ --- (Updated Oct. 18, 2013, 10:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: plasma-framework Description --- Improve the porting scripts in plasma-framework (maybe they should be in kdesdk?). - Add a script to remove the Qt module part of an include (QtGui/QLabel becomes QLabel). - Add more cases when porting cmake files, adding the Qt libraries as well. Diffs - tools/port-cmake.sh 832cdd2 tools/port-includes.sh PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113300/diff/ Testing --- Been trying to port an application, to see how it worked. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/#review42201 --- Ship it! It definitely needs to be there, although Ben already added it. - Aleix Pol Gonzalez On Oct. 21, 2013, 11:23 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/ --- (Updated Oct. 21, 2013, 11:23 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Subject says it all. Diffs - find-modules/FindKF5.cmake 8f95469 Diff: http://git.reviewboard.kde.org/r/113377/diff/ Testing --- find_package(KF5 ... KDeclarative) works with this patch, it doesn't work without. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113402: Fix KI18n standalone build
On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: I can only say that whatever is the proper fix here, it is fine with me. Since non-installed headers are being used, maybe ki18n is using KJS in a way which became deprecated somewhere along the way? If so, I've nothing against fixing that instead. Well the thing is that ki18n was using private API (since it was in the same module, kdelibs). Aurélien: what about installing these headers in a private/ directory? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/#review4 --- On Oct. 23, 2013, 2:30 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/ --- (Updated Oct. 23, 2013, 2:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KI18n depends on KJS to build the ktranscript plugin. This plugin requires an internal KJS Perl script as well as headers which were not installed. This is a 3-commit patches, which does the following: 1. Install kjs headers 2. Install wtf headers, using wtf/ and kjs/ in include directives (because some kjs headers includes wtf headers) 3. Fix KI18n: - Format top-level CMakeLists.txt according to CMake template - Duplicate KJS create_hash_table script - Add call to find_package(KJS) Individual patches available from http://agateau.com/tmp/ki18n-standalone.patch Diffs - superbuild/CMakeLists.txt 5cdec94 tier1/kjs/src/CMakeLists.txt 8629716 tier1/kjs/src/kjs/CMakeLists.txt 9523e89 tier1/kjs/src/wtf/CMakeLists.txt 83b4417 tier1/kjs/src/wtf/FastMalloc.h 29a72a5 tier1/kjs/src/wtf/HashCountedSet.h be3c387 tier1/kjs/src/wtf/HashFunctions.h f665447 tier1/kjs/src/wtf/HashMap.h ba2971c tier1/kjs/src/wtf/HashSet.h e84b349 tier1/kjs/src/wtf/HashTable.h 0b2c22c tier1/kjs/src/wtf/HashTable.cpp e08d09a tier1/kjs/src/wtf/HashTraits.h 4d01726 tier1/kjs/src/wtf/ListRefPtr.h 0a704d8 tier1/kjs/src/wtf/OwnArrayPtr.h 3b77871 tier1/kjs/src/wtf/OwnPtr.h 188a1dc tier1/kjs/src/wtf/PassRefPtr.h 25b9906 tier1/kjs/src/wtf/RefPtr.h 493ab05 tier1/kjs/src/wtf/Vector.h 9b0f38a tier1/kjs/src/wtf/VectorTraits.h 31ae028 tier2/ki18n/CMakeLists.txt 4cc8e30 tier2/ki18n/src/CMakeLists.txt 7f8259b4 tier2/ki18n/src/create_hash_table PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113402/diff/ Testing --- Builds within kdelibs and standalone. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113402: Fix KI18n standalone build
On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: I can only say that whatever is the proper fix here, it is fine with me. Since non-installed headers are being used, maybe ki18n is using KJS in a way which became deprecated somewhere along the way? If so, I've nothing against fixing that instead. Aleix Pol Gonzalez wrote: Well the thing is that ki18n was using private API (since it was in the same module, kdelibs). Aurélien: what about installing these headers in a private/ directory? Chusslove Illich wrote: If I recall, when implementing that I mimicked what khtml was doing. And apparently is still doing. khtml is in kdelibs as well, nobody has tried to build it standalone just yet, I guess. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/#review4 --- On Oct. 23, 2013, 2:30 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/ --- (Updated Oct. 23, 2013, 2:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KI18n depends on KJS to build the ktranscript plugin. This plugin requires an internal KJS Perl script as well as headers which were not installed. This is a 3-commit patches, which does the following: 1. Install kjs headers 2. Install wtf headers, using wtf/ and kjs/ in include directives (because some kjs headers includes wtf headers) 3. Fix KI18n: - Format top-level CMakeLists.txt according to CMake template - Duplicate KJS create_hash_table script - Add call to find_package(KJS) Individual patches available from http://agateau.com/tmp/ki18n-standalone.patch Diffs - superbuild/CMakeLists.txt 5cdec94 tier1/kjs/src/CMakeLists.txt 8629716 tier1/kjs/src/kjs/CMakeLists.txt 9523e89 tier1/kjs/src/wtf/CMakeLists.txt 83b4417 tier1/kjs/src/wtf/FastMalloc.h 29a72a5 tier1/kjs/src/wtf/HashCountedSet.h be3c387 tier1/kjs/src/wtf/HashFunctions.h f665447 tier1/kjs/src/wtf/HashMap.h ba2971c tier1/kjs/src/wtf/HashSet.h e84b349 tier1/kjs/src/wtf/HashTable.h 0b2c22c tier1/kjs/src/wtf/HashTable.cpp e08d09a tier1/kjs/src/wtf/HashTraits.h 4d01726 tier1/kjs/src/wtf/ListRefPtr.h 0a704d8 tier1/kjs/src/wtf/OwnArrayPtr.h 3b77871 tier1/kjs/src/wtf/OwnPtr.h 188a1dc tier1/kjs/src/wtf/PassRefPtr.h 25b9906 tier1/kjs/src/wtf/RefPtr.h 493ab05 tier1/kjs/src/wtf/Vector.h 9b0f38a tier1/kjs/src/wtf/VectorTraits.h 31ae028 tier2/ki18n/CMakeLists.txt 4cc8e30 tier2/ki18n/src/CMakeLists.txt 7f8259b4 tier2/ki18n/src/create_hash_table PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113402/diff/ Testing --- Builds within kdelibs and standalone. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 24, 2013, 1:40 p.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Changes --- Adopt changes proposed by Neundorf. - Improved documentation. - Added different arguments to configure how the macro works. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs (updated) - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 29 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29 This variable shouldn't be needed at all. Variable? Or argument? Why? On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 32 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32 I recommend not putting this in the API of the function, and instead users should use install(DIRECTORY) to install the generated files. Why? On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 11 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line11 I really think the answers to my questions here need to be found first: http://thread.gmane.org/gmane.comp.kde.cvs/1272841 It should be more-simple than it currently is. I think that this patch answers most of these questions, leaving up to discussion if we expect people to include module/something.h or just something.h. I'd say that if Qt5 transition teaches something is that it's not very flexible to namespace the include files, but that's up to the developer anyway... - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 --- On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 24, 2013, 1:40 p.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113422: Port kconfigtest and kconfignokdehometest to QStandardPaths
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/#review42297 --- tier1/kconfig/autotests/kconfignokdehometest.cpp http://git.reviewboard.kde.org/r/113422/#comment30774 Please review what you changed. You're removing the config directory of the test user, sounds dangerous! Note that it was changing the value of the XDG_CONFIG_HOME before running the test. I'm unsure what's the proper cross-platform fix to it. - Aleix Pol Gonzalez On Oct. 24, 2013, 3:55 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/ --- (Updated Oct. 24, 2013, 3:55 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Port kconfigtest and kconfignokdehometest to QStandardPaths They relied on setting XDG_CONFIG_HOME which will not work on Windows Diffs - tier1/kconfig/autotests/kconfigtest.h e0d7f7350159187e7611ddefd99d7d6faabde6ac tier1/kconfig/autotests/kconfignokdehometest.cpp ce53ca58fc7e1ce5a4345cce8a17de0e05866019 tier1/kconfig/autotests/kconfigtest.cpp 26e6a781bedf226ef0ca0d9030e107d3c412bd35 Diff: http://git.reviewboard.kde.org/r/113422/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113423/#review42298 --- Ship it! Ship It! tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp http://git.reviewboard.kde.org/r/113423/#comment30775 You can pass CMAKE_EXECUTABLE_SUFFIX from cmake. - Aleix Pol Gonzalez On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113423/ --- (Updated Oct. 24, 2013, 3:59 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KConfigCompiler_Test::testRunning() on Windows The test expects that the executables to find have no suffix Diffs - tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 7f2697ad94ac6d433d18fb16a99ed1435433547d Diff: http://git.reviewboard.kde.org/r/113423/diff/ Testing --- Test passes. Although IMO it might make sense to drop this test, it takes ages due to spawning all those programs that do nothing useful. Compiling these generated files to see that they contain no errors is enough. Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113373: Enable C++11 support by default.
On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: As far as I know, only threadweaver and karchive will be released in December. The rest of the frameworks won't be released until summer. By summer, CMake 3.0.0 will most likely be out. Volker Krause wrote: while the CMake 3 solution is obviously much nicer, what are our alternatives until then? The current solution is adding -std=c++0x without proper compiler checks ad-hoc where needed, I think that's far worse than this change. Also, it wont detect incompatibilities with C++11 in currently C++98-only code paths. And changes here are needed anyway, since -ansi effectively prevents you from enabling C++11 (which also suggests ICC hasn't been tested in quite a while). Ivan Čukić wrote: +1 Stephen Kelly wrote: Fair enough. I don't recommend releasing ecm with this though. I don't see any reason to release ecm when releasing KArchive and Threadweaver. I recommend just copying needed files into the first release of those instead. Alexander Neundorf wrote: I.e. both will have copies of ECMSetupVersion.cmake, ECMVersionHeader.h.in, KDEInstallDirs.cmake, KDECompilerSettings.cmake and KDECMakeSettings.cmake ? This is just so much against what was originally, at least my, idea of e-c-m: make cmake stuff we have in KDE, but which can be useful also in other projects, easier and quicker available to others (instead of not being able to release it when the first frameworks are released). But I don't object, it's your decision. Stephen Kelly wrote: It's not my decision either. It's just a recommendation. I object. What's the big impediment of releasing ECM? If there's an impediment, let's fix it. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/#review42130 --- On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/ --- (Updated Oct. 21, 2013, 6:51 p.m.) Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Enable C++11 support by default. Diffs - kde-modules/KDECompilerSettings.cmake b745ec3c52fe66b3cfb89a334c99a5ea8ef71d4d Diff: http://git.reviewboard.kde.org/r/113373/diff/ Testing --- Compiles, all required fixes have been integrated into the frameworks branch by now (at least for the subset I have the required dependencies for). Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 29
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29
This variable shouldn't be needed at all.
Aleix Pol Gonzalez wrote:
Variable? Or argument? Why?
Stephen Kelly wrote:
Argument, yes, sorry.
I think that because the source dir is already in the
INTERFACE_INCLUDE_DIRECTORIES of the target, there is no need to have to
specify it, and there should be no need to use ${EGH_HEADERS_DIR}/ in the
generated include.
I guess you have some reason for doing that, but that just points to
non-uniformity which should maybe be fixed, as I wrote in the KIO commit I
linked to.
Alexander Neundorf wrote:
I don't see any target involved here...
So maybe we should link the generated headers to a target?
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 24, 2013, 1:40 p.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 9:35 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Changes --- Remove the install functionality, and the INSTALL_DIR argument with it, cmake can install the files quite easily anyway. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs (updated) - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 10:56 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Changes --- My bad, I uploaded the wrong patch version. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs (updated) - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 32 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32 I recommend not putting this in the API of the function, and instead users should use install(DIRECTORY) to install the generated files. Aleix Pol Gonzalez wrote: Why? Stephen Kelly wrote: I think it's better API. It's what all existing functions which generate headers do. Then it's weird because we'll need to have a separate call for installing all the headers as well, so we will have them all listed twice. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 --- On Oct. 26, 2013, 10:56 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 10:56 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:28 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Changes --- updated patch following remarks, added KParts changes in a more stable place. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs (updated) - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments (updated) example of how KParts would change http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:32 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments example of how KParts would change http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 32 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32 I recommend not putting this in the API of the function, and instead users should use install(DIRECTORY) to install the generated files. Aleix Pol Gonzalez wrote: Why? Stephen Kelly wrote: I think it's better API. It's what all existing functions which generate headers do. Aleix Pol Gonzalez wrote: Then it's weird because we'll need to have a separate call for installing all the headers as well, so we will have them all listed twice. Stephen Kelly wrote: Are you sure? You wouldn't just have a single install(DIRECTORY), as I wrote before? See the KParts patch I attached. We want to install the actual header, not the forward header, right? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 --- On Oct. 29, 2013, 12:32 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:32 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments example of how KParts would change http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113155: Port all kde4_add_unit_test uses
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 29, 2013, 8:46 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 59a0a56 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 10:52 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Changes --- updated example Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments (updated) kparts changes example http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 32
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32
I recommend not putting this in the API of the function, and instead
users should use
install(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call for installing
all the headers as well, so we will have them all listed twice.
Stephen Kelly wrote:
Are you sure? You wouldn't just have a single install(DIRECTORY), as I
wrote before?
Aleix Pol Gonzalez wrote:
See the KParts patch I attached. We want to install the actual header,
not the forward header, right?
Stephen Kelly wrote:
Your kparts patch contains this:
+#still need to see what to do with these...
+# install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/kparts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Why would you install the contents of ${CMAKE_CURRENT_BINARY_DIR}/kparts
? It contains hardcoded source dir paths. They don't need to though. If
srcdir/part.h exists, then write include 'part.h' to that file, not
'srcdir/part.h'. The source dir is already part of the -I passed to the
compiler (recall that I wrote before I think that because the source dir is
already in the INTERFACE_INCLUDE_DIRECTORIES of the target), so no need to
hardcode it at all.
Actually reading your message again, I think that's what you are asking
me. Yes, you want to install the actual headers.
Yes, so we can install the headers either from the macro or from the
CMakeLists.txt. If we do it from the CMakeLists.txt files, we'll end up having
to list the headers twice.
See updated diff.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 29, 2013, 10:52 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 29, 2013, 10:52 a.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
File Attachments
kparts changes example
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 32
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32
I recommend not putting this in the API of the function, and instead
users should use
install(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call for installing
all the headers as well, so we will have them all listed twice.
Stephen Kelly wrote:
Are you sure? You wouldn't just have a single install(DIRECTORY), as I
wrote before?
Aleix Pol Gonzalez wrote:
See the KParts patch I attached. We want to install the actual header,
not the forward header, right?
Stephen Kelly wrote:
Your kparts patch contains this:
+#still need to see what to do with these...
+# install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/kparts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Why would you install the contents of ${CMAKE_CURRENT_BINARY_DIR}/kparts
? It contains hardcoded source dir paths. They don't need to though. If
srcdir/part.h exists, then write include 'part.h' to that file, not
'srcdir/part.h'. The source dir is already part of the -I passed to the
compiler (recall that I wrote before I think that because the source dir is
already in the INTERFACE_INCLUDE_DIRECTORIES of the target), so no need to
hardcode it at all.
Actually reading your message again, I think that's what you are asking
me. Yes, you want to install the actual headers.
Aleix Pol Gonzalez wrote:
Yes, so we can install the headers either from the macro or from the
CMakeLists.txt. If we do it from the CMakeLists.txt files, we'll end up
having to list the headers twice.
See updated diff.
Stephen Kelly wrote:
You can also populate an out-list. See for example what
QT4_EXTRACT_OPTIONS does with _qt4_files.
I prefer installing from the macro than having an output list.
The macro can be used to standardize the installation of headers, whereas if
we're returning a list we can barely help developers.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 29, 2013, 10:52 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 29, 2013, 10:52 a.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
File Attachments
kparts changes example
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113625: Prepare KHTML for moving into tier4.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/#review43050 --- Ship it! Looks good to me - Aleix Pol Gonzalez On Nov. 5, 2013, 11:52 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/ --- (Updated Nov. 5, 2013, 11:52 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Tidy target_link for KHTML. Diffs - khtml/src/CMakeLists.txt ed113f5 khtml/src/java/CMakeLists.txt 3dd2d88 Diff: http://git.reviewboard.kde.org/r/113625/diff/ Testing --- Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets
On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote:
tier2/kjobwidgets/src/CMakeLists.txt, line 17
http://git.reviewboard.kde.org/r/113643/diff/1/?file=209153#file209153line17
You should replace this line with:
if(${CMAKE_BINARY_DIR} STREQUAL ${CMAKE_CURRENT_BINARY_DIR})
This is more future-proof in case the top-level project gets renamed.
David Narváez wrote:
Mmm, I understand your point but note that
CMAKE_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets
CMAKE_CURRENT_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets/src
You should always do the find_package() from the root CMakeLists.txt of the
module.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/#review43058
---
On Nov. 5, 2013, 1:53 p.m., David Narváez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/
---
(Updated Nov. 5, 2013, 1:53 p.m.)
Review request for KDE Frameworks and Aurélien Gâteau.
Repository: kdelibs
Description
---
Specify required find_packages when not in kdelib's source dir. This does not
fix the standalone build itself.
Diffs
-
tier2/kjobwidgets/src/CMakeLists.txt 032df16
Diff: http://git.reviewboard.kde.org/r/113643/diff/
Testing
---
1. Configure a standalone build
Before this patch the configuration would complain of missing find_packages
for KCore
Thanks,
David Narváez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113650: Adopt ecm_generate_headers in KParts framework
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/ --- (Updated Nov. 6, 2013, 1:14 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Changes --- add alex and steveire to the review, in case they didn't get it. Repository: kdelibs Description --- Generate the forward headers using the macro instead of crafting it into a loop. Install the CamelCase headers in prefix/includes/KParts. Diffs - tier3/kparts/src/CMakeLists.txt 4c3de10 Diff: http://git.reviewboard.kde.org/r/113650/diff/ Testing --- Built, everything installed ok. Installed files: kde-devel@thinktatil:~/build-frameworks/kdelibs$ cat install_manifest.txt | grep include | grep -i kparts /home/kde-devel/kde5/include/kparts_version.h /home/kde-devel/kde5/include/KParts/ListingExtension /home/kde-devel/kde5/include/KParts/PartManager /home/kde-devel/kde5/include/KParts/TextExtension /home/kde-devel/kde5/include/KParts/ScriptableExtension /home/kde-devel/kde5/include/KParts/HistoryProvider /home/kde-devel/kde5/include/KParts/BrowserExtension /home/kde-devel/kde5/include/KParts/BrowserInterface /home/kde-devel/kde5/include/KParts/MainWindow /home/kde-devel/kde5/include/KParts/BrowserOpenOrSaveQuestion /home/kde-devel/kde5/include/KParts/Event /home/kde-devel/kde5/include/KParts/BrowserRun /home/kde-devel/kde5/include/KParts/HtmlExtension /home/kde-devel/kde5/include/KParts/FileInfoExtension /home/kde-devel/kde5/include/KParts/StatusBarExtension /home/kde-devel/kde5/include/KParts/Part /home/kde-devel/kde5/include/KParts/Plugin /home/kde-devel/kde5/include/kparts/kparts_export.h /home/kde-devel/kde5/include/kparts/part.h /home/kde-devel/kde5/include/kparts/plugin.h /home/kde-devel/kde5/include/kparts/partmanager.h /home/kde-devel/kde5/include/kparts/mainwindow.h /home/kde-devel/kde5/include/kparts/event.h /home/kde-devel/kde5/include/kparts/browserextension.h /home/kde-devel/kde5/include/kparts/historyprovider.h /home/kde-devel/kde5/include/kparts/browserinterface.h /home/kde-devel/kde5/include/kparts/browserrun.h /home/kde-devel/kde5/include/kparts/statusbarextension.h /home/kde-devel/kde5/include/kparts/browseropenorsavequestion.h /home/kde-devel/kde5/include/kparts/scriptableextension.h /home/kde-devel/kde5/include/kparts/textextension.h /home/kde-devel/kde5/include/kparts/htmlextension.h /home/kde-devel/kde5/include/kparts/fileinfoextension.h /home/kde-devel/kde5/include/kparts/listingextension.h /home/kde-devel/kde5/include/kparts/componentfactory.h /home/kde-devel/kde5/include/kparts/genericfactory.h /home/kde-devel/kde5/include/kparts/factory.h /home/kde-devel/kde5/include/KDE/KParts/BrowserExtension /home/kde-devel/kde5/include/KDE/KParts/BrowserHostExtension /home/kde-devel/kde5/include/KDE/KParts/BrowserInterface /home/kde-devel/kde5/include/KDE/KParts/BrowserRun /home/kde-devel/kde5/include/KDE/KParts/ComponentFactory /home/kde-devel/kde5/include/KDE/KParts/DockMainWindow3 /home/kde-devel/kde5/include/KDE/KParts/Event /home/kde-devel/kde5/include/KDE/KParts/Factory /home/kde-devel/kde5/include/KDE/KParts/FileInfoExtension /home/kde-devel/kde5/include/KDE/KParts/GUIActivateEvent /home/kde-devel/kde5/include/KDE/KParts/GenericFactory /home/kde-devel/kde5/include/KDE/KParts/GenericFactoryBase /home/kde-devel/kde5/include/KDE/KParts/HistoryProvider /home/kde-devel/kde5/include/KDE/KParts/HtmlExtension /home/kde-devel/kde5/include/KDE/KParts/LiveConnectExtension /home/kde-devel/kde5/include/KDE/KParts/ListingExtension /home/kde-devel/kde5/include/KDE/KParts/MainWindow /home/kde-devel/kde5/include/KDE/KParts/OpenUrlEvent /home/kde-devel/kde5/include/KDE/KParts/Part /home/kde-devel/kde5/include/KDE/KParts/PartActivateEvent /home/kde-devel/kde5/include/KDE/KParts/PartBase /home/kde-devel/kde5/include/KDE/KParts/PartManager /home/kde-devel/kde5/include/KDE/KParts/PartSelectEvent /home/kde-devel/kde5/include/KDE/KParts/Plugin /home/kde-devel/kde5/include/KDE/KParts/ReadOnlyPart /home/kde-devel/kde5/include/KDE/KParts/ReadWritePart /home/kde-devel/kde5/include/KDE/KParts/StatusBarExtension /home/kde-devel/kde5/include/KDE/KParts/TextExtension /home/kde-devel/kde5/include/KDE/KParts/WindowArgs Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113677: Fix standalone build of KUnitConversion
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113677/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Specify the different dependencies so it builds. Diffs - tier3/kunitconversion/CMakeLists.txt 6895079 Diff: http://git.reviewboard.kde.org/r/113677/diff/ Testing --- Builds, installs and tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113650: Adopt ecm_generate_headers in KParts framework
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/ --- (Updated Nov. 6, 2013, 1:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- Generate the forward headers using the macro instead of crafting it into a loop. Install the CamelCase headers in prefix/includes/KParts. Diffs - tier3/kparts/src/CMakeLists.txt 4c3de10 Diff: http://git.reviewboard.kde.org/r/113650/diff/ Testing --- Built, everything installed ok. Installed files: kde-devel@thinktatil:~/build-frameworks/kdelibs$ cat install_manifest.txt | grep include | grep -i kparts /home/kde-devel/kde5/include/kparts_version.h /home/kde-devel/kde5/include/KParts/ListingExtension /home/kde-devel/kde5/include/KParts/PartManager /home/kde-devel/kde5/include/KParts/TextExtension /home/kde-devel/kde5/include/KParts/ScriptableExtension /home/kde-devel/kde5/include/KParts/HistoryProvider /home/kde-devel/kde5/include/KParts/BrowserExtension /home/kde-devel/kde5/include/KParts/BrowserInterface /home/kde-devel/kde5/include/KParts/MainWindow /home/kde-devel/kde5/include/KParts/BrowserOpenOrSaveQuestion /home/kde-devel/kde5/include/KParts/Event /home/kde-devel/kde5/include/KParts/BrowserRun /home/kde-devel/kde5/include/KParts/HtmlExtension /home/kde-devel/kde5/include/KParts/FileInfoExtension /home/kde-devel/kde5/include/KParts/StatusBarExtension /home/kde-devel/kde5/include/KParts/Part /home/kde-devel/kde5/include/KParts/Plugin /home/kde-devel/kde5/include/kparts/kparts_export.h /home/kde-devel/kde5/include/kparts/part.h /home/kde-devel/kde5/include/kparts/plugin.h /home/kde-devel/kde5/include/kparts/partmanager.h /home/kde-devel/kde5/include/kparts/mainwindow.h /home/kde-devel/kde5/include/kparts/event.h /home/kde-devel/kde5/include/kparts/browserextension.h /home/kde-devel/kde5/include/kparts/historyprovider.h /home/kde-devel/kde5/include/kparts/browserinterface.h /home/kde-devel/kde5/include/kparts/browserrun.h /home/kde-devel/kde5/include/kparts/statusbarextension.h /home/kde-devel/kde5/include/kparts/browseropenorsavequestion.h /home/kde-devel/kde5/include/kparts/scriptableextension.h /home/kde-devel/kde5/include/kparts/textextension.h /home/kde-devel/kde5/include/kparts/htmlextension.h /home/kde-devel/kde5/include/kparts/fileinfoextension.h /home/kde-devel/kde5/include/kparts/listingextension.h /home/kde-devel/kde5/include/kparts/componentfactory.h /home/kde-devel/kde5/include/kparts/genericfactory.h /home/kde-devel/kde5/include/kparts/factory.h /home/kde-devel/kde5/include/KDE/KParts/BrowserExtension /home/kde-devel/kde5/include/KDE/KParts/BrowserHostExtension /home/kde-devel/kde5/include/KDE/KParts/BrowserInterface /home/kde-devel/kde5/include/KDE/KParts/BrowserRun /home/kde-devel/kde5/include/KDE/KParts/ComponentFactory /home/kde-devel/kde5/include/KDE/KParts/DockMainWindow3 /home/kde-devel/kde5/include/KDE/KParts/Event /home/kde-devel/kde5/include/KDE/KParts/Factory /home/kde-devel/kde5/include/KDE/KParts/FileInfoExtension /home/kde-devel/kde5/include/KDE/KParts/GUIActivateEvent /home/kde-devel/kde5/include/KDE/KParts/GenericFactory /home/kde-devel/kde5/include/KDE/KParts/GenericFactoryBase /home/kde-devel/kde5/include/KDE/KParts/HistoryProvider /home/kde-devel/kde5/include/KDE/KParts/HtmlExtension /home/kde-devel/kde5/include/KDE/KParts/LiveConnectExtension /home/kde-devel/kde5/include/KDE/KParts/ListingExtension /home/kde-devel/kde5/include/KDE/KParts/MainWindow /home/kde-devel/kde5/include/KDE/KParts/OpenUrlEvent /home/kde-devel/kde5/include/KDE/KParts/Part /home/kde-devel/kde5/include/KDE/KParts/PartActivateEvent /home/kde-devel/kde5/include/KDE/KParts/PartBase /home/kde-devel/kde5/include/KDE/KParts/PartManager /home/kde-devel/kde5/include/KDE/KParts/PartSelectEvent /home/kde-devel/kde5/include/KDE/KParts/Plugin /home/kde-devel/kde5/include/KDE/KParts/ReadOnlyPart /home/kde-devel/kde5/include/KDE/KParts/ReadWritePart /home/kde-devel/kde5/include/KDE/KParts/StatusBarExtension /home/kde-devel/kde5/include/KDE/KParts/TextExtension /home/kde-devel/kde5/include/KDE/KParts/WindowArgs Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113677: Fix standalone build of KUnitConversion
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113677/ --- (Updated Nov. 6, 2013, 3:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Specify the different dependencies so it builds. Diffs - tier3/kunitconversion/CMakeLists.txt 6895079 Diff: http://git.reviewboard.kde.org/r/113677/diff/ Testing --- Builds, installs and tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113681: Fix xmlgui standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/#review43172 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 6, 2013, 3:09 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/ --- (Updated Nov. 6, 2013, 3:09 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix xmlgui standalone build Diffs - superbuild/CMakeLists.txt e965cc8 tier3/xmlgui/CMakeLists.txt b2b9446 tier3/xmlgui/XmlGuiConfig.cmake.in 7761565 tier3/xmlgui/src/CMakeLists.txt fb319c0 tier3/xmlgui/tests/krichtexteditor/CMakeLists.txt 8448e4f Diff: http://git.reviewboard.kde.org/r/113681/diff/ Testing --- Builds alone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Adds all the dependencies so it can be compiled. Diffs - staging/kio/src/core/kprotocolmanager.h af8c8a8 tier3/kparts/CMakeLists.txt 77557bf tier3/kparts/autotests/CMakeLists.txt d47a821 tier3/kparts/src/browserrun.h 9038fd4 tier3/kparts/tests/CMakeLists.txt 1e675f0 Diff: http://git.reviewboard.kde.org/r/113686/diff/ Testing --- Builds, installs, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113692: Fix kjsembed standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113692/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Just find the dependencies. Diffs - tier3/kjsembed/CMakeLists.txt c7a3040 Diff: http://git.reviewboard.kde.org/r/113692/diff/ Testing --- Builds, installs, I can run the test. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113693: Fix KNotifyConfig standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Add the dependencies of dependencies. Small fixes. Diffs - tier3/knotifyconfig/CMakeLists.txt 8be2ceb tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 Diff: http://git.reviewboard.kde.org/r/113693/diff/ Testing --- Builds, installs, the test seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113694: Fix KNewStuff standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Adds dependencies to make sure KNewStuff can be compiled alone Diffs - tier3/knewstuff/CMakeLists.txt f7f4dfa Diff: http://git.reviewboard.kde.org/r/113694/diff/ Testing --- Builds and installs. All tests are commented out. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113657: Fix Standalone Configuration of DNSSD
On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: It's going in the right direction, but I am wondering whether the Find*.cmake files should go to extra-cmake-modules instead of being part of the framework. You should add Steve (skelly) to the review to get his opinion. Well, the idea was to have them all in extra-cmake-modules. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43202 --- On Nov. 6, 2013, 12:36 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 6, 2013, 12:36 a.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kdelibs Description --- Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version. Diffs - cmake/modules/CMakeLists.txt 7910270 cmake/modules/FindAvahi.cmake cmake/modules/FindDNSSD.cmake 8604bd5 tier2/dnssd/CMakeLists.txt 2cfcc40 Diff: http://git.reviewboard.kde.org/r/113657/diff/ Testing --- 1. Configure with cmake 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113702: Fix KEmoticons standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43211 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 7, 2013, 10:47 a.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 7, 2013, 10:47 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make KEmoticons build standalone. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kemoticons/CMakeLists.txt bc2812b tier3/kemoticons/autotests/CMakeLists.txt c88a288 tier3/kemoticons/src/core/CMakeLists.txt 556d9bb Diff: http://git.reviewboard.kde.org/r/113702/diff/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113695: Fix KDEWebKit standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/ --- (Updated Nov. 7, 2013, 12:38 p.m.) Review request for KDE Frameworks. Changes --- Add the superbuild bits Repository: kdelibs Description --- Adds missing dependencies, small other fixes. Diffs (updated) - superbuild/CMakeLists.txt 90688f6 tier3/kdewebkit/CMakeLists.txt b56e71d tier3/kdewebkit/src/CMakeLists.txt c48b7ed Diff: http://git.reviewboard.kde.org/r/113695/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113694: Fix KNewStuff standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/ --- (Updated Nov. 7, 2013, 1:04 p.m.) Review request for KDE Frameworks. Changes --- add superbuild Repository: kdelibs Description --- Adds dependencies to make sure KNewStuff can be compiled alone Diffs (updated) - superbuild/CMakeLists.txt 90688f6 tier3/knewstuff/CMakeLists.txt f7f4dfa Diff: http://git.reviewboard.kde.org/r/113694/diff/ Testing --- Builds and installs. All tests are commented out. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
