Re: git review
On Thu, Aug 09, 2012 at 08:57:01AM -0500, Norbert Thiebaud wrote: > no it would not, because if I swith to branch 3-5... what version do I > have then ? If you switch -- the same. ./download would install it into solenv/bin, which is not changed by git checkout. Also I would suggest to backport that to all branches -- it wont affect the build anyway, so should be easy to review. > not to mention have n-copy of it (I do have typically half-a dozen of > clone of core...)... yeah the src directory can be share... still. I > tend to do make clean a lot... so I would have to rebuild it every > time to make sure it is there when I need it ? Well, I doubt that small script is the right place to start to look of build dir size. Even killing autodoc will help a lot more. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
On Thu, Aug 9, 2012 at 8:11 AM, Bjoern Michaelsen wrote: > On Thu, Aug 09, 2012 at 07:55:45AM -0500, Norbert Thiebaud wrote: >> I know that michael disagree with me on that, but I prefer dev-tools >> to be in ... dev-tools.git >> one can install it as he see fit. and you get the version you >> want/need regardless where you are in the source tree... > > Well, putting it in ./download would be even better, as it would be living > upstream at openstack. no it would not, because if I swith to branch 3-5... what version do I have then ? not to mention have n-copy of it (I do have typically half-a dozen of clone of core...)... yeah the src directory can be share... still. I tend to do make clean a lot... so I would have to rebuild it every time to make sure it is there when I need it ? Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
Quoting Norbert Thiebaud : On Thu, Aug 9, 2012 at 7:04 AM, Bjoern Michaelsen Thinking a bit about this, another possibility would be to do with git-review as we do with other external stuff: Downloading and installing a local copy in "./download". That would ensure it to be universally available and be up to date. I know that michael disagree with me on that, but I prefer dev-tools to be in ... dev-tools.git one can install it as he see fit. and you get the version you want/need regardless where you are in the source tree... Well to put it in dev-tool is much less painfull as to put it elsewhere. Note this tool must be in your PATH! For all branches. And even if you switch the branches and no matter what your current directory is, you must be able to say: git review --dry-run that it. But who is the person who will put it in dev-tools once and update it all the time? (Last time i contributed to git-review was today morning). But even if that person (not me) or some cron jobs continuously synchronize it, the user must still update it. So the user must now periodically update dev-tool to get the fresh version of git-review? But then what is the difference to say git pull dev-tools/git-review or sudo apt-get update upgrade (place here your distro command) or (*) sudo pip install git-review sudo pip install --upgrade git-review sudo pip uninstall git-review (*) http://www.pip-installer.org/en/latest/index.html Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
On Thu, Aug 09, 2012 at 07:55:45AM -0500, Norbert Thiebaud wrote: > I know that michael disagree with me on that, but I prefer dev-tools > to be in ... dev-tools.git > one can install it as he see fit. and you get the version you > want/need regardless where you are in the source tree... Well, putting it in ./download would be even better, as it would be living upstream at openstack. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
On Thu, Aug 9, 2012 at 7:04 AM, Bjoern Michaelsen wrote: > On Wed, Aug 08, 2012 at 11:52:03PM +0200, Bjoern Michaelsen wrote: >> > Like described in link above, you have three options here: >> > pypi-system-wide, pypi-user-local and distro package. >> > No other options please. >> >> Most people wont even know what pypi-system-wide is and dont want to know. >> And >> they shouldnt need to. >> >> We will loose possible contributors that way. Not an option. Patch submittal >> has to work hasslefree and out of the box. This is really critical: there has >> to be no extra step at all for patch submittal otherwise we failed. > > Thinking a bit about this, another possibility would be to do with git-review > as we do with other external stuff: > Downloading and installing a local copy in "./download". That would ensure it > to be universally available and be up to date. I know that michael disagree with me on that, but I prefer dev-tools to be in ... dev-tools.git one can install it as he see fit. and you get the version you want/need regardless where you are in the source tree... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
On Wed, Aug 08, 2012 at 11:52:03PM +0200, Bjoern Michaelsen wrote: > > Like described in link above, you have three options here: > > pypi-system-wide, pypi-user-local and distro package. > > No other options please. > > Most people wont even know what pypi-system-wide is and dont want to know. And > they shouldnt need to. > > We will loose possible contributors that way. Not an option. Patch submittal > has to work hasslefree and out of the box. This is really critical: there has > to be no extra step at all for patch submittal otherwise we failed. Thinking a bit about this, another possibility would be to do with git-review as we do with other external stuff: Downloading and installing a local copy in "./download". That would ensure it to be universally available and be up to date. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
On Thu, Aug 09, 2012 at 09:15:48AM +0200, Jan Holesovsky wrote: > David Tardon píše v Čt 09. 08. 2012 v 07:17 +0200: > > > > It has worked hasslefree and out of the box while we have been using > > email. > > > > It was a precondition for the gerrit work that the email submission + > direct push must still be possible, and I for one will make sure this is > still so ;-) Agreed. gerrit is a platform and it should integrate all kind of workflows whether they are email-based, web-based, CLI-based, IRC-based or whatever. That doesnt mean the 'gerrit guys' will implement every of your pet features there, but we have to make the basic workflow available there. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
Hi David, David Tardon píše v Čt 09. 08. 2012 v 07:17 +0200: > > We will loose possible contributors that way. Not an option. Patch submittal > > has to work hasslefree and out of the box. This is really critical: there > > has > > to be no extra step at all for patch submittal otherwise we failed. > > > It has worked hasslefree and out of the box while we have been using > email. > It was a precondition for the gerrit work that the email submission + direct push must still be possible, and I for one will make sure this is still so ;-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
Hi, On Wed, Aug 08, 2012 at 11:52:03PM +0200, Bjoern Michaelsen wrote: > On Wed, Aug 08, 2012 at 11:19:09PM +0200, David Ostrovsky wrote: > > Like described in link above, you have three options here: > > pypi-system-wide, pypi-user-local and distro package. > > No other options please. > > Most people wont even know what pypi-system-wide is and dont want to know. And > they shouldnt need to. > > We will loose possible contributors that way. Not an option. Patch submittal > has to work hasslefree and out of the box. This is really critical: there has > to be no extra step at all for patch submittal otherwise we failed. It has worked hasslefree and out of the box while we have been using email. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
On Wed, Aug 08, 2012 at 11:19:09PM +0200, David Ostrovsky wrote: > > But IMHO git-review MUST work out of the box then -- without any setup. > No! You don't dump a copy of git, bash and binutils, don't you? Because they are install with ~all systems and are available on all system as a nicely maintained package. Thats is not the case for git-review yet. Besides, it is small and we should have in our repos anyway for safety when it becomes part of our infrastructure. Besides we _have_ copies of boost, glib, expat and openssl in our repos for valid reasons. > Like described in link above, you have three options here: > pypi-system-wide, pypi-user-local and distro package. > No other options please. Most people wont even know what pypi-system-wide is and dont want to know. And they shouldnt need to. We will loose possible contributors that way. Not an option. Patch submittal has to work hasslefree and out of the box. This is really critical: there has to be no extra step at all for patch submittal otherwise we failed. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git review
Hi Bjoern, On 02.08.2012 23:21, Bjoern Michaelsen wrote: http://wiki.documentfoundation.org/Development/GitReview so: - what are the experiences? - should we recommend it in general? I am really happy with git review. It has killer features that i don't want to miss anymore, in fact they saved my life (and some other guys too ,-) To name the few: 1. called with git review -s (once) it does all the setup for your. It even checks if you have commit-msg hook in place and download and install one, if you don't! 2. it checks if your commit has Change-Id and ammend to recrate it, in case you commited before installing commit-msg hook. 3. it has --dry-run option and shows you what it would do without actually doing anything (like git push command) 4. and last but not least it really save your life by checking how much commits your are going to upload and warn and ask for confirmation if the count is > 1. [...] I would suggest, if possible, to dump a copy that can work standalone into the core repo root. Even if it might be outdated compared to openstack its likely better in the long run than ./logerrit for submittal. But IMHO git-review MUST work out of the box then -- without any setup. No! You don't dump a copy of git, bash and binutils, don't you? Like described in link above, you have three options here: pypi-system-wide, pypi-user-local and distro package. No other options please. [...] (*) plus patching to provide something like "./logerrit resubmit" i just uploaded the git-review patch: https://review.openstack.org/#/c/11046/ So the simultaneous submissions to release branch and direct push to master should be possible now (once openstack guys apporved my change). And hej, my patch in git-review was shorter then your in logerrit ;-) Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
git review (was: [Libreoffice-qa] minutes of ESC call ...)
Hi all, On Thu, Aug 02, 2012 at 05:52:16PM +0100, Michael Meeks wrote: > ESC minutes here is a topic for the next ESC call. Quite a few of you have already used: http://wiki.documentfoundation.org/Development/GitReview so: - what are the experiences? - should we recommend it in general? I think there are two scenarios we want to consider. newcomer/casual contributor/submitter: - should work out of the box (without install) for simple patch upload - should be most trivial (no complex switches or parameters) - does not need to provide review capabilities (the web UI is perfectly suited for a first attempt at a review, CLI is only interesting for mass review) core dev/reviewer: - an one time setup cost doesnt hurt too bad - can some more complexity for addiional features - mass review from the CLI should be possible Ignoring the second group for now (they will create their own Python/Perl/Haskell/Brainfuck scripting in the end anyway). If the feedback by current users of git review is positive and deemed suitable for firsttime users, I would suggest, if possible, to dump a copy that can work standalone into the core repo root. Even if it might be outdated compared to openstack its likely better in the long run than ./logerrit for submittal. But IMHO git-review MUST work out of the box then -- without any setup. @David: Do you think git-review allows that? For reviewers, we keep the ./logerrit sceleton around (removing all submittal functionality) - not so much because its an excellent client, but as template fro whatever scripting reviewers write themselves in the end. Best, Bjoern (*) plus patching to provide something like "./logerrit resubmit" ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[master]: git-review integration: .gitreview for core repository added
>From Björn Michaelsen : Björn Michaelsen has posted comments on this change. Change subject: git-review integration: .gitreview for core repository added .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) File .gitreview Line 5: defaultremote=logerrit We are already asking devs to setup an alias: https://wiki.documentfoundation.org/Development/gerrit/setup In the end you need to write something into your .ssh/config for nontrivial work anyway to set the port and the ssh key, so I used an alias there -- esp. to make direct use of the "ssh logerrit gerrit ..." easily possible for (nonscripted) ad-hoc actions. -- To view, visit https://gerrit.libreoffice.org/262 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb72ef80f66f1d84a764bdc2629ad45f14acfe7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Ostrovsky Gerrit-Reviewer: Björn Michaelsen Gerrit-Reviewer: James E. Blair Gerrit-Reviewer: Michael Stahl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[master]: git-review integration: .gitreview for core repository added
>From James E. Blair : James E. Blair has posted comments on this change. Change subject: git-review integration: .gitreview for core repository added .. Patch Set 1: (3 inline comments) Hi. Hope you don't mind, I left a couple of inline comments. File .gitreview Line 2: host=logerrit If you set this to 'gerrit.libreoffice.org', you won't need an ssh host alias (but then you might need to set the gerrit username either using git config or by manually entering it, if your username is different than your workstation login). Even so, that strikes me as being preferable to requiring an ssh host alias. Line 5: defaultremote=logerrit This will cause git-review to use "logerrit" as the name of the git remote, instead of "gerrit". That's fine, but I'm curious why? Line 6: defaultbranch=master This should already be the default, but I guess it doesn't hurt. -- To view, visit https://gerrit.libreoffice.org/262 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb72ef80f66f1d84a764bdc2629ad45f14acfe7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Ostrovsky Gerrit-Reviewer: Björn Michaelsen Gerrit-Reviewer: James E. Blair Gerrit-Reviewer: Michael Stahl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[master]: git-review integration: .gitreview for core repository added
>From David Ostrovsky : David Ostrovsky has uploaded a new change for review. Change subject: git-review integration: .gitreview for core repository added .. git-review integration: .gitreview for core repository added Change-Id: Iecb72ef80f66f1d84a764bdc2629ad45f14acfe7 --- A .gitreview 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/262/1 -- To view, visit https://gerrit.libreoffice.org/262 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iecb72ef80f66f1d84a764bdc2629ad45f14acfe7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Ostrovsky ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
