Re: LyX 1.5.x Patch Candidate List #7
On Fri, Nov 02, 2007 at 12:51:46AM +0100, Michael Gerz wrote: > Hi, > > any comments are welcome. > > Thanks, Michael > > > > Patch Candidate List #7 > > Approved by Jürgen > -- > http://www.lyx.org/trac/changeset/20692 - Allow dissolution of insets inside > mathed Yes, why not > Supported by author > --- > > > New > --- > http://www.lyx.org/trac/changeset/21214 - Fix ERT blanks doubling bug Irrelevant > http://www.lyx.org/trac/changeset/21267 - Update current font when moving > cursor by clicking mouse No, fixes new (trunk-only) bug > http://www.lyx.org/trac/changeset/21293 - Fix line count off-by-one for > single-par verbatims No, new bug > http://www.lyx.org/trac/changeset/21294 - Fix thinko: we need to apply the > default font here, not the inset's font commands No, trunk-specific > http://www.lyx.org/trac/changeset/21295 - const, sorry No > http://www.lyx.org/trac/changeset/21316 - NeedProtect inside Index inset No - Martin
docstring help needed
Enrico wrote today: > Now waiting for the next bug associated > to unsigned chars and docstreams. There's a potential problem in Hyperlink.cpp I'm not able to fix: http://www.lyx.org/trac/changeset/21352 Could anybody please help me here? I can't get it to work when I change to char_type, I get then countless compiler errors I don't understand. char_type is not really needed here because the characters in the list are ASCII and the list a const. But docstring wants char_type. At the moment the hyperlink stuff is stable, I can even use Vietnamese double-accent characters in the dialog and it works. But would like to have it correct and btw. learn how this is done. thanks and regards Uwe
Re: LyX 1.5.x Patch Candidate List #7
> ? http://www.lyx.org/trac/changeset/20825 - languages: - add comment for Hungarian and correct its > name in LyX - whitespace fixes - add comments for Sorbian - disable Upper Sorbian as this is > broken, see bug http://bugzilla.lyx.org/show_bug.cgi?id=4257 No, would be a fileformat change. > ? http://www.lyx.org/trac/changeset/20959 - ERTUi.ui: fix dialog size Maybe but not that important. > http://www.lyx.org/trac/changeset/21136 - configure.py, legacy_lyxpreview2ppm.py, > lyxpreview2bitmap.py: check also for "platex" (Japanese variant of "latex"); patch by Koji Wouldn't be an advantage since the other prerequisites needed for proper Japanese support can ans should not go to branch. Depends on 21136. > http://www.lyx.org/trac/changeset/21247 - InsetMathFrac: add support for \tbinom and \dbinom, > fixes bug 4305 Minor and new feature. I could try to backport it if this is really wanted. > http://www.lyx.org/trac/changeset/21137 - configure.py: correct previous commit > http://www.lyx.org/trac/changeset/21295 - const, sorry Why do you list this type ofcommits in this list? In general, I usually send patches for branch when I think it helps to stabilize the stable series. So when I commit things anly to trunk, there are reasons against branch (fileformat, new feature). regards Uwe
Re: [Patch] Bug 2739 - Alphabetical sort of environments in the toolbar
> > JMarc, do you plan to commit it ? > > Me? No, I did not! But if nobody did anything on monday, I'll do it. please. pavel
Re: Translation problem: "cc" has two different meanings, but only one translation
> What is the correct way to do this? you can not do this until somebody changes string in source code using [[]] . > Also, please don't update nb.po in svn right now. this is not problem, you can post the entire .po file if merge conflict appears. pavel
LyX 1.5.x Patch Candidate List #7
Hi, any comments are welcome. Thanks, Michael Patch Candidate List #7 Approved by Jürgen -- http://www.lyx.org/trac/changeset/20419 - GuiApplication::notify(): don't crash with abort() but exit gracefully when an exception is caught. try to catch LyX specific exceptions. http://www.lyx.org/trac/changeset/20531 - Gives the user some information about the crash. http://www.lyx.org/trac/changeset/20437 - Remove redundant AlignPossible? lines http://www.lyx.org/trac/changeset/20438 - Disallow setting of alignment in protected environments, where it is broken. http://www.lyx.org/trac/changeset/20692 - Allow dissolution of insets inside mathed http://www.lyx.org/trac/changeset/20728 - the singlepar optimization (r20567) (TESTING REQUIRED!) http://www.lyx.org/trac/changeset/20890 - fix bug reported by Jean-Marc http://www.lyx.org/trac/changeset/20903 - initial support for shift + right-mouse-click selection. (TESTING REQUIRED) http://www.lyx.org/trac/changeset/20891 - thinko (already committed to branch???) http://www.lyx.org/trac/changeset/20892 - shut up (already committed to branch???) Supported by author --- New --- ? http://www.lyx.org/trac/changeset/20825 - languages: - add comment for Hungarian and correct its name in LyX - whitespace fixes - add comments for Sorbian - disable Upper Sorbian as this is broken, see bug http://bugzilla.lyx.org/show_bug.cgi?id=4257 http://www.lyx.org/trac/changeset/20895 - Crash fix. I don't know why this is triggered only now... I guess someone changed the way toolbars are initialized. The changes are safer anyway. http://www.lyx.org/trac/changeset/20897 - fix in r20895 was not fully correct. ? http://www.lyx.org/trac/changeset/20916 - add "copy to clipboard" button to log dialog http://www.lyx.org/trac/changeset/20917 - small facelift for close button on tabwidget ? http://www.lyx.org/trac/changeset/20959 - ERTUi.ui: fix dialog size ? http://www.lyx.org/trac/changeset/20996 - Change how InsetBibTeX does this check. http://www.lyx.org/trac/changeset/21116 - Fix a warning that is potentially a bug (!= used instead of |=). http://www.lyx.org/trac/changeset/21136 - configure.py, legacy_lyxpreview2ppm.py, lyxpreview2bitmap.py: check also for "platex" (Japanese variant of "latex"); patch by Koji http://www.lyx.org/trac/changeset/21137 - configure.py: correct previous commit http://www.lyx.org/trac/changeset/21177 - bug fix. http://www.lyx.org/trac/changeset/21179 - * layouts/ijmpd.layout: * layouts/amsmaths.inc: do not use the notation @Section@ for LabelString. http://www.lyx.org/trac/changeset/21214 - Fix ERT blanks doubling bug http://www.lyx.org/trac/changeset/21225 - Fix IEEEtran layout by loading counters before the sectioning styles, in order to avoid having sections numbered as 0.X instead of simply X. http://www.lyx.org/trac/changeset/21247 - InsetMathFrac: add support for \tbinom and \dbinom, fixes bug 4305 http://www.lyx.org/trac/changeset/21267 - Update current font when moving cursor by clicking mouse http://www.lyx.org/trac/changeset/21272 - unbreak font panel http://www.lyx.org/trac/changeset/21287 - src/frontends/qt4/GuiSearch.cpp: - use selectAll function instead of home-brewn method. http://www.lyx.org/trac/changeset/21293 - Fix line count off-by-one for single-par verbatims http://www.lyx.org/trac/changeset/21294 - Fix thinko: we need to apply the default font here, not the inset's font commands http://www.lyx.org/trac/changeset/21295 - const, sorry http://www.lyx.org/trac/changeset/21316 - NeedProtect inside Index inset http://www.lyx.org/trac/changeset/21322 - * monochrome rendering support. You can set two color, the min and max.
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 08:57:40PM +0100, Abdelrazak Younes wrote:
> Is that Myshkin?
In latex, it would be My\v{s}kin, but my ignorance didn't let me use
the correct transliteration ;-) Now let's stop here and go forward.
--
Enrico
[patch] pixmap cache goes rc
The attached patch implements a pref option to enable the pixmap cache on
Windows and the Mac (it is now disabled by default).
I cannot really test, since I'm on Linux. Could someone do this and check
that it works?
I do not plan to forwardport this to trunk ATM, since Abdel maybe has
different plans. It can be done easily, if needed.
Jürgen
Index: src/LyXRC.h
===
--- src/LyXRC.h (Revision 21308)
+++ src/LyXRC.h (Arbeitskopie)
@@ -139,6 +139,7 @@
RC_USE_ESC_CHARS,
RC_USE_INP_ENC,
RC_USE_PERS_DICT,
+ RC_USE_PIXMAP_CACHE,
RC_USE_SPELL_LIB,
RC_VIEWDVI_PAPEROPTION,
RC_VIEWER,
@@ -289,6 +290,8 @@
bool isp_use_alt_lang;
/// Use personal dictionary?
bool isp_use_pers_dict;
+ /// Use pixmap cache?
+ bool use_pixmap_cache;
/// Use escape chars?
bool isp_use_esc_chars;
/// Alternate language for ispell
Index: src/frontends/qt4/QLPainter.cpp
===
--- src/frontends/qt4/QLPainter.cpp (Revision 21308)
+++ src/frontends/qt4/QLPainter.cpp (Arbeitskopie)
@@ -23,6 +23,7 @@
#include "debug.h"
#include "Language.h"
#include "Color.h"
+#include "LyXRC.h"
#include "support/unicode.h"
@@ -45,7 +46,7 @@
namespace {
-bool const usePixmapCache = USE_PIXMAP_CACHE;
+bool const usePixmapCache = (lyxrc.use_pixmap_cache && USE_PIXMAP_CACHE);
QString generateStringSignature(QString const & str, Font const & f)
{
Index: src/frontends/qt4/ui/PrefUi.ui
===
--- src/frontends/qt4/ui/PrefUi.ui (Revision 21308)
+++ src/frontends/qt4/ui/PrefUi.ui (Arbeitskopie)
@@ -5,14 +5,12 @@
0
0
-459
-425
+464
+497
-
-1
-1
+
0
0
@@ -21,70 +19,6 @@
-
-9
-
-
-6
-
-
-
-
- Scrolling
-
-
- Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop
-
-
-
- 11
-
-
- 6
-
-
-
-
- Cursor follows &scrollbar
-
-
-
-
-
-
- Qt::Vertical
-
-
-
- 20
- 40
-
-
-
-
-
-
-
-
-
-
- Qt::Vertical
-
-
-
- 20
- 40
-
-
-
-
-
-
-
- B&rowse...
-
-
-
@@ -95,6 +29,16 @@
+
+
+
+
+
+
+ Bro&wse...
+
+
+
@@ -105,25 +49,20 @@
-
-
+
+
-
-
+
+
- Bro&wse...
+ B&rowse...
-
-
-
-
- 5
- 5
+
0
0
@@ -132,12 +71,24 @@
Session
-
+
9
-
+
+ 9
+
+
+ 9
+
+
+ 9
+
+
6
+
+ 6
+
@@ -190,12 +141,21 @@
-
- 0
-
6
+
+ 0
+
+
+ 0
+
+
+ 0
+
+
+ 0
+
@@ -227,12 +187,12 @@
false
+
+ 200
+
-
- 200
-
10
@@ -253,12 +213,12 @@
false
+
+ 200
+
-
- 200
-
10
@@ -285,18 +245,27 @@
-
+
Documents
-
- 11
-
6
+
+ 11
+
+
+ 11
+
+
+ 11
+
+
+ 11
+
@@ -306,12 +275,21 @@
-
- 0
-
6
+
+ 0
+
+
+ 0
+
+
+ 0
+
+
+ 0
+
@@ -340,12 +318,12 @@
+
+ 1
+
300
-
- 1
-
@@ -359,12 +337,21 @@
-
- 0
-
6
+
+ 0
+
+
+ 0
+
+
+ 0
+
+
+ 0
+
@@ -387,6 +374,85 @@
+
+
+
+ Scrolling
+
+
+ Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop
+
+
Re: [patch] Putting ForceLTR to use
On Thu, Nov 01, 2007 at 11:24:37PM +0200, Dov Feldstern wrote:
> Dov Feldstern wrote:
>> Richard Heck wrote:
>>> Some silly comments.
+/// is this inset based on the CollapsableInset class?
+virtual InsetCollapsable * asCollapsableInset() { return 0; }
+/// is this inset based on the CollapsableInset class?
+virtual InsetCollapsable const * asCollapsableInset() const {
return 0; }
>>> Probably should be asInsetCollapsable().
>> Hmm, yes. I tried to conform to the example of asTextInset, but I now
>> notice that asInsetMath goes the other way... Should I change asTextInset
>> -> asInsetText, as well?
>
> Ugh, I see that in mathed there are a million asXxxxInset... I'm not going
> to start switching all of those! But asInsetCollapsable and asInsetText I
> guess I'll change...
That's beacuse the math insets changed names, and the asFooInset busines
originated in mathed.
Andre'
Re: [patch] Putting ForceLTR to use
On Thu, Nov 01, 2007 at 10:58:29PM +0200, Dov Feldstern wrote:
> Richard Heck wrote:
>> Some silly comments.
>>> +/// is this inset based on the CollapsableInset class?
>>> +virtual InsetCollapsable * asCollapsableInset() { return 0; }
>>> +/// is this inset based on the CollapsableInset class?
>>> +virtual InsetCollapsable const * asCollapsableInset() const { return
>>> 0; }
>>>
>> Probably should be asInsetCollapsable().
>
> Hmm, yes. I tried to conform to the example of asTextInset, but I now
> notice that asInsetMath goes the other way... Should I change asTextInset
> -> asInsetText, as well?
Yes, please.
Andre'
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 07:37:26PM +0100, Abdelrazak Younes wrote:
> Abdelrazak Younes wrote:
>> Andre Poenitz wrote:
>>> On Wed, Oct 31, 2007 at 06:25:31PM +0100, Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> If somebody use the docstream with latin8 character we will have bugs
> for sure.
How could we forbid 8bit chars to operator<>>> private version?
>>>
>>> Sort of. Declare but not implement it.
>> Problem is... that it is already implemented:
>> inline
>> odocstream & operator<<(odocstream & os, char c)
>> {
>> os.put(c);
>> return os;
>> }
>> Putting an BOOST_ASSERT(false) here or throwing an exception would achieve
>> what you want JMarc.
>
> But we cannot do that right now because this operator is used by mathed.
> Andre', I think the next big thing in mathed is to move to unicode and to
> remove any font related business from there.
I am not stopping you... ;-}
Andre'
Re: [patch] Putting ForceLTR to use
Dov Feldstern wrote:
Richard Heck wrote:
Some silly comments.
+/// is this inset based on the CollapsableInset class?
+virtual InsetCollapsable * asCollapsableInset() { return 0; }
+/// is this inset based on the CollapsableInset class?
+virtual InsetCollapsable const * asCollapsableInset() const {
return 0; }
Probably should be asInsetCollapsable().
Hmm, yes. I tried to conform to the example of asTextInset, but I now
notice that asInsetMath goes the other way... Should I change
asTextInset -> asInsetText, as well?
Ugh, I see that in mathed there are a million asXxxxInset... I'm not
going to start switching all of those! But asInsetCollapsable and
asInsetText I guess I'll change...
+///
+InsetCollapsable * asCollapsableInset() { return this; }
+///
+InsetCollapsable const * asCollapsableInset() const { return
this; }
and similarly.
rh
Re: fix LFUN_LANGUAGE bug, due to Font/Language separation
Mael Hilléreau wrote: Le 31 oct. 07 à 08:40, Abdelrazak Younes a écrit : Perhaps a better solution would be to further separate between Font and Language, by changing toggleFree to deal with them in a totally separate manner, or even to have separate functions for the language and font. Right, separate functions is what we should aim at. Dov, I'm really not surprised to hear about that at this point! Where is the simplification? I presume that next step should be to separate concepts as well, i.e. use char sets (insets, why not) in place of char attributes... ;-) If anyone feels like looking into this, feel free. This should be a mid-term goal. You, as a proponent of char attributes (for spelling, styles, etc) should be interested in doing that ;-) lol Mael. Mael, long time no speak! I was worried that I had scared you away (from the mailing list, if not entirely from LyX) with the ignore-spelling business... Glad to see you're still around. Dov
Re: fix LFUN_LANGUAGE bug, due to Font/Language separation
Abdelrazak Younes wrote: Dov Feldstern wrote: Perhaps a better solution would be to further separate between Font and Language, by changing toggleFree to deal with them in a totally separate manner, or even to have separate functions for the language and font. Right, separate functions is what we should aim at. If anyone feels like looking into this, feel free. This should be a mid-term goal. You, as a proponent of char attributes (for spelling, styles, etc) should be interested in doing that ;-) Yeah, sure. I'll probably get to it around 1.8 or 1.9... ;) The truth is, I still haven't made up my mind as to whether Language and Font should really be separate or not. So I can go either way at this point. If/when I take a better look at this issue, maybe I'll clean this up... For now, I'm content with the fact that my current fix is acceptable. Abdel. Dov
Re: [patch] Putting ForceLTR to use
Martin Vermeer wrote:
Hmmm, I see the ERT calls its own version of resetParagraphsFont(). I
believe it can be removed so it uses the InsetCollapsable one. Saves a
few lines. (I think I planned on doing this, but forgot.)
That doesn't impact this patch, though, does it? Here I'm using the
ForceLTR for opening an extra \L{ when necessary; but I don't want such
an environment to be opened for ERT. That's what this exception here is
for. This has nothing to do with resetParagraphsFont() AFAIU.
+// ERT is an exception, since it doesn't go to output
+&& inset->lyxCode() != ERT_CODE))
&& running_font.isRightToLeft()) {
if (running_font.language()->lang() == "farsi")
os << "\\beginL{}";
- Martin
Re: [patch] Putting ForceLTR to use
Richard Heck wrote:
Some silly comments.
+/// is this inset based on the CollapsableInset class?
+virtual InsetCollapsable * asCollapsableInset() { return 0; }
+/// is this inset based on the CollapsableInset class?
+virtual InsetCollapsable const * asCollapsableInset() const {
return 0; }
Probably should be asInsetCollapsable().
Hmm, yes. I tried to conform to the example of asTextInset, but I now
notice that asInsetMath goes the other way... Should I change
asTextInset -> asInsetText, as well?
+///
+InsetCollapsable * asCollapsableInset() { return this; }
+///
+InsetCollapsable const * asCollapsableInset() const { return this; }
and similarly.
rh
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 07:30:50PM +0100, Abdelrazak Younes wrote: Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 07:11:05PM +0100, Juergen Spitzmueller wrote: Enrico Forestieri wrote: If you think so, then a combination of the two patches is ok. You mean what Abdel committed to trunk? Yes, that solves this bug. Now waiting for the next bug associated to unsigned chars and docstreams. That's exactly why I proposed that your patch should probably go in anyway. But you are too focused on demonstrating your cleverness that you missed that... Please, understand that I don't feel/have to demonstrate anything, but I surely don't feel like a prince Myskin. Is that Myshkin? http://en.wikipedia.org/wiki/Prince_Myshkin No, Enrico, I know you are not an "entirely positive... with an absolutely beautiful nature" person. And I know you are not an idiot either :-) Abdel.
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 07:24:04PM +0100, Abdelrazak Younes wrote: I must say I am disappointed by your attitude Enrico, I just don't understand why you are so sarcastic. Maybe I am just mean. Please accept my apologies. And accept mine. Abdel.
Re: Patch: further clean-up of inset font handling etc.
On Thu, Nov 01, 2007 at 09:05:37AM +0100, [EMAIL PROTECTED] wrote: > On Thu, 1 Nov 2007, Martin Vermeer wrote: > >>> By the way, please use '=' instead of a copy ctor, looks cleaner: > >>> + FontInfo font = inherit_font; > > Just a C++ check, the above still use the copy constructor, right? > (As opposed to assignment) Yes. Formally it is construction of a temporary, followed by copy construction. The copy construction can be omitted by the optimizer (even if there were side effects(!)), so this is what is done by non-antique compilers. Andre'
Re: [Cvslog] r21312 - in /lyx-devel/trunk/src: BranchList.h BufferView...
On Thu, Nov 01, 2007 at 01:06:21AM +0100, Stefan Schimanski wrote: >> /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp: In function >> 'const lyx::docstring lyx::_(const std::string&)': >> /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp:20: error: >> return type 'const struct lyx::docstring' is incomplete >> /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp: In function >> 'const lyx::docstring lyx::_(const std::string&)': >> /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp:22: error: >> invalid use of undefined type 'const struct lyx::docstring' >> /Users/sts/Quellen/mac/dynmacro16/src/support/strfwd.h:24: error: >> declaration of 'const struct lyx::docstring' >> >> Probably some missing header, but am too tired now to search for the exact >> reason. > > Was simple, just the docstring.h include was missing. Yes, that was the plan. > André, I guess your forward declaration would not be enough here > because no reference or pointer was returned? I don't think it is needed. I'll try to look it up, though. Andre'
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 07:30:50PM +0100, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Thu, Nov 01, 2007 at 07:11:05PM +0100, Juergen Spitzmueller wrote: > > > >> Enrico Forestieri wrote: > >> > >>> If you think so, then a combination of the two patches is ok. > >> You mean what Abdel committed to trunk? > > > > Yes, that solves this bug. Now waiting for the next bug associated > > to unsigned chars and docstreams. > > That's exactly why I proposed that your patch should probably go in > anyway. But you are too focused on demonstrating your cleverness that > you missed that... Please, understand that I don't feel/have to demonstrate anything, but I surely don't feel like a prince Myskin. -- Enrico
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 07:24:04PM +0100, Abdelrazak Younes wrote: > I must say I am disappointed by your attitude Enrico, I just > don't understand why you are so sarcastic. Maybe I am just mean. Please accept my apologies. -- Enrico
Re: [patch] bug 4147: Multiple cells paste as one in tables
Abdelrazak Younes wrote: > I am just a C++ ignorant but I am reasonably confident my change will > work on all platforms. But your change to branch might not be enough... After Enrico's explanations, I'm just about backporting your fix. And please stop that ignorance discourse ;-) Jürgen
Re: [patch] bug 4147: Multiple cells paste as one in tables
Abdelrazak Younes wrote: Andre Poenitz wrote: On Wed, Oct 31, 2007 at 06:25:31PM +0100, Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: If somebody use the docstream with latin8 character we will have bugs for sure. How could we forbid 8bit chars to operator
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 07:11:05PM +0100, Juergen Spitzmueller wrote: Enrico Forestieri wrote: If you think so, then a combination of the two patches is ok. You mean what Abdel committed to trunk? Yes, that solves this bug. Now waiting for the next bug associated to unsigned chars and docstreams. That's exactly why I proposed that your patch should probably go in anyway. But you are too focused on demonstrating your cleverness that you missed that... Abdel.
Re: [Cvslog] r21353 - in /lyx-devel/branches/BRANCH_1_5_X: src/insets/...
Michael Gerz wrote: > Is this patch complete? http://www.lyx.org/trac/changeset/21344 has more > changes. Please read lyx-devel. Jürgen
Re: [patch] bug 4147: Multiple cells paste as one in tables
Juergen Spitzmueller wrote: Abdelrazak Younes wrote: I apply a combination of your two patch Juergen. Enrico might think this is due to ignorance about C++ but this is just ignorance about a bug in the odocstream. For the time being, I just committed my second patch to branch. If Enrico confirms your char->char_type change also works on the problematic systems, we can still do that. I am just a C++ ignorant but I am reasonably confident my change will work on all platforms. But your change to branch might not be enough... Abdel.
Re: [Cvslog] r21353 - in /lyx-devel/branches/BRANCH_1_5_X: src/insets/...
[EMAIL PROTECTED] schrieb: Author: spitz Date: Thu Nov 1 19:02:15 2007 New Revision: 21353 URL: http://www.lyx.org/trac/changeset/21353 Log: * src/insets/InsetTabular.cpp: - handle char correctly for docstream (bug 4147). Modified: lyx-devel/branches/BRANCH_1_5_X/src/insets/InsetTabular.cpp lyx-devel/branches/BRANCH_1_5_X/status.15x Modified: lyx-devel/branches/BRANCH_1_5_X/src/insets/InsetTabular.cpp URL: http://www.lyx.org/trac/file/lyx-devel/branches/BRANCH_1_5_X/src/insets/InsetTabular.cpp?rev=21353 == --- lyx-devel/branches/BRANCH_1_5_X/src/insets/InsetTabular.cpp (original) +++ lyx-devel/branches/BRANCH_1_5_X/src/insets/InsetTabular.cpp Thu Nov 1 19:02:15 2007 @@ -2794,7 +2794,7 @@ if (isPartOfMultiColumn(i, j)) continue; if (onlydata && j > 0) - os << delim; + os.put(delim); plaintextPrintCell(buf, os, runparams, cell, i, j, clen, onlydata); ++cell; Is this patch complete? http://www.lyx.org/trac/changeset/21344 has more changes. Michael
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote:
On Thu, Nov 01, 2007 at 06:05:04PM +0100, Abdelrazak Younes wrote:
Juergen Spitzmueller wrote:
Enrico Forestieri wrote:
It also doesn't work on Windows and FreeBSD, for example. I think it
would be embarrassing explaining it, as this would imply recognizing a
basic ignorance about C++, and this should not be the case.
You refer to my first or my second patch? If to the latter, please don't
hesitate. I'm well aware of my basic ignorance about C++. If you agree my
second patch would be a reasonable and working compromise, I'd propose to
apply this, because it is safer than yours, IMHO.
I apply a combination of your two patch Juergen. Enrico might think this
is due to ignorance about C++ but this is just ignorance about a bug in
the odocstream.
Yea, a bug in C++. LOL!
Re-read please: a bug in the odocstream. AFAIK this is our creature not
part of the C++ STL. The bug would not exist if we'd use the one that is
in the STL (of course we can't because it is not the same on all
platform). I must say I am disappointed by your attitude Enrico, I just
don't understand why you are so sarcastic.
Enrico's patch might be needed for platform were char is unsigned,
It is not.
Good let's remove the other one then.
dunno. But I maintain the assertion is correct.
Your opinion, of course.
Right, everything I say is just my opinion.
We should also put an
assertion here:
inline
odocstream & operator<<(odocstream & os, char c)
{
os.put(c);
return os;
}
I give up.
Me too.
Abdel.
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 07:11:05PM +0100, Juergen Spitzmueller wrote: > Enrico Forestieri wrote: > > > If you think so, then a combination of the two patches is ok. > > You mean what Abdel committed to trunk? Yes, that solves this bug. Now waiting for the next bug associated to unsigned chars and docstreams. -- Enrico
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 05:20:17PM +0100, Abdelrazak Younes wrote: Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 03:54:06PM +0100, Abdelrazak Younes wrote: Juergen Spitzmueller wrote: Abdelrazak Younes wrote: As for adding the possibility to output an unsigned char to the docstream I think this buy us absolutely nothing and that it is not even worth supporting. How about the attached patch? That should do. But I personally prefer you first patch and I'd be interested to know why it doesn't work on cygwin. It also doesn't work on Windows and FreeBSD, for example. Well, as I said, if there is something to fix by passing a char_type instead of an unsigned char, let's just fix it instead of turning around the problem. I must admit I haven't looked closely at the source though. I think it would be embarrassing explaining it, as this would imply recognizing a basic ignorance about C++, and this should not be the case. That is maybe the case. As my ego is not so enormous that I can admit I am stupid when this is the case, please explain me. A typedef name provides an alternative name for an existing data type. It does not create a new data type, so when char_type is typedef'd to boost::uint32_t, you will get an integral representation of the char_type value rather than the corresponding character when outputting to a docstream. And you can't overload a typedef. Pfiou... I am relieved! I guess I am not too stupid at the end as I managed to discover the problem all by myself. But thanks for the humility lessons :-) Abdel.
Re: [Cvslog] r21312 - in /lyx-devel/trunk/src: BranchList.h BufferView...
On Thu, Nov 01, 2007 at 12:49:37AM +0100, Stefan Schimanski wrote: >>> Did I miss anything important? >> >> Just add the missing 's' and commit. > > Did it already. > >> It was in a branch that was not >> active in my build. [What system is that, btw, and to what type is >> boost::uint32_t typedef'd there?] > > It's on Mac, gcc 4.01. How do I find out easily about the typedef? > > And just got another problem: > > /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp: In function > 'const lyx::docstring lyx::_(const std::string&)': > /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp:20: error: return > type 'const struct lyx::docstring' is incomplete > /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp: In function > 'const lyx::docstring lyx::_(const std::string&)': > /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/gettext.cpp:22: error: > invalid use of undefined type 'const struct lyx::docstring' > /Users/sts/Quellen/mac/dynmacro16/src/support/strfwd.h:24: error: > declaration of 'const struct lyx::docstring' > > Probably some missing header, but am too tired now to search for the exact > reason. Declaration of return type should be sufficient. Andre'
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 06:05:04PM +0100, Abdelrazak Younes wrote:
> Juergen Spitzmueller wrote:
> > Enrico Forestieri wrote:
> >
> >> It also doesn't work on Windows and FreeBSD, for example. I think it
> >> would be embarrassing explaining it, as this would imply recognizing a
> >> basic ignorance about C++, and this should not be the case.
> >
> > You refer to my first or my second patch? If to the latter, please don't
> > hesitate. I'm well aware of my basic ignorance about C++. If you agree my
> > second patch would be a reasonable and working compromise, I'd propose to
> > apply this, because it is safer than yours, IMHO.
>
> I apply a combination of your two patch Juergen. Enrico might think this
> is due to ignorance about C++ but this is just ignorance about a bug in
> the odocstream.
Yea, a bug in C++. LOL!
> See comment in docstream.h:
>
> /** Base class for UCS4 output streams.
> If you want to output a single UCS4 character, use \code
> os.put(c);
> \endcode, not \code
> os << c;
> \endcode . The latter will not output the character, but the code point
> as number. This is because we can't overload operator<< (our character
> type is not a real type but a typedef). Narrow characters of type char
> can be output as usual.
> */
> typedef std::basic_ostream odocstream;
>
>
> Enrico's patch might be needed for platform were char is unsigned,
It is not.
> dunno. But I maintain the assertion is correct.
Your opinion, of course.
> We should also put an
> assertion here:
>
> inline
> odocstream & operator<<(odocstream & os, char c)
> {
> os.put(c);
> return os;
> }
I give up.
--
Enrico
LyX svn problems
Hi all,
LyX from svn seems quite unstable/unusable. Just opening the Intro.lyx
and moving around a few lines suffices to get a SIGSEGV.
Also, renaming the folder where LyX was compiled, seems to cause
an infinite loop (100% CPU) on lyx boot. The output of "lyx -dbg any"
obtained in such case follows below (cut, because it is repeating
over and over the same thing, also creating infinite temporary
things in /tmp). I think it should report an
error saying that it does not find the expected files, instead.
Guess it is actually trying to use the stuff in the configured prefix
from a previous "make install", and has some problems in converting
them to the new format.
T.
Converting layout file from format 4 to 5
Temporary file `/tmp/19508fFomvR' created.
Running `python -tt
'/usr/local/lyx-devel/share/lyx/scripts/layout2layout.py'
'/tmp/19508dRMi98' '/tmp/19508fFomvR''
Reading textclass /tmp/19508fFomvR
filetools(getFormatFromContents)
Couldn't find a known format!
lyxlex: UNcompressed
Comment read: `#% Do not delete he line below; configure depends on this'
Comment read: `# \DeclareLaTeXClass{article (IEEEtran)}'
Comment read: `# Based on Article textclass definition file.'
Comment read: `#'
Comment read: `# Author : Allan Rae <[EMAIL PROTECTED]>'
Comment read: `#'
Comment read: `# IEEEtran is the class used for submitting to any of the
IEEE Transactions.'
Comment read: `# The on-screen display in LyX is set to reflect the
appearance of two column'
Comment read: `# text. The section counters appear correctly in the
output but are'
Comment read: `# in arabic numerals in LyX -- this requires some
additional code in LyX'
Comment read: `# to get right (maybe LyX-2.0 ;-).'
Comment read: `#'
Comment read: `# IEEEtran.cls can be obtained from the www.ieee.org
website -- look for'
Comment read: `# the author information area. There is a LaTeX 2.09
IEEEtran.sty available'
Comment read: `# also but LyX doesn't support 2.09 stuff so don't get
that one.'
Converting layout file from format 4 to 5
Temporary file `/tmp/195086GlKqA' created.
Running `python -tt
'/usr/local/lyx-devel/share/lyx/scripts/layout2layout.py'
'/tmp/19508fFomvR' '/tmp/195086GlKqA''
Reading textclass /tmp/195086GlKqA
filetools(getFormatFromContents)
Couldn't find a known format!
lyxlex: UNcompressed
Comment read: `#% Do not delete he line below; configure depends on this'
Comment read: `# \DeclareLaTeXClass{article (IEEEtran)}'
Comment read: `# Based on Article textclass definition file.'
Comment read: `#'
Comment read: `# Author : Allan Rae <[EMAIL PROTECTED]>'
Comment read: `#'
Comment read: `# IEEEtran is the class used for submitting to any of the
IEEE Transactions.'
Comment read: `# The on-screen display in LyX is set to reflect the
appearance of two column'
Comment read: `# text. The section counters appear correctly in the
output but are'
Comment read: `# in arabic numerals in LyX -- this requires some
additional code in LyX'
Comment read: `# to get right (maybe LyX-2.0 ;-).'
Comment read: `#'
Comment read: `# IEEEtran.cls can be obtained from the www.ieee.org
website -- look for'
Comment read: `# the author information area. There is a LaTeX 2.09
IEEEtran.sty available'
Comment read: `# also but LyX doesn't support 2.09 stuff so don't get
that one.'
Converting layout file from format 4 to 5
Temporary file `/tmp/19508g2Rwwk' created.
Running `python -tt
'/usr/local/lyx-devel/share/lyx/scripts/layout2layout.py'
'/tmp/195086GlKqA' '/tmp/19508g2Rwwk''
Reading textclass /tmp/19508g2Rwwk
filetools(getFormatFromContents)
Couldn't find a known format!
lyxlex: UNcompressed
Comment read: `#% Do not delete he line below; configure depends on this'
Comment read: `# \DeclareLaTeXClass{article (IEEEtran)}'
Comment read: `# Based on Article textclass definition file.'
Comment read: `#'
Comment read: `# Author : Allan Rae <[EMAIL PROTECTED]>'
Comment read: `#'
Comment read: `# IEEEtran is the class used for submitting to any of the
IEEE Transactions.'
Comment read: `# The on-screen display in LyX is set to reflect the
appearance of two column'
Comment read: `# text. The section counters appear correctly in the
output but are'
Comment read: `# in arabic numerals in LyX -- this requires some
additional code in LyX'
Comment read: `# to get right (maybe LyX-2.0 ;-).'
Comment read: `#'
Comment read: `# IEEEtran.cls can be obtained from the www.ieee.org
website -- look for'
Comment read: `# the author information area. There is a LaTeX 2.09
IEEEtran.sty available'
Comment read: `# also but LyX doesn't support 2.09 stuff so don't get
that one.'
Converting layout file from format 4 to 5
Temporary file `/tmp/19508fOugn5' created.
Running `python -tt
'/usr/local/lyx-devel/share/lyx/scripts/layout2layout.py'
'/tmp/19508g2Rwwk' '/tmp/19508fOugn5''
Reading textclass /tmp/19508fOugn5
filetools(getFormatFromContents)
Couldn't find a known format!
lyxlex: UNcompressed
Comment read: `#% Do not d
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 05:20:17PM +0100, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Thu, Nov 01, 2007 at 03:54:06PM +0100, Abdelrazak Younes wrote: > > > >> Juergen Spitzmueller wrote: > >>> Abdelrazak Younes wrote: > >>> > As for adding the possibility to output an unsigned char to the > docstream I think this buy us absolutely nothing and that it is not even > worth supporting. > >>> How about the attached patch? > >> That should do. But I personally prefer you first patch and I'd be > >> interested to know why it doesn't work on cygwin. > > > > It also doesn't work on Windows and FreeBSD, for example. > > Well, as I said, if there is something to fix by passing a char_type > instead of an unsigned char, let's just fix it instead of turning around > the problem. I must admit I haven't looked closely at the source though. > > > I think it > > would be embarrassing explaining it, as this would imply recognizing a > > basic ignorance about C++, and this should not be the case. > > That is maybe the case. As my ego is not so enormous that I can admit I > am stupid when this is the case, please explain me. A typedef name provides an alternative name for an existing data type. It does not create a new data type, so when char_type is typedef'd to boost::uint32_t, you will get an integral representation of the char_type value rather than the corresponding character when outputting to a docstream. And you can't overload a typedef. -- Enrico
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: > If you think so, then a combination of the two patches is ok. You mean what Abdel committed to trunk? Jürgen
Re: [patch] bug 4147: Multiple cells paste as one in tables
Abdelrazak Younes wrote: > I apply a combination of your two patch Juergen. Enrico might think this > is due to ignorance about C++ but this is just ignorance about a bug in > the odocstream. For the time being, I just committed my second patch to branch. If Enrico confirms your char->char_type change also works on the problematic systems, we can still do that. Jürgen
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 05:55:49PM +0100, Juergen Spitzmueller wrote: > Enrico Forestieri wrote: > > > It also doesn't work on Windows and FreeBSD, for example. I think it > > would be embarrassing explaining it, as this would imply recognizing a > > basic ignorance about C++, and this should not be the case. > > You refer to my first or my second patch? If to the latter, please don't > hesitate. I think I was not replying to you. I was aiming at Solons only. > I'm well aware of my basic ignorance about C++. No need for socratisms. > If you agree my > second patch would be a reasonable and working compromise, I'd propose to > apply this, because it is safer than yours, IMHO. If you think so, then a combination of the two patches is ok. -- Enrico
trunk crashes after start
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xb71966d0 (LWP 19089)] 0xb7a54a99 in QLayout::totalSizeHint () from /usr/lib/libQtGui.so.4 (gdb) bt #0 0xb7a54a99 in QLayout::totalSizeHint () from /usr/lib/libQtGui.so.4 #1 0xb7a6b396 in QWidget::sizeHint () from /usr/lib/libQtGui.so.4 #2 0xb7d3752f in QFrame::sizeHint () from /usr/lib/libQtGui.so.4 #3 0x085a12c3 in lyx::InsetCollapsable::dimensionCollapsed ( this=0x8ff29f0) at insets/InsetCollapsable.cpp:178 #4 0x085a3f19 in lyx::InsetCollapsable::draw (this=0x8ff29f0, [EMAIL PROTECTED], x=60, y=51) at insets/InsetCollapsable.cpp:259 #5 0x085b0d72 in lyx::InsetERT::draw (this=0x8ff29f0, [EMAIL PROTECTED], x=60, y=51) at insets/InsetERT.cpp:245 #6 0x0844fe2c in lyx::RowPainter::paintInset (this=0xbfbb2ffc, inset=0x8ff29f0, pos=0) at rowpainter.cpp:140 ---Type to continue, or q to quit--- #7 0x084522d2 in lyx::RowPainter::paintText (this=0xbfbb2ffc) at rowpainter.cpp:792 #8 0x0827abc9 in lyx::TextMetrics::drawParagraph ( this=0x8ff2b8c, [EMAIL PROTECTED], pit=0, x=0, y=51) at TextMetrics.cpp:2001 #9 0x0827b4cd in lyx::TextMetrics::draw (this=0x8ff2b8c, [EMAIL PROTECTED], x=0, y=51) at TextMetrics.cpp:1916 #10 0x0830a1e0 in lyx::BufferView::draw (this=0x8fe4fb8, [EMAIL PROTECTED]) at BufferView.cpp:2124 #11 0x088acac3 in lyx::frontend::GuiWorkArea::updateScreen ( this=0x8fe4538) at GuiWorkArea.cpp:503 #12 0x088acb48 in lyx::frontend::GuiWorkArea::expose ( this=0x8fe4538, x=0, y=0, w=666, h=334) at GuiWorkArea.cpp:494 #13 0x086bcd94 in lyx::frontend::WorkArea::redraw ( ---Type to continue, or q to quit--- this=0x8fe454c) at WorkArea.cpp:154 #14 0x086bd9e9 in lyx::frontend::WorkAreaManager::redrawAll ( this=0x8fbd500) at WorkAreaManager.cpp:42 #15 0x082bc8b3 in lyx::Buffer::changed (this=0x8f7e168) at Buffer.cpp:290 #16 0x0831043a in lyx::BufferView::processUpdateFlags ( this=0x8fe4fb8, flags=3) at BufferView.cpp:562 #17 0x08154218 in lyx::LyXFunc::dispatch (this=0x8d22ef0, [EMAIL PROTECTED]) at LyXFunc.cpp:2091 #18 0x081113e2 in lyx::dispatch ([EMAIL PROTECTED]) at LyX.cpp:1484 #19 0x086b9dfc in lyx::frontend::LyXView::dispatch ( this=0x8da98cc, [EMAIL PROTECTED]) at LyXView.cpp:296 #20 0x08917223 in lyx::frontend::Action::action (this=0x8e70078) at Action.cpp:70 ---Type to continue, or q to quit--- #21 0x08917298 in lyx::frontend::Action::qt_metacall ( this=0x8e70078, _c=QMetaObject::InvokeMetaMethod, _id=13, _a=0xbfbb5fec) at Action_moc.cpp:69 #22 0xb781b0c0 in QMetaObject::activate () from /usr/lib/libQtCore.so.4 #23 0xb781b3d0 in QMetaObject::activate () from /usr/lib/libQtCore.so.4 #24 0xb7a2cbd1 in QAction::triggered () from /usr/lib/libQtGui.so.4 #25 0xb7a2d70f in QAction::activate () from /usr/lib/libQtGui.so.4 #26 0xb7db05f2 in QToolButton::nextCheckState () from /usr/lib/libQtGui.so.4 #27 0xb7cf8c9f in QAbstractButtonPrivate::click () from /usr/lib/libQtGui.so.4 ---Type to continue, or q to quit--- #28 0xb7cf8efb in QAbstractButton::mouseReleaseEvent () from /usr/lib/libQtGui.so.4 #29 0xb7db06ec in QToolButton::mouseReleaseEvent () from /usr/lib/libQtGui.so.4 #30 0xb7a7784c in QWidget::event () from /usr/lib/libQtGui.so.4 #31 0xb7cf9adf in QAbstractButton::event () from /usr/lib/libQtGui.so.4 #32 0xb7db02c4 in QToolButton::event () from /usr/lib/libQtGui.so.4 #33 0xb7a32c1d in QApplicationPrivate::notify_helper () from /usr/lib/libQtGui.so.4 #34 0xb7a3938d in QApplication::notify () from /usr/lib/libQtGui.so.4 #35 0x086cd242 in lyx::frontend::GuiApplication::notify ( this=0x8d26830, receiver=0x8e75920, event=0xbfbb64e4) ---Type to continue, or q to quit--- at GuiApplication.cpp:290 #36 0xb7809d5b in QCoreApplication::notifyInternal () from /usr/lib/libQtCore.so.4 #37 0xb7a89733 in QETWidget::translateMouseEvent () from /usr/lib/libQtGui.so.4 #38 0xb7a88d96 in QApplication::x11ProcessEvent () from /usr/lib/libQtGui.so.4 #39 0xb7aac17a in ?? () from /usr/lib/libQtGui.so.4 #40 0x08d26830 in ?? () #41 0xbfbb6948 in ?? () #42 0xbfbb68c8 in ?? () #43 0xb73fbff0 in _xcb_unlock_io () from /usr/lib/libxcb.so.1 #44 0xb767e446 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #45 0xb76817e2 in ?? () from /usr/lib/libglib-2.0.so.0 ---Type to continue, or q to quit--- #46 0x08d2f0f8 in ?? () #47 0x in ?? ()
Re: [patch] bug 4147: Multiple cells paste as one in tables
Andre Poenitz wrote: On Wed, Oct 31, 2007 at 06:25:31PM +0100, Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: If somebody use the docstream with latin8 character we will have bugs for sure. How could we forbid 8bit chars to operator
Re: [patch] bug 4147: Multiple cells paste as one in tables
Juergen Spitzmueller wrote:
Enrico Forestieri wrote:
It also doesn't work on Windows and FreeBSD, for example. I think it
would be embarrassing explaining it, as this would imply recognizing a
basic ignorance about C++, and this should not be the case.
You refer to my first or my second patch? If to the latter, please don't
hesitate. I'm well aware of my basic ignorance about C++. If you agree my
second patch would be a reasonable and working compromise, I'd propose to
apply this, because it is safer than yours, IMHO.
I apply a combination of your two patch Juergen. Enrico might think this
is due to ignorance about C++ but this is just ignorance about a bug in
the odocstream. See comment in docstream.h:
/** Base class for UCS4 output streams.
If you want to output a single UCS4 character, use \code
os.put(c);
\endcode, not \code
os << c;
\endcode . The latter will not output the character, but the code point
as number. This is because we can't overload operator<< (our character
type is not a real type but a typedef). Narrow characters of type char
can be output as usual.
*/
typedef std::basic_ostream odocstream;
Enrico's patch might be needed for platform were char is unsigned,
dunno. But I maintain the assertion is correct. We should also put an
assertion here:
inline
odocstream & operator<<(odocstream & os, char c)
{
os.put(c);
return os;
}
Abdel.
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: > It also doesn't work on Windows and FreeBSD, for example. I think it > would be embarrassing explaining it, as this would imply recognizing a > basic ignorance about C++, and this should not be the case. You refer to my first or my second patch? If to the latter, please don't hesitate. I'm well aware of my basic ignorance about C++. If you agree my second patch would be a reasonable and working compromise, I'd propose to apply this, because it is safer than yours, IMHO. Jürgen
Re: [patch] bug 4147: Multiple cells paste as one in tables
Enrico Forestieri wrote: On Thu, Nov 01, 2007 at 03:54:06PM +0100, Abdelrazak Younes wrote: Juergen Spitzmueller wrote: Abdelrazak Younes wrote: As for adding the possibility to output an unsigned char to the docstream I think this buy us absolutely nothing and that it is not even worth supporting. How about the attached patch? That should do. But I personally prefer you first patch and I'd be interested to know why it doesn't work on cygwin. It also doesn't work on Windows and FreeBSD, for example. Well, as I said, if there is something to fix by passing a char_type instead of an unsigned char, let's just fix it instead of turning around the problem. I must admit I haven't looked closely at the source though. I think it would be embarrassing explaining it, as this would imply recognizing a basic ignorance about C++, and this should not be the case. That is maybe the case. As my ego is not so enormous that I can admit I am stupid when this is the case, please explain me. Abdel.
Re: [patch] bug 4147: Multiple cells paste as one in tables
On Thu, Nov 01, 2007 at 03:54:06PM +0100, Abdelrazak Younes wrote: > Juergen Spitzmueller wrote: > > Abdelrazak Younes wrote: > > > >> As for adding the possibility to output an unsigned char to the > >> docstream I think this buy us absolutely nothing and that it is not even > >> worth supporting. > > > > How about the attached patch? > > That should do. But I personally prefer you first patch and I'd be > interested to know why it doesn't work on cygwin. It also doesn't work on Windows and FreeBSD, for example. I think it would be embarrassing explaining it, as this would imply recognizing a basic ignorance about C++, and this should not be the case. -- Enrico
Re: Lots of warning compiling mathed
/// index of default value cell of optional parameter (#1 -> n=0)
pos_type optIdx(int n) const { return n + 1; }
Stefan, why did you use pos_type here? Do you need something
signed? Even if yes, pos_type is in general related to a character
position inside a Paragraph.
Replaced this one and several others now with the right types. A lot
less warnings...
Stefan
PGP.sig
Description: Signierter Teil der Nachricht
Re: Lots of warning compiling mathed
Will fix them. Stefan PGP.sig Description: Signierter Teil der Nachricht
Lots of warning compiling mathed
/// index of default value cell of optional parameter (#1 -> n=0)
pos_type optIdx(int n) const { return n + 1; }
Stefan, why did you use pos_type here? Do you need something signed?
Even if yes, pos_type is in general related to a character position
inside a Paragraph.
Abdel.
Compiling...
MathSupport.cpp
MathParser.cpp
MathMacroTemplate.cpp
..\..\..\..\src\mathed\MathMacroTemplate.cpp(443) : warning C4018: '>' :
signed/unsigned mismatch
..\..\..\..\src\mathed\MathMacroTemplate.cpp(468) : warning C4018: '>='
: signed/unsigned mismatch
..\..\..\..\src\mathed\MathMacroTemplate.cpp(490) : warning C4018: '>' :
signed/unsigned mismatch
MathMacroArgument.cpp
MathMacro.cpp
..\..\..\..\src\mathed\MathMacro.cpp(423) : warning C4018: '<' :
signed/unsigned mismatch
..\..\..\..\src\mathed\MathMacro.cpp(438) : warning C4018: '<' :
signed/unsigned mismatch
..\..\..\..\src\mathed\MathMacro.cpp(541) : warning C4018: '<' :
signed/unsigned mismatch
..\..\..\..\src\mathed\MathMacro.cpp(552) : warning C4018: '<' :
signed/unsigned mismatch
..\..\..\..\src\mathed\MathMacro.cpp(559) : warning C4018: '<' :
signed/unsigned mismatch
MathFactory.cpp
MathData.cpp
..\..\..\..\src\mathed\MathData.cpp(431) : warning C4018: '<' :
signed/unsigned mismatch
..\..\..\..\src\mathed\MathData.cpp(439) : warning C4018: '<' :
signed/unsigned mismatch
MacroTable.cpp
InsetMathNest.cpp
InsetMathGrid.cpp
InsetMathFrac.cpp
InsetMathDelim.cpp
InsetMathChar.cpp
Generating Code...
Build log was saved at
"file://d:\devel\lyx\trunk\development\cmake\src\mathed\mathed.dir\Release\BuildLog.htm"
mathed - 0 error(s), 10 warning(s)
The build has been canceled at the user's request
Re: Patch: further clean-up of inset font handling etc.
Martin Vermeer wrote:
On Wed, Oct 31, 2007 at 10:28:04PM +0200, Martin Vermeer wrote:
On Wed, Oct 31, 2007 at 07:53:22PM +0100, Andre Poenitz wrote:
On Wed, Oct 31, 2007 at 06:24:22PM +0200, Martin Vermeer wrote:
// Read a font definition from given file in lyx format
// Used for layouts
-FontInfo lyxRead(Lexer & lex)
+FontInfo lyxRead(Lexer & lex, FontInfo f)
Should be FontInfo const &.
Andre'
Yes, here is a better patch (with now also needprotect implemented)
I just notice that the NeedProtect parameter is poorly named. What it
signals is this environment _has a moving argument_. It does not signal
that this command (inset?) needs protection because _it is fragile_.
Proper usage like illustrated below.
Ideally we would need two parameters, and better named ones at that:
HasMovingArg and IsFragile. Currently we have only the first, meaning
\protect gets output way too often. Not disastrous, but at least the
naming could be better.
Yes, this issue came up a while ago when I was trying to work on the
"alignment in tables" bugs.
Richard
- Martin
Index: InsetCollapsable.cpp
===
--- InsetCollapsable.cpp(revision 21308)
+++ InsetCollapsable.cpp(working copy)
@@ -797,6 +797,8 @@
if (!layout_.latexname.empty()) {
if (layout_.latextype == "command") {
// FIXME UNICODE
+ if (runparams.moving_arg)
+ os << "\\protect";
os << '\\' << from_utf8(layout_.latexname);
if (!layout_.latexparam.empty())
os << from_utf8(layout_.latexparam);
@@ -810,6 +812,8 @@
OutputParams rp = runparams;
if (layout_.passthru)
rp.verbatim = true;
+ if (layout_.needprotect)
+ rp.moving_arg = true;
int i = InsetText::latex(buf, os, rp);
if (!layout_.latexname.empty()) {
if (layout_.latextype == "command") {
--
==
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Re: [patch] bug 4147: Multiple cells paste as one in tables
Juergen Spitzmueller wrote: Abdelrazak Younes wrote: As for adding the possibility to output an unsigned char to the docstream I think this buy us absolutely nothing and that it is not even worth supporting. How about the attached patch? That should do. But I personally prefer you first patch and I'd be interested to know why it doesn't work on cygwin. Abdel.
Re: beta stix fonts available
Edwin Leuven wrote: Juergen Spitzmueller wrote: "Regrettably, this beta test will *not* include TeX support. We expect the TeX package to be ready for beta test near the end of this year." but this doesn't prohibit using the glyphs to draw math in lyx if someone would be interested in that... Yes, and that would be a good time to migrate mathed to unicode at the same time. Abdel.
Re: 1.6svn does not compile, error in MacroTable.cpp
Edwin fixed it. Thanks! Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: Patch: further clean-up of inset font handling etc.
[EMAIL PROTECTED] wrote: On Thu, 1 Nov 2007, Martin Vermeer wrote: By the way, please use '=' instead of a copy ctor, looks cleaner: +FontInfo font = inherit_font; Just a C++ check, the above still use the copy constructor, right? (As opposed to assignment) Yes. Abdel.
Re: 1.6svn does not compile, error in MacroTable.cpp
Stefan Schimanski wrote: Fixed. Interesting that gcc 4.01 does not care. I use gcc 4.2. I compiled again, this time MathMacro worked, the compile stopped on MacroTable instead. Helge Hafting g++ -DHAVE_CONFIG_H -I. -I../../lyx-devel/src -I. -I../../lyx-devel/src -Wextra -Wall -g -O2 -MT MacroTable.lo -MD -MP -MF .deps/MacroTable.Tpo -c ../../lyx-devel/src/mathed/MacroTable.cpp -o MacroTable.o ../../lyx-devel/src/mathed/MacroTable.cpp:20:20: error: buffer.h: No such file or directory ../../lyx-devel/src/mathed/MacroTable.cpp: In member function 'bool lyx::MacroContext::has(const lyx::docstring&) const': ../../lyx-devel/src/mathed/MacroTable.cpp:157: error: invalid use of incomplete type 'const struct lyx::Buffer' ../../lyx-devel/src/mathed/MacroTable.h:25: error: forward declaration of 'const struct lyx::Buffer' ../../lyx-devel/src/mathed/MacroTable.cpp: In member function 'const lyx::MacroData& lyx::MacroContext::get(const lyx::docstring&) const': ../../lyx-devel/src/mathed/MacroTable.cpp:168: error: invalid use of incomplete type 'const struct lyx::Buffer' ../../lyx-devel/src/mathed/MacroTable.h:25: error: forward declaration of 'const struct lyx::Buffer' make[3]: *** [MacroTable.lo] Error 1 make[3]: Leaving directory `/usr/src/lyx-build/src' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/usr/src/lyx-build/src' make[1]: *** [all] Error 2 make[1]: Leaving directory `/usr/src/lyx-build/src' make: *** [all-recursive] Error 1
Re: 1.6svn does not compile, error in MathMacro.cpp
Fixed. Interesting that gcc 4.01 does not care. Stefan PGP.sig Description: Signierter Teil der Nachricht
1.6svn does not compile, error in MathMacro.cpp
g++ -DHAVE_CONFIG_H -I. -I../../lyx-devel/src -I. -I../../lyx-devel/src -Wextra -Wall -g -O2 -MT MathMacro.lo -MD -MP -MF .deps/MathMacro.Tpo -c ../../lyx-deve l/src/mathed/MathMacro.cpp -o MathMacro.o In file included from ../../lyx-devel/src/mathed/MathMacro.cpp:15: ../../lyx-devel/src/mathed/MathMacro.h:69: error: extra qualification 'lyx::Math Macro::' on member 'write' ../../lyx-devel/src/mathed/MathMacro.cpp:355: warning: unused parameter 'mi' ../../lyx-devel/src/mathed/MathMacro.cpp: In member function 'void lyx::MathMacr o::removeArgument(size_t)': ../../lyx-devel/src/mathed/MathMacro.cpp:419: warning: comparison of unsigned ex pression >= 0 is always true ../../lyx-devel/src/mathed/MathMacro.cpp:423: warning: comparison between signed and unsigned integer expressions ../../lyx-devel/src/mathed/MathMacro.cpp: In member function 'void lyx::MathMacr o::insertArgument(size_t)': ../../lyx-devel/src/mathed/MathMacro.cpp:434: warning: comparison of unsigned ex pression >= 0 is always true ../../lyx-devel/src/mathed/MathMacro.cpp:438: warning: comparison between signed and unsigned integer expressions ../../lyx-devel/src/mathed/MathMacro.cpp: In member function 'virtual void lyx:: MathMacro::write(lyx::WriteStream&) const': ../../lyx-devel/src/mathed/MathMacro.cpp:541: warning: comparison between signed and unsigned integer expressions ../../lyx-devel/src/mathed/MathMacro.cpp:552: warning: comparison between signed and unsigned integer expressions ../../lyx-devel/src/mathed/MathMacro.cpp:559: warning: comparison between signed and unsigned integer expressions make[3]: *** [MathMacro.lo] Error 1
Re: Translation problem: "cc" has two different meanings, but only one translation
> "cc" has two meanings. Maybe this file helps you: http://www.lyx.org/trac/browser/lyx-devel/trunk/README.localization "[[Context]] is used to distinguish otherwise identical strings, which could have different translation dependent on the Context. [[Context]] appears only in msgid string and should not be repeated in the translated version." regards Uwe
Re: beta stix fonts available
Juergen Spitzmueller wrote: "Regrettably, this beta test will *not* include TeX support. We expect the TeX package to be ready for beta test near the end of this year." but this doesn't prohibit using the glyphs to draw math in lyx if someone would be interested in that...
Re: beta stix fonts available
Edwin Leuven wrote: > here: > > http://www.aip.org/stixfonts/font_download.jsp > > for those interested in playing around with them... "Regrettably, this beta test will *not* include TeX support. We expect the TeX package to be ready for beta test near the end of this year." Jürgen
Re: beta stix fonts available
Edwin Leuven wrote: > here: > > http://www.aip.org/stixfonts/font_download.jsp > > for those interested in playing around with them... OK, installed onto my linux F8 system. Any suggestion for 'playing around' with them in lyx?
beta stix fonts available
here: http://www.aip.org/stixfonts/font_download.jsp for those interested in playing around with them...
Re: [Cvslog] r21315 - in /lyx-devel/trunk: lib/layouts/stdinsets.inc s...
Am 01.11.2007 um 10:43 schrieb Martin Vermeer: On Thu, Nov 01, 2007 at 10:12:12AM +0100, Stefan Schimanski wrote: /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp: In member function 'bool lyx::Layout::read(lyx::Lexer&, const lyx::TextClass&)': /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:314: error: call of overloaded 'lyxRead(lyx::Lexer&)' is ambiguous /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/Font.h:49: note: candidates are: lyx::FontInfo lyx::lyxRead(lyx::Lexer&) /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:30: note: lyx::FontInfo lyx::lyxRead(lyx::Lexer&, const lyx::FontInfo&) Stefan Oops... a tex2lyx problem. Update and try again. Thanks! Then I guess my last two commits can be reverted. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [Cvslog] r21318 - /lyx-devel/trunk/src/TextClass.cpp
On Thu, Nov 01, 2007 at 09:16:25AM +, [EMAIL PROTECTED] wrote: > Author: sts > Date: Thu Nov 1 10:16:23 2007 > New Revision: 21318 > > URL: http://www.lyx.org/trac/changeset/21318 > Log: > * and another one. Trying to compile before committing would make sense > sometimes :-/ I did... just not tex2lyx :-( It doesn't happen automatically when compiling from src. Your two last "fixes" (workarounds) can now be reverted. - Martin
Re: [Cvslog] r21315 - in /lyx-devel/trunk: lib/layouts/stdinsets.inc s...
On Thu, Nov 01, 2007 at 10:12:12AM +0100, Stefan Schimanski wrote: > /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp: In member function > 'bool lyx::Layout::read(lyx::Lexer&, const lyx::TextClass&)': > /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:314: error: call of > overloaded 'lyxRead(lyx::Lexer&)' is ambiguous > /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/Font.h:49: note: > candidates are: lyx::FontInfo lyx::lyxRead(lyx::Lexer&) > /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:30: > note: lyx::FontInfo lyx::lyxRead(lyx::Lexer&, const > lyx::FontInfo&) > > Stefan Oops... a tex2lyx problem. Update and try again. - Martin
Re: [Cvslog] r21315 - in /lyx-devel/trunk: lib/layouts/stdinsets.inc s...
Even with the compile fixes now it does not link because the lyxread symbols cannot be found. Spending another useless hour to fix compile bugs :-/ Stefan Am 01.11.2007 um 10:12 schrieb Stefan Schimanski: /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp: In member function 'bool lyx::Layout::read(lyx::Lexer&, const lyx::TextClass&)': /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:314: error: call of overloaded 'lyxRead(lyx::Lexer&)' is ambiguous /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/Font.h:49: note: candidates are: lyx::FontInfo lyx::lyxRead(lyx::Lexer&) /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:30: note: lyx::FontInfo lyx::lyxRead(lyx::Lexer&, const lyx::FontInfo&) Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] bug 4147: Multiple cells paste as one in tables
Abdelrazak Younes wrote: > As for adding the possibility to output an unsigned char to the > docstream I think this buy us absolutely nothing and that it is not even > worth supporting. How about the attached patch? Jürgen Index: src/insets/InsetTabular.cpp === --- src/insets/InsetTabular.cpp (Revision 21308) +++ src/insets/InsetTabular.cpp (Arbeitskopie) @@ -2794,7 +2794,7 @@ if (isPartOfMultiColumn(i, j)) continue; if (onlydata && j > 0) -os << delim; +os.put(delim); plaintextPrintCell(buf, os, runparams, cell, i, j, clen, onlydata); ++cell;
Re: [Cvslog] r21315 - in /lyx-devel/trunk: lib/layouts/stdinsets.inc s...
/Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp: In member function 'bool lyx::Layout::read(lyx::Lexer&, const lyx::TextClass&)': /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:314: error: call of overloaded 'lyxRead(lyx::Lexer&)' is ambiguous /Users/sts/Quellen/mac/dynmacro16/src/tex2lyx/Font.h:49: note: candidates are: lyx::FontInfo lyx::lyxRead(lyx::Lexer&) /Users/sts/Quellen/mac/dynmacro16/src/Layout.cpp:30: note: lyx::FontInfo lyx::lyxRead(lyx::Lexer&, const lyx::FontInfo&) Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: Patch: further clean-up of inset font handling etc.
On Thu, 1 Nov 2007, Martin Vermeer wrote: By the way, please use '=' instead of a copy ctor, looks cleaner: + FontInfo font = inherit_font; Just a C++ check, the above still use the copy constructor, right? (As opposed to assignment) /Christian -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
