Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

 From: Peter KümmelSent: Montag, 18. Januar 2016 03:18‎> Something is different on your system, there should be no problem with finding Qt 5. How actual is your cmake installation? Up to date (3.4.1). Qt is in the folder you hardcoded in the script.> Or do you use a years old Windows for the build? What do you imply with this sentence?‎ I'm on Win7 64bit.
> Latest build folder name should be build5-msvc2010, didn't land this commit upstream? It is. This folder.However, with the build script I uploaded to git I can and could compile LyX so we don't need to invest time in your script to release a beta version.
Regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 18. Januar 2016 09:17:01 MEZ, schrieb "Uwe Stöhr" :
>
>
>From: Peter Kümmel
>
>Sent: Montag, 18. Januar 2016 03:18‎
>
>
>> Something is different on your system, there should be no problem
>with finding Qt 5. How actual is your cmake installation? 
>
>
>Up to date (3.4.1). Qt is in the folder you hardcoded in the script.
>
>
>> Or do you use a years old Windows for the build?
>
> What do you imply with this sentence?‎ I'm on Win7 64bit.
>
>> Latest build folder name should be build5-msvc2010, didn't land this
>commit upstream? 
>
>
>It is. This folder.
>
>
>However, with the build script I uploaded to git I can and could
>compile LyX so we don't need to invest time in your script to release a
>beta version.
>

Forget it, your script or system is broken. 

>Regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Hello Uwe,

as you told, you have big problems in settings up clean build.
Therefore I've changed the build5-2010.bat file you added for building 
with MSVC2010.


This script now works with a double click, and builds LyX with MSVC2010 
in a clean build directory.


Three pathes are hardcoded:
- Qt installation qt C:\Qt
- MSVC2010 installation in C:\Program Files (x86)\Microsoft Visual 
Studio 10.0\VC
- and the deps at the same level as the LyX sources 
lyx20-deps-msvc2010-x86\deps20 (I disabled the automatic download)


I assume the pathes are the same on most systems.
You only have to unpack the deps-msvc2010-x86 folder once at the right 
place.


A simple double click creates the folder "build5-msvc2010" with
the LYX_INSTALLED files. Please use these files for you installer.

We should change this script until it also works for you.
The goal is that you don't have to touch it before you execute it.

I really hope this improves the current installer chaos.

Peter

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 17.01.2016 um 18:59 schrieb Peter Kümmel:

> as you told, you have big problems in settings up clean build.

Therefore I've changed the build5-2010.bat file you added for building
with MSVC2010.


As I reported proudly I was able to get a clean build. I still have some 
troubles with CMake and reported them as

http://www.lyx.org/trac/ticket/9927

The script you modified is the one I uploaded after I could use it to 
compile LyX with it with just a click.


Now I cannot use the script to build LyX: double-clicking on it gives 
starts a console that is clased after a few seconds.  The error message is:


---
CMake Error at CMakeLists.txt:561 (find_package):
  By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this 
project has
  asked CMake to find a package configuration file provided by 
"Qt5Core", but

  CMake did not find one.

  Could not find a package configuration file provided by "Qt5Core" 
with any

  of the following names:

Qt5CoreConfig.cmake
qt5core-config.cmake

  Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
  "Qt5Core_DIR" to a directory containing one of the above files.  If
  "Qt5Core" provides a separate development package or SDK, be sure it has
  been installed.

-- Configuring incomplete, errors occurred!
See also "D:/LyXGit/compile-msvc2010/CMakeFiles/CMakeOutput.log".
---

I miss in your script a method to select to build a devel or an install 
build.

Moreover
-DLYX_MERGE_REBUILD=1 -DLYX_MERGE_FILES=1
never worked for me. i get then compilation errors. Thus I am forced to use
-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0


I really hope this improves the current installer chaos.


I am very thankful that you help me here but I don't understand what you 
mean with "installer chaos". I provided a buggy installer for alpha2 
because I could not test it. That was it. My main problems are to build 
LyX because of the CMake bugs and because I first need to find out that 
LyX cannot be built with MSVC 2012 or newer.


regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 18. Januar 2016 01:10:41 MEZ, schrieb "Uwe Stöhr" :
>Am 17.01.2016 um 18:59 schrieb Peter Kümmel:
>
> > as you told, you have big problems in settings up clean build.
>> Therefore I've changed the build5-2010.bat file you added for
>building
>> with MSVC2010.
>
>As I reported proudly I was able to get a clean build. I still have
>some 
>troubles with CMake and reported them as
>http://www.lyx.org/trac/ticket/9927
>
>The script you modified is the one I uploaded after I could use it to 
>compile LyX with it with just a click.
>
>Now I cannot use the script to build LyX: double-clicking on it gives 
>starts a console that is clased after a few seconds.  The error message
>is:
>
>---
>CMake Error at CMakeLists.txt:561 (find_package):
>   By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this 
>project has
>   asked CMake to find a package configuration file provided by 
>"Qt5Core", but
>   CMake did not find one.
>
>   Could not find a package configuration file provided by "Qt5Core" 
>with any
>   of the following names:
>
> Qt5CoreConfig.cmake
> qt5core-config.cmake
>
>   Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
>   "Qt5Core_DIR" to a directory containing one of the above files.  If
>"Qt5Core" provides a separate development package or SDK, be sure it
>has
>   been installed.
>
>-- Configuring incomplete, errors occurred!
>See also "D:/LyXGit/compile-msvc2010/CMakeFiles/CMakeOutput.log".
>---
>
>I miss in your script a method to select to build a devel or an install
>
>build.
>Moreover
>-DLYX_MERGE_REBUILD=1 -DLYX_MERGE_FILES=1
>never worked for me. i get then compilation errors. Thus I am forced to
>use
>-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0
>
>> I really hope this improves the current installer chaos.
>
>I am very thankful that you help me here but I don't understand what
>you 
>mean with "installer chaos". I provided a buggy installer for alpha2 
>because I could not test it. That was it. My main problems are to build
>
>LyX because of the CMake bugs and because I first need to find out that
>
>LyX cannot be built with MSVC 2012 or newer.
>
>regards Uwe

Something is different on your system, there should be no problem with finding 
Qt 5. How actual is your cmake installation? Or do you use a years old Windows 
for the build?

Latest build folder name should be build5-msvc2010, didn't land this commit 
upstream? 

Script maybe misses the correcr man dir pass this could be fixed.

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

>
>I miss in your script a method to select to build a devel or an install

We need a reliable script for the installer input, which only builds lyx 
nothing else, this is the intention. No parameters no choice. 

>Moreover
>-DLYX_MERGE_REBUILD=1 

This flag is only needed when you rebuild again, which is the case here, each 
time the build dir is clean.

-DLYX_MERGE_FILES=1
>never worked for me. i get then compilation errors. Thus I am forced to
>use
>-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0
>
>> I really hope this improves the current installer chaos.
>
>I am very thankful that you help me here but I don't understand what
>you 
>mean with "installer chaos". I provided a buggy installer for alpha2 
>because I could not test it. That was it. My main problems are to build
>
>LyX because of the CMake bugs and because I first need to find out that
>
>LyX cannot be built with MSVC 2012 or newer.
>
>regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 18. Januar 2016 01:10:41 MEZ, schrieb "Uwe Stöhr" :
>Am 17.01.2016 um 18:59 schrieb Peter Kümmel:
>
> > as you told, you have big problems in settings up clean build.
>> Therefore I've changed the build5-2010.bat file you added for
>building
>> with MSVC2010.
>
>As I reported proudly I was able to get a clean build. I still have
>some 
>troubles with CMake and reported them as
>http://www.lyx.org/trac/ticket/9927
>
>The script you modified is the one I uploaded after I could use it to 
>compile LyX with it with just a click.
>
>Now I cannot use the script to build LyX: double-clicking on it gives 
>starts a console that is clased after a few seconds.  The error message
>is:
>
>---
>CMake Error at CMakeLists.txt:561 (find_package):
>   By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this 
>project has
>   asked CMake to find a package configuration file provided by 
>"Qt5Core", but
>   CMake did not find one.
>
>   Could not find a package configuration file provided by "Qt5Core" 
>with any
>   of the following names:
>
> Qt5CoreConfig.cmake
> qt5core-config.cmake
>
>   Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
>   "Qt5Core_DIR" to a directory containing one of the above files.  If
>"Qt5Core" provides a separate development package or SDK, be sure it
>has
>   been installed.
>
>-- Configuring incomplete, errors occurred!
>See also "D:/LyXGit/compile-msvc2010/CMakeFiles/CMakeOutput.log".
>---
>
>I miss in your script a method to select to build a devel or an install
>
>build.
>Moreover
>-DLYX_MERGE_REBUILD=1 -DLYX_MERGE_FILES=1
>never worked for me. i get then compilation errors. Thus I am forced to
>use
>-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0
>
>> I really hope this improves the current installer chaos.
>
>I am very thankful that you help me here but I don't understand what
>you 
>mean with "installer chaos". I provided a buggy installer for alpha2 
>because I could not test it. That was it. My main problems are to build
>
>LyX because of the CMake bugs and because I first need to find out that
>
>LyX cannot be built with MSVC 2012 or newer.
>
>regards Uwe

Is Qt installed on D: in your system? This could be the reason that Qt is not 
found. Please check the Qt path bin the script.

Is it a problem on your system to use Qt's default paths? Maybe you should also 
use a virtual machine only used for building lyx.

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 14.01.2016 um 20:58 schrieb Georg Baum:


Please continue. I will have to switch to MinGW because Qt 5.6 does not
support MSVC 2010 and due to a bug in our code MSVC 2012, 2013 and 2015
cannot be used to compile LyX.


Do you mean http://www.lyx.org/trac/ticket/9892 or are there other bugs?


I mean this bug.
As I understood the comments there
std::basic_istringstream
is the problem. But since this affects different MSVC versions I cannot 
imagine that it is a bug in MSVC that so many programs/projects use to 
compile. If it would be it would have been fixed in MSVC.


I googled a bit around and it seems that support for the 
basic_istringstream Class was not changed:

MSVC 2010:
https://msdn.microsoft.com/de-de/library/windows/hardware/czkzky67%28v=vs.100%29.aspx
MSVC 2013:
https://msdn.microsoft.com/de-de/library/windows/hardware/czkzky67%28v=vs.120%29.aspx

However I find this warning
"  Reading from a stream buffer is not considered to be a read 
operation. Instead it is considered to be a write operation because the 
state of the class is changed. "

in
https://msdn.microsoft.com/de-de/library/windows/hardware/c9ceah3b%28v=vs.120%29.aspx


The page about the basic_istringstream Members is only available for 
MSVC 2010 and 2012 and not 2013 and 2015:

https://msdn.microsoft.com/de-de/library/windows/hardware/349xheek%28v=vs.100%29.aspx

Here the general info about iostreams for MSVC:
https://msdn.microsoft.com/de-de/library/windows/hardware/8e9dt98w%28v=vs.120%29.aspx

In the breaking changes i cannot find something about streams, but maybe 
you do:

MSVC 2012:
https://msdn.microsoft.com/en-us/library/bb531344%28v=vs.110%29.aspx
MSVC 2013:
https://msdn.microsoft.com/en-us/library/bb531344%28v=vs.120%29.aspx
MSVC 2015:
https://msdn.microsoft.com/en-us/library/bb531344%28v=vs.140%29.aspx


regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Georg Baum]

Uwe Stöhr wrote:

> Please continue. I will have to switch to MinGW because Qt 5.6 does not
> support MSVC 2010 and due to a bug in our code MSVC 2012, 2013 and 2015
> cannot be used to compile LyX.

Do you mean http://www.lyx.org/trac/ticket/9892 or are there other bugs?


Georg

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 13.01.2016 um 05:41 schrieb Peter Kümmel:


If 5.6 is to buggy, we can also use 5.5.1 build with mingw.


Apparently beta1 will be built with Qt 5.5.1. And now, after some hours 
of fiddling with CMake I am able to build Qt 5.5.1 with MSVC 2010 and 
the result looks promising - stable LyX without all the crashes I had 
with MSVC 2013.


So to save time I will build beta with MSVC2010.


But when we now decide to use only msvc2010, then I stop working on a mingw 
build.


Please continue. I will have to switch to MinGW because Qt 5.6 does not 
support MSVC 2010 and due to a bug in our code MSVC 2012, 2013 and 2015 
cannot be used to compile LyX.


As soon as beta1 is out I will try out MinGW.

many thanks and regards
Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 13. Januar 2016 05:27:22 MEZ, schrieb "Peter Kümmel" :
>Am 13. Januar 2016 05:19:09 MEZ, schrieb "Peter Kümmel"
>:
>>
 It is a warning only committed from me today to fix a linker error.
>>>You tried it with msvc 2010? And it worked?
>>>
>>>Yes. I can now compile with MSVC 2010 and Qt 5.5.1. The compilation
>of
>>
>>>Zlib and friends works here also with MSVC2013.
>>
>>
>>Ok, then you could build an installer again with MSVC2010 and 5.5.1. 
>>
>>But afaik Qt 5.6 will not support MSVC2010 any more. So maybe it is
>>worth now to start trying with mingw, because atm the new msvc
>>compilers have no real futute within lyx. I assume even clang would be
>>better.
>>
>>Is there a recipe how to procede after the successfull build of lyx?
>>How complicated is it to get an installer created?
>>
>>The mingw.bat works, so is it possible to add a second script which
>>produces the installer?i 
>>
>>>
>>>regards Uwe

If 5.6 is to buggy, we can also use 5.5.1 build with mingw.

But when we now decide to use only msvc2010, then I stop working on a mingw 
build. 

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 13. Januar 2016 05:19:09 MEZ, schrieb "Peter Kümmel" :
>
>>> It is a warning only committed from me today to fix a linker error.
>>You tried it with msvc 2010? And it worked?
>>
>>Yes. I can now compile with MSVC 2010 and Qt 5.5.1. The compilation of
>
>>Zlib and friends works here also with MSVC2013.
>
>
>Ok, then you could build an installer again with MSVC2010 and 5.5.1. 
>
>But afaik Qt 5.6 will not support MSVC2010 any more. So maybe it is
>worth now to start trying with mingw, because atm the new msvc
>compilers have no real futute within lyx. I assume even clang would be
>better.
>
>Is there a recipe how to procede after the successfull build of lyx?
>How complicated is it to get an installer created?
>
>The mingw.bat works, so is it possible to add a second script which
>produces the installer?i 
>
>>
>>regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Georg Baum]

Am 12.01.2016 um 00:37 schrieb Uwe Stöhr:

I did this now as I wrote in the
Questions for Uwe once you are back
thread.
I had to delete CMake's cache first and re-run it from scratch. The 
3rd party programs are compiled (with 134 warnings) but I don't get a 
DLL. Is this the plan - not to rely anymore on DLLs?


Almost. The libs are currently compiled as static libraries. But this is 
not the most important aspect. The main goal of having these sources 
included with LyX is that no externally compiled prerequisites are 
needed anymore (except for qt). This has two advantages:


1) It makes it more easy for other people to build LyX on windows, even 
if they have a different compiler than you. I hope that this will 
attract other people who build on windows in the long term, so that you 
do not need to do everything alone.


2) It eliminates all possibillities of errors that may occur because of 
different compilers. This makes it more easy for you to switch to a new 
MSVC version.


If it turns out that for some reason having one of these thirdparty 
libraries as dll has advantages, we could also change the build 
procedure to produce dlls from the same sources.



Georg

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 12.01.2016 um 00:37 schrieb Uwe Stöhr:

I had to delete CMake's cache first and re-run it from scratch. The 3rd
party programs are compiled (with 134 warnings) but I don't get a DLL.
Is this the plan - not to rely anymore on DLLs?


Yes, no Dlls any more (only the Qt related ones).



thanks and regards
Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 13.01.2016 um 01:38 schrieb Peter Kümmel:


It is a warning only committed from me today to fix a linker error. You tried 
it with msvc 2010? And it worked?


Yes. I can now compile with MSVC 2010 and Qt 5.5.1. The compilation of 
Zlib and friends works here also with MSVC2013.


regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 12. Januar 2016 20:24:38 MEZ, schrieb Georg Baum 
:
>Am 12.01.2016 um 00:37 schrieb Uwe Stöhr:
>> I did this now as I wrote in the
>> Questions for Uwe once you are back
>> thread.
>> I had to delete CMake's cache first and re-run it from scratch. The 
>> 3rd party programs are compiled (with 134 warnings) but I don't get a
>
>> DLL. Is this the plan - not to rely anymore on DLLs?
>>
>Almost. The libs are currently compiled as static libraries. But this
>is 
>not the most important aspect. The main goal of having these sources 
>included with LyX is that no externally compiled prerequisites are 
>needed anymore (except for qt). This has two advantages:
>
>1) It makes it more easy for other people to build LyX on windows, even
>
>if they have a different compiler than you. I hope that this will 
>attract other people who build on windows in the long term, so that you
>
>do not need to do everything alone.
>
>2) It eliminates all possibillities of errors that may occur because of
>
>different compilers. This makes it more easy for you to switch to a new
>
>MSVC version.


But Atm all msvc > 2010 versions are broken. So the only way to go is mingw or 
2010. 

>
>If it turns out that for some reason having one of these thirdparty 
>libraries as dll has advantages, we could also change the build 
>procedure to produce dlls from the same sources.
>
>
>Georg

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 12.01.2016 um 11:16 schrieb Peter Kümmel:


Yes, no Dlls any more (only the Qt related ones).


OK.

However I get now man times this warning:

D:\LyXGit\Master\compile-2010\zconf.h(10): warning C4005: 'Z_PREFIX': 
Makro-Neudefinition [D:\LyXGit\Master\compile-2010\src\LyX.vcxproj]
  D:\LyXGit\Master\compile-2010\config.h(78): Siehe vorherige 
Definition von 'Z_PREFIX'


Can we do something against this (MSVC 2010)?


thanks and regards
Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 13. Januar 2016 01:18:12 MEZ, schrieb "Uwe Stöhr" :
>Am 12.01.2016 um 11:16 schrieb Peter Kümmel:
>
>> Yes, no Dlls any more (only the Qt related ones).
>
>OK.
>
>However I get now man times this warning:
>
>D:\LyXGit\Master\compile-2010\zconf.h(10): warning C4005: 'Z_PREFIX': 
>Makro-Neudefinition [D:\LyXGit\Master\compile-2010\src\LyX.vcxproj]
>   D:\LyXGit\Master\compile-2010\config.h(78): Siehe vorherige 
>Definition von 'Z_PREFIX'
>
>Can we do something against this (MSVC 2010)?
>
>>> thanks and regards
>>> Uwe

It is a warning only committed from me today to fix a linker error. You tried 
it with msvc 2010? And it worked?

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 11.01.2016 um 20:44 schrieb Georg Baum:


welcome back and a happy new year!


Thanks. The same to you.


As I wrote in the "questions" mail: I am pretty sure that using the sources
in 3rdparty instead of the precompiled binary dependencies will result in a
better build and less work. Please try to do that by setting the
3RDPARTY_BUILD option to ON in the cmake call and unsetting the GNUWIN32_DIR
variable.


I did this now as I wrote in the
Questions for Uwe once you are back
thread.
I had to delete CMake's cache first and re-run it from scratch. The 3rd 
party programs are compiled (with 134 warnings) but I don't get a DLL. 
Is this the plan - not to rely anymore on DLLs?


thanks and regards
Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Georg Baum]

Hi Uwe,

welcome back and a happy new year!


Uwe Stöhr wrote:

> I can compile LyX 2.2dev with
> - Qt 4.8.7 and MSVC 2010
> - Qt 5.5.1 and MSVC 2013 (the resulting build has problems I already
> reported in December, but the compilation itself works)
> 
> But if I use
> - Qt 5.5.1 and MSVC 2010
> I get these libiconv compilation errors:
> 
> "D:\LyXGit\Master\compile-2010\src\LyX.vcxproj" (Standardziel) (23) ->
> (Link Ziel) ->
>support.lib(docstream.obj) : error LNK2019: Verweis auf nicht
> aufgel÷stes externes Symbol "__imp__libiconv_open" in Funktion ""public:
> __thiscall `anonymous
> namespace'::iconv_codecvt_facet::iconv_codecvt_facet(class
> std::basic_string std::allocator > const &,int,unsigned int)"
> (??0iconv_codecvt_facet@?A0x188375c2@@QAE@ABV?$basic_string@DU?
$char_traits@D@std@@V?$allocator@D@2@@std@@HI@Z)".

The build script looks as if it uses the old binary MSVC 2010 dependencies. 
They do probably intefere with the new 3rdparty directory added by Peter.

As I wrote in the "questions" mail: I am pretty sure that using the sources 
in 3rdparty instead of the precompiled binary dependencies will result in a 
better build and less work. Please try to do that by setting the 
3RDPARTY_BUILD option to ON in the cmake call and unsetting the GNUWIN32_DIR 
variable.


Georg