[Mahara-contributors] [Bug 2037565] Re: Display problem with search label in Portfolios page (lang french)
This bug has been copied over to git.mahara.org - Issue #185 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2037565 Title: Display problem with search label in Portfolios page (lang french) Status in Mahara: New Bug description: To reproduce : * Navigate to the 'Portfolios' (page view/index.php or Main menu > create > Portfolios) * Click the "Language chooser" to switch to french language. Actual : the two Drop-down labels of 'Search' and 'Sort by' are overlapped. Expected : spacing between them To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2037565/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2032599] Re: Small fix for CPD block 'To' description.
https://git.mahara.org/catalyst/mahara/-/issues/133 ** Bug watch added: git.mahara.org/catalyst/mahara/-/issues #133 https://git.mahara.org/catalyst/mahara/-/issues/133 ** Changed in: mahara Status: New => Opinion -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2032599 Title: Small fix for CPD block 'To' description. Status in Mahara: Opinion Bug description: The same "start date" is used in the 'From' and 'To' descriptions in the CPD block. Therefore, it would be better for us to modify the "To" description as follows. Langfile to modify: artefact/cpds/blocktype/cpds/lang/en.utf8/blocktype.cpds.php String ID: enddatedesc [Before] Filter entries with activity start date on or before this date [After] Filter entries with activity end date on or before this date To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2032599/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2018332] Re: Show more or all content types when adding a block
https://git.mahara.org/catalyst/mahara/-/issues/132 ** Changed in: mahara Status: Confirmed => In Progress ** Bug watch added: git.mahara.org/catalyst/mahara/-/issues #132 https://git.mahara.org/catalyst/mahara/-/issues/132 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2018332 Title: Show more or all content types when adding a block Status in Mahara: In Progress Bug description: Feedback from Paul at https://www.linkedin.com/feed/update/urn:li:activity:7058553107261128704?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A7058553107261128704%2C7058755874982387712%29=urn%3Ali%3Afsd_comment%3A%287058755874982387712%2Curn%3Ali%3Aactivity%3A7058553107261128704%29 Only seeing 4 content types is limiting for students as they need to click 'Show more' continuously. It would be good to see more items or all of them directly so that not the stereotypical 4 are selected bu more creative ones. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2018332/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1982702] Re: Date strings to be in correct language
https://git.mahara.org/catalyst/mahara/-/issues/89
** Changed in: mahara
Assignee: (unassigned) => Doris Tam (doristam)
** Changed in: mahara
Status: Confirmed => In Progress
** Bug watch added: git.mahara.org/catalyst/mahara/-/issues #89
https://git.mahara.org/catalyst/mahara/-/issues/89
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1982702
Title:
Date strings to be in correct language
Status in Mahara:
In Progress
Bug description:
Display the dates in correct language
If we have a multi tenancy site then the PHP language may not be set
to the one a person is viewing the site with so that PHP created
strings, like a date may be in wrong language, eg
EN 24 July 2022, 08:37
DE 24. July 2022, 08:37
We can't use the PHP setlocale() function because it can cause issues
on a multithreaded server
Now that we are including PHP intl module by default we can use some
of it's functions to get what we need,
eg:
$cl = current_language();
// Remove the '.utf8' from the language
$cl = preg_replace('/\.utf8$/','',$cl);
$langobject = datefmt_create($cl, IntlDateFormatter::LONG,
IntlDateFormatter::SHORT, null, null, 'dd. , hh:HH');
$langstring = datefmt_format($langobject, 1658651838);
log_debug($langstring);
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1982702/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1863820] Re: navigation block html export - views titles link back to original site
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1863820 Title: navigation block html export - views titles link back to original site Status in Mahara: Fix Released Status in Mahara 19.10 series: Fix Released Status in Mahara 20.04 series: Fix Released Bug description: tested on master to test: - Create a collection and add at least 2 pages - Add a navigation block in one of the pages - Export the collection as html - Open the stand alone html site and find the page with the navigation block - Click on any of the view links in the navigation block Expected result: It redirects to the page in the stand alone site Actual result: It redirects to the page on the original site To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1863820/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1871249] Re: Shared access with users produces a warning in 19.10 when search results count = 0
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1871249 Title: Shared access with users produces a warning in 19.10 when search results count = 0 Status in Mahara: Fix Released Status in Mahara 19.04 series: Fix Released Status in Mahara 19.10 series: Fix Released Bug description: The code currently in 19.10 to share access with 'Users' will produce a warning when the search count is 0, i.e a site that has no current users. It's possible there are other ways to return a User search count of 0 but this is the most reliable for testing purposes. The warning message is: [WAR] c4 (view/access.json.php:60) Invalid argument supplied for foreach() To reproduce: 1. On a fresh install of Mahara 19.10 codebase with no users, create a page. 2. Navigate to "Share" and select to edit share access for the new page 3. Select "User" from dropdown box and scroll on the drop down to select a User (it will say No results found) 4. Refresh the page Expected results: Page displays no warnings Actual results: Page displays with a warning message This is happening in 19.10 (possibly a fix needs to be applied to earlier versions of the code). This issue didn't affect code after 19.10. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1871249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1871018] Re: Importing page with embedded image not working in all cases
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1871018 Title: Importing page with embedded image not working in all cases Status in Mahara: Fix Released Status in Mahara 18.10 series: Fix Released Status in Mahara 19.04 series: Fix Released Status in Mahara 19.10 series: Fix Released Status in Mahara 20.04 series: Fix Released Bug description: If I have - User A that has - A page, Page A, that has - A text block on it called Block A - And in that block some text and an embedded image (using tinymce image selector) And I export Page A Then I import it into User B I can see the newly created page has a copy of the embedded image in it. However if I go to another site and import it into User C the embedded image is not present in the page - It is present in the files area though - but just not hooked up to the text block. The reason for this is the creating of the text block from imported Leap2A want to match on the tag containing the same url domain as the current site. When it needs to be more flexible that this To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1871018/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1866913] Re: Elasticsearch::add_to_queue() not found in 19.04
** No longer affects: mahara -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1866913 Title: Elasticsearch::add_to_queue() not found in 19.04 Status in Mahara 18.10 series: Fix Released Status in Mahara 19.04 series: Fix Released Bug description: When we fixed Bug 1840201 we backported this to 19.04 branch but that branch didn't have the associated function. So will need to fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.10/+bug/1866913/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1841118] Re: upgrade query takes too long in DB upgrade to 18.04
** Changed in: mahara
Status: Confirmed => Won't Fix
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1841118
Title:
upgrade query takes too long in DB upgrade to 18.04
Status in Mahara:
Won't Fix
Bug description:
When upgrading from 17.10 to 18.04, with MySQL 5.7 the upgrade script
takes too long to upgrade the event_log table
In queries like
log_debug('Adjust existing "event_log" data for "saveview" and
"deleteview" events');
$sql = "UPDATE {event_log} e
LEFT JOIN {view} v ON v.id = JSON_EXTRACT( CAST( e.data
AS JSON ), '$.id')
SET e.resourceid = JSON_EXTRACT( CAST( e.data AS JSON
), '$.id'),
e.resourcetype = 'view',
e.ownerid = v.owner,
e.ownertype= CASE WHEN v.owner IS NULL THEN NULL
ELSE 'view' END
WHERE e.event IN ('saveview', 'deleteview')";
execute_sql($sql);
if there are too many logs in the table, the sql query will take too
long too run. This needs to be improved.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1841118/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995527] Re: Unable to delete a group
** Changed in: mahara/21.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995527 Title: Unable to delete a group Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When I try to delete a group when the submissions plugin is not installed I get the following message: ERROR: relation "module_submissions" does not exist This module may not be installed if upgrading from older system. Need to add an if_plugin_installed() check similar to is_plugin_active() so we can check if a plugin has been installed at some point even if it's not active currently - because when deleting a group we want to delete the info for the plugin even if it's not active. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995527/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995533] Re: Unable to see skin artefacts owned by another person
** Changed in: mahara/21.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995533 Title: Unable to see skin artefacts owned by another person Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Now that we are using accesscontrol.php for checking if we can see the artefact we need to have a check when the artefact is part of a skin To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995533/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996472] Re: Respect the 'do not send stats' when not in production mode
** Changed in: mahara/21.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996472 Title: Respect the 'do not send stats' when not in production mode Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When you create a site when " $cfg->productionmode = false; " you can't register the site with Mahara.org (which is correct). And if you change the site to " $cfg->productionmode = true; " you can register with Mahara.org (again this correct). But if you then set the site back to " $cfg->productionmode = false; " it will continue to send registration data (this is not correct). We need a check to see what mode the site is in before sending the data and only do it if the site is currently in production mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998725] Re: Incorrect root path for export of profileicon by id
** Changed in: mahara/21.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998725
Title:
Incorrect root path for export of profileicon by id
Status in Mahara 21.10 series:
Fix Released
Status in Mahara 22.04 series:
Fix Released
Bug description:
We sometimes get this error when doing an HTML (or PDF) export
* log_message("Undefined property: HtmlExportOutputFilter::$rootd...", 8,
true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652)
* error(8, "Undefined property: HtmlExportOutputFilter::$rootd...",
"/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652, array(size 9))
* HtmlExportOutputFilter->replace_thumbnail_link(array(size 4))
To test:
Create a person and add a profile icon to the person
Create a page and add comment to the page
Export the person
Expected result
In report bar the message - Export generated successfully.
Actual result
In report bar the message - Export generated with some errors.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1998725/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999347] Re: Update SimpleSamlPhp in Mahara to 1.19.7
** Changed in: mahara/21.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1999347 Title: Update SimpleSamlPhp in Mahara to 1.19.7 Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Update includes a security fix To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1999347/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006637] Re: Issue with upgrade and setting the blocktype_installed_viewtypes values correctly
** Changed in: mahara/21.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006637 Title: Issue with upgrade and setting the blocktype_installed_viewtypes values correctly Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When we add a new view type we update the blocktype_installed_viewtype table to know what blocks can be used on this new view type. But if we have an upgrade path where we add two new view types in one upgrade session then the information is not correct from Blocktype::get_viewtypes() because it is set to be static. We need it to ignore this static-ness on upgrade. To test: Install a 20.04_STABLE site Upgrade to main Run the following command in database: select * from blocktype_installed_viewtype where viewtype = 'activity' order by blocktype; Should see: 29 (or 30) rows including 'placeholder' and 'image' blocktypes Actually see: 21 (or 22) rows and 'placeholder' and 'image' blocktypes are missing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006637/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998860] Re: Problems with deleting a page / person when page is on a watchlist
** Changed in: mahara/21.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998860 Title: Problems with deleting a page / person when page is on a watchlist Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: There are couple of issues around watchlists and queued items To test - problem one: 1) Create a site and add some people to it 2) Create a group and add some people as members 3) As group creator add a page to the group and add a block to the page 4) Masquerade as another group member and view the page - add page to watchlist 5) As this group member edit the page and add a block 6) Then straight away delete the block and go to the group portfolios page and delete the page (do this quickly to beat cron) You get an error: ERROR: update or delete on table "view" violates foreign key constraint "watcqueu_vie_fk" on table "watchlist_queue" This is because when you edit a page that is being watched the watchlist_queue table gets populated with changes and when you delete the block the line isn't removed from the watchlist_queue just the block ID (as it is still a valid view change - the block deletion) so when you try and delete the page it's still referenced. We need to remove the reference on page deletion To test - problem two: 1-5) The same steps as above 6) Stop masquerading as other person and delete person Person deletes successfully but they are still referenced in the watchlist_queue table - we need to remove those references on person deletion so we don't try and send a notification to a deleted person To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998860/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004852] Re: LTI 1.1 grading not working for some locales
** Changed in: mahara/21.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2004852
Title:
LTI 1.1 grading not working for some locales
Status in Mahara:
Fix Committed
Status in Mahara 21.10 series:
Fix Released
Status in Mahara 22.04 series:
Fix Released
Status in Mahara 22.10 series:
Fix Committed
Status in Mahara 23.04 series:
Fix Released
Bug description:
With a LTI to a Moodle instance, when the teachers grades a
submission, the grade is not sent to Moodle in some cases. I think it
has to do with my server's locale set to french. The grade of 94%, for
example, si translated to 0,94 instead of 0.94.
I printed some debug and was able to see the error "Score must be
numeric". I also printed the xml from the $body variable (see
attachment).
I made a few changes in function publish_lti_outcome of
htdocs/module/lti/lib.php around line 1001 and it now works correctly.
$grade = $this->grade / 100;
$grade = str_replace(',', '.', $grade);
$smarty->assign('score', $grade);
This was tested with Mahara 22.10 and Moodle 3.11.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2004852/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1987709] Re: Authentication via SAML looks to cause improper setting of 'lastlastlogin'
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1987709 Title: Authentication via SAML looks to cause improper setting of 'lastlastlogin' Status in Mahara: Fix Committed Bug description: It looks like we set it in the auth/saml/lib.php file but also call the $USER->reanimate() function that then calls $USER->authenticate() that also look to set it. We need to check if we actually need to set it in the saml file or just leave it to the reanimate function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1987709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1966154] Re: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1966154 Title: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties Status in Mahara: Fix Committed Bug description: It is not possible to add more rows to a table when you want to edit text via tinyMCE on a mobile device, e.g. phone. The current mobile interface of tinyMCE prevents the editing of table properties. I checked the online demo of tinyMCE and there it is possible to edit tables in both the basic and fully featured examples https://www.tiny.cloud/docs/demo/ but it doesn't look like those examples are using the mobile tinyMCE interface. We'd need to investigate: - Is the mobile interface we use still supported? There were some deprecations? - Do we still need a special mobile interface or can tinyMCE 5 be used on mobile as is? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1966154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013246] Re: Disable copy page link when link is an tag
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013246 Title: Disable copy page link when link is an tag Status in Mahara: Fix Committed Bug description: Normally the 'copy' option is a button set by pieforms and so has a built in disable/processing system so we can only click it once. But if we have an link tag that hits the copying page directly with the view/collection id there is no disable mechanism on the link once it is clicked. This can cause people to click the link multiple times when the portfolio being copied is large because there is a delay after the clicking and before the finishing of process/redirection to new copy. We need some javascript to disable the link after the first click / show a processing icon so that people can only click it once before the process finishes/redirects To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013246/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013001] Re: Change email header in 'logged in' contact us from 'From' to 'Reply-to'
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013001 Title: Change email header in 'logged in' contact us from 'From' to 'Reply- to' Status in Mahara: Fix Committed Bug description: When you send a 'Contact us' message while you are not logged in, Mahara sends it correctly: From: [Site name] Reply-to: [Sender name] However, when you are logged in, it puts the sender's details in the 'From' field and thus the 'Reply-to' field is ignored. We need to follow the logged out sender format so that email providers don't put our mails into spam because they think we are pretending to send from a domain we don't control. So instead of having a customisation to do things differently for 'Contact us', we should have one rule that follows what we currently do for emails when people are not logged in. How to differentiate the notifications when logged in and when not? - The notification when someone is logged in includes a link to their profile URL via 'See...' after the main body of the message. The scenario that should be covered: 1. You are not logged into Mahara. 2. Send a message via 'Contact us'. 3. Existing behaviour:The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. 4. Log into Mahara as a regular account holder. 5. Send a message via 'Contact us'. 6. The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013001/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969539] Re: Behat test for the portfolio completion page
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969539 Title: Behat test for the portfolio completion page Status in Mahara: Fix Committed Bug description: Related to this bug here: https://bugs.launchpad.net/mahara/+bug/1857933 Test steps (from Release Testing spreadsheet) 1. Admin turns Portfolio completion on in the institution settings 2. Log in as institution member. 3. Create a collection with Portfolio completion turned on. Add 3 pages with the following blocks: P1. Sign-off block P2. Sign-off block with verification enabled P3. No sign-off block 4. Page owner ticks off the pages on the front page of the collection. Portfolio completion shows 67% 5. Owner shares collection with a specific person who they assign the manager role to. 6. Log in as the manager. They should see the following on the collection front page: P1. Sign off block ticked, nothing to do for verifier P2. Sign off block ticked; red dot for verification P3. No sign-off or verification. 7. Manager ticks off the Verification. It becomes a tick and the completion becomes 100% To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969539/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1966154] Re: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties
** Changed in: mahara Status: Triaged => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1966154 Title: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties Status in Mahara: In Progress Bug description: It is not possible to add more rows to a table when you want to edit text via tinyMCE on a mobile device, e.g. phone. The current mobile interface of tinyMCE prevents the editing of table properties. I checked the online demo of tinyMCE and there it is possible to edit tables in both the basic and fully featured examples https://www.tiny.cloud/docs/demo/ but it doesn't look like those examples are using the mobile tinyMCE interface. We'd need to investigate: - Is the mobile interface we use still supported? There were some deprecations? - Do we still need a special mobile interface or can tinyMCE 5 be used on mobile as is? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1966154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Fix Committed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012987] Re: Group forum moderated forum posts attachment visibility missing
** Description changed: Steps to reproduce: 1. Create a group (where posts can be moderated/edited by admin) 2. Add a group member - as the group member, make a forum post with an attachment and embed a file 3. As the admin, go to the group member's forum post 4. Go to edit the forum post Expectation: As admin, I can see the existing forum post attachment listed in the attachments area Current result: The attachments area has nothing listed - 'No files found' Additionally, when moderating a post, on saving, the embedded image is no longer visible to the admin. + + 5. Make no changes, but still press 'Save' + + Expectation: Nothing changes + Current result: The file attachments are deleted/no longer associated to the forum post. The embedded image is no longer visible. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012987 Title: Group forum moderated forum posts attachment visibility missing Status in Mahara: New Bug description: Steps to reproduce: 1. Create a group (where posts can be moderated/edited by admin) 2. Add a group member - as the group member, make a forum post with an attachment and embed a file 3. As the admin, go to the group member's forum post 4. Go to edit the forum post Expectation: As admin, I can see the existing forum post attachment listed in the attachments area Current result: The attachments area has nothing listed - 'No files found' Additionally, when moderating a post, on saving, the embedded image is no longer visible to the admin. 5. Make no changes, but still press 'Save' Expectation: Nothing changes Current result: The file attachments are deleted/no longer associated to the forum post. The embedded image is no longer visible. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012987/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013261] Re: Private comments on group artefacts
** Attachment added: "admin_view_group_page_private_comment_other.png" https://bugs.launchpad.net/mahara/+bug/2013261/+attachment/5658839/+files/admin_view_group_page_private_comment_other.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013261 Title: Private comments on group artefacts Status in Mahara: New Bug description: In a group, members can make post private and public comments on artefacts and pages. These comments have the note 'This comment is private.' below the content. Comments like these are private to the group rather than to the author, unlike other areas of Mahara. All private comments have visibility within the group. The author of a private comment can delete and publicise the comment. But, when other members of the group view the private comment, they can only delete it. To test: 1. Create a group with two members 2. Create a group page 3. Add an image block to the group page 4. Add a private comment to the image artefact 5. Add a private comment to the group page 6. Log in as the other member 7. Go to the group page Expect: both group members can publicise the private comments and delete them. Actual: both group members can delete the private comments, but only the author can publicise them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013261] Re: Private comments on group artefacts
** Attachment added: "admin_view_group_members.png" https://bugs.launchpad.net/mahara/+bug/2013261/+attachment/5658838/+files/admin_view_group_members.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013261 Title: Private comments on group artefacts Status in Mahara: New Bug description: In a group, members can make post private and public comments on artefacts and pages. These comments have the note 'This comment is private.' below the content. Comments like these are private to the group rather than to the author, unlike other areas of Mahara. All private comments have visibility within the group. The author of a private comment can delete and publicise the comment. But, when other members of the group view the private comment, they can only delete it. To test: 1. Create a group with two members 2. Create a group page 3. Add an image block to the group page 4. Add a private comment to the image artefact 5. Add a private comment to the group page 6. Log in as the other member 7. Go to the group page Expect: both group members can publicise the private comments and delete them. Actual: both group members can delete the private comments, but only the author can publicise them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013261] Re: Private comments on group artefacts
** Attachment added: "admin_view_group_page_private_comment_author.png" https://bugs.launchpad.net/mahara/+bug/2013261/+attachment/5658837/+files/admin_view_group_page_private_comment_author.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013261 Title: Private comments on group artefacts Status in Mahara: New Bug description: In a group, members can make post private and public comments on artefacts and pages. These comments have the note 'This comment is private.' below the content. Comments like these are private to the group rather than to the author, unlike other areas of Mahara. All private comments have visibility within the group. The author of a private comment can delete and publicise the comment. But, when other members of the group view the private comment, they can only delete it. To test: 1. Create a group with two members 2. Create a group page 3. Add an image block to the group page 4. Add a private comment to the image artefact 5. Add a private comment to the group page 6. Log in as the other member 7. Go to the group page Expect: both group members can publicise the private comments and delete them. Actual: both group members can delete the private comments, but only the author can publicise them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013261] [NEW] Private comments on group artefacts
Public bug reported: In a group, members can make post private and public comments on artefacts and pages. These comments have the note 'This comment is private.' below the content. Comments like these are private to the group rather than to the author, unlike other areas of Mahara. All private comments have visibility within the group. The author of a private comment can delete and publicise the comment. But, when other members of the group view the private comment, they can only delete it. To test: 1. Create a group with two members 2. Create a group page 3. Add an image block to the group page 4. Add a private comment to the image artefact 5. Add a private comment to the group page 6. Log in as the other member 7. Go to the group page Expect: both group members can publicise the private comments and delete them. Actual: both group members can delete the private comments, but only the author can publicise them. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013261 Title: Private comments on group artefacts Status in Mahara: New Bug description: In a group, members can make post private and public comments on artefacts and pages. These comments have the note 'This comment is private.' below the content. Comments like these are private to the group rather than to the author, unlike other areas of Mahara. All private comments have visibility within the group. The author of a private comment can delete and publicise the comment. But, when other members of the group view the private comment, they can only delete it. To test: 1. Create a group with two members 2. Create a group page 3. Add an image block to the group page 4. Add a private comment to the image artefact 5. Add a private comment to the group page 6. Log in as the other member 7. Go to the group page Expect: both group members can publicise the private comments and delete them. Actual: both group members can delete the private comments, but only the author can publicise them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1966154] Re: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties
One possibility for this could be that we are missing a plugin: The bare bones demo is https://www.tiny.cloud/docs/quick-start/ which looks closer to what we have in Mahara. There is a note saying a bunch of plugins can be added. The demos on: https://www.tiny.cloud/docs/demo/ have a bunch of plugins installed and also has a much larger toolbar than ours. We have a $tinymceconfig that sets up what we see in the editor. This will need to get looked at again and see if all the available interactions are available -> htdocs/lib/web.php TinyMCE supports mobile. What is the mobile interface that we use? LINKS - https://www.tiny.cloud/docs/general-configuration-guide/work-with-plugins/ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1966154 Title: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties Status in Mahara: Triaged Bug description: It is not possible to add more rows to a table when you want to edit text via tinyMCE on a mobile device, e.g. phone. The current mobile interface of tinyMCE prevents the editing of table properties. I checked the online demo of tinyMCE and there it is possible to edit tables in both the basic and fully featured examples https://www.tiny.cloud/docs/demo/ but it doesn't look like those examples are using the mobile tinyMCE interface. We'd need to investigate: - Is the mobile interface we use still supported? There were some deprecations? - Do we still need a special mobile interface or can tinyMCE 5 be used on mobile as is? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1966154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1976415] Re: PHP 8 Compatibility: account
This was before we moved over to Composer. This is not a problem because we can no longer test verify this problem. Any PHP 8.1 issues will have come up and gotten resolved in https://bugs.launchpad.net/mahara/+bug/2008956 ** Changed in: mahara Status: In Progress => Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1976415 Title: PHP 8 Compatibility: account Status in Mahara: Invalid Bug description: This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1. The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools. This bug tracks files in the account directory. Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1. https://phpstan.org/ https://github.com/phan/phan To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1976415/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: In Progress Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2009760] Re: Issue with deleting multirecipient notifications in MySQL
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2009760 Title: Issue with deleting multirecipient notifications in MySQL Status in Mahara: Fix Committed Bug description: When deleting a person one of the cleanup things that happens is any multi-recipient notifications for the person are delete also. But when using MySQL it could cause an issue (segmentation fault) when deleting then via the admin/cli/delete_inactive_users.php CLI script. The cause of this was the SQL for creating one of the queries was wrong. The query ordering syntax was ' ORDER BY ? ' but we can't pass in the value that way because ADODB will wrap it in quotations and cause things to fail. We need to have the query be like this ' ORDER BY ' . $sortby so that ADODB doesn't try to quote it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2009760/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012572] Re: Bootstrap upgrade icon for copy page has changed - change back
*** This bug is a duplicate of bug 2008956 *** https://bugs.launchpad.net/bugs/2008956 ** This bug has been marked a duplicate of bug 2008956 PHP 8 deprecations to fix behat tests -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012572 Title: Bootstrap upgrade icon for copy page has changed - change back Status in Mahara: Confirmed Bug description: https://fontawesome.com/icons/clone?f=classic=regular Icon name 'copy' looks different after the upgrade. To keep the icon visually looking the same, it needs to be called 'clone' To check, make css on the 'main' branch and go to the "Portfolios" page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012572/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012987] Re: Group forum moderated forum posts attachment visibility missing
** Description changed: Steps to reproduce: 1. Create a group (where posts can be moderated/edited by admin) 2. Add a group member - as the group member, make a forum post with an attachment and embed a file 3. As the admin, go to the group member's forum post 4. Go to edit the forum post Expectation: As admin, I can see the existing forum post attachment listed in the attachments area Current result: The attachments area has nothing listed - 'No files found' + + Additionally, when moderating a post, on saving, the embedded image is + no longer visible to the admin. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012987 Title: Group forum moderated forum posts attachment visibility missing Status in Mahara: New Bug description: Steps to reproduce: 1. Create a group (where posts can be moderated/edited by admin) 2. Add a group member - as the group member, make a forum post with an attachment and embed a file 3. As the admin, go to the group member's forum post 4. Go to edit the forum post Expectation: As admin, I can see the existing forum post attachment listed in the attachments area Current result: The attachments area has nothing listed - 'No files found' Additionally, when moderating a post, on saving, the embedded image is no longer visible to the admin. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012987/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012987] [NEW] Group forum moderated forum posts attachment visibility missing
Public bug reported: Steps to reproduce: 1. Create a group (where posts can be moderated/edited by admin) 2. Add a group member - as the group member, make a forum post with an attachment and embed a file 3. As the admin, go to the group member's forum post 4. Go to edit the forum post Expectation: As admin, I can see the existing forum post attachment listed in the attachments area Current result: The attachments area has nothing listed - 'No files found' ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012987 Title: Group forum moderated forum posts attachment visibility missing Status in Mahara: New Bug description: Steps to reproduce: 1. Create a group (where posts can be moderated/edited by admin) 2. Add a group member - as the group member, make a forum post with an attachment and embed a file 3. As the admin, go to the group member's forum post 4. Go to edit the forum post Expectation: As admin, I can see the existing forum post attachment listed in the attachments area Current result: The attachments area has nothing listed - 'No files found' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012987/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007897] Re: Different icons on 'Portfolios' overview page when portfolio is submitted
** Changed in: mahara Status: Confirmed => Fix Committed ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007897 Title: Different icons on 'Portfolios' overview page when portfolio is submitted Status in Mahara: Fix Committed Bug description: In bug #1996475 we are changing the submission workflow so that copies of portfolios are submitted. Currently, the only differentiator between submitted portfolios and those that are ready to be turned into regular portfolios is colour: muted yellow (fully submitted) and muted green (not submitted any more, but still marked as submission so it doesn't clutter the regular portfolios screen). We should have another visual indicator for those that can't perceive colour. The idea is to use different icons in place of the 'More options' icon instead of having an information icon that is not clickable. That means, to tie in with the three different states that we have: 1. Regular portfolio: 'More options' icon of the ellipses 2. Submitted portfolio: Instead of the ellipses have icon check-to-slot that we already use for 'Submissions' in the admin area https://fontawesome.com/icons/check-to-slot?s=solid=classic ; tooltip / screenreader text: 'Submission information for "Title of the portfolio"' 3. Released portfolio but still flagged as submission: Instead of the ellipses have icon square-check https://fontawesome.com/icons/square-check?s=regular=classic ; tooltip / screenreader text: 'Portfolio "Title of the portfolio" released' Once we have the icons, check with Evonne if we should / could colorise them to match the muted colour states, but we'd need to check the contrast. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012572] [NEW] Bootstrap upgrade icon for copy page has changed - change back
Public bug reported: https://fontawesome.com/icons/clone?f=classic=regular Icon name 'copy' looks different after the upgrade. To keep the icon visually looking the same, it needs to be called 'clone' To check, make css on the 'main' branch and go to the "Portfolios" page. ** Affects: mahara Importance: Undecided Assignee: Doris Tam (doristam) Status: New ** Changed in: mahara Milestone: None => 23.04.0 ** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012572 Title: Bootstrap upgrade icon for copy page has changed - change back Status in Mahara: New Bug description: https://fontawesome.com/icons/clone?f=classic=regular Icon name 'copy' looks different after the upgrade. To keep the icon visually looking the same, it needs to be called 'clone' To check, make css on the 'main' branch and go to the "Portfolios" page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012572/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
Unable to replicate the issue. Upon upgrading a site from 22.10 to main, the sign-off forms remained with the expected states on both pages. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Confirmed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006632] Re: PHP port in use for behat
Gold further mentioned that this patch was to solve the issue of him docker running on his machine which utilised port 8000 so behat would not start. Since not all machines are set up like this for Mahara development, the patch file is not needed. ** Changed in: mahara Status: In Progress => Triaged -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006632 Title: PHP port in use for behat Status in Mahara: Triaged Bug description: I had an issue running mahara_behat.sh and tracked it down to port 8000 already being used. We should check for the port being in use and incrementing if so. The attached patch resolved this for me. This uses nc (netcat) to test the port. From what I've seen, netcat is installed on more distros than not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006632/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008956] [NEW] PHP 8 deprecations to fix behat tests
Public bug reported: Fixes to get tests running on PHP 8 ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008956 Title: PHP 8 deprecations to fix behat tests Status in Mahara: New Bug description: Fixes to get tests running on PHP 8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008840] Re: Regex error on PHP 8 Behat steps
** Description changed: - TO fix the following error - - In RegexPatternPolicy.php line 70: - - The regex `/^(?:\I )echo the line "([^"]*)"$/` is invalid: Return type of GuzzleHttp\Cookie\CookieJar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice + Attempting to run behat on PHP 8 throws a bunch of errors. ** Description changed: - Attempting to run behat on PHP 8 throws a bunch of errors. + Attempting to run behat on PHP 8 throws a bunch of errors - from CLI -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008840 Title: Regex error on PHP 8 Behat steps Status in Mahara: New Bug description: Attempting to run behat on PHP 8 throws a bunch of errors - from CLI To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008840/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008840] [NEW] Regex error on PHP 8 Behat steps
Public bug reported: TO fix the following error In RegexPatternPolicy.php line 70: The regex `/^(?:\I )echo the line "([^"]*)"$/` is invalid: Return type of GuzzleHttp\Cookie\CookieJar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008840 Title: Regex error on PHP 8 Behat steps Status in Mahara: New Bug description: TO fix the following error In RegexPatternPolicy.php line 70: The regex `/^(?:\I )echo the line "([^"]*)"$/` is invalid: Return type of GuzzleHttp\Cookie\CookieJar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008840/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006523] Re: Do not list group homepage in group views block that can only appear on group homepage
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 23.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006523 Title: Do not list group homepage in group views block that can only appear on group homepage Status in Mahara: Fix Committed Bug description: It makes little sense to list and have a link to group homepage when on the group homepage (circular reference) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006523/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] [NEW] Third party library updates for 23.04
Public bug reported: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack ** Affects: mahara Importance: Undecided Assignee: Doris Tam (doristam) Status: New ** Changed in: mahara Milestone: None => 23.04.0 ** Description changed: Third-party investigation and updates. + + To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack ** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: New Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006512] [NEW] 'Manage access' or 'Sharing' - which is it?
Public bug reported: The page which displays management of sharing pages is currently called 'Share'. However, on the 'Portfolios' page, the card dropdown says ' Manage access' http://mahara/view/accessurl.php?collection=1 goes to a page called ' Edit access' See images for more. Titles, buttons, and links that go to the same functionality should be called the same otherwise it creates complexity in people learning to use Mahara. ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "mahara_lock_icon.zip" https://bugs.launchpad.net/bugs/2006512/+attachment/5645337/+files/mahara_lock_icon.zip -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006512 Title: 'Manage access' or 'Sharing' - which is it? Status in Mahara: New Bug description: The page which displays management of sharing pages is currently called 'Share'. However, on the 'Portfolios' page, the card dropdown says ' Manage access' http://mahara/view/accessurl.php?collection=1 goes to a page called ' Edit access' See images for more. Titles, buttons, and links that go to the same functionality should be called the same otherwise it creates complexity in people learning to use Mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006512/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] Re: PHP 8 Compatibility: phpcs
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: Fix Committed Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998874] Re: Fix up showcomments for non page comments causing JS error 'author_link'
** Description changed: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save + 5. Go to the notification sent to the owner of the page with the showcomment url + 6. Navigate to the url Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment - Reality: the page comments dropdown opens, and nothing is focused. + Reality: the page comments dropdown opens, and nothing is focused. Also broken page. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998874 Title: Fix up showcomments for non page comments causing JS error 'author_link' Status in Mahara: In Progress Bug description: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save 5. Go to the notification sent to the owner of the page with the showcomment url 6. Navigate to the url Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment Reality: the page comments dropdown opens, and nothing is focused. Also broken page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998874/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003990] [NEW] GrumPHP Mahara for linting on commits
Public bug reported: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: New Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003988] [NEW] glob-parent vulnerability
Public bug reported: glob-parent before 5.1.2 vulnerable to Regular Expression Denial of Service in enclosure regex - https://github.com/advisories/GHSA-ww39-953v-wcq6 - https://nvd.nist.gov/vuln/detail/CVE-2020-28469 - https://cwe.mitre.org/data/definitions/400.html In our third-party libraries, we are waiting for gulp to update their dependencies. However, it's been 3 years since their last update. Unsure if they will. Yet to be fixed: gulp - but not hopeful currently https://twitter.com/gulpjs/status/1564430489473077248?cxt=HHwWgMCqjbrP_LUr However, our CSS gets compiled from hardcoded sass files before webpages get loaded. mahara-themes@1.0.2 /.../.../code/mahara ├─┬ gulp@4.0.2 │ ├─┬ glob-watcher@5.0.5 │ │ └─┬ chokidar@2.1.8 │ │ └── glob-parent@3.1.0 │ └─┬ vinyl-fs@3.0.3 │ └─┬ glob-stream@6.1.0 │ └── glob-parent@3.1.0 deduped └─┬ sass@1.57.1 └─┬ chokidar@3.5.3 └── glob-parent@5.1.2 ✅ ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003988 Title: glob-parent vulnerability Status in Mahara: New Bug description: glob-parent before 5.1.2 vulnerable to Regular Expression Denial of Service in enclosure regex - https://github.com/advisories/GHSA-ww39-953v-wcq6 - https://nvd.nist.gov/vuln/detail/CVE-2020-28469 - https://cwe.mitre.org/data/definitions/400.html In our third-party libraries, we are waiting for gulp to update their dependencies. However, it's been 3 years since their last update. Unsure if they will. Yet to be fixed: gulp - but not hopeful currently https://twitter.com/gulpjs/status/1564430489473077248?cxt=HHwWgMCqjbrP_LUr However, our CSS gets compiled from hardcoded sass files before webpages get loaded. mahara-themes@1.0.2 /.../.../code/mahara ├─┬ gulp@4.0.2 │ ├─┬ glob-watcher@5.0.5 │ │ └─┬ chokidar@2.1.8 │ │ └── glob-parent@3.1.0 │ └─┬ vinyl-fs@3.0.3 │ └─┬ glob-stream@6.1.0 │ └── glob-parent@3.1.0 deduped └─┬ sass@1.57.1 └─┬ chokidar@3.5.3 └── glob-parent@5.1.2 ✅ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003988/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2002364] Re: Copying a group throws error
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2002364
Title:
Copying a group throws error
Status in Mahara:
Fix Committed
Bug description:
When you want to copy a group, the following error message is
displayed and the copying aborted:
[WAR] 0b (lib/errors.php:852) Failed to get a recordset: postgres9 error:
[-1: ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
log_message("Failed to get a recordset: postgres9 error: [-1: E...", 8,
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:89
log_warn("Failed to get a recordset: postgres9 error: [-1: E...") at
/home/kristina/code/mahara/htdocs/lib/errors.php:852
SQLException->__construct("Failed to get a recordset: postgres9 error:
[-1: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:1236
insert_record("block_instance", object(stdClass), "id", true) at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kristina/code/mahara/htdocs/lib/group.php:3354
group_copy(3, "mygroups") at
/home/kristina/code/mahara/htdocs/group/copy.php:44
[WAR] 0b (lib/dml.php:1236) Failed to get a recordset: postgres9 error: [-1:
ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
insert_record() at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kristina/code/mahara/htdocs/lib/group.php:3354
group_copy() at /home/kristina/code/mahara/htdocs/group/copy.php:44
[WAR] 0b (lib/errors.php:852) Failed to get a recordset: postgres9 error:
[-1: ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
log_message("Failed to get a recordset: postgres9 error: [-1: E...", 8,
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:89
log_warn("Failed to get a recordset: postgres9 error: [-1: E...") at
/home/kristina/code/mahara/htdocs/lib/errors.php:852
SQLException->__construct("Failed to get a recordset: postgres9 error:
[-1: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:1236
insert_record("block_instance", object(stdClass), "id", true) at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kristina/code/mahara/htdocs/lib/group.php:3354
group_copy(3, "mygroups") at
/home/kristina/code/mahara/htdocs/group/copy.php:44
[WAR] 0b (lib/dml.php:1236) Failed to get a recordset: postgres9 error: [-1:
ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
insert_record() at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
[Mahara-contributors] [Bug 1998971] Re: Add ctime and mtime to block_instance table
** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) ** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998971 Title: Add ctime and mtime to block_instance table Status in Mahara: In Progress Bug description: Currently, we send notifications out on any change on a page. However, not all changes on a block require letting others know, such as block title changes. With these new columns, we can look at each blocktype independently to decide if a notification needs to be sent out. This will help limit the notification on page updates. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998971] [NEW] Add ctime and mtime to block_instance table
Public bug reported: Currently, we send notifications out on any change on a page. However, not all changes on a block require letting others know, such as block title changes. With these new columns, we can look at each blocktype independently to decide if a notification needs to be sent out. This will help limit the notification on page updates. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998971 Title: Add ctime and mtime to block_instance table Status in Mahara: New Bug description: Currently, we send notifications out on any change on a page. However, not all changes on a block require letting others know, such as block title changes. With these new columns, we can look at each blocktype independently to decide if a notification needs to be sent out. This will help limit the notification on page updates. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998874] [NEW] Fix up showcomments for non page comments causing JS error 'author_link'
Public bug reported: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment Reality: the page comments dropdown opens, and nothing is focused. ** Affects: mahara Importance: Undecided Assignee: Doris Tam (doristam) Status: New ** Summary changed: - Peerassessment comments JS error 'author_link' + Fix up showcomments for non page comments causing JS error 'author_link' ** Description changed: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save - Expectation: on save, the page loads and focuses on the comment + Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment Reality: the page comments dropdown opens, and nothing is focused. ** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998874 Title: Fix up showcomments for non page comments causing JS error 'author_link' Status in Mahara: New Bug description: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment Reality: the page comments dropdown opens, and nothing is focused. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998874/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991605] Re: Outcomes portfolio (5): Checkpoint block infrastructure
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991605 Title: Outcomes portfolio (5): Checkpoint block infrastructure Status in Mahara: In Progress Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio This is especially closely linked to bug #1991604 Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Checkpoint_block_infrastructure # Checkpoint block infrastructure ## High level overview * Create a new block type * Pull information through from the activity page setup for levels of achievement * Deal with achievements and rules of what shall happen once a checkpoint has been achieved * Resembles the peer assessment block * No restriction though who can add comments * No draft option * No instructions * Page comments are still kept separate and could still be used. ## Details ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. Items 1-13 are part of the 'Activity page infrastructure' (see section there for details). Here are only the items listed that pertain to the 'Checkpoint' block, which is a new block type. 14. Checkpoint block is added in full width. When a checkpoint block is deleted by a group tutor or group admin, there is logic that renames all subsequent blocks. 15. Click 'Add comment' to add a comment to the checkpoint. Comments are displayed in reverse chronological order. 16. When a comment was made, the profile picture, the name, the time the comment was made and the comment itself are displayed. Comments can be saved as draft and then published, similarly to the 'Peer assessment'. Comments can be added no matter whether a checkpoint has been achieved or not. 17. [no change] Additional blocks can be pulled onto the page. 18. Set the achievement level with the drop-down menu. The help icon displays the long-form text for the levels. The menu itself only displays 'Level 1', 'Level 2', 'Level 3', and 'Level 4'. 19. Once the level has been set, a number icon represents the achievement level and below it is a help icon that contains the name of the person who set the level and when they did it. It also contains the long description of the achieved level. 20. Group tutors and group admins can delete comments. Editing of comments is possible for 10 minutes after posting or until somebody adds a new comment, whichever comes first. Group members cannot delete comments. > Note: It is possible to add new comments no matter whether an achievement level has been set or not. * New block type but block config is just the normal things that we record for blocks: block type, view, config data, dimensions * new table: ID, blockID, achievement level ID, userID, ctime * New table to record checkpoint results for future proofing in case things do need to be reported over it * Fetches achievement levels from the view_activity_achievement_level table * Levels: Lang string 'Level' added automatically to the priority number of the level * Actual name of the levels is in the help icon * New artefact table similar to peer assessment table To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991605/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991605] Re: Outcomes portfolio (5): Checkpoint block infrastructure
** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991605 Title: Outcomes portfolio (5): Checkpoint block infrastructure Status in Mahara: Confirmed Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio This is especially closely linked to bug #1991604 Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Checkpoint_block_infrastructure # Checkpoint block infrastructure ## High level overview * Create a new block type * Pull information through from the activity page setup for levels of achievement * Deal with achievements and rules of what shall happen once a checkpoint has been achieved * Resembles the peer assessment block * No restriction though who can add comments * No draft option * No instructions * Page comments are still kept separate and could still be used. ## Details ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. Items 1-13 are part of the 'Activity page infrastructure' (see section there for details). Here are only the items listed that pertain to the 'Checkpoint' block, which is a new block type. 14. Checkpoint block is added in full width. When a checkpoint block is deleted by a group tutor or group admin, there is logic that renames all subsequent blocks. 15. Click 'Add comment' to add a comment to the checkpoint. Comments are displayed in reverse chronological order. 16. When a comment was made, the profile picture, the name, the time the comment was made and the comment itself are displayed. Comments can be saved as draft and then published, similarly to the 'Peer assessment'. Comments can be added no matter whether a checkpoint has been achieved or not. 17. [no change] Additional blocks can be pulled onto the page. 18. Set the achievement level with the drop-down menu. The help icon displays the long-form text for the levels. The menu itself only displays 'Level 1', 'Level 2', 'Level 3', and 'Level 4'. 19. Once the level has been set, a number icon represents the achievement level and below it is a help icon that contains the name of the person who set the level and when they did it. It also contains the long description of the achieved level. 20. Group tutors and group admins can delete comments. Editing of comments is possible for 10 minutes after posting or until somebody adds a new comment, whichever comes first. Group members cannot delete comments. > Note: It is possible to add new comments no matter whether an achievement level has been set or not. * New block type but block config is just the normal things that we record for blocks: block type, view, config data, dimensions * new table: ID, blockID, achievement level ID, userID, ctime * New table to record checkpoint results for future proofing in case things do need to be reported over it * Fetches achievement levels from the view_activity_achievement_level table * Levels: Lang string 'Level' added automatically to the priority number of the level * Actual name of the levels is in the help icon * New artefact table similar to peer assessment table To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991605/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997298] Re: Copying a Collection with SmartEvidence throws errors
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997298 Title: Copying a Collection with SmartEvidence throws errors Status in Mahara: In Progress Bug description: When copying a Collection with SmartEvidence the attached errors show up. This appears to be from the foreach ($evidences as $evidence) loop when $newartefact does not appear as a key in $newblocks. To replicate: * Create a Collection * Add SmarteEvidence * Add an Annotation block * Copy the Collection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997298] Re: Copying a Collection with SmartEvidence throws errors
** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997298 Title: Copying a Collection with SmartEvidence throws errors Status in Mahara: New Bug description: When copying a Collection with SmartEvidence the attached errors show up. This appears to be from the foreach ($evidences as $evidence) loop when $newartefact does not appear as a key in $newblocks. To replicate: * Create a Collection * Add SmarteEvidence * Add an Annotation block * Copy the Collection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997199] Re: Group tutors cannot create new pages - page stays loading
Unable to replicate :/ ** Changed in: mahara/22.10 Status: Confirmed => Invalid ** Changed in: mahara/23.04 Status: Confirmed => Invalid ** No longer affects: mahara/22.10 ** No longer affects: mahara/23.04 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997199 Title: Group tutors cannot create new pages - page stays loading Status in Mahara: Invalid Bug description: Set up: 1. Create a controlled group and change the type to 'Course' so that the role 'Tutor' is available. 2. Add a member to the group as a tutor 3. Log in as the tutor and create a new page Expectation: Page is created Reality: The page stays loading and never finishes Dev: the function 'role_has_permission' gets called when a group 'member' creates a page. However, when tutors create a page, this is skipped. It might be missing some checks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997199/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997199] [NEW] Group tutors cannot create new pages - page stays loading
Public bug reported: Set up: 1. Create a controlled group and change the type to 'Course' so that the role 'Tutor' is available. 2. Add a member to the group as a tutor 3. Log in as the tutor and create a new page Expectation: Page is created Reality: The page stays loading and never finishes Dev: the function 'role_has_permission' gets called when a group 'member' creates a page. However, when tutors create a page, this is skipped. It might be missing some checks. ** Affects: mahara Importance: Undecided Status: New ** Affects: mahara/22.04 Importance: Undecided Status: New ** Affects: mahara/22.10 Importance: Undecided Status: New ** Affects: mahara/23.04 Importance: Undecided Status: New ** Changed in: mahara Milestone: None => 22.04.4 ** Changed in: mahara Milestone: 22.04.4 => 22.10.1 ** Changed in: mahara Milestone: 22.10.1 => 22.04.4 ** Also affects: mahara/23.04 Importance: Undecided Status: New ** Also affects: mahara/22.04 Importance: Undecided Status: New ** Also affects: mahara/22.10 Importance: Undecided Status: New ** Description changed: Set up: 1. Create a controlled group and change the type to 'Course' so that the role 'Tutor' is available. 2. Add a member to the group as a tutor 3. Log in as the tutor and create a new page Expectation: Page is created Reality: The page stays loading and never finishes + + + Dev: the function 'role_has_permission' gets called when a group 'member' creates a page. However, when tutors create a page, this is skipped. It might be missing some checks. ** Changed in: mahara/23.04 Milestone: 22.04.4 => 23.04.0 ** Changed in: mahara/22.10 Milestone: None => 22.04.4 ** Changed in: mahara/22.04 Milestone: None => 22.10.1 ** Changed in: mahara/22.04 Milestone: 22.10.1 => 22.04.4 ** Changed in: mahara/22.10 Milestone: 22.04.4 => 22.10.1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997199 Title: Group tutors cannot create new pages - page stays loading Status in Mahara: New Status in Mahara 22.04 series: New Status in Mahara 22.10 series: New Status in Mahara 23.04 series: New Bug description: Set up: 1. Create a controlled group and change the type to 'Course' so that the role 'Tutor' is available. 2. Add a member to the group as a tutor 3. Log in as the tutor and create a new page Expectation: Page is created Reality: The page stays loading and never finishes Dev: the function 'role_has_permission' gets called when a group 'member' creates a page. However, when tutors create a page, this is skipped. It might be missing some checks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997199/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1952143] Re: Default width for blocks to be full-width
** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1952143 Title: Default width for blocks to be full-width Status in Mahara: In Progress Bug description: This item follows the design and usability considerations discussed in the analysis of this related Wishlist item: https://bugs.launchpad.net/mahara/+bug/1860600 The recommendation is that the default width for blocks on all pages is to be full-width, with the ability to adjust this as desired. This option already exists for those creating pages in accessible mode. To be applied to individual, group, institution, site and template pages, i.e. all pages, in 'normal' mode. In summary, this is an improvement on aesthetics, equity and usability. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1952143/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996114] Re: Move sign-off/verify functionality out of the sign-off block
** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) ** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996114 Title: Move sign-off/verify functionality out of the sign-off block Status in Mahara: In Progress Bug description: Move the configuration for signing-off and verifying a page into the page settings. Move the action of signing-off and verifying a page out of a block and display it at the top of a page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996114/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996114] [NEW] Move sign-off/verify functionality out of the sign-off block
Public bug reported: Move the configuration for signing-off and verifying a page into the page settings. Move the action of signing-off and verifying a page out of a block and display it at the top of a page. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996114 Title: Move sign-off/verify functionality out of the sign-off block Status in Mahara: New Bug description: Move the configuration for signing-off and verifying a page into the page settings. Move the action of signing-off and verifying a page out of a block and display it at the top of a page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996114/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1986746] Re: A few missing strings on the 'Admin overview' page
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1986746 Title: A few missing strings on the 'Admin overview' page Status in Mahara: Fix Released Bug description: In the 'Manage people' area, two strings are missing: 'adduser/admin' and 'uploadcsv/admin'. In the 'Configure site' block, 'Viewscollections/view' looks are missing. Both these appear to be missing on 'main' (currently 22.10_DEV) Please see the attached screenshot To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1986746/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1981767] Re: Fix spelling mistakes found by codespell
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1981767 Title: Fix spelling mistakes found by codespell Status in Mahara: Fix Released Bug description: Fix spelling mistakes found by codespell to not trip on them every time. This includes fixing typos in comments, but excludes fixing spelling mistakes in third-party libraries for the time being. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1981767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1981386] Re: select2.full.js doesn't load if wwwroot is not set
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1981386
Title:
select2.full.js doesn't load if wwwroot is not set
Status in Mahara:
Fix Released
Bug description:
If $cfg->wwwroot is not set it defaults to '/'. In head.tpl (linked
below) this file is included with a src of
{$WWWROOT}/js/select2/select2.full.js
In the resulting html this becomes //js/select2/select2.full.js and
the browser will translate that to https://js/select2/select2.full.js
which is a broken link.
There are many other
[Mahara-contributors] [Bug 1981944] Re: Add XML-RPC to impish and jammy
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1981944 Title: Add XML-RPC to impish and jammy Status in Mahara: Fix Released Bug description: This relates to Docker and the versions of Ubuntu available there Code review at https://reviews.mahara.org/c/mahara/+/13001 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1981944/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1982719] Re: Allow for default values to new LTI advantage fields In case the tables already have content
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1982719 Title: Allow for default values to new LTI advantage fields In case the tables already have content Status in Mahara: Fix Released Bug description: We need to set them up with correct default values To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1982719/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1984016] Re: Updating the supported web browsers on the "Login" help page.
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1984016 Title: Updating the supported web browsers on the "Login" help page. Status in Mahara: Fix Released Bug description: Since Internet Explorer has retired on 15 June 2022, We need to update the supported web browsers on the "Login" help page (lang/en.utf8/help/sections/loginbox.html). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1984016/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1983802] Re: Behat: Semi-automating manual check for eyeballing themes
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1983802 Title: Behat: Semi-automating manual check for eyeballing themes Status in Mahara: Fix Released Bug description: This is related to the work the general refactoring that the Mahara Team does fortnightly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1983802/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1988005] Re: Groups containing collections with cover images cannot be deleted
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1988005 Title: Groups containing collections with cover images cannot be deleted Status in Mahara: Fix Released Status in Mahara 21.04 series: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: Fix Released Bug description: Attempting to delete a Group containing one or more collections with cover images set cannot be deleted due to a foreign key relation between collection and artifact for the "coverimage". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1988005/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1984032] Re: The adding people by CSV page's progress now finishes at 110%
** Changed in: mahara Status: Fix Committed => Won't Fix ** Changed in: mahara Status: Won't Fix => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1984032 Title: The adding people by CSV page's progress now finishes at 110% Status in Mahara: Fix Released Bug description: Some recent change causes the bar to go outside the box as it reaches 110% max instead of 100% To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1984032/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1984851] Re: Site logo not shown in maintenance mode
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1984851 Title: Site logo not shown in maintenance mode Status in Mahara: Fix Released Bug description: When a site is in maintenance mode, a site logo uploaded via the admin interface is not displayed to people who are not logged in. This should be rectified because any logo shown on the site should be public one and not required to be hidden. To test: 1. Upload a logo for 'No institution' in Admin menu -> Institutions -> Settings. 2. Put the site into maintenance mode. 3. Log out and view the site. Results: - Expected: You can see the logo. - Actual: The logo displays as broken image. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1984851/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1988701] Re: Selected rows that are grey in 'People search' are not highlighted
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1988701 Title: Selected rows that are grey in 'People search' are not highlighted Status in Mahara: Fix Released Bug description: When I select everyone on the 'People search' page in the admin area, only the rows that normally have a white background are highlighted in yellow, but all the grey rows stay grey when they should also receive the same colour since I'm selecting those rows as well. See screenshot. To replicate: 1. Create more than 3 accounts on your site. 2. Go to Admin menu -> People -> People search. 3. Select all accounts. Results: - Expected: All rows are highlighted in yellow because they are selected. - Actual: Only every other row is highlighted in yellow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1988701/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1844199] Re: Check skin before when copying a page
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1844199 Title: Check skin before when copying a page Status in Mahara: Fix Released Bug description: When creating a site/group/institution page, we should not be allowing to choose from "My skins". When copying a page, there should be a check to see if the user that wants to copy has access to the skin. If not, the skin should not be included in the new page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1844199/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1946619] Re: UX: Change 'Return to pages and collections' button icon
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1946619 Title: UX: Change 'Return to pages and collections' button icon Status in Mahara: Fix Released Bug description: We currently have a back button that allows people to return back to the 'Pages and collections' page. The icon is an arrow pointing to the left to indicate "go back". This button is displayed when they are viewing a page in edit mode, but not in display mode. If I have navigated to the second page of a collection, the meaning of this icon changes. It does not take me "back" to the previous screen, but it takes me back to the 'Pages and collections' page. A solution to this would be to change the icon from a back arrow, to a books icon. The image of books is commonly used to represent a library, or a place where all pages/artefects/things are stored. I think this would more clearly communicate the function of this button, as a quick link back to the place where all of the person's work is stored. (Match between system and real world) This can be further reinforced by renaming the 'Pages and collections' page to "Portfolio Library" as in this bug report here: https://bugs.launchpad.net/mahara/+bug/1946291 Furthermore, having this books/return icon available in all modes for collections and portfolios would improve the usability significantly. As the user will spend a lot of time navigating through pages and artefacts to manage their learning, it makes sense to give them the option to 'return home' at any point in their journey (User control and freedom). (An even better fix could be to include the books icon in the navbar, so that the user has quick, one-click access to their portfolio library from any view in the site.) Link to fontawesome books icon: https://fontawesome.com/v5.15/icons/books?style=solid (This is under the paid plan, but I'm sure we could find or make something consistent with our design scheme). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1946619/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1918357] Re: Use dart-sass instead of node-sass for gulp make css
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1918357 Title: Use dart-sass instead of node-sass for gulp make css Status in Mahara: Fix Released Bug description: Node-sass uses Lib-sass which is deprecated. Node-sass is deprecated and bootstrap recommends dart-sass over it for the new version to be compatible with upgrading the library. This is related to https://bugs.launchpad.net/mahara/+bug/1918373 with reference to https://getbootstrap.com/docs/5.0/getting-started/build- tools/#sass for future purposes when we have BS5 https://getbootstrap.com/docs/5.0/getting-started/build- tools/#tooling-setup To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1918357/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1939364] Re: Using plan templates throws an error on Collection creation when plan is associated with an assigned TaskView
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1939364 Title: Using plan templates throws an error on Collection creation when plan is associated with an assigned TaskView Status in Mahara: Fix Released Bug description: The only situation I've found this is when we copy a group with plans. The functionality to duplicate a plan doesn't seem to be an option elsewhere. Create a plan template. Set it as a template with assignment tasks on. Create a task for that plan template, attaching a collection etc. Create a new plan from the template in a group. Submit without changing anything. Error is thrown. 1. Create a page. 2. Create a group and add five members. 3. Create a personal plan with these settings: 1. Assignment tasks (Yes). 2. Template (Yes). 4. Create a task for the plan with these settings: 1. Select your a page to be the ‘Task page’. 5. In your group, create a new plan from your personal plan template. 6. Check that once the template is applied, ‘Assignment tasks’ setting is ‘Yes’. 7. Press save. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1939364/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1962219] Re: Upgrade JSON Editor from 1.3.5 to 2.6.1
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1962219 Title: Upgrade JSON Editor from 1.3.5 to 2.6.1 Status in Mahara: Fix Released Bug description: https://github.com/json-editor/json-editor/blob/master/CHANGELOG.md 2.x Major fixes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1962219/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1947785] Re: UX/IA: Change 'Add' button to 'Create' on 'Pages and collections' overview page
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1947785 Title: UX/IA: Change 'Add' button to 'Create' on 'Pages and collections' overview page Status in Mahara: Fix Released Bug description: Follow-on from bug #1946291 Location: 'Pages and collections' overview page Summary The term 'add' implies that something that already exists is being added to the user's profile. However in reality, when we click 'add', we are actually creating a page, or a collection/portfolio that didn't already exist. As a new user, seeing the word 'add' creates some hesitancy, as we don't have anything to add at that point. What we're trying to do is create something new. When we open the menu we see a "Create" menu, when we click 'Add' the heading of the modal says 'Create'. Therefore, my proposal is that the word 'Add' in the button on the 'pages and collections' page be replaced with 'Create'. I believe this is a simple change that will improve the usability of Mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1947785/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1951892] Re: Update library: Popper JS from 1.16 to 2.X (needed for BS5)
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1951892 Title: Update library: Popper JS from 1.16 to 2.X (needed for BS5) Status in Mahara: Fix Released Bug description: Bootstrap 5 is not compatible with Popper JS 1.16 , therefore in the works of getting Bootstrap 5 to work with Mahara, we need to upgrade this library. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1951892/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1968758] Re: Typo in a support admin lang string
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1968758 Title: Typo in a support admin lang string Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Bug description: Supprt administrators updated Context: lang/en.utf8/admin.php supportadminusersupdated To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1968758/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1964826] Re: Unreliable results in user_content/placeholder.feature
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1964826 Title: Unreliable results in user_content/placeholder.feature Status in Mahara: Fix Released Bug description: The step "Then I should see "Please edit this block to choose its type."" in the Scenario "Adding a placeholder block to the page" has inconsistent results. This appears to be because it is only sometimes visible when the test is run. There is very little on the page and jumping to the end seems to allow the issue to resolve. This could be resolved with a "And I scroll to the end|bottom" step. This doesn't appear to be available yet. I tried with "And I scroll to the base of id "powered-by"" but with the block being in a dynamically sized div it doesn't quite scroll far enough. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1964826/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1965079] Re: Group invite reason got lost
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1965079
Title:
Group invite reason got lost
Status in Mahara:
Fix Released
Bug description:
When you invite someone via their profile page, you can enter a reason
for them to join the group. That used to be added to the notification
they received. However, that is not the case any more and only a
generic notification is sent.
To replicate:
1. Create a group.
2. Go to somebody else's profile page.
3. Invite them to the group.
4. Fill in a reason.
Results:
- Expected: The reason shows up in the notification.
- Actual: It doesn't.
The current notification (replicated is the plain text one, but if an
HTML one exists) is:
DISPLAYNAME (function) OF GROUP ADMIN has invited you to join a group,
'GROUPTITLE'. Click on the link below
for more information.
See http://DOMAIN/group/view.php?id=1
Suggested updated notification
-
Hi FIRSTNAME,
I'd like to invite you to join the group 'GROUPTITLE'.
[This section only if a reason was given] My reason is:
{add the reason that was provided}
Go to http://mahara.anitsirk.wgtn.cat-it.co.nz/group/view.php?id=1 to accept
or decline this invitation.
Thank you
DISPLAYNAME OF GROUPADMIN who invited the person
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1965079/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969717] Re: Unable to select a skin for a page with the keyboard
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969717 Title: Unable to select a skin for a page with the keyboard Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: Fix Released Bug description: When I am creating a page and I want to use a skin, I am unable to select a skin using the keyboard only to select it. 1. Log in as site admin. 2. Create a site skin at Admin menu → Configure site → Skins. 3. Create one new account. 4. Create a personal skin via Main menu → Create → Skins and make it a public one. 5. Log in as the other account holder. 6. Favourite the site admin's skin via Main menu → Create → Skins. 7. Create a personal skin. 8. Add a page and use the keyboard to navigate to the 'Skins' panel on the 'Settings' page. Results: - Expected: You can select your personal skin, click the panels for the favourite and site skins and select those. - Actual result: You can only click the headers, but not the skins themselves, and the panels for the favourite and site skins don't expand. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969717/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969549] Re: Styling issue when viewing exported page with Maroon theme in browser
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969549 Title: Styling issue when viewing exported page with Maroon theme in browser Status in Mahara: Fix Released Bug description: Tested in Firefox with MySQL8 and the Maroon theme Test steps: HTML export 1) Create a page with page instructions and a text block. 2) Export the page and save the file to your computer. 3) Extract the archive and open the index.html page in a browser. Problems: - page heading is aligned diagonally with the header - Information in the footer "Export generated for [Name of the person] on 20 April 2022, 14:47, from their portfolio at Mahara" is not readable due to almost zero contrast ratio See attached screenshot To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969549/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1970277] Re: Consistent display of language names around Mahara
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1970277 Title: Consistent display of language names around Mahara Status in Mahara: Fix Released Bug description: The new language pack management section was created in this patch: https://bugs.launchpad.net/mahara/+bug/1884717 The option for te reo Māori currently just says "Maori" - this is missing the macron over the a, and should also really say "Te Reo Māori" (imo) 1. Admin>Development>Languages 2. Open "Add language" menu Expected: - see the option "Te Reo Māori" or at least "Māori" (with macron) Actual: - option is "Maori" Brief chat in the Catalyst 'kōrero' channel: "For me, Te Reo Māori" "I don't think I'd care although 'Te Reo Māori' is the language" "I'm used to seeing "Te Reo Māori" or even just "Te Reo"" "Google only uses Māori the word language is already in the selection label? Imho what also influences this is whether you write the language names in their language or in English" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1970277/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1970693] Re: module_submissions: Missing language string
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1970693 Title: module_submissions: Missing language string Status in Mahara: Fix Released Status in Mahara 21.04 series: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Bug description: This item creates the language strings for when Mahara prevents you from submitting an assessment. Test Cases: Submit assignment as student Do not grade or access as staff Revoke submission as student Attempt to resubmit same page Version: 21.10.1 Database: postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1970693/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1971654] Re: More information on PDF/PDFLite when export fails
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1971654 Title: More information on PDF/PDFLite when export fails Status in Mahara: Fix Released Bug description: More feedback on PDF/PDFLite when exporting to help diagnose why it is not working for some To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1971654/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1971910] Re: install_blocktype_viewtypes_for_plugin() needs to check if block still exists
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1971910 Title: install_blocktype_viewtypes_for_plugin() needs to check if block still exists Status in Mahara: Fix Released Bug description: If a blocktype is deleted then on upgrading to a newer version if we call install_blocktype_extras() for another block - it will cause errors / upgrade fail. The install_blocktype_viewtypes_for_plugin() function should behave like the install_blocktype_categories_for_plugin() for calling the safe require() To test: 1) Install a 21.10 site 2) Checkout main 3) Delete a blocktype plugin from codebase, eg rm -rf htdocs/blocktype/myfriends/ 4) Run upgrade Without patch - get errors: [WAR] 47 (lib/mahara.php:1711) File htdocs/blocktype/myfriends/lib.php did not exist Call stack (most recent first): * safe_require() at htdocs/lib/upgrade.php:1235 * install_blocktype_viewtypes_for_plugin() at htdocs/lib/upgrade.php:1273 * install_blocktype_extras() at htdocs/lib/db/upgrade.php:450 * xmldb_core_upgrade() at htdocs/lib/upgrade.php:377 * upgrade_core() at htdocs/lib/mahara.php:281 * upgrade_mahara() at htdocs/admin/cli/upgrade.php:76 With patch should allow upgrade without errors To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1971910/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1976197] Re: Redundant div when replying to a message
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1976197 Title: Redundant div when replying to a message Status in Mahara: Fix Released Bug description: This is not easy to replicate at all. When you reply to a private message, it could be that the side blocks were left at the top and the entire message dropped to the bottom. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1976197/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973822] Re: SmartEvidence summary repeats
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973822 Title: SmartEvidence summary repeats Status in Mahara: Fix Released Bug description: The Sum of Statuses line repeats if more than one Framework is in use. This line looks to only be needed at the start and end of the list. Testing: 1. Set up a SE framework with multiple standards, e.g. download an EntreComp one from https://seafile.catalyst.net.nz/d/c5a4876b06/ 2. Configure the framework so it displays all assessment statuses. 2. Create a collection with this framework. 3. Add annotations. 4. Refresh the overview page. Results: - Expected: There is only one sum line at the top of the table and one at the bottom. - Actual: There are sum lines after each standard. c.f https://bugs.launchpad.net/mahara/+bug/1968769 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1977671] Re: External system tries to get the remote path even when it's not enabled.
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1977671 Title: External system tries to get the remote path even when it's not enabled. Status in Mahara: Fix Released Bug description: When trying to download a file, it needs to check if an external file system is enabled before it goes off to object storage like S3 to try to download the file. Steps to reproduce: 1. Fresh install mahara 2. Install https://github.com/catalyst/mahara-module_aws and https://github.com/catalyst/mahara-module_objectfs 3. Configure the plugin with test S3 crendentials 4. Ensure that Enable transfer tasks is unticked (we installed the plugin but not using it yet). 5. Add this in config.php $cfg->externalfilesystem = array( "includefilepath" => "module/objectfs/classes/s3_file_system.php", "class" => "module_objectfs\\s3_file_system" ); 6. Upload an image on the artefact (site/artefact/file/index.php) 7. Rotate the image. It would be broken and the only way to fix is to move back orientation to 0 8. If possible, check the logs and you will see it's trying to grab a file from S3 At the moment, when downloading/rotating a file where an external system plugin is installed, it doesn't check whether it's enabled or not. It only checks if there is an external system and then tries getting the remote path if it fails getting local path. PS: this is very similar to https://bugs.launchpad.net/mahara/+bug/1975712 however in this case the external system is not enabled but it's still trying to download the image from S3. It should check first if it's enabled, if disabled then it should proceed to get local path. I understand this is quite specific. Please let me know if you need more information from me. I will create a patch for this :) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1977671/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1977800] Re: Replace h3 tags with h1 tags in htdocs/lang/en.utf8/help files
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1977800 Title: Replace h3 tags with h1 tags in htdocs/lang/en.utf8/help files Status in Mahara: Fix Released Bug description: Replace h3 tags with h1 tags in htdocs/lang/en.utf8/help files for accessibility To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1977800/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1978300] Re: Mahara 22.04 upgrade fails due to missing use of dbprefix syntax
** Changed in: mahara/22.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1978300
Title:
Mahara 22.04 upgrade fails due to missing use of dbprefix syntax
Status in Mahara:
Fix Released
Status in Mahara 21.04 series:
Fix Committed
Status in Mahara 21.10 series:
Fix Released
Status in Mahara 22.04 series:
Fix Committed
Status in Mahara 22.10 series:
Fix Released
Bug description:
Mahara 22.04.1
Upgrade failed when using "$cfg->dbprefix" in config.php due to missing
brackets in
lib/dp/upgrade.php :
Line 842
execute_sql("UPDATE artefact SET title = ? WHERE id = ?",
array($record->email, $record->id));
need to be
execute_sql("UPDATE {artefact} SET title = ? WHERE id = ?",
array($record->email, $record->id));
Thanks
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1978300/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979148] Re: Bootstrap 5: 'Skip to main content' button not visible
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1979148 Title: Bootstrap 5: 'Skip to main content' button not visible Status in Mahara: Fix Released Bug description: Test environment: Chromium/Firefox 1. Visit Dashboard 2. Press the tab key once Expected: - 'Skip to main content' button visible on page top left Actual: - Not visible (but still accessible via keyboard) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1979148/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979150] Re: Accessibility: Keyboard access/Tab focus order - 'Add page' is last, should be first
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1979150 Title: Accessibility: Keyboard access/Tab focus order - 'Add page' is last, should be first Status in Mahara: Fix Released Bug description: Test environment: Chrome and Firefox on main When visiting view/index.php, using keyboard only, the tab focus lands on the search field, and then it moves through each existing page, through the side panels, then the footer, then the header and menus BEFORE moving to the 'Add page'/'copy' buttons. We need to change the focus order so that someone using a keyboard can access the 'Add page' button before having to tab through the entire contents of the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1979150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979162] Re: Chart.js canvas element overlaps legend data between 992 and 1200px
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1979162 Title: Chart.js canvas element overlaps legend data between 992 and 1200px Status in Mahara: Fix Released Bug description: Tested in Chrome on Main with Bootstrap 4 and on Chrome with Bootstrap 5 To test: 1. Create 6 institutions with at least 1 person in each 2. run cron 3. Go to Admin > reports page 4. Resize screen to between 992 and 1200px wide 5. Check 'People by institution' pie chart Outcome: Piechart overlaps legend at this screen width, as width and height changes responsively. The width and height seems to be controlled by the canvas aspect-ratio property in CSS in response to the size of the parent div. Need to look into it further to resolve. https://www.chartjs.org/docs/latest/configuration/responsive.html To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1979162/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979921] Re: Potential issue with artefact chooser and getting group artefacts
** Changed in: mahara/22.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1979921
Title:
Potential issue with artefact chooser and getting group artefacts
Status in Mahara:
Fix Released
Status in Mahara 21.04 series:
Fix Committed
Status in Mahara 21.10 series:
Fix Released
Status in Mahara 22.04 series:
Fix Committed
Status in Mahara 22.10 series:
Fix Released
Bug description:
There is an issue with View::get_artefactchooser_artefacts() if we
pass it a $group identifier as a integer rather than a string or a
class.
We need to fix that up so a group ID passed in as integer is also
handled other wise the error below can occur.
The was reported by a community member and the only way I could
replicate it was doing the following.
Make this change:
diff --git a/htdocs/blocktype/lib.php b/htdocs/blocktype/lib.php
index 1bb21f32af..816969a241 100644
--- a/htdocs/blocktype/lib.php
+++ b/htdocs/blocktype/lib.php
@@ -2337,7 +2337,7 @@ class BlockInstance {
list($allowed, $count) = View::get_artefactchooser_artefacts(
$searchdata,
$this->get_view()->get('owner'),
-$this->get_view()->get('group'),
+(int)$this->get_view()->get('group'),
$this->get_view()->get('institution'),
true
);
Then create a new group and on the group homepage click 'edit'.
Add a new block of content type 'image' to the page, upload an image to
'group files' tab, select it and click save.
Then resize the image by dragging its corner to make it wider and higher.
Reload page and see the error.
But as they got the error without altering the code it would be best
to harden the View::get_artefactchooser_artefacts() so it can deal
with integer correctly.
[WAR] f1 (lib/view.php:3841) get_class() expects parameter 1 to be object,
int given
Call stack (most recent first):
log_message("get_class() expects parameter 1 to be object, int ...", 8, true,
true, "/var/www/html/mahara.abc.xyz/lib/v...", 3841) at
/var/www/html/mahara.abc.xyz/lib/errors.php:515
error(2, "get_class() expects parameter 1 to be object, int ...",
"/var/www/html/mahara.abc.xyz/lib/v...", 3841, array(size 19)) at
/var/www/html/mahara.abc.xyz/lib/view.php:3841
View::get_artefactchooser_artefacts(array(size 2), null, 603, null, true) at
/var/www/html/mahara.abc.xyz/blocktype/lib.php:2336
BlockInstance->rebuild_artefact_list() at
/var/www/html/mahara.abc.xyz/blocktype/lib.php:2275
BlockInstance->commit() at /var/www/html/mahara.abc.xyz/lib/view.php:2829
View->moveblockinstance(array(size 7)) at
/var/www/html/mahara.abc.xyz/lib/view.php:2107
View->process_changes() at
/var/www/html/mahara.abc.xyz/view/blocks.json.php:30
[WAR] f1 (lib/errors.php:853) Failed to get a recordset: mysqli error: [0: ]
in EXECUTE("SELECT DISTINCT agg.* FROM (SELECT a.id, a.id AS b FROM "artefact"
a LEFT JOIN "tag" t ON t.resourcetype = 'artefact' AND a.id = t.resourceid
LEFT OUTER JOIN (
SELECT
r.artefact, r.can_view, r.can_edit, m.group
FROM
"group_member" m
JOIN "artefact" aa ON aa.group = m.group
JOIN "artefact_access_role" r ON aa.id = r.artefact AND
r.role = m.role
WHERE
m.group = ?
AND m.member = ?
AND r.can_view = 1
) ga ON (ga.group = a.group AND a.id = ga.artefact) WHERE
(a.institution = 'mahara' OR ga.can_view = 1 OR a.owner = ?) AND a.id = 291249)
AS agg")Command was: SELECT DISTINCT agg.* FROM (SELECT a.id, a.id AS b FROM
"artefact" a LEFT JOIN "tag" t ON t.resourcetype = 'artefact' AND a.id =
t.resourceid
LEFT OUTER JOIN (
SELECT
r.artefact, r.can_view, r.can_edit, m.group
FROM
"group_member" m
JOIN "artefact" aa ON aa.group = m.group
JOIN "artefact_access_role" r ON aa.id = r.artefact AND
r.role = m.role
WHERE
m.group = ?
AND m.member = ?
AND r.can_view = 1
) ga ON (ga.group = a.group AND a.id = ga.artefact) WHERE
(a.institution = 'mahara' OR ga.can_view = 1 OR a.owner = ?) AND a.id = 291249)
AS agg and values was (0:1135)
Call stack (most recent first):
log_message("Failed to get a recordset: mysqli error: [0: ] in ...", 8, true,
true) at /var/www/html/mahara.abc.xyz/lib/errors.php:89
log_warn("Failed to get a recordset: mysqli error: [0: ] in ...") at
[Mahara-contributors] [Bug 1980291] Re: file_cleanup_old_temp_files() causing an error
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1980291 Title: file_cleanup_old_temp_files() causing an error Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: Fix Released Bug description: The following is appearing in the logs when cron runs [WAR] 7e (lib/file.php:973) Undefined offset: 0 Call stack (most recent first): • log_message(string(size 19), integer, true, true, string(size 33), integer) at /var/www/html/mahara/lib/errors.php:515 • error(integer, string(size 19), string(size 33), integer, array(size 3)) at /var/www/html/mahara/lib/file.php:973 • file_cleanup_old_temp_files() at /var/www/html/mahara/lib/cron.php:201 This is caused by some incorrect code To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1980291/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
