Re: [nant-dev] Fwd: Filesets referencing filesets ?
-Original Message- From: Martin Aliger [mailto:[EMAIL PROTECTED] Sent: Monday, September 5, 2005 11:19 AM To: nant-developers@lists.sourceforge.net Subject: RE: [nant-dev] Fwd: Filesets referencing filesets ? Hello, I agree, these problems should be resolved before we introduce this feature. I'm tempted to include it and let people have a play with it and then refine it as necessary rather than holding out until its perfect. What do people think ? I'm not convinced to either. Resolve those issues completely could be pretty diffucult, but 95% use cases will be trivial case without basedirs and include/exclude conflict. IMHO atleast overall strategy should be discussed before introducing this feature to the core. I'd rather have a more general approach, where all global types implement support for merging two distinct instances. I dont think I catch it. How could have general type merge operator? I'm pretty sure that merging several data type instances does not only apply to filesets. For example, users will probably also want to have different sets of namespace imports that they can combine where needed. I think you even made a proposal for this a while ago. Gert --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Fwd: Filesets referencing filesets ?
Hello, I agree, these problems should be resolved before we introduce this feature. I'm tempted to include it and let people have a play with it and then refine it as necessary rather than holding out until its perfect. What do people think ? I'm not convinced to either. Resolve those issues completely could be pretty diffucult, but 95% use cases will be trivial case without basedirs and include/exclude conflict. IMHO atleast overall strategy should be discussed before introducing this feature to the core. I'd rather have a more general approach, where all global types implement support for merging two distinct instances. I dont think I catch it. How could have general type merge operator? Also, I'm not sure if this is something we should introduce this late in the game. We should try to get 0.85 out asap ... I've been too busy lately, but I hope to find a few hours next week ... I definitely don't mean to sound disrespectful here. I appreciate the work Martin has been doing here ! Agreed it should go after 0.85. No new features after RC is out is good strategy, I think. Martin --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Fwd: Filesets referencing filesets ?
I'd rather have a more general approach, where all global types implement support for merging two distinct instances. Is this meaningful for all types? Or just those that are collections? Does it make sense, for example, to talk about merging two proxies? Exactly. btw: it would be also very helpful to have some other collection types in core, mainly StringCollection. Any Collection should be enumerable by foreach task. I was in need of it once, fortuntelly it could be (pretty easily) workarounded in string using seperator char. Still, it'd be nice. Any idea how merge operator could be generalized to any collection type? Martin --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Fwd: Filesets referencing filesets ?
I would definitely like the ability to combine filesets, personally... it places less onus on the task creator to add explicit support to reference files in different locations. I think that it is critical to support merging filesets with different basedirs, given this is probably the most requested feature for some tasks, such as the zip task - create a zip including files from different folders... the path to the file from the basedir is very important when determining the retained path in the zip. Ok, lets discuss that on test-case example: fileset id=foo1 basedir=. include name=world.peace / include name=*.war / /fileset fileset id=foo2 basedir=..\t2\ includesfileset refid=foo1 / include name=reefer.saddness / include name=*.war / /fileset both dirs includes 3 files: reefer.saddness world.peace world.war What should Scan() on foo2 return? It always returns full pathnames so I'd expect simply: c:\foo\t1\world.peace c:\foo\t1\world.war c:\foo\t2\world.war c:\foo\t2\reefer.saddness Not very handy for zip task, I think... Perhaps zip is better with filesetcollection (each with different basedir) as it is in current design. Some better ideas? -- Regarding includes/excludes conflicts, I think it would make the most sense (ie- least support queries) to offer both: Logical intersection of two filesets - include all files referenced in each fileset, regardless if that file is excluded by the other fileset: fileset include fileset=fileset1/ include fileset=fileset2/ /fileset Logical subtraction of two filesets - include those files in fileset1 that are not in fileset2: fileset include fileset=fileset1/ exclude fileset=fileset2/ /fileset I'm not convinced it makes sense to include logical intersection of two filesets. Regarding determining hits between the contents of filesets for subtraction, I would suggest comparison based on path to the file relative to the containing fileset's basedir... so the file /a/b/c/d with a basedir of /a/b and the file /x/y/z/c/d with a basedir of /x/y/z would have the same relative path. First could be easy. For exclusion, we could compare full referenced (scanned) filenames. But what if I do this: fileset include fileset=foo1/ exclude name=*.war/ /fileset ? Should be c:\foo\t1\world.war excluded from result fileset. What if basedir differs? Any ideas are welcomed (as always :-) Martin --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fwd: Filesets referencing filesets ?
- Original Message - From: Ian MacLean [EMAIL PROTECTED] To: Martin Aliger [EMAIL PROTECTED] Cc: 'Rory Becker' [EMAIL PROTECTED]; nant-developers@lists.sourceforge.net Sent: Wednesday, August 31, 2005 5:46 AM Subject: Re: [nant-dev] Fwd: Filesets referencing filesets ? Hi Martin, Martin Aliger wrote: Thanks, here is patch again, this time it is agains 0.85 RC3. I'd really love to see this incorporated in core. There are some implementation problems which we already discussed, though: - what should happen, if referenced fileset have another basedir ? - what should happen, if exclude/include of 2 filesets conflicts ? - is every possible combination of those covered in test cases? For mine use, I dont combine basedirs and dont use excludes at all, but those problems should be solved. I feel, this is main problem why this extension wasnt incorporated yet. Maybe we could discuss it now... I agree, these problems should be resolved before we introduce this feature. I'm tempted to include it and let people have a play with it and then refine it as necessary rather than holding out until its perfect. What do people think ? I'd rather have a more general approach, where all global types implement support for merging two distinct instances. Also, I'm not sure if this is something we should introduce this late in the game. We should try to get 0.85 out asap ... I've been too busy lately, but I hope to find a few hours next week ... I definitely don't mean to sound disrespectful here. I appreciate the work Martin has been doing here ! Gert --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fwd: Filesets referencing filesets ?
Gert Driesen wrote: ... - what should happen, if referenced fileset have another basedir ? - what should happen, if exclude/include of 2 filesets conflicts ? - is every possible combination of those covered in test cases? For mine use, I dont combine basedirs and dont use excludes at all, but those problems should be solved. I feel, this is main problem why this extension wasnt incorporated yet. Maybe we could discuss it now... I agree, these problems should be resolved before we introduce this feature. I agree, too. Otherwise it will be impossible to test and chaos around the expected results will ensue. I'm tempted to include it and let people have a play with it and then refine it as necessary rather than holding out until its perfect. What do people think ? I'd rather have a more general approach, where all global types implement support for merging two distinct instances. Is this meaningful for all types? Or just those that are collections? Does it make sense, for example, to talk about merging two proxies? Also, I'm not sure if this is something we should introduce this late in the game. I am sure - it's not. Once a release candidate has gone out the door, with the intent of a final release soon thereafter, only bug fixes should go in. No feature requests, enhancements, etc. Sometimes there's a gray area as to whether something is a bug fix or an enhancement, but I think this is clearly the latter. Gary --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fwd: Filesets referencing filesets ?
On 8/26/05, Martin Aliger [EMAIL PROTECTED] wrote: Thanks, here is patch again, this time it is agains 0.85 RC3. I'd really love to see this incorporated in core. There are some implementation problems which we already discussed, though: - what should happen, if referenced fileset have another basedir ? - what should happen, if exclude/include of 2 filesets conflicts ? - is every possible combination of those covered in test cases? For mine use, I dont combine basedirs and dont use excludes at all, but those problems should be solved. I feel, this is main problem why this extension wasnt incorporated yet. Maybe we could discuss it now... My take on the matter... I would definitely like the ability to combine filesets, personally... it places less onus on the task creator to add explicit support to reference files in different locations. I think that it is critical to support merging filesets with different basedirs, given this is probably the most requested feature for some tasks, such as the zip task - create a zip including files from different folders... the path to the file from the basedir is very important when determining the retained path in the zip. Regarding includes/excludes conflicts, I think it would make the most sense (ie- least support queries) to offer both: Logical intersection of two filesets - include all files referenced in each fileset, regardless if that file is excluded by the other fileset: fileset include fileset=fileset1/ include fileset=fileset2/ /fileset Logical subtraction of two filesets - include those files in fileset1 that are not in fileset2: fileset include fileset=fileset1/ exclude fileset=fileset2/ /fileset I'm not convinced it makes sense to include logical intersection of two filesets. Regarding determining hits between the contents of filesets for subtraction, I would suggest comparison based on path to the file relative to the containing fileset's basedir... so the file /a/b/c/d with a basedir of /a/b and the file /x/y/z/c/d with a basedir of /x/y/z would have the same relative path. Comments? Do other people's (expected?) usage patterns of filesets match/conflict with the above? -- Troy --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fwd: Filesets referencing filesets ?
Hi Martin, Martin Aliger wrote: Thanks, here is patch again, this time it is agains 0.85 RC3. I'd really love to see this incorporated in core. There are some implementation problems which we already discussed, though: - what should happen, if referenced fileset have another basedir ? - what should happen, if exclude/include of 2 filesets conflicts ? - is every possible combination of those covered in test cases? For mine use, I dont combine basedirs and dont use excludes at all, but those problems should be solved. I feel, this is main problem why this extension wasnt incorporated yet. Maybe we could discuss it now... I'm tempted to include it and let people have a play with it and then refine it as necessary rather than holding out until its perfect. What do people think ? Ian Martin Aliger -Original Message- From: Rory Becker [mailto:[EMAIL PROTECTED] Sent: Friday, August 26, 2005 10:50 AM To: Martin Aliger Subject: Re: [nant-dev] Fwd: Filesets referencing filesets ? Assuming that your syntax has not varied too greatly from the version I saw in the newsgroup, I agree entirely that this is the right way to go. No task supports more that one fileset but allowing a fileset to contain or be created based on other filesets allows for many combinations I assume that this allows the derivative fileset types like zipfileset to inherit a similar behaviour I believe that this would make a great enhancement to the core nant system. How would we proceed from here Can I get a copy of this patch? How would I use it? Should I wait for the community to approve the patch?(really don't want to do this) Ideas? Suggestions ? Rory BTW Well done martin for this Idea / Implementation. Very simple and very powerful. :) On 8/26/05, Martin Aliger [EMAIL PROTECTED] wrote: Hello Rory, Currently, I fear, there is no such feature in NAnt. Some tasks allow to specify multiple filesets, but only some... That syntax you stole from another post was mine proposal to extend current fileset task. I have it locally and it works for me. I use it in production, in fact. I already sent patch for this and could send more current one, if community have interest for it. I'd like to see that incorporated in NAnt's core. btw: it also allow adding to existing fileset - and its what I need in production. Martin Aliger -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Rory Becker Sent: Thursday, August 25, 2005 1:59 PM To: nant-developers@lists.sourceforge.net Subject: [nant-dev] Fwd: Filesets referencing filesets ? This was posted to the users group originally sorry :) Rory -- Forwarded message -- From: Rory Becker [EMAIL PROTECTED] Date: Aug 25, 2005 12:48 PM Subject: Filesets referencing filesets ? To: nantList nant-users@lists.sourceforge.net I would like to alter fileset so that it could reference multiple other filesets but I am not sure where to start. The syntax has been stolen from a post I read http://www.mail-archive.com/[EMAIL PROTECTED] net/msg03232.html and is as follows fileset id=Group1 include name=File1.dll / include name=File2.dll / /fileset fileset id=Group2 include name=File3.dll / include name=File4.dll / /fileset fileset includeFileset refid=Group1 / includeFileset refid=Group2 / /fileset I have found the fileset Class in Nant.Core and I figured I needed to determine how to use the refid syntax. So I looked for another class that already does this. The CopyTask seems to provide this but I cannot find anything in the source to indicate how this is handled. Can anyone help? Thanks Rory --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Fwd: Filesets referencing filesets ?
Hello Rory, Currently, I fear, there is no such feature in NAnt. Some tasks allow to specify multiple filesets, but only some... That syntax you stole from another post was mine proposal to extend current fileset task. I have it locally and it works for me. I use it in production, in fact. I already sent patch for this and could send more current one, if community have interest for it. I'd like to see that incorporated in NAnt's core. btw: it also allow adding to existing fileset - and its what I need in production. Martin Aliger -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Rory Becker Sent: Thursday, August 25, 2005 1:59 PM To: nant-developers@lists.sourceforge.net Subject: [nant-dev] Fwd: Filesets referencing filesets ? This was posted to the users group originally sorry :) Rory -- Forwarded message -- From: Rory Becker [EMAIL PROTECTED] Date: Aug 25, 2005 12:48 PM Subject: Filesets referencing filesets ? To: nantList nant-users@lists.sourceforge.net I would like to alter fileset so that it could reference multiple other filesets but I am not sure where to start. The syntax has been stolen from a post I read http://www.mail-archive.com/[EMAIL PROTECTED] net/msg03232.html and is as follows fileset id=Group1 include name=File1.dll / include name=File2.dll / /fileset fileset id=Group2 include name=File3.dll / include name=File4.dll / /fileset fileset includeFileset refid=Group1 / includeFileset refid=Group2 / /fileset I have found the fileset Class in Nant.Core and I figured I needed to determine how to use the refid syntax. So I looked for another class that already does this. The CopyTask seems to provide this but I cannot find anything in the source to indicate how this is handled. Can anyone help? Thanks Rory --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Fwd: Filesets referencing filesets ?
Thanks, here is patch again, this time it is agains 0.85 RC3. I'd really love to see this incorporated in core. There are some implementation problems which we already discussed, though: - what should happen, if referenced fileset have another basedir ? - what should happen, if exclude/include of 2 filesets conflicts ? - is every possible combination of those covered in test cases? For mine use, I dont combine basedirs and dont use excludes at all, but those problems should be solved. I feel, this is main problem why this extension wasnt incorporated yet. Maybe we could discuss it now... Martin Aliger -Original Message- From: Rory Becker [mailto:[EMAIL PROTECTED] Sent: Friday, August 26, 2005 10:50 AM To: Martin Aliger Subject: Re: [nant-dev] Fwd: Filesets referencing filesets ? Assuming that your syntax has not varied too greatly from the version I saw in the newsgroup, I agree entirely that this is the right way to go. No task supports more that one fileset but allowing a fileset to contain or be created based on other filesets allows for many combinations I assume that this allows the derivative fileset types like zipfileset to inherit a similar behaviour I believe that this would make a great enhancement to the core nant system. How would we proceed from here Can I get a copy of this patch? How would I use it? Should I wait for the community to approve the patch?(really don't want to do this) Ideas? Suggestions ? Rory BTW Well done martin for this Idea / Implementation. Very simple and very powerful. :) On 8/26/05, Martin Aliger [EMAIL PROTECTED] wrote: Hello Rory, Currently, I fear, there is no such feature in NAnt. Some tasks allow to specify multiple filesets, but only some... That syntax you stole from another post was mine proposal to extend current fileset task. I have it locally and it works for me. I use it in production, in fact. I already sent patch for this and could send more current one, if community have interest for it. I'd like to see that incorporated in NAnt's core. btw: it also allow adding to existing fileset - and its what I need in production. Martin Aliger -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Rory Becker Sent: Thursday, August 25, 2005 1:59 PM To: nant-developers@lists.sourceforge.net Subject: [nant-dev] Fwd: Filesets referencing filesets ? This was posted to the users group originally sorry :) Rory -- Forwarded message -- From: Rory Becker [EMAIL PROTECTED] Date: Aug 25, 2005 12:48 PM Subject: Filesets referencing filesets ? To: nantList nant-users@lists.sourceforge.net I would like to alter fileset so that it could reference multiple other filesets but I am not sure where to start. The syntax has been stolen from a post I read http://www.mail-archive.com/[EMAIL PROTECTED] net/msg03232.html and is as follows fileset id=Group1 include name=File1.dll / include name=File2.dll / /fileset fileset id=Group2 include name=File3.dll / include name=File4.dll / /fileset fileset includeFileset refid=Group1 / includeFileset refid=Group2 / /fileset I have found the fileset Class in Nant.Core and I figured I needed to determine how to use the refid syntax. So I looked for another class that already does this. The CopyTask seems to provide this but I cannot find anything in the source to indicate how this is handled. Can anyone help? Thanks Rory --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers FileSet.cs.patch Description: Binary data
