Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Mourad,

On 16 May 2017 at 08:51, Mourad Boufarguine
 wrote:
> Builds and osgviewer runs fine with VS 2015 Win64.

Thanks for the testing.

> I got these debug output to the console :
>
> _forceVertexArrayObject = 0
> _forceVertexBufferObject = 0
> _forceVertexArrayObject = 0
> _forceVertexBufferObject = 0
> _forceVertexArrayObject = 0
> _forceVertexBufferObject = 0
> ViewerBase::configureAffinity() numProcessors=8
>   databasePagers = 1

I'm happy for these to stay for this dev release.  These values can be
useful when testing the new VertexArrayObject and Affinity that are
are in 3.5.6.  These will likely be changed to INFO for the next dev
release, and certainly won't be part of the final stable release.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Mourad Boufarguine]

Hi Robert,

Builds and osgviewer runs fine with VS 2015 Win64.
I got these debug output to the console :

_forceVertexArrayObject = 0
_forceVertexBufferObject = 0
_forceVertexArrayObject = 0
_forceVertexBufferObject = 0
_forceVertexArrayObject = 0
_forceVertexBufferObject = 0
ViewerBase::configureAffinity() numProcessors=8
  databasePagers = 1

Cheers,
Mourad

On Mon, May 15, 2017 at 3:56 PM, Robert Osfield 
wrote:

> Hi Mourad,
>
> On 15 May 2017 at 14:52, Mourad Boufarguine
>  wrote:
> > You're right we need both :
> >
> > COLLADA_BOOST_BUILDNAME : to follow boost naming convention with 3 digits
> > for MSVC toolset version
> > COLLADA_BUILDNAME : to follow collada naming convention with 1/2 digits
> for
> > MSVC toolset version
>
> I've been thinking along the same lines, I've refactored the
> FindCOLLADA.cmake to use a combination of your and Toroben's versions,
> the changes are :
>
>
> diff --git a/CMakeModules/FindCOLLADA.cmake b/CMakeModules/FindCOLLADA.
> cmake
> index f086069..5fb2cec 100644
> --- a/CMakeModules/FindCOLLADA.cmake
> +++ b/CMakeModules/FindCOLLADA.cmake
> @@ -23,37 +23,38 @@ ELSE ()
>  ENDIF()
>
>
> -
> -
> -
>  IF(APPLE)
>  SET(COLLADA_BUILDNAME "mac")
> -SET(COLLADA_BOOST_BUILDNAME "mac")
> +  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
>  ELSEIF(MINGW)
>  SET(COLLADA_BUILDNAME "mingw")
> -SET(COLLADA_BOOST_BUILDNAME "mingw")
> -ELSEIF(MSVC14)
> +  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
> +ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
>  SET(COLLADA_BUILDNAME "vc14")
> -string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> -ELSEIF(MSVC12)
> +SET(COLLADA_BOOST_BUILDNAME "vc140")
> +ELSEIF(MSVC_VERSION EQUAL 1800)
>  SET(COLLADA_BUILDNAME "vc12")
> -string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> -ELSEIF(MSVC11)
> +SET(COLLADA_BOOST_BUILDNAME "vc120")
> +ELSEIF(MSVC_VERSION EQUAL 1700)
>  SET(COLLADA_BUILDNAME "vc11")
> -string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> -ELSEIF(MSVC10)
> +SET(COLLADA_BOOST_BUILDNAME "vc110")
> +ELSEIF(MSVC_VERSION EQUAL 1600)
>  SET(COLLADA_BUILDNAME "vc10")
> -string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> -ELSEIF(MSVC90)
> +SET(COLLADA_BOOST_BUILDNAME "vc100")
> +ELSEIF(MSVC_VERSION EQUAL 1500)
>  SET(COLLADA_BUILDNAME "vc9")
> -string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> -ELSEIF(MSVC80)
> +SET(COLLADA_BOOST_BUILDNAME "vc90")
> +ELSEIF(MSVC_VERSION EQUAL 1400)
>  SET(COLLADA_BUILDNAME "vc8")
> -string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> -ELSE(APPLE)
> +SET(COLLADA_BOOST_BUILDNAME "vc80")
> +ELSE()
>SET(COLLADA_BUILDNAME "linux")
> -  SET(COLLADA_BOOST_BUILDNAME "linux")
> -ENDIF(APPLE)
> +  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
> +ENDIF()
> +
> +IF(${CMAKE_VS_PLATFORM_TOOLSET})
> +string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> +ENDIF()
>
>
> I have now checked this into git master, I'd appreciate testing out
> under Windows, fingers crossed we are getting a bit closer.
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Mourad,

On 15 May 2017 at 14:52, Mourad Boufarguine
 wrote:
> You're right we need both :
>
> COLLADA_BOOST_BUILDNAME : to follow boost naming convention with 3 digits
> for MSVC toolset version
> COLLADA_BUILDNAME : to follow collada naming convention with 1/2 digits for
> MSVC toolset version

I've been thinking along the same lines, I've refactored the
FindCOLLADA.cmake to use a combination of your and Toroben's versions,
the changes are :


diff --git a/CMakeModules/FindCOLLADA.cmake b/CMakeModules/FindCOLLADA.cmake
index f086069..5fb2cec 100644
--- a/CMakeModules/FindCOLLADA.cmake
+++ b/CMakeModules/FindCOLLADA.cmake
@@ -23,37 +23,38 @@ ELSE ()
 ENDIF()


-
-
-
 IF(APPLE)
 SET(COLLADA_BUILDNAME "mac")
-SET(COLLADA_BOOST_BUILDNAME "mac")
+  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
 ELSEIF(MINGW)
 SET(COLLADA_BUILDNAME "mingw")
-SET(COLLADA_BOOST_BUILDNAME "mingw")
-ELSEIF(MSVC14)
+  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
+ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
 SET(COLLADA_BUILDNAME "vc14")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC12)
+SET(COLLADA_BOOST_BUILDNAME "vc140")
+ELSEIF(MSVC_VERSION EQUAL 1800)
 SET(COLLADA_BUILDNAME "vc12")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC11)
+SET(COLLADA_BOOST_BUILDNAME "vc120")
+ELSEIF(MSVC_VERSION EQUAL 1700)
 SET(COLLADA_BUILDNAME "vc11")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC10)
+SET(COLLADA_BOOST_BUILDNAME "vc110")
+ELSEIF(MSVC_VERSION EQUAL 1600)
 SET(COLLADA_BUILDNAME "vc10")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC90)
+SET(COLLADA_BOOST_BUILDNAME "vc100")
+ELSEIF(MSVC_VERSION EQUAL 1500)
 SET(COLLADA_BUILDNAME "vc9")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC80)
+SET(COLLADA_BOOST_BUILDNAME "vc90")
+ELSEIF(MSVC_VERSION EQUAL 1400)
 SET(COLLADA_BUILDNAME "vc8")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSE(APPLE)
+SET(COLLADA_BOOST_BUILDNAME "vc80")
+ELSE()
   SET(COLLADA_BUILDNAME "linux")
-  SET(COLLADA_BOOST_BUILDNAME "linux")
-ENDIF(APPLE)
+  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
+ENDIF()
+
+IF(${CMAKE_VS_PLATFORM_TOOLSET})
+string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
+ENDIF()


I have now checked this into git master, I'd appreciate testing out
under Windows, fingers crossed we are getting a bit closer.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Mourad Boufarguine]

You're right we need both :

COLLADA_BOOST_BUILDNAME : to follow boost naming convention with 3 digits
for MSVC toolset version
COLLADA_BUILDNAME : to follow collada naming convention with 1/2 digits for
MSVC toolset version

On Mon, May 15, 2017 at 3:32 PM, Robert Osfield 
wrote:

> Hi Mourad,
>
> On 15 May 2017 at 14:16, Mourad Boufarguine
>  wrote:
> > You are missing the ending 0s.
>
> I was just following Torben's usage, if we add back the 0's then the
> search names would change.  I presume this is why Torben introduced
> using two variables COLLADA_BUILDNAME & COLLADA_BOOST_BUILDNAME.
>
> > By the way the MSVCXX vars are discouraged (there is no var defined
> starting
> > from Visual 2017), MSVC_VERSION is the recommended way now :
> > https://cmake.org/cmake/help/v3.8/variable/MSVC14.html?highlight=msvc14
> >
> > IF(APPLE)
> > SET(COLLADA_BUILDNAME "mac")
> > ELSEIF(MINGW)
> > SET(COLLADA_BUILDNAME "mingw")
> > ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
> > SET(COLLADA_BUILDNAME "vc140")
> > ELSEIF(MSVC_VERSION EQUAL 1800)
> > SET(COLLADA_BUILDNAME "vc120")
> > ELSEIF(MSVC_VERSION EQUAL 1700)
> > SET(COLLADA_BUILDNAME "vc110")
> > ELSEIF(MSVC_VERSION EQUAL 1600)
> > SET(COLLADA_BUILDNAME "vc100")
> > ELSEIF(MSVC_VERSION EQUAL 1500)
> > SET(COLLADA_BUILDNAME "vc90")
> > ELSEIF(MSVC_VERSION EQUAL 1400)
> > SET(COLLADA_BUILDNAME "vc80")
> > ELSE()
> >   SET(COLLADA_BUILDNAME "linux")
> > ENDIF()
>
> Have you tested the above suggestion on your system?  I'm curious how
> things are working w.r.t Windows with COLLADA being installed.
>
> Hopefully Torben will join this thread as it's his changes that were
> meant to resolve building under Windows.
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Mourad,

On 15 May 2017 at 14:16, Mourad Boufarguine
 wrote:
> You are missing the ending 0s.

I was just following Torben's usage, if we add back the 0's then the
search names would change.  I presume this is why Torben introduced
using two variables COLLADA_BUILDNAME & COLLADA_BOOST_BUILDNAME.

> By the way the MSVCXX vars are discouraged (there is no var defined starting
> from Visual 2017), MSVC_VERSION is the recommended way now :
> https://cmake.org/cmake/help/v3.8/variable/MSVC14.html?highlight=msvc14
>
> IF(APPLE)
> SET(COLLADA_BUILDNAME "mac")
> ELSEIF(MINGW)
> SET(COLLADA_BUILDNAME "mingw")
> ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
> SET(COLLADA_BUILDNAME "vc140")
> ELSEIF(MSVC_VERSION EQUAL 1800)
> SET(COLLADA_BUILDNAME "vc120")
> ELSEIF(MSVC_VERSION EQUAL 1700)
> SET(COLLADA_BUILDNAME "vc110")
> ELSEIF(MSVC_VERSION EQUAL 1600)
> SET(COLLADA_BUILDNAME "vc100")
> ELSEIF(MSVC_VERSION EQUAL 1500)
> SET(COLLADA_BUILDNAME "vc90")
> ELSEIF(MSVC_VERSION EQUAL 1400)
> SET(COLLADA_BUILDNAME "vc80")
> ELSE()
>   SET(COLLADA_BUILDNAME "linux")
> ENDIF()

Have you tested the above suggestion on your system?  I'm curious how
things are working w.r.t Windows with COLLADA being installed.

Hopefully Torben will join this thread as it's his changes that were
meant to resolve building under Windows.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Mourad Boufarguine]

You are missing the ending 0s.
By the way the MSVCXX vars are discouraged (there is no var defined
starting from Visual 2017), MSVC_VERSION is the recommended way now :
https://cmake.org/cmake/help/v3.8/variable/MSVC14.html?highlight=msvc14

IF(APPLE)
SET(COLLADA_BUILDNAME "mac")
ELSEIF(MINGW)
SET(COLLADA_BUILDNAME "mingw")
ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
SET(COLLADA_BUILDNAME "vc140")
ELSEIF(MSVC_VERSION EQUAL 1800)
SET(COLLADA_BUILDNAME "vc120")
ELSEIF(MSVC_VERSION EQUAL 1700)
SET(COLLADA_BUILDNAME "vc110")
ELSEIF(MSVC_VERSION EQUAL 1600)
SET(COLLADA_BUILDNAME "vc100")
ELSEIF(MSVC_VERSION EQUAL 1500)
SET(COLLADA_BUILDNAME "vc90")
ELSEIF(MSVC_VERSION EQUAL 1400)
SET(COLLADA_BUILDNAME "vc80")
ELSE()
  SET(COLLADA_BUILDNAME "linux")
ENDIF()

On Mon, May 15, 2017 at 2:50 PM, Robert Osfield 
wrote:

> On 15 May 2017 at 13:08, Robert Osfield  wrote:
> > Looks like we'll need to rewrite this problem block for the case when
> > CMAKE_VS_PLATFORM_TOOLSET is not set.
> >
> > Don't yet know what this might be though...
>
> Would the following approach work better?
>
> -- Modified CMakeModues/FindCOLLADA.camke script :
>
> IF(APPLE)
> SET(COLLADA_BUILDNAME "mac")
> ELSEIF(MINGW)
> SET(COLLADA_BUILDNAME "mingw")
> ELSEIF(MSVC14)
> SET(COLLADA_BUILDNAME "vc14")
> ELSEIF(MSVC12)
> SET(COLLADA_BUILDNAME "vc12")
> ELSEIF(MSVC11)
> SET(COLLADA_BUILDNAME "vc11")
> ELSEIF(MSVC10)
> SET(COLLADA_BUILDNAME "vc10")
> ELSEIF(MSVC90)
> SET(COLLADA_BUILDNAME "vc9")
> ELSEIF(MSVC80)
> SET(COLLADA_BUILDNAME "vc8")
> ELSE()
>   SET(COLLADA_BUILDNAME "linux")
> ENDIF()
>
> SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BOOST_BUILDNAME})
>
> IF(${CMAKE_VS_PLATFORM_TOOLSET})
> string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> ENDIF()
>
> --
>
> I've moved the string(REPLACE...) lines into a single block wrapped in a
> check.
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

On 15 May 2017 at 13:08, Robert Osfield  wrote:
> Looks like we'll need to rewrite this problem block for the case when
> CMAKE_VS_PLATFORM_TOOLSET is not set.
>
> Don't yet know what this might be though...

Would the following approach work better?

-- Modified CMakeModues/FindCOLLADA.camke script :

IF(APPLE)
SET(COLLADA_BUILDNAME "mac")
ELSEIF(MINGW)
SET(COLLADA_BUILDNAME "mingw")
ELSEIF(MSVC14)
SET(COLLADA_BUILDNAME "vc14")
ELSEIF(MSVC12)
SET(COLLADA_BUILDNAME "vc12")
ELSEIF(MSVC11)
SET(COLLADA_BUILDNAME "vc11")
ELSEIF(MSVC10)
SET(COLLADA_BUILDNAME "vc10")
ELSEIF(MSVC90)
SET(COLLADA_BUILDNAME "vc9")
ELSEIF(MSVC80)
SET(COLLADA_BUILDNAME "vc8")
ELSE()
  SET(COLLADA_BUILDNAME "linux")
ENDIF()

SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BOOST_BUILDNAME})

IF(${CMAKE_VS_PLATFORM_TOOLSET})
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ENDIF()

--

I've moved the string(REPLACE...) lines into a single block wrapped in a check.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Mourad Boufarguine]

Hi Robert,

I think it is more correct to use the same logic (testing against the
compiler version CMAKE_CXX_COMPILER_VERSION  ) as in the mainstream
FindBoost.cmake :
https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L432-L453


Cheers,
Mourad

On Mon, May 15, 2017 at 2:08 PM, Robert Osfield 
wrote:

> Hi Mourad,
>
> On 15 May 2017 at 12:58, Mourad Boufarguine
>  wrote:
> > CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely
> specifies a
> > toolset when invoking cmake :
> >
> > cmake -G "Visual Studio XX" -T v1YY srcDir
> >
> > If the user does not specify a toolset, the default toolset of the chosen
> > Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET
> > variable will not be set, and this is what is causing the problem here.
>
> Thanks for the clarification.
>
> Looks like we'll need to rewrite this problem block for the case when
> CMAKE_VS_PLATFORM_TOOLSET is not set.
>
> Don't yet know what this might be though...
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Mourad,

On 15 May 2017 at 12:58, Mourad Boufarguine
 wrote:
> CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely specifies a
> toolset when invoking cmake :
>
> cmake -G "Visual Studio XX" -T v1YY srcDir
>
> If the user does not specify a toolset, the default toolset of the chosen
> Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET
> variable will not be set, and this is what is causing the problem here.

Thanks for the clarification.

Looks like we'll need to rewrite this problem block for the case when
CMAKE_VS_PLATFORM_TOOLSET is not set.

Don't yet know what this might be though...

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

Hi Robert (and Mourad),

I tried -T v140 but I still didn't seem to get that variable set, with or 
without the -G option. And note that I use MinGW makefiles even when building 
with MSVC so deducing partially from -G won't work right in that case anyway.

From this page 
(https://cmake.org/cmake/help/latest/variable/CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION.html)
 it looks like Windows 10 may do things a little differently (I'm on Win10).

I guess the discussion from 
http://forum.openscenegraph.org/viewtopic.php?t=16592 may not be fully resolved 
yet.

Cheers,
Stuart
--
Stuart Mentzer
Objexx Engineering
/Office/  +1 781 455 1150 x11
/Mobile/ +1 781 708 3872

On 5/15/2017 7:58 AM, Mourad Boufarguine wrote:

Hi Robert,

CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely specifies a 
toolset when invoking cmake :

cmake -G "Visual Studio XX" -T v1YY srcDir

If the user does not specify a toolset, the default toolset of the chosen 
Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET variable 
will not be set, and this is what is causing the problem here.

Cheers,
Mourad



On Mon, May 15, 2017 at 1:23 PM, Robert Osfield > wrote:

Hi Stuart,

On 15 May 2017 at 12:07, Stuart Mentzer > wrote:
> https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html 

>
> Which mentons that it's set for VC10 and above. Torben uses the
> CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
> happen here.
>
> What VC number is reported on your system?
>
> Visual C++ 2015 corresponds to MSVC14.

Looking at the CMake docs it would seem CMAKE_VS_PLATFORM_TOOLSET
should be defined, but given your error it would seem on your system
it's not.

Could you check whether CMAKE_VS_PLATFORM_TOOLSET is defined and what
it's value is?


> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 
but
> the prev version builds OK]
>
> Is this a build error in curl, or the OSG plugin building against curl
> 7.54.0?
>
> It is in the curl build itself. Here is the bug report I filed:
> https://github.com/curl/curl/issues/1482 


OK, this isn't an OSG issue then so I can safely leave this to someone
else to resolve:-)

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org 

http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org 





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Mourad Boufarguine]

Hi Robert,

CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely specifies
a toolset when invoking cmake :

cmake -G "Visual Studio XX" -T v1YY srcDir

If the user does not specify a toolset, the default toolset of the chosen
Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET
variable will not be set, and this is what is causing the problem here.

Cheers,
Mourad



On Mon, May 15, 2017 at 1:23 PM, Robert Osfield 
wrote:

> Hi Stuart,
>
> On 15 May 2017 at 12:07, Stuart Mentzer  wrote:
> > https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_
> PLATFORM_TOOLSET.html
> >
> > Which mentons that it's set for VC10 and above.  Torben uses the
> > CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
> > happen here.
> >
> > What VC number is reported on your system?
> >
> > Visual C++ 2015 corresponds to MSVC14.
>
> Looking at the CMake docs it would seem CMAKE_VS_PLATFORM_TOOLSET
> should be defined, but given your error it would seem on your system
> it's not.
>
> Could you check whether CMAKE_VS_PLATFORM_TOOLSET is defined and what
> it's value is?
>
>
> > [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015
> but
> > the prev version builds OK]
> >
> > Is this a build error in curl, or the OSG plugin building against curl
> > 7.54.0?
> >
> > It is in the curl build itself. Here is the bug report I filed:
> > https://github.com/curl/curl/issues/1482
>
> OK, this isn't an OSG issue then so I can safely leave this to someone
> else to resolve:-)
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Stuart,

On 15 May 2017 at 12:07, Stuart Mentzer  wrote:
> https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html
>
> Which mentons that it's set for VC10 and above.  Torben uses the
> CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
> happen here.
>
> What VC number is reported on your system?
>
> Visual C++ 2015 corresponds to MSVC14.

Looking at the CMake docs it would seem CMAKE_VS_PLATFORM_TOOLSET
should be defined, but given your error it would seem on your system
it's not.

Could you check whether CMAKE_VS_PLATFORM_TOOLSET is defined and what
it's value is?


> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
> the prev version builds OK]
>
> Is this a build error in curl, or the OSG plugin building against curl
> 7.54.0?
>
> It is in the curl build itself. Here is the bug report I filed:
> https://github.com/curl/curl/issues/1482

OK, this isn't an OSG issue then so I can safely leave this to someone
else to resolve:-)

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

Hi Robert,

On 5/15/2017 5:13 AM, Robert Osfield wrote:

Hi Stuart,

On 12 May 2017 at 14:32, Stuart Mentzer  wrote:

I always build from scratch in an empty build directory.

Thanks for the clarification.


Adding " around the 3rd and 4th args in the REPLACE lines did indeed
eliminate the error. Torben should check that this is still OK when the
Collada plugin is in use.

I'm currently looking at the changes and the error report, trying to
make sense of what is the root of the issue and how to resolve it.
Unfortunately I haven't heard from Torben yet so don't yet know what
his thoughts are.  Form what I understand Torben introduced the
COLLADA_BOOST_BUILDNAME to cope with variations under Windows related
to the platform tools set, hence the introduction of the
CMAKE_VS_PLATFORM_TOOLSET in the lines like:


ELSEIF(MSVC14)
 SET(COLLADA_BUILDNAME "vc14")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC12)
 SET(COLLADA_BUILDNAME "vc12")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC11)
 SET(COLLADA_BUILDNAME "vc11")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC10)
 SET(COLLADA_BUILDNAME "vc10")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC90)
 SET(COLLADA_BUILDNAME "vc9")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC80)
 SET(COLLADA_BUILDNAME "vc8")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSE(APPLE)

CMaker docs for the CMAKE_VS_PLATFORM_TOOLSET} are:

 https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html

Which mentons that it's set for VC10 and above.  Torben uses the
CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
happen here.

What VC number is reported on your system?

Visual C++ 2015 corresponds to MSVC14.

[Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
the prev version builds OK]

Is this a build error in curl, or the OSG plugin building against curl 7.54.0?

It is in the curl build itself. Here is the bug report I filed: 
https://github.com/curl/curl/issues/1482

Thanks,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Cheers,
Stuart
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Stuart,

On 12 May 2017 at 14:32, Stuart Mentzer  wrote:
> I always build from scratch in an empty build directory.

Thanks for the clarification.

> Adding " around the 3rd and 4th args in the REPLACE lines did indeed
> eliminate the error. Torben should check that this is still OK when the
> Collada plugin is in use.

I'm currently looking at the changes and the error report, trying to
make sense of what is the root of the issue and how to resolve it.
Unfortunately I haven't heard from Torben yet so don't yet know what
his thoughts are.  Form what I understand Torben introduced the
COLLADA_BOOST_BUILDNAME to cope with variations under Windows related
to the platform tools set, hence the introduction of the
CMAKE_VS_PLATFORM_TOOLSET in the lines like:


ELSEIF(MSVC14)
SET(COLLADA_BUILDNAME "vc14")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC12)
SET(COLLADA_BUILDNAME "vc12")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC11)
SET(COLLADA_BUILDNAME "vc11")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC10)
SET(COLLADA_BUILDNAME "vc10")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC90)
SET(COLLADA_BUILDNAME "vc9")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC80)
SET(COLLADA_BUILDNAME "vc8")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSE(APPLE)

CMaker docs for the CMAKE_VS_PLATFORM_TOOLSET} are:

https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html

Which mentons that it's set for VC10 and above.  Torben uses the
CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
happen here.

What VC number is reported on your system?

> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
> the prev version builds OK]

Is this a build error in curl, or the OSG plugin building against curl 7.54.0?

Thanks,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[jamie robertson]

Hi Robert,

A very minor one, but I've noticed that in 
osg::Text::computePositionsImplementation(), any bounding box margins set are 
never taken into account when calculating the position of the text, as the 
positions are calculated from the bounding box before the margins are applied.


Code:
void Text::computePositionsImplementation()
{
TextBase::computePositionsImplementation();

computeBackdropPositions();
computeBackdropBoundingBox();
computeBoundingBoxMargin();
}



For example if you set the text alignment to LEFT_BOTTOM and set a bounding box 
margin, the margin is not taken into account when calculating the position. 

Possibly it should be something like:


Code:
void Text::computePositionsImplementation()
void Text::computePositionsImplementation()
{
TextBase::computePositionsImplementation();

computeBackdropPositions();
computeBackdropBoundingBox();
computeBoundingBoxMargin();

// Compute position again to include bounding box margins for non 
base-line text alignments
if (_alignment < LEFT_BASE_LINE) 
TextBase::computePositionsImplementation();
}



Cheers,

Jamie

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=70920#70920





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

I always build from scratch in an empty build directory.

What platform and build tools are you using?

The use of REPLACE was introduced in a submission from Torben related
to VS2017 binary support:

 
https://github.com/openscenegraph/OpenSceneGraph/commit/67ef816da00441121f7b2cb606ee19bbb1f15e80

We could revert this but it'd break support for VS2017 binaries...  I
don't have any suggestions yet on what an appropriate fix might be.
I'm not a Windows dev so will need to defer resolution to those with
WIndows expertise.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Hi Robert,

Adding " around the 3rd and 4th args in the REPLACE lines did indeed eliminate 
the error. Torben should check that this is still OK when the Collada plugin is in 
use.

[Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but the 
prev version builds OK]

Cheers,
Stuart
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

I always build from scratch in an empty build directory.

What platform and build tools are you using?

The use of REPLACE was introduced in a submission from Torben related
to VS2017 binary support:

 
https://github.com/openscenegraph/OpenSceneGraph/commit/67ef816da00441121f7b2cb606ee19bbb1f15e80

We could revert this but it'd break support for VS2017 binaries...  I
don't have any suggestions yet on what an appropriate fix might be.
I'm not a Windows dev so will need to defer resolution to those with
WIndows expertise.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Windows 10 (64-bit), CMake 3.8.1, Visual C++ 2015.

My guess is that it just needs a fixup to deal with the case of NOT building 
the Collada plugin, when those strings are probably empty. I'll kick off a 
build with the quote-wrapping fix and let you know later but it is probably 
best to ask Torben to take a look.

Cheers,
Stuart
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

> I always build from scratch in an empty build directory.

What platform and build tools are you using?

The use of REPLACE was introduced in a submission from Torben related
to VS2017 binary support:


https://github.com/openscenegraph/OpenSceneGraph/commit/67ef816da00441121f7b2cb606ee19bbb1f15e80

We could revert this but it'd break support for VS2017 binaries...  I
don't have any suggestions yet on what an appropriate fix might be.
I'm not a Windows dev so will need to defer resolution to those with
WIndows expertise.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

On 5/12/2017 4:50 AM, Robert Osfield wrote:

Hi Stuart,

On 12 May 2017 at 09:18, Stuart Mentzer  wrote:

I don't think it is a change in CMake: it looks like REPLACE has had the
same syntax since at least 3.0:

string(REPLACE 
 
 [...])

The version of FindCOLLADA.cmake in 3.4.0 didn't have the REPLACE lines, so
I guess that is where the problem lies. The (first) offending line is:
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
Since I am not building with the Collada plugin I assume one or both of the
last 2 arguments are blank, thus too few args. Probably wrapping them in "
would fix it but I haven't had a chance to try that yet. Maybe best to kick
this to the contributor of the revised FindCOLLADA.cmake.


Do you clean your CMakeCache.txt and run CMake from scratch when you
did your testing?  I am wondering if an new CMake variable is intended
to be set elsewhere in the OSG that isn't being set it your case.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Hi Robert,

I always build from scratch in an empty build directory.

Cheers,
Stuart

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi Stuart,

On 12 May 2017 at 09:18, Stuart Mentzer  wrote:
> I don't think it is a change in CMake: it looks like REPLACE has had the
> same syntax since at least 3.0:
>
> string(REPLACE 
> 
> [...])
>
> The version of FindCOLLADA.cmake in 3.4.0 didn't have the REPLACE lines, so
> I guess that is where the problem lies. The (first) offending line is:
> string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> Since I am not building with the Collada plugin I assume one or both of the
> last 2 arguments are blank, thus too few args. Probably wrapping them in "
> would fix it but I haven't had a chance to try that yet. Maybe best to kick
> this to the contributor of the revised FindCOLLADA.cmake.


Do you clean your CMakeCache.txt and run CMake from scratch when you
did your testing?  I am wondering if an new CMake variable is intended
to be set elsewhere in the OSG that isn't being set it your case.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

I don't think it is a change in CMake: it looks like REPLACE has had the same 
syntax since at least 3.0:

string(REPLACE  
 
 [...])

The version of FindCOLLADA.cmake in 3.4.0 didn't have the REPLACE lines, so I 
guess that is where the problem lies. The (first) offending line is:
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME ${CMAKE_VS_PLATFORM_TOOLSET})
Since I am not building with the Collada plugin I assume one or both of the last 2 
arguments are blank, thus too few args. Probably wrapping them in " would fix 
it but I haven't had a chance to try that yet. Maybe best to kick this to the 
contributor of the revised FindCOLLADA.cmake.

Cheers,
Stuart

On 5/12/2017 3:56 AM, Robert Osfield wrote:

HI Stuart,

On 12 May 2017 at 02:04, Stuart Mentzer  wrote:

Current master build fails on Windows with:
CMake Error at CMakeModules/FindCOLLADA.cmake:37 (string):
   string sub-command REPLACE requires at least four arguments.
Call Stack (most recent call first):
   CMakeLists.txt:743 (FIND_PACKAGE)

Details: Windows 10, CMake 3.8.1, Visual C++ 2015

Is this error due to recent changes in the OSG or an issue introduced
by CMake 3.8.1?

Cheers,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

HI Stuart,

On 12 May 2017 at 02:04, Stuart Mentzer  wrote:
> Current master build fails on Windows with:
> CMake Error at CMakeModules/FindCOLLADA.cmake:37 (string):
>   string sub-command REPLACE requires at least four arguments.
> Call Stack (most recent call first):
>   CMakeLists.txt:743 (FIND_PACKAGE)
>
> Details: Windows 10, CMake 3.8.1, Visual C++ 2015

Is this error due to recent changes in the OSG or an issue introduced
by CMake 3.8.1?

Cheers,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Stuart Mentzer]

Hi Robert,

Current master build fails on Windows with:
CMake Error at CMakeModules/FindCOLLADA.cmake:37 (string):
  string sub-command REPLACE requires at least four arguments.
Call Stack (most recent call first):
  CMakeLists.txt:743 (FIND_PACKAGE)

Details: Windows 10, CMake 3.8.1, Visual C++ 2015

Cheers,
Stuart

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=70901#70901





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

[osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

[Robert Osfield]

Hi All,

Today I merged two branches into master that contain some significant
changes to KdTree, LineSegment and PolytopIntersector and
AutoTransform respectively.  I would like testing of these as well all
the rest of the changes from the community that I've merged this week.
If things look stable then I'll tag 3.5.6 developer release.

On the KdTree/Intersector front I've refactor KdTree to support point,
line and quad primitives in addition to original triangles that is
supported.  The LineSegmentIntersector c;ass has been updated use the
new KdTree API and unifies it's intersection code which will make it
easier to maintain going forward.  The PolytopeIntersector adds
support for using KdTree's to accelerate intersection testing so you
can now get KdTree accelerated intersections for point clouds and line
models.

The AutoTransform class has been re-factored so that it now computes
transforms on the fly within the cull traversal, this change enables
support for use in applications that use multiple Views and share the
same subgraphs that contain AutoTransform.  For most users you won't
need to make any changes, it'll just work as before, only now it'll
properly work in when you use multiple views.  If you application is
hardwired to the internal data structures in AutoTransform you may
need to refactor the code as some of the internal structures no longer
exist.

Thanks in advance for testing,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org