Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

On 4/20/2011 10:41 AM, Chris 'Xenon' Hanson wrote:

   I'll preface this by saying, don't request improvements unless you're 
willing to chip in
to get them done, or help someone else get them done. ;)


Assuming I'll be the one committing the changes to the 2.8 branch... I'd like to 
see the submission process be identical to that of the submission process on 
main trunk. For example, to submit a change on main trunk, you check out the 
trunk, you make your change on trunk, then you post the changed files. For the 
2.8.5 release, you would similarly check out the 2.8 branch, make your changes 
on the branch, then post the changed files. Please prefix the subject line with 
"2.8.5" when you post the submission.


To check out the 2.8 branch, use this URL:
http://www.openscenegraph.org/svn/osg/OpenSceneGraph/branches/OpenSceneGraph-2.8

(As with the 2.8.4 release, I have very limited bandwidth, so my involvement 
with 2.8.5 will primarily be "svn committer".)

   -Paul
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Chris 'Xenon' Hanson]

On 4/20/2011 11:06 AM, Paul Martz wrote:
> On 4/20/2011 10:41 AM, Chris 'Xenon' Hanson wrote:
>>I'll preface this by saying, don't request improvements unless you're 
>> willing to chip in
>> to get them done, or help someone else get them done. ;)
> Assuming I'll be the one committing the changes to the 2.8 branch... I'd like 
> to see the
> submission process be identical to that of the submission process on main 
> trunk. For
> example, to submit a change on main trunk, you check out the trunk, you make 
> your change
> on trunk, then you post the changed files. For the 2.8.5 release, you would 
> similarly
> check out the 2.8 branch, make your changes on the branch, then post the 
> changed files.
> Please prefix the subject line with "2.8.5" when you post the submission.
> To check out the 2.8 branch, use this URL:
> http://www.openscenegraph.org/svn/osg/OpenSceneGraph/branches/OpenSceneGraph-2.8
> (As with the 2.8.4 release, I have very limited bandwidth, so my involvement 
> with 2.8.5
> will primarily be "svn committer".)

  Sounds great, Paul.

>-Paul

-- 
Chris 'Xenon' Hanson, omo sanza lettere. xe...@alphapixel.com 
http://www.alphapixel.com/
  Digital Imaging. OpenGL. Scene Graphs. GIS. GPS. Training. Consulting. 
Contracting.
"There is no Truth. There is only Perception. To Perceive is to Exist." - 
Xen
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

Hi Chris -- I'd like to add r11952 to the 2.8.5 feature list. This was Michael 
Plating's performance enhancement for large numbers of uniforms, which 
effectively eliminates the std::map lookup.


There hasn't been any posts on this thread for 10 days, so it looks like you and 
I are the only people interested in contributing to a 2.8.5 release. Is this 
correct? If so, I suggest we freeze the feature list at this point. (Any new 
feature requests would need to be trivial to add to the branch.)

   -Paul


On 4/20/2011 10:41 AM, Chris 'Xenon' Hanson wrote:

   I'd like to open the discussion about a possible 2.8.5 release.


   I'll preface this by saying, don't request improvements unless you're 
willing to chip in
to get them done, or help someone else get them done. ;)


   These are some of the improvements that have been proposed by a small group 
of my
associates:


* NOTIFY_WARN (&  etc) macros to ease backporting (added to trunk pre-2.8.3).
* 3DS writer fixes (4/8/10 and others).
* FLT writer fixes for multitexture (11/19/10).
* Really most any of the plugins could be updated.
* Support for Texture2DMultisample (4/9/10).
* Bump version / SO numbers.


   Nothing is set in stone here, and we're not yet sure anyone is willing to 
take on any of
these tasks.


   Discuss?




--
  -Paul Martz  Skew Matrix Software
   http://www.skew-matrix.com/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[mike . weiblen]

Heh sorry I'm interested, just got back to DFW and hail. Don't have any 
particular reqs tho, other than the 3ds plugin. Looking fwd to build osgtoy and 
vrpn on this foundation. 
--mew



Sent from my BlackBerry® smartphone, powered by CREDO Mobile.

-Original Message-
From: Paul Martz 
Sender: osg-users-bounces@lists.openscenegraph.orgDate: Sun, 01 May 2011 
18:57:27 
To: OpenSceneGraph Users
Reply-To: OpenSceneGraph Users 
Subject: Re: [osg-users] OSG 2.8.5 stable release discussion

Hi Chris -- I'd like to add r11952 to the 2.8.5 feature list. This was Michael 
Plating's performance enhancement for large numbers of uniforms, which 
effectively eliminates the std::map lookup.

There hasn't been any posts on this thread for 10 days, so it looks like you 
and 
I are the only people interested in contributing to a 2.8.5 release. Is this 
correct? If so, I suggest we freeze the feature list at this point. (Any new 
feature requests would need to be trivial to add to the branch.)
-Paul


On 4/20/2011 10:41 AM, Chris 'Xenon' Hanson wrote:
>I'd like to open the discussion about a possible 2.8.5 release.
>
>
>I'll preface this by saying, don't request improvements unless you're 
> willing to chip in
> to get them done, or help someone else get them done. ;)
>
>
>These are some of the improvements that have been proposed by a small 
> group of my
> associates:
>
>
> * NOTIFY_WARN (&  etc) macros to ease backporting (added to trunk pre-2.8.3).
> * 3DS writer fixes (4/8/10 and others).
> * FLT writer fixes for multitexture (11/19/10).
> * Really most any of the plugins could be updated.
> * Support for Texture2DMultisample (4/9/10).
> * Bump version / SO numbers.
>
>
>Nothing is set in stone here, and we're not yet sure anyone is willing to 
> take on any of
> these tasks.
>
>
>Discuss?
>


-- 
   -Paul Martz  Skew Matrix Software
http://www.skew-matrix.com/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

Yep, and we had already discussed this offline. The 3ds writer fixes are on the 
feature list. Thanks.

   -Paul


On 5/2/2011 11:59 AM, mike.weib...@gmail.com wrote:

Heh sorry I'm interested, just got back to DFW and hail. Don't have any 
particular reqs tho, other than the 3ds plugin. Looking fwd to build osgtoy and 
vrpn on this foundation.
--mew



Sent from my BlackBerry® smartphone, powered by CREDO Mobile.

-Original Message-
From: Paul Martz
Sender: osg-users-bounces@lists.openscenegraph.orgDate: Sun, 01 May 2011 
18:57:27
To: OpenSceneGraph Users
Reply-To: OpenSceneGraph Users
Subject: Re: [osg-users] OSG 2.8.5 stable release discussion

Hi Chris -- I'd like to add r11952 to the 2.8.5 feature list. This was Michael
Plating's performance enhancement for large numbers of uniforms, which
effectively eliminates the std::map  lookup.

There hasn't been any posts on this thread for 10 days, so it looks like you and
I are the only people interested in contributing to a 2.8.5 release. Is this
correct? If so, I suggest we freeze the feature list at this point. (Any new
feature requests would need to be trivial to add to the branch.)
 -Paul


On 4/20/2011 10:41 AM, Chris 'Xenon' Hanson wrote:

I'd like to open the discussion about a possible 2.8.5 release.


I'll preface this by saying, don't request improvements unless you're 
willing to chip in
to get them done, or help someone else get them done. ;)


These are some of the improvements that have been proposed by a small group 
of my
associates:


* NOTIFY_WARN (&   etc) macros to ease backporting (added to trunk pre-2.8.3).
* 3DS writer fixes (4/8/10 and others).
* FLT writer fixes for multitexture (11/19/10).
* Really most any of the plugins could be updated.
* Support for Texture2DMultisample (4/9/10).
* Bump version / SO numbers.


Nothing is set in stone here, and we're not yet sure anyone is willing to 
take on any of
these tasks.


Discuss?







--
  -Paul Martz  Skew Matrix Software
   http://www.skew-matrix.com/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

Hi Robert and all -- It is very likely that I'll move forward with the 2.8.5 
release as we have been discussing on this thread.


I'd like to reserve SO version number 74 for this release.
   -Paul

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Robert Osfield]

Hi Paul,

On Tue, May 3, 2011 at 12:26 AM, Paul Martz  wrote:
> Hi Robert and all -- It is very likely that I'll move forward with the 2.8.5
> release as we have been discussing on this thread.
>
> I'd like to reserve SO version number 74 for this release.

OK, I'll skip 74 next time I bump svn/trunk's SO version number.  If I
forget to do the bump to 75 let me know.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Chris 'Xenon' Hanson]

On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
> I'd like to propose my fixes that I sent in on -submissions pre-2.8.4: all 
> except the
> VC2010 build fix still apply. They are these two:
> Improvements to osgconv:
> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
> (I've also forward-ported these to trunk: 
> https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
> Fixes to the osgWrappers:
> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...fix-wrappers

  I'll take a look at them. As long as you're willing to contribute 
ready-to-check-in
files, and do and coordinate testing of the results, I'm totally welcoming of 
them. But,
we're in a position where we can't do the patch-porting and testing for most 
features,
because we don't have the resources or knowledge.

  The ffmpeg stuff in 2.8.4 turned out to be difficult because while Robert 
ported it and
tested it on Linux, it took a long time to find people who could test it on 
Windows and
Mac OSX. So we have to make sure we can do a proper job on each patch before we 
can accept it.

> Thank you!

  Thank you!

> Ryan

-- 
Chris 'Xenon' Hanson, omo sanza lettere. xe...@alphapixel.com 
http://www.alphapixel.com/
  Digital Imaging. OpenGL. Scene Graphs. GIS. GPS. Training. Consulting. 
Contracting.
"There is no Truth. There is only Perception. To Perceive is to Exist." - 
Xen
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Tue, May 3, 2011 at 4:55 PM, Chris 'Xenon' Hanson
wrote:

> On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
> > I'd like to propose my fixes that I sent in on -submissions pre-2.8.4:
> all except the
> > VC2010 build fix still apply. They are these two:
> > Improvements to osgconv:
> >
> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
> > (I've also forward-ported these to trunk:
> > https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
> > Fixes to the osgWrappers:
> > https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...fix-wrappers
>
>   I'll take a look at them. As long as you're willing to contribute
> ready-to-check-in
> files, and do and coordinate testing of the results, I'm totally welcoming
> of them. But,
> we're in a position where we can't do the patch-porting and testing for
> most features,
> because we don't have the resources or knowledge.
>
>  The ffmpeg stuff in 2.8.4 turned out to be difficult because while Robert
> ported it and
> tested it on Linux, it took a long time to find people who could test it on
> Windows and
> Mac OSX. So we have to make sure we can do a proper job on each patch
> before we can accept it.
>
> > Thank you!
>
>  Thank you!
>
> > Ryan
>
>
I have access to all three platforms and can test on them. (Have already
tested the wrappers fix on Windows vc9 and Linux, and the osgconv on Windows
[functional] and linux [build, didn't actually try using it])

GitHub should give you access to the updated files in whatever form you
prefer - patch, full file, etc.  I haven't figured out how to automatically
zip up the full files for all files touched (as requested in the submission
info) using Git yet, but hopefully this method isn't too difficult to use.

Ryan

-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Chris 'Xenon' Hanson]

On 5/3/2011 4:30 PM, Ryan Pavlik wrote:
> GitHub should give you access to the updated files in whatever form you 
> prefer - patch,
> full file, etc.  I haven't figured out how to automatically zip up the full 
> files for all
> files touched (as requested in the submission info) using Git yet, but 
> hopefully this
> method isn't too difficult to use.

  I'm not very good with Git at all. Can you just send us a zipfile of the full 
files?

> Ryan

-- 
Chris 'Xenon' Hanson, omo sanza lettere. xe...@alphapixel.com 
http://www.alphapixel.com/
  Digital Imaging. OpenGL. Scene Graphs. GIS. GPS. Training. Consulting. 
Contracting.
"There is no Truth. There is only Perception. To Perceive is to Exist." - 
Xen
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

(My replies to Ryan Pavlik on this thread seem to be getting routed to 
/dev/null, so here's a repost...)



Hi Ryan -- For future reference (as mentioned previously on this thread), 
submissions for 2.8.5 should be posted to osg-submissions. But I've got this 
now, so no problem.


I'll take a look at them in the near future and see if they merit being added to 
the 2.8.5 release.

   -Paul

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Wed, May 4, 2011 at 12:31 PM, Paul Martz  wrote:

> (My replies to Ryan Pavlik on this thread seem to be getting routed to
> /dev/null, so here's a repost...)
>
>
> Hi Ryan -- For future reference (as mentioned previously on this thread),
> submissions for 2.8.5 should be posted to osg-submissions. But I've got this
> now, so no problem.
>
> I'll take a look at them in the near future and see if they merit being
> added to the 2.8.5 release.
>   -Paul
>
>
Yes - that's where I initially submitted these, but they kind of fell off
the radar. In looking at the forum mirror of the mailing lists, I saw that
the request for submissions/features was taking place here, and I didn't
want them missed, so I subscribed to this list too and sent the email I did
(hoping it would get lumped in with the thread started before I joined).

Thanks!

Ryan



-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

On 5/3/2011 3:02 PM, Ryan Pavlik wrote:

I'd like to propose my fixes that I sent in on -submissions pre-2.8.4: all
except the VC2010 build fix still apply. They are these two:

Improvements to osgconv:
https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv

(I've also forward-ported these to trunk:
https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )


So, if I understand correctly, you did not post this change to osg-submissions 
for inclusion in OSG's svn trunk, is that correct? Or, you did post them, but 
they are awaiting action by Robert?


Has anyone other than you tested the changes?

What, exactly, are these improvements to osgconv? (No, I haven't looked at the 
code -- yet.)



Fixes to the osgWrappers:
https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...fix-wrappers


Thanks! These are now committed to the 2.8 branch. Please test to verify they 
were applied correctly.

   -Paul
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

On 5/10/2011 7:11 PM, Paul Martz wrote:

On 5/3/2011 3:02 PM, Ryan Pavlik wrote:

I'd like to propose my fixes that I sent in on -submissions pre-2.8.4: all
except the VC2010 build fix still apply. They are these two:

Improvements to osgconv:
https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv

(I've also forward-ported these to trunk:
https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )


So, if I understand correctly, you did not post this change to osg-submissions
for inclusion in OSG's svn trunk, is that correct? Or, you did post them, but
they are awaiting action by Robert?

Has anyone other than you tested the changes?

What, exactly, are these improvements to osgconv? (No, I haven't looked at the
code -- yet.)


Having reviewed the code, I see two changes:

1) A simple change to an error message in osgconv.cpp. Looks straightforward.

2) A change to the image file name format as output by the dot OSG plugin. Not 
sure I understand this one, but it doesn't appear to be an "improvement to 
osgconv". Did you include this by mistake?

   -Paul

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Tue, May 10, 2011 at 8:24 PM, Paul Martz  wrote:

> On 5/10/2011 7:11 PM, Paul Martz wrote:
>
>> On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
>>
>>> I'd like to propose my fixes that I sent in on -submissions pre-2.8.4:
>>> all
>>> except the VC2010 build fix still apply. They are these two:
>>>
>>> Improvements to osgconv:
>>>
>>> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
>>>
>>> (I've also forward-ported these to trunk:
>>> https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
>>>
>>
>> So, if I understand correctly, you did not post this change to
>> osg-submissions
>> for inclusion in OSG's svn trunk, is that correct? Or, you did post them,
>> but
>> they are awaiting action by Robert?
>>
>> Has anyone other than you tested the changes?
>>
>> What, exactly, are these improvements to osgconv? (No, I haven't looked at
>> the
>> code -- yet.)
>>
>
> Having reviewed the code, I see two changes:
>
> 1) A simple change to an error message in osgconv.cpp. Looks
> straightforward.
>
> 2) A change to the image file name format as output by the dot OSG plugin.
> Not sure I understand this one, but it doesn't appear to be an "improvement
> to osgconv". Did you include this by mistake?
>
>   -Paul
>
>
No, the .osg plugin modification essentially only affects use of osgconv.
 What it does is, if  the OutputTextureFiles option is turned on (such as by
passing -O OutputTextureFiles to osgconv), it will create a directory as a
sibling to the desired output file, create the textures in that directory,
and use relative file names in the output osg file so that as long as the
osg file and its matching texture directory are moved together, textures are
found.  Previously, the output location was less clear and an absolute path
was specified in the resulting osg file, which rather negated the effect of
choosing to output texture files, since the osg file would no longer have
textures if moved to a new location.

Hopefully this makes it a bit more clear.

Ryan



-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Tue, May 10, 2011 at 8:11 PM, Paul Martz  wrote:

> On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
>
>> I'd like to propose my fixes that I sent in on -submissions pre-2.8.4: all
>> except the VC2010 build fix still apply. They are these two:
>>
>> Improvements to osgconv:
>>
>> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
>>
>> (I've also forward-ported these to trunk:
>> https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
>>
>
> So, if I understand correctly, you did not post this change to
> osg-submissions for inclusion in OSG's svn trunk, is that correct? Or, you
> did post them, but they are awaiting action by Robert?
>

I hadn't done the forward-port to trunk until I sent this email. I did not
post the trunk version of this change to osg-submissions, though I did post
the 2.8 branch one.

Has anyone other than you tested the changes?
>

Nobody besides me has built it, though we've been using these binaries on a
number of systems here in our lab.

What, exactly, are these improvements to osgconv? (No, I haven't looked at
> the code -- yet.)
>
>
>  Fixes to the osgWrappers:
>> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...fix-wrappers
>>
>
> Thanks! These are now committed to the 2.8 branch. Please test to verify
> they were applied correctly.
>
>   -Paul
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>



-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

On 5/11/2011 11:21 AM, Ryan Pavlik wrote:

So, if I understand correctly, you did not post this change to
osg-submissions for inclusion in OSG's svn trunk, is that correct? Or, you
did post them, but they are awaiting action by Robert?


I hadn't done the forward-port to trunk until I sent this email. I did not post
the trunk version of this change to osg-submissions, though I did post the 2.8
branch one.


Now that I think about it, adding this change to trunk would not be appropriate, 
as the dot OSG plugin is deprecated in trunk.

   -Paul
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

On 5/11/2011 11:20 AM, Ryan Pavlik wrote:



On Tue, May 10, 2011 at 8:24 PM, Paul Martz mailto:pma...@skew-matrix.com>> wrote:

On 5/10/2011 7:11 PM, Paul Martz wrote:

On 5/3/2011 3:02 PM, Ryan Pavlik wrote:

I'd like to propose my fixes that I sent in on -submissions
pre-2.8.4: all
except the VC2010 build fix still apply. They are these two:

Improvements to osgconv:

https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv

(I've also forward-ported these to trunk:

https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )


So, if I understand correctly, you did not post this change to
osg-submissions
for inclusion in OSG's svn trunk, is that correct? Or, you did post
them, but
they are awaiting action by Robert?

Has anyone other than you tested the changes?

What, exactly, are these improvements to osgconv? (No, I haven't looked
at the
code -- yet.)


Having reviewed the code, I see two changes:

1) A simple change to an error message in osgconv.cpp. Looks 
straightforward.

2) A change to the image file name format as output by the dot OSG plugin.
Not sure I understand this one, but it doesn't appear to be an "improvement
to osgconv". Did you include this by mistake?

   -Paul


No, the .osg plugin modification essentially only affects use of osgconv.  What
it does is, if  the OutputTextureFiles option is turned on (such as by passing
-O OutputTextureFiles to osgconv),


...or anytime "OutputTextureFiles" is present in the Options string. This 
functionality is orthogonal to osgconv. Any application can access it anytime 
they write a dot OSG file. This change will affect more than osgconv.

   -Paul
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Wed, May 11, 2011 at 1:27 PM, Paul Martz  wrote:

> On 5/11/2011 11:20 AM, Ryan Pavlik wrote:
>
>>
>>
>> On Tue, May 10, 2011 at 8:24 PM, Paul Martz > > wrote:
>>
>>On 5/10/2011 7:11 PM, Paul Martz wrote:
>>
>>On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
>>
>>I'd like to propose my fixes that I sent in on -submissions
>>pre-2.8.4: all
>>except the VC2010 build fix still apply. They are these two:
>>
>>Improvements to osgconv:
>>
>> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
>>
>>(I've also forward-ported these to trunk:
>>
>> https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
>>
>>
>>So, if I understand correctly, you did not post this change to
>>osg-submissions
>>for inclusion in OSG's svn trunk, is that correct? Or, you did post
>>them, but
>>they are awaiting action by Robert?
>>
>>Has anyone other than you tested the changes?
>>
>>What, exactly, are these improvements to osgconv? (No, I haven't
>> looked
>>at the
>>code -- yet.)
>>
>>
>>Having reviewed the code, I see two changes:
>>
>>1) A simple change to an error message in osgconv.cpp. Looks
>> straightforward.
>>
>>2) A change to the image file name format as output by the dot OSG
>> plugin.
>>Not sure I understand this one, but it doesn't appear to be an
>> "improvement
>>to osgconv". Did you include this by mistake?
>>
>>   -Paul
>>
>>
>> No, the .osg plugin modification essentially only affects use of osgconv.
>>  What
>> it does is, if  the OutputTextureFiles option is turned on (such as by
>> passing
>> -O OutputTextureFiles to osgconv),
>>
>
> ...or anytime "OutputTextureFiles" is present in the Options string. This
> functionality is orthogonal to osgconv. Any application can access it
> anytime they write a dot OSG file. This change will affect more than
> osgconv.
>
>   -Paul
>

Well, yes. In retrospect, I didn't name the patch very accurately given its
contents - I created it while working on osgconv which is presumably why I
mentioned osgconv in the name.

In any case, we can consider it as a separate patch, to the .osg writer
plugin. My intent was to make saving models with textures to OSG format work
better.  In all of the following cases, insert the qualification "with
OutputTextureFiles enabled" - behavior does not change unless this option is
added. Before and after the patch, loading an .osg model in the place where
it was initially saved works. After the patch, however, the textures go to a
subdirectory named in a way that clearly links it with the model that uses
it, and loading the saved model from another location as long as the
textures were also copied/moved works correctly.  The only case I can see
that worked before and won't work after, is if the .osg file alone is
moved/copied somewhere else, but the textures remain in the
originally-exported location. (This is due to the fact that it now exports
relative paths.)

As a useful side-effect (for privacy/security) of using relative paths, .osg
files saved with this option turned on don't reveal details about the file
organization of the computer they were saved on.

Would this be an improvement that would better be separated into a distinct
option string like OutputRelativeTextures or something like that?

Ryan

-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

On 5/11/2011 1:46 PM, Ryan Pavlik wrote:



On Wed, May 11, 2011 at 1:27 PM, Paul Martz mailto:pma...@skew-matrix.com>> wrote:

On 5/11/2011 11:20 AM, Ryan Pavlik wrote:



On Tue, May 10, 2011 at 8:24 PM, Paul Martz mailto:pma...@skew-matrix.com>
>> wrote:

On 5/10/2011 7:11 PM, Paul Martz wrote:

On 5/3/2011 3:02 PM, Ryan Pavlik wrote:

I'd like to propose my fixes that I sent in on -submissions
pre-2.8.4: all
except the VC2010 build fix still apply. They are these two:

Improvements to osgconv:

https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv

(I've also forward-ported these to trunk:
https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )


So, if I understand correctly, you did not post this change to
osg-submissions
for inclusion in OSG's svn trunk, is that correct? Or, you did 
post
them, but
they are awaiting action by Robert?

Has anyone other than you tested the changes?

What, exactly, are these improvements to osgconv? (No, I haven't
looked
at the
code -- yet.)


Having reviewed the code, I see two changes:

1) A simple change to an error message in osgconv.cpp. Looks
straightforward.

2) A change to the image file name format as output by the dot OSG
plugin.
Not sure I understand this one, but it doesn't appear to be an
"improvement
to osgconv". Did you include this by mistake?

   -Paul


No, the .osg plugin modification essentially only affects use of
osgconv.  What
it does is, if  the OutputTextureFiles option is turned on (such as by
passing
-O OutputTextureFiles to osgconv),


...or anytime "OutputTextureFiles" is present in the Options string. This
functionality is orthogonal to osgconv. Any application can access it
anytime they write a dot OSG file. This change will affect more than 
osgconv.

   -Paul


Well, yes. In retrospect, I didn't name the patch very accurately given its
contents - I created it while working on osgconv which is presumably why I
mentioned osgconv in the name.

In any case, we can consider it as a separate patch, to the .osg writer plugin.
My intent was to make saving models with textures to OSG format work better.  In
all of the following cases, insert the qualification "with OutputTextureFiles
enabled" - behavior does not change unless this option is added. Before and
after the patch, loading an .osg model in the place where it was initially saved
works. After the patch, however, the textures go to a subdirectory named in a
way that clearly links it with the model that uses it, and loading the saved
model from another location as long as the textures were also copied/moved works
correctly.  The only case I can see that worked before and won't work after, is
if the .osg file alone is moved/copied somewhere else, but the textures remain
in the originally-exported location. (This is due to the fact that it now
exports relative paths.)

As a useful side-effect (for privacy/security) of using relative paths, .osg
files saved with this option turned on don't reveal details about the file
organization of the computer they were saved on.

Would this be an improvement that would better be separated into a distinct
option string like OutputRelativeTextures or something like that?


Yes, that's the way I'm leaning now. Your patch changes behavior, and would 
break any apps or utilities that depend on the current behavior. I'd be a lot 
more comfortable with this if it were a feature addition rather than a change to 
existing functionality.


Do you think "OutputRelativeTextures" is a good name for it? If so, I can 
rewrite the submission locally (but you'll need to test it).

   -Paul
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Wed, May 11, 2011 at 5:19 PM, Paul Martz  wrote:

> On 5/11/2011 1:46 PM, Ryan Pavlik wrote:
>
>>
>>
>> On Wed, May 11, 2011 at 1:27 PM, Paul Martz > > wrote:
>>
>>On 5/11/2011 11:20 AM, Ryan Pavlik wrote:
>>
>>
>>
>>On Tue, May 10, 2011 at 8:24 PM, Paul Martz <
>> pma...@skew-matrix.com
>>
>>>>
>> wrote:
>>
>>On 5/10/2011 7:11 PM, Paul Martz wrote:
>>
>>On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
>>
>>I'd like to propose my fixes that I sent in on
>> -submissions
>>pre-2.8.4: all
>>except the VC2010 build fix still apply. They are these
>> two:
>>
>>Improvements to osgconv:
>>
>> https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
>>
>>(I've also forward-ported these to trunk:
>>
>> https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
>>
>>
>>So, if I understand correctly, you did not post this change
>> to
>>osg-submissions
>>for inclusion in OSG's svn trunk, is that correct? Or, you
>> did post
>>them, but
>>they are awaiting action by Robert?
>>
>>Has anyone other than you tested the changes?
>>
>>What, exactly, are these improvements to osgconv? (No, I
>> haven't
>>looked
>>at the
>>code -- yet.)
>>
>>
>>Having reviewed the code, I see two changes:
>>
>>1) A simple change to an error message in osgconv.cpp. Looks
>>straightforward.
>>
>>2) A change to the image file name format as output by the dot
>> OSG
>>plugin.
>>Not sure I understand this one, but it doesn't appear to be an
>>"improvement
>>to osgconv". Did you include this by mistake?
>>
>>   -Paul
>>
>>
>>No, the .osg plugin modification essentially only affects use of
>>osgconv.  What
>>it does is, if  the OutputTextureFiles option is turned on (such as
>> by
>>passing
>>-O OutputTextureFiles to osgconv),
>>
>>
>>...or anytime "OutputTextureFiles" is present in the Options string.
>> This
>>functionality is orthogonal to osgconv. Any application can access it
>>anytime they write a dot OSG file. This change will affect more than
>> osgconv.
>>
>>   -Paul
>>
>>
>> Well, yes. In retrospect, I didn't name the patch very accurately given
>> its
>> contents - I created it while working on osgconv which is presumably why I
>> mentioned osgconv in the name.
>>
>> In any case, we can consider it as a separate patch, to the .osg writer
>> plugin.
>> My intent was to make saving models with textures to OSG format work
>> better.  In
>> all of the following cases, insert the qualification "with
>> OutputTextureFiles
>> enabled" - behavior does not change unless this option is added. Before
>> and
>> after the patch, loading an .osg model in the place where it was initially
>> saved
>> works. After the patch, however, the textures go to a subdirectory named
>> in a
>> way that clearly links it with the model that uses it, and loading the
>> saved
>> model from another location as long as the textures were also copied/moved
>> works
>> correctly.  The only case I can see that worked before and won't work
>> after, is
>> if the .osg file alone is moved/copied somewhere else, but the textures
>> remain
>> in the originally-exported location. (This is due to the fact that it now
>> exports relative paths.)
>>
>> As a useful side-effect (for privacy/security) of using relative paths,
>> .osg
>> files saved with this option turned on don't reveal details about the file
>> organization of the computer they were saved on.
>>
>> Would this be an improvement that would better be separated into a
>> distinct
>> option string like OutputRelativeTextures or something like that?
>>
>
> Yes, that's the way I'm leaning now. Your patch changes behavior, and would
> break any apps or utilities that depend on the current behavior. I'd be a
> lot more comfortable with this if it were a feature addition rather than a
> change to existing functionality.
>
> Do you think "OutputRelativeTextures" is a good name for it? If so, I can
> rewrite the submission locally (but you'll need to test it).
>
>   -Paul
>

It makes sense to me, at least. Thanks!

Ryan

-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Paul Martz]

Would this be an improvement that would better be separated into a 
distinct
option string like OutputRelativeTextures or something like that?


Yes, that's the way I'm leaning now. Your patch changes behavior, and would
break any apps or utilities that depend on the current behavior. I'd be a
lot more comfortable with this if it were a feature addition rather than a
change to existing functionality.

Do you think "OutputRelativeTextures" is a good name for it? If so, I can
rewrite the submission locally (but you'll need to test it).

   -Paul


It makes sense to me, at least. Thanks!


Okay, this is now in. Please test.

I've coded it so that if OutputRelativeTextures and OutputTextureFiles are both 
present, OutputRelativeTextures will take precedent.

   -Paul
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OSG 2.8.5 stable release discussion

[Ryan Pavlik]

On Wed, May 11, 2011 at 7:55 PM, Paul Martz  wrote:

>Would this be an improvement that would better be separated into a
>> distinct
>>option string like OutputRelativeTextures or something like that?
>>
>>
>>Yes, that's the way I'm leaning now. Your patch changes behavior, and
>> would
>>break any apps or utilities that depend on the current behavior. I'd be
>> a
>>lot more comfortable with this if it were a feature addition rather
>> than a
>>change to existing functionality.
>>
>>Do you think "OutputRelativeTextures" is a good name for it? If so, I
>> can
>>rewrite the submission locally (but you'll need to test it).
>>
>>   -Paul
>>
>>
>> It makes sense to me, at least. Thanks!
>>
>
> Okay, this is now in. Please test.
>
> I've coded it so that if OutputRelativeTextures and OutputTextureFiles are
> both present, OutputRelativeTextures will take precedent.
>
>   -Paul
>

Thanks!  I can confirm that this works properly!

Noticed some other minor issues when testing this that probably should block
2.8.5 for now - will send to osg-submissions.

Ryan
-- 
Ryan Pavlik
HCI Graduate Student
Virtual Reality Applications Center
Iowa State University

rpav...@iastate.edu
http://academic.cleardefinition.com
Internal VRAC/HCI Site: http://tinyurl.com/rpavlik
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org