Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:10 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs (updated) - src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:12 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs (updated) - src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123735: version of QmlObject with a static engine
On May 12, 2015, 3:52 p.m., David Edmundson wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 62 https://git.reviewboard.kde.org/r/123735/diff/2/?file=368373#file368373line62 this needs to be initialised. line 65 QQmlEngine *QmlObjectSharedEnginePrivate::s_engine = 0; On May 12, 2015, 3:52 p.m., David Edmundson wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 69 https://git.reviewboard.kde.org/r/123735/diff/2/?file=368373#file368373line69 I'm not sure the ownership on the context is right. I think we want the context to last for the lifespan of the QmlObjectSharedEngine (this), currently it's the lifespan of the enitre app if i parent it it crashes on initialization, if i delete the context on the qmlobject destruction, it seems to work fine On May 12, 2015, 3:52 p.m., David Edmundson wrote: src/kdeclarative/qmlobject.cpp, line 176 https://git.reviewboard.kde.org/r/123735/diff/2/?file=368371#file368371line176 if we're using the shared engine we end up not setting the incubation controller. I don't know what difference that will make? ah, even if now is sync, the incubator is still needed for the initialProperties paramenter, added it - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80244 --- On May 12, 2015, 4:05 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:05 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs - src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80252 --- src/kdeclarative/qmlobjectsharedengine.h (line 57) https://git.reviewboard.kde.org/r/123735/#comment55048 std::unique_ptr... ... then you can also forget about the delete in the destructor. src/kdeclarative/qmlobjectsharedengine.cpp (line 48) https://git.reviewboard.kde.org/r/123735/#comment55050 static const QQmlEngine ... Prevents changing the pointer later on. src/kdeclarative/qmlobjectsharedengine.cpp (line 75) https://git.reviewboard.kde.org/r/123735/#comment55049 remove if you decide to use a smart pointer for this one. - Mark Gaiser On mei 12, 2015, 4:12 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated mei 12, 2015, 4:12 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs - src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123738: Use column major in the taskbar when Force row settings is set
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- When we have Force row settings and more than one row of items, the items start to jump around and it is had to keep track of where each item is. The atached patch changes the flow to TopToBottom, in stead of LeftToRight, when we have a horizontal layout and Force row settings, and similarly to LeftToRight in vertical layout. (In practice the vertical layout is always one column and this patch has no effect) Here are two videos that describe the problem First is the row major where taskbar items jump around: https://youtu.be/8udr2DJKobw And the second with a patched taskbar where the items jump around a lot less: https://youtu.be/bk17gnu1ETo Diffs - applets/taskmanager/package/contents/ui/main.qml 98ba7c3 Diff: https://git.reviewboard.kde.org/r/123738/diff/ Testing --- I'm using this patch on all my installations and tried the vertical layout Thanks, Kåre Särs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123738: Use column major in the taskbar when Force row settings is set
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123738/#review80256
---
applets/taskmanager/package/contents/ui/main.qml (line 237)
https://git.reviewboard.kde.org/r/123738/#comment55051
Two ternary operators in one row is _really_ hard to read! Please consider
making it readable with if - elseif - else.
flow: {
if (...) {
} ...
}
etc.
I really like how this change makes drag/drop much more easier to follow! Great
change imho, just the style of the change could be made more readable.
- Mark Gaiser
On mei 12, 2015, 7:26 p.m., Kåre Särs wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123738/
---
(Updated mei 12, 2015, 7:26 p.m.)
Review request for Plasma and Eike Hein.
Repository: plasma-desktop
Description
---
When we have Force row settings and more than one row of items, the items
start to jump around and it is had to keep track of where each item is.
The atached patch changes the flow to TopToBottom, in stead of LeftToRight,
when we have a horizontal layout and Force row settings, and similarly to
LeftToRight in vertical layout. (In practice the vertical layout is always
one column and this patch has no effect)
Here are two videos that describe the problem
First is the row major where taskbar items jump around:
https://youtu.be/8udr2DJKobw
And the second with a patched taskbar where the items jump around a lot less:
https://youtu.be/bk17gnu1ETo
Diffs
-
applets/taskmanager/package/contents/ui/main.qml 98ba7c3
Diff: https://git.reviewboard.kde.org/r/123738/diff/
Testing
---
I'm using this patch on all my installations and tried the vertical layout
Thanks,
Kåre Särs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123740: Add timezone filtering by region too
On May 12, 2015, 10:23 p.m., David Edmundson wrote: applets/digital-clock/plugin/timezonemodel.h, line 34 https://git.reviewboard.kde.org/r/123740/diff/1/?file=368406#file368406line34 it's worth always having a NOTIFY, otherwise if in the future anything binds to filterString it'll not work properly. Ok, I'll add one. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/#review80257 --- On May 12, 2015, 10:05 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/ --- (Updated May 12, 2015, 10:05 p.m.) Review request for Plasma. Bugs: 346681 https://bugs.kde.org/show_bug.cgi?id=346681 Repository: plasma-workspace Description --- Adds a simple QSortFilterProxyModel on top of TimeZonesModel and reimplements filterAcceptsRow using QStringMatcher (supposedly faster according to qtdocs). Sidenote: Originally I did try to implement this using the filterCallback in PlasmaCore.SortFilterModel, but this worked very very wonkily. Basically on z it would match correctly, on zu the list is suddenly empty. Sometimes. No matter what I tried, I couldn't get that to work and work reliably (it also requires changes in plasma-framework to call the invalidate() after each char is typed in and a get(int row) function in the TimeZoneModel). After spending manymany hours on this, I just went for this simple 50 lines addition instead. And it just works (tm). Diffs - applets/digital-clock/package/contents/ui/configTimeZones.qml ef04381 applets/digital-clock/plugin/digitalclockplugin.cpp d4bfad4 applets/digital-clock/plugin/timezonemodel.h 761d78d applets/digital-clock/plugin/timezonemodel.cpp 27698a3 Diff: https://git.reviewboard.kde.org/r/123740/diff/ Testing --- Timezones are now correctly filtered by both city and region. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123740: Add timezone filtering by region too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/ --- (Updated May 12, 2015, 8:53 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 72041b7c90c3f4e1d1ec6812813dee84952f3f89 by Martin Klapetek to branch Plasma/5.3. Bugs: 346681 https://bugs.kde.org/show_bug.cgi?id=346681 Repository: plasma-workspace Description --- Adds a simple QSortFilterProxyModel on top of TimeZonesModel and reimplements filterAcceptsRow using QStringMatcher (supposedly faster according to qtdocs). Sidenote: Originally I did try to implement this using the filterCallback in PlasmaCore.SortFilterModel, but this worked very very wonkily. Basically on z it would match correctly, on zu the list is suddenly empty. Sometimes. No matter what I tried, I couldn't get that to work and work reliably (it also requires changes in plasma-framework to call the invalidate() after each char is typed in and a get(int row) function in the TimeZoneModel). After spending manymany hours on this, I just went for this simple 50 lines addition instead. And it just works (tm). Diffs - applets/digital-clock/package/contents/ui/configTimeZones.qml ef04381 applets/digital-clock/plugin/digitalclockplugin.cpp d4bfad4 applets/digital-clock/plugin/timezonemodel.h 761d78d applets/digital-clock/plugin/timezonemodel.cpp 27698a3 Diff: https://git.reviewboard.kde.org/r/123740/diff/ Testing --- Timezones are now correctly filtered by both city and region. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123746: Workaround DBusMenuQt's design
On May 13, 2015, 4:49 a.m., Aleix Pol Gonzalez wrote: Has DBusMenuQt been fixed? Or is it beyond our reach for a weird reason? PS: I don't mind the workaround as long as we fix upstream too. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123746/#review80272 --- On May 13, 2015, 3:39 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123746/ --- (Updated May 13, 2015, 3:39 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- DBusMenuImporter by default connects QMenu::aboutToShow to a private slot slotMenuAboutToShow, in this slot it reloads the menu befre it gets shown because the menu shows just after aboutToShow() returns DBusMenuQt in it's infinite wisdom spawns a new event loop to block the QMenu processing till we get the network reply Not only is this rather pointless as all uses in Plamsa calls updateMenu() before showing, so we fetch the menu twice it also leads to all sorts of crazy crashes as when we process all other events we might delete the menu from within QMenu emitting aboutToShow() which is a very unexpected thing to do as QMenu::popup ends up with 'this' being destroyed halfway through it's frame. BUG: 343971 BUG: 345838 BUG: 345933 Ideal fix is in DBusMenuQt, and I /hate/ doing workarounds, but I can't see how to solve it without *significantly* changing the API. Diffs - dataengines/statusnotifieritem/statusnotifieritemsource.cpp b6a50279c01076e7242afaf93d1769348ba031ba Diff: https://git.reviewboard.kde.org/r/123746/diff/ Testing --- Opened steam closed steam from menu quickly click on the SNI before it exits. Used to crash. Now doesn't. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123727: [klipper] Ensure global shortcut actions work
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123727/ --- (Updated May 12, 2015, 9:39 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 56a5947e3707c104fe9170a51bdda308deee4d13 by Martin Gräßlin to branch Plasma/5.3. Bugs: 345945 https://bugs.kde.org/show_bug.cgi?id=345945 Repository: plasma-workspace Description --- Some actions were set to not-visible in order to not show them in the popup if not in standalone mode. This has the side effect of global shortcuts no longer working as global shortcuts do not trigger for not visible actions. To fullfill both needs the check is now done to only add the actions to the popup if it's in standalone mode, but the visibility is not changed. BUG: 345945 FIXED-IN: 5.3.1 Diffs - klipper/klipper.cpp da7d831d1c659f0385966acd98a9d7fbc2ff6c06 Diff: https://git.reviewboard.kde.org/r/123727/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123426: Kickoff is not mounting removable devices and shows Invalid URL
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123426/ --- (Updated May 12, 2015, 9:32 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 49a1a2827639b3099a2f16fc3c8eef6130e4d95d by Marco Martin to branch master. Bugs: 346002 None Description --- Fixed version of /r/123350/ Why VisualDelegateModel? It may be workaround/hack/you name it but it was the only way I found acceptable. You need to pass QModelIndex to openItem and I don't know how to get it using plain ListView and SystemModel. VisualDelegateModel has a convenience method modelIndex which is already used in KickoffItem.qml (but only if ApplicationsView tab is active). I changed BaseView to use VisualDelegateModel to have modelIndex method and to be more consistent with ApplicaitonView. this change seems uneeded; we're using modelIndex fine in the old code, see line 40 in KickoffItem.qml in the old code. (unless maybe that didn't work ?) My understanding is setting the model to a QAIM, internally just creates a VDM anyway. It didn't work. modelIndex is used only if flag hasModelChildren is set to true. That can happen only for ApplicationView, as only there children exist. Also ApplicationView uses VisualDataModel explicitly, so method modelIndex is available. In SystemView model is set directly, VisualDataModel is not created implicitly (or even if it is it is not accessible). In other words listItem.ListView.view.model returns SystemModel object which is QAbstractProxyModel/QAbstractItemModel implementation. SystemModel does not have any slot that would be usefull in this case. Passing model variable is not an option. It would be a good idea as it contains all data related to current item but this is internal QML/Qt Quick class. In KDE 4 it was not a problem as it was easy to get QModelIndex from event (lines 860 - 878): https://projects.kde.org/projects/kde/kde-workspace/repository/entry/plasma/desktop/applets/kickoff/ui/launcher.cpp?rev=KDE%2F4.9 Diffs - Diff: https://git.reviewboard.kde.org/r/123426/diff/ Testing --- I was able to reproduce bug using latest GIT code. Screenshots, first shows not mounted removable device, second is error message (in Polish): https://www.dropbox.com/s/8vcokx17kmn3onw/zrzut%20ekranu1.png?dl=0s=sl https://www.dropbox.com/s/sqkci1z1fhb3h3p/zrzut%20ekranu2.png?dl=0s=sl In console I can find this message: Opening item with URL It looks that KFilePlacesModel-url(index) returns empty string for not mounted devices. I have 5.9.0 version of libkf5kiocore5 installed. Patch fixed mounting. I also tested all tabs, all items works as expected. File Attachments Use VisualDataModel-modelIndex in openItem https://git.reviewboard.kde.org/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch Thanks, Konrad Materka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: testing the single QQmlEngine plasmashell
On Tuesday 12 May 2015, Aleix Pol wrote: Hi, I wanted to give it a go as well, and so I did. :D http://proli.net/meu/kde/massif.out.3278-beforeBranchChange http://proli.net/meu/kde/massif.out.5283-afterBranchChange http://proli.net/meu/kde/massif.out.5759-afterBranchChange this is after playing with it for a while and showing the system stray stuff. It seems that it saves quite some memory, at least the same amount on my system than on yours. It's weird how in takes much more memory on my system than on yours. Maybe because I have 2 screens here? With regards to runtime, it feels a bit smoother, but that might be just me wishing for it. 2 screens increases a lot yep, also, the system on which i traced is 32 bit, on the 64 bit system it takes a lot more -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: testing the single QQmlEngine plasmashell
On Mon, May 11, 2015 at 6:20 PM, Marco Martin notm...@gmail.com wrote: On Monday 11 May 2015, Marco Martin wrote: please test it to see if there are obvious regressions, if it's faster or slower, more or less crashy, if it takes more or less memory (dere it slims by about 25 MB on a 32bit system, of about 40 on a 64 bit), good profiling of memory and startup time may be nice as well (will try in massif later) particularly important to test as many aplets as possible, as it may be perfect for one and break another known regression atm is broken translations but should be easily fixable massif trace is at: http://notmart.org/misc/massif.out.25745.plasmashell-multipleEngines http://notmart.org/misc/massif.out.26911.plasmashell-singleEngine This is from plasmoidviewer of the systray, that's the next biggest thing after the full shell: http://notmart.org/misc/massif.out.24047.singleEngine http://notmart.org/misc/massif.out.25446.multipleEngines -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel Hi, I wanted to give it a go as well, and so I did. :D http://proli.net/meu/kde/massif.out.3278-beforeBranchChange http://proli.net/meu/kde/massif.out.5283-afterBranchChange http://proli.net/meu/kde/massif.out.5759-afterBranchChange this is after playing with it for a while and showing the system stray stuff. It seems that it saves quite some memory, at least the same amount on my system than on yours. It's weird how in takes much more memory on my system than on yours. Maybe because I have 2 screens here? With regards to runtime, it feels a bit smoother, but that might be just me wishing for it. Aleix PS: note I'm on self-compiled Qt 5.5 with debug symbols on debug ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs - CMakeLists.txt e6155e2 src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c788943 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/clipboard.h 980ce54 src/qmlcontrols/kquickcontrolsaddons/plotter.h a564761 tests/helloworld/metadata.desktop dd188c7 tests/helloworldnowindow/metadata.desktop 15d8783 Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123736: single QQmlEngine for all applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- use a single shared QQmlEngine for all applets, tooltip and wallpapers (each of which used to use an own one) views are still separed engines because being View subclass of QQuickView which api unfortunately requires it (a qquickengine can be passed to the ctor, but in that case they would share their QQmlContext, which wouldn't work) For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will still have own engine Diffs - src/declarativeimports/core/tooltipdialog.cpp feeacc3 src/plasmaquick/appletquickitem.cpp c6fcf22 src/plasmaquick/packageurlinterceptor.h 36c85a9 src/plasmaquick/packageurlinterceptor.cpp 5f77c3a src/plasmaquick/private/appletquickitem_p.h a1ec683 src/scriptengines/qml/plasmoid/wallpaperinterface.cpp fcaca4b Diff: https://git.reviewboard.kde.org/r/123736/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80241 --- Can you make the diff against the branch root instead of origin/master? There's some unrelated stuff there... - Aleix Pol Gonzalez On May 12, 2015, 5:22 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 5:22 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs - CMakeLists.txt e6155e2 src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c788943 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/clipboard.h 980ce54 src/qmlcontrols/kquickcontrolsaddons/plotter.h a564761 tests/helloworld/metadata.desktop dd188c7 tests/helloworldnowindow/metadata.desktop 15d8783 Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 3:35 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs (updated) - src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123736: single QQmlEngine for all applets
On May 12, 2015, 3:44 p.m., Kai Uwe Broulik wrote: For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will still have own engine You mean SharedEngine? :) that :) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/#review80243 --- On May 12, 2015, 3:30 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/ --- (Updated May 12, 2015, 3:30 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- use a single shared QQmlEngine for all applets, tooltip and wallpapers (each of which used to use an own one) views are still separed engines because being View subclass of QQuickView which api unfortunately requires it (a qquickengine can be passed to the ctor, but in that case they would share their QQmlContext, which wouldn't work) For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will still have own engine Diffs - src/declarativeimports/core/tooltipdialog.cpp feeacc3 src/plasmaquick/appletquickitem.cpp c6fcf22 src/plasmaquick/packageurlinterceptor.h 36c85a9 src/plasmaquick/packageurlinterceptor.cpp 5f77c3a src/plasmaquick/private/appletquickitem_p.h a1ec683 src/scriptengines/qml/plasmoid/wallpaperinterface.cpp fcaca4b Diff: https://git.reviewboard.kde.org/r/123736/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80249 --- src/kdeclarative/qmlobject.h (line 81) https://git.reviewboard.kde.org/r/123735/#comment55043 Empty comment? src/kdeclarative/qmlobjectsharedengine.cpp (line 65) https://git.reviewboard.kde.org/r/123735/#comment55044 Maybe it should better use Q_GLOBAL_STATIC? - Aleix Pol Gonzalez On May 12, 2015, 5:35 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 5:35 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Diffs - src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
