[Differential] [Commented On] D3188: Modified distance function to keep aspect ratio as close as possible

[mart (Marco Martin)]

mart added a comment.


  almost perfect :)
  
  last thing, can the test be moved in a subfolder called autotests? (just a 
convention)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3225: Don't snap to auto-hidden panels

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  dont-snap-to-auto-hidden-panel-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3225

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3188: Modified distance function to keep aspect ratio as close as possible

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  arcpatch-D3188

REVISION DETAIL
  https://phabricator.kde.org/D3188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart retitled this revision from "[WIP]: show full scrollbar only on mouse 
over" to "Show full scrollbar only on mouse over".

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3131

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Updated, 171 lines] D3131: [WIP]: show full scrollbar only on mouse over

[mart (Marco Martin)]

mart updated this revision to Diff 7701.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  - use the internal breeze animation machinery
  - use the same graphics for the handle not under mouse
  - scrollbar on mouse over is configurable

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3131?vs=7597=7701

BRANCH
  arcpatch-D3131

REVISION DETAIL
  https://phabricator.kde.org/D3131

AFFECTED FILES
  kstyle/animations/breezescrollbardata.cpp
  kstyle/animations/breezescrollbardata.h
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3131: [WIP]: show full scrollbar only on mouse over

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3131#58136, @hpereiradacosta wrote:
  
  > Hello,
  >  the idea is nice. For the implementation however, rather than changing the 
opacity of the painter, I think it would be more efficiency with changing the 
opacity of the colors that are passed to the various rendering methods instead.
  >  As for the other design changes suggested in the comments:
  >
  > - this should go to different commits
  > - should be discussed with the vdg. Well, this change should be discussed 
with the vdg too in fact :)
  
  
  yes, this change is from a request by the VDG,
  now, a good thing would be getting them to try it, but is always hard for c++ 
;)
  
  the latest version should use only color animations, removed all the painter 
opacity and the animation engine of breeze should be used in a more correct way.
  a config option to enable/disable all of this is added.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3131

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Accepted] D3184: Bring potd wallpaper back to life.

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3184

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3183: Port potd (picture of the day) dataengine to KF5.

[mart (Marco Martin)]

mart added a comment.


  code looks good.
  I tested the urls, annotated inline those that work and those that don't.
  Unfortunately there are still two that don't, in flickr, where a no longer 
valid api key is used and the wikipedia one.

INLINE COMMENTS

> apodprovider.cpp:83
>  {
> -KUrl url( QLatin1String( "http://antwrp.gsfc.nasa.gov/apod/; ) );
> +QUrl url( QLatin1String( "http://antwrp.gsfc.nasa.gov/apod/; ) );
>  KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload, 
> KIO::HideProgressInfo );

works, +1

> epodprovider.cpp:82
>  {
> -KUrl url( QLatin1String( "http://epod.usra.edu/blog/; ) );
> +QUrl url( QLatin1String( "http://epod.usra.edu/blog/; ) );
>  KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload, 
> KIO::HideProgressInfo );

this works, +1

> flickrprovider.cpp:81
>  
> -KUrl url( QLatin1String( 
> "http://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4=flickr.interestingness.getList=;
>  ) + mActualDate.toString( Qt::ISODate) );
> +QUrl url( QLatin1String( 
> "https://api.flickr.com/services/rest/?api_key=11829a470557ad8e10b02e80afacb3af=flickr.interestingness.getList=;
>  ) + mActualDate.toString( Qt::ISODate) );
>  KIO::StoredTransferJob *pageJob = 
> KIO::storedGet(url, KIO::NoReload, KIO::HideProgressInfo);

this one is valid, same api key should be used in the other queries

> flickrprovider.cpp:129
> +QUrl url(QLatin1String(
> +
> "https://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4=flickr.interestingness.getList=;
>  ) + date().toString( Qt::ISODate ) );

says "key has expired",
should have 11829a470557ad8e10b02e80afacb3af  instead?

> natgeoprovider.cpp:96
>  {
> -const QUrl url( QLatin1String( 
> "http://photography.nationalgeographic.com/photography/photo-of-the-day; ) );
> +const QUrl url( QLatin1String( 
> "https://www.nationalgeographic.com/photography/photo-of-the-day; ) );
>  connect( d->mPage, SIGNAL(loadFinished(bool)), this, 
> SLOT(pageRequestFinished(bool)) );

works, +1

> noaaprovider.cpp:95
>  {
> -const QUrl url( QLatin1String( 
> "http://photography.nationalgeographic.com/photography/photo-of-the-day; ) );
> +QUrl url( QLatin1String( "http://www.nnvl.noaa.gov/imageoftheday.php; ) 
> );
>  connect( d->mPage, SIGNAL(loadFinished(bool)), this, 
> SLOT(pageRequestFinished(bool)) );

this one works, +1

> wcpotdprovider.cpp:54
>  
> -KUrl picUrl( QLatin1String( 
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600; ) );  
> KIO::StoredTransferJob *imageJob = KIO::storedGet( picUrl, KIO::NoReload, 
> KIO::HideProgressInfo );
> +QUrl picUrl( QLatin1String( 
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600; ) );  
> KIO::StoredTransferJob *imageJob = KIO::storedGet( picUrl, KIO::NoReload, 
> KIO::HideProgressInfo );
>  mParent->connect( imageJob, SIGNAL(finished(KJob*)), 
> SLOT(imageRequestFinished(KJob*)) );

other copy of invalid url

> wcpotdprovider.cpp:73
>  {
> -KUrl url( QLatin1String( 
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600; ));
> +QUrl url( QLatin1String( 
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600; ));
>  

this url doesn't seem to be valid anymore

maybe should web-scrape 
https://en.wikipedia.org/wiki/Wikipedia:Wikimedia_Commons/POTD ?
(don't know if there is a way to obtain directly the image)

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3151: Trigger resize of input window when deco size changes

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  input-window-maximize-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3151

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3166: make sure containment actions config is up to date

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3166#59071, @davidedmundson wrote:
  
  > It's still a bodge round broken user code.
  
  
  it is, but the thing is, that's the way is supported by the api right now, 
and there are users for it, so it has to work, regardless if it's quite ugly.
  i can't really see much other ways, either that or put a watcher on the 
config update...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 168 lines] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart updated this revision to Diff 7725.
mart added a comment.


  - try harder to figure out the widget is under mouse
  
  when drawing the arrow we can't know if the widget is under mouse
  by the style option, and we can't access the widget when using the
  qstyle over QML, so check either the widget if is there or a property
  in the styleObject in the case of QML.
  this also fixes arrows visibility when animations are disabled

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3131?vs=7720=7725

BRANCH
  arcpatch-D3131

REVISION DETAIL
  https://phabricator.kde.org/D3131

AFFECTED FILES
  kstyle/animations/breezescrollbardata.cpp
  kstyle/animations/breezescrollbardata.h
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote:
  
  > Hi Marco,
  >
  > Couple of comments on the look of it
  >
  > 1/ if you set the animation time to somehting long (500ms), then hover on a 
scrollbar, in the groove, and not on the handle, while making sure that the 
view in which you hove does not have focus, in order to make sure that the 
handle is painted grey, not blue (either focus blue or hover blue), there is a 
glitch at the end of the animation where a somewhat too dark grey jumps to a 
lighter one. Must be some problem with transparency. Can you confirm, double 
check ? I 'think' this is also the case when you mouse-over the handle but this 
is less clear.
  
  
  yes, can reproduce, looking into that
  
  > 2/ I wonder whether the unhovered scrollbar of a focused view should use 
the focus blue for the handle (as it is now, without your change), instead of 
light grey. I at least was using is somewhat strong blue to easily catch the 
view that have focus, instead of the much more subtle blue outline. What do you 
think ?
  
  for me either way is fine, would like also vdg opinion on it
  
  > 3/ I agree that the animation looks good on views like dolphin and 
systemsettings. However for views with a header, or when you have both vertical 
and horizontal bars it looks stranger . But this is a matter of taste
  
  yeah, asked about this concern back them to vdg, they say basically that 
yeah, it's not that pretty, but better than nothing
  
  > 4/ finally, I had this crazy idea :)
  >  What if ... instead of making the groove "fade-in" on hover, we would make 
it "expand" vertically, from around the handle ? as if it would appear from 
under the handle and grow to ocupy the full height of the view ? Do you think 
it could look cool ?
  
  may be cool.. (or also look a bit too jumpy) one thing, since i'm writing a 
qstyle-based theme for QtQuickControls2, this would make it harder to 
replicateon that weird qml/qstyle hybrid

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3131

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Closed] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
mart marked 4 inline comments as done.
Closed by commit rBREEZEe33206e4f74f: Show full scrollbar only on mouse over 
(authored by mart).

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3131?vs=7736=7778

REVISION DETAIL
  https://phabricator.kde.org/D3131

AFFECTED FILES
  kstyle/animations/breezescrollbardata.cpp
  kstyle/animations/breezescrollbardata.h
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3191: guard against dataengine missing

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3191#59338, @davidedmundson wrote:
  
  > So why is PluginLoader::loadDataEngine returning something?
  
  
  from https://bugs.kde.org/show_bug.cgi?id=371779 it looks like it's not?

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3191

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 136 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 7783.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  - Merge branch 'master' into arcpatch-D3210

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=7766=7783

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, hpereiradacosta, #plasma, #vdg
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 46 lines] D3191: guard against dataengine missing

[mart (Marco Martin)]

mart updated this revision to Diff 7790.
mart added a comment.


  - remove unneeded isValid() calls

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3191?vs=7733=7790

BRANCH
  arcpatch-D3191_1

REVISION DETAIL
  https://phabricator.kde.org/D3191

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comicmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart updated this revision to Diff 7736.
mart added a comment.


  - adress comments

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3131?vs=7725=7736

BRANCH
  arcpatch-D3131

REVISION DETAIL
  https://phabricator.kde.org/D3131

AFFECTED FILES
  kstyle/animations/breezescrollbardata.cpp
  kstyle/animations/breezescrollbardata.h
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3210#60230, @hpereiradacosta wrote:
  
  > So, just to make sure I understand:
  >
  > - 1 option to "only show full scrollbar on mouse over" (as we have now)
  > - 1 option to "use slim scrollbar" (with reduced width handle) Is that what 
you have in mind ? or do you suggest to group the two ? (in which case I'm 
pretty sure some users will want one and not the other, namely slim scrollbar 
with groove always visible, no groove but large handle, etc.)
  
  
  personally, (and would be good if thomas, jens or alex from the cdg weigh on 
that) I would have the default as:
  
  - small scrollbar
  - show on mouseover enabled
  - no arrow buttons
  
  tough i feel there may be the need for configuration options, even tough i 
usually really dislike them, for the code complexity reason you rightly 
mentioned
  
  > Thanks for the feedback,
  > 
  > Hugo
  > 
  > One last comment about options: every time one adds one, one make the code 
maintenance more complicated, with more combinations to test each time a change 
to the code is made. Just saying :)
  
  yep, i fully agree with that.
  unfortunately over the years  i seen the storm that can happen every time one 
changes anything visual (seems that changing the size of something is even more 
delicate as shown by a recent storm over systray icons size) so yeah, I'm just 
a bit afraid to :) (could fall into the category of the "omg they are pushing a 
mobile ui on me" kind of hater)
  
  we could even try to make this not configurable for 5.9 and see what the 
feedback is and eventually get the options back later..

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 92 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 7870.
mart added a comment.


  - make the scrollbar size config a simple checkbox

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=7783=7870

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3256: Close popups on escape

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  arcpatch-D3200

REVISION DETAIL
  https://phabricator.kde.org/D3256

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3250: Use Plasma tooling for installing plasmoids

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3250

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3257: Close the system tray on escape - system tray

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3257

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3204: [KSMServer] Turn user switcher into a separate binary

[mart (Marco Martin)]

mart added a comment.


  +1 from me, other opinions?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3249: Use our tooling for installing plasmoids

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3249

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3256: Close popups on escape

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3256#60552, @mart wrote:
  
  > speaking of which, i'm noticing the systray has its own popup and no esc, 
so adding the same thing there right now
  
  
  ah, seen now your other rr for the tray, nevermind :)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  arcpatch-D3200

REVISION DETAIL
  https://phabricator.kde.org/D3256

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3253: [desktopgrid] Don't manipulate virtual desktop of desktop window

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  having desktop windows not on all desktops i guess historically is for the 
old feature of different wallpapers for each desktop

REPOSITORY
  rKWIN KWin

BRANCH
  desktop-grid-no-click-desktop

REVISION DETAIL
  https://phabricator.kde.org/D3253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3259: Don't handle closing the popup ourselves

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3259

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3228: [helpers/killer] Force to platform XCB

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  killer-force-xcb-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3228

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3243: [kioslave/remote] Port away from kdelibs4support

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  port-remote

REVISION DETAIL
  https://phabricator.kde.org/D3243

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3257: Close the system tray on escape - system tray

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> PlasmoidPopupsContainer.qml:30
>  focus: true
> -Keys.forwardTo: [currentItem]
>  

wouldn't this break keyboard navigation in an item if supported? (like going up 
and down in the device list in the device notifier)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3257

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3231: [Lock Screen] Show "Switch User" button only if allowed

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3231

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff, mart
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3256: Close popups on escape

[mart (Marco Martin)]

mart added a comment.


  speaking of which, i'm noticing the systray has its own popup and no esc, so 
adding the same thing there right now

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  arcpatch-D3200

REVISION DETAIL
  https://phabricator.kde.org/D3256

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3210#60493, @colomar wrote:
  
  > If I understood it correctly (that there is only a checkbox "Only show full 
scrollbar on mouse over" added to the config) then that is exactly what I had 
in mind.
  
  
  in this latest version there are 2 checkboxes: "show scrollbar only on mouse 
over" and "small scrollbar" which both defautls to true

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

[mart (Marco Martin)]

mart added a comment.


  any news on this?

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D3166: make sure containment actions config is up to date

[mart (Marco Martin)]

mart abandoned this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 6 lines] D3263: fix behavior of scrollable systray popups

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  it's very rare that the icon list in the hidden area
  of the systray is long enough to get a scrollbar, but
  when it does it had a couple of issues:
  sometimes it gets an horizontal scrollbar too and
  the wheel events gets eaten:
  always disable the horizontal scrollbar and
  ignore wheel events over the label.
  wheel events over the icon are still managed by
  the applet (so still possible to for instance
  adjusting the volume on pa applet)
  
  BUG:372050

TEST PLAN
  hidden all the cions to enable scrollbar: wheel over
  the text scrolls the view, over the icon adjusts the volume

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/wheel

REVISION DETAIL
  https://phabricator.kde.org/D3263

AFFECTED FILES
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3263: fix behavior of scrollable systray popups

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEae658c33c8a6: fix behavior of scrollable 
systray popups (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3263?vs=7903=7904#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3263?vs=7903=7904

REVISION DETAIL
  https://phabricator.kde.org/D3263

AFFECTED FILES
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3209: [Notification Applet] Position dialog before showing it

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  tested locally on x11, it seems to still work correctly

INLINE COMMENTS

> notificationshelper.cpp:150
>  
> -QTimer::singleShot(300, popup, ::show);
> +QTimer::singleShot(100, popup, [this, popup] {
> +// Now we can position the popups properly as the geometry is now 
> known

is the delay by timer still needed?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3209

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mck182, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3220: Introduce new pre-layout script hook

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  Let's go with this, maybe use two different wariables for the script paths, 
but let's go with it.
  even if is a new thing, it should go on 5.8 as well tough.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: apol, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 21 lines] D3166: make sure containment actions config is up to date

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  if the containment actions plugins have been
  configured in the startup script, their config must be
  reloaded when the script ends, otherwise during the plasma
  session the config will be outdated
  
  BUG:371704

TEST PLAN
  the patch has been tested on new sessions with a customized look and feel 
package (maui) that changes the visible context menu entries

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/resetcontact

REVISION DETAIL
  https://phabricator.kde.org/D3166

AFFECTED FILES
  shell/scripting/containment.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 46 lines] D3191: guard against dataengine missing

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  this should never happen, but weird distribution packaging policies
  can make this happen. At least don't crash the whole sesison
  
  CCBUG:371779

TEST PLAN
  with dataengine present still works, with dataengine plugin delteted
  it still load without crashing, even if broken

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  phab/checkengine

REVISION DETAIL
  https://phabricator.kde.org/D3191

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comicmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3188: Modified distance function to keep aspect ratio as close as possible

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> image.cpp:186
>  
> -//qDebug() << "wanted" << m_targetSize << "options" << images;
> -
> -// choose the nearest resolution, always preferring images with the same 
> aspect ratio
> +//float targetAspectRatio = (m_targetSize.height() > 0 ) ? 
> m_targetSize.width() / (float)m_targetSize.height() : 0;
> +//qDebug() << "wanted" << m_targetSize << "options" << images << "aspect 
> ratio" << targetAspectRatio;

remove dead code

> image.cpp:196
>  }
> -float candidateAspectRatio = 
> candidate.width()/(float)candidate.height();
> +//float candidateAspectRatio = (candidate.height() > 0 ) ? 
> candidate.width() / (float)candidate.height() : FLT_MAX;
>  

dead code

> testfindpreferredimage.cpp:90
> + total++;
> + if (preferred != expected) failed++;
> + std::cout << "For a screen size of " << 
> qPrintable(formatResolution(resolution))

good that a test has been added!
but instead of doing all of this manually, couldn't it use qt autotest stuff, 
qcompare, qtest etc?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Requested Changes To] D3188: Modified distance function to keep aspect ratio as close as possible

[mart (Marco Martin)]

mart requested changes to this revision.
mart added a reviewer: mart.
This revision now requires changes to proceed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3168: Use microphone volume icon for capture devices/streams in applet

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design, mart
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3120: [kwineffects] Add hide/show cursor to EffectsHandler

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  effects-show-hide-cursor

REVISION DETAIL
  https://phabricator.kde.org/D3120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 162 lines] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart updated this revision to Diff 7720.
mart added a comment.


  - don't draw the handle separatedly

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3131?vs=7701=7720

BRANCH
  arcpatch-D3131

REVISION DETAIL
  https://phabricator.kde.org/D3131

AFFECTED FILES
  kstyle/animations/breezescrollbardata.cpp
  kstyle/animations/breezescrollbardata.h
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote:
  
  > Hi Marco,
  >
  > Couple of comments on the look of it
  >
  > 1/ if you set the animation time to somehting long (500ms), then hover on a 
scrollbar, in the groove, and not on the handle, while making sure that the 
view in which you hove does not have focus, in order to make sure that the 
handle is painted grey, not blue (either focus blue or hover blue), there is a 
glitch at the end of the animation where a somewhat too dark grey jumps to a 
lighter one. Must be some problem with transparency. Can you confirm, double 
check ? I 'think' this is also the case when you mouse-over the handle but this 
is less clear.
  
  
  that was because while animating the handle was drawn 2 times one on top of 
each other (as in the beginning the non mouse over was slimmer), now it just 
paints the same one, so it also has the proper color (blue on focus)

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3131

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3131#59205, @mart wrote:
  
  > In https://phabricator.kde.org/D3131#59202, @hpereiradacosta wrote:
  >
  > > 3/ I agree that the animation looks good on views like dolphin and 
systemsettings. However for views with a header, or when you have both vertical 
and horizontal bars it looks stranger . But this is a matter of taste
  >
  >
  > yeah, asked about this concern back them to vdg, they say basically that 
yeah, it's not that pretty, but better than nothing
  
  
  also should be minimized since iirc their intention is also to make the 
scrollbar a bit slimmer by default (painted around as wide as progressbars, 
maybe still with wider blank working mouse area but overall smaller

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3131

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Commented On] D3131: Show full scrollbar only on mouse over

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3131#59229, @hpereiradacosta wrote:
  
  > > also should be minimized since iirc their intention is also to make the 
scrollbar a bit slimmer by default (painted around as wide as progressbars, 
maybe still with wider blank working mouse area but overall smaller
  >
  > Just for my curiosity, where do these VDG discussions take place these days 
? IRC ?
  
  
  mostly Telegram https://telegram.me/vdgmainroom
  
  relayed on irc too on #kde-vdg channel

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3131

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, abetts, lesliezhai, ali-mohamed, jensreuterberg, sebas

[Differential] [Request, 197 lines] D3024: Remove WaylandDialogFilter

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  now that KWayland is a framework, it's used directly from
  Dialog, no need to inject kwayland usage from here anymore

TEST PLAN
  Dialogs still have shadows and still move under wayland

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/nofilter

REVISION DETAIL
  https://phabricator.kde.org/D3024

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/waylanddialogfilter.cpp
  shell/waylanddialogfilter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3021: restore all panel properties

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEaea33cddb547: restore all panel properties 
(authored by mart).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3021?vs=7305=7309

REVISION DETAIL
  https://phabricator.kde.org/D3021

AFFECTED FILES
  shell/scripting/scriptengine_v1.cpp
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3024: Remove WaylandDialogFilter

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE092c2c7cf734: Remove WaylandDialogFilter 
(authored by mart).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3024?vs=7311=7312

REVISION DETAIL
  https://phabricator.kde.org/D3024

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/waylanddialogfilter.cpp
  shell/waylanddialogfilter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, graesslin
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 27 lines] D3021: restore all panel properties

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  restore the missing panel properties:
  alignment
  minimum length
  maximum length
  offset
  
  also, allow non integer values for the measures (height, min/max, offset)
  BUG:368074
  BUG:367918

TEST PLAN
  dumped a config with a custom panel, different height/alignment/offset etc
  started a new plasma session with that l package, restored panel correctly

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/panelrestore

REVISION DETAIL
  https://phabricator.kde.org/D3021

AFFECTED FILES
  shell/scripting/scriptengine_v1.cpp
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3017: enable all preview plugins

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEc05f2fc2171e: enable all preview plugins 
(authored by mart).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3017?vs=7296=7302

REVISION DETAIL
  https://phabricator.kde.org/D3017

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

[mart (Marco Martin)]

mart added a comment.


  i am in favor  of this chane, but i think the real reson of the breakage 
should be investigated as well, uf there may be problems in kconfigwidget itself

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3048

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, broulik, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

[mart (Marco Martin)]

mart added a comment.


  hmm, also wouldn't be loaded if a kde app is loaded from another 
desktopwithout config prior existing i guess

INLINE COMMENTS

> colorscm.cpp:118
>  const QString name = group.readEntry("Name", info.baseName());
> -QListWidgetItem * newItem = new QListWidgetItem(icon, name);
> -// stash the file basename for use later
> -newItem->setData(Qt::UserRole, info.baseName());
> -schemeList->addItem(newItem);
> +if (name == "Default") {
> +defaultItem = new QListWidgetItem(icon, name);

is this name localized?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3048

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, broulik, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3048#56489, @ochurlaud wrote:
  
  > In https://phabricator.kde.org/D3048#56488, @mart wrote:
  >
  > > i am in favor  of this chane, but i think the real reson of the breakage 
should be investigated as well, uf there may be problems in kconfigwidget itself
  >
  >
  > Then I need help :)
  
  
  ok, later today i'll give a try at that bug hunting as well.
  depending from the result, we'll see what to do about this one, ok?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3048

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, broulik, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2986: Systray: Move all icon resolution to dataengine

[mart (Marco Martin)]

mart accepted this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2986

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: roberts, #plasma, davidedmundson, mart
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3000: If we manually invoke ::restore remove the pending timer to call restore

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3000

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2991: Fix moving windows to a different activity.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2991

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 7 lines] D3006: fix screenForContainment when screen ids > count

[mart (Marco Martin)]

mart updated this revision to Diff 7265.
mart added a comment.


  - bring back old logic

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3006?vs=7263=7265

BRANCH
  phab/screenforcont

REVISION DETAIL
  https://phabricator.kde.org/D3006

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3006: fix screenForContainment when screen ids > count

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEca1bf0e3e4c0: fix screenForContainment when 
screen ids > count (authored by mart).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3006?vs=7265=7266

REVISION DETAIL
  https://phabricator.kde.org/D3006

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

[mart (Marco Martin)]

mart added a comment.


  this version has the old logic again, it iterates trough all the screens but 
doesn't check for ids being < of the count, it just checks that thre is a 
qscreen for that screen id by using the association in screenpool

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3006

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 3 lines] D3017: enable all preview plugins

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  try to preview everything that's found in the list.
  by default not all image types are enabled, like
  svg, which is a supported wallpaper type

TEST PLAN
  svg files are correctly previewed in the thumbnail grid

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/svgPreview

REVISION DETAIL
  https://phabricator.kde.org/D3017

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3530#65867, @dfaure wrote:
  
  > But desktop:/ and applications:/ make no sense in other workspaces (I'm 
surprised we even still have applications:/, it's kind of a toy, isn't it?).
  >
  > (ok applications:/ might make sense in gnome, but definitely not on 
Windows/OSX)
  
  
  desktop:/ should be probably conditionally built only on Linux(but in there 
is quite core), while, may make sense to actually kill applications:/ 
altogether??

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3425: If we get a notification with no body, treat the subject line as the body

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3425

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, broulik, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3508: Implement borderlessMaximizedWindows for Wayland windows

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  shell-client-borderless-maximized-windows

REVISION DETAIL
  https://phabricator.kde.org/D3508

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Changed Subscribers] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> groupingplasmoid.kdev4:1
> +[Buildset]
> +BuildItems=@Variant(\x00\x00\x00\t\x00\x00\x00\x00\x01\x00\x00\x00\x0b\x00\x00\x00\x00\x01\x00\x00\x00
>  
> \x00g\x00r\x00o\x00u\x00p\x00i\x00n\x00g\x00p\x00l\x00a\x00s\x00m\x00o\x00i\x00d)

this foder shouldn't be added

> groupedappletscontainer.cpp:132
> +} else {
> +m_innerContainment->setFormFactor(Plasma::Types::Horizontal);
> +}

when this containment is in a desktop, shouldn't be better for it to be planer 
instead to let more applets to be expanded?

> main.qml:28
> +
> +Layout.minimumWidth: internalSystray ? 
> internalSystray.Layout.minimumWidth : 0
> +Layout.minimumHeight: internalSystray ? 
> internalSystray.Layout.minimumHeight : 0

rename *systray?

> groupingplasmoid.kdev4:1
> +[Project]
> +CreatedFrom=CMakeLists.txt

remove this file?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3620

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3585: Fix building library with qmake

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3585

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Requested Changes To] D3630: [Digital Clock] Bug fixes and ui code optimization

[mart (Marco Martin)]

mart requested changes to this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> DigitalClock.qml:57
>  // if the date/timezone cannot be fit with the smallest font to its 
> designated space
> -readonly property bool tooSmall: plasmoid.formFactor == 
> PlasmaCore.Types.Horizontal && Math.round(2 * (main.height / 5)) <= 
> theme.smallestFont.pixelSize
> +readonly property bool tooSmall: plasmoid.formFactor == 
> PlasmaCore.Types.Horizontal && Math.floor(0.4 * main.height) <= 
> theme.smallestFont.pointSize
>  

here you are comparing points and pixels

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3620

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3606: Listen for broadcast notifications on system bus

[mart (Marco Martin)]

mart added a subscriber: davidedmundson.
mart added a comment.


  In https://phabricator.kde.org/D3606#67751, @davidedmundson wrote:
  
  > Note that actions won't work, we'd always be replying on the session bus. 
(this is solvable)
  
  
  is that even possible to add an action at all from there?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3598: rework kscreen's OSD logic

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3598#67455, @sebas wrote:
  
  > protocol), we'll move this code into its own daemon and kwin will authorize 
that daemon. THat's basically the same approach we'll have to take with 
powerdevil.
  
  
  so in the end the authorized process would be that separed daemon and not 
kded? (as kded can in turn run all sort of 3rd party stuff, would be better if 
itself is not an authorized process)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D3598

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: mart, graesslin, broulik, plasma-devel, davidedmundson, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3606#67898, @broulik wrote:
  
  > What would be the best place to put a little utility (similar to 
notify-send or kdialog --passivepopup) for this?
  
  
  kde-cli-tools

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3615

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3658: Set Automatic login flag to adjust SDDM config directly

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3658

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3679: Introduce undefined fields

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Frameworks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3679

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2687: [Icon Widget] Bring back properties dialog

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3638: Implement drag from free space also for QtQuickControls

[mart (Marco Martin)]

mart added a comment.


  +1
  any news on that?

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D3638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, hpereiradacosta
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3688: [Runners] Register actions right away

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3688

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3658: Set Automatic login flag to adjust SDDM config directly

[mart (Marco Martin)]

mart added a comment.


  did the helper already supported the action or is a different rr?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3658

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

[mart (Marco Martin)]

mart added a comment.


  like it a lot!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2687: [Icon Widget] Bring back properties dialog

[mart (Marco Martin)]

mart added a comment.


  for me +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> appentry.h:79
>  AppGroupEntry(AppsModel *parentModel, KServiceGroup::Ptr group,
> -bool flat, bool sorted, bool separators, int appNameFormat);
> +bool paginate, int pageSize, bool flat, bool sorted, bool 
> separators, int appNameFormat);
>  

a constructor with a list of bool parameters doesn't look particularly good, 
but as i see was already like that before adding the paginate option, so is 
probably a bit late.. I would probably have seen bettea couple of different 
subclasses for different entries style? (same for the model)

> appsmodel.h:46
>  public:
> -explicit AppsModel(const QString  = QString(), bool flat = 
> false, bool sorted = true, bool separators = true, QObject *parent = 0);
> +explicit AppsModel(const QString  = QString(), bool 
> paginate = false, int pageSize = 24,
> +bool flat = false, bool sorted = true, bool separators = true, 
> QObject *parent = 0);

are all those parameters really needed right in the ctor?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3655

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

[mart (Marco Martin)]

mart added a comment.


  yes, if you are comparing with an item height, it should stay in pixelSize

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.


  not pretty for sure, but unfortunately i don't see much ways to avoid this, 
so go for it

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3581

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> TextField.qml:49
> +// this takes into account kiosk restriction
> +readonly property bool __effectiveRevealPasswordButtonShown: 
> revealPasswordButtonShown
> +  && 
> KAuthorized.authorize("lineedit_reveal_password")

instead of having a __ name, could also be a property of an object that's 
inside instead of the root object, so would be pretty much inaccessible from 
the outside

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3654

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3651: Add utility to send broadcast notifications

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D3651

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3655: Kicker backend changes for Simple Menu.

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3655

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3666: Test the variable type without warning

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3666

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Commented On] D3606: RFC: Listen for broadcast notifications on system bus

[mart (Marco Martin)]

mart added a comment.


  since is rfc this is my comment: I like the idea a lot

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 175 lines] D3603: Option to show percentage charge in the icon

[mart (Marco Martin)]

mart updated this revision to Diff 8840.
mart added a comment.


  - add missing file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3603?vs=8802=8840

BRANCH
  phab/batterypercent

REVISION DETAIL
  https://phabricator.kde.org/D3603

AFFECTED FILES
  applets/batterymonitor/package/contents/config/config.qml
  applets/batterymonitor/package/contents/config/main.xml
  applets/batterymonitor/package/contents/ui/BadgeOverlay.qml
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  applets/batterymonitor/package/contents/ui/ConfigGeneral.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

[mart (Marco Martin)]

mart added a comment.


  F672027: Spectacle.T21326.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3603

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 177 lines] D3603: Option to show percentage charge in the icon

[mart (Marco Martin)]

mart updated this revision to Diff 8843.
mart added a comment.


  - use anchors

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3603?vs=8840=8843

BRANCH
  phab/batterypercent

REVISION DETAIL
  https://phabricator.kde.org/D3603

AFFECTED FILES
  applets/batterymonitor/package/contents/config/config.qml
  applets/batterymonitor/package/contents/config/main.xml
  applets/batterymonitor/package/contents/ui/BadgeOverlay.qml
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  applets/batterymonitor/package/contents/ui/ConfigGeneral.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, broulik, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D3603: Option to show percentage charge in the icon

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:27ac0b760855: Option to show percentage charge in the 
icon (authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3603?vs=8843=8844

REVISION DETAIL
  https://phabricator.kde.org/D3603

AFFECTED FILES
  applets/batterymonitor/package/contents/config/config.qml
  applets/batterymonitor/package/contents/config/main.xml
  applets/batterymonitor/package/contents/ui/BadgeOverlay.qml
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  applets/batterymonitor/package/contents/ui/ConfigGeneral.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, broulik, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3681: Fix KAuthActionReply usage

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3681

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3684: WIP: Media Controls on lock screen

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3684

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3685: Add SDDM theme install/uninstall with GHNS to the SDDM KCM

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  ghns

REVISION DETAIL
  https://phabricator.kde.org/D3685

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3553: Fix 2 RTL bugs

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4fada5bdb032: Fix 2 RTL bugs (authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3553?vs=8647=9037

REVISION DETAIL
  https://phabricator.kde.org/D3553

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ttv20, #plasma_workspaces, mart
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3680: Don't list separately plasmoids from metadata.desktop and .json

[mart (Marco Martin)]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> packageloader.cpp:251
> +
> +if (dirs.contains(dir))
> +continue;

use { }

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas