Re: [NEW] games/mvdsv 0.32
On 2018-11-23 13:47, Jeremie Courreges-Anglas wrote:
On Fri, Nov 23 2018, Jeremie Courreges-Anglas wrote:
On Fri, Oct 19 2018, Solene Rapenne wrote:
Tom Murphy wrote:
On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote:
> Small introduction for people reading ports@.
>
> mvdsv is a quake world game server. It has some features like allowing to
> record games from every player point of view. That can be played again in a
> quake client like ezquake.
>
> ok solene@
Thanks Solene and Stuart for their help! Attached is a new tarball
using
GH_TAGNAME and the correct DISTFILES settings.
-Tom
up
looks fine to me
The build system is not very portable. The configure script hardcodes
a bunch of arch-dependent logic which breaks on eg. sparc64:
../../src/pr_exec.c:1: error: -m32 is not supported by this
configuration
Also, Makefile.BSD contains:
--8<--
. if ${MACHINE_ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
USE_ASM=-Did386
DO_CFLAGS += ${USE_ASM}
. endif
-->8--
It would be good to check that the port builds on i386 with assembly
enabled. Or you could wait for bulk build reports. ;)
Using devel/meson could be a nicer alternative to Makefile.BSD, which
looks a bit outdated (no curl support for example).
Using meson is cleaner since meson.build doesn't hardcode so much crap.
Also it autodetects system pcre instead of falling back to an ancient
bundled version. Updated tarball.
This builds much faster and cleaner with those changes. Works on my
amd64.
Thanks for that!
-Tom
Re: [NEW] games/mvdsv 0.32
On Fri, Nov 23 2018, Jeremie Courreges-Anglas wrote:
> On Fri, Oct 19 2018, Solene Rapenne wrote:
>> Tom Murphy wrote:
>>> On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote:
>>> > Small introduction for people reading ports@.
>>> >
>>> > mvdsv is a quake world game server. It has some features like allowing to
>>> > record games from every player point of view. That can be played again in
>>> > a
>>> > quake client like ezquake.
>>> >
>>> > ok solene@
>>>
>>> Thanks Solene and Stuart for their help! Attached is a new tarball using
>>> GH_TAGNAME and the correct DISTFILES settings.
>>>
>>> -Tom
>>
>> up
>>
>> looks fine to me
>
> The build system is not very portable. The configure script hardcodes
> a bunch of arch-dependent logic which breaks on eg. sparc64:
>
> ../../src/pr_exec.c:1: error: -m32 is not supported by this configuration
>
> Also, Makefile.BSD contains:
>
> --8<--
> . if ${MACHINE_ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
> USE_ASM=-Did386
> DO_CFLAGS += ${USE_ASM}
> . endif
> -->8--
>
> It would be good to check that the port builds on i386 with assembly
> enabled. Or you could wait for bulk build reports. ;)
>
> Using devel/meson could be a nicer alternative to Makefile.BSD, which
> looks a bit outdated (no curl support for example).
Using meson is cleaner since meson.build doesn't hardcode so much crap.
Also it autodetects system pcre instead of falling back to an ancient
bundled version. Updated tarball.
mvdsv.4.tgz
Description: Binary data
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: [NEW] games/mvdsv 0.32
On Fri, Oct 19 2018, Solene Rapenne wrote:
> Tom Murphy wrote:
>> On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote:
>> > Small introduction for people reading ports@.
>> >
>> > mvdsv is a quake world game server. It has some features like allowing to
>> > record games from every player point of view. That can be played again in a
>> > quake client like ezquake.
>> >
>> > ok solene@
>>
>> Thanks Solene and Stuart for their help! Attached is a new tarball using
>> GH_TAGNAME and the correct DISTFILES settings.
>>
>> -Tom
>
> up
>
> looks fine to me
The build system is not very portable. The configure script hardcodes
a bunch of arch-dependent logic which breaks on eg. sparc64:
../../src/pr_exec.c:1: error: -m32 is not supported by this configuration
Also, Makefile.BSD contains:
--8<--
. if ${MACHINE_ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
USE_ASM=-Did386
DO_CFLAGS += ${USE_ASM}
. endif
-->8--
It would be good to check that the port builds on i386 with assembly
enabled. Or you could wait for bulk build reports. ;)
Using devel/meson could be a nicer alternative to Makefile.BSD, which
looks a bit outdated (no curl support for example). Else, we could pass
arguments to the CONFIGURE_SCRIPT to fix its behavior.
Another concern: I think this has already been pointed out by fcambus@,
qwprogs.dat should have a versioned file name, should it be updated some
day.
Here's an updated tarball, Makefile diff below to ease review. With
those changes, ok jca@ to import
mvdsv.2.tgz
Description: Binary data
--- Makefile.orig Thu Oct 4 22:03:40 2018
+++ MakefileFri Nov 23 13:14:26 2018
@@ -13,6 +13,7 @@ HOMEPAGE =https://sourceforge.net/projects/mvdsv/
MAINTAINER = Tom Murphy
QWP_COMMIT = 0023db327bc1db00068284b70e1db45857aeee35
+QWP_VERSION = 20120131
MASTER_SITES0 =
https://raw.githubusercontent.com/id-Software/Quake/${QWP_COMMIT}/QW/progs/
# GPLv2+
@@ -21,15 +22,24 @@ PERMIT_PACKAGE_CDROM = Yes
WANTLIB += c curl m pthread
DISTFILES =mvdsv-{}${GH_TAGNAME}.tar.gz \
- qwprogs.dat:0
+ qwprogs-${QWP_VERSION}{qwprogs}.dat:0
EXTRACT_ONLY = mvdsv-${GH_TAGNAME}.tar.gz
LIB_DEPENDS = net/curl
+.include
+.if ${PROPERTIES:Mlp64}
+BITS = 64
+.else
+BITS = 32
+.endif
+
CONFIGURE_STYLE = simple
+CONFIGURE_ARGS = OpenBSD ${BITS}
MAKE_FLAGS = CC="${CC}" CFLAGS="${CFLAGS} -I${LOCALBASE}/include" \
- LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib -lcurl -lm"
+ LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib -lcurl -lm" \
+ FORCE32BITFLAGS=""
NO_TEST = Yes
@@ -41,6 +51,7 @@ do-install:
${INSTALL_PROGRAM} ${WRKSRC}/mvdsv ${PREFIX}/bin
${INSTALL_DATA_DIR} ${SAMPLES_DIR}
${INSTALL_DATA} ${FILESDIR}/server.cfg ${SAMPLES_DIR}
- ${INSTALL_DATA} ${DISTDIR}/qwprogs.dat ${SAMPLES_DIR}
+ ${INSTALL_DATA} ${DISTDIR}/qwprogs-${QWP_VERSION}.dat \
+ ${SAMPLES_DIR}/qwprogs.dat
.include
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: [NEW] games/mvdsv 0.32
On Fri, Oct 19, 2018 at 09:40:19PM +0200, Solene Rapenne wrote: > Tom Murphy wrote: > > On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote: > > > Small introduction for people reading ports@. > > > > > > mvdsv is a quake world game server. It has some features like allowing to > > > record games from every player point of view. That can be played again in > > > a > > > quake client like ezquake. > > > > > > ok solene@ > > > > Thanks Solene and Stuart for their help! Attached is a new tarball using > > GH_TAGNAME and the correct DISTFILES settings. > > > > -Tom > > up > > looks fine to me > Tested on a recent snapshot. I was able to start a local server following the README instructions and connect to it with games/ezquake. OK awolk@ to import
Re: [NEW] games/mvdsv 0.32
Hi, Is there any other issue holding up having this go in that I need to address? If so, let me know. Just pinging the list. Thanks, Tom
Re: [NEW] games/mvdsv 0.32
Tom Murphy wrote: > On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote: > > Small introduction for people reading ports@. > > > > mvdsv is a quake world game server. It has some features like allowing to > > record games from every player point of view. That can be played again in a > > quake client like ezquake. > > > > ok solene@ > > Thanks Solene and Stuart for their help! Attached is a new tarball using > GH_TAGNAME and the correct DISTFILES settings. > > -Tom up looks fine to me
Re: [NEW] games/mvdsv 0.32
On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote: > Small introduction for people reading ports@. > > mvdsv is a quake world game server. It has some features like allowing to > record games from every player point of view. That can be played again in a > quake client like ezquake. > > ok solene@ Thanks Solene and Stuart for their help! Attached is a new tarball using GH_TAGNAME and the correct DISTFILES settings. -Tom mvdsv.tgz Description: application/tar-gz
Re: [NEW] games/mvdsv 0.32
Tom Murphy wrote: > Hi, > > Attached is an updated tarball for games/mvdsv 0.32. > I incorporated some updates to the Makefile from solene@. > Thanks Solene! > > -Tom Small introduction for people reading ports@. mvdsv is a quake world game server. It has some features like allowing to record games from every player point of view. That can be played again in a quake client like ezquake. ok solene@
Re: [NEW] games/mvdsv 0.32
Hi, Attached is an updated tarball for games/mvdsv 0.32. I incorporated some updates to the Makefile from solene@. Thanks Solene! -Tom mvdsv.tgz Description: application/tar-gz
Re: [NEW] games/mvdsv 0.32
On Fri, Sep 14, 2018 at 02:59:49PM +0100, Stuart Henderson wrote:
> On 2018/09/14 15:10, Frederic Cambus wrote:
> > Fetching non versioned files like this one is problematic in case the
> > content change at some point, so should be avoided.
> >
> > I don't have a definitive answer on what should be done to move
> > this port forward, but I see three options:
> >
> > 1) Don't fetch and install the .dat file. I see in pkg/README that some
> > additional files are required to be manually installed anyway, so it
> > could be mentioned here. That's what the FreeBSD port is doing.
> >
> > 2) Create a versioned archive like qwprogs-20180914.tar.gz containing
> > the .dat file and licensing information, and host it somewhere.
> >
> > 3) Get the .dat file from the Quake repository, using a MASTER_SITES0
> > directive, look at emulators/ppsspp for an example. It's a bit wasteful
> > to fetch the whole repository just for one file, but it isn't that big
> > so that could be option and this solves the versioning problem.
>
> You don't need the entire repo, you can fetch the blob by commit id -
> https://github.com/id-Software/Quake/raw/0023db327bc1db00068284b70e1db45857aeee35/QW/progs/qwprogs.dat
>
> Either the file will need renaming using DISTFILES {} syntax, or download
> it to a versioned subdirectory with DIST_SUBDIR, but that's easy enough to do.
Here's an updated tarball of the port. It now brings in qwprogs.dat
separately as DISTFILES and will copy it into the share directory.
I left the qwprogs.dat commit id variable in there just in case it ever changes.
(It probably won't.)
Thanks,
Tom
mvdsv.tgz
Description: application/tar-gz
Re: [NEW] games/mvdsv 0.32
On 2018/09/14 15:10, Frederic Cambus wrote:
> On Fri, Aug 17, 2018 at 08:08:58PM +0100, Tom Murphy wrote:
>
> > > I'm not sure if it's a good idea to have qwprogs.dat in files/, as it
> > > means commiting a 196K binary file to CVS.
> > >
> > > I think it would be better to package it and host it somewhere, and
> > > download it as an additional distfile.
>
> > The file is freely distributable (under GPLv2+ license), and there's
> > a copy up at:
> >
> > https://github.com/id-Software/Quake/blob/master/QW/progs/qwprogs.dat
> >
> > Would that be a sufficient place to get it or does it need to be hosted
> > somewhere else? I don't have the capability to do any long term hosting of
> > distfiles, unfortunately.
>
> Fetching non versioned files like this one is problematic in case the
> content change at some point, so should be avoided.
>
> I don't have a definitive answer on what should be done to move
> this port forward, but I see three options:
>
> 1) Don't fetch and install the .dat file. I see in pkg/README that some
> additional files are required to be manually installed anyway, so it
> could be mentioned here. That's what the FreeBSD port is doing.
>
> 2) Create a versioned archive like qwprogs-20180914.tar.gz containing
> the .dat file and licensing information, and host it somewhere.
>
> 3) Get the .dat file from the Quake repository, using a MASTER_SITES0
> directive, look at emulators/ppsspp for an example. It's a bit wasteful
> to fetch the whole repository just for one file, but it isn't that big
> so that could be option and this solves the versioning problem.
You don't need the entire repo, you can fetch the blob by commit id -
https://github.com/id-Software/Quake/raw/0023db327bc1db00068284b70e1db45857aeee35/QW/progs/qwprogs.dat
Either the file will need renaming using DISTFILES {} syntax, or download
it to a versioned subdirectory with DIST_SUBDIR, but that's easy enough to do.
Re: [NEW] games/mvdsv 0.32
On Fri, Aug 17, 2018 at 08:08:58PM +0100, Tom Murphy wrote: > > I'm not sure if it's a good idea to have qwprogs.dat in files/, as it > > means commiting a 196K binary file to CVS. > > > > I think it would be better to package it and host it somewhere, and > > download it as an additional distfile. > The file is freely distributable (under GPLv2+ license), and there's > a copy up at: > > https://github.com/id-Software/Quake/blob/master/QW/progs/qwprogs.dat > > Would that be a sufficient place to get it or does it need to be hosted > somewhere else? I don't have the capability to do any long term hosting of > distfiles, unfortunately. Fetching non versioned files like this one is problematic in case the content change at some point, so should be avoided. I don't have a definitive answer on what should be done to move this port forward, but I see three options: 1) Don't fetch and install the .dat file. I see in pkg/README that some additional files are required to be manually installed anyway, so it could be mentioned here. That's what the FreeBSD port is doing. 2) Create a versioned archive like qwprogs-20180914.tar.gz containing the .dat file and licensing information, and host it somewhere. 3) Get the .dat file from the Quake repository, using a MASTER_SITES0 directive, look at emulators/ppsspp for an example. It's a bit wasteful to fetch the whole repository just for one file, but it isn't that big so that could be option and this solves the versioning problem. In case the last two options are preferred, it might be a good idea to use DIST_SUBDIR to group distfiles.
Re: [NEW] games/mvdsv 0.32
On Thu, Aug 16, 2018 at 10:38:21PM +0200, Frederic Cambus wrote: > On Thu, Aug 16, 2018 at 06:24:51PM +0100, Tom Murphy wrote: > > > > I've made a number of changes to this. Make sure the pkg/* stuff is still > > > correct. That opening line to the pkg/DESCR sounds a little too > > > advertise-y > > > for my tastes but maybe someone else will tell me it's fine. > > > > > > ~Brian > > > > > Looks good! I reworded the DESCR a little bit to make it sound less of > > an "advertisement". > > > > Updated tarball attached. > > I'm not sure if it's a good idea to have qwprogs.dat in files/, as it > means commiting a 196K binary file to CVS. > > I think it would be better to package it and host it somewhere, and > download it as an additional distfile. Hi Frederic, The file is freely distributable (under GPLv2+ license), and there's a copy up at: https://github.com/id-Software/Quake/blob/master/QW/progs/qwprogs.dat Would that be a sufficient place to get it or does it need to be hosted somewhere else? I don't have the capability to do any long term hosting of distfiles, unfortunately. -Tom
Re: [NEW] games/mvdsv 0.32
On Thu, Aug 16, 2018 at 06:24:51PM +0100, Tom Murphy wrote: > > I've made a number of changes to this. Make sure the pkg/* stuff is still > > correct. That opening line to the pkg/DESCR sounds a little too advertise-y > > for my tastes but maybe someone else will tell me it's fine. > > > > ~Brian > > > Looks good! I reworded the DESCR a little bit to make it sound less of > an "advertisement". > > Updated tarball attached. I'm not sure if it's a good idea to have qwprogs.dat in files/, as it means commiting a 196K binary file to CVS. I think it would be better to package it and host it somewhere, and download it as an additional distfile.
Re: [NEW] games/mvdsv 0.32
On 08/16/18 13:24, Tom Murphy wrote: On Wed, Aug 15, 2018 at 04:59:54PM -0400, Brian Callahan wrote: On 08/14/18 16:30, Tom Murphy wrote: I've updated the original tarball to move the info from the DESCR into the README. Again, this is a kind of sister port to games/ezquake. It's only for hosting a Quakeworld server. You still need the original Quake 1 data files that must be purchased with the game. Is this OK? Thanks! Tom I've made a number of changes to this. Make sure the pkg/* stuff is still correct. That opening line to the pkg/DESCR sounds a little too advertise-y for my tastes but maybe someone else will tell me it's fine. ~Brian Looks good! I reworded the DESCR a little bit to make it sound less of an "advertisement". Updated tarball attached. Thanks, Tom I don't want to send a whole tarball back because all I did was change the pkg/DESCR to: ``` MVDSV (MultiView Demo SerVer) is a QuakeWorld server that not only offers a multiplayer environment, but also allows you to record demos from every player's point of view as well as provide different game modes. While this package and the game server are open source, one still needs to provide the original game assets from Quake, which is not open source. You will need to purchase the original game to use this package. ``` For the first paragraph, it's just tweaking the tenses of the sentences so they all agree. I really like this language for the second paragraph, because it lets everyone know at a glance that the actual software being distributed in the package is entirely open source, and therefore we can distribute it in the first place, but just because this package is able to be distributed doesn't make it useful--you'll have to supply this other non-open source software yourself in order to make it useful. Which lets users make easier decisions regarding whether or not to install this package. ~Brian
Re: [NEW] games/mvdsv 0.32
On Wed, Aug 15, 2018 at 04:59:54PM -0400, Brian Callahan wrote: > > On 08/14/18 16:30, Tom Murphy wrote: > > I've updated the original tarball to move the info from > > the DESCR into the README. > > > > Again, this is a kind of sister port to games/ezquake. > > It's only for hosting a Quakeworld server. You still need > > the original Quake 1 data files that must be purchased with the > > game. > > > > Is this OK? > > > > Thanks! > > Tom > > I've made a number of changes to this. Make sure the pkg/* stuff is still > correct. That opening line to the pkg/DESCR sounds a little too advertise-y > for my tastes but maybe someone else will tell me it's fine. > > ~Brian > Looks good! I reworded the DESCR a little bit to make it sound less of an "advertisement". Updated tarball attached. Thanks, Tom mvdsv.tgz Description: application/tar-gz
Re: [NEW] games/mvdsv 0.32
On 08/14/18 16:30, Tom Murphy wrote: I've updated the original tarball to move the info from the DESCR into the README. Again, this is a kind of sister port to games/ezquake. It's only for hosting a Quakeworld server. You still need the original Quake 1 data files that must be purchased with the game. Is this OK? Thanks! Tom I've made a number of changes to this. Make sure the pkg/* stuff is still correct. That opening line to the pkg/DESCR sounds a little too advertise-y for my tastes but maybe someone else will tell me it's fine. ~Brian mvdsv.tgz Description: Binary data
Re: [NEW] games/mvdsv 0.32
I've updated the original tarball to move the info from the DESCR into the README. Again, this is a kind of sister port to games/ezquake. It's only for hosting a Quakeworld server. You still need the original Quake 1 data files that must be purchased with the game. Is this OK? Thanks! Tom mvdsv.tgz Description: application/tar-gz
